[sr-dev] Re: [kamailio/kamailio] OpenSSL depreacation warning (Issue #3502)
**crypto_uuid.c** => ``crypto`` **auth_crypt.c:** => ``ims_dialog`` **auth_identity.c** => ``auth_identity`` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3502#issuecomment-1620473090 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:f82fba83: pkg/kamailio/deb: version set 5.8.0~dev1 [skip ci]
Module: kamailio Branch: master Commit: f82fba83957c6ae62dd150914c80cb062af433f4 URL: https://github.com/kamailio/kamailio/commit/f82fba83957c6ae62dd150914c80cb062af433f4 Author: Victor Seva Committer: Victor Seva Date: 2023-06-28T15:04:28+02:00 pkg/kamailio/deb: version set 5.8.0~dev1 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/f82fba83957c6ae62dd150914c80cb062af433f4.diff Patch: https://github.com/kamailio/kamailio/commit/f82fba83957c6ae62dd150914c80cb062af433f4.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:15348a75: pkg/kamailio/deb: remove microhttpd from older versions
Module: kamailio Branch: master Commit: 15348a754a398b830345e485926022a199c4fc00 URL: https://github.com/kamailio/kamailio/commit/15348a754a398b830345e485926022a199c4fc00 Author: Victor Seva Committer: Victor Seva Date: 2023-06-28T13:59:10+02:00 pkg/kamailio/deb: remove microhttpd from older versions > https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/2442/console --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bionic/rules Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/buster/rules Modified: pkg/kamailio/deb/debian/backports/bionic Modified: pkg/kamailio/deb/debian/backports/buster Modified: pkg/kamailio/deb/debian/backports/focal Modified: pkg/kamailio/deb/debian/backports/stretch Modified: pkg/kamailio/deb/debian/backports/xenial Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/focal/rules Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/stretch/rules Modified: pkg/kamailio/deb/xenial/control Modified: pkg/kamailio/deb/xenial/rules --- Diff: https://github.com/kamailio/kamailio/commit/15348a754a398b830345e485926022a199c4fc00.diff Patch: https://github.com/kamailio/kamailio/commit/15348a754a398b830345e485926022a199c4fc00.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] fix warnings detected via codeql (PR #3497)
@linuxmaniac pushed 6 commits. f8091c4e884e71e95b1d250b67f525da0af42c0f sipcapture: use memcpy instead of strncpy for coherence 7af111e89a02a66ba0de916c27dbdbeec54725f1 rtpproxy: use memcpy instead of strcpy for coherence 507d2d29c84a5490a05a98d855e3c71d655fa168 path: use snprintf() instead of sprintf() 995dc2ec66295de80e5213922ccc3e4517863658 permissions: use strncpy() for setting boundaries 4e76ef52393e954881ead87359c8828dd18ab1b6 core: socket_info use strncpy() for setting boundaries 98d1c4f03e6fe128ee1b962c47429e95d3a8e57f jsonrcps: use strncpy() for setting boundaries -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3497/files/fc4de03af89c85edb1246731c65e2d618fc21b59..98d1c4f03e6fe128ee1b962c47429e95d3a8e57f You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.4:dc938876: utils/kamcmd: fix memory leak
Module: kamailio
Branch: 5.4
Commit: dc938876d4434afe649a374979fcca4bb4b1f103
URL:
https://github.com/kamailio/kamailio/commit/dc938876d4434afe649a374979fcca4bb4b1f103
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-27T13:01:48+02:00
utils/kamcmd: fix memory leak
fixes #3478
(cherry picked from commit badc81cb427ba5aaf03ca26e4c2654d58ee08588)
(cherry picked from commit 402bab6f63b515a13a72ac2dad6e40075ded1479)
---
Modified: utils/kamcmd/kamcmd.c
---
Diff:
https://github.com/kamailio/kamailio/commit/dc938876d4434afe649a374979fcca4bb4b1f103.diff
Patch:
https://github.com/kamailio/kamailio/commit/dc938876d4434afe649a374979fcca4bb4b1f103.patch
---
diff --git a/utils/kamcmd/kamcmd.c b/utils/kamcmd/kamcmd.c
index eee600c9abc..489ac08af16 100644
--- a/utils/kamcmd/kamcmd.c
+++ b/utils/kamcmd/kamcmd.c
@@ -1399,6 +1399,8 @@ void free_cfg_grp_lst()
while(grp){
last=grp;
grp=grp->next;
+ if(last->var_names)
+ free(last->var_names);
free(last);
}
cfg_grp_lst=0;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.5:f39f320b: utils/kamcmd: fix memory leak
Module: kamailio
Branch: 5.5
Commit: f39f320b6be93eb20936805b4e0396ce48da7985
URL:
https://github.com/kamailio/kamailio/commit/f39f320b6be93eb20936805b4e0396ce48da7985
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-27T13:01:24+02:00
utils/kamcmd: fix memory leak
fixes #3478
(cherry picked from commit badc81cb427ba5aaf03ca26e4c2654d58ee08588)
(cherry picked from commit 402bab6f63b515a13a72ac2dad6e40075ded1479)
---
Modified: utils/kamcmd/kamcmd.c
---
Diff:
https://github.com/kamailio/kamailio/commit/f39f320b6be93eb20936805b4e0396ce48da7985.diff
Patch:
https://github.com/kamailio/kamailio/commit/f39f320b6be93eb20936805b4e0396ce48da7985.patch
---
diff --git a/utils/kamcmd/kamcmd.c b/utils/kamcmd/kamcmd.c
index 2d1cd9c93be..b302c4a6dad 100644
--- a/utils/kamcmd/kamcmd.c
+++ b/utils/kamcmd/kamcmd.c
@@ -1399,6 +1399,8 @@ void free_cfg_grp_lst()
while(grp){
last=grp;
grp=grp->next;
+ if(last->var_names)
+ free(last->var_names);
free(last);
}
cfg_grp_lst=0;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.6:edd4744a: utils/kamcmd: fix memory leak
Module: kamailio
Branch: 5.6
Commit: edd4744a4cd7be96549f5515512187b801335d66
URL:
https://github.com/kamailio/kamailio/commit/edd4744a4cd7be96549f5515512187b801335d66
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-27T13:00:56+02:00
utils/kamcmd: fix memory leak
fixes #3478
(cherry picked from commit badc81cb427ba5aaf03ca26e4c2654d58ee08588)
(cherry picked from commit 402bab6f63b515a13a72ac2dad6e40075ded1479)
---
Modified: utils/kamcmd/kamcmd.c
---
Diff:
https://github.com/kamailio/kamailio/commit/edd4744a4cd7be96549f5515512187b801335d66.diff
Patch:
https://github.com/kamailio/kamailio/commit/edd4744a4cd7be96549f5515512187b801335d66.patch
---
diff --git a/utils/kamcmd/kamcmd.c b/utils/kamcmd/kamcmd.c
index 459fbfc30ae..e5b91430360 100644
--- a/utils/kamcmd/kamcmd.c
+++ b/utils/kamcmd/kamcmd.c
@@ -1403,6 +1403,8 @@ void free_cfg_grp_lst()
while(grp){
last=grp;
grp=grp->next;
+ if(last->var_names)
+ free(last->var_names);
free(last);
}
cfg_grp_lst=0;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:402bab6f: utils/kamcmd: fix memory leak
Module: kamailio
Branch: 5.7
Commit: 402bab6f63b515a13a72ac2dad6e40075ded1479
URL:
https://github.com/kamailio/kamailio/commit/402bab6f63b515a13a72ac2dad6e40075ded1479
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-27T12:58:17+02:00
utils/kamcmd: fix memory leak
fixes #3478
(cherry picked from commit badc81cb427ba5aaf03ca26e4c2654d58ee08588)
---
Modified: utils/kamcmd/kamcmd.c
---
Diff:
https://github.com/kamailio/kamailio/commit/402bab6f63b515a13a72ac2dad6e40075ded1479.diff
Patch:
https://github.com/kamailio/kamailio/commit/402bab6f63b515a13a72ac2dad6e40075ded1479.patch
---
diff --git a/utils/kamcmd/kamcmd.c b/utils/kamcmd/kamcmd.c
index f3a3a19f11f..97e0a7311d1 100644
--- a/utils/kamcmd/kamcmd.c
+++ b/utils/kamcmd/kamcmd.c
@@ -1403,6 +1403,8 @@ void free_cfg_grp_lst()
while(grp){
last=grp;
grp=grp->next;
+ if(last->var_names)
+ free(last->var_names);
free(last);
}
cfg_grp_lst=0;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] fix warnings detected via codeql (PR #3497)
@linuxmaniac pushed 2 commits. bcdce041c1f4b0a9cb1c40aee7008c113c2d952a permissions: use strncpy() for setting boundaries fc4de03af89c85edb1246731c65e2d618fc21b59 core: socket_info use strncpy() for setting boundaries -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3497/files/1edf22c025aeef5698d154b192cf985d6071f77f..fc4de03af89c85edb1246731c65e2d618fc21b59 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:777ecf6b: github: don't execute codeql for each push [skip ci]
Module: kamailio Branch: master Commit: 777ecf6bd8735538bf61f4f6e10d46ad7c39981b URL: https://github.com/kamailio/kamailio/commit/777ecf6bd8735538bf61f4f6e10d46ad7c39981b Author: Victor Seva Committer: Victor Seva Date: 2023-06-27T10:01:27+02:00 github: don't execute codeql for each push [skip ci] * set schedule cifuzz and codeql --- Modified: .github/workflows/cifuzz.yml Modified: .github/workflows/codeql.yml --- Diff: https://github.com/kamailio/kamailio/commit/777ecf6bd8735538bf61f4f6e10d46ad7c39981b.diff Patch: https://github.com/kamailio/kamailio/commit/777ecf6bd8735538bf61f4f6e10d46ad7c39981b.patch --- diff --git a/.github/workflows/cifuzz.yml b/.github/workflows/cifuzz.yml index f44d25e808..d376f8a1b3 100644 --- a/.github/workflows/cifuzz.yml +++ b/.github/workflows/cifuzz.yml @@ -1,5 +1,9 @@ name: CIFuzz -on: [pull_request] +on: + pull_request: +branches: [ "master" ] + schedule: +- cron: "30 0 * * *" permissions: contents: read jobs: diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 60d66b6996..5fde27446e 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -1,13 +1,10 @@ name: "CodeQL" on: - push: -branches-ignore: - - 'dependabot/**' pull_request: branches: [ "master" ] schedule: -- cron: "35 19 * * 3" +- cron: "30 0 * * *" permissions: contents: read jobs: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] fix warnings detected via codeql (PR #3497)
@linuxmaniac pushed 1 commit. 1edf22c025aeef5698d154b192cf985d6071f77f path: use snprintf() instead of sprintf() -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3497/files/8f3702fa49fbcb7b0ef3ed1cbd756039bd533ee1..1edf22c025aeef5698d154b192cf985d6071f77f You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] fix warnings detected via codeql (PR #3497)
Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [ ] Tested changes locally You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3497 -- Commit Summary -- * sipcapture: use memcpy instead of strncpy for coherence * rtpproxy: use memcpy instead of strcpy for coherence -- File Changes -- M src/modules/rtpproxy/rtpproxy.c (40) M src/modules/sipcapture/sipcapture.c (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3497.patch https://github.com/kamailio/kamailio/pull/3497.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3497 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:7e94c365: github: permissions for actions [skip ci]
Module: kamailio Branch: master Commit: 7e94c365359ca24ae7410121a5e4b4f7382b0b79 URL: https://github.com/kamailio/kamailio/commit/7e94c365359ca24ae7410121a5e4b4f7382b0b79 Author: Victor Seva Committer: Victor Seva Date: 2023-06-27T08:35:38+02:00 github: permissions for actions [skip ci] --- Modified: .github/workflows/cifuzz.yml Modified: .github/workflows/codeql.yml --- Diff: https://github.com/kamailio/kamailio/commit/7e94c365359ca24ae7410121a5e4b4f7382b0b79.diff Patch: https://github.com/kamailio/kamailio/commit/7e94c365359ca24ae7410121a5e4b4f7382b0b79.patch --- diff --git a/.github/workflows/cifuzz.yml b/.github/workflows/cifuzz.yml index 081e0a833d..f44d25e808 100644 --- a/.github/workflows/cifuzz.yml +++ b/.github/workflows/cifuzz.yml @@ -1,5 +1,7 @@ name: CIFuzz on: [pull_request] +permissions: + contents: read jobs: Fuzzing: runs-on: ubuntu-latest diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 0b56d6e918..60d66b6996 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -2,12 +2,14 @@ name: "CodeQL" on: push: -branches: [ "master", "3.1", "3.2", "3.3", "4.0", "4.1", "4.2", "4.3", "4.4", "5.0", "5.1", "5.2", "5.3", "5.4", "5.5", "5.6" ] +branches-ignore: + - 'dependabot/**' pull_request: branches: [ "master" ] schedule: - cron: "35 19 * * 3" - +permissions: + contents: read jobs: analyze: name: Analyze ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:02a066e9: pkg/kamailio/deb: kamailio-microhttpd-modules
Module: kamailio Branch: master Commit: 02a066e95f6b58f04663dc21c4061883d568677b URL: https://github.com/kamailio/kamailio/commit/02a066e95f6b58f04663dc21c4061883d568677b Author: Victor Seva Committer: Victor Seva Date: 2023-06-27T08:24:08+02:00 pkg/kamailio/deb: kamailio-microhttpd-modules --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bionic/rules Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bookworm/rules Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/bullseye/rules Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/buster/rules Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/debian/rules Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/focal/rules Modified: pkg/kamailio/deb/jammy/control Modified: pkg/kamailio/deb/jammy/rules Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/jessie/rules Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/precise/rules Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/sid/rules Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/stretch/rules Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/trusty/rules Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/wheezy/rules Modified: pkg/kamailio/deb/xenial/control Modified: pkg/kamailio/deb/xenial/rules --- Diff: https://github.com/kamailio/kamailio/commit/02a066e95f6b58f04663dc21c4061883d568677b.diff Patch: https://github.com/kamailio/kamailio/commit/02a066e95f6b58f04663dc21c4061883d568677b.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build(deps): bump actions/upload-artifact from 1 to 3 (PR #3495)
Merged #3495 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3495#event-9645236552 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:d215b556: github: bump actions/upload-artifact from 1 to 3
Module: kamailio Branch: master Commit: d215b5562e959db6a90bca65bea94fff9971ab74 URL: https://github.com/kamailio/kamailio/commit/d215b5562e959db6a90bca65bea94fff9971ab74 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Committer: Victor Seva Date: 2023-06-27T01:41:19+02:00 github: bump actions/upload-artifact from 1 to 3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v1...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- Modified: .github/workflows/cifuzz.yml --- Diff: https://github.com/kamailio/kamailio/commit/d215b5562e959db6a90bca65bea94fff9971ab74.diff Patch: https://github.com/kamailio/kamailio/commit/d215b5562e959db6a90bca65bea94fff9971ab74.patch --- diff --git a/.github/workflows/cifuzz.yml b/.github/workflows/cifuzz.yml index 948ab18b888..081e0a833d9 100644 --- a/.github/workflows/cifuzz.yml +++ b/.github/workflows/cifuzz.yml @@ -19,7 +19,7 @@ jobs: dry-run: false language: c - name: Upload Crash - uses: actions/upload-artifact@v1 + uses: actions/upload-artifact@v3 if: failure() && steps.build.outcome == 'success' with: name: artifacts ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build(deps): bump actions/checkout from 2 to 3 (PR #3496)
Merged #3496 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3496#event-9645232609 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:549cca07: github: bump actions/checkout from 2 to 3
Module: kamailio Branch: master Commit: 549cca07beef76f734e9eafe06a66b5509170b07 URL: https://github.com/kamailio/kamailio/commit/549cca07beef76f734e9eafe06a66b5509170b07 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Committer: Victor Seva Date: 2023-06-27T01:40:18+02:00 github: bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- Modified: .github/workflows/main.yml Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/549cca07beef76f734e9eafe06a66b5509170b07.diff Patch: https://github.com/kamailio/kamailio/commit/549cca07beef76f734e9eafe06a66b5509170b07.patch --- diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4cbe088f0ab..1cd2b414452 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -30,7 +30,7 @@ jobs: - distribution: sid compilier: clang steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: ammaraskar/gcc-problem-matcher@0.2.0 - name: build run: | diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index ff6ca190199..bf3168859de 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -12,7 +12,7 @@ jobs: check-format: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: wolletd/clang-format-checker@v1.10 with: target-ref: master @@ -33,7 +33,7 @@ jobs: - distribution: bookworm compilier: clang steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - uses: ammaraskar/gcc-problem-matcher@0.2.0 - name: build run: | ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build(deps): bump actions/upload-artifact from 1 to 3 (PR #3495)
@dependabot recreate -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3495#issuecomment-1608464343 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:b306bab6: github: dependabot use prefix in commit [skip ci]
Module: kamailio Branch: master Commit: b306bab6fb87033dadbf7b5eefbfbd233e3dc51a URL: https://github.com/kamailio/kamailio/commit/b306bab6fb87033dadbf7b5eefbfbd233e3dc51a Author: Victor Seva Committer: Victor Seva Date: 2023-06-27T01:34:01+02:00 github: dependabot use prefix in commit [skip ci] --- Modified: .github/dependabot.yml --- Diff: https://github.com/kamailio/kamailio/commit/b306bab6fb87033dadbf7b5eefbfbd233e3dc51a.diff Patch: https://github.com/kamailio/kamailio/commit/b306bab6fb87033dadbf7b5eefbfbd233e3dc51a.patch --- diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 23c4cb3b50..775cd54658 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -5,3 +5,5 @@ updates: directory: "/" schedule: interval: "weekly" +commit-message: + prefix: "github: [skip ci]" ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:881bcd10: github: remove updater.yaml [skip ci]
Module: kamailio
Branch: master
Commit: 881bcd1094af3846fa0770d64a4f7c93b5835921
URL:
https://github.com/kamailio/kamailio/commit/881bcd1094af3846fa0770d64a4f7c93b5835921
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-27T01:29:11+02:00
github: remove updater.yaml [skip ci]
* we are now using dependabot directly
---
Removed: .github/workflows/updater.yml
---
Diff:
https://github.com/kamailio/kamailio/commit/881bcd1094af3846fa0770d64a4f7c93b5835921.diff
Patch:
https://github.com/kamailio/kamailio/commit/881bcd1094af3846fa0770d64a4f7c93b5835921.patch
---
diff --git a/.github/workflows/updater.yml b/.github/workflows/updater.yml
deleted file mode 100644
index d517b85edb..00
--- a/.github/workflows/updater.yml
+++ /dev/null
@@ -1,17 +0,0 @@
-name: GitHub Actions Version Updater
-on:
- schedule:
-# Automatically run on every Sunday
-- cron: '0 0 * * 0'
-jobs:
- build:
-runs-on: ubuntu-latest
-steps:
- - uses: actions/checkout@v3
-with:
- token: ${{ secrets.WORKFLOW_SECRET }}
- - name: Run GitHub Actions Version Updater
-uses: saadmk11/github-actions-version-updater@v0.7.4
-with:
- token: ${{ secrets.WORKFLOW_SECRET }}
- pull_request_user_reviewers: linuxmaniac
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:006a6c2f: github: switch to bookworm for builds [skip ci]
Module: kamailio
Branch: master
Commit: 006a6c2fc7039ccbd9d1230ecbdf7f774e1c0c54
URL:
https://github.com/kamailio/kamailio/commit/006a6c2fc7039ccbd9d1230ecbdf7f774e1c0c54
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-26T23:36:28+02:00
github: switch to bookworm for builds [skip ci]
* codeql: add libmicrohttpd-dev dependency
build was failing due to missing dependency
---
Modified: .github/workflows/codeql.yml
Modified: .github/workflows/main.yml
Modified: .github/workflows/pull_request.yml
---
Diff:
https://github.com/kamailio/kamailio/commit/006a6c2fc7039ccbd9d1230ecbdf7f774e1c0c54.diff
Patch:
https://github.com/kamailio/kamailio/commit/006a6c2fc7039ccbd9d1230ecbdf7f774e1c0c54.patch
---
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index bc0eebfbe40..0b56d6e9185 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -32,7 +32,7 @@ jobs:
if: ${{ matrix.language == 'cpp' }}
run: |
sudo apt-get update
- sudo apt-get install --yes bison default-libmysqlclient-dev flex
libcurl4-openssl-dev libjansson-dev libhiredis-dev libevent-dev liblua5.1-0-dev
libpcre3-dev libncurses5-dev libpq-dev libreadline-dev libssl-dev
libunistring-dev libxml2-dev pkg-config python3 python3-dev uuid-dev zlib1g-dev
+ sudo apt-get install --yes bison default-libmysqlclient-dev flex
libcurl4-openssl-dev libjansson-dev libhiredis-dev libevent-dev liblua5.1-0-dev
libpcre3-dev libncurses5-dev libpq-dev libreadline-dev libssl-dev
libunistring-dev libmicrohttpd-dev libxml2-dev pkg-config python3 python3-dev
uuid-dev zlib1g-dev
- name: Configure (cpp)
if: ${{ matrix.language == 'cpp' }}
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index ddec775816c..4cbe088f0ab 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -21,9 +21,9 @@ jobs:
strategy:
matrix:
include:
- - distribution: bullseye
+ - distribution: bookworm
compilier: gcc
- - distribution: bullseye
+ - distribution: bookworm
compilier: clang
- distribution: sid
compilier: gcc
diff --git a/.github/workflows/pull_request.yml
b/.github/workflows/pull_request.yml
index 8887768239f..ff6ca190199 100644
--- a/.github/workflows/pull_request.yml
+++ b/.github/workflows/pull_request.yml
@@ -28,9 +28,9 @@ jobs:
strategy:
matrix:
include:
- - distribution: bullseye
+ - distribution: bookworm
compilier: gcc
- - distribution: bullseye
+ - distribution: bookworm
compilier: clang
steps:
- uses: actions/checkout@v2
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:1f3746cd: pkg/kamailio/deb: add libmicrohttpd-dev for microhttpd module
Module: kamailio Branch: master Commit: 1f3746cd020f5c6031cd157894d636f312132946 URL: https://github.com/kamailio/kamailio/commit/1f3746cd020f5c6031cd157894d636f312132946 Author: Victor Seva Committer: Victor Seva Date: 2023-06-26T23:24:53+02:00 pkg/kamailio/deb: add libmicrohttpd-dev for microhttpd module --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/bookworm/control Modified: pkg/kamailio/deb/bullseye/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jammy/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/1f3746cd020f5c6031cd157894d636f312132946.diff Patch: https://github.com/kamailio/kamailio/commit/1f3746cd020f5c6031cd157894d636f312132946.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tlsa + OpenSSL 3.0.x: multiple unpredictable shm corruption (Issue #3222)
@space88man can you please try master now? We introduced some changes related to openssl 3.0 recently -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3222#issuecomment-1603835735 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] OpenSSL 3.0 deprecated API (Issue #3011)
Closed #3011 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3011#event-9614679871 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] Segmentation fault on kamailio git master - TLS with libssl 3.0 (Issue #3259)
@admin-toneca can you please try master now? We introduced some changes related to openssl 3.0 recently -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3259#issuecomment-1603831324 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] kamcmd.c: memory leak (Issue #3478)
Closed #3478 as completed via badc81cb427ba5aaf03ca26e4c2654d58ee08588. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3478#event-9614450854 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:badc81cb: utils/kamcmd: fix memory leak
Module: kamailio
Branch: master
Commit: badc81cb427ba5aaf03ca26e4c2654d58ee08588
URL:
https://github.com/kamailio/kamailio/commit/badc81cb427ba5aaf03ca26e4c2654d58ee08588
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-23T09:07:07+02:00
utils/kamcmd: fix memory leak
fixes #3478
---
Modified: utils/kamcmd/kamcmd.c
---
Diff:
https://github.com/kamailio/kamailio/commit/badc81cb427ba5aaf03ca26e4c2654d58ee08588.diff
Patch:
https://github.com/kamailio/kamailio/commit/badc81cb427ba5aaf03ca26e4c2654d58ee08588.patch
---
diff --git a/utils/kamcmd/kamcmd.c b/utils/kamcmd/kamcmd.c
index b4a8cad8eeb..9190b6138ac 100644
--- a/utils/kamcmd/kamcmd.c
+++ b/utils/kamcmd/kamcmd.c
@@ -1395,6 +1395,8 @@ void free_cfg_grp_lst()
while(grp) {
last = grp;
grp = grp->next;
+ if(last->var_names)
+ free(last->var_names);
free(last);
}
cfg_grp_lst = 0;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
@juha-h it should be fine now in master and 5.7 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1603767413 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:2bd813b0: http_client: fix depecration of CURLOPT_REDIR_PROTOCOLS
Module: kamailio
Branch: 5.7
Commit: 2bd813b0c4c1b942ee634eca5e68a025be9fab8e
URL:
https://github.com/kamailio/kamailio/commit/2bd813b0c4c1b942ee634eca5e68a025be9fab8e
Author: Daniel-Constantin Mierla
Committer: Victor Seva
Date: 2023-06-23T08:54:57+02:00
http_client: fix depecration of CURLOPT_REDIR_PROTOCOLS
- GH #3492
(cherry picked from commit 4d8263f9be97a541a24cbc6acc9855509640780b)
---
Modified: src/modules/http_client/functions.c
---
Diff:
https://github.com/kamailio/kamailio/commit/2bd813b0c4c1b942ee634eca5e68a025be9fab8e.diff
Patch:
https://github.com/kamailio/kamailio/commit/2bd813b0c4c1b942ee634eca5e68a025be9fab8e.patch
---
diff --git a/src/modules/http_client/functions.c
b/src/modules/http_client/functions.c
index be0b2024b0d..8b1f33d74ef 100644
--- a/src/modules/http_client/functions.c
+++ b/src/modules/http_client/functions.c
@@ -161,8 +161,13 @@ static int curL_request_url(struct sip_msg *_m, const char
*_met,
res = curl_easy_setopt(
curl, CURLOPT_PROTOCOLS, CURLPROTO_HTTP |
CURLPROTO_HTTPS);
#endif
+
+#if defined(CURL_AT_LEAST_VERSION) && CURL_AT_LEAST_VERSION(7, 85, 0)
+ res = curl_easy_setopt(curl, CURLOPT_REDIR_PROTOCOLS_STR, "http,https");
+#else
res = curl_easy_setopt(
curl, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP |
CURLPROTO_HTTPS);
+#endif
if(_met != NULL) {
/* Enforce method (GET, PUT, ...) */
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:ff0e0d7a: tls: fix build for openssl < 1.1.1
Module: kamailio
Branch: 5.7
Commit: ff0e0d7aafa3905526599e604ff91542529a5b32
URL:
https://github.com/kamailio/kamailio/commit/ff0e0d7aafa3905526599e604ff91542529a5b32
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-23T08:45:43+02:00
tls: fix build for openssl < 1.1.1
OPENSSL_INIT_ATFORK was introduced in libssl 1.1.1
error introduced at 9d6bfb96528c49e6aaa39aa47be877ca528c3537
(cherry picked from commit 82f5fcbf88ee3058bd9da520b528c86393cc422a)
---
Modified: src/modules/tls/tls_init.c
---
Diff:
https://github.com/kamailio/kamailio/commit/ff0e0d7aafa3905526599e604ff91542529a5b32.diff
Patch:
https://github.com/kamailio/kamailio/commit/ff0e0d7aafa3905526599e604ff91542529a5b32.patch
---
diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c
index 8071ec3ad74..82a850cf9ac 100644
--- a/src/modules/tls/tls_init.c
+++ b/src/modules/tls/tls_init.c
@@ -740,7 +740,11 @@ int tls_h_mod_pre_init_f(void)
LM_DBG("preparing tls env for modules initialization\n");
#if OPENSSL_VERSION_NUMBER >= 0x01010L && !defined(LIBRESSL_VERSION_NUMBER)
LM_DBG("preparing tls env for modules initialization (libssl >=1.1)\n");
+#if OPENSSL_VERSION_NUMBER >= 0x010101000L
OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL);
+#else
+ OPENSSL_init_ssl(0, NULL);
+#endif
#else
LM_DBG("preparing tls env for modules initialization (libssl <=1.0)\n");
SSL_library_init();
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:82f5fcbf: tls: fix build for openssl < 1.1.1
Module: kamailio
Branch: master
Commit: 82f5fcbf88ee3058bd9da520b528c86393cc422a
URL:
https://github.com/kamailio/kamailio/commit/82f5fcbf88ee3058bd9da520b528c86393cc422a
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-22T18:03:46+02:00
tls: fix build for openssl < 1.1.1
OPENSSL_INIT_ATFORK was introduced in libssl 1.1.1
error introduced at 9d6bfb96528c49e6aaa39aa47be877ca528c3537
---
Modified: src/modules/tls/tls_init.c
---
Diff:
https://github.com/kamailio/kamailio/commit/82f5fcbf88ee3058bd9da520b528c86393cc422a.diff
Patch:
https://github.com/kamailio/kamailio/commit/82f5fcbf88ee3058bd9da520b528c86393cc422a.patch
---
diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c
index 1919b611f81..d7399e8c792 100644
--- a/src/modules/tls/tls_init.c
+++ b/src/modules/tls/tls_init.c
@@ -749,7 +749,11 @@ int tls_h_mod_pre_init_f(void)
LM_DBG("preparing tls env for modules initialization\n");
#if OPENSSL_VERSION_NUMBER >= 0x01010L && !defined(LIBRESSL_VERSION_NUMBER)
LM_DBG("preparing tls env for modules initialization (libssl >=1.1)\n");
+#if OPENSSL_VERSION_NUMBER >= 0x010101000L
OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL);
+#else
+ OPENSSL_init_ssl(0, NULL);
+#endif
#else
LM_DBG("preparing tls env for modules initialization (libssl <=1.0)\n");
SSL_library_init();
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tls: fix build for openssl < 1.1.1 (PR #3493)
Merged #3493 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3493#event-9608536150 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tls: fix build for openssl < 1.1.1 (PR #3493)
> I would prefer not to have the gcc output in the commit log, it makes the > ChangeLog not really nice to read. OK, done. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3493#issuecomment-1602913549 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] tls: fix build for openssl < 1.1.1 (PR #3493)
>From >https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=amd64,distribution=stretch/2438/consoleFull gcc -fPIC -DPIC -funroll-loops -Wcast-align -m64 -minline-all-stringops -falign-loops -ftree-vectorize -fno-strict-overflow -mtune=generic -pthread -DKSR_PTHREAD_MUTEX_SHARED -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/kamailio-5.8.0~dev0+bpo9.20230622005415.2462=. -fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE -DNAME=kamailio -DVERSION=5.8.0-dev0 -DARCH=x86_64 -DOS=linux_ -DOS_QUOTED=linux -DCOMPILER=gcc 6.3.0 -D__CPU_x86_64 -D__OS_linux -DVERSIONVAL=5008000 -DCFG_DIR=/etc/kamailio/ -DSHARE_DIR=/usr/share/kamailio/ -DRUN_DIR=/var/run/kamailio/ -DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT -DMOD_NAME=tls -DMOD_NAMEID=tls -c tls_init.c -o tls_init.o -MMD -MP tls_init.c: In function tls_h_mod_pre_init_f: tls_init.c:752:19: error: OPENSSL_INIT_ATFORK undeclared (first use in this function) OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL); ^~~ tls_init.c:752:19: note: each undeclared identifier is reported only once for each function it appears in ../../Makefile.rules:100: recipe for target tls_init.o failed error introduced at 9d6bfb96528c49e6aaa39aa47be877ca528c3537 !-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with git cherry-pick -x ... - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -- Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue # (replace with an open issue number) Description !-- Describe your changes in detail -- You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3493 -- Commit Summary -- * tls: fix build for openssl 1.1.1 -- File Changes -- M src/modules/tls/tls_init.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3493.patch https://github.com/kamailio/kamailio/pull/3493.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3493 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
Now we are getting build error in [stretch ](https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=amd64,distribution=stretch/2438/consoleFull) ``` 03:08:53 gcc -fPIC -DPIC -funroll-loops -Wcast-align -m64 -minline-all-stringops -falign-loops -ftree-vectorize -fno-strict-overflow -mtune=generic -pthread -DKSR_PTHREAD_MUTEX_SHARED -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/kamailio-5.8.0~dev0+bpo9.20230622005415.2462=. -fstack-protector-strong -Wformat -Werror=format-security -DVERSION_NODATE -DNAME='"kamailio"' -DVERSION='"5.8.0-dev0"' -DARCH='"x86_64"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 6.3.0"' -D__CPU_x86_64 -D__OS_linux -DVERSIONVAL=5008000 -DCFG_DIR='"/etc/kamailio/"' -DSHARE_DIR='"/usr/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLOCKLIST -DUSE_NAPTR -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN -DUSE_RAW_SOCKS -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKAROUND -DUSE_FUTEX -DHAVE_SELECT -DMOD_NAME='"tls"' -DMOD_NAMEID='tls' -c tls_init.c -o tls_init.o -MMD -MP 03:08:53 tls_init.c: In function 'tls_h_mod_pre_init_f': 03:08:53 tls_init.c:752:19: error: 'OPENSSL_INIT_ATFORK' undeclared (first use in this function) 03:08:53 OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL); 03:08:53^~~ 03:08:53 tls_init.c:752:19: note: each undeclared identifier is reported only once for each function it appears in 03:08:53 ../../Makefile.rules:100: recipe for target 'tls_init.o' failed ``` Seems 9d6bfb96528c49e6aaa39aa47be877ca528c3537 broke it libssl-dev is 1.1.0l ``` 02:59:07 Setting up libssl-dev:amd64 (1.1.0l-1~deb9u6) ... ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1602650569 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
``` commit 23a121e5d8ffa172f71433c2ef74f323a54e8315 (HEAD -> 5.7, origin/5.7) Author: Daniel-Constantin Mierla Date: Wed Jun 21 09:27:28 2023 +0200 http_client: fix depecration of CURLOPT_PROTOCOLS and CURLINFO_SIZE_DOWNLOAD - GH #3484 (cherry picked from commit b7b3c67fc1205d114fadf360a594930ef69835a3) commit 8cc9ec410ff359e3d93e994c210977a8baa578c4 Author: Victor Seva Date: Mon Jun 19 20:12:17 2023 +0200 tls: disable tls_rand for openssl >= 3.0 From https://www.openssl.org/docs/man3.0/man3/RAND_set_rand_method.html > All of the functions described on this page are deprecated. > Applications should instead use RAND_set_DRBG_type(3), EVP_RAND(3) and > EVP_RAND(7). (cherry picked from commit c4b04696a6bfe31fdd65fa56529b0d46f2774067) commit d4b7333ca126ae7c77ec8f095f8728234d0dfe43 Author: Victor Seva Date: Mon Jun 19 13:36:53 2023 +0200 tls: disable engine for openssl >= 3.0 From https://www.openssl.org/docs/man3.0/man7/migration_guide.html > The refactoring to support Providers conflicts internally with the APIs > used to support engines, including the ENGINE API and any function that > creates or modifies custom "METHODS" From https://www.openssl.org/docs/man3.0/man3/ENGINE_init.html: > All of the functions described on this page are deprecated. Applications > should instead use the provider APIs. (cherry picked from commit a0a9373ccb3d3da3a1e9e1335d904fcf013d9ebd) commit 6669c0befcd69f5d5e196c53188bed58a6a9e1c2 Author: Victor Seva Date: Tue Jun 13 12:37:21 2023 +0200 tls: OPENSSL_fork_[prepare|parent|child] deprecated at openssl 3.0 From https://www.openssl.org/docs/man3.0/man3/OPENSSL_fork_prepare.html: > OPENSSL_fork_prepare, OPENSSL_fork_parent, OPENSSL_fork_child have been > deprecated since OpenSSL 3.0. > > These methods are currently unused, and as such, no replacement methods > are required or planned. > > OpenSSL has state that should be reset when a process forks. For > example, the entropy pool used to generate random numbers (and therefore > encryption keys) should not be shared across multiple programs. The > OPENSSL_fork_prepare(), OPENSSL_fork_parent(), and OPENSSL_fork_child() > functions are used to reset this internal state. > > OPENSSL_init_crypto(3) will register these functions with the > appropriate handler, when the OPENSSL_INIT_ATFORK flag is used (cherry picked from commit 9d6bfb96528c49e6aaa39aa47be877ca528c3537) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1600568979 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:6669c0be: tls: OPENSSL_fork_[prepare|parent|child] deprecated at openssl 3.0
Module: kamailio
Branch: 5.7
Commit: 6669c0befcd69f5d5e196c53188bed58a6a9e1c2
URL:
https://github.com/kamailio/kamailio/commit/6669c0befcd69f5d5e196c53188bed58a6a9e1c2
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-21T12:10:28+02:00
tls: OPENSSL_fork_[prepare|parent|child] deprecated at openssl 3.0
>From https://www.openssl.org/docs/man3.0/man3/OPENSSL_fork_prepare.html:
> OPENSSL_fork_prepare, OPENSSL_fork_parent, OPENSSL_fork_child have been
> deprecated since OpenSSL 3.0.
>
> These methods are currently unused, and as such, no replacement methods
> are required or planned.
>
> OpenSSL has state that should be reset when a process forks. For
> example, the entropy pool used to generate random numbers (and therefore
> encryption keys) should not be shared across multiple programs. The
> OPENSSL_fork_prepare(), OPENSSL_fork_parent(), and OPENSSL_fork_child()
> functions are used to reset this internal state.
>
> OPENSSL_init_crypto(3) will register these functions with the
> appropriate handler, when the OPENSSL_INIT_ATFORK flag is used
(cherry picked from commit 9d6bfb96528c49e6aaa39aa47be877ca528c3537)
---
Modified: src/modules/tls/tls_init.c
Modified: src/modules/tls/tls_mod.c
---
Diff:
https://github.com/kamailio/kamailio/commit/6669c0befcd69f5d5e196c53188bed58a6a9e1c2.diff
Patch:
https://github.com/kamailio/kamailio/commit/6669c0befcd69f5d5e196c53188bed58a6a9e1c2.patch
---
diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c
index 8f40fab0212..8071ec3ad74 100644
--- a/src/modules/tls/tls_init.c
+++ b/src/modules/tls/tls_init.c
@@ -740,7 +740,7 @@ int tls_h_mod_pre_init_f(void)
LM_DBG("preparing tls env for modules initialization\n");
#if OPENSSL_VERSION_NUMBER >= 0x01010L && !defined(LIBRESSL_VERSION_NUMBER)
LM_DBG("preparing tls env for modules initialization (libssl >=1.1)\n");
- OPENSSL_init_ssl(0, NULL);
+ OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL);
#else
LM_DBG("preparing tls env for modules initialization (libssl <=1.0)\n");
SSL_library_init();
diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c
index 466e2fcdbbe..22be7688d16 100644
--- a/src/modules/tls/tls_mod.c
+++ b/src/modules/tls/tls_mod.c
@@ -450,7 +450,8 @@ static int mod_child(int rank)
_params, _params) < 0)
return -1;
}
-#if OPENSSL_VERSION_NUMBER >= 0x010101000L
+#if OPENSSL_VERSION_NUMBER >= 0x010101000L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
if(ksr_tls_init_mode_MODE_FORK_PREPARE) {
OPENSSL_fork_prepare();
}
@@ -458,7 +459,8 @@ static int mod_child(int rank)
return 0;
}
-#if OPENSSL_VERSION_NUMBER >= 0x010101000L
+#if OPENSSL_VERSION_NUMBER >= 0x010101000L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
if(ksr_tls_init_mode_MODE_FORK_PREPARE) {
if(rank==PROC_POSTCHILDINIT) {
/*
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:23a121e5: http_client: fix depecration of CURLOPT_PROTOCOLS and CURLINFO_SIZE_DOWNLOAD
Module: kamailio
Branch: 5.7
Commit: 23a121e5d8ffa172f71433c2ef74f323a54e8315
URL:
https://github.com/kamailio/kamailio/commit/23a121e5d8ffa172f71433c2ef74f323a54e8315
Author: Daniel-Constantin Mierla
Committer: Victor Seva
Date: 2023-06-21T12:11:29+02:00
http_client: fix depecration of CURLOPT_PROTOCOLS and CURLINFO_SIZE_DOWNLOAD
- GH #3484
(cherry picked from commit b7b3c67fc1205d114fadf360a594930ef69835a3)
---
Modified: src/modules/http_client/functions.c
---
Diff:
https://github.com/kamailio/kamailio/commit/23a121e5d8ffa172f71433c2ef74f323a54e8315.diff
Patch:
https://github.com/kamailio/kamailio/commit/23a121e5d8ffa172f71433c2ef74f323a54e8315.patch
---
diff --git a/src/modules/http_client/functions.c
b/src/modules/http_client/functions.c
index 8a2b9938538..be0b2024b0d 100644
--- a/src/modules/http_client/functions.c
+++ b/src/modules/http_client/functions.c
@@ -155,8 +155,12 @@ static int curL_request_url(struct sip_msg *_m, const char
*_met,
res = curl_easy_setopt(curl, CURLOPT_URL, _url);
/* Limit to HTTP and HTTPS protocols */
+#if defined(CURL_AT_LEAST_VERSION) && CURL_AT_LEAST_VERSION(7, 85, 0)
+ res = curl_easy_setopt(curl, CURLOPT_PROTOCOLS_STR, "http,https");
+#else
res = curl_easy_setopt(
curl, CURLOPT_PROTOCOLS, CURLPROTO_HTTP |
CURLPROTO_HTTPS);
+#endif
res = curl_easy_setopt(
curl, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP |
CURLPROTO_HTTPS);
@@ -383,8 +387,13 @@ static int curL_request_url(struct sip_msg *_m, const char
*_met,
if((stat >= 200) && (stat < 500)) {
double datasize = 0;
-
+#if defined(CURL_AT_LEAST_VERSION) && CURL_AT_LEAST_VERSION(7, 55, 0)
+ curl_off_t dlsize;
+ curl_easy_getinfo(curl, CURLINFO_SIZE_DOWNLOAD_T, );
+ download_size = (double)dlsize;
+#else
curl_easy_getinfo(curl, CURLINFO_SIZE_DOWNLOAD, _size);
+#endif
LM_DBG(" -- curl download size: %u \n", (unsigned
int)download_size);
datasize = download_size;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:8cc9ec41: tls: disable tls_rand for openssl >= 3.0
Module: kamailio
Branch: 5.7
Commit: 8cc9ec410ff359e3d93e994c210977a8baa578c4
URL:
https://github.com/kamailio/kamailio/commit/8cc9ec410ff359e3d93e994c210977a8baa578c4
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-21T12:10:59+02:00
tls: disable tls_rand for openssl >= 3.0
>From https://www.openssl.org/docs/man3.0/man3/RAND_set_rand_method.html
> All of the functions described on this page are deprecated.
> Applications should instead use RAND_set_DRBG_type(3), EVP_RAND(3) and
> EVP_RAND(7).
(cherry picked from commit c4b04696a6bfe31fdd65fa56529b0d46f2774067)
---
Modified: src/modules/tls/tls_mod.c
Modified: src/modules/tls/tls_rand.c
Modified: src/modules/tls/tls_rand.h
---
Diff:
https://github.com/kamailio/kamailio/commit/8cc9ec410ff359e3d93e994c210977a8baa578c4.diff
Patch:
https://github.com/kamailio/kamailio/commit/8cc9ec410ff359e3d93e994c210977a8baa578c4.patch
---
diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c
index a0f90c11064..e57a98c052d 100644
--- a/src/modules/tls/tls_mod.c
+++ b/src/modules/tls/tls_mod.c
@@ -506,7 +506,8 @@ static void mod_destroy(void)
int ksr_rand_engine_param(modparam_t type, void* val)
{
-#if OPENSSL_VERSION_NUMBER >= 0x1010L
+#if OPENSSL_VERSION_NUMBER >= 0x1010L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
str *reng;
if(val==NULL) {
@@ -674,7 +675,8 @@ int mod_register(char *path, int *dlflags, void *p1, void
*p2)
register_tls_hooks(_h);
-#if OPENSSL_VERSION_NUMBER >= 0x1010L
+#if OPENSSL_VERSION_NUMBER >= 0x1010L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
LM_DBG("setting cryptorand random engine\n");
RAND_set_rand_method(RAND_ksr_cryptorand_method());
#endif
diff --git a/src/modules/tls/tls_rand.c b/src/modules/tls/tls_rand.c
index 2cdb2ec0efe..260cd7ddbb9 100644
--- a/src/modules/tls/tls_rand.c
+++ b/src/modules/tls/tls_rand.c
@@ -29,7 +29,8 @@
#include "tls_rand.h"
-#if OPENSSL_VERSION_NUMBER >= 0x1010L
+#if OPENSSL_VERSION_NUMBER >= 0x1010L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
#include "../../core/dprint.h"
#include "../../core/locking.h"
diff --git a/src/modules/tls/tls_rand.h b/src/modules/tls/tls_rand.h
index 34d6b2d1ff2..58ddc853acd 100644
--- a/src/modules/tls/tls_rand.h
+++ b/src/modules/tls/tls_rand.h
@@ -21,7 +21,8 @@
#define _TLS_RAND_H_
#include
-#if OPENSSL_VERSION_NUMBER >= 0x1010L
+#if OPENSSL_VERSION_NUMBER >= 0x1010L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
#include
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:d4b7333c: tls: disable engine for openssl >= 3.0
Module: kamailio
Branch: 5.7
Commit: d4b7333ca126ae7c77ec8f095f8728234d0dfe43
URL:
https://github.com/kamailio/kamailio/commit/d4b7333ca126ae7c77ec8f095f8728234d0dfe43
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-21T12:10:46+02:00
tls: disable engine for openssl >= 3.0
>From https://www.openssl.org/docs/man3.0/man7/migration_guide.html
> The refactoring to support Providers conflicts internally with the APIs
> used to support engines, including the ENGINE API and any function that
> creates or modifies custom "METHODS"
>From https://www.openssl.org/docs/man3.0/man3/ENGINE_init.html:
> All of the functions described on this page are deprecated. Applications
> should instead use the provider APIs.
(cherry picked from commit a0a9373ccb3d3da3a1e9e1335d904fcf013d9ebd)
---
Modified: src/modules/tls/tls_domain.c
Modified: src/modules/tls/tls_mod.c
Modified: src/modules/tls/tls_server.c
---
Diff:
https://github.com/kamailio/kamailio/commit/d4b7333ca126ae7c77ec8f095f8728234d0dfe43.diff
Patch:
https://github.com/kamailio/kamailio/commit/d4b7333ca126ae7c77ec8f095f8728234d0dfe43.patch
---
diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c
index d718c92893..ad6e08bffa 100644
--- a/src/modules/tls/tls_domain.c
+++ b/src/modules/tls/tls_domain.c
@@ -30,6 +30,10 @@
#include
#include
+#if OPENSSL_VERSION_NUMBER >= 0x03000L
+#define OPENSSL_NO_ENGINE
+#endif
+
#ifndef OPENSSL_NO_ENGINE
#include
#include "tls_map.h"
diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c
index 22be7688d1..a0f90c1106 100644
--- a/src/modules/tls/tls_mod.c
+++ b/src/modules/tls/tls_mod.c
@@ -87,6 +87,9 @@ int ksr_rand_engine_param(modparam_t type, void* val);
MODULE_VERSION
+#if OPENSSL_VERSION_NUMBER >= 0x03000L
+#define OPENSSL_NO_ENGINE
+#endif
extern str sr_tls_event_callback;
str sr_tls_xavp_cfg = {0, 0};
diff --git a/src/modules/tls/tls_server.c b/src/modules/tls/tls_server.c
index afd16ab542..5c039c920b 100644
--- a/src/modules/tls/tls_server.c
+++ b/src/modules/tls/tls_server.c
@@ -128,6 +128,9 @@ int tls_run_event_routes(struct tcp_connection *c);
#endif /* __SUNPRO_c */
#endif /* TLS_RD_DEBUG */
+#if OPENSSL_VERSION_NUMBER >= 0x03000L
+#define OPENSSL_NO_ENGINE
+#endif
extern str sr_tls_xavp_cfg;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
I'll backport the changes -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1600560324 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
Yes, It can't make things worse -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1600447831 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
Closed #3484 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#event-9578189490 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
build warnings are fixed by #3482 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1598567410 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:a0a9373c: tls: disable engine for openssl >= 3.0
Module: kamailio
Branch: master
Commit: a0a9373ccb3d3da3a1e9e1335d904fcf013d9ebd
URL:
https://github.com/kamailio/kamailio/commit/a0a9373ccb3d3da3a1e9e1335d904fcf013d9ebd
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-20T12:51:16+02:00
tls: disable engine for openssl >= 3.0
>From https://www.openssl.org/docs/man3.0/man7/migration_guide.html
> The refactoring to support Providers conflicts internally with the APIs
> used to support engines, including the ENGINE API and any function that
> creates or modifies custom "METHODS"
>From https://www.openssl.org/docs/man3.0/man3/ENGINE_init.html:
> All of the functions described on this page are deprecated. Applications
> should instead use the provider APIs.
---
Modified: src/modules/tls/tls_domain.c
Modified: src/modules/tls/tls_mod.c
Modified: src/modules/tls/tls_server.c
---
Diff:
https://github.com/kamailio/kamailio/commit/a0a9373ccb3d3da3a1e9e1335d904fcf013d9ebd.diff
Patch:
https://github.com/kamailio/kamailio/commit/a0a9373ccb3d3da3a1e9e1335d904fcf013d9ebd.patch
---
diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c
index b730ccbd948..4e35f91f8a5 100644
--- a/src/modules/tls/tls_domain.c
+++ b/src/modules/tls/tls_domain.c
@@ -30,6 +30,10 @@
#include
#include
+#if OPENSSL_VERSION_NUMBER >= 0x03000L
+#define OPENSSL_NO_ENGINE
+#endif
+
#ifndef OPENSSL_NO_ENGINE
#include
#include "tls_map.h"
diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c
index 156eff81c76..9878c0f5178 100644
--- a/src/modules/tls/tls_mod.c
+++ b/src/modules/tls/tls_mod.c
@@ -87,6 +87,9 @@ int ksr_rand_engine_param(modparam_t type, void *val);
MODULE_VERSION
+#if OPENSSL_VERSION_NUMBER >= 0x03000L
+#define OPENSSL_NO_ENGINE
+#endif
extern str sr_tls_event_callback;
str sr_tls_xavp_cfg = {0, 0};
diff --git a/src/modules/tls/tls_server.c b/src/modules/tls/tls_server.c
index 61df0983b00..721c38451fc 100644
--- a/src/modules/tls/tls_server.c
+++ b/src/modules/tls/tls_server.c
@@ -128,6 +128,9 @@ int tls_run_event_routes(struct tcp_connection *c);
#endif /* __SUNPRO_c */
#endif /* TLS_RD_DEBUG */
+#if OPENSSL_VERSION_NUMBER >= 0x03000L
+#define OPENSSL_NO_ENGINE
+#endif
extern str sr_tls_xavp_cfg;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tls: openssl 3.0 changes (PR #3482)
Merged #3482 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3482#event-9578079963 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:9d6bfb96: tls: OPENSSL_fork_[prepare|parent|child] deprecated at openssl 3.0
Module: kamailio
Branch: master
Commit: 9d6bfb96528c49e6aaa39aa47be877ca528c3537
URL:
https://github.com/kamailio/kamailio/commit/9d6bfb96528c49e6aaa39aa47be877ca528c3537
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-20T12:51:16+02:00
tls: OPENSSL_fork_[prepare|parent|child] deprecated at openssl 3.0
>From https://www.openssl.org/docs/man3.0/man3/OPENSSL_fork_prepare.html:
> OPENSSL_fork_prepare, OPENSSL_fork_parent, OPENSSL_fork_child have been
> deprecated since OpenSSL 3.0.
>
> These methods are currently unused, and as such, no replacement methods
> are required or planned.
>
> OpenSSL has state that should be reset when a process forks. For
> example, the entropy pool used to generate random numbers (and therefore
> encryption keys) should not be shared across multiple programs. The
> OPENSSL_fork_prepare(), OPENSSL_fork_parent(), and OPENSSL_fork_child()
> functions are used to reset this internal state.
>
> OPENSSL_init_crypto(3) will register these functions with the
> appropriate handler, when the OPENSSL_INIT_ATFORK flag is used
---
Modified: src/modules/tls/tls_init.c
Modified: src/modules/tls/tls_mod.c
---
Diff:
https://github.com/kamailio/kamailio/commit/9d6bfb96528c49e6aaa39aa47be877ca528c3537.diff
Patch:
https://github.com/kamailio/kamailio/commit/9d6bfb96528c49e6aaa39aa47be877ca528c3537.patch
---
diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c
index 0a2f13a77b2..cb035ee24fa 100644
--- a/src/modules/tls/tls_init.c
+++ b/src/modules/tls/tls_init.c
@@ -745,7 +745,7 @@ int tls_h_mod_pre_init_f(void)
LM_DBG("preparing tls env for modules initialization\n");
#if OPENSSL_VERSION_NUMBER >= 0x01010L && !defined(LIBRESSL_VERSION_NUMBER)
LM_DBG("preparing tls env for modules initialization (libssl >=1.1)\n");
- OPENSSL_init_ssl(0, NULL);
+ OPENSSL_init_ssl(OPENSSL_INIT_ATFORK, NULL);
#else
LM_DBG("preparing tls env for modules initialization (libssl <=1.0)\n");
SSL_library_init();
diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c
index 3f42073b175..156eff81c76 100644
--- a/src/modules/tls/tls_mod.c
+++ b/src/modules/tls/tls_mod.c
@@ -452,7 +452,8 @@ static int mod_child(int rank)
< 0)
return -1;
}
-#if OPENSSL_VERSION_NUMBER >= 0x010101000L
+#if OPENSSL_VERSION_NUMBER >= 0x010101000L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
if(ksr_tls_init_mode & TLS_MODE_FORK_PREPARE) {
OPENSSL_fork_prepare();
}
@@ -460,7 +461,8 @@ static int mod_child(int rank)
return 0;
}
-#if OPENSSL_VERSION_NUMBER >= 0x010101000L
+#if OPENSSL_VERSION_NUMBER >= 0x010101000L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
if(ksr_tls_init_mode & TLS_MODE_FORK_PREPARE) {
if(rank == PROC_POSTCHILDINIT) {
/*
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:c4b04696: tls: disable tls_rand for openssl >= 3.0
Module: kamailio
Branch: master
Commit: c4b04696a6bfe31fdd65fa56529b0d46f2774067
URL:
https://github.com/kamailio/kamailio/commit/c4b04696a6bfe31fdd65fa56529b0d46f2774067
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-20T12:51:16+02:00
tls: disable tls_rand for openssl >= 3.0
>From https://www.openssl.org/docs/man3.0/man3/RAND_set_rand_method.html
> All of the functions described on this page are deprecated.
> Applications should instead use RAND_set_DRBG_type(3), EVP_RAND(3) and
> EVP_RAND(7).
---
Modified: src/modules/tls/tls_mod.c
Modified: src/modules/tls/tls_rand.c
Modified: src/modules/tls/tls_rand.h
---
Diff:
https://github.com/kamailio/kamailio/commit/c4b04696a6bfe31fdd65fa56529b0d46f2774067.diff
Patch:
https://github.com/kamailio/kamailio/commit/c4b04696a6bfe31fdd65fa56529b0d46f2774067.patch
---
diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c
index 9878c0f5178..c966e34b6f8 100644
--- a/src/modules/tls/tls_mod.c
+++ b/src/modules/tls/tls_mod.c
@@ -510,7 +510,8 @@ static void mod_destroy(void)
int ksr_rand_engine_param(modparam_t type, void *val)
{
-#if OPENSSL_VERSION_NUMBER >= 0x1010L
+#if OPENSSL_VERSION_NUMBER >= 0x1010L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
str *reng;
if(val == NULL) {
@@ -678,7 +679,8 @@ int mod_register(char *path, int *dlflags, void *p1, void
*p2)
register_tls_hooks(_h);
-#if OPENSSL_VERSION_NUMBER >= 0x1010L
+#if OPENSSL_VERSION_NUMBER >= 0x1010L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
LM_DBG("setting cryptorand random engine\n");
RAND_set_rand_method(RAND_ksr_cryptorand_method());
#endif
diff --git a/src/modules/tls/tls_rand.c b/src/modules/tls/tls_rand.c
index 297855e5b4a..288642e4ce7 100644
--- a/src/modules/tls/tls_rand.c
+++ b/src/modules/tls/tls_rand.c
@@ -29,7 +29,8 @@
#include "tls_rand.h"
-#if OPENSSL_VERSION_NUMBER >= 0x1010L
+#if OPENSSL_VERSION_NUMBER >= 0x1010L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
#include "../../core/dprint.h"
#include "../../core/locking.h"
diff --git a/src/modules/tls/tls_rand.h b/src/modules/tls/tls_rand.h
index 34d6b2d1ff2..58ddc853acd 100644
--- a/src/modules/tls/tls_rand.h
+++ b/src/modules/tls/tls_rand.h
@@ -21,7 +21,8 @@
#define _TLS_RAND_H_
#include
-#if OPENSSL_VERSION_NUMBER >= 0x1010L
+#if OPENSSL_VERSION_NUMBER >= 0x1010L \
+ && OPENSSL_VERSION_NUMBER < 0x03000L
#include
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tls: openssl 3.0 changes (PR #3482)
@linuxmaniac pushed 2 commits. 4980e0584c08b1357e1165e9ec4f35f2476856fa tls: disable engine for openssl >= 3.0 bc6326ab747c35f689410b1f51aa956141ffe7e5 tls: disable tls_rand for openssl >= 3.0 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3482/files/cbbdbdc19611bb0b1969712726f7582b6c732149..bc6326ab747c35f689410b1f51aa956141ffe7e5 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tls: openssl 3.0 changes (PR #3482)
@linuxmaniac pushed 3 commits. ab4cd28371a47f32d65ba5fc643f8857ed8ef9aa tls: OPENSSL_fork_[prepare|parent|child] deprecated at openssl 3.0 808223dc0808d63544772d5aef7f19a24cbca215 tls: disable engine for openssl >= 3.0 cbbdbdc19611bb0b1969712726f7582b6c732149 tls: disable tls_rand for openssl >= 3.0 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3482/files/4cbe8241f59c3238472facd85ccf7ac7fe67995d..cbbdbdc19611bb0b1969712726f7582b6c732149 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
disabling tls_rand too at (vseva/tls https://github.com/kamailio/kamailio/pull/3482/commits/4cbe8241f59c3238472facd85ccf7ac7fe67995d ) No more warnings with openssl 3.0. Now we have to test it. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1597577886 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tls: openssl 3.0 changes (PR #3482)
@linuxmaniac pushed 1 commit. 4cbe8241f59c3238472facd85ccf7ac7fe67995d tls: disable tls_rand for openssl >= 3.0 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3482/files/9e0197ca3a130a559db08fcd4b352a03c5371f04..4cbe8241f59c3238472facd85ccf7ac7fe67995d You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
@juha-h with 9e0197ca3a130a559db08fcd4b352a03c5371f04 ( vseva/tls branch ) last warnings are: ``` tls_mod.c: In function 'ksr_rand_engine_param': tls_mod.c:523:17: warning: 'RAND_set_rand_method' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 523 | RAND_set_rand_method(RAND_ksr_krand_method()); | ^~~~ In file included from tls_rand.h:26, from tls_mod.c:54: /usr/include/openssl/rand.h:49:27: note: declared here 49 | OSSL_DEPRECATEDIN_3_0 int RAND_set_rand_method(const RAND_METHOD *meth); | ^~~~ tls_mod.c:526:17: warning: 'RAND_set_rand_method' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 526 | RAND_set_rand_method(RAND_ksr_fastrand_method()); | ^~~~ /usr/include/openssl/rand.h:49:27: note: declared here 49 | OSSL_DEPRECATEDIN_3_0 int RAND_set_rand_method(const RAND_METHOD *meth); | ^~~~ tls_mod.c:529:17: warning: 'RAND_set_rand_method' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 529 | RAND_set_rand_method(RAND_ksr_cryptorand_method()); | ^~~~ /usr/include/openssl/rand.h:49:27: note: declared here 49 | OSSL_DEPRECATEDIN_3_0 int RAND_set_rand_method(const RAND_METHOD *meth); | ^~~~ tls_mod.c:532:17: warning: 'RAND_set_rand_method' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 532 | RAND_set_rand_method(RAND_ksr_kxlibssl_method()); | ^~~~ /usr/include/openssl/rand.h:49:27: note: declared here 49 | OSSL_DEPRECATEDIN_3_0 int RAND_set_rand_method(const RAND_METHOD *meth); | ^~~~ tls_mod.c: In function 'mod_register': tls_mod.c:683:9: warning: 'RAND_set_rand_method' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 683 | RAND_set_rand_method(RAND_ksr_cryptorand_method()); | ^~~~ /usr/include/openssl/rand.h:49:27: note: declared here 49 | OSSL_DEPRECATEDIN_3_0 int RAND_set_rand_method(const RAND_METHOD *meth); | ^~~~ CC (gcc) [M tls.so] tls_rand.o tls_rand.c: In function 'ksr_kxlibssl_init': tls_rand.c:179:17: warning: 'RAND_get_rand_method' is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations] 179 | _ksr_kxlibssl_local_method = RAND_get_rand_method(); | ^~ In file included from tls_rand.h:26, from tls_rand.c:30: /usr/include/openssl/rand.h:50:42: note: declared here 50 | OSSL_DEPRECATEDIN_3_0 const RAND_METHOD *RAND_get_rand_method(void); | ^~~~ ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1597043934 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
> From https://www.openssl.org/docs/man3.0/man7/migration_guide.html > > > Engines and "METHOD" APIs > > The refactoring to support Providers conflicts internally with the APIs > > used to support engines, including the ENGINE API and any function that > > creates or modifies custom "METHODS" (for example > > [EVP_MD_meth_new(3)](http://man.he.net/man3/EVP_MD_meth_new), > > [EVP_CIPHER_meth_new(3)](http://man.he.net/man3/EVP_CIPHER_meth_new), > > [EVP_PKEY_meth_new(3)](http://man.he.net/man3/EVP_PKEY_meth_new), > > [RSA_meth_new(3)](http://man.he.net/man3/RSA_meth_new), > > [EC_KEY_METHOD_new(3)](http://man.he.net/man3/EC_KEY_METHOD_new), etc.). > > These functions are being deprecated in OpenSSL 3.0, and users of these > > APIs should know that their use can likely bypass provider selection and > > configuration, with unintended consequences. This is particularly relevant > > for applications written to use the OpenSSL 3.0 FIPS module, as detailed > > below. Authors and maintainers of external engines are strongly encouraged > > to refactor their code transforming engines into providers using the new > > Provider API and avoiding deprecated methods. > > related to: > [3948783](https://github.com/kamailio/kamailio/commit/394878313770a3b8b57a346a0a323effe8e88a4f) > all ENGINE_* warnings @aalba6675 maybe for openssl >= 3.0 an external implementation of [PKCS#11 provider](https://github.com/latchset/pkcs11-provider) is good enough or at least the way to move forward? I would disable tls_engine by default for openssl >= 3.0 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1597041928 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] tls: openssl 3.0 changes (PR #3482)
@linuxmaniac pushed 2 commits. a498be6438eb08956491660a644fb989c1889cc0 tls: OPENSSL_fork_[prepare|parent|child] deprecated at openssl 3.0 9e0197ca3a130a559db08fcd4b352a03c5371f04 tls: disable engine for openssl >= 3.0 -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3482/files/91c0280370f8f1ccb1508b390f9f8e2dc14eb280..9e0197ca3a130a559db08fcd4b352a03c5371f04 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
>From https://www.openssl.org/docs/man3.0/man7/migration_guide.html > Engines and "METHOD" APIs >The refactoring to support Providers conflicts internally with the APIs used >to support engines, including the ENGINE API and any function that creates or >modifies custom "METHODS" (for example >[EVP_MD_meth_new(3)](http://man.he.net/man3/EVP_MD_meth_new), >[EVP_CIPHER_meth_new(3)](http://man.he.net/man3/EVP_CIPHER_meth_new), >[EVP_PKEY_meth_new(3)](http://man.he.net/man3/EVP_PKEY_meth_new), >[RSA_meth_new(3)](http://man.he.net/man3/RSA_meth_new), >[EC_KEY_METHOD_new(3)](http://man.he.net/man3/EC_KEY_METHOD_new), etc.). These >functions are being deprecated in OpenSSL 3.0, and users of these APIs should >know that their use can likely bypass provider selection and configuration, >with unintended consequences. This is particularly relevant for applications >written to use the OpenSSL 3.0 FIPS module, as detailed below. Authors and >maintainers of external engines are strongly encouraged to refactor their code >transforming engines into providers using the new Provider API and avoiding >deprecated methods. related to: https://github.com/kamailio/kamailio/commit/394878313770a3b8b57a346a0a323effe8e88a4f all ENGINE_* warnings -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1596731488 You are receiving this because you commented. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warnings on bookworm (Issue #3484)
@juha-h can you please test https://github.com/kamailio/kamailio/pull/3482? At least the OPENSSL_fork_* warnings should be solved. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3484#issuecomment-1592915447 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:3a8ebf57: db_redis: graceful scan
Module: kamailio
Branch: master
Commit: 3a8ebf5717eba0116cb71c7f953e9b7ff60d4b0e
URL:
https://github.com/kamailio/kamailio/commit/3a8ebf5717eba0116cb71c7f953e9b7ff60d4b0e
Author: Sipwise Development Team
Committer: Victor Seva
Date: 2023-06-14T14:26:27+02:00
db_redis: graceful scan
---
Modified: src/modules/db_redis/redis_dbase.c
---
Diff:
https://github.com/kamailio/kamailio/commit/3a8ebf5717eba0116cb71c7f953e9b7ff60d4b0e.diff
Patch:
https://github.com/kamailio/kamailio/commit/3a8ebf5717eba0116cb71c7f953e9b7ff60d4b0e.patch
---
diff --git a/src/modules/db_redis/redis_dbase.c
b/src/modules/db_redis/redis_dbase.c
index bda72446d9..eebd7e54ce 100644
--- a/src/modules/db_redis/redis_dbase.c
+++ b/src/modules/db_redis/redis_dbase.c
@@ -824,7 +824,7 @@ static int db_redis_scan_query_keys_pattern(km_redis_con_t
*con,
int l;
-#undef USE_SCAN
+#define USE_SCAN
#ifdef USE_SCAN
@@ -832,6 +832,8 @@ static int db_redis_scan_query_keys_pattern(km_redis_con_t
*con,
unsigned long cursor = 0;
unsigned int match_count = match_count_start_val;
char match_count_str[16];
+ struct timeval start_tv, end_tv;
+ long tv_diff;
do {
snprintf(cursor_str, sizeof(cursor_str), "%lu", cursor);
@@ -869,8 +871,12 @@ static int db_redis_scan_query_keys_pattern(km_redis_con_t
*con,
LM_ERR("Failed to add count value to scan query\n");
goto err;
}
-
+ gettimeofday(_tv, NULL);
reply = db_redis_command_argv(con, query_v);
+ gettimeofday(_tv, NULL);
+ tv_diff = ((long long)end_tv.tv_sec * 1000LL + end_tv.tv_usec /
1000L)
+ - ((long long)start_tv.tv_sec * 1000LL
+ + start_tv.tv_usec / 1000L);
db_redis_key_free(_v);
db_redis_check_reply(con, reply, err);
if(reply->type != REDIS_REPLY_ARRAY) {
@@ -966,11 +972,15 @@ static int
db_redis_scan_query_keys_pattern(km_redis_con_t *con,
}
#ifdef USE_SCAN
- // exponential increase and falloff, hovering around 1000
results
- if(keys_list->elements > 1300 && match_count > 500)
+ // exponential increase and falloff, not to exceed ~100 ms
query run time
+ if(tv_diff > 50 && match_count > 10)
match_count /= 2;
- else if(keys_list->elements < 700 && match_count < 50)
+ else if(tv_diff < 25 && match_count < 100)
match_count *= 2;
+ if(cursor > 0) {
+ // give other queries some time to run
+ usleep(10);
+ }
#endif
db_redis_free_reply();
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:41c47363: db_redis: use sscan
Module: kamailio Branch: master Commit: 41c4736367186f43e68361be0460bd590b7660bd URL: https://github.com/kamailio/kamailio/commit/41c4736367186f43e68361be0460bd590b7660bd Author: Sipwise Development Team Committer: Victor Seva Date: 2023-06-14T14:26:28+02:00 db_redis: use sscan --- Modified: src/modules/db_redis/redis_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/41c4736367186f43e68361be0460bd590b7660bd.diff Patch: https://github.com/kamailio/kamailio/commit/41c4736367186f43e68361be0460bd590b7660bd.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:c5a3c2cd: db_redis: skip empty keys
Module: kamailio
Branch: master
Commit: c5a3c2cd8c6952356237c235c2ade159c030382b
URL:
https://github.com/kamailio/kamailio/commit/c5a3c2cd8c6952356237c235c2ade159c030382b
Author: Sipwise Development Team
Committer: Victor Seva
Date: 2023-06-14T14:26:27+02:00
db_redis: skip empty keys
---
Modified: src/modules/db_redis/redis_dbase.c
---
Diff:
https://github.com/kamailio/kamailio/commit/c5a3c2cd8c6952356237c235c2ade159c030382b.diff
Patch:
https://github.com/kamailio/kamailio/commit/c5a3c2cd8c6952356237c235c2ade159c030382b.patch
---
diff --git a/src/modules/db_redis/redis_dbase.c
b/src/modules/db_redis/redis_dbase.c
index 83d11e9b318..bda72446d96 100644
--- a/src/modules/db_redis/redis_dbase.c
+++ b/src/modules/db_redis/redis_dbase.c
@@ -700,6 +700,9 @@ static int db_redis_build_query_keys(km_redis_con_t *con,
const str *table_name,
LM_DBG("no direct entry key found, checking type keys\n");
for(type = table->types; type; type = type->next) {
key = type->keys;
+ /* skip value-less master keys */
+ if(!key)
+ continue;
LM_DBG("checking type '%.*s'\n", type->type.len,
type->type.s);
if(db_redis_find_query_key(key, table_name, table,
>type, _k,
_v, _op, _n, , _found,
ts_scan_start)
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:60485701: pv_headers: rework pvh_remove_header_param, take two
Module: kamailio Branch: master Commit: 60485701ea3c065e657206ebcb6dbfa212adf1d4 URL: https://github.com/kamailio/kamailio/commit/60485701ea3c065e657206ebcb6dbfa212adf1d4 Author: Victor Seva Committer: Victor Seva Date: 2023-06-14T11:43:43+02:00 pv_headers: rework pvh_remove_header_param, take two * pvh_set_xavi changes/removes xavi, so we need the new value * after pvh_remove_header, search for the header again --- Modified: src/modules/pv_headers/pv_headers.c Modified: src/modules/pv_headers/pvh_func.c Modified: src/modules/pv_headers/pvh_xavp.c Modified: src/modules/pv_headers/pvh_xavp.h --- Diff: https://github.com/kamailio/kamailio/commit/60485701ea3c065e657206ebcb6dbfa212adf1d4.diff Patch: https://github.com/kamailio/kamailio/commit/60485701ea3c065e657206ebcb6dbfa212adf1d4.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:dd9c891b: cfgt: don't dump same node
Module: kamailio
Branch: master
Commit: dd9c891bafe8de5dace630d676f9ea697152a4de
URL:
https://github.com/kamailio/kamailio/commit/dd9c891bafe8de5dace630d676f9ea697152a4de
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-14T11:30:06+02:00
cfgt: don't dump same node
---
Modified: src/modules/cfgt/cfgt_int.c
---
Diff:
https://github.com/kamailio/kamailio/commit/dd9c891bafe8de5dace630d676f9ea697152a4de.diff
Patch:
https://github.com/kamailio/kamailio/commit/dd9c891bafe8de5dace630d676f9ea697152a4de.patch
---
diff --git a/src/modules/cfgt/cfgt_int.c b/src/modules/cfgt/cfgt_int.c
index 2480f4b66f1..6dba3a1dc94 100644
--- a/src/modules/cfgt/cfgt_int.c
+++ b/src/modules/cfgt/cfgt_int.c
@@ -32,6 +32,7 @@
#include "../../core/rpc.h"
#include "../../core/rpc_lookup.h"
#include "../../core/parser/msg_parser.h"
+#include "../../core/script_cb.h"
#include "cfgt_int.h"
#include "cfgt_json.h"
@@ -460,11 +461,25 @@ void _cfgt_print_node(cfgt_node_p node, int json)
int _cfgt_set_dump(struct sip_msg *msg, cfgt_node_p node, str *flow)
{
+ int len;
+ char v;
srjson_t *f, *vars;
if(node == NULL || flow == NULL)
return -1;
+ /* don't generate two same nodes */
+ if((len = srjson_GetArraySize(>jdoc, node->flow)) >= 1) {
+ f = srjson_GetArrayItem(>jdoc, node->flow, len - 1);
+ STR_VTOZ(flow->s[flow->len], v);
+ f = srjson_GetObjectItem(>jdoc, f, flow->s);
+ STR_ZTOV(flow->s[flow->len], v);
+ if(f != NULL) {
+ LM_DBG("node[%.*s] flow already there\n", flow->len,
flow->s);
+ return 0;
+ }
+ }
+
vars = srjson_CreateObject(>jdoc);
if(vars == NULL) {
LM_ERR("cannot create json object\n");
@@ -763,11 +778,35 @@ int cfgt_msgin(sr_event_param_t *evp)
return -1;
}
+static inline void print_cb_flags(unsigned int flags)
+{
+ LM_DBG("flags:");
+ if(flags & REQUEST_CB)
+ LM_DBG("REQUEST_CB");
+ if(flags & FAILURE_CB)
+ LM_DBG("FAILURE_CB");
+ if(flags & ONREPLY_CB)
+ LM_DBG("ONREPLY_CB");
+ if(flags & BRANCH_CB)
+ LM_DBG("BRANCH_CB");
+ if(flags & ONSEND_CB)
+ LM_DBG("ONSEND_CB");
+ if(flags & ERROR_CB)
+ LM_DBG("ERROR_CB");
+ if(flags & LOCAL_CB)
+ LM_DBG("LOCAL_CB");
+ if(flags & EVENT_CB)
+ LM_DBG("EVENT_CB");
+ if(flags & BRANCH_FAILURE_CB)
+ LM_DBG("BRANCH_FAILURE_CB");
+}
+
int cfgt_pre(struct sip_msg *msg, unsigned int flags, void *bar)
{
str unknown = {"unknown", 7};
int get_hdr_result = 0, res;
+ print_cb_flags(flags);
if(_cfgt_node) {
if(_cfgt_node->msgid == 0) {
LM_DBG("new node\n");
@@ -812,7 +851,7 @@ int cfgt_pre(struct sip_msg *msg, unsigned int flags, void
*bar)
int cfgt_post(struct sip_msg *msg, unsigned int flags, void *bar)
{
str flowname = STR_NULL;
-
+ print_cb_flags(flags);
if(_cfgt_node) {
if(cfgt_skip_unknown
&& strncmp(_cfgt_node->uuid.s, "unknown", 7) ==
0) {
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:b5ea290b: cfgt: skip_unknown modparam
Module: kamailio
Branch: master
Commit: b5ea290be4a5f92cd24dd39cbefe2987ed577d19
URL:
https://github.com/kamailio/kamailio/commit/b5ea290be4a5f92cd24dd39cbefe2987ed577d19
Author: Victor Seva
Committer: Victor Seva
Date: 2023-06-14T11:25:28+02:00
cfgt: skip_unknown modparam
If enabled, value different from 0, cfgt will not generate the report
of any message that doesn't match the callid_prefix.
---
Modified: src/modules/cfgt/cfgt_int.c
Modified: src/modules/cfgt/cfgt_mod.c
Modified: src/modules/cfgt/doc/cfgt_admin.xml
---
Diff:
https://github.com/kamailio/kamailio/commit/b5ea290be4a5f92cd24dd39cbefe2987ed577d19.diff
Patch:
https://github.com/kamailio/kamailio/commit/b5ea290be4a5f92cd24dd39cbefe2987ed577d19.patch
---
diff --git a/src/modules/cfgt/cfgt_int.c b/src/modules/cfgt/cfgt_int.c
index 2509b3eb6e7..2480f4b66f1 100644
--- a/src/modules/cfgt/cfgt_int.c
+++ b/src/modules/cfgt/cfgt_int.c
@@ -43,6 +43,7 @@ cfgt_hash_p _cfgt_uuid = NULL;
str cfgt_hdr_prefix = {"NGCP%", 5};
str cfgt_basedir = {"/tmp", 4};
int cfgt_mask = CFGT_DP_ALL;
+int cfgt_skip_unknown = 0;
int not_sip = 0;
int _cfgt_get_filename(int msgid, str uuid, str *dest, int *dir);
@@ -385,6 +386,10 @@ void cfgt_save_node(cfgt_node_p node)
str dest = STR_NULL;
int dir = 0;
struct stat sb;
+ if(cfgt_skip_unknown && strncmp(_cfgt_node->uuid.s, "unknown", 7) == 0)
{
+ LM_DBG("skip unknown\n");
+ return;
+ }
if(_cfgt_get_filename(node->msgid, node->uuid, , ) < 0) {
LM_ERR("can't build filename\n");
return;
@@ -658,6 +663,9 @@ int cfgt_process_route(struct sip_msg *msg, struct action
*a)
LM_ERR("node empty\n");
return -1;
}
+ if(cfgt_skip_unknown && strncmp(_cfgt_node->uuid.s, "unknown", 7) == 0)
{
+ return 0;
+ }
if(a->rname == NULL) {
LM_DBG("no routename. type:%d\n", a->type);
return 0;
@@ -806,6 +814,10 @@ int cfgt_post(struct sip_msg *msg, unsigned int flags,
void *bar)
str flowname = STR_NULL;
if(_cfgt_node) {
+ if(cfgt_skip_unknown
+ && strncmp(_cfgt_node->uuid.s, "unknown", 7) ==
0) {
+ return 1;
+ }
LM_DBG("dump last flow\n");
if(_cfgt_node->route == NULL
&& strncmp(_cfgt_node->uuid.s, "unknown", 7) ==
0)
@@ -844,6 +856,10 @@ int cfgt_msgout(sr_event_param_t *evp)
}
if(_cfgt_node) {
+ if(cfgt_skip_unknown
+ && strncmp(_cfgt_node->uuid.s, "unknown", 7) ==
0) {
+ return 0;
+ }
jobj = srjson_CreateStr(&_cfgt_node->jdoc, buf->s, buf->len);
if(jobj == NULL) {
LM_ERR("cannot create json object\n");
diff --git a/src/modules/cfgt/cfgt_mod.c b/src/modules/cfgt/cfgt_mod.c
index 728d22813c8..7dec36ae064 100644
--- a/src/modules/cfgt/cfgt_mod.c
+++ b/src/modules/cfgt/cfgt_mod.c
@@ -42,6 +42,7 @@ unsigned int init_flag = 0;
extern int cfgt_mask;
extern str cfgt_basedir;
extern str cfgt_hdr_prefix;
+extern int cfgt_skip_unknown;
/* clang-format off */
/*! \brief
* Exported functions
@@ -58,6 +59,7 @@ static param_export_t params[] = {
{"basedir", PARAM_STR, _basedir},
{"mask", INT_PARAM, _mask},
{"callid_prefix", PARAM_STR, _hdr_prefix},
+ {"skip_unknown", INT_PARAM, _skip_unknown},
{0, 0, 0}
};
diff --git a/src/modules/cfgt/doc/cfgt_admin.xml
b/src/modules/cfgt/doc/cfgt_admin.xml
index 2a2b158e57d..84d3df612e6 100644
--- a/src/modules/cfgt/doc/cfgt_admin.xml
+++ b/src/modules/cfgt/doc/cfgt_admin.xml
@@ -143,6 +143,26 @@ modparam("cfgt", "mask", 12)
# using '%' as delimiter
modparam("cfgt", "callid_prefix", "TEST-ID%")
...
+
+
+
+
+ skip_unknown (int)
+
+ If enabled, value different from 0, cfgt will not
generate the report
+ of any message that doesn't match the callid_prefix.
+
+
+
+ Default value is 0, false.
+
+
+
+ Set skip_unknown parameter
+
+...
+modparam("cfgt", "skip_unknown", "1")
+...
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:1ce15ab7: cfgt: route_log modparam
Module: kamailio Branch: master Commit: 1ce15ab7094d3b13bf6db3cabb86bcdbab969d88 URL: https://github.com/kamailio/kamailio/commit/1ce15ab7094d3b13bf6db3cabb86bcdbab969d88 Author: Victor Seva Committer: Victor Seva Date: 2023-06-14T11:30:40+02:00 cfgt: route_log modparam If enabled, cfgt will log (WARN) the execution time of routes. --- Modified: src/modules/cfgt/cfgt_int.c Modified: src/modules/cfgt/cfgt_int.h Modified: src/modules/cfgt/cfgt_mod.c Modified: src/modules/cfgt/doc/cfgt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1ce15ab7094d3b13bf6db3cabb86bcdbab969d88.diff Patch: https://github.com/kamailio/kamailio/commit/1ce15ab7094d3b13bf6db3cabb86bcdbab969d88.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:c3f2ff65: pua_dialoginfo: fix dlg_var store and retrieval
Module: kamailio Branch: master Commit: c3f2ff656475d85b190f0a2f138b526d9a63e732 URL: https://github.com/kamailio/kamailio/commit/c3f2ff656475d85b190f0a2f138b526d9a63e732 Author: Victor Seva Committer: Victor Seva Date: 2023-06-14T10:53:34+02:00 pua_dialoginfo: fix dlg_var store and retrieval * pubruri_calle[e|r]_avp can have more than one value. Store values as comma separate strings at pubruri_calle[e|r]_dlg_var * be aware of possible multiple values when restoring values from pubruri_calle[e|r]_dlg_var * alloc string values always for str_list --- Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/c3f2ff656475d85b190f0a2f138b526d9a63e732.diff Patch: https://github.com/kamailio/kamailio/commit/c3f2ff656475d85b190f0a2f138b526d9a63e732.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] tls: openssl 3.0 changes (PR #3482)
Pre-Submission Checklist !-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -- !-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-- !-- If youre unsure about any of these, dont hesitate to ask on sr-dev mailing list -- - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) Checklist: !-- Go over all points below, and after creating the PR, tick the checkboxes that apply -- - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issues #3011 #3222 #3259 Description investigate changes needed for openssl 3.0 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3482 -- Commit Summary -- * tls: OPENSSL_fork_[prepare|parent|child] deprecated at openssl 3.0 -- File Changes -- M src/modules/tls/tls_init.c (2) M src/modules/tls/tls_mod.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3482.patch https://github.com/kamailio/kamailio/pull/3482.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3482 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: pv_cache_dump (PR #3448)
Merged #3448 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3448#event-9333218821 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:1205869f: core: pv_cache_dump
Module: kamailio
Branch: master
Commit: 1205869ffd9c7e16a4f299b020f0bc90a2d4fcd7
URL:
https://github.com/kamailio/kamailio/commit/1205869ffd9c7e16a4f299b020f0bc90a2d4fcd7
Author: Victor Seva
Committer: Victor Seva
Date: 2023-05-25T00:16:12+02:00
core: pv_cache_dump
related to #3440
---
Modified: src/core/cfg_core.c
Modified: src/core/cfg_core.h
Modified: src/core/pvapi.c
Modified: src/core/pvapi.h
---
Diff:
https://github.com/kamailio/kamailio/commit/1205869ffd9c7e16a4f299b020f0bc90a2d4fcd7.diff
Patch:
https://github.com/kamailio/kamailio/commit/1205869ffd9c7e16a4f299b020f0bc90a2d4fcd7.patch
---
diff --git a/src/core/cfg_core.c b/src/core/cfg_core.c
index 52629bd9022..982cd6c92ea 100644
--- a/src/core/cfg_core.c
+++ b/src/core/cfg_core.c
@@ -55,6 +55,7 @@
#include "sock_ut.h"
#include "cfg/cfg.h"
#include "cfg_core.h"
+#include "pvapi.h"
struct cfg_group_core default_core_cfg = {
L_WARN, /*!< print only msg. < L_WARN */
@@ -121,6 +122,7 @@ struct cfg_group_core default_core_cfg = {
0, /*!< latency limit db */
0, /*!< latency limit action */
0, /*!< latency limit cfg */
+ 0, /*!< pv_cache_dump */
2048, /*!< pv_cache_limit */
0 /*!< pv_cache_action */
};
@@ -336,6 +338,8 @@ cfg_def_t core_cfg_def[] = {
"limit in ms for alerting on time consuming
config actions"},
{"latency_limit_cfg", CFG_VAR_INT | CFG_ATOMIC, 0, 0, 0, 0,
"limit in ms for alerting on time consuming
config execution"},
+ {"pv_cache_dump", CFG_VAR_INT, 0, 0, 0, pv_cache_dump_cb,
+ "dump process pv cache, parameter: pid_number"},
{"pv_cache_limit", CFG_VAR_INT | CFG_ATOMIC, 0, 0, 0, 0,
"limit to alert if too many vars in pv cache"},
{"pv_cache_action", CFG_VAR_INT | CFG_ATOMIC, 0, 0, 0, 0,
diff --git a/src/core/cfg_core.h b/src/core/cfg_core.h
index e0f5c357073..18dc3b059f7 100644
--- a/src/core/cfg_core.h
+++ b/src/core/cfg_core.h
@@ -112,6 +112,7 @@ struct cfg_group_core
int latency_limit_db; /*!< alert limit of running db commands */
int latency_limit_action; /*!< alert limit of running cfg actions */
int latency_limit_cfg;/*!< alert limit of running cfg routing
script */
+ int pv_cache_dump; /*!< dump process pv cache, parameter:
pid_number */
int pv_cache_limit; /*!< alert limit of having too many vars in pv
cache */
int pv_cache_action; /*!< action to be taken on pv cache limit */
};
diff --git a/src/core/pvapi.c b/src/core/pvapi.c
index 37a872b9575..0bb20367ba5 100644
--- a/src/core/pvapi.c
+++ b/src/core/pvapi.c
@@ -90,6 +90,38 @@ pv_cache_t **pv_cache_get_table(void)
return NULL;
}
+static void pv_cache_dump(int level)
+{
+ int i;
+ pv_cache_t *pvi = NULL;
+
+ if(_pv_cache_set == 0) {
+ LM_DBG("PV cache not initialized\n");
+ return;
+ }
+
+ for(i = 0; i < PV_CACHE_SIZE; i++) {
+ pvi = _pv_cache[i];
+ while(pvi) {
+ LOG(level, "pvar [%.*s] found in cache[%d]\n",
pvi->pvname.len,
+ pvi->pvname.s, i);
+ pvi = pvi->next;
+ }
+ }
+}
+
+/* Dumps pv cache.
+ * Per-child process callback that is called
+ * when pv_cache_dump cfg var is changed.
+ */
+void pv_cache_dump_cb(str *gname, str *name)
+{
+ if(cfg_get(core, core_cfg, pv_cache_dump) == my_pid()) {
+ pv_cache_dump(cfg_get(core, core_cfg, memlog));
+ cfg_get(core, core_cfg, pv_cache_dump) = 0;
+ }
+}
+
/**
* @brief Check if a char is valid according to the PV syntax
* @param c checked char
diff --git a/src/core/pvapi.h b/src/core/pvapi.h
index 729bcf307f0..9cea1a803d4 100644
--- a/src/core/pvapi.h
+++ b/src/core/pvapi.h
@@ -22,6 +22,7 @@
#ifndef __pvapi_h__
#define __pvapi_h__
+#include "str.h"
int pv_init_api(void);
void pv_destroy_api(void);
@@ -34,6 +35,7 @@ int pv_get_buffer_size(void);
int pv_get_buffer_slots(void);
void pv_set_buffer_size(int n);
void pv_set_buffer_slots(int n);
+void pv_cache_dump_cb(str *gname, str *name);
#endif /*__pvapi_h__*/
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: pv_cache_dump (PR #3448)
@linuxmaniac pushed 1 commit. ed29e2f1d4d600ae4899896668b0cd121064e4e4 core: pv_cache_dump -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3448/files/b2188e30d3728a7f4bf5aec6359c92183becdc15..ed29e2f1d4d600ae4899896668b0cd121064e4e4 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:a2209018: core: clang-format for coherent indentation and coding style
Module: kamailio Branch: master Commit: a2209018fb03dda6d4b7df90f933c97bf4ae532b URL: https://github.com/kamailio/kamailio/commit/a2209018fb03dda6d4b7df90f933c97bf4ae532b Author: Victor Seva Committer: Victor Seva Date: 2023-05-19T01:40:55+02:00 core: clang-format for coherent indentation and coding style --- Modified: src/core/action.c Modified: src/core/action.h Modified: src/core/async_task.c Modified: src/core/async_task.h Modified: src/core/atomic/atomic_alpha.h Modified: src/core/atomic/atomic_arm.h Modified: src/core/atomic/atomic_common.h Modified: src/core/atomic/atomic_mips2.h Modified: src/core/atomic/atomic_native.h Modified: src/core/atomic/atomic_ppc.h Modified: src/core/atomic/atomic_sparc.h Modified: src/core/atomic/atomic_sparc64.h Modified: src/core/atomic/atomic_unknown.h Modified: src/core/atomic/atomic_x86.h Modified: src/core/atomic_ops.c Modified: src/core/atomic_ops.h Modified: src/core/basex.c Modified: src/core/basex.h Modified: src/core/bit_count.h Modified: src/core/bit_scan.c Modified: src/core/bit_scan.h Modified: src/core/bit_test.h Modified: src/core/cfg/cfg.c Modified: src/core/cfg/cfg.h Modified: src/core/cfg/cfg_ctx.c Modified: src/core/cfg/cfg_ctx.h Modified: src/core/cfg/cfg_script.c Modified: src/core/cfg/cfg_script.h Modified: src/core/cfg/cfg_select.c Modified: src/core/cfg/cfg_select.h Modified: src/core/cfg/cfg_struct.c Modified: src/core/cfg/cfg_struct.h Modified: src/core/cfg_core.c Modified: src/core/cfg_core.h Modified: src/core/cfg_parser.c Modified: src/core/cfg_parser.h Modified: src/core/char_msg_val.h Modified: src/core/clist.h Modified: src/core/compiler_opt.h Modified: src/core/config.h Modified: src/core/core_cmd.c Modified: src/core/core_stats.h Modified: src/core/counters.c Modified: src/core/counters.h Modified: src/core/crc.c Modified: src/core/crc.h Modified: src/core/crypto/md5.c Modified: src/core/crypto/md5.h Modified: src/core/crypto/md5utils.c Modified: src/core/crypto/md5utils.h Modified: src/core/crypto/rijndael.c Modified: src/core/crypto/rijndael.h Modified: src/core/crypto/sha256.c Modified: src/core/crypto/sha256.h Modified: src/core/crypto/shautils.c Modified: src/core/daemonize.c Modified: src/core/daemonize.h Modified: src/core/data_lump.c Modified: src/core/data_lump.h Modified: src/core/data_lump_rpl.c Modified: src/core/data_lump_rpl.h Modified: src/core/dns_cache.c Modified: src/core/dns_cache.h Modified: src/core/dns_func.c Modified: src/core/dns_func.h Modified: src/core/dns_wrappers.h Modified: src/core/dprint.c Modified: src/core/dprint.h Modified: src/core/dset.c Modified: src/core/dset.h Modified: src/core/dst_blocklist.c Modified: src/core/dst_blocklist.h Modified: src/core/endianness.c Modified: src/core/endianness.h Modified: src/core/error.c Modified: src/core/error.h Modified: src/core/events.c Modified: src/core/events.h Modified: src/core/fastlock.h Modified: src/core/fix_lumps.h Modified: src/core/flags.c Modified: src/core/flags.h Modified: src/core/fmsg.c Modified: src/core/fmsg.h Modified: src/core/forward.c Modified: src/core/forward.h Modified: src/core/futexlock.h Modified: src/core/globals.h Modified: src/core/hash_func.c Modified: src/core/hash_func.h Modified: src/core/hashes.h Modified: src/core/id.c Modified: src/core/id.h Modified: src/core/io_wait.c Modified: src/core/io_wait.h Modified: src/core/ip_addr.c Modified: src/core/ip_addr.h Modified: src/core/kemi.c Modified: src/core/kemi.h Modified: src/core/kemiexec.c Modified: src/core/list.h Modified: src/core/local_timer.c Modified: src/core/local_timer.h Modified: src/core/lock_alloc.h Modified: src/core/lock_ops.c Modified: src/core/lock_ops.h Modified: src/core/locking.c Modified: src/core/locking.h Modified: src/core/lump_struct.h Modified: src/core/lvalue.c Modified: src/core/lvalue.h Modified: src/core/mem/dl_malloc.c Modified: src/core/mem/dl_malloc.h Modified: src/core/mem/f_malloc.c Modified: src/core/mem/f_malloc.h Modified: src/core/mem/ll_malloc.c Modified: src/core/mem/ll_malloc.h Modified: src/core/mem/mem.h Modified: src/core/mem/memapi.h Modified: src/core/mem/memdbg.h Modified: src/core/mem/meminfo.h Modified: src/core/mem/memtest.c Modified: src/core/mem/pkg.c Modified: src/core/mem/pkg.h Modified: src/core/mem/q_malloc.c Modified: src/core/mem/q_malloc.h Modified: src/core/mem/sf_malloc.c Modified: src/core/mem/sf_malloc.h Modified: src/core/mem/shm.c Modified: src/core/mem/shm.h Modified: src/core/mem/shm_mem.h Modified: src/core/mem/src_loc.h Modified: src/core/mem/tlsf_malloc.c Modified: src/core/mem/tlsf_malloc.h Modified: src/core/mem/tlsf_malloc_bits.h Modified: src/core/mod_fix.c Modified: src/core/mod_fix.h Modified: src/core/modparam.c Modified: src/core/modparam.h Modified: src/core/msg_translator.c Modified: src/core/msg_translator.h Modified: src/core/name_alias.h Modified: src/core/nonsip_hooks.c Modified: src/core/nonsip_hooks.h Modified: src/core/onsend.c Modified: src/core/onsend.h Modified: src/core/parser
[sr-dev] git:master:339891e7: pre-commit: add mixed-line-ending hook [skip ci]
Module: kamailio Branch: master Commit: 339891e7da584abcc378aa2104f536841d615e57 URL: https://github.com/kamailio/kamailio/commit/339891e7da584abcc378aa2104f536841d615e57 Author: Victor Seva Committer: Victor Seva Date: 2023-05-19T01:40:44+02:00 pre-commit: add mixed-line-ending hook [skip ci] --- Modified: .pre-commit-config.yaml --- Diff: https://github.com/kamailio/kamailio/commit/339891e7da584abcc378aa2104f536841d615e57.diff Patch: https://github.com/kamailio/kamailio/commit/339891e7da584abcc378aa2104f536841d615e57.patch --- diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 6bd7b3d08e..7e8b8a8860 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -7,6 +7,7 @@ repos: - id: end-of-file-fixer - id: trailing-whitespace - id: check-merge-conflict + - id: mixed-line-ending - repo: https://github.com/pre-commit/mirrors-clang-format rev: v15.0.7 hooks: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: clang-format for coherent indentation and coding style (PR #3461)
Closed #3461. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3461#event-9284466235 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:e66a63a2: README: add pre-commit badge
Module: kamailio Branch: master Commit: e66a63a230e91461af0a82e3bbc54eabbf5195c7 URL: https://github.com/kamailio/kamailio/commit/e66a63a230e91461af0a82e3bbc54eabbf5195c7 Author: Victor Seva Committer: Victor Seva Date: 2023-05-19T01:08:17+02:00 README: add pre-commit badge --- Modified: README.md --- Diff: https://github.com/kamailio/kamailio/commit/e66a63a230e91461af0a82e3bbc54eabbf5195c7.diff Patch: https://github.com/kamailio/kamailio/commit/e66a63a230e91461af0a82e3bbc54eabbf5195c7.patch --- diff --git a/README.md b/README.md index aff44050c6a..a4616f9d66c 100644 --- a/README.md +++ b/README.md @@ -2,6 +2,7 @@ [](https://github.com/kamailio/kamailio/actions) [](https://www.codetriage.com/kamailio/kamailio) +[](https://github.com/pre-commit/pre-commit) Project Website: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:e15a57e0: pre-commit: update pre-commit-hooks [skip ci]
Module: kamailio Branch: master Commit: e15a57e0e027425827509277203341d55ace49fa URL: https://github.com/kamailio/kamailio/commit/e15a57e0e027425827509277203341d55ace49fa Author: Victor Seva Committer: Victor Seva Date: 2023-05-19T00:51:27+02:00 pre-commit: update pre-commit-hooks [skip ci] --- Modified: .pre-commit-config.yaml --- Diff: https://github.com/kamailio/kamailio/commit/e15a57e0e027425827509277203341d55ace49fa.diff Patch: https://github.com/kamailio/kamailio/commit/e15a57e0e027425827509277203341d55ace49fa.patch --- diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f9af7b878e1..6bd7b3d08e1 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,6 +1,6 @@ repos: - repo: https://github.com/pre-commit/pre-commit-hooks -rev: v2.3.0 +rev: v4.4.0 hooks: - id: check-yaml - id: check-xml ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:f781dc9c: pre-commit: tool to keep thing tidy [skip ci]
Module: kamailio Branch: master Commit: f781dc9ce914cc619abd9d53f987f117b720 URL: https://github.com/kamailio/kamailio/commit/f781dc9ce914cc619abd9d53f987f117b720 Author: Victor Seva Committer: Victor Seva Date: 2023-05-19T00:25:47+02:00 pre-commit: tool to keep thing tidy [skip ci] --- Added: .pre-commit-config.yaml --- Diff: https://github.com/kamailio/kamailio/commit/f781dc9ce914cc619abd9d53f987f117b720.diff Patch: https://github.com/kamailio/kamailio/commit/f781dc9ce914cc619abd9d53f987f117b720.patch --- diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml new file mode 100644 index 000..f9af7b878e1 --- /dev/null +++ b/.pre-commit-config.yaml @@ -0,0 +1,13 @@ +repos: + - repo: https://github.com/pre-commit/pre-commit-hooks +rev: v2.3.0 +hooks: + - id: check-yaml + - id: check-xml + - id: end-of-file-fixer + - id: trailing-whitespace + - id: check-merge-conflict + - repo: https://github.com/pre-commit/mirrors-clang-format +rev: v15.0.7 +hooks: +- id: clang-format ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:2cac52c6: README: remove travis-ci info [skip ci]
Module: kamailio Branch: master Commit: 2cac52c68feeacc1dc90e4ff322b6109c32669e8 URL: https://github.com/kamailio/kamailio/commit/2cac52c68feeacc1dc90e4ff322b6109c32669e8 Author: Victor Seva Committer: Victor Seva Date: 2023-05-19T00:25:47+02:00 README: remove travis-ci info [skip ci] no longer used --- Modified: README.md --- Diff: https://github.com/kamailio/kamailio/commit/2cac52c68feeacc1dc90e4ff322b6109c32669e8.diff Patch: https://github.com/kamailio/kamailio/commit/2cac52c68feeacc1dc90e4ff322b6109c32669e8.patch --- diff --git a/README.md b/README.md index f0a904a0831..aff44050c6a 100644 --- a/README.md +++ b/README.md @@ -121,9 +121,4 @@ News: * https://www.kamailio.org/w/category/news/ * Twitter @kamailio -## Travis-CI - Testing Build Environment - - * [travis-ci](https://travis-ci.org/kamailio/kamailio/builds/) - * [docker build](/test/travis/README.md) - **Thank you for flying Kamailio!** ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: clang-format for coherent indentation and coding style (PR #3461)
@linuxmaniac pushed 14 commits. 95513201e195147a1363b21b0fd99d35071e0de4 pre-commit: tool to keep thing tidy 9e67b77829c69208a656eecf8805bd21251cb7a3 core: [atomic] clang-format for coherent indentation and coding style 7aede62f97073b5fb066fdda8d9106fb4d876e6f core: [cfg] clang-format for coherent indentation and coding style d1794f1d78bf6231c638152b28588d33565ceb70 core: [crypto] clang-format for coherent indentation and coding style cbc6a0fe229435f0345828dbb6c8e78ae0c5ca94 core: [mem] clang-format for coherent indentation and coding style 7f7ee96a277146380cc425049de5aa855d88a9db core: [parser] clang-format for coherent indentation and coding style 3c225c7447158ccc00a75bc6f3012925bb230502 core: [rand] clang-format for coherent indentation and coding style aaa7a592ebc83ff4aaf19b15f22528a1868c6332 core: [utils] clang-format for coherent indentation and coding style 87e56dbafc6f3652dab52faa5cc473b5d76c7180 core: [action] clang-format for coherent indentation and coding style 56451536a12567d3e2c8d047e17b82857799b79f core: [async_task] clang-format for coherent indentation and coding style fc86c375a492aee89762b922533b256972004db8 core: [atomic_ops] clang-format for coherent indentation and coding style f4741bc29a541dbf34105e98a086fc0b86bb365e core: [basex] clang-format for coherent indentation and coding style 18ae9990df48f676fb965e88b2d6e5741a484c0d core: [bit_*] clang-format for coherent indentation and coding style ab4825d1dc381119ccf64960619a5f22d95662d4 core: [cfg_*] clang-format for coherent indentation and coding style -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3461/files/52d872ad31b39b0488f36a9444762610c98066d6..ab4825d1dc381119ccf64960619a5f22d95662d4 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: git:master:61833193: dispatcher: fix force send socket functionality, was not working in some TCP scenarios
Hi, On 18/5/23 13:43, Henning Westerholt wrote: Should be fixed now. Just to be 100% safe - executing the clang-format in the Kamailio root will pick up the correct format, right? Yes, it's fixed. Yes, executing the clang-format at the root of the repository will pick the .clang-format configuration Thanks -- - | ,''`. Victor Seva | | : :' : linuxman...@torreviejawireless.org | | `. `' PGP Key ID: 0x51A09B18CF5A5068 | |`- Debian Developer | - OpenPGP_0x51A09B18CF5A5068.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: git:master:61833193: dispatcher: fix force send socket functionality, was not working in some TCP scenarios
Hi,
On 18/5/23 12:54, Henning Westerholt wrote:
Module: kamailio
Branch: master
Commit: 6183319381573e42b882d05ae1748539f7547d8c
URL:
https://github.com/kamailio/kamailio/commit/6183319381573e42b882d05ae1748539f7547d8c
We have to find a way to enforce clang-format. First commit after the huge
merge... now it doesn't pass the check.
diff --git a/src/modules/dispatcher/dispatch.c
b/src/modules/dispatcher/dispatch.c
index f0322a6b57..e8d7886ec9 100644
--- a/src/modules/dispatcher/dispatch.c
+++ b/src/modules/dispatcher/dispatch.c
@@ -1869,7 +1869,8 @@ static inline int ds_push_dst(
break;
}
if(sock) {
- LM_DBG("set send socket to %.*s\n", sock->sock_str.len,
sock->sock_str.s);
+ LM_DBG("set send socket to %.*s\n", sock->sock_str.len,
+ sock->sock_str.s);
set_force_socket(msg, sock);
}
return 0;
--
-
| ,''`. Victor Seva |
| : :' : linuxman...@torreviejawireless.org |
| `. `' PGP Key ID: 0x51A09B18CF5A5068 |
|`- Debian Developer |
-
OpenPGP_0x51A09B18CF5A5068.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] [kamailio/kamailio] core: clang-format for coherent indentation and coding style (PR #3461)
for i in $(find src/core -name .git -prune -o -regextype posix-egrep -regex ^.*\.(c|h)$) ; do clang-format -i $i; done You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3461 -- Commit Summary -- * core: clang-format for coherent indentation and coding style -- File Changes -- M src/core/action.c (1735) M src/core/action.h (21) M src/core/async_task.c (183) M src/core/async_task.h (6) M src/core/atomic/atomic_alpha.h (371) M src/core/atomic/atomic_arm.h (313) M src/core/atomic/atomic_common.h (15) M src/core/atomic/atomic_mips2.h (380) M src/core/atomic/atomic_native.h (4) M src/core/atomic/atomic_ppc.h (302) M src/core/atomic/atomic_sparc.h (55) M src/core/atomic/atomic_sparc64.h (328) M src/core/atomic/atomic_unknown.h (263) M src/core/atomic/atomic_x86.h (382) M src/core/atomic_ops.c (47) M src/core/atomic_ops.h (2) M src/core/basex.c (551) M src/core/basex.h (701) M src/core/bit_count.h (8) M src/core/bit_scan.c (14) M src/core/bit_scan.h (259) M src/core/bit_test.h (51) M src/core/cfg/cfg.c (197) M src/core/cfg/cfg.h (74) M src/core/cfg/cfg_ctx.c (1116) M src/core/cfg/cfg_ctx.h (112) M src/core/cfg/cfg_script.c (288) M src/core/cfg/cfg_script.h (32) M src/core/cfg/cfg_select.c (202) M src/core/cfg/cfg_select.h (10) M src/core/cfg/cfg_struct.c (674) M src/core/cfg/cfg_struct.h (314) M src/core/cfg_core.c (457) M src/core/cfg_core.h (53) M src/core/cfg_parser.c (982) M src/core/cfg_parser.h (98) M src/core/char_msg_val.h (37) M src/core/clist.h (64) M src/core/compiler_opt.h (11) M src/core/config.h (138) M src/core/core_cmd.c (1192) M src/core/core_stats.h (19) M src/core/counters.c (0) M src/core/counters.h (0) M src/core/crc.c (0) M src/core/crc.h (0) M src/core/crypto/md5.c (0) M src/core/crypto/md5.h (0) M src/core/crypto/md5utils.c (0) M src/core/crypto/md5utils.h (0) M src/core/crypto/rijndael.c (0) M src/core/crypto/rijndael.h (0) M src/core/crypto/sha256.c (0) M src/core/crypto/sha256.h (0) M src/core/crypto/shautils.c (0) M src/core/daemonize.c (0) M src/core/daemonize.h (0) M src/core/data_lump.c (0) M src/core/data_lump.h (0) M src/core/data_lump_rpl.c (0) M src/core/data_lump_rpl.h (0) M src/core/dns_cache.c (0) M src/core/dns_cache.h (0) M src/core/dns_func.c (0) M src/core/dns_func.h (0) M src/core/dns_wrappers.h (0) M src/core/dprint.c (0) M src/core/dprint.h (0) M src/core/dset.c (0) M src/core/dset.h (0) M src/core/dst_blocklist.c (0) M src/core/dst_blocklist.h (0) M src/core/endianness.c (0) M src/core/endianness.h (0) M src/core/error.c (0) M src/core/error.h (0) M src/core/events.c (0) M src/core/events.h (0) M src/core/fastlock.h (0) M src/core/fix_lumps.h (0) M src/core/flags.c (0) M src/core/flags.h (0) M src/core/fmsg.c (0) M src/core/fmsg.h (0) M src/core/forward.c (0) M src/core/forward.h (0) M src/core/futexlock.h (0) M src/core/globals.h (0) M src/core/hash_func.c (0) M src/core/hash_func.h (0) M src/core/hashes.h (0) M src/core/id.c (0) M src/core/id.h (0) M src/core/io_wait.c (0) M src/core/io_wait.h (0) M src/core/ip_addr.c (0) M src/core/ip_addr.h (0) M src/core/kemi.c (0) M src/core/kemi.h (0) M src/core/kemiexec.c (0) M src/core/list.h (0) M src/core/local_timer.c (0) M src/core/local_timer.h (0) M src/core/lock_alloc.h (0) M src/core/lock_ops.c (0) M src/core/lock_ops.h (0) M src/core/locking.c (0) M src/core/locking.h (0) M src/core/lump_struct.h (0) M src/core/lvalue.c (0) M src/core/lvalue.h (0) M src/core/mem/dl_malloc.c (0) M src/core/mem/dl_malloc.h (0) M src/core/mem/f_malloc.c (0) M src/core/mem/f_malloc.h (0) M src/core/mem/ll_malloc.c (0) M src/core/mem/ll_malloc.h (0) M src/core/mem/mem.h (0) M src/core/mem/memapi.h (0) M src/core/mem/memdbg.h (0) M src/core/mem/meminfo.h (0) M src/core/mem/memtest.c (0) M src/core/mem/pkg.c (0) M src/core/mem/pkg.h (0) M src/core/mem/q_malloc.c (0) M src/core/mem/q_malloc.h (0) M src/core/mem/sf_malloc.c (0) M src/core/mem/sf_malloc.h (0) M src/core/mem/shm.c (0) M src/core/mem/shm.h (0) M src/core/mem/shm_mem.h (0) M src/core/mem/src_loc.h (0) M src/core/mem/tlsf_malloc.c (0) M src/core/mem/tlsf_malloc.h (0) M src/core/mem/tlsf_malloc_bits.h (0) M src/core/mod_fix.c (0) M src/core/mod_fix.h (0) M src/core/modparam.c (0) M src/core/modparam.h (0) M src/core/msg_translator.c (0) M src/core/msg_translator.h (0) M src/core/name_alias.h (0) M src/core/nonsip_hooks.c (0) M src/core/nonsip_hooks.h
[sr-dev] Re: clang-format changes
Hi, On 18/5/23 12:39, Henning Westerholt wrote: Hello, the PR related to this proposal was merged quite fast, less then 24h after creation. Why this was merged already, given that it affects all modules? Well, that was only me. I discussed enforcing clang-format already in the past [0] and no one was against it. So doing it pretty early in the development process of the new release seemed the best way to finally enforce it. I have nothing against this change, but it would have been polite to give it a bit more time for feedback from other module authors, especially as today is a public holiday in many countries. It might also cause conflicts with other people work in progress code. Yes, but this kind of change is going to be disruptive no matter when it gets merged. So I apologize if someone had not enough time to send any feedback. I'm going to send another review with the changes for core. I will wait a bit longer this time. Cheers [0] https://kamailio.org/wikidocs/devel/irc-meetings/2022a/ -- - | ,''`. Victor Seva | | : :' : linuxman...@torreviejawireless.org | | `. `' PGP Key ID: 0x51A09B18CF5A5068 | |`- Debian Developer | - OpenPGP_0x51A09B18CF5A5068.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git: new commits in branch master
- URL: https://github.com/kamailio/kamailio/commit/afdf66528d695994152ec67138643af0deac8741 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 auth: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/b41657fb5597423e443e561812b1ed8d42106900 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 acc: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/5666ee0ffc2b7e794563821afbfff0ef883d2a6a Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 acc_diameter: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/64a2e2dda7d0e1a78942ebadff7e60a2d26bb286 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 acc_json: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/70ac94f3df4f6cd06fc53404f6867eb326077da5 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_java: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/3b7e80c3c5572cfda5770087d99e10b2a53c2a9a Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_jsdt: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/fc61e9ab5123abd90600f342de6ec3d470e7e4a5 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_lua: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/285c0e8ca7ec89bd9ff57c43e59ec729d966a9b2 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_lua_sr: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/2ed8ff55b11df3f2b92755e804c7306bd1b9ae65 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_mono: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/1d347efddd7ff0e77ad1558dae27ed4bd31a25b4 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_perl: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/d9bfe53033379f202de38fe9e8eb5e6290a644ae Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_python: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/a449857542ecb24b718acfd632447a97a3821042 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_python3: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/ef556363a5b8e983ed302ff7a8b7eac2b5431de3 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_python3s: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/8f8a45ff3cc66839b0a714f88ab2bef17b4abb61 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_ruby: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/93879bb507f75cc93b8ff002facb30ef2d9b7009 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_ruby_proc: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/9f247443eb0e69f1a0b9980e711f752c24623acc Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 app_sqlang: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/1083f1fe43c43c312afaa1c8cbc9ad754db0795c Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 async: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/5eed2433c43d1f15adcf09bc971c398d4be67f40 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 auth_db: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/63b19282d967ceb2dfa8e2d8a4beadbdfe9cffca Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 auth_diameter: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/d889afa8189d79510bdbfc006ef0ca4781898f15 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 auth_ephemeral: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/552c5b148ee8d9d7cf9c9e971f0c1327bea95019 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 auth_identity: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/08e243030c190b57eec9bdefd9bd869263209923 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 auth_radius: clang-format for coherent indentation and coding style - URL: https://github.com/kamailio/kamailio/commit/dff2f1a5d033ffaf252bd80a004f06346ff21169 Author: Victor Seva Date: 2023-05-18T12:22:30+02:00 auth_xkeys: clang-format for coherent indentation and coding style
[sr-dev] Re: [kamailio/kamailio] clang-format for coherent indentation and coding style (PR #3459)
Merged #3459 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3459#event-9278192762 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] clang-format for coherent indentation and coding style (PR #3459)
@linuxmaniac pushed 245 commits. 3f5401cfc28448e679d77fbc1a4a02e795dcc25e acc: clang-format for coherent indentation and coding style c4905c3a83dd084231a9283e412900839f983dba acc_diameter: clang-format for coherent indentation and coding style 8b942d7831328c63d2231797420c29e12d0d54ad acc_json: clang-format for coherent indentation and coding style a418a38bffdbb9560c6ed44c35cdf5e7ffc99c7b app_java: clang-format for coherent indentation and coding style 2477e08626ac3b414281aad13cfb3c402dc912ef app_jsdt: clang-format for coherent indentation and coding style 6ce4a2f71463dcdadb0a4c89356dc9b8bf1c1907 app_lua: clang-format for coherent indentation and coding style 58a2c77d711ed473d1703182a99bf96fb259e578 app_lua_sr: clang-format for coherent indentation and coding style fc501f85cffa931317a11e76693ce1cc6a4b92d8 app_mono: clang-format for coherent indentation and coding style 0d2fd315fb9a726b1ad200bf3a416f2e8e0432d8 app_perl: clang-format for coherent indentation and coding style bcb0c8b78af360bf8c373798583c382bc6545404 app_python: clang-format for coherent indentation and coding style 203b8af418a47837ca48e6d712450124f1553510 app_python3: clang-format for coherent indentation and coding style d13db39b7fab56ef75933480e162d6f7ac9fb668 app_python3s: clang-format for coherent indentation and coding style 69cc2ab66f416215bde45d3562e0f38de7a68077 app_ruby: clang-format for coherent indentation and coding style c66c47669943101ae414b65d8a93b957287bcc92 app_ruby_proc: clang-format for coherent indentation and coding style 12e4348b843ad7764663a261a39695b640c4a5b8 app_sqlang: clang-format for coherent indentation and coding style af4a0deb14cad0ae0ecb10c61badde9fea3d1991 async: clang-format for coherent indentation and coding style af5ebd028726893520a73b39d0fcda17bfe8d645 auth_db: clang-format for coherent indentation and coding style 788b59bef98f4ae9416846636f195c813b6bd989 auth_diameter: clang-format for coherent indentation and coding style c8264b3003597460baebf03c046f684a82d177bf auth_ephemeral: clang-format for coherent indentation and coding style 0566c762fb9a2f7c0ce0e49fe494544e7d2e49ac auth_identity: clang-format for coherent indentation and coding style 429942184e43edd802e92339aa9b2f17270cd84e auth_radius: clang-format for coherent indentation and coding style 4ce21cd37ce2a1ea57dd318947c4440be73f6e0b auth_xkeys: clang-format for coherent indentation and coding style 8d817d7f9d296039b8d684be475e8b4747f488f3 avp: clang-format for coherent indentation and coding style 0ded8b19819ad9eccb6114589b90d857e8d86ca9 avpops: clang-format for coherent indentation and coding style bec1d9eef0a652d4f08ae670145e7e85b18ee4ed benchmark: clang-format for coherent indentation and coding style 41bedc54a578a6e686ddb242bc993f6e5980b9b4 blst: clang-format for coherent indentation and coding style 980debec1f6d85722b6629346ed27a3c74d8491f call_control: clang-format for coherent indentation and coding style e7c4d2d6aaa4b828057b6b2e23955bb5c5dfd17f call_obj: clang-format for coherent indentation and coding style 251fbc4e0dedba519a61e4efbd3b7001799dd073 carrierroute: clang-format for coherent indentation and coding style 40a9c818c3e52643b5192eebaa249483e32a2718 cdp: clang-format for coherent indentation and coding style 6866d6f11fc8b168af17c9ac37c732c4bafc372d cdp_avp: clang-format for coherent indentation and coding style 1fd93a47d727fa75425a3d61643a1130319133a3 cfg_db: clang-format for coherent indentation and coding style b5389af5ffd0c114443c7f32d7cf8982f19e1e07 cfgt: clang-format for coherent indentation and coding style f1fb05c0079eccbe70c6e7c5b0f8890e1274becc cfgutils: clang-format for coherent indentation and coding style 45ab4714faf03a14d488a469ac474142fec4394f cnxcc: clang-format for coherent indentation and coding style b564cb82b81b76e35f0df503ae414786a94fb8fb corex: clang-format for coherent indentation and coding style ad388ae39ec3e4998f75109a13cb72b728e4f419 counters: clang-format for coherent indentation and coding style 4f7dae2bbe1df6461539b683b77e0b35a348fce6 cplc: clang-format for coherent indentation and coding style b3cf63963625e95f5040f74b89b1365923e76731 crypto: clang-format for coherent indentation and coding style c78813b1eee5348f2056bcaff77ae56544f739b4 ctl: clang-format for coherent indentation and coding style b34a08cd1c65ed799d42940bd1eb6dd0d27b39e0 db2_ldap: clang-format for coherent indentation and coding style 93ff6b069ea53c5cb4aebb2df2e5ca160d3641c3 db2_ops: clang-format for coherent indentation and coding style c2757228af654863c2485c8f9466e7255c4fe063 db_berkeley: clang-format for coherent indentation and coding style 4f71d1d64a541e90316804c6d4d868e4c5992eb7 db_cassandra: clang-format for coherent indentation and coding style 01ac7e1c931d44f1605351322382dfd1f4c9d61a db_cluster: clang-format for coherent indentation and coding style 267cea54e10a9e8438cddf127ea2ad6992fd2627 db_flatstore: clang-format for coherent indentation
[sr-dev] [kamailio/kamailio] clang-format for coherent indentation and coding style (PR #3459)
changes in modules after clang-format execution. This is a test to check the pull-request check of clang-format You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3459 -- Commit Summary -- * auth: clang-format for coherent indentation and coding style -- File Changes -- M src/modules/auth/api.c (156) M src/modules/auth/api.h (128) M src/modules/auth/auth_mod.c (623) M src/modules/auth/auth_mod.h (13) M src/modules/auth/challenge.c (176) M src/modules/auth/challenge.h (16) M src/modules/auth/nc.c (152) M src/modules/auth/nc.h (24) M src/modules/auth/nid.c (43) M src/modules/auth/nid.h (19) M src/modules/auth/nonce.c (193) M src/modules/auth/nonce.h (87) M src/modules/auth/ot_nonce.c (142) M src/modules/auth/ot_nonce.h (21) M src/modules/auth/rfc2617.c (38) M src/modules/auth/rfc2617.h (77) M src/modules/auth/rfc2617_sha256.c (38) M src/modules/auth/rfc2617_sha256.h (32) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3459.patch https://github.com/kamailio/kamailio/pull/3459.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3459 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/pull/3...@github.com ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] clang-format changes
Hi, I'm thinking we should start enforcing clang-format in order to have a coherent indentation and coding style in the project. I've added a check in the pull-request Github Action to check the clang-format in the commits but for sure now it will almost always fail due to our code is not always formatted properly. Is is OK if I start committing changes module by module of just changes related to clang-format formatting? I'm aware this will our life harder to backport fixes to supported branches but I think it will help us in the long run. Cheers -- - | ,''`. Victor Seva | | : :' : linuxman...@torreviejawireless.org | | `. `' PGP Key ID: 0x51A09B18CF5A5068 | |`- Debian Developer | - OpenPGP_0x51A09B18CF5A5068.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: pv_cache_dump (PR #3448)
@linuxmaniac pushed 1 commit. b2188e30d3728a7f4bf5aec6359c92183becdc15 core: pv_cache_dump -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3448/files/aee1cc1de80291f80ff3f753391eaa8066eb6199..b2188e30d3728a7f4bf5aec6359c92183becdc15 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:5c075f89: github: define proper target-ref in clang-format-checker [skip ci]
Module: kamailio Branch: master Commit: 5c075f8982bdf282f03d9e74f9663509a432474b URL: https://github.com/kamailio/kamailio/commit/5c075f8982bdf282f03d9e74f9663509a432474b Author: Victor Seva Committer: Victor Seva Date: 2023-05-17T12:43:36+02:00 github: define proper target-ref in clang-format-checker [skip ci] --- Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/5c075f8982bdf282f03d9e74f9663509a432474b.diff Patch: https://github.com/kamailio/kamailio/commit/5c075f8982bdf282f03d9e74f9663509a432474b.patch --- diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index d515b8ff56..8887768239 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/checkout@v2 - uses: wolletd/clang-format-checker@v1.10 with: - target-ref: main + target-ref: master build: runs-on: ubuntu-latest container: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: pv_cache_dump (PR #3448)
@linuxmaniac pushed 1 commit. aee1cc1de80291f80ff3f753391eaa8066eb6199 core: pv_cache_dump -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3448/files/efd0c0b160eb19e93e3447981dbb6bdc0b82c38f..aee1cc1de80291f80ff3f753391eaa8066eb6199 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:e18adca6: github: add checkout before clang-format-checker [skip ci]
Module: kamailio Branch: master Commit: e18adca6d62ab327cb8b8c23291eef8ab4543d53 URL: https://github.com/kamailio/kamailio/commit/e18adca6d62ab327cb8b8c23291eef8ab4543d53 Author: Victor Seva Committer: Victor Seva Date: 2023-05-17T12:41:24+02:00 github: add checkout before clang-format-checker [skip ci] > https://github.com/WolleTD/clang-format-checker/issues/15 --- Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/e18adca6d62ab327cb8b8c23291eef8ab4543d53.diff Patch: https://github.com/kamailio/kamailio/commit/e18adca6d62ab327cb8b8c23291eef8ab4543d53.patch --- diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 1ea695d874..d515b8ff56 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -12,6 +12,7 @@ jobs: check-format: runs-on: ubuntu-latest steps: + - uses: actions/checkout@v2 - uses: wolletd/clang-format-checker@v1.10 with: target-ref: main ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: pv_cache_dump (PR #3448)
@linuxmaniac pushed 1 commit. efd0c0b160eb19e93e3447981dbb6bdc0b82c38f core: pv_cache_dump -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3448/files/925e9764254dd1cb9f7644c928d9c0762c8c2fab..efd0c0b160eb19e93e3447981dbb6bdc0b82c38f You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:2c36d50a: github: update clang-format-checker action to v1.10 [skip ci]
Module: kamailio Branch: master Commit: 2c36d50ac56663c92bc007c85b18199a1fdff363 URL: https://github.com/kamailio/kamailio/commit/2c36d50ac56663c92bc007c85b18199a1fdff363 Author: Victor Seva Committer: Victor Seva Date: 2023-05-17T12:35:14+02:00 github: update clang-format-checker action to v1.10 [skip ci] --- Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/2c36d50ac56663c92bc007c85b18199a1fdff363.diff Patch: https://github.com/kamailio/kamailio/commit/2c36d50ac56663c92bc007c85b18199a1fdff363.patch --- diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index f340ff425d..1ea695d874 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -12,7 +12,7 @@ jobs: check-format: runs-on: ubuntu-latest steps: - - uses: wolletd/clang-format-checker@v1 + - uses: wolletd/clang-format-checker@v1.10 with: target-ref: main build: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: pv_cache_dump (PR #3448)
@linuxmaniac pushed 1 commit. 925e9764254dd1cb9f7644c928d9c0762c8c2fab core: pv_cache_dump -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3448/files/4828969aa17e52e25712708b84660dc684be01da..925e9764254dd1cb9f7644c928d9c0762c8c2fab You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:2b4cceb3: github: add clang-format-checker for pull-request [skip ci]
Module: kamailio Branch: master Commit: 2b4cceb35bf49fc581fdb7af10c080f927a93a4a URL: https://github.com/kamailio/kamailio/commit/2b4cceb35bf49fc581fdb7af10c080f927a93a4a Author: Victor Seva Committer: Victor Seva Date: 2023-05-17T12:18:07+02:00 github: add clang-format-checker for pull-request [skip ci] --- Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/2b4cceb35bf49fc581fdb7af10c080f927a93a4a.diff Patch: https://github.com/kamailio/kamailio/commit/2b4cceb35bf49fc581fdb7af10c080f927a93a4a.patch --- diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 197361aaf21..f340ff425d8 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -9,6 +9,12 @@ name: checks_pr permissions: contents: read # to fetch code (actions/checkout) jobs: + check-format: +runs-on: ubuntu-latest +steps: + - uses: wolletd/clang-format-checker@v1 +with: + target-ref: main build: runs-on: ubuntu-latest container: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:2eb17e9c: github: GitHub Actions Version Updater
Module: kamailio
Branch: master
Commit: 2eb17e9ccfa3963813215e6ddf2fdadeb588f485
URL:
https://github.com/kamailio/kamailio/commit/2eb17e9ccfa3963813215e6ddf2fdadeb588f485
Author: Victor Seva
Committer: Victor Seva
Date: 2023-05-17T10:09:53+02:00
github: GitHub Actions Version Updater
> https://github.com/marketplace/actions/github-actions-version-updater
* PAT created using kamailio-sync
* organization secret WORKFLOW_SECRET created
---
Added: .github/workflows/updater.yml
---
Diff:
https://github.com/kamailio/kamailio/commit/2eb17e9ccfa3963813215e6ddf2fdadeb588f485.diff
Patch:
https://github.com/kamailio/kamailio/commit/2eb17e9ccfa3963813215e6ddf2fdadeb588f485.patch
---
diff --git a/.github/workflows/updater.yml b/.github/workflows/updater.yml
new file mode 100644
index 000..d517b85edbe
--- /dev/null
+++ b/.github/workflows/updater.yml
@@ -0,0 +1,17 @@
+name: GitHub Actions Version Updater
+on:
+ schedule:
+# Automatically run on every Sunday
+- cron: '0 0 * * 0'
+jobs:
+ build:
+runs-on: ubuntu-latest
+steps:
+ - uses: actions/checkout@v3
+with:
+ token: ${{ secrets.WORKFLOW_SECRET }}
+ - name: Run GitHub Actions Version Updater
+uses: saadmk11/github-actions-version-updater@v0.7.4
+with:
+ token: ${{ secrets.WORKFLOW_SECRET }}
+ pull_request_user_reviewers: linuxmaniac
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:master:fe4c47bb: siptrace: fix destination target parameter on ki_sip_trace_msg
Module: kamailio
Branch: master
Commit: fe4c47bb47e466af2eddc0a8987c13cb976e5a3b
URL:
https://github.com/kamailio/kamailio/commit/fe4c47bb47e466af2eddc0a8987c13cb976e5a3b
Author: Victor Seva
Committer: Victor Seva
Date: 2023-05-17T09:22:10+02:00
siptrace: fix destination target parameter on ki_sip_trace_msg
fixes #3457
---
Modified: src/modules/siptrace/siptrace.c
---
Diff:
https://github.com/kamailio/kamailio/commit/fe4c47bb47e466af2eddc0a8987c13cb976e5a3b.diff
Patch:
https://github.com/kamailio/kamailio/commit/fe4c47bb47e466af2eddc0a8987c13cb976e5a3b.patch
---
diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c
index 0a2d9b327e1..538e3b6a70b 100644
--- a/src/modules/siptrace/siptrace.c
+++ b/src/modules/siptrace/siptrace.c
@@ -1231,7 +1231,14 @@ static int w_sip_trace_msg(sip_msg_t *msg, char *vmsg,
char *saddr, char *taddr,
static int ki_sip_trace_msg(sip_msg_t *msg, str *vmsg, str *saddr, str *taddr,
str *duri, str *corrid)
{
- trace_send_hep_duplicate(vmsg, saddr, taddr, (duri &&
duri->len>0)?:NULL,
+ dest_info_t dest;
+ if(duri && duri->len>0) {
+ if (siptrace_parse_uri(duri, ) < 0) {
+ LM_ERR("failed to parse mirroring destination uri\n");
+ return -1;
+ }
+ }
+ trace_send_hep_duplicate(vmsg, saddr, taddr, (duri &&
duri->len>0)?:NULL,
(corrid && corrid->len>0)?corrid:NULL);
return 1;
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] build warning (Issue #3457)
Closed #3457 as completed via fe4c47bb47e466af2eddc0a8987c13cb976e5a3b. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3457#event-9265675393 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] git:5.7:72db97b7: pkg/kamailio/deb: version set 5.7.0 [skip ci]
Module: kamailio Branch: 5.7 Commit: 72db97b7b8618e6cc9eed80ef670495547b7c2d0 URL: https://github.com/kamailio/kamailio/commit/72db97b7b8618e6cc9eed80ef670495547b7c2d0 Author: Victor Seva Committer: Victor Seva Date: 2023-05-17T08:13:45+02:00 pkg/kamailio/deb: version set 5.7.0 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/72db97b7b8618e6cc9eed80ef670495547b7c2d0.diff Patch: https://github.com/kamailio/kamailio/commit/72db97b7b8618e6cc9eed80ef670495547b7c2d0.patch ___ Kamailio (SER) - Development Mailing List To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
[sr-dev] Re: [kamailio/kamailio] core: pv_cache_dump (PR #3448)
Ah, I see. So like this? Change already pushed
```
diff --git a/src/core/pvapi.c b/src/core/pvapi.c
index b36c92b2be..c184db28d9 100644
--- a/src/core/pvapi.c
+++ b/src/core/pvapi.c
@@ -119,6 +119,7 @@ void pv_cache_dump_cb(str *gname, str *name)
{
if (cfg_get(core, core_cfg, pv_cache_dump) == my_pid()) {
pv_cache_dump(cfg_get(core, core_cfg, memlog));
+ cfg_get(core, core_cfg, pv_cache_dump) = 0;
}
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3448#issuecomment-1549570768
You are receiving this because you are subscribed to this thread.
Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org
