Re: Accidental file delete on mobile.

[Chirana Gheorghita Eugeniu Theodor via subsurface]

still the same but seems to crash the app faster :). log attached

On Mon, Jan 18, 2021, 23:40 Dirk Hohndel  wrote:

>
>
> On Jan 18, 2021, at 12:40 PM, Dirk Hohndel via subsurface <
> subsurface@subsurface-divelog.org> wrote:
>
> OK, I have a crazy idea. If I implement a transition that slowly hides the
> item instead of
> just turning it off. Yeah, kinda silly, but... what if that's enough to
> keep the object around
> long enough that the signal handler can complete.
>
>
> So a transition didn't seem to work for that (because it's hard to add
> transitions to Actions...)
> Instead I created an ugly hack with a timer and some property trickery
> that keeps the action
> visible for at least a hundred ms after we are done deleting the dive.
>
> I just pushed .367 to the Google Play beta track. No idea how long it will
> take to show up.
> But that includes the hack described above. I'd love to see if things
> still crash for you with that.
>
> /D
>


subsurface.log
Description: Binary data
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Dirk Hohndel via subsurface]

> On Jan 18, 2021, at 12:40 PM, Dirk Hohndel via subsurface 
>  wrote:
> 
> OK, I have a crazy idea. If I implement a transition that slowly hides the 
> item instead of
> just turning it off. Yeah, kinda silly, but... what if that's enough to keep 
> the object around
> long enough that the signal handler can complete.

So a transition didn't seem to work for that (because it's hard to add 
transitions to Actions...)
Instead I created an ugly hack with a timer and some property trickery that 
keeps the action
visible for at least a hundred ms after we are done deleting the dive.

I just pushed .367 to the Google Play beta track. No idea how long it will take 
to show up.
But that includes the hack described above. I'd love to see if things still 
crash for you with that.

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Dirk Hohndel via subsurface]

As you can tell from the picture, it still isn't perfect. The '>' in the title 
between 'Dive list' and 'Martin Luther King Boulevard' is the wrong font size 
which pushes the dive location text down somewhat. But I should be able to 
track that one down...

Thanks for the update!

Which island are you on? Bonaire? Aruba? Is KLM still flying the ~7pm flight 
from there to AMS?
I've been on that flight a few times myself (well, on the days when it flies 
back via Bonaire - I've never been to Aruba for diving)

:-)

/D

> On Jan 18, 2021, at 1:23 PM, Attilla de Groot  wrote:
> 
> Just installed 366, looks much better!
> 
> Thanks for the work. 
> 
> 
> -- Attilla 
> 
> 
> 
> On January 18, 2021 16:46:25 Attilla de Groot via subsurface 
>  wrote:
> 
>>> On 18 Jan 2021, at 14:02, Dirk Hohndel  wrote:
>>> 
>>> Responding to myself... :-)
>>> 
 On Jan 18, 2021, at 9:21 AM, Dirk Hohndel via subsurface 
  wrote:
 
 I'm disappointed that you do see that issue with the title bar, but at 
 least now I have that confirmation and can try to dig some more to figure 
 out what I missed in all this. Maybe it's a timing issue that the value is 
 determined to early... I noticed that there are order of initialization 
 differences between iOS and Android (which seems insane) - and most of my 
 testing is indeed on Android or directly with mobile-on-desktop. So I'll 
 do some more iOS testing, I guess.
>>> 
>>> It turned out to be something else entirely - and it's not clear why I 
>>> never saw the effect as dramatically as you did. But I think that's because 
>>> of the other issue that I mentioned where your font height to gridUnit 
>>> ratio is just weird...
>>> Anyway, I believe I found and fixed the issue (at least now the font in the 
>>> title bar updates reliably whenever we change the font size of the app). 
>>> And in case that still doesn't work correctly with your iPhone 12, I added 
>>> one more important piece of information to the log that might help shed 
>>> some more light on this.
>>> Version .366 should be making its way through Apple's TestFlight system 
>>> soon and then we'll see if this was enough to fix it or if some more 
>>> hackery is needed.
>> 
>> Glad you found this one!.
>> 
 Yes, the theme test page looks flat out ridiculous in dark mode. Something 
 else to at least mildly touch up...
>>> 
>>> That is also fixed in .366 :-)
>> 
>> Awesome!
>> 
>>> "going home from the tropical island"
>>> 
>>> Yeah, I haven't been on an airplane in almost eleven months and much as I 
>>> miss diving, risking my life (and the health of my lungs) doesn't appear to 
>>> be the right trade-off for me. But maybe you are flying your private jet 
>>> and this isn't as much of an issue :-)
>> 
>> I had the same. Luckily the Netherlands has the Dutch Carribean where we 
>> were still welcome. When I was there, I dicided to stay a bit longer and 
>> work remotely and dive some more. All good things come to an end though.
>> 
>> 
>> — Attilla
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
> 
> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Attilla de Groot via subsurface]

> On 18 Jan 2021, at 14:02, Dirk Hohndel  wrote:
> 
> Responding to myself... :-)
> 
>> On Jan 18, 2021, at 9:21 AM, Dirk Hohndel via subsurface 
>>  wrote:
>> 
>> I'm disappointed that you do see that issue with the title bar, but at least 
>> now I have that confirmation and can try to dig some more to figure out what 
>> I missed in all this. Maybe it's a timing issue that the value is determined 
>> to early... I noticed that there are order of initialization differences 
>> between iOS and Android (which seems insane) - and most of my testing is 
>> indeed on Android or directly with mobile-on-desktop. So I'll do some more 
>> iOS testing, I guess.
> 
> It turned out to be something else entirely - and it's not clear why I never 
> saw the effect as dramatically as you did. But I think that's because of the 
> other issue that I mentioned where your font height to gridUnit ratio is just 
> weird...
> Anyway, I believe I found and fixed the issue (at least now the font in the 
> title bar updates reliably whenever we change the font size of the app). And 
> in case that still doesn't work correctly with your iPhone 12, I added one 
> more important piece of information to the log that might help shed some more 
> light on this.
> Version .366 should be making its way through Apple's TestFlight system soon 
> and then we'll see if this was enough to fix it or if some more hackery is 
> needed.

Glad you found this one!.

>> Yes, the theme test page looks flat out ridiculous in dark mode. Something 
>> else to at least mildly touch up...
> 
> That is also fixed in .366 :-)

Awesome!

> "going home from the tropical island"
> 
> Yeah, I haven't been on an airplane in almost eleven months and much as I 
> miss diving, risking my life (and the health of my lungs) doesn't appear to 
> be the right trade-off for me. But maybe you are flying your private jet and 
> this isn't as much of an issue :-)

I had the same. Luckily the Netherlands has the Dutch Carribean where we were 
still welcome. When I was there, I dicided to stay a bit longer and work 
remotely and dive some more. All good things come to an end though.


— Attilla
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Dirk Hohndel via subsurface]

> On Jan 18, 2021, at 12:11 PM, Chirana Gheorghita Eugeniu Theodor 
>  wrote:
> 
> Ps. I just create a new dive and save, no fields completed. all blank... 
> maibe this is let me test
> 
> So 
> 
> new dive > save > long press or using 3 dots to delete crashes app
> 
> 2. new dive > complete dive location > save > long press or context to delete 
> does not crash app anymore :)
> 
> So I guess the default "unnamed dive site" type of entry is the culprit


Interesting. Even with that I cannot reproduce the crash on my Android phone, 
but at least
this gives me something else to look into. Hmmm. What is special about a dive 
that has
no valid data attached to it (BTW: I had considered in the past to not even add 
a dive that
has neither a depth nor a duration).

I'm still not seeing it, I'm still not getting which object we are creating in 
QML that has a
signal handler still running. I wish the debug message from QML was a little 
more useful.
How about if it told me what type of object it was that still had a handler 
running...

Hmmm.

So the log says that the handler was running ContextDrawerActionItem.qml line 
84.
That's the code in Kirigami that executes the action that you clicked on / 
tapped.
So that seems to say that we are deleted the action itself. And that kinda 
makes sense,
because I bet that when we make an action invisible, it deletes the object from 
the parents
list of children or something like that.

And the action becomes invisible, once the currentItem on the dive list goes 
away. Which
conceivably could happen while we still aren't done with the 
QMLManager::deleteDive() 
call in the signal handler.

So this is a classic race condition. But how do I prevent this...

OK, I have a crazy idea. If I implement a transition that slowly hides the item 
instead of
just turning it off. Yeah, kinda silly, but... what if that's enough to keep 
the object around
long enough that the signal handler can complete.

OK, I'll try that and push a new binary out.
Stay tuned for another attempt (of course I don't know how long it will take 
for Google
to push things)

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Chirana Gheorghita Eugeniu Theodor via subsurface]

Ps. I just create a new dive and save, no fields completed. all blank...
maibe this is let me test

So

new dive > save > long press or using 3 dots to delete crashes app

2. new dive > complete dive location > save > long press or context to
delete does not crash app anymore :)

So I guess the default "unnamed dive site" type of entry is the culprit

Regards,
Theodor

On Mon, Jan 18, 2021, 22:03 Chirana Gheorghita Eugeniu Theodor <
off...@adaptcom.ro> wrote:

> Hmmm. I will try reproducing and detail each step. By the way I am using
> dark theme :)
>
> On Mon, Jan 18, 2021, 20:47 Dirk Hohndel  wrote:
>
>>
>>
>> On Jan 18, 2021, at 12:00 AM, Chirana Gheorghita Eugeniu Theodor <
>> off...@adaptcom.ro> wrote:
>>
>> Hello. OK.
>>
>> Discovered something:
>> - I add a new dive
>> -Save and exit to Dive list
>> - Enter that dive again
>> - delete it >> all ok.
>>
>> - Add a new dive
>> - Save and exit to Dive list
>> - select another dive and back to dive list
>> - Select the newly added dive and back to dive list and tha new dive
>> remains selected
>> - Open context menu and hit delete >>> App crashes.. Attached logs.
>>
>>
>>
>> So I understand what the log tells us... but I cannot figure out how to
>> reproduce the situation.
>> I followed your steps as exactly as I could. And tried several
>> variations. I tried this on three different Android devices (including two
>> running Android 11) as well as on iOS and mobile-on-desktop.
>> I simply cannot reproduce the crash.
>>
>> The log file implied that a QML object was deleted while one of its
>> signal handlers was running. During the dive delete a signal handler for
>> the context menu is running, but I don't see how that object could be
>> deleted.
>> And because of the undo stack, the dive itself isn't actually deleted,
>> just moved on a different list. The one thing that does get deleted is the
>> delegate that shows the dive in the dive list - but that one doesn't
>> actually have a  signal handler running... because even if you opened the
>> context drawer by press-and-hold on the dive (instead of using the three
>> dots in the lower right corner), the signal handler for that delegate has
>> finished when you open the context menu. And by the time you tap on delete
>> in the context menu, it has definitely completed running.
>>
>> So... hmm... no idea...
>>
>> And as I said many times before - fixing bugs I cannot reproduce is
>> incredibly hard :-(
>>
>> /D
>>
>>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Chirana Gheorghita Eugeniu Theodor via subsurface]

Hmmm. I will try reproducing and detail each step. By the way I am using
dark theme :)

On Mon, Jan 18, 2021, 20:47 Dirk Hohndel  wrote:

>
>
> On Jan 18, 2021, at 12:00 AM, Chirana Gheorghita Eugeniu Theodor <
> off...@adaptcom.ro> wrote:
>
> Hello. OK.
>
> Discovered something:
> - I add a new dive
> -Save and exit to Dive list
> - Enter that dive again
> - delete it >> all ok.
>
> - Add a new dive
> - Save and exit to Dive list
> - select another dive and back to dive list
> - Select the newly added dive and back to dive list and tha new dive
> remains selected
> - Open context menu and hit delete >>> App crashes.. Attached logs.
>
>
>
> So I understand what the log tells us... but I cannot figure out how to
> reproduce the situation.
> I followed your steps as exactly as I could. And tried several variations.
> I tried this on three different Android devices (including two running
> Android 11) as well as on iOS and mobile-on-desktop.
> I simply cannot reproduce the crash.
>
> The log file implied that a QML object was deleted while one of its signal
> handlers was running. During the dive delete a signal handler for the
> context menu is running, but I don't see how that object could be deleted.
> And because of the undo stack, the dive itself isn't actually deleted,
> just moved on a different list. The one thing that does get deleted is the
> delegate that shows the dive in the dive list - but that one doesn't
> actually have a  signal handler running... because even if you opened the
> context drawer by press-and-hold on the dive (instead of using the three
> dots in the lower right corner), the signal handler for that delegate has
> finished when you open the context menu. And by the time you tap on delete
> in the context menu, it has definitely completed running.
>
> So... hmm... no idea...
>
> And as I said many times before - fixing bugs I cannot reproduce is
> incredibly hard :-(
>
> /D
>
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Dirk Hohndel via subsurface]

> On Jan 18, 2021, at 12:00 AM, Chirana Gheorghita Eugeniu Theodor 
>  wrote:
> 
> Hello. OK.
> 
> Discovered something:
> - I add a new dive
> -Save and exit to Dive list
> - Enter that dive again
> - delete it >> all ok.
> 
> - Add a new dive
> - Save and exit to Dive list
> - select another dive and back to dive list
> - Select the newly added dive and back to dive list and tha new dive remains 
> selected
> - Open context menu and hit delete >>> App crashes.. Attached logs.
> 


So I understand what the log tells us... but I cannot figure out how to 
reproduce the situation.
I followed your steps as exactly as I could. And tried several variations. I 
tried this on three different Android devices (including two running Android 
11) as well as on iOS and mobile-on-desktop.
I simply cannot reproduce the crash.

The log file implied that a QML object was deleted while one of its signal 
handlers was running. During the dive delete a signal handler for the context 
menu is running, but I don't see how that object could be deleted.
And because of the undo stack, the dive itself isn't actually deleted, just 
moved on a different list. The one thing that does get deleted is the delegate 
that shows the dive in the dive list - but that one doesn't actually have a  
signal handler running... because even if you opened the context drawer by 
press-and-hold on the dive (instead of using the three dots in the lower right 
corner), the signal handler for that delegate has finished when you open the 
context menu. And by the time you tap on delete in the context menu, it has 
definitely completed running.

So... hmm... no idea...

And as I said many times before - fixing bugs I cannot reproduce is incredibly 
hard :-(

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Dirk Hohndel via subsurface]

Responding to myself... :-)

> On Jan 18, 2021, at 9:21 AM, Dirk Hohndel via subsurface 
>  wrote:
> 
> I'm disappointed that you do see that issue with the title bar, but at least 
> now I have that confirmation and can try to dig some more to figure out what 
> I missed in all this. Maybe it's a timing issue that the value is determined 
> to early... I noticed that there are order of initialization differences 
> between iOS and Android (which seems insane) - and most of my testing is 
> indeed on Android or directly with mobile-on-desktop. So I'll do some more 
> iOS testing, I guess.

It turned out to be something else entirely - and it's not clear why I never 
saw the effect as dramatically as you did. But I think that's because of the 
other issue that I mentioned where your font height to gridUnit ratio is just 
weird...
Anyway, I believe I found and fixed the issue (at least now the font in the 
title bar updates reliably whenever we change the font size of the app). And in 
case that still doesn't work correctly with your iPhone 12, I added one more 
important piece of information to the log that might help shed some more light 
on this.
Version .366 should be making its way through Apple's TestFlight system soon 
and then we'll see if this was enough to fix it or if some more hackery is 
needed.

> Yes, the theme test page looks flat out ridiculous in dark mode. Something 
> else to at least mildly touch up...

That is also fixed in .366 :-)

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Dirk Hohndel via subsurface]

> On Jan 18, 2021, at 8:45 AM, Attilla de Groot  wrote:
> 
> Just updated. The colors of the statistics don’t match the dark mode, but I 
> don’t mind that. The font-size in the statistics menu seem to be correct now.

Yeah, the statistics itself is drawn in C++ code that currently isn't dark mode 
aware. That's something we'll add, but as the code is under very active 
development, now may not be the best time to do so.
But I will try to remember to do that before an actual release :-)

>> 
>>> If I’m leaving out the dark mode/statistics, the only “problem” is the top 
>>> menu(?) header. It seems that all fontsizes are changed, except for that 
>>> one. Only when on “extra large” the font sizes seem to match, but 
>>> everything else doesn’t aline as I would expect it to.
>> 
>> Technically you didn't answer my question... I'll try to phrase it 
>> differently.
>> 
>> So, let's say you switch to 'small' as your font. Then you quit the app. 
>> Simple on Android with the back button. Or swipe it away in the app switcher.
>> If you now restart, do you still have the same problem?
> 
> I thought I wrote that, but multitasking (packing, going home from the 
> tropical island). Yes, even when restarting the top bar seems to be the only 
> one that has an issue left.

"going home from the tropical island"

Yeah, I haven't been on an airplane in almost eleven months and much as I miss 
diving, risking my life (and the health of my lungs) doesn't appear to be the 
right trade-off for me. But maybe you are flying your private jet and this 
isn't as much of an issue :-)

I'm disappointed that you do see that issue with the title bar, but at least 
now I have that confirmation and can try to dig some more to figure out what I 
missed in all this. Maybe it's a timing issue that the value is determined to 
early... I noticed that there are order of initialization differences between 
iOS and Android (which seems insane) - and most of my testing is indeed on 
Android or directly with mobile-on-desktop. So I'll do some more iOS testing, I 
guess.

>> Because I do see this problem sometimes when changing fonts in the running 
>> app. I tried to make sure that the title bar is resized as well, but that 
>> still isn't 100% working.
>> But once you restart the app, the title bar for me is ALWAYS correct. So if 
>> this isn't working for you... something is weird.
>> 
>> You also didn't send me a screenshot of the Theme test page in a case where 
>> you have the mis-sized title bar (go to the main menu -> Developer -> Theme 
>> information)
> 
> Hereby, but that looks quite weird. :-)

Yes, the theme test page looks flat out ridiculous in dark mode. Something else 
to at least mildly touch up... but the page does show that there is something 
really screwy on your phone with font size vs. gridUnit size.
On ALL of my devices the number of characters shown in the last box is fairly 
consistent somewhere between 11 and 12. On your phone it's more than 15. And 
just trying this again, my iPad pro is a bit of an outlier in the other 
direction with only 9
So clearly there's "something" where iOS behaves differently when we try to get 
all the sizes to work consistently together. Now I have a good starting point 
to figure this out.

Yay.

/D___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Martin de Weger via subsurface]

I was just about to send a mail: first test looks great. The bars are shown 
when rotating back and forth. 

Met vriendelijke groet,

Martin de Weger 

> Op 18 jan. 2021 om 17:25 heeft Dirk Hohndel  het volgende 
> geschreven:
> 
> Ok, so Apple was unexpectedly swift and .364 should just have been pushed 
> out to you via TestFlight.
> This contains a cruel hack to try and force a redraw of the statistics after 
> rotation.
> Would you mind testing that as I can't reproduce the issue, as I mentioned :-)
> 
> Thanks
> 
> /D
> 
>> On Jan 18, 2021, at 7:27 AM, Martin de Weger  wrote:
>> 
>> I’m using an iPhone 12 Pro with the latest stable release from iOS. 
>> 
>> Fixing an issue that you cannot reproduce is a pain, I know...
>> 
>> Thanks for all the work you guys are putting into this. 
>> 
>> Met vriendelijke groet,
>> 
>> Martin de Weger 
>> 
 Op 18 jan. 2021 om 16:21 heeft Dirk Hohndel via subsurface 
  het volgende geschreven:
>>> 
>>> Thanks for testing.
>>> What did you think about the notification after changes, with the button 
>>> that opens the context menu... is that helpful? Is that a reasonable user 
>>> experience?
>>> 
>>> /D
>>> 
 On Jan 18, 2021, at 06:19, Willem Ferguson 
  wrote:
 I tested this on a Galaxy A20 running Android 10. Deleted dives and edited 
 dive contents, doing undo afterwards. Looks perfect to me. Huge 
 improvement (that is, after I discovered the undo stack!, duh me.). LGTM.
 
 Kind regards,
 
 willem
>>> ___
>>> subsurface mailing list
>>> subsurface@subsurface-divelog.org
>>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>> 
> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Dirk Hohndel via subsurface]

Ok, so Apple was unexpectedly swift and .364 should just have been pushed out 
to you via TestFlight.
This contains a cruel hack to try and force a redraw of the statistics after 
rotation.
Would you mind testing that as I can't reproduce the issue, as I mentioned :-)

Thanks

/D

> On Jan 18, 2021, at 7:27 AM, Martin de Weger  wrote:
> 
> I’m using an iPhone 12 Pro with the latest stable release from iOS. 
> 
> Fixing an issue that you cannot reproduce is a pain, I know...
> 
> Thanks for all the work you guys are putting into this. 
> 
> Met vriendelijke groet,
> 
> Martin de Weger 
> 
>> Op 18 jan. 2021 om 16:21 heeft Dirk Hohndel via subsurface 
>>  het volgende geschreven:
>> 
>> Thanks for testing.
>> What did you think about the notification after changes, with the button 
>> that opens the context menu... is that helpful? Is that a reasonable user 
>> experience?
>> 
>> /D
>> 
>>> On Jan 18, 2021, at 06:19, Willem Ferguson 
>>>  wrote:
>>> I tested this on a Galaxy A20 running Android 10. Deleted dives and edited 
>>> dive contents, doing undo afterwards. Looks perfect to me. Huge improvement 
>>> (that is, after I discovered the undo stack!, duh me.). LGTM.
>>> 
>>> Kind regards,
>>> 
>>> willem
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Dirk Hohndel via subsurface]

> On Jan 18, 2021, at 7:38 AM, Attilla de Groot wrote:
> 
> Hi Dirk,
> 
> No problem as long as it’s known. Seems I’m the only dark theme user. :-)

No, there are more - I know how many requests I got when it was broken. And I 
also see more people send dark mode screen shots.
Also, can you update to the latest version on the beta channel? Right now that 
should be .363, you are still running .355.
That latest one has the dark mode statistics fixed :-)

BTW: the mailing list clamps down on LARGE messages (since they go out to 
several hundred people). Which is why your emails typically get held for 
moderation.

> If I’m leaving out the dark mode/statistics, the only “problem” is the top 
> menu(?) header. It seems that all fontsizes are changed, except for that one. 
> Only when on “extra large” the font sizes seem to match, but everything else 
> doesn’t aline as I would expect it to.

Technically you didn't answer my question... I'll try to phrase it differently.

So, let's say you switch to 'small' as your font. Then you quit the app. Simple 
on Android with the back button. Or swipe it away in the app switcher.
If you now restart, do you still have the same problem?

Because I do see this problem sometimes when changing fonts in the running app. 
I tried to make sure that the title bar is resized as well, but that still 
isn't 100% working.
But once you restart the app, the title bar for me is ALWAYS correct. So if 
this isn't working for you... something is weird.

You also didn't send me a screenshot of the Theme test page in a case where you 
have the mis-sized title bar (go to the main menu -> Developer -> Theme 
information)

> It didn’t allow me to select text from the log, I hope the screenshot is 
> sufficient.

I was able to extract what I was trying to see (you're on Android on a Samsung 
S10 and as we have seen from many devices (and especially Samsung devices) we 
are being given a crazy list of app size updates at the start.
Your phone claims to have app sizes of 510x765, 360x765, 510x540, and finally 
411x778 (which is also reported as physical screen size). All of these show up 
within 530ms :-)
And I was able to tell that the app picked the correct one and tried to resize 
its geometry elements based on it...

BTW... to send logs without screen shots, simply go to Help->About and click on 
the button. Now you can paste the log into the email app... :-)

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Dirk Hohndel via subsurface]

OK, I do have a friend here locally (not a diver, not a Subsurface user) who 
has an iPhone 12 Pro XL mega wizzytop or whatever it’s called. So at least 
someone in this time zone who can test my experiments... and I can ask my wife 
to try it on her 11 Pro.

> On Jan 18, 2021, at 07:27, Martin de Weger  wrote:
> 
> I’m using an iPhone 12 Pro with the latest stable release from iOS. 
> 
> Fixing an issue that you cannot reproduce is a pain, I know...
> 
> Thanks for all the work you guys are putting into this. 
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Martin de Weger via subsurface]

I’m using an iPhone 12 Pro with the latest stable release from iOS. 

Fixing an issue that you cannot reproduce is a pain, I know...

Thanks for all the work you guys are putting into this. 

Met vriendelijke groet,

Martin de Weger 

> Op 18 jan. 2021 om 16:21 heeft Dirk Hohndel via subsurface 
>  het volgende geschreven:
> 
> Thanks for testing.
> What did you think about the notification after changes, with the button that 
> opens the context menu... is that helpful? Is that a reasonable user 
> experience?
> 
> /D
> 
>> On Jan 18, 2021, at 06:19, Willem Ferguson  
>> wrote:
>> I tested this on a Galaxy A20 running Android 10. Deleted dives and edited 
>> dive contents, doing undo afterwards. Looks perfect to me. Huge improvement 
>> (that is, after I discovered the undo stack!, duh me.). LGTM.
>> 
>> Kind regards,
>> 
>> willem
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Dirk Hohndel via subsurface]

Thanks for testing.
What did you think about the notification after changes, with the button that 
opens the context menu... is that helpful? Is that a reasonable user experience?

/D

> On Jan 18, 2021, at 06:19, Willem Ferguson  
> wrote:
> I tested this on a Galaxy A20 running Android 10. Deleted dives and edited 
> dive contents, doing undo afterwards. Looks perfect to me. Huge improvement 
> (that is, after I discovered the undo stack!, duh me.). LGTM.
> 
> Kind regards,
> 
> willem
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Dirk Hohndel via subsurface]

I’ve been battling this behavior from the very start. Right now (with .363) 
with the devices I have (half a dozen Android phones, two older iPhones and an 
iPad pro) this seems to work correctly on all of them, all the time. But I have 
seen that effect that you describe many times during my testing.

I’m a bit at a loss for ideas what else to try to make this work. Maybe I need 
to reassign the variables (which is what you do with the dropdown, after all). 
Or maybe I need a short time delay before asking for a redraw.

I’ll keep playing. But since it works for me right now, it’s harder to test.

Out of curiosity - what device are you using to test?

/D

> On Jan 18, 2021, at 05:36, Martin de Weger via subsurface 
>  wrote:
> 
> Thanks for the answer. When testing this, I found something else. If I turn 
> my iPhone to landscape, the statistics area is empty. Only when I reselect 
> the data I want to see, the bars are shown again (and stay visible when 
> switching from landscape to portrait v.v.)
> 
> Met vriendelijke groet,
> 
> Martin de Weger 
> 
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Dirk Hohndel via subsurface]

Did you test this with .361 or .363?


The latter has a fix for this issue that appears to work on my devices...

/D

On January 18, 2021 1:01:41 AM PST, Paul Buxton 
 wrote:
>Statistics look pretty awesome.
>I do notice if you change to the dark theme (your favorite) that there
>is
>some issue with the size of the titles for the combo boxes.
>All looks pretty good otherwise.
>
>Paul
>
>On Sun, Jan 17, 2021 at 3:14 AM Dirk Hohndel via subsurface <
>subsurface@subsurface-divelog.org> wrote:
>
>> Hi Everyone,
>>
>> I just pushed new versions of Subsurface-mobile to TestFlight and the
>beta
>> channel on Google Play. 3.1.3(4,9,10.355)
>> Those contain a few interesting new features:
>> - early statistics code (this still will change quite a bit as
>Berthold
>> continues to rewrite the underlying code)
>> - completely reimagined dive edit code that adapts to different
>screen
>> sizes and should provide a much better experience
>> - overhaul of the font size changes - he old code was completely
>bogus and
>> didn't actually do what it promised to do; with these changes the
>screen
>> layout and fonts finally changing in proportionate ways. As a side
>effect
>> there are now 5 font sizes instead of just 3
>>
>> Since all this is pretty invasive, I'd love to get feedback on what
>works,
>> what doesn't work, or what's ill designed.
>>
>> Thanks
>>
>> /D
>>
>> ___
>> subsurface mailing list
>> subsurface@subsurface-divelog.org
>>
>http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>

-- 
Sent from my phone___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Willem Ferguson via subsurface]

On 2021/01/18 00:05, Dirk Hohndel wrote:
To me this flow is informative, relatively unobtrusive, and makes 
sense. Best of all, even if you miss the time window to press the 
button in the notification, you still can just open the context menu 
and trigger the undo (or redo) action.


Please, PLEASE test this and let me know how this works for you, if it 
is intuitive, if this should be changed in some way.
Of course the texts will be translated (and even the command in the 
button that's part of the notification will be translated).


As of this writing the new versions has just now been pushed for iOS, 
the Android one is still waiting for Google to review and push out - 
but lately that hasn't taken too long.


Thanks

/D


I tested this on a Galaxy A20 running Android 10. Deleted dives and 
edited dive contents, doing undo afterwards. Looks perfect to me. Huge 
improvement (that is, after I discovered the undo stack!, duh me.). LGTM.


Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Martin de Weger via subsurface]

Thanks for the answer. When testing this, I found something else. If I turn my 
iPhone to landscape, the statistics area is empty. Only when I reselect the 
data I want to see, the bars are shown again (and stay visible when switching 
from landscape to portrait v.v.)

Met vriendelijke groet,

Martin de Weger 

> Op 18 jan. 2021 om 13:49 heeft Willem Ferguson via subsurface 
>  het volgende geschreven:
> 
> On 2021/01/18 11:13, Martin de Weger via subsurface wrote:
>> I had a quick look on the statistics. They look great. I found one weird 
>> thing:
>> 
>> When looking at the minimum depth per year, the minimum depth is shown in 
>> the column. When doing the same thing for maximum dept, the maximum depth 
>> isn’t shown in the table.
> 
> It is a question of having enough horizontal space in portrait mode (screen 
> upright) to print all the text labels inside the bars. If I turn my phone to 
> landscape (screen horizontal, not upright) then the text is shown. Maybe the 
> default text size will have an effect.
> 
> Kind regards,
> 
> willem.
> 
> 
> -- 
> This message and attachments are subject to a disclaimer.
> 
> Please refer to 
> http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
>  for
> full details.
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Willem Ferguson via subsurface]

On 2021/01/18 11:13, Martin de Weger via subsurface wrote:
I had a quick look on the statistics. They look great. I found one 
weird thing:


When looking at the minimum depth per year, the minimum depth is shown 
in the column. When doing the same thing for maximum dept, the maximum 
depth isn’t shown in the table.


It is a question of having enough horizontal space in portrait mode 
(screen upright) to print all the text labels inside the bars. If I turn 
my phone to landscape (screen horizontal, not upright) then the text is 
shown. Maybe the default text size will have an effect.


Kind regards,

willem.


--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: mobile version testing

[Paul Buxton via subsurface]

Statistics look pretty awesome.
I do notice if you change to the dark theme (your favorite) that there is
some issue with the size of the titles for the combo boxes.
All looks pretty good otherwise.

Paul

On Sun, Jan 17, 2021 at 3:14 AM Dirk Hohndel via subsurface <
subsurface@subsurface-divelog.org> wrote:

> Hi Everyone,
>
> I just pushed new versions of Subsurface-mobile to TestFlight and the beta
> channel on Google Play. 3.1.3(4,9,10.355)
> Those contain a few interesting new features:
> - early statistics code (this still will change quite a bit as Berthold
> continues to rewrite the underlying code)
> - completely reimagined dive edit code that adapts to different screen
> sizes and should provide a much better experience
> - overhaul of the font size changes - he old code was completely bogus and
> didn't actually do what it promised to do; with these changes the screen
> layout and fonts finally changing in proportionate ways. As a side effect
> there are now 5 font sizes instead of just 3
>
> Since all this is pretty invasive, I'd love to get feedback on what works,
> what doesn't work, or what's ill designed.
>
> Thanks
>
> /D
>
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Chirana Gheorghita Eugeniu Theodor via subsurface]

PS: Android 11 OS on N20

On Mon, Jan 18, 2021 at 10:00 AM Chirana Gheorghita Eugeniu Theodor <
off...@adaptcom.ro> wrote:

> Hello. OK.
>
> Discovered something:
> - I add a new dive
> -Save and exit to Dive list
> - Enter that dive again
> - delete it >> all ok.
>
> - Add a new dive
> - Save and exit to Dive list
> - select another dive and back to dive list
> - Select the newly added dive and back to dive list and tha new dive
> remains selected
> - Open context menu and hit delete >>> App crashes.. Attached logs.
>
> On Mon, Jan 18, 2021 at 9:05 AM Dirk Hohndel  wrote:
>
>> Please note that I haven't merged this, yet, and haven't pushed the new
>> strings, either.
>> I wanted to make sure we have heard more feedback to avoid duplicative
>> work for the translators in case the comments result in bigger changes (as
>> the first comments certainly did).
>>
>> /D
>>
>> On January 17, 2021 10:57:28 PM PST, Chirana Gheorghita Eugeniu Theodor <
>> off...@adaptcom.ro> wrote:
>> >All seems to work as designed. I will see with the Ro translation and
>> >come
>> >back if I encounter any issues.
>>
>> --
>> Sent from my phone
>>
>
>
> --
> 
> Cu stima/Best regards/Mit freundlichen Grüßen,
>
> Chirana-Gheorghita Eugeniu-Theodor
> Bucharest, Romania
>
> e-mail : off...@adaptcom.ro
> mobile: 0743 698721
> 0747 447675
> SSI diver ID: 1118289
>


-- 

Cu stima/Best regards/Mit freundlichen Grüßen,

Chirana-Gheorghita Eugeniu-Theodor
Bucharest, Romania

e-mail : off...@adaptcom.ro
mobile: 0743 698721
0747 447675
SSI diver ID: 1118289
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Accidental file delete on mobile.

[Chirana Gheorghita Eugeniu Theodor via subsurface]

Hello. OK.

Discovered something:
- I add a new dive
-Save and exit to Dive list
- Enter that dive again
- delete it >> all ok.

- Add a new dive
- Save and exit to Dive list
- select another dive and back to dive list
- Select the newly added dive and back to dive list and tha new dive
remains selected
- Open context menu and hit delete >>> App crashes.. Attached logs.

On Mon, Jan 18, 2021 at 9:05 AM Dirk Hohndel  wrote:

> Please note that I haven't merged this, yet, and haven't pushed the new
> strings, either.
> I wanted to make sure we have heard more feedback to avoid duplicative
> work for the translators in case the comments result in bigger changes (as
> the first comments certainly did).
>
> /D
>
> On January 17, 2021 10:57:28 PM PST, Chirana Gheorghita Eugeniu Theodor <
> off...@adaptcom.ro> wrote:
> >All seems to work as designed. I will see with the Ro translation and
> >come
> >back if I encounter any issues.
>
> --
> Sent from my phone
>


-- 

Cu stima/Best regards/Mit freundlichen Grüßen,

Chirana-Gheorghita Eugeniu-Theodor
Bucharest, Romania

e-mail : off...@adaptcom.ro
mobile: 0743 698721
0747 447675
SSI diver ID: 1118289


subsurface[2].log
Description: Binary data
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface