Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

2019-06-21 Thread Jonathan Gibbons

"Invisible" captions need to be discussed for our documentation in general.

Although  is optional for HTML 5, the accessibility guidelines 
that we follow require that we use it. We need to work to provide useful 
(and visible) captions on tables.


-- Jon


On 06/21/2019 01:54 PM, Alexey Ivanov wrote:

On 20/06/2019 01:00, Sergey Bylokhov wrote:

On 12/06/2019 07:09, Alexey Ivanov wrote:


I'd rather leave bold rendering for keys, I think it makes sense. 
Yet it's up to you to decide.


Something like this?
http://cr.openjdk.java.net/~serb/8225146/webrev.03
http://cr.openjdk.java.net/~serb/8225146/webrev.03/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 



Yes, looks good to me.

The  element is optional. Does it make any difference to 
have one if it's hidden? With “display: none” it will not be visible 
to assistive technologies such as screen reader, will it?


The "caption" tag is used across our javadocs because in most cases 
the content of the "caption" tag is a content of the "summary" tag 
which was deprecated in html5, I guess at some point we will need to 
migrate to "aria-label" or something like this.


Yeah, I understand that. And it makes sense where  is visible.
In this case,  element has “display: none” style, thus it's 
invisible for visual browser users, and it's invisible for screen 
reader users as well. As such, we could drop  element 
completely.


It's rather a concern for discussion…







Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

2019-06-21 Thread Alexey Ivanov

On 20/06/2019 01:00, Sergey Bylokhov wrote:

On 12/06/2019 07:09, Alexey Ivanov wrote:


I'd rather leave bold rendering for keys, I think it makes sense. Yet 
it's up to you to decide.


Something like this?
http://cr.openjdk.java.net/~serb/8225146/webrev.03
http://cr.openjdk.java.net/~serb/8225146/webrev.03/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html 



Yes, looks good to me.

The  element is optional. Does it make any difference to 
have one if it's hidden? With “display: none” it will not be visible 
to assistive technologies such as screen reader, will it?


The "caption" tag is used across our javadocs because in most cases 
the content of the "caption" tag is a content of the "summary" tag 
which was deprecated in html5, I guess at some point we will need to 
migrate to "aria-label" or something like this.


Yeah, I understand that. And it makes sense where  is visible.
In this case,  element has “display: none” style, thus it's 
invisible for visual browser users, and it's invisible for screen reader 
users as well. As such, we could drop  element completely.


It's rather a concern for discussion…




--
Regards,
Alexey


Re: [13] Review Request: 8225146 Accessibility issues in javax/swing/plaf/nimbus/doc-files/properties.html

2019-06-19 Thread Sergey Bylokhov

On 12/06/2019 07:09, Alexey Ivanov wrote:

However, I'd prefer a more “verbose” version of  element, I mean with 
added line-breaks and indents unless we're saving disk space.
I also wonder whether it's preserved intact after passing through javadoc.

I tried to save the space before the copyright header, and not to move it to 
the middle of the page.

I'd rather leave bold rendering for keys, I think it makes sense. Yet it's up 
to you to decide.

Something like this?
http://cr.openjdk.java.net/~serb/8225146/webrev.03
http://cr.openjdk.java.net/~serb/8225146/webrev.03/raw_files/new/src/java.desktop/share/classes/javax/swing/plaf/nimbus/doc-files/properties.html


The  element is optional. Does it make any difference to have one if 
it's hidden? With “display: none” it will not be visible to assistive technologies 
such as screen reader, will it?

The "caption" tag is used across our javadocs because in most cases the content of the "caption" 
tag is a content of the "summary" tag which was deprecated in html5, I guess at some point we will need to 
migrate to "aria-label" or something like this.



I'm still for lower-case “and” in the page title and 

. But it's mostly nitpicking…

I tried to set the style to tbody itself and it does not work, will check your 
suggestion below.

But before that, I would like to confirm that the "bold-version"(webrev.00) is 
not good enough?

(The previous version defaulted to bold rendering.)
If yes, is it possible to add a stylesheet to handle this for the entire page?