Re: [OSM-talk] Cannot correct ring self intersection -- josm enhancement needed?

2008-03-14 Thread D Tucny
On 13/03/2008, Joerg Ostertag (OSM Munich/Germany) 
[EMAIL PROTECTED] wrote:

   Alternatively you could split the way into 2: select the way  the
 node
   with the 4 segments, then tools-Split Way. I'm not certain whether
 this
   will end up with 2 closed ways but I think it should.
 
  I have not succeeded at all in splitting closed ways with JOSM. It
 always
  says to me that I should select a node from the middle of the road.  It
  seems to think that any node in the closed ring is the starting
 one.  Other
  way to think is that any node in the ring is in the middle...

 I have not succeeded in doing this either ...
 So maybe this is woth an enhancement request for josm ...


I found that to split a ring you need to select two nodes then split
resulting in two ways, effectively taking a slice out of the ring...

d
___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk


Re: [OSM-talk] Cannot correct ring self intersection

2008-03-13 Thread Rahkonen Jukka
Jon Burgess wrote:

On Thu, 2008-03-13 at 00:16 +, Jukka Rahkonen wrote:
 Hi,
 
 I found about 100 topology errors from polygons in Finland with the following
 work flow:
 
 - OSM-data are in PostGIS 
 - I took polygons with topology errors directly into OpenJUMP map with db 
 query:
   select * from osm_polygon where not  isvalid(way);
 - I used OpenJUMP topology check tool which creates a new point layer
   showing the exact places of the errors
 - That layer I converted to gpx and loaded into JOSM. Then I downloaded OSM 
 data

 An efficient way to do it. I was going to write a script to do the
 something similar but your approach sounds easier.

At least it can be used directly without programming.  It is flexible as well,
the same system works as well with select * from osm_line where 
highway='prmary'.

   around error locations and made corrections.
 
 Usually this works rather well.  But then I faced such a ring 
 self-intersection
 that I cannot correct it.  It is about a lake that intersects itself but also
 shares one node with a road.  The place is here:  
 
 http://www.openstreetmap.org/index.html?mlat=61.277669238738454mlon=28.855010608222813zoom=13
 
 I was thinking that I should cut the lake polygon, draw a couple of new nodes
 and connect the lake together again, but I just cannot split the lake 
 boundary.
  How should I do it?

 What I would do is:

 Use the shift-delete to remove 2 of the 4 segements from the common
 node. Then create another node some small distance away. Then add the
 segments back again going via the new node.

I got it corrected by doing some shift-deleting and redrawing. Thanks to Jörg 
who 
helped by separating the highway for me.


 Alternatively you could split the way into 2: select the way  the node
 with the 4 segments, then tools-Split Way. I'm not certain whether this
 will end up with 2 closed ways but I think it should.

I have not succeeded at all in splitting closed ways with JOSM. It always says 
to 
me that I should select a node from the middle of the road.  It seems to think 
that any node in the closed ring is the starting one.  Other way to think 
is that any node in the ring is in the middle...

-Jukka-



___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk


Re: [OSM-talk] Cannot correct ring self intersection -- josm enhancement needed?

2008-03-13 Thread Joerg Ostertag (OSM Munich/Germany)
  Alternatively you could split the way into 2: select the way  the node
  with the 4 segments, then tools-Split Way. I'm not certain whether this
  will end up with 2 closed ways but I think it should.

 I have not succeeded at all in splitting closed ways with JOSM. It always
 says to me that I should select a node from the middle of the road.  It
 seems to think that any node in the closed ring is the starting one.  Other
 way to think is that any node in the ring is in the middle...

I have not succeeded in doing this either ... 
So maybe this is woth an enhancement request for josm ...

-- 
Jörg (Germany, Munich)

http://www.ostertag.name/
irc://irc.oftc.net/#osm
Tel.: +49 89 420950304
Skype: JoergOstertag

___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk


Re: [OSM-talk] Cannot correct ring self intersection -- josmenhancement needed?

2008-03-13 Thread Juan Lucas Dominguez Rubio
I agree, that's a strange restriction in JOSM.
 
(I grab the opportunity to say that I love JOSM and I thank Immanuel Scholz and 
Frederik Ramm for it.)
 
Lucas



De: [EMAIL PROTECTED] en nombre de Joerg Ostertag (OSM Munich/Germany)
Enviado el: jue 13/03/2008 9:22
Para: talk@openstreetmap.org
Asunto: Re: [OSM-talk] Cannot correct ring self intersection -- 
josmenhancement needed?



  Alternatively you could split the way into 2: select the way  the node
  with the 4 segments, then tools-Split Way. I'm not certain whether this
  will end up with 2 closed ways but I think it should.

 I have not succeeded at all in splitting closed ways with JOSM. It always
 says to me that I should select a node from the middle of the road.  It
 seems to think that any node in the closed ring is the starting one.  Other
 way to think is that any node in the ring is in the middle...

I have not succeeded in doing this either ...
So maybe this is woth an enhancement request for josm ...

--
Jörg (Germany, Munich)

http://www.ostertag.name/
irc://irc.oftc.net/#osm
Tel.: +49 89 420950304
Skype: JoergOstertag

___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk


___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk


Re: [OSM-talk] Cannot correct ring self intersection

2008-03-13 Thread Frederik Ramm
Hi,

 I have not succeeded at all in splitting closed ways with JOSM. It always 
 says to 
 me that I should select a node from the middle of the road.  It seems to 
 think 
 that any node in the closed ring is the starting one.  Other way to think 
 is that any node in the ring is in the middle...

The error message was misleading and has been changed a while ago. If 
you have a recent JOSM version, the message you'll see is: You must 
select two or more nodes to split a circular way.

Which is quite obvious. If you have a way A-B-C-D-E-A and are told to 
split that circular way at node C, how could you do it?

Bye
Frederik


___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk


Re: [OSM-talk] Cannot correct ring self intersection

2008-03-13 Thread Jukka Rahkonen
Frederik Ramm frederik at remote.org writes:


 The error message was misleading and has been changed a while ago. If 
 you have a recent JOSM version, the message you'll see is: You must 
 select two or more nodes to split a circular way.

I updated my josm-latest to josm-latest, and yes, the error message is much more
helpful now.  And selecting two nodes and split is not at all too complicated.
 
 Which is quite obvious. If you have a way A-B-C-D-E-A and are told to 
 split that circular way at node C, how could you do it?

Give scissors to any three-year-old children and you'll see.

-Jukka- 



___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk


[OSM-talk] Cannot correct ring self intersection

2008-03-12 Thread Jukka Rahkonen
Hi,

I found about 100 topology errors from polygons in Finland with the following
work flow:

- OSM-data are in PostGIS 
- I took polygons with topology errors directly into OpenJUMP map with db query:
  select * from osm_polygon where not  isvalid(way);
- I used OpenJUMP topology check tool which creates a new point layer
  showing the exact places of the errors
- That layer I converted to gpx and loaded into JOSM. Then I downloaded OSM data

  around error locations and made corrections.

Usually this works rather well.  But then I faced such a ring self-intersection
that I cannot correct it.  It is about a lake that intersects itself but also
shares one node with a road.  The place is here:  

http://www.openstreetmap.org/index.html?mlat=61.277669238738454mlon=28.855010608222813zoom=13

I was thinking that I should cut the lake polygon, draw a couple of new nodes
and connect the lake together again, but I just cannot split the lake boundary.
 How should I do it?

-Jukka Rahkonen-


___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk


Re: [OSM-talk] Cannot correct ring self intersection

2008-03-12 Thread Jon Burgess

On Thu, 2008-03-13 at 00:16 +, Jukka Rahkonen wrote:
 Hi,
 
 I found about 100 topology errors from polygons in Finland with the following
 work flow:
 
 - OSM-data are in PostGIS 
 - I took polygons with topology errors directly into OpenJUMP map with db 
 query:
   select * from osm_polygon where not  isvalid(way);
 - I used OpenJUMP topology check tool which creates a new point layer
   showing the exact places of the errors
 - That layer I converted to gpx and loaded into JOSM. Then I downloaded OSM 
 data

An efficient way to do it. I was going to write a script to do the
something similar but your approach sounds easier.

   around error locations and made corrections.
 
 Usually this works rather well.  But then I faced such a ring 
 self-intersection
 that I cannot correct it.  It is about a lake that intersects itself but also
 shares one node with a road.  The place is here:  
 
 http://www.openstreetmap.org/index.html?mlat=61.277669238738454mlon=28.855010608222813zoom=13
 
 I was thinking that I should cut the lake polygon, draw a couple of new nodes
 and connect the lake together again, but I just cannot split the lake 
 boundary.
  How should I do it?

What I would do is:

Use the shift-delete to remove 2 of the 4 segements from the common
node. Then create another node some small distance away. Then add the
segments back again going via the new node.

Alternatively you could split the way into 2: select the way  the node
with the 4 segments, then tools-Split Way. I'm not certain whether this
will end up with 2 closed ways but I think it should.

Jon



___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk


Re: [OSM-talk] Cannot correct ring self intersection

2008-03-12 Thread Joerg Ostertag (OSM Munich/Germany)
On Donnerstag 13 März 2008, Jukka Rahkonen wrote:
 Hi,

 I found about 100 topology errors from polygons in Finland with the
 following work flow:

 - OSM-data are in PostGIS
 - I took polygons with topology errors directly into OpenJUMP map with db
 query: select * from osm_polygon where not  isvalid(way);
 - I used OpenJUMP topology check tool which creates a new point layer
   showing the exact places of the errors
 - That layer I converted to gpx and loaded into JOSM. Then I downloaded OSM
 data

   around error locations and made corrections.

 Usually this works rather well.  But then I faced such a ring
 self-intersection that I cannot correct it.  It is about a lake that
 intersects itself but also shares one node with a road.  The place is here:

 http://www.openstreetmap.org/index.html?mlat=61.277669238738454mlon=28.855
010608222813zoom=13

 I was thinking that I should cut the lake polygon, draw a couple of new
 nodes and connect the lake together again, but I just cannot split the lake
 boundary. How should I do it?

I did split the street from the wood for you and seperated the two wood 
peaces. I hope this does help you in editing furter ...

-- 
Jörg (Germany, Munich)

http://www.ostertag.name/
irc://irc.oftc.net/#osm
Tel.: +49 89 420950304
Skype: JoergOstertag

___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/talk