Re: [Talk-transit] Naptan import

2009-08-01 Thread Roger Slevin
Plusbus zones are polygons which are unrelated to the road network - so for Rye 
it covers a large polygon defined by straight lines linking each pair of 
adjacent nodes on the source list of defining points.  The representation of 
this "along the roads" is inappropriate - and certainly not how it should be 
should be shown in terms of the zone definition intended.

The Rye example is a particularly extreme example, as there are few roads in 
the area with bus routes - and lots of marshland and open countryside covered 
by the Plusbus zone.

Roger

-Original Message-
From: talk-transit-boun...@openstreetmap.org 
[mailto:talk-transit-boun...@openstreetmap.org] On Behalf Of Christoph Böhme
Sent: 02 August 2009 00:24
To: Thomas Wood
Cc: Public transport/transit/shared taxi related topics
Subject: Re: [Talk-transit] Naptan import

Thomas Wood  schrieb:

> 2009/7/30 Christoph Böhme :
> > Thomas Wood  schrieb:
> >> 2009/7/29 Christoph Böhme :
> >> > I transformed the Plusbus Zones into a josm-file (XSLT is
> >> > cool :-). Thomas can you import it using the naptan-user if no
> >> > one objects to the tagging scheme?
> >> >
> >> > http://www.mappa-mercia.org/nptg/plusbuszones.osm.gz
> >> >
> >> > Cheers,
> >> > Christoph
> >> >
> >> > ___
> >> > Talk-transit mailing list
> >> > Talk-transit@openstreetmap.org
> >> > http://lists.openstreetmap.org/listinfo/talk-transit
> >> >
> >>
> >> That looks fine, the only issue is that none of the polygons are
> >> closed!
> >
> > Oh, good that you noticed this. I fixed the file and uploaded it
> > again.
> >
> > Christoph
> >
> 
> I have run JOSM's validator over it to clean up some duplicate ways,
> and the more obviously incorrect polygon geometries (West Mids had a
> weird doubleback by the look of it) a few have overlapping segments,
> but I've chosen to ignore their 'errorness'.
> 
> http://www.openstreetmap.org/browse/changeset/2008301

Good idea to use JOSM's validator, I should have done it myself ...

The incorrect geometries are converted directly from the NPTG data.
Some of the polygons there have duplicate nodes. Removing the
duplicate nodes was a sensible choice, I think. I had a look at the
very distorted Plusbus Zone for Rye. Its strange shape seems to stem
from the fact that it simple spans four villages and follows the road
between them. I think there are similar reasons for the other errors.

Thank you checking and importing the changeset!

Christoph

> -- 
> Regards,
> Thomas Wood
> (Edgemaster)

___
Talk-transit mailing list
Talk-transit@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-transit


___
Talk-transit mailing list
Talk-transit@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-transit


Re: [Talk-transit] Naptan import

2009-08-01 Thread Christoph Böhme
Thomas Wood  schrieb:

> 2009/7/30 Christoph Böhme :
> > Thomas Wood  schrieb:
> >> 2009/7/29 Christoph Böhme :
> >> > I transformed the Plusbus Zones into a josm-file (XSLT is
> >> > cool :-). Thomas can you import it using the naptan-user if no
> >> > one objects to the tagging scheme?
> >> >
> >> > http://www.mappa-mercia.org/nptg/plusbuszones.osm.gz
> >> >
> >> > Cheers,
> >> > Christoph
> >> >
> >> > ___
> >> > Talk-transit mailing list
> >> > Talk-transit@openstreetmap.org
> >> > http://lists.openstreetmap.org/listinfo/talk-transit
> >> >
> >>
> >> That looks fine, the only issue is that none of the polygons are
> >> closed!
> >
> > Oh, good that you noticed this. I fixed the file and uploaded it
> > again.
> >
> > Christoph
> >
> 
> I have run JOSM's validator over it to clean up some duplicate ways,
> and the more obviously incorrect polygon geometries (West Mids had a
> weird doubleback by the look of it) a few have overlapping segments,
> but I've chosen to ignore their 'errorness'.
> 
> http://www.openstreetmap.org/browse/changeset/2008301

Good idea to use JOSM's validator, I should have done it myself ...

The incorrect geometries are converted directly from the NPTG data.
Some of the polygons there have duplicate nodes. Removing the
duplicate nodes was a sensible choice, I think. I had a look at the
very distorted Plusbus Zone for Rye. Its strange shape seems to stem
from the fact that it simple spans four villages and follows the road
between them. I think there are similar reasons for the other errors.

Thank you checking and importing the changeset!

Christoph

> -- 
> Regards,
> Thomas Wood
> (Edgemaster)

___
Talk-transit mailing list
Talk-transit@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-transit


Re: [Talk-transit] NaPTAN Import

2009-08-01 Thread Thomas Wood
2009/8/1 Christoph Böhme :
> Thomas Wood  schrieb:
>
>> 2009/8/1 Christoph Böhme :
>> > Thomas Wood  schrieb:
>> >> Otherwise, a test upload of the Surrey data is visible here -
>> >> http://api06.dev.openstreetmap.org/browse/changeset/394
>> >> Comments welcomed.
>> >
>> > Could it be that the tags are missing? All the nodes I have looked
>> > at are empty
>> > (http://api06.dev.openstreetmap.org/browse/node/416977, for example)
>>
>> Ooops, I linked the wrong changeset!
>> http://api06.dev.openstreetmap.org/browse/changeset/389 was my intent.
>
> That looks much better :-) I noticed that the bus stops are all tagged
> with highway=bus_stop. Is this intentional? I thought this should
> depend on what people wished for their local area.
>
> Cheers,
> Christoph
>

It is optional, by default I test with it enabled, it requires an
extra command-line option to disable.
So far most people have chosen for it to be on though -
http://wiki.openstreetmap.org/wiki/NaPTAN/Request_for_Import

-- 
Regards,
Thomas Wood
(Edgemaster)

___
Talk-transit mailing list
Talk-transit@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-transit


Re: [Talk-transit] Naptan import

2009-08-01 Thread Thomas Wood
2009/7/30 Christoph Böhme :
> Thomas Wood  schrieb:
>> 2009/7/29 Christoph Böhme :
>> > I transformed the Plusbus Zones into a josm-file (XSLT is cool :-).
>> > Thomas can you import it using the naptan-user if no one objects to
>> > the tagging scheme?
>> >
>> > http://www.mappa-mercia.org/nptg/plusbuszones.osm.gz
>> >
>> > Cheers,
>> > Christoph
>> >
>> > ___
>> > Talk-transit mailing list
>> > Talk-transit@openstreetmap.org
>> > http://lists.openstreetmap.org/listinfo/talk-transit
>> >
>>
>> That looks fine, the only issue is that none of the polygons are
>> closed!
>
> Oh, good that you noticed this. I fixed the file and uploaded it again.
>
> Christoph
>

I have run JOSM's validator over it to clean up some duplicate ways,
and the more obviously incorrect polygon geometries (West Mids had a
weird doubleback by the look of it) a few have overlapping segments,
but I've chosen to ignore their 'errorness'.

http://www.openstreetmap.org/browse/changeset/2008301

-- 
Regards,
Thomas Wood
(Edgemaster)

___
Talk-transit mailing list
Talk-transit@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-transit


Re: [Talk-transit] NaPTAN Import

2009-08-01 Thread Christoph Böhme
Thomas Wood  schrieb:

> 2009/8/1 Christoph Böhme :
> > Thomas Wood  schrieb:
> >> Otherwise, a test upload of the Surrey data is visible here -
> >> http://api06.dev.openstreetmap.org/browse/changeset/394
> >> Comments welcomed.
> >
> > Could it be that the tags are missing? All the nodes I have looked
> > at are empty
> > (http://api06.dev.openstreetmap.org/browse/node/416977, for example)
> 
> Ooops, I linked the wrong changeset!
> http://api06.dev.openstreetmap.org/browse/changeset/389 was my intent.

That looks much better :-) I noticed that the bus stops are all tagged
with highway=bus_stop. Is this intentional? I thought this should
depend on what people wished for their local area.

Cheers,
Christoph

___
Talk-transit mailing list
Talk-transit@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-transit


Re: [Talk-transit] NaPTAN Import

2009-08-01 Thread Thomas Wood
2009/8/1 Christoph Böhme :
> Thomas Wood  schrieb:
>
>> I think all outstanding coding issues have now been dealt with.
>> There's one minor tagging issue to address - should the source tag be
>> on the data or changesets.
>
> Since the source tag applies to the whole changeset it makes sense to
> tag only the changeset. However, I believe editors do not display
> changeset tags at the moment. This means changeset tags are basically
> not visible when you edit data. While it can be handy to see the source
> of an element when you edit it (e.g. I'm much less relucant to move
> NPE-sourced data if it does not fit with my tracks than surveyed data)
> this should not be a problem with the naptan-import. The naptan:-tags
> are a very obvious hint where the data is coming from.
>
> So, I'd vote for placing the source-tag at the changeset.
>
>> Otherwise, a test upload of the Surrey data is visible here -
>> http://api06.dev.openstreetmap.org/browse/changeset/394
>> Comments welcomed.
>
> Could it be that the tags are missing? All the nodes I have looked at
> are empty (http://api06.dev.openstreetmap.org/browse/node/416977, for
> example)

Ooops, I linked the wrong changeset!
http://api06.dev.openstreetmap.org/browse/changeset/389 was my intent.

>
>> We're then ready to begin uploading to the main database.
>
> Cool :-)
>
> Cheers,
> Christoph
>
> ___
> Talk-transit mailing list
> Talk-transit@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/talk-transit
>



-- 
Regards,
Thomas Wood
(Edgemaster)

___
Talk-transit mailing list
Talk-transit@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-transit


Re: [Talk-transit] NaPTAN Import

2009-08-01 Thread Christoph Böhme
Thomas Wood  schrieb:

> I think all outstanding coding issues have now been dealt with.
> There's one minor tagging issue to address - should the source tag be
> on the data or changesets.

Since the source tag applies to the whole changeset it makes sense to
tag only the changeset. However, I believe editors do not display
changeset tags at the moment. This means changeset tags are basically
not visible when you edit data. While it can be handy to see the source
of an element when you edit it (e.g. I'm much less relucant to move
NPE-sourced data if it does not fit with my tracks than surveyed data)
this should not be a problem with the naptan-import. The naptan:-tags
are a very obvious hint where the data is coming from.

So, I'd vote for placing the source-tag at the changeset.

> Otherwise, a test upload of the Surrey data is visible here -
> http://api06.dev.openstreetmap.org/browse/changeset/394
> Comments welcomed.

Could it be that the tags are missing? All the nodes I have looked at
are empty (http://api06.dev.openstreetmap.org/browse/node/416977, for
example)

> We're then ready to begin uploading to the main database.

Cool :-)

Cheers,
Christoph

___
Talk-transit mailing list
Talk-transit@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-transit


[Talk-transit] NaPTAN Import

2009-08-01 Thread Thomas Wood
I think all outstanding coding issues have now been dealt with.
There's one minor tagging issue to address - should the source tag be
on the data or changesets.

Otherwise, a test upload of the Surrey data is visible here -
http://api06.dev.openstreetmap.org/browse/changeset/394
Comments welcomed.

We're then ready to begin uploading to the main database.

I will fetch a fresh copy of the NaPTAN data now, as agreed earlier last month.

-- 
Regards,
Thomas Wood
(Edgemaster)

___
Talk-transit mailing list
Talk-transit@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk-transit