Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-10-19 Thread David Wheeler 
On Oct 18, 2004, at 5:06 PM, [EMAIL PROTECTED] wrote:
  add new test_config make target, equivalent to t/TEST -conf,
  and make it a prerequisite for the cmodules make target.  now
  you can 'make cmodules' to build the things in c-modules/
  without running t/TEST -conf first.
Uh, what? Can you tell me what this does, Geoff, so I can figure out 
whether it needs to be implemented for TestMB, too?

Thanks,
David

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-09-05 Thread Stas Bekman 
Geoffrey Young wrote:
[EMAIL PROTECTED] wrote:
stas2004/08/26 17:51:55
 Modified:perl-framework/Apache-Test/lib/Apache TestConfig.pm
  perl-framework/Apache-Test Changes
 Log:
 Make sure that when Apache-Test is a part of modperl-2.0 checkout, the
 interactive configuration is properly run (it must not be run when
 mod_perl 2.0 is tested since it should have all the info needed to run
 the tests).

  
 -use constant IS_MOD_PERL_2_BUILD = IS_MOD_PERL_2 
 -require Apache::Build  Apache::Build::IS_MOD_PERL_BUILD();
 -
  use constant IS_APACHE_TEST_BUILD =
  grep { -e $_/lib/Apache/TestConfig.pm } qw(Apache-Test . ..);
  
 +use constant IS_MOD_PERL_2_BUILD =
 +IS_MOD_PERL_2  !IS_APACHE_TEST_BUILD 
 +require Apache::Build  Apache::Build::IS_MOD_PERL_BUILD();
 +

this borked the mod_perl build.  IS_APACHE_TEST_BUILD now reports back true
for a mod_perl checkout, which makes IS_MOD_PERL_2_BUILD false.  the result
is that Apache2.pm is added to t/TEST but lib/ is not, so t/TEST can't run
on a fresh checkout (where there are no mod_perl files in site_lib).
I think the attached patch makes more sense, but I'm not sure if it collides
with the problem you were trying to solve.
--Geoff

Index: Apache-Test/lib/Apache/TestConfig.pm
===
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.243
diff -u -r1.243 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm	27 Aug 2004 01:03:55 -	1.243
+++ Apache-Test/lib/Apache/TestConfig.pm	3 Sep 2004 14:23:24 -
@@ -31,7 +31,7 @@
 eval { require mod_perl  $mod_perl::VERSION = 1.99 } || 0;
 
 use constant IS_APACHE_TEST_BUILD =
-grep { -e $_/lib/Apache/TestConfig.pm } qw(Apache-Test . ..);
+grep { -e $_/lib/Apache/TestConfig.pm } qw(. ..);
 
 use constant IS_MOD_PERL_2_BUILD =
 IS_MOD_PERL_2  !IS_APACHE_TEST_BUILD 
thanks Geoff for the heads up, I think I've found a more suitable solution 
for this. One shouldn't run 'perl Makefile.PL' from within Apache-Test/ 
when that is a checkout inside modperl-2.0. I have been bitten by that 
quite a few times, as there are many bad sideeffects when 
Apache-Test/t/conf is populated (it gets picked up by modperl tests then 
causing all kind breakages).

--
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-06-28 Thread Geoffrey Young 


Stas Bekman wrote:
 [EMAIL PROTECTED] wrote:
 
 stas2004/06/27 11:46:03

   Modified:perl-framework/Apache-Test/lib/Apache TestReportPerl.pm
perl-framework/Apache-Test Changes
   Log:
   Force projects that use Apache::TestReportPerl to implement
   report_to() if they use t/REPORT in their projects.
 
 
 ay, didn't realize the candidate is still out there and wasn't released.
 Sorry about that. Though these changes should be harmless :)

that's ok - I have rerolled a new candidate with these changes incorporated
for you to test ;)

if all looks good to you I'll release.

--Geoff

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-06-28 Thread David Wheeler 
On Jun 28, 2004, at 6:14 AM, Geoffrey Young wrote:
that's ok - I have rerolled a new candidate with these changes 
incorporated
for you to test ;)

if all looks good to you I'll release.
All tests pass for me. I don't know if this was intentional, but the 
new tests I introduced last week aren't in the current tarball. It 
might just make sense to put t/redirect.t into MANIFEST after this 
release, so that there is some more testing of them between now and 
1.13. Although they should just work, and where they don't it should 
identify bugs in the current code anyway...But I leave it up to you 
guys.

Regards,
David

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-06-28 Thread Stas Bekman 
David Wheeler wrote:
On Jun 28, 2004, at 6:14 AM, Geoffrey Young wrote:
that's ok - I have rerolled a new candidate with these changes 
incorporated
for you to test ;)

if all looks good to you I'll release.

All tests pass for me. I don't know if this was intentional, but the new 
tests I introduced last week aren't in the current tarball. It might 
just make sense to put t/redirect.t into MANIFEST after this release, so 
that there is some more testing of them between now and 1.13. Although 
they should just work, and where they don't it should identify bugs in 
the current code anyway...But I leave it up to you guys.
Added. We used to not do that manually, since modperl-2.0 automatically 
generates MANIFEST. Not the case with A-T.

Geoff, just go ahead and release it with the new MANIFEST.
--
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-06-27 Thread Stas Bekman 
[EMAIL PROTECTED] wrote:
stas2004/06/27 11:46:03
  Modified:perl-framework/Apache-Test/lib/Apache TestReportPerl.pm
   perl-framework/Apache-Test Changes
  Log:
  Force projects that use Apache::TestReportPerl to implement
  report_to() if they use t/REPORT in their projects.
ay, didn't realize the candidate is still out there and wasn't released. Sorry 
about that. Though these changes should be harmless :)

--
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-05-04 Thread Stas Bekman 
Cliff Woolley wrote:
On Mon, 5 Apr 2004 [EMAIL PROTECTED] wrote:

stas2004/04/04 21:35:21
 Modified:perl-framework/Apache-Test/lib/Apache TestRun.pm
   TestConfig.pm
  perl-framework/Apache-Test Changes
 Log:
 Don't try to set ulimit unlimited for coredumps on Solaris, unless run
 as root
 Submitted by:  Rob Kinyon [EMAIL PROTECTED]

Um, wait, why is this?  I have ulimit -c unlimited in my non-root-user
.bashrc on Solaris 8 and it works fine (it worked on other versions as
well).
The only time it won't let you set it as a normal user that I was aware of
was when the system-wide login script has it set to something less than
unlimited explicitly ... a normal user can decrease the limit but not
increase it.
Cliff, did you have a chance to look at this issue? Thanks!
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-04-05 Thread Cliff Woolley 
On Mon, 5 Apr 2004 [EMAIL PROTECTED] wrote:

 stas2004/04/04 21:35:21

   Modified:perl-framework/Apache-Test/lib/Apache TestRun.pm
 TestConfig.pm
perl-framework/Apache-Test Changes
   Log:
   Don't try to set ulimit unlimited for coredumps on Solaris, unless run
   as root
   Submitted by:   Rob Kinyon [EMAIL PROTECTED]

Um, wait, why is this?  I have ulimit -c unlimited in my non-root-user
.bashrc on Solaris 8 and it works fine (it worked on other versions as
well).

The only time it won't let you set it as a normal user that I was aware of
was when the system-wide login script has it set to something less than
unlimited explicitly ... a normal user can decrease the limit but not
increase it.

--Cliff

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2004-04-05 Thread Stas Bekman 
Cliff Woolley wrote:
On Mon, 5 Apr 2004 [EMAIL PROTECTED] wrote:

stas2004/04/04 21:35:21
 Modified:perl-framework/Apache-Test/lib/Apache TestRun.pm
   TestConfig.pm
  perl-framework/Apache-Test Changes
 Log:
 Don't try to set ulimit unlimited for coredumps on Solaris, unless run
 as root
 Submitted by:  Rob Kinyon [EMAIL PROTECTED]

Um, wait, why is this?  I have ulimit -c unlimited in my non-root-user
.bashrc on Solaris 8 and it works fine (it worked on other versions as
well).
The only time it won't let you set it as a normal user that I was aware of
was when the system-wide login script has it set to something less than
unlimited explicitly ... a normal user can decrease the limit but not
increase it.
Cool, can you patch it so that it'll check first whether it can do that, 
before it does that? We get users reporting problems when ulimit fails. I 
don't have an access to Solaris, so if you can fix that, that would be great. 
Thanks.

I guess it needs to check the output of 'ulimit -c' and do the decision based 
on that. But I'll leave it to you to get the right logic.

--
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2003-12-15 Thread Stas Bekman 
[EMAIL PROTECTED] wrote:
geoff   2003/12/15 06:08:16
  Modified:perl-framework/Apache-Test Changes
  Log:
  allow conditional C module compilation on a more granular level.
  #define HTTPD_TEST_REQUIRE_APACHE 2.0.49 is now recognized.
[...]
  +allow conditional C module compilation on a more granular level.
  +#define HTTPD_TEST_REQUIRE_APACHE 2.0.49 is now recognized.
  +[Geoffrey Young]
 docs?
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2003-05-21 Thread Stas Bekman 
Sander Temme wrote:
on 5/20/03 10:53, Sander Temme at [EMAIL PROTECTED] wrote:

This breaks on RH 8.0 and Solaris 7, both on perl 5.8.0, with the following

The following patch gets me back in the saddle, not only on Linux/Solaris
but also on Darwin 6.6:
Index: Apache-Test/lib/Apache/TestConfig.pm
===
RCS file: 
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.
pm,v
retrieving revision 1.162
diff -u -r1.162 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm20 May 2003 06:01:38 -
1.162
+++ Apache-Test/lib/Apache/TestConfig.pm20 May 2003 18:18:08 -
@@ -781,7 +781,7 @@
 push @dirs, '../lib';
 }
 
-push @dirs, 'Apache-Test' if IS_MOD_PERL_2_BUILD;
+push @dirs, 'Apache-Test/lib';
 
 return EOF;
 
I'm not building mod_perl, so that Apache-Test did not get included on
Darwin (running perl 5.6.0 which apparently doesn't choke on the constant)
and furthermore it needs to be Apache-Test/lib.

Please let me know if I'm onto something, or merely on something.
Yes, yes, I've messed things up a bit. My goal was to cleanup @INC from 
non-existing dirs. Therefore can you try this patch:

Index: Apache-Test/lib/Apache/TestConfig.pm
===
RCS file: 
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.162
diff -u -r1.162 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm20 May 2003 06:01:38 - 
 1.162
+++ Apache-Test/lib/Apache/TestConfig.pm20 May 2003 23:33:27 -
@@ -781,7 +781,13 @@
 push @dirs, '../lib';
 }

-push @dirs, 'Apache-Test' if IS_MOD_PERL_2_BUILD;
+for (qw(. ..)) {
+my $dir = catdir $FindBin::Bin, .., $_ , Apache-Test, lib;
+if (-d $dir) {
+push @dirs, $dir;
+last;
+}
+}
 return EOF;

__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2003-05-21 Thread Stas Bekman 
Stas Bekman wrote:
Sander Temme wrote:
on 5/20/03 10:53, Sander Temme at [EMAIL PROTECTED] wrote:

This breaks on RH 8.0 and Solaris 7, both on perl 5.8.0, with the 
following
Eventually I've committed a different fix. Please check that it works for you. 
Thanks.

__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2003-05-20 Thread Sander Temme 
on 5/19/03 23:01, [EMAIL PROTECTED] at [EMAIL PROTECTED] wrote:

This breaks on RH 8.0 and Solaris 7, both on perl 5.8.0, with the following
protest:

pxs /tmp/apache2/bin/apxs
Useless use of a constant in void context at
Apache-Test/lib/Apache/TestConfig.pm line 784.
Compilation failed in require at Apache-Test/lib/Apache/TestMM.pm line 7.
BEGIN failed--compilation aborted at Apache-Test/lib/Apache/TestMM.pm line
7.
Compilation failed in require at Makefile.PL line 9.
BEGIN failed--compilation aborted at Makefile.PL line 9.

The offending line is the following:

 +push @dirs, 'Apache-Test' if IS_MOD_PERL_2_BUILD;

Does that IS_MOD_PERL_2_BUILD need to be in a name space when it is
referenced within the subroutine?

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2003-05-20 Thread Sander Temme 
on 5/20/03 10:53, Sander Temme at [EMAIL PROTECTED] wrote:

 This breaks on RH 8.0 and Solaris 7, both on perl 5.8.0, with the following

The following patch gets me back in the saddle, not only on Linux/Solaris
but also on Darwin 6.6:

Index: Apache-Test/lib/Apache/TestConfig.pm
===
RCS file: 
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.
pm,v
retrieving revision 1.162
diff -u -r1.162 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm20 May 2003 06:01:38 -
1.162
+++ Apache-Test/lib/Apache/TestConfig.pm20 May 2003 18:18:08 -
@@ -781,7 +781,7 @@
 push @dirs, '../lib';
 }
 
-push @dirs, 'Apache-Test' if IS_MOD_PERL_2_BUILD;
+push @dirs, 'Apache-Test/lib';
 
 return EOF;
 
I'm not building mod_perl, so that Apache-Test did not get included on
Darwin (running perl 5.6.0 which apparently doesn't choke on the constant)
and furthermore it needs to be Apache-Test/lib.

Please let me know if I'm onto something, or merely on something.

Thanks,

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2003-05-14 Thread Geoffrey Young 
sorry, I didn't realize I was subscribed to this list :)
use Config;
  +use Apache::TestLoad ();
whoops :)
--Geoff

Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2003-05-14 Thread Stas Bekman 
Geoffrey Young wrote:
sorry, I didn't realize I was subscribed to this list :)
 use Config;
  +use Apache::TestLoad ();

whoops :)
oops indeed, thanks for the fix Geoff. I've removed it.

__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com