cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationServlet.java

[remm]

remm2003/07/07 23:32:53

  Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
ApplicationServlet.java
  Log:
  - Feel free to veto, but I believe a well behaved application should not
fork a thread for something like doing its init stuff (even if it's faster).
  
  Revision  ChangesPath
  1.4   +7 -18 
jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationServlet.java
  
  Index: ApplicationServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationServlet.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- ApplicationServlet.java   17 Mar 2003 07:50:12 -  1.3
  +++ ApplicationServlet.java   8 Jul 2003 06:32:52 -   1.4
  @@ -82,7 +82,7 @@
* @version $Revision$ $Date$
*/
   
  -public class ApplicationServlet extends ActionServlet implements Runnable {
  +public class ApplicationServlet extends ActionServlet {
   
   
   // - Manifest Constants
  @@ -147,19 +147,8 @@
* @exception ServletException if an initialization error occurs.
*/
   public void init() throws javax.servlet.ServletException {
  -new Thread(this).start();
  -}
  -
  -public void run() {
  -try {
  -// Perform normal superclass initialization
  -super.init();
  -
  -// Perform initialization specific to this application
  -initApplicationLocales();
  -} catch( Exception ex ) {
  -ex.printStackTrace();
  -}
  +super.init();
  +initApplicationLocales();
   }
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session SimpleTcpReplicationManager.java

[remm]

remm2003/07/07 23:30:45

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/session
SimpleTcpReplicationManager.java
  Log:
  - Remove session recycling, as well as the comments criticizing session
recycling.
  
  Revision  ChangesPath
  1.9   +4 -26 
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/SimpleTcpReplicationManager.java
  
  Index: SimpleTcpReplicationManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/SimpleTcpReplicationManager.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- SimpleTcpReplicationManager.java  18 Apr 2003 02:51:24 -  1.8
  +++ SimpleTcpReplicationManager.java  8 Jul 2003 06:30:45 -   1.9
  @@ -229,29 +229,7 @@
   throw new 
IllegalStateException(sm.getString("standardManager.createSession.ise"));
   
   
  -// Recycle or create a Session instance
  -Session session = null;
  -//modified to make sure we only recycle sessions that are of 
type=ReplicatedSession
  -//I personally believe the VM does a much better job pooling object 
instances
  -//than the synchronized penalty gives us
  -synchronized (recycled) {
  -int size = recycled.size();
  -int index = size;
  -if (size > 0) {
  -do
  -{
  -index--;
  -session = (Session) recycled.get(index);
  -recycled.remove(index);
  -} while ( index > 0 && (session instanceof ReplicatedSession));
  -}
  -}//synchronized
  -
  -//set the current manager
  -if (session != null)
  -session.setManager(this);
  -else
  -session = new ReplicatedSession(this);
  +Session session = new ReplicatedSession(this);
   
   // Initialize the properties of the new session and return it
   session.setNew(true);
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java PersistentManagerBase.java StandardManager.java StandardSession.java

[remm]

remm2003/07/07 23:28:02

  Modified:catalina/src/share/org/apache/catalina/session
ManagerBase.java PersistentManagerBase.java
StandardManager.java StandardSession.java
  Log:
  - Remove session recycling.
  
  Revision  ChangesPath
  1.19  +26 -38
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java
  
  Index: ManagerBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- ManagerBase.java  24 Apr 2003 22:14:59 -  1.18
  +++ ManagerBase.java  8 Jul 2003 06:28:02 -   1.19
  @@ -207,12 +207,6 @@
   
   
   /**
  - * The set of previously recycled Sessions for this Manager.
  - */
  -protected ArrayList recycled = new ArrayList();
  -
  -
  -/**
* The set of currently active Sessions for this Manager, keyed by
* session identifier.
*/
  @@ -719,19 +713,7 @@
* because it reads it from the Store.
*/
   public Session createEmptySession() {
  -Session session = null;
  -synchronized (recycled) {
  -int size = recycled.size();
  -if (size > 0) {
  -session = (Session) recycled.get(size - 1);
  -recycled.remove(size - 1);
  -}
  -}
  -if (session != null)
  -session.setManager(this);
  -else
  -session = getNewSession();
  -return(session);
  +return (getNewSession());
   }
   
   
  @@ -915,22 +897,13 @@
   }
   
   
  -/**
  - * Add this Session to the recycle collection for this Manager.
  - *
  - * @param session Session to be recycled
  - */
  -protected void recycle(Session session) {
  -synchronized (recycled) {
  -recycled.add(session);
  -}
  -}
  -
   public void setSessionCounter(int sessionCounter) {
   this.sessionCounter = sessionCounter;
   }
   
  -/** Total sessions created by this manager.
  +
  +/** 
  + * Total sessions created by this manager.
*
* @return sessions created
*/
  @@ -938,8 +911,10 @@
   return sessionCounter;
   }
   
  -/** Number of duplicated session IDs generated by the random source.
  - *  Anything bigger than 0 means problems.
  +
  +/** 
  + * Number of duplicated session IDs generated by the random source.
  + * Anything bigger than 0 means problems.
*
* @return
*/
  @@ -947,11 +922,14 @@
   return duplicates;
   }
   
  +
   public void setDuplicates(int duplicates) {
   this.duplicates = duplicates;
   }
   
  -/** Returns the number of active sessions
  +
  +/** 
  + * Returns the number of active sessions
*
* @return number of sessions active
*/
  @@ -959,7 +937,9 @@
   return sessions.size();
   }
   
  -/** Max number of concurent active sessions
  +
  +/**
  + * Max number of concurent active sessions
*
* @return
*/
  @@ -967,11 +947,14 @@
   return maxActive;
   }
   
  +
   public void setMaxActive(int maxActive) {
   this.maxActive = maxActive;
   }
   
  -/** For debugging: return a list of all session ids currently active
  +
  +/** 
  + * For debugging: return a list of all session ids currently active
*
*/
   public String listSessionIds() {
  @@ -983,7 +966,9 @@
   return sb.toString();
   }
   
  -/** For debugging: get a session attribute
  +
  +/** 
  + * For debugging: get a session attribute
*
* @param sessionId
* @param key
  @@ -1000,6 +985,7 @@
   return o.toString();
   }
   
  +
   public void expireSession( String sessionId ) {
   Session s=(Session)sessions.get(sessionId);
   if( s==null ) {
  @@ -1009,6 +995,7 @@
   s.expire();
   }
   
  +
   public String getLastAccessedTime( String sessionId ) {
   Session s=(Session)sessions.get(sessionId);
   if( s==null ) {
  @@ -1017,6 +1004,7 @@
   }
   return new Date(s.getLastAccessedTime()).toString();
   }
  +
   
   //  JMX and Registration  
   protected String domain;
  
  
  
  1.8   +4 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/PersistentManagerBase.java
  
  Index: PersistentManagerBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/PersistentManagerBase.java,v
  retrievin

cvs commit: jakarta-tomcat-5 build.xml

[remm]

remm2003/07/07 23:27:09

  Modified:.build.xml
  Log:
  - Exclude generated source in the JSP examples.
  
  Revision  ChangesPath
  1.139 +3 -1  jakarta-tomcat-5/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/build.xml,v
  retrieving revision 1.138
  retrieving revision 1.139
  diff -u -r1.138 -r1.139
  --- build.xml 6 Jul 2003 23:15:11 -   1.138
  +++ build.xml 8 Jul 2003 06:27:09 -   1.139
  @@ -1097,7 +1097,9 @@
   
   -->
   
  -  
  +  
  +
  +  
   
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21390] - Incorrect code generated by the jsp compiler

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21390

Incorrect code generated by the jsp compiler





--- Additional Comments From [EMAIL PROTECTED]  2003-07-08 02:48 ---
Created an attachment (id=7144)
A sample application which reports the error in tomcat 4.1 and up

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [5.0] Removing session recycling code

[Costin Manolache]

+1 

The session is a long-lived object, so the improvement on recycling is
minor. 

Costin

Remy Maucherat wrote:

> Hi,
> 
> I'd like to completely remove session recycling code from TC 5, as it is
> a potentially dangerous feature (which has been disabled in TC 4.1.x)
> and does not bring any actual performance improvement while using memory.
> The biggest impact of the change is the removal of the recycled array
> list for base manager, which can break existing TC 4 managers. OTOH,
> using that is unsafe, and fixing an affected manager is very easy (just
> remove whatever recylcling code was used).
> 
> I plan to keep Session.recycle around (nulling out references can help
> GC, esp since there could be a lot of session objects - with all their
> children - waiting to be GCed).
> 
> Comments ?
> 
> Remy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21390] New: - Incorrect code generated by the jsp compiler

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21390

Incorrect code generated by the jsp compiler

   Summary: Incorrect code generated by the jsp compiler
   Product: Tomcat 5
   Version: 5.0.3
  Platform: All
OS/Version: Windows XP
Status: NEW
  Severity: Major
  Priority: Other
 Component: Jasper2
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hi,

This problem seems to have started with the 4.1 release of tomcat.
It was working fine in 4.0.
I have 2 tags on a jsp page.
Both of them expose variables with the same name and this results in the jsp
compiler from 4.1 and above giving the follwing compilation error.

Generated servlet error:
[javac] Compiling 1 source file

C:\apps\jakarta-tomcat-5.0.3\work\Catalina\localhost\oracletest\org\apache\jsp\test_jsp.java:95:
cannot resolve symbol
symbol  : variable Message 
location: class org.apache.jsp.test_jsp
  Message = (String) pageContext.findAttribute("Message");
  ^



An error occurred at line: 17 in the jsp file: /test.jsp

Generated servlet error:
C:\apps\jakarta-tomcat-5.0.3\work\Catalina\localhost\oracletest\org\apache\jsp\test_jsp.java:96:
cannot resolve symbol
symbol  : variable prop 
location: class org.apache.jsp.test_jsp
  prop = (test.TempProperties) pageContext.findAttribute("prop");
  ^



An error occurred at line: 19 in the jsp f


The following is the jsp page


<%@ taglib uri="/test" prefix="test" %>

<%
int i = 0;
{
%>


Message 1: <%= Message %>
<%= prop.getProperty("one") %>

<%
}

{
%>


Message 2: <%= Message %>
<%= prop.getProperty("two") %>
<%
}
%>


I can send you a zip file containing the entire web application so that you can
check this out.

Can you please let me know, since this is a serious regression according to me.


Thanks,


Roshan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [5.0] Removing session recycling code

[Bill Barker]

- Original Message -
From: "Remy Maucherat" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Monday, July 07, 2003 2:54 PM
Subject: [5.0] Removing session recycling code


> Hi,
>
> I'd like to completely remove session recycling code from TC 5, as it is
> a potentially dangerous feature (which has been disabled in TC 4.1.x)
> and does not bring any actual performance improvement while using memory.
> The biggest impact of the change is the removal of the recycled array
> list for base manager, which can break existing TC 4 managers. OTOH,
> using that is unsafe, and fixing an affected manager is very easy (just
> remove whatever recylcling code was used).
>
> I plan to keep Session.recycle around (nulling out references can help
> GC, esp since there could be a lot of session objects - with all their
> children - waiting to be GCed).
>
> Comments ?

Having put so much work into getting the session recycling code working in
3.3, I'm +1 for not seeing that headache again ;-).


>
> Remy
>
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication in 
error, please notify us immediately by e-mail and then delete all copies of this 
message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through the 
Internet is not secure. Do not send confidential or sensitive information, such as 
social security numbers, account numbers, personal identification numbers and 
passwords, to us via ordinary (unencrypted) e-mail.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: [5.0] Removing session recycling code

[kev]

I'd like to completely remove session recycling code from TC 5, as it 
is a potentially dangerous feature (which has been disabled in TC 
4.1.x) and does not bring any actual performance improvement while 
using memory.
The biggest impact of the change is the removal of the recycled array 
list for base manager, which can break existing TC 4 managers. OTOH, 
using that is unsafe, and fixing an affected manager is very easy 
(just remove whatever recylcling code was used).

I plan to keep Session.recycle around (nulling out references can help 
GC, esp since there could be a lot of session objects - with all their 
children - waiting to be GCed).

Comments ?
If it can't be used safely at all my gut instinct would be to remove it 
to prevent something from blowing up in peoples faces.  It also sounds 
like a "performance enhancement" which has gone wrong, so it's a prime 
candidate for removal in my opinion. (But then what do I know :)

erm +1 is it?

Kev

--
"To be governed is to be watched over, inspected, spied on, directed, 
legislated..." - Pierre-Joseph Proudhon

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[5.0] Removing session recycling code

[Remy Maucherat]

Hi,

I'd like to completely remove session recycling code from TC 5, as it is 
a potentially dangerous feature (which has been disabled in TC 4.1.x) 
and does not bring any actual performance improvement while using memory.
The biggest impact of the change is the removal of the recycled array 
list for base manager, which can break existing TC 4 managers. OTOH, 
using that is unsafe, and fixing an affected manager is very easy (just 
remove whatever recylcling code was used).

I plan to keep Session.recycle around (nulling out references can help 
GC, esp since there could be a lot of session objects - with all their 
children - waiting to be GCed).

Comments ?

Remy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21369] - Problem with WAR containing JARS

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21369

Problem with WAR containing JARS





--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 20:08 ---
You should get that from CVS (sorry). I'll do a quick test anyway, just to be sure.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Software caused connection abort

[Eyal Bekerman]

Hello all,

I’m quite desperate.
I’m using Tomcat 4.0.3 on Solaris 2.7 and keep getting the following error in the 
Catalina log file:
HttpConnector[44301] accept: 
java.net.SocketException: Software caused connection abort
at java.net.PlainSocketImpl.socketAccept(Native Method)
at java.net.PlainSocketImpl.accept(PlainSocketImpl.java:343)
at java.net.ServerSocket.implAccept(ServerSocket.java:438)
at java.net.ServerSocket.accept(ServerSocket.java:409)
at org.apache.catalina.connector.http.HttpConnector.run(HttpConnector.java:993)
at java.lang.Thread.run(Thread.java:536)

This happens when the I browse my application using IE and click on several pages 
without waiting for them to finish loading.
I read some posts on this issue but found no answer.

Eyal

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21369] - Problem with WAR containing JARS

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21369

Problem with WAR containing JARS





--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 15:09 ---
Thanks,

is there a nightly available or do I need to grab the CVS bits?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21369] - Problem with WAR containing JARS

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21369

Problem with WAR containing JARS

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 14:51 ---
There is no value in specifying docBase="jsp-ex.war" or even the docBase at all
anymore (no matter what you do, the WAR will be expanded according to
unpackWARs). Remove the setting.
I believe this has been fixed post 5.0.3. See revision 1.16 and 1.17 of HostConfig.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 4091] - custom host with unpackWARs="true" don't expand war automatically - work around fails log4j!

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4091

custom host with unpackWARs="true" don't expand war automatically - work around fails 
log4j!

[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|4.0.1 Beta 1|4.1.24



--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 14:15 ---
in server.xml, removing the lines (where "privalope" could well be replaced "myapp")



solves two problems:
1) the war files get expanded automatically
2) the context path is no longer "null", thus log4j is working again

!!! The remaining problem is now: how to tell tomcat not to use cookies !!!

Further background:
System.out.println("1=" +getServletContext().getRealPath("\\"));
1=C:\tomcat\jakarta-tomcat-4.1.24\bin\..\webapps\privaLope\
...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21369] - Problem with WAR containing JARS

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21369

Problem with WAR containing JARS

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |



--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 14:09 ---
Hmmm,

well it clearly doesn't work for me :)

This is easy to reproduce. 

I took the jsp-examples directory and zipped it up as jsp-ex.zip, then added a
jar to the WEB-INF/lib directory (any non JSP/Servlet related JAR will do). I
renamed the zip calling it jsp-ex.war and copied it into webapps. I then create
a context in conf/catalina/localhost (called jsp-ex.xml which obviously doesn't
matter) which looks like this





notice the docbase is the war file. 

I change nothing else so unpackWars is true and autoDeploy is true. Start tomcat
5.0.3 and I get the TLD exception.

If I remove the context file the war is expanded and works fine.

If I point the docbase at jsp-ex then the war isn't expanded and I get other
errors (I believe this is another bug but war/context management is so unusual I
 wasn't convinced)

This all works OK in 5.0.2

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21369] - Problem with WAR containing JARS

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21369

Problem with WAR containing JARS

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 13:41 ---
I am very sorry, but this clearly work for me. If you think your reports sound
phony, don't worry, I have felt the same for some time ;-)
Please attach a ready to run test case if you'd like to reopen this.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21369] New: - Problem with WAR containing JARS

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21369

Problem with WAR containing JARS

   Summary: Problem with WAR containing JARS
   Product: Tomcat 5
   Version: 5.0.3
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Sorry ahead of time if this is slightly wooly. I have a web app that I deploy in
expanded form to Tomcat 5.0.3 and it works fine. I'm also testing this app using
Cactus, for this I create a WAR file and deploy that. I have a server.xml file
that looks like this




















username
admin


password



driverClassName
com.mysql.jdbc.Driver


url
jdbc:mysql://localhost/TestCourseBlog











And when the app is run I get the following error

 [java] 07-Jul-2003 13:45:06 org.apache.catalina.core.StandardContext start
 [java] SEVERE: Error reading tld listeners
java.lang.IllegalArgumentException: Invalid TLD resource path /WEB-INF/lib/as
pectjrt-1.0.5.jar
 [java] java.lang.IllegalArgumentException: Invalid TLD resource path
/WEB-INF/lib/aspectjrt-1.0.5.jar
 [java] at
org.apache.catalina.startup.TldConfig.tldScanJar(TldConfig.java:442)
 [java] at org.apache.catalina.startup.TldConfig.execute(TldConfig.java:228)
 [java] at
org.apache.catalina.core.StandardContext.start(StandardContext.java:4037)
 [java] at
org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1127)
 [java] at
org.apache.catalina.core.StandardHost.start(StandardHost.java:795)
 [java] at
org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1127)
 [java] at
org.apache.catalina.core.StandardEngine.start(StandardEngine.java:502)
 [java] at
org.apache.catalina.core.StandardService.start(StandardService.java:519)
 [java] at
org.apache.catalina.core.StandardServer.start(StandardServer.java:2312)
 [java] at org.apache.catalina.startup.Catalina.start(Catalina.java:577)
 [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 [java] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 [java] at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 [java] at java.lang.reflect.Method.invoke(Method.java:324)
 [java] at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:297)
 [java] at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:394)

where aspectjrt-1.0.5.jar is the first jar in the jar file.

If I expand the app and run it it is fine so the aspectj JAR file is not the
issue. If I run this under 5.0.2 then it works fine so it looks like 5.0.3 is
mistaking this JAR as a TLD listener.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 16877] - Null pointer exception when misspelling attribute name in server.xml .

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16877

Null pointer exception when misspelling attribute name in server.xml .





--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 11:48 ---
The above attached fix addresses the situation when path or docBase have not 
been specified for Context. 

To have a generic fix, such attributes could be made #REQUIRED in the schema 
for this xml doc and calling setValidating(true) for the digester.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 16877] - Null pointer exception when misspelling attribute name in server.xml .

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16877

Null pointer exception when misspelling attribute name in server.xml .





--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 11:34 ---
Created an attachment (id=7120)
Null check has been introduced for Context.path & Context.docBase - Fix in 
ContextRuleSet.java

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 20376] - Internet Explorer 6.0 Duplicate Requests IE PLEASE HELP

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20376

Internet Explorer 6.0 Duplicate Requests IE PLEASE HELP





--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 11:17 ---
Hi! (Sorry for the long delay)

I'm sorry, but I can't send you an example: it is in our product, which is a 
web based management system. There is one page which always produces the fault. 
I tried to extract it, but when it is not used in the frameset, the error 
doesn't occur?!?!

To your question: The webservers read up to the reported content length. The IE
SOMETIMES(!) adds a CRLF that does not contribute to that length. Depending on 
request length, buffers, and maybe the network the IE considers that data as 
sent or not. If not, it complains about a response (and sends the request a 
second time).

I had problems again, since I used a plain InputStream and trying to read the 2 
unreported characters (CRLF) hanged up my application, since sometimes they are 
not there. So what I do now, i that I create a buffer of +2 bytes 
size and do a read with that array. If the characters are there, they are read, 
if not, I see it in the return value of my read. But I did that in my web 
server. If you use Tomcat, then you don't have direct control over that part. 
But what if you use the ServletInputStream to parse the post data yourself? 
This might work in Servlets, but in JSPs it might be tricky.

I don't know the O'Reilly package so I can't help you on that.

So my suggestion would be that you try a read (with timeout!) on the 
InputStream if you can get access and consume the left bytes.

Jürgen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 4091] - custom host with unpackWARs="true" don't expand war automatically - work around fails log4j!

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4091

custom host with unpackWARs="true" don't expand war automatically - work around fails 
log4j!

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
URL||http://nagoya.apache.org/bug
   ||zilla/show_bug.cgi?id=21367



--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 10:54 ---
see also the corresponding log4j bug we posted
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21367

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[GUMP] Build timed out - jk

[Craig McClanahan]

This email is autogenerated from the output from:



Buildfile: build.xml

init:
 [echo] /home/rubys
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk
 [echo] linux=true solaris=${solaris} win32=${win32} hpux=${hpux} 
netware=${netware}

apache20:

apache13:

iis:

netscape:

jni:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-connectors/jk/build/jk/jni
   [so] Compiling 4 out of 4
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_map.c
Compiling /home/rubys/jakarta/jakarta-tomcat-connectors/jk/native/common/jk_pool.c
/home/rubys/bin/timeout: timed out

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[GUMP] Build Failure - jakarta-tomcat-5

[bobh]

This email is autogenerated from the output from:



Buildfile: build.xml

prepare-release:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/release
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/release/v5.0
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/release/v5.0/bin
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/release/v5.0/src

init:
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/build
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/build/classes
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/build/server/lib
[mkdir] Created dir: /home/rubys/jakarta/jakarta-tomcat-5/build/common/lib

deploy-static:
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat-5/build/common/lib
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat-5/build/common/lib
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat-5/build/common/lib
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat-5/build/common/lib
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat-5/build/common/lib
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat-5/build/common/lib
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat-5/build/server/lib
 [copy] Copying 1 file to /home/rubys/jakarta/jakarta-tomcat-5/build/server/lib

BUILD FAILED
/home/rubys/jakarta/jakarta-tomcat-5/build.xml:156: Warning: Could not find file 
/usr/local/commons-daemon/bin/jsvc.tar.gz to copy.

Total time: 4 seconds

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 21366] New: - A minor JSP-Servlet translation bug

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21366

A minor JSP-Servlet translation bug

   Summary: A minor JSP-Servlet translation bug
   Product: Tomcat 4
   Version: 4.1.24
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Servlet & JSP API
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


When I write a snippet in a JSP document (XML syntax) like this:

---
(some code)
...

  

...
(some foot code)
---

The JSP-Servlet translation converts that code into this:

---
//Here we go   String foo = "foo";  String bar = "bar";
---

So, as it converts the scriptlet into one line, when it gets compiled, the rest
of the code after comment will get commented too.

Note that using 'CDATA' is optional, when you use '<' or '&' characters. You can
omit CDATA when you are not using special characters. So this is not the reason.

When I transform the JSP Document wroten in XML syntax to JSP syntax, it works
properly.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18467] - Incorrect timezone value in access logs

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18467

Incorrect timezone value in access logs





--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 09:15 ---
Firstly.  The original bug report has an error.

The example log line should be + 2 hours.  Not + 20.  Two problems in fact.  One
is the missing +, and the other is the added 0 in the wrong place.  

It should be

127.0.0.1 - - [28/Mar/2003:11:21:46 +0200] "POST /myservlet HTTP/1.1" 200 -

The original code obviously assumes noone runs webservers east of Greenwich. :)

Also using DateFormat would include daylight savings, and possibly convert to a
three letter string e.g. EST, EET, CST etc

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 19965] - mod_jk2 connection fails, "workerEnv.init() create slot epStat.0 failed"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19965

mod_jk2 connection fails, "workerEnv.init() create slot epStat.0 failed"





--- Additional Comments From [EMAIL PROTECTED]  2003-07-07 08:51 ---
I don't weather this is related but I did a similiar setup ie apache 
communication with JBOSS/Tomcat (default configuartaion). I didn't specify any 
shared file. The configuration worked but on loading an Internal Sever error 
occured. Once I've put the shm file in place thsi error did not occur any 
more

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]