Re: SVN::GetRootAndHead
onsdag 1 maj 2024 kl. 11:29:44 UTC+2 skrev Daniel Sahlberg:
Den mån 29 apr. 2024 kl 19:28 skrev Stefan via TortoiseSVN-dev <
tortois...@googlegroups.com>:
would it work if we do both?
rev = cachedProperties.GetHeadRevision(uuid, path);
if ((rev == NO_REVISION) || (m_err != nullptr))
{
svn_error_clear(m_err);
rev = cachedProperties.GetHeadRevision(uuid, url);
}
I don't have a setup ready to test this. At least it would be better than
before:
- if the path doesn't exist anymore, we try again with the root
- if root works, fine
- if root doesn't work either, it's no worse than before
Stefan
Agree with you that it's no worse than before. It seems to work in my
testing. I've committed as r29691.
I've also asked on the subversion dev@ mailing list.
Kind regards,
Daniel
Turned out to be my fault altogether, based in r29499. I've reverted
everything and will circle back to the original project monitor issue.
--
You received this message because you are subscribed to the Google Groups
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/tortoisesvn-dev/d821caf4-bf68-40f1-b6ac-6e1808ef42c3n%40googlegroups.com.
Re: SVN::GetRootAndHead
Den mån 29 apr. 2024 kl 19:28 skrev Stefan via TortoiseSVN-dev <
tortoisesvn-dev@googlegroups.com>:
> would it work if we do both?
>
> rev = cachedProperties.GetHeadRevision(uuid, path);
> if ((rev == NO_REVISION) || (m_err != nullptr))
> {
> svn_error_clear(m_err);
> rev = cachedProperties.GetHeadRevision(uuid, url);
> }
> I don't have a setup ready to test this. At least it would be better than
> before:
> - if the path doesn't exist anymore, we try again with the root
> - if root works, fine
> - if root doesn't work either, it's no worse than before
>
> Stefan
>
>
Agree with you that it's no worse than before. It seems to work in my
testing. I've committed as r29691.
I've also asked on the subversion dev@ mailing list.
Kind regards,
Daniel
--
You received this message because you are subscribed to the Google Groups
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/tortoisesvn-dev/CAMHy98OpkNREhjqyd4yfiY8NtM-H0Gye9FqFzc4kJ4f33v7mBg%40mail.gmail.com.
Re: SVN::GetRootAndHead
would it work if we do both?
rev = cachedProperties.GetHeadRevision(uuid, path);
if ((rev == NO_REVISION) || (m_err != nullptr))
{
svn_error_clear(m_err);
rev = cachedProperties.GetHeadRevision(uuid, url);
}
I don't have a setup ready to test this. At least it would be better than
before:
- if the path doesn't exist anymore, we try again with the root
- if root works, fine
- if root doesn't work either, it's no worse than before
Stefan
--
You received this message because you are subscribed to the Google Groups
"TortoiseSVN-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to tortoisesvn-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/tortoisesvn-dev/f0a0e607-cecc-45ac-94b5-0e3bd5a07946n%40googlegroups.com.
Re: SVN::GetRootAndHead
So. That didn't turn out well at all (https://groups.google.com/g/tortoisesvn/c/IJuG6WvHTds). I've successfully reproduced the error. Some quick debugging indicate that svn_client_open_ra_session2() now barf if the user doesn't have read access to the repository root. I've reproduced this using VisualSVN Server (it has an "implicit list folder permissions for parents of readable paths" that has to be disabled). I didn't dig all the way down to the server but I'm quite sure the server is returning a 403 on the root but a valid return code on the actual subdirectory. I'm a bit at loss what to do here since we send the URL when establishing the ra session. If the URL doesn't exist anymore, we get an error. If we send in the root, we get another error. Any ideas? Kind regards, Daniel söndag 10 mars 2024 kl. 09:16:48 UTC+1 skrev Daniel Sahlberg: > Thanks! Committed in r29682 > > lördag 9 mars 2024 kl. 21:11:08 UTC+1 skrev Stefan: > >> no objections from me. >> The revision for the repo root is the same as for the path, but of course >> works for non-existing paths as well since the root is never deleted. >> >> -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tortoisesvn-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/493f39bf-e45c-4c61-87f6-dd692a0174a5n%40googlegroups.com.
Re: SVN::GetRootAndHead
Thanks! Committed in r29682 lördag 9 mars 2024 kl. 21:11:08 UTC+1 skrev Stefan: > no objections from me. > The revision for the repo root is the same as for the path, but of course > works for non-existing paths as well since the root is never deleted. > > -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tortoisesvn-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/8aecee7a-1133-4bd4-968e-cc2038796a4fn%40googlegroups.com.
Re: SVN::GetRootAndHead
no objections from me. The revision for the repo root is the same as for the path, but of course works for non-existing paths as well since the root is never deleted. -- You received this message because you are subscribed to the Google Groups "TortoiseSVN-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tortoisesvn-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tortoisesvn-dev/d94c2d4b-aaba-43fa-8731-4aa9a52f3cfdn%40googlegroups.com.
