Re: [Twisted-Python] porting twisted.spread to Python3

[Kevin Horn]

On Sun, Oct 5, 2014 at 2:58 PM,  wrote:

> On 04:23 pm, wolfgang@rohdewald.de wrote:
>
>>
>> BTW what about Ticket 7628, news extension "port"? I could soon start
>> feeding porting tickets but if this extension is useful, I guess it
>> should be applied first.
>>
>
> Looks like Kevin is working on it.  I'll review it when it comes up


Apologies.  I got sidetracked preparing for PyTexas (which was last
weekend).  I'll try to get back to it ASAP.
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] Boston Area Twisted Sprint

[exarkun]

Hello all,

I'm happy to invite you to a Twisted sprint on Saturday, November 1st
in Cambridge, Massachusetts.  ClusterHQ will be hosting up to twenty
(20) Twisted sprinters at the Cambridge Innovation Center ("Coronet
City" room) in Kendall Square from 10AM until 11PM.  The sprint topics
are attendee choice - hacking on any part of Twisted is welcome.  A
large part of the ClusterHQ team will be taking part in the sprint.

ClusterHQ is developing Flocker, a data management tool for use with
Docker written in Python and based on Twisted.  Follow us on Github:

   https://github.com/clusterhq/flocker

ClusterHQ will provide lunch and dinner (something like delivery
pizza, comment on the meetup page if you'd like to suggest
something!).

Find details and chat about sprint topics at the Boston Twisted Python
meetup page:

   http://www.meetup.com/Boston-Twisted-Python/

Early birds, feel free to contact me off-list about meeting up for 
coffee at

around 9AM before the sprint starts.

Space at CIC is limited.  Please RSVP on the Meetup page!

See you there,
Jean-Paul

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] a review to speed up other reviews?

[Jonathan Lange]

On Wed Oct 08 2014 at 7:54:57 PM Glyph Lefkowitz 
wrote:

>
> On Oct 8, 2014, at 11:50 AM, Jonathan Lange  wrote:
>
> Comments are on the ticket:
> https://twistedmatrix.com/trac/ticket/7633#comment:14. I forgot to
> reassign when I did the review earlier today.
>
>
> ...
>


> It *looks* like a "address these minor issues and merge" review, but
> given that you said you didn't have time to look at certain things, I don't
> want to make any assumptions.
>
>
Done. Thanks for the reminders.

jml
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] a review to speed up other reviews?

[Glyph Lefkowitz]

On Oct 8, 2014, at 11:50 AM, Jonathan Lange  wrote:

> Comments are on the ticket: 
> https://twistedmatrix.com/trac/ticket/7633#comment:14. I forgot to reassign 
> when I did the review earlier today.

Thanks again.

If that was intended to be a full review though, you did leave out one 
important step:

As documented in 
,

When you're done with the review, always say what the next step should be: for 
example, if the author is a committer, can they commit after making a few minor 
fixes? If your review feedback is more substantial, should they re-submit for 
another review?

It looks like a "address these minor issues and merge" review, but given that 
you said you didn't have time to look at certain things, I don't want to make 
any assumptions.

-g___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] a review to speed up other reviews?

[Jonathan Lange]

Comments are on the ticket:
https://twistedmatrix.com/trac/ticket/7633#comment:14. I forgot to reassign
when I did the review earlier today.

On Wed Oct 08 2014 at 7:37:38 PM Glyph Lefkowitz 
wrote:

> On Oct 8, 2014, at 2:13 AM, Jonathan Lange  wrote:
>
> > Done. Not reviewed for style guide compliance, and I haven't run it
> locally or on the build slaves. Hope this helps.
>
> Thanks very much for having a look at this!  I'll address the feedback.
>
> You shouldn't need to review for style-guide compliance, as that's the
> twistedchecker buildbot's job.  Which, I should mention, is green on the
> branch :).
>
> Also, I already ran the buildbots.  You can quickly investigate their
> results by looking at the "buildbot" link in the "branch" field of the
> ticket description.
>
> Armed with these two additional pieces of information, would you be
> willing to turn this comment into a passing review? ;-)
>
> -glyph
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] a review to speed up other reviews?

[Glyph Lefkowitz]

On Oct 8, 2014, at 2:13 AM, Jonathan Lange  wrote:

> Done. Not reviewed for style guide compliance, and I haven't run it locally 
> or on the build slaves. Hope this helps.

Thanks very much for having a look at this!  I'll address the feedback.

You shouldn't need to review for style-guide compliance, as that's the 
twistedchecker buildbot's job.  Which, I should mention, is green on the branch 
:).

Also, I already ran the buildbots.  You can quickly investigate their results 
by looking at the "buildbot" link in the "branch" field of the ticket 
description.

Armed with these two additional pieces of information, would you be willing to 
turn this comment into a passing review? ;-)

-glyph
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] a review to speed up other reviews?

[Jonathan Lange]

Done. Not reviewed for style guide compliance, and I haven't run it locally
or on the build slaves. Hope this helps.

On Wed Oct 08 2014 at 8:32:59 AM Glyph  wrote:

>  is keeping one of the
> buildbots persistently red.  It's in review.  There's some discussion on
> the ticket,
>
> If anyone has some free time to review it, this would make other
> code-reviews go just a little bit faster, since reviewers wouldn't need to
> keep looking at the logs for that builder to make sure that the failures
> are the "expected" ones; all the builders should be consistently green
> except for the pesky windows XP one.
>
> -glyph
>
> ___
> Twisted-Python mailing list
> Twisted-Python@twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

[Twisted-Python] a review to speed up other reviews?

[Glyph]

 is keeping one of the buildbots 
persistently red.  It's in review.  There's some discussion on the ticket, 

If anyone has some free time to review it, this would make other code-reviews 
go just a little bit faster, since reviewers wouldn't need to keep looking at 
the logs for that builder to make sure that the failures are the "expected" 
ones; all the builders should be consistently green except for the pesky 
windows XP one.

-glyph

___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python

Re: [Twisted-Python] naming question before we end up committed...

[Glyph]

On Sep 28, 2014, at 8:36 AM, Chris  wrote:

> +1 for twisted.logger.

Since everyone seemed to agree, this is now in review: 
.

-glyph


___
Twisted-Python mailing list
Twisted-Python@twistedmatrix.com
http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python