Re: [U-Boot] Is the Numonyx's M29W128 fully supported in U-Boot?
Hi all,
This is a patch to fix the NUMONYX's M29W128GL cfi detection bug in my
Lite5200B based custom board. I thing I's only a starting point for a
more formal patch valid for any kind of architecture (big and little
endian) and flash layout (I've only check it in a 16x portwitdh 8x
chipwitch).
I'm not a CFI flash expert and any feedback about this issue will be
welcomed.
TIA,
--- cfi_flash_old.c 2009-12-09 18:25:44.0 +0100
+++ cfi_flash_new.c 2009-12-17 10:28:00.0 +0100
@@ -214,6 +214,10 @@ static void flash_make_cmd(flash_info_t
val = *((uchar*)cmd + sizeof(u32) - cword_offset - 1);
#endif
cp[cp_offset] = (cword_offset = sizeof(u32)) ? 0x00 : val;
+ if(info-cfi_fixup CFI_NUMONYX_FIXUP) {
+ if(cp_offset 1)
+ cp[cp_offset] = 0x00;
+ }
}
}
@@ -266,7 +270,10 @@ static inline uchar flash_read_uchar (fl
#if defined(__LITTLE_ENDIAN) || defined(CONFIG_SYS_WRITE_SWAPPED_DATA)
retval = flash_read8(cp);
#else
- retval = flash_read8(cp + info-portwidth - 1);
+ if(info-cfi_fixup CFI_NUMONYX_FIXUP)
+ retval = flash_read8(cp);
+ else
+ retval = flash_read8(cp + info-portwidth - 1);
#endif
flash_unmap (info, 0, offset, cp);
return retval;
@@ -1420,7 +1427,12 @@ static void cmdset_amd_read_jedec_ids(fl
{
ushort bankId = 0;
uchar manuId;
+ uchar portwidth;
+ portwidth = info-portwidth;
+ if(info-chipwidth == FLASH_CFI_8BIT)
+ info-portwidth = FLASH_CFI_8BIT;
+
flash_write_cmd(info, 0, 0, AMD_CMD_RESET);
flash_unlock_seq(info, 0);
flash_write_cmd(info, 0, info-addr_unlock1, FLASH_CMD_READ_ID);
@@ -1438,14 +1450,14 @@ static void cmdset_amd_read_jedec_ids(fl
switch (info-chipwidth){
case FLASH_CFI_8BIT:
info-device_id = flash_read_uchar (info,
- FLASH_OFFSET_DEVICE_ID);
+ FLASH_OFFSET_DEVICE_ID *
portwidth);
if (info-device_id == 0x7E) {
/* AMD 3-byte (expanded) device ids */
info-device_id2 = flash_read_uchar (info,
- FLASH_OFFSET_DEVICE_ID2);
+ FLASH_OFFSET_DEVICE_ID2 *
portwidth);
info-device_id2 = 8;
info-device_id2 |= flash_read_uchar (info,
- FLASH_OFFSET_DEVICE_ID3);
+ FLASH_OFFSET_DEVICE_ID3 *
portwidth);
}
break;
case FLASH_CFI_16BIT:
@@ -1456,6 +1468,9 @@ static void cmdset_amd_read_jedec_ids(fl
break;
}
flash_write_cmd(info, 0, 0, AMD_CMD_RESET);
+
+ info-portwidth = portwidth;
+
}
static int cmdset_amd_init(flash_info_t *info, struct cfi_qry *qry)
@@ -1582,6 +1597,10 @@ void __flash_cmd_reset(flash_info_t *inf
* that AMD flash roms ignore the Intel command.
*/
flash_write_cmd(info, 0, 0, AMD_CMD_RESET);
+
+ if(info-cfi_fixup CFI_NUMONYX_FIXUP)
+ return;
+
flash_write_cmd(info, 0, 0, FLASH_CMD_RESET);
}
void flash_cmd_reset(flash_info_t *info)
@@ -1646,6 +1665,12 @@ static int flash_detect_cfi (flash_info_
{
debug (flash detect cfi\n);
+ info-cfi_fixup = 0;
+
+#ifdef CONFIG_FLASH_NUMONYX_FIXUP
+ info-cfi_fixup = CFI_NUMONYX_FIXUP;
+#endif
+
for (info-portwidth = CONFIG_SYS_FLASH_CFI_WIDTH;
info-portwidth = FLASH_CFI_64BIT; info-portwidth = 1) {
for (info-chipwidth = FLASH_CFI_BY8;
--- flash_old.h 2009-12-10 12:25:41.0 +0100
+++ flash_new.h 2009-12-17 10:26:55.0 +0100
@@ -55,6 +55,7 @@ typedef struct {
ulong addr_unlock1; /* unlock address 1 for AMD flash roms
*/
ulong addr_unlock2; /* unlock address 2 for AMD flash roms
*/
const char *name; /* human-readable name
*/
+ ucharcfi_fixup;
#endif
} flash_info_t;
@@ -87,6 +88,9 @@ typedef unsigned long flash_sect_t;
/* convert between bit value and numeric value */
#define CFI_FLASH_SHIFT_WIDTH 3
+
+#define CFI_NUMONYX_FIXUP 0x01
+
/* Prototypes */
extern unsigned long flash_init (void);
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] TI: DaVinci: Updating EMAC driver for DM365, DM646x and DA8XX
On 16/12/09 22:00, Wolfgang Denk wrote:
Dear Nick Thompson,
In message 4b2770f8.5090...@ge.com you wrote:
The EMAC IP on DM365, DM646x and DA830 is slightly different
from that on DM644x. This change updates the DaVinci EMAC driver
so that EMAC becomes operational on SOCs with EMAC v2.
Signed-off-by: Nick Thompson nick.thomp...@ge.com
Signed-off-by: Sandeep Paulraj s-paul...@ti.com
---
Applies to: u-boot-ti
This is a combined patch with Sandeep's DM365 and DM646x changes
and additional changes for DA830. It replaces previous submissions
for EMAC support on these devices.
drivers/net/davinci_emac.c | 131
-
include/asm-arm/arch-davinci/emac_defs.h | 60 +-
2 files changed, 164 insertions(+), 27 deletions(-)
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index fa8cee4..dbf94d2 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -42,6 +42,7 @@
#include miiphy.h
#include malloc.h
#include asm/arch/emac_defs.h
+#include asm/io.h
unsigned intemac_dbg = 0;
#define debug_emac(fmt,args...) if (emac_dbg) printf(fmt,##args)
@@ -107,6 +108,35 @@ static void davinci_eth_mdio_enable(void)
while (adap_mdio-CONTROL MDIO_CONTROL_IDLE) {;}
Please fix this as well while we are here. Please make this:
while (adap_mdio-CONTROL MDIO_CONTROL_IDLE)
;
Yes, will do, here and elsewhere in the file. I will also change
all these cases to use readl().
+/* Wait for command to complete */
+while (readl(adap_mdio-USERACCESS0) MDIO_USERACCESS0_GO);
Please make this:
while (readl(adap_mdio-USERACCESS0) MDIO_USERACCESS0_GO)
;
Done.
+static void emac_gigabit_enable(void)
+{
+#ifdef DAVINCI_EMAC_GIG_ENABLE
+int temp
+
+if (mdio_read(EMAC_MDIO_PHY_NUM, 0) (1 6)) {
+/*
+ * Check if link detected is giga-bit
+ * If Gigabit mode detected, enable gigbit in MAC and PHY
+ */
+writel(EMAC_MACCONTROL_GIGFORCE |
+ EMAC_MACCONTROL_GIGABIT_ENABLE,
+ adap_emac-MACCONTROL);
+
+/*
+ * The SYS_CLK which feeds the SOC for giga-bit operation
+ * does not seem to be enabled after reset as expected.
+ * Force enabling SYS_CLK by writing to the PHY
+ */
+temp = mdio_read(EMAC_MDIO_PHY_NUM, 22);
+temp |= (1 4);
+mdio_write(EMAC_MDIO_PHY_NUM, 22, temp);
+}
+#endif
+}
Can we - instead of providing an empty function when
DAVINCI_EMAC_GIG_ENABLE is not set - either omit this function
completely, or use a weak implementation instead?
I don't want to use weak as it implies the function maybe replaced. This is
not the intention here. To avoid ifdefs all over the place I have added:
#ifdef DAVINCI_EMAC_GIG_ENABLE
#define mdio_gigabit_detect(phy)(mdio_read(phy, 0) (1 6))
#else
#define mdio_gigabit_detect(phy)0
#endif
and changed the if in the above function to:
if (mdio_gigabit_detect(EMAC_MDIO_PHY_NUM)) {
int temp;
...
The function is always present, but optimised away if there is a 0 method for
detecting gigabit in the phy. Is that acceptable?
if (!phy.get_link_speed(active_phy_addr))
return(0);
+else
+emac_gigabit_enable();
No else is needed here. Remove it, and un-indent the
emac_gigabit_enable() call.
Ahh yes - removed in all three cases.
I will submit a new patch tomorrow.
Thanks,
Nick.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] TI: DaVinci: Updating EMAC dri ver for DM365, DM646x and DA8XX
Nick Thompson nick.thompson at ge.com writes:
+/* Write to a PHY register via MDIO inteface */
+void mdio_write(int phy_addr, int reg_num, unsigned int data)
+{
+ /* Wait for User access register to be ready */
+ while (readl(adap_mdio-USERACCESS0) MDIO_USERACCESS0_GO);
+
Arent these functions duplicating functionality in davinci_eth_phy_write() and
davinci_eth_phy_read()? Is the intent here to move from accessing registers
as overlay to using writel/readl functions. If so, we need to get rid of one
of these implementations
+static void emac_gigabit_enable(void)
+{
+#ifdef DAVINCI_EMAC_GIG_ENABLE
+ int temp
+
+ if (mdio_read(EMAC_MDIO_PHY_NUM, 0) (1 6)) {
+ /*
+ * Check if link detected is giga-bit
+ * If Gigabit mode detected, enable gigbit in MAC and PHY
+ */
+ writel(EMAC_MACCONTROL_GIGFORCE |
+EMAC_MACCONTROL_GIGABIT_ENABLE,
+adap_emac-MACCONTROL);
+
+ /*
+ * The SYS_CLK which feeds the SOC for giga-bit operation
+ * does not seem to be enabled after reset as expected.
+ * Force enabling SYS_CLK by writing to the PHY
+ */
+ temp = mdio_read(EMAC_MDIO_PHY_NUM, 22);
+ temp |= (1 4);
+ mdio_write(EMAC_MDIO_PHY_NUM, 22, temp);
+ }
+#endif
+}
PHY register 22 is vendor specific(specific to a PHY) and the same PHY need
not be Used on all platforms which use this driver. Also, can this not be done
once during initialization alone?
+#if defined(DAVINCI_EMAC_VERSION2)
+ writel(1, adap_ewrap-softrst);
+ while (readl(adap_ewrap-softrst) != 0);
+#else
adap_ewrap-EWCTL = 0;
for (cnt = 0; cnt 5; cnt++) {
clkdiv = adap_ewrap-EWCTL;
}
+#endif
Again some registers are accessed through overlays and some are accessed
through readl/writel(). Should we make this consistent? Also the register
names use CAPs in some instances and not for others - is this intentional?
/* Init MDIO get link state */
clkdiv = (EMAC_MDIO_BUS_FREQ / EMAC_MDIO_CLOCK_FREQ) - 1;
adap_mdio-CONTROL = ((clkdiv 0xff) | MDIO_CONTROL_ENABLE |
MDIO_CONTROL_FAULT);
+#if defined(DAVINCI_EMAC_VERSION2)
+ /* We need to wait for MDIO to start */
+ udelay(1000);
+#endif
+
The controller doesnt specify/expect a delay for EMAC version2. How is the
delay specific to EMAC version2?
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Invitation to connect on LinkedIn
LinkedIn Baojun Wang requested to add you as a connection on LinkedIn: -- Srinath, I'd like to add you to my professional network on LinkedIn. - Baojun Accept invitation from Baojun Wang http://www.linkedin.com/e/YhLefj14Y3m-0E8v1ZCDgtixJP5Kn9_7/blk/I1667137373_2/pmpxnSRJrSdvj4R5fnhv9ClRsDgZp6lQs6lzoQ5AomZIpn8_cBYPdPcTcP4TdzoNiiZxoCR8iCFPuiYUd3oMdz0TcPALrCBxbOYWrSlI/EML_comm_afe/ View invitation from Baojun Wang http://www.linkedin.com/e/YhLefj14Y3m-0E8v1ZCDgtixJP5Kn9_7/blk/I1667137373_2/39vcPsPdPcNdPoSckALqnpPbOYWrSlI/svi/ -- DID YOU KNOW you can be the first to know when a trusted member of your network changes jobs? With Network Updates on your LinkedIn home page, you'll be notified as members of your network change their current position. Be the first to know and reach out! http://www.linkedin.com/ -- (c) 2009, LinkedIn Corporation ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Add misc_init_r support to AVR32
misc_init_r is available in most other platforms and can be used in board initialization code for late stage stuff. Signed-off-by: Semih Hazar semih.ha...@indefia.com --- lib_avr32/board.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/lib_avr32/board.c b/lib_avr32/board.c index 57115df..7459e21 100644 --- a/lib_avr32/board.c +++ b/lib_avr32/board.c @@ -354,6 +354,11 @@ void board_init_r(gd_t *new_gd, ulong dest_addr) jumptable_init(); console_init_r(); +#if defined(CONFIG_MISC_INIT_R) + /* miscellaneous platform dependent initialisations */ + misc_init_r(); +#endif + s = getenv(loadaddr); if (s) load_addr = simple_strtoul(s, NULL, 16); -- 1.5.4.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] macb: Fix mii_phy_read and mii_phy_write functions
Enabling CONFIG_CMD_MII in AVR32 boards was not possible due to
compile errors.
This patch fixes miiphy_read and miiphy_write functions and
registers them properly.
Signed-off-by: Semih Hazar semih.ha...@indefia.com
---
drivers/net/macb.c | 110 +++
1 files changed, 33 insertions(+), 77 deletions(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 6de0a04..c74bee5 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -42,6 +42,7 @@
#include net.h
#include netdev.h
#include malloc.h
+#include miiphy.h
#include linux/mii.h
#include asm/io.h
@@ -164,6 +165,36 @@ static u16 macb_mdio_read(struct macb_device *macb, u8 reg)
return MACB_BFEXT(DATA, frame);
}
+#if defined(CONFIG_CMD_MII)
+
+int macb_miiphy_read(char *devname, u8 phy_adr, u8 reg, u16 *value)
+{
+ struct eth_device *dev = eth_get_dev_by_name(devname);
+ struct macb_device *macb = to_macb(dev);
+
+ if ( macb-phy_addr != phy_adr )
+ return -1;
+
+ *value = macb_mdio_read(macb, reg);
+
+ return 0;
+}
+
+int macb_miiphy_write(char *devname, u8 phy_adr, u8 reg, u16 value)
+{
+ struct eth_device *dev = eth_get_dev_by_name(devname);
+ struct macb_device *macb = to_macb(dev);
+
+ if ( macb-phy_addr != phy_adr )
+ return -1;
+
+ macb_mdio_write(macb, reg, value);
+
+ return 0;
+}
+#endif
+
+
#if defined(CONFIG_CMD_NET)
static int macb_send(struct eth_device *netdev, volatile void *packet,
@@ -540,84 +571,9 @@ int macb_eth_initialize(int id, void *regs, unsigned int
phy_addr)
eth_register(netdev);
- return 0;
-}
-
-#endif
-
#if defined(CONFIG_CMD_MII)
-
-int miiphy_read(unsigned char addr, unsigned char reg, unsigned short *value)
-{
- unsigned long netctl;
- unsigned long netstat;
- unsigned long frame;
- int iflag;
-
- iflag = disable_interrupts();
- netctl = macb_readl(macb, EMACB_NCR);
- netctl |= MACB_BIT(MPE);
- macb_writel(macb, EMACB_NCR, netctl);
- if (iflag)
- enable_interrupts();
-
- frame = (MACB_BF(SOF, 1)
-| MACB_BF(RW, 2)
-| MACB_BF(PHYA, addr)
-| MACB_BF(REGA, reg)
-| MACB_BF(CODE, 2));
- macb_writel(macb, EMACB_MAN, frame);
-
- do {
- netstat = macb_readl(macb, EMACB_NSR);
- } while (!(netstat MACB_BIT(IDLE)));
-
- frame = macb_readl(macb, EMACB_MAN);
- *value = MACB_BFEXT(DATA, frame);
-
- iflag = disable_interrupts();
- netctl = macb_readl(macb, EMACB_NCR);
- netctl = ~MACB_BIT(MPE);
- macb_writel(macb, EMACB_NCR, netctl);
- if (iflag)
- enable_interrupts();
-
- return 0;
-}
-
-int miiphy_write(unsigned char addr, unsigned char reg, unsigned short value)
-{
- unsigned long netctl;
- unsigned long netstat;
- unsigned long frame;
- int iflag;
-
- iflag = disable_interrupts();
- netctl = macb_readl(macb, EMACB_NCR);
- netctl |= MACB_BIT(MPE);
- macb_writel(macb, EMACB_NCR, netctl);
- if (iflag)
- enable_interrupts();
-
- frame = (MACB_BF(SOF, 1)
-| MACB_BF(RW, 1)
-| MACB_BF(PHYA, addr)
-| MACB_BF(REGA, reg)
-| MACB_BF(CODE, 2)
-| MACB_BF(DATA, value));
- macb_writel(macb, EMACB_MAN, frame);
-
- do {
- netstat = macb_readl(macb, EMACB_NSR);
- } while (!(netstat MACB_BIT(IDLE)));
-
- iflag = disable_interrupts();
- netctl = macb_readl(macb, EMACB_NCR);
- netctl = ~MACB_BIT(MPE);
- macb_writel(macb, EMACB_NCR, netctl);
- if (iflag)
- enable_interrupts();
-
+ miiphy_register(netdev-name, macb_miiphy_read, macb_miiphy_write);
+#endif
return 0;
}
--
1.5.4.3
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Remove duplicate #defines in atngw100.h and mimc200.h
Two configuration include files had duplicate CONFIG_DOS_PARTITION definitions with the same value. This patch does not effect anything, just trims unnecessary text. Signed-off-by: Semih Hazar semih.ha...@indefia.com --- include/configs/atngw100.h |2 -- include/configs/mimc200.h |2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/include/configs/atngw100.h b/include/configs/atngw100.h index 4ed5514..5066448 100644 --- a/include/configs/atngw100.h +++ b/include/configs/atngw100.h @@ -101,8 +101,6 @@ #define CONFIG_BOOTP_SUBNETMASK #define CONFIG_BOOTP_GATEWAY -#define CONFIG_DOS_PARTITION 1 - /* * Command line configuration. */ diff --git a/include/configs/mimc200.h b/include/configs/mimc200.h index 8ff2f8a..b2cb206 100644 --- a/include/configs/mimc200.h +++ b/include/configs/mimc200.h @@ -104,8 +104,6 @@ #define CONFIG_BOOTP_SUBNETMASK #define CONFIG_BOOTP_GATEWAY -#define CONFIG_DOS_PARTITION 1 - /* * Command line configuration. */ -- 1.5.4.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Add support for Indefia Nimbus Cloud Board
Nimbus Cloud is an AVR32 based single board computer with 256MiB NAND, 64MiB SDRAM, battery backed RTC, LCD/touch screen support, VGA Output, Ethernet and offers seamless integration with Indefia's Zigbee transceivers. --- CREDITS |4 + MAINTAINERS |4 + MAKEALL |1 + Makefile|3 + board/indefia/nimbuscloud/Makefile | 40 ++ board/indefia/nimbuscloud/config.mk |3 + board/indefia/nimbuscloud/flash.c | 225 +++ board/indefia/nimbuscloud/nimbuscloud.c | 167 +++ board/indefia/nimbuscloud/u-boot.lds| 72 ++ include/configs/nimbuscloud.h | 180 10 files changed, 699 insertions(+), 0 deletions(-) create mode 100644 board/indefia/nimbuscloud/Makefile create mode 100644 board/indefia/nimbuscloud/config.mk create mode 100644 board/indefia/nimbuscloud/flash.c create mode 100644 board/indefia/nimbuscloud/nimbuscloud.c create mode 100644 board/indefia/nimbuscloud/u-boot.lds create mode 100644 include/configs/nimbuscloud.h diff --git a/CREDITS b/CREDITS index 2471029..69a9dde 100644 --- a/CREDITS +++ b/CREDITS @@ -196,6 +196,10 @@ N: Anne-Sophie Harnois E: anne-sophie.harn...@nextream.fr D: Port to Walnut405 board +N: Semih Hazar +E: semih.ha...@indefia.com +D: Nimbus Cloud board support + N: Andreas Heppel E: ahep...@sysgo.de D: CPU Support for MPC 75x; board support for Eltec BAB750 [obsolete!] diff --git a/MAINTAINERS b/MAINTAINERS index 9734b1d..0764ee9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -880,6 +880,10 @@ Hans-Christian Egtvedt hans-christian.egtv...@atmel.com FAVR-32-EZKIT AT32AP7000 +Semih Hazar semih.ha...@indefia.com + + NIMBUSCLOUD AT32AP7000 + Mark Jackson m...@mimc.co.uk MIMC200 AT32AP7000 diff --git a/MAKEALL b/MAKEALL index ab1bb6f..fde90ee 100755 --- a/MAKEALL +++ b/MAKEALL @@ -859,6 +859,7 @@ LIST_avr32=\ favr-32-ezkit \ hammerhead \ mimc200 \ + nimbuscloud \ # diff --git a/Makefile b/Makefile index 536ccb3..ea16786 100644 --- a/Makefile +++ b/Makefile @@ -3595,6 +3595,9 @@ hammerhead_config : unconfig mimc200_config : unconfig @$(MKCONFIG) $(@:_config=) avr32 at32ap mimc200 mimc at32ap700x +nimbuscloud_config : unconfig +@$(MKCONFIG) $(@:_config=) avr32 at32ap nimbuscloud indefia at32ap700x + # # SH3 (SuperH) # diff --git a/board/indefia/nimbuscloud/Makefile b/board/indefia/nimbuscloud/Makefile new file mode 100644 index 000..5ddc351 --- /dev/null +++ b/board/indefia/nimbuscloud/Makefile @@ -0,0 +1,40 @@ +# +# Copyright (C) 2008-2009 Indefia +# +# See file CREDITS for list of people who contributed to this project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA + +include $(TOPDIR)/config.mk + +LIB:= $(obj)lib$(BOARD).a + +COBJS := $(BOARD).o flash.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) + +$(LIB): $(obj).depend $(OBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/indefia/nimbuscloud/config.mk b/board/indefia/nimbuscloud/config.mk new file mode 100644 index 000..9a794e5 --- /dev/null +++ b/board/indefia/nimbuscloud/config.mk @@ -0,0 +1,3 @@ +TEXT_BASE = 0x +PLATFORM_RELFLAGS += -ffunction-sections -fdata-sections +PLATFORM_LDFLAGS += --gc-sections diff --git a/board/indefia/nimbuscloud/flash.c b/board/indefia/nimbuscloud/flash.c new file mode 100644 index 000..04e6974 --- /dev/null +++ b/board/indefia/nimbuscloud/flash.c @@ -0,0 +1,225 @@ +/* + * Copyright (C) 2009 Indefia + * + * Based on work (c) Atmel
[U-Boot] [PATCH] OMAP3EVM: Increase bootargs string length.
Increase the bootargs string length as multiple options (especially for Video settings) are passed to the kernel through bootargs. Also increase the number of args. Signed-off-by: Sriramakrishnan s...@ti.com --- include/configs/omap3_evm.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h index a5514ae..fe7b0e2 100644 --- a/include/configs/omap3_evm.h +++ b/include/configs/omap3_evm.h @@ -200,11 +200,11 @@ #define CONFIG_SYS_HUSH_PARSER /* use hush command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 #define CONFIG_SYS_PROMPT V_PROMPT -#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ +#define CONFIG_SYS_CBSIZE 512 /* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command */ /* args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE(CONFIG_SYS_CBSIZE) -- 1.6.2.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] OMAP3EVM: Increase bootargs string length.
On 17.12.2009 14:29, Sriramakrishnan wrote: Increase the bootargs string length as multiple options (especially for Video settings) are passed to the kernel through bootargs. Also increase the number of args. Signed-off-by: Sriramakrishnans...@ti.com --- include/configs/omap3_evm.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h index a5514ae..fe7b0e2 100644 --- a/include/configs/omap3_evm.h +++ b/include/configs/omap3_evm.h @@ -200,11 +200,11 @@ #define CONFIG_SYS_HUSH_PARSER /* use hush command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 #define CONFIG_SYS_PROMPT V_PROMPT -#define CONFIG_SYS_CBSIZE256 /* Console I/O Buffer Size */ +#define CONFIG_SYS_CBSIZE512 /* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command */ /* args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE (CONFIG_SYS_CBSIZE) Should we do this for some more OMAP3 boards, too? E.g. Overo and Beagle? Or for all OMAP3 boards? Best regards Dirk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] OMAP3EVM: Increase bootargs string length.
On 17.12.2009 14:29, Sriramakrishnan wrote: Increase the bootargs string length as multiple options (especially for Video settings) are passed to the kernel through bootargs. Also increase the number of args. Signed-off-by: Sriramakrishnans...@ti.com --- include/configs/omap3_evm.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h index a5514ae..fe7b0e2 100644 --- a/include/configs/omap3_evm.h +++ b/include/configs/omap3_evm.h @@ -200,11 +200,11 @@ #define CONFIG_SYS_HUSH_PARSER/* use hush command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 #define CONFIG_SYS_PROMPT V_PROMPT -#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ +#define CONFIG_SYS_CBSIZE 512 /* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command */ /* args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE (CONFIG_SYS_CBSIZE) Should we do this for some more OMAP3 boards, too? E.g. Overo and Beagle? Or for all OMAP3 boards? Best regards Dirk I believe the change is relevant for other OMAP3 boards as well. I can repost the patch with changes for all OMAP3 boards but I will not be able to Test this on boards other than omap3evm. Regards Sriram ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCHv2] OMAP3: Increase bootargs string length.
Increase the bootargs string length as multiple options (especially for Video settings) are passed to the kernel through bootargs. Also increase the number of args. This patch updates the config files for all omap3 boards to increase the bootargs string length. Signed-off-by: Sriramakrishnan s...@ti.com --- include/configs/omap3_beagle.h |4 ++-- include/configs/omap3_evm.h |4 ++-- include/configs/omap3_overo.h |4 ++-- include/configs/omap3_pandora.h |4 ++-- include/configs/omap3_sdp3430.h |4 ++-- include/configs/omap3_zoom1.h |4 ++-- include/configs/omap3_zoom2.h |4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h index 19a5ec9..33bf615 100644 --- a/include/configs/omap3_beagle.h +++ b/include/configs/omap3_beagle.h @@ -219,11 +219,11 @@ #define CONFIG_SYS_HUSH_PARSER /* use hush command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 #define CONFIG_SYS_PROMPT V_PROMPT -#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ +#define CONFIG_SYS_CBSIZE 512 /* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command args */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE(CONFIG_SYS_CBSIZE) diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h index a5514ae..fe7b0e2 100644 --- a/include/configs/omap3_evm.h +++ b/include/configs/omap3_evm.h @@ -200,11 +200,11 @@ #define CONFIG_SYS_HUSH_PARSER /* use hush command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 #define CONFIG_SYS_PROMPT V_PROMPT -#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ +#define CONFIG_SYS_CBSIZE 512 /* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command */ /* args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZE(CONFIG_SYS_CBSIZE) diff --git a/include/configs/omap3_overo.h b/include/configs/omap3_overo.h index ffb515d..307d5c0 100644 --- a/include/configs/omap3_overo.h +++ b/include/configs/omap3_overo.h @@ -205,11 +205,11 @@ #define CONFIG_SYS_HUSH_PARSER /* use hush command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 #define CONFIG_SYS_PROMPT V_PROMPT -#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ +#define CONFIG_SYS_CBSIZE 512 /* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command */ /* args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZECONFIG_SYS_CBSIZE diff --git a/include/configs/omap3_pandora.h b/include/configs/omap3_pandora.h index 6f21af3..7d59588 100644 --- a/include/configs/omap3_pandora.h +++ b/include/configs/omap3_pandora.h @@ -197,11 +197,11 @@ #define CONFIG_SYS_HUSH_PARSER /* use hush command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 #define CONFIG_SYS_PROMPT V_PROMPT -#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ +#define CONFIG_SYS_CBSIZE 512 /* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /* max number of command */ +#define CONFIG_SYS_MAXARGS 32 /* max number of command */ /* args */ /* Boot Argument Buffer Size */ #define CONFIG_SYS_BARGSIZECONFIG_SYS_CBSIZE diff --git a/include/configs/omap3_sdp3430.h b/include/configs/omap3_sdp3430.h index 229dc5e..5f73837 100644 --- a/include/configs/omap3_sdp3430.h +++ b/include/configs/omap3_sdp3430.h @@ -269,11 +269,11 @@ #define CONFIG_SYS_HUSH_PARSER /* use hush command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 #define CONFIG_SYS_PROMPT V_PROMPT -#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */
Re: [U-Boot] [PATCH] OMAP3 Move declaration of gpmc_cfg.
-Original Message-
From: u-boot-boun...@lists.denx.de
[mailto:u-boot-boun...@lists.denx.de] On Behalf Of Tom Rix
Sent: Tuesday, November 17, 2009 2:20 AM
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3 Move declaration of gpmc_cfg.
Every omap3 board config file declared the global variable gpmc_cfg.
This changes moves the declaration to a better location in the
arch dependent header file cpu.h.
Hi Tom,
Wouldn't omap_gpmc.h be a better place for this?
Sorry, I had missed this post earlier; but found after implementing
the change for omap3evm and am3517evm; Came across this port while
following the trail for removing other externs from the config files.
Best regards,
Sanjeev
Signed-off-by: Tom Rix tom@windriver.com
---
include/asm-arm/arch-omap3/cpu.h |4
include/configs/devkit8000.h |1 -
include/configs/omap3_beagle.h |1 -
include/configs/omap3_evm.h |1 -
include/configs/omap3_overo.h|1 -
include/configs/omap3_pandora.h |1 -
include/configs/omap3_sdp3430.h |1 -
include/configs/omap3_zoom1.h|1 -
include/configs/omap3_zoom2.h|1 -
9 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/include/asm-arm/arch-omap3/cpu.h
b/include/asm-arm/arch-omap3/cpu.h
index e51c4f3..aa8de32 100644
--- a/include/asm-arm/arch-omap3/cpu.h
+++ b/include/asm-arm/arch-omap3/cpu.h
@@ -136,6 +136,10 @@ struct gpmc {
u32 ecc8_result;/* 0x21C */
u32 ecc9_result;/* 0x220 */
};
+
+/* Used for board specific gpmc initialization */
+extern struct gpmc *gpmc_cfg;
+
#else /* __ASSEMBLY__ */
#define GPMC_CONFIG1 0x00
#define GPMC_CONFIG2 0x04
diff --git a/include/configs/devkit8000.h
b/include/configs/devkit8000.h
index 1011770..7487bb7 100644
--- a/include/configs/devkit8000.h
+++ b/include/configs/devkit8000.h
@@ -299,7 +299,6 @@
#define CONFIG_ENV_OFFSETboot_flash_off
#ifndef __ASSEMBLY__
-extern struct gpmc *gpmc_cfg;
extern unsigned int boot_flash_base;
extern volatile unsigned int boot_flash_env_addr;
extern unsigned int boot_flash_off;
diff --git a/include/configs/omap3_beagle.h
b/include/configs/omap3_beagle.h
index 024b9b8..70186ce 100644
--- a/include/configs/omap3_beagle.h
+++ b/include/configs/omap3_beagle.h
@@ -314,7 +314,6 @@
#define CONFIG_SYS_JFFS2_NUM_BANKS 1
#ifndef __ASSEMBLY__
-extern struct gpmc *gpmc_cfg;
extern unsigned int boot_flash_base;
extern volatile unsigned int boot_flash_env_addr;
extern unsigned int boot_flash_off;
diff --git a/include/configs/omap3_evm.h b/include/configs/omap3_evm.h
index 6709edc..162bfea 100644
--- a/include/configs/omap3_evm.h
+++ b/include/configs/omap3_evm.h
@@ -295,7 +295,6 @@
#define CONFIG_SYS_JFFS2_NUM_BANKS 1
#ifndef __ASSEMBLY__
-extern struct gpmc *gpmc_cfg;
extern unsigned int boot_flash_base;
extern volatile unsigned int boot_flash_env_addr;
extern unsigned int boot_flash_off;
diff --git a/include/configs/omap3_overo.h
b/include/configs/omap3_overo.h
index 0f812a7..ff25aba 100644
--- a/include/configs/omap3_overo.h
+++ b/include/configs/omap3_overo.h
@@ -299,7 +299,6 @@
#define CONFIG_SYS_JFFS2_NUM_BANKS 1
#ifndef __ASSEMBLY__
-extern struct gpmc *gpmc_cfg;
extern unsigned int boot_flash_base;
extern volatile unsigned int boot_flash_env_addr;
extern unsigned int boot_flash_off;
diff --git a/include/configs/omap3_pandora.h
b/include/configs/omap3_pandora.h
index 0cafeb8..838b1ad 100644
--- a/include/configs/omap3_pandora.h
+++ b/include/configs/omap3_pandora.h
@@ -292,7 +292,6 @@
#define CONFIG_SYS_JFFS2_NUM_BANKS 1
#ifndef __ASSEMBLY__
-extern struct gpmc *gpmc_cfg;
extern unsigned int boot_flash_base;
extern volatile unsigned int boot_flash_env_addr;
extern unsigned int boot_flash_off;
diff --git a/include/configs/omap3_sdp3430.h
b/include/configs/omap3_sdp3430.h
index d91c8ff..a2a4b8a 100644
--- a/include/configs/omap3_sdp3430.h
+++ b/include/configs/omap3_sdp3430.h
@@ -361,7 +361,6 @@
/*
--*/
#ifndef __ASSEMBLY__
-extern struct gpmc *gpmc_cfg;
extern unsigned int boot_flash_base;
extern volatile unsigned int boot_flash_env_addr;
extern unsigned int boot_flash_off;
diff --git a/include/configs/omap3_zoom1.h
b/include/configs/omap3_zoom1.h
index 2aef973..62a6340 100644
--- a/include/configs/omap3_zoom1.h
+++ b/include/configs/omap3_zoom1.h
@@ -300,7 +300,6 @@
#define CONFIG_SYS_JFFS2_NUM_BANKS 1
#ifndef __ASSEMBLY__
-extern struct gpmc *gpmc_cfg;
extern unsigned int boot_flash_base;
extern volatile unsigned int boot_flash_env_addr;
extern unsigned int boot_flash_off;
diff --git a/include/configs/omap3_zoom2.h
b/include/configs/omap3_zoom2.h
index 5b03fb6..5296630 100644
--- a/include/configs/omap3_zoom2.h
+++
Re: [U-Boot] [PATCH] OMAP3: Beagle: Update revision detection
Dirk Behme wrote: New BeagleBoard revision C4 uses a new ID. Update revision detection. Signed-off-by: Dirk Behme dirk.be...@googlemail.com --- Tested on C1/2 and C4 (prototype). Patch against v2009.11 Known C4 changes: - Use OMAP3 720MHz devices. - Change in the way the USB Host PHY is powered. (to be added later based on this patch) board/ti/beagle/beagle.c | 68 ++- board/ti/beagle/beagle.h |9 -- 2 files changed, 51 insertions(+), 26 deletions(-) Patch looks fine. I tested this on B7 and C3. B7 reported ok C3 reported as C1/C2 which is not. Is there another way to test C3 vs C1/C2 ? Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Breakage on arm/next
-Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Tom Sent: Tuesday, December 01, 2009 8:10 PM To: apgmoorthy Cc: 'Scott Wood'; u-boot@lists.denx.de; kyungmin.p...@samsung.com Subject: Re: [U-Boot] Breakage on arm/next apgmoorthy wrote: Hi Tom, snip Moving these Macro definitions to include/linux/mtd/onenand.h looks more viable. I can send across the patch. Please comment. Could the macros defined in apollo.h also be defined in the other target board's config file ? Thank you for looking into this Tom Is there any update on the fix/proposal? I am trying to build for omap3_evm; but see the same problem. My repo is currently at: bb3bcfa : Merge branch 'next' of ../next a200a7c : Update CHANGELOG; prepare Prepare v2009.11 Best regards, Sanjeev With Regards Moorthy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length.
Dirk Behme wrote: On 17.12.2009 14:29, Sriramakrishnan wrote: Increase the bootargs string length as multiple options (especially for Video settings) are passed to the kernel through bootargs. Also increase the number of args. snip Should we do this for some more OMAP3 boards, too? E.g. Overo and Beagle? Or for all OMAP3 boards? It seems like a lot of the omap3 boards share common config options. What do you think about consolidating the common options to a sub config file ? Tom Best regards Dirk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length.
-Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Tom Sent: Thursday, December 17, 2009 9:25 PM To: Dirk Behme Cc: u-boot@lists.denx.de Subject: [U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length. Dirk Behme wrote: On 17.12.2009 14:29, Sriramakrishnan wrote: Increase the bootargs string length as multiple options (especially for Video settings) are passed to the kernel through bootargs. Also increase the number of args. snip Should we do this for some more OMAP3 boards, too? E.g. Overo and Beagle? Or for all OMAP3 boards? It seems like a lot of the omap3 boards share common config options. What do you think about consolidating the common options to a sub config file ? Seems a good idea; only if we are sure that the next board doesn't break the current list of common configs. Else, we would be having patches to move config options back to board specific files. ~sanjeev Tom Best regards Dirk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length.
On 17.12.2009 16:58, Premi, Sanjeev wrote: -Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Tom Sent: Thursday, December 17, 2009 9:25 PM To: Dirk Behme Cc: u-boot@lists.denx.de Subject: [U-Boot] RFC common omap3 subconfig ? was Re: [PATCH] OMAP3EVM: Increase bootargs string length. Dirk Behme wrote: On 17.12.2009 14:29, Sriramakrishnan wrote: Increase the bootargs string length as multiple options (especially for Video settings) are passed to the kernel through bootargs. Also increase the number of args. snip Should we do this for some more OMAP3 boards, too? E.g. Overo and Beagle? Or for all OMAP3 boards? It seems like a lot of the omap3 boards share common config options. What do you think about consolidating the common options to a sub config file ? Seems a good idea; only if we are sure that the next board doesn't break the current list of common configs. Else, we would be having patches to move config options back to board specific files. Does Wolfgang have a basic opinion about sub-configs for configuration stuff common for similar boards? Best regards Dirk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] onenand: Fix compile errors due to FlexOneNAND
This patch fixes the compile error while trying to
compile for omap3evm.
env_onenand.c: In function 'env_relocate_spec':
env_onenand.c:70: error: 'CONFIG_ENV_ADDR_FLEX' undeclared
(first use in this function)
env_onenand.c:70: error: (Each undeclared identifier is re
ported only once
env_onenand.c:70: error: for each function it appears in.)
env_onenand.c: In function 'saveenv':
env_onenand.c:106: error: 'CONFIG_ENV_ADDR_FLEX' undeclare
d (first use in this function)
env_onenand.c:107: error: 'CONFIG_ENV_SIZE_FLEX' undeclare
d (first use in this function)
Signed-off-by: Sanjeev Premi pr...@ti.com
---
common/env_onenand.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/common/env_onenand.c b/common/env_onenand.c
index 23d2caa..473e0b2 100644
--- a/common/env_onenand.c
+++ b/common/env_onenand.c
@@ -66,9 +66,10 @@ void env_relocate_spec(void)
size_t retlen;
env_addr = CONFIG_ENV_ADDR;
+#ifdef CONFIG_ENV_ADDR_FLEX
if (FLEXONENAND(this))
env_addr = CONFIG_ENV_ADDR_FLEX;
-
+#endif
/* Check OneNAND exist */
if (mtd-writesize)
/* Ignore read fail */
@@ -102,12 +103,14 @@ int saveenv(void)
size_t retlen;
instr.len = CONFIG_ENV_SIZE;
+#ifdef CONFIG_ENV_ADDR_FLEX
if (FLEXONENAND(this)) {
env_addr = CONFIG_ENV_ADDR_FLEX;
instr.len = CONFIG_ENV_SIZE_FLEX;
instr.len = onenand_mtd.eraseregions[0].numblocks == 1 ?
1 : 0;
}
+#endif
instr.addr = env_addr;
instr.mtd = mtd;
if (mtd-erase(mtd, instr)) {
--
1.6.2.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 9/9] SPEAr600 build support added
Dear Vipin KUMAR, In message 1260955110-5656-10-git-send-email-vipin.ku...@st.com you wrote: Signed-off-by: Vipin vipin.ku...@st.com --- MAKEALL |1 + Makefile |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) This patch must be merged with the one adding the actual code for this board. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The only way to learn a new programming language is by writing pro- grams in it.- Brian Kernighan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] Prepare for da850 support
Dear Sudhakar Rajashekhara, In message 1260959053-29746-1-git-send-email-sudhakar@ti.com you wrote: DA850/OMAP-L138 is a new SoC from Texas Instruments (http://focus.ti.com/docs/prod/folders/print/omap-l138.html). This SoC is similar to DA830/OMAP-L137 in many aspects. Hence rename the da830 specific files and folders to da8xx to accommodate DA850/OMAP-L138. ... 7 files changed, 226 insertions(+), 222 deletions(-) delete mode 100644 board/davinci/da830evm/Makefile delete mode 100644 board/davinci/da830evm/config.mk delete mode 100644 board/davinci/da830evm/da830evm.c create mode 100644 board/davinci/da8xxevm/Makefile create mode 100644 board/davinci/da8xxevm/config.mk create mode 100644 board/davinci/da8xxevm/da830evm.c Please use the -M option to git format-patch (maybe also -C and even --find-copies-harder) to save reviewers the work of comparing the deleted and the new files. Please resubmit - I am not in the mood to manually compare the files. diff --git a/Makefile b/Makefile index b891b1b..769bf22 100644 --- a/Makefile +++ b/Makefile @@ -2934,7 +2934,9 @@ cp1026_config: unconfig @board/armltd/integrator/split_by_variant.sh cp $@ da830evm_config: unconfig - @$(MKCONFIG) $(@:_config=) arm arm926ejs da830evm davinci davinci + @mkdir -p $(obj)include + echo #define CONFIG_DA830_EVM $(obj)include/config.h + @$(MKCONFIG) -a $(@:_config=) arm arm926ejs da8xxevm davinci davinci Don't add scripting to the top level Makefile, this is not needed any more. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A man either lives life as it happens to him, meets it head-on and licks it, or he turns his back on it and starts to wither away. -- Dr. Boyce, The Menagerie (The Cage), stardate unknown ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] ubi part failing on NAND
The ubi part command is failing for me on my PowerPC 85xx board. I am not trying to do anything special, just create the partitions and volumes so that I can try writing an ubi.img. It spits out enough information that it looks like it did work but it prints out an error nonetheless. And of course there is the long standing issue of the reported MTD number not making any sense. But previous posts have discounted this as an issue. Here is the snippet of the error: UBI error: ubi_init: cannot attach mtd2 UBI: mtd2 is detached from ubi0 UBI error: ubi_init: UBI error: cannot initialize UBI, error -17 UBI init error -17 Here is a cleaned up version of the session log: = mtdparts device nor0 f800.nor, # parts = 8 #: namesizeoffset mask_flags 0: config 0x0002 0x 0 1: kernel 0x0026 0x0002 0 2: fdt 0x0002 0x0028 0 3: tinyfs 0x0060 0x002a 0 4: rootfs 0x076a 0x008a 0 5: u-boot-env-r0x0002 0x07f4 1 6: u-boot-env 0x0002 0x07f6 1 7: u-boot 0x0008 0x07f8 1 device nand0 f400.nand, # parts = 2 #: namesizeoffset mask_flags 0: fs1 0x2000 0x 0 1: fs2 0x2000 0x2000 0 = nand erase 0x0 0x4000 NAND erase: device 0 whole chip Skipping bad block at 0x0120 Skipping bad block at 0x0e88 Skipping bad block at 0x1cd8 Skipping bad block at 0x2b30 Skipping bad block at 0x323c Skipping bad block at 0x364c Skipping bad block at 0x37cc Erasing at 0x3ffc -- 100% complete. OK = ubi part fs1 Creating 1 MTD partitions on nand0: 0x-0x2000 : mtd=0 UBI: attaching mtd2 to ubi0 UBI: physical eraseblock size: 262144 bytes (256 KiB) UBI: logical eraseblock size:253952 bytes UBI: smallest flash I/O unit:4096 UBI: VID header offset: 4096 (aligned 4096) UBI: data offset:8192 UBI: empty MTD device detected UBI: create volume table (copy #1) UBI: create volume table (copy #2) UBI: attached mtd2 to ubi0 UBI: MTD device name:mtd=0 UBI: MTD device size:512 MiB UBI: number of good PEBs:2045 UBI: number of bad PEBs: 3 UBI: max. allowed volumes: 128 UBI: wear-leveling threshold:4096 UBI: number of internal volumes: 1 UBI: number of user volumes: 0 UBI: available PEBs: 2021 UBI: total number of reserved PEBs: 24 UBI: number of PEBs reserved for bad PEB handling: 20 UBI: max/mean erase counter: 0/0 UBI error: ubi_init: cannot attach mtd2 UBI: mtd2 is detached from ubi0 UBI error: ubi_init: UBI error: cannot initialize UBI, error -17 UBI init error -17 exit not allowed from main input shell. My last sync with the denx git was when 2.6.31 was released. Here is my version: = ver U-Boot 2009.08-00213-gfdf80f7 (Dec 17 2009 - 12:57:07) Jeff Angielski The PTR Group www.theptrgroup.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/4] fsl-ddr: add override for the Rtt_WR
Dear Kumar Gala, In message 1260980679-13236-3-git-send-email-ga...@kernel.crashing.org you wrote: From: Dave Liu dave...@freescale.com It may be different settings of Rtt_nom and Rtt_WR for different boards, adding the override provide the capability. I don't understand what this commit message is supposed to say. Can you please explain what this commit is supposed to do? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Give a man a fish, and you feed him for a day. Teach a man to fish, and he'll invite himself over for dinner. - Calvin Keegan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ppc/p4080: Add Corenet Platform Cache (CPC) registers
Dear Kumar Gala,
In message 1260980960-15351-1-git-send-email-ga...@kernel.crashing.org you
wrote:
From: Becky Bruce bec...@kernel.crashing.org
Signed-off-by: Becky Bruce bec...@kernel.crashing.org
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
include/asm-ppc/immap_85xx.h | 74
++
1 files changed, 74 insertions(+), 0 deletions(-)
diff --git a/include/asm-ppc/immap_85xx.h b/include/asm-ppc/immap_85xx.h
index 43b3a2c..176a381 100644
--- a/include/asm-ppc/immap_85xx.h
+++ b/include/asm-ppc/immap_85xx.h
@@ -1562,6 +1562,77 @@ typedef struct par_io {
u8 res[8];
} par_io_t;
+#ifdef CONFIG_SYS_FSL_CPC
+/*
+ * Define a single offset that is the start of all the CPC register
+ * blocks - if there is more than one CPC, we expect these to be
+ * contiguous 4k regions
+ */
+
+typedef struct cpc_corenet {
+ u32 cpccsr0;/* Config/status reg */
+#define CPC_CSR0_CE 0x8000 /* Cache Enable */
+#define CPC_CSR0_PE 0x4000 /* Enable ECC */
+#define CPC_CSR0_FI 0x0020 /* Cache Flash Invalidate */
+#define CPC_CSR0_WT 0x0008 /* Write-through mode */
+#define CPC_CSR0_FL 0x0800 /* Hardware cache flush */
+#define CPC_CSR0_LFC 0x0400 /* Cache Lock Flash Clear */
+ u32 res1;
+ u32 cpccfg0;/* Configuration register */
+#define CPC_CFG0_SZ_MASK 0x3fff
+#define CPC_CFG0_SZ_K(x) ((x CPC_CFG0_SZ_MASK) 6)
+#define CPC_CFG0_NUM_WAYS(x) (((x 14) 0x1f) + 1)
+#define CPC_CFG0_LINE_SZ(x) x 23) 0x3) + 1) * 32)
+ u32 res2;
+ u32 cpcewcr0; /* External Write reg 0 */
+ u32 cpcewabr0; /* External write base reg 0 */
+ u32 res3[2];
+ u32 cpcewcr1; /* External Write reg 1 */
+ u32 cpcewabr1; /* External write base reg 1 */
+ u32 res4[54];
+ u32 cpcsrcr1; /* SRAM control reg 1 */
+#define CPC_SRCR1_SRBARU_MASK0x
+#define CPC_SRCR1_SRBARU(x) (((unsigned long long)x 32) \
+ CPC_SRCR1_SRBARU_MASK)
+ u32 cpcsrcr0; /* SRAM control reg 0 */
+#define CPC_SRCR0_SRBARL_MASK 0x8000
+#define CPC_SRCR0_SRBARL(x) (x CPC_SRCR0_SRBARL_MASK)
+#define CPC_SRCR0_INTLVEN0x0100
+#define CPC_SRCR0_SRAMSZ_1_WAY 0x
+#define CPC_SRCR0_SRAMSZ_2_WAY 0x0002
+#define CPC_SRCR0_SRAMSZ_4_WAY 0x0004
+#define CPC_SRCR0_SRAMSZ_8_WAY 0x0006
+#define CPC_SRCR0_SRAMSZ_16_WAY 0x0008
+#define CPC_SRCR0_SRAMSZ_32_WAY 0x000a
+#define CPC_SRCR0_SRAMEN 0x0001
+ u32 res5[62];
+ struct {
+ u32 id; /* partition ID */
+ u32 res;
+ u32 alloc; /* partition allocation */
+ u32 way;/* partition way */
+ } partition_regs[16];
+ u32 res6[704];
+ u32 cpcerrinjhi;/* Error injection high */
+ u32 cpcerrinjlo;/* Error injection lo */
+ u32 cpcerrinjctl; /* Error injection control */
+ u32 res7[5];
+ u32 cpccaptdatahi; /* capture data high */
+ u32 cpccaptdatalo; /* capture data low */
+ u32 cpcaptecc; /* capture ECC */
+ u32 res8[5];
+ u32 cpcerrdet; /* error detect */
+ u32 cpcerrdis; /* error disable */
+#define CPC_ERRDIS_TMHITDIS 0x0080 /* multi-way hit
disable */
+ u32 cpcerrinten;/* errir interrupt enable */
+ u32 cpcerrattr; /* error attribute */
+ u32 cpcerreaddr;/* error extended address */
+ u32 cpcerraddr; /* error address */
+ u32 cpcerrctl; /* error control */
+ u32 res9[105]; /* pad out to 4k */
+} cpc_corenet_t;
+#endif /* CONFIG_SYS_FSL_CPC */
I really dislike mixing code (struct declaration) and macro defines.
Please do not do this. I understand the intention, but the result is
ugly and unreadable.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
A student of probability soon realizes that by its nature the
billion-to-one chance crops up nine times out of ten, and that the
greatest odds boil down to a double-sided statement: it will happen,
or it will not. - Terry Pratchett, _The Dark Side of the Sun_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] drivers/bios_emulator: Fix compile error in .depend not being generated
Dear Kumar Gala, In message 1260994331-22733-1-git-send-email-ga...@kernel.crashing.org you wrote: make -C drivers/bios_emulator/ make[2]: Entering directory `drivers/bios_emulator' In file included from atibios.c:49: biosemui.h:47:21: error: biosemu.h: No such file or directory In file included from biosemu.c:50: biosemui.h:47:21: error: biosemu.h: No such file or directory In file included from besys.c:51: biosemui.h:47:21: error: biosemu.h: No such file or directory In file included from bios.c:45: biosemui.h:47:21: error: biosemu.h: No such file or directory x86emu/decode.c:40:28: error: x86emu/x86emui.h: No such file or directory x86emu/ops2.c:45:28: error: x86emu/x86emui.h: No such file or directory x86emu/ops.c:76:28: error: x86emu/x86emui.h: No such file or directory x86emu/prim_ops.c:103:28: error: x86emu/x86emui.h: No such file or directory x86emu/sys.c:43:28: error: x86emu/x86emui.h: No such file or directory x86emu/debug.c:42:28: error: x86emu/x86emui.h: No such file or directory Due to lack of proper CPPFLAGS being passed to .depend generation rule Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- drivers/bios_emulator/Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If you'll excuse me a minute, I'm going to have a cup of coffee. - broadcast from Apollo 11's LEM, Eagle, to Johnson Space Center, Houston July 20, 1969, 7:27 P.M. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] About GPL
Dear Rob Westfall, In message 63e059e40912161855q31eb64e4h84f8fbbdb088a...@mail.gmail.com you wrote: Where exactly is the line for what you have to provide vs what you don't have to provide? If you want to know exactly, then please read the GPL itself (see file COPYING in the top level directory) or http://www.gnu.org/licenses/gpl-2.0.html We are building boards that are based on a standard board, but we have obviously had to modify include/config/boardname to setup for our hardware and create customized files to support our board. We have NOT modified files outside of customizing a /include/config/boardname and creating a board/boardname directory based on a existing board that is already released from the cpu vendor. For a quick summary, see A Practical Guide to GPL Compliance at http://www.softwarefreedom.org/resources/2008/compliance-guide.html Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Spock, did you see the looks on their faces? Yes, Captain, a sort of vacant contentment. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 07/25] Blackfin: do not require CONFIG_BAUDRATE
Dear Mike Frysinger,
In message 1261017850-22802-8-git-send-email-vap...@gentoo.org you wrote:
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
cpu/blackfin/initcode.c |3 +++
lib_blackfin/board.c|2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
...
static int init_baudrate(void)
{
+#ifdef CONFIG_BAUDRATE
char baudrate[15];
int i = getenv_r(baudrate, baudrate, sizeof(baudrate));
gd-bd-bi_baudrate = gd-baudrate = (i 0)
? simple_strtoul(baudrate, NULL, 10)
: CONFIG_BAUDRATE;
+#endif
return 0;
}
Out of curiosity: what do these boards do when CONFIG_BAUDRATE is not
defined?
It seems yo me you add a new, additional meaning to the
CONFIG_BAUDRATE option here. This should be documented (at least in
the README).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Time is fluid ... like a river with currents, eddies, backwash.
-- Spock, The City on the Edge of Forever, stardate 3134.0
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/25] Blackfin: kill off useless initdram() usage
Dear Mike Frysinger, In message 1261017850-22802-9-git-send-email-vap...@gentoo.org you wrote: While the initdram() function makes sense on some arches, it doesn't for Blackfin systems as it's always implemented the same way. Would it not make sense to start using get_ram_size(), too? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Unix is like a toll road on which you have to stop every 50 feet to pay another nickel. But hey! You only feel 5 cents poorer each time. - Larry Wall in 1992aug13.192357.15...@netlabs.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 11/25] Blackfin: support boards with no external memory
Dear Mike Frysinger,
In message 1261017850-22802-12-git-send-email-vap...@gentoo.org you wrote:
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
cpu/blackfin/initcode.c | 16 +++-
cpu/blackfin/start.S |6 ++
include/asm-blackfin/config.h |9 +++--
lib_blackfin/board.c | 22 --
lib_blackfin/u-boot.lds.S | 21 ++---
5 files changed, 54 insertions(+), 20 deletions(-)
diff --git a/cpu/blackfin/initcode.c b/cpu/blackfin/initcode.c
index 9b0cfbc..b99f70c 100644
--- a/cpu/blackfin/initcode.c
+++ b/cpu/blackfin/initcode.c
@@ -541,10 +541,18 @@ program_memory_controller(ADI_BOOT_DATA *bootstruct,
bool put_into_srfs)
* self-refresh. So we have to pull it out before programming.
*/
#ifdef EBIU_RSTCTL
+# ifdef CONFIG_EBIU_RSTCTL_VAL
bfin_write_EBIU_RSTCTL(bfin_read_EBIU_RSTCTL() | 0x1 /*DDRSRESET*/ |
CONFIG_EBIU_RSTCTL_VAL);
...
+# define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_MAX_RAM_SIZE -
CONFIG_SYS_MONITOR_LEN)
...
+ if ((CONFIG_SYS_MONITOR_BASE CPLB_PAGE_MASK) !=
((CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN) CPLB_PAGE_MASK)) {
+ icplb_add((CONFIG_SYS_MONITOR_BASE +
CONFIG_SYS_MONITOR_LEN) CPLB_PAGE_MASK, SDRAM_IKERNEL);
+ dcplb_add((CONFIG_SYS_MONITOR_BASE +
CONFIG_SYS_MONITOR_LEN) CPLB_PAGE_MASK, SDRAM_DKERNEL);
+ ++i;
Lines too log, please fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The combination of a number of things to make existence worthwhile.
Yes, the philosophy of 'none,' meaning 'all.'
-- Spock and Lincoln, The Savage Curtain, stardate 5906.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 15/25] Blackfin: use new bfin read/write mmr helper funcs
Dear Mike Frysinger,
In message 1261017850-22802-16-git-send-email-vap...@gentoo.org you wrote:
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
cpu/blackfin/initcode.c | 10 ++--
cpu/blackfin/interrupts.c | 12 ++--
cpu/blackfin/serial.c | 20 ++---
cpu/blackfin/serial.h | 119 +---
include/asm-blackfin/blackfin_local.h |2 +-
5 files changed, 83 insertions(+), 80 deletions(-)
...
/* When debugging is disabled, we only care about the DR bit, so if other
* bits get set/cleared, we don't really care since we don't read them
* anyways (and thus anomaly 0599 is irrelevant).
*/
-static inline uint16_t uart_lsr_read(void) { return *pUART_LSR; }
-static inline void uart_lsr_clear(void) { *pUART_LSR = -1; }
+static uint16_t uart_lsr_read(void) { return bfin_read16(pUART-lsr); }
+static void uart_lsr_clear(void) { bfin_write16(pUART-lsr,
bfin_read16(pUART-lsr) | -1); }
Line too long.
...
+# define ACCESS_LATCH()bfin_write16(pUART-lcr,
bfin_read16(pUART-lcr) | DLAB)
+# define ACCESS_PORT_IER() bfin_write16(pUART-lcr,
bfin_read16(pUART-lcr) ~DLAB)
Ditto. Please fix globally.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The human race is faced with a cruel choice: work or daytime tele-
vision.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 21/25] Blackfin: section off the CF/IDE io.h hacks
Dear Mike Frysinger, In message 1261017850-22802-22-git-send-email-vap...@gentoo.org you wrote: These need to be rethought, but until that happens, isolate the hack so that we can extend the common code without breaking things. Signed-off-by: Mike Frysinger vap...@gentoo.org ... +#define inb(addr) cf_inb((volatile unsigned char *)(addr)) +#define outb(x, addr) cf_outb((unsigned char)(x), (volatile unsigned char *)(addr)) +#define insw(port, addr, count) cf_insw((unsigned short *)(addr), (unsigned short *)(port), (count)) +#define outsw(port, addr, count) cf_outsw((unsigned short *)(port), (unsigned short *)(addr), (count)) Lines too long. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Philosophy is a game with objectives and no rules. Mathematics is a game with rules and no objectives. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 22/25] Blackfin: pull io funcs from linux
Dear Mike Frysinger, In message 1261017850-22802-23-git-send-email-vap...@gentoo.org you wrote: Some common code uses more of the io.h funcs than we currently provide, so pull in all of the ones from the linux kernel. Signed-off-by: Mike Frysinger vap...@gentoo.org ... +/* We are single threaded most of the time */ +#define CONFIG_BFIN_INS_LOWOVERHEAD Most of the time? I'd say U-Boot is always single-threaded? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It is undignified for a woman to play servant to a man who is not hers. -- Spock, Amok Time, stardate 3372.7 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 25/25] Blackfin: add support for BF527-EZKIT v2.1
Dear Mike Frysinger, In message 1261017850-22802-26-git-send-email-vap...@gentoo.org you wrote: From: Michael Hennerich michael.henner...@analog.com The new board revision has a different LCD. Signed-off-by: Michael Hennerich michael.henner...@analog.com Signed-off-by: Mike Frysinger vap...@gentoo.org --- i've removed include/asm-blackfin/bfin_logo_rgb565_230x230.h from the diffstat since it's so big (120kb) and it's generated output from easylogo and the Blackfin .tga. Seems you removed it not fromthe diffstat, but from the patch itself? $(BFIN_BOARDS:%=%_config): unconfig - @$(MKCONFIG) $(@:_config=) blackfin blackfin $(@:_config=) + @$(MKCONFIG) $(MKCONFIG_$(@:_config=)) $(@:_config=) blackfin blackfin $(@:_config=) Line too long. +#if !(defined(CONFIG_LQ035Q1_USE_RGB888_8_BIT_PPI) || defined(CONFIG_LQ035Q1_USE_RGB565_8_BIT_PPI)) +#define CONFIG_LQ035Q1_USE_RGB565_8_BIT_PPI +#endif + +/* Interface 16/18-bit TFT over an 8-bit wide PPI using a small Programmable Logic Device (CPLD) + * http://blackfin.uclinux.org/gf/project/stamp/frs/?action=FrsReleaseBrowsefrs_package_id=165 + */ Lines too long. Please fix globally. --- a/include/configs/bf527-ezkit.h +++ b/include/configs/bf527-ezkit.h @@ -155,6 +155,15 @@ /* + * Video Settings + */ +#ifdef CONFIG_MK_BF527_EZKIT_REV_2_1 +# define CONFIG_LQ035Q1_SPI_BUS 0 +# define CONFIG_LQ035Q1_SPI_CS 7 +#endif + + Please don't add that many empty lines. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Successful and fortunate crime is called virtue. - Seneca ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Update Makefile for tag generating
Dear Li Yang, In message 1260353606-5498-1-git-send-email-le...@freescale.com you wrote: Get tag directories from the $(__LIB) and also generate tag for .S files. Signed-off-by: Li Yang le...@freescale.com Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de On our campus the UNIX system has proved to be not only an effective software tool, but an agent of technical and social change within the University. - John Lions (U. of Toronto (?)) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - net/next
Dear Ben Warren, In message 4b29c3a2.6000...@gmail.com you wrote: Wolfgang, The following changes since commit 4b142febff71eabdb7ddbb125c7b583b24ddc434: Heiko Schocher (1): common: delete CONFIG_SYS_64BIT_VSPRINTF and CONFIG_SYS_64BIT_STRTOUL are available in the git repository at: git://git.denx.de/u-boot-net.git next Ben Warren (1): Net: Clean up LAN91C96 Support John Ogness (1): fec_mxc: incomplete error handling Mike Frysinger (1): net: pull CONFIG checks out of source and into makefile Nishanth Menon (3): NET: LAN91C96 CONFIG_NET_MULTIify TI OMAP3: SDP3430 FIX NET_MULTI Warning LAN91C96: Enable NET_MULTI LAN driver Reinhard Arlt (1): net: e1000: Add support for the Intel 82546GB controller Remy Bohmer (1): Add error codes/handling for TFTP-server Thomas Weber (1): net: dm9000x: fix debug output board/apollon/apollon.c | 13 +- board/assabet/assabet.c | 12 + board/dave/B2/B2.c | 12 + board/gcplus/gcplus.c| 12 + board/logicpd/zoom1/zoom1.c | 12 + board/logicpd/zoom2/zoom2.c | 12 + board/lubbock/lubbock.c | 12 + board/ti/omap1510inn/omap1510innovator.c | 12 + board/ti/omap1610inn/omap1610innovator.c | 12 + board/ti/omap2420h4/omap2420h4.c | 12 + board/ti/omap5912osk/omap5912osk.c | 12 + board/ti/omap730p2/omap730p2.c | 12 + board/ti/sdp3430/sdp.c | 12 +- drivers/net/Makefile |2 +- drivers/net/dm9000x.c|2 +- drivers/net/e1000.c |1 + drivers/net/fec_mxc.c|1 + drivers/net/lan91c96.c | 452 -- drivers/net/lan91c96.h | 110 include/configs/B2.h |4 +- include/configs/apollon.h|3 +- include/configs/assabet.h|3 +- include/configs/gcplus.h |3 +- include/configs/lubbock.h|3 +- include/configs/omap1510inn.h|3 +- include/configs/omap1610h2.h |3 +- include/configs/omap1610inn.h|3 +- include/configs/omap2420h4.h |3 +- include/configs/omap3_sdp3430.h |3 +- include/configs/omap5912osk.h|3 +- include/configs/omap730p2.h |3 +- include/configs/pleb2.h |6 +- include/netdev.h |1 + include/pci_ids.h|1 + net/Makefile | 12 +- net/bootp.c |4 - net/eth.c|7 +- net/net.c|4 - net/nfs.c|4 - net/rarp.c |4 - net/tftp.c | 36 ++- 41 files changed, 452 insertions(+), 389 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Time is fluid ... like a river with currents, eddies, backwash. -- Spock, The City on the Edge of Forever, stardate 3134.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/25] Blackfin: kill off useless initdram() usage
On Thursday 17 December 2009 16:33:46 Wolfgang Denk wrote: Mike Frysinger wrote: While the initdram() function makes sense on some arches, it doesn't for Blackfin systems as it's always implemented the same way. Would it not make sense to start using get_ram_size(), too? i havent heard of this function before. looking through the tree, it seems like this is an optional board-specific function that probes external memory sizes by reading/writing to it. on a Blackfin system, this is a pretty big waste. memory must always be mapped starting at address 0 which means once the highest address is validated, things can return. ignoring that, the Blackfin port has no relocation support, so the link time addresses are fixed. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 22/25] Blackfin: pull io funcs from linux
On Thursday 17 December 2009 16:43:11 Wolfgang Denk wrote: Mike Frysinger wrote: Some common code uses more of the io.h funcs than we currently provide, so pull in all of the ones from the linux kernel. ... +/* We are single threaded most of the time */ +#define CONFIG_BFIN_INS_LOWOVERHEAD Most of the time? I'd say U-Boot is always single-threaded? it's referring to no interrupts being used most of the time, not there being multiple threads. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 25/25] Blackfin: add support for BF527-EZKIT v2.1
On Thursday 17 December 2009 16:47:20 Wolfgang Denk wrote: Mike Frysinger wrote: From: Michael Hennerich michael.henner...@analog.com The new board revision has a different LCD. Signed-off-by: Michael Hennerich michael.henner...@analog.com Signed-off-by: Mike Frysinger vap...@gentoo.org --- i've removed include/asm-blackfin/bfin_logo_rgb565_230x230.h from the diffstat since it's so big (120kb) and it's generated output from easylogo and the Blackfin .tga. Seems you removed it not fromthe diffstat, but from the patch itself? that's what i meant -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add ASTRO MCF5373L board
Dear Wolfgang Wegner,
In message 1260378648-19232-1-git-send-email-w.weg...@astro-kom.de you wrote:
This patch adds support for ASTRO board(s) based on MCF5373L.
Signed-off-by: Wolfgang Wegner w.weg...@astro-kom.de
---
There is another board (series) in the queue to be submitted, thus
I added a subdirectory for all our boards.
Makefile | 12 +
board/astro/mcf5373l/Makefile| 44 +++
board/astro/mcf5373l/astro.h | 39 +++
board/astro/mcf5373l/config.mk | 28 ++
board/astro/mcf5373l/fpga.c | 424 +++
board/astro/mcf5373l/mcf5373l.c | 204 +++
board/astro/mcf5373l/u-boot.lds | 142
board/astro/mcf5373l/update.c| 699
++
include/configs/astro_mcf5373l.h | 516
9 files changed, 2108 insertions(+), 0 deletions(-)
create mode 100644 board/astro/mcf5373l/Makefile
create mode 100644 board/astro/mcf5373l/astro.h
create mode 100644 board/astro/mcf5373l/config.mk
create mode 100644 board/astro/mcf5373l/fpga.c
create mode 100644 board/astro/mcf5373l/mcf5373l.c
create mode 100644 board/astro/mcf5373l/u-boot.lds
create mode 100644 board/astro/mcf5373l/update.c
create mode 100644 include/configs/astro_mcf5373l.h
Entries for MAINTAINERS and MAKEALL missing.
diff --git a/Makefile b/Makefile
index 75b2c1e..924e210 100644
--- a/Makefile
+++ b/Makefile
@@ -2263,6 +2263,18 @@ M5485HFE_config : unconfig
TASREG_config : unconfig
@$(MKCONFIG) $(@:_config=) m68k mcf52x2 tasreg esd
+astro_mcf5373l_config \
+astro_mcf5373l_ram_config : unconfig
+ @if [ $@ = astro_mcf5373l_ram_config ] ; then \
+ echo #define CONFIG_MONITOR_IS_IN_RAM
$(obj)include/config.h ; \
+ echo TEXT_BASE = 0x4002
$(obj)board/astro/mcf5373l/config.tmp ; \
+ $(XECHO) ... for RAM boot ... ; \
+ else \
+ echo TEXT_BASE = 0x
$(obj)board/astro/mcf5373l/config.tmp ; \
+ $(XECHO) ... for FLASH boot ... ; \
+ fi
+ @$(MKCONFIG) -a astro_mcf5373l m68k mcf532x mcf5373l astro
Please keep lists sorted, and don't add such scripting to the
Makefile. It is not needed any more.
diff --git a/board/astro/mcf5373l/astro.h b/board/astro/mcf5373l/astro.h
new file mode 100644
index 000..9478787
--- /dev/null
+++ b/board/astro/mcf5373l/astro.h
...
+typedef struct _s_karten_id {
+ char Kartentyp;
+ char Hardwareversion;
+ char Softwareversion;
+ char SoftwareSubversion;/* ,a,..z */
+ char FPGA_Version_Alt;
+ char FPGA_Version_Xil;
+} s_karten_id;
Variable names must be all lower case. Please fix globally.
+typedef struct {
+ unsigned char mode;
+ unsigned char deviation;
+ unsigned short freq;
+} __attribute__ ((packed)) s_output_params;
And please decide for one language. Don;t use half german and half
English names. Note that English is striclty preferred.
diff --git a/board/astro/mcf5373l/fpga.c b/board/astro/mcf5373l/fpga.c
new file mode 100644
index 000..eb1bf49
--- /dev/null
+++ b/board/astro/mcf5373l/fpga.c
...
+/*
+ * Altera/Xilinx FPGA configuration support for the ASTRO URMEL board
+ */
+
+#include common.h
+#include watchdog.h
+#include altera.h
+#include ACEX1K.h
+#include spartan3.h
+#include command.h
+#include asm/immap_5329.h
+#include fpga.h
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int altera_pre_fn (int cookie)
+{
+ volatile gpio_t *gpiop = (volatile gpio_t *)MMAP_GPIO;
+
+/* first, set the required pins to GPIO function */
Incorrect indentation. Please fix globally.
+ /* PAR_T0IN - GPIO */
+ gpiop-par_timer = 0xfc;
Please use I/O accessors to access device registers. Please fix
globally.
+
+/* writes the complete buffer to the FPGA
+ writing the complete buffer in one function is much faster,
+ then calling it for every bit */
Incorrect multiline comment. Please fix globally.
+/*
+ * Test the state of the active-low FPGA INIT line. Return 1 on INIT
+ * asserted (low).
+ */
+int xilinx_init_fn (int cookie)
+{
+ unsigned char state;
+ volatile gpio_t *gpiop = (volatile gpio_t *)MMAP_GPIO;
+
+ state = (gpiop-ppd_pwm 0x08) 3;
+ if (state)
+ return 0;
+ else
+ return 1;
Simplify:
return ((gpiop-ppd_pwm 0x08) != 0);
(but use I/O accessor instead.
--- /dev/null
+++ b/board/astro/mcf5373l/mcf5373l.c
...
+ return CONFIG_SYS_SDRAM_SIZE * 1024 * 1024;
Use get_ram_size() ?
+int testdram (void)
+{
+ printf (DRAM test not implemented!\n);
+
+ return (0);
+}
We already have a number of memory tests. Don't reinvent the wheel.
+void astro_put_char (char ch)
+{
+ volatile uart_t *uart;
+ int i;
+
+ uart = (volatile uart_t *)(MMAP_UART0);
+ /* Wait for last character to go. */
+ for (i = 0; (i 0x1);
Re: [U-Boot] [PATCH 07/25] Blackfin: do not require CONFIG_BAUDRATE
On Thursday 17 December 2009 16:32:38 Wolfgang Denk wrote:
Mike Frysinger wrote:
Signed-off-by: Mike Frysinger vap...@gentoo.org
---
cpu/blackfin/initcode.c |3 +++
lib_blackfin/board.c|2 ++
2 files changed, 5 insertions(+), 0 deletions(-)
...
static int init_baudrate(void)
{
+#ifdef CONFIG_BAUDRATE
char baudrate[15];
int i = getenv_r(baudrate, baudrate, sizeof(baudrate));
gd-bd-bi_baudrate = gd-baudrate = (i 0)
? simple_strtoul(baudrate, NULL, 10)
: CONFIG_BAUDRATE;
+#endif
return 0;
}
Out of curiosity: what do these boards do when CONFIG_BAUDRATE is not
defined?
the boards lack serial and/or dont use it. they're controlled via JTAG.
It seems yo me you add a new, additional meaning to the
CONFIG_BAUDRATE option here. This should be documented (at least in
the README).
i could just fall back to a value of 0 ... there'd be a little more useless
code added, but not much to be done here seeing as how the rest of u-boot
assumes baudrate is usable.
-mike
signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Makefile: fix parallel build
Dear Daniel Hobi,
In message 1260885106-3494-1-git-send-email-daniel.h...@schmid-telecom.ch you
wrote:
During parallel build, the top Makefile spawns multiple sub-makes for
targets in cpu/$(CPU) and $(dir $(LDSCRIPT)). If the .depend files are
not present in these directories, the sub-makes may end up generating
these files simultaneously which leads to corrupted content.
...
diff --git a/Makefile b/Makefile
index 19b5ac0..e9be7a5 100644
--- a/Makefile
+++ b/Makefile
@@ -400,7 +400,8 @@ env:
$(MAKE) -C tools/env all MTD_VERSION=${MTD_VERSION} || exit 1
depend dep: $(TIMESTAMP_FILE) $(VERSION_FILE) $(obj)include/autoconf.mk
- for dir in $(SUBDIRS) ; do $(MAKE) -C $$dir _depend ; done
+ for dir in $(SUBDIRS) cpu/$(CPU) $(dir $(LDSCRIPT)) ; do \
+ $(MAKE) -C $$dir _depend ; done
I ageree with Mike: please add a comment here.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The important thing about being a leader is not being right or wrong,
but being *certain*.- Terry Pratchett, _Truckers_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added
Dear Peter Tyser, In message 1260988086.11634.3576.ca...@localhost.localdomain you wrote: I see. It'd be nice to put some of the above information in the U-Boot commit logs to give people an idea about what's going on without having to use google, etc. ...and even better in some doc/README.??? so it is part of the source code. I haven't looked at the code differences between the sp3xx boards, but you might be able to use 1 common board file/header file to support them all. For example, take a look at the M5475AFE_config rule in U-Boot's ./Makefile. Some extra code in the Makefile and some #ifdefs in the sp3xx code might accommodate all 3 boards. Extra code in the Makefile should not be needed any more. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Zero is an enigmatic value. It can mean success (fclose) or failure (scanf). It can mean black or white. It can mean no permissions (chmod) or all permissions (umask). It can mean now (setjmp) or later (atexit). It can mean the beginning (lseek) or the end (read). It can mean myself (getpgrp) or child (fork). It can mean all (kill's 1st argument) or nothing (kill's 2nd argument). It can mean `default' (SIG_IGN) or `I don't care' (waitpid) or `try to guess' (strtol). Indeed 0 lets you talk to God (setuid). Verily is 0 all things to all people. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/25] Blackfin: kill off useless initdram() usage
Dear Mike Frysinger, In message 200912171723.51435.vap...@gentoo.org you wrote: Would it not make sense to start using get_ram_size(), too? i havent heard of this function before. looking through the tree, it seems Seems you have ignored a lot of messages on this list ;-) like this is an optional board-specific function that probes external memory sizes by reading/writing to it. Right, with at least two purposes: detecting memroy errors, and determining the available memory size. on a Blackfin system, this is a pretty big waste. memory must always be Waste in terms of ... ? mapped starting at address 0 which means once the highest address is validated, things can return. ignoring that, the Blackfin port has no relocation support, so the link time addresses are fixed. The memory test alone is a pretty good reason to add this. And don;t you have boards with multiple configurations / different RAM sizes where auto-sizing would be useful? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Worlds are conquered, galaxies destroyed -- but a woman is always a woman. -- Kirk, Conscience of the King, stardate unknown ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added
Hi Wolfgang, snip I haven't looked at the code differences between the sp3xx boards, but you might be able to use 1 common board file/header file to support them all. For example, take a look at the M5475AFE_config rule in U-Boot's ./Makefile. Some extra code in the Makefile and some #ifdefs in the sp3xx code might accommodate all 3 boards. Extra code in the Makefile should not be needed any more. To be clear, you still think its a good idea to look into combining the similar boards, correct? I haven't dealt with the MKCONFIG voodoo, so maybe I chose a poor example. Perhaps the CPCI405 and friends is a better example? Best, Peter ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/25] Blackfin: kill off useless initdram() usage
On Thursday 17 December 2009 17:48:48 Wolfgang Denk wrote: Mike Frysinger wrote: like this is an optional board-specific function that probes external memory sizes by reading/writing to it. Right, with at least two purposes: detecting memroy errors, and determining the available memory size. the memory error checking is kind of lame. i cant imagine it catching anything useful which the board crashing doesnt already tell you -- things are screwed. on a Blackfin system, this is a pretty big waste. memory must always be Waste in terms of ... ? if it's only detecting memory, then probing all the way down to the base is a waste of time. mapped starting at address 0 which means once the highest address is validated, things can return. ignoring that, the Blackfin port has no relocation support, so the link time addresses are fixed. The memory test alone is a pretty good reason to add this. And don;t you have boards with multiple configurations / different RAM sizes where auto-sizing would be useful? not really, and we havent had a customer ask for this kind of functionality. we do however get people always asking for faster loading times. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/9] SPEAr600 SoC support added
Dear Peter Tyser, In message 1261090481.11634.5308.ca...@localhost.localdomain you wrote: I haven't looked at the code differences between the sp3xx boards, but you might be able to use 1 common board file/header file to support them all. For example, take a look at the M5475AFE_config rule in U-Boot's ./Makefile. Some extra code in the Makefile and some #ifdefs in the sp3xx code might accommodate all 3 boards. Extra code in the Makefile should not be needed any more. To be clear, you still think its a good idea to look into combining the similar boards, correct? I haven't dealt with the MKCONFIG voodoo, so Yes, of course. maybe I chose a poor example. Perhaps the CPCI405 and friends is a better example? Or this: 2485 P1011RDB_config \ 2486 P1011RDB_NAND_config \ 2487 P1011RDB_SDCARD_config \ 2488 P1011RDB_SPIFLASH_config \ 2489 P1020RDB_config \ 2490 P1020RDB_NAND_config \ 2491 P1020RDB_SDCARD_config \ 2492 P1020RDB_SPIFLASH_config \ 2493 P2010RDB_config \ 2494 P2010RDB_NAND_config \ 2495 P2010RDB_SDCARD_config \ 2496 P2010RDB_SPIFLASH_config \ 2497 P2020RDB_config \ 2498 P2020RDB_NAND_config \ 2499 P2020RDB_SDCARD_config \ 2500 P2020RDB_SPIFLASH_config: unconfig 2501 @$(MKCONFIG) -t $(@:_config=) P1_P2_RDB ppc mpc85xx p1_p2_rdb freescale No scripting any more in the Makefile :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Vulcans worship peace above all. -- McCoy, Return to Tomorrow, stardate 4768.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] MPC8313 with 512MB SDRAM, u-boot version 1.3.0
Hi, Did anybody get 512MB DDR SDRAM working on MPC8313? My board here didn't work. In u-boot source, I changed CFG_DDRCONFIG to handle the 512MB ICs, changed CFG_IBAT_0U and CFG_DBAT_0U to handle 512MB, defined CONFIG_VERY_LAGE_RAM and CONFIG_MAX_MEM_MAPPED. When I set the CFG_DDR_SIZE to 256 to use only half memory, u-boot and Linux kernel (2.6.23) worked fine on this board. When I change CFG_DDR_SIZE to 512 to use all the memory, u-boot seems happy without error reporting, but crashed when booting the kernel. Any help is highly appreciated. Following is the boot log: U-Boot 1.3.0 (Dec 17 2009 - 15:04:24) MPC83XX Reset Status: External/Internal Soft, External/Internal Hard CPU: e300c3, MPC8313E, Rev: 21 at 333.333 MHz, CSB: 166 MHz Board: ePM8313 I2C: ready DRAM: 512 MB FLASH: 32 MB NAND: 64 MiB In:serial Out: serial Err: serial Net: TSEC0 [PRIME], TSEC1 Hit any key to stop autoboot: 0 ## Booting image at f808 ... Image Name: Linux-2.6.23 Created: 2009-12-02 18:38:53 UTC Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size:1685120 Bytes = 1.6 MB Load Address: Entry Point: Verifying Checksum ... OK Uncompressing Kernel Image ... OK ## Loading RAMDisk Image at f832 ... Image Name: Ramdisk Image Created: 2009-10-29 0:30:48 UTC Image Type: PowerPC Linux RAMDisk Image (gzip compressed) Data Size:5136056 Bytes = 4.9 MB Load Address: Entry Point: Verifying Checksum ... OK Booting using the fdt at 0xf830 Loading Ramdisk to 0fa52000, end 0ff37eb8 ... OK Loading Device Tree to 007fc000, end 007fefff ... OK Using ePM8313 machine description Linux version 2.6.23 (r...@davidlaptopduo) (gcc version 4.2.2) #49 Wed Dec 2 10:38:51 PST 2009 Found initrd at 0xcfa52000:0xcff37eb8 console [udbg0] enabled setup_arch: bootmem epm8313e_setup_arch() arch: exit Zone PFN ranges: DMA 0 - 131072 Normal 131072 - 131072 Movable zone start PFN for each node early_node_map[1] active PFN ranges 0:0 - 131072 Built 1 zonelists in Zone order. Total pages: 130048 Kernel command line: root=/dev/ram rw ramdisk_size=81976 PID hash table entries: 2048 (order: 11, 8192 bytes) I-pipe 2.0-02: pipeline enabled. Dentry cache hash table entries: 65536 (order: 6, 262144 bytes) Inode-cache hash table entries: 32768 (order: 5, 131072 bytes) Memory: 510592k/524288k available (3376k kernel code, 13300k reserved, 152k data, 212k bss, 160k init) Mount-cache hash table entries: 512 [ cut here ] Badness at c017e7b8 [verbose debug info unavailable] NIP: c017e7b8 LR: c000d6a8 CTR: REGS: c0373e70 TRAP: 0700 Not tainted (2.6.23) MSR: 00029032 EE,ME,IR,DR CR: 84042048 XER: TASK = c034f208[0] 'swapper' THREAD: c0372000 GPR00: 0001 c0373f20 c034f208 d00c dffe5e08 GPR08: 0005 dffe8778 003f 24042022 100aec40 0fffb000 GPR16: 007ffc00 004e5eb8 007ffbb0 f8320040 0ff37eb8 0fff7298 GPR24: 0fa52000 c037741c c034e000 dfffeee8 dfffef3a dfffefd8 Call Trace: [c0373f20] [c00df258] (unreliable) [c0373f30] [c022f4dc] [c0373f40] [c00df324] [c0373f60] [c00df318] [c0373f80] [c00df318] [c0373fa0] [c00df48c] [c0373fb0] [c03385f8] [c0373fc0] [c03249c8] [c0373ff0] [3438] Instruction dump: 409e0010 7c8903a6 4e800421 3801 7c030378 80010014 38210010 7c0803a6 4e800020 8003 7c34 5400d97e 0f00 7d201828 31290001 7d20192d WARNING: Bad of_node_put() on Call Trace: [c0373ec0] [c0007b5c] (unreliable) [c0373f00] [c000db50] [c0373f20] [c017e794] [c0373f30] [c000d678] [c0373f40] [c00df390] [c0373f60] [c00df318] [c0373f80] [c00df318] [c0373fa0] [c00df48c] [c0373fb0] [c03385f8] [c0373fc0] [c03249c8] [c0373ff0] [3438] [ cut here ] Badness at c017e7b8 [verbose debug info unavailable] NIP: c017e7b8 LR: c000d6a8 CTR: 0009 REGS: c0373e90 TRAP: 0700 Not tainted (2.6.23) MSR: 00029032 EE,ME,IR,DR CR: 84042048 XER: TASK = c034f208[0] 'swapper' THREAD: c0372000 GPR00: 0001 c0373f40 c034f208 d0b4 dfffeee8 0009 dffe5984 GPR08: dffe 0004 dffe8778 006e 22042042 100aec40 0fffb000 GPR16: 007ffc00 004e5eb8 007ffbb0 f8320040 0ff37eb8 0fff7298 GPR24: 0fa52000 c037741c c034e000 dfffecd8 dfffef3a dfffeee8 d080 Call Trace: [c0373f40] [c00df3b0] (unreliable) [c0373f50] [c022f4dc] [c0373f60] [c00df324] [c0373f80] [c00df318] [c0373fa0] [c00df48c] [c0373fb0] [c03385f8] [c0373fc0] [c03249c8] [c0373ff0] [3438] Instruction dump: 409e0010 7c8903a6 4e800421 3801 7c030378 80010014 38210010 7c0803a6 4e800020 8003 7c34 5400d97e 0f00 7d201828 31290001 7d20192d Unable to handle kernel paging request for data at address 0x Faulting instruction address: 0xc0014a08 Oops: Kernel
Re: [U-Boot] [PATCH] add ASTRO MCF5373L board
Dear Wolfgang Denk,
thank you for all the comments and suggestions and sorry for that
many reasons to complain!
I just would like to ask a few questions in-line.
On Thu, Dec 17, 2009 at 11:33:07PM +0100, Wolfgang Denk wrote:
Dear Wolfgang Wegner,
In message 1260378648-19232-1-git-send-email-w.weg...@astro-kom.de you
wrote:
--- a/Makefile
+++ b/Makefile
@@ -2263,6 +2263,18 @@ M5485HFE_config :unconfig
TASREG_config :unconfig
@$(MKCONFIG) $(@:_config=) m68k mcf52x2 tasreg esd
+astro_mcf5373l_config \
+astro_mcf5373l_ram_config :unconfig
+ @if [ $@ = astro_mcf5373l_ram_config ] ; then \
+ echo #define CONFIG_MONITOR_IS_IN_RAM
$(obj)include/config.h ; \
+ echo TEXT_BASE = 0x4002
$(obj)board/astro/mcf5373l/config.tmp ; \
+ $(XECHO) ... for RAM boot ... ; \
+ else \
+ echo TEXT_BASE = 0x
$(obj)board/astro/mcf5373l/config.tmp ; \
+ $(XECHO) ... for FLASH boot ... ; \
+ fi
+ @$(MKCONFIG) -a astro_mcf5373l m68k mcf532x mcf5373l astro
Please keep lists sorted, and don't add such scripting to the
Makefile. It is not needed any more.
How can I avoid this scripting? I took the freescale EVM boards as a
reference. Could you please point me to a better example on how to
set these variables, especially TEXT_BASE, on a per-target basis?
+ /* PAR_T0IN - GPIO */
+ gpiop-par_timer = 0xfc;
Please use I/O accessors to access device registers. Please fix
globally.
Sorry if this is a stupid question, but so this should read:
tmp_char = readb(gpiop-par_timer);
tmp_char = 0xfc;
writeb(tmp_char, gpiop-par_timer);
And how about word and long-word registers? As far as I understand
from asm-m68k/io.h, the I/O accessors do byte-swap, how does this
make sense on a big-endian-only device?
Do you really need a board specific linker script?
Probably not in this case, but unfortunately this is what all
current Coldfire boards do, and I am not familiar enough with
ld to overlook which consequences changing this might have.
(It may be trivial for MCF53xx, but for other devices like
MCF5445x with the possibility for serial boot, there are
big differences between the different linker files.)
+void do_crc (unsigned char data)
+{
Cool. Yet another CRC function :-(
I have no choice here. The CRC algorithm is dictated, so either
I can use an already existing CRC function implementing exactly
this scheme (sorry for not having searched for it yet), or I have
to implement it here. :-(
+ s = flash_full_status_check_nb (flash_info, fl_sector,
+ 0, erase);
+ if (s != ERR_BUSY) {
+ if (s == ERR_OK) {
+ flash_sect_count++;
+ flash_prog_stat = FL_STAT_IDLE;
+ }
+ else
And again. Please fix indentation globally.
Sorry to ask, but which part of indentation is wrong here?
(Except the else/if you quoted in the other examples)
Regards,
Wolfgang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Invitation to connect on LinkedIn
LinkedIn Bai Shuwei requested to add you as a connection on LinkedIn: -- Srinath, I'd like to add you to my professional network on LinkedIn. - Bai Accept invitation from Bai Shuwei http://www.linkedin.com/e/YhLefj14Y3m-0E8v1ZCDgtixJP5Kn9_7/blk/I1669366652_2/pmpxnSRJrSdvj4R5fnhv9ClRsDgZp6lQs6lzoQ5AomZIpn8_cBYOdjoSdzcVdzoNiiZ9q4kJsQVUiyYTd3wVdjwUcPALrCBxbOYWrSlI/EML_comm_afe/ View invitation from Bai Shuwei http://www.linkedin.com/e/YhLefj14Y3m-0E8v1ZCDgtixJP5Kn9_7/blk/I1669366652_2/39vczkSdzoPejoSckALqnpPbOYWrSlI/svi/ -- DID YOU KNOW that LinkedIn can find the answers to your most difficult questions? Post those vexing questions on LinkedIn Answers to tap into the knowledge of the world's foremost business experts: http://www.linkedin.com/e/ask/inv-23/ -- (c) 2009, LinkedIn Corporation ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Build breakage in qemu-mips
Hi All, I cloned the git tree of Wolfgang and tried compilation of qemu_mips_config. But the build breaks with following error: zlib.c:31:27: error: asm/unaligned.h: No such file or directory zlib.c: In function ‘inflate_fast’: zlib.c:641: warning: implicit declaration of function ‘get_unaligned’ make[1]: *** [zlib.o] Error 1 make[1]: Leaving directory `/home/hschauhan/Development/u-boot/lib_generic' make: *** [lib_generic/libgeneric.a] Error 2 I see that in include directory asm points to asm-mips. Inside asm-mips there is another link arch-arch-mips which is a dead link. THere is no directory named arch-mips there. Whats the problem here? Should I pull only the MIPS custodian tree? Thanks Best Regards Himanshu ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
