Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

Hi


On Wed, Mar 23, 2022 at 1:06 PM Gaurav Jain  wrote:
>
> Hi Michael
>
> > -Original Message-
> > From: Michael Nazzareno Trimarchi 
> > Sent: Saturday, March 19, 2022 11:30 PM
> > To: Tom Rini 
> > Cc: Fabio Estevam ; Gaurav Jain
> > ; Stefano Babic ; Michael Walle
> > ; Varun Sethi ; Adrian Alonso
> > ; Alison Wang ; Andy Tang
> > ; Franck Lenormand ;
> > Horia Geanta ; Ji Luo ;
> > ma...@denx.de; Meenakshi Aggarwal ;
> > Mingkai Hu ; olte...@gmail.com; Pankaj Gupta
> > ; Peng Fan ; Pramod Kumar
> > ; Priyanka Jain ; Rajesh
> > Bhagat ; Sahil Malhotra ;
> > Shengzhou Liu ; Silvano Di Ninno
> > ; s...@chromium.org; u-boot@lists.denx.de; dl-
> > uboot-imx ; Wasim Khan ; Ye Li
> > ; Raffaele RECALCATI ; Jagan
> > Teki 
> > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> > ring driver model
> >
> > Caution: EXT Email
> >
> > HI Tom
> >
> > On Sat, Mar 19, 2022 at 6:51 PM Tom Rini  wrote:
> > >
> > > On Sat, Mar 19, 2022 at 06:49:25PM +0100, Michael Nazzareno Trimarchi
> > wrote:
> > > > HI Tom
> > > >
> > > > On Sat, Mar 19, 2022 at 6:44 PM Tom Rini  wrote:
> > > > >
> > > > > On Sat, Mar 19, 2022 at 06:37:18PM +0100, Michael Nazzareno Trimarchi
> > wrote:
> > > > > > Hi Tom
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 6:30 PM Tom Rini  wrote:
> > > > > > >
> > > > > > > On Sat, Mar 19, 2022 at 06:27:38PM +0100, Michael Nazzareno
> > Trimarchi wrote:
> > > > > > > > Hi
> > > > > > > >
> > > > > > > > On Sat, Mar 19, 2022 at 6:25 PM Tom Rini 
> > wrote:
> > > > > > > > >
> > > > > > > > > On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno
> > Trimarchi wrote:
> > > > > > > > > > Hi Tom
> > > > > > > > > >
> > > > > > > > > > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini 
> > > > > > > > > > 
> > wrote:
> > > > > > > > > > >
> > > > > > > > > > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael 
> > > > > > > > > > > Nazzareno
> > Trimarchi wrote:
> > > > > > > > > > > > Hi Tom
> > > > > > > > > > > >
> > > > > > > > > > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini
> >  wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael
> > Nazzareno Trimarchi wrote:
> > > > > > > > > > > > > > Hi
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam
> >  wrote:
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Hi Michael,
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael
> > > > > > > > > > > > > > > Nazzareno Trimarchi 
> > wrote:
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > HI
> > > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > > Please send me a link to apply your series
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > You can get the series from patchwork (just
> > > > > > > > > > > > > > > click in the 'series' button)
> > > > > > > > > > > > > > > https://eur01.safelinks.protection.outlook.com
> > > > > > > > > > > > > > > /?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpro
> > > > > > > > > > > > > > > ject%2Fuboot%2Fpatch%2F20220112133127.16880-2-
> > > > > > > > > > > > > > >

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hi Michael

> -Original Message-
> From: Michael Nazzareno Trimarchi 
> Sent: Saturday, March 19, 2022 11:30 PM
> To: Tom Rini 
> Cc: Fabio Estevam ; Gaurav Jain
> ; Stefano Babic ; Michael Walle
> ; Varun Sethi ; Adrian Alonso
> ; Alison Wang ; Andy Tang
> ; Franck Lenormand ;
> Horia Geanta ; Ji Luo ;
> ma...@denx.de; Meenakshi Aggarwal ;
> Mingkai Hu ; olte...@gmail.com; Pankaj Gupta
> ; Peng Fan ; Pramod Kumar
> ; Priyanka Jain ; Rajesh
> Bhagat ; Sahil Malhotra ;
> Shengzhou Liu ; Silvano Di Ninno
> ; s...@chromium.org; u-boot@lists.denx.de; dl-
> uboot-imx ; Wasim Khan ; Ye Li
> ; Raffaele RECALCATI ; Jagan
> Teki 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Caution: EXT Email
> 
> HI Tom
> 
> On Sat, Mar 19, 2022 at 6:51 PM Tom Rini  wrote:
> >
> > On Sat, Mar 19, 2022 at 06:49:25PM +0100, Michael Nazzareno Trimarchi
> wrote:
> > > HI Tom
> > >
> > > On Sat, Mar 19, 2022 at 6:44 PM Tom Rini  wrote:
> > > >
> > > > On Sat, Mar 19, 2022 at 06:37:18PM +0100, Michael Nazzareno Trimarchi
> wrote:
> > > > > Hi Tom
> > > > >
> > > > > On Sat, Mar 19, 2022 at 6:30 PM Tom Rini  wrote:
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 06:27:38PM +0100, Michael Nazzareno
> Trimarchi wrote:
> > > > > > > Hi
> > > > > > >
> > > > > > > On Sat, Mar 19, 2022 at 6:25 PM Tom Rini 
> wrote:
> > > > > > > >
> > > > > > > > On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno
> Trimarchi wrote:
> > > > > > > > > Hi Tom
> > > > > > > > >
> > > > > > > > > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini 
> wrote:
> > > > > > > > > >
> > > > > > > > > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno
> Trimarchi wrote:
> > > > > > > > > > > Hi Tom
> > > > > > > > > > >
> > > > > > > > > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini
>  wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael
> Nazzareno Trimarchi wrote:
> > > > > > > > > > > > > Hi
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam
>  wrote:
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Hi Michael,
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael
> > > > > > > > > > > > > > Nazzareno Trimarchi 
> wrote:
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > HI
> > > > > > > > > > > > > > >
> > > > > > > > > > > > > > > Please send me a link to apply your series
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > You can get the series from patchwork (just
> > > > > > > > > > > > > > click in the 'series' button)
> > > > > > > > > > > > > > https://eur01.safelinks.protection.outlook.com
> > > > > > > > > > > > > > /?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpro
> > > > > > > > > > > > > > ject%2Fuboot%2Fpatch%2F20220112133127.16880-2-
> > > > > > > > > > > > > > gaurav.jain%40nxp.com%2F&data=04%7C01%7Cga
> > > > > > > > > > > > > > urav.jain%40nxp.com%7Cf2e5639efe9e491287e008da
> > > > > > > > > > > > > > 09d260f9%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> > > > > > > > > > > > > >
> 0%7C0%7C637833096989631395%7CUnknown%7CTWFpbGZ
> > > > > > > > > > > > > > sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBT
> > > > > > > > > > > > > > iI6

R: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Raffaele RECALCATI]

Hi Michael,

>HI Tom
>
>On Sat, Mar 19, 2022 at 6:51 PM Tom Rini  wrote:
>>
>> On Sat, Mar 19, 2022 at 06:49:25PM +0100, Michael Nazzareno Trimarchi wrote:
>> > HI Tom
>> >
>> > On Sat, Mar 19, 2022 at 6:44 PM Tom Rini  wrote:
>> > >
>> > > On Sat, Mar 19, 2022 at 06:37:18PM +0100, Michael Nazzareno Trimarchi 
>> > > wrote:
>> > > > Hi Tom
>> > > >
>> > > > On Sat, Mar 19, 2022 at 6:30 PM Tom Rini  wrote:
>> > > > >
>> > > > > On Sat, Mar 19, 2022 at 06:27:38PM +0100, Michael Nazzareno 
>> > > > > Trimarchi wrote:
>> > > > > > Hi
>> > > > > >
>> > > > > > On Sat, Mar 19, 2022 at 6:25 PM Tom Rini  
>> > > > > > wrote:
>> > > > > > >
>> > > > > > > On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno 
>> > > > > > > Trimarchi wrote:
>> > > > > > > > Hi Tom
>>> > > > > > > >
>>> > > > > > > > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  
>>> > > > > > > > wrote:
>>> > > > > > > > >
 > > > > > > > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael 
 > > > > > > > > Nazzareno Trimarchi wrote:
 > > > > > > > > > Hi Tom
>>> > > > > > > > > >
>>> > > > > > > > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini 
>>> > > > > > > > > >  wrote:
>> > > > > > > > > > >
>> > > > > > > > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael 
>> > > > > > > > > > > Nazzareno Trimarchi wrote:
>> > > > > > > > > > > > Hi
>> > > > > > > > > > > >
>> > > > > > > > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam 
>> > > > > > > > > > > >  wrote:
>> > > > > > > > > > > > >
>> > > > > > > > > > > > > Hi Michael,
>> > > > > > > > > > > > >
>> > > > > > > > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno 
>> > > > > > > > > > > > > Trimarchi
>> > > > > > > > > > > > >  wrote:
>> > > > > > > > > > > > > >
>> > > > > > > > > > > > > > HI
>> > > > > > > > > > > > > >
>> > > > > > > > > > > > > > Please send me a link to apply your series
>> > > > > > > > > > > > >
>> > > > > > > > > > > > > You can get the series from patchwork (just click in 
>> > > > > > > > > > > > > the 'series' button)
>> > > > > > > > > > > > > https://eur01.safelinks.protection.outlook.com/?>url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20220112133127.16880-2->gaurav.jain%40nxp.com%2F&data=04%7C01%7Craffaele.recalcati%40bticino.it%7Cd7b85983151448602>62808da09d260da%7C199686b5bef4496087867a6b1888fee3%7C1%7C0%7C637833096424290979%7CUnkn>own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30>00&sdata=cLvLVUDGQzJ7VTyzBrTqOeobl0lgBOxJtmhV2RMjvB0%3D&reserved=0url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20220112133127.16880-2-gaurav.jain%40nxp.com%2F&data=04%7C01%7Craffaele.recalcati%40bticino.it%7Cd7b8598315144860262808da09d260da%7C199686b5bef4496087867a6b1888fee3%7C1%7C0%7C637833096424290979%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=cLvLVUDGQzJ7VTyzBrTqOeobl0lgBOxJtmhV2RMjvB0%3D&reserved=0>
>> > > > > > > > > > > >
>> > > > > > > > > > > > Done, well, I have tried remove DM_GPIO in SPL. Seems 
>> > > > > > > > > > > > that I need to
>> > > > > > > > > > > > remove a lot of features. I have tested LTO build but 
>> > > > > > > > > > > > size
>> > > > > > > > > > > > of SPL increase. Is that strange?
>> > > > > > > > > > >
>> > > > > > > > > > > That is very strange.  Can you post your patches 
>> > > > > > > > > > > somewhere?
>> > > > > > > > > > >
>> > > > > > > > > > > --
>> > > > > > > > > > > Tom
>> > > > > > > > > >
>> > > > > > > > > > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
>> > > > > > > > > > export ARCH=arm
>> > > > > > > > > > export CROSS_COMPILE=arm-linux-gnueabihf-
>> > > > > > > > > >
>> > > > > > > > > > make imx6dl_mamoj_defconfig
>> > > > > > > > > > build it
>> > > > > > > > > >
>> > > > > > > > > > Try then to enable LTO and build it again
>> > > > > > > > > >
>> > > > > > > > > > spl/u-boot-spl.bin exceeds file size limit:
>> > > > > > > > > >   limit:  0xefa0 bytes
>> > > > > > > > > >   actual: 0xf071 bytes
>> > > > > > > > > >   excess: 0xd1 bytes
>> > > > > > > > > >
>> > > > > > > > > > So LTO does not help even on beginning on this board. You 
>> > > > > > > > > > don't need
>> > > > > > > > > > to apply any patch for this test
>> > > > > > > > >
>> > > > > > > > > I think that's some artifact of mixing LTO/non-LTO and the 
>> > > > > > > > > world not
>> > > > > > > > > getting rebuilt?  Just enabling LTO after the defconfig 
>> > > > > > > > > works fine and
>> > > > > > > > > is smaller than before.
>> > > > > > > >
>> > > > > > > > In order to save space I did not change what we have. Every 
>> > > > > > > > build starts from
>> > > > > > > > a mrproper and new configuration. I can not mix LTO/non-LTO in 
>> > > > > > > > this case. I'm
>> > > > > > > > using upstream defconfig and upstream defconfig + LTO enabled 
>> > > > > > > > and the result is
>> > > > > > > > that spl increase in size for LTO 

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

HI Tom

On Sat, Mar 19, 2022 at 6:51 PM Tom Rini  wrote:
>
> On Sat, Mar 19, 2022 at 06:49:25PM +0100, Michael Nazzareno Trimarchi wrote:
> > HI Tom
> >
> > On Sat, Mar 19, 2022 at 6:44 PM Tom Rini  wrote:
> > >
> > > On Sat, Mar 19, 2022 at 06:37:18PM +0100, Michael Nazzareno Trimarchi 
> > > wrote:
> > > > Hi Tom
> > > >
> > > > On Sat, Mar 19, 2022 at 6:30 PM Tom Rini  wrote:
> > > > >
> > > > > On Sat, Mar 19, 2022 at 06:27:38PM +0100, Michael Nazzareno Trimarchi 
> > > > > wrote:
> > > > > > Hi
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 6:25 PM Tom Rini  wrote:
> > > > > > >
> > > > > > > On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno 
> > > > > > > Trimarchi wrote:
> > > > > > > > Hi Tom
> > > > > > > >
> > > > > > > > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno 
> > > > > > > > > Trimarchi wrote:
> > > > > > > > > > Hi Tom
> > > > > > > > > >
> > > > > > > > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini 
> > > > > > > > > >  wrote:
> > > > > > > > > > >
> > > > > > > > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael 
> > > > > > > > > > > Nazzareno Trimarchi wrote:
> > > > > > > > > > > > Hi
> > > > > > > > > > > >
> > > > > > > > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam 
> > > > > > > > > > > >  wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > > Hi Michael,
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno 
> > > > > > > > > > > > > Trimarchi
> > > > > > > > > > > > >  wrote:
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > HI
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > Please send me a link to apply your series
> > > > > > > > > > > > >
> > > > > > > > > > > > > You can get the series from patchwork (just click in 
> > > > > > > > > > > > > the 'series' button)
> > > > > > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > > > > > > > > > > >
> > > > > > > > > > > > Done, well, I have tried remove DM_GPIO in SPL. Seems 
> > > > > > > > > > > > that I need to
> > > > > > > > > > > > remove a lot of features. I have tested LTO build but 
> > > > > > > > > > > > size
> > > > > > > > > > > > of SPL increase. Is that strange?
> > > > > > > > > > >
> > > > > > > > > > > That is very strange.  Can you post your patches 
> > > > > > > > > > > somewhere?
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Tom
> > > > > > > > > >
> > > > > > > > > > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> > > > > > > > > > export ARCH=arm
> > > > > > > > > > export CROSS_COMPILE=arm-linux-gnueabihf-
> > > > > > > > > >
> > > > > > > > > > make imx6dl_mamoj_defconfig
> > > > > > > > > > build it
> > > > > > > > > >
> > > > > > > > > > Try then to enable LTO and build it again
> > > > > > > > > >
> > > > > > > > > > spl/u-boot-spl.bin exceeds file size limit:
> > > > > > > > > >   limit:  0xefa0 bytes
> > > > > > > > > >   actual: 0xf071 bytes
> > > > > > > > > >   excess: 0xd1 bytes
> > > > > > > > > >
> > > > > > > > > > So LTO does not help even on beginning on this board. You 
> > > > > > > > > > don't need
> > > > > > > > > > to apply any patch for this test
> > > > > > > > >
> > > > > > > > > I think that's some artifact of mixing LTO/non-LTO and the 
> > > > > > > > > world not
> > > > > > > > > getting rebuilt?  Just enabling LTO after the defconfig works 
> > > > > > > > > fine and
> > > > > > > > > is smaller than before.
> > > > > > > >
> > > > > > > > In order to save space I did not change what we have. Every 
> > > > > > > > build starts from
> > > > > > > > a mrproper and new configuration. I can not mix LTO/non-LTO in 
> > > > > > > > this case. I'm
> > > > > > > > using upstream defconfig and upstream defconfig + LTO enabled 
> > > > > > > > and the result is
> > > > > > > > that spl increase in size for LTO building. I'm working to keep 
> > > > > > > > out
> > > > > > > > part that are not really needed but
> > > > > > > > I was hoping that LTO give me some help here
> > > > > > >
> > > > > > > Yes, LTO saves about 5KiB on the SPL binary.  You just need to 
> > > > > > > enable it
> > > > > > > in the config before you start building, not after you've built
> > > > > > > everything once.
> > > > > >
> > > > > > Offcourse ;) but this not the case. I don't drink enough to think 
> > > > > > that
> > > > > > change a config, decrease the build size ;)
> > > > >
> > > > > LTO is an entirely different way of the compiler / linker optimizing 
> > > > > the
> > > > > binary.  So yes, in this case enabling a single option decreases the
> > > > > size.
> > > >
> > > >
> > > > I think we are in a circle. Let's have the result with LTO
> > > >
> > > > spl/keep-syms-lto.c
> > > >   ( cd spl && arm-linux-gnueabihf-gcc -nostdlib -nostartfiles
> > > > -fuse-linker-plugin -flto=8 -Wall -Wstrict-pro

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Tom Rini]

On Sat, Mar 19, 2022 at 06:49:25PM +0100, Michael Nazzareno Trimarchi wrote:
> HI Tom
> 
> On Sat, Mar 19, 2022 at 6:44 PM Tom Rini  wrote:
> >
> > On Sat, Mar 19, 2022 at 06:37:18PM +0100, Michael Nazzareno Trimarchi wrote:
> > > Hi Tom
> > >
> > > On Sat, Mar 19, 2022 at 6:30 PM Tom Rini  wrote:
> > > >
> > > > On Sat, Mar 19, 2022 at 06:27:38PM +0100, Michael Nazzareno Trimarchi 
> > > > wrote:
> > > > > Hi
> > > > >
> > > > > On Sat, Mar 19, 2022 at 6:25 PM Tom Rini  wrote:
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno 
> > > > > > Trimarchi wrote:
> > > > > > > Hi Tom
> > > > > > >
> > > > > > > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno 
> > > > > > > > Trimarchi wrote:
> > > > > > > > > Hi Tom
> > > > > > > > >
> > > > > > > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno 
> > > > > > > > > > Trimarchi wrote:
> > > > > > > > > > > Hi
> > > > > > > > > > >
> > > > > > > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam 
> > > > > > > > > > >  wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > Hi Michael,
> > > > > > > > > > > >
> > > > > > > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno 
> > > > > > > > > > > > Trimarchi
> > > > > > > > > > > >  wrote:
> > > > > > > > > > > > >
> > > > > > > > > > > > > HI
> > > > > > > > > > > > >
> > > > > > > > > > > > > Please send me a link to apply your series
> > > > > > > > > > > >
> > > > > > > > > > > > You can get the series from patchwork (just click in 
> > > > > > > > > > > > the 'series' button)
> > > > > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > > > > > > > > > >
> > > > > > > > > > > Done, well, I have tried remove DM_GPIO in SPL. Seems 
> > > > > > > > > > > that I need to
> > > > > > > > > > > remove a lot of features. I have tested LTO build but size
> > > > > > > > > > > of SPL increase. Is that strange?
> > > > > > > > > >
> > > > > > > > > > That is very strange.  Can you post your patches somewhere?
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Tom
> > > > > > > > >
> > > > > > > > > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> > > > > > > > > export ARCH=arm
> > > > > > > > > export CROSS_COMPILE=arm-linux-gnueabihf-
> > > > > > > > >
> > > > > > > > > make imx6dl_mamoj_defconfig
> > > > > > > > > build it
> > > > > > > > >
> > > > > > > > > Try then to enable LTO and build it again
> > > > > > > > >
> > > > > > > > > spl/u-boot-spl.bin exceeds file size limit:
> > > > > > > > >   limit:  0xefa0 bytes
> > > > > > > > >   actual: 0xf071 bytes
> > > > > > > > >   excess: 0xd1 bytes
> > > > > > > > >
> > > > > > > > > So LTO does not help even on beginning on this board. You 
> > > > > > > > > don't need
> > > > > > > > > to apply any patch for this test
> > > > > > > >
> > > > > > > > I think that's some artifact of mixing LTO/non-LTO and the 
> > > > > > > > world not
> > > > > > > > getting rebuilt?  Just enabling LTO after the defconfig works 
> > > > > > > > fine and
> > > > > > > > is smaller than before.
> > > > > > >
> > > > > > > In order to save space I did not change what we have. Every build 
> > > > > > > starts from
> > > > > > > a mrproper and new configuration. I can not mix LTO/non-LTO in 
> > > > > > > this case. I'm
> > > > > > > using upstream defconfig and upstream defconfig + LTO enabled and 
> > > > > > > the result is
> > > > > > > that spl increase in size for LTO building. I'm working to keep 
> > > > > > > out
> > > > > > > part that are not really needed but
> > > > > > > I was hoping that LTO give me some help here
> > > > > >
> > > > > > Yes, LTO saves about 5KiB on the SPL binary.  You just need to 
> > > > > > enable it
> > > > > > in the config before you start building, not after you've built
> > > > > > everything once.
> > > > >
> > > > > Offcourse ;) but this not the case. I don't drink enough to think that
> > > > > change a config, decrease the build size ;)
> > > >
> > > > LTO is an entirely different way of the compiler / linker optimizing the
> > > > binary.  So yes, in this case enabling a single option decreases the
> > > > size.
> > >
> > >
> > > I think we are in a circle. Let's have the result with LTO
> > >
> > > spl/keep-syms-lto.c
> > >   ( cd spl && arm-linux-gnueabihf-gcc -nostdlib -nostartfiles
> > > -fuse-linker-plugin -flto=8 -Wall -Wstrict-prototypes
> > > -Wno-format-security -fno-builtin -ffreestanding -std=gnu11
> > > -fshort-wchar -fno-strict-aliasing -fno-PIE -Os  -flto=8
> > > -fno-stack-protector -fno-delete-null-pointer-checks -Wno-pointer-sign
> > > -Wno-stringop-truncation  -Wno-array-bounds -Wno-stringop-overflow
> > > -Wno-maybe-uninitialized -fmacro-prefix-map=./= -g -fstack-usage
> > > -

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

HI Tom

On Sat, Mar 19, 2022 at 6:44 PM Tom Rini  wrote:
>
> On Sat, Mar 19, 2022 at 06:37:18PM +0100, Michael Nazzareno Trimarchi wrote:
> > Hi Tom
> >
> > On Sat, Mar 19, 2022 at 6:30 PM Tom Rini  wrote:
> > >
> > > On Sat, Mar 19, 2022 at 06:27:38PM +0100, Michael Nazzareno Trimarchi 
> > > wrote:
> > > > Hi
> > > >
> > > > On Sat, Mar 19, 2022 at 6:25 PM Tom Rini  wrote:
> > > > >
> > > > > On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno Trimarchi 
> > > > > wrote:
> > > > > > Hi Tom
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  wrote:
> > > > > > >
> > > > > > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno 
> > > > > > > Trimarchi wrote:
> > > > > > > > Hi Tom
> > > > > > > >
> > > > > > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  
> > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno 
> > > > > > > > > Trimarchi wrote:
> > > > > > > > > > Hi
> > > > > > > > > >
> > > > > > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam 
> > > > > > > > > >  wrote:
> > > > > > > > > > >
> > > > > > > > > > > Hi Michael,
> > > > > > > > > > >
> > > > > > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno 
> > > > > > > > > > > Trimarchi
> > > > > > > > > > >  wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > HI
> > > > > > > > > > > >
> > > > > > > > > > > > Please send me a link to apply your series
> > > > > > > > > > >
> > > > > > > > > > > You can get the series from patchwork (just click in the 
> > > > > > > > > > > 'series' button)
> > > > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > > > > > > > > >
> > > > > > > > > > Done, well, I have tried remove DM_GPIO in SPL. Seems that 
> > > > > > > > > > I need to
> > > > > > > > > > remove a lot of features. I have tested LTO build but size
> > > > > > > > > > of SPL increase. Is that strange?
> > > > > > > > >
> > > > > > > > > That is very strange.  Can you post your patches somewhere?
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Tom
> > > > > > > >
> > > > > > > > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> > > > > > > > export ARCH=arm
> > > > > > > > export CROSS_COMPILE=arm-linux-gnueabihf-
> > > > > > > >
> > > > > > > > make imx6dl_mamoj_defconfig
> > > > > > > > build it
> > > > > > > >
> > > > > > > > Try then to enable LTO and build it again
> > > > > > > >
> > > > > > > > spl/u-boot-spl.bin exceeds file size limit:
> > > > > > > >   limit:  0xefa0 bytes
> > > > > > > >   actual: 0xf071 bytes
> > > > > > > >   excess: 0xd1 bytes
> > > > > > > >
> > > > > > > > So LTO does not help even on beginning on this board. You don't 
> > > > > > > > need
> > > > > > > > to apply any patch for this test
> > > > > > >
> > > > > > > I think that's some artifact of mixing LTO/non-LTO and the world 
> > > > > > > not
> > > > > > > getting rebuilt?  Just enabling LTO after the defconfig works 
> > > > > > > fine and
> > > > > > > is smaller than before.
> > > > > >
> > > > > > In order to save space I did not change what we have. Every build 
> > > > > > starts from
> > > > > > a mrproper and new configuration. I can not mix LTO/non-LTO in this 
> > > > > > case. I'm
> > > > > > using upstream defconfig and upstream defconfig + LTO enabled and 
> > > > > > the result is
> > > > > > that spl increase in size for LTO building. I'm working to keep out
> > > > > > part that are not really needed but
> > > > > > I was hoping that LTO give me some help here
> > > > >
> > > > > Yes, LTO saves about 5KiB on the SPL binary.  You just need to enable 
> > > > > it
> > > > > in the config before you start building, not after you've built
> > > > > everything once.
> > > >
> > > > Offcourse ;) but this not the case. I don't drink enough to think that
> > > > change a config, decrease the build size ;)
> > >
> > > LTO is an entirely different way of the compiler / linker optimizing the
> > > binary.  So yes, in this case enabling a single option decreases the
> > > size.
> >
> >
> > I think we are in a circle. Let's have the result with LTO
> >
> > spl/keep-syms-lto.c
> >   ( cd spl && arm-linux-gnueabihf-gcc -nostdlib -nostartfiles
> > -fuse-linker-plugin -flto=8 -Wall -Wstrict-prototypes
> > -Wno-format-security -fno-builtin -ffreestanding -std=gnu11
> > -fshort-wchar -fno-strict-aliasing -fno-PIE -Os  -flto=8
> > -fno-stack-protector -fno-delete-null-pointer-checks -Wno-pointer-sign
> > -Wno-stringop-truncation  -Wno-array-bounds -Wno-stringop-overflow
> > -Wno-maybe-uninitialized -fmacro-prefix-map=./= -g -fstack-usage
> > -Wno-format-nonliteral -Wno-address-of-packed-member
> > -Wno-unused-but-set-variable -Werror=date-time -Wno-packed-not-aligned
> >  -ffunction-sections -fdata-sections -fno-stack-protector -D__KERNEL__
> > -D__UBOOT__  -DCONFIG_SPL_BUILD  -D__ARM__ -Wa,-mimplicit-it=always
> > -mthumb -mthumb-interwork  -mabi=aapcs-linux  -mno-unaligned-ac

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Tom Rini]

On Sat, Mar 19, 2022 at 06:37:18PM +0100, Michael Nazzareno Trimarchi wrote:
> Hi Tom
> 
> On Sat, Mar 19, 2022 at 6:30 PM Tom Rini  wrote:
> >
> > On Sat, Mar 19, 2022 at 06:27:38PM +0100, Michael Nazzareno Trimarchi wrote:
> > > Hi
> > >
> > > On Sat, Mar 19, 2022 at 6:25 PM Tom Rini  wrote:
> > > >
> > > > On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno Trimarchi 
> > > > wrote:
> > > > > Hi Tom
> > > > >
> > > > > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  wrote:
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno 
> > > > > > Trimarchi wrote:
> > > > > > > Hi Tom
> > > > > > >
> > > > > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno 
> > > > > > > > Trimarchi wrote:
> > > > > > > > > Hi
> > > > > > > > >
> > > > > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam 
> > > > > > > > >  wrote:
> > > > > > > > > >
> > > > > > > > > > Hi Michael,
> > > > > > > > > >
> > > > > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
> > > > > > > > > >  wrote:
> > > > > > > > > > >
> > > > > > > > > > > HI
> > > > > > > > > > >
> > > > > > > > > > > Please send me a link to apply your series
> > > > > > > > > >
> > > > > > > > > > You can get the series from patchwork (just click in the 
> > > > > > > > > > 'series' button)
> > > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > > > > > > > >
> > > > > > > > > Done, well, I have tried remove DM_GPIO in SPL. Seems that I 
> > > > > > > > > need to
> > > > > > > > > remove a lot of features. I have tested LTO build but size
> > > > > > > > > of SPL increase. Is that strange?
> > > > > > > >
> > > > > > > > That is very strange.  Can you post your patches somewhere?
> > > > > > > >
> > > > > > > > --
> > > > > > > > Tom
> > > > > > >
> > > > > > > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> > > > > > > export ARCH=arm
> > > > > > > export CROSS_COMPILE=arm-linux-gnueabihf-
> > > > > > >
> > > > > > > make imx6dl_mamoj_defconfig
> > > > > > > build it
> > > > > > >
> > > > > > > Try then to enable LTO and build it again
> > > > > > >
> > > > > > > spl/u-boot-spl.bin exceeds file size limit:
> > > > > > >   limit:  0xefa0 bytes
> > > > > > >   actual: 0xf071 bytes
> > > > > > >   excess: 0xd1 bytes
> > > > > > >
> > > > > > > So LTO does not help even on beginning on this board. You don't 
> > > > > > > need
> > > > > > > to apply any patch for this test
> > > > > >
> > > > > > I think that's some artifact of mixing LTO/non-LTO and the world not
> > > > > > getting rebuilt?  Just enabling LTO after the defconfig works fine 
> > > > > > and
> > > > > > is smaller than before.
> > > > >
> > > > > In order to save space I did not change what we have. Every build 
> > > > > starts from
> > > > > a mrproper and new configuration. I can not mix LTO/non-LTO in this 
> > > > > case. I'm
> > > > > using upstream defconfig and upstream defconfig + LTO enabled and the 
> > > > > result is
> > > > > that spl increase in size for LTO building. I'm working to keep out
> > > > > part that are not really needed but
> > > > > I was hoping that LTO give me some help here
> > > >
> > > > Yes, LTO saves about 5KiB on the SPL binary.  You just need to enable it
> > > > in the config before you start building, not after you've built
> > > > everything once.
> > >
> > > Offcourse ;) but this not the case. I don't drink enough to think that
> > > change a config, decrease the build size ;)
> >
> > LTO is an entirely different way of the compiler / linker optimizing the
> > binary.  So yes, in this case enabling a single option decreases the
> > size.
> 
> 
> I think we are in a circle. Let's have the result with LTO
> 
> spl/keep-syms-lto.c
>   ( cd spl && arm-linux-gnueabihf-gcc -nostdlib -nostartfiles
> -fuse-linker-plugin -flto=8 -Wall -Wstrict-prototypes
> -Wno-format-security -fno-builtin -ffreestanding -std=gnu11
> -fshort-wchar -fno-strict-aliasing -fno-PIE -Os  -flto=8
> -fno-stack-protector -fno-delete-null-pointer-checks -Wno-pointer-sign
> -Wno-stringop-truncation  -Wno-array-bounds -Wno-stringop-overflow
> -Wno-maybe-uninitialized -fmacro-prefix-map=./= -g -fstack-usage
> -Wno-format-nonliteral -Wno-address-of-packed-member
> -Wno-unused-but-set-variable -Werror=date-time -Wno-packed-not-aligned
>  -ffunction-sections -fdata-sections -fno-stack-protector -D__KERNEL__
> -D__UBOOT__  -DCONFIG_SPL_BUILD  -D__ARM__ -Wa,-mimplicit-it=always
> -mthumb -mthumb-interwork  -mabi=aapcs-linux  -mno-unaligned-access
> -fno-common -ffixed-r9  -msoft-float -mgeneral-regs-only-pipe
> -march=armv7-a -D__LINUX_ARM_ARCH__=7 -mtune=generic-armv7-a
> -Ispl/include -Iinclude -I./arch/arm/include -include
> ./include/linux/kconfig.h  -nostdinc -isystem
> /usr/lib/gcc-cross/arm-linux-gnueabihf/9/include  -Wl,-T
> -Wl,u-boot-spl.lds -Wl,-Bstatic 

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

Hi Tom

On Sat, Mar 19, 2022 at 6:30 PM Tom Rini  wrote:
>
> On Sat, Mar 19, 2022 at 06:27:38PM +0100, Michael Nazzareno Trimarchi wrote:
> > Hi
> >
> > On Sat, Mar 19, 2022 at 6:25 PM Tom Rini  wrote:
> > >
> > > On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno Trimarchi 
> > > wrote:
> > > > Hi Tom
> > > >
> > > > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  wrote:
> > > > >
> > > > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno Trimarchi 
> > > > > wrote:
> > > > > > Hi Tom
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  wrote:
> > > > > > >
> > > > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno 
> > > > > > > Trimarchi wrote:
> > > > > > > > Hi
> > > > > > > >
> > > > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam 
> > > > > > > >  wrote:
> > > > > > > > >
> > > > > > > > > Hi Michael,
> > > > > > > > >
> > > > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
> > > > > > > > >  wrote:
> > > > > > > > > >
> > > > > > > > > > HI
> > > > > > > > > >
> > > > > > > > > > Please send me a link to apply your series
> > > > > > > > >
> > > > > > > > > You can get the series from patchwork (just click in the 
> > > > > > > > > 'series' button)
> > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > > > > > > >
> > > > > > > > Done, well, I have tried remove DM_GPIO in SPL. Seems that I 
> > > > > > > > need to
> > > > > > > > remove a lot of features. I have tested LTO build but size
> > > > > > > > of SPL increase. Is that strange?
> > > > > > >
> > > > > > > That is very strange.  Can you post your patches somewhere?
> > > > > > >
> > > > > > > --
> > > > > > > Tom
> > > > > >
> > > > > > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> > > > > > export ARCH=arm
> > > > > > export CROSS_COMPILE=arm-linux-gnueabihf-
> > > > > >
> > > > > > make imx6dl_mamoj_defconfig
> > > > > > build it
> > > > > >
> > > > > > Try then to enable LTO and build it again
> > > > > >
> > > > > > spl/u-boot-spl.bin exceeds file size limit:
> > > > > >   limit:  0xefa0 bytes
> > > > > >   actual: 0xf071 bytes
> > > > > >   excess: 0xd1 bytes
> > > > > >
> > > > > > So LTO does not help even on beginning on this board. You don't need
> > > > > > to apply any patch for this test
> > > > >
> > > > > I think that's some artifact of mixing LTO/non-LTO and the world not
> > > > > getting rebuilt?  Just enabling LTO after the defconfig works fine and
> > > > > is smaller than before.
> > > >
> > > > In order to save space I did not change what we have. Every build 
> > > > starts from
> > > > a mrproper and new configuration. I can not mix LTO/non-LTO in this 
> > > > case. I'm
> > > > using upstream defconfig and upstream defconfig + LTO enabled and the 
> > > > result is
> > > > that spl increase in size for LTO building. I'm working to keep out
> > > > part that are not really needed but
> > > > I was hoping that LTO give me some help here
> > >
> > > Yes, LTO saves about 5KiB on the SPL binary.  You just need to enable it
> > > in the config before you start building, not after you've built
> > > everything once.
> >
> > Offcourse ;) but this not the case. I don't drink enough to think that
> > change a config, decrease the build size ;)
>
> LTO is an entirely different way of the compiler / linker optimizing the
> binary.  So yes, in this case enabling a single option decreases the
> size.


I think we are in a circle. Let's have the result with LTO

spl/keep-syms-lto.c
  ( cd spl && arm-linux-gnueabihf-gcc -nostdlib -nostartfiles
-fuse-linker-plugin -flto=8 -Wall -Wstrict-prototypes
-Wno-format-security -fno-builtin -ffreestanding -std=gnu11
-fshort-wchar -fno-strict-aliasing -fno-PIE -Os  -flto=8
-fno-stack-protector -fno-delete-null-pointer-checks -Wno-pointer-sign
-Wno-stringop-truncation  -Wno-array-bounds -Wno-stringop-overflow
-Wno-maybe-uninitialized -fmacro-prefix-map=./= -g -fstack-usage
-Wno-format-nonliteral -Wno-address-of-packed-member
-Wno-unused-but-set-variable -Werror=date-time -Wno-packed-not-aligned
 -ffunction-sections -fdata-sections -fno-stack-protector -D__KERNEL__
-D__UBOOT__  -DCONFIG_SPL_BUILD  -D__ARM__ -Wa,-mimplicit-it=always
-mthumb -mthumb-interwork  -mabi=aapcs-linux  -mno-unaligned-access
-fno-common -ffixed-r9  -msoft-float -mgeneral-regs-only-pipe
-march=armv7-a -D__LINUX_ARM_ARCH__=7 -mtune=generic-armv7-a
-Ispl/include -Iinclude -I./arch/arm/include -include
./include/linux/kconfig.h  -nostdinc -isystem
/usr/lib/gcc-cross/arm-linux-gnueabihf/9/include  -Wl,-T
-Wl,u-boot-spl.lds -Wl,-Bstatic -Wl,--gc-sections
-Wl,--no-dynamic-linker -Wl,--build-id=none -Wl,-Ttext -Wl,0x00908000
arch/arm/cpu/armv7/start.o -Wl,--whole-archive
arch/arm/cpu/armv7/built-in.o arch/arm/cpu/built-in.o
arch/arm/lib/built-in.o arch/arm/mach-imx/built-in.o
board/bticino/mamoj/built-in.o common/spl/built-in.o
common/init/built-in.o boot/built-in.o common/built-in.

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Tom Rini]

On Sat, Mar 19, 2022 at 06:27:38PM +0100, Michael Nazzareno Trimarchi wrote:
> Hi
> 
> On Sat, Mar 19, 2022 at 6:25 PM Tom Rini  wrote:
> >
> > On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno Trimarchi wrote:
> > > Hi Tom
> > >
> > > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  wrote:
> > > >
> > > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno Trimarchi 
> > > > wrote:
> > > > > Hi Tom
> > > > >
> > > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  wrote:
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno 
> > > > > > Trimarchi wrote:
> > > > > > > Hi
> > > > > > >
> > > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam 
> > > > > > >  wrote:
> > > > > > > >
> > > > > > > > Hi Michael,
> > > > > > > >
> > > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
> > > > > > > >  wrote:
> > > > > > > > >
> > > > > > > > > HI
> > > > > > > > >
> > > > > > > > > Please send me a link to apply your series
> > > > > > > >
> > > > > > > > You can get the series from patchwork (just click in the 
> > > > > > > > 'series' button)
> > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > > > > > >
> > > > > > > Done, well, I have tried remove DM_GPIO in SPL. Seems that I need 
> > > > > > > to
> > > > > > > remove a lot of features. I have tested LTO build but size
> > > > > > > of SPL increase. Is that strange?
> > > > > >
> > > > > > That is very strange.  Can you post your patches somewhere?
> > > > > >
> > > > > > --
> > > > > > Tom
> > > > >
> > > > > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> > > > > export ARCH=arm
> > > > > export CROSS_COMPILE=arm-linux-gnueabihf-
> > > > >
> > > > > make imx6dl_mamoj_defconfig
> > > > > build it
> > > > >
> > > > > Try then to enable LTO and build it again
> > > > >
> > > > > spl/u-boot-spl.bin exceeds file size limit:
> > > > >   limit:  0xefa0 bytes
> > > > >   actual: 0xf071 bytes
> > > > >   excess: 0xd1 bytes
> > > > >
> > > > > So LTO does not help even on beginning on this board. You don't need
> > > > > to apply any patch for this test
> > > >
> > > > I think that's some artifact of mixing LTO/non-LTO and the world not
> > > > getting rebuilt?  Just enabling LTO after the defconfig works fine and
> > > > is smaller than before.
> > >
> > > In order to save space I did not change what we have. Every build starts 
> > > from
> > > a mrproper and new configuration. I can not mix LTO/non-LTO in this case. 
> > > I'm
> > > using upstream defconfig and upstream defconfig + LTO enabled and the 
> > > result is
> > > that spl increase in size for LTO building. I'm working to keep out
> > > part that are not really needed but
> > > I was hoping that LTO give me some help here
> >
> > Yes, LTO saves about 5KiB on the SPL binary.  You just need to enable it
> > in the config before you start building, not after you've built
> > everything once.
> 
> Offcourse ;) but this not the case. I don't drink enough to think that
> change a config, decrease the build size ;)

LTO is an entirely different way of the compiler / linker optimizing the
binary.  So yes, in this case enabling a single option decreases the
size.

-- 
Tom


signature.asc
Description: PGP signature

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

Hi

On Sat, Mar 19, 2022 at 6:25 PM Tom Rini  wrote:
>
> On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno Trimarchi wrote:
> > Hi Tom
> >
> > On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  wrote:
> > >
> > > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno Trimarchi 
> > > wrote:
> > > > Hi Tom
> > > >
> > > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  wrote:
> > > > >
> > > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno Trimarchi 
> > > > > wrote:
> > > > > > Hi
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam  
> > > > > > wrote:
> > > > > > >
> > > > > > > Hi Michael,
> > > > > > >
> > > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
> > > > > > >  wrote:
> > > > > > > >
> > > > > > > > HI
> > > > > > > >
> > > > > > > > Please send me a link to apply your series
> > > > > > >
> > > > > > > You can get the series from patchwork (just click in the 'series' 
> > > > > > > button)
> > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > > > > >
> > > > > > Done, well, I have tried remove DM_GPIO in SPL. Seems that I need to
> > > > > > remove a lot of features. I have tested LTO build but size
> > > > > > of SPL increase. Is that strange?
> > > > >
> > > > > That is very strange.  Can you post your patches somewhere?
> > > > >
> > > > > --
> > > > > Tom
> > > >
> > > > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> > > > export ARCH=arm
> > > > export CROSS_COMPILE=arm-linux-gnueabihf-
> > > >
> > > > make imx6dl_mamoj_defconfig
> > > > build it
> > > >
> > > > Try then to enable LTO and build it again
> > > >
> > > > spl/u-boot-spl.bin exceeds file size limit:
> > > >   limit:  0xefa0 bytes
> > > >   actual: 0xf071 bytes
> > > >   excess: 0xd1 bytes
> > > >
> > > > So LTO does not help even on beginning on this board. You don't need
> > > > to apply any patch for this test
> > >
> > > I think that's some artifact of mixing LTO/non-LTO and the world not
> > > getting rebuilt?  Just enabling LTO after the defconfig works fine and
> > > is smaller than before.
> >
> > In order to save space I did not change what we have. Every build starts 
> > from
> > a mrproper and new configuration. I can not mix LTO/non-LTO in this case. 
> > I'm
> > using upstream defconfig and upstream defconfig + LTO enabled and the 
> > result is
> > that spl increase in size for LTO building. I'm working to keep out
> > part that are not really needed but
> > I was hoping that LTO give me some help here
>
> Yes, LTO saves about 5KiB on the SPL binary.  You just need to enable it
> in the config before you start building, not after you've built
> everything once.

Offcourse ;) but this not the case. I don't drink enough to think that
change a config, decrease the build size ;)

Michael

>
> --
> Tom


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Tom Rini]

On Sat, Mar 19, 2022 at 06:08:18PM +0100, Michael Nazzareno Trimarchi wrote:
> Hi Tom
> 
> On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  wrote:
> >
> > On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno Trimarchi wrote:
> > > Hi Tom
> > >
> > > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  wrote:
> > > >
> > > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno Trimarchi 
> > > > wrote:
> > > > > Hi
> > > > >
> > > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam  
> > > > > wrote:
> > > > > >
> > > > > > Hi Michael,
> > > > > >
> > > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
> > > > > >  wrote:
> > > > > > >
> > > > > > > HI
> > > > > > >
> > > > > > > Please send me a link to apply your series
> > > > > >
> > > > > > You can get the series from patchwork (just click in the 'series' 
> > > > > > button)
> > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > > > >
> > > > > Done, well, I have tried remove DM_GPIO in SPL. Seems that I need to
> > > > > remove a lot of features. I have tested LTO build but size
> > > > > of SPL increase. Is that strange?
> > > >
> > > > That is very strange.  Can you post your patches somewhere?
> > > >
> > > > --
> > > > Tom
> > >
> > > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> > > export ARCH=arm
> > > export CROSS_COMPILE=arm-linux-gnueabihf-
> > >
> > > make imx6dl_mamoj_defconfig
> > > build it
> > >
> > > Try then to enable LTO and build it again
> > >
> > > spl/u-boot-spl.bin exceeds file size limit:
> > >   limit:  0xefa0 bytes
> > >   actual: 0xf071 bytes
> > >   excess: 0xd1 bytes
> > >
> > > So LTO does not help even on beginning on this board. You don't need
> > > to apply any patch for this test
> >
> > I think that's some artifact of mixing LTO/non-LTO and the world not
> > getting rebuilt?  Just enabling LTO after the defconfig works fine and
> > is smaller than before.
> 
> In order to save space I did not change what we have. Every build starts from
> a mrproper and new configuration. I can not mix LTO/non-LTO in this case. I'm
> using upstream defconfig and upstream defconfig + LTO enabled and the result 
> is
> that spl increase in size for LTO building. I'm working to keep out
> part that are not really needed but
> I was hoping that LTO give me some help here

Yes, LTO saves about 5KiB on the SPL binary.  You just need to enable it
in the config before you start building, not after you've built
everything once.

-- 
Tom


signature.asc
Description: PGP signature

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

Hi Tom

On Sat, Mar 19, 2022 at 6:03 PM Tom Rini  wrote:
>
> On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno Trimarchi wrote:
> > Hi Tom
> >
> > On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  wrote:
> > >
> > > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno Trimarchi 
> > > wrote:
> > > > Hi
> > > >
> > > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam  
> > > > wrote:
> > > > >
> > > > > Hi Michael,
> > > > >
> > > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
> > > > >  wrote:
> > > > > >
> > > > > > HI
> > > > > >
> > > > > > Please send me a link to apply your series
> > > > >
> > > > > You can get the series from patchwork (just click in the 'series' 
> > > > > button)
> > > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > > >
> > > > Done, well, I have tried remove DM_GPIO in SPL. Seems that I need to
> > > > remove a lot of features. I have tested LTO build but size
> > > > of SPL increase. Is that strange?
> > >
> > > That is very strange.  Can you post your patches somewhere?
> > >
> > > --
> > > Tom
> >
> > Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> > export ARCH=arm
> > export CROSS_COMPILE=arm-linux-gnueabihf-
> >
> > make imx6dl_mamoj_defconfig
> > build it
> >
> > Try then to enable LTO and build it again
> >
> > spl/u-boot-spl.bin exceeds file size limit:
> >   limit:  0xefa0 bytes
> >   actual: 0xf071 bytes
> >   excess: 0xd1 bytes
> >
> > So LTO does not help even on beginning on this board. You don't need
> > to apply any patch for this test
>
> I think that's some artifact of mixing LTO/non-LTO and the world not
> getting rebuilt?  Just enabling LTO after the defconfig works fine and
> is smaller than before.
>

In order to save space I did not change what we have. Every build starts from
a mrproper and new configuration. I can not mix LTO/non-LTO in this case. I'm
using upstream defconfig and upstream defconfig + LTO enabled and the result is
that spl increase in size for LTO building. I'm working to keep out
part that are not really needed but
I was hoping that LTO give me some help here

Michael


> --
> Tom



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Tom Rini]

On Sat, Mar 19, 2022 at 05:48:59PM +0100, Michael Nazzareno Trimarchi wrote:
> Hi Tom
> 
> On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  wrote:
> >
> > On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno Trimarchi wrote:
> > > Hi
> > >
> > > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam  wrote:
> > > >
> > > > Hi Michael,
> > > >
> > > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
> > > >  wrote:
> > > > >
> > > > > HI
> > > > >
> > > > > Please send me a link to apply your series
> > > >
> > > > You can get the series from patchwork (just click in the 'series' 
> > > > button)
> > > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> > >
> > > Done, well, I have tried remove DM_GPIO in SPL. Seems that I need to
> > > remove a lot of features. I have tested LTO build but size
> > > of SPL increase. Is that strange?
> >
> > That is very strange.  Can you post your patches somewhere?
> >
> > --
> > Tom
> 
> Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
> export ARCH=arm
> export CROSS_COMPILE=arm-linux-gnueabihf-
> 
> make imx6dl_mamoj_defconfig
> build it
> 
> Try then to enable LTO and build it again
> 
> spl/u-boot-spl.bin exceeds file size limit:
>   limit:  0xefa0 bytes
>   actual: 0xf071 bytes
>   excess: 0xd1 bytes
> 
> So LTO does not help even on beginning on this board. You don't need
> to apply any patch for this test

I think that's some artifact of mixing LTO/non-LTO and the world not
getting rebuilt?  Just enabling LTO after the defconfig works fine and
is smaller than before.

-- 
Tom


signature.asc
Description: PGP signature

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

Hi Tom

On Sat, Mar 19, 2022 at 5:05 PM Tom Rini  wrote:
>
> On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno Trimarchi wrote:
> > Hi
> >
> > On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam  wrote:
> > >
> > > Hi Michael,
> > >
> > > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
> > >  wrote:
> > > >
> > > > HI
> > > >
> > > > Please send me a link to apply your series
> > >
> > > You can get the series from patchwork (just click in the 'series' button)
> > > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> >
> > Done, well, I have tried remove DM_GPIO in SPL. Seems that I need to
> > remove a lot of features. I have tested LTO build but size
> > of SPL increase. Is that strange?
>
> That is very strange.  Can you post your patches somewhere?
>
> --
> Tom

Start from here 9776c4e9d00ac49d6388ffe9e084ff03b37ae479
export ARCH=arm
export CROSS_COMPILE=arm-linux-gnueabihf-

make imx6dl_mamoj_defconfig
build it

Try then to enable LTO and build it again

spl/u-boot-spl.bin exceeds file size limit:
  limit:  0xefa0 bytes
  actual: 0xf071 bytes
  excess: 0xd1 bytes

So LTO does not help even on beginning on this board. You don't need
to apply any patch for this test

Michael


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Tom Rini]

On Sat, Mar 19, 2022 at 02:51:01PM +0100, Michael Nazzareno Trimarchi wrote:
> Hi
> 
> On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam  wrote:
> >
> > Hi Michael,
> >
> > On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
> >  wrote:
> > >
> > > HI
> > >
> > > Please send me a link to apply your series
> >
> > You can get the series from patchwork (just click in the 'series' button)
> > https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/
> 
> Done, well, I have tried remove DM_GPIO in SPL. Seems that I need to
> remove a lot of features. I have tested LTO build but size
> of SPL increase. Is that strange?

That is very strange.  Can you post your patches somewhere?

-- 
Tom


signature.asc
Description: PGP signature

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

Hi

On Sat, Mar 19, 2022 at 2:25 PM Fabio Estevam  wrote:
>
> Hi Michael,
>
> On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
>  wrote:
> >
> > HI
> >
> > Please send me a link to apply your series
>
> You can get the series from patchwork (just click in the 'series' button)
> https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/

Done, well, I have tried remove DM_GPIO in SPL. Seems that I need to
remove a lot of features. I have tested LTO build but size
of SPL increase. Is that strange?

Michael

-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Fabio Estevam]

Hi Michael,

On Sat, Mar 19, 2022 at 6:47 AM Michael Nazzareno Trimarchi
 wrote:
>
> HI
>
> Please send me a link to apply your series

You can get the series from patchwork (just click in the 'series' button)
https://patchwork.ozlabs.org/project/uboot/patch/20220112133127.16880-2-gaurav.j...@nxp.com/

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

Hi Gaurav

On Sat, Mar 19, 2022 at 10:47 AM Michael Nazzareno Trimarchi
 wrote:
>
> HI
>
> Please send me a link to apply your series
>
> Michael
>
> On Thu, Mar 17, 2022 at 1:10 PM Gaurav Jain  wrote:
> >
> > Hello Michael
> >
> > A gentle reminder!!
> > As you said earlier, can you test the mamoj board with proposed solution to 
> > fix SPL size issue.
> >
> > Regards
> > Gaurav Jain
> >
> > > -Original Message-
> > > From: Gaurav Jain
> > > Sent: Monday, March 14, 2022 11:18 AM
> > > To: Michael Nazzareno Trimarchi ; Stefano
> > > Babic 
> > > Cc: Tom Rini ; Fabio Estevam ;
> > > Michael Walle ; Varun Sethi ; Adrian
> > > Alonso ; Alison Wang ;
> > > Andy Tang ; Franck Lenormand
> > > ; Horia Geanta ; Ji
> > > Luo ; ma...@denx.de; Meenakshi Aggarwal
> > > ; Mingkai Hu ;
> > > olte...@gmail.com; Pankaj Gupta ; Peng Fan
> > > ; Pramod Kumar ;
> > > Priyanka Jain ; Rajesh Bhagat
> > > ; Sahil Malhotra ;
> > > Shengzhou Liu ; Silvano Di Ninno
> > > ; s...@chromium.org; u-boot@lists.denx.de; dl-
> > > uboot-imx ; Wasim Khan ;
> > > Ye Li ; Raffaele RECALCATI ;
> > > Jagan Teki 
> > > Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM 
> > > Job
> > > ring driver model
> > >
> > > Hi Michael
> > >
> > > > -Original Message-
> > > > From: Michael Nazzareno Trimarchi 
> > > > Sent: Tuesday, March 8, 2022 7:05 PM
> > > > To: Stefano Babic 
> > > > Cc: Tom Rini ; Fabio Estevam
> > > ;
> > > > Gaurav Jain ; Michael Walle ;
> > > > Varun Sethi ; Adrian Alonso ;
> > > > Alison Wang ; Andy Tang ;
> > > > Franck Lenormand ; Horia Geanta
> > > > ; Ji Luo ; ma...@denx.de;
> > > > Meenakshi Aggarwal ; Mingkai Hu
> > > > ; olte...@gmail.com; Pankaj Gupta
> > > > ; Peng Fan ; Pramod Kumar
> > > > ; Priyanka Jain ;
> > > > Rajesh Bhagat ; Sahil Malhotra
> > > > ; Shengzhou Liu ;
> > > > Silvano Di Ninno ; s...@chromium.org; u-
> > > > b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> > > > ; Ye Li ; Raffaele RECALCATI
> > > > ; Jagan Teki
> > > > 
> > > > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > > > CAAM Job ring driver model
> > > >
> > > > Caution: EXT Email
> > > >
> > > > Hi
> > > >
> > > > On Tue, Mar 8, 2022 at 2:28 PM Stefano Babic  wrote:
> > > > >
> > > > > Hi Tom,
> > > > >
> > > > > On 08.03.22 13:48, Tom Rini wrote:
> > > > > > On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
> > > > > >> On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain 
> > > > wrote:
> > > > > >>
> > > > > >>> I further checked on your concern and propose the below change
> > > > > >>> to
> > > > stop building caam driver in SPL for imx6dl_mamoj.
> > > > > >>>
> > > > > >>> --- a/configs/imx6dl_mamoj_defconfig
> > > > > >>> +++ b/configs/imx6dl_mamoj_defconfig
> > > > > >>> @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> > > > > >>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> > > > > >>>   CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> > > > > >>>   CONFIG_CI_UDC=y
> > > > > >>> +CONFIG_SPL_CRYPTO=n
> > > > > >>
> > > > > >> No, this is not how defconfig works.
> > > > > >>
> > > > > >> You should set:
> > > > > >>
> > > > > >> # CONFIG_SPL_CRYPTO is not set
> > > > > >
> > > > > > But more, WHY is this the right answer?  You're disabling
> > > > > > functionality and the board maintainers aren't even on the CC list
> > > > > > for this thread it looks like.
> > > > >
> > > > > This was my blocking point, too, for this series. There is no answer
> > > > > about the board.
> > > > >
> > > > > I can just imagine (as for other MX6DL) that the required
> > > > > functionality is secure boot, then CONFIG_IMX_HAB is eno

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

HI

Please send me a link to apply your series

Michael

On Thu, Mar 17, 2022 at 1:10 PM Gaurav Jain  wrote:
>
> Hello Michael
>
> A gentle reminder!!
> As you said earlier, can you test the mamoj board with proposed solution to 
> fix SPL size issue.
>
> Regards
> Gaurav Jain
>
> > -Original Message-
> > From: Gaurav Jain
> > Sent: Monday, March 14, 2022 11:18 AM
> > To: Michael Nazzareno Trimarchi ; Stefano
> > Babic 
> > Cc: Tom Rini ; Fabio Estevam ;
> > Michael Walle ; Varun Sethi ; Adrian
> > Alonso ; Alison Wang ;
> > Andy Tang ; Franck Lenormand
> > ; Horia Geanta ; Ji
> > Luo ; ma...@denx.de; Meenakshi Aggarwal
> > ; Mingkai Hu ;
> > olte...@gmail.com; Pankaj Gupta ; Peng Fan
> > ; Pramod Kumar ;
> > Priyanka Jain ; Rajesh Bhagat
> > ; Sahil Malhotra ;
> > Shengzhou Liu ; Silvano Di Ninno
> > ; s...@chromium.org; u-boot@lists.denx.de; dl-
> > uboot-imx ; Wasim Khan ;
> > Ye Li ; Raffaele RECALCATI ;
> > Jagan Teki 
> > Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> > ring driver model
> >
> > Hi Michael
> >
> > > -Original Message-
> > > From: Michael Nazzareno Trimarchi 
> > > Sent: Tuesday, March 8, 2022 7:05 PM
> > > To: Stefano Babic 
> > > Cc: Tom Rini ; Fabio Estevam
> > ;
> > > Gaurav Jain ; Michael Walle ;
> > > Varun Sethi ; Adrian Alonso ;
> > > Alison Wang ; Andy Tang ;
> > > Franck Lenormand ; Horia Geanta
> > > ; Ji Luo ; ma...@denx.de;
> > > Meenakshi Aggarwal ; Mingkai Hu
> > > ; olte...@gmail.com; Pankaj Gupta
> > > ; Peng Fan ; Pramod Kumar
> > > ; Priyanka Jain ;
> > > Rajesh Bhagat ; Sahil Malhotra
> > > ; Shengzhou Liu ;
> > > Silvano Di Ninno ; s...@chromium.org; u-
> > > b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> > > ; Ye Li ; Raffaele RECALCATI
> > > ; Jagan Teki
> > > 
> > > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > > CAAM Job ring driver model
> > >
> > > Caution: EXT Email
> > >
> > > Hi
> > >
> > > On Tue, Mar 8, 2022 at 2:28 PM Stefano Babic  wrote:
> > > >
> > > > Hi Tom,
> > > >
> > > > On 08.03.22 13:48, Tom Rini wrote:
> > > > > On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
> > > > >> On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain 
> > > wrote:
> > > > >>
> > > > >>> I further checked on your concern and propose the below change
> > > > >>> to
> > > stop building caam driver in SPL for imx6dl_mamoj.
> > > > >>>
> > > > >>> --- a/configs/imx6dl_mamoj_defconfig
> > > > >>> +++ b/configs/imx6dl_mamoj_defconfig
> > > > >>> @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> > > > >>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> > > > >>>   CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> > > > >>>   CONFIG_CI_UDC=y
> > > > >>> +CONFIG_SPL_CRYPTO=n
> > > > >>
> > > > >> No, this is not how defconfig works.
> > > > >>
> > > > >> You should set:
> > > > >>
> > > > >> # CONFIG_SPL_CRYPTO is not set
> > > > >
> > > > > But more, WHY is this the right answer?  You're disabling
> > > > > functionality and the board maintainers aren't even on the CC list
> > > > > for this thread it looks like.
> > > >
> > > > This was my blocking point, too, for this series. There is no answer
> > > > about the board.
> > > >
> > > > I can just imagine (as for other MX6DL) that the required
> > > > functionality is secure boot, then CONFIG_IMX_HAB is enough. But
> > > > well, just the board maintainers can say. Added Raffaele and Jagan
> > > > as reported maintainers for this board.
> > > >
> > > > >  Why are you not fixing the board so it still links?  What makes
> > > > > this board a problem that other (I assume) imx6dl boards are not?
> > > >
> > > > Well, this board has, compared to other MX6DL, a lot of SPL_ option
> > > > that are bloating the SPL size. And then does not match anymore with
> > > > the internal RAm, while other MX6DL board

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hello Michael

A gentle reminder!!
As you said earlier, can you test the mamoj board with proposed solution to fix 
SPL size issue.

Regards
Gaurav Jain

> -Original Message-
> From: Gaurav Jain
> Sent: Monday, March 14, 2022 11:18 AM
> To: Michael Nazzareno Trimarchi ; Stefano
> Babic 
> Cc: Tom Rini ; Fabio Estevam ;
> Michael Walle ; Varun Sethi ; Adrian
> Alonso ; Alison Wang ;
> Andy Tang ; Franck Lenormand
> ; Horia Geanta ; Ji
> Luo ; ma...@denx.de; Meenakshi Aggarwal
> ; Mingkai Hu ;
> olte...@gmail.com; Pankaj Gupta ; Peng Fan
> ; Pramod Kumar ;
> Priyanka Jain ; Rajesh Bhagat
> ; Sahil Malhotra ;
> Shengzhou Liu ; Silvano Di Ninno
> ; s...@chromium.org; u-boot@lists.denx.de; dl-
> uboot-imx ; Wasim Khan ;
> Ye Li ; Raffaele RECALCATI ;
> Jagan Teki 
> Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Hi Michael
> 
> > -Original Message-
> > From: Michael Nazzareno Trimarchi 
> > Sent: Tuesday, March 8, 2022 7:05 PM
> > To: Stefano Babic 
> > Cc: Tom Rini ; Fabio Estevam
> ;
> > Gaurav Jain ; Michael Walle ;
> > Varun Sethi ; Adrian Alonso ;
> > Alison Wang ; Andy Tang ;
> > Franck Lenormand ; Horia Geanta
> > ; Ji Luo ; ma...@denx.de;
> > Meenakshi Aggarwal ; Mingkai Hu
> > ; olte...@gmail.com; Pankaj Gupta
> > ; Peng Fan ; Pramod Kumar
> > ; Priyanka Jain ;
> > Rajesh Bhagat ; Sahil Malhotra
> > ; Shengzhou Liu ;
> > Silvano Di Ninno ; s...@chromium.org; u-
> > b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> > ; Ye Li ; Raffaele RECALCATI
> > ; Jagan Teki
> > 
> > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > CAAM Job ring driver model
> >
> > Caution: EXT Email
> >
> > Hi
> >
> > On Tue, Mar 8, 2022 at 2:28 PM Stefano Babic  wrote:
> > >
> > > Hi Tom,
> > >
> > > On 08.03.22 13:48, Tom Rini wrote:
> > > > On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
> > > >> On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain 
> > wrote:
> > > >>
> > > >>> I further checked on your concern and propose the below change
> > > >>> to
> > stop building caam driver in SPL for imx6dl_mamoj.
> > > >>>
> > > >>> --- a/configs/imx6dl_mamoj_defconfig
> > > >>> +++ b/configs/imx6dl_mamoj_defconfig
> > > >>> @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> > > >>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> > > >>>   CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> > > >>>   CONFIG_CI_UDC=y
> > > >>> +CONFIG_SPL_CRYPTO=n
> > > >>
> > > >> No, this is not how defconfig works.
> > > >>
> > > >> You should set:
> > > >>
> > > >> # CONFIG_SPL_CRYPTO is not set
> > > >
> > > > But more, WHY is this the right answer?  You're disabling
> > > > functionality and the board maintainers aren't even on the CC list
> > > > for this thread it looks like.
> > >
> > > This was my blocking point, too, for this series. There is no answer
> > > about the board.
> > >
> > > I can just imagine (as for other MX6DL) that the required
> > > functionality is secure boot, then CONFIG_IMX_HAB is enough. But
> > > well, just the board maintainers can say. Added Raffaele and Jagan
> > > as reported maintainers for this board.
> > >
> > > >  Why are you not fixing the board so it still links?  What makes
> > > > this board a problem that other (I assume) imx6dl boards are not?
> > >
> > > Well, this board has, compared to other MX6DL, a lot of SPL_ option
> > > that are bloating the SPL size. And then does not match anymore with
> > > the internal RAm, while other MX6DL boards are not so affected by
> > > the increased size because they have no SPL at all or SPL with less
> > > options and then smaller. We do not need to fix the link, but reduce
> > > the size, and nobody else than the maintainers can tell us if
> > > removing some feature is ok.
> > >
> >
> > I will test this week, and try to find a board here to test
> >
> > * Jagan * Do you have a momoj?
> 
> Have you tested mamoj board?
> 
> Regards
> Gaurav
> >
> > Michael
> >
> > > Regards,
> > > Stefano
> > >
> > > --
> > >
> >
> ==

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hi Michael

> -Original Message-
> From: Michael Nazzareno Trimarchi 
> Sent: Tuesday, March 8, 2022 7:05 PM
> To: Stefano Babic 
> Cc: Tom Rini ; Fabio Estevam ;
> Gaurav Jain ; Michael Walle ;
> Varun Sethi ; Adrian Alonso ;
> Alison Wang ; Andy Tang ;
> Franck Lenormand ; Horia Geanta
> ; Ji Luo ; ma...@denx.de;
> Meenakshi Aggarwal ; Mingkai Hu
> ; olte...@gmail.com; Pankaj Gupta
> ; Peng Fan ; Pramod Kumar
> ; Priyanka Jain ;
> Rajesh Bhagat ; Sahil Malhotra
> ; Shengzhou Liu ;
> Silvano Di Ninno ; s...@chromium.org; u-
> b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> ; Ye Li ; Raffaele RECALCATI
> ; Jagan Teki 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Caution: EXT Email
> 
> Hi
> 
> On Tue, Mar 8, 2022 at 2:28 PM Stefano Babic  wrote:
> >
> > Hi Tom,
> >
> > On 08.03.22 13:48, Tom Rini wrote:
> > > On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
> > >> On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain 
> wrote:
> > >>
> > >>> I further checked on your concern and propose the below change to
> stop building caam driver in SPL for imx6dl_mamoj.
> > >>>
> > >>> --- a/configs/imx6dl_mamoj_defconfig
> > >>> +++ b/configs/imx6dl_mamoj_defconfig
> > >>> @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> > >>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> > >>>   CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> > >>>   CONFIG_CI_UDC=y
> > >>> +CONFIG_SPL_CRYPTO=n
> > >>
> > >> No, this is not how defconfig works.
> > >>
> > >> You should set:
> > >>
> > >> # CONFIG_SPL_CRYPTO is not set
> > >
> > > But more, WHY is this the right answer?  You're disabling
> > > functionality and the board maintainers aren't even on the CC list
> > > for this thread it looks like.
> >
> > This was my blocking point, too, for this series. There is no answer
> > about the board.
> >
> > I can just imagine (as for other MX6DL) that the required
> > functionality is secure boot, then CONFIG_IMX_HAB is enough. But well,
> > just the board maintainers can say. Added Raffaele and Jagan as
> > reported maintainers for this board.
> >
> > >  Why are you not fixing the board so it still links?  What makes
> > > this board a problem that other (I assume) imx6dl boards are not?
> >
> > Well, this board has, compared to other MX6DL, a lot of SPL_ option
> > that are bloating the SPL size. And then does not match anymore with
> > the internal RAm, while other MX6DL boards are not so affected by the
> > increased size because they have no SPL at all or SPL with less
> > options and then smaller. We do not need to fix the link, but reduce
> > the size, and nobody else than the maintainers can tell us if removing
> > some feature is ok.
> >
> 
> I will test this week, and try to find a board here to test
> 
> * Jagan * Do you have a momoj?

Have you tested mamoj board?

Regards
Gaurav
> 
> Michael
> 
> > Regards,
> > Stefano
> >
> > --
> >
> 
> =
> > DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
> >
> 
> =
> 
> 
> 
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> mich...@amarulasolutions.com
> __
> 
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172
> i...@amarulasolutions.com
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.a
> marulasolutions.com%2F&data=04%7C01%7Cgaurav.jain%40nxp.com%
> 7C843e57f75346449f13ae08da010867b6%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635%7C0%7C0%7C637823432854617357%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%7C3000&sdata=f025HmlIM8FuTEYspDjwOevTT1k7JRZeIiS%2FpTH2hc
> Y%3D&reserved=0

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Nazzareno Trimarchi]

Hi

On Tue, Mar 8, 2022 at 2:28 PM Stefano Babic  wrote:
>
> Hi Tom,
>
> On 08.03.22 13:48, Tom Rini wrote:
> > On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
> >> On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain  wrote:
> >>
> >>> I further checked on your concern and propose the below change to stop 
> >>> building caam driver in SPL for imx6dl_mamoj.
> >>>
> >>> --- a/configs/imx6dl_mamoj_defconfig
> >>> +++ b/configs/imx6dl_mamoj_defconfig
> >>> @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> >>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> >>>   CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> >>>   CONFIG_CI_UDC=y
> >>> +CONFIG_SPL_CRYPTO=n
> >>
> >> No, this is not how defconfig works.
> >>
> >> You should set:
> >>
> >> # CONFIG_SPL_CRYPTO is not set
> >
> > But more, WHY is this the right answer?  You're disabling functionality
> > and the board maintainers aren't even on the CC list for this thread it
> > looks like.
>
> This was my blocking point, too, for this series. There is no answer
> about the board.
>
> I can just imagine (as for other MX6DL) that the required functionality
> is secure boot, then CONFIG_IMX_HAB is enough. But well, just the board
> maintainers can say. Added Raffaele and Jagan as reported maintainers
> for this board.
>
> >  Why are you not fixing the board so it still links?  What
> > makes this board a problem that other (I assume) imx6dl boards are not?
>
> Well, this board has, compared to other MX6DL, a lot of SPL_ option that
> are bloating the SPL size. And then does not match anymore with the
> internal RAm, while other MX6DL boards are not so affected by the
> increased size because they have no SPL at all or SPL with less options
> and then smaller. We do not need to fix the link, but reduce the size,
> and nobody else than the maintainers can tell us if removing some
> feature is ok.
>

I will test this week, and try to find a board here to test

* Jagan * Do you have a momoj?

Michael

> Regards,
> Stefano
>
> --
> =
> DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
> =



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mich...@amarulasolutions.com
__

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
i...@amarulasolutions.com
www.amarulasolutions.com

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Tom Rini]

On Tue, Mar 08, 2022 at 01:21:41PM +, Gaurav Jain wrote:
> 
> 
> > -Original Message-
> > From: Tom Rini 
> > Sent: Tuesday, March 8, 2022 6:19 PM
> > To: Fabio Estevam 
> > Cc: Gaurav Jain ; Michael Walle ;
> > sba...@denx.de; Varun Sethi ; Adrian Alonso
> > ; Alison Wang ; Andy Tang
> > ; Franck Lenormand ;
> > Horia Geanta ; Ji Luo ;
> > ma...@denx.de; Meenakshi Aggarwal ;
> > Mingkai Hu ; olte...@gmail.com; Pankaj Gupta
> > ; Peng Fan ; Pramod Kumar
> > ; Priyanka Jain ; Rajesh
> > Bhagat ; Sahil Malhotra ;
> > Shengzhou Liu ; Silvano Di Ninno
> > ; s...@chromium.org; u-boot@lists.denx.de; dl-
> > uboot-imx ; Wasim Khan ; Ye Li
> > 
> > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> > ring driver model
> > 
> > On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
> > > On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain  wrote:
> > >
> > > > I further checked on your concern and propose the below change to stop
> > building caam driver in SPL for imx6dl_mamoj.
> > > >
> > > > --- a/configs/imx6dl_mamoj_defconfig
> > > > +++ b/configs/imx6dl_mamoj_defconfig
> > > > @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> > > >  CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> > > >  CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> > > >  CONFIG_CI_UDC=y
> > > > +CONFIG_SPL_CRYPTO=n
> > >
> > > No, this is not how defconfig works.
> > >
> > > You should set:
> > >
> > > # CONFIG_SPL_CRYPTO is not set
> > 
> > But more, WHY is this the right answer?  You're disabling functionality and 
> > the
> > board maintainers aren't even on the CC list for this thread it looks like. 
> >  Why are
> > you not fixing the board so it still links?  What makes this board a 
> > problem that
> > other (I assume) imx6dl boards are not?
> > 
> SPL exceeds the maximum size for only imx6dl_mamoj.
> spl/u-boot-spl.bin exceeds file size limit:
>   limit:  0xefa0 bytes
>   actual: 0x1004d bytes
>   excess: 0x10ad bytes
> 
> on further checking I see that caam is not initialized in SPL but only built.
> So disabling the build for caam driver in SPL should not be a problem.
> 
> (Added Jagan, Raffaele, Simone as board maintainer.)

That's a lot of growth, what's going on?  And is the CAAM being built
but not initialized a generic issue with imx6 platforms?  That seems
like something to further understand, and hopefully the board
maintainers can chime in here soon.

-- 
Tom


signature.asc
Description: PGP signature

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Stefano Babic]

Hi Tom,

On 08.03.22 13:48, Tom Rini wrote:

On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:

On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain  wrote:


I further checked on your concern and propose the below change to stop building 
caam driver in SPL for imx6dl_mamoj.

--- a/configs/imx6dl_mamoj_defconfig
+++ b/configs/imx6dl_mamoj_defconfig
@@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
  CONFIG_USB_GADGET_VENDOR_NUM=0x0525
  CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
  CONFIG_CI_UDC=y
+CONFIG_SPL_CRYPTO=n


No, this is not how defconfig works.

You should set:

# CONFIG_SPL_CRYPTO is not set


But more, WHY is this the right answer?  You're disabling functionality
and the board maintainers aren't even on the CC list for this thread it
looks like.


This was my blocking point, too, for this series. There is no answer 
about the board.


I can just imagine (as for other MX6DL) that the required functionality 
is secure boot, then CONFIG_IMX_HAB is enough. But well, just the board 
maintainers can say. Added Raffaele and Jagan as reported maintainers 
for this board.



 Why are you not fixing the board so it still links?  What
makes this board a problem that other (I assume) imx6dl boards are not? 


Well, this board has, compared to other MX6DL, a lot of SPL_ option that 
are bloating the SPL size. And then does not match anymore with the 
internal RAm, while other MX6DL boards are not so affected by the 
increased size because they have no SPL at all or SPL with less options 
and then smaller. We do not need to fix the link, but reduce the size, 
and nobody else than the maintainers can tell us if removing some 
feature is ok.


Regards,
Stefano

--
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

> -Original Message-
> From: Tom Rini 
> Sent: Tuesday, March 8, 2022 6:19 PM
> To: Fabio Estevam 
> Cc: Gaurav Jain ; Michael Walle ;
> sba...@denx.de; Varun Sethi ; Adrian Alonso
> ; Alison Wang ; Andy Tang
> ; Franck Lenormand ;
> Horia Geanta ; Ji Luo ;
> ma...@denx.de; Meenakshi Aggarwal ;
> Mingkai Hu ; olte...@gmail.com; Pankaj Gupta
> ; Peng Fan ; Pramod Kumar
> ; Priyanka Jain ; Rajesh
> Bhagat ; Sahil Malhotra ;
> Shengzhou Liu ; Silvano Di Ninno
> ; s...@chromium.org; u-boot@lists.denx.de; dl-
> uboot-imx ; Wasim Khan ; Ye Li
> 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
> > On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain  wrote:
> >
> > > I further checked on your concern and propose the below change to stop
> building caam driver in SPL for imx6dl_mamoj.
> > >
> > > --- a/configs/imx6dl_mamoj_defconfig
> > > +++ b/configs/imx6dl_mamoj_defconfig
> > > @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> > >  CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> > >  CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> > >  CONFIG_CI_UDC=y
> > > +CONFIG_SPL_CRYPTO=n
> >
> > No, this is not how defconfig works.
> >
> > You should set:
> >
> > # CONFIG_SPL_CRYPTO is not set
> 
> But more, WHY is this the right answer?  You're disabling functionality and 
> the
> board maintainers aren't even on the CC list for this thread it looks like.  
> Why are
> you not fixing the board so it still links?  What makes this board a problem 
> that
> other (I assume) imx6dl boards are not?
> 
SPL exceeds the maximum size for only imx6dl_mamoj.
spl/u-boot-spl.bin exceeds file size limit:
  limit:  0xefa0 bytes
  actual: 0x1004d bytes
  excess: 0x10ad bytes

on further checking I see that caam is not initialized in SPL but only built.
So disabling the build for caam driver in SPL should not be a problem.

(Added Jagan, Raffaele, Simone as board maintainer.)

Gaurav
> --
> Tom

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Tom Rini]

On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
> On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain  wrote:
> 
> > I further checked on your concern and propose the below change to stop 
> > building caam driver in SPL for imx6dl_mamoj.
> >
> > --- a/configs/imx6dl_mamoj_defconfig
> > +++ b/configs/imx6dl_mamoj_defconfig
> > @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> >  CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> >  CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> >  CONFIG_CI_UDC=y
> > +CONFIG_SPL_CRYPTO=n
> 
> No, this is not how defconfig works.
> 
> You should set:
> 
> # CONFIG_SPL_CRYPTO is not set

But more, WHY is this the right answer?  You're disabling functionality
and the board maintainers aren't even on the CC list for this thread it
looks like.  Why are you not fixing the board so it still links?  What
makes this board a problem that other (I assume) imx6dl boards are not?

-- 
Tom


signature.asc
Description: PGP signature

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

> -Original Message-
> From: Fabio Estevam 
> Sent: Tuesday, March 8, 2022 4:42 PM
> To: Gaurav Jain 
> Cc: Tom Rini ; Michael Walle ;
> sba...@denx.de; Varun Sethi ; Adrian Alonso
> ; Alison Wang ; Andy Tang
> ; Franck Lenormand ;
> Horia Geanta ; Ji Luo ;
> ma...@denx.de; Meenakshi Aggarwal ;
> Mingkai Hu ; olte...@gmail.com; Pankaj Gupta
> ; Peng Fan ; Pramod Kumar
> ; Priyanka Jain ; Rajesh
> Bhagat ; Sahil Malhotra ;
> Shengzhou Liu ; Silvano Di Ninno
> ; s...@chromium.org; u-boot@lists.denx.de; dl-
> uboot-imx ; Wasim Khan ; Ye Li
> 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Caution: EXT Email
> 
> On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain  wrote:
> 
> > I further checked on your concern and propose the below change to stop
> building caam driver in SPL for imx6dl_mamoj.
> >
> > --- a/configs/imx6dl_mamoj_defconfig
> > +++ b/configs/imx6dl_mamoj_defconfig
> > @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> >  CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> >  CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> >  CONFIG_CI_UDC=y
> > +CONFIG_SPL_CRYPTO=n
> 
> No, this is not how defconfig works.
> 
> You should set:
> 
> # CONFIG_SPL_CRYPTO is not set
Ok. Noted.

Gaurav

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Fabio Estevam]

On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain  wrote:

> I further checked on your concern and propose the below change to stop 
> building caam driver in SPL for imx6dl_mamoj.
>
> --- a/configs/imx6dl_mamoj_defconfig
> +++ b/configs/imx6dl_mamoj_defconfig
> @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x0525
>  CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
>  CONFIG_CI_UDC=y
> +CONFIG_SPL_CRYPTO=n

No, this is not how defconfig works.

You should set:

# CONFIG_SPL_CRYPTO is not set

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hi Tom

> -Original Message-
> From: Tom Rini 
> Sent: Monday, March 7, 2022 8:46 PM
> To: Gaurav Jain 
> Cc: Michael Walle ; sba...@denx.de; Varun Sethi
> ; Adrian Alonso ; Alison Wang
> ; Andy Tang ;
> feste...@gmail.com; Franck Lenormand ; Horia
> Geanta ; Ji Luo ; ma...@denx.de;
> Meenakshi Aggarwal ; Mingkai Hu
> ; olte...@gmail.com; Pankaj Gupta
> ; Peng Fan ; Pramod Kumar
> ; Priyanka Jain ; Rajesh
> Bhagat ; Sahil Malhotra ;
> Shengzhou Liu ; Silvano Di Ninno
> ; s...@chromium.org; u-boot@lists.denx.de; dl-
> uboot-imx ; Wasim Khan ; Ye Li
> 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> On Mon, Mar 07, 2022 at 12:03:42PM +, Gaurav Jain wrote:
> >
> >
> > > -Original Message-
> > > From: Michael Walle 
> > > Sent: Monday, March 7, 2022 5:12 PM
> > > To: Gaurav Jain 
> > > Cc: sba...@denx.de; Varun Sethi ; Adrian Alonso
> > > ; Alison Wang ; Andy
> > > Tang ; feste...@gmail.com; Franck Lenormand
> > > ; Horia Geanta ; Ji
> > > Luo ; ma...@denx.de; Meenakshi Aggarwal
> > > ; Mingkai Hu ;
> > > olte...@gmail.com; Pankaj Gupta ; Peng Fan
> > > ; Pramod Kumar ;
> Priyanka
> > > Jain ; Rajesh Bhagat ;
> > > Sahil Malhotra ; Shengzhou Liu
> > > ; Silvano Di Ninno ;
> > > s...@chromium.org; u- b...@lists.denx.de; dl-uboot-imx
> > > ; Wasim Khan ; Ye Li
> > > 
> > > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > > CAAM Job ring driver model
> > >
> > > Caution: EXT Email
> > >
> > > Am 2022-03-07 12:33, schrieb Gaurav Jain:
> > > >> -Original Message-
> > > >> From: Michael Walle 
> > > >> Sent: Monday, March 7, 2022 4:39 PM
> > > >> To: Gaurav Jain 
> > > >> Cc: sba...@denx.de; Varun Sethi ; Adrian Alonso
> > > >> ; Alison Wang ; Andy
> > > Tang
> > > >> ; feste...@gmail.com; Franck Lenormand
> > > >> ; Horia Geanta ;
> > > >> Ji Luo ; ma...@denx.de; Meenakshi Aggarwal
> > > >> ; Mingkai Hu ;
> > > >> olte...@gmail.com; Pankaj Gupta ; Peng Fan
> > > >> ; Pramod Kumar ;
> > > Priyanka
> > > >> Jain ; Rajesh Bhagat
> > > >> ; Sahil Malhotra ;
> > > >> Shengzhou Liu ; Silvano Di Ninno
> > > >> ; s...@chromium.org; u-
> > > >> b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> > > >> ; Ye Li 
> > > >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support
> > > >> for CAAM Job ring driver model
> > > >>
> > > >> Caution: EXT Email
> > > >>
> > > >> Am 2022-03-07 11:56, schrieb Gaurav Jain:
> > > >> >> -Original Message-
> > > >> >> From: Michael Walle 
> > > >> >> Sent: Monday, March 7, 2022 3:28 PM
> > > >> >> To: sba...@denx.de
> > > >> >> Cc: Varun Sethi ; Adrian Alonso
> > > >> >> ; Alison Wang ;
> > > >> >> Andy
> > > >> Tang
> > > >> >> ; feste...@gmail.com; Franck Lenormand
> > > >> >> ; Gaurav Jain ;
> > > >> >> Horia Geanta ; Ji Luo ;
> > > >> >> ma...@denx.de; Meenakshi Aggarwal
> > > >> >> ; Mingkai Hu
> ;
> > > >> >> olte...@gmail.com; Pankaj Gupta ; Peng
> > > >> >> Fan ; Pramod
> > > Kumar
> > > >> >> ; Priyanka Jain
> > > >> >> ; Rajesh Bhagat
> > > >> >> ; Sahil Malhotra
> > > >> >> ; Shengzhou Liu
> > > >> >> ; Silvano Di Ninno
> > > >> >> ; s...@chromium.org; u-
> > > >> >> b...@lists.denx.de; dl-uboot-imx ; Wasim
> > > >> >> Khan ; Ye Li ; Michael
> > > >> >> Walle 
> > > >> >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add
> > > >> >> support for CAAM Job ring driver model
> > > >> >>
> > > >> >> Caution: EXT Email
> > > >> >>
> > > >> >> > On 03.03.22 14:41, Gaurav Jain wrote:
> > > >> >> >> As we have not received any response from imx6dl_mamoj
> > > >> >> >> board
> > > >> maintainer.
> > >

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[ZHIZHIKIN Andrey]

Hello Gaurav,

> -Original Message-
> From: U-Boot  On Behalf Of Gaurav Jain
> Sent: Monday, March 7, 2022 3:10 PM
> To: ZHIZHIKIN Andrey ; Stefano Babic
> ; u-boot@lists.denx.de; Marek Vasut 
> Cc: Fabio Estevam ; Peng Fan ; Simon 
> Glass
> ; Priyanka Jain ; Ye Li 
> ;
> Horia Geanta ; Ji Luo ; Franck Lenormand
> ; Silvano Di Ninno ; Sahil
> Malhotra ; Pankaj Gupta ; Varun
> Sethi ; dl-uboot-imx ; Shengzhou Liu
> ; Mingkai Hu ; Rajesh Bhagat
> ; Meenakshi Aggarwal ; 
> Wasim
> Khan ; Alison Wang ; Pramod Kumar
> ; Andy Tang ; Adrian Alonso
> ; Vladimir Oltean 
> Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job 
> ring
> driver model
> 
> Hello Andrey
> 
> 
> Ok, I will follow the approach suggested by you. First a patch will be 
> submitted
> to ATF and then the one for uboot will follow.

Perfect, thanks a lot for following it up here!

> Will send a V11 after removing the JR0 reservation code. Any other concern?

Besides the one above, I have no further concerns on the series.

> 
> Gaurav
> 
> >

-- andrey

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Tom Rini]

On Mon, Mar 07, 2022 at 12:03:42PM +, Gaurav Jain wrote:
> 
> 
> > -Original Message-
> > From: Michael Walle 
> > Sent: Monday, March 7, 2022 5:12 PM
> > To: Gaurav Jain 
> > Cc: sba...@denx.de; Varun Sethi ; Adrian Alonso
> > ; Alison Wang ; Andy Tang
> > ; feste...@gmail.com; Franck Lenormand
> > ; Horia Geanta ; Ji Luo
> > ; ma...@denx.de; Meenakshi Aggarwal
> > ; Mingkai Hu ;
> > olte...@gmail.com; Pankaj Gupta ; Peng Fan
> > ; Pramod Kumar ; Priyanka
> > Jain ; Rajesh Bhagat ; Sahil
> > Malhotra ; Shengzhou Liu ;
> > Silvano Di Ninno ; s...@chromium.org; u-
> > b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> > ; Ye Li 
> > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> > ring driver model
> > 
> > Caution: EXT Email
> > 
> > Am 2022-03-07 12:33, schrieb Gaurav Jain:
> > >> -Original Message-
> > >> From: Michael Walle 
> > >> Sent: Monday, March 7, 2022 4:39 PM
> > >> To: Gaurav Jain 
> > >> Cc: sba...@denx.de; Varun Sethi ; Adrian Alonso
> > >> ; Alison Wang ; Andy
> > Tang
> > >> ; feste...@gmail.com; Franck Lenormand
> > >> ; Horia Geanta ; Ji
> > >> Luo ; ma...@denx.de; Meenakshi Aggarwal
> > >> ; Mingkai Hu ;
> > >> olte...@gmail.com; Pankaj Gupta ; Peng Fan
> > >> ; Pramod Kumar ;
> > Priyanka
> > >> Jain ; Rajesh Bhagat ;
> > >> Sahil Malhotra ; Shengzhou Liu
> > >> ; Silvano Di Ninno ;
> > >> s...@chromium.org; u- b...@lists.denx.de; dl-uboot-imx
> > >> ; Wasim Khan ; Ye Li
> > >> 
> > >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > >> CAAM Job ring driver model
> > >>
> > >> Caution: EXT Email
> > >>
> > >> Am 2022-03-07 11:56, schrieb Gaurav Jain:
> > >> >> -Original Message-
> > >> >> From: Michael Walle 
> > >> >> Sent: Monday, March 7, 2022 3:28 PM
> > >> >> To: sba...@denx.de
> > >> >> Cc: Varun Sethi ; Adrian Alonso
> > >> >> ; Alison Wang ; Andy
> > >> Tang
> > >> >> ; feste...@gmail.com; Franck Lenormand
> > >> >> ; Gaurav Jain ;
> > >> >> Horia Geanta ; Ji Luo ;
> > >> >> ma...@denx.de; Meenakshi Aggarwal ;
> > >> >> Mingkai Hu ; olte...@gmail.com; Pankaj Gupta
> > >> >> ; Peng Fan ; Pramod
> > Kumar
> > >> >> ; Priyanka Jain ;
> > >> >> Rajesh Bhagat ; Sahil Malhotra
> > >> >> ; Shengzhou Liu ;
> > >> >> Silvano Di Ninno ; s...@chromium.org; u-
> > >> >> b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> > >> >> ; Ye Li ; Michael Walle
> > >> >> 
> > >> >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support
> > >> >> for CAAM Job ring driver model
> > >> >>
> > >> >> Caution: EXT Email
> > >> >>
> > >> >> > On 03.03.22 14:41, Gaurav Jain wrote:
> > >> >> >> As we have not received any response from imx6dl_mamoj board
> > >> maintainer.
> > >> >> >> I propose the below solution
> > >> >> >>
> > >> >> >> --- a/arch/arm/mach-imx/Kconfig
> > >> >> >> +++ b/arch/arm/mach-imx/Kconfig
> > >> >> >> @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
> > >> >> >> -   select FSL_CAAM if HAS_CAAM
> > >> >> >> -   imply CMD_DEKBLOB if HAS_CAAM
> > >> >> >> +   imply FSL_CAAM if HAS_CAAM
> > >> >> >> +   imply CMD_DEKBLOB if FSL_CAAM
> > >> >> >>   Help
> > >> >> >>
> > >> >> >
> > >> >> > IMO this is ok, I was also wrong, Marek is not the maintainer of
> > >> >> > this board. This was the only board with broken build - let's
> > >> >> > say, I will still wait a couple of days, and if there is no
> > >> >> > comments, I will apply your series (but then V10). I can apply
> > >> >> > this fix myself, no need to post the series again (I have not
> > >> >> > seen any other comment or request to
> > >> >>

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hello Andrey

> -Original Message-
> From: ZHIZHIKIN Andrey 
> Sent: Monday, March 7, 2022 1:08 AM
> To: Stefano Babic ; Gaurav Jain ; u-
> b...@lists.denx.de; Marek Vasut 
> Cc: Fabio Estevam ; Peng Fan ;
> Simon Glass ; Priyanka Jain ; Ye
> Li ; Horia Geanta ; Ji Luo
> ; Franck Lenormand ; Silvano Di
> Ninno ; Sahil Malhotra ;
> Pankaj Gupta ; Varun Sethi ; dl-
> uboot-imx ; Shengzhou Liu ;
> Mingkai Hu ; Rajesh Bhagat ;
> Meenakshi Aggarwal ; Wasim Khan
> ; Alison Wang ; Pramod
> Kumar ; Andy Tang ;
> Adrian Alonso ; Vladimir Oltean 
> Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Caution: EXT Email
> 
> Hello Stefano,
> 
> > -Original Message-
> > From: U-Boot  On Behalf Of Stefano Babic
> > Sent: Thursday, March 3, 2022 4:30 PM
> > To: Gaurav Jain ; Stefano Babic ;
> > u- b...@lists.denx.de; Marek Vasut 
> > Cc: Fabio Estevam ; Peng Fan ;
> > Simon Glass ; Priyanka Jain ;
> > Ye Li ; Horia Geanta ; Ji Luo
> > ; Franck Lenormand ; Silvano
> > Di Ninno ; Sahil Malhotra
> > ; Pankaj Gupta ; Varun
> > Sethi ; dl-uboot-imx ; Shengzhou
> > Liu ; Mingkai Hu ; Rajesh
> > Bhagat ; Meenakshi Aggarwal
> > ; Wasim Khan ;
> Alison
> > Wang ; Pramod Kumar
> ;
> > Andy Tang ; Adrian Alonso ;
> > Vladimir Oltean 
> > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > CAAM Job ring driver model
> >
> > Hi,
> >
> > On 03.03.22 14:41, Gaurav Jain wrote:
> > > Hi Stefano
> > >
> > > As we have not received any response from imx6dl_mamoj board maintainer.
> > > I propose the below solution
> > >
> > > --- a/arch/arm/mach-imx/Kconfig
> > > +++ b/arch/arm/mach-imx/Kconfig
> > > @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
> > > -   select FSL_CAAM if HAS_CAAM
> > > -   imply CMD_DEKBLOB if HAS_CAAM
> > > +   imply FSL_CAAM if HAS_CAAM
> > > +   imply CMD_DEKBLOB if FSL_CAAM
> > >   Help
> > >
> >
> > IMO this is ok, I was also wrong, Marek is not the maintainer of this
> > board. This was the only board with broken build - let's say, I will
> > still wait a couple of days, and if there is no comments, I will apply
> > your series (but then V10). I can apply this fix myself, no need to
> > post the series again (I have not seen any other comment or request to
> change).
> 
> I had a couple of concerns which I raised in V10 without any follow-up.
> 
> Main thing is the JR reservation, which (if applied) would lead to
> misconfiguration when upstream TF-A is used, see [1].
> 
> >
> > Regards,
> > Stefano
> >
> 
> Link: [1]:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kern
> el.org%2Fu-
> boot%2FAM6PR06MB4691178347827CB77F44F537A6309%40AM6PR06MB4691
> .eurprd06.prod.outlook.com%2F&data=04%7C01%7Cgaurav.jain%40nxp.c
> om%7C87775d9291044d6aad3808d9ffa8db17%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C637821922977072803%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C3000&sdata=3Gng6vVpNKyV8xNLSEuwG%2F7DEVDjSnYh5iYi47wvyvc%3
> D&reserved=0

Ok, I will follow the approach suggested by you. First a patch will be 
submitted to ATF and then the one for uboot will follow.
Will send a V11 after removing the JR0 reservation code. Any other concern?

Gaurav

> 
> -- andrey

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

> -Original Message-
> From: Michael Walle 
> Sent: Monday, March 7, 2022 5:12 PM
> To: Gaurav Jain 
> Cc: sba...@denx.de; Varun Sethi ; Adrian Alonso
> ; Alison Wang ; Andy Tang
> ; feste...@gmail.com; Franck Lenormand
> ; Horia Geanta ; Ji Luo
> ; ma...@denx.de; Meenakshi Aggarwal
> ; Mingkai Hu ;
> olte...@gmail.com; Pankaj Gupta ; Peng Fan
> ; Pramod Kumar ; Priyanka
> Jain ; Rajesh Bhagat ; Sahil
> Malhotra ; Shengzhou Liu ;
> Silvano Di Ninno ; s...@chromium.org; u-
> b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> ; Ye Li 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Caution: EXT Email
> 
> Am 2022-03-07 12:33, schrieb Gaurav Jain:
> >> -Original Message-
> >> From: Michael Walle 
> >> Sent: Monday, March 7, 2022 4:39 PM
> >> To: Gaurav Jain 
> >> Cc: sba...@denx.de; Varun Sethi ; Adrian Alonso
> >> ; Alison Wang ; Andy
> Tang
> >> ; feste...@gmail.com; Franck Lenormand
> >> ; Horia Geanta ; Ji
> >> Luo ; ma...@denx.de; Meenakshi Aggarwal
> >> ; Mingkai Hu ;
> >> olte...@gmail.com; Pankaj Gupta ; Peng Fan
> >> ; Pramod Kumar ;
> Priyanka
> >> Jain ; Rajesh Bhagat ;
> >> Sahil Malhotra ; Shengzhou Liu
> >> ; Silvano Di Ninno ;
> >> s...@chromium.org; u- b...@lists.denx.de; dl-uboot-imx
> >> ; Wasim Khan ; Ye Li
> >> 
> >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> >> CAAM Job ring driver model
> >>
> >> Caution: EXT Email
> >>
> >> Am 2022-03-07 11:56, schrieb Gaurav Jain:
> >> >> -Original Message-
> >> >> From: Michael Walle 
> >> >> Sent: Monday, March 7, 2022 3:28 PM
> >> >> To: sba...@denx.de
> >> >> Cc: Varun Sethi ; Adrian Alonso
> >> >> ; Alison Wang ; Andy
> >> Tang
> >> >> ; feste...@gmail.com; Franck Lenormand
> >> >> ; Gaurav Jain ;
> >> >> Horia Geanta ; Ji Luo ;
> >> >> ma...@denx.de; Meenakshi Aggarwal ;
> >> >> Mingkai Hu ; olte...@gmail.com; Pankaj Gupta
> >> >> ; Peng Fan ; Pramod
> Kumar
> >> >> ; Priyanka Jain ;
> >> >> Rajesh Bhagat ; Sahil Malhotra
> >> >> ; Shengzhou Liu ;
> >> >> Silvano Di Ninno ; s...@chromium.org; u-
> >> >> b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> >> >> ; Ye Li ; Michael Walle
> >> >> 
> >> >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support
> >> >> for CAAM Job ring driver model
> >> >>
> >> >> Caution: EXT Email
> >> >>
> >> >> > On 03.03.22 14:41, Gaurav Jain wrote:
> >> >> >> As we have not received any response from imx6dl_mamoj board
> >> maintainer.
> >> >> >> I propose the below solution
> >> >> >>
> >> >> >> --- a/arch/arm/mach-imx/Kconfig
> >> >> >> +++ b/arch/arm/mach-imx/Kconfig
> >> >> >> @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
> >> >> >> -   select FSL_CAAM if HAS_CAAM
> >> >> >> -   imply CMD_DEKBLOB if HAS_CAAM
> >> >> >> +   imply FSL_CAAM if HAS_CAAM
> >> >> >> +   imply CMD_DEKBLOB if FSL_CAAM
> >> >> >>   Help
> >> >> >>
> >> >> >
> >> >> > IMO this is ok, I was also wrong, Marek is not the maintainer of
> >> >> > this board. This was the only board with broken build - let's
> >> >> > say, I will still wait a couple of days, and if there is no
> >> >> > comments, I will apply your series (but then V10). I can apply
> >> >> > this fix myself, no need to post the series again (I have not
> >> >> > seen any other comment or request to
> >> >> change).
> >> >>
> >> >> I don't understand why the solution isn't the same one as for the
> >> >> layerscape part in this series[1]: enable the config per board
> >> >> (that is your boards) and leave all others the same as before?
> >> >
> >> > imx6dl_mamoj caam driver is not enabled by any of my changes.
> >> > This board is enabling  IMX_HAB which select FSL_CAAM.
> >> > Proposed changes making it imply so that FSL_CAAM can be disabled
> >> > in board defconfig.
> >>
> >> Ahh it was already selected before. But mhh, does IMX_HAB even makes
> >> sense without FSL_CAAM? Why was is a hard dependency before?
> >
> > With imply, this will still enable FSL_CAAM unless it is explicitly
> > disabled in defconfig. With select I do not have choice of disabling
> > FSL_CAAM in defconfig. Now I have disabled FSL_CAAM only for
> > imx6dl_mamoj_defconfig, as it is reporting spl size issues with caam
> > driver model approach.
> 
> I can see *what* you are doing, but that doesn't answer *why* it was a hard
> dependency before and why now of a sudden can be a soft dependency.

I am not sure of any other dependency, but from the code 
./arch/arm/mach-imx/cmd_dek.c  needs caam for blob_encap_dek operation for mx6, 
mx7, mx7ulp.
Making it soft dependency allows me to disable caam for imx6dl_mamoj.

Gaurav
> 
> -michael

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Walle]

Am 2022-03-07 12:33, schrieb Gaurav Jain:

-Original Message-
From: Michael Walle 
Sent: Monday, March 7, 2022 4:39 PM
To: Gaurav Jain 
Cc: sba...@denx.de; Varun Sethi ; Adrian Alonso
; Alison Wang ; Andy Tang
; feste...@gmail.com; Franck Lenormand
; Horia Geanta ; Ji 
Luo

; ma...@denx.de; Meenakshi Aggarwal
; Mingkai Hu ;
olte...@gmail.com; Pankaj Gupta ; Peng Fan
; Pramod Kumar ; Priyanka
Jain ; Rajesh Bhagat ; 
Sahil
Malhotra ; Shengzhou Liu 
;

Silvano Di Ninno ; s...@chromium.org; u-
b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
; Ye Li 
Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for 
CAAM Job

ring driver model

Caution: EXT Email

Am 2022-03-07 11:56, schrieb Gaurav Jain:
>> -Original Message-
>> From: Michael Walle 
>> Sent: Monday, March 7, 2022 3:28 PM
>> To: sba...@denx.de
>> Cc: Varun Sethi ; Adrian Alonso
>> ; Alison Wang ; Andy
Tang
>> ; feste...@gmail.com; Franck Lenormand
>> ; Gaurav Jain ; Horia
>> Geanta ; Ji Luo ;
>> ma...@denx.de; Meenakshi Aggarwal ;
>> Mingkai Hu ; olte...@gmail.com; Pankaj Gupta
>> ; Peng Fan ; Pramod Kumar
>> ; Priyanka Jain ;
>> Rajesh Bhagat ; Sahil Malhotra
>> ; Shengzhou Liu ;
>> Silvano Di Ninno ; s...@chromium.org; u-
>> b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
>> ; Ye Li ; Michael Walle
>> 
>> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
>> CAAM Job ring driver model
>>
>> Caution: EXT Email
>>
>> > On 03.03.22 14:41, Gaurav Jain wrote:
>> >> As we have not received any response from imx6dl_mamoj board
maintainer.
>> >> I propose the below solution
>> >>
>> >> --- a/arch/arm/mach-imx/Kconfig
>> >> +++ b/arch/arm/mach-imx/Kconfig
>> >> @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
>> >> -   select FSL_CAAM if HAS_CAAM
>> >> -   imply CMD_DEKBLOB if HAS_CAAM
>> >> +   imply FSL_CAAM if HAS_CAAM
>> >> +   imply CMD_DEKBLOB if FSL_CAAM
>> >>   Help
>> >>
>> >
>> > IMO this is ok, I was also wrong, Marek is not the maintainer of
>> > this board. This was the only board with broken build - let's say,
>> > I will still wait a couple of days, and if there is no comments, I
>> > will apply your series (but then V10). I can apply this fix myself,
>> > no need to post the series again (I have not seen any other comment
>> > or request to
>> change).
>>
>> I don't understand why the solution isn't the same one as for the
>> layerscape part in this series[1]: enable the config per board (that
>> is your boards) and leave all others the same as before?
>
> imx6dl_mamoj caam driver is not enabled by any of my changes.
> This board is enabling  IMX_HAB which select FSL_CAAM.
> Proposed changes making it imply so that FSL_CAAM can be disabled in
> board defconfig.

Ahh it was already selected before. But mhh, does IMX_HAB even makes 
sense

without FSL_CAAM? Why was is a hard dependency before?


With imply, this will still enable FSL_CAAM unless it is explicitly
disabled in defconfig. With select I do not have choice of disabling
FSL_CAAM in defconfig. Now I have disabled FSL_CAAM only for
imx6dl_mamoj_defconfig, as it is reporting spl size issues with caam
driver model approach.


I can see *what* you are doing, but that doesn't answer *why* it was
a hard dependency before and why now of a sudden can be a soft
dependency.

-michael

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

> -Original Message-
> From: Michael Walle 
> Sent: Monday, March 7, 2022 4:39 PM
> To: Gaurav Jain 
> Cc: sba...@denx.de; Varun Sethi ; Adrian Alonso
> ; Alison Wang ; Andy Tang
> ; feste...@gmail.com; Franck Lenormand
> ; Horia Geanta ; Ji Luo
> ; ma...@denx.de; Meenakshi Aggarwal
> ; Mingkai Hu ;
> olte...@gmail.com; Pankaj Gupta ; Peng Fan
> ; Pramod Kumar ; Priyanka
> Jain ; Rajesh Bhagat ; Sahil
> Malhotra ; Shengzhou Liu ;
> Silvano Di Ninno ; s...@chromium.org; u-
> b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> ; Ye Li 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Caution: EXT Email
> 
> Am 2022-03-07 11:56, schrieb Gaurav Jain:
> >> -Original Message-
> >> From: Michael Walle 
> >> Sent: Monday, March 7, 2022 3:28 PM
> >> To: sba...@denx.de
> >> Cc: Varun Sethi ; Adrian Alonso
> >> ; Alison Wang ; Andy
> Tang
> >> ; feste...@gmail.com; Franck Lenormand
> >> ; Gaurav Jain ; Horia
> >> Geanta ; Ji Luo ;
> >> ma...@denx.de; Meenakshi Aggarwal ;
> >> Mingkai Hu ; olte...@gmail.com; Pankaj Gupta
> >> ; Peng Fan ; Pramod Kumar
> >> ; Priyanka Jain ;
> >> Rajesh Bhagat ; Sahil Malhotra
> >> ; Shengzhou Liu ;
> >> Silvano Di Ninno ; s...@chromium.org; u-
> >> b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> >> ; Ye Li ; Michael Walle
> >> 
> >> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> >> CAAM Job ring driver model
> >>
> >> Caution: EXT Email
> >>
> >> > On 03.03.22 14:41, Gaurav Jain wrote:
> >> >> As we have not received any response from imx6dl_mamoj board
> maintainer.
> >> >> I propose the below solution
> >> >>
> >> >> --- a/arch/arm/mach-imx/Kconfig
> >> >> +++ b/arch/arm/mach-imx/Kconfig
> >> >> @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
> >> >> -   select FSL_CAAM if HAS_CAAM
> >> >> -   imply CMD_DEKBLOB if HAS_CAAM
> >> >> +   imply FSL_CAAM if HAS_CAAM
> >> >> +   imply CMD_DEKBLOB if FSL_CAAM
> >> >>   Help
> >> >>
> >> >
> >> > IMO this is ok, I was also wrong, Marek is not the maintainer of
> >> > this board. This was the only board with broken build - let's say,
> >> > I will still wait a couple of days, and if there is no comments, I
> >> > will apply your series (but then V10). I can apply this fix myself,
> >> > no need to post the series again (I have not seen any other comment
> >> > or request to
> >> change).
> >>
> >> I don't understand why the solution isn't the same one as for the
> >> layerscape part in this series[1]: enable the config per board (that
> >> is your boards) and leave all others the same as before?
> >
> > imx6dl_mamoj caam driver is not enabled by any of my changes.
> > This board is enabling  IMX_HAB which select FSL_CAAM.
> > Proposed changes making it imply so that FSL_CAAM can be disabled in
> > board defconfig.
> 
> Ahh it was already selected before. But mhh, does IMX_HAB even makes sense
> without FSL_CAAM? Why was is a hard dependency before?

With imply, this will still enable FSL_CAAM unless it is explicitly disabled in 
defconfig. With select I do not have choice of disabling FSL_CAAM in defconfig. 
Now I have disabled FSL_CAAM only for imx6dl_mamoj_defconfig, as it is 
reporting spl size issues with caam driver model approach.

Gaurav
> 
> -michael

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Walle]

Am 2022-03-07 11:56, schrieb Gaurav Jain:

-Original Message-
From: Michael Walle 
Sent: Monday, March 7, 2022 3:28 PM
To: sba...@denx.de
Cc: Varun Sethi ; Adrian Alonso 
;

Alison Wang ; Andy Tang ;
feste...@gmail.com; Franck Lenormand ;
Gaurav Jain ; Horia Geanta 
; Ji

Luo ; ma...@denx.de; Meenakshi Aggarwal
; Mingkai Hu ;
olte...@gmail.com; Pankaj Gupta ; Peng Fan
; Pramod Kumar ; Priyanka
Jain ; Rajesh Bhagat ; 
Sahil
Malhotra ; Shengzhou Liu 
;

Silvano Di Ninno ; s...@chromium.org; u-
b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
; Ye Li ; Michael Walle

Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for 
CAAM Job

ring driver model

Caution: EXT Email

> On 03.03.22 14:41, Gaurav Jain wrote:
>> As we have not received any response from imx6dl_mamoj board maintainer.
>> I propose the below solution
>>
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
>> -   select FSL_CAAM if HAS_CAAM
>> -   imply CMD_DEKBLOB if HAS_CAAM
>> +   imply FSL_CAAM if HAS_CAAM
>> +   imply CMD_DEKBLOB if FSL_CAAM
>>   Help
>>
>
> IMO this is ok, I was also wrong, Marek is not the maintainer of this
> board. This was the only board with broken build - let's say, I will
> still wait a couple of days, and if there is no comments, I will apply
> your series (but then V10). I can apply this fix myself, no need to
> post the series again (I have not seen any other comment or request to
change).

I don't understand why the solution isn't the same one as for the 
layerscape part
in this series[1]: enable the config per board (that is your boards) 
and leave all

others the same as before?


imx6dl_mamoj caam driver is not enabled by any of my changes.
This board is enabling  IMX_HAB which select FSL_CAAM.
Proposed changes making it imply so that FSL_CAAM can be disabled in
board defconfig.


Ahh it was already selected before. But mhh, does IMX_HAB even
makes sense without FSL_CAAM? Why was is a hard dependency
before?

-michael

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

> -Original Message-
> From: Michael Walle 
> Sent: Monday, March 7, 2022 3:28 PM
> To: sba...@denx.de
> Cc: Varun Sethi ; Adrian Alonso ;
> Alison Wang ; Andy Tang ;
> feste...@gmail.com; Franck Lenormand ;
> Gaurav Jain ; Horia Geanta ; Ji
> Luo ; ma...@denx.de; Meenakshi Aggarwal
> ; Mingkai Hu ;
> olte...@gmail.com; Pankaj Gupta ; Peng Fan
> ; Pramod Kumar ; Priyanka
> Jain ; Rajesh Bhagat ; Sahil
> Malhotra ; Shengzhou Liu ;
> Silvano Di Ninno ; s...@chromium.org; u-
> b...@lists.denx.de; dl-uboot-imx ; Wasim Khan
> ; Ye Li ; Michael Walle
> 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Caution: EXT Email
> 
> > On 03.03.22 14:41, Gaurav Jain wrote:
> >> As we have not received any response from imx6dl_mamoj board maintainer.
> >> I propose the below solution
> >>
> >> --- a/arch/arm/mach-imx/Kconfig
> >> +++ b/arch/arm/mach-imx/Kconfig
> >> @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
> >> -   select FSL_CAAM if HAS_CAAM
> >> -   imply CMD_DEKBLOB if HAS_CAAM
> >> +   imply FSL_CAAM if HAS_CAAM
> >> +   imply CMD_DEKBLOB if FSL_CAAM
> >>   Help
> >>
> >
> > IMO this is ok, I was also wrong, Marek is not the maintainer of this
> > board. This was the only board with broken build - let's say, I will
> > still wait a couple of days, and if there is no comments, I will apply
> > your series (but then V10). I can apply this fix myself, no need to
> > post the series again (I have not seen any other comment or request to
> change).
> 
> I don't understand why the solution isn't the same one as for the layerscape 
> part
> in this series[1]: enable the config per board (that is your boards) and 
> leave all
> others the same as before?

imx6dl_mamoj caam driver is not enabled by any of my changes.
This board is enabling  IMX_HAB which select FSL_CAAM.
Proposed changes making it imply so that FSL_CAAM can be disabled in board 
defconfig.

Gaurav
> 
> -michael
> 
> [1]
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kern
> el.org%2Fu-
> boot%2F4068dc3f802dad82972c64123743fd08%40walle.cc%2F&data=04%
> 7C01%7Cgaurav.jain%40nxp.com%7C998fc3ba1b384d75e58708da0021058b%7
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637822439101994232%7
> CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI
> 6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=u7fCKThNnSHG0ttLAzOxTo0
> SHC6kGAwDpJgUmdSDokw%3D&reserved=0

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Michael Walle]

> On 03.03.22 14:41, Gaurav Jain wrote:
>> As we have not received any response from imx6dl_mamoj board maintainer.
>> I propose the below solution
>> 
>> --- a/arch/arm/mach-imx/Kconfig
>> +++ b/arch/arm/mach-imx/Kconfig
>> @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
>> -   select FSL_CAAM if HAS_CAAM
>> -   imply CMD_DEKBLOB if HAS_CAAM
>> +   imply FSL_CAAM if HAS_CAAM
>> +   imply CMD_DEKBLOB if FSL_CAAM
>>   Help
>> 
> 
> IMO this is ok, I was also wrong, Marek is not the maintainer of this 
> board. This was the only board with broken build - let's say, I will 
> still wait a couple of days, and if there is no comments, I will apply 
> your series (but then V10). I can apply this fix myself, no need to post 
> the series again (I have not seen any other comment or request to change).

I don't understand why the solution isn't the same one as for the
layerscape part in this series[1]: enable the config per board (that is
your boards) and leave all others the same as before?

-michael

[1] https://lore.kernel.org/u-boot/4068dc3f802dad82972c64123743f...@walle.cc/

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[ZHIZHIKIN Andrey]

Hello Stefano,

> -Original Message-
> From: U-Boot  On Behalf Of Stefano Babic
> Sent: Thursday, March 3, 2022 4:30 PM
> To: Gaurav Jain ; Stefano Babic ; u-
> b...@lists.denx.de; Marek Vasut 
> Cc: Fabio Estevam ; Peng Fan ; Simon 
> Glass
> ; Priyanka Jain ; Ye Li 
> ;
> Horia Geanta ; Ji Luo ; Franck Lenormand
> ; Silvano Di Ninno ; Sahil
> Malhotra ; Pankaj Gupta ; Varun
> Sethi ; dl-uboot-imx ; Shengzhou Liu
> ; Mingkai Hu ; Rajesh Bhagat
> ; Meenakshi Aggarwal ; 
> Wasim
> Khan ; Alison Wang ; Pramod Kumar
> ; Andy Tang ; Adrian Alonso
> ; Vladimir Oltean 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job 
> ring
> driver model
> 
> Hi,
> 
> On 03.03.22 14:41, Gaurav Jain wrote:
> > Hi Stefano
> >
> > As we have not received any response from imx6dl_mamoj board maintainer.
> > I propose the below solution
> >
> > --- a/arch/arm/mach-imx/Kconfig
> > +++ b/arch/arm/mach-imx/Kconfig
> > @@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
> > -   select FSL_CAAM if HAS_CAAM
> > -   imply CMD_DEKBLOB if HAS_CAAM
> > +   imply FSL_CAAM if HAS_CAAM
> > +   imply CMD_DEKBLOB if FSL_CAAM
> >   Help
> >
> 
> IMO this is ok, I was also wrong, Marek is not the maintainer of this
> board. This was the only board with broken build - let's say, I will
> still wait a couple of days, and if there is no comments, I will apply
> your series (but then V10). I can apply this fix myself, no need to post
> the series again (I have not seen any other comment or request to change).

I had a couple of concerns which I raised in V10 without any follow-up. 

Main thing is the JR reservation, which (if applied) would lead to
misconfiguration when upstream TF-A is used, see [1].

> 
> Regards,
> Stefano
> 

Link: [1]: 
https://lore.kernel.org/u-boot/am6pr06mb4691178347827cb77f44f537a6...@am6pr06mb4691.eurprd06.prod.outlook.com/

-- andrey

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Stefano Babic]

Hi,

On 03.03.22 14:41, Gaurav Jain wrote:

Hi Stefano

As we have not received any response from imx6dl_mamoj board maintainer.
I propose the below solution

--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
-   select FSL_CAAM if HAS_CAAM
-   imply CMD_DEKBLOB if HAS_CAAM
+   imply FSL_CAAM if HAS_CAAM
+   imply CMD_DEKBLOB if FSL_CAAM
  Help



IMO this is ok, I was also wrong, Marek is not the maintainer of this 
board. This was the only board with broken build - let's say, I will 
still wait a couple of days, and if there is no comments, I will apply 
your series (but then V10). I can apply this fix myself, no need to post 
the series again (I have not seen any other comment or request to change).


Regards,
Stefano


--- a/configs/imx6dl_mamoj_defconfig
+++ b/configs/imx6dl_mamoj_defconfig
@@ -59,3 +59,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
+CONFIG_FSL_CAAM=n

Need your help to review this or suggest any other solution.

Regards
Gaurav Jain


-Original Message-
From: Stefano Babic 
Sent: Thursday, March 3, 2022 6:32 PM
To: Gaurav Jain ; Stefano Babic ; u-
b...@lists.denx.de; Marek Vasut 
Cc: Fabio Estevam ; Peng Fan ;
Simon Glass ; Priyanka Jain ; Ye
Li ; Horia Geanta ; Ji Luo
; Franck Lenormand ; Silvano Di
Ninno ; Sahil Malhotra ;
Pankaj Gupta ; Varun Sethi ; dl-
uboot-imx ; Shengzhou Liu ;
Mingkai Hu ; Rajesh Bhagat ;
Meenakshi Aggarwal ; Wasim Khan
; Alison Wang ; Pramod
Kumar ; Andy Tang ;
Adrian Alonso ; Vladimir Oltean 
Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
ring driver model

Caution: EXT Email

On 03.03.22 13:44, Gaurav Jain wrote:

Hello Stefano

A gentle reminder!!
Need your help to check the proposed solution to fix imx6dl_mamoj SPL size

issue shared in last mail.

Ouch...is there a solution ? I confess I have not seen, is there an answer by
Marek ?

Regards,
Stefano



Regards
Gaurav Jain


-Original Message-
From: Gaurav Jain
Sent: Friday, February 25, 2022 12:33 PM
To: Stefano Babic ; u-boot@lists.denx.de; Marek Vasut

Cc: Fabio Estevam ; Peng Fan ;
Simon Glass ; Priyanka Jain
; Ye Li ; Horia Geanta
; Ji Luo ; Franck Lenormand
; Silvano Di Ninno
; Sahil Malhotra ;
Pankaj Gupta ; Varun Sethi ;
dl- uboot-imx ; Shengzhou Liu
; Mingkai Hu ; Rajesh
Bhagat ; Meenakshi Aggarwal
; Wasim Khan ;

Alison

Wang ; Pramod Kumar

;

Andy Tang ; Adrian Alonso ;
Vladimir Oltean 
Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
CAAM Job ring driver model

Hello Stefano


-Original Message-
From: Gaurav Jain
Sent: Friday, February 11, 2022 3:09 PM
To: Stefano Babic ; u-boot@lists.denx.de; Marek
Vasut 
Cc: Fabio Estevam ; Peng Fan ;
Simon Glass ; Priyanka Jain
; Ye Li ; Horia Geanta
; Ji Luo ; Franck Lenormand
; Silvano Di Ninno
; Sahil Malhotra ;
Pankaj Gupta ; Varun Sethi ;
dl- uboot-imx ; Shengzhou Liu
; Mingkai Hu ; Rajesh
Bhagat ; Meenakshi Aggarwal
; Wasim Khan ;

Alison

Wang ; Pramod Kumar

;

Andy Tang ; Adrian Alonso
; Vladimir Oltean 
Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
CAAM Job ring driver model

Hello Marek

A gentle reminder!!
Please help to check if some feature can be dropped in SPL from
imx6dl_mamoj board so that CAAM driver model patches can be accepted.

Regards
Gaurav Jain


-Original Message-
From: Gaurav Jain
Sent: Monday, February 7, 2022 12:43 PM
To: Stefano Babic ; u-boot@lists.denx.de; Marek
Vasut 
Cc: Fabio Estevam ; Peng Fan
; Simon Glass ; Priyanka Jain
; Ye Li ; Horia Geanta
; Ji Luo ; Franck Lenormand
; Silvano Di Ninno
; Sahil Malhotra ;
Pankaj Gupta ; Varun Sethi ;
dl- uboot-imx ; Shengzhou Liu
; Mingkai Hu ; Rajesh
Bhagat ; Meenakshi Aggarwal
; Wasim Khan ;

Alison

Wang ; Pramod Kumar

;

Andy Tang ; Adrian Alonso
; Vladimir Oltean 
Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
CAAM Job ring driver model

Hello Marek


-Original Message-
From: Stefano Babic 
Sent: Saturday, February 5, 2022 7:46 PM
To: Gaurav Jain ; u-boot@lists.denx.de
Cc: Stefano Babic ; Fabio Estevam
; Peng Fan ; Simon Glass
; Priyanka Jain ; Ye Li
; Horia Geanta ; Ji Luo
; Franck Lenormand ;
Silvano Di Ninno ; Sahil Malhotra
; Pankaj Gupta ;
Varun Sethi ; dl-uboot-imx ;
Shengzhou Liu ; Mingkai Hu
; Rajesh Bhagat ;
Meenakshi Aggarwal ; Wasim Khan
;

Alison

Wang ; Pramod Kumar

;

Andy Tang ; Adrian Alonso
; Vladimir Oltean ;
Marek Vasut 
Subject: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
CAAM Job ring driver model

Caution: EXT Email

Hi Gaurav,

rather I still have issues to run CI with this applied. The reason
is that this adds an overhead to SPL and it breaks the board
imx6dl_mamoj because SPL exceeds the maximum size for a DL SOC.

See
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
so
ur
ce.d
enx.de%2Fu-boot%2Fcustodians%2Fu-boot-imx%2F-
%2Fjobs%2F387370&data=04%7C01%7Cgaurav.jain%40nxp.

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hi Stefano

As we have not received any response from imx6dl_mamoj board maintainer.
I propose the below solution

--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
-   select FSL_CAAM if HAS_CAAM
-   imply CMD_DEKBLOB if HAS_CAAM
+   imply FSL_CAAM if HAS_CAAM
+   imply CMD_DEKBLOB if FSL_CAAM
 Help

--- a/configs/imx6dl_mamoj_defconfig
+++ b/configs/imx6dl_mamoj_defconfig
@@ -59,3 +59,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
+CONFIG_FSL_CAAM=n

Need your help to review this or suggest any other solution.

Regards
Gaurav Jain

> -Original Message-
> From: Stefano Babic 
> Sent: Thursday, March 3, 2022 6:32 PM
> To: Gaurav Jain ; Stefano Babic ; u-
> b...@lists.denx.de; Marek Vasut 
> Cc: Fabio Estevam ; Peng Fan ;
> Simon Glass ; Priyanka Jain ; Ye
> Li ; Horia Geanta ; Ji Luo
> ; Franck Lenormand ; Silvano Di
> Ninno ; Sahil Malhotra ;
> Pankaj Gupta ; Varun Sethi ; dl-
> uboot-imx ; Shengzhou Liu ;
> Mingkai Hu ; Rajesh Bhagat ;
> Meenakshi Aggarwal ; Wasim Khan
> ; Alison Wang ; Pramod
> Kumar ; Andy Tang ;
> Adrian Alonso ; Vladimir Oltean 
> Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Caution: EXT Email
> 
> On 03.03.22 13:44, Gaurav Jain wrote:
> > Hello Stefano
> >
> > A gentle reminder!!
> > Need your help to check the proposed solution to fix imx6dl_mamoj SPL size
> issue shared in last mail.
> 
> Ouch...is there a solution ? I confess I have not seen, is there an answer by
> Marek ?
> 
> Regards,
> Stefano
> 
> >
> > Regards
> > Gaurav Jain
> >
> >> -Original Message-
> >> From: Gaurav Jain
> >> Sent: Friday, February 25, 2022 12:33 PM
> >> To: Stefano Babic ; u-boot@lists.denx.de; Marek Vasut
> >> 
> >> Cc: Fabio Estevam ; Peng Fan ;
> >> Simon Glass ; Priyanka Jain
> >> ; Ye Li ; Horia Geanta
> >> ; Ji Luo ; Franck Lenormand
> >> ; Silvano Di Ninno
> >> ; Sahil Malhotra ;
> >> Pankaj Gupta ; Varun Sethi ;
> >> dl- uboot-imx ; Shengzhou Liu
> >> ; Mingkai Hu ; Rajesh
> >> Bhagat ; Meenakshi Aggarwal
> >> ; Wasim Khan ;
> Alison
> >> Wang ; Pramod Kumar
> ;
> >> Andy Tang ; Adrian Alonso ;
> >> Vladimir Oltean 
> >> Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> >> CAAM Job ring driver model
> >>
> >> Hello Stefano
> >>
> >>> -Original Message-
> >>> From: Gaurav Jain
> >>> Sent: Friday, February 11, 2022 3:09 PM
> >>> To: Stefano Babic ; u-boot@lists.denx.de; Marek
> >>> Vasut 
> >>> Cc: Fabio Estevam ; Peng Fan ;
> >>> Simon Glass ; Priyanka Jain
> >>> ; Ye Li ; Horia Geanta
> >>> ; Ji Luo ; Franck Lenormand
> >>> ; Silvano Di Ninno
> >>> ; Sahil Malhotra ;
> >>> Pankaj Gupta ; Varun Sethi ;
> >>> dl- uboot-imx ; Shengzhou Liu
> >>> ; Mingkai Hu ; Rajesh
> >>> Bhagat ; Meenakshi Aggarwal
> >>> ; Wasim Khan ;
> >> Alison
> >>> Wang ; Pramod Kumar
> >> ;
> >>> Andy Tang ; Adrian Alonso
> >>> ; Vladimir Oltean 
> >>> Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> >>> CAAM Job ring driver model
> >>>
> >>> Hello Marek
> >>>
> >>> A gentle reminder!!
> >>> Please help to check if some feature can be dropped in SPL from
> >>> imx6dl_mamoj board so that CAAM driver model patches can be accepted.
> >>>
> >>> Regards
> >>> Gaurav Jain
> >>>
> >>>> -Original Message-
> >>>> From: Gaurav Jain
> >>>> Sent: Monday, February 7, 2022 12:43 PM
> >>>> To: Stefano Babic ; u-boot@lists.denx.de; Marek
> >>>> Vasut 
> >>>> Cc: Fabio Estevam ; Peng Fan
> >>>> ; Simon Glass ; Priyanka Jain
> >>>> ; Ye Li ; Horia Geanta
> >>>> ; Ji Luo ; Franck Lenormand
> >>>> ; Silvano Di Ninno
> >>>> ; Sahil Malhotra ;
> >>>> Pankaj Gupta ; Varun Sethi ;
> >>>> dl- uboot-imx ; Shengzhou Liu
> >>>> ; Mingkai Hu ; Rajesh
> >>>> Bhagat ; Meenakshi Aggarwal
> >>>> ; Wasim Khan ;
> >>> Alison
> >>>> Wang ; Pramod Kumar
> >>> ;
> >>>> Andy Tang ; Adrian Alonso
> >

Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Stefano Babic]

On 03.03.22 13:44, Gaurav Jain wrote:

Hello Stefano

A gentle reminder!!
Need your help to check the proposed solution to fix imx6dl_mamoj SPL size 
issue shared in last mail.


Ouch...is there a solution ? I confess I have not seen, is there an 
answer by Marek ?


Regards,
Stefano



Regards
Gaurav Jain


-Original Message-
From: Gaurav Jain
Sent: Friday, February 25, 2022 12:33 PM
To: Stefano Babic ; u-boot@lists.denx.de; Marek Vasut

Cc: Fabio Estevam ; Peng Fan ;
Simon Glass ; Priyanka Jain ; Ye
Li ; Horia Geanta ; Ji Luo
; Franck Lenormand ; Silvano Di
Ninno ; Sahil Malhotra ;
Pankaj Gupta ; Varun Sethi ; dl-
uboot-imx ; Shengzhou Liu ;
Mingkai Hu ; Rajesh Bhagat ;
Meenakshi Aggarwal ; Wasim Khan
; Alison Wang ; Pramod
Kumar ; Andy Tang ;
Adrian Alonso ; Vladimir Oltean 
Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
ring driver model

Hello Stefano


-Original Message-
From: Gaurav Jain
Sent: Friday, February 11, 2022 3:09 PM
To: Stefano Babic ; u-boot@lists.denx.de; Marek Vasut

Cc: Fabio Estevam ; Peng Fan ;
Simon Glass ; Priyanka Jain ;
Ye Li ; Horia Geanta ; Ji Luo
; Franck Lenormand ; Silvano
Di Ninno ; Sahil Malhotra
; Pankaj Gupta ; Varun
Sethi ; dl- uboot-imx ; Shengzhou
Liu ; Mingkai Hu ; Rajesh
Bhagat ; Meenakshi Aggarwal
; Wasim Khan ;

Alison

Wang ; Pramod Kumar

;

Andy Tang ; Adrian Alonso ;
Vladimir Oltean 
Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
CAAM Job ring driver model

Hello Marek

A gentle reminder!!
Please help to check if some feature can be dropped in SPL from
imx6dl_mamoj board so that CAAM driver model patches can be accepted.

Regards
Gaurav Jain


-Original Message-
From: Gaurav Jain
Sent: Monday, February 7, 2022 12:43 PM
To: Stefano Babic ; u-boot@lists.denx.de; Marek
Vasut 
Cc: Fabio Estevam ; Peng Fan ;
Simon Glass ; Priyanka Jain
; Ye Li ; Horia Geanta
; Ji Luo ; Franck Lenormand
; Silvano Di Ninno
; Sahil Malhotra ;
Pankaj Gupta ; Varun Sethi ;
dl- uboot-imx ; Shengzhou Liu
; Mingkai Hu ; Rajesh
Bhagat ; Meenakshi Aggarwal
; Wasim Khan ;

Alison

Wang ; Pramod Kumar

;

Andy Tang ; Adrian Alonso
; Vladimir Oltean 
Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
CAAM Job ring driver model

Hello Marek


-Original Message-
From: Stefano Babic 
Sent: Saturday, February 5, 2022 7:46 PM
To: Gaurav Jain ; u-boot@lists.denx.de
Cc: Stefano Babic ; Fabio Estevam
; Peng Fan ; Simon Glass
; Priyanka Jain ; Ye Li
; Horia Geanta ; Ji Luo
; Franck Lenormand ;
Silvano Di Ninno ; Sahil Malhotra
; Pankaj Gupta ;
Varun Sethi ; dl-uboot-imx ;
Shengzhou Liu ; Mingkai Hu
; Rajesh Bhagat ;
Meenakshi Aggarwal ; Wasim Khan
;

Alison

Wang ; Pramod Kumar

;

Andy Tang ; Adrian Alonso
; Vladimir Oltean ;
Marek Vasut 
Subject: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
CAAM Job ring driver model

Caution: EXT Email

Hi Gaurav,

rather I still have issues to run CI with this applied. The reason
is that this adds an overhead to SPL and it breaks the board
imx6dl_mamoj because SPL exceeds the maximum size for a DL SOC.

See
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
so
ur
ce.d
enx.de%2Fu-boot%2Fcustodians%2Fu-boot-imx%2F-
%2Fjobs%2F387370&data=04%7C01%7Cgaurav.jain%40nxp.com%7C

3a

2

73







1dd27fc4bebcad308d9e8b21464%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C







0%7C0%7C637796673834942697%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4







wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am







p;sdata=pI%2F%2FlNtrdrGCa8sSvcr6uNu4jze7pzDqZtI52FIDj50%3D&reserve

d=0

I do not know if it is possible to drop some features from SPL for
this board (Added Marek as board maintainer).


As we have not received any response from imx6dl_mamoj board maintainer.
I propose the below solution

--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN  config IMX_HAB
-   select FSL_CAAM if HAS_CAAM
-   imply CMD_DEKBLOB if HAS_CAAM
+   imply FSL_CAAM if HAS_CAAM
+   imply CMD_DEKBLOB if FSL_CAAM
 Help

--- a/configs/imx6dl_mamoj_defconfig
+++ b/configs/imx6dl_mamoj_defconfig
@@ -59,3 +59,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
+CONFIG_FSL_CAAM=n

Need your help to review this or suggest any other solution.

Regards
Gaurav Jain



CONFIG_IMX_HAB is enabled for imx6dl_mamoj. So CAAM is built for
SPL, results in increased size.
However CAAM is not initialized in SPL. As Stefano suggested, Can
you drop some features from SPL?

Regards
Gaurav Jain


Best regards,
Stefano

On 10.01.22 13:27, Gaurav Jain wrote:

added device tree support for job ring driver.
sec is initialized based on job ring information processed from
device tree.

Signed-off-by: Gaurav Jain 
Reviewed-by: Ye Li 
---
   drivers/crypto/fsl/jr.c | 323 ++--
   drivers/crypto/fsl/jr.h |  31 +++-
   2 files changed, 240 insertions(+), 114 deletions(-)

diff --gi

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hello Stefano

A gentle reminder!!
Need your help to check the proposed solution to fix imx6dl_mamoj SPL size 
issue shared in last mail.

Regards
Gaurav Jain

> -Original Message-
> From: Gaurav Jain
> Sent: Friday, February 25, 2022 12:33 PM
> To: Stefano Babic ; u-boot@lists.denx.de; Marek Vasut
> 
> Cc: Fabio Estevam ; Peng Fan ;
> Simon Glass ; Priyanka Jain ; Ye
> Li ; Horia Geanta ; Ji Luo
> ; Franck Lenormand ; Silvano Di
> Ninno ; Sahil Malhotra ;
> Pankaj Gupta ; Varun Sethi ; dl-
> uboot-imx ; Shengzhou Liu ;
> Mingkai Hu ; Rajesh Bhagat ;
> Meenakshi Aggarwal ; Wasim Khan
> ; Alison Wang ; Pramod
> Kumar ; Andy Tang ;
> Adrian Alonso ; Vladimir Oltean 
> Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Hello Stefano
> 
> > -Original Message-
> > From: Gaurav Jain
> > Sent: Friday, February 11, 2022 3:09 PM
> > To: Stefano Babic ; u-boot@lists.denx.de; Marek Vasut
> > 
> > Cc: Fabio Estevam ; Peng Fan ;
> > Simon Glass ; Priyanka Jain ;
> > Ye Li ; Horia Geanta ; Ji Luo
> > ; Franck Lenormand ; Silvano
> > Di Ninno ; Sahil Malhotra
> > ; Pankaj Gupta ; Varun
> > Sethi ; dl- uboot-imx ; Shengzhou
> > Liu ; Mingkai Hu ; Rajesh
> > Bhagat ; Meenakshi Aggarwal
> > ; Wasim Khan ;
> Alison
> > Wang ; Pramod Kumar
> ;
> > Andy Tang ; Adrian Alonso ;
> > Vladimir Oltean 
> > Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > CAAM Job ring driver model
> >
> > Hello Marek
> >
> > A gentle reminder!!
> > Please help to check if some feature can be dropped in SPL from
> > imx6dl_mamoj board so that CAAM driver model patches can be accepted.
> >
> > Regards
> > Gaurav Jain
> >
> > > -Original Message-
> > > From: Gaurav Jain
> > > Sent: Monday, February 7, 2022 12:43 PM
> > > To: Stefano Babic ; u-boot@lists.denx.de; Marek
> > > Vasut 
> > > Cc: Fabio Estevam ; Peng Fan ;
> > > Simon Glass ; Priyanka Jain
> > > ; Ye Li ; Horia Geanta
> > > ; Ji Luo ; Franck Lenormand
> > > ; Silvano Di Ninno
> > > ; Sahil Malhotra ;
> > > Pankaj Gupta ; Varun Sethi ;
> > > dl- uboot-imx ; Shengzhou Liu
> > > ; Mingkai Hu ; Rajesh
> > > Bhagat ; Meenakshi Aggarwal
> > > ; Wasim Khan ;
> > Alison
> > > Wang ; Pramod Kumar
> > ;
> > > Andy Tang ; Adrian Alonso
> > > ; Vladimir Oltean 
> > > Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > > CAAM Job ring driver model
> > >
> > > Hello Marek
> > >
> > > > -Original Message-
> > > > From: Stefano Babic 
> > > > Sent: Saturday, February 5, 2022 7:46 PM
> > > > To: Gaurav Jain ; u-boot@lists.denx.de
> > > > Cc: Stefano Babic ; Fabio Estevam
> > > > ; Peng Fan ; Simon Glass
> > > > ; Priyanka Jain ; Ye Li
> > > > ; Horia Geanta ; Ji Luo
> > > > ; Franck Lenormand ;
> > > > Silvano Di Ninno ; Sahil Malhotra
> > > > ; Pankaj Gupta ;
> > > > Varun Sethi ; dl-uboot-imx ;
> > > > Shengzhou Liu ; Mingkai Hu
> > > > ; Rajesh Bhagat ;
> > > > Meenakshi Aggarwal ; Wasim Khan
> > > > ;
> > > Alison
> > > > Wang ; Pramod Kumar
> > > ;
> > > > Andy Tang ; Adrian Alonso
> > > > ; Vladimir Oltean ;
> > > > Marek Vasut 
> > > > Subject: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > > > CAAM Job ring driver model
> > > >
> > > > Caution: EXT Email
> > > >
> > > > Hi Gaurav,
> > > >
> > > > rather I still have issues to run CI with this applied. The reason
> > > > is that this adds an overhead to SPL and it breaks the board
> > > > imx6dl_mamoj because SPL exceeds the maximum size for a DL SOC.
> > > >
> > > > See
> > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> > > > so
> > > > ur
> > > > ce.d
> > > > enx.de%2Fu-boot%2Fcustodians%2Fu-boot-imx%2F-
> > > > %2Fjobs%2F387370&data=04%7C01%7Cgaurav.jain%40nxp.com%7C
> 3a
> > 2
> > > 73
> > > >
> > >
> >
> 1dd27fc4bebcad308d9e8b21464%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> > > >
> > >
> >
> 0%7C0%7C637796673834942697%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> > > >

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hello Stefano

> -Original Message-
> From: Gaurav Jain
> Sent: Friday, February 11, 2022 3:09 PM
> To: Stefano Babic ; u-boot@lists.denx.de; Marek Vasut
> 
> Cc: Fabio Estevam ; Peng Fan ;
> Simon Glass ; Priyanka Jain ; Ye
> Li ; Horia Geanta ; Ji Luo
> ; Franck Lenormand ; Silvano Di
> Ninno ; Sahil Malhotra ;
> Pankaj Gupta ; Varun Sethi ; dl-
> uboot-imx ; Shengzhou Liu ;
> Mingkai Hu ; Rajesh Bhagat ;
> Meenakshi Aggarwal ; Wasim Khan
> ; Alison Wang ; Pramod
> Kumar ; Andy Tang ;
> Adrian Alonso ; Vladimir Oltean 
> Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Hello Marek
> 
> A gentle reminder!!
> Please help to check if some feature can be dropped in SPL from imx6dl_mamoj
> board so that CAAM driver model patches can be accepted.
> 
> Regards
> Gaurav Jain
> 
> > -Original Message-
> > From: Gaurav Jain
> > Sent: Monday, February 7, 2022 12:43 PM
> > To: Stefano Babic ; u-boot@lists.denx.de; Marek Vasut
> > 
> > Cc: Fabio Estevam ; Peng Fan ;
> > Simon Glass ; Priyanka Jain ;
> > Ye Li ; Horia Geanta ; Ji Luo
> > ; Franck Lenormand ; Silvano
> > Di Ninno ; Sahil Malhotra
> > ; Pankaj Gupta ; Varun
> > Sethi ; dl- uboot-imx ; Shengzhou
> > Liu ; Mingkai Hu ; Rajesh
> > Bhagat ; Meenakshi Aggarwal
> > ; Wasim Khan ;
> Alison
> > Wang ; Pramod Kumar
> ;
> > Andy Tang ; Adrian Alonso ;
> > Vladimir Oltean 
> > Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > CAAM Job ring driver model
> >
> > Hello Marek
> >
> > > -Original Message-
> > > From: Stefano Babic 
> > > Sent: Saturday, February 5, 2022 7:46 PM
> > > To: Gaurav Jain ; u-boot@lists.denx.de
> > > Cc: Stefano Babic ; Fabio Estevam
> > > ; Peng Fan ; Simon Glass
> > > ; Priyanka Jain ; Ye Li
> > > ; Horia Geanta ; Ji Luo
> > > ; Franck Lenormand ;
> > > Silvano Di Ninno ; Sahil Malhotra
> > > ; Pankaj Gupta ; Varun
> > > Sethi ; dl-uboot-imx ; Shengzhou
> > > Liu ; Mingkai Hu ; Rajesh
> > > Bhagat ; Meenakshi Aggarwal
> > > ; Wasim Khan ;
> > Alison
> > > Wang ; Pramod Kumar
> > ;
> > > Andy Tang ; Adrian Alonso
> > > ; Vladimir Oltean ; Marek
> > > Vasut 
> > > Subject: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM
> > > Job ring driver model
> > >
> > > Caution: EXT Email
> > >
> > > Hi Gaurav,
> > >
> > > rather I still have issues to run CI with this applied. The reason
> > > is that this adds an overhead to SPL and it breaks the board
> > > imx6dl_mamoj because SPL exceeds the maximum size for a DL SOC.
> > >
> > > See
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fso
> > > ur
> > > ce.d
> > > enx.de%2Fu-boot%2Fcustodians%2Fu-boot-imx%2F-
> > > %2Fjobs%2F387370&data=04%7C01%7Cgaurav.jain%40nxp.com%7C3a
> 2
> > 73
> > >
> >
> 1dd27fc4bebcad308d9e8b21464%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> > >
> >
> 0%7C0%7C637796673834942697%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> > >
> >
> wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am
> > >
> >
> p;sdata=pI%2F%2FlNtrdrGCa8sSvcr6uNu4jze7pzDqZtI52FIDj50%3D&reserve
> > > d=0
> > >
> > > I do not know if it is possible to drop some features from SPL for
> > > this board (Added Marek as board maintainer).

As we have not received any response from imx6dl_mamoj board maintainer. 
I propose the below solution
 
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -49,8 +49,8 @@ config USE_IMXIMG_PLUGIN
 config IMX_HAB
-   select FSL_CAAM if HAS_CAAM
-   imply CMD_DEKBLOB if HAS_CAAM
+   imply FSL_CAAM if HAS_CAAM
+   imply CMD_DEKBLOB if FSL_CAAM
Help

--- a/configs/imx6dl_mamoj_defconfig
+++ b/configs/imx6dl_mamoj_defconfig
@@ -59,3 +59,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
+CONFIG_FSL_CAAM=n

Need your help to review this or suggest any other solution.

Regards
Gaurav Jain

> >
> > CONFIG_IMX_HAB is enabled for imx6dl_mamoj. So CAAM is built for SPL,
> > results in increased size.
> > However CAAM is not initialized in SPL. As Stefano suggested, Can you
> > drop some features from SPL?
> >
> > Regards
> > Gaurav Jain
> > >
> > > Best regards,
> > > Stefano
> > >
> > > On 10.01.22 13:27, Gaurav Jain wrote:
> &

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hello Marek

A gentle reminder!!
Please help to check if some feature can be dropped in SPL from imx6dl_mamoj 
board so that CAAM driver model patches can be accepted.

Regards
Gaurav Jain

> -Original Message-
> From: Gaurav Jain
> Sent: Monday, February 7, 2022 12:43 PM
> To: Stefano Babic ; u-boot@lists.denx.de; Marek Vasut
> 
> Cc: Fabio Estevam ; Peng Fan ;
> Simon Glass ; Priyanka Jain ; Ye
> Li ; Horia Geanta ; Ji Luo
> ; Franck Lenormand ; Silvano Di
> Ninno ; Sahil Malhotra ;
> Pankaj Gupta ; Varun Sethi ; dl-
> uboot-imx ; Shengzhou Liu ;
> Mingkai Hu ; Rajesh Bhagat ;
> Meenakshi Aggarwal ; Wasim Khan
> ; Alison Wang ; Pramod
> Kumar ; Andy Tang ;
> Adrian Alonso ; Vladimir Oltean 
> Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Hello Marek
> 
> > -Original Message-
> > From: Stefano Babic 
> > Sent: Saturday, February 5, 2022 7:46 PM
> > To: Gaurav Jain ; u-boot@lists.denx.de
> > Cc: Stefano Babic ; Fabio Estevam
> > ; Peng Fan ; Simon Glass
> > ; Priyanka Jain ; Ye Li
> > ; Horia Geanta ; Ji Luo
> > ; Franck Lenormand ; Silvano
> > Di Ninno ; Sahil Malhotra
> > ; Pankaj Gupta ; Varun
> > Sethi ; dl-uboot-imx ; Shengzhou
> > Liu ; Mingkai Hu ; Rajesh
> > Bhagat ; Meenakshi Aggarwal
> > ; Wasim Khan ;
> Alison
> > Wang ; Pramod Kumar
> ;
> > Andy Tang ; Adrian Alonso ;
> > Vladimir Oltean ; Marek Vasut 
> > Subject: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM
> > Job ring driver model
> >
> > Caution: EXT Email
> >
> > Hi Gaurav,
> >
> > rather I still have issues to run CI with this applied. The reason is
> > that this adds an overhead to SPL and it breaks the board imx6dl_mamoj
> > because SPL exceeds the maximum size for a DL SOC.
> >
> > See
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour
> > ce.d
> > enx.de%2Fu-boot%2Fcustodians%2Fu-boot-imx%2F-
> > %2Fjobs%2F387370&data=04%7C01%7Cgaurav.jain%40nxp.com%7C3a2
> 73
> >
> 1dd27fc4bebcad308d9e8b21464%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> >
> 0%7C0%7C637796673834942697%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> >
> wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am
> >
> p;sdata=pI%2F%2FlNtrdrGCa8sSvcr6uNu4jze7pzDqZtI52FIDj50%3D&reserve
> > d=0
> >
> > I do not know if it is possible to drop some features from SPL for
> > this board (Added Marek as board maintainer).
> 
> CONFIG_IMX_HAB is enabled for imx6dl_mamoj. So CAAM is built for SPL,
> results in increased size.
> However CAAM is not initialized in SPL. As Stefano suggested, Can you drop
> some features from SPL?
> 
> Regards
> Gaurav Jain
> >
> > Best regards,
> > Stefano
> >
> > On 10.01.22 13:27, Gaurav Jain wrote:
> > > added device tree support for job ring driver.
> > > sec is initialized based on job ring information processed from
> > > device tree.
> > >
> > > Signed-off-by: Gaurav Jain 
> > > Reviewed-by: Ye Li 
> > > ---
> > >   drivers/crypto/fsl/jr.c | 323 ++--
> > >   drivers/crypto/fsl/jr.h |  31 +++-
> > >   2 files changed, 240 insertions(+), 114 deletions(-)
> > >
> > > diff --git a/drivers/crypto/fsl/jr.c b/drivers/crypto/fsl/jr.c index
> > > 22b649219e..8103987425 100644
> > > --- a/drivers/crypto/fsl/jr.c
> > > +++ b/drivers/crypto/fsl/jr.c
> > > @@ -1,7 +1,7 @@
> > >   // SPDX-License-Identifier: GPL-2.0+
> > >   /*
> > >* Copyright 2008-2014 Freescale Semiconductor, Inc.
> > > - * Copyright 2018 NXP
> > > + * Copyright 2018, 2021 NXP
> > >*
> > >* Based on CAAM driver in drivers/crypto/caam in Linux
> > >*/
> > > @@ -11,7 +11,6 @@
> > >   #include 
> > >   #include 
> > >   #include 
> > > -#include "fsl_sec.h"
> > >   #include "jr.h"
> > >   #include "jobdesc.h"
> > >   #include "desc_constr.h"
> > > @@ -21,7 +20,10 @@
> > >   #include 
> > >   #include 
> > >   #endif
> > > +#include 
> > >   #include 
> > > +#include 
> > > +#include 
> > >   #include 
> > >
> > >   #define CIRC_CNT(head, tail, size)  (((head) - (tail)) & (size -
> > > 1)) @@ -35,20 +37,29 @@ uint32_t
> > sec_offset[CONFIG_SYS_FSL_MAX_NUM_OF_SEC] = {
> > >   #endif
> &

RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Gaurav Jain]

Hello Marek

> -Original Message-
> From: Stefano Babic 
> Sent: Saturday, February 5, 2022 7:46 PM
> To: Gaurav Jain ; u-boot@lists.denx.de
> Cc: Stefano Babic ; Fabio Estevam ;
> Peng Fan ; Simon Glass ; Priyanka
> Jain ; Ye Li ; Horia Geanta
> ; Ji Luo ; Franck Lenormand
> ; Silvano Di Ninno ;
> Sahil Malhotra ; Pankaj Gupta
> ; Varun Sethi ; dl-uboot-imx
> ; Shengzhou Liu ; Mingkai Hu
> ; Rajesh Bhagat ; Meenakshi
> Aggarwal ; Wasim Khan
> ; Alison Wang ; Pramod
> Kumar ; Andy Tang ;
> Adrian Alonso ; Vladimir Oltean
> ; Marek Vasut 
> Subject: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring
> driver model
> 
> Caution: EXT Email
> 
> Hi Gaurav,
> 
> rather I still have issues to run CI with this applied. The reason is that 
> this adds an
> overhead to SPL and it breaks the board imx6dl_mamoj because SPL exceeds the
> maximum size for a DL SOC.
> 
> See
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource.d
> enx.de%2Fu-boot%2Fcustodians%2Fu-boot-imx%2F-
> %2Fjobs%2F387370&data=04%7C01%7Cgaurav.jain%40nxp.com%7C3a273
> 1dd27fc4bebcad308d9e8b21464%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C
> 0%7C0%7C637796673834942697%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am
> p;sdata=pI%2F%2FlNtrdrGCa8sSvcr6uNu4jze7pzDqZtI52FIDj50%3D&reserve
> d=0
> 
> I do not know if it is possible to drop some features from SPL for this board
> (Added Marek as board maintainer).

CONFIG_IMX_HAB is enabled for imx6dl_mamoj. So CAAM is built for SPL, results 
in increased size.
However CAAM is not initialized in SPL. As Stefano suggested, Can you drop some 
features from SPL?

Regards
Gaurav Jain 
> 
> Best regards,
> Stefano
> 
> On 10.01.22 13:27, Gaurav Jain wrote:
> > added device tree support for job ring driver.
> > sec is initialized based on job ring information processed from device
> > tree.
> >
> > Signed-off-by: Gaurav Jain 
> > Reviewed-by: Ye Li 
> > ---
> >   drivers/crypto/fsl/jr.c | 323 ++--
> >   drivers/crypto/fsl/jr.h |  31 +++-
> >   2 files changed, 240 insertions(+), 114 deletions(-)
> >
> > diff --git a/drivers/crypto/fsl/jr.c b/drivers/crypto/fsl/jr.c index
> > 22b649219e..8103987425 100644
> > --- a/drivers/crypto/fsl/jr.c
> > +++ b/drivers/crypto/fsl/jr.c
> > @@ -1,7 +1,7 @@
> >   // SPDX-License-Identifier: GPL-2.0+
> >   /*
> >* Copyright 2008-2014 Freescale Semiconductor, Inc.
> > - * Copyright 2018 NXP
> > + * Copyright 2018, 2021 NXP
> >*
> >* Based on CAAM driver in drivers/crypto/caam in Linux
> >*/
> > @@ -11,7 +11,6 @@
> >   #include 
> >   #include 
> >   #include 
> > -#include "fsl_sec.h"
> >   #include "jr.h"
> >   #include "jobdesc.h"
> >   #include "desc_constr.h"
> > @@ -21,7 +20,10 @@
> >   #include 
> >   #include 
> >   #endif
> > +#include 
> >   #include 
> > +#include 
> > +#include 
> >   #include 
> >
> >   #define CIRC_CNT(head, tail, size)  (((head) - (tail)) & (size - 1))
> > @@ -35,20 +37,29 @@ uint32_t
> sec_offset[CONFIG_SYS_FSL_MAX_NUM_OF_SEC] = {
> >   #endif
> >   };
> >
> > +#if CONFIG_IS_ENABLED(DM)
> > +struct udevice *caam_dev;
> > +#else
> >   #define SEC_ADDR(idx)   \
> >   (ulong)((CONFIG_SYS_FSL_SEC_ADDR + sec_offset[idx]))
> >
> >   #define SEC_JR0_ADDR(idx)   \
> >   (ulong)(SEC_ADDR(idx) + \
> >(CONFIG_SYS_FSL_JR0_OFFSET - CONFIG_SYS_FSL_SEC_OFFSET))
> > +struct caam_regs caam_st;
> > +#endif
> >
> > -struct jobring jr0[CONFIG_SYS_FSL_MAX_NUM_OF_SEC];
> > +static inline u32 jr_start_reg(u8 jrid) {
> > + return (1 << jrid);
> > +}
> >
> > -static inline void start_jr0(uint8_t sec_idx)
> > +static inline void start_jr(struct caam_regs *caam)
> >   {
> > - ccsr_sec_t *sec = (void *)SEC_ADDR(sec_idx);
> > + ccsr_sec_t *sec = caam->sec;
> >   u32 ctpr_ms = sec_in32(&sec->ctpr_ms);
> >   u32 scfgr = sec_in32(&sec->scfgr);
> > + u32 jrstart = jr_start_reg(caam->jrid);
> >
> >   if (ctpr_ms & SEC_CTPR_MS_VIRT_EN_INCL) {
> >   /* VIRT_EN_INCL = 1 & VIRT_EN_POR = 1 or @@ -56,23
> > +67,16 @@ static inline void start_jr0(uint8_t sec_idx)
> >*/
> >   if ((ctpr_ms & SEC_CTPR_MS_VIRT_EN_POR) ||
> >   (scfgr & SEC_