Re: [U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync
I'm ok if you take them. I should be doing a push today, so either way works for me. On Aug 18, 2012, at 2:05 PM, Scott Wood wrote: On 08/13/2012 06:23 PM, Scott Wood wrote: On 08/13/2012 01:10 PM, Matthew McClintock wrote: This change reduces the SPL size by removing the redundant syncs produced by out_be32 and just replies on one final sync Done with: sed -r '/in_be32/b; s/(out_be32)\(([^,]*),\s+(.*)\)/__raw_writel(\3, \2)/g' -i `git grep --name-only sdram_init nand_spl/` Signed-off-by: Matthew McClintock m...@freescale.com --- nand_spl/board/freescale/p1010rdb/nand_boot.c | 54 ++--- nand_spl/board/freescale/p1023rds/nand_boot.c | 42 nand_spl/board/freescale/p1_p2_rdb_pc/nand_boot.c | 48 +- 3 files changed, 71 insertions(+), 73 deletions(-) This should come first if the other patches break without it, to preserve bisectability. Note that I'm going to try to convert this stuff (at least one board as an example, but hopefully it should be easy enough to do additional boards once the first is done) to the new spl Really Soon Now(tm), so it doesn't make much sense to fiddle around with the old stuff right now unless I miss the merge window. I'll incorporate these changes into the new-spl version. I may do that by applying these patches first, but I'd rather they not go via the mpc85xx tree (and please CC me on NAND patches). I'm not going to have this working by the end of the merge window, so these patches can go in as is. Andy, do you want to take them or should I? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync
On 08/20/2012 11:11 AM, Andy Fleming wrote: I'm ok if you take them. I should be doing a push today, so either way works for me. If you're doing one today, go ahead and take them: Acked-by: Scott Wood scottw...@freescale.com -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync
On 08/13/2012 06:23 PM, Scott Wood wrote: On 08/13/2012 01:10 PM, Matthew McClintock wrote: This change reduces the SPL size by removing the redundant syncs produced by out_be32 and just replies on one final sync Done with: sed -r '/in_be32/b; s/(out_be32)\(([^,]*),\s+(.*)\)/__raw_writel(\3, \2)/g' -i `git grep --name-only sdram_init nand_spl/` Signed-off-by: Matthew McClintock m...@freescale.com --- nand_spl/board/freescale/p1010rdb/nand_boot.c | 54 ++--- nand_spl/board/freescale/p1023rds/nand_boot.c | 42 nand_spl/board/freescale/p1_p2_rdb_pc/nand_boot.c | 48 +- 3 files changed, 71 insertions(+), 73 deletions(-) This should come first if the other patches break without it, to preserve bisectability. Note that I'm going to try to convert this stuff (at least one board as an example, but hopefully it should be easy enough to do additional boards once the first is done) to the new spl Really Soon Now(tm), so it doesn't make much sense to fiddle around with the old stuff right now unless I miss the merge window. I'll incorporate these changes into the new-spl version. I may do that by applying these patches first, but I'd rather they not go via the mpc85xx tree (and please CC me on NAND patches). I'm not going to have this working by the end of the merge window, so these patches can go in as is. Andy, do you want to take them or should I? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync
This change reduces the SPL size by removing the redundant syncs produced
by out_be32 and just replies on one final sync
Done with:
sed -r '/in_be32/b; s/(out_be32)\(([^,]*),\s+(.*)\)/__raw_writel(\3, \2)/g' -i
`git grep --name-only sdram_init nand_spl/`
Signed-off-by: Matthew McClintock m...@freescale.com
---
nand_spl/board/freescale/p1010rdb/nand_boot.c | 54 ++---
nand_spl/board/freescale/p1023rds/nand_boot.c | 42
nand_spl/board/freescale/p1_p2_rdb_pc/nand_boot.c | 48 +-
3 files changed, 71 insertions(+), 73 deletions(-)
diff --git a/nand_spl/board/freescale/p1010rdb/nand_boot.c
b/nand_spl/board/freescale/p1010rdb/nand_boot.c
index 931e562..7190b00 100644
--- a/nand_spl/board/freescale/p1010rdb/nand_boot.c
+++ b/nand_spl/board/freescale/p1010rdb/nand_boot.c
@@ -36,39 +36,37 @@ void sdram_init(void)
/* mask off E bit */
u32 svr = SVR_SOC_VER(mfspr(SPRN_SVR));
- out_be32(ddr-sdram_cfg, CONFIG_SYS_DDR_CONTROL | SDRAM_CFG_32_BE);
- out_be32(ddr-cs0_bnds, CONFIG_SYS_DDR_CS0_BNDS);
- out_be32(ddr-cs0_config, CONFIG_SYS_DDR_CS0_CONFIG);
- out_be32(ddr-sdram_cfg_2, CONFIG_SYS_DDR_CONTROL_2);
- out_be32(ddr-sdram_data_init, CONFIG_SYS_DDR_DATA_INIT);
+ __raw_writel(CONFIG_SYS_DDR_CONTROL | SDRAM_CFG_32_BE, ddr-sdram_cfg);
+ __raw_writel(CONFIG_SYS_DDR_CS0_BNDS, ddr-cs0_bnds);
+ __raw_writel(CONFIG_SYS_DDR_CS0_CONFIG, ddr-cs0_config);
+ __raw_writel(CONFIG_SYS_DDR_CONTROL_2, ddr-sdram_cfg_2);
+ __raw_writel(CONFIG_SYS_DDR_DATA_INIT, ddr-sdram_data_init);
if (ddr_freq_mhz 700) {
- out_be32(ddr-timing_cfg_3, CONFIG_SYS_DDR_TIMING_3_667);
- out_be32(ddr-timing_cfg_0, CONFIG_SYS_DDR_TIMING_0_667);
- out_be32(ddr-timing_cfg_1, CONFIG_SYS_DDR_TIMING_1_667);
- out_be32(ddr-timing_cfg_2, CONFIG_SYS_DDR_TIMING_2_667);
- out_be32(ddr-sdram_mode, CONFIG_SYS_DDR_MODE_1_667);
- out_be32(ddr-sdram_mode_2, CONFIG_SYS_DDR_MODE_2_667);
- out_be32(ddr-sdram_interval, CONFIG_SYS_DDR_INTERVAL_667);
- out_be32(ddr-sdram_clk_cntl, CONFIG_SYS_DDR_CLK_CTRL_667);
- out_be32(ddr-ddr_wrlvl_cntl,
- CONFIG_SYS_DDR_WRLVL_CONTROL_667);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_3_667, ddr-timing_cfg_3);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_0_667, ddr-timing_cfg_0);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_1_667, ddr-timing_cfg_1);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_2_667, ddr-timing_cfg_2);
+ __raw_writel(CONFIG_SYS_DDR_MODE_1_667, ddr-sdram_mode);
+ __raw_writel(CONFIG_SYS_DDR_MODE_2_667, ddr-sdram_mode_2);
+ __raw_writel(CONFIG_SYS_DDR_INTERVAL_667, ddr-sdram_interval);
+ __raw_writel(CONFIG_SYS_DDR_CLK_CTRL_667, ddr-sdram_clk_cntl);
+ __raw_writel(CONFIG_SYS_DDR_WRLVL_CONTROL_667,
ddr-ddr_wrlvl_cntl);
} else {
- out_be32(ddr-timing_cfg_3, CONFIG_SYS_DDR_TIMING_3_800);
- out_be32(ddr-timing_cfg_0, CONFIG_SYS_DDR_TIMING_0_800);
- out_be32(ddr-timing_cfg_1, CONFIG_SYS_DDR_TIMING_1_800);
- out_be32(ddr-timing_cfg_2, CONFIG_SYS_DDR_TIMING_2_800);
- out_be32(ddr-sdram_mode, CONFIG_SYS_DDR_MODE_1_800);
- out_be32(ddr-sdram_mode_2, CONFIG_SYS_DDR_MODE_2_800);
- out_be32(ddr-sdram_interval, CONFIG_SYS_DDR_INTERVAL_800);
- out_be32(ddr-sdram_clk_cntl, CONFIG_SYS_DDR_CLK_CTRL_800);
- out_be32(ddr-ddr_wrlvl_cntl,
- CONFIG_SYS_DDR_WRLVL_CONTROL_800);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_3_800, ddr-timing_cfg_3);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_0_800, ddr-timing_cfg_0);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_1_800, ddr-timing_cfg_1);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_2_800, ddr-timing_cfg_2);
+ __raw_writel(CONFIG_SYS_DDR_MODE_1_800, ddr-sdram_mode);
+ __raw_writel(CONFIG_SYS_DDR_MODE_2_800, ddr-sdram_mode_2);
+ __raw_writel(CONFIG_SYS_DDR_INTERVAL_800, ddr-sdram_interval);
+ __raw_writel(CONFIG_SYS_DDR_CLK_CTRL_800, ddr-sdram_clk_cntl);
+ __raw_writel(CONFIG_SYS_DDR_WRLVL_CONTROL_800,
ddr-ddr_wrlvl_cntl);
}
- out_be32(ddr-timing_cfg_4, CONFIG_SYS_DDR_TIMING_4);
- out_be32(ddr-timing_cfg_5, CONFIG_SYS_DDR_TIMING_5);
- out_be32(ddr-ddr_zq_cntl, CONFIG_SYS_DDR_ZQ_CONTROL);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_4, ddr-timing_cfg_4);
+ __raw_writel(CONFIG_SYS_DDR_TIMING_5, ddr-timing_cfg_5);
+ __raw_writel(CONFIG_SYS_DDR_ZQ_CONTROL, ddr-ddr_zq_cntl);
/* P1014 and it's derivatives support max 16bit DDR width */
if (svr == SVR_P1014) {
diff --git
Re: [U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync
On 08/13/2012 01:10 PM, Matthew McClintock wrote: This change reduces the SPL size by removing the redundant syncs produced by out_be32 and just replies on one final sync Done with: sed -r '/in_be32/b; s/(out_be32)\(([^,]*),\s+(.*)\)/__raw_writel(\3, \2)/g' -i `git grep --name-only sdram_init nand_spl/` Signed-off-by: Matthew McClintock m...@freescale.com --- nand_spl/board/freescale/p1010rdb/nand_boot.c | 54 ++--- nand_spl/board/freescale/p1023rds/nand_boot.c | 42 nand_spl/board/freescale/p1_p2_rdb_pc/nand_boot.c | 48 +- 3 files changed, 71 insertions(+), 73 deletions(-) This should come first if the other patches break without it, to preserve bisectability. Note that I'm going to try to convert this stuff (at least one board as an example, but hopefully it should be easy enough to do additional boards once the first is done) to the new spl Really Soon Now(tm), so it doesn't make much sense to fiddle around with the old stuff right now unless I miss the merge window. I'll incorporate these changes into the new-spl version. I may do that by applying these patches first, but I'd rather they not go via the mpc85xx tree (and please CC me on NAND patches). -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync
On Mon, Aug 13, 2012 at 6:23 PM, Scott Wood scottw...@freescale.com wrote: On 08/13/2012 01:10 PM, Matthew McClintock wrote: This change reduces the SPL size by removing the redundant syncs produced by out_be32 and just replies on one final sync Done with: sed -r '/in_be32/b; s/(out_be32)\(([^,]*),\s+(.*)\)/__raw_writel(\3, \2)/g' -i `git grep --name-only sdram_init nand_spl/` Signed-off-by: Matthew McClintock m...@freescale.com --- nand_spl/board/freescale/p1010rdb/nand_boot.c | 54 ++--- nand_spl/board/freescale/p1023rds/nand_boot.c | 42 nand_spl/board/freescale/p1_p2_rdb_pc/nand_boot.c | 48 +- 3 files changed, 71 insertions(+), 73 deletions(-) This should come first if the other patches break without it, to preserve bisectability. I think they all work on at least some compilers not that that's extremely helpful. -M Note that I'm going to try to convert this stuff (at least one board as an example, but hopefully it should be easy enough to do additional boards once the first is done) to the new spl Really Soon Now(tm), so it doesn't make much sense to fiddle around with the old stuff right now unless I miss the merge window. I'll incorporate these changes into the new-spl version. I may do that by applying these patches first, but I'd rather they not go via the mpc85xx tree (and please CC me on NAND patches). -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync
On 08/13/2012 06:31 PM, McClintock Matthew-B29882 wrote: On Mon, Aug 13, 2012 at 6:23 PM, Scott Wood scottw...@freescale.com wrote: On 08/13/2012 01:10 PM, Matthew McClintock wrote: This change reduces the SPL size by removing the redundant syncs produced by out_be32 and just replies on one final sync Done with: sed -r '/in_be32/b; s/(out_be32)\(([^,]*),\s+(.*)\)/__raw_writel(\3, \2)/g' -i `git grep --name-only sdram_init nand_spl/` Signed-off-by: Matthew McClintock m...@freescale.com --- nand_spl/board/freescale/p1010rdb/nand_boot.c | 54 ++--- nand_spl/board/freescale/p1023rds/nand_boot.c | 42 nand_spl/board/freescale/p1_p2_rdb_pc/nand_boot.c | 48 +- 3 files changed, 71 insertions(+), 73 deletions(-) This should come first if the other patches break without it, to preserve bisectability. I think they all work on at least some compilers not that that's extremely helpful. Was this patch meant to free up room for the other patches, or was it just bundled in because it's touching the same code? -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/6] nand_spl: change out_be32 to raw_writel and depend on subsequent sync
On Mon, Aug 13, 2012 at 6:34 PM, Scott Wood scottw...@freescale.com wrote: On 08/13/2012 06:31 PM, McClintock Matthew-B29882 wrote: On Mon, Aug 13, 2012 at 6:23 PM, Scott Wood scottw...@freescale.com wrote: On 08/13/2012 01:10 PM, Matthew McClintock wrote: This change reduces the SPL size by removing the redundant syncs produced by out_be32 and just replies on one final sync Done with: sed -r '/in_be32/b; s/(out_be32)\(([^,]*),\s+(.*)\)/__raw_writel(\3, \2)/g' -i `git grep --name-only sdram_init nand_spl/` Signed-off-by: Matthew McClintock m...@freescale.com --- nand_spl/board/freescale/p1010rdb/nand_boot.c | 54 ++--- nand_spl/board/freescale/p1023rds/nand_boot.c | 42 nand_spl/board/freescale/p1_p2_rdb_pc/nand_boot.c | 48 +- 3 files changed, 71 insertions(+), 73 deletions(-) This should come first if the other patches break without it, to preserve bisectability. I think they all work on at least some compilers not that that's extremely helpful. Was this patch meant to free up room for the other patches, or was it just bundled in because it's touching the same code? I believe I was tasked with fixing builds on our newer toolchains (or was it older toolchains?) since some combinations ran out of space. The exact reasoning escapes me, also why did it last a well... I can reorder them if you would like... -M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
