Re: [U-Boot] [PATCH v2 1/2] 85xx/mpc8536ds: Use is_serdes_configured()to determine of PCIe enabled

2010-04-28 Thread Kumar Gala

On Apr 28, 2010, at 3:25 AM, Li Yang-R58472 wrote:

> 
>>> Subject: [U-Boot] [PATCH v2 1/2] 85xx/mpc8536ds: Use 
>>> is_serdes_configured()to determine of PCIe enabled
>>> 
>>> The new is_serdes_configured covers a broader range of 
>> devices than the 
>>> PCI specific code.  Use it instead as we convert away from the
>>> is_fsl_pci_cfg() code.
>>> 
>>> Additionally move to setting LAWs for PCI based on if its configured.
>>> Also updated PCI FDT fixup code to remove PCI controllers from dtb if 
>>> they are configured.
>>> 
>>> Signed-off-by: Kumar Gala 
>>> ---
>>> * Added code to handle dynamic LAW setup for PCI
>>> * Added removing of PCI controller nodes from dtb if not cfg
>>> 
>>> arch/powerpc/cpu/mpc8xxx/pci_cfg.c|   12 
>>> board/freescale/mpc8536ds/law.c   |8 
>>> board/freescale/mpc8536ds/mpc8536ds.c |   33 
>>> +
>> 
>> Wouldn't it be better to share the PCIE initialization code 
>> through all the MPC85xx boards?  Like in the P2020 serdes 
>> patch series I proposed last year.  What do you think?
> 
> The patch can be referenced at
> http://www.mail-archive.com/u-boot@lists.denx.de/msg26339.html
> 
> - Leo

Yeah, we can get there.  Just one step at a time.

- k
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v2 1/2] 85xx/mpc8536ds: Use is_serdes_configured()to determine of PCIe enabled

2010-04-28 Thread Li Yang-R58472
 
>>Subject: [U-Boot] [PATCH v2 1/2] 85xx/mpc8536ds: Use 
>>is_serdes_configured()to determine of PCIe enabled
>>
>>The new is_serdes_configured covers a broader range of 
>devices than the 
>>PCI specific code.  Use it instead as we convert away from the
>>is_fsl_pci_cfg() code.
>>
>>Additionally move to setting LAWs for PCI based on if its configured.
>>Also updated PCI FDT fixup code to remove PCI controllers from dtb if 
>>they are configured.
>>
>>Signed-off-by: Kumar Gala 
>>---
>>* Added code to handle dynamic LAW setup for PCI
>>* Added removing of PCI controller nodes from dtb if not cfg
>>
>> arch/powerpc/cpu/mpc8xxx/pci_cfg.c|   12 
>> board/freescale/mpc8536ds/law.c   |8 
>> board/freescale/mpc8536ds/mpc8536ds.c |   33 
>>+
>
>Wouldn't it be better to share the PCIE initialization code 
>through all the MPC85xx boards?  Like in the P2020 serdes 
>patch series I proposed last year.  What do you think?

The patch can be referenced at
http://www.mail-archive.com/u-boot@lists.denx.de/msg26339.html

- Leo
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v2 1/2] 85xx/mpc8536ds: Use is_serdes_configured()to determine of PCIe enabled

2010-04-28 Thread Li Yang-R58472
>Subject: [U-Boot] [PATCH v2 1/2] 85xx/mpc8536ds: Use 
>is_serdes_configured()to determine of PCIe enabled
>
>The new is_serdes_configured covers a broader range of devices than the
>PCI specific code.  Use it instead as we convert away from the
>is_fsl_pci_cfg() code.
>
>Additionally move to setting LAWs for PCI based on if its configured.
>Also updated PCI FDT fixup code to remove PCI controllers from dtb if
>they are configured.
>
>Signed-off-by: Kumar Gala 
>---
>* Added code to handle dynamic LAW setup for PCI
>* Added removing of PCI controller nodes from dtb if not cfg
>
> arch/powerpc/cpu/mpc8xxx/pci_cfg.c|   12 
> board/freescale/mpc8536ds/law.c   |8 
> board/freescale/mpc8536ds/mpc8536ds.c |   33 
>+

Wouldn't it be better to share the PCIE initialization code through all
the MPC85xx boards?  Like in the P2020 serdes patch series I proposed
last year.  What do you think?

- Leo
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v2 1/2] 85xx/mpc8536ds: Use is_serdes_configured() to determine of PCIe enabled

2010-04-28 Thread Kumar Gala
The new is_serdes_configured covers a broader range of devices than the
PCI specific code.  Use it instead as we convert away from the
is_fsl_pci_cfg() code.

Additionally move to setting LAWs for PCI based on if its configured.
Also updated PCI FDT fixup code to remove PCI controllers from dtb if
they are configured.

Signed-off-by: Kumar Gala 
---
* Added code to handle dynamic LAW setup for PCI
* Added removing of PCI controller nodes from dtb if not cfg

 arch/powerpc/cpu/mpc8xxx/pci_cfg.c|   12 
 board/freescale/mpc8536ds/law.c   |8 
 board/freescale/mpc8536ds/mpc8536ds.c |   33 +
 3 files changed, 29 insertions(+), 24 deletions(-)

diff --git a/arch/powerpc/cpu/mpc8xxx/pci_cfg.c 
b/arch/powerpc/cpu/mpc8xxx/pci_cfg.c
index 85995ca..186936f 100644
--- a/arch/powerpc/cpu/mpc8xxx/pci_cfg.c
+++ b/arch/powerpc/cpu/mpc8xxx/pci_cfg.c
@@ -56,18 +56,6 @@ static struct pci_info pci_config_info[] =
 #elif defined(CONFIG_MPC8536)
 static struct pci_info pci_config_info[] =
 {
-   [LAW_TRGT_IF_PCI] = {
-   .cfg =   0,
-   },
-   [LAW_TRGT_IF_PCIE_1] = {
-   .cfg =   (1 << 2) | (1 << 3) | (1 << 5) | (1 << 7),
-   },
-   [LAW_TRGT_IF_PCIE_2] = {
-   .cfg =   (1 << 5) | (1 << 7),
-   },
-   [LAW_TRGT_IF_PCIE_3] = {
-   .cfg =   (1 << 7),
-   },
 };
 #elif defined(CONFIG_MPC8544)
 static struct pci_info pci_config_info[] =
diff --git a/board/freescale/mpc8536ds/law.c b/board/freescale/mpc8536ds/law.c
index 1f11563..61b7454 100644
--- a/board/freescale/mpc8536ds/law.c
+++ b/board/freescale/mpc8536ds/law.c
@@ -28,15 +28,7 @@
 #include 
 
 struct law_entry law_table[] = {
-   SET_LAW(CONFIG_SYS_PCI1_MEM_PHYS, LAW_SIZE_256M, LAW_TRGT_IF_PCI),
-   SET_LAW(CONFIG_SYS_PCI1_IO_PHYS, LAW_SIZE_64K, LAW_TRGT_IF_PCI),
SET_LAW(CONFIG_SYS_FLASH_BASE_PHYS, LAW_SIZE_256M, LAW_TRGT_IF_LBC),
-   SET_LAW(CONFIG_SYS_PCIE1_MEM_PHYS, LAW_SIZE_128M, LAW_TRGT_IF_PCIE_1),
-   SET_LAW(CONFIG_SYS_PCIE1_IO_PHYS, LAW_SIZE_64K, LAW_TRGT_IF_PCIE_1),
-   SET_LAW(CONFIG_SYS_PCIE2_MEM_PHYS, LAW_SIZE_128M, LAW_TRGT_IF_PCIE_2),
-   SET_LAW(CONFIG_SYS_PCIE2_IO_PHYS, LAW_SIZE_64K, LAW_TRGT_IF_PCIE_2),
-   SET_LAW(CONFIG_SYS_PCIE3_MEM_PHYS, LAW_SIZE_512M, LAW_TRGT_IF_PCIE_3),
-   SET_LAW(CONFIG_SYS_PCIE3_IO_PHYS, LAW_SIZE_64K, LAW_TRGT_IF_PCIE_3),
SET_LAW(PIXIS_BASE_PHYS, LAW_SIZE_4K, LAW_TRGT_IF_LBC),
SET_LAW(CONFIG_SYS_NAND_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_LBC),
 };
diff --git a/board/freescale/mpc8536ds/mpc8536ds.c 
b/board/freescale/mpc8536ds/mpc8536ds.c
index 253ed18..8daa0c3 100644
--- a/board/freescale/mpc8536ds/mpc8536ds.c
+++ b/board/freescale/mpc8536ds/mpc8536ds.c
@@ -1,5 +1,5 @@
 /*
- * Copyright 2008-2009 Freescale Semiconductor, Inc.
+ * Copyright 2008-2010 Freescale Semiconductor, Inc.
  *
  * See file CREDITS for list of people who contributed to this
  * project.
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -219,9 +220,13 @@ void pci_init_board(void)
 
puts("\n");
 #ifdef CONFIG_PCIE3
-   pcie_configured = is_fsl_pci_cfg(LAW_TRGT_IF_PCIE_3, io_sel);
+   pcie_configured = is_serdes_configured(PCIE3);
 
if (pcie_configured && !(devdisr & MPC85xx_DEVDISR_PCIE3)){
+   set_next_law(CONFIG_SYS_PCIE3_MEM_PHYS, LAW_SIZE_512M,
+   LAW_TRGT_IF_PCIE_3);
+   set_next_law(CONFIG_SYS_PCIE3_IO_PHYS, LAW_SIZE_64K,
+   LAW_TRGT_IF_PCIE_3);
SET_STD_PCIE_INFO(pci_info[num], 3);
pcie_ep = fsl_setup_hose(&pcie3_hose, pci_info[num].regs);
printf ("PCIE3 connected to Slot3 as %s (base address 
%lx)\n",
@@ -239,9 +244,13 @@ void pci_init_board(void)
 #endif
 
 #ifdef CONFIG_PCIE1
-   pcie_configured = is_fsl_pci_cfg(LAW_TRGT_IF_PCIE_1, io_sel);
+   pcie_configured = is_serdes_configured(PCIE1);
 
if (pcie_configured && !(devdisr & MPC85xx_DEVDISR_PCIE)){
+   set_next_law(CONFIG_SYS_PCIE1_MEM_PHYS, LAW_SIZE_128M,
+   LAW_TRGT_IF_PCIE_1);
+   set_next_law(CONFIG_SYS_PCIE1_IO_PHYS, LAW_SIZE_64K,
+   LAW_TRGT_IF_PCIE_1);
SET_STD_PCIE_INFO(pci_info[num], 1);
pcie_ep = fsl_setup_hose(&pcie1_hose, pci_info[num].regs);
printf ("PCIE1 connected to Slot1 as %s (base address 
%lx)\n",
@@ -259,9 +268,13 @@ void pci_init_board(void)
 #endif
 
 #ifdef CONFIG_PCIE2
-   pcie_configured = is_fsl_pci_cfg(LAW_TRGT_IF_PCIE_2, io_sel);
+   pcie_configured = is_serdes_configured(PCIE2);
 
if (pcie_configured && !(devdisr & MPC85xx_DEVDISR_PCIE2)){
+   set_next_law(CONFIG_SYS_PCIE2_MEM_PHYS, LAW_SIZE_128M,
+   LAW_TRGT_IF_PCIE_2);
+   set_next_law(CONFIG_SYS_PCIE2_IO_PHY