Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-05 Thread Matthias Wessendorf
perhaps adding Trinidad to the download page of MyFaces isn't a bad idea.
I'll do that, once 1.2.2 is released, since I have to touch that page
at that time

-Matthias

On 9/5/07, Matthias Wessendorf [EMAIL PROTECTED] wrote:
 Hi,

   Also releases and corresponding downloads seem to be a little mixed
   up currently:
  
   http://myfaces.apache.org/ has latest news about 1.0._1_ and 1.2.1
  
   If you follow the download link from that main page you'll find
   core, tomahawk, tobago, but no trinidad.
  
   If you first select trinidad project then go to downloads you'll
   find only 1.0.2 even though the release notes available on the
   trinidad project page talk about 1.0.3.
  
   The trinidad download page has a link to nightly builds, but I haven't
   found any when following that link.
 
 
  Matthias, can you look at these?

 well, the new,... they are not really synced w/ the state of releases,
 yeah, that sucks, I know.
 I'll update.

 But, there is a download page for Trinidad...

 http://myfaces.apache.org/trinidad/download.html

 that is always! up-to-date. And it mentions the 1.0.2 and 1.2.1 (1.2.2
 will be released soon)

 Greetings,
 Matthias


 
  -- Adam
 
 
   Andrew Robinson wrote:
Fixed in 1.0.3-SNAPSHOT
   
On 9/4/07, Stephen Friedrich [EMAIL PROTECTED] wrote:
After reading the tag doc for panelLabelAndMessage I would have
thought that in the following example the tr:message would not
be needed.
   
However if I omit the tr:message then on validation failure it
fails silently without ever showing a message.
   
(Trinidad 1.2.1)
   
tr:panelLabelAndMessage styleClass=inputLabel_10
  label=#{Output.BRANCH} showRequired=true
 tr:selectOneChoice id=employeeBranchId
  value=#{_employeeList.employeeBranchId} required=true
  unselectedLabel= simple=true
 f:selectItems
  value=#{_employeeList.employeeBranchItems}/
 /tr:selectOneChoice
 tr:message for=employeeBranchId/
/tr:panelLabelAndMessage
   
   
   
  
  
 
 


 --
 Matthias Wessendorf

 further stuff:
 blog: http://matthiaswessendorf.wordpress.com/
 mail: matzew-at-apache-dot-org



-- 
Matthias Wessendorf

further stuff:
blog: http://matthiaswessendorf.wordpress.com/
mail: matzew-at-apache-dot-org


Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-05 Thread Stephen Friedrich
 The simplest way I can think of is to use panelLabelAndMessage
 containing a panelHorizontalLayout with two non-simple fields,
 where you haven't set the label on either (but do set the shortDesc
 attribute for accessibility).
  
 -- Adam

Well, actually that was what I tried first.
However then the required asterisks get added to each field which
looks ugly because it makes them mis-aligned with the other fields
and it also kind of scatters asterisk around (the other are at the
very start of each field's label of course).
I'll file a jira issue.


[Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-04 Thread Stephen Friedrich

After reading the tag doc for panelLabelAndMessage I would have
thought that in the following example the tr:message would not
be needed.

However if I omit the tr:message then on validation failure it
fails silently without ever showing a message.

(Trinidad 1.2.1)

tr:panelLabelAndMessage styleClass=inputLabel_10 label=#{Output.BRANCH} 
showRequired=true
tr:selectOneChoice id=employeeBranchId value=#{_employeeList.employeeBranchId} 
required=true unselectedLabel= simple=true
f:selectItems value=#{_employeeList.employeeBranchItems}/
/tr:selectOneChoice
tr:message for=employeeBranchId/
/tr:panelLabelAndMessage




Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-04 Thread Andrew Robinson
Fixed in 1.0.3-SNAPSHOT

On 9/4/07, Stephen Friedrich [EMAIL PROTECTED] wrote:
 After reading the tag doc for panelLabelAndMessage I would have
 thought that in the following example the tr:message would not
 be needed.

 However if I omit the tr:message then on validation failure it
 fails silently without ever showing a message.

 (Trinidad 1.2.1)

 tr:panelLabelAndMessage styleClass=inputLabel_10 label=#{Output.BRANCH} 
 showRequired=true
  tr:selectOneChoice id=employeeBranchId 
 value=#{_employeeList.employeeBranchId} required=true unselectedLabel= 
 simple=true
  f:selectItems value=#{_employeeList.employeeBranchItems}/
  /tr:selectOneChoice
  tr:message for=employeeBranchId/
 /tr:panelLabelAndMessage





Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-04 Thread Stephen Friedrich

Thanks for the info, Andrew!

Adam, will 1.2.2 contain this fix, too?
Or will you strictly only transfer fixes from 1.0._2_?

Depending on how many changes there were in between 1.0.2 and 1.0.3
maybe it would make sense to skip 1.0.2 and directly go to 1.2.3?

Well, 1.2.3 really makes for a nicer version number anyhow ;-

Also releases and corresponding downloads seem to be a little mixed
up currently:

http://myfaces.apache.org/ has latest news about 1.0._1_ and 1.2.1

If you follow the download link from that main page you'll find
core, tomahawk, tobago, but no trinidad.

If you first select trinidad project then go to downloads you'll
find only 1.0.2 even though the release notes available on the
trinidad project page talk about 1.0.3.

The trinidad download page has a link to nightly builds, but I haven't
found any when following that link.



Andrew Robinson wrote:

Fixed in 1.0.3-SNAPSHOT

On 9/4/07, Stephen Friedrich [EMAIL PROTECTED] wrote:

After reading the tag doc for panelLabelAndMessage I would have
thought that in the following example the tr:message would not
be needed.

However if I omit the tr:message then on validation failure it
fails silently without ever showing a message.

(Trinidad 1.2.1)

tr:panelLabelAndMessage styleClass=inputLabel_10 label=#{Output.BRANCH} 
showRequired=true
 tr:selectOneChoice id=employeeBranchId value=#{_employeeList.employeeBranchId} 
required=true unselectedLabel= simple=true
 f:selectItems value=#{_employeeList.employeeBranchItems}/
 /tr:selectOneChoice
 tr:message for=employeeBranchId/
/tr:panelLabelAndMessage







Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-04 Thread Stephen Friedrich

While we're at it - a few more questions regarding panelLabelAndMessage:
If there are multiple child components will messages for all of them be shown?
If so, in a single place/message component or individually where the messages
would be if the components were not simple?
Does it work if child components are nested in a panelHorizontalLayout?

Andrew Robinson wrote:

Fixed in 1.0.3-SNAPSHOT


Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-04 Thread Andrew Robinson
On 9/4/07, Stephen Friedrich [EMAIL PROTECTED] wrote:
 While we're at it - a few more questions regarding panelLabelAndMessage:
 If there are multiple child components will messages for all of them be shown?

No, it requires a for attribute. That is the component that the
label and the message are for. Also in 1.0.3 the code will
automatically use the first EditableValueHolder it finds if the for is
not given, but it still only supports one component. To get multiple
components, you have to have multiple panelLabelAndMessage components.

 Does it work if child components are nested in a panelHorizontalLayout?

Yes.


Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-04 Thread Stephen Friedrich

Andrew Robinson wrote:

No, it requires a for attribute. That is the component that the
label and the message are for. Also in 1.0.3 the code will
automatically use the first EditableValueHolder it finds if the for is
not given, but it still only supports one component. To get multiple
components, you have to have multiple panelLabelAndMessage components.

Hm, that kind of defeats the purpose of panelLabelAndMessage:
I nested firstName and lastName fields in a single panelLabelAndMessage
to have them shown in a single row of a form managed by panelFormLayout.
Of course I'd like to show messages for both of them.
How can I do that?
Can I switch the automatic message part OFF and then add two tr:message
tag (one for each input field)? Then again that would require some
additional layout to get the messages to appear under the correct field.

It really would be easiest to be able to have a semi-simple where the
component does not manage its label, but manages its own message.
simple=message-only ?

BTW: The same structure repeats in my app with other pairs with other
pairs (zip/city, start/end date, street/no, ...).



Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-04 Thread Andrew Robinson
Why don't you submit a wish jira for the functionality, sounds like
something that makes sense to develop.

On 9/4/07, Stephen Friedrich [EMAIL PROTECTED] wrote:
 Andrew Robinson wrote:
  No, it requires a for attribute. That is the component that the
  label and the message are for. Also in 1.0.3 the code will
  automatically use the first EditableValueHolder it finds if the for is
  not given, but it still only supports one component. To get multiple
  components, you have to have multiple panelLabelAndMessage components.
 Hm, that kind of defeats the purpose of panelLabelAndMessage:
 I nested firstName and lastName fields in a single panelLabelAndMessage
 to have them shown in a single row of a form managed by panelFormLayout.
 Of course I'd like to show messages for both of them.
 How can I do that?
 Can I switch the automatic message part OFF and then add two tr:message
 tag (one for each input field)? Then again that would require some
 additional layout to get the messages to appear under the correct field.

 It really would be easiest to be able to have a semi-simple where the
 component does not manage its label, but manages its own message.
 simple=message-only ?

 BTW: The same structure repeats in my app with other pairs with other
 pairs (zip/city, start/end date, street/no, ...).




Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-04 Thread Adam Winer
On 9/4/07, Stephen Friedrich [EMAIL PROTECTED] wrote:

 Thanks for the info, Andrew!

 Adam, will 1.2.2 contain this fix, too?
 Or will you strictly only transfer fixes from 1.0._2_?



1.2.2 is exactly 1.0.2 + 1.2 changes.

Depending on how many changes there were in between 1.0.2 and 1.0.3
 maybe it would make sense to skip 1.0.2 and directly go to 1.2.3?

 Well, 1.2.3 really makes for a nicer version number anyhow ;-

 Also releases and corresponding downloads seem to be a little mixed
 up currently:

 http://myfaces.apache.org/ has latest news about 1.0._1_ and 1.2.1

 If you follow the download link from that main page you'll find
 core, tomahawk, tobago, but no trinidad.

 If you first select trinidad project then go to downloads you'll
 find only 1.0.2 even though the release notes available on the
 trinidad project page talk about 1.0.3.

 The trinidad download page has a link to nightly builds, but I haven't
 found any when following that link.



Matthias, can you look at these?

-- Adam


Andrew Robinson wrote:
  Fixed in 1.0.3-SNAPSHOT
 
  On 9/4/07, Stephen Friedrich [EMAIL PROTECTED] wrote:
  After reading the tag doc for panelLabelAndMessage I would have
  thought that in the following example the tr:message would not
  be needed.
 
  However if I omit the tr:message then on validation failure it
  fails silently without ever showing a message.
 
  (Trinidad 1.2.1)
 
  tr:panelLabelAndMessage styleClass=inputLabel_10 label=#{
 Output.BRANCH} showRequired=true
   tr:selectOneChoice id=employeeBranchId
 value=#{_employeeList.employeeBranchId} required=true unselectedLabel=
 simple=true
   f:selectItems
 value=#{_employeeList.employeeBranchItems}/
   /tr:selectOneChoice
   tr:message for=employeeBranchId/
  /tr:panelLabelAndMessage
 
 
 




Re: [Trinidad] panelLabelAndMessage still needs extra message tag?!

2007-09-04 Thread Adam Winer
On 9/4/07, Stephen Friedrich [EMAIL PROTECTED] wrote:

 Andrew Robinson wrote:
  No, it requires a for attribute. That is the component that the
  label and the message are for. Also in 1.0.3 the code will
  automatically use the first EditableValueHolder it finds if the for is
  not given, but it still only supports one component. To get multiple
  components, you have to have multiple panelLabelAndMessage components.
 Hm, that kind of defeats the purpose of panelLabelAndMessage:
 I nested firstName and lastName fields in a single panelLabelAndMessage
 to have them shown in a single row of a form managed by panelFormLayout.
 Of course I'd like to show messages for both of them.
 How can I do that?


The simplest way I can think of is to use panelLabelAndMessage
containing a panelHorizontalLayout with two non-simple fields,
where you haven't set the label on either (but do set the shortDesc
attribute for accessibility).

-- Adam


Can I switch the automatic message part OFF and then add two tr:message
 tag (one for each input field)? Then again that would require some
 additional layout to get the messages to appear under the correct field.

 It really would be easiest to be able to have a semi-simple where the
 component does not manage its label, but manages its own message.
 simple=message-only ?

 BTW: The same structure repeats in my app with other pairs with other
 pairs (zip/city, start/end date, street/no, ...).