Change in vdsm[master]: build: use pythondir for yajsonrpc
Eyal Edri has posted comments on this change. Change subject: build: use pythondir for yajsonrpc .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c98abc9f52f948d4807d4ee6eda6efba6c42bcd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Kiril Nesenko Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Deleted ovirt check from vdsm-restore-net-config
Dan Kenigsberg has posted comments on this change. Change subject: Deleted ovirt check from vdsm-restore-net-config .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae86110fbbdeca7b27e3528fdfaaa1a7dfb88e26 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: Skip source routing cfg files when restoring device...
Antoni Segura Puimedon has posted comments on this change. Change subject: netconf: Skip source routing cfg files when restoring devices .. Patch Set 1: Looks good to me, but someone else must approve Thanks Mark! -- To view, visit http://gerrit.ovirt.org/17213 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f72bd29f5f9d4f5d02d8cd2e19675d00eac4600 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Do not fail releasing a VM due to agent stopping error...
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Do not fail releasing a VM due to agent stopping errors
..
Patch Set 3: (2 inline comments)
File vdsm/guestIF.py
Line 241: # socket was already closed
Line 242: pass
Line 243: else:
Line 244: raise
Line 245: except AttributeError:
Done
Line 246: # This is not supposed to happen, but might if we fail to
connect
Line 247: # to the VirtIO channel because it does not exist.
Line 248: self.log.exception("Failure on unregistering guest VirtIO
channel")
Line 249: else:
File vdsm/vm.py
Line 4209: if self.guestAgent:
Line 4210: try:
Line 4211: self.guestAgent.stop()
Line 4212: except Exception:
Line 4213: # This is on purpose that generic because
there's no
Isn't it funny that this is the only place where there was no try catch block
around this?
The other places calling self.guestAgent.stop() surrounded by a try-except
Anyway, I have removed it.
Line 4214: # reason for letting the destroy now fail.
Line 4215: # We'll just logging it
Line 4216: self.log.exception("Failure occurred during
stopping "
Line 4217:"of the guest agent
communication "
--
To view, visit http://gerrit.ovirt.org/17072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ac23b11294dc90e4980944d7ba6fad6abc22dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Peter V. Saveliev
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Do not fail releasing a VM due to agent stopping error...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Do not fail releasing a VM due to agent stopping errors .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2644/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3451/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3535/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10ac23b11294dc90e4980944d7ba6fad6abc22dc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netconf: make ifcfg's rollback cover new added networks
Antoni Segura Puimedon has posted comments on this change.
Change subject: netconf: make ifcfg's rollback cover new added networks
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
There's a use case that we have to cover (commented it inline).
File vdsm/netconf/ifcfg.py
Line 343: for dev in reversed(changed):
Line 344: ifdown(dev)
Line 345:
Line 346: def _startAtomicDevices(self):
Line 347: for dev in self._sortModifiedIfcfgs()[0]:
We are supposed to leave the nics and bonds up after removing the
configuration. Thus, an iteration and check like that of liknes 338-339 would
be needed.
Line 348: try:
Line 349: ifup(dev)
Line 350: except ConfigNetworkError:
Line 351: logging.error('Failed to ifup device %s during
rollback.', dev,
--
To view, visit http://gerrit.ovirt.org/17214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabcfb10119d303f81f505a6065e3139eddb3b049
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: remove the option implicitBonding
Antoni Segura Puimedon has posted comments on this change.
Change subject: configNetwork: remove the option implicitBonding
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I still have to review that it doesn't break anything, but I found this small
typo.
File vdsm/configNetwork.py
Line 389: bond = Bond.objectivize(bondName, configurator,
Line 390: bondAttrs.get('options'),
Line 391: bondAttrs.get('nics'), mtu=None,
Line 392: _netinfo=_netinfo,
Line 393: destoryOnRemoval='remove' in
bondAttrs)
This is a typo. It should read destroyOnRemoval.
Line 394: if 'remove' in bondAttrs:
Line 395: logger.debug("Removing bond %s with attributes %s",
bondName,
Line 396: bondAttrs)
Line 397: configurator.removeBond(bond)
--
To view, visit http://gerrit.ovirt.org/17215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb6429a67d522e4a813494c45e90187d39fcdcd1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/3] - Respond to setSafeNetwor...
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [2/3] - Respond to setSafeNetworkConfig .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve logging for misformed ip routes and rules
Assaf Muller has uploaded a new change for review.
Change subject: Improve logging for misformed ip routes and rules
..
Improve logging for misformed ip routes and rules
Change-Id: Ie68187851964431ecb08dd791be0318b7767a554
Signed-off-by: Assaf Muller
---
M lib/vdsm/ipwrapper.py
1 file changed, 15 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/17239/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index 77659d7..57c8da9 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -39,10 +39,10 @@
class Route(object):
def __init__(self, network, ipaddr=None, device=None, table=None):
if not _isValid(network, IPNetwork):
-raise ValueError('network is not properly defined')
+raise ValueError('network %s is not properly defined' % network)
if ipaddr and not _isValid(ipaddr, IPAddress):
-raise ValueError('ipaddr is not properly defined')
+raise ValueError('ipaddr %s is not properly defined' % ipaddr)
self.network = network
self.ipaddr = ipaddr
@@ -62,7 +62,8 @@
"""
if len(route) % 2 == 0:
raise ValueError('The length of the textual representation of a '
- 'route must be odd')
+ 'route must be odd. Route %s failed parsing' %
+ route)
network, params = route[0], route[1:]
data = dict(params[i:i + 2] for i in range(0, len(params), 2))
@@ -85,11 +86,11 @@
try:
ipaddr = data['via']
except KeyError:
-raise ValueError('Routes require an IP address.')
+raise ValueError('Route %s: Routes require an IP address.' % data)
try:
device = data['dev']
except KeyError:
-raise ValueError('Routes require a device.')
+raise ValueError('Route %s: Routes require a device.' % data)
table = data.get('table')
return cls(data['network'], ipaddr=ipaddr, device=device, table=table)
@@ -113,13 +114,14 @@
if not (_isValid(source, IPAddress) or
_isValid(source, IPNetwork)):
raise ValueError('Invalid source: Not an ip address '
- 'or network')
+ 'or network. Source received: %s' % source)
if destination:
if not (_isValid(destination, IPAddress) or
_isValid(destination, IPNetwork)):
raise ValueError('Invalid destination: Not an ip address '
- 'or network')
+ 'or network. Destination received: %s' %
+ destination)
self.table = table
self.source = source
@@ -145,17 +147,20 @@
if len(rule) % 2 == 0:
raise ValueError('The length of a textual representation of a '
- 'rule must be odd')
+ 'rule must be odd.' +
+ ' Rule that failed parsing: %s' % rule)
data = dict(parameters[i:i + 2] for i in range(0, len(parameters), 2))
try:
table = data['lookup']
except KeyError:
-raise ValueError('Rules require "lookup" information.')
+raise ValueError('Rules require "lookup" information.' +
+ ' Rule that failed parsing: %s' % rule)
try:
source = data['from']
except KeyError:
-raise ValueError('Rules require "from" information.')
+raise ValueError('Rules require "from" information.' +
+ ' Rule that failed parsing: %s' % rule)
destination = data.get('to')
if source == 'all':
--
To view, visit http://gerrit.ovirt.org/17239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie68187851964431ecb08dd791be0318b7767a554
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve logging for misformed ip routes and rules
Assaf Muller has posted comments on this change. Change subject: Improve logging for misformed ip routes and rules .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie68187851964431ecb08dd791be0318b7767a554 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve logging for misformed ip routes and rules
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve logging for misformed ip routes and rules .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2645/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3452/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3536/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie68187851964431ecb08dd791be0318b7767a554 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use strings when reporting VM's memory stats
Martin Sivák has posted comments on this change. Change subject: Use strings when reporting VM's memory stats .. Patch Set 8: Verified Verified both with MoM and with engine from yesterday. -- To view, visit http://gerrit.ovirt.org/17086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60b52fface17e5023c666ebed24dd5fc6b204dbc Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix log level for failures in execCmd
Ayal Baron has posted comments on this change. Change subject: Fix log level for failures in execCmd .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5c3ac5bde06ed9083bc9c1662d3b4eddc85034 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use strings when reporting VM's memory stats
Martin Sivák has posted comments on this change. Change subject: Use strings when reporting VM's memory stats .. Patch Set 9: Verified Verified with updated MoM and yesterdays engine. -- To view, visit http://gerrit.ovirt.org/17086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60b52fface17e5023c666ebed24dd5fc6b204dbc Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Reassign mount specification in case of backup option
oVirt Jenkins CI Server has posted comments on this change. Change subject: mount: Reassign mount specification in case of backup option .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2646/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3453/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3537/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3166c6863dffa297bc0adcdeb4c22f810d18de8e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] vdsm: API extension to improve the communication with ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] vdsm: API extension to improve the communication with the Engine .. Patch Set 5: Fails; I would prefer that you didn't submit this Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2647/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3454/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3538/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa0a7a86a351a8c2d891f22802a95d1fe1bc1df4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Frank Kobzik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] bugfix: regression network qos
Giuseppe Vallarelli has uploaded a new change for review.
Change subject: [WIP] bugfix: regression network qos
..
[WIP] bugfix: regression network qos
Inbound and Outbound parameters are no longer dispatched
through the configurator when adding a network, this means
that configured network will not present the desired
QoS. See http://gerrit.ovirt.org/#/c/15724/17/vdsm/configNetwork.py
* Patchset 1 - Improving a previously defined functional test
and verified that the current implementation make
the updated test fail.
Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161
Signed-off-by: Giuseppe Vallarelli
---
M tests/functional/networkTests.py
M tests/functional/utils.py
2 files changed, 40 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/17241/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index ab79aa3..fc2b440 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -229,12 +229,16 @@
@ValidateRunningAsRoot
def testQosNetwork(self):
with dummyIf(1) as nics:
-qos = {'qosInbound': {'average': '1024', 'burst': '2048'},
+qos = {'qosInbound': {'average': '1024', 'burst': '2048',
+ 'peak': '42'},
'qosOutbound': {'average': '2400', 'burst': '2048',
'peak': '100'}}
status, msg = self.vdsm_net.addNetwork(NETWORK_NAME,
nics=nics,
opts=qos)
-
self.assertEqual(status, SUCCESS, msg)
+
+networkQos = self.vdsm_net.networkQos(NETWORK_NAME)
+self.assertEqual(qos['qosInbound'], networkQos.inbound)
+self.assertEqual(qos['qosOutbound'], networkQos.outbound)
diff --git a/tests/functional/utils.py b/tests/functional/utils.py
index f4a3d68..d6dceb9 100644
--- a/tests/functional/utils.py
+++ b/tests/functional/utils.py
@@ -16,20 +16,24 @@
#
# Refer to the README and COPYING files for full details of the license
#
+from collections import namedtuple
from contextlib import contextmanager
from functools import wraps
import random
import time
import threading
+from xml.dom import minidom
from nose.plugins.skip import SkipTest
+from vdsm import libvirtconnection
from vdsm import netinfo
from vdsm import vdscli
from vdsm import utils
SUCCESS = 0
+Qos = namedtuple('Qos', 'inbound outbound')
ip = utils.CommandPath('ip',
@@ -202,3 +206,33 @@
raise
finally:
done = True
+
+def networkQos(self, network):
+cn = libvirtconnection.get()
+networkXml = cn.networkLookupByName(netinfo.LIBVIRT_NET_PREFIX
++ network).XMLDesc(0)
+
+def createQosDict(elem):
+qos_dict = {'average': elem.getAttribute('average'),
+'burst': elem.getAttribute('burst'),
+'peak': elem.getAttribute('peak')}
+return qos_dict
+
+qos = Qos(None, None)
+
+doc = minidom.parseString(networkXml)
+bandwidthElem = doc.getElementsByTagName('bandwidth')
+if bandwidthElem:
+inboundElem = bandwidthElem[0].getElementsByTagName('inbound')
+outboundElem = bandwidthElem[0].getElementsByTagName('outbound')
+if inboundElem:
+inbound = createQosDict(inboundElem[0])
+else:
+inbound = None
+if outboundElem:
+outbound = createQosDict(outboundElem[0])
+else:
+outbound = None
+qos = Qos(inbound, outbound)
+
+return qos
--
To view, visit http://gerrit.ovirt.org/17241
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use strings when reporting VM's memory stats
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use strings when reporting VM's memory stats .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2648/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3455/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3539/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60b52fface17e5023c666ebed24dd5fc6b204dbc Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] bugfix: regression network qos
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] bugfix: regression network qos .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2649/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3456/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3540/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve logging for misformed ip routes and rules
oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve logging for misformed ip routes and rules .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2650/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3457/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3541/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie68187851964431ecb08dd791be0318b7767a554 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] bugfix: regression network qos
Dan Kenigsberg has posted comments on this change. Change subject: [WIP] bugfix: regression network qos .. Patch Set 1: When was the regression introduced? Am I to blame? -- To view, visit http://gerrit.ovirt.org/17241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve logging for misformed ip routes and rules
Dan Kenigsberg has posted comments on this change.
Change subject: Improve logging for misformed ip routes and rules
..
Patch Set 2: (1 inline comment)
File lib/vdsm/ipwrapper.py
Line 60: The network / first column is required, followed by key+value
pairs.
Line 61: Thus, the length of a route must be odd.
Line 62: """
Line 63: if len(route) % 2 == 0:
Line 64: raise ValueError('Route: %s. The length of the textual '
Minor typo: colon should sit to the right of %s.
Line 65: 'representation of a route must be odd.'
% route)
Line 66:
Line 67: network, params = route[0], route[1:]
Line 68: data = dict(params[i:i + 2] for i in range(0, len(params), 2))
--
To view, visit http://gerrit.ovirt.org/17239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie68187851964431ecb08dd791be0318b7767a554
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: do not distribute precompiled cpopen.so
Eyal Edri has posted comments on this change. Change subject: build: do not distribute precompiled cpopen.so .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45058a8d2c9c1824f812d16772ad98cfbcc92692 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Kiril Nesenko Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: use pythondir for yajsonrpc
Eyal Edri has posted comments on this change. Change subject: build: use pythondir for yajsonrpc .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c98abc9f52f948d4807d4ee6eda6efba6c42bcd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Kiril Nesenko Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: use pythondir for yajsonrpc
Dan Kenigsberg has submitted this change and it was merged. Change subject: build: use pythondir for yajsonrpc .. build: use pythondir for yajsonrpc Change-Id: I7c98abc9f52f948d4807d4ee6eda6efba6c42bcd Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/17131 Reviewed-by: Dan Kenigsberg Reviewed-by: Eyal Edri Tested-by: Eyal Edri --- M configure.ac M lib/yajsonrpc/Makefile.am M vdsm.spec.in 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c98abc9f52f948d4807d4ee6eda6efba6c42bcd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Kiril Nesenko Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: do not distribute precompiled cpopen.so
Dan Kenigsberg has posted comments on this change. Change subject: build: do not distribute precompiled cpopen.so .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45058a8d2c9c1824f812d16772ad98cfbcc92692 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Kiril Nesenko Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: do not distribute precompiled cpopen.so
Dan Kenigsberg has submitted this change and it was merged. Change subject: build: do not distribute precompiled cpopen.so .. build: do not distribute precompiled cpopen.so Change-Id: I45058a8d2c9c1824f812d16772ad98cfbcc92692 Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/17189 Tested-by: Eyal Edri Reviewed-by: Dan Kenigsberg --- M lib/cpopen/Makefile.am 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Eyal Edri: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45058a8d2c9c1824f812d16772ad98cfbcc92692 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Kiril Nesenko Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: do not distribute precompiled cpopen.so
Dan Kenigsberg has posted comments on this change. Change subject: build: do not distribute precompiled cpopen.so .. Patch Set 1: I cannot say that I understand this auto make witchcraft, following Federico's lead. -- To view, visit http://gerrit.ovirt.org/17189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45058a8d2c9c1824f812d16772ad98cfbcc92692 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Kiril Nesenko Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] bugfix: regression network qos
Giuseppe Vallarelli has posted comments on this change. Change subject: [WIP] bugfix: regression network qos .. Patch Set 1: I'm still understanding why it's happening, I need to verify a thing first. No one is to blame... -- To view, visit http://gerrit.ovirt.org/17241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve logging for misformed ip routes and rules
Dan Kenigsberg has submitted this change and it was merged. Change subject: Improve logging for misformed ip routes and rules .. Improve logging for misformed ip routes and rules Change-Id: Ie68187851964431ecb08dd791be0318b7767a554 Signed-off-by: Assaf Muller Signed-off-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/17239 --- M lib/vdsm/ipwrapper.py 1 file changed, 16 insertions(+), 14 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie68187851964431ecb08dd791be0318b7767a554 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve logging for misformed ip routes and rules
Dan Kenigsberg has posted comments on this change. Change subject: Improve logging for misformed ip routes and rules .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie68187851964431ecb08dd791be0318b7767a554 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] bugfix: regression network qos
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] bugfix: regression network qos .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2652/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3459/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3543/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: Rearrange PYTHONPATH for remoteFileHandler
oVirt Jenkins CI Server has posted comments on this change. Change subject: infra: Rearrange PYTHONPATH for remoteFileHandler .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2653/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3460/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3544/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4eed6fb94686d4e77a23e0d3b6505bb4bd439cd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: java_bindings: Java client
oVirt Jenkins CI Server has posted comments on this change. Change subject: java_bindings: Java client .. Patch Set 16: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2654/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3461/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3545/ : FAILURE -- To view, visit http://gerrit.ovirt.org/13747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1af69cee1aced5c28e48c0c07a1d155be2889036 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: infra: Add logging in case PoolHandler crashes
oVirt Jenkins CI Server has posted comments on this change. Change subject: infra: Add logging in case PoolHandler crashes .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2655/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3462/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3546/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie46a608a6855019d4c36eb2b31c9a941f8c8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Fix schema error
oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: Fix schema error .. Patch Set 7: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2656/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3463/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3547/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife79569b1f73443ce6119882b765ed77b5dfed7b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use shared lock for setStorageDomainDescription command
Ayal Baron has posted comments on this change. Change subject: Use shared lock for setStorageDomainDescription command .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca7b7b6642c222d88a6cd2a94d4033c0c3ef70b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: java_bindings: Minor imporovements
oVirt Jenkins CI Server has posted comments on this change. Change subject: java_bindings: Minor imporovements .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2657/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3464/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3548/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ceb7f58122accf6c911120b99b87d38b656e8e4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use shared lock for setStorageDomainDescription command
Sergey Gotliv has posted comments on this change. Change subject: Use shared lock for setStorageDomainDescription command .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/17198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca7b7b6642c222d88a6cd2a94d4033c0c3ef70b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: regression network qos
Giuseppe Vallarelli has posted comments on this change.
Change subject: bugfix: regression network qos
..
Patch Set 3: Verified
Verifying this patch implies:
create a new network by providing QoS parameters:
For example: from vdsm import vdscli connection = vdscli.connect()
connection.addNetwork('toni', '', '', ['p1p4'], {'qosInbound':{'average':
'1024', 'burst': '2048'}, 'qosOutbound':{'average': '2400'}})
then:
virsh -r net-dumpxml vdsm-toni
should display something like:
vdsm-toni
515e2c51-226a-4db9-4957-fe9a75e49fd7
--
To view, visit http://gerrit.ovirt.org/17241
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: java_bindings: Add function overloads
oVirt Jenkins CI Server has posted comments on this change. Change subject: java_bindings: Add function overloads .. Patch Set 7: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2658/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3465/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3549/ : FAILURE -- To view, visit http://gerrit.ovirt.org/14823 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40887a5fd2e3901efdcc9633c5858ae6b2445291 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Make proton reactor client capable as well
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Make proton reactor client capable as well .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2659/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3466/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3550/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/12303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14bc36adf2bd7536227138398761818a77174231 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Introduce the definitive JsonRpcClient
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Introduce the definitive JsonRpcClient .. Patch Set 12: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2660/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3467/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3551/ : FAILURE -- To view, visit http://gerrit.ovirt.org/12304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie514c9029416a5869802f065b49f2da033ff3da6 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: use pythondir for vdsmapi
Federico Simoncelli has uploaded a new change for review.
Change subject: build: use pythondir for vdsmapi
..
build: use pythondir for vdsmapi
Change-Id: I8077efea03adb7d018c35cfd81b121b9e47d3e98
Signed-off-by: Federico Simoncelli
---
M vdsm.spec.in
M vdsm_api/Makefile.am
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/17249/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 9b02677..608735a 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1208,7 +1208,7 @@
%files api
%doc vdsm_api/vdsm-api.html
%{_datadir}/%{vdsm_name}/vdsmapi-schema.json
-%{python_sitearch}/vdsmapi.py*
+%{python_sitelib}/vdsmapi.py*
%files jsonrpc
%{_datadir}/%{vdsm_name}/BindingJsonRpc.py*
diff --git a/vdsm_api/Makefile.am b/vdsm_api/Makefile.am
index 0a9e610..8331dea 100644
--- a/vdsm_api/Makefile.am
+++ b/vdsm_api/Makefile.am
@@ -16,7 +16,7 @@
vdsmapi-schema.json \
$(NULL)
-dist_pyexec_PYTHON = \
+dist_python_PYTHON = \
vdsmapi.py \
$(NULL)
--
To view, visit http://gerrit.ovirt.org/17249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8077efea03adb7d018c35cfd81b121b9e47d3e98
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: use pythondir for vdsmapi
Federico Simoncelli has posted comments on this change. Change subject: build: use pythondir for vdsmapi .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8077efea03adb7d018c35cfd81b121b9e47d3e98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: regression network qos
Dan Kenigsberg has posted comments on this change. Change subject: bugfix: regression network qos .. Patch Set 3: Looks good to me, approved Seems like the outcome of a bad rebase of http://gerrit.ovirt.org/16692 This regression should better be fixed for ovirt-3.3 -- To view, visit http://gerrit.ovirt.org/17241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: regression network qos
Dan Kenigsberg has submitted this change and it was merged. Change subject: bugfix: regression network qos .. bugfix: regression network qos Inbound and Outbound parameters are no longer dispatched through the configurator when adding a network, this means that configured network will not present the desired QoS. See previously merged implementation http://gerrit.ovirt.org/#/c/15724/17/vdsm/configNetwork.py * Patchset 1 - Improving a previously defined functional test and verified that the current implementation make the updated test fail. * Patchset 2 - Adding missing qos parameters to configureLibvirtNetwork verified the code behaviour. Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161 Signed-off-by: Giuseppe Vallarelli Reviewed-on: http://gerrit.ovirt.org/17241 Reviewed-by: Dan Kenigsberg --- M tests/functional/networkTests.py M tests/functional/utils.py M vdsm/configNetwork.py 3 files changed, 43 insertions(+), 3 deletions(-) Approvals: Giuseppe Vallarelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I306db7f04dd302f857dc263f3c536659aef5a161 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Antoni Segura Puimedon has uploaded a new change for review. Change subject: fix setupNets 'remove' of non-existent net .. fix setupNets 'remove' of non-existent net setupNetworks was assuming that if a net was not in vdsm nets nor in libvirt nets it was a net that we were trying to add when, in fact, it could very well be a non-existent network that was incorrectly marked for removal. The fix checks the case specified above and raises the same configNetworkError that delNetwork does on similar circumstances. Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Bug-url: https://bugzilla.redhat.com/977843 Signed-off-by: Antoni S. Puimedon --- M vdsm/configNetwork.py 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/17254/1 diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py index c0d31f2..f0c9f2c 100755 --- a/vdsm/configNetwork.py +++ b/vdsm/configNetwork.py @@ -506,6 +506,10 @@ if 'remove' in networkAttrs: del networks[network] del libvirt_nets[network] +elif 'remove' in networkAttrs: +raise ConfigNetworkError(ne.ERR_BAD_BRIDGE, "Cannot delete " + "network %r: It doesn't exist in the " + "system" % network) else: networksAdded.add(network) -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Assaf Muller has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: I would prefer that you didn't submit this ERR_BAD_BRIDGE is very confusing. Maybe the network in question is not even bridged? I suggest we create a new error code. -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Change base class invoke semantics
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Change base class invoke semantics .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2661/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3469/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3553/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665386edf26d73262847be4164bea0c0080451a2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Fix race in AsynChat
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Fix race in AsynChat .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2662/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3468/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3552/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfb18afa8ce7aa6e7636928922cf7c749ef67ae9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: java_bindings: SSL support
oVirt Jenkins CI Server has posted comments on this change. Change subject: java_bindings: SSL support .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2663/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3470/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3554/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c547af2f2c846781141e9e5e10c850a92071ea4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: java_biniding: Simplify bindings by using object mappers
oVirt Jenkins CI Server has posted comments on this change. Change subject: java_biniding: Simplify bindings by using object mappers .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2664/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3471/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3555/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida303667cbba365bf14cc10147bbf507e3b730d6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Add SSL support to asyncore transport
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Add SSL support to asyncore transport .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3472/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3556/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad305e26d7d62fd967c71e5ac4dbd8157639a36d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Dan Kenigsberg has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: Looks good to me, but someone else must approve I am not sure that we need another error code: we already use the current code for both meanings, and I do not think that Engine cares about the bridge/network granularity. Note that this patch fixes a regression. We surely need to rename the ERR_BAD_BRIDGE name, in another patch. -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use shared lock for setStorageDomainDescription command
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use shared lock for setStorageDomainDescription command .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2666/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3473/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3557/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca7b7b6642c222d88a6cd2a94d4033c0c3ef70b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: use pythondir for vdsmapi
Dan Kenigsberg has submitted this change and it was merged. Change subject: build: use pythondir for vdsmapi .. build: use pythondir for vdsmapi Change-Id: I8077efea03adb7d018c35cfd81b121b9e47d3e98 Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/17249 Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in M vdsm_api/Makefile.am 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Federico Simoncelli: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8077efea03adb7d018c35cfd81b121b9e47d3e98 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: use pythondir for vdsmapi
Dan Kenigsberg has posted comments on this change. Change subject: build: use pythondir for vdsmapi .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8077efea03adb7d018c35cfd81b121b9e47d3e98 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2669/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3476/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3560/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] vdsm: API extension to improve the communication with ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] vdsm: API extension to improve the communication with the Engine .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2667/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3474/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3558/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa0a7a86a351a8c2d891f22802a95d1fe1bc1df4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Frank Kobzik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Assaf Muller has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: What do we lose from creating a new error code? Clearly this has nothing to do with bad bridges. This is a new type of error and should be reported as such. Additionally BAD_BRIDGE is very weird from a readability standpoint. -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal' .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2671/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3478/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3562/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: fix that vdsmd.service is not enabled after installati...
Antoni Segura Puimedon has posted comments on this change. Change subject: spec: fix that vdsmd.service is not enabled after installation .. Patch Set 2: Looks good to me, but someone else must approve @Zhou: http://www.freedesktop.org/software/systemd/man/systemd.preset.html states that presets should not be provided by the package providing the units, but rather as part of policy packages that normally are part of distro spins. Thus, for now, I think the current patch approach is a good solution. -- To view, visit http://gerrit.ovirt.org/16754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ba726296d510c1281bc9425e9f420b911ec45f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
oVirt Jenkins CI Server has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2672/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3479/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3563/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Antoni Segura Puimedon has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: @Assaf, it is not a new type of error, it is exactly the same error raised by delNetworks. If you look at it, you'll see that I copied it verbatim. -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Assaf Muller has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: Yeah, I see that it's used in the same way in delNetwork. That doesn't mean that ERR_BAD_BRIDGE is in any way related to this type of error. I also see that it is used in netmodels:Bridge:validateName, where it makes more sense. We should create a new error code and use it during delNetwork and setupNetworks. -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Antoni Segura Puimedon has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: That would effectively be an API change. One that I agree with, but not one that is a bugfix that has to be backported to the ovirt-3.3 branch. As Dan said, I'd get this in, backport it to ovirt-3.3, and for 3.4 make the API altering patch that splits this error into two codes. -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2673/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3564/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
Giuseppe Vallarelli has posted comments on this change.
Change subject: QoS host networks: caps now reports QoS for networks.
..
Patch Set 3:
In order to verify this patch those steps detailed below can be executed:
In [1]: from vdsm import vdscli
In [2]: cn = vdscli.connect()
In [3]: cn.addNetwork('pluto', '', '', ['p1p4'], {'qosInbound':{'average':
'1024'}, 'qosOutbound':{'average': '2400'}})
Out[3]: {'status': {'code': 0, 'message': 'Done'}}
In [4]: cn.addNetwork('toni', '', '', ['p1p3'], {'qosInbound':{'average':
'1024'}})
Out[4]: {'status': {'code': 0, 'message': 'Done'}}
In [5]: cn.addNetwork('goofy', '', '', ['p1p2'], {'qosInbound':{'average':
'1024', 'burst': '42', 'peak': '152'}}
Out[5]: {'status': {'code': 0, 'message': 'Done'}}
using vdsClient getVdsCaps should report as networks the following:
networks = {'goofy': {'addr': '',
'bridged': True,
'cfg': {'DELAY': '0',
'DEVICE': 'goofy',
'NM_CONTROLLED': 'no',
'ONBOOT': 'yes',
'TYPE': 'Bridge'},
'gateway': '0.0.0.0',
'iface': 'goofy',
'ipv6addrs': ['fe80::210:18ff:fee1:6d2a/64'],
'ipv6gateway': '::',
'mtu': '1500',
'netmask': '',
'ports': ['p1p2'],
'qosInbound': {'average': '1024', 'burst': '42',
'peak': '152'},
'qosOutbound': '',
'stp': 'off'},
'ovirtmgmt': {'addr': '10.34.63.169',
'bridged': True,
'cfg': {'BOOTPROTO': 'dhcp',
'DELAY': '0',
'DEVICE': 'ovirtmgmt',
'NM_CONTROLLED': 'no',
'ONBOOT': 'yes',
'STP': 'no',
'TYPE': 'Bridge'},
'gateway': '10.34.63.254',
'iface': 'ovirtmgmt',
'ipv6addrs': ['fe80::d267:e5ff:fef0:75b4/64',
'2620:52:0:223c:d267:e5ff:fef0:75b4/64'],
'ipv6gateway': 'fe80:52:0:223c::3fe',
'mtu': '1500',
'netmask': '255.255.252.0',
'ports': ['em1'],
'qosInbound': '',
'qosOutbound': '',
'stp': 'off'},
'pluto': {'addr': '',
'bridged': True,
'cfg': {'DELAY': '0',
'DEVICE': 'pluto',
'NM_CONTROLLED': 'no',
'ONBOOT': 'yes',
'TYPE': 'Bridge'},
'gateway': '0.0.0.0',
'iface': 'pluto',
'ipv6addrs': ['fe80::210:18ff:fee1:6d2e/64'],
'ipv6gateway': '::',
'mtu': '1500',
'netmask': '',
'ports': ['p1p4'],
'qosInbound': {'average': '1024', 'burst': '',
'peak': ''},
'qosOutbound': {'average': '2400', 'burst': '',
'peak': ''},
'stp': 'off'},
'toni': {'addr': '',
'bridged': True,
'cfg': {'DELAY': '0',
'DEVICE': 'toni',
'NM_CONTROLLED': 'no',
'ONBOOT': 'yes',
'TYPE': 'Bridge'},
'gateway': '0.0.0.0',
'iface': 'toni',
'ipv6addrs': ['fe80::210:18ff:fee1:6d2c/64'],
'ipv6gateway': '::',
'mtu': '1500',
'netmask': '',
'ports': ['p1p3'],
'qosInbound': {'average': '1024', 'burst': '',
'peak': ''},
'qosOutbound': '',
'stp': 'off'}}
--
To view, visit http://gerrit.ovirt.org/17218
To unsubscribe, visit http://gerrit.ovirt.or
Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
Giuseppe Vallarelli has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/17218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Use reload option on multipath rescan
Yeela Kaplan has uploaded a new change for review. Change subject: multipath: Use reload option on multipath rescan .. multipath: Use reload option on multipath rescan Change-Id: I39f0789c8f296fe0e38739128ade45bca8833cb1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=964768 Signed-off-by: Yeela Kaplan --- M vdsm/storage/multipath.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/17263/1 diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py index 3dcf41f..7f647e5 100644 --- a/vdsm/storage/multipath.py +++ b/vdsm/storage/multipath.py @@ -108,7 +108,8 @@ supervdsm.getProxy().forceScsiScan() # Now let multipath daemon pick up new devices -misc.execCmd([constants.EXT_MULTIPATH], sudo=True) +cmd = [constants.EXT_MULTIPATH, "-r"] +misc.execCmd(cmd, sudo=True) def isEnabled(): -- To view, visit http://gerrit.ovirt.org/17263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I39f0789c8f296fe0e38739128ade45bca8833cb1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Assaf Muller has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: Looks good to me, but someone else must approve After talking to Dan offline I was convinced that the right thing to do is to merge this in, and push a later patch (Which I take responsibility for) to introduce a new error code and make the appropriate change engine-side to display a more descriptive error message to the user. -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Antoni Segura Puimedon has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: Thanks Assaf for the review and taking care of the future change in error codes ;-) -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Antoni Segura Puimedon has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: Verified Passed the functional tests and returned the proper error message. -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: multipath: Use reload option on multipath rescan
oVirt Jenkins CI Server has posted comments on this change. Change subject: multipath: Use reload option on multipath rescan .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2674/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3565/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39f0789c8f296fe0e38739128ade45bca8833cb1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
Giuseppe Vallarelli has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 3: I would prefer that you didn't submit this -1 A bugzilla should be associated being a feature the engine will rely upon. -- To view, visit http://gerrit.ovirt.org/17218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Dan Kenigsberg has submitted this change and it was merged. Change subject: fix setupNets 'remove' of non-existent net .. fix setupNets 'remove' of non-existent net setupNetworks was assuming that if a net was not in vdsm nets nor in libvirt nets it was a net that we were trying to add when, in fact, it could very well be a non-existent network that was incorrectly marked for removal. The fix checks the case specified above and raises the same configNetworkError that delNetwork does on similar circumstances. Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Bug-url: https://bugzilla.redhat.com/977843 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/17254 Reviewed-by: Assaf Muller Reviewed-by: Dan Kenigsberg --- M vdsm/configNetwork.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Antoni Segura Puimedon: Verified Assaf Muller: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix setupNets 'remove' of non-existent net
Dan Kenigsberg has posted comments on this change. Change subject: fix setupNets 'remove' of non-existent net .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If79c46cbc21c5bb451d69c2acd73f6e1ecf330bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use shared lock for setStorageDomainDescription command
Dan Kenigsberg has posted comments on this change. Change subject: Use shared lock for setStorageDomainDescription command .. Patch Set 3: This (letting hsm mess with SD metadata) seems potentially serious - but should this get into beta? -- To view, visit http://gerrit.ovirt.org/17198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca7b7b6642c222d88a6cd2a94d4033c0c3ef70b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
Giuseppe Vallarelli has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 4: Verified Added also the BZ. -- To view, visit http://gerrit.ovirt.org/17218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...
Dan Kenigsberg has posted comments on this change. Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal' .. Patch Set 3: Looks good to me, but someone else must approve Removing non-functional code (with a silent try-except!) is honorable. However, since this was introduce by http://gerrit.ovirt.org/#/c/305/6/vdsm/storage/iscsi.py to solve https://bugzilla.redhat.com/show_bug.cgi?id=499222 I would prefer that Federico acks it. -- To view, visit http://gerrit.ovirt.org/17212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2675/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3482/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3566/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
Antoni Segura Puimedon has posted comments on this change.
Change subject: QoS host networks: caps now reports QoS for networks.
..
Patch Set 4: (1 inline comment)
File lib/vdsm/netinfo.py
Line 447: def _getNetInfo(network, iface, bridged, routes, ipv6routes):
Line 448: '''Returns a dictionary of properties about the network's
interface status.
Line 449: Raises a KeyError if the iface does not exist.'''
Line 450: data = {}
Line 451:
"Beautifying" old code in a moderately sized patch is distracting.
Line 452: try:
Line 453: if bridged:
Line 454: data.update({'ports': ports(iface), 'stp':
bridge_stp_state(iface),
Line 455: 'cfg': getIfaceCfg(iface)})
--
To view, visit http://gerrit.ovirt.org/17218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Petr Šebek
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...
Giuseppe Vallarelli has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 2: Rebase on top of http://gerrit.ovirt.org/#/c/17218/ -- To view, visit http://gerrit.ovirt.org/16838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd28a6e0fb0a192c033e19ff8fe029728cafdf5c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.
Giuseppe Vallarelli has posted comments on this change.
Change subject: QoS host networks: caps now reports QoS for networks.
..
Patch Set 4: (1 inline comment)
Added comment related to the blank line.
File lib/vdsm/netinfo.py
Line 447: def _getNetInfo(network, iface, bridged, routes, ipv6routes):
Line 448: '''Returns a dictionary of properties about the network's
interface status.
Line 449: Raises a KeyError if the iface does not exist.'''
Line 450: data = {}
Line 451:
I agree but now, it looks like an Haiku :-)
Line 452: try:
Line 453: if bridged:
Line 454: data.update({'ports': ports(iface), 'stp':
bridge_stp_state(iface),
Line 455: 'cfg': getIfaceCfg(iface)})
--
To view, visit http://gerrit.ovirt.org/17218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b9dde8c580b6087ada29bc3b0d682ed638d92f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Petr Šebek
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2676/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3483/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3567/ : FAILURE -- To view, visit http://gerrit.ovirt.org/16838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd28a6e0fb0a192c033e19ff8fe029728cafdf5c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...
oVirt Jenkins CI Server has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2677/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3484/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3568/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd28a6e0fb0a192c033e19ff8fe029728cafdf5c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...
Giuseppe Vallarelli has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 3: Failure due to small pep8 issue. -- To view, visit http://gerrit.ovirt.org/16838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd28a6e0fb0a192c033e19ff8fe029728cafdf5c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...
Giuseppe Vallarelli has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 3: Verified running the usual testsuite -- To view, visit http://gerrit.ovirt.org/16838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd28a6e0fb0a192c033e19ff8fe029728cafdf5c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...
Federico Simoncelli has posted comments on this change. Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal' .. Patch Set 3: (1 inline comment) File vdsm/storage/iscsi.py Line 181: portalStr = "%s:%d" % (portal.hostname, portal.port) Line 182: Line 183: with _iscsiadmTransactionLock: Line 184: iscsiadm.discoverydb_new(discoverType, iface.name, portalStr) Line 185: Wouldn't it be better to fix it? Why we don't need this anymore? (beside that it was failing since some time) Line 186: try: Line 187: # Push credentials Line 188: if credentials is not None: Line 189: for key, value in credentials.getIscsiadmOptions(): -- To view, visit http://gerrit.ovirt.org/17212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: refactoring: Configurator base class making attributes expli...
Giuseppe Vallarelli has posted comments on this change. Change subject: refactoring: Configurator base class making attributes explicit. .. Patch Set 2: Verified test suite green -- To view, visit http://gerrit.ovirt.org/16845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e5719146493c83349d18284fa1f67f99bc239fa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Giuseppe Vallarelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...
Sergey Gotliv has posted comments on this change. Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal' .. Patch Set 3: (1 inline comment) File vdsm/storage/iscsi.py Line 181: portalStr = "%s:%d" % (portal.hostname, portal.port) Line 182: Line 183: with _iscsiadmTransactionLock: Line 184: iscsiadm.discoverydb_new(discoverType, iface.name, portalStr) Line 185: I agree with you. I fixed it in the patch #2, but then I just tempted to remove it, this code doesn't work 16 month now and nobody doesn't complaint about it. ??? I'll provide another patch with the fix Line 186: try: Line 187: # Push credentials Line 188: if credentials is not None: Line 189: for key, value in credentials.getIscsiadmOptions(): -- To view, visit http://gerrit.ovirt.org/17212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...
Dan Kenigsberg has posted comments on this change. Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal' .. Patch Set 3: (1 inline comment) File vdsm/storage/iscsi.py Line 181: portalStr = "%s:%d" % (portal.hostname, portal.port) Line 182: Line 183: with _iscsiadmTransactionLock: Line 184: iscsiadm.discoverydb_new(discoverType, iface.name, portalStr) Line 185: Oh please do not! I like the code removal, hence the +1. I just need Federico's review. Line 186: try: Line 187: # Push credentials Line 188: if credentials is not None: Line 189: for key, value in credentials.getIscsiadmOptions(): -- To view, visit http://gerrit.ovirt.org/17212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use shared lock for setStorageDomainDescription command
Eduardo has posted comments on this change. Change subject: Use shared lock for setStorageDomainDescription command .. Patch Set 3: Do not submit This review is temporary in order to avoid the merge of this patch until some questions will be ellucidated. By https://bugzilla.redhat.com/show_bug.cgi?id=819316#c2 this is and old issue. (Already known in 2009!) The actual state is that this operation can be issued to a host which is not the SPM. In the block case this can lead to DL. If such cases are not exist, we can deduce that the command was not issued very often and/or that engine sent this command to the SPM only. The actual patch makes the command to fail if it was issued to a non SPM host, which is absolutely right, but this can lead to removal the engine protection, if it exists. In such case new engines sending this command to wrong hosts running the old vdsm (unprotected) code and producing DL. The SD description (name in the MD) is retrieved by getStorageDomainInfo command, unused by vdsm, and never passed as an indentifier, compared, etc. In case that the engine issued the getStorageDomain command I'm dobious if this field content is used in any form. The same info is already in the engine DB. Can this verb to be replaced by a NO OP in the vdsm side? When setStorageDomainDescription is issued by the engine? -- To view, visit http://gerrit.ovirt.org/17198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca7b7b6642c222d88a6cd2a94d4033c0c3ef70b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...
Eduardo has posted comments on this change. Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal' .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) File vdsm/storage/iscsi.py Line 182: Line 183: with _iscsiadmTransactionLock: Line 184: iscsiadm.discoverydb_new(discoverType, iface.name, portalStr) Line 185: Line 186: try: Please reduce this try-block and check if it is necessary at all. hideValue is a specially arcane name. Line 187: # Push credentials Line 188: if credentials is not None: Line 189: for key, value in credentials.getIscsiadmOptions(): Line 190: key = "discovery.sendtargets." + key -- To view, visit http://gerrit.ovirt.org/17212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove unused lvm._vgmknodes().
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove unused lvm._vgmknodes(). .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2679/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3486/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3570/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I963ca7ed57a2c26fdc07caf0d1f92dba18cd1335 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make lvm.listPVNames() be based on vgs information.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make lvm.listPVNames() be based on vgs information. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2678/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3485/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3569/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e04a73476cab53e9a0a6c74eab2e747380f25c4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Elad Ben Aharon Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove broken getDeviceInfo().
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove broken getDeviceInfo(). .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2680/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3487/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3571/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/14632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23924f8de928d7e4fe75e999be48f778adb71452 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Paikov Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use shared lock for setStorageDomainDescription command
Ayal Baron has posted comments on this change. Change subject: Use shared lock for setStorageDomainDescription command .. Patch Set 3: ^ This review is temporary in order to avoid the merge of this patch until some questions will be ellucidated. This does not mean it should have a -2 ^ ^ By https://bugzilla.redhat.com/show_bug.cgi?id=819316#c2 this is and old issue. (Already known in 2009!) That doesn't mean it shouldn't be fixed ^ ^ The actual state is that this operation can be issued to a host which is not the SPM. In the block case this can lead to DL. Which in itself is a good enough reason to fix it ^ ^ If such cases are not exist, we can deduce that the command was not issued very often and/or that engine sent this command to the SPM only. The fact that engine doesn't call it as an HSM verb doesn't mean we should leave it as such. ^ ^ The actual patch makes the command to fail if it was issued to a non SPM host, which is absolutely right, but this can lead to removal the engine protection, if it exists. In such case new engines sending this command to wrong hosts running the old vdsm (unprotected) code and producing DL. This doesn't even make sense and we're wasting time here on not merging a patch that you agree is fixing the problem. ^ The SD description (name in the MD) is retrieved by getStorageDomainInfo command, unused by vdsm, and never passed as an indentifier, compared, etc. The purpose of it is to be able to correlate what this domain is from vdsm side without needing to know what the UUID of the domain means. ^ ^ In case that the engine issued the getStorageDomain command I'm dobious if this field content is used in any form. ^ ^ The same info is already in the engine DB. ^ ^ Can this verb to be replaced by a NO OP in the vdsm side? When setStorageDomainDescription is issued by the engine? No. -- To view, visit http://gerrit.ovirt.org/17198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca7b7b6642c222d88a6cd2a94d4033c0c3ef70b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing update of 'node.startup' setting in 'addIscsiPortal...
Sergey Gotliv has posted comments on this change. Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal' .. Patch Set 3: (1 inline comment) File vdsm/storage/iscsi.py Line 182: Line 183: with _iscsiadmTransactionLock: Line 184: iscsiadm.discoverydb_new(discoverType, iface.name, portalStr) Line 185: Line 186: try: Its not related to the patch. This patch resolves a bug, please, see bug-url. All other changes even if they are make our code better are irrelevant for that issue. Line 187: # Push credentials Line 188: if credentials is not None: Line 189: for key, value in credentials.getIscsiadmOptions(): Line 190: key = "discovery.sendtargets." + key -- To view, visit http://gerrit.ovirt.org/17212 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib34952047367db196733e942416a232d12a4e491 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sergey Gotliv Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
