Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Michal Skrivanek has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 12:
(1 comment)
File lib/vdsm/libvirtconnection.py
Line 131: log.debug('trying to connect libvirt')
Line 132: conn = utils.retry(libvirtOpenAuth, timeout=10, sleep=0.2)
Line 133: __connections[id(target)] = conn
Line 134:
Line 135: setattr(conn, 'pingLibvirt', getattr(conn,
'getLibVersion'))
since libvirtconnection is trying to be just a wrapper, IMHO it's better to
avoid creating of new verbs...why not just use getLibVersion at line 95
Line 136: for name in dir(libvirt.virConnect):
Line 137: method = getattr(conn, name)
Line 138: if callable(method) and name[0] != '_':
Line 139: setattr(conn, name, wrapMethod(method))
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for ram/vram on QXL device
Michal Skrivanek has posted comments on this change. Change subject: vdsm: add support for ram/vram on QXL device .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Zhou Zheng Sheng has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 1: Verified+1 Tested on Ubunt 13.04 and launchpad.net PPA build environment. -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
oVirt Jenkins CI Server has posted comments on this change. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3759/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4568/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4644/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ubuntu: packaging: keep up with vdsm.spec.in
Zhou Zheng Sheng has uploaded a new change for review. Change subject: Ubuntu: packaging: keep up with vdsm.spec.in .. Ubuntu: packaging: keep up with vdsm.spec.in In vdsm.spec.in we add new files and folders, so add those files and folders to Ubuntu packaging scripts as well. Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Signed-off-by: Zhou Zheng Sheng --- M debian/vdsm-tests.install M debian/vdsm.dirs 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/19587/1 diff --git a/debian/vdsm-tests.install b/debian/vdsm-tests.install index 4526d63..ad48def 100644 --- a/debian/vdsm-tests.install +++ b/debian/vdsm-tests.install @@ -7,6 +7,10 @@ usr/share/vdsm/tests/functional/*.policy usr/share/vdsm/tests/functional/*.py usr/share/vdsm/tests/glob_1c60971a-8647-44ac-ae33-6520887f8843.out +usr/share/vdsm/tests/glusterVolumeProfileInfo.xml +usr/share/vdsm/tests/glusterVolumeProfileInfoNfs.xml +usr/share/vdsm/tests/glusterVolumeRebalanceStatus.xml +usr/share/vdsm/tests/glusterVolumeRemoveBricksStatus.xml usr/share/vdsm/tests/lvs_3386c6f2-926f-42c4-839c-38287fac8998.out usr/share/vdsm/tests/netmaskconversions usr/share/vdsm/tests/run_tests.sh diff --git a/debian/vdsm.dirs b/debian/vdsm.dirs index b30e5fc..d33303b 100644 --- a/debian/vdsm.dirs +++ b/debian/vdsm.dirs @@ -2,6 +2,7 @@ etc/pki/vdsm etc/pki/vdsm/certs etc/pki/vdsm/keys +etc/pki/vdsm/libvirt-spice etc/vdsm etc/vdsm/mom.d rhev -- To view, visit http://gerrit.ovirt.org/19587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie436c02537abbedc60d8144bc3f50d99df21226a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add iproute2 configurator
Mark Wu has posted comments on this change. Change subject: Add iproute2 configurator .. Patch Set 18: (1 comment) File vdsm/netconf/iproute2.py Line 121: if toBeRemoved: Line 122: if iface.master is None: Line 123: self.configApplier.removeIpConfig(iface) Line 124: Line 125: if destroy: Done Line 126: destroyAction(iface) Line 127: else: Line 128: self.configApplier.setIfaceMtu(iface.name, Line 129:netinfo.DEFAULT_MTU) -- To view, visit http://gerrit.ovirt.org/15301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: UpdateVmDevice QoS
Dan Kenigsberg has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 3126: link = xml.dom.minidom.Element('link')
Line 3127: vnicXML.appendChildWithArgs(link)
Line 3128: link.setAttribute('state', linkValue)
Line 3129: if specParams and \
Line 3130: ('inbound' in specParams or 'outbound' in
specParams):
Oh, and please document your decision in the commit message.
Line 3131: new_bandwidth = dev.getXmlBandwidth(specParams)
Line 3132: try:
Line 3133: old_bandwidth =
vnicXML.getElementsByTagName('bandwidth')[0]
Line 3134: vnicXML.replaceChild(new_bandwidth, old_bandwidth)
--
To view, visit http://gerrit.ovirt.org/19545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Šebek
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: UpdateVmDevice QoS
Dan Kenigsberg has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 2: Code-Review-1
(1 comment)
File vdsm/vm.py
Line 3126: link = xml.dom.minidom.Element('link')
Line 3127: vnicXML.appendChildWithArgs(link)
Line 3128: link.setAttribute('state', linkValue)
Line 3129: if specParams and \
Line 3130: ('inbound' in specParams or 'outbound' in
specParams):
Only now have I realized that we need to somehow differentiate a request of
"keep current QoS", from a request to remove inboud/outbound.
With networkValue we use missing value to mean "keep current" and the empty
string to mean "delete".
Line 3131: new_bandwidth = dev.getXmlBandwidth(specParams)
Line 3132: try:
Line 3133: old_bandwidth =
vnicXML.getElementsByTagName('bandwidth')[0]
Line 3134: vnicXML.replaceChild(new_bandwidth, old_bandwidth)
--
To view, visit http://gerrit.ovirt.org/19545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Šebek
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: use the correct default for LEASE_TIME_SEC
Dan Kenigsberg has submitted this change and it was merged. Change subject: sd: use the correct default for LEASE_TIME_SEC .. sd: use the correct default for LEASE_TIME_SEC Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011505 Change-Id: I7d0e3939241120656513d47d1bbb1cacaef0ae83 Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/19567 Tested-by: Ohad Basan Reviewed-by: Dan Kenigsberg --- M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Ohad Basan: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d0e3939241120656513d47d1bbb1cacaef0ae83 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ohad Basan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: use the correct default for LEASE_TIME_SEC
Dan Kenigsberg has posted comments on this change. Change subject: sd: use the correct default for LEASE_TIME_SEC .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d0e3939241120656513d47d1bbb1cacaef0ae83 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ohad Basan Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: UpdateVmDevice QoS
Petr Šebek has posted comments on this change.
Change subject: bugfix: UpdateVmDevice QoS
..
Patch Set 1:
(3 comments)
File vdsm/vm.py
Line 1302: if self.sndbufParam:
Line 1303: tune = iface.appendChildWithArgs('tune')
Line 1304: tune.appendChildWithArgs('sndbuf', text=self.sndbufParam)
Line 1305:
Line 1306: if hasattr(self, 'specParams'):
Created new function NetworkInterfaceDevice.getXmlBandwidth.
Line 1307: if 'inbound' in self.specParams or 'outbound' in
self.specParams:
Line 1308: bandwidth = self.createXmlElem('bandwidth', None)
Line 1309: # Inbound and Outbound traffic can be indipendently
shaped.
Line 1310: inbound = self.specParams.get('inbound')
Line 3113:
Line 3114: @contextmanager
Line 3115: def setLinkAndNetwork(self, dev, conf, linkValue, networkValue,
custom,
Line 3116: specParams):
Line 3117: def updateXMLWithQoS(vnicXML, qos):
Now it's without qos.
Line 3118: bandwidth = vnicXML.getElementsByTagName('bandwidth')[0]
Line 3119: inbound = bandwidth.getElementsByTagName('inbound')[0]
Line 3120: outbound = bandwidth.getElementsByTagName('outbound')[0]
Line 3121: if 'inbound' in qos:
Line 3114: @contextmanager
Line 3115: def setLinkAndNetwork(self, dev, conf, linkValue, networkValue,
custom,
Line 3116: specParams):
Line 3117: def updateXMLWithQoS(vnicXML, qos):
Line 3118: bandwidth = vnicXML.getElementsByTagName('bandwidth')[0]
The code now handles these cases.
Line 3119: inbound = bandwidth.getElementsByTagName('inbound')[0]
Line 3120: outbound = bandwidth.getElementsByTagName('outbound')[0]
Line 3121: if 'inbound' in qos:
Line 3122: bandwidth.remove(inbound)
--
To view, visit http://gerrit.ovirt.org/19545
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Petr Šebek
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bugfix: UpdateVmDevice QoS
oVirt Jenkins CI Server has posted comments on this change. Change subject: bugfix: UpdateVmDevice QoS .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3758/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4567/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4643/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43a383b2a9cf96366927beebf63f1344027169fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Šebek Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing
Dan Kenigsberg has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/19295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: shared attribute backward compatibility
Dan Kenigsberg has posted comments on this change. Change subject: vm: shared attribute backward compatibility .. Patch Set 5: It's better than what I've expected - assuming that Engine is never sending the extended values to ovirt-3.3 clusters. right? -- To view, visit http://gerrit.ovirt.org/19509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d377635b0687baccc69b203cb3fbe8dbf573169 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4643/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4565/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3758/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4642/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4566/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: use the correct default for LEASE_TIME_SEC
Ohad Basan has posted comments on this change. Change subject: sd: use the correct default for LEASE_TIME_SEC .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d0e3939241120656513d47d1bbb1cacaef0ae83 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Ohad Basan Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: setupNetworks over exiting USED bond
Dan Kenigsberg has posted comments on this change. Change subject: net tests: setupNetworks over exiting USED bond .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc5159665a23863cc997390cfc6dc9100a33eca2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: setupNetworks over exiting USED bond
oVirt Jenkins CI Server has posted comments on this change. Change subject: net tests: setupNetworks over exiting USED bond .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4642/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4564/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4641/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3756/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4565/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc5159665a23863cc997390cfc6dc9100a33eca2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net tests: setupNetworks over exiting USED bond
Dan Kenigsberg has uploaded a new change for review.
Change subject: net tests: setupNetworks over exiting USED bond
..
net tests: setupNetworks over exiting USED bond
Currently testSetupNetworksAddOverExistingBond fails, but only because
it is too strict: it does not allow the bonding device to change its
state even when it has no users. However, if the bond is not used, we
actually WANT it to be reconfigured (e.g. if its MTU is to be set to a
lower value).
Thus the tests is amended so that it would fail only if bond0 changes
its operstate while it is being used by a birdgeless network.
Change-Id: Ibc5159665a23863cc997390cfc6dc9100a33eca2
Signed-off-by: Dan Kenigsberg
---
M tests/functional/networkTests.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/19573/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index beb5ae7..83a5988 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -167,7 +167,9 @@
def testSetupNetworksAddOverExistingBond(self, bridged=True):
with dummyIf(2) as nics:
status, msg = self.vdsm_net.setupNetworks(
-{}, {BONDING_NAME: {'nics': nics}},
+{NETWORK_NAME + '0': {'bonding': BONDING_NAME,
+ 'bridged': False}},
+{BONDING_NAME: {'nics': nics}},
{'connectivityCheck': False})
self.assertEqual(status, SUCCESS, msg)
self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
@@ -182,7 +184,8 @@
self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME, bridged))
status, msg = self.vdsm_net.setupNetworks(
-{NETWORK_NAME: {'remove': True}},
+{NETWORK_NAME: {'remove': True},
+ NETWORK_NAME + '0': {'remove': True}},
{}, {'connectivityCheck': False})
self.assertEqual(status, SUCCESS, msg)
self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
--
To view, visit http://gerrit.ovirt.org/19573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc5159665a23863cc997390cfc6dc9100a33eca2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: systemd: vdsmd: fixed sanlock requirement
Dan Kenigsberg has submitted this change and it was merged. Change subject: systemd: vdsmd: fixed sanlock requirement .. systemd: vdsmd: fixed sanlock requirement Added missing .service. Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Signed-off-by: Sandro Bonazzola Reviewed-on: http://gerrit.ovirt.org/19572 Reviewed-by: Antoni Segura Puimedon Reviewed-by: Dan Kenigsberg --- M init/systemd/vdsmd.service.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: systemd: vdsmd: fixed sanlock requirement
Dan Kenigsberg has posted comments on this change. Change subject: systemd: vdsmd: fixed sanlock requirement .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit http://gerrit.ovirt.org/19572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: systemd: vdsmd: fixed sanlock requirement
Antoni Segura Puimedon has posted comments on this change. Change subject: systemd: vdsmd: fixed sanlock requirement .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: systemd: vdsmd: fixed sanlock requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: systemd: vdsmd: fixed sanlock requirement .. Patch Set 1: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4564/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4641/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4563/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3756/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: systemd: vdsmd: fixed sanlock requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: systemd: vdsmd: fixed sanlock requirement .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4562/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3755/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4563/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: systemd: vdsmd: fixed sanlock requirement
oVirt Jenkins CI Server has posted comments on this change. Change subject: systemd: vdsmd: fixed sanlock requirement .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4562/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3755/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3755/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4562/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: systemd: vdsmd: fixed sanlock requirement
Sandro Bonazzola has posted comments on this change. Change subject: systemd: vdsmd: fixed sanlock requirement .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: systemd: vdsmd: fixed sanlock requirement
Sandro Bonazzola has uploaded a new change for review. Change subject: systemd: vdsmd: fixed sanlock requirement .. systemd: vdsmd: fixed sanlock requirement Added missing .service. Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Signed-off-by: Sandro Bonazzola --- M init/systemd/vdsmd.service.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/19572/1 diff --git a/init/systemd/vdsmd.service.in b/init/systemd/vdsmd.service.in index eefa661..f14ec17 100644 --- a/init/systemd/vdsmd.service.in +++ b/init/systemd/vdsmd.service.in @@ -1,7 +1,7 @@ [Unit] Description=Virtual Desktop Server Manager Requires=multipathd.service libvirtd.service time-sync.target \ - iscsid.service rpcbind.service supervdsmd.service sanlock + iscsid.service rpcbind.service supervdsmd.service sanlock.service Conflicts=libvirt-guests.service ksmtuned.service [Service] -- To view, visit http://gerrit.ovirt.org/19572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic1f4270ec1db959cae458ee7292175ea8efc57b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
mooli tayer has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 12: Verified-1
What I did to test this patch:
a.) Wrote unit tests
b.) Ran cross migration between two hosts running a total of 4 vms. I installed
them from ovirt-stable repo and replaced libvirtconnection.py
I discovered that in patch set 11 and before the whole thing was one big bug:
I wrote wrapper like so:
def wrapper(pingLibvirt=True, *args, **kwargs):
...
ret = f(*args, **kwargs)
and the user of this class called this wrapper for example:
conn.nwfilterLookupByName('someArg')
That would lead to:
pingLibvirt='someArg'
And worse args = []
Shame on me!
After the fix of this patch set the migration still does not work. not sure if
it is related to this patch set or not.
one host becomes non operational (the engine runs getCaps on it and gives the
error: 'Host host_01 running without virtualization hardware acceleration' )
still checking this
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: use the correct default for LEASE_TIME_SEC
oVirt Jenkins CI Server has posted comments on this change. Change subject: sd: use the correct default for LEASE_TIME_SEC .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4639/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4561/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3754/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4639/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3754/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4561/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d0e3939241120656513d47d1bbb1cacaef0ae83 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: use the correct default for LEASE_TIME_SEC
Federico Simoncelli has uploaded a new change for review. Change subject: sd: use the correct default for LEASE_TIME_SEC .. sd: use the correct default for LEASE_TIME_SEC Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011505 Change-Id: I7d0e3939241120656513d47d1bbb1cacaef0ae83 Signed-off-by: Federico Simoncelli --- M vdsm/storage/blockSD.py M vdsm/storage/fileSD.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/19567/1 diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 0867ad3..d27f331 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -564,7 +564,7 @@ sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC: sd.DEFAULT_LEASE_PARAMS[ sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC], sd.DMDK_LEASE_TIME_SEC: sd.DEFAULT_LEASE_PARAMS[ -sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC], +sd.DMDK_LEASE_TIME_SEC], sd.DMDK_IO_OP_TIMEOUT_SEC: sd.DEFAULT_LEASE_PARAMS[ sd.DMDK_IO_OP_TIMEOUT_SEC], sd.DMDK_LEASE_RETRIES: sd.DEFAULT_LEASE_PARAMS[ diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py index ee1255f..8e788a5 100644 --- a/vdsm/storage/fileSD.py +++ b/vdsm/storage/fileSD.py @@ -227,7 +227,7 @@ sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC: sd.DEFAULT_LEASE_PARAMS[sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC], sd.DMDK_LEASE_TIME_SEC: sd.DEFAULT_LEASE_PARAMS[ -sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC], +sd.DMDK_LEASE_TIME_SEC], sd.DMDK_IO_OP_TIMEOUT_SEC: sd.DEFAULT_LEASE_PARAMS[sd.DMDK_IO_OP_TIMEOUT_SEC], sd.DMDK_LEASE_RETRIES: -- To view, visit http://gerrit.ovirt.org/19567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7d0e3939241120656513d47d1bbb1cacaef0ae83 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix duplicate port mirrorring when reattaching vm
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix duplicate port mirrorring when reattaching vm .. Fix duplicate port mirrorring when reattaching vm When there is a VM running with port mirrorring defined, the fact that a vdsm restart re-attaches by "recreating" the vdsm vm object makes it run setPortMirroring again. This caused every vdsm restart to add a mirrorring duplication. Change-Id: I63deb5e703060f1891779d6697eaf17cd06ce8d3 Bug-Url: https://bugzilla.redhat.com/1001704 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/19534 Reviewed-by: Dan Kenigsberg --- M vdsm/vm.py 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63deb5e703060f1891779d6697eaf17cd06ce8d3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: bug fix for listing and adding hook
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: bug fix for listing and adding hook .. gluster: bug fix for listing and adding hook Earlier, with regard to gluster hooks there would be definitely a pre and post directory for each and every gluster command. But presently, if either pre or post script is not present there will be no pre or post directories also. Therefore, if there is no such directories available the gluster hook list will simply omit it. When a gluster hook is added if pre or post directories are absent, they will be created accordingly, then the hook will be added. Change-Id: I470470da153edef3fe7eb3a7d41a775bac208449 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999795 Signed-off-by: Timothy Asir Reviewed-on: http://gerrit.ovirt.org/18345 Reviewed-by: Dan Kenigsberg --- M vdsm/gluster/hooks.py 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Timothy Asir: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I470470da153edef3fe7eb3a7d41a775bac208449 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: bug fix for listing and adding hook
Dan Kenigsberg has posted comments on this change. Change subject: gluster: bug fix for listing and adding hook .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/18345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I470470da153edef3fe7eb3a7d41a775bac208449 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsiadm: Filter out IPv6 addresses when discovering targets
oVirt Jenkins CI Server has posted comments on this change. Change subject: iscsiadm: Filter out IPv6 addresses when discovering targets .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4638/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4560/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3753/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4638/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3753/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4560/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f6d60e780e9ac50041cdcaa0c45394e392b52f4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsiadm: Filter out IPv6 addresses when discovering targets
Dan Kenigsberg has submitted this change and it was merged. Change subject: iscsiadm: Filter out IPv6 addresses when discovering targets .. iscsiadm: Filter out IPv6 addresses when discovering targets This patch is not diminishing any capabilities we have, since we currently don't support ipV6 targets in vdsm. When discovering targets on Netapp storage we get a return value that includes both IPv4 and IPv6 addresses. The only thing I've changed is preventing vdsm from failing discovery because of getting an unexpected response from iscsiadm (our parser is very hardcoded). If we decide to support ipV6 addresses for discovery, login and managing the connection then it needs to be addressed separately. Change-Id: I2f6d60e780e9ac50041cdcaa0c45394e392b52f4 Signed-off-by: Yeela Kaplan Reviewed-on: http://gerrit.ovirt.org/19431 Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M vdsm/storage/iscsiadm.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f6d60e780e9ac50041cdcaa0c45394e392b52f4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsiadm: Filter out IPv6 addresses when discovering targets
Dan Kenigsberg has posted comments on this change. Change subject: iscsiadm: Filter out IPv6 addresses when discovering targets .. Patch Set 3: Verified+1 Code-Review+2 Copy score -- To view, visit http://gerrit.ovirt.org/19431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f6d60e780e9ac50041cdcaa0c45394e392b52f4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsiadm: Filter out IPv6 addresses when discovering targets
Yeela Kaplan has posted comments on this change. Change subject: iscsiadm: Filter out IPv6 addresses when discovering targets .. Patch Set 2: (1 comment) Commit Message Line 3: AuthorDate: 2013-09-22 13:16:41 +0200 Line 4: Commit: Yeela Kaplan Line 5: CommitDate: 2013-09-24 13:15:19 +0200 Line 6: Line 7: iscsiadm: Filter out IPv6 addresses when discovering targets This patch is not diminishing any capabilities we have, since we currently don't support ipV6 targets in vdsm. When discovering targets on Netapp storage we get a return value that includes both IPv4 and IPv6 addresses. The only thing I've changed is preventing vdsm from failing discovery because of getting an unexpected response from iscsiadm (our parser is very hardcoded). If we decide to support ipV6 addresses for discovery, login and managing the connection then it needs to be addressed separately. Line 8: Line 9: Change-Id: I2f6d60e780e9ac50041cdcaa0c45394e392b52f4 -- To view, visit http://gerrit.ovirt.org/19431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f6d60e780e9ac50041cdcaa0c45394e392b52f4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: bug fix for listing and adding hook
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: bug fix for listing and adding hook .. Patch Set 9: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4637/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4559/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3752/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I470470da153edef3fe7eb3a7d41a775bac208449 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
