Change in vdsm[master]: Remove redundant file closing
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove redundant file closing .. Remove redundant file closing Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Signed-off-by: Antoni S. Puimedon asegu...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20106 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/netconf/ifcfg.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant file closing
Dan Kenigsberg has posted comments on this change. Change subject: Remove redundant file closing .. Patch Set 1: Code-Review+2 Oops. -- To view, visit http://gerrit.ovirt.org/20106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant file closing
Dan Kenigsberg has posted comments on this change. Change subject: Remove redundant file closing .. Patch Set 1: Verified+1 Obviously correct. -- To view, visit http://gerrit.ovirt.org/20106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdcda3813722de117aad89664cf75d55cda19c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
Dan Kenigsberg has posted comments on this change.
Change subject: Unified persistence [3/4] - Restore network config
..
Patch Set 29: Code-Review-1
(2 comments)
Minor nit.
File vdsm/vdsm-restore-net-config
Line 44: removeBonds = {}
Line 45: for network in runningConfig.networks:
Line 46: removeNetworks[network] = {'remove': True}
Line 47: for bond in runningConfig.bonds:
Line 48: removeBonds[bond] = {'remove': True}
I am so happy for having functional tests to catch the need for this...
Line 49: logging.debug('Removing all networks (%s) and bonds (%s) in
running '
Line 50: 'config.' % (removeNetworks, removeBonds))
Line 51: setupNetworks(removeNetworks, removeBonds, connectivityCheck=False)
Line 52:
Line 46: removeNetworks[network] = {'remove': True}
Line 47: for bond in runningConfig.bonds:
Line 48: removeBonds[bond] = {'remove': True}
Line 49: logging.debug('Removing all networks (%s) and bonds (%s) in
running '
Line 50: 'config.' % (removeNetworks, removeBonds))
Let logging render the string (done only if loglevel requires it).
Line 51: setupNetworks(removeNetworks, removeBonds, connectivityCheck=False)
Line 52:
Line 53: configurator.flush()
Line 54: persistentConfig = PersistentConfig()
--
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Petr Šebek pse...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus
Bala.FA has posted comments on this change. Change subject: gluster: Fix output format compatibility of removeBrickStatus .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Fix output format compatibility of removeBrickStatus .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4929/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4043/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4853/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Replace bricks verbs removed
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Replace bricks verbs removed .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4930/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4044/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4854/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23cd224ced9c6892ab182f663476df428f2f35da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus
Aravinda VK has posted comments on this change. Change subject: gluster: Fix output format compatibility of removeBrickStatus .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/20108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Replace bricks verbs removed
Aravinda VK has posted comments on this change. Change subject: gluster: Replace bricks verbs removed .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/20060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23cd224ced9c6892ab182f663476df428f2f35da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume
Aravinda VK has posted comments on this change. Change subject: gluster: Get size information of a gluster volume .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/17822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: add ddWatchCopy append tests
Dan Kenigsberg has submitted this change and it was merged. Change subject: test: add ddWatchCopy append tests .. test: add ddWatchCopy append tests Change-Id: Ib3a8cc6b59b356b333f4338103e7b665af584cdc Signed-off-by: Federico Simoncelli fsimo...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20075 Reviewed-by: Sergey Gotliv sgot...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/miscTests.py 1 file changed, 68 insertions(+), 9 deletions(-) Approvals: Federico Simoncelli: Verified Sergey Gotliv: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3a8cc6b59b356b333f4338103e7b665af584cdc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: add ddWatchCopy append tests
Dan Kenigsberg has posted comments on this change. Change subject: test: add ddWatchCopy append tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3a8cc6b59b356b333f4338103e7b665af584cdc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: refactor remoteFileHandler truncateFile tests
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: refactor remoteFileHandler truncateFile tests .. tests: refactor remoteFileHandler truncateFile tests The old test was too big, causing one test to fail if the other failed. Now there are 2 separated tests, sharing setup, teardown and check methods. Additionally, creation of the test file is more correct, and the code is hopefully more readable. Change-Id: I0c23482e5d25651dc6090c7acfaa0ae221a562fe Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/20084 Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/remoteFileHandlerTests.py 1 file changed, 24 insertions(+), 21 deletions(-) Approvals: Nir Soffer: Verified Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c23482e5d25651dc6090c7acfaa0ae221a562fe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: refactor remoteFileHandler truncateFile tests
Dan Kenigsberg has posted comments on this change. Change subject: tests: refactor remoteFileHandler truncateFile tests .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c23482e5d25651dc6090c7acfaa0ae221a562fe Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Fix output format compatibility of removeBrickStatus .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix output format compatibility of removeBrickStatus
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: Fix output format compatibility of removeBrickStatus
..
gluster: Fix output format compatibility of removeBrickStatus
Rebalance status and Remove brick status have common output structure,
engine uses common code to parse the vdsm output of both verbs.
This patch fixes the incompatibility in remove brick status output.
(As this verb is not consumed by engine/RHS-C yet, its OK to differ
in compatibility now)
Output:
{'summary': {
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
},
'hosts': [{
'name': STRING,
'filesScanned': INT,
'filesMoved': INT,
'filesFailed': INT,
'filesSkipped': INT,
'totalSizeMoved': INT,
'status': STRING
}..]}
Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Signed-off-by: Aravinda VK avish...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/20108
Reviewed-by: Bala.FA barum...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/gluster/api.py
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Bala.FA: Looks good to me, but someone else must approve
Aravinda VK: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20108
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7996af2a779119a6f703f309ad377c8a425b1c5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: ndarshan dnara...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: return domain lockspace status
Sergey Gotliv has posted comments on this change. Change subject: stats: return domain lockspace status .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/20099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: return domain lockspace status
Sandro Bonazzola has posted comments on this change. Change subject: stats: return domain lockspace status .. Patch Set 1: Verified+1 Verified with both: - http://gerrit.ovirt.org/19762 - http://gerrit.ovirt.org/19867 rebased on master. -- To view, visit http://gerrit.ovirt.org/20099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7069781f9945b4e4637b769a22562de30a6d681d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Sandro Bonazzola has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 2: Verified+1 Verified with both: - http://gerrit.ovirt.org/20099 - http://gerrit.ovirt.org/19867 See my previous comments about vdsClient module -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Get size information of a gluster volume .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4931/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4045/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4855/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring the device dict creation
Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: Refactoring the device dict creation .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/19733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Get size information of a gluster volume
Aravinda VK has posted comments on this change. Change subject: gluster: Get size information of a gluster volume .. Patch Set 7: I didn't succeed with the libgfapi approach to get statvfs information of glusterfs volume. Falling back to `mount -t glusterfs` method to get statvfs info of glusterfs volume. -- To view, visit http://gerrit.ovirt.org/17822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring the device dict creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Refactoring the device dict creation .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4932/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4046/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4856/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Bump kernel requires version to pass testSetupNetworksMtus o...
Dan Kenigsberg has posted comments on this change. Change subject: Bump kernel requires version to pass testSetupNetworksMtus on F19 .. Patch Set 1: Code-Review+2 Taking, based on (10:16:59 AM) ewoud: danken: however, it seems all f19 guests are running that version -- To view, visit http://gerrit.ovirt.org/19974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I161b34b0a67c88fe18c21e9857841639f7001098 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Bump kernel requires version to pass testSetupNetworksMtus o...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Bump kernel requires version to pass testSetupNetworksMtus on F19 .. Bump kernel requires version to pass testSetupNetworksMtus on F19 It's found that testSetupNetworksMtus fails on F19 because of the broken promiscuity reference counting issue in kernel. It has been fixed in kernel-3.11.3-201.fc19. With the updated kernel, the test testSetupNetworksMtus can pass. For detailed information, please see: https://bugzilla.redhat.com/show_bug.cgi?id=1005567 This problem doesn't exist in RHEL6 because it's triggered by a new kernel change. So we don't need any fix for rhel kernel. Change-Id: I161b34b0a67c88fe18c21e9857841639f7001098 Signed-off-by: Mark Wu wu...@linux.vnet.ibm.com Reviewed-on: http://gerrit.ovirt.org/19974 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Mark Wu: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I161b34b0a67c88fe18c21e9857841639f7001098 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Replace bricks verbs removed
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Replace bricks verbs removed .. Patch Set 2: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4933/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4047/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4857/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23cd224ced9c6892ab182f663476df428f2f35da Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: ndarshan dnara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. vdsm hooks: this patch provides after/before_network_setup hooks. This enables the capability to interact with physical network management interfaces, setting up extra parameters, or interacting with switches, etc. It also introduces a standard testing decorator for hook testcases. Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Signed-off-by: Miguel Angel Ajo miguelan...@ajo.es Reviewed-on: http://gerrit.ovirt.org/20076 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M AUTHORS M tests/Makefile.am M tests/functional/networkTests.py A tests/hookValidation.py M vdsm.spec.in M vdsm/configNetwork.py M vdsm/hooks.py M vdsm/vdsmd.8.in M vdsm_hooks/Makefile.am 9 files changed, 154 insertions(+), 5 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Miguel Angel Ajo Pelayo: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
Sandro Bonazzola has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 3: Verified+1 Addressed my comments as per Dan Kenigsberg request. Verified with both: - http://gerrit.ovirt.org/20099 - http://gerrit.ovirt.org/19867 and this patchset dependencies, rebased on master. -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()
Dan Kenigsberg has submitted this change and it was merged. Change subject: Read pool metadata once in StoragePool.getInfo() .. Read pool metadata once in StoragePool.getInfo() The behavioural change of spm_id should be safe since StoragePool.getInfo() call in hsm.getStoragePoolInfo() is under the (shared) pool lock making startSpm block in this host when the info is retrieved. Making repoStats pool independent. Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546 Signed-off-by: Eduardo ewars...@redhat.com Reviewed-on: http://gerrit.ovirt.org/14672 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/storage/sp.py 1 file changed, 15 insertions(+), 13 deletions(-) Approvals: Eduardo: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()
Dan Kenigsberg has posted comments on this change. Change subject: Read pool metadata once in StoragePool.getInfo() .. Patch Set 7: Code-Review+2 Copy Ayal's score. -- To view, visit http://gerrit.ovirt.org/14672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a79662a4bd01fc310aa5554c38a16f3f8ba546 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vered Volansky vvola...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add Patch class for fixture monkey patching
Nir Soffer has posted comments on this change. Change subject: tests: Add Patch class for fixture monkey patching .. Patch Set 2: Waking up reviewers -- To view, visit http://gerrit.ovirt.org/19881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd419377be951635fe7d10cb21c0d1195e88cf8d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4934/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4048/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/682/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make getRepoStats() a hsm method.
Federico Simoncelli has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 8: Verified-1 Code-Review-1 (1 comment) 'isoprefix' is not returned and you can't run VMs with cdroms. File vdsm/storage/hsm.py Line 2544: poolInfo = pool.getInfo() Line 2545: doms = pool.getDomains() Line 2546: domInfo = self._getDomsStats(pool.domainMonitor, doms) Line 2547: for sdUUID in doms.iterkeys(): Line 2548: if 'isoprefix' in domInfo[sdUUID] and domInfo[sdUUID]['isoprefix']: 'isoprefix' is not returned by _getDomsStats, it's returned by _getRepoStats. The end result is that 'isoprefix' is not reported and you can't run VMs with cdroms. Line 2549: poolInfo['isoprefix'] = domInfo[sdUUID]['isoprefix'] Line 2550: Line 2551: return dict(info=poolInfo, dominfo=domInfo) Line 2552: -- To view, visit http://gerrit.ovirt.org/14673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0273611a23f29b5c6be0354a4c6b2d6526a9b574 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Paikov pai...@gmail.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Elad Ben Aharon eladba1...@gmail.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding [start|stop]MonitoringDomain().
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding [start|stop]MonitoringDomain(). .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4935/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4049/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4859/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983d49b0a42cc06428ec75b7795d23abaa6ab84c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Gadi Ickowicz gicko...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Refactoring the device dict creation
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Refactoring the device dict creation .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4936/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4050/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4860/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ce2afa73f1f8d1aea15782fec7fee52ee49d66e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: refresh on mda permission mismatch
Federico Simoncelli has uploaded a new change for review. Change subject: lvm: refresh on mda permission mismatch .. lvm: refresh on mda permission mismatch Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=905665 Change-Id: I6a77b967a057329a90499d7707074befe756b68a Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/lvm.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/20121/1 diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 0c2964e..3686570 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -1299,6 +1299,9 @@ changelv(vg, lv, (--permission, permission)) except se.StorageException: l = getLV(vg, lv) +if l.attr.permission == 'R': +refreshLV(vg, lv) +l = getLV(vg, lv) if l.writeable == rw: # Ignore the error since lv is now rw, hoping that the error was # because lv was already rw, see BZ#654691. We may hide here -- To view, visit http://gerrit.ovirt.org/20121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6a77b967a057329a90499d7707074befe756b68a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: refresh on mda permission mismatch
Federico Simoncelli has posted comments on this change. Change subject: lvm: refresh on mda permission mismatch .. Patch Set 1: (1 comment) File vdsm/storage/lvm.py Line 1299: changelv(vg, lv, (--permission, permission)) Line 1300: except se.StorageException: Line 1301: l = getLV(vg, lv) Line 1302: if l.attr.permission == 'R': Line 1303: refreshLV(vg, lv) I am still not convinced that this is the appropriate fix. I'd prefer to fix this in lvm. Line 1304: l = getLV(vg, lv) Line 1305: if l.writeable == rw: Line 1306: # Ignore the error since lv is now rw, hoping that the error was Line 1307: # because lv was already rw, see BZ#654691. We may hide here -- To view, visit http://gerrit.ovirt.org/20121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a77b967a057329a90499d7707074befe756b68a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: pre-validate disks for snapshot
Federico Simoncelli has posted comments on this change. Change subject: vm: pre-validate disks for snapshot .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/20029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fb507c2f7268bb688af5fd187dcd033d0a068a2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network functional tests assertion improvements
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Network functional tests assertion improvements
..
Network functional tests assertion improvements
This change allows for more fine grained assertion errors. It allows
, among other things, to differentiate if what failed is making a
net or putting it into the running configuration.
Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M tests/functional/networkTests.py
M tests/functional/utils.py
2 files changed, 162 insertions(+), 160 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/20123/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index b85c3d5..304a01d 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -163,10 +163,10 @@
{})
self.assertEqual(status, SUCCESS, msg)
for vlan_net in network_names:
-self.assertTrue(self.vdsm_net.networkExists(vlan_net, bridged))
-self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
-self.assertTrue(self.vdsm_net.vlanExists(BONDING_NAME + '.' +
-networks[vlan_net]['vlan']))
+self.vdsm_net.assertNetworkExists(vlan_net, bridged)
+self.vdsm_net.assertBondExists(BONDING_NAME, nics)
+self.vdsm_net.assertVlanExists(BONDING_NAME + '.' +
+ networks[vlan_net]['vlan'])
with self.vdsm_net.pinger():
for vlan_net in network_names:
@@ -174,11 +174,9 @@
{vlan_net: {'remove': True}},
{BONDING_NAME: {'remove': True}}, {})
self.assertEqual(status, SUCCESS, msg)
-self.assertFalse(self.vdsm_net.networkExists(vlan_net,
- bridged))
-self.assertFalse(
-self.vdsm_net.vlanExists(BONDING_NAME + '.' +
- networks[vlan_net]['vlan']))
+self.vdsm_net.assertNetworkDoesntExist(vlan_net)
+self.vdsm_net.assertVlanDoesntExist(
+BONDING_NAME + '.' + networks[vlan_net]['vlan'])
@cleanupNet
@permutations([[True], [False]])
@@ -192,15 +190,15 @@
{'bonding': BONDING_NAME, 'bridged': bridged}},
{BONDING_NAME: {'nics': nics, 'options': 'mode=2'}}, {})
self.assertEqual(status, SUCCESS, msg)
-self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME, bridged))
-self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
+self.vdsm_net.assertNetworkExists(NETWORK_NAME, bridged)
+self.vdsm_net.assertBondExists(BONDING_NAME, nics)
with self.vdsm_net.pinger():
status, msg = self.vdsm_net.setupNetworks(
{NETWORK_NAME: {'remove': True}},
{BONDING_NAME: {'remove': True}}, {})
self.assertEqual(status, SUCCESS, msg)
-self.assertFalse(self.vdsm_net.networkExists(NETWORK_NAME))
+self.vdsm_net.assertNetworkDoesntExist(NETWORK_NAME)
@cleanupNet
@permutations([[True], [False]])
@@ -214,7 +212,7 @@
{BONDING_NAME: {'nics': nics}},
{'connectivityCheck': False})
self.assertEqual(status, SUCCESS, msg)
-self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
+self.vdsm_net.assertBondExists(BONDING_NAME, nics)
with nonChangingOperstate(BONDING_NAME):
status, msg = self.vdsm_net.setupNetworks(
@@ -223,19 +221,32 @@
'vlan': VLAN_ID}},
{}, {'connectivityCheck': False})
self.assertEqual(status, SUCCESS, msg)
-self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME, bridged))
+self.vdsm_net.assertNetworkExists(NETWORK_NAME, bridged)
status, msg = self.vdsm_net.setupNetworks(
{NETWORK_NAME: {'remove': True},
NETWORK_NAME + '0': {'remove': True}},
{}, {'connectivityCheck': False})
self.assertEqual(status, SUCCESS, msg)
-self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME, nics))
+self.vdsm_net.assertBondExists(BONDING_NAME, nics)
status, msg = self.vdsm_net.setupNetworks(
{},
{BONDING_NAME: {'remove': True}}, {'connectivityCheck': False})
self.assertEqual(status, SUCCESS, msg)
+
+def assertNetworkExists(self, networkName, bridged=None):
+
Change in vdsm[master]: Network functional tests assertion improvements
Dan Kenigsberg has posted comments on this change.
Change subject: Network functional tests assertion improvements
..
Patch Set 1: Code-Review-1
(3 comments)
File tests/functional/networkTests.py
Line 234: {},
Line 235: {BONDING_NAME: {'remove': True}},
{'connectivityCheck': False})
Line 236: self.assertEqual(status, SUCCESS, msg)
Line 237:
Line 238: def assertNetworkExists(self, networkName, bridged=None):
do we need this defined both here and in utils? I prefer to have it here due to
the delicate differences between self.assertTrue and the 'assert' statement
that you use in utils.
Line 239: self.assert_(networkName in self.vdsm_net.netinfo.networks)
Line 240: if bridged:
Line 241: self.assertEqual(
Line 242: bridged,
Line 235: {BONDING_NAME: {'remove': True}},
{'connectivityCheck': False})
Line 236: self.assertEqual(status, SUCCESS, msg)
Line 237:
Line 238: def assertNetworkExists(self, networkName, bridged=None):
Line 239: self.assert_(networkName in self.vdsm_net.netinfo.networks)
isn't assert_ an undocumented assertTrue? Do you find it nicer?
Line 240: if bridged:
Line 241: self.assertEqual(
Line 242: bridged,
Line 243:
self.vdsm_net.netinfo.networks[networkName]['bridged'])
Line 236: self.assertEqual(status, SUCCESS, msg)
Line 237:
Line 238: def assertNetworkExists(self, networkName, bridged=None):
Line 239: self.assert_(networkName in self.vdsm_net.netinfo.networks)
Line 240: if bridged:
if bridge is not None
Line 241: self.assertEqual(
Line 242: bridged,
Line 243:
self.vdsm_net.netinfo.networks[networkName]['bridged'])
Line 244: if self.vdsm_net.config is not None:
--
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: refresh on mda permission mismatch
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: refresh on mda permission mismatch .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4937/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4051/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4861/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a77b967a057329a90499d7707074befe756b68a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: pre-validate disks for snapshot
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: pre-validate disks for snapshot .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4938/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4052/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4862/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fb507c2f7268bb688af5fd187dcd033d0a068a2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified persistence [3/4] - Restore network config
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified persistence [3/4] - Restore network config .. Patch Set 30: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4939/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4053/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4863/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/683/ : FAILURE -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network functional tests assertion improvements
oVirt Jenkins CI Server has posted comments on this change. Change subject: Network functional tests assertion improvements .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4940/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4054/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4864/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/684/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network functional tests assertion improvements
Antoni Segura Puimedon has posted comments on this change.
Change subject: Network functional tests assertion improvements
..
Patch Set 1:
(1 comment)
File tests/functional/networkTests.py
Line 234: {},
Line 235: {BONDING_NAME: {'remove': True}},
{'connectivityCheck': False})
Line 236: self.assertEqual(status, SUCCESS, msg)
Line 237:
Line 238: def assertNetworkExists(self, networkName, bridged=None):
In fact my original code was the new asserts in networkTests. But since we
originally didn't want this module to access self.vdsm_net.netinfo nor config I
moved it there.
This method is not used and it is a glitch of my git cherry-picking.
Line 239: self.assert_(networkName in self.vdsm_net.netinfo.networks)
Line 240: if bridged:
Line 241: self.assertEqual(
Line 242: bridged,
--
To view, visit http://gerrit.ovirt.org/20123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network functional tests assertion improvements
Dan Kenigsberg has posted comments on this change. Change subject: Network functional tests assertion improvements .. Patch Set 2: Code-Review+1 (2 comments) Commit Message Line 6: Line 7: Network functional tests assertion improvements Line 8: Line 9: This change allows for more fine grained assertion errors. It allows Line 10: , among other things, to differentiate if what failed is making a English style: no leading comma please. Line 11: net or putting it into the running configuration. Line 12: Line 13: Change-Id: Icca9a552272818039bc677c6adebfed3d5664454 File tests/functional/networkTests.py Line 146: Line 147: def assertNetworkExists(self, networkName, bridged=None): Line 148: netinfo = self.vdsm_net.netinfo Line 149: config = self.vdsm_net.config Line 150: self.assertTrue(networkName in netinfo.networks) using assertIn() (after pulling it to python 2.6) would provide clearer outputs in case of assertion. Ancient Ruth had it. Line 151: if bridged is not None: Line 152: self.assertEqual(bridged, netinfo.networks[networkName]['bridged']) Line 153: if config is not None: Line 154: self.assertTrue(networkName in config.networks) -- To view, visit http://gerrit.ovirt.org/20123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network functional tests assertion improvements
Antoni Segura Puimedon has posted comments on this change. Change subject: Network functional tests assertion improvements .. Patch Set 2: (1 comment) File tests/functional/networkTests.py Line 146: Line 147: def assertNetworkExists(self, networkName, bridged=None): Line 148: netinfo = self.vdsm_net.netinfo Line 149: config = self.vdsm_net.config Line 150: self.assertTrue(networkName in netinfo.networks) Yeah. I had assertIn until I figured it wasn't on 2.7. I guess I could backport it to testrunner. Line 151: if bridged is not None: Line 152: self.assertEqual(bridged, netinfo.networks[networkName]['bridged']) Line 153: if config is not None: Line 154: self.assertTrue(networkName in config.networks) -- To view, visit http://gerrit.ovirt.org/20123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP vdsStats: return HA agent score when applicable
Greg Padgett has uploaded a new change for review.
Change subject: WIP vdsStats: return HA agent score when applicable
..
WIP vdsStats: return HA agent score when applicable
When the Hosted Engine HA Agent is installed, it can provide information
useful to the engine about the host's suitability to run the engine VM.
Provide this information to the engine through the vdsStats interface.
Change-Id: Ibdad8accb0660dbdcc8b6e1b83f491c2f89c2d30
Bug-Url: https://bugzilla.redhat.com/??
Signed-off-by: Greg Padgett gpadg...@redhat.com
---
M vdsm/API.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 28 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/20126/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 37bb908..8ca5a0b 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -48,6 +48,13 @@
import supervdsm
+try:
+import ovirt_hosted_engine_ha.client.client as ha_client
+ha_agent = True
+except ImportError:
+ha_agent = False
+
+
# default message for system shutdown, will be displayed in guest
USER_SHUTDOWN_MESSAGE = 'System going down'
@@ -1209,6 +1216,11 @@
stats['netConfigDirty'] = str(self._cif._netConfigDirty)
stats['generationID'] = self._cif._generationID
+
+haScore = self._getHaScore()
+if haScore is not False:
+stats['haScore'] = haScore
+
return {'status': doneCode, 'info': stats}
def setLogLevel(self, level):
@@ -1493,6 +1505,18 @@
self.log.error(vmId + ': Lost connection to VM')
return count, active, migrating
+def _getHaScore(self):
+
+Return the hosted engine HA score for this host,
+or False if unavailable.
+
+if ha_agent:
+try:
+return ha_client.HAClient().get_local_host_score()
+except:
+pass
+return False
+
@staticmethod
def translateNetOptionsToNew(options):
_translationMap = {
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index aae6c6e..47f7114 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -1613,6 +1613,9 @@
#
# @momStatus: The current status of the MOM policy engine
#
+# @haScore: #optional The host score according to the HA agent,
+# if installed
+#
# Since: 4.10.0
##
{'type': 'HostStats',
@@ -1630,7 +1633,7 @@
'vmCount': 'int', 'vmActive': 'int', 'vmMigrating': 'int',
'dateTime': 'str', 'ksmState': 'bool', 'ksmPages': 'int',
'ksmCpu': 'float', 'netConfigDirty': 'bool', 'generationID': 'UUID',
- 'momStatus': 'MOMStatus'}}
+ 'momStatus': 'MOMStatus', 'haScore': 'uint'}}
##
# @Host.getStats:
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdad8accb0660dbdcc8b6e1b83f491c2f89c2d30
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett gpadg...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network functional tests assertion improvements
oVirt Jenkins CI Server has posted comments on this change. Change subject: Network functional tests assertion improvements .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4941/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4055/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4865/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/685/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network functional tests assertion improvements
oVirt Jenkins CI Server has posted comments on this change. Change subject: Network functional tests assertion improvements .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4942/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4056/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4866/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/686/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP vdsStats: return HA agent score when applicable
Greg Padgett has posted comments on this change. Change subject: WIP vdsStats: return HA agent score when applicable .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/20126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdad8accb0660dbdcc8b6e1b83f491c2f89c2d30 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP vdsStats: return HA agent score when applicable
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP vdsStats: return HA agent score when applicable .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4943/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4057/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4867/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdad8accb0660dbdcc8b6e1b83f491c2f89c2d30 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network functional tests assertion improvements
oVirt Jenkins CI Server has posted comments on this change. Change subject: Network functional tests assertion improvements .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4944/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4058/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4868/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/688/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca9a552272818039bc677c6adebfed3d5664454 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
