Change in vdsm[master]: vdsm: fix RTC offset
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2264:
Line 2265: def _rtcUpdate(self, timeOffset):
Line 2266: self.log.debug('new rtc offset %s', timeOffset)
Line 2267: with self._confLock:
Line 2268: self.conf['timeOffset'] = self._initTimeRTC +
long(timeOffset)
my understanding is missed event doesn't matter, we always get the new offset
relative to VMs start
Line 2269:
Line 2270: def extendDriveVolume(self, vmDrive):
Line 2271: if not vmDrive.blockDev:
Line 2272: return
--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reduce the migration progress timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Reduce the migration progress timeout .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4710/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5510/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5589/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/16602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f314d70b8f32cfff58f9776bcc2182a748a9b67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reduce the migration progress timeout
Vinzenz Feenstra has posted comments on this change. Change subject: vdsm: Reduce the migration progress timeout .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/16602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f314d70b8f32cfff58f9776bcc2182a748a9b67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration cancellation replies wrong message format
Michal Skrivanek has posted comments on this change. Change subject: Migration cancellation replies wrong message format .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17a2463154e9f67191a818f137a4e7158a74dbbb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reduce the migration progress timeout
Michal Skrivanek has posted comments on this change. Change subject: vdsm: Reduce the migration progress timeout .. Patch Set 4: (1 comment) File vdsm/vm.py Line 747: if (smallest_dataRemaining is None or Line 748: smallest_dataRemaining dataRemaining): Line 749: smallest_dataRemaining = dataRemaining Line 750: lastProgressTime = time.time() Line 751: elif (time.time() - lastProgressTime) progress_timeout: what about migration_timeout now? Line 752: # Migration is stuck, abort Line 753: self._vm.log.warn( Line 754: 'Migration is stuck: Hasn\'t progressed in %s seconds. ' Line 755: 'Aborting.' % (time.time() - lastProgressTime)) -- To view, visit http://gerrit.ovirt.org/16602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f314d70b8f32cfff58f9776bcc2182a748a9b67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reduce the migration progress timeout
Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: Reduce the migration progress timeout
..
Patch Set 4:
(1 comment)
File vdsm/vm.py
Line 747: if (smallest_dataRemaining is None or
Line 748: smallest_dataRemaining dataRemaining):
Line 749: smallest_dataRemaining = dataRemaining
Line 750: lastProgressTime = time.time()
Line 751: elif (time.time() - lastProgressTime) progress_timeout:
It is still used here:
3472 elif 'migrationDest' in self.conf:
3473 timeout = config.getint('vars', 'migration_timeout')
3474 self.log.debug(Waiting %s seconds for end of migration %
timeout)
3475 self._incomingMigrationFinished.wait(timeout)
and here:
2404 def _migrationTimeout(self):
2405 timeout = config.getint('vars', 'migration_timeout')
2406 mem = int(self.conf['memSize'])
2407 if mem 2048:
2408 timeout = timeout * mem / 2048
2409 return timeout
Line 752: # Migration is stuck, abort
Line 753: self._vm.log.warn(
Line 754: 'Migration is stuck: Hasn\'t progressed in %s
seconds. '
Line 755: 'Aborting.' % (time.time() - lastProgressTime))
--
To view, visit http://gerrit.ovirt.org/16602
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f314d70b8f32cfff58f9776bcc2182a748a9b67
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
Dan Kenigsberg has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 4: (1 comment) File tests/netconfpersistenceTests.py Line 50: Line 51: persistence = Config(self.tempdir) Line 52: self.assertEqual(persistence.networks[NETWORK], NETWORK_ATTRIBUTES) Line 53: finally: Line 54: os.remove(filePath) in POSIX you can easily remove an open file. but rmFile is fine by me. Line 55: Line 56: def testSetAndRemoveNetwork(self): Line 57: persistence = Config(self.tempdir) Line 58: persistence.setNetwork(NETWORK, NETWORK_ATTRIBUTES) -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
Dan Kenigsberg has submitted this change and it was merged. Change subject: Add unit tests for unified network persistence .. Add unit tests for unified network persistence Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Signed-off-by: Assaf Muller amul...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21269 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/netconfpersistence.py M tests/Makefile.am A tests/netconfpersistenceTests.py 3 files changed, 83 insertions(+), 2 deletions(-) Approvals: Assaf Muller: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add unit tests for unified network persistence
Dan Kenigsberg has posted comments on this change. Change subject: Add unit tests for unified network persistence .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0221f2e0313a80d0ed5ce2d5406dc45f08ab26dd Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reduce the migration progress timeout
Michal Skrivanek has posted comments on this change. Change subject: vdsm: Reduce the migration progress timeout .. Patch Set 4: (1 comment) File vdsm/vm.py Line 747: if (smallest_dataRemaining is None or Line 748: smallest_dataRemaining dataRemaining): Line 749: smallest_dataRemaining = dataRemaining Line 750: lastProgressTime = time.time() Line 751: elif (time.time() - lastProgressTime) progress_timeout: yeah…but it seems to me it's not really canceling the migration anywhere. Line 752: # Migration is stuck, abort Line 753: self._vm.log.warn( Line 754: 'Migration is stuck: Hasn\'t progressed in %s seconds. ' Line 755: 'Aborting.' % (time.time() - lastProgressTime)) -- To view, visit http://gerrit.ovirt.org/16602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f314d70b8f32cfff58f9776bcc2182a748a9b67 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration cancellation replies wrong message format
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Migration cancellation replies wrong message format
..
Migration cancellation replies wrong message format
The message currently returns:
{'status': {'message': 'Migration canceled',
'code': { 'status': { 'message': 'Migration not in progress',
'code': 47}}},
'progress': 1}
The content of code is wrong. This commit fixes it so the message will
look like this:
{'status': {'message': 'Migration canceled', 'code': 47}, 'progress': 1}
Change-Id: I17a2463154e9f67191a818f137a4e7158a74dbbb
Bug-Url: https://bugzilla.redhat.com/1015887
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/21250
Reviewed-by: Michal Skrivanek michal.skriva...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Vinzenz Feenstra: Verified
Dan Kenigsberg: Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/21250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17a2463154e9f67191a818f137a4e7158a74dbbb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration cancellation replies wrong message format
Dan Kenigsberg has posted comments on this change. Change subject: Migration cancellation replies wrong message format .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17a2463154e9f67191a818f137a4e7158a74dbbb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow setting just a single value in MoM policy
Doron Fediuck has posted comments on this change. Change subject: Allow setting just a single value in MoM policy .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Amador Pahim ama...@pahim.org Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prepareVolumePath correct path handling for cdrom
Martin Polednik has posted comments on this change. Change subject: vdsm: prepareVolumePath correct path handling for cdrom .. Patch Set 5: Verified+1 cdrom path is always passed in specParams when starting VM from template with cd attached (therefore it is still needed and should be fixed in engine) -- To view, visit http://gerrit.ovirt.org/20074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e5e0c12e7cc37a692c0e5c47eed3e4c8e7cda9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make ip link wrapper hidden config be at class lvl
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Make ip link wrapper hidden config be at class lvl
..
Make ip link wrapper hidden config be at class lvl
Before this patch we got the config for each device that needed it.
This allowed each device to pick up changes in the config that
could have happened between each device object creation, at the
cost of speed and simplicity. Since config is supposed to be
stable during the life of a vdsm process, this was moved to the class
level.
Change-Id: I43e484c2e2614b1d9bbd67468e3eb050d55d32f6
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/ipwrapper.py
1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/21407/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index 2210897..9919d45 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -72,6 +72,10 @@
@equals
class Link(object):
Represents link information obtained from iproute2
+_fakeNics = config.get('vars', 'fake_nics').split(',')
+_hiddenNics = config.get('vars', 'hidden_nics').split(',')
+_hiddenVlans = config.get('vars', 'hidden_vlans').split(',')
+
def __init__(self, address, index, linkType, mtu, name, qdisc, state,
vlanid=None, vlanprotocol=None, master=None, **kwargs):
self.address = address
@@ -88,13 +92,6 @@
self.vlanprotocol = vlanprotocol
for key, value in kwargs.items():
setattr(self, key, value)
-if linkType == LinkType.DUMMY:
-self._fakeNics = config.get('vars', 'fake_nics').split(',')
-self._hiddenNics = config.get('vars', 'hidden_nics').split(',')
-if linkType == LinkType.NIC:
-self._hiddenNics = config.get('vars', 'hidden_nics').split(',')
-if linkType == LinkType.VLAN:
-self._hiddenVlans = config.get('vars', 'hidden_vlans').split(',')
def __repr__(self):
return '%s: %s(%s) %s' % (self.index, self.name, self.type,
--
To view, visit http://gerrit.ovirt.org/21407
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43e484c2e2614b1d9bbd67468e3eb050d55d32f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make ip link wrapper hidden config be at class lvl
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make ip link wrapper hidden config be at class lvl .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4711/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5511/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/819/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5590/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43e484c2e2614b1d9bbd67468e3eb050d55d32f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change mom policy related interface to support multi-policy
Itamar Heim has posted comments on this change. Change subject: Change mom policy related interface to support multi-policy .. Patch Set 14: ping -- To view, visit http://gerrit.ovirt.org/12466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09c40fee74b10d3eb41f4ec3ca18096a9b20dfcd Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp .. Patch Set 10: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4712/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5512/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/820/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5591/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9dbb59f3cd420b2071eb0ec42f9816ab52151bce Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Benas pbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Petr Benas pbe...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: check the syntaxs of optional parameters in json schema
Itamar Heim has posted comments on this change. Change subject: check the syntaxs of optional parameters in json schema .. Patch Set 2: ping -- To view, visit http://gerrit.ovirt.org/10446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94f92459ee8787780a54a510b6f8cc074fb2a235 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmDevices: introduce VmDeviceContainer
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmDevices: introduce VmDeviceContainer .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4713/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5513/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5592/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65debd35115da078df0c0cb6f50c57feb984c5a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dump the core of a VM
Itamar Heim has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 14: ping -- To view, visit http://gerrit.ovirt.org/7329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: provide IPv6 configuration editing API
Itamar Heim has posted comments on this change. Change subject: configNetwork: provide IPv6 configuration editing API .. Patch Set 1: ping -- To view, visit http://gerrit.ovirt.org/11741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf39d8cba75e8879a84e83e22a46a4a00eab1384 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add tuneBlockDevIo interface
Itamar Heim has posted comments on this change. Change subject: vdsm: Add tuneBlockDevIo interface .. Patch Set 14: ping -- To view, visit http://gerrit.ovirt.org/14394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb33510a081d221af0f69d4dd2d55adf0b79efd2 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: storage: Introduce Image.removeAsBlockDevice vdsm verb
Itamar Heim has posted comments on this change. Change subject: WIP: storage: Introduce Image.removeAsBlockDevice vdsm verb .. Patch Set 8: ping -- To view, visit http://gerrit.ovirt.org/14919 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d8823c394f1a0fcae28bb8aecf9c50d0c6d2f98 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sharad Mishra snmis...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: get the status of core dump
Itamar Heim has posted comments on this change. Change subject: get the status of core dump .. Patch Set 8: ping -- To view, visit http://gerrit.ovirt.org/11131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d552db4dbd88762950ec5a113a25c13b73319c8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: storage: Introduce Image.exportAsBlockDevice vdsm verb
Itamar Heim has posted comments on this change. Change subject: WIP: storage: Introduce Image.exportAsBlockDevice vdsm verb .. Patch Set 10: ping -- To view, visit http://gerrit.ovirt.org/14403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ccacda2b09810a71f445ed65de6a09336ea3fb1 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sharad Mishra snmis...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: cancel the core dump of a VM
Itamar Heim has posted comments on this change. Change subject: cancel the core dump of a VM .. Patch Set 9: ping -- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fa9e82cfbd43c9edb98fac9af41eb0deb0c67ad Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: provide IPv6 configuration editing API
Petr Šebek has posted comments on this change. Change subject: configNetwork: provide IPv6 configuration editing API .. Patch Set 1: I believe that this should be abandoned since this patch http://gerrit.ovirt.org/#/c/18284/ is merged. -- To view, visit http://gerrit.ovirt.org/11741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf39d8cba75e8879a84e83e22a46a4a00eab1384 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow setting just a single value in MoM policy
Dan Kenigsberg has posted comments on this change. Change subject: Allow setting just a single value in MoM policy .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Amador Pahim ama...@pahim.org Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow setting just a single value in MoM policy
Dan Kenigsberg has submitted this change and it was merged. Change subject: Allow setting just a single value in MoM policy .. Allow setting just a single value in MoM policy This patch prevents a policy coruption that could have happened when the 01-parameters policy was updated with just a single value. If there were more values defined, the variables were lost and the policy ended up broken. This patch defines the variables in a file that is not touched by the setMOMPolicyParameters and uses (set name value) syntax in the generated policy part. It also remembers the old setting and puts all the values to the policy part when it is autogenerated. Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Signed-off-by: Martin Sivak msi...@redhat.com Reviewed-on: http://gerrit.ovirt.org/21225 Reviewed-by: Amador Pahim apa...@redhat.com Reviewed-by: Doron Fediuck dfedi...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm.install M vdsm/Makefile.am A vdsm/mom.d/00-defines.policy D vdsm/mom.d/00-python.policy M vdsm/mom.d/01-parameters.policy M vdsm/momIF.py 6 files changed, 17 insertions(+), 11 deletions(-) Approvals: Martin Sivák: Verified Doron Fediuck: Looks good to me, but someone else must approve Amador Pahim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bb1001a05e670e393b2cc0ab4b271b3b333d2e8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Amador Pahim ama...@pahim.org Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: wait until lvm bootstrap is done before connecting to pool
Ayal Baron has posted comments on this change. Change subject: hsm: wait until lvm bootstrap is done before connecting to pool .. Patch Set 1: what scenarios have you tested? engine has a 3 minute timeout for connectStoragePool. If the combined time of connectStoragePool and waiting for bootstrap to finish is bigger than that then connect would fail. how long does it take when you have a VG with 1000 LVs on it? -- To view, visit http://gerrit.ovirt.org/21388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22e851dca4c2063d19446f34897a7b208b9cace4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make ip link wrapper hidden config be at class lvl
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make ip link wrapper hidden config be at class lvl .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4714/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5514/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/821/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5593/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43e484c2e2614b1d9bbd67468e3eb050d55d32f6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improvements from using Link devices
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netinfo: improvements from using Link devices
..
netinfo: improvements from using Link devices
Make use of the new linkwrapper features to simplify netinfo code.
Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/ipwrapper.py
M lib/vdsm/netinfo.py
M tests/netinfoTests.py
3 files changed, 79 insertions(+), 115 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/21408/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index ebfda41..69be2aa 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -37,6 +37,7 @@
'/sbin/ethtool', # EL6, ubuntu and Debian
'/usr/bin/ethtool', # Arch
)
+NET_PATH = '/sys/class/net'
def _isValid(ip, verifier):
@@ -74,6 +75,7 @@
class Link(object):
Represents link information obtained from iproute2
_fakeNics = config.get('vars', 'fake_nics').split(',')
+_hiddenBonds = config.get('vars', 'hidden_bonds').split(',')
_hiddenNics = config.get('vars', 'hidden_nics').split(',')
_hiddenVlans = config.get('vars', 'hidden_vlans').split(',')
@@ -149,7 +151,7 @@
detectedType = None
rc, out, _ = execCmd([_ETHTOOL_BINARY.cmd, '-i', name])
if rc == 71: # Unkown driver, usually dummy or loopback
-if not os.path.exists('/sys/class/net/' + name):
+if not os.path.exists(os.path.join(NET_PATH, name)):
raise ValueError('Device %s does not exist' % name)
if name == 'lo':
detectedType = LinkType.LOOPBACK
@@ -178,6 +180,12 @@
detectedType = LinkType.NIC
return detectedType
+def isBOND(self):
+return self.type == LinkType.BOND
+
+def isBRIDGE(self):
+return self.type == LinkType.BRIDGE
+
def isDUMMY(self):
return self.type == LinkType.DUMMY
@@ -204,9 +212,16 @@
if self.isVLAN():
return anyFnmatch(self.name, self._hiddenVlans)
elif self.isDUMMY() or self.isVETH() or self.isNIC():
-return anyFnmatch(self.name, self._hiddenNics)
-else:
-raise NotImplementedError
+return (anyFnmatch(self.name, self._hiddenNics) or
+(self.master and _bondExists(self.master) and
+ anyFnmatch(self.master, self._hiddenBonds)))
+elif self.isBOND():
+return anyFnmatch(self.name, self._hiddenBonds)
+return False
+
+
+def _bondExists(bondName):
+return os.path.exists(os.path.join(NET_PATH, bondName, 'bonding'))
def getLinks():
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index dd54a96..39b2d84 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -34,6 +34,7 @@
from .config import config
from . import constants
from .ipwrapper import getLink, getLinks
+from .ipwrapper import NET_PATH
from .ipwrapper import Route
from .ipwrapper import routeShowAllDefaultGateways
from . import libvirtconnection
@@ -49,7 +50,6 @@
NET_CONF_PREF = NET_CONF_DIR + 'ifcfg-'
PROC_NET_VLAN = '/proc/net/vlan/'
-NET_PATH = '/sys/class/net'
BONDING_MASTERS = '/sys/class/net/bonding_masters'
BONDING_SLAVES = '/sys/class/net/%s/bonding/slaves'
BONDING_OPT = '/sys/class/net/%s/bonding/%s'
@@ -67,42 +67,11 @@
OPERSTATE_UP = 'up'
-def _nic_devices():
-
-Returns an iterable of nic devices real or fakes, available on the host.
-
-deviceLinks = getLinks()
-for device in deviceLinks:
-if device.isNIC() or device.isFakeNIC():
-yield device
-
-
def nics():
-
-Returns a list of nics devices available to be used by vdsm.
-The list of nics is built by filtering out nics defined
-as hidden, fake or hidden bonds (with related nics'slaves).
-
-def isEnslavedByHiddenBond(device):
-
-Returns boolean stating if a nic device is enslaved to an hidden bond.
-
-hidden_bonds = config.get('vars', 'hidden_bonds').split(',')
-valid_bonds_fn = (bond_fn for bond_fn in hidden_bonds if bond_fn)
-
-for bond_fn in valid_bonds_fn:
-for bond_path in iglob(NET_PATH + '/' + bond_fn):
-bond = os.path.basename(bond_path)
-if device in slaves(bond):
-return True
-return False
-
-def isManagedByVdsm(device):
-Returns boolean stating if a device should be managed by vdsm.
-return (not device.isHidden() and
-not isEnslavedByHiddenBond(device.name))
-
-res = [dev.name for dev in _nic_devices() if isManagedByVdsm(dev)]
+Returns a list of nics and fake nics devices available (not hidden) to
+be used by vdsm.
+res = [dev.name for dev in getLinks() if
Change in vdsm[master]: netinfo: improvements from using Link devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: improvements from using Link devices .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4715/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5515/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/822/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5594/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: improvements from using Link devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: improvements from using Link devices .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4715/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5515/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/822/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5595/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a51c0d3bcec1358521846238e0cbd4c13ae1d17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configNetwork: provide IPv6 configuration editing API
Dan Kenigsberg has abandoned this change. Change subject: configNetwork: provide IPv6 configuration editing API .. Abandoned Hunt Xu, thanks a lot for this initiative! Now we should extend it to the Engine! -- To view, visit http://gerrit.ovirt.org/11741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibf39d8cba75e8879a84e83e22a46a4a00eab1384 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Petr Šebek pse...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration cancellation on timeout
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Migration cancellation on timeout
..
Migration cancellation on timeout
During migrations the configured value of migration_timeout is not honoured
in the sense that we are not aborting the migration if it takes longer
than the configured value of conf.migration_timeout
Bug-Url: https://bugzilla.redhat.com/970645
Change-Id: Ieb8fc80f0e592e20db7408615bcb95786f5e23b8
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
---
M vdsm/vm.py
1 file changed, 16 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/21409/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index e4dd392..268021a 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -733,9 +733,11 @@
self._vm.log.debug('starting migration monitor thread')
-lastProgressTime = time.time()
+startTime = time.time()
+lastProgressTime = startTime
smallest_dataRemaining = None
progress_timeout = config.getint('vars', 'migration_progress_timeout')
+migration_timeout = config.getint('vars', 'migration_timeout')
while not self._stop.isSet():
self._stop.wait(self._MIGRATION_MONITOR_INTERVAL)
@@ -744,15 +746,26 @@
memTotal, memProcessed, memRemaining,
fileTotal, fileProcessed, _) = self._vm._dom.jobInfo()
+now = time.time()
+abort = False
if (smallest_dataRemaining is None or
smallest_dataRemaining dataRemaining):
smallest_dataRemaining = dataRemaining
-lastProgressTime = time.time()
+lastProgressTime = now
elif (time.time() - lastProgressTime) progress_timeout:
# Migration is stuck, abort
self._vm.log.warn(
'Migration is stuck: Hasn\'t progressed in %s seconds. '
-'Aborting.' % (time.time() - lastProgressTime))
+'Aborting.' % (now - lastProgressTime))
+abort = True
+elif now - startTime migration_timeout:
+self._vm.log.warn(
+'The migration took already %s seconds which is longer '
+'than the configured migration_timeout value (%s seconds).'
+' Aborting.', now - lastProgressTime, migration_timeout)
+abort = True
+
+if abort:
self._vm._dom.abortJob()
self.stop()
break
--
To view, visit http://gerrit.ovirt.org/21409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb8fc80f0e592e20db7408615bcb95786f5e23b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Migration cancellation on timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: Migration cancellation on timeout .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4716/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5596/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb8fc80f0e592e20db7408615bcb95786f5e23b8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix ipwrapper Monitor for deleted links and oneline input
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Fix ipwrapper Monitor for deleted links and oneline input
..
Fix ipwrapper Monitor for deleted links and oneline input
The previous parsing would not work when a link was deleted. This
patch fixes it and sets the state as DELETED on those cases. It
also changes the ip monitor command to use the more machine readable
ip -d -o monitor link (one line per link event).
Change-Id: I1c593467d328c39654eae723126f889b51ff39d2
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/ipwrapper.py
M tests/ipwrapperTests.py
2 files changed, 32 insertions(+), 17 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/21411/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index 69be2aa..85cd919 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -527,34 +527,42 @@
MonitorEvent = namedtuple('MonitorEvent', ['device', 'flags', 'state'])
-class Monitor():
+class Monitor(object):
Minimal wrapper over `ip monitor link`
def __init__(self):
self.proc = None
def start(self):
-self.proc = execCmd([_IP_BINARY.cmd, 'monitor', 'link'], sync=False)
+self.proc = execCmd([_IP_BINARY.cmd, 'monitor', '-d', '-o', 'link'],
+sync=False)
def stop(self):
self.proc.kill()
@classmethod
def _parse(cls, text):
+deletionText = 'Deleted'
changes = []
for line in text.splitlines():
-if line.startswith(' '):
-continue
+state = None
+if line.startswith(deletionText):
+state = deletionText.upper()
+line = line[len(deletionText):]
-tokens = line.split()
-if not tokens[1].endswith(':'):
-continue
+_, device, data = [el.strip() for el in line.split(':', 2)]
+flagVal, _ = data.split('\\', 1) # We don't parse link/ether
-device = tokens[1][:-1]
-flags = frozenset(tokens[2][1:-1].split(','))
-values = dict(tokens[i:i + 2] for i in range(3, len(tokens), 2))
+flags, values = data.split('')
+flags = frozenset(flags[1:].split(','))
+if state is None:
+values = (el for el in values.strip().split(' ') if el)
+for key, value in pairwise(values):
+if key == 'state':
+state = value
+break
-changes.append(MonitorEvent(device, flags, values.get('state')))
+changes.append(MonitorEvent(device, flags, state))
return changes
diff --git a/tests/ipwrapperTests.py b/tests/ipwrapperTests.py
index fb6bc02..d85deb3 100644
--- a/tests/ipwrapperTests.py
+++ b/tests/ipwrapperTests.py
@@ -190,11 +190,14 @@
self.assertRaises(ValueError, Rule.fromText, text)
def testMonitorEvents(self):
-out = (273: bond0: BROADCAST,MULTICAST,MASTER
- mtu 1500 qdisc noqueue state DOWN \n
- link/ether 33:44:55:66:77:88 brd ff:ff:ff:ff:ff:ff \n
- 4: wlp3s0: BROADCAST,MULTICAST,UP,LOWER_UP \n
- link/ether \n)
+out = ('273: bond0: BROADCAST,MULTICAST,MASTER mtu 1500 qdisc '
+ 'noqueue state DOWN \\link/ether 33:44:55:66:77:88 brd '
+ 'ff:ff:ff:ff:ff:ff \n'
+ '4: wlp3s0: BROADCAST,MULTICAST,UP,LOWER_UP \\'
+ 'link/ether \n'
+ 'Deleted 418: foo: BROADCAST,MULTICAST mtu 1500 qdisc noop '
+ 'state DOWN group default \\link/ether ba:2c:7b:68:b8:77 '
+ 'brd ff:ff:ff:ff:ff:ff\n')
expected = [
MonitorEvent(
'bond0',
@@ -203,6 +206,10 @@
MonitorEvent(
'wlp3s0',
frozenset(['BROADCAST', 'MULTICAST', 'UP', 'LOWER_UP']),
-None)]
+None),
+MonitorEvent(
+'foo',
+frozenset(['BROADCAST', 'MULTICAST']),
+'DELETED')]
self.assertEqual(Monitor._parse(out), expected)
--
To view, visit http://gerrit.ovirt.org/21411
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c593467d328c39654eae723126f889b51ff39d2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix ipwrapper Monitor for deleted links and oneline input
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix ipwrapper Monitor for deleted links and oneline input .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4717/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5517/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/823/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5597/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c593467d328c39654eae723126f889b51ff39d2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix ipwrapper Monitor for deleted links and oneline input
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix ipwrapper Monitor for deleted links and oneline input .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4718/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5518/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/824/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5598/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c593467d328c39654eae723126f889b51ff39d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: improve extension check in extendDrivesIfNeeded
Federico Simoncelli has uploaded a new change for review.
Change subject: vm: improve extension check in extendDrivesIfNeeded
..
vm: improve extension check in extendDrivesIfNeeded
Change-Id: Ide5034cd5d87451c06a2ba034011fdf5696440e6
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
M vdsm/vm.py
1 file changed, 23 insertions(+), 25 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/21423/1
diff --git a/vdsm/vm.py b/vdsm/vm.py
index e82867c..192f632 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -78,6 +78,9 @@
CONSOLE_DEVICES = 'console'
SMARTCARD_DEVICES = 'smartcard'
+# qcow2 format overhead is estimated to be 10% of capacity
+QCOW2_OVERHEAD = 0.1
+
def isVdsmImage(drive):
return all(k in drive.keys() for k in ('volumeID', 'domainID', 'imageID',
@@ -2288,46 +2291,41 @@
if not drive.blockDev or drive.format != 'cow':
continue
-capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
+capacity, curAlloc, physical = self._dom.blockInfo(drive.path, 0)
-# Since the check based on nextPhysSize is extremly risky (it
-# may result in the VM being paused) we can't use the regular
-# getNextVolumeSize call as it relies on a cached value of the
-# drive apparentsize.
-nextPhysSize = physical + drive.VOLWM_CHUNK_MB * constants.MEGAB
+if physical - curAlloc drive.watermarkLimit:
+continue # Extension is not needed
+
+# When an extension is needed we compute the maxium allowed size
+# taking in account the qcow2 format overhead and rounding it up
+# to the next volume chunk.
+extChunkBytes = drive.VOLWM_CHUNK_MB * constants.MEGAB
+totAlloc = capacity * (1.0 + QCOW2_OVERHEAD)
+maxAlloc = (
+int((totAlloc + extChunkBytes - 1) / extChunkBytes) *
+extChunkBytes
+)
# NOTE: the intent of this check is to prevent faulty images to
# trick qemu in requesting extremely large extensions (BZ#998443).
-# Probably the definitive check would be comparing the allocated
-# space with capacity + format_overhead. Anyway given that:
-#
-# - format_overhead is tricky to be computed (it depends on few
-# assumptions that may change in the future e.g. cluster size)
-# - currently we allow only to extend by one chunk at time
-#
-# the current check compares alloc with the next volume size.
-# It should be noted that alloc cannot be directly compared with
-# the volume physical size as it includes also the clusters not
-# written yet (pending).
-if alloc nextPhysSize:
+if curAlloc maxAlloc:
self.log.error(
Improbable extension request for volume %s on domain
%s, pausing the VM to avoid corruptions (capacity: %s,
-allocated: %s, physical: %s, next physical size: %s),
-drive.volumeID, drive.domainID, capacity, alloc,
-physical, nextPhysSize)
+allocated: %s, physical: %s, max allocation: %s),
+drive.volumeID, drive.domainID, capacity, curAlloc,
+physical, maxAlloc)
self.pause(pauseCode='EOTHER')
return False
-if physical - alloc drive.watermarkLimit:
-extend.append((drive, capacity, alloc, physical))
+extend.append((drive, capacity, curAlloc, physical))
-for drive, capacity, alloc, physical in extend:
+for drive, capacity, curAlloc, physical in extend:
self.log.info(
Requesting extension for volume %s on domain %s (apparent:
%s, capacity: %s, allocated: %s, physical: %s),
drive.volumeID, drive.domainID, drive.apparentsize, capacity,
-alloc, physical)
+curAlloc, physical)
self.extendDriveVolume(drive)
return len(extend) 0
--
To view, visit http://gerrit.ovirt.org/21423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide5034cd5d87451c06a2ba034011fdf5696440e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: improve extension check in extendDrivesIfNeeded
Federico Simoncelli has posted comments on this change. Change subject: vm: improve extension check in extendDrivesIfNeeded .. Patch Set 1: (1 comment) File vdsm/vm.py Line 2307: ) Line 2308: Line 2309: # NOTE: the intent of this check is to prevent faulty images to Line 2310: # trick qemu in requesting extremely large extensions (BZ#998443). Line 2311: if curAlloc maxAlloc: We're blocked on the fact that maxAlloc might be much higher if we have leaked clusters. Line 2312: self.log.error( Line 2313: Improbable extension request for volume %s on domain Line 2314: %s, pausing the VM to avoid corruptions (capacity: %s, Line 2315: allocated: %s, physical: %s, max allocation: %s), -- To view, visit http://gerrit.ovirt.org/21423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide5034cd5d87451c06a2ba034011fdf5696440e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: [wip] receive domains map in connectStoragePool
Federico Simoncelli has uploaded a new change for review.
Change subject: sp: [wip] receive domains map in connectStoragePool
..
sp: [wip] receive domains map in connectStoragePool
Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
4 files changed, 243 insertions(+), 135 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/21427/1
diff --git a/vdsm/API.py b/vdsm/API.py
index f91910c..90ba002 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -958,9 +958,12 @@
APIBase.__init__(self)
self._UUID = UUID
-def connect(self, hostID, scsiKey, masterSdUUID, masterVersion):
-return self._irs.connectStoragePool(self._UUID, hostID, scsiKey,
-masterSdUUID, masterVersion)
+# FIXME: WIP patch, requires backward compatibility considerations
+def connect(self, hostID, scsiKey, masterSdUUID, masterVersion,
+domainsMap):
+return self._irs.connectStoragePool(
+self._UUID, hostID, scsiKey, masterSdUUID, masterVersion,
+domainsMap)
def connectStorageServer(self, domainType, connectionParams):
return self._irs.connectStorageServer(domainType, self._UUID,
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index dd82b05..a1c8817 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -542,10 +542,12 @@
image = API.Image(imgUUID, spUUID, sdUUID)
return image.download(methodArgs, volUUID)
+# FIXME: WIP patch, requires backward compatibility considerations
def poolConnect(self, spUUID, hostID, scsiKey, msdUUID, masterVersion,
-options=None):
+domainsMap=None, options=None):
pool = API.StoragePool(spUUID)
-return pool.connect(hostID, scsiKey, msdUUID, masterVersion)
+return pool.connect(hostID, scsiKey, msdUUID, masterVersion,
+domainsMap)
def poolConnectStorageServer(self, domType, spUUID, conList, options=None):
pool = API.StoragePool(spUUID)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 3707528..56b24b4 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -981,8 +981,8 @@
poolName, masterDom, domList, masterVersion, leaseParams)
@public
-def connectStoragePool(self, spUUID, hostID, scsiKey,
- msdUUID, masterVersion, options=None):
+def connectStoragePool(self, spUUID, hostID, scsiKey, msdUUID,
+ masterVersion, domainsMap=None, options=None):
Connect a Host to a specific storage pool.
@@ -1010,11 +1010,12 @@
hostID, scsiKey)))
with rmanager.acquireResource(STORAGE, HSM_DOM_MON_LOCK,
rm.LockType.exclusive):
-return self._connectStoragePool(spUUID, hostID, scsiKey, msdUUID,
-masterVersion, options)
+return self._connectStoragePool(
+spUUID, hostID, scsiKey, msdUUID, masterVersion,
+domainsMap, options)
def _connectStoragePool(self, spUUID, hostID, scsiKey, msdUUID,
-masterVersion, options=None):
+masterVersion, domainsMap=None, options=None):
misc.validateUUID(spUUID, 'spUUID')
# TBD: To support multiple pool connection on single host,
@@ -1055,7 +1056,13 @@
masterVersion=masterVersion)
return
-pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng)
+if domainsMap is not None:
+pool = sp.StoragePool(spUUID, self.domainMonitor,
+ self.taskMng, domainsMap, masterVersion)
+else:
+pool = sp.StoragePoolLegacy(
+spUUID, self.domainMonitor, self.taskMng)
+
res = pool.connect(hostID, scsiKey, msdUUID, masterVersion)
if res:
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 46e8224..638891f 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -38,6 +38,7 @@
import fileSD
import sd
import misc
+from misc import deprecated
import fileUtils
from vdsm.config import config
from sdc import sdCache
@@ -101,7 +102,7 @@
MAX_DOMAINS /= 48
-class StoragePool(Securable):
+class StoragePoolBase(Securable):
'''
StoragePool object should be relatively cheap to construct. It should defer
any heavy lifting activities until the time it is really needed.
@@ -113,7 +114,7 @@
lvExtendPolicy = config.get('irs', 'vol_extend_policy')
def __init__(self, spUUID, domainMonitor, taskManager):
-
Change in vdsm[master]: sd: [wip] add getClusterLockOwnerId method
Federico Simoncelli has uploaded a new change for review. Change subject: sd: [wip] add getClusterLockOwnerId method .. sd: [wip] add getClusterLockOwnerId method Change-Id: I10e64d74319ea6591a7edf8e17809d367a758386 Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/clusterlock.py M vdsm/storage/sd.py 2 files changed, 27 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/21426/1 diff --git a/vdsm/storage/clusterlock.py b/vdsm/storage/clusterlock.py index 6e4d8d6..d0da854 100644 --- a/vdsm/storage/clusterlock.py +++ b/vdsm/storage/clusterlock.py @@ -112,6 +112,9 @@ raise se.AcquireLockFailure(self._sdUUID, rc, out, err) self.log.debug(Clustered lock acquired successfully) +def getOwnerId(self): +pass # FIXME: missing implementation + def getLockUtilFullPath(self): return os.path.join(self.lockUtilPath, self.lockCmd) @@ -167,6 +170,9 @@ def getReservedId(self): return MAX_HOST_ID + +def getLockDisk(self): +return [(self._leasesPath, SDM_LEASE_OFFSET)] def acquireHostId(self, hostId, async): with self._lock: @@ -235,7 +241,7 @@ try: sanlock.acquire(self._sdUUID, SDM_LEASE_NAME, -[(self._leasesPath, SDM_LEASE_OFFSET)], +self.getLockDisk(), slkfd=SANLock._sanlock_fd) except sanlock.SanlockException as e: if e.errno != os.errno.EPIPE: @@ -250,14 +256,26 @@ self.log.debug(Cluster lock for domain %s successfully acquired (id: %s), self._sdUUID, hostId) +def getOwnerId(self): +owners = sanlock.read_resource_owners( +self._sdUUID, SDM_LEASE_NAME, self.getLockDisk()) + +if len(owners) == 1: +return owners[0].get(host_id) +elif len(owners) 1: +self.log.error(Cluster lock is reported to have more than + one owner: %s, owners) +raise RuntimeError(Cluster lock multiple owners error) + +return None + def release(self): with self._lock: self.log.info(Releasing cluster lock for domain %s, self._sdUUID) try: sanlock.release(self._sdUUID, SDM_LEASE_NAME, -[(self._leasesPath, SDM_LEASE_OFFSET)], -slkfd=SANLock._sanlock_fd) +self.getLockDisk(), slkfd=SANLock._sanlock_fd) except sanlock.SanlockException as e: raise se.ReleaseLockFailure(self._sdUUID, e) @@ -345,6 +363,9 @@ self.log.debug(Local lock for domain %s successfully acquired (id: %s), self._sdUUID, hostId) +def getOwnerId(self): +pass # FIXME: missing implementation + def release(self): with self._globalLockMapSync: self.log.info(Releasing local lock for domain %s, self._sdUUID) diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py index 3249343..03d3274 100644 --- a/vdsm/storage/sd.py +++ b/vdsm/storage/sd.py @@ -489,6 +489,9 @@ def releaseClusterLock(self): self._clusterLock.release() +def getClusterLockOwnerId(self): +self._clusterLock.getOwnerId() + def attach(self, spUUID): self.invalidateMetadata() pools = self.getPools() -- To view, visit http://gerrit.ovirt.org/21426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I10e64d74319ea6591a7edf8e17809d367a758386 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove the uploadVolume command
Federico Simoncelli has uploaded a new change for review.
Change subject: api: remove the uploadVolume command
..
api: remove the uploadVolume command
Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
M vdsm_api/vdsmapi-schema.json
6 files changed, 0 insertions(+), 140 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/21425/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 67ce3b7..d549500 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -989,19 +989,6 @@
return status['status']['code'], status['status']['message']
return 0, ''
-def uploadVolume(self, args):
-sdUUID = args[0]
-spUUID = args[1]
-imgUUID = args[2]
-volUUID = args[3]
-srcPath = args[4]
-size = args[5]
-status = self.s.uploadVolume(sdUUID, spUUID, imgUUID,
- volUUID, srcPath, size, *args[6:])
-if status['status']['code']:
-return status['status']['code'], status['status']['message']
-return 0, ''
-
def setVolumeDescription(self, args):
sdUUID = args[0]
spUUID = args[1]
@@ -2223,11 +2210,6 @@
'spUUID sdUUID imgUUID volUUID newSize',
'Extend the volume size (virtual disk size seen by the guest).',
)),
-'uploadVolume': (serv.uploadVolume,
- ('sdUUID spUUID imgUUID volUUID srcPath '
- 'size',
- 'Upload volume file into existing volume'
- )),
'getVolumePath': (serv.getVolumePath,
('sdUUID spUUID imgUUID volume uuid',
'Returns the path to the requested uuid'
diff --git a/vdsm/API.py b/vdsm/API.py
index c799090..f91910c 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -947,10 +947,6 @@
def setDescription(self, description):
return self._irs.setStorageDomainDescription(self._UUID, description)
-def uploadVolume(self, spUUID, imgUUID, volUUID, srcPath, size, method):
-return self._irs.uploadVolume(self._UUID, spUUID, imgUUID, volUUID,
- srcPath, size, method)
-
def validate(self):
return self._irs.validateStorageDomain(self._UUID)
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index fcd3221..dd82b05 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -502,12 +502,6 @@
domain = API.StorageDomain(sdUUID)
return domain.setDescription(description)
-def domainUploadVolume(self, sdUUID, spUUID, imgUUID, volUUID,
- srcPath, size, method=rsync, options=None):
-domain = API.StorageDomain(sdUUID)
-return domain.uploadVolume(spUUID, imgUUID, volUUID, srcPath, size,
- method)
-
def domainValidate(self, sdUUID, options=None):
domain = API.StorageDomain(sdUUID)
return domain.validate()
@@ -884,7 +878,6 @@
(self.domainGetStats, 'getStorageDomainStats'),
(self.domainGetVolumes, 'getVolumesList'),
(self.domainSetDescription, 'setStorageDomainDescription'),
-(self.domainUploadVolume, 'uploadVolume'),
(self.domainValidate, 'validateStorageDomain'),
(self.imageDelete, 'deleteImage'),
(self.imageDeleteVolumes, 'deleteVolume'),
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 68bb4ca..3707528 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1411,34 +1411,6 @@
return dict(vmlist=vms)
@public
-def uploadVolume(self, sdUUID, spUUID, imgUUID, volUUID, srcPath, size,
- method=rsync, options=None):
-
-Uploads a volume to the server. (NFS only?)
-
-:param spUUID: The UUID of the storage pool that will contain the
- new volume.
-:type spUUID: UUID
-:param sdUUID: The UUID of the backup domain that will contain the
- new volume.
-:type sdUUID: UUID
-:param imgUUID: The UUID of image you want associated with that volume.
-:type imgUUID: UUID
-:param volUUID: The UUID that the new volume will have after upload.
-:type volUUID: UUID
-:param size: The size of the volume being uploaded in ...?
-:type size: ?
-:param method: The desired method of upload. Currently only *'wget'*
- and *'rsync'* are supported.
-:type method: str
-:param options: ?
-
-vars.task.getSharedLock(STORAGE, spUUID)
-pool = self.getPool(spUUID)
-
Change in vdsm[master]: sp: move reconnection info check to StoragePool
Federico Simoncelli has uploaded a new change for review. Change subject: sp: move reconnection info check to StoragePool .. sp: move reconnection info check to StoragePool The entire reconnection info logic belongs to the StoragePool class. Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/hsm.py M vdsm/storage/sp.py 2 files changed, 11 insertions(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/21424/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index 5e53f3a..68bb4ca 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1056,9 +1056,8 @@ return pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng) -if not hostID or not scsiKey or not msdUUID or not masterVersion: -hostID, scsiKey, msdUUID, masterVersion = pool.getPoolParams() res = pool.connect(hostID, scsiKey, msdUUID, masterVersion) + if res: self.pools[spUUID] = pool for callback in self.domainStateChangeCallbacks: diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 0e23e1d..bf49b79 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -677,6 +677,12 @@ domain: %s (ver = %s) % (hostID, self.spUUID, msdUUID, masterVersion)) +if not hostID or not scsiKey or not msdUUID or not masterVersion: +hostID, scsiKey, msdUUID, masterVersion = self.getPoolParams() +self.log.info(Using saved connection parameters: hostID=%s + scsiKey=%s, msdUUID=%s, masterVersion=%s, + hostID, scsiKey, msdUUID, masterVersion) + if not os.path.exists(self._poolsTmpDir): msg = (StoragePoolConnectionError for hostId: %s, on poolId: %s, Pools temp data dir: %s does not exist % @@ -732,21 +738,10 @@ @unsecured def getPoolParams(self): -file = open(self._poolFile, r) -for line in file: -pair = line.strip().split(=) -if len(pair) == 2: -if pair[0] == id: -hostId = int(pair[1]) -elif pair[0] == scsiKey: -scsiKey = pair[1] -elif pair[0] == sdUUID: -msdUUID = pair[1] -elif pair[0] == version: -masterVersion = pair[1] -file.close() - -return hostId, scsiKey, msdUUID, masterVersion +with open(self._poolFile, r) as f: +poolInfo = dict((x.strip().split(=, 1) for x in f)) +return tuple(poolInfo.get(x) for x in + (hostId, scsiKey, msdUUID, masterVersion)) @unsecured def createMaster(self, poolName, domain, masterVersion, leaseParams): -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: improve extension check in extendDrivesIfNeeded
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: improve extension check in extendDrivesIfNeeded .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4719/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5519/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5599/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide5034cd5d87451c06a2ba034011fdf5696440e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: [wip] add getClusterLockOwnerId method
oVirt Jenkins CI Server has posted comments on this change. Change subject: sd: [wip] add getClusterLockOwnerId method .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4722/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5522/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5602/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10e64d74319ea6591a7edf8e17809d367a758386 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: move reconnection info check to StoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: move reconnection info check to StoragePool .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4720/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5520/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5600/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia57afc04db02b6c15633d09349a55b3ff5ae7fda Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove the uploadVolume command
Federico Simoncelli has posted comments on this change. Change subject: api: remove the uploadVolume command .. Patch Set 1: Dan, remind me, was there something that I should have attended when we remove a verb? (e.g. should it stay in the api json file marked as deprecated?) -- To view, visit http://gerrit.ovirt.org/21425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove the uploadVolume command
oVirt Jenkins CI Server has posted comments on this change. Change subject: api: remove the uploadVolume command .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4721/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5601/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert configuring selinux allowing qemu-kvm to generate co...
mooli tayer has uploaded a new change for review.
Change subject: Revert configuring selinux allowing qemu-kvm to generate
coredumps. in favor of abrt.
..
Revert configuring selinux allowing qemu-kvm to generate coredumps.
in favor of abrt.
This reverts commit 2c2ca06fd410db0c8398c44bddd7154c85ab58d9.
Change-Id: Id1a051079cf284606e1c30af9c23b1579d004f28
Signed-off-by: Mooli Tayer mta...@redhat.com
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/21428/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index c225c23..5b3c4d2 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -654,10 +654,6 @@
/etc/sysctl.conf
fi
-# hack until we replace core dump with abrt
-/usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
-/sbin/restorecon -R -v /var/log/core
-
%if 0%{?rhel}
if [ $1 -eq 1 ] ; then
/sbin/chkconfig --add vdsmd
--
To view, visit http://gerrit.ovirt.org/21428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1a051079cf284606e1c30af9c23b1579d004f28
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sp: [wip] receive domains map in connectStoragePool
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: [wip] receive domains map in connectStoragePool .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4723/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5523/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5603/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I393677f643a62e3711af2a3cfb8b4b9a5ce11c2d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert configuring selinux allowing qemu-kvm to generate co...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert configuring selinux allowing qemu-kvm to generate coredumps. in favor of abrt. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4725/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5525/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5605/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1a051079cf284606e1c30af9c23b1579d004f28 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 13:
(9 comments)
Pushing new patch set in a second...
I had an offline session with Yaniv and we came to an understanding about the
logger. I answered the rest of the comments.
Commit Message
Line 9: Unified network persistence feature:
Line 10: http://www.ovirt.org/Feature/NetworkReloaded#Unified_persistence
Line 11:
Line 12: This patch is the first of two patches that implement an upgrade
Line 13: that is the ran the first time VDSM that uses unified network
Done
Line 14: persistence is started. The goal is to look at the current
Line 15: host networking configuration and populate the running config.
Line 16:
Line 17: Please see the next patch in the series:
Line 9: Unified network persistence feature:
Line 10: http://www.ovirt.org/Feature/NetworkReloaded#Unified_persistence
Line 11:
Line 12: This patch is the first of two patches that implement an upgrade
Line 13: that is the ran the first time VDSM that uses unified network
Done
Line 14: persistence is started. The goal is to look at the current
Line 15: host networking configuration and populate the running config.
Line 16:
Line 17: Please see the next patch in the series:
Line 16:
Line 17: Please see the next patch in the series:
Line 18: http://gerrit.ovirt.org/#/c/18425/
Line 19:
Line 20: To better understand how this patch is used.
Done
Line 21:
Line 22: Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9
File lib/vdsm/tool/upgrade.py
Line 25:
Line 26: LOGGER_CONF_FILE = constants.P_VDSM_CONF + 'vdsm-tool.logger.conf'
Line 27:
Line 28:
Line 29: class Upgrade(object):
Done
Line 30: def __init__(self, upgradeName):
Line 31: self.upgradeName = upgradeName
Line 32: self.upgradeFilePath = os.path.join(constants.P_VDSM_LIB,
Line 33: upgrade,
self.upgradeName)
Line 32: self.upgradeFilePath = os.path.join(constants.P_VDSM_LIB,
Line 33: upgrade,
self.upgradeName)
Line 34: try:
Line 35: logging.config.fileConfig(LOGGER_CONF_FILE)
Line 36: self.log = logging.getLogger('vdsm-tool')
Done
Line 37: except Exception:
Line 38: logging.basicConfig(filename='/dev/stdout', filemode='w+',
Line 39: level=logging.DEBUG)
Line 40: logging.error(Could not init proper logging,
exc_info=True)
Line 45: def seal(self):
Line 46:
Line 47: Mark the upgrade as a success
Line 48:
Line 49: self.log.debug(Upgrade %s successfully performed %
self.upgradeName)
Done
Line 46:
Line 47: Mark the upgrade as a success
Line 48:
Line 49: self.log.debug(Upgrade %s successfully performed %
self.upgradeName)
Line 50: open(self.upgradeFilePath, 'w').close()
I don't know why it would be helpful.
Line 46:
Line 47: Mark the upgrade as a success
Line 48:
Line 49: self.log.debug(Upgrade %s successfully performed %
self.upgradeName)
Line 50: open(self.upgradeFilePath, 'w').close()
Done
Line 46:
Line 47: Mark the upgrade as a success
Line 48:
Line 49: self.log.debug(Upgrade %s successfully performed %
self.upgradeName)
Line 50: open(self.upgradeFilePath, 'w').close()
Done
--
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Assaf Muller amul...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: fix missing method in TransportWrapper
Federico Simoncelli has uploaded a new change for review. Change subject: vdscli: fix missing method in TransportWrapper .. vdscli: fix missing method in TransportWrapper TransportWrapper should also provide the request method as required by xmlrpclib.ServerProxy. Change-Id: Id25df21af1a9c9350876198d02f5f87ee49295fc Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- M lib/vdsm/vdscli.py.in 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/21429/1 diff --git a/lib/vdsm/vdscli.py.in b/lib/vdsm/vdscli.py.in index 2fc55e4..e487573 100644 --- a/lib/vdsm/vdscli.py.in +++ b/lib/vdsm/vdscli.py.in @@ -41,6 +41,7 @@ transport.parse_response = types.MethodType( self.wrapped_parse_response, transport) +self.request = transport.request def wrapped_parse_response(self, *args, **kwargs): try: -- To view, visit http://gerrit.ovirt.org/21429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id25df21af1a9c9350876198d02f5f87ee49295fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: fix missing method in TransportWrapper
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: fix missing method in TransportWrapper .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4726/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5606/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id25df21af1a9c9350876198d02f5f87ee49295fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add asynchronous operation to the monitor
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Add asynchronous operation to the monitor
..
Add asynchronous operation to the monitor
Apart from the current way of operating a moniter:
mon = Monitor()
mon.start()
mon.stop()
eventList = mon.events()
Now it is possible to do:
mon = Monitor()
for event in mon:
do things with the event
This is the first step towards having a thread that keeps netinfo
updated by events.
Change-Id: Ib8ca850fc324a5b4c0268541fd4d4d062706a159
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M lib/vdsm/ipwrapper.py
1 file changed, 56 insertions(+), 24 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/21430/1
diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index 22eaacb..2a6ff0a 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -19,6 +19,7 @@
from collections import namedtuple
import os
+import select
from netaddr.core import AddrFormatError
from netaddr import IPAddress
@@ -528,10 +529,28 @@
class Monitor(object):
-Minimal wrapper over `ip monitor link`
+Wrapper over `ip monitor link`
+Can be used in synchronous mode:
+mon = Monitor()
+mon.start()
+
+mon.stop()
+eventList = mon.events()
+Or in asynchronous:
+mon = Monitor()
+for event in mon:
+print event
+
+_deletionText = 'Deleted'
def __init__(self):
self.proc = None
+
+def __iter__(self):
+if self.proc is None:
+raise StopIteration
+for line in self._stdoutLines():
+yield self._parseLine(line)
def start(self):
self.proc = execCmd([_IP_BINARY.cmd, '-d', '-o', 'monitor', 'link'],
@@ -539,34 +558,47 @@
def stop(self):
self.proc.kill()
+self.proc = None
+
+@classmethod
+def _parseLine(cls, line):
+state = None
+if line.startswith(cls._deletionText):
+state = cls._deletionText.upper()
+line = line[len(cls._deletionText):]
+
+_, device, data = [el.strip() for el in line.split(':', 2)]
+flagVal, _ = data.split('\\', 1) # We don't parse link/ether
+
+flags, values = data.split('')
+flags = frozenset(flags[1:].split(','))
+if state is None:
+values = (el for el in values.strip().split(' ') if el)
+for key, value in pairwise(values):
+if key == 'state':
+state = value
+break
+
+return MonitorEvent(device, flags, state)
@classmethod
def _parse(cls, text):
-deletionText = 'Deleted'
-changes = []
-for line in text.splitlines():
-state = None
-if line.startswith(deletionText):
-state = deletionText.upper()
-line = line[len(deletionText):]
-
-_, device, data = [el.strip() for el in line.split(':', 2)]
-flagVal, _ = data.split('\\', 1) # We don't parse link/ether
-
-flags, values = data.split('')
-flags = frozenset(flags[1:].split(','))
-if state is None:
-values = (el for el in values.strip().split(' ') if el)
-for key, value in pairwise(values):
-if key == 'state':
-state = value
-break
-
-changes.append(MonitorEvent(device, flags, state))
-
-return changes
+return [cls._parseLine(line) for line in text.splitlines()]
def events(self):
out, _ = self.proc.communicate()
return self._parse(out)
+
+def _stdoutLines(self):
+ep = select.epoll()
+ep.register(self.proc.stdout, select.EPOLLIN)
+fd, event = ep.poll()[0]
+outBuffer = os.read(fd, 1024)
+while self.proc is not None:
+if '\n' in outBuffer:
+line, outBuffer = outBuffer.split('\n', 1)
+yield line + '\n'
+else:
+fd, event = ep.poll()[0]
+outBuffer += os.read(fd, 1024)
--
To view, visit http://gerrit.ovirt.org/21430
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8ca850fc324a5b4c0268541fd4d4d062706a159
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 17: Patch set 17 is a rebase. -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running conf .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5608/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
oVirt Jenkins CI Server has posted comments on this change. Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4728/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5528/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5609/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate qemu-kvm coredumps using abrt
oVirt Jenkins CI Server has posted comments on this change. Change subject: generate qemu-kvm coredumps using abrt .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4730/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5530/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5610/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 31: Verified+1 -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 10: Code-Review+1 I adapted this patch, needed also for http://gerrit.ovirt.org/#/c/21291/. Hope you don't mind me sharing it :-) -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Reboot capability for VM
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 31: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4731/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5531/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5611/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Better Saggi bettersa...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Giuseppe Vallarelli gvall...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5533/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5613/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Introduce CallbackChain
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Introduce CallbackChain .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4732/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5532/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5612/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b35eeb3c7865945458801d13615c5dc92ebb5dd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate lvs during bootstrap
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4734/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5534/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5614/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate lvs during bootstrap
Nir Soffer has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap .. Patch Set 6: Changes: - Avoid the race for special lvs by refreshing them instead of deactivation, as suggested by Federico - Use log debug for open lvs - they are expected when vdsm restart when vm are running. -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate qemu-kvm coredumps using abrt
Dan Kenigsberg has posted comments on this change.
Change subject: generate qemu-kvm coredumps using abrt
..
Patch Set 3:
(1 comment)
Is that all that it takes? Where are the cores dumped too? Log-collector should
pick them up, and we must make sure it's writable on ovirt-node.
You should also drop the selinux hack and any other ref to /var/log/core.
File init/vdsmd_init_common.sh.in
Line 24: pre-start tasks
Line 25: task_configure_coredump() {
Line 26: local conf_file=@CONFDIR@/vdsm.conf
Line 27: local getconfitem=@VDSMDIR@/get-conf-item
Line 28: }
Please drop this configurable from config.py.in too.
Line 29:
Line 30: task_run_init_hooks(){
Line 31: @PYTHON@ @VDSMDIR@/hooks.pyc before_vdsm_start
Line 32: }
--
To view, visit http://gerrit.ovirt.org/20751
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer mta...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: fix missing method in TransportWrapper
Dan Kenigsberg has posted comments on this change. Change subject: vdscli: fix missing method in TransportWrapper .. Patch Set 1: Inheritance, even dynamic, is not so evil. -- To view, visit http://gerrit.ovirt.org/21429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id25df21af1a9c9350876198d02f5f87ee49295fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove the uploadVolume command
Dan Kenigsberg has posted comments on this change. Change subject: api: remove the uploadVolume command .. Patch Set 1: If it was never used by Engine I do not mind being soft and just delete it - with a more explanatory commit message. -- To view, visit http://gerrit.ovirt.org/21425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: remove the uploadVolume command
Federico Simoncelli has posted comments on this change. Change subject: api: remove the uploadVolume command .. Patch Set 1: (1 comment) File vdsm/storage/sp.py Line 23: import logging Line 24: import threading Line 25: import errno Line 26: import uuid Line 27: import codecs I should remove this one. Line 28: import signal Line 29: from contextlib import nested Line 30: from functools import partial Line 31: from weakref import proxy -- To view, visit http://gerrit.ovirt.org/21425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2b26aded19f482751196ef642386dcf92d81ce4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate qemu-kvm coredumps using abrt
Dan Kenigsberg has posted comments on this change. Change subject: generate qemu-kvm coredumps using abrt .. Patch Set 3: Oh I see that you have the hack reverted in the same topic branch. Thanks. -- To view, visit http://gerrit.ovirt.org/20751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: gluster prepareImage: return gluster-specific information
Ayal Baron has posted comments on this change. Change subject: gluster prepareImage: return gluster-specific information .. Patch Set 1: same -- To view, visit http://gerrit.ovirt.org/21151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9a8fbf2baafa1f9bfc3677b1301c7934ca74651 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make ip link wrapper hidden config be at class lvl
Dan Kenigsberg has posted comments on this change. Change subject: Make ip link wrapper hidden config be at class lvl .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/21407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43e484c2e2614b1d9bbd67468e3eb050d55d32f6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to reload selinux policy
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: conditional to reload selinux policy
..
vdsm.spec: conditional to reload selinux policy
Only reload policy if selinux is enabled
Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M vdsm.spec.in
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/21432/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index c225c23..3a5d7e9 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -655,8 +655,12 @@
fi
# hack until we replace core dump with abrt
-/usr/sbin/semanage fcontext -a -t virt_cache_t '/var/log/core(/.*)?'
+/usr/sbin/semanage fcontext -N -a -t virt_cache_t '/var/log/core(/.*)?'
+if /usr/sbin/selinuxenabled ; then
+/usr/sbin/load_policy
+fi;
/sbin/restorecon -R -v /var/log/core
+# hack until we replace core dump with abrt
%if 0%{?rhel}
if [ $1 -eq 1 ] ; then
--
To view, visit http://gerrit.ovirt.org/21432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to reload selinux policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: conditional to reload selinux policy .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4735/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5535/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5615/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to reload selinux policy
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: conditional to reload selinux policy .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/21432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.spec: conditional to reload selinux policy
Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: conditional to reload selinux policy .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d40e6d9dcaac16d74c685e4a6a6d5cb130ac531 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check device visibility on failed hotplugDisk
Dan Kenigsberg has posted comments on this change. Change subject: clientIF: Check device visibility on failed hotplugDisk .. Patch Set 3: Code-Review-1 Setting -1 for visibility. -- To view, visit http://gerrit.ovirt.org/21181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate lvs during bootstrap
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5536/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5616/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: deactivate lvs during bootstrap
Nir Soffer has posted comments on this change. Change subject: lvm: deactivate lvs during bootstrap .. Patch Set 7: Changes: - Shorter straightforward code - Improve commit message -- To view, visit http://gerrit.ovirt.org/21291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f142ebca7a00d45f2500ad2631fab2366f2f7db Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: fix missing method in TransportWrapper
Dan Kenigsberg has posted comments on this change. Change subject: vdscli: fix missing method in TransportWrapper .. Patch Set 1: Code-Review-1 Piotr, please fix the unit test, too. -- To view, visit http://gerrit.ovirt.org/21429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id25df21af1a9c9350876198d02f5f87ee49295fc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: pep8: Fix indentation to comply with pep8 1.3.3
Nir Soffer has posted comments on this change. Change subject: pep8: Fix indentation to comply with pep8 1.3.3 .. Patch Set 1: Abandon? -- To view, visit http://gerrit.ovirt.org/21196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3431742f9dbfd86a9816c7b3c6de90e282dbd415 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert clientIF: rescan devices on failed hotplugDisk
Nir Soffer has posted comments on this change. Change subject: Revert clientIF: rescan devices on failed hotplugDisk .. Patch Set 3: Rebase on master, no code change. -- To view, visit http://gerrit.ovirt.org/21173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib978fada8ee82e3c6da9de9b79a66edafba4eb70 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4737/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5537/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5617/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46ede1124f4c5f849b040b598b49ee784c540ecc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check device visibility on failed hotplugDisk
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Check device visibility on failed hotplugDisk .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4738/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5538/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5618/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Do not hide errors when checking device visibility
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4739/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5539/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5619/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7411d7d2eaa9172f612fd1b1e04177bef270ab19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Check all devices visibility after multipath rescan
Nir Soffer has posted comments on this change. Change subject: hsm: Check all devices visibility after multipath rescan .. Patch Set 3: Rebase over [21173] Revert clientIF: rescan devices on failed hotplugDisk instead of [21173] clientIF: Check device visibility on failed hotplugDisk. Dan does not like yet the clientIF patch, and this delay this patch for no good reason. No code change. -- To view, visit http://gerrit.ovirt.org/21182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46ede1124f4c5f849b040b598b49ee784c540ecc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Revert clientIF: rescan devices on failed hotplugDisk
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert clientIF: rescan devices on failed hotplugDisk .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4740/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5540/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5620/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/21173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib978fada8ee82e3c6da9de9b79a66edafba4eb70 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Do not hide errors when checking device visibility
Nir Soffer has posted comments on this change. Change subject: hsm: Do not hide errors when checking device visibility .. Patch Set 3: Rebase - no code change. -- To view, visit http://gerrit.ovirt.org/21211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7411d7d2eaa9172f612fd1b1e04177bef270ab19 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: Check device visibility on failed hotplugDisk
Nir Soffer has posted comments on this change. Change subject: clientIF: Check device visibility on failed hotplugDisk .. Patch Set 4: Rebase over [21181] hsm: Do not hide errors when checking device visibility so we don't delay other patches. No code change. -- To view, visit http://gerrit.ovirt.org/21181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d75ac53ca809b7a25d7fb237ec661dd865e31fc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Lee Yarwood has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 10: @Nir np, maybe I'm missing something regarding gerrit workflow but isn't it cleaner to rebase and push your own change? Introducing the dependency without the need to repush this change or my two other changes that depend on it ;) -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Nir Soffer has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 10: Well thats what I tried to do - rebase on your patch. However it was rebased on old version, so I rebased again both patches on master. Sorry for causing you extra work. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: check the syntaxs of optional parameters in json schema
Nir Soffer has posted comments on this change.
Change subject: check the syntaxs of optional parameters in json schema
..
Patch Set 2:
(5 comments)
Commit Message
Line 3: AuthorDate: 2012-12-28 00:27:20 +0800
Line 4: Commit: ShaoHe Feng shao...@linux.vnet.ibm.com
Line 5: CommitDate: 2012-12-28 14:30:30 +0800
Line 6:
Line 7: check the syntaxs of optional parameters in json schema
Detect optional parameter syntax errors in JSON schema
Line 8:
Line 9: There are so many syntaxs error of optional parameters define in
Line 10: json schema
Line 11: This patch can both check the descrption errors of optional parameters
Line 8:
Line 9: There are so many syntaxs error of optional parameters define in
Line 10: json schema
Line 11: This patch can both check the descrption errors of optional parameters
Line 12: missing #optional and the define error of optional parameters missing *
There are too many syntax errors using optional parameters in JSON schema. This
patch detects these errors.
Line 13:
Line 14: Change-Id: I94f92459ee8787780a54a510b6f8cc074fb2a235
File vdsm_api/process-schema.py
Line 23: import re
Line 24: import vdsmapi
Line 25: try:
Line 26: from collections import OrderedDict
Line 27: OrderedDict # make pyflakes happy
Can we fix pyflakes instead? This type of code make me sad :-)
Line 28: except ImportError:
Line 29: from ordereddict import OrderedDict
Line 30:
Line 31: html_escape_table = {
Line 151: # check optional parameters
Line 152: if desc.startswith('#optional'):
Line 153: assert ('*' + name in symbol['data'].keys()), \
Line 154: ('Define of %s optional parameter
error:\n\t%s should '
Line 155: 'start with *' % (symbol['name'], name))
Since we raise ValueError bellow - why not raise it here also?
Line 156: if isinstance(symbol['data'], OrderedDict):
Line 157: if '*' + name in symbol['data'].keys():
Line 158: assert desc.startswith('#optional'), \
Line 159: ('Description of %s optional parameter
error:\n\t'
Line 158: assert desc.startswith('#optional'), \
Line 159: ('Description of %s optional parameter
error:\n\t'
Line 160: 'The description of optional parameter
%s '
Line 161: 'should start with #optional' %
Line 162: (symbol['name'], name))
ValueError?
Line 163: else:
Line 164: # Just append it to the last one we added
Line 165: symbol[mode][last_arg] += ' ' + line
Line 166: elif mode == 'info_return':
--
To view, visit http://gerrit.ovirt.org/10446
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94f92459ee8787780a54a510b6f8cc074fb2a235
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Better Saggi bettersa...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Itamar Heim ih...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Dan Kenigsberg has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 7: (2 comments) Commit Message Line 8: Line 9: At present we trust that active LVs represent the current state of a Line 10: given LV. This may not be the case if the LV has been modified Line 11: (extended, recreated etc) by another host while the LV is active on Line 12: the current host. Could you detail how we can get to such a condition? http://gerrit.ovirt.org/#/c/21291/ fixes the two cases that I am aware of (auto activate on boot and vdsm crash after activation). Line 13: Line 14: This change forces active LVs that are part of a guest image to be Line 15: refreshed before use. Line 16: File vdsm/storage/blockSD.py Line 1073: Line 1074: if toRefresh: Line 1075: log.warning(The following volumes are already active and will be Line 1076: refreshed before use : %s, toRefresh) Line 1077: lvm.refreshLVs(self.sdUUID, toRefresh) until http://gerrit.ovirt.org/#/c/8382/ is in, this could be a problem for shared volumes, which are written to by another VM. Line 1078: Line 1079: vgDir = os.path.join(/dev, self.sdUUID) Line 1080: return self.createImageLinks(vgDir, imgUUID, volUUIDs) Line 1081: -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Lee Yarwood lyarw...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate qemu-kvm coredumps using abrt
oVirt Jenkins CI Server has posted comments on this change. Change subject: generate qemu-kvm coredumps using abrt .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4741/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5541/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5621/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: generate qemu-kvm coredumps using abrt
oVirt Jenkins CI Server has posted comments on this change. Change subject: generate qemu-kvm coredumps using abrt .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4742/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5622/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1acb287cdfcc9b8c05569fe1fc01e88957309ff9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer mta...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
