Change in vdsm[master]: hooks: Add hook for fake VM stats
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/400/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6817/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7607/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7717/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add hook for fake VM stats
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/401/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6818/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7608/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7718/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: consider 'action' when handling I/O errors
Francesco Romani has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 1: Verified+1 Verification: - same code as master (no changes in this area) - re-verified on branch - forced disk error policy to 'enospace', then blocked storage; - VM was never paused - I/O error reported as expected on logs and inside the VM console - (unexpected) to me 'Bus Error' reported in VM console as well, seems unrelated/outside of the scope of this patch. -- To view, visit http://gerrit.ovirt.org/26023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add hook for fake VM stats
oVirt Jenkins CI Server has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/402/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6819/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7609/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7719/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: handle missing domains on recovery
Dan Kenigsberg has posted comments on this change. Change subject: vm: handle missing domains on recovery .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00ef12883c8035209de0f273925eb8603d6b6da8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: handle missing domains on recovery
Vinzenz Feenstra has posted comments on this change. Change subject: vm: handle missing domains on recovery .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00ef12883c8035209de0f273925eb8603d6b6da8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: consider 'action' when handling I/O errors
Vinzenz Feenstra has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: handle missing domains on recovery
Dan Kenigsberg has posted comments on this change. Change subject: vm: handle missing domains on recovery .. Patch Set 1: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/25275/1//COMMIT_MSG Commit Message: Line 7: vm: handle missing domains on recovery Line 8: Line 9: When VDSM tries to reconnect to libvirt, it is possible Line 10: that the domain lookup fails. This is especially true on Line 11: recovering. Sorry for being a bit slow here, but we should already have a safeguard in place: Vdsm should not even try to recover VMs before it holds a libvirt connection, and it should be taken down if the connection is broken while recovering. Please explain better why we need this, and why it has to be the basis of the follow-up patch. Line 12: Line 13: This patch add an explicit check in the recovery path to Line 14: make sure that a VM is either created with a valid libvirt Line 15: domain handle, or it is reported as Down so the engine -- To view, visit http://gerrit.ovirt.org/25275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00ef12883c8035209de0f273925eb8603d6b6da8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: recovery: try to restore VMs from recovery files
Dan Kenigsberg has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 1: Code-Review-1
(2 comments)
Please include a functional test, that starts a Vm, stops Vdsm, kills qemu, and
verifies that the kill Vm is reported back as Down.
http://gerrit.ovirt.org/#/c/25276/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2014-03-03 15:06:09 +0100
Line 6:
Line 7: recovery: try to restore VMs from recovery files
Line 8:
Line 9: on recovery, VDSM tries to recover the all the VMs reported
English: the all the
Line 10: as active by libvirt.
Line 11: If a VM disappears while VDSM is down or restarting, the
Line 12: VM silently disappears without VDSM noticing, and the recovery
Line 13: file is discarded.
http://gerrit.ovirt.org/#/c/25276/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 419: # we do this to safely handle VMs which disappeared
Line 420: # from the host while VDSM was down/restarting
Line 421: for vmId in self._getVDSMVmsFromRecovery():
Line 422: if not self._recoverVm(vmId):
Line 423: self.log.info('expected VM %s from recovery file
but'
Where is a new VM object created and added to vmContainer in Down state?
Line 424: 'missing, reported as Down', vmId)
Line 425:
Line 426: while (self._enabled and
Line 427:'WaitForLaunch' in [v.lastStatus for v in
--
To view, visit http://gerrit.ovirt.org/25276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id495f6047ba658c2b04da19bd7bf76425b3b9659
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: handle missing domains on recovery
Francesco Romani has posted comments on this change. Change subject: vm: handle missing domains on recovery .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25275/1//COMMIT_MSG Commit Message: Line 7: vm: handle missing domains on recovery Line 8: Line 9: When VDSM tries to reconnect to libvirt, it is possible Line 10: that the domain lookup fails. This is especially true on Line 11: recovering. Sorry for being a bit slow here, but we should already have a safeguard in Ack. Will amend the commit message in the next upload. Line 12: Line 13: This patch add an explicit check in the recovery path to Line 14: make sure that a VM is either created with a valid libvirt Line 15: domain handle, or it is reported as Down so the engine -- To view, visit http://gerrit.ovirt.org/25275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00ef12883c8035209de0f273925eb8603d6b6da8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/25778/5/vdsm/storage/image.py File vdsm/storage/image.py: Line 357: # To avoid prezeroing preallocated volumes on NFS domains Line 358: # we create the target as a sparse volume (since it will be Line 359: # soon filled with the data coming from the copy) and then Line 360: # we change its metadata back to the original value. Line 361: if (destDom.supportsSparseness): No need for parentheses. Line 362: tmpVolPreallocation = volume.SPARSE_VOL Line 363: else: Line 364: tmpVolPreallocation = volume.PREALLOCATED_VOL Line 365: Line 382: # Change destination volume metadata back to the original Line 383: # type unless the domain does not supports sparseness, in Line 384: # that case leave it as preallocated Line 385: if tmpVolPreallocation != volParams['prealloc'] and \ Line 386: destDom.supportsSparseness: I think it should be: if (volParams['prealloc'] == volume.PREALLOCATED_VOL and tmpVolPreallocation != volume.PREALLOCATED_VOL): dstVol.setType(volume.PREALLOCATED_VOL) Line 387: dstVol.setType(volParams['prealloc']) Line 388: Line 389: dstChain.append(dstVol) Line 390: except se.StorageException: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: consider 'action' when handling I/O errors
Yaniv Bronhaim has posted comments on this change. Change subject: vm: consider 'action' when handling I/O errors .. Patch Set 1: Code-Review-1 the bug is not targeted to ovirt-3.4 -- To view, visit http://gerrit.ovirt.org/26023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface .. hsm: Distinguish between iface and initiator when creating iSCSI iface VDSM mistakely assumed that iface name and iface initiator name are the same, so if admin configured specific initiator name in the host its value is mistakenly overwritten by ifaceName in the iface file. In such a case the host fails to establish the iSCSI connection with the target. Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Signed-off-by: Sergey Gotliv sgot...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25628 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Rename _BCInitiatorNameResolve function
Dan Kenigsberg has submitted this change and it was merged. Change subject: hsm: Rename _BCInitiatorNameResolve function .. hsm: Rename _BCInitiatorNameResolve function Function _BCInitiatorNameResolve actually resolves the iface name not the initiator name so new name emphasizes that. Change-Id: I716317afdba3321c9d6bf0e382f261b3b22802f7 Signed-off-by: Sergey Gotliv sgot...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25701 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com --- M vdsm/storage/hsm.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved Sergey Gotliv: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I716317afdba3321c9d6bf0e382f261b3b22802f7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pre-start: touch/configure vdsm logs
Dan Kenigsberg has posted comments on this change. Change subject: pre-start: touch/configure vdsm logs .. Patch Set 5: Douglas, could vdsmd be started by vdsm-reg prior to registration? Isn't http://gerrit.ovirt.org/#/c/25878/ good enough to hack this problem away? As Yaniv says, we should fix the problem in vdsm-tool, instead of adding more and more elaborated hacks. -- To view, visit http://gerrit.ovirt.org/25912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca927cb447eeb24195cff6a1174e0f9a7295214 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Ryan Barry rba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Dan Kenigsberg has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/26055/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 114: def getName(self):
Line 115: return 'sanlock'
Line 116:
Line 117: def getServices(self):
Line 118: return ['sanlock']
we cannot just drop configure. Non-rpm installation may depend on it; if it's
gone, there's no much point in keeping SanlockModuleConfigure.
Line 119:
Line 120: def isconfigured(self):
Line 121:
Line 122: True if sanlock service is configured, False if sanlock
service
http://gerrit.ovirt.org/#/c/26055/1/vdsm.spec.in
File vdsm.spec.in:
Line 733: /bin/systemctl daemon-reload /dev/null 21 || :
Line 734: exit 0
Line 735: %endif
Line 736:
Line 737: %preun
These should happen on %posun, after all files with this ownership are removed,
and only there are no more copies of vdsm installed (if [ $1 -eq 0 ]).
Line 738: /usr/bin/gpasswd -d %{snlk_user} %{qemu_group}
Line 739: /usr/bin/gpasswd -d %{snlk_user} %{vdsm_group}
Line 740:
Line 741: if [ $1 -eq 0 ]; then
--
To view, visit http://gerrit.ovirt.org/26055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 6: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6820/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7610/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7720/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7611/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7721/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6822/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7612/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7722/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/25877/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1266: self._finally.insert(0, (func, args, kwargs))
Line 1267:
Line 1268:
Line 1269: @memoized
Line 1270: def getBootTime():
you should keep the memoized, but there is no reason for putting it under
utils.py. currently this function is required only by sampling.py . keep it
there
Line 1271: with file('/proc/stat') as f:
Line 1272: btime_line = [l for l in f.read().splitlines()
Line 1273: if l.startswith('btime')][0]
Line 1273: startswith
a bit of waist (not much, but still)
take it as all values we retrieve from /proc/stat - map(int,
file('/proc/stat').readline().split()[x:y]) (in sampling.py)
or maybe.. we should have getStat in utils that returns namedtuple, as we do in
utils:pidStat function. can be useful , but the former is preferable in this
patch scope
--
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Tal Nisan tni...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: recovery: try to restore VMs from recovery files
Francesco Romani has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25276/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 419: # we do this to safely handle VMs which disappeared
Line 420: # from the host while VDSM was down/restarting
Line 421: for vmId in self._getVDSMVmsFromRecovery():
Line 422: if not self._recoverVm(vmId):
Line 423: self.log.info('expected VM %s from recovery file
but'
Where is a new VM object created and added to vmContainer in Down state?
the VM object will be added by clientIF.createVm (see line 380) which is in
turn called by clientIF._recoverVm (line 522).
The Down state will be a result of trying to recover a Vm from a recovery file
without a libvirt connection.
The change http://gerrit.ovirt.org/#/c/25275/ will catch those situations and
force the VM object to Down.
Line 424: 'missing, reported as Down', vmId)
Line 425:
Line 426: while (self._enabled and
Line 427:'WaitForLaunch' in [v.lastStatus for v in
--
To view, visit http://gerrit.ovirt.org/25276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id495f6047ba658c2b04da19bd7bf76425b3b9659
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/26055/1/vdsm.spec.in
File vdsm.spec.in:
Line 689: /usr/bin/getent passwd %{vdsm_user} /dev/null || \
Line 690: /usr/sbin/useradd -r -u 36 -g %{vdsm_group} -d /var/lib/vdsm \
Line 691: -s /sbin/nologin -c Node Virtualization Manager %{vdsm_user}
Line 692: /usr/sbin/usermod -a -G %{qemu_group},%{snlk_group} %{vdsm_user}
Line 693: /usr/sbin/usermod -a -G %{qemu_group},%{vdsm_group} %{snlk_user}
why not to call vdsm-tool configure --module sanlock ?
Line 694:
Line 695: %post
Line 696: %{_bindir}/vdsm-tool sebool-config || :
Line 697: # set the vdsm secret password for libvirt
Line 733: /bin/systemctl daemon-reload /dev/null 21 || :
Line 734: exit 0
Line 735: %endif
Line 736:
Line 737: %preun
These should happen on %posun, after all files with this ownership are remo
again, do remove-config verb in vdsm-tool for sanlock module. much nicer imo
Line 738: /usr/bin/gpasswd -d %{snlk_user} %{qemu_group}
Line 739: /usr/bin/gpasswd -d %{snlk_user} %{vdsm_group}
Line 740:
Line 741: if [ $1 -eq 0 ]; then
--
To view, visit http://gerrit.ovirt.org/26055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6823/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7613/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7723/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6824/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7614/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7724/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7615/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7725/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: always run migration monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: always run migration monitor .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6827/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7617/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7727/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4953ddda5a5c6c0ecd7ea0f95377309e18f771a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: move threads in a separate module
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: move threads in a separate module .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6826/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7616/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7726/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/403/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia69c7448b66417c7bba8ae3d301e7d777ca88067 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7618/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7728/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6829/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7620/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7730/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: always run migration monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: always run migration monitor .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6831/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7621/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7731/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4953ddda5a5c6c0ecd7ea0f95377309e18f771a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7619/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7729/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6832/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7622/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7732/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/404/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
Dan Kenigsberg has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 4: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/25877/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1266: self._finally.insert(0, (func, args, kwargs))
Line 1267:
Line 1268:
Line 1269: @memoized
Line 1270: def getBootTime():
you should keep the memoized, but there is no reason for putting it under u
+1, and please add a unittest for this function.
Line 1271: with file('/proc/stat') as f:
Line 1272: btime_line = [l for l in f.read().splitlines()
Line 1273: if l.startswith('btime')][0]
Line 1269: @memoized
Line 1270: def getBootTime():
Line 1271: with file('/proc/stat') as f:
Line 1272: btime_line = [l for l in f.read().splitlines()
Line 1273: if l.startswith('btime')][0]
a bit of waist (not much, but still)
I actually think that the grep btime method is nicer and safer.
--
To view, visit http://gerrit.ovirt.org/25877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Tal Nisan tni...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: util: fix execCmd to accept tuples
Dima Kuznetsov has uploaded a new change for review. Change subject: util: fix execCmd to accept tuples .. util: fix execCmd to accept tuples There was an issue when occasionally when flags were given along with a command in a tuple, there was an exception in execCmd, because + operator was used to append tuple with commands to a list. Change-Id: I8d1269d9a26b1fef1552976ae626cf4596471283 Signed-off-by: Dima Kuznetsov dkuzn...@redhat.com --- M lib/vdsm/utils.py 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/26070/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index b682dec..430f46d 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -660,18 +660,22 @@ if ioclassdata is not None: command.extend((-n, str(ioclassdata))) -command = command + cmd +command = itertools.chain(command, cmd) if nice is not None: -command = [constants.EXT_NICE, '-n', str(nice)] + command +command = itertools.chain([constants.EXT_NICE, '-n', str(nice)], + command) if setsid: -command = [constants.EXT_SETSID] + command +command = itertools.chain([constants.EXT_SETSID], command) if sudo: if os.geteuid() != 0: -command = [constants.EXT_SUDO, SUDO_NON_INTERACTIVE_FLAG] + command +command = itertools.chain([constants.EXT_SUDO, + SUDO_NON_INTERACTIVE_FLAG], + command) +command = list(command) if not printable: printable = command -- To view, visit http://gerrit.ovirt.org/26070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8d1269d9a26b1fef1552976ae626cf4596471283 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Initial commit for vdsm-tool testing infrastructure
Dan Kenigsberg has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 16: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25263/16/tests/toolTests.py
File tests/toolTests.py:
Line 26:
Line 27: test_env = {}
Line 28:
Line 29: # TODO: tough it works well in make rpm,
Line 30: # this is no good since the execution cwd effects the test.
Right! so please use the
testPath = os.path.realpath(__file__)
trick that is used elsewhere.
Line 31: test_env['GETCONFITEM'] = '../vdsm/get-conf-item'
Line 32: test_env['OVIRT_FUNC_PATH'] = '../vdsm/ovirt_functions.sh'
Line 33: test_env['TESTING_ENV'] = 'TRUE'
Line 34:
--
To view, visit http://gerrit.ovirt.org/25263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae0fec9b2057c5ba932f38ed5d34d654486043ef
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6833/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7623/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/405/ : FAILURE -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: util: fix execCmd to accept tuples
oVirt Jenkins CI Server has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7624/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7734/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d1269d9a26b1fef1552976ae626cf4596471283 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Allon Mureinik has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: util: fix execCmd to accept tuples
Yaniv Bronhaim has posted comments on this change. Change subject: util: fix execCmd to accept tuples .. Patch Set 1: Code-Review-1 please add unit tests for that. -- To view, visit http://gerrit.ovirt.org/26070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d1269d9a26b1fef1552976ae626cf4596471283 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve logging on some filesystem operations
Allon Mureinik has posted comments on this change. Change subject: Improve logging on some filesystem operations .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26046/2//COMMIT_MSG Commit Message: Line 6: Line 7: Improve logging on some filesystem operations Line 8: Line 9: The rationale behind this patch is to increase the logging on some Line 10: filesystem operations. Before no trace was given when creating or storage operations, not filesystem operations. Note that you're also ch take that back - it's all about linking and unlinking. Line 11: deleting symbolic links or removing or renaming files or folders in Line 12: storage operations. This patch tries to solve this adding debug Line 13: messages after those operations succeed. Line 14: -- To view, visit http://gerrit.ovirt.org/26046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3602513af123951f71091c03f799e36ea759aa61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: fencing: stop using a deprecated command
Dan Kenigsberg has uploaded a new change for review.
Change subject: fencing: stop using a deprecated command
..
fencing: stop using a deprecated command
Recently, fence-agents stopped supporting the option alias for its
action STDIN command.
https://lists.fedorahosted.org/pipermail/cluster-commits/2013-February/003090.html
Let us conform to the new option name. The action name has been long
supported by el6 and f19's fence-agents, so it can be safely used.
Thanks to John Taylor for reporting the issue.
Bug-Url: https://bugzilla.redhat.com/1063472
Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc
Signed-off-by: Dan Kenigsberg dan...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/24303
Reviewed-by: Eli Mesika emes...@redhat.com
Reviewed-by: Douglas Schilling Landgraf dougsl...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/24343
Reviewed-by: Yaniv Bronhaim ybron...@redhat.com
(cherry picked from commit 02efd473ac8886ec860023815aba2ae5af43b91c)
---
M vdsm/API.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/26075/1
diff --git a/vdsm/API.py b/vdsm/API.py
index 37bb908..f379e9c 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1123,7 +1123,7 @@
return errCode['fenceAgent']
raise
-inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\noption=%s\n'
+inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\naction=%s\n'
'passwd=%s\n') % (agent, addr, username, action, password)
if port != '':
inp += 'port=%s\n' % (port,)
--
To view, visit http://gerrit.ovirt.org/26075
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0e167e493412f95eda2325e0b028eb7c29c18bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6835/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7625/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7735/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 2: need to be tested in case looks good to reviewers. -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 2: I mean, tested in the rhev-h -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: use sanlock user constant
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: use sanlock user constant .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6836/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7626/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7736/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43464961cba6b6b761a98ad4b72a271228914ca1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: use sanlock user constant
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: configurator: use sanlock user constant .. configurator: use sanlock user constant Replace the static value with a constant. Change-Id: I43464961cba6b6b761a98ad4b72a271228914ca1 Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com --- M lib/vdsm/constants.py.in M lib/vdsm/tool/configurator.py 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/26080/1 diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in index 6653d54..4ddfe84 100644 --- a/lib/vdsm/constants.py.in +++ b/lib/vdsm/constants.py.in @@ -41,6 +41,9 @@ QEMU_PROCESS_USER = '@QEMUUSER@' QEMU_PROCESS_GROUP = '@QEMUGROUP@' +# Sanlock definitions +SANLOCK_USER = '@SNLKUSER@' + # # The username of SASL authenticating for libvirt connection # diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py index d1c876c..896aa25 100644 --- a/lib/vdsm/tool/configurator.py +++ b/lib/vdsm/tool/configurator.py @@ -24,7 +24,8 @@ from .. import utils from . import service, expose -from ..constants import P_VDSM_EXEC, QEMU_PROCESS_GROUP, VDSM_GROUP +from ..constants import P_VDSM_EXEC, QEMU_PROCESS_GROUP, \ +SANLOCK_USER, VDSM_GROUP class _ModuleConfigure(object): @@ -132,7 +133,7 @@ '-a', '-G', ','.join(self.SANLOCK_GROUPS), -'sanlock' +SANLOCK_USER ), raw=True, ) -- To view, visit http://gerrit.ovirt.org/26080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I43464961cba6b6b761a98ad4b72a271228914ca1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Dan Kenigsberg has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26055/2/vdsm.spec.in
File vdsm.spec.in:
Line 828: if [ ${vdsmd_start_required} = 'yes' ]; then
Line 829: %{_bindir}/vdsm-tool service-start vdsmd /dev/null 21 || :
Line 830: fi
Line 831:
Line 832: %{_bindir}/vdsm-tool unconfigure --module sanlock
repeat: this must be run only when $1 equals 0.
Line 833: fi
Line 834: exit 0
Line 835:
Line 836: %if 0%{?rhel} == 6
--
To view, visit http://gerrit.ovirt.org/26055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: use sanlock user constant
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: use sanlock user constant .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6838/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7628/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7738/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43464961cba6b6b761a98ad4b72a271228914ca1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: avoid to reply with half-baked statistics .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6839/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7629/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7739/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: use sanlock user constant
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: use sanlock user constant .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6840/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7630/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7740/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/407/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43464961cba6b6b761a98ad4b72a271228914ca1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: use sanlock user constant
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: use sanlock user constant .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7631/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7741/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43464961cba6b6b761a98ad4b72a271228914ca1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: avoid to reply with half-baked statistics
Francesco Romani has posted comments on this change. Change subject: vm: avoid to reply with half-baked statistics .. Patch Set 2: Patch set 1 was a highly-localized band-aid fix. Patch set 2 (and onwards) tries more aggressively to fix the root cause of this problem. -- To view, visit http://gerrit.ovirt.org/25803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65197459cd183af5e7a1634a5ffb01719364a070 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6842/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7632/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7742/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/408/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 4: Requires: http://gerrit.ovirt.org/#/c/26080/ Jenkins said nothing to do with 26080 and I couldn't update this one. -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6843/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7633/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7743/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/409/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6837/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7627/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7737/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/406/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Initial commit for vdsm-tool testing infrastructure
mooli tayer has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 16:
(1 comment)
http://gerrit.ovirt.org/#/c/25263/16/tests/toolTests.py
File tests/toolTests.py:
Line 26:
Line 27: test_env = {}
Line 28:
Line 29: # TODO: tough it works well in make rpm,
Line 30: # this is no good since the execution cwd effects the test.
Right! so please use the
ok!
Line 31: test_env['GETCONFITEM'] = '../vdsm/get-conf-item'
Line 32: test_env['OVIRT_FUNC_PATH'] = '../vdsm/ovirt_functions.sh'
Line 33: test_env['TESTING_ENV'] = 'TRUE'
Line 34:
--
To view, visit http://gerrit.ovirt.org/25263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae0fec9b2057c5ba932f38ed5d34d654486043ef
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/25778/7/vdsm/storage/image.py File vdsm/storage/image.py: Line 380: dstVol.extend((volParams['apparentsize'] + 511) / 512) Line 381: Line 382: # Change destination volume metadata back to the original Line 383: # type unless the domain does not supports sparseness, in Line 384: # that case leave it as preallocated Probably you need to update the comment. Line 385: if volParams['prealloc'] == volume.PREALLOCATED_VOL \ Line 386: and tmpVolPreallocation != volume.PREALLOCATED_VOL: Line 387: dstVol.setType(volume.PREALLOCATED_VOL) Line 388: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Initial commit for vdsm-tool testing infrastructure
oVirt Jenkins CI Server has posted comments on this change. Change subject: Initial commit for vdsm-tool testing infrastructure .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7634/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7744/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae0fec9b2057c5ba932f38ed5d34d654486043ef Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Tal Nisan has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: Verified+1 Verified moving all different options of format types and sparse/preallocated from file to block domain and vice versa -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Tal Nisan has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/25778/7/vdsm/storage/image.py File vdsm/storage/image.py: Line 380: dstVol.extend((volParams['apparentsize'] + 511) / 512) Line 381: Line 382: # Change destination volume metadata back to the original Line 383: # type unless the domain does not supports sparseness, in Line 384: # that case leave it as preallocated Probably you need to update the comment. Done Line 385: if volParams['prealloc'] == volume.PREALLOCATED_VOL \ Line 386: and tmpVolPreallocation != volume.PREALLOCATED_VOL: Line 387: dstVol.setType(volume.PREALLOCATED_VOL) Line 388: -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Federico Simoncelli has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
Tal Nisan has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Verified+1 Verified moving all different options of format types and sparse/preallocated from file to block domain and vice versa -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: Add boot time to the getVdsStats API
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: Add boot time to the getVdsStats API .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6845/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7635/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7745/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I319e619cdaecac2f86d0154e3adbb3beda9c57d6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Allow moving of sparse images to a block domains
oVirt Jenkins CI Server has posted comments on this change. Change subject: Allow moving of sparse images to a block domains .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6846/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7746/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25778 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id95d700cf6acb46464d6c5d063966f9331a15028 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VmStatsThread: make _getNicStats testable
oVirt Jenkins CI Server has posted comments on this change. Change subject: VmStatsThread: make _getNicStats testable .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6847/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7637/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7747/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd6ffa12341b814775bea96a47365645b571f3a8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm iface stats: fix arithmetic
Dan Kenigsberg has posted comments on this change. Change subject: vm iface stats: fix arithmetic .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie356d5f96c73b65925b38f6149d5eb36f43023ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Pavlik xpavl...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm iface stats: fix arithmetic
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm iface stats: fix arithmetic .. vm iface stats: fix arithmetic My commit 672ff43 has a serious arithmetic flaw: the modulu must be taken on the sample difference! Bug-Url: https://bugzilla.redhat.com/1062166 Change-Id: Ie356d5f96c73b65925b38f6149d5eb36f43023ad Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25960 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Tested-by: Martin Pavlik xpavl...@gmail.com --- M vdsm/vm.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Pavlik: Verified Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie356d5f96c73b65925b38f6149d5eb36f43023ad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Pavlik xpavl...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm iface stats: fix arithmetic
Dan Kenigsberg has uploaded a new change for review. Change subject: vm iface stats: fix arithmetic .. vm iface stats: fix arithmetic My commit 672ff43 has a serious arithmetic flaw: the modulu must be taken on the sample difference! Bug-Url: https://bugzilla.redhat.com/1062166 Change-Id: Ie356d5f96c73b65925b38f6149d5eb36f43023ad Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25960 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Tested-by: Martin Pavlik xpavl...@gmail.com (cherry picked from commit d0c9357bbf6b6c61dc633edba6691a53b592e895) --- M vdsm/vm.py 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/26088/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 0db8466..832bca8 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -609,12 +609,12 @@ ifStats['txDropped'] = str(eInfo[nic.name][7]) ifRxBytes = (100.0 * - (eInfo[nic.name][0] - sInfo[nic.name][0]) % - 2 ** 32 / + ((eInfo[nic.name][0] - sInfo[nic.name][0]) % + 2 ** 32) / sampleInterval / ifSpeed / self.MBPS_TO_BPS) ifTxBytes = (100.0 * - (eInfo[nic.name][4] - sInfo[nic.name][4]) % - 2 ** 32 / + ((eInfo[nic.name][4] - sInfo[nic.name][4]) % + 2 ** 32) / sampleInterval / ifSpeed / self.MBPS_TO_BPS) ifStats['rxRate'] = '%.1f' % ifRxBytes -- To view, visit http://gerrit.ovirt.org/26088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie356d5f96c73b65925b38f6149d5eb36f43023ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: configurator: move usermod to spec
..
configurator: move usermod to spec
vdsm-tool configure --force adds to /etc/group (qemu/kvm) sanlock
but doesn't persist the file in ovirt node distro which will
affect vdsm start on next reboot. This patch adds the usermod to
spec file.
Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/26089/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 361a9c1..fc9110a 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -692,6 +692,7 @@
/usr/sbin/usermod -a -G %{qemu_group},%{snlk_group} %{vdsm_user}
%post
+%{_bindir}/vdsm-tool configure --module sanlock
%{_bindir}/vdsm-tool sebool-config || :
# set the vdsm secret password for libvirt
%{_bindir}/vdsm-tool set-saslpasswd
--
To view, visit http://gerrit.ovirt.org/26089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 4: Code-Review-1 Need to be resync, since we are splitting into http://gerrit.ovirt.org/26089 -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 1: If all reviewers agree, need to be tested under ovirt-node. -- To view, visit http://gerrit.ovirt.org/26089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Dan Kenigsberg has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6848/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7638/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7748/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/410/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26089/1/vdsm.spec.in
File vdsm.spec.in:
Line 692: /usr/sbin/usermod -a -G %{qemu_group},%{snlk_group} %{vdsm_user}
Line 693:
Line 694: %post
Line 695: %{_bindir}/vdsm-tool configure --module sanlock
Line 696: %{_bindir}/vdsm-tool sebool-config || :
you must put --force to configure sanlock if sanlock service is down.
otherwise, when sanlock service is down isconfigured returns true and configure
won't do anything.
Line 697: # set the vdsm secret password for libvirt
Line 698: %{_bindir}/vdsm-tool set-saslpasswd
Line 699:
Line 700: # After vdsm install we should create the logs files.
--
To view, visit http://gerrit.ovirt.org/26089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve logging on some filesystem operations
Xavi Francisco has posted comments on this change. Change subject: Improve logging on some filesystem operations .. Patch Set 2: In general that's true but in this case we use the logging to check for successful operations so probably it could be nice to keep the logging after the successful operation happened -- To view, visit http://gerrit.ovirt.org/26046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3602513af123951f71091c03f799e36ea759aa61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Xavi Francisco xfran...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: use sanlock user constant
Yaniv Bronhaim has posted comments on this change. Change subject: configurator: use sanlock user constant .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43464961cba6b6b761a98ad4b72a271228914ca1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6849/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7639/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7749/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/411/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm iface stats: fix arithmetic
Dan Kenigsberg has uploaded a new change for review. Change subject: vm iface stats: fix arithmetic .. vm iface stats: fix arithmetic My commit 672ff43 has a serious arithmetic flaw: the modulu must be taken on the sample difference! Bug-Url: https://bugzilla.redhat.com/1062166 Change-Id: Ie356d5f96c73b65925b38f6149d5eb36f43023ad Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25960 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Tested-by: Martin Pavlik xpavl...@gmail.com (cherry picked from commit d0c9357bbf6b6c61dc633edba6691a53b592e895) --- M vdsm/vm.py 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/26091/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 529b1bc..debc874 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -618,12 +618,12 @@ ifStats['txDropped'] = str(eInfo[nic.name][7]) ifRxBytes = (100.0 * - (eInfo[nic.name][0] - sInfo[nic.name][0]) % - 2 ** 32 / + ((eInfo[nic.name][0] - sInfo[nic.name][0]) % + 2 ** 32) / sampleInterval / ifSpeed / self.MBPS_TO_BPS) ifTxBytes = (100.0 * - (eInfo[nic.name][4] - sInfo[nic.name][4]) % - 2 ** 32 / + ((eInfo[nic.name][4] - sInfo[nic.name][4]) % + 2 ** 32) / sampleInterval / ifSpeed / self.MBPS_TO_BPS) ifStats['rxRate'] = '%.1f' % ifRxBytes -- To view, visit http://gerrit.ovirt.org/26091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie356d5f96c73b65925b38f6149d5eb36f43023ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pre-start: touch/configure vdsm logs
oVirt Jenkins CI Server has posted comments on this change. Change subject: pre-start: touch/configure vdsm logs .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6850/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7640/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7750/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca927cb447eeb24195cff6a1174e0f9a7295214 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Ryan Barry rba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add hook for fake VM stats
Barak Azulay has posted comments on this change. Change subject: hooks: Add hook for fake VM stats .. Patch Set 6: Code-Review-1 This hook intends to simulate a single fake vm statistics, Such a hook is required to test hosl level scale with fake host (see faqemu hook). This brings up 2 different issues: 1 - in a scaled environment when one might execute big number of fake VMs this hook will be called per vm (hence process invocation write to disk). when this happens for 100 VMs this might pause a scale issue for the fake host, especially when this call is done every few seconds from the engine). so I would suggest to have a getAllVmStats hook. 2 - such a hook should also fake the internal stats reported by the guest Agent -- To view, visit http://gerrit.ovirt.org/25927 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a6d13f43495170a5cb86ae0b0efc1ae85ef05ab Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: netconfig: set ETHTOOL_OPTS when a NIC goes up
Dan Kenigsberg has uploaded a new change for review.
Change subject: netconfig: set ETHTOOL_OPTS when a NIC goes up
..
netconfig: set ETHTOOL_OPTS when a NIC goes up
There's broken hardware out there where lro needs to to be turned off
explicitly.
This patch lets an admin of a local node set
ethtool_opts.eth0 = lro off
to disable LRO on the interface named eth0.
This patch includes a substantial fix based on
Iac6646bbad8c7431ec1c035ebc01f0180a8338ee by Antoni S. Puimedon.
Bug-Url: https://bugzilla.redhat.com/1059680
Change-Id: Ic8a5a933e1c93f80185d61f3cd43eee53c3a7c1a
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
Signed-off-by: Dan Kenigsberg dan...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/23366
Reviewed-on: http://gerrit.ovirt.org/23792
Reviewed-on: http://gerrit.ovirt.org/23761
Reviewed-by: Yaniv Bronhaim ybron...@redhat.com
---
M lib/vdsm/config.py.in
M vdsm/netconf/__init__.py
M vdsm/netconf/ifcfg.py
3 files changed, 21 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/26092/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 7d85232..afe2670 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -47,6 +47,12 @@
'NetworkManager is disabled and device name persistence does '
'not depend on HWADDR.'),
+('ethtool_opts', '',
+'Which special ethtool options should be applied to NICs after '
+'they are taken up, e.g. lro off on buggy devices. '
+'To apply options to a single interface, '
+'set ethtool_opts.iface_name.'),
+
('nic_model', 'rtl8139,pv',
'NIC model is rtl8139, ne2k_pci pv or any other valid device '
'recognized by kvm/qemu if a coma separated list given then a '
diff --git a/vdsm/netconf/__init__.py b/vdsm/netconf/__init__.py
index b614183..5520d01 100644
--- a/vdsm/netconf/__init__.py
+++ b/vdsm/netconf/__init__.py
@@ -17,12 +17,14 @@
# Refer to the README and COPYING files for full details of the license
#
+import ConfigParser
import logging
from netmodels import Bond, Bridge
from sourceRoute import StaticSourceRoute
from sourceRoute import DynamicSourceRoute
from vdsm import netinfo
+from vdsm.config import config
class Configurator(object):
@@ -120,3 +122,11 @@
else:
self.configApplier.setIfaceMtu(iface.name, maxMtu)
return maxMtu
+
+
+def getEthtoolOpts(name):
+try:
+opts = config.get('vars', 'ethtool_opts.' + name)
+except ConfigParser.NoOptionError:
+opts = config.get('vars', 'ethtool_opts')
+return opts
diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py
index 06bdba4..f823671 100644
--- a/vdsm/netconf/ifcfg.py
+++ b/vdsm/netconf/ifcfg.py
@@ -29,7 +29,7 @@
import threading
import dsaversion
-from netconf import Configurator
+from netconf import Configurator, getEthtoolOpts
from neterrors import ConfigNetworkError
from netmodels import Nic, Bridge, IpConfig
from sourceRoute import DynamicSourceRoute
@@ -574,6 +574,10 @@
if nic.bond:
conf += 'MASTER=%s\nSLAVE=yes\n' % pipes.quote(nic.bond.name)
+ethtool_opts = getEthtoolOpts(nic.name)
+if ethtool_opts:
+conf += 'ETHTOOL_OPTS=%s\n' % pipes.quote(ethtool_opts)
+
ipconfig, mtu = self._getIfaceConfValues(nic, _netinfo)
self._createConfFile(conf, nic.name, ipconfig, mtu, **opts)
--
To view, visit http://gerrit.ovirt.org/26092
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8a5a933e1c93f80185d61f3cd43eee53c3a7c1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: netconfig: set ETHTOOL_OPTS when a NIC goes up
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconfig: set ETHTOOL_OPTS when a NIC goes up .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1178/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8a5a933e1c93f80185d61f3cd43eee53c3a7c1a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Francesco Romani has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 6: -Code-Review Verified-1 -1 is not enough, so un-ticking verified until discussion has taken place -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Dan Kenigsberg has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/26089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: performance: switch to cPickle
Francesco Romani has posted comments on this change. Change subject: performance: switch to cPickle .. Patch Set 6: Code-Review-1 self-inflicted -1 until proper discussion on vdsm-devel about performance benefits -- To view, visit http://gerrit.ovirt.org/25860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b4b7d600c8432c948b795adad0459c318c8164b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tools: configurator must persist usermod changes
Douglas Schilling Landgraf has abandoned this change. Change subject: tools: configurator must persist usermod changes .. Abandoned We are going to use http://gerrit.ovirt.org/#/c/26089/ -- To view, visit http://gerrit.ovirt.org/25974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id4a7dea08bac41ff557aa52826463f2bdf481562 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Francesco Romani has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 10: I had the chance to run this code together with 21790 and some other minor unrelated patches. I did: * (intense) test of VM startup/shutdown during benchmarking * recovering: started a VM, restarted VDSM while VM was running * migration source/destination * suspension (hibernation) and re-starting from suspension. Let me know if this can be enough for verification or, if not, if I can help with some more tests. -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
Francesco Romani has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 9: I had the chance to run this code together with 21792 and some other minor unrelated patches. I did: * (intense) test of VM startup/shutdown during benchmarking * recovering: started a VM, restarted VDSM while VM was running * migration source/destination * suspension (hibernation) and re-starting from suspension. Let me know if this can be enough for verification or, if not, if I can help with some more tests. -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert vm status strings to constants
Francesco Romani has posted comments on this change. Change subject: Convert vm status strings to constants .. Patch Set 9: Code-Review+1 considering also my previous comment, looks fine. -- To view, visit http://gerrit.ovirt.org/21790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95e6945c2ee9d443e22586f04dc0f9646cc5cbb3 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 2: Verified+1 Generated a ISO, after install the groups were added correct. Second test, registered the node and after the reboot vdsm is up and running. -- To view, visit http://gerrit.ovirt.org/26089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move virt things into vdsm/virt
Francesco Romani has posted comments on this change. Change subject: Move virt things into vdsm/virt .. Patch Set 10: Code-Review+1 considering also my previous comment, looks OK. -- To view, visit http://gerrit.ovirt.org/21792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdfaefbe8837d2059674fdc4dc83fca431d76f8d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: use sanlock user constant
Douglas Schilling Landgraf has posted comments on this change. Change subject: configurator: use sanlock user constant .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/26080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43464961cba6b6b761a98ad4b72a271228914ca1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pre-start: touch/configure vdsm logs
Douglas Schilling Landgraf has posted comments on this change. Change subject: pre-start: touch/configure vdsm logs .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/25912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca927cb447eeb24195cff6a1174e0f9a7295214 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Ryan Barry rba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pre-start: touch/configure vdsm logs
oVirt Jenkins CI Server has posted comments on this change. Change subject: pre-start: touch/configure vdsm logs .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6851/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7641/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7751/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca927cb447eeb24195cff6a1174e0f9a7295214 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Ryan Barry rba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
Dan Kenigsberg has submitted this change and it was merged. Change subject: configurator: move usermod to spec .. configurator: move usermod to spec vdsm-tool configure --force adds to /etc/group (qemu/kvm) sanlock but doesn't persist the file in ovirt node distro which will affect vdsm start on next reboot. This patch adds the usermod to spec file. Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/26089 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator: move usermod to spec
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator: move usermod to spec .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/412/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a44a8a4d3301263beeb03e1d106c25ffe85263e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pre-start: touch/configure vdsm logs
Dan Kenigsberg has submitted this change and it was merged. Change subject: pre-start: touch/configure vdsm logs .. pre-start: touch/configure vdsm logs During pre-start of vdsm we must create vdsm logs files with proper perms/user/group/ if they doesn't exist. This situation happens currently because during ovirt node build it cleans /var/log dir so it will remove all vdsm logs created during rpm install. Change-Id: I6ca927cb447eeb24195cff6a1174e0f9a7295214 Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Reviewed-on: http://gerrit.ovirt.org/25912 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M configure.ac M init/vdsmd_init_common.sh.in 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/25912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ca927cb447eeb24195cff6a1174e0f9a7295214 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Ryan Barry rba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pre-start: touch/configure vdsm logs
Dan Kenigsberg has posted comments on this change. Change subject: pre-start: touch/configure vdsm logs .. Patch Set 7: Code-Review+2 According to Douglas, this was verified with http://gerrit.ovirt.org/#/c/26089/ . I hate the patch, we should have https://bugzilla.redhat.com/show_bug.cgi?id=1080580 fixed properly. -- To view, visit http://gerrit.ovirt.org/25912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca927cb447eeb24195cff6a1174e0f9a7295214 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Fabian Deutsch fabi...@fedoraproject.org Gerrit-Reviewer: Kiril Nesenko knese...@redhat.com Gerrit-Reviewer: Ryan Barry rba...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
