Change in vdsm[master]: vm: add optimizations for hyperv
Michal Skrivanek has posted comments on this change. Change subject: vm: add optimizations for hyperv .. Patch Set 1: do we know exact host versions where all those are supported? -- To view, visit http://gerrit.ovirt.org/27619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28ea1d5adeda07798255484209e1a1d92c2c2bc5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add execCmd sync mode failing stress tests
Nir Soffer has posted comments on this change. Change subject: utils: Add execCmd sync mode failing stress tests .. Patch Set 2: Verified+1 Changes: - Simplify the way to pass data to a test function - Remove duplicate code running dd - Update the commit message with test runs from 2 8 cores machines. Verified by running the tests with the next patch. -- To view, visit http://gerrit.ovirt.org/27784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57ebd5faf028ccfc928a8b2e7ae47008f0970c23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Decrease cpu usage when executing commands
Nir Soffer has posted comments on this change. Change subject: utils: Decrease cpu usage when executing commands .. Patch Set 11: Rebase, no code change. -- To view, visit http://gerrit.ovirt.org/27553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ecf1f27d8434aeae672e92ec7adb12e52e419a9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Add execCmd sync mode failing stress tests
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Add execCmd sync mode failing stress tests .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8928/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9069/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8140/ : FAILURE -- To view, visit http://gerrit.ovirt.org/27784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57ebd5faf028ccfc928a8b2e7ae47008f0970c23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Decrease cpu usage when executing commands
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Decrease cpu usage when executing commands .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8927/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9068/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8139/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ecf1f27d8434aeae672e92ec7adb12e52e419a9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Decrease cpu usage when executing commands
Nir Soffer has posted comments on this change. Change subject: utils: Decrease cpu usage when executing commands .. Patch Set 11: Note that the new crazy execCmd tests using 200 threads pass now even on jenkins. -- To view, visit http://gerrit.ovirt.org/27553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ecf1f27d8434aeae672e92ec7adb12e52e419a9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Nir Soffer has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 1: Code-Review+1 Nice, easy to review. -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add the cmd get-ca-issuer
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: add the cmd get-ca-issuer .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27651/2/lib/vdsm/tool/validate_ovirt_certs.py.in File lib/vdsm/tool/validate_ovirt_certs.py.in: Line 71: cmd = [ Line 72: EX_OPENSSL, 'x509', '-in', PATH_CACERT, '-noout', '-issuer' Line 73: ] Line 74: rc, out, err = execCmd(cmd, raw=True) Line 75: if not err: It is better practice to check rc value. -- To view, visit http://gerrit.ovirt.org/27651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70a19f54169498c53cabba0ac75e7a5611762ece Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Cleanup command logging
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: Cleanup command logging .. utils: Cleanup command logging A new dictionary was created for selecting the "SUCCESS" or "FAILED" message for the debug log. This is pointless when debug messages are not logged. Replaced with nicer and probably more efficient conditional expression. repr(err) was invoked even when debug messages are not logged. Use now %r format, so conversion is done only when log message is formatted. Change-Id: Ia5cbe6c380a5427dd69a3efbceea4ea8e35783ab Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/27757 Reviewed-by: Dan Kenigsberg --- M lib/vdsm/utils.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5cbe6c380a5427dd69a3efbceea4ea8e35783ab Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Cleanup command logging
Dan Kenigsberg has posted comments on this change. Change subject: utils: Cleanup command logging .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/27757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5cbe6c380a5427dd69a3efbceea4ea8e35783ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Cleanup command logging
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Cleanup command logging .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1311/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5cbe6c380a5427dd69a3efbceea4ea8e35783ab Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Test profile decorator format
Nir Soffer has uploaded a new change for review. Change subject: profile: Test profile decorator format .. profile: Test profile decorator format The option to set profile format using a profile decorator was not tested. Lets test it before we add new options to this decorator. Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Signed-off-by: Nir Soffer --- M tests/profileTests.py 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/27786/1 diff --git a/tests/profileTests.py b/tests/profileTests.py index 6bbb24f..d1760f7 100644 --- a/tests/profileTests.py +++ b/tests/profileTests.py @@ -138,6 +138,13 @@ requires_yappi() self.assertRaises(profile.Error, self.recursive_profile) +@MonkeyPatch(profile, 'config', make_config(enable='false')) +def test_ystat_format(self): +requires_yappi() +self.ystat_foramt() +stats = yappi.YFuncStats() +stats.add(FILENAME) + @profile.profile(FILENAME) def profiled_function(self): self.assertTrue(profile.is_running()) @@ -145,3 +152,7 @@ @profile.profile(FILENAME) def recursive_profile(self): self.profiled_function() + +@profile.profile(FILENAME, format="ystat") +def ystat_foramt(self): +pass -- To view, visit http://gerrit.ovirt.org/27786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Test profile decorator format
Nir Soffer has posted comments on this change. Change subject: profile: Test profile decorator format .. Patch Set 1: Verified+1 Verified by running the tests. -- To view, visit http://gerrit.ovirt.org/27786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Test profile decorator format
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Test profile decorator format .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8929/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9070/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8141/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6564002efd6ea5dbd2e643623f84e4e5030df48a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi builtins option
Nir Soffer has uploaded a new change for review.
Change subject: profile: Support yappi builtins option
..
profile: Support yappi builtins option
yappi support profiling also builtin python functions. This patch adds a
new configuration value to enable profiling builtins in an application
wide profile, and a new builtins kwarg to the profile decorator.
This option can be handy when trying to understand why code is
expensive.
Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca
Signed-off-by: Nir Soffer
---
M lib/vdsm/config.py.in
M lib/vdsm/profile.py
M tests/profileTests.py
3 files changed, 66 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/27787/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 0656404..01d5580 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -35,6 +35,10 @@
('profile_format', 'pstat',
'Profile file format (pstat, callgrind, ystat)'),
+('profile_builtins', 'false',
+'Profile builtin functions used by standart Python modules. '
+'false by default.'),
+
('host_mem_reserve', '256',
'Reserves memory for the host to prevent VMs from using all the '
'physical pages. The values are in Mbytes.'),
diff --git a/lib/vdsm/profile.py b/lib/vdsm/profile.py
index dbdf81a..809e1dc 100644
--- a/lib/vdsm/profile.py
+++ b/lib/vdsm/profile.py
@@ -35,6 +35,7 @@
_FILENAME = os.path.join(constants.P_VDSM_RUN, 'vdsmd.prof')
_FORMAT = config.get('vars', 'profile_format')
+_BUILTINS = config.getboolean('vars', 'profile_builtins')
_lock = threading.Lock()
@@ -46,7 +47,7 @@
def start():
""" Starts application wide profiling """
if is_enabled():
-_start_profiling()
+_start_profiling(builtins=_BUILTINS)
def stop():
@@ -64,7 +65,7 @@
return yappi and yappi.is_running()
-def profile(filename, format=_FORMAT):
+def profile(filename, format=_FORMAT, builtins=False):
"""
Profile decorated function, saving profile to filename using format.
@@ -74,7 +75,7 @@
def decorator(f):
@wraps(f)
def wrapper(*a, **kw):
-_start_profiling()
+_start_profiling(builtins=builtins)
try:
return f(*a, **kw)
finally:
@@ -83,7 +84,7 @@
return decorator
-def _start_profiling():
+def _start_profiling(builtins=False):
global yappi
logging.debug("Starting profiling")
with _lock:
@@ -93,7 +94,7 @@
# that thinks they own the single process profiler.
if yappi.is_running():
raise Error('Profiler is already running')
-yappi.start()
+yappi.start(builtins=builtins)
def _stop_profiling(filename, format):
diff --git a/tests/profileTests.py b/tests/profileTests.py
index d1760f7..cf9abbf 100644
--- a/tests/profileTests.py
+++ b/tests/profileTests.py
@@ -19,6 +19,7 @@
#
import ConfigParser
+import StringIO
import errno
import os
import pstats
@@ -86,6 +87,30 @@
@MonkeyPatch(profile, 'config', make_config(enable='true'))
@MonkeyPatch(profile, '_FILENAME', FILENAME)
+@MonkeyPatch(profile, '_FORMAT', 'pstat')
+@MonkeyPatch(profile, '_BUILTINS', True)
+def test_with_builtins(self):
+requires_yappi()
+profile.start()
+dict()
+profile.stop()
+out = read_pstats(FILENAME)
+self.assertIn('__builtin__:0', out)
+
+@MonkeyPatch(profile, 'config', make_config(enable='true'))
+@MonkeyPatch(profile, '_FILENAME', FILENAME)
+@MonkeyPatch(profile, '_FORMAT', 'pstat')
+@MonkeyPatch(profile, '_BUILTINS', False)
+def test_without_builtins(self):
+requires_yappi()
+profile.start()
+dict()
+profile.stop()
+out = read_pstats(FILENAME)
+self.assertNotIn('__builtin__:0', out)
+
+@MonkeyPatch(profile, 'config', make_config(enable='true'))
+@MonkeyPatch(profile, '_FILENAME', FILENAME)
def test_is_running(self):
requires_yappi()
self.assertFalse(profile.is_running())
@@ -145,6 +170,20 @@
stats = yappi.YFuncStats()
stats.add(FILENAME)
+@MonkeyPatch(profile, 'config', make_config(enable='false'))
+def test_with_builtins(self):
+requires_yappi()
+self.with_builtins()
+out = read_pstats(FILENAME)
+self.assertIn('__builtin__:0', out)
+
+@MonkeyPatch(profile, 'config', make_config(enable='false'))
+def test_without_builtins(self):
+requires_yappi()
+self.without_builtins()
+out = read_pstats(FILENAME)
+self.assertNotIn('__builtin__:0', out)
+
@profile.profile(FILENAME)
def profiled_function(self):
self.assertTrue(profile.is_running())
@@ -156,3 +195,20 @@
@profile.profile(FILENAME, format="ystat")
def ystat_foramt(self):
Change in vdsm[master]: profile: Support yappi builtins option
Nir Soffer has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 1: Verified+1 Verified by the tests. -- To view, visit http://gerrit.ovirt.org/27787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi builtins option
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8930/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9071/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8142/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi builtins option
Nir Soffer has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 2: Verified+1 Make argument passing more consistent. You can set the default either through the config or through the decorator. Lower level function require the builtins argument so we don't have multiple places when this value has a default. -- To view, visit http://gerrit.ovirt.org/27787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi builtins option
oVirt Jenkins CI Server has posted comments on this change. Change subject: profile: Support yappi builtins option .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8931/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9072/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8143/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profile: Support yappi builtins option
Nir Soffer has posted comments on this change.
Change subject: profile: Support yappi builtins option
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27787/2/tests/profileTests.py
File tests/profileTests.py:
Line 94: profile.start()
Line 95: dict()
Line 96: profile.stop()
Line 97: out = read_pstats(FILENAME)
Line 98: self.assertIn('__builtin__:0', out)
I hate this way of testing, but it was way faster then understand how to
iterate on the contents of yappi.YFuncStats object. I'll check how to do this
in a later patch.
Line 99:
Line 100: @MonkeyPatch(profile, 'config', make_config(enable='true'))
Line 101: @MonkeyPatch(profile, '_FILENAME', FILENAME)
Line 102: @MonkeyPatch(profile, '_FORMAT', 'pstat')
--
To view, visit http://gerrit.ovirt.org/27787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67c6fc52ac64f8ff7f13471a53129a66361192ca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: add the cmd get-ca-issuer
Nir Soffer has posted comments on this change. Change subject: vdsm-tool: add the cmd get-ca-issuer .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27651/2/lib/vdsm/tool/validate_ovirt_certs.py.in File lib/vdsm/tool/validate_ovirt_certs.py.in: Line 71: cmd = [ Line 72: EX_OPENSSL, 'x509', '-in', PATH_CACERT, '-noout', '-issuer' Line 73: ] Line 74: rc, out, err = execCmd(cmd, raw=True) Line 75: if not err: > It is better practice to check rc value. It is bad practice - please fix. -- To view, visit http://gerrit.ovirt.org/27651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70a19f54169498c53cabba0ac75e7a5611762ece Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
