Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize
Daniel Erez has posted comments on this change. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28382/1//COMMIT_MSG Commit Message: Line 14: QImgError: ecode=1, stdout=[], stderr=[ Line 15:"Could not open '(image path)': No such file or directory"] Line 16: Line 17: Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Line 18: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1097819 > BZ should be cloned to 3.4.z Done Line 19: Signed-off-by: Federico Simoncelli Line 20: Reviewed-on: http://gerrit.ovirt.org/28009 Line 21: Reviewed-by: Kevin Wolf -- To view, visit http://gerrit.ovirt.org/28382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Kevin Wolf Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: virt: Ensure not to handle no longer tracked fds in epoll
Yaniv Bronhaim has submitted this change and it was merged. Change subject: virt: Ensure not to handle no longer tracked fds in epoll .. virt: Ensure not to handle no longer tracked fds in epoll In some cases it is possible that events from epoll are received before the socket is closed. This patch ensures that we're ignoring events which belong to fds we are not tracking (anymore). Change-Id: Idde0f89d2859107dd1bb697d1753709137335677 Bug-Url: https://bugzilla.redhat.com/1102072 Signed-off-by: Vinzenz Feenstra Reviewed-on: http://gerrit.ovirt.org/28179 Reviewed-by: Francesco Romani Reviewed-by: Michal Skrivanek Reviewed-by: Gal Hammer Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/28297 Reviewed-by: Yaniv Bronhaim --- M vdsm/vmChannels.py 1 file changed, 13 insertions(+), 9 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Vinzenz Feenstra: Verified Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idde0f89d2859107dd1bb697d1753709137335677 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gal Hammer Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: virt: Ensure not to handle no longer tracked fds in epoll
Yaniv Bronhaim has posted comments on this change. Change subject: virt: Ensure not to handle no longer tracked fds in epoll .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde0f89d2859107dd1bb697d1753709137335677 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gal Hammer Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize
Yaniv Bronhaim has submitted this change and it was merged. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. blockVolume: prepare volumes for shrinkToOptimalSize The qemu-img check command needs the entire volume chain in order to be able to open the image. Up until now shrinkToOptimalSize worked only for base volumes, in the other cases it was failing with: QImgError: ecode=1, stdout=[], stderr=[ "Could not open '(image path)': No such file or directory"] Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1105848 Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/28009 Reviewed-by: Kevin Wolf Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/28382 Tested-by: Daniel Erez Reviewed-by: Allon Mureinik Reviewed-by: Yaniv Bronhaim --- M vdsm/storage/blockVolume.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Kevin Wolf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize
Yaniv Bronhaim has posted comments on this change. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Kevin Wolf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: hsm: unify vm ovf management lock
Yaniv Bronhaim has posted comments on this change. Change subject: hsm: unify vm ovf management lock .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia857d4afa25e7eebd59fb10ef31e98c25caa9928 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: hsm: unify vm ovf management lock
Yaniv Bronhaim has submitted this change and it was merged. Change subject: hsm: unify vm ovf management lock .. hsm: unify vm ovf management lock Taking one lock per VM definition could be extremely slow (especially when the engine sends 100 ovf). In one case it took more than 3 minutes to take 76 locks. This patch unifies the VM locks into a generic one. There was no real advantage in the current implementation, in fact if by any chance updateVM was stuck trying to persist a VM definition it is understood that also removeVM would get stuck at file-system level. Moreover storing 100 ovf is a quite fast operation (if it doesn't get stuck) and it is not supposed to starve removeVM. Multiple removeVM calls are still executed in parallel because the generic lock is acquired in shared mode. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1103844 Relates-To: https://bugzilla.redhat.com/show_bug.cgi?id=1100527 Change-Id: Ia857d4afa25e7eebd59fb10ef31e98c25caa9928 Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/28068 Reviewed-by: Dan Kenigsberg Signed-off-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/28379 Reviewed-by: Allon Mureinik Reviewed-by: Yaniv Bronhaim --- M vdsm/storage/hsm.py 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Federico Simoncelli: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/28379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia857d4afa25e7eebd59fb10ef31e98c25caa9928 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ifcfg: Put hotplug=no for virtual devices
Yaniv Bronhaim has submitted this change and it was merged. Change subject: ifcfg: Put hotplug=no for virtual devices .. ifcfg: Put hotplug=no for virtual devices In el6 systems, udev can trigger an ifup call when a device is created. The issue with the triggering is that when we create a virtual device, e.g. a vlan, we do so via ifup, so what will happen is: we write ethX.Y initscripts creates the vlan device with id Y on top of ethX. udev detects the new device | Process 1 | Process 2 initscripts finished doing udev calls initscripts' ifup ifup, possibly calling dhclientfor the new vlan device initscripts possibly calls dhclient The issue is that the two processes can do the dhclient in whichever order and one dhclient will prevent the other from succeeding. Only one ifup should be called for each device, so we need hotplug=no to prevent Process 2 from succeeding in its ifup. Our current usage of ifcfg files does not set hotplug=no so that when the user replaces a physical card by hot-unplugging and hot-plugging there will be an auto configuration. This behavior is maintained by the fact that we only set hotplug=no for those devices for which we control the whole life cycle, i.e., vlans, bonds and bridges. Bug-Url: https://bugzilla.redhat.com/1097818 Change-Id: I6a60bb8d461572855c951fff8c991e34e0feb332 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/27980 Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/28438 --- M vdsm/netconf/ifcfg.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a60bb8d461572855c951fff8c991e34e0feb332 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: virt: Ensure not to handle no longer tracked fds in epoll
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Ensure not to handle no longer tracked fds in epoll .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/222/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde0f89d2859107dd1bb697d1753709137335677 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Gal Hammer Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ifcfg: remove and re-create bonds when they are not to be de...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: ifcfg: remove and re-create bonds when they are not to be destroyed .. ifcfg: remove and re-create bonds when they are not to be destroyed In order to make sure that bonds that should be left undestroyed, but do not have users, are set with the default options and devoid of any previous configuration, we delete the bond and its ifcfg file and create new ones. Bug-Url: https://bugzilla.redhat.com/1105645 Change-Id: If897e1ad96737916a6e440664295694790e2226a Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/28062 Reviewed-by: Dan Kenigsberg Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/28439 --- M vdsm/netconf/ifcfg.py 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Antoni Segura Puimedon: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If897e1ad96737916a6e440664295694790e2226a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: Fix memShared units when reported from MOM
Yaniv Bronhaim has posted comments on this change. Change subject: Fix memShared units when reported from MOM .. Patch Set 1: do we still consider taking it ?.. please abandon if not -- To view, visit http://gerrit.ovirt.org/28267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6a68221d74192c38de158fca4d5f96f268150ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Martin Sivák Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: blockVolume: prepare volumes for shrinkToOptimalSize
oVirt Jenkins CI Server has posted comments on this change. Change subject: blockVolume: prepare volumes for shrinkToOptimalSize .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/223/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9fceee28932da6895829c7e7efadb735c1ec060 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Kevin Wolf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: hsm: unify vm ovf management lock
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: unify vm ovf management lock .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/224/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia857d4afa25e7eebd59fb10ef31e98c25caa9928 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ifcfg: Put hotplug=no for virtual devices
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: Put hotplug=no for virtual devices .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/225/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a60bb8d461572855c951fff8c991e34e0feb332 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: ifcfg: remove and re-create bonds when they are not to be de...
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: remove and re-create bonds when they are not to be destroyed .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/226/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If897e1ad96737916a6e440664295694790e2226a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Alon Bar-Lev has posted comments on this change. Change subject: vdsm-tool: vdsm-id: add force option to force generate id .. Patch Set 10: rebase -- To view, visit http://gerrit.ovirt.org/20808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Alon Bar-Lev has posted comments on this change. Change subject: utils: add ovirt-node persistence functions .. Patch Set 3: rebase -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report legacy bond devices instead of actually creating them
Antoni Segura Puimedon has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 1: Code-Review-1 (5 comments) Some insignificant issues and one test suggestion. Thanks for this patch. I'm glad to get rid of this! http://gerrit.ovirt.org/#/c/28455/1//COMMIT_MSG Commit Message: Line 6: Line 7: Report legacy bond devices instead of actually creating them Line 8: Line 9: Engine <= 3.2 expects to see bonding devices bond0-bond4 predefined on Line 10: each host. Therefor, Vdsm creates them on boot, and never deletes them. I believe this "Therefor" should be "Therefore", it fits more to the meaning. Line 11: This add cumbersome logic, which has lead to bugs. Line 12: Line 13: Instead, this patch simply reports the existence of the 5 expected Line 14: bonds, instead of actually creating them. http://gerrit.ovirt.org/#/c/28455/1/lib/vdsm/tool/load_needed_modules.py.in File lib/vdsm/tool/load_needed_modules.py.in: Line 1: # Copyright IBM, Corp. 2012 I think we can add RedHat 2014 ;-) Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or http://gerrit.ovirt.org/#/c/28455/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1: # Line 2: # Copyright 2013 Red Hat, Inc. 2013-2014 Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; either version 2 of the License, or Line 6: # (at your option) any later version. Line 262: def assertMtu(self, mtu, *elems): Line 263: for elem in elems: Line 264: self.assertEquals(int(mtu), int(self.vdsm_net.getMtu(elem))) Line 265: Line 266: @cleanupNet I don't think that this test needs any cleanup. Line 267: def testLegacyBonds(self): Line 268: for b in _REQUIRED_BONDINGS: Line 269: self.assertBondExists(b, []) Line 270: http://gerrit.ovirt.org/#/c/28455/1/vdsm/caps.py File vdsm/caps.py: Line 1: # Line 2: # Copyright 2011 Red Hat, Inc. 2011-2014 Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or -- To view, visit http://gerrit.ovirt.org/28455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4028a70cc8fd3e0599f02ac339a783a7d85f045e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add ovirt-node persistence functions .. Patch Set 3: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9761/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8823/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9608/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1110/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: vdsm-id: add force option to force generate id .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9762/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8824/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9609/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit// : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/20808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add ovirt-node persistence functions .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9763/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9610/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1112/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-tool: vdsm-id: add force option to force generate id .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9764/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8826/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9611/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1113/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/20808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: oop: Add an option to configure oop implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 19: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9765/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8827/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9612/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1114/ : The patch does not pass the storage functional tests -- To view, visit http://gerrit.ovirt.org/26576 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd756afd43d23631dc7ed4bac64bec9a81b358b4 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ioprocess implementation
oVirt Jenkins CI Server has posted comments on this change. Change subject: ioprocess implementation .. Patch Set 17: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9766/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8828/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9613/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1115/ : The patch does not pass the storage functional tests -- To view, visit http://gerrit.ovirt.org/26967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I132129315c73e880d998a13f84e822a9d4fec2a6 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
mooli tayer has posted comments on this change. Change subject: utils: add ovirt-node persistence functions .. Patch Set 4: It is not clear to me when ovirtNodePersist and ovirtNodeUnpersist should be called. could you explain about it in the doc string? Should ovirtNodePersist be called when calling chmod? -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods and conf for CPU limit MOM integration
Dan Kenigsberg has posted comments on this change.
Change subject: Adding API methods and conf for CPU limit MOM integration
..
Patch Set 32: Code-Review-1
(1 comment)
Please break to a patch per new api.
http://gerrit.ovirt.org/#/c/27258/32/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 311: def _getCpuTuneInfo(self, stats):
Line 312: ret = {}
Line 313: try:
Line 314: if self._dom:
Line 315: ret = self._dom.schedulerParameters()
You must not access the _dom object within the context of getAllVmStats, as a
single blocked VM was DoS the whole node.
Line 316:
Line 317: if ret['vcpu_quota'] is None:
Line 318: ret['vcpu_quota'] = -1
Line 319:
--
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Doron Fediuck
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Alon Bar-Lev has posted comments on this change. Change subject: utils: add ovirt-node persistence functions .. Patch Set 4: ovirtNodePersist - if you add a new file at /etc, please be aware that once it is persisted you can only modify file in place, you cannot rename or move file into ovirtNodeUnPersist - if you want to remove a file at /etc -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Additional oop functionality
oVirt Jenkins CI Server has posted comments on this change. Change subject: Additional oop functionality .. Patch Set 11: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9767/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8829/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9614/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1116/ : The patch does not pass the storage functional tests -- To view, visit http://gerrit.ovirt.org/27641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I438f01236767e807f010be7531678ee5b1a05056 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Final separation of IOProcess and RFH
oVirt Jenkins CI Server has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9768/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8830/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/689/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9615/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1117/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief85d2dca2d22058c4ed2504e49dc3dd62547532 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add ovirt-node persistence functions .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9769/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8831/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9616/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1118/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove redundant print
Yaniv Bronhaim has posted comments on this change. Change subject: Remove redundant print .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28406 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6df376664ffcda66ea19f66e28edc0521566c091 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods and conf for CPU limit MOM integration .. Patch Set 33: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9770/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8832/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9617/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/649/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1119/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
please add short comment what persist means in this scope, and what unpersist
allows you to do and why it is useful
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Kobi Ianko has uploaded a new change for review.
Change subject: Adding API methods for CPU limit MOM integration
..
Adding API methods for CPU limit MOM integration
Adding API methods to vm.py to integrate with MOM's collectors and controllers
Two new functions were added to the vdsm api:
VM.setCpuTuneQuota
This function sets a new quota value to the VM using the libvirt api.
Input: a Int value representing the quota as explained
at "http://libvirt.org/formatdomain.html#elementsCPUTuning";.
VM.setCpuTunePeriod
This function sets a new period value to the VM using libvirt api.
Input: a Int value representing the period as explained
at "http://libvirt.org/formatdomain.html#elementsCPUTuning";.
Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08
Signed-off-by: Kobi Ianko
---
M vdsm/API.py
M vdsm/virt/vm.py
M vdsm_api/vdsmapi-schema.json
3 files changed, 86 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/28462/1
diff --git a/vdsm/API.py b/vdsm/API.py
index c43c1d0..f312a4a 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -690,6 +690,18 @@
return errCode['noVM']
return v.setBalloonTarget(target)
+def setCpuTuneQuota(self, quota):
+v = self._cif.vmContainer.get(self._UUID)
+if not v:
+return errCode['noVM']
+return v.setCpuTuneQuota(quota)
+
+def setCpuTunePeriod(self, period):
+v = self._cif.vmContainer.get(self._UUID)
+if not v:
+return errCode['noVM']
+return v.setCpuTunePeriod(period)
+
def getDiskAlignment(self, drive):
if self._UUID != VM.BLANK_UUID:
return errCode['noimpl']
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4a6813e..d882fd2 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4471,26 +4471,18 @@
def setBalloonTarget(self, target):
-def reportError(key='balloonErr', msg=None):
-self.log.error("Set new balloon target failed", exc_info=True)
-if msg is None:
-error = errCode[key]
-else:
-error = {'status': {'code': errCode[key]
- ['status']['code'], 'message': msg}}
-return error
-
if self._dom is None:
-return reportError()
+return self._reportError(entity='balloon target')
+target = int(target)
try:
-target = int(target)
self._dom.setMemory(target)
except ValueError:
-return reportError(msg='an integer is required for target')
+return self._reportError(msg='an integer is required for target',
+ entity='balloon target')
except libvirt.libvirtError as e:
if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
-return reportError(key='noVM')
-return reportError(msg=e.message)
+return self._reportError(key='noVM', entity='balloon target')
+return self._reportError(msg=e.message, entity='balloon target')
else:
for dev in self.conf['devices']:
if dev['type'] == BALLOON_DEVICES and \
@@ -4500,6 +4492,42 @@
self.saveState()
return {'status': doneCode}
+def setCpuTuneQuota(self, quota):
+
+if self._dom is None:
+return self._reportError(entity='vcpu quota')
+
+quota = int(quota)
+try:
+self._dom.setSchedulerParameters({'vcpu_quota': quota})
+return {'status': doneCode}
+except libvirt.libvirtError as e:
+return self._reportError(msg=e.message, entity='vcpu quota')
+
+def setCpuTunePeriod(self, period):
+
+if self._dom is None:
+return self._reportError(key='cpuTuneErr', entity='vcpu period')
+
+period = int(period)
+try:
+self._dom.setSchedulerParameters({'vcpu_period': period})
+return {'status': doneCode}
+except ValueError:
+return self._reportError(msg='an integer is required for period',
+ entity='vcpu period')
+except libvirt.libvirtError as e:
+return self._reportError(msg=e.message, entity='vcpu period')
+
+def _reportError(self, key='Err', msg=None, entity=None):
+self.log.error("Set new " + entity + " failed", exc_info=True)
+if msg is None:
+error = errCode[key]
+else:
+error = {'status': {'code': errCode[key]
+['status']['code'], 'message': msg}}
+return error
+
def _getUnderlyingDeviceAddress(self, devXml):
"""
Obtain device's address from libvirt
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 6457af8..e752cfa 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vds
Change in vdsm[master]: changes in configfile.py.
mooli tayer has uploaded a new change for review. Change subject: changes in configfile.py. .. changes in configfile.py. 1.) remove suffix space from '# VDSM backup '. This way we maintain backward comp with libvirt_configure.sh 2.) on ovirt node wrap calls to rename with ovirt node unpersist and persist. these calls use the new node namespace being ovirt.node.utils.fs.Config. Change-Id: I76aced9da7a68eefdb60b82907bc83d224e449f5 Signed-off-by: Mooli Tayer --- M lib/vdsm/tool/configfile.py 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/28463/1 diff --git a/lib/vdsm/tool/configfile.py b/lib/vdsm/tool/configfile.py index afeab02..9b5a703 100644 --- a/lib/vdsm/tool/configfile.py +++ b/lib/vdsm/tool/configfile.py @@ -25,6 +25,9 @@ import selinux import io +from .. import utils +if utils.isOvirtNode: +from ovirt.node.utils.fs import Config ( BEFORE, @@ -82,7 +85,7 @@ version, sectionStart='## beginning of configuration section by vdsm', sectionEnd='## end of configuration section by vdsm', - prefix='# VDSM backup ', + prefix='# VDSM backup', lineComment='by vdsm'): if not os.path.exists(filename): raise OSError( @@ -170,7 +173,13 @@ f.writelines(oldlines) if self._entries: self._writeEntries(f, oldentries) + +if utils.isOvirtNode(): +Config().unpersist(self._filename) os.rename(tname, self._filename) +if utils.isOvirtNode(): +Config().persist(self._filename) + if self._oldmod != os.stat(self._filename).st_mode: os.chmod(self._filename, self._oldmod) -- To view, visit http://gerrit.ovirt.org/28463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I76aced9da7a68eefdb60b82907bc83d224e449f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods and conf for CPU limit MOM integration .. Patch Set 34: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9771/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8833/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9618/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/650/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1120/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 34 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: extract reconfiguration of x is done to ver...
Yaniv Bronhaim has posted comments on this change. Change subject: configurator.py: extract reconfiguration of x is done to verb level. .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2eb2e1e889539571bd20cfb09ab1499333a47fd4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
Yaniv Bronhaim has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
Yaniv Bronhaim has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 23: Code-Review+1 (1 comment) hope i haven't miss more changes . but expect the naming, it seems alright http://gerrit.ovirt.org/#/c/27298/23/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 36: SANLOCK_ENABLED, LIBVIRT_SELINUX, P_VDSM Line 37: from vdsm.config import config Line 38: Line 39: if utils.isOvirtNode: Line 40: from ovirt.node.utils.fs import Config import as nodeCfg will be more easier to understand imo Line 41: Line 42: Line 43: class InvalidConfig(UsageError): Line 44: """ raise when invalid configuration passed """ -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
mooli tayer has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 23: (4 comments) http://gerrit.ovirt.org/#/c/27298/23/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 36: SANLOCK_ENABLED, LIBVIRT_SELINUX, P_VDSM Line 37: from vdsm.config import config Line 38: Line 39: if utils.isOvirtNode: Line 40: from ovirt.node.utils.fs import Config Douglas: looks right? Line 41: Line 42: Line 43: class InvalidConfig(UsageError): Line 44: """ raise when invalid configuration passed """ Line 36: SANLOCK_ENABLED, LIBVIRT_SELINUX, P_VDSM Line 37: from vdsm.config import config Line 38: Line 39: if utils.isOvirtNode: Line 40: from ovirt.node.utils.fs import Config > import as nodeCfg will be more easier to understand imo ybronhei: OK. (waiting for comments from Douglas) Line 41: Line 42: Line 43: class InvalidConfig(UsageError): Line 44: """ raise when invalid configuration passed """ Line 189: if os.path.isfile(TARGET): Line 190: oldmod = os.stat(TARGET).st_mode Line 191: Line 192: if utils.isOvirtNode(): Line 193: Config().unpersist(TARGET) Douglas: looks right? Line 194: shutil.copyfile(packaged, TARGET) Line 195: if utils.isOvirtNode(): Line 196: Config().persist(TARGET) Line 197: Line 301: delete a file if it exists. Line 302: """ Line 303: utils.rmFile(content['path']) Line 304: if utils.isOvirtNode(): Line 305: Config().unpersist(content['path']) Douglas: looks right? Line 306: Line 307: def _unprefixAndRemoveSection(self, path): Line 308: """ Line 309: undo changes done by _prefixAndPrepend. -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: sort imports alphabetically
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: sort imports alphabetically .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9773/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8835/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9620/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee51b9d3c2dd04824cc3dbb91a413f310f38523 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changes in configfile.py.
mooli tayer has posted comments on this change. Change subject: changes in configfile.py. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28463/1/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 174: if self._entries: Line 175: self._writeEntries(f, oldentries) Line 176: Line 177: if utils.isOvirtNode(): Line 178: Config().unpersist(self._filename) Douglas: looks right? Line 179: os.rename(tname, self._filename) Line 180: if utils.isOvirtNode(): Line 181: Config().persist(self._filename) Line 182: -- To view, visit http://gerrit.ovirt.org/28463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aced9da7a68eefdb60b82907bc83d224e449f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9619/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/651/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1121/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changes in configfile.py.
Yaniv Bronhaim has posted comments on this change. Change subject: changes in configfile.py. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28463/1/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 26: import io Line 27: Line 28: from .. import utils Line 29: if utils.isOvirtNode: Line 30: from ovirt.node.utils.fs import Config commented on the wrong patch. import it as nodeCfg Line 31: Line 32: ( Line 33: BEFORE, Line 34: WITHIN, -- To view, visit http://gerrit.ovirt.org/28463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aced9da7a68eefdb60b82907bc83d224e449f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurator.py: extract reconfiguration of x is done to ver...
oVirt Jenkins CI Server has posted comments on this change. Change subject: configurator.py: extract reconfiguration of x is done to verb level. .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9774/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8836/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9622/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27841 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2eb2e1e889539571bd20cfb09ab1499333a47fd4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ConfigFile.py: improve indentation of multiline if statments.
oVirt Jenkins CI Server has posted comments on this change. Change subject: ConfigFile.py: improve indentation of multiline if statments. .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9775/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8837/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9621/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3783bf50d55c54ec38c3240f66b4a14296f244a8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
oVirt Jenkins CI Server has posted comments on this change. Change subject: replace configure_libvirt.py with python code. .. Patch Set 23: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9776/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8838/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/690/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9624/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/27298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Kobi Ianko has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 32:
(1 comment)
http://gerrit.ovirt.org/#/c/27258/32/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 311: def _getCpuTuneInfo(self, stats):
Line 312: ret = {}
Line 313: try:
Line 314: if self._dom:
Line 315: ret = self._dom.schedulerParameters()
> You must not access the _dom object within the context of getAllVmStats, as
Done
Line 316:
Line 317: if ret['vcpu_quota'] is None:
Line 318: ret['vcpu_quota'] = -1
Line 319:
--
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Doron Fediuck
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changes in configfile.py.
oVirt Jenkins CI Server has posted comments on this change. Change subject: changes in configfile.py. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9777/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8839/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9623/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aced9da7a68eefdb60b82907bc83d224e449f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Kobi Ianko has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 35: splitted into 2 patches, api patch at: http://gerrit.ovirt.org/#/c/28462/ -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Saggi Mizrahi has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
> please add short comment what persist means in this scope, and what unpersi
The function should operate on a single file.
If there is no advantage to batching you should let the caller do the loop as
you are needlessly forcing the caller to have the files as an iterable.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 35: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9778/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8840/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9625/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/652/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/27258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Kobi Ianko Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Gilad Chaplik Gerrit-Reviewer: Kobi Ianko Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
i would handle IOError here, return None and add exception message. no need for
full backtrace
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
Line 834: __hostUUID = hostid
Line 835: else:
--
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changes in configfile.py.
Saggi Mizrahi has posted comments on this change. Change subject: changes in configfile.py. .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28463/1/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 25: import selinux Line 26: import io Line 27: Line 28: from .. import utils Line 29: if utils.isOvirtNode: iirc utils.isOvirtNode is a function not a variable. Line 30: from ovirt.node.utils.fs import Config Line 31: Line 32: ( Line 33: BEFORE, -- To view, visit http://gerrit.ovirt.org/28463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aced9da7a68eefdb60b82907bc83d224e449f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
> The function should operate on a single file.
the reason was not to check the node each time and not to import the
ovirtfunctions each time. please confirm again your request.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
> i would handle IOError here, return None and add exception message. no need
the entire idea of force is to fail if not succeeding... no?
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
Line 834: __hostUUID = hostid
Line 835: else:
--
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add createdir, cleanupdir, simplewalk functionality
Yeela Kaplan has abandoned this change. Change subject: Add createdir, cleanupdir, simplewalk functionality .. Abandoned -- To view, visit http://gerrit.ovirt.org/27735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ica6cb0fee5802c664548011c38e358529b155333 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Convert file metadata to use ioprocess for read/writes
Yeela Kaplan has abandoned this change. Change subject: Convert file metadata to use ioprocess for read/writes .. Abandoned -- To view, visit http://gerrit.ovirt.org/27267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I86beb53885dc935ad473498208e486895eab8315 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Implement rest of os and os.path functionality
Yeela Kaplan has abandoned this change. Change subject: Implement rest of os and os.path functionality .. Abandoned -- To view, visit http://gerrit.ovirt.org/27482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic4476982ba0125f8b1d8466f5f5809a0e9464cf5 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Change file permissions using ioprocess
Yeela Kaplan has abandoned this change. Change subject: Change file permissions using ioprocess .. Abandoned -- To view, visit http://gerrit.ovirt.org/27268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If71ebd4172e53fe0a9c530d29584603b9d2eef5c Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils.validateAccess ioprocess implementation
Yeela Kaplan has abandoned this change. Change subject: fileUtils.validateAccess ioprocess implementation .. Abandoned -- To view, visit http://gerrit.ovirt.org/27120 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ide82ef85d245216492e1e4327efb37c6c32a55dc Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: repoStats implementation using ioprocess instead of RFH
Yeela Kaplan has abandoned this change. Change subject: repoStats implementation using ioprocess instead of RFH .. Abandoned -- To view, visit http://gerrit.ovirt.org/27266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I225b8914801628c625716f58cdca19884081b4b6 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Yoav Kleinberger has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel P. Berrange Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: changes in configfile.py.
mooli tayer has posted comments on this change. Change subject: changes in configfile.py. .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28463/1/lib/vdsm/tool/configfile.py File lib/vdsm/tool/configfile.py: Line 26: import io Line 27: Line 28: from .. import utils Line 29: if utils.isOvirtNode: Line 30: from ovirt.node.utils.fs import Config > commented on the wrong patch. import it as nodeCfg Fixed both comments above. Waiting for response from Douglas. Line 31: Line 32: ( Line 33: BEFORE, Line 34: WITHIN, -- To view, visit http://gerrit.ovirt.org/28463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aced9da7a68eefdb60b82907bc83d224e449f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: re-implement rotateFiles()
Yeela Kaplan has uploaded a new change for review.
Change subject: utils: re-implement rotateFiles()
..
utils: re-implement rotateFiles()
Change-Id: Ie871d8289c71d7985de81d85aecef124bfcbaa96
Signed-off-by: Yeela Kaplan
---
M lib/vdsm/tool/configurator.py
M lib/vdsm/utils.py
2 files changed, 17 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/28464/1
diff --git a/lib/vdsm/tool/configurator.py b/lib/vdsm/tool/configurator.py
index e872682..0c244cb 100644
--- a/lib/vdsm/tool/configurator.py
+++ b/lib/vdsm/tool/configurator.py
@@ -239,7 +239,6 @@
"/lib/udev/scsi_id", # Ubuntu
)
-
def __init__(self):
super(MultipathModuleConfigure, self).__init__()
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 1a62e1c..993d9d4 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -240,11 +240,10 @@
self.wfile.write(response)
-def rotateFiles(directory, prefixName, gen, cp=False, persist=False):
+def rotateFiles(dir, prefixName, gen, cp=False, persist=False):
logging.debug("dir: %s, prefixName: %s, versions: %s" %
- (directory, prefixName, gen))
+ (dir, prefixName, gen))
gen = int(gen)
-files = os.listdir(directory)
files = glob.glob("%s*" % prefixName)
fd = {}
for fname in files:
@@ -266,33 +265,29 @@
logging.debug("versions found: %s" % (keys))
for key in keys:
-oldName = os.path.join(directory, fd[key]['old'])
-newName = os.path.join(directory, fd[key]['new'])
-if isOvirtNode() and persist and not cp:
+oldName = os.path.join(dir, fd[key]['old'])
+newName = os.path.join(dir, fd[key]['new'])
+if persist and not cp:
try:
-execCmd([constants.EXT_UNPERSIST, oldName], logErr=False,
-sudo=True)
-execCmd([constants.EXT_UNPERSIST, newName], logErr=False,
-sudo=True)
+unpersistFile(oldName)
+unpersistFile(newName)
except:
pass
try:
if cp:
execCmd([constants.EXT_CP, oldName, newName], sudo=True)
-if isOvirtNode() and persist and not os.path.exists(newName):
-execCmd([constants.EXT_PERSIST, newName], logErr=False,
-sudo=True)
+if persist and not os.path.exists(newName):
+persistFile(newName)
else:
os.rename(oldName, newName)
except:
pass
-if isOvirtNode() and persist and not cp:
+if persist and not cp:
try:
-execCmd([constants.EXT_PERSIST, newName], logErr=False,
-sudo=True)
+persistFile(newName)
except:
-pass
+logging.warning("Filed to persist file: %s" % newName)
class IPXMLRPCServer(SimpleXMLRPCServer):
@@ -1048,6 +1043,11 @@
execCmd([constants.EXT_PERSIST, name], sudo=True)
+def unpersistFile(name):
+if isOvirtNode():
+execCmd([constants.EXT_UNPERSIST, name], sudo=True)
+
+
def validateMinimalKeySet(dictionary, reqParams):
if not all(key in dictionary for key in reqParams):
raise ValueError
--
To view, visit http://gerrit.ovirt.org/28464
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie871d8289c71d7985de81d85aecef124bfcbaa96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Keep resource state if registerResource fails
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25284/4/vdsm/storage/resourceManager.py
File vdsm/storage/resourceManager.py:
Line 599: resource.activeUsers += 1
Line 600:
Line 601: self._log.debug("Resource '%s' is free. Now locking
as '%s' "
Line 602: "(1 active user)", fullName,
request.lockType)
Line 603: request.grant()
> Does this mean that if something breaks we have a granted request for a res
request.grant(), does *not* grant the resource to the caller, so we don't have
an issue failing after request.grant() was called.
What can be an issue, is the request.emit call, invoking the user callback.
This happens when exiting from this context, and should not happen something
was raised in this context - but I'm not sure this is the case - this code is
way too complex to reason about.
Line 604: ref = RequestRef(request)
Line 605: contextCleanup.defer(request.emit,
Line 606: ResourceRef(namespace, name,
Line 607: resource.realObj,
--
To view, visit http://gerrit.ovirt.org/25284
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Daniel P. Berrange
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Liron Ar
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yoav Kleinberger
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move multipath configuration to vdsm-tool configurator .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9779/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9626/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1122/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/26123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40f802477e39000c5cae01a496ac2d9f879ebfa8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: re-implement rotateFiles()
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: re-implement rotateFiles() .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9780/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8842/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9627/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1123/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/28464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie871d8289c71d7985de81d85aecef124bfcbaa96 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Saggi Mizrahi has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 4: Code-Review-1 This update is actually wrong. You can't call resource.grant() before incrementing the activeUsers count. grant() sets the _doneEvent() which might prompt another thread to act as if the resource is owned when an error is hit. It's impossible to do anything assuming the standard library can throw errors at any time as it causes to many unpredictable behaviors. The solution, sadly, is to trap the error in a wrapper to the logging or manually wrap every log call in try\except. -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel P. Berrange Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails
Saggi Mizrahi has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 4: Another possibility Maybe panic() in case of an unexpected error. -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16abf41ebc8a8a99b292d38c945074752254a34b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel P. Berrange Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Saggi Mizrahi has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
> the reason was not to check the node each time and not to import the ovirtf
I was going to suggest moving the import to the top
of the file.
ovirtfunctions = None
if isOvirtNode() then
from ovirtnode import ovirtfunctions
or
try:
from ovirtnode import ovirtfunctions
except ImportError:
ovirtfunctions = None
further more isOvirtNode() is memoized so it's
not really that much of a performance hit to
merit a style break
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
> I was going to suggest moving the import to the top
ok, I wanted to avoid even try to import this code which is not the best one...
see[1]
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1080974
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 11:
(2 comments)
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/tool/vdsm-id.py
File lib/vdsm/tool/vdsm-id.py:
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19:
Line 20:
Line 21: import argparse
argparse is a 2.7 feature.
Iirc it's not available in el6.
Should this code be supported on el6?
Line 22: import sys
Line 23:
Line 24:
Line 25: from ..utils import getHostUUID
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 825:
Line 826: if ret == 0 and 'Not' not in out:
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
I think that a getter shouldn't really create the things it's supposed to
retrieve.
The whole concept of force getter is a bit odd. You are trying so hard to get
the UUID that you end up making one up?
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
--
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Saggi Mizrahi has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
> ok, I wanted to avoid even try to import this code which is not the best on
Maybe you could just use the new imports like in:
http://gerrit.ovirt.org/#/c/28463/1/lib/vdsm/tool/configfile.py,cm
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 11:
(2 comments)
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/tool/vdsm-id.py
File lib/vdsm/tool/vdsm-id.py:
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19:
Line 20:
Line 21: import argparse
> argparse is a 2.7 feature.
we have:
%if 0%{?rhel} == 6
BuildRequires: python-argparse
BuildRequires: python-ordereddict
%endif
Line 22: import sys
Line 23:
Line 24:
Line 25: from ..utils import getHostUUID
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 825:
Line 826: if ret == 0 and 'Not' not in out:
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
> I think that a getter shouldn't really create the things it's supposed to r
yes. if there is one in bios, we generate random.
force is introduce so we have id no matter what.
IMO it was a mistake to use BIOS ones anyway, we should have generated random
always, but...
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
--
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Alon Bar-Lev has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
> Maybe you could just use the new imports like in:
again, I do not mind dropping this patch... I already told mooli I will be
surprised.
if we are to use the new node api, this should be horizontal patch throughout
vdsm, with extensive testing.
up until that point, I suggest we use the old known evil.
your call.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
Saggi Mizrahi has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 23:
(8 comments)
http://gerrit.ovirt.org/#/c/27298/23//COMMIT_MSG
Commit Message:
Line 6:
Line 7: replace configure_libvirt.py with python code.
Line 8:
Line 9: The port is to behave as similar as possible to the old
Line 10: sh code. python should allow easier testing (tests added
Seems like ) got moved around
Line 11: ) and better overall readability.
Line 12:
Line 13: A testing matrix [1] documents my tests of this feature.
Line 14:
http://gerrit.ovirt.org/#/c/27298/23/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 30: from .. import utils
Line 31: from . import service, expose, validate_ovirt_certs
Line 32: from . import NotRootError, UsageError
Line 33: from configfile import ConfigFile, ParserWrapper
Line 34: from ..constants import QEMU_PROCESS_GROUP, \
If you are already working on this line please change it to
from .. constants import \
QEMU_PROCESS_GROUP,
SANLOCK_USER,
.
So that future diffs are easier to read.
Line 35: SANLOCK_USER, VDSM_GROUP, SYSCONF_PATH, P_VDSM_CERT, \
Line 36: SANLOCK_ENABLED, LIBVIRT_SELINUX, P_VDSM
Line 37: from vdsm.config import config
Line 38:
Line 35: SANLOCK_USER, VDSM_GROUP, SYSCONF_PATH, P_VDSM_CERT, \
Line 36: SANLOCK_ENABLED, LIBVIRT_SELINUX, P_VDSM
Line 37: from vdsm.config import config
Line 38:
Line 39: if utils.isOvirtNode:
Again, I think it's a function.
Line 40: from ovirt.node.utils.fs import Config
Line 41:
Line 42:
Line 43: class InvalidConfig(UsageError):
Line 117: # write configuration
Line 118: for cfile, content in self.FILES.items():
Line 119: content['configure'](self, content, vdsmConfiguration)
Line 120:
Line 121: sys.stdout.write("Reconfiguration of libvirt is done.")
end with \n?
Why write to stdout directly?
Line 122:
Line 123: def validate(self):
Line 124: """
Line 125: Validate conflict in configured files
Line 179: LIBVIRTD_UPSTART
os.path.basename(fname) == LIBVIRTD_UPSTART
is much more accurate representation of what you actually trying to do.
Line 183: if os.path.isfile(packaged):
Line 184: if not os.path.isfile(TARGET):
Line 185: service.service_stop('libvirtd')
Line 186: if (not os.path.isfile(TARGET) or
Line 187: not filecmp.cmp(packaged, TARGET)):
if not os.path.isfile(TARGET):
service.service_stop('libvirtd')
if not filecmp.cmp(packaged, TARGET):
Line 188: oldmod = None
Line 189: if os.path.isfile(TARGET):
Line 190: oldmod = os.stat(TARGET).st_mode
Line 191:
Line 197:
Line 198: if (oldmod is not None and
Line 199: oldmod != os.stat(TARGET).st_mode):
Line 200: os.chmod(TARGET, oldmod)
Line 201: rc, out, err = utils.execCmd((INITCTL,
Factor out to a proper function
Line 202:
"reload-configuration"))
Line 203: if rc != 0:
Line 204: sys.stdout.write(out)
Line 205: sys.stderr.write(err)
Line 215: ssl = config.getboolean('vars', 'ssl')
Line 216:
Line 217: lconf_p = ParserWrapper({
Line 218: 'listen_tcp': '0',
Line 219: 'auth_tcp': 'sasl'
Add comma at EOL
Line 220: })
Line 221: lconf_p.read(self._getFile('LCONF'))
Line 222: listen_tcp = lconf_p.getint('listen_tcp')
Line 223: auth_tcp = lconf_p.get('auth_tcp')
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
mooli tayer has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
> again, I do not mind dropping this patch... I already told mooli I will be
There is no disagreement about isOvirtNode(). we will
benefit if you would separate to two different patches.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Alon Bar-Lev has posted comments on this change. Change subject: utils: add ovirt-node persistence functions .. Patch Set 4: mooli, feel free to drop this one in favour of whatever you agree... I will use whatever within vdsm in future host-deploy work. I just sorry I did not have time to complete it back then. -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nfsSD: Remove unneeded and expensive mount check
Nir Soffer has posted comments on this change. Change subject: nfsSD: Remove unneeded and expensive mount check .. Patch Set 1: Verified+1 Verified on RHEL 6.5 with 2 hosts and 45 storage domains. - Add couple of storage domains - Deactivate storage domain - Activate storage domain - Remove storage domain - Switch spm - Reconstract master - Create vm from template - Create template from vm - Run vm - Vm migration -- To view, visit http://gerrit.ovirt.org/28089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8c617c3e9b9e24b5404a197427551408f659549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Saggi Mizrahi has posted comments on this change.
Change subject: utils: add ovirt-node persistence functions
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/20811/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 1234: glob.glob('/etc/ovirt-node-*-release')
Line 1235: )
Line 1236:
Line 1237:
Line 1238: def ovirtNodePersist(files):
> again, I do not mind dropping this patch... I already told mooli I will be
I want one method used. And the one that the node people recommend. If there
isn't a consensus I don't mind just execCmd the persist\unpersist CLI command
like the rest of VDSM.
Line 1239: if isOvirtNode():
Line 1240: from ovirtnode import ovirtfunctions
Line 1241: for f in files:
Line 1242: if not ovirtfunctions.is_persisted(f):
--
To view, visit http://gerrit.ovirt.org/20811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: add ovirt-node persistence functions
Alon Bar-Lev has abandoned this change. Change subject: utils: add ovirt-node persistence functions .. Abandoned ok... dropping this patch. -- To view, visit http://gerrit.ovirt.org/20811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib93af61a44a52c37faf92d6f6081babefa3a09aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: nfsSD: Remove unneeded and expensive mount check
Nir Soffer has posted comments on this change. Change subject: nfsSD: Remove unneeded and expensive mount check .. Patch Set 1: -Verified Sent too early - verifying in progress... -- To view, visit http://gerrit.ovirt.org/28089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8c617c3e9b9e24b5404a197427551408f659549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 825:
Line 826: if ret == 0 and 'Not' not in out:
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
> yes. if there is one in bios, we generate random.
Isn't there a stage where we can call
ensureHostUUID() that does this?
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
--
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 825:
Line 826: if ret == 0 and 'Not' not in out:
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
> Isn't there a stage where we can call
and expose the structure of the id as uuid? instead of having this at one place?
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
--
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: GET requests - use Range header
Liron Ar has uploaded a new change for review.
Change subject: core: GET requests - use Range header
..
core: GET requests - use Range header
This patch replaces the use of the custom Size header with use of http
Range header.
(http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.35)
Currently the Range header is mandatory to issue a get request for an
image and support ranges between zero and specified last byte position.
Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d
Signed-off-by: Liron Aravot
---
M vdsm/BindingXMLRPC.py
1 file changed, 40 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/28465/1
diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index 08a818d..475b078 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -26,6 +26,7 @@
import logging
import libvirt
import threading
+import re
import sys
from vdsm import utils
@@ -119,9 +120,10 @@
HEADER_IMAGE = 'Image-Id'
HEADER_VOLUME = 'Volume-Id'
HEADER_TASK_ID = 'Task-Id'
-HEADER_SIZE = 'Size'
+HEADER_RANGE = 'Range'
HEADER_CONTENT_LENGTH = 'content-length'
HEADER_CONTENT_TYPE = 'content-type'
+HEADER_CONTENT_RANGE = 'content-range'
class RequestException():
def __init__(self, httpStatusCode, errorMessage):
@@ -135,8 +137,7 @@
def do_GET(self):
try:
-length = self._getIntHeader(self.HEADER_SIZE,
-httplib.BAD_REQUEST)
+length = self._getLength()
img = self._createImage()
startEvent = threading.Event()
methodArgs = {'fileObj': self.wfile,
@@ -153,10 +154,12 @@
startEvent, volUUID)
if response['status']['code'] == 0:
-self.send_response(httplib.OK)
+self.send_response(httplib.PARTIAL_CONTENT)
self.send_header(self.HEADER_CONTENT_TYPE,
'application/octet-stream')
self.send_header(self.HEADER_CONTENT_LENGTH, length)
+self.send_header(self.HEADER_CONTENT_RANGE,
+ "bytes=0-%d" % length)
self.send_header(self.HEADER_TASK_ID, response['uuid'])
self.end_headers()
startEvent.set()
@@ -238,21 +241,51 @@
event.wait()
def _getIntHeader(self, headerName, missingError):
+value = self._getRequiredHeader(headerName, missingError)
+
+return self._getInt(value)
+
+def _getRequiredHeader(self, headerName, missingError):
value = self.headers.getheader(
headerName)
if not value:
raise self.RequestException(
missingError,
"missing header %s" % headerName)
+return value
+def _getInt(self, value):
try:
-value = int(value)
+return int(value)
except ValueError:
raise self.RequestException(
httplib.BAD_REQUEST,
-"invalid header value %r" % value)
+"not int value %r" % value)
-return value
+def _getLength(self):
+value = self._getRequiredHeader(self.HEADER_RANGE,
+httplib.BAD_REQUEST)
+
+m = re.match('^bytes=(\d*)-(\d+)$', value)
+if m is None:
+raise self.RequestException(
+httplib.BAD_REQUEST,
+"range in an unsupported format")
+
+min = m.group(1)
+if min != '0':
+raise self.RequestException(
+httplib.BAD_REQUEST,
+"range first byte position other than 0 isn't "
+"supported")
+
+max = m.group(2)
+if max == '':
+raise self.RequestException(
+httplib.BAD_REQUEST,
+"range last byte position must be specified")
+
+return self._getInt(max)
def send_error(self, error, message, exc_info=False):
try:
--
To view, visit http://gerrit.ovirt.org/28465
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d
Gerrit-PatchSet: 1
Gerrit
Change in vdsm[master]: Adding API methods for CPU limit MOM integration
Dan Kenigsberg has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 1: Code-Review-1
(4 comments)
Please separate refactoring and feature-addition. Adding an API per commit
would be nicer, too.
http://gerrit.ovirt.org/#/c/28462/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4493: return {'status': doneCode}
Line 4494:
Line 4495: def setCpuTuneQuota(self, quota):
Line 4496:
Line 4497: if self._dom is None:
Why do you have this check? it can happen only if setCpuTuneQuota is called
while the VM is waiting for launch of its qemu process (which should never
happen) or if qemu died. The suggested reported error is not going to help the
caller anyway. I'd rather drop this condition.
Line 4498: return self._reportError(entity='vcpu quota')
Line 4499:
Line 4500: quota = int(quota)
Line 4501: try:
Line 4499:
Line 4500: quota = int(quota)
Line 4501: try:
Line 4502: self._dom.setSchedulerParameters({'vcpu_quota': quota})
Line 4503: return {'status': doneCode}
Keeping try-block as short as possible is a good practice. Please call return
outside of the block.
Line 4504: except libvirt.libvirtError as e:
Line 4505: return self._reportError(msg=e.message, entity='vcpu
quota')
Line 4506:
Line 4507: def setCpuTunePeriod(self, period):
Line 4518: entity='vcpu period')
Line 4519: except libvirt.libvirtError as e:
Line 4520: return self._reportError(msg=e.message, entity='vcpu
period')
Line 4521:
Line 4522: def _reportError(self, key='Err', msg=None, entity=None):
please be kind to your reviewer, and separate this refactoring from the
addition of new API.
Where is errCode['Err'] defined?
Line 4523: self.log.error("Set new " + entity + " failed",
exc_info=True)
Line 4524: if msg is None:
Line 4525: error = errCode[key]
Line 4526: else:
Line 4519: except libvirt.libvirtError as e:
Line 4520: return self._reportError(msg=e.message, entity='vcpu
period')
Line 4521:
Line 4522: def _reportError(self, key='Err', msg=None, entity=None):
Line 4523: self.log.error("Set new " + entity + " failed",
exc_info=True)
this explodes if "entity" has its default value of None.
Line 4524: if msg is None:
Line 4525: error = errCode[key]
Line 4526: else:
Line 4527: error = {'status': {'code': errCode[key]
--
To view, visit http://gerrit.ovirt.org/28462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia78529b736ec0c841d232ba8aa1434bd0d0e8e08
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Doron Fediuck
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: GET requests - use Range header
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9781/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8843/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9628/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1124/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration
Dan Kenigsberg has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 35: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/27258/35/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 30: import tempfile
Line 31: import threading
Line 32: import time
Line 33: import xml.dom.minidom
Line 34: import re
is it used?
Line 35:
Line 36: # 3rd party libs imports
Line 37: import libvirt
Line 38:
Line 267: def _sampleCpuTune(self):
Line 268: infos = self._dom.schedulerParameters()
Line 269: infos['vcpuCount'] =
self._dom.vcpusFlags(libvirt.VIR_DOMAIN_MEM_CURRENT)
Line 270:
Line 271: vcpuLimitUri = 'http://ovirt.org/vm/tune/1.0'
This string should be defined as a CONSTANT. Maybe in the module level.
Line 272: metadataCpuLimit = self._dom.metadata(2, vcpuLimitUri, 0)
Line 273: if metadataCpuLimit:
Line 274: metadataCpuLimitXML = _domParseStr(metadataCpuLimit)
Line 275: nodeList = \
Line 268: infos = self._dom.schedulerParameters()
Line 269: infos['vcpuCount'] =
self._dom.vcpusFlags(libvirt.VIR_DOMAIN_MEM_CURRENT)
Line 270:
Line 271: vcpuLimitUri = 'http://ovirt.org/vm/tune/1.0'
Line 272: metadataCpuLimit = self._dom.metadata(2, vcpuLimitUri, 0)
Use libvirt.VIR_DOMAIN_METADATA_ELEMENT constant instead on magic 2.
Line 273: if metadataCpuLimit:
Line 274: metadataCpuLimitXML = _domParseStr(metadataCpuLimit)
Line 275: nodeList = \
Line 276: metadataCpuLimitXML.getElementsByTagName('vcpulimit')
Line 273: if metadataCpuLimit:
Line 274: metadataCpuLimitXML = _domParseStr(metadataCpuLimit)
Line 275: nodeList = \
Line 276: metadataCpuLimitXML.getElementsByTagName('vcpulimit')
Line 277: value = nodeList[0].childNodes[0].data
if metadataCpuLimit is None, value is not going to be set, and the following
statement is going to explode.
Line 278:
Line 279: infos['vcpuLimit'] = value
Line 280: return infos
Line 281:
Line 342: ret['vcpu_period'] = 1000
Line 343: else:
Line 344: ret['vcpu_period'] = eInfo['vcpu_period']
Line 345:
Line 346: except (AttributeError, libvirt.libvirtError):
nothing in the try block can raise libvirtError; I cannot find any
AttributeError either.
I believe that this is my forth request not report invented values with we do
not know the vcpu_period.
Line 347: # Metadata is not set, set the defaults
Line 348: self.log.debug('Domain Metadata is not set',
exc_info=True)
Line 349: ret['vcpu_quota'] = -1
Line 350: ret['vcpu_period'] = 1000
Line 2694: stats['network'] = decStats[var]
Line 2695: elif var == 'balloonInfo':
Line 2696: stats['balloonInfo'] = decStats[var]
Line 2697: elif var == 'vcpu_quota':
Line 2698: stats['vcpu_quota'] = decStats[var]
non-dictionary elements do not need explicit handling here
Line 2699: elif var == 'vcpu_period':
Line 2700: stats['vcpu_period'] = decStats[var]
Line 2701: elif var == 'cpu_count':
Line 2702: stats['cpu_count'] = decStats[var]
--
To view, visit http://gerrit.ovirt.org/27258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic502d9a4a976cd76bb6042bbb51f6cd281199631
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: David Caro
Gerrit-Reviewer: Doron Fediuck
Gerrit-Reviewer: Gilad Chaplik
Gerrit-Reviewer: Kobi Ianko
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28244/2/vdsm_reg/vdsm-upgrade File vdsm_reg/vdsm-upgrade: Line 41: Line 42: logging.debug(out) Line 43: logging.debug(msg) Line 44: print(msg) Line 45: return rc > what previous tool? it should be here in the wrapper. Douglas, element has a "message" attribute. I think that Alon suggests that you put err and out inside it (after proper quoting, of course!). Line 46: Line 47: if __name__ == "__main__": -- To view, visit http://gerrit.ovirt.org/28244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b997d70a440545497246d1a19d9671b054a56a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Joey Boggs Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: GET requests - use Range header
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9782/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8844/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9629/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1125/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: replace configure_libvirt.py with python code.
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 23:
(8 comments)
http://gerrit.ovirt.org/#/c/27298/23//COMMIT_MSG
Commit Message:
Line 6:
Line 7: replace configure_libvirt.py with python code.
Line 8:
Line 9: The port is to behave as similar as possible to the old
Line 10: sh code. python should allow easier testing (tests added
> Seems like ) got moved around
fixed
Line 11: ) and better overall readability.
Line 12:
Line 13: A testing matrix [1] documents my tests of this feature.
Line 14:
http://gerrit.ovirt.org/#/c/27298/23/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 30: from .. import utils
Line 31: from . import service, expose, validate_ovirt_certs
Line 32: from . import NotRootError, UsageError
Line 33: from configfile import ConfigFile, ParserWrapper
Line 34: from ..constants import QEMU_PROCESS_GROUP, \
> If you are already working on this line please change it to
from .. constants import \
QEMU_PROCESS_GROUP, \
SANLOCK_USER, \
...
?
Line 35: SANLOCK_USER, VDSM_GROUP, SYSCONF_PATH, P_VDSM_CERT, \
Line 36: SANLOCK_ENABLED, LIBVIRT_SELINUX, P_VDSM
Line 37: from vdsm.config import config
Line 38:
Line 35: SANLOCK_USER, VDSM_GROUP, SYSCONF_PATH, P_VDSM_CERT, \
Line 36: SANLOCK_ENABLED, LIBVIRT_SELINUX, P_VDSM
Line 37: from vdsm.config import config
Line 38:
Line 39: if utils.isOvirtNode:
> Again, I think it's a function.
changed.
Line 40: from ovirt.node.utils.fs import Config
Line 41:
Line 42:
Line 43: class InvalidConfig(UsageError):
Line 117: # write configuration
Line 118: for cfile, content in self.FILES.items():
Line 119: content['configure'](self, content, vdsmConfiguration)
Line 120:
Line 121: sys.stdout.write("Reconfiguration of libvirt is done.")
> end with \n?
Added \n, also notice this is moved to verb level here:
http://gerrit.ovirt.org/#/c/27841/
Line 122:
Line 123: def validate(self):
Line 124: """
Line 125: Validate conflict in configured files
Line 179: LIBVIRTD_UPSTART
> os.path.basename(fname) == LIBVIRTD_UPSTART
Done.
Line 183: if os.path.isfile(packaged):
Line 184: if not os.path.isfile(TARGET):
Line 185: service.service_stop('libvirtd')
Line 186: if (not os.path.isfile(TARGET) or
Line 187: not filecmp.cmp(packaged, TARGET)):
> if not os.path.isfile(TARGET):
iiuc what you are saying would be true if it was:
not os.path.isfile(TARGET) and not filecmp.cmp(packaged, TARGET)
I think
if a():
x()
if a or b:
y()
is not the same as
if a:
x()
if b:
y()
In the case where a = False and b = True.
Line 188: oldmod = None
Line 189: if os.path.isfile(TARGET):
Line 190: oldmod = os.stat(TARGET).st_mode
Line 191:
Line 197:
Line 198: if (oldmod is not None and
Line 199: oldmod != os.stat(TARGET).st_mode):
Line 200: os.chmod(TARGET, oldmod)
Line 201: rc, out, err = utils.execCmd((INITCTL,
> Factor out to a proper function
Done
Line 202:
"reload-configuration"))
Line 203: if rc != 0:
Line 204: sys.stdout.write(out)
Line 205: sys.stderr.write(err)
Line 215: ssl = config.getboolean('vars', 'ssl')
Line 216:
Line 217: lconf_p = ParserWrapper({
Line 218: 'listen_tcp': '0',
Line 219: 'auth_tcp': 'sasl'
> Add comma at EOL
Done
Line 220: })
Line 221: lconf_p.read(self._getFile('LCONF'))
Line 222: listen_tcp = lconf_p.getint('listen_tcp')
Line 223: auth_tcp = lconf_p.get('auth_tcp')
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dima Kuznetsov
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Zhou Zheng Sheng
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: core: GET requests - use Range header
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9783/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8845/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9630/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1126/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164867347b1cf800efd2a78cc98dbc10c02ee0d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: fix version to family parameter name
Dan Kenigsberg has submitted this change and it was merged. Change subject: ipwrapper: fix version to family parameter name .. ipwrapper: fix version to family parameter name In commit e435e680fdae8f1baaf8dac549c72db32c07549f there is a change to add ipv6 support to various ipwrapper functions. During the review process it was suggested to change the parameter from 'version' to 'family' but I missed one of the parameters. Change-Id: I2ee57be88cb0037a337bfa28aa296cd01c8799a7 Signed-off-by: Antoni S. Puimedon Reviewed-on: http://gerrit.ovirt.org/28095 Reviewed-by: Dan Kenigsberg Tested-by: Dan Kenigsberg --- M lib/vdsm/ipwrapper.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ee57be88cb0037a337bfa28aa296cd01c8799a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: fix version to family parameter name
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: fix version to family parameter name .. Patch Set 1: Verified+1 Verfied by running the functional tests. -- To view, visit http://gerrit.ovirt.org/28095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee57be88cb0037a337bfa28aa296cd01c8799a7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: log pyflakes version
Yaniv Bronhaim has posted comments on this change. Change subject: build: log pyflakes version .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86d82b5fda7e7f2900b62bcf7c3654488f83f770 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: fix version to family parameter name
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: fix version to family parameter name .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1402/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee57be88cb0037a337bfa28aa296cd01c8799a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 11:
(2 comments)
http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 825:
Line 826: if ret == 0 and 'Not' not in out:
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
> and expose the structure of the id as uuid? instead of having this at one p
it is valid way to sign UUID to host for now. later we'll find better unique
UUID on ppc or other arcs that don't retreive uuid by dmidecode. so force it
is.. its not simple getter, its a getter with a bit of logic
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
Line 827: # Avoid error string - 'Not Settable' or 'Not
Present'
Line 828: __hostUUID = out.strip()
Line 829: elif force:
Line 830: hostid = str(uuid.uuid4())
Line 831: with open(constants.P_VDSM_NODE_ID, 'w') as f:
> the entire idea of force is to fail if not succeeding... no?
return None it is count as failure in that part, so i prefer it cleaner
Line 832: f.write("%s\n", hostid)
Line 833: ovirtNodePersist([constants.P_VDSM_NODE_ID])
Line 834: __hostUUID = hostid
Line 835: else:
--
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-tool: vdsm-id: add force option to force generate id
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: vdsm-id: add force option to force generate id .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/20808/11/lib/vdsm/tool/vdsm-id.py File lib/vdsm/tool/vdsm-id.py: Line 17: # Refer to the README and COPYING files for full details of the license Line 18: # Line 19: Line 20: Line 21: import argparse > we have: we use all over already. don't worry about it :) Line 22: import sys Line 23: Line 24: Line 25: from ..utils import getHostUUID -- To view, visit http://gerrit.ovirt.org/20808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: log pyflakes version
Dan Kenigsberg has posted comments on this change. Change subject: build: log pyflakes version .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86d82b5fda7e7f2900b62bcf7c3654488f83f770 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
