Change in vdsm[master]: Introduction for caching the parsed domain XML
Vinzenz Feenstra has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:
Line 19: #
Line 20: import xml.dom.minidom
Line 21:
Line 22:
Line 23: class DomainDescriptor(object):
Blank line bellow the class is common and make it even nicer.
Done
Line 24: def __init__(self, xmlStr):
Line 25: self._xml = xmlStr
Line 26: self._dom = xml.dom.minidom.parseString(xmlStr)
Line 27: self._devices = self.firstElementByTagName('devices')
Line 29: self._devicesHash = str(hash(self._devices)) if self._devices
else '0'
Line 30:
Line 31: @staticmethod
Line 32: def fromId(uuid):
Line 33: return DomainDescriptor('domainuuid%s/uuid/domain' %
uuid)
Should be class method:
Done
Line 34:
Line 35: @property
Line 36: def xml(self):
Line 37: return self._xml
--
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev svinota.savel...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: fixing cif getinstance issue
Dan Kenigsberg has posted comments on this change. Change subject: test: fixing cif getinstance issue .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a4248519c01d21dee2f55f7e150c931b75e30e2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: fixing cif getinstance issue
Dan Kenigsberg has submitted this change and it was merged. Change subject: test: fixing cif getinstance issue .. test: fixing cif getinstance issue During running jsonrpc test cif.getInstance fails due to missing logger. We mock getInstance method to return fake cif. Change-Id: I7a4248519c01d21dee2f55f7e150c931b75e30e2 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: http://gerrit.ovirt.org/29188 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/jsonRpcTests.py 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4248519c01d21dee2f55f7e150c931b75e30e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: fixing cif getinstance issue
oVirt Jenkins CI Server has posted comments on this change. Change subject: test: fixing cif getinstance issue .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1539/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5524/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3682/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a4248519c01d21dee2f55f7e150c931b75e30e2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving conf init things together
Vinzenz Feenstra has uploaded a new change for review.
Change subject: Moving conf init things together
..
Moving conf init things together
Change-Id: I41ac420cd0da5a3118ce5b3c4c3643b292ec2e86
Signed-off-by: Vinzenz Feenstra vfeen...@redhat.com
---
M vdsm/rpc/Bridge.py
M vdsm/virt/vm.py
2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/29320/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index 539c70c..12ed98e 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -286,6 +286,7 @@
return [v['vmId'] for v in ret['vmList']]
+
def Host_queryVms_Ret(ret):
The result contains two data structures which must be merged
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 2c5c910..098a3d5 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1814,8 +1814,7 @@
self._dom = None
self.recovering = recover
-self.conf = {'pid': '0'}
-self.conf['_blockJobs'] = {}
+self.conf = {'pid': '0', '_blockJobs': {}, 'clientIp': ''}
self.conf.update(params)
self._initLegacyConf() # restore placeholders for BC sake
self.cif = cif
@@ -1825,7 +1824,6 @@
str(self.conf['vmId']) + '.recovery'
self.user_destroy = False
self._monitorResponse = 0
-self.conf['clientIp'] = ''
self.memCommitted = 0
self._confLock = threading.Lock()
self._jobsLock = threading.Lock()
--
To view, visit http://gerrit.ovirt.org/29320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41ac420cd0da5a3118ce5b3c4c3643b292ec2e86
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Query interface for all VM fields
oVirt Jenkins CI Server has posted comments on this change. Change subject: Query interface for all VM fields .. Patch Set 8: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9706/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10491/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1040/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/27/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/60/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/39/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10648/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddb4657d738ca0406950d07b84a7c85721e80b78 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving conf init things together
oVirt Jenkins CI Server has posted comments on this change. Change subject: Moving conf init things together .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9707/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10492/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1041/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10649/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41ac420cd0da5a3118ce5b3c4c3643b292ec2e86 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Moving conf init things together
oVirt Jenkins CI Server has posted comments on this change. Change subject: Moving conf init things together .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9708/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10493/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1042/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10650/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41ac420cd0da5a3118ce5b3c4c3643b292ec2e86 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Query interface for all VM fields
oVirt Jenkins CI Server has posted comments on this change. Change subject: Query interface for all VM fields .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9709/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10494/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1043/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/28/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/61/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/40/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10651/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddb4657d738ca0406950d07b84a7c85721e80b78 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: disable virtio-rng on rhel 7.1
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel 7.1
..
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/28838/2/vdsm/caps.py
File vdsm/caps.py:
Line 499: return dict(release=release, version=version, name=osname)
Line 500:
Line 501:
Line 502: @utils.memoized
Line 503: def libvirtversion():
I'd use getLibvirtVersion or something like this to be conformant con the r
... and please declare it private with a underscore, since it is currently
unused out of module.
Line 504:
Line 505: Returns the libvirt version in the format
Line 506: major * 1,000,000 + minor * 1,000 + release
Line 507:
Line 607: caps['memSize'] = str(utils.readMemInfo()['MemTotal'] / 1024)
Line 608: caps['reservedMem'] = str(config.getint('vars',
'host_mem_reserve') +
Line 609: config.getint('vars',
'extra_mem_reserve'))
Line 610: caps['guestOverhead'] = config.get('vars', 'guest_ram_overhead')
Line 611: # rng device is supported in qemu: 1.3 libvirt: 1.0.3 kernel:
2.6.26
So why is it safe to ignore the version of qemu?
Line 612: if libvirtversion() = 1001003:
Line 613: caps['rngSources'] = _getRngSources()
Line 614: caps['numaNodes'] = getNumaTopology()
Line 615: caps['numaNodeDistance'] = getNumaNodeDistance()
--
To view, visit http://gerrit.ovirt.org/28838
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3493fec50d5d0e055a09f3393c86ff76f2a1ce5a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpole...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: detach: Support force detach on Storage Domains with old pools.
Yaniv Bronhaim has posted comments on this change. Change subject: detach: Support force detach on Storage Domains with old pools. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: detach: Support force detach on Storage Domains with old pools.
Yaniv Bronhaim has submitted this change and it was merged. Change subject: detach: Support force detach on Storage Domains with old pools. .. detach: Support force detach on Storage Domains with old pools. Force detach of storage domain only being supported on storage domains which are part of pool. For supporting import Data Storage Domain feature, we should also support force detach of Storage Domain which are not connected to any pool. The force detach will clear the SP_UUID meta data of the imported Stroage Dimain, when a BLANK_UUID will be passed from the client and will enable the engine to attach it to other DC in ifferent setups. Signed-off-by: Maor Lipchuk mlipc...@redhat.com Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be Reviewed-on: http://gerrit.ovirt.org/29303 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/storage/hsm.py M vdsm/storage/sd.py 2 files changed, 35 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Dan Kenigsberg: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/29303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: detach: Support force detach on Storage Domains with old pools.
Yaniv Bronhaim has posted comments on this change. Change subject: detach: Support force detach on Storage Domains with old pools. .. Patch Set 2: next time please add link to the patch on master (http://gerrit.ovirt.org/29042) -- To view, visit http://gerrit.ovirt.org/29303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a6fb01775f7c834a3466e45b9b7ed9b4bd5c3be Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...
Martin Sivák has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 6:
(4 comments)
I can't persist the data when I change them, because libvirt can change the
values. I can't do this only when MOM asks for it, because MOM asks for
everything every 10 seconds (which is more often than in this patch).
The only thing I can do is to change the period to about 60s, because that is
probably enough for our purposes.
Unless you give me a way to collect libvirt data in less cpu intensive way, I
can't change this to get reliable data so it really does not matter.
I understand that parsing XML is hard, but the xml is the official libvirt API.
And as far as I know, vdsm does not refresh the xml by itself so I can't just
traverse the DOM of already parsed document.
http://gerrit.ovirt.org/#/c/28712/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 189: ('vm_sample_vcpu_pin_window', '2', None),
Line 190:
Line 191: ('vm_sample_cpu_tune_interval', '15', None),
Line 192:
Line 193: ('vm_sample_io_tune_interval', '15', None),
Since we need to parse the full domain XML at each run ( :( ), any chance t
MOM reevaluates its rules every 10 seconds by default. But I guess we could
increase this to once per minute or so.
Line 194:
Line 195: ('trust_store_path', '@TRUSTSTORE@',
Line 196: 'Where the certificates and keys are situated.'),
Line 197:
http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 331: infos['vcpuLimit'] = nodeList[0].childNodes[0].data
Line 332:
Line 333: return infos
Line 334:
Line 335: def _sampleIoTune(self):
But why every 2 seconds? How often these values may change?
Where do you see two seconds? The default was 15.
Line 336: info = []
Line 337:
Line 338: try:
Line 339: lastXMLDesc = self._vm._dom.XMLDesc(0)
Line 338: try:
Line 339: lastXMLDesc = self._vm._dom.XMLDesc(0)
Line 340: except libvirt.libvirtError:
Line 341: self._log.exception(Error while collecting ioTune for
%s,
Line 342: self._vm.name)
This may flood the logs - is there anything useful in this traceback?
Not being able to colelct data from libvirt is a serious issue. That is what
the logs are for.
Line 343: return None
Line 344:
Line 345: devxml = _domParseStr(lastXMLDesc).childNodes[0] \
Line 346: .getElementsByTagName('devices')[0]
Line 607: self._getDiskStats(stats)
Line 608: self._getDiskLatency(stats)
Line 609: self._getBalloonStats(stats)
Line 610: self._getVmJobs(stats)
Line 611: self._getIoTuneStats(stats)
+1
All the following calls are QoS code as well.
But if it makes you happy..
Line 612:
Line 613: vmNumaNodeRuntimeMap =
numaUtils.getVmNumaNodeRuntimeInfo(self._vm)
Line 614: if vmNumaNodeRuntimeMap:
Line 615: stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap
--
To view, visit http://gerrit.ovirt.org/28712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...
Martin Sivák has posted comments on this change. Change subject: Collect current QoS settings for IO devices and report through RunningVmStats .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 607: self._getDiskStats(stats) Line 608: self._getDiskLatency(stats) Line 609: self._getBalloonStats(stats) Line 610: self._getVmJobs(stats) Line 611: self._getIoTuneStats(stats) All the following calls are QoS code as well. And btw are you two aware of the fact that this call only merges two dictionaries and does nothing cpu intensive? Line 612: Line 613: vmNumaNodeRuntimeMap = numaUtils.getVmNumaNodeRuntimeInfo(self._vm) Line 614: if vmNumaNodeRuntimeMap: Line 615: stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap -- To view, visit http://gerrit.ovirt.org/28712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for reporting the timezone and os info
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for reporting the timezone and os info .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9710/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10495/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1044/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10652/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadb85a5003fcb4693b5a1174655acf59193340b5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP virt: use (c)ElementTree to process XML
Francesco Romani has abandoned this change. Change subject: WIP virt: use (c)ElementTree to process XML .. Abandoned Severely out of date. Will reboot once the xmldom and the domain_descriptor patches are in. -- To view, visit http://gerrit.ovirt.org/26856 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7874026acf52b869b8329f433d5833530e0d02e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 23: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9712/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10497/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1046/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10654/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 24: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9711/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10496/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1045/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10653/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9713/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10498/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1047/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10655/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 22: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9714/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10499/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1048/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10656/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9715/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10500/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1049/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10657/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 13: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9716/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10501/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1050/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10658/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: simplify the remote port handling
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: simplify the remote port handling .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9717/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10502/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1051/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10659/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for reporting the timezone and os info
Michal Skrivanek has posted comments on this change. Change subject: Added support for reporting the timezone and os info .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28940/3//COMMIT_MSG Commit Message: Line 6: Line 7: Added support for reporting the timezone and os info Line 8: Line 9: The guest agent reports now the timezone and more detailed Line 10: os information. This patch introduces the support for those please refer the change in ga Line 11: new messages. Line 12: Line 13: Change-Id: Iadb85a5003fcb4693b5a1174655acf59193340b5 Line 14: Guest-Agent-API-Version: 2 http://gerrit.ovirt.org/#/c/28940/3/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 253: self.effectiveApiVersion = _IMPLICIT_API_VERSION_ZERO Line 254: elif message == 'host-name': Line 255: self.guestInfo['guestName'] = args['name'] Line 256: elif message == 'os-version': Line 257: self.guestInfo['guestOs'] = args['version'] so this is basically superseded by the os-info, right? Line 258: elif message == 'os-info': Line 259: self.guestInfo['guestOsInfo'] = args Line 260: elif message == 'timezone': Line 261: self.guestInfo['guestTimezone'] = args -- To view, visit http://gerrit.ovirt.org/28940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadb85a5003fcb4693b5a1174655acf59193340b5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for reporting the timezone and os info
Vinzenz Feenstra has posted comments on this change. Change subject: Added support for reporting the timezone and os info .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28940/3//COMMIT_MSG Commit Message: Line 6: Line 7: Added support for reporting the timezone and os info Line 8: Line 9: The guest agent reports now the timezone and more detailed Line 10: os information. This patch introduces the support for those please refer the change in ga Done Line 11: new messages. Line 12: Line 13: Change-Id: Iadb85a5003fcb4693b5a1174655acf59193340b5 Line 14: Guest-Agent-API-Version: 2 http://gerrit.ovirt.org/#/c/28940/3/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 253: self.effectiveApiVersion = _IMPLICIT_API_VERSION_ZERO Line 254: elif message == 'host-name': Line 255: self.guestInfo['guestName'] = args['name'] Line 256: elif message == 'os-version': Line 257: self.guestInfo['guestOs'] = args['version'] so this is basically superseded by the os-info, right? Yes, but we have to support it due to backwards compatibility Line 258: elif message == 'os-info': Line 259: self.guestInfo['guestOsInfo'] = args Line 260: elif message == 'timezone': Line 261: self.guestInfo['guestTimezone'] = args -- To view, visit http://gerrit.ovirt.org/28940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadb85a5003fcb4693b5a1174655acf59193340b5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added support for reporting the timezone and os info
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added support for reporting the timezone and os info .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9718/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1052/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10660/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadb85a5003fcb4693b5a1174655acf59193340b5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmcli: Add a contrib command line client alternative
Dan Kenigsberg has posted comments on this change. Change subject: vdsmcli: Add a contrib command line client alternative .. Patch Set 1: Code-Review+2 I'd prefer something that parses the schema, but we can take it in, and see if it turns out helpful. -- To view, visit http://gerrit.ovirt.org/28152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5574b2b34f0b7b2174e9da0c4487f812ff20f5b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...
Nir Soffer has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 331: infos['vcpuLimit'] = nodeList[0].childNodes[0].data
Line 332:
Line 333: return infos
Line 334:
Line 335: def _sampleIoTune(self):
Where do you see two seconds? The default was 15.
Sorry, I was confused by IO_TUNE_SAMPLING_WINDOW.
And now for my second question - when these values may change, and why we have
to use 15 seconds interval?
Please describe the flow in the commit message.
Line 336: info = []
Line 337:
Line 338: try:
Line 339: lastXMLDesc = self._vm._dom.XMLDesc(0)
Line 338: try:
Line 339: lastXMLDesc = self._vm._dom.XMLDesc(0)
Line 340: except libvirt.libvirtError:
Line 341: self._log.exception(Error while collecting ioTune for
%s,
Line 342: self._vm.name)
Not being able to colelct data from libvirt is a serious issue. That is wha
You did not answer my question about the usefulness of the traceback. Does it
add anything to log.error(e) where e is the libvirtError instance?
Line 343: return None
Line 344:
Line 345: devxml = _domParseStr(lastXMLDesc).childNodes[0] \
Line 346: .getElementsByTagName('devices')[0]
--
To view, visit http://gerrit.ovirt.org/28712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: remove last dependency on ifcfg persistence
Dan Kenigsberg has posted comments on this change. Change subject: net: remove last dependency on ifcfg persistence .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5d682eaf93b488fac0391bf4b84394d73d7f485 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Collect current QoS settings for IO devices and report throu...
Michal Skrivanek has posted comments on this change.
Change subject: Collect current QoS settings for IO devices and report through
RunningVmStats
..
Patch Set 6:
(4 comments)
not sure the design is actually correct if these values are not really dynamic.
Most harm has already been done with previous patches though, so I can live
with some proposal and plan how to change it...
http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 331: infos['vcpuLimit'] = nodeList[0].childNodes[0].data
Line 332:
Line 333: return infos
Line 334:
Line 335: def _sampleIoTune(self):
MOM and dynamic updates. When you set the blkio values, libvirt proceses th
If you set something and you just want to check once that it was applied(or
applied partially or adjusted) you should only read it once. This doesn't
belong to stats thread.
If it can change over the life of VM there should be libvirt event for that
(file a bug and add TODO)
If it can then change only on actions we do (migration, live storage mig, etc)
the vdsm code should retrieve the data only on that specific actions
And yes, cpu tune is wrong as well.
Line 336: info = []
Line 337:
Line 338: try:
Line 339: lastXMLDesc = self._vm._dom.XMLDesc(0)
Line 338: try:
Line 339: lastXMLDesc = self._vm._dom.XMLDesc(0)
Line 340: except libvirt.libvirtError:
Line 341: self._log.exception(Error while collecting ioTune for
%s,
Line 342: self._vm.name)
You did not answer my question about the usefulness of the traceback. Does
+1
as errors in stats thread do occur quite often around the lifecycle events…they
always alarm people and we should keep them at minimum
Line 343: return None
Line 344:
Line 345: devxml = _domParseStr(lastXMLDesc).childNodes[0] \
Line 346: .getElementsByTagName('devices')[0]
Line 346: .getElementsByTagName('devices')[0]
Line 347:
Line 348: diskxml = devxml.getElementsByTagName('disk')
Line 349:
Line 350: for disk in diskxml:
No way to match the xml record with the proper _devices entry without parsi
isn't it what alias is good for and used elsewhere?
Line 351: alias, path, name = self._vm._getDriveIdentification(disk)
Line 352: io_tune_dom = disk.getElementsByTagName('iotune')
Line 353: io_tune_values = {}
Line 354:
Line 607: self._getDiskStats(stats)
Line 608: self._getDiskLatency(stats)
Line 609: self._getBalloonStats(stats)
Line 610: self._getVmJobs(stats)
Line 611: self._getIoTuneStats(stats)
And btw are you two aware of the fact that this call only merges two dictio
yes, it will make me happy to add new things at the end and over the course of
versions be able to quickly see what is there and what not.
Of course the NUMA ugliness below should be fixed as well (separately) :)
Line 612:
Line 613: vmNumaNodeRuntimeMap =
numaUtils.getVmNumaNodeRuntimeInfo(self._vm)
Line 614: if vmNumaNodeRuntimeMap:
Line 615: stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap
--
To view, visit http://gerrit.ovirt.org/28712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ifcfg: make default route network be started by sysV
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: make default route network be started by sysV .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29312/1//COMMIT_MSG Commit Message: Line 7: ifcfg: make default route network be started by sysV Line 8: Line 9: With the change to unified persistence, the networks defined by vdsm Line 10: are only started and restored on boot by vdsmd itself. The issue with Line 11: this is that if vdsmd fails to start for not networking reasons it I think that s/not networking reasons/whatever reason/ would make the sentence clearer. Line 12: may impede remote access to the machine. Line 13: Line 14: This patch is a fix for oVirt 3.5 only (future versions will have Line 15: separate network and vdsm initializations) that solves the issue by Line 27: Line 28: It's easy to see that if (c) does not happen we will be left with Line 29: only the default route network, so remote access will still be Line 30: possible. Line 31: Please add something like Label: ovirt-3.4-only so that on the next branch point, we can be extra sure that this patch has been fixed in master? https://fedorahosted.org/ovirt/ticket/104 Line 32: Change-Id: Iaf656958e8ddfdd7e8be9a8bcb51962e073ae26a -- To view, visit http://gerrit.ovirt.org/29312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf656958e8ddfdd7e8be9a8bcb51962e073ae26a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: assert: Replace assetion with AssertionError
Antoni Segura Puimedon has posted comments on this change.
Change subject: assert: Replace assetion with AssertionError
..
Patch Set 1: Code-Review-1
(6 comments)
Thanks for the change. Some string suggestions.
http://gerrit.ovirt.org/#/c/29307/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-06-26 20:57:04 +0300
Line 4: Commit: Nir Soffer nsof...@redhat.com
Line 5: CommitDate: 2014-06-26 22:12:24 +0300
Line 6:
Line 7: assert: Replace assetion with AssertionError
s/assetion/assertion/
Line 8:
Line 9: If Python is run with -O flag, assertions are removed. This may casue a
Line 10: useful error message to be hidden, making it harder to debug, or worse,
Line 11: code invoke inside an assert will not run, changing the flow of the
Line 7: assert: Replace assetion with AssertionError
Line 8:
Line 9: If Python is run with -O flag, assertions are removed. This may casue a
Line 10: useful error message to be hidden, making it harder to debug, or worse,
Line 11: code invoke inside an assert will not run, changing the flow of the
s/invoke/invoked/
Line 12: optimized code.
Line 13:
Line 14: This patch replaces assertions with raising AssertionError, ensuring
Line 15: that when the impossible happen, we will get an expection.
http://gerrit.ovirt.org/#/c/29307/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 1007: for port in ports:
Line 1008: if port in self.vlans:
Line 1009: if vlan is not None:
Line 1010: raise AssertionError(Unexpected vlan: %s
exepected: None
Line 1011: % (vlan,))
the message should be: 'Unsupported: Found extra vlan device %s in network
%s that already has a vlan %s port.' % (port, network, vlan)
Line 1012: nic = getVlanDevice(port)
Line 1013: vlan = getVlanID(port)
Line 1014: if self.vlans[port]['iface'] != nic:
Line 1015: raise AssertionError(Unexpected iface: %s
expected: %s %
Line 1012: nic = getVlanDevice(port)
Line 1013: vlan = getVlanID(port)
Line 1014: if self.vlans[port]['iface'] != nic:
Line 1015: raise AssertionError(Unexpected iface: %s
expected: %s %
Line 1016: (self.vlans[port]['iface'],
nic))
the message should be: 'Unexpected vlan link device %s, expected %s' %
(self.vlans[port]['iface'], nic)
Line 1017: port = nic
Line 1018: if port in self.bondings:
Line 1019: if bonding is not None:
Line 1020: raise AssertionError(Unexpected bonding: %s
expected:
Line 1017: port = nic
Line 1018: if port in self.bondings:
Line 1019: if bonding is not None:
Line 1020: raise AssertionError(Unexpected bonding: %s
expected:
Line 1021: None % bonding)
the message should be: 'Unsupported: Found extra bond device %s in network
%s that already has a bond %s port.' % (port, network, bonding)
Line 1022: bonding = port
Line 1023: lnics += self.bondings[bonding]['slaves']
Line 1024: elif port in self.nics:
Line 1025: lnics.append(port)
http://gerrit.ovirt.org/#/c/29307/1/vdsm/rpc/BindingXMLRPC.py
File vdsm/rpc/BindingXMLRPC.py:
Line 1088: logLevel = logging.TRACE
Line 1089: displayArgs = args
Line 1090: if f.__name__ == 'vmDesktopLogin':
Line 1091: if 'password' in kwargs:
Line 1092: raise AssertionError(Unexpected kwarg:
password)
I'd say it should read: 'illegal parameter password for vmDesktopLogin'
Line 1093: if len(args) 3:
Line 1094: displayArgs = args[:3] + ('',) + args[4:]
Line 1095:
Line 1096: # Logging current call
--
To view, visit http://gerrit.ovirt.org/29307
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c60c65b283f4343448bb9eaf6ccf2526b188db0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: verifyingTransport testing
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: verifyingTransport testing .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9719/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10504/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/29/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/62/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/41/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10661/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: adding docstring to MultiProtocolAcceptor and Connecte...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9720/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10662/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: lastclient info in jsonrpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9721/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10663/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ifcfg: make default route network be started by sysV
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: make default route network be started by sysV .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf656958e8ddfdd7e8be9a8bcb51962e073ae26a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: adding docstring to MultiProtocolAcceptor and Connecte...
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer .. vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer MultiProtocolAcceptor and ConnectedTCPServer now have docstring explanation how they work. Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: http://gerrit.ovirt.org/28806 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/xmlrpc.py M vdsm/protocoldetector.py 2 files changed, 30 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: adding docstring to MultiProtocolAcceptor and Connecte...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: adding docstring to MultiProtocolAcceptor and Connecte...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: adding docstring to MultiProtocolAcceptor and ConnectedTcpServer .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1540/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5525/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3683/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28806 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bc02d93dfec10e95e4dd2554b797376f3a7543 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-store-net-config: make use of oVirt node bindings
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: vdsm-store-net-config: make use of oVirt node bindings
..
vdsm-store-net-config: make use of oVirt node bindings
Up until now, vdsm-store-net-config was a bash script that relied on
oVirt node's bash bindings for their python scripts. This patch
avoids the extra step to have a more fine grained access to the
new style ovirt.node.utils.fs package.
This patch depends on the oVirt node patches that make oVirt node
support symlink persistence.
Change-Id: Iee19cb9f6e1ba007631e7e6d315726d6efa03d09
Signed-off-by: Antoni S. Puimedon asegu...@redhat.com
---
M .gitignore
M vdsm/Makefile.am
A vdsm/vdsm-store-net-config
D vdsm/vdsm-store-net-config.in
4 files changed, 170 insertions(+), 85 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/29355/1
diff --git a/.gitignore b/.gitignore
index 5e8b53f..24ddb94 100644
--- a/.gitignore
+++ b/.gitignore
@@ -65,7 +65,6 @@
vdsm/vdsm-gencerts.sh
vdsm/vdsm-logrotate.conf
vdsm/vdsm-sosplugin.py
-vdsm/vdsm-store-net-config
vdsm/vdsm.rwtab
vdsm/vdsmd.8
vdsm/gluster/hostname.py
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 763ef2a..66b7a69 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -60,7 +60,6 @@
nodist_vdsm_SCRIPTS = \
mk_sysprep_floppy \
- vdsm-store-net-config
nodist_noinst_DATA = \
logger.conf \
@@ -80,6 +79,7 @@
supervdsmServer \
vdsm \
vdsm-restore-net-config \
+ vdsm-store-net-config \
$(NULL)
nodist_man8_MANS = \
@@ -118,7 +118,6 @@
vdsm-logrotate \
vdsm-logrotate.conf.in \
vdsm-modules-load.d.conf \
- vdsm-store-net-config.in \
vdsm-sysctl.conf \
vdsm.rwtab.in \
vdsmd.8.in \
diff --git a/vdsm/vdsm-store-net-config b/vdsm/vdsm-store-net-config
new file mode 100644
index 000..a54da13
--- /dev/null
+++ b/vdsm/vdsm-store-net-config
@@ -0,0 +1,169 @@
+#!/usr/bin/env python2
+#
+# Copyright 2009-2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+
+Stores all the vdsm configured networks persistently
+
+import glob
+import logging
+import logging.config
+import os
+import time
+import shutil
+
+from vdsm import config, constants, utils
+
+# ifcfg persistence directories
+NET_CONF_DIR = '/etc/sysconfig/network-scripts/'
+NET_CONF_BACK_DIR = constants.P_VDSM_LIB + '/netconfback'
+
+# Unified persistence directories
+RUN_CONF_DIR = constants.P_VDSM_RUN + '/netconf'
+PERSISTENT_SYMLINK_PATH = constants.P_VDSM_LIB + 'persistence/netconf'
+
+
+def _ifcfg_non_node_persist():
+Removes the backed up configuration files, thus implicitly marking those
+under /etc/sysconfig/network-scripts as safe
+logging.debug('Persistence: Marking /etc/sysconfig/network-scripts as safe'
+ )
+_rm_dir_contents(NET_CONF_BACK_DIR)
+
+
+def _ifcfg_node_persist():
+Removes the backed up configuration files and leverages oVirt node's
+facilities to make /etc/sysconfig/netwrok-scripts persistent
+node_conf = fs.Config()
+for path in os.listdir(NET_CONF_BACK_DIR):
+filename = os.path.basename(path)
+sysconf_ifcfg_path = NET_CONF_DIR + filename
+if os.path.exists(sysconf_ifcfg_path):
+# If we currently have a running configuration for the file, we
+# should make sure that it is persisted by the node
+logging.debug('Persistence: oVirt node persisting %s' %
+ sysconf_ifcfg_path)
+node_conf.persist(sysconf_ifcfg_path)
+else:
+# If there is no current file, we should make sure that there is
+# no persistent version either
+logging.debug('Persistence: oVirt node deleting %s' %
+ sysconf_ifcfg_path)
+node_conf.delete(sysconf_ifcfg_path)
+# remove the backup in case there's restore nets before reboot (on
+# reboot the file would be gone anyway)
+utils.rmFile(path)
+
+
+def _unified_non_node_persist():
+Atomically set RUN_CONF_DIR configuration as the new persistent vdsm
+network configuration
+
Change in vdsm[master]: vdsm-store-net-config: make use of oVirt node bindings
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-store-net-config: make use of oVirt node bindings .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9722/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10507/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10664/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1569/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit http://gerrit.ovirt.org/29355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee19cb9f6e1ba007631e7e6d315726d6efa03d09 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: verifyingTransport testing
Nir Soffer has posted comments on this change. Change subject: vdsm: verifyingTransport testing .. Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/28858/6/tests/sslTests.py File tests/sslTests.py: Line 64: def serve_forever(self): Line 65: try: Line 66: self.server.serve_forever() Line 67: except: Line 68: # we want to hide server side exception Do we? why? Line 69: pass Line 70: Line 71: def stop(self): Line 72: self.server.shutdown() Line 93: Line 94: class VerifyingTransportTests(TestCaseBase): Line 95: Line 96: def test_valid(self): Line 97: server = TestServer() try should be here - the server starts when created. Line 98: client = VerifingClient(server.port, KEY_FILE, CRT_FILE) Line 99: try: Line 100: self.assertEquals(client.add(2, 3), 5) Line 101: finally: Line 102: server.stop() Line 103: client.close() Line 104: Line 105: def test_invalid(self): Line 106: server = TestServer() Why this test does not need try finally? What you need here is a single check method, that run the same flow with different arguments: def check(self, key_file, crt_file): server = TestServer() try: client = VerifyingClient(server.port, key_fie, crt_file) try: return client.add(2, 3) finally: client.close() finally: server.stop() And then: def test_valid(self): self.assertEquals(self.check(KEY_FILE, CRT_FILE), 5) def test_invalid_crt(self): self.assertRaises... And so on, all needed combinations. Another option is to write a context mananger that starts a server and returns a client that you can use to send messages: @contextmanager def verifingclient(key_file, crt_file): server = TestServer() try: client = VerifyingClient(server.port, key_fie, crt_file) try: yield client finally: client.close() finally: server.stop() If it works, the tests can be nicer: with verifyingclient(...) as client: self.assertEquals(client.add(2, 3), 5) I'm not sure this effort is need for this module, but we can use what we learn here to make other tests nicer and easier to maintain. Line 107: client = VerifingClient(server.port, OTHER_KEY_FILE, OTHER_CRT_FILE) Line 108: Line 109: with self.assertRaises(ssl.SSLError): Line 110: self.assertEquals(client.add(2, 3), 5) Line 109: with self.assertRaises(ssl.SSLError): Line 110: self.assertEquals(client.add(2, 3), 5) Line 111: Line 112: server.stop() Line 113: client.close() Should we test also other combinations, like same KEY_FILE, other CRT_FILE? I don't know much abut the details of the verification. Line 114: Line 115: Line 116: class SSLServerThread(threading.Thread): Line 117: A very simple server thread. -- To view, visit http://gerrit.ovirt.org/28858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: verifyingTransport testing
Nir Soffer has posted comments on this change. Change subject: vdsm: verifyingTransport testing .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/28858/6/tests/run_tests_local.sh.in File tests/run_tests_local.sh.in: Line 3: PYTHON_EXE=@PYTHON@ Line 4: fi Line 5: Line 6: if [ ! -f @top_srcdir@/tests/server.crt ] || [ ! -f @top_srcdir@/tests/server.csr ] || [ ! -f @top_srcdir@/tests/server.key ] || [ ! -f @top_srcdir@/tests/other.crt ] || [ ! -f @top_srcdir@/tests/other.csr ] || [ ! -f @top_srcdir@/tests/other.key ]; then Line 7: @top_srcdir@/tests/makecert.sh In another patch, maybe move this to make target instead? Line 8: fi Line 9: -- To view, visit http://gerrit.ovirt.org/28858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop redundant hasattr()
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: drop redundant hasattr() .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9724/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10509/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1054/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10666/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23743b7c6f4a8b71a301d02670c348d53f23f124 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: set status before to invoke suspend
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: set status before to invoke suspend .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9723/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10508/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1053/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10665/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3aea96c7122d60e6cb888273678b565c3f3e537f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Add liveMerge capability to vdsCaps
Adam Litke has posted comments on this change. Change subject: Live Merge: Add liveMerge capability to vdsCaps .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/28998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac66c679166b5687ed3940e517fe6827fe10e258 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: improve log messages
Adam Litke has posted comments on this change. Change subject: Live Merge: improve log messages .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/29310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5d22e4c503d5781eb1dc00c6c326146d5d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: fix race between libvirt event and vm stats
Adam Litke has posted comments on this change. Change subject: Live Merge: fix race between libvirt event and vm stats .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/29309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0314a39428419bb21bc579f07a92227d5a7acff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: support active layer commit
Adam Litke has posted comments on this change. Change subject: Live Merge: support active layer commit .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:
Line 29: self._devicesHash = str(hash(self._devices)) if self._devices
else '0'
Line 30:
Line 31: @staticmethod
Line 32: def fromId(uuid):
Line 33: return DomainDescriptor('domainuuid%s/uuid/domain' %
uuid)
Should be class method:
@Nir are you sure you're not confusing this with @classmethod?
https://docs.python.org/2/library/functions.html#staticmethod vs
https://docs.python.org/2/library/functions.html#classmethod
Line 34:
Line 35: @property
Line 36: def xml(self):
Line 37: return self._xml
--
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev svinota.savel...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: support active layer commit
Greg Padgett has posted comments on this change. Change subject: Live Merge: support active layer commit .. Patch Set 5: Verified+1 Code-Review+1 Not too familiar with this code, but looks reasonable to me, and it works :) -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: fix race between libvirt event and vm stats
Greg Padgett has posted comments on this change. Change subject: Live Merge: fix race between libvirt event and vm stats .. Patch Set 1: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0314a39428419bb21bc579f07a92227d5a7acff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: cleanup the migration mode
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: cleanup the migration mode .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9725/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10510/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1055/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10667/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bfbc71e25dddf623ad2d79d5ee66f1501dbb81b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: improve log messages
Greg Padgett has posted comments on this change. Change subject: Live Merge: improve log messages .. Patch Set 1: Verified+1 Code-Review+1 My only reservation here is the job id first appears only at debug level, so if an error occurs and debug logging isn't enabled there is little host-side information to determine the specifics of what the job with that id was doing. However, it is cleaner and with a little investigating you can figure out what was going on. -- To view, visit http://gerrit.ovirt.org/29310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5d22e4c503d5781eb1dc00c6c326146d5d1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: replace status string with constant
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: replace status string with constant .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9726/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10511/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1056/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10668/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3bc8289141622561b0ce494598c7f7af1d6f837 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Add liveMerge capability to vdsCaps
Greg Padgett has posted comments on this change. Change subject: Live Merge: Add liveMerge capability to vdsCaps .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac66c679166b5687ed3940e517fe6827fe10e258 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: verifyingTransport testing
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: verifyingTransport testing .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9728/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10513/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/30/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/63/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/42/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10670/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: support active layer commit
Francesco Romani has posted comments on this change. Change subject: Live Merge: support active layer commit .. Patch Set 5: Code-Review-1 (5 comments) Since we are waiting on libvirt, let's try to make this code nicer. -1 for visibility. http://gerrit.ovirt.org/#/c/28598/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5541: flags |= libvirt.VIR_DOMAIN_BLOCK_COMMIT_ACTIVE Line 5542: except AttributeError: Line 5543: self.log.error(Unable to merge the active layer. Libvirt is Line 5544:missing VIR_DOMAIN_BLOCK_COMMIT_ACTIVE.) Line 5545: return errCode['mergeErr'] I think we can factor out this code with the new one added into http://gerrit.ovirt.org/#/c/28998 (which btw looks nice and ready to go). I think that rebasing this patch on 28998 will lead to simpler and cleaner code. Line 5546: Line 5547: try: Line 5548: self.trackBlockJob(jobUUID, drive, baseVolUUID, topVolUUID, Line 5549:'commit') Line 5666: if x['volumeID'] in volumes] Line 5667: device['volumeChain'] = drive.volumeChain = newChain Line 5668: Line 5669: def _onBlockJobActiveCommitEvent(self, diskName): Line 5670: flags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT this temporary looks unnecessary Line 5671: try: Line 5672: self._dom.blockJobAbort(diskName, flags) Line 5673: except libvirt.libvirtError: Line 5674: self.log.error(Failed to perform pivot, exc_info=True) Line 5670: flags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT Line 5671: try: Line 5672: self._dom.blockJobAbort(diskName, flags) Line 5673: except libvirt.libvirtError: Line 5674: self.log.error(Failed to perform pivot, exc_info=True) self._reportException may be handy here Line 5675: Line 5676: def _onBlockJobEvent(self, diskName, blockJobType, status): Line 5677: def isActiveCommit(jobType, status): Line 5678: if status != libvirt.VIR_DOMAIN_BLOCK_JOB_READY: Line 5681: if jobType == libvirt.VIR_DOMAIN_BLOCK_JOB_TYPE_ACTIVE_COMMIT: Line 5682: return True Line 5683: except AttributeError: Line 5684: pass Line 5685: return False Same as per line 5524: can we simplify this helper function , maybe after rebasing this patch on top of http://gerrit.ovirt.org/#/c/28998 ? Line 5686: Line 5687: drive = self._findDriveByName(diskName) Line 5688: try: Line 5689: jobID = self.getBlockJob(drive)['jobID'] Line 5686: Line 5687: drive = self._findDriveByName(diskName) Line 5688: try: Line 5689: jobID = self.getBlockJob(drive)['jobID'] Line 5690: except LookupError: Just caught my eye - can this raise KeyError also? Line 5691: self.log.debug(Ignoring event for untracked block job on disk Line 5692:'%s', diskName) Line 5693: return Line 5694: -- To view, visit http://gerrit.ovirt.org/28598 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idab76081c2d004bc4f9e5bc9cb72e86845640f6a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Add liveMerge capability to vdsCaps
Francesco Romani has posted comments on this change. Change subject: Live Merge: Add liveMerge capability to vdsCaps .. Patch Set 2: Code-Review+1 Looks good. Please consider to rebase http://gerrit.ovirt.org/#/c/28598/5 on top of this in order to save quite some AttributeError checks. -- To view, visit http://gerrit.ovirt.org/28998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac66c679166b5687ed3940e517fe6827fe10e258 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move Vm._reportError into utils
oVirt Jenkins CI Server has posted comments on this change. Change subject: janitorial: move Vm._reportError into utils .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9727/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10512/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1057/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10669/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01e822429b360bd0973d05b4831ba1b42b93a27f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Explicitly save block job info
Adam Litke has uploaded a new change for review.
Change subject: Live Merge: Explicitly save block job info
..
Live Merge: Explicitly save block job info
When we removed _blockJobs from the VM.status() it had the unfortunate
side effect of causing block job info to not be saved by VM.saveState().
Fix this by explicitly adding it to toSave.
Change-Id: I6175530fe0aed1e00ad02b6a4abe0704c294e45b
Signed-off-by: Adam Litke ali...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/29358/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 543b798..8813d94 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2351,6 +2351,8 @@
drive['truesize'] = str(d.truesize)
drive['apparentsize'] = str(d.apparentsize)
+toSave['_blockJobs'] = deepcopy(self.conf.get('_blockJobs', {}))
+
with tempfile.NamedTemporaryFile(dir=constants.P_VDSM_RUN,
delete=False) as f:
pickle.dump(toSave, f)
--
To view, visit http://gerrit.ovirt.org/29358
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6175530fe0aed1e00ad02b6a4abe0704c294e45b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke ali...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: lastclient info in jsonrpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9729/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10514/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10671/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Explicitly save block job info
Adam Litke has posted comments on this change. Change subject: Live Merge: Explicitly save block job info .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/29358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6175530fe0aed1e00ad02b6a4abe0704c294e45b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: improve log messages
Francesco Romani has posted comments on this change.
Change subject: Live Merge: improve log messages
..
Patch Set 1: Code-Review+1
(1 comment)
seems a nice improvement.
http://gerrit.ovirt.org/#/c/29310/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 5461: ret = None
Line 5462: if 'done' not in job:
Line 5463: ret = self._dom.blockJobInfo(drive.name, 0)
Line 5464: if not ret:
Line 5465: self.log.debug(Block Job %s has ended,
jobID)
Maybe change to info? no big deal however.
Line 5466: job['done'] = True
Line 5467:
Line 5468: entry = {'id': jobID, 'jobType': 'block',
Line 5469: 'blockJobType': job['blockJobType'],
--
To view, visit http://gerrit.ovirt.org/29310
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d22e4c503d5781eb1dc00c6c326146d5d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Explicitly save block job info
oVirt Jenkins CI Server has posted comments on this change. Change subject: Live Merge: Explicitly save block job info .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9730/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10515/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1058/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10672/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6175530fe0aed1e00ad02b6a4abe0704c294e45b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: janitorial: move Vm._reportError into utils
Francesco Romani has posted comments on this change. Change subject: janitorial: move Vm._reportError into utils .. Patch Set 3: Verified+1 fixed 'self' (not needed anymore). Verified the error path using vdsClient and the setBalloonTarget verb, by manually injecting errors. -- To view, visit http://gerrit.ovirt.org/28835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01e822429b360bd0973d05b4831ba1b42b93a27f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: lastclient info in jsonrpc
Saggi Mizrahi has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc .. Patch Set 8: Instead of passing address couldn't we just use socket.getsockname() To get the address\port associated with the socket. -- To view, visit http://gerrit.ovirt.org/28817 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I402e15cb05f89a98dab14491d9da5985335e095e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: allow window=1 in AdvancedStatsFunction
Francesco Romani has posted comments on this change. Change subject: sampling: allow window=1 in AdvancedStatsFunction .. Patch Set 8: Verified+1 verified with the unit tests; being a new API, can't break anything. -- To view, visit http://gerrit.ovirt.org/28992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ce1fed5a211ed58b7df4728d5bfc3c17fccfbd8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: allow window=1 in AdvancedStatsFunction
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: allow window=1 in AdvancedStatsFunction .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9731/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1059/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10673/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ce1fed5a211ed58b7df4728d5bfc3c17fccfbd8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpole...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add an helper method to get Vm policy
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: add an helper method to get Vm policy .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9732/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10517/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1060/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10674/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9291b939c044ac603b825053a3a06f3ab9649e2f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Kobi Ianko k...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: stats: move VmStatsThread away from vm.py
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: stats: move VmStatsThread away from vm.py .. Patch Set 19: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9733/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10518/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1061/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10675/ : FAILURE -- To view, visit http://gerrit.ovirt.org/26792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd18288b94c7593ddd2a5e6a1314b6be7a7d8f92 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add direct import of advancedstats helpers
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add direct import of advancedstats helpers .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9734/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10519/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1062/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10676/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b009f4a0cb0179fa1f1b74774ba61fd6638d8a9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: verifyingTransport testing
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: verifyingTransport testing .. Patch Set 7: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28858/7/tests/sslTests.py File tests/sslTests.py: Line 64: def serve_forever(self): Line 65: try: Line 66: self.server.serve_forever() Line 67: except: Line 68: # we want to hide server side exception could you catch only the expected exceptions here? and if you keep the comment, please explain *why* we want to hide the errors. Line 69: pass Line 70: Line 71: def stop(self): Line 72: self.server.shutdown() Line 93: Line 94: class VerifyingTransportTests(TestCaseBase): Line 95: Line 96: def test_valid(self): Line 97: server = TestServer() I do not see Nir's comments acted upon - shouldn't they? Line 98: client = VerifingClient(server.port, KEY_FILE, CRT_FILE) Line 99: try: Line 100: self.assertEquals(client.add(2, 3), 5) Line 101: finally: -- To view, visit http://gerrit.ovirt.org/28858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: extend image over jsonrpc
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: extend image over jsonrpc .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9735/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10520/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10677/ : FAILURE -- To view, visit http://gerrit.ovirt.org/29359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I437a23e04f97fb89eb4cd5646b73d9b1bddf240a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Eylon yaniv.ey...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 23: Verified+1 Verified on a patched VDSM doing a few migrations back and forth. -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 22: verified on a patched VDSM doing a few migraiton back and forth. Tested: 25976, 25977, 25978, 26279 -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 22: Verified+1 -- To view, visit http://gerrit.ovirt.org/25976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: merge monitor and downtime thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: merge monitor and downtime thread .. Patch Set 23: Tested: 25976, 25977, 25978, 26279 -- To view, visit http://gerrit.ovirt.org/25977 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 25: Verified doing a few migration back and forth. Tested-With: 25976, 25977, 25978, 26279 -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
Francesco Romani has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 25: Verified+1 -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
Francesco Romani has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 14: Verified by doing a few migrations back and forth Tested-With: 25976, 25977, 25978, 26279 -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: simplify the remote port handling
Francesco Romani has posted comments on this change. Change subject: virt: migration: simplify the remote port handling .. Patch Set 3: Verified+1 Verified by doing some migrations. Note that the default configuration was not changed during the tests, and it was the same on both src and dst host. -- To view, visit http://gerrit.ovirt.org/29048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: replace magic number
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: replace magic number .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9737/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10522/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1065/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10680/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ef125866ed7d1590f1c0cee0084daf86c6ee912 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: use contextmanager for monitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor .. Patch Set 25: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9736/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1063/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10678/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: decouple monitoring from thread
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: decouple monitoring from thread .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9739/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10524/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1066/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10681/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/26279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I364a9eeb72e3b4213278adff352f3eade19548a3 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: rename helper function
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: rename helper function .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9738/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10523/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1064/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10679/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida7287528456763d641bc465dfd6e5e8e83f3f62 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: simplify the remote port handling
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: migration: simplify the remote port handling .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9740/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/10525/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1067/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/10682/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee19377c6387738d7c4d4a898b6e716a1eeb884c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: migration: add monitor thread control loop
Dan Kenigsberg has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 22: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/25976/22/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 415: while not self._stop.isSet():
Line 416: self._stop.wait(self._MONITOR_TICK)
Line 417: for action in actions:
Line 418: action(step)
Line 419: step += self._MONITOR_TICK
step has to be integer - there are no 1.2 steps. It's not just a matter of
names (see next comment), but I think things woul dbecome simpler if you track
elapsed time.
Line 420:
Line 421: self._vm.log.debug('migration monitor thread exiting')
Line 422:
Line 423: def monitor_migration(self, step):
Line 426: return 100
Line 427: progress = 100 - 100 * remaining / total if total else 0
Line 428: return progress if (progress 100) else 99
Line 429:
Line 430: if step % self._MONITOR_INTERVAL == 0: # each
_MONITOR_INTERVAL ticks
this would not work if someone sets a non-integer _MONITOR_TICK: for example,
10 % 0.2 != 0
as a rule, floating point arithmetic should be avoided.
Line 431: (jobType, timeElapsed, _,
Line 432: dataTotal, dataProcessed, dataRemaining,
Line 433: memTotal, memProcessed, memRemaining,
Line 434: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo()
--
To view, visit http://gerrit.ovirt.org/25976
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extract the DOM to Drive name, alias and path logic to reusa...
Dan Kenigsberg has posted comments on this change. Change subject: Extract the DOM to Drive name, alias and path logic to reusable method .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7389dd8960c9c6245148d9191b2bea5a7e9e4a46 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extract the DOM to Drive name, alias and path logic to reusa...
Dan Kenigsberg has submitted this change and it was merged. Change subject: Extract the DOM to Drive name, alias and path logic to reusable method .. Extract the DOM to Drive name, alias and path logic to reusable method Change-Id: I7389dd8960c9c6245148d9191b2bea5a7e9e4a46 Signed-off-by: Martin Sivak msi...@redhat.com Reviewed-on: http://gerrit.ovirt.org/29059 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 14 insertions(+), 11 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Martin Sivák: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/29059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7389dd8960c9c6245148d9191b2bea5a7e9e4a46 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improve the _validateIoTuneParams so the params are passed a...
Dan Kenigsberg has posted comments on this change. Change subject: Improve the _validateIoTuneParams so the params are passed as argument .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08e8bd5a25320f45501b35bb0c9cae507200eb8b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Extract the DOM to Drive name, alias and path logic to reusa...
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract the DOM to Drive name, alias and path logic to reusable method .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1541/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3684/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7389dd8960c9c6245148d9191b2bea5a7e9e4a46 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: extract a method to wait for migration
Dan Kenigsberg has posted comments on this change.
Change subject: vm: extract a method to wait for migration
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28509/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3592: del self.conf['username']
Line 3593: self.saveState()
Line 3594: self.log.debug(End of migration)
Line 3595:
Line 3596: def _waitForIncomingMigrationToComplete(self):
this confuses me with _waitForIncomingMigrationFinish
I mean, that the separation of responsibility between the calling
waitForIncomingMigrationFinish and the new waitForIncomingMigrationToComplete
is not clear to me, and their names do not help.
Line 3597: timeout = config.getint('vars',
'migration_destination_timeout')
Line 3598: self.log.debug(Waiting %s seconds for end of migration,
timeout)
Line 3599: self._incomingMigrationFinished.wait(timeout)
Line 3600:
--
To view, visit http://gerrit.ovirt.org/28509
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic469814afc607951870f4171499cef958855fc54
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: verifyingTransport testing
Nir Soffer has posted comments on this change. Change subject: vdsm: verifyingTransport testing .. Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/28858/7/tests/sslTests.py File tests/sslTests.py: Line 28: import tempfile Line 29: import threading Line 30: import xmlrpclib Line 31: Line 32: from sslHelper import KEY_FILE, CRT_FILE, OTHER_KEY_FILE, OTHER_CRT_FILE can you rename this to sslhelper ? modules names should not use mixedCase. We have such modules (and Python standard library also) but pep8 recommend lowercase module names. Line 33: from testrunner import VdsmTestCase as TestCaseBase Line 34: from vdsm.sslutils import SSLServerSocket Line 35: from vdsm.sslutils import VerifyingSafeTransport Line 36: Line 64: def serve_forever(self): Line 65: try: Line 66: self.server.serve_forever() Line 67: except: Line 68: # we want to hide server side exception could you catch only the expected exceptions here? and if you keep the comm Please replace the comment with with the text in your reply in version 6: http://gerrit.ovirt.org/#/c/28858/6/tests/sslTests.py The current comment does not add any new information. I can tell by looking at the code that you want to hide server side exception. What I cannot tell is why. Line 69: pass Line 70: Line 71: def stop(self): Line 72: self.server.shutdown() -- To view, visit http://gerrit.ovirt.org/28858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: janitorial: detect if dom is running
Dan Kenigsberg has posted comments on this change. Change subject: vm: janitorial: detect if dom is running .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5bd28c43ab934dc5525fc952b646e2bd9b71b78 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: janitorial: detect if dom is running
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: janitorial: detect if dom is running .. vm: janitorial: detect if dom is running this patch extracts a little helper method to detect if the underlying libvirt domain is running. Change-Id: If5bd28c43ab934dc5525fc952b646e2bd9b71b78 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/28510 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/28510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5bd28c43ab934dc5525fc952b646e2bd9b71b78 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: janitorial: detect if dom is running
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: janitorial: detect if dom is running .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5527/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3685/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/28510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5bd28c43ab934dc5525fc952b646e2bd9b71b78 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:
Line 29: self._devicesHash = str(hash(self._devices)) if self._devices
else '0'
Line 30:
Line 31: @staticmethod
Line 32: def fromId(uuid):
Line 33: return DomainDescriptor('domainuuid%s/uuid/domain' %
uuid)
@Nir are you sure you're not confusing this with @classmethod? https://docs
I do not understand your question - Vinzenz is using a @staticmethod and I
suggested a @classmethod - where is the confusion?
Line 34:
Line 35: @property
Line 36: def xml(self):
Line 37: return self._xml
--
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev svinota.savel...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
