Change in vdsm[master]: virt: sampling: consolidate disk statistics
Francesco Romani has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29953/4//COMMIT_MSG Commit Message: Line 16: and cheaper to read all the needed information in one go, Line 17: saving one libvirt call without losing any information. Line 18: Line 19: If the configuration is different, the old behaviour is Line 20: preserved for the sake of backward compatibility. > Do we need this backward compatibility? I think this configuration is for u I agree with you, because the backward compatibility makes the code uglier in every way I can conceive. But we exposed these settings to the user (and long ago), so we are bound to keep them for all the 3.x.y cycle, I believe. Dan? Line 21: Line 22: Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c -- To view, visit http://gerrit.ovirt.org/29953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Francesco Romani has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 25: (1 comment) http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4489: return pid Line 4490: Line 4491: def _updateDomainDescriptor(self): Line 4492: domainXML = self._dom.XMLDesc(0) Line 4493: self._lastXMLDesc = DomainDescriptor(domainXML) > We can also do it in another patch - but this patch changes every line that 'domain' is nicer and shorter, and as you said saves developer time. Will change. Should I also squash http://gerrit.ovirt.org/#/c/33672/1 in this? Only name are changed, non changes in functioning. Line 4494: Line 4495: def _ejectFloppy(self): Line 4496: if 'volatileFloppy' in self.conf: Line 4497: utils.rmFile(self.conf['floppy']) -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ewoud Kohl van Wijngaarden Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: consolidate disk statistics
Nir Soffer has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics .. Patch Set 4: (1 comment) Partial review http://gerrit.ovirt.org/#/c/29953/4//COMMIT_MSG Commit Message: Line 16: and cheaper to read all the needed information in one go, Line 17: saving one libvirt call without losing any information. Line 18: Line 19: If the configuration is different, the old behaviour is Line 20: preserved for the sake of backward compatibility. Do we need this backward compatibility? I think this configuration is for us, so we can modify the behavior easily, not for users. This configuration is not documented right? Lets drop the false backward compatibility and simplify the code. Line 21: Line 22: Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c -- To view, visit http://gerrit.ovirt.org/29953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Nir Soffer has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 25: (1 comment) http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4489: return pid Line 4490: Line 4491: def _updateDomainDescriptor(self): Line 4492: domainXML = self._dom.XMLDesc(0) Line 4493: self._lastXMLDesc = DomainDescriptor(domainXML) > Lets clean up the ugly _lastXMLDesc - how about self._domain? We can also do it in another patch - but this patch changes every line that touch self._lastXMLDesc since we change the type. Changing the name now will save additional verification and will save reviewers time. Line 4494: Line 4495: def _ejectFloppy(self): Line 4496: if 'volatileFloppy' in self.conf: Line 4497: utils.rmFile(self.conf['floppy']) -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ewoud Kohl van Wijngaarden Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 25:
(2 comments)
Partial review
http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4489: return pid
Line 4490:
Line 4491: def _updateDomainDescriptor(self):
Line 4492: domainXML = self._dom.XMLDesc(0)
Line 4493: self._lastXMLDesc = DomainDescriptor(domainXML)
Lets clean up the ugly _lastXMLDesc - how about self._domain?
For example:
for device in self._domain.devices:
...
Or:
self._domain.xml
Line 4494:
Line 4495: def _ejectFloppy(self):
Line 4496: if 'volatileFloppy' in self.conf:
Line 4497: utils.rmFile(self.conf['floppy'])
Line 5045: def _getUnderlyingNetworkInterfaceInfo(self):
Line 5046: """
Line 5047: Obtain network interface info from libvirt.
Line 5048: """
Line 5049: # TODO use xpath instead of parseString (here and elsewhere)
This comment can be remove now.
Line 5050: for x in self._lastXMLDesc.getDeviceElements('interface'):
Line 5051: devType = x.getAttribute('type')
Line 5052: mac =
x.getElementsByTagName('mac')[0].getAttribute('address')
Line 5053: alias =
x.getElementsByTagName('alias')[0].getAttribute('name')
--
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Peter V. Saveliev
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd
Nir Soffer has posted comments on this change. Change subject: utils: move nice ionice sid and sudo out of execCmd .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/33691/1//COMMIT_MSG Commit Message: Line 4: Commit: Federico Simoncelli Line 5: CommitDate: 2014-10-01 17:22:45 + Line 6: Line 7: utils: move nice ionice sid and sudo out of execCmd Line 8: > Description will come. Main reason is code reuse (for who'll be using CPope I'm waiting for the detailed description and examples client code using the new api. Line 9: Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40 -- To view, visit http://gerrit.ovirt.org/33691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf
Vitor de Lima has posted comments on this change. Change subject: vm: Fix error with missing cdrom in conf .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/33472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Fix error with missing cdrom in conf
Vitor de Lima has posted comments on this change. Change subject: vm: Fix error with missing cdrom in conf .. Patch Set 1: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/33501/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-09-29 13:17:02 -0300 Line 6: Line 7: vm: Fix error with missing cdrom in conf Line 8: Line 9: Avoids referencing the cdrom parameter in conf in case it is missing. > Please try to find out what triggered this issue on Engine's side, since th By checking the source code, as long as the engine uses the "new" VmInfoBuilder (and not the VmOldInfoBuilder), the "cdrom" key will be missing in conf until the user changes the attached CD ISO. So, as far as I could tell, this happens since 3.1. Line 10: Line 11: Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7 Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145728 -- To view, visit http://gerrit.ovirt.org/33501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfebf61316372f24428f7342479a5f29637a4fc7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: task: add the support for abortEvent
oVirt Jenkins CI Server has posted comments on this change. Change subject: task: add the support for abortEvent .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11775/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12719/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12564/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib82289e28e5ad9ea142850c31ccff3366b8397dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: missing verbs in command info
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: missing verbs in command info .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/35/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/31/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/30/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/35/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: task: add the support for abortEvent
oVirt Jenkins CI Server has posted comments on this change. Change subject: task: add the support for abortEvent .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12723/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib82289e28e5ad9ea142850c31ccff3366b8397dc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: task: remove unused canAbortRecover
oVirt Jenkins CI Server has posted comments on this change. Change subject: task: remove unused canAbortRecover .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12722/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9796d92fad0210778bba5e50015faa289e283b28 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: remove obsolete getVolumePath verb
Federico Simoncelli has posted comments on this change. Change subject: hsm: remove obsolete getVolumePath verb .. Patch Set 1: Verified+1 Verified building. -- To view, visit http://gerrit.ovirt.org/33353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d15dee9e805478f4b4d2bfcb7985484db77339e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd
Federico Simoncelli has posted comments on this change. Change subject: utils: move nice ionice sid and sudo out of execCmd .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33691/1//COMMIT_MSG Commit Message: Line 4: Commit: Federico Simoncelli Line 5: CommitDate: 2014-10-01 17:22:45 + Line 6: Line 7: utils: move nice ionice sid and sudo out of execCmd Line 8: Description will come. Main reason is code reuse (for who'll be using CPopen directly instead of execCmd/watchCmd/AsyncProc... that as far as I understood from Saggi are probably going to be deprecated somehow). Line 9: Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40 http://gerrit.ovirt.org/#/c/33691/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 556: Line 557: Line 558: def nice_cmd(cmd, nice): Line 559: command = [constants.EXT_NICE, '-n', str(nice)] Line 560: command.extend(cmd) I am using this syntax (instead of: command + cmd) so that "cmd" can be anything (tuple, iter, etc.). Maybe I should comment in the code... although I'd probably have to comment it in each command. Also: I just noticed that I haven't renamed one of the two cmd/command (ugly). Suggestions on names are welcome. Line 561: return command Line 562: Line 563: Line 564: def ionice_cmd(cmd, ioclass, ioclassdata=None): -- To view, visit http://gerrit.ovirt.org/33691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: move nice ionice sid and sudo out of execCmd .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11777/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12721/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12566/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33691 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yoav Kleinberger Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: remove return redundant parenthesis
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: remove return redundant parenthesis .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11776/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12720/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12565/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71708a90499d8b2375ffb6bd83297a0c1b1c5ce3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add eventfd and EventFile synchronization
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add eventfd and EventFile synchronization .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11773/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12717/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12562/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d237f13c42b1f4505c90d30c6d3c3ecbd1e9fa7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add eventfd and EventFile synchronization
Federico Simoncelli has posted comments on this change. Change subject: vdsm: add eventfd and EventFile synchronization .. Patch Set 1: Verified+1 (1 comment) Verified with unit tests. http://gerrit.ovirt.org/#/c/33687/1//COMMIT_MSG Commit Message: Line 4: Commit: Federico Simoncelli Line 5: CommitDate: 2014-10-01 17:19:35 + Line 6: Line 7: vdsm: add eventfd and EventFile synchronization Line 8: Description will come. Line 9: Change-Id: I0d237f13c42b1f4505c90d30c6d3c3ecbd1e9fa7 -- To view, visit http://gerrit.ovirt.org/33687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d237f13c42b1f4505c90d30c6d3c3ecbd1e9fa7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: task: remove unused canAbortRecover
oVirt Jenkins CI Server has posted comments on this change. Change subject: task: remove unused canAbortRecover .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11774/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12718/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12563/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9796d92fad0210778bba5e50015faa289e283b28 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: task: add the support for abortEvent
Federico Simoncelli has uploaded a new change for review.
Change subject: task: add the support for abortEvent
..
task: add the support for abortEvent
Change-Id: Ib82289e28e5ad9ea142850c31ccff3366b8397dc
Signed-off-by: Federico Simoncelli
---
M vdsm/storage/task.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/33689/1
diff --git a/vdsm/storage/task.py b/vdsm/storage/task.py
index cc1d85e..97c30bf 100644
--- a/vdsm/storage/task.py
+++ b/vdsm/storage/task.py
@@ -58,6 +58,7 @@
from threadLocal import vars
from weakref import proxy
from vdsm.config import config
+from vdsm.eventfd import EventFile
import outOfProcess as oop
from logUtils import SimpleLogAdapter
@@ -488,6 +489,7 @@
self.mng = None
self._aborting = False
+self.abortEvent = EventFile()
self._forceAbort = False
self.ref = 0
@@ -544,6 +546,7 @@
def __state_aborting(self, fromState):
if self.ref > 1:
return
+self.abortEvent.set()
self.log.debug("_aborting: recover policy %s", self.recoveryPolicy)
if self.recoveryPolicy == TaskRecoveryType.auto:
self._updateState(State.racquiring)
@@ -564,6 +567,7 @@
def __state_raborting(self, fromState):
if self.ref == 1:
+self.abortEvent.set()
self._updateState(State.failed)
else:
self.log.warn("State was change to 'raborting' "
@@ -1225,6 +1229,7 @@
"ignoring", self.state)
return
+self.abortEvent.set()
self._aborting = True
self._forceAbort = force
finally:
--
To view, visit http://gerrit.ovirt.org/33689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib82289e28e5ad9ea142850c31ccff3366b8397dc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add eventfd and EventFile synchronization
Federico Simoncelli has uploaded a new change for review.
Change subject: vdsm: add eventfd and EventFile synchronization
..
vdsm: add eventfd and EventFile synchronization
Change-Id: I0d237f13c42b1f4505c90d30c6d3c3ecbd1e9fa7
Signed-off-by: Federico Simoncelli
---
M lib/vdsm/Makefile.am
A lib/vdsm/eventfd.py
M tests/Makefile.am
A tests/eventfdTests.py
4 files changed, 251 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/33687/1
diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am
index 4bebf28..e712cad 100644
--- a/lib/vdsm/Makefile.am
+++ b/lib/vdsm/Makefile.am
@@ -25,6 +25,7 @@
__init__.py \
compat.py \
define.py \
+ eventfd.py \
exception.py \
ipwrapper.py \
libvirtconnection.py \
diff --git a/lib/vdsm/eventfd.py b/lib/vdsm/eventfd.py
new file mode 100644
index 000..b2a7084
--- /dev/null
+++ b/lib/vdsm/eventfd.py
@@ -0,0 +1,140 @@
+#
+# Copyright 2014 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+"""\
+This module provides the support for eventfd(2).
+
+More information about eventfd and usage examples can be found in the
+eventfd(2) man page.
+
+The EventFile class provides a single synchronization object exposing
+the python Event interface and associated eventfds.
+
+The eventfd() context manager returns a file descriptor that can be
+used to provide the event notice to select, poll and epoll, e.g.
+
+import os
+import sys
+import select
+import threading
+import time
+from vdsm.eventfd import EventFile, DATASIZE
+
+e = EventFile()
+p = select.epoll()
+
+threading.Timer(5, e.set).start()
+
+with e.eventfd() as efd:
+p.register(efd, select.EPOLLIN)
+p.register(sys.stdin.fileno(), select.EPOLLIN)
+
+print "Echoing lines until event is received"
+event_received = False
+
+while not event_received:
+for fileno, event in p.poll():
+if not event & select.EPOLLIN:
+continue
+
+if fileno == efd:
+os.read(efd, DATASIZE)
+event_received = True
+elif fileno == sys.stdin.fileno():
+print os.read(sys.stdin.fileno(), 1024),
+
+print "Event received!"
+
+
+The Event set() semantic is preserved in the eventfd context manager:
+if the event is set then the eventfd already contains the notification.
+This is both to maintain the semantic and to avoid possible races as:
+
+if not e.is_set():
+with e.eventfd() as efd:
+...
+"""
+
+import os
+import ctypes
+import threading
+
+from contextlib import contextmanager
+
+_libc = ctypes.CDLL('libc.so.6', use_errno=True)
+
+EFD_NONBLOCK = os.O_NONBLOCK
+EFD_CLOEXEC = 0200 # os.O_CLOEXEC in python 3.3
+EFD_SEMAPHORE = 0001
+
+DATASIZE = ctypes.sizeof(ctypes.c_ulonglong)
+
+
+def eventfd(initval, flags):
+return _libc.eventfd(initval, flags)
+
+
+class EventFile(object):
+def __init__(self, event=None):
+self.__lock = threading.Lock()
+self.__fds = set()
+self.__event = event or threading.Event()
+
+@staticmethod
+def __fire_event(fd):
+os.write(fd, ctypes.c_ulonglong(1))
+
+def open_eventfd(self):
+with self.__lock:
+fd = eventfd(0, 0)
+
+self.__fds.add(fd)
+
+if self.__event.is_set():
+self.__fire_event(fd)
+
+return fd
+
+@contextmanager
+def eventfd(self):
+fd = self.open_eventfd()
+
+yield fd
+
+with self.__lock:
+self.__fds.remove(fd)
+os.close(fd)
+
+def isSet(self):
+return self.__event.isSet()
+
+is_set = isSet
+
+def set(self):
+with self.__lock:
+self.__event.set()
+for fd in self.__fds:
+self.__fire_event(fd)
+
+def clear(self):
+self.__event.clear()
+
+def wait(self, timeout=None, balancing=True):
+self.__event.wait(timeout)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 449d7b1..120712e 100644
--- a/tests/M
Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd
Federico Simoncelli has uploaded a new change for review.
Change subject: utils: move nice ionice sid and sudo out of execCmd
..
utils: move nice ionice sid and sudo out of execCmd
Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40
Signed-off-by: Federico Simoncelli
---
M lib/vdsm/utils.py
1 file changed, 33 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/33691/1
diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py
index 30b0d0c..244f0e2 100644
--- a/lib/vdsm/utils.py
+++ b/lib/vdsm/utils.py
@@ -555,6 +555,34 @@
return ' '.join(parts)
+def nice_cmd(cmd, nice):
+command = [constants.EXT_NICE, '-n', str(nice)]
+command.extend(cmd)
+return command
+
+
+def ionice_cmd(cmd, ioclass, ioclassdata=None):
+command = [constants.EXT_IONICE, '-c', str(ioclass)]
+if ioclassdata is not None:
+command.extend(('-n', str(ioclassdata)))
+command.extend(cmd)
+return command
+
+
+def setsid_cmd(cmd):
+command = [constants.EXT_SETSID]
+command.extend(cmd)
+return command
+
+
+def sudo_cmd(cmd):
+command = []
+if os.geteuid() != 0:
+command.extend((constants.EXT_SUDO, SUDO_NON_INTERACTIVE_FLAG))
+command.extend(cmd)
+return command
+
+
def execCmd(command, sudo=False, cwd=None, data=None, raw=False,
printable=None, env=None, sync=True, nice=None, ioclass=None,
ioclassdata=None, setsid=False, execCmdLogger=logging.root,
@@ -571,22 +599,17 @@
command = list(command)
if ioclass is not None:
-cmd = command
-command = [constants.EXT_IONICE, '-c', str(ioclass)]
-if ioclassdata is not None:
-command.extend(("-n", str(ioclassdata)))
-
-command = command + cmd
+command = ionice_cmd(command, ioclass=ioclass,
+ ioclassdata=ioclassdata)
if nice is not None:
-command = [constants.EXT_NICE, '-n', str(nice)] + command
+command = nice_cmd(command, nice=nice)
if setsid:
-command = [constants.EXT_SETSID] + command
+command = setsid_cmd(command)
if sudo:
-if os.geteuid() != 0:
-command = [constants.EXT_SUDO, SUDO_NON_INTERACTIVE_FLAG] + command
+command = sudo_cmd(command)
if not printable:
printable = command
--
To view, visit http://gerrit.ovirt.org/33691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I442c64e8b9cfb3933dbe9879b1d442d0e96fbe40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: task: remove unused canAbortRecover
Federico Simoncelli has uploaded a new change for review.
Change subject: task: remove unused canAbortRecover
..
task: remove unused canAbortRecover
Change-Id: I9796d92fad0210778bba5e50015faa289e283b28
Signed-off-by: Federico Simoncelli
---
M vdsm/storage/task.py
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/33688/1
diff --git a/vdsm/storage/task.py b/vdsm/storage/task.py
index f9ce837..cc1d85e 100644
--- a/vdsm/storage/task.py
+++ b/vdsm/storage/task.py
@@ -207,9 +207,6 @@
def canAbortRecovery(self):
return self.state in self._moveto[self.raborting]
-def canAbortRecover(self):
-return self.state in self._moveto[self.raborting]
-
def __str__(self):
return self.state
@@ -936,7 +933,7 @@
try:
try:
if (not self.state.canAbort() and
-(force and not self.state.canAbortRecover())):
+(force and not self.state.canAbortRecovery())):
self.log.warning("Task._doAbort %s: ignoring - "
"at state %s", self, self.state)
return
--
To view, visit http://gerrit.ovirt.org/33688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9796d92fad0210778bba5e50015faa289e283b28
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: remove return redundant parenthesis
Federico Simoncelli has uploaded a new change for review. Change subject: utils: remove return redundant parenthesis .. utils: remove return redundant parenthesis Change-Id: I71708a90499d8b2375ffb6bd83297a0c1b1c5ce3 Signed-off-by: Federico Simoncelli --- M lib/vdsm/utils.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/33690/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index 23c63e8..30b0d0c 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -617,7 +617,7 @@ out = out.splitlines(False) err = err.splitlines(False) -return (p.returncode, out, err) +return p.returncode, out, err def stripNewLines(lines): @@ -645,7 +645,7 @@ [proc.returncode == 0], repr(err), proc.returncode) -return (proc.returncode, out, err) +return proc.returncode, out, err def traceback(on="", msg="Unhandled exception"): -- To view, visit http://gerrit.ovirt.org/33690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I71708a90499d8b2375ffb6bd83297a0c1b1c5ce3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: missing verbs in command info
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: missing verbs in command info .. jsonrpc: missing verbs in command info Missing clone image structure and image sync data in command info. Bug-Url: https://bugzilla.redhat.com/1148498 Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Signed-off-by: pkliczewski Reviewed-on: http://gerrit.ovirt.org/33669 Reviewed-by: Daniel Erez Tested-by: Daniel Erez Reviewed-by: Dan Kenigsberg (cherry picked from commit 5073708e0e0e2b4fd41625a41ea8bdd0d5e8bb5e) Reviewed-on: http://gerrit.ovirt.org/33678 --- M vdsm/rpc/Bridge.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: missing verbs in command info
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: missing verbs in command info .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: sslutils: Document M2Crypto threading initialization
oVirt Jenkins CI Server has posted comments on this change. Change subject: sslutils: Document M2Crypto threading initialization .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/34/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/30/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/29/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/34/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e5f8dc4662e16ba7e39f60336819750e1366124 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert "ssl: adding ssl threading initialization"
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert "ssl: adding ssl threading initialization" .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/33/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/29/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/28/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/33/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddc883dc7ad18eeaecd02f864b8d788c07f7e776 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: adding ssl threading initialization
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: adding ssl threading initialization .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/32/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/28/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/27/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/32/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcf8d9dc26d3a040a5519629d42aa5860fa73f52 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: missing verbs in command info
Dan Kenigsberg has uploaded a new change for review.
Change subject: jsonrpc: missing verbs in command info
..
jsonrpc: missing verbs in command info
Missing clone image structure and image sync data in command info.
Bug-url: https://bugzilla.redhat.com/1148498
Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed
Signed-off-by: pkliczewski
Reviewed-on: http://gerrit.ovirt.org/33669
Reviewed-by: Daniel Erez
Tested-by: Daniel Erez
Reviewed-by: Dan Kenigsberg
(cherry picked from commit 5073708e0e0e2b4fd41625a41ea8bdd0d5e8bb5e)
---
M vdsm/rpc/Bridge.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/33678/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index f7788b8..34d347f 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -408,6 +408,7 @@
'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
'Host_getAllVmStats': {'ret': 'statsList'},
'Host_setupNetworks': {'ret': 'status'},
+'Image_cloneStructure': {'ret': 'uuid'},
'Image_delete': {'ret': 'uuid'},
'Image_deleteVolumes': {'ret': 'uuid'},
'Image_getVolumes': {'ret': 'uuidlist'},
@@ -415,6 +416,7 @@
'Image_mergeSnapshots': {'ret': 'uuid'},
'Image_move': {'ret': 'uuid'},
'Image_reconcileVolumeChain': {'ret': 'volumes'},
+'Image_syncData': {'ret': 'uuid'},
'ISCSIConnection_discoverSendTargets': {'ret': 'fullTargets'},
'LVMVolumeGroup_create': {'ret': 'uuid'},
'LVMVolumeGroup_getInfo': {'ret': 'info'},
--
To view, visit http://gerrit.ovirt.org/33678
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing verbs in command info
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: mssing verbs in command info .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/251/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5884/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4044/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/54/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/50/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/56/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/30/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ravi Nori Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: sslutils: Document M2Crypto threading initialization
Dan Kenigsberg has submitted this change and it was merged. Change subject: sslutils: Document M2Crypto threading initialization .. sslutils: Document M2Crypto threading initialization As documented and painfully recognized long ago in, using M2Crypto in a multi-threaded server such as Vdsm requires explicit initialization. M2Crypto was initialized but the code was not docuemnted properly. This lead to the initialization being removed in this patch: http://gerrit.ovirt.org/#/c/28858/4/lib/vdsm/verifyingtransport.py Hopefully, improved documentation and moving it to the sslutils module will prevent such attempts in the future. Change-Id: I8e5f8dc4662e16ba7e39f60336819750e1366124 Relates-to: http://www.heikkitoivonen.net/m2crypto/api/M2Crypto.threading-module.html Relates-to: https://bugzilla.redhat.com/482420 Signed-off-by: Nir Soffer Signed-off-by: pkliczewski Bug-Url: https://bugzilla.redhat.com/1147487 Reviewed-on: http://gerrit.ovirt.org/33671 Reviewed-by: Dan Kenigsberg --- M lib/vdsm/SecureXMLRPCServer.py M lib/vdsm/sslutils.py 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e5f8dc4662e16ba7e39f60336819750e1366124 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: sslutils: Document M2Crypto threading initialization
Dan Kenigsberg has posted comments on this change. Change subject: sslutils: Document M2Crypto threading initialization .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e5f8dc4662e16ba7e39f60336819750e1366124 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert "ssl: adding ssl threading initialization"
Dan Kenigsberg has submitted this change and it was merged. Change subject: Revert "ssl: adding ssl threading initialization" .. Revert "ssl: adding ssl threading initialization" This reverts commit 2889e233dbe9b2cf8b37dfdef9133130e9e43132. Change-Id: Iddc883dc7ad18eeaecd02f864b8d788c07f7e776 Signed-off-by: pkliczewski Bug-Url: https://bugzilla.redhat.com/1147487 Reviewed-on: http://gerrit.ovirt.org/33675 Reviewed-by: Dan Kenigsberg --- M lib/vdsm/sslutils.py 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddc883dc7ad18eeaecd02f864b8d788c07f7e776 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert "ssl: adding ssl threading initialization"
Dan Kenigsberg has posted comments on this change. Change subject: Revert "ssl: adding ssl threading initialization" .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33675 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddc883dc7ad18eeaecd02f864b8d788c07f7e776 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing verbs in command info
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: mssing verbs in command info .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ravi Nori Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing verbs in command info
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: mssing verbs in command info .. jsonrpc: mssing verbs in command info Missing clone image structure and image sync data in command info. Bug-url: https://bugzilla.redhat.com/1148498 Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Signed-off-by: pkliczewski Reviewed-on: http://gerrit.ovirt.org/33669 Reviewed-by: Daniel Erez Tested-by: Daniel Erez Reviewed-by: Dan Kenigsberg --- M vdsm/rpc/Bridge.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ravi Nori Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/31/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/27/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/26/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/31/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing verbs in command info
Daniel Erez has posted comments on this change. Change subject: jsonrpc: mssing verbs in command info .. Patch Set 3: Verified+1 Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ravi Nori Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing verbs in command info
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: mssing verbs in command info .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12716/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12561/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ravi Nori Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing verbs in command info
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: mssing verbs in command info .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12715/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12560/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ravi Nori Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make domain_descriptor.py API pep8-friendly .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11770/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12714/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1711/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12559/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6aadabb0152966dae7da885b6933c440d6496f6d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly
Francesco Romani has uploaded a new change for review.
Change subject: virt: make domain_descriptor.py API pep8-friendly
..
virt: make domain_descriptor.py API pep8-friendly
Only changes in naming.
Change-Id: I6aadabb0152966dae7da885b6933c440d6496f6d
Signed-off-by: Francesco Romani
---
M vdsm/virt/domain_descriptor.py
M vdsm/virt/vm.py
M vdsm/virt/vmxml.py
3 files changed, 20 insertions(+), 20 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/33672/1
diff --git a/vdsm/virt/domain_descriptor.py b/vdsm/virt/domain_descriptor.py
index b1d6cb7..ef9c373 100644
--- a/vdsm/virt/domain_descriptor.py
+++ b/vdsm/virt/domain_descriptor.py
@@ -25,12 +25,12 @@
def __init__(self, xmlStr):
self._xml = xmlStr
self._dom = xml.dom.minidom.parseString(xmlStr)
-self._devices = self.firstElementByTagName('devices')
+self._devices = self.first_element_by_tag_name('devices')
# VDSM by default reports '0' as hash when it has no device list yet
-self._devicesHash = hash(self._devices) if self._devices else 0
+self._devices_hash = hash(self._devices) if self._devices else 0
@classmethod
-def fromId(cls, uuid):
+def from_id(cls, uuid):
return cls('%s' % uuid)
@property
@@ -41,7 +41,7 @@
def dom(self):
return self._dom
-def firstElementByTagName(self, tagName):
+def first_element_by_tag_name(self, tagName):
elements = self._dom.childNodes[0].getElementsByTagName(tagName)
return elements[0] if elements else None
@@ -49,9 +49,9 @@
def devices(self):
return self._devices
-def getDeviceElements(self, tagName):
+def get_device_elements(self, tagName):
return self._devices.getElementsByTagName(tagName)
@property
-def devicesHash(self):
-return self._devicesHash
+def devices_hash(self):
+return self._devices_hash
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ccbb740..6479cdc 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1500,7 +1500,7 @@
self._qemuguestSocketFile = self._makeChannelPath(_QEMU_GA_DEVICE_NAME)
self.guestAgent = guestagent.GuestAgent(
self._guestSocketFile, self.cif.channelListener, self.log)
-self._lastXMLDesc = DomainDescriptor.fromId(self.id)
+self._lastXMLDesc = DomainDescriptor.from_id(self.id)
self._released = False
self._releaseLock = threading.Lock()
self.saveState()
@@ -2516,7 +2516,7 @@
exc_info=True)
stats.update(self._getGraphicsStats())
-stats['hash'] = str(hash((self._lastXMLDesc.devicesHash,
+stats['hash'] = str(hash((self._lastXMLDesc.devices_hash,
self.guestAgent.diskMappingHash)))
if self._watchdogEvent:
stats['watchdogEvent'] = self._watchdogEvent
@@ -4728,7 +4728,7 @@
"""
Obtain controller devices info from libvirt.
"""
-for x in self._lastXMLDesc.getDeviceElements('controller'):
+for x in self._lastXMLDesc.get_device_elements('controller'):
# Ignore controller devices without address
if not x.getElementsByTagName('address'):
continue
@@ -4772,7 +4772,7 @@
"""
Obtain balloon device info from libvirt.
"""
-for x in self._lastXMLDesc.getDeviceElements('memballoon'):
+for x in self._lastXMLDesc.get_device_elements('memballoon'):
# Ignore balloon devices without address.
if not x.getElementsByTagName('address'):
address = None
@@ -4797,7 +4797,7 @@
"""
Obtain the alias for the console device from libvirt
"""
-for x in self._lastXMLDesc.getDeviceElements('console'):
+for x in self._lastXMLDesc.get_device_elements('console'):
# All we care about is the alias
alias = x.getElementsByTagName('alias')[0].getAttribute('name')
for dev in self._devices[CONSOLE_DEVICES]:
@@ -4813,7 +4813,7 @@
"""
Obtain smartcard device info from libvirt.
"""
-for x in self._lastXMLDesc.getDeviceElements('smartcard'):
+for x in self._lastXMLDesc.get_device_elements('smartcard'):
if not x.getElementsByTagName('address'):
continue
@@ -4835,7 +4835,7 @@
"""
Obtain watchdog device info from libvirt.
"""
-for x in self._lastXMLDesc.getDeviceElements('watchdog'):
+for x in self._lastXMLDesc.get_device_elements('watchdog'):
# PCI watchdog has "address" different from ISA watchdog
if x.getElementsByTagName('address'):
@@ -4857,7 +4857,7 @@
"""
Obtain video devices info from libvirt.
"""
-for x in self._lastXMLDesc.g
Change in vdsm[ovirt-3.5]: sslutils: Document M2Crypto threading initialization
Nir Soffer has posted comments on this change. Change subject: sslutils: Document M2Crypto threading initialization .. Patch Set 2: Code-Review-1 You are creating a mess again. Please: 1. Revet the patch that added double init 2. Backport this patch without any semnatic change 3. Post your patch again without this change -- To view, visit http://gerrit.ovirt.org/33671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e5f8dc4662e16ba7e39f60336819750e1366124 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing clone image structure in command info
Daniel Erez has posted comments on this change.
Change subject: jsonrpc: mssing clone image structure in command info
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33669/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 408: 'Host_getVMList': {'call': Host_getVMList_Call, 'ret':
Host_getVMList_Ret},
Line 409: 'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret':
'vmList'},
Line 410: 'Host_getAllVmStats': {'ret': 'statsList'},
Line 411: 'Host_setupNetworks': {'ret': 'status'},
Line 412: 'Image_cloneStructure': {'ret': 'uuid'},
same should be done for 'syncImageData'
Line 413: 'Image_delete': {'ret': 'uuid'},
Line 414: 'Image_deleteVolumes': {'ret': 'uuid'},
Line 415: 'Image_getVolumes': {'ret': 'uuidlist'},
Line 416: 'Image_download': {'ret': 'uuid'},
--
To view, visit http://gerrit.ovirt.org/33669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Ravi Nori
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Francesco Romani has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 25: fixes tests broken by rebase. Will do any other change but rebase fixes/address reviewer's comments in followup patches. let's unfreeze this change and have it in! -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ewoud Kohl van Wijngaarden Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gitignore: Ingore vdsm-lvm.rule.tpl
oVirt Jenkins CI Server has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/30/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/26/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/25/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/30/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: adding ssl threading initialization
Yaniv Bronhaim has submitted this change and it was merged. Change subject: ssl: adding ssl threading initialization .. ssl: adding ssl threading initialization Bug-Url: https://bugzilla.redhat.com/1147487 Change-Id: Ibcf8d9dc26d3a040a5519629d42aa5860fa73f52 Signed-off-by: pkliczewski Reviewed-on: http://gerrit.ovirt.org/33670 Reviewed-by: Yaniv Bronhaim --- M lib/vdsm/sslutils.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcf8d9dc26d3a040a5519629d42aa5860fa73f52 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Yaniv Bronhaim has submitted this change and it was merged. Change subject: ssl: ssl_accept blocks after reboot .. ssl: ssl_accept blocks after reboot When rebooting host most of the times ssl_accept blocks when there is new connection established just after socket is opened. Setting timeout on socket seems to help but when testing I noticed sometimes there is still connection blocked on ssl_accept. Bug-Url: https://bugzilla.redhat.com/1147487 Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Signed-off-by: pkliczewski Signed-off-by: Saggi Mizrahi Reviewed-on: http://gerrit.ovirt.org/33643 Reviewed-by: Yaniv Bronhaim --- M lib/vdsm/sslutils.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Yaniv Bronhaim has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: adding ssl threading initialization
Yaniv Bronhaim has posted comments on this change. Change subject: ssl: adding ssl threading initialization .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcf8d9dc26d3a040a5519629d42aa5860fa73f52 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing clone image structure in command info
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: mssing clone image structure in command info .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: mssing clone image structure in command info
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: mssing clone image structure in command info .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12712/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12557/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Modify lv selinux label only if not labablled as libvir...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/29/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/25/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/24/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/29/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gitignore: Ingore vdsm-lvm.rule.tpl
Dan Kenigsberg has submitted this change and it was merged. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. gitignore: Ingore vdsm-lvm.rule.tpl In a previous commit I forgot to add this new template to the ignore list, which breaks the build. I will be punished for this. Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/33630 Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/33634 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require newer version of selinux-policy
Yeela Kaplan has uploaded a new change for review. Change subject: spec: Require newer version of selinux-policy .. spec: Require newer version of selinux-policy The newer version of selinux-policy allows logrotate to read /var/log/core which is tagged as a file of type virt_cache_t Change-Id: Ie783bcccb1ab39397714fc728336fd65ee4b95a9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131460 Signed-off-by: Yeela Kaplan --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/33667/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 58ed07c..d35f396 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -204,7 +204,7 @@ Requires: initscripts >= 9.03.31-2.el6_3.1 Requires: policycoreutils >= 2.0.83-19.30 Requires: policycoreutils-python >= 2.0.83-19.30 -Requires: selinux-policy-targeted >= 3.7.19-195.el6_4.13 +Requires: selinux-policy-targeted >= 3.7.19-249.el6 Requires: lvm2 >= 2.02.100-5 Requires: logrotate < 3.8.0 %endif -- To view, visit http://gerrit.ovirt.org/33667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie783bcccb1ab39397714fc728336fd65ee4b95a9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Functional test for Multiple Gateways source routing
Dan Kenigsberg has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing .. Patch Set 2: Code-Review-1 (1 comment) Partial review. http://gerrit.ovirt.org/#/c/33612/2/tests/functional/utils.py File tests/functional/utils.py: Line 228: result = self.vdscli.updateVmPolicy([vmId, vcpuLimit]) Line 229: return result['status']['code'], result['status']['message'] Line 230: Line 231: Line 232: def wait_for_predicate(predicate, timeout, poll_period=1): Use vdsm.until.retry instead of this nicely-named function. Line 233: absolute_timeout = time.time() + timeout Line 234: while time.time() <= absolute_timeout: Line 235: res = predicate() Line 236: if res: -- To view, visit http://gerrit.ovirt.org/33612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib510bb56c205dffc98aa2bae3f55c1b4c7f6f56f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/250/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5883/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4043/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/53/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/49/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/55/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/29/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Francesco Romani has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 24: (2 comments) some possible improvements I'd like to implement, probably better in follow up patches once this is in. http://gerrit.ovirt.org/#/c/17694/24/vdsm/virt/domain_descriptor.py File vdsm/virt/domain_descriptor.py: Line 40: @property Line 41: def dom(self): Line 42: return self._dom Line 43: Line 44: def firstElementByTagName(self, tagName): according to git grep, this can be made private Line 45: elements = self._dom.childNodes[0].getElementsByTagName(tagName) Line 46: return elements[0] if elements else None Line 47: Line 48: @property Line 49: def devices(self): Line 50: return self._devices Line 51: Line 52: def getDeviceElements(self, tagName): Line 53: return self._devices.getElementsByTagName(tagName) Since we need another round of review due to the big rebase being made, I'd like to propose a new API here. My rationale is 1 since this is new module, have an API more_pep8_friendly and goAwayFromCamelCase 2 add more convenience methods, possibly merging helpers currently in vmxml.py 3 abstract from the minidom API, in not-so-distant future we want to move to cElementTree for performance and nicer API. What about replacing the two above with @property def all_devices(self): return self._devices def devices(self, type): # klass? dev_type? kind? return self._devices.getElementsByTagName(type) - of course this will not address #3 above Line 54: Line 55: @property Line 56: def devicesHash(self): -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ewoud Kohl van Wijngaarden Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduction for caching the parsed domain XML
Francesco Romani has posted comments on this change. Change subject: Introduction for caching the parsed domain XML .. Patch Set 24: rebased, due to vmxml.py changes introduced since the revision before. -- To view, visit http://gerrit.ovirt.org/17694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ewoud Kohl van Wijngaarden Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Nir Soffer has posted comments on this change.
Change subject: ssl: ssl_accept blocks after reboot
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/33643/2/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 25: DEFAULT_ACCEPT_TIMEOUT = 5
Line 26:
Line 27: # M2Crypto.threading needs initialization.
Line 28: # See https://bugzilla.redhat.com/482420
Line 29: threading.init()
Why this is new code? I move this code here few moth ago, after you deleted in
one of your patches.
Please separate this to a new patch and explain this change.
Line 30:
Line 31:
Line 32: class SSLSocket(object):
Line 33: def __init__(self, connection):
Line 117:
Line 118: try:
Line 119: client.setup_ssl()
Line 120: client.set_accept_state()
Line 121: client.settimeout(self.accept_timeout)
accept does not work in non-blocking mode?
This is really bad for a non blocking server.
Line 122: client.accept_ssl()
Line 123: client.settimeout(None)
Line 124: except SSL.SSLError as e:
Line 125: raise SSL.SSLError("%s, client %s" % (e, address[0]))
--
To view, visit http://gerrit.ovirt.org/33643
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_acceptor: Make SSL handshake asynchronous
oVirt Jenkins CI Server has posted comments on this change. Change subject: protocol_acceptor: Make SSL handshake asynchronous .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12709/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12554/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable lvm selinux fix for Fedora
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/28/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/24/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/23/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/28/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: protocol_acceptor: Make SSL handshake asynchronous
Saggi Mizrahi has uploaded a new change for review.
Change subject: protocol_acceptor: Make SSL handshake asynchronous
..
protocol_acceptor: Make SSL handshake asynchronous
Change-Id: Ia8808633344389297fe026cd2219aa513f6f1dff
Signed-off-by: Saggi Mizrahi
---
M lib/vdsm/sslutils.py
M vdsm/protocoldetector.py
2 files changed, 53 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/33657/1
diff --git a/lib/vdsm/sslutils.py b/lib/vdsm/sslutils.py
index 74d2bdf..505db0e 100644
--- a/lib/vdsm/sslutils.py
+++ b/lib/vdsm/sslutils.py
@@ -169,7 +169,7 @@
def wrapSocket(self, sock):
context = self.context
-return SSLSocket(SSL.Connection(context, sock=sock), self)
+return SSLSocket(SSL.Connection(context, sock=sock))
class VerifyingHTTPSConnection(httplib.HTTPSConnection):
diff --git a/vdsm/protocoldetector.py b/vdsm/protocoldetector.py
index 7e15f9c..7d428bf 100644
--- a/vdsm/protocoldetector.py
+++ b/vdsm/protocoldetector.py
@@ -27,9 +27,15 @@
from M2Crypto import SSL
-from vdsm.sslutils import SSLServerSocket
from vdsm.utils import traceback
from vdsm import utils
+
+
+def _is_handshaking(sock):
+if not hasattr(sock, "is_handshaking"):
+return False
+
+return sock.is_handshaking
class MultiProtocolAcceptor:
@@ -60,8 +66,11 @@
"""
log = logging.getLogger("vds.MultiProtocolAcceptor")
-READ_ONLY_MASK = (select.POLLIN | select.POLLPRI | select.POLLHUP
- | select.POLLERR)
+READ_ONLY_MASK = (select.POLLIN | select.POLLPRI | select.POLLHUP |
+ select.POLLERR)
+
+READ_WRITE_MASK = (select.POLLIN | select.POLLPRI |
+ select.POLLOUT | select.POLLHUP | select.POLLERR)
CLEANUP_INTERVAL = 30.0
def __init__(self, host, port, sslctx=None):
@@ -113,8 +122,8 @@
self._accept_connection()
else:
self._handle_connection_read(fd)
-else:
-pass
+if event & (select.POLLOUT):
+self._handle_connection_write(fd)
now = time.time()
if now > self._next_cleanup:
@@ -173,12 +182,21 @@
raise
def _accept_connection(self):
-try:
-client_socket, _ = self._socket.accept()
-except SSL.SSLError as e:
-self.log.warning("Unable to accept connection due to %s", e)
-else:
-self._add_connection(client_socket)
+client_socket, address = self._socket.accept()
+if self._sslctx:
+client_socket = self._sslctx.wrapSocket(client_socket)
+client_socket.address = address
+try:
+client_socket.setup_ssl()
+client_socket.set_accept_state()
+except SSL.SSLError as e:
+self.log.warning("Error setting up ssl: %s", e)
+client_socket.close()
+return
+
+client_socket.is_handshaking = True
+
+self._add_connection(client_socket)
def _add_connection(self, socket):
host, port = socket.getpeername()
@@ -186,7 +204,10 @@
socket.setblocking(0)
self._pending_connections[socket.fileno()] = (time.time(),
socket)
-self._poller.register(socket, self.READ_ONLY_MASK)
+if _is_handshaking(socket):
+self._poller.register(socket, self.READ_WRITE_MASK)
+else:
+self._poller.register(socket, self.READ_ONLY_MASK)
def _remove_connection(self, socket):
self._poller.unregister(socket)
@@ -195,8 +216,27 @@
host, port = socket.getpeername()
self.log.debug("Connection removed from %s:%d", host, port)
+def _process_handshake(self, socket):
+try:
+socket.is_handshaking = (socket.accept_ssl() == 0)
+except Exception as e:
+self.log.debug("Error during handshake: %s", e)
+socket.close()
+else:
+if not socket.is_hanshaking:
+self._poller.modify(socket, self.READ_ONLY_MASK)
+
+def _handle_connection_write(self, fd):
+_, client_socket = self._pending_connections[fd]
+if _is_handshaking(client_socket):
+self._process_handshake(client_socket)
+
def _handle_connection_read(self, fd):
_, client_socket = self._pending_connections[fd]
+if _is_handshaking(client_socket):
+self._process_handshake(client_socket)
+return
+
try:
data = client_socket.recv(self._required_size, socket.MSG_PEEK)
except socket.error as e:
@@ -233,12 +273,6 @@
server_socket.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
server_socket.bind(addr[0][4])
server_socket.listen(5)
-
-if sel
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Saggi Mizrahi has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Set libvirt image selinux label on block devices backin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/27/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/23/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/22/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/27/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has posted comments on this change. Change subject: DONTMERGE: virt: log device changes .. Patch Set 2: Code-Review-1 Verified-1 debug only -- To view, visit http://gerrit.ovirt.org/33641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Dan Kenigsberg has submitted this change and it was merged. Change subject: ssl: ssl_accept blocks after reboot .. ssl: ssl_accept blocks after reboot When rebooting host most of the times ssl_accept blocks when there is new connection established just after socket is opened. Setting timeout on socket seems to help but when testing I noticed sometimes there is still connection blocked on ssl_accept. Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Signed-off-by: pkliczewski Signed-off-by: Saggi Mizrahi Reviewed-on: http://gerrit.ovirt.org/33611 Reviewed-by: Dan Kenigsberg --- M lib/vdsm/sslutils.py M tests/sslTests.py 2 files changed, 29 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Dan Kenigsberg has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11764/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12708/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12553/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has uploaded a new change for review.
Change subject: DONTMERGE: virt: log device changes
..
DONTMERGE: virt: log device changes
DO NOT MERGE - DEBUG ONLY
log device changes to improve debuggability of VDSM.
This is an hack which adds unnecessary traffic in the logs!
Proper, streamlined change will be prepared in parallel.
Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14
Signed-off-by: Francesco Romani
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/33641/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 0f9e4ce..e845a50 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4810,9 +4810,13 @@
def _getUnderlyingVmInfo(self):
self._lastXMLDesc = self._dom.XMLDesc(0)
devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
-getElementsByTagName('devices')[0]
-self._devXmlHash = str(hash(devxml.toxml()))
+getElementsByTagName('devices')[0].toxml()
+xmlHash = hash(devxml)
+if xmlHash != self._devXmlHash:
+self.log.debug('VM device changed:\n%s', devxml)
+
+self._devXmlHash = xmlHash
return self._lastXMLDesc
def _ejectFloppy(self):
--
To view, visit http://gerrit.ovirt.org/33641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: DONTMERGE: virt: log device changes
Francesco Romani has posted comments on this change. Change subject: DONTMERGE: virt: log device changes .. Patch Set 1: Code-Review-1 Verified-1 debug only -- To view, visit http://gerrit.ovirt.org/33641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17bf634bf949473081c828c3aaae98a4e040d14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Dan Kenigsberg has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33611/4/tests/sslTests.py File tests/sslTests.py: Line 114: server.server.socket.accept_timeout = 1 Line 115: timeout = server.server.socket.accept_timeout + 1 Line 116: server.start() Line 117: try: Line 118: client_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM) nit picking again: please use with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as client_socket and drop the close() on finally. client_socket may not be defined there. Line 119: client_socket.settimeout(timeout) Line 120: client_socket.connect((HOST, server.port)) Line 121: # Wait for data that will never arrive. Line 122: # This will return successfuly if the other side closes the -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11763/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12707/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12552/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Code-Review+1 First start might fail[1]. since this is simple and on specific upgrade scenario, consider declaring this a known issue? [1] (since ultimately systemd starts libvirt vdsm and long libvirt restart, done by tool, might cause systemd to timeout on starting vdsm) -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Modify lv selinux label only if not labablled as libvir...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. lvm: Modify lv selinux label only if not labablled as libvirt image When using the faulty version of systemd that removes libvirt image labels from block devices, this patch has no effect. However when a fix is available and libvirt image label exists, vdsm will not change the original libvirt label. This allows the increase protection for virtual machines. Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Bug-Url: https://bugzilla.redhat.com/1127460 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/33620 Reviewed-by: Federico Simoncelli Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/33632 --- M .gitignore M configure.ac M vdsm.spec.in A vdsm/storage/vdsm-chcon.in M vdsm/storage/vdsm-lvm.rules.tpl.in 5 files changed, 32 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable lvm selinux fix for Fedora
Yaniv Bronhaim has submitted this change and it was merged. Change subject: spec: Enable lvm selinux fix for Fedora .. spec: Enable lvm selinux fix for Fedora In case we cannot get the real fix in systemd quickly, this patch enables the temporary hack on Fedora. Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Bug-Url: https://bugzilla.redhat.com/1127460 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/33555 Reviewed-by: Federico Simoncelli Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/33628 --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Set libvirt image selinux label on block devices backin...
Yaniv Bronhaim has submitted this change and it was merged. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. lvm: Set libvirt image selinux label on block devices backing vdsm images The SELinux sVirt protection for QEMU virtual machines is setup in such a way that a domain can only access files or devices which are labelled svirt_image_t label. Libvirt sets this label on block devices backing images when it starts a vm. On Fedora 19, 20 and EL 7, the selinux label on the block device is lost after refreshing a logical volume. The root cause of this issue is systemd-udevd, trying to "preserve" the selinux label upon device change event. Loosing the selinux label causes the vm to pause. The only way to use the vm is to restart the vm. Practically, this breaks thin provisioning on block storage, since after each automatic extend, a logical volume must be refreshed. This patch adds a temporary hack, by updating vdsm lvm rules to set the libvirt image selinux label on vdsm images. This change should be reverted when a fix is available in systemd-udevd. This hack is enabled by default only for EL7, since we hope to get a fix for systemd-udevd soon for Fedora. To enable this hack on other platforms: ./configure --enable-chcon-hack Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Bug-Url: https://bugzilla.redhat.com/1127460 Releates-To: https://bugzilla.redhat.com/1147910 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/33492 Reviewed-by: Dan Kenigsberg Reviewed-by: Federico Simoncelli Reviewed-on: http://gerrit.ovirt.org/33627 --- M configure.ac M vdsm.spec.in M vdsm/storage/Makefile.am R vdsm/storage/vdsm-lvm.rules.tpl.in 4 files changed, 52 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11762/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12706/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12551/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
oVirt Jenkins CI Server has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/249/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5882/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4042/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/52/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/48/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/54/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/28/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: sanitize earlier the 'smp' parameter
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: vm: sanitize earlier the 'smp' parameter .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11761/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12705/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1708/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12550/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b90a26ff6af560359f3d60a73afc56fb25dc15c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Functional test for Multiple Gateways source routing
Antoni Segura Puimedon has posted comments on this change.
Change subject: Functional test for Multiple Gateways source routing
..
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/33612/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 1950:
Line 1951: # DHCP source routing configuration is async hence
we wait
Line 1952: # patiently
Line 1953: rules_exist = lambda: (ruleExists(rule1) and
ruleExists(rule2))
Line 1954: wait_for_predicate(rules_exist, 10)
Good for now. We should eventually replace this with the netlink monitor.
Line 1955: routes = [Route.fromText(r)
Line 1956: for r in routeShowTable(routing_table)]
Line 1957: default_route = Route('0.0.0.0/0', via=IP_GATEWAY,
Line 1958: device=str(route_rule_dev))
Line 1955: routes = [Route.fromText(r)
Line 1956: for r in routeShowTable(routing_table)]
Line 1957: default_route = Route('0.0.0.0/0', via=IP_GATEWAY,
Line 1958: device=str(route_rule_dev))
Line 1959: specific_route = Route(IP_NETWORK_AND_CIDR,
If I'm not mistaken the proper name for such route would be "link scope route".
However, unfortunately, the configuring code does not currently set it with the
correct scope (link instead of local).
Line 1960:via=str(device_ip_addr),
Line 1961:device=str(route_rule_dev))
Line 1962: self.assertIn(default_route, routes)
Line 1963: self.assertIn(specific_route, routes)
--
To view, visit http://gerrit.ovirt.org/33612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib510bb56c205dffc98aa2bae3f55c1b4c7f6f56f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gitignore: Ingore vdsm-lvm.rule.tpl
Dan Kenigsberg has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: spec: Enable lvm selinux fix for Fedora
Dan Kenigsberg has posted comments on this change. Change subject: spec: Enable lvm selinux fix for Fedora .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29e54ee1e52d323d15452c2c1975b63d6c9fa7e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Modify lv selinux label only if not labablled as libvir...
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Set libvirt image selinux label on block devices backin...
Dan Kenigsberg has posted comments on this change. Change subject: lvm: Set libvirt image selinux label on block devices backing vdsm images .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f85c7b548b2c058693b20b1fa177714a6e1a10 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Dan Kenigsberg has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/33611/2/tests/sslTests.py File tests/sslTests.py: Line 109: Line 110: class SocketTests(TestCaseBase): Line 111: Line 112: def test_block_socket(self): Line 113: # this test make sure that we won't block during I don't understand how this test works :-( You start a server, open a TCP connection to it, but you don't check that the server is still responsive. Would this test really fail on master branch (before your fix)? I think that you should: * start a server * open a DoS connection to it * open a legitimate client to the server * if the client is not served within 10 seconds, fail the test. Line 114: # accept. It will hang the build if accept blocks Line 115: server = TestServer() Line 116: server.start() Line 117: try: Line 119: sock.settimeout(1) Line 120: sock.connect((HOST, server.port)) Line 121: finally: Line 122: server.stop() Line 123: sock.close() puritan: at this point, "sock" may have not been defined. better use with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as sock: Line 124: Line 125: Line 126: class VerifyingTransportTests(TestCaseBase): Line 127: -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gitignore: Ingore vdsm-lvm.rule.tpl
Nir Soffer has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 1: Verified+1 Yea, there is no bug url, but it fixes the build (first check in make check fails without it). -- To view, visit http://gerrit.ovirt.org/33634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11760/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12704/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12549/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: gitignore: Ingore vdsm-lvm.rule.tpl
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/33634 to review the following change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. gitignore: Ingore vdsm-lvm.rule.tpl In a previous commit I forgot to add this new template to the ignore list, which breaks the build. I will be punished for this. Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/33630 Reviewed-by: Dan Kenigsberg --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/33634/1 diff --git a/.gitignore b/.gitignore index efb99aa..d1e919b 100644 --- a/.gitignore +++ b/.gitignore @@ -58,6 +58,7 @@ vdsm/storage/protect/safelease vdsm/storage/lvm.env vdsm/storage/vdsm-lvm.rules +vdsm/storage/vdsm-lvm.rules.tpl vdsm/sudoers.vdsm vdsm/svdsm.logger.conf vdsm/vdscli.py -- To view, visit http://gerrit.ovirt.org/33634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
Dan Kenigsberg has submitted this change and it was merged. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. gitignore: Ingore vdsm-lvm.rule.tpl In a previous commit I forgot to add this new template to the ignore list, which breaks the build. I will be punished for this. Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/33630 Reviewed-by: Dan Kenigsberg --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
Dan Kenigsberg has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Modify lv selinux label only if not labablled as libvir...
Nir Soffer has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 1: Verified+1 Verified the extend flow on el6 and el7, other flows. -- To view, visit http://gerrit.ovirt.org/33632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: lvm: Modify lv selinux label only if not labablled as libvir...
Hello Federico Simoncelli, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33632
to review the following change.
Change subject: lvm: Modify lv selinux label only if not labablled as libvirt
image
..
lvm: Modify lv selinux label only if not labablled as libvirt image
When using the faulty version of systemd that removes libvirt image
labels from block devices, this patch has no effect. However when a fix
is available and libvirt image label exists, vdsm will not change the
original libvirt label. This allows the increase protection for virtual
machines.
Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb
Bug-Url: https://bugzilla.redhat.com/1127460
Signed-off-by: Nir Soffer
Reviewed-on: http://gerrit.ovirt.org/33620
Reviewed-by: Federico Simoncelli
Reviewed-by: Dan Kenigsberg
---
M .gitignore
M configure.ac
M vdsm.spec.in
A vdsm/storage/vdsm-chcon.in
M vdsm/storage/vdsm-lvm.rules.tpl.in
5 files changed, 32 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/33632/1
diff --git a/.gitignore b/.gitignore
index efb99aa..cafa8d8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -57,6 +57,7 @@
vdsm/sos/vdsm.py
vdsm/storage/protect/safelease
vdsm/storage/lvm.env
+vdsm/storage/vdsm-chcon
vdsm/storage/vdsm-lvm.rules
vdsm/sudoers.vdsm
vdsm/svdsm.logger.conf
diff --git a/configure.ac b/configure.ac
index 4261216..3aae03e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -122,7 +122,10 @@
)
AC_SUBST([LIBVIRT_SERVICE_DEFAULT], ["${with_libvirt_service_default}"])
-AC_SUBST([LIBVIRT_IMAGE_LABEL], ['svirt_image_t'])
+
+# Selinux image label
+AC_SUBST([SVIRT_IMAGE_LABEL], ['svirt_image_t'])
+AC_SUBST([SVIRT_CONTENT_LABEL], ['svirt_content_t'])
# Users and groups
@@ -228,6 +231,7 @@
AC_PATH_PROG([ISCSIADM_PATH], [iscsiadm], [/sbin/iscsiadm])
AC_PATH_PROG([KILL_PATH], [kill], [/bin/kill])
AC_PATH_PROG([LSBLK_PATH], [lsblk], [/bin/lsblk])
+AC_PATH_PROG([LS_PATH], [ls], [/bin/ls])
AC_PATH_PROG([LVM_PATH], [lvm], [/sbin/lvm])
AC_PATH_PROG([MKFS_MSDOS_PATH], [mkfs.msdos], [/sbin/mkfs.msdos])
AC_PATH_PROG([MKFS_PATH], [mkfs], [/sbin/mkfs])
@@ -296,6 +300,7 @@
vdsm/storage/Makefile
vdsm/storage/imageRepository/Makefile
vdsm/storage/protect/Makefile
+ vdsm/storage/vdsm-chcon
vdsm/storage/vdsm-lvm.rules.tpl
vdsm/virt/Makefile
vdsm_hooks/Makefile
diff --git a/vdsm.spec.in b/vdsm.spec.in
index f867105..4f822e4 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -50,8 +50,10 @@
%if 0%{?rhel} == 6
%global _udevrulesdir /lib/udev/rules.d/
+%global _udevexecdir /lib/udev/
%else
%global _udevrulesdir /usr/lib/udev/rules.d/
+%global _udevexecdir /usr/lib/udev/
%endif
Name: %{vdsm_name}
@@ -668,6 +670,11 @@
install -Dm 0644 vdsm/storage/vdsm-lvm.rules \
%{buildroot}%{_udevrulesdir}/12-vdsm-lvm.rules
+%if 0%{?with_chcon_hack}
+install -Dm 0755 vdsm/storage/vdsm-chcon \
+ %{buildroot}%{_udevexecdir}/vdsm-chcon
+%endif
+
install -Dm 0644 vdsm/limits.conf \
%{buildroot}/etc/security/limits.d/99-vdsm.conf
@@ -1143,6 +1150,9 @@
%endif
%{python_sitelib}/sos/plugins/vdsm.py*
%{_udevrulesdir}/12-vdsm-lvm.rules
+%if 0%{?with_chcon_hack}
+%{_udevexecdir}/vdsm-chcon
+%endif
/etc/security/limits.d/99-vdsm.conf
%{_mandir}/man8/vdsmd.8*
%if 0%{?rhel}
diff --git a/vdsm/storage/vdsm-chcon.in b/vdsm/storage/vdsm-chcon.in
new file mode 100644
index 000..6f1eb6e
--- /dev/null
+++ b/vdsm/storage/vdsm-chcon.in
@@ -0,0 +1,14 @@
+#!/bin/sh
+
+# This script must be called from a udev rule and assumes the udev environment
+# variables.
+
+# Do not touch the device if it is already labelled is libvirt image. It will
+# probably be a fixed_disk_t or it may have no selinux label.
+if @LS_PATH@ -Z "$DEVNAME" | \
+@GREP_PATH@ -q -E ":@SVIRT_CONTENT_LABEL@:|:@SVIRT_IMAGE_LABEL@:"; then
+exit 0
+fi
+
+echo "Changing selinux type to @SVIRT_IMAGE_LABEL@ on $DEVNAME" >&2
+@CHCON_PATH@ -t @SVIRT_IMAGE_LABEL@ "$DEVNAME"
diff --git a/vdsm/storage/vdsm-lvm.rules.tpl.in
b/vdsm/storage/vdsm-lvm.rules.tpl.in
index 0869cdf..fb6c87a 100644
--- a/vdsm/storage/vdsm-lvm.rules.tpl.in
+++ b/vdsm/storage/vdsm-lvm.rules.tpl.in
@@ -23,16 +23,13 @@
# label is lost after refreshing a logical volume, and vm get paused. This rule
# ensures that the label exist after device changes. See
# https://bugzilla.redhat.com/1147910
-#
-# TODO: use SECLABEL{selinux}="@LIBVIRT_IMAGE_LABEL@" when this syntax is
-# supported. See https://bugzilla.redhat.com/1015300
{{endif}}
# "add" event is processed on coldplug only, so we need "change", too.
ACTION!="add|change", GOTO="lvm_end"
# Fix ownership for RHEV volumes
-ENV{DM_VG_NAME}=="[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a-f0-9][a-f0-9]-[a-f0-9][a-f0-9][a
Change in vdsm[master]: lvm: Modify lv selinux label only if not labablled as libvir...
oVirt Jenkins CI Server has posted comments on this change. Change subject: lvm: Modify lv selinux label only if not labablled as libvirt image .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/248/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5881/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4041/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/51/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/47/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/53/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/27/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide7560564e4c83c84dd288b5a8305ad1ddb4cfcb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: exponential downtime increment
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: migration: exponential downtime increment .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11759/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12703/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1707/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12548/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/25820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6401772f52ea28144452e67198bddff18f6703eb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: migration: move wait countdown in a function
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: migration: move wait countdown in a function .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11758/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1706/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12547/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/32706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id808539a654e1556519ed54f6f4b67364eacf48a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: ssl_accept blocks after reboot
Martin Peřina has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 1: Verified+1 Verified, that it fixes engine - host connection issues after host was fenced when using JSONRPC (more than 10 tests executed without error). Verified, that it doesn't introduce any error in the above scenario when using XMLRPC (6 tests executed without errror) -- To view, visit http://gerrit.ovirt.org/33611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gitignore: Ingore vdsm-lvm.rule.tpl
oVirt Jenkins CI Server has posted comments on this change. Change subject: gitignore: Ingore vdsm-lvm.rule.tpl .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12701/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12546/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
