Change in vdsm[master]: gluster: add createBrick verb
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 15:
(2 comments)
http://gerrit.ovirt.org/#/c/35498/15/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 212: if rc:
Line 213: raise
ge.GlusterHostStorageDeviceMkfsFailedException(devPath,
Line 214:
alignment,
Line 215:
stripeSize,
Line 216:
fsType)
> 1. why are not out/err considered here?
Done
Line 217: if fsType == DEFAULT_FS_TYPE:
Line 218: _formatDeviceXfs()
Line 219: else:
Line 220: log.error("This file system type:%s will not be
supported" % fsType)
Line 216:
fsType)
Line 217: if fsType == DEFAULT_FS_TYPE:
Line 218: _formatDeviceXfs()
Line 219: else:
Line 220: log.error("This file system type:%s will not be
supported" % fsType)
> Have it clean msg like '%s is currently unsupported'
Done
Line 221: raise
ge.GlusterHostStorageDeviceMkfsFailedException(devPath,
Line 222:
alignment,
Line 223:
stripeSize,
Line 224:
fsType)
--
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Shubhendu Tripathi
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add ExpiringCache
Francesco Romani has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 8: (8 comments) http://gerrit.ovirt.org/#/c/36716/8/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 49: is attached to each key. Thread safe. Line 50: Line 51: Parameters: Line 52: ttl: validity of the keys in `clock' time units since Line 53: the time of their inserion in the ExpiringCache. > This can be simplified and be more clear: agreed and done Line 54: clock: time.time() or monotonic_time()-like callable. Line 55: Line 56: NOTE: The time interval of key validity is [T, T+ttl) Line 57: where `T' is the clock() time of insertion. Line 53: the time of their inserion in the ExpiringCache. Line 54: clock: time.time() or monotonic_time()-like callable. Line 55: Line 56: NOTE: The time interval of key validity is [T, T+ttl) Line 57: where `T' is the clock() time of insertion. > This is not clear. I think the description of ttl is good enough. Removed. Line 58: Line 59: Expired keys are transparently removed on the first attempt Line 60: to access them, using get or __getitem__. In that case, Line 61: ItemExpired is raised; in case of a missing key, KeyError Line 55: Line 56: NOTE: The time interval of key validity is [T, T+ttl) Line 57: where `T' is the clock() time of insertion. Line 58: Line 59: Expired keys are transparently removed on the first attempt > transparently can be removed. Done Line 60: to access them, using get or __getitem__. In that case, Line 61: ItemExpired is raised; in case of a missing key, KeyError Line 62: is raised as for regular dict()s. Line 63: """ Line 56: NOTE: The time interval of key validity is [T, T+ttl) Line 57: where `T' is the clock() time of insertion. Line 58: Line 59: Expired keys are transparently removed on the first attempt Line 60: to access them, using get or __getitem__. In that case, > "using get or __getitem__" does not add anything. There is no other way to Not at present moment, so removed. Line 61: ItemExpired is raised; in case of a missing key, KeyError Line 62: is raised as for regular dict()s. Line 63: """ Line 64: def __init__(self, ttl, clock=monotonic_time): Line 57: where `T' is the clock() time of insertion. Line 58: Line 59: Expired keys are transparently removed on the first attempt Line 60: to access them, using get or __getitem__. In that case, Line 61: ItemExpired is raised; in case of a missing key, KeyError > The discussion about ItemExpired is relevant only to __getitem__, get wil n Done Line 62: is raised as for regular dict()s. Line 63: """ Line 64: def __init__(self, ttl, clock=monotonic_time): Line 65: self._ttl = ttl Line 58: Line 59: Expired keys are transparently removed on the first attempt Line 60: to access them, using get or __getitem__. In that case, Line 61: ItemExpired is raised; in case of a missing key, KeyError Line 62: is raised as for regular dict()s. > People reading this may miss the fact that ItemExpired is a KeyError. The t Agreed and done. Line 63: """ Line 64: def __init__(self, ttl, clock=monotonic_time): Line 65: self._ttl = ttl Line 66: self._clock = clock Line 90: del self._items[key] Line 91: Line 92: # private Line 93: Line 94: def _get_unexpired(self, key): > This name is strange. Maybe _get_live? get_live is probably a little nicer. Changed. Line 95: """ Line 96: Automatically cleanups expired keys. Line 97: Raises KeyError if a key was not found. Line 98: Raises ItemExpired if an expired key is cleaned up. Line 94: def _get_unexpired(self, key): Line 95: """ Line 96: Automatically cleanups expired keys. Line 97: Raises KeyError if a key was not found. Line 98: Raises ItemExpired if an expired key is cleaned up. > This documentation belongs to __getitem__ Done Line 99: """ Line 100: now = self._clock() Line 101: with self._lock: Line 102: expiration, value = self._items[key] -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: restore highWrite monitoring
Francesco Romani has uploaded a new change for review.
Change subject: vm: restore highWrite monitoring
..
vm: restore highWrite monitoring
Restores the highWrite monitoring, done by polling libvirt
until we get proper events.
Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd
Signed-off-by: Francesco Romani
---
M vdsm/virt/services.py
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/37596/1
diff --git a/vdsm/virt/services.py b/vdsm/virt/services.py
index 5ab5f25..cbff4da 100644
--- a/vdsm/virt/services.py
+++ b/vdsm/virt/services.py
@@ -64,7 +64,9 @@
RepeatingCall(SampleVmJobs(cif),
config.getint('vars', 'vm_sample_jobs_interval')),
RepeatingCall(sampling.SampleVMs(cif, sampling.vmstats),
- config.getint('vars', 'vm_sample_interval'))]
+ config.getint('vars', 'vm_sample_interval')),
+RepeatingCall(HighWater(cif),
+ config.getint('vars', 'vm_watermark_interval'))]
for call in _calls:
call.start()
@@ -135,6 +137,11 @@
self._step()
def _step(self):
+if self._period <= 0:
+# I want to be able to easily disable highWrite for
+# benchmarking purposes.
+return
+
self._log.debug("after %f seconds: %s", self._period, self._func)
self._scheduler.schedule(self._period, self._dispatch)
@@ -166,3 +173,14 @@
vms = self._cif.getVMs()
for vmId, vmObj in vms.iteritems():
vmObj.updateVmJobs()
+
+
+class HighWater(object):
+def __init__(self, cif):
+self._cif = cif
+
+def __call__(self):
+vms = self._cif.getVMs()
+for vmId, vmObj in vms.iteritems():
+if vmObj.isDisksStatsCollectionEnabled():
+vmObj.extendDrivesIfNeeded()
--
To view, visit http://gerrit.ovirt.org/37596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce the services infrastracture
Francesco Romani has uploaded a new change for review.
Change subject: virt: introduce the services infrastracture
..
virt: introduce the services infrastracture
In order to keep track of the state of a VM,
the virt code needs to perform periodic bookkeeping
operation. Currently, these operation are piggybacked
in the sampling thread, just because this is a simple
and cheap way to run some code asynchronously to Engine's
query and periodically.
But these operations can hardly be consider 'sampling',
and sometimes just can't.
To have them as part of the sampling make the code more
confusing and harder to improve, as they can't fit nicely
in any bulk sampling schema.
What we really need is a reliable method to run async,
possibly periodically, operations related to VMs.
As part of the sampling improvement effort, we added
two generic utilities which provide great buliding
blocks for this task as well, scheduler and executor.
So, this patch laids down the basic infrastructure
to run async/periodic VM-related operations, and start
moving bookkeeping operations to them.
Known issues:
- the usage of globals is questionable
- need to improve how to RepeatingCalls are stored
- the start function does too much work
- naming is questionable ("services" means nothing!
it just vaguely reminds daemons) and needs to be
improved.
Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed
Signed-off-by: Francesco Romani
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/vdsm
M vdsm/virt/Makefile.am
A vdsm/virt/services.py
5 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/37593/1
diff --git a/debian/vdsm.install b/debian/vdsm.install
index cd71517..7f8fd81 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -151,6 +151,7 @@
./usr/share/vdsm/virt/guestagent.py
./usr/share/vdsm/virt/migration.py
./usr/share/vdsm/virt/sampling.py
+./usr/share/vdsm/virt/services.py
./usr/share/vdsm/virt/vm.py
./usr/share/vdsm/virt/vmchannels.py
./usr/share/vdsm/virt/vmexitreason.py
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 6c8f781..c179182 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1061,6 +1061,7 @@
%{_datadir}/%{vdsm_name}/virt/guestagent.py*
%{_datadir}/%{vdsm_name}/virt/migration.py*
%{_datadir}/%{vdsm_name}/virt/sampling.py*
+%{_datadir}/%{vdsm_name}/virt/services.py*
%{_datadir}/%{vdsm_name}/virt/vmchannels.py*
%{_datadir}/%{vdsm_name}/virt/vmstatus.py*
%{_datadir}/%{vdsm_name}/virt/vmtune.py*
diff --git a/vdsm/vdsm b/vdsm/vdsm
index 5c1ab71..11b2996 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -40,6 +40,7 @@
from storage.hsm import HSM
import vdsm.infra.zombiereaper as zombiereaper
+from virt import services
import dsaversion
loggerConfFile = constants.P_VDSM_CONF + 'logger.conf'
@@ -88,11 +89,13 @@
from clientIF import clientIF # must import after config is read
cif = clientIF.getInstance(irs, log)
cif.start()
+services.start(cif)
try:
while running[0]:
signal.pause()
profile.stop()
+services.stop()
finally:
cif.prepareForShutdown()
diff --git a/vdsm/virt/Makefile.am b/vdsm/virt/Makefile.am
index 2bb8c0e..a40496e 100644
--- a/vdsm/virt/Makefile.am
+++ b/vdsm/virt/Makefile.am
@@ -29,6 +29,7 @@
guestagent.py \
migration.py \
sampling.py \
+ services.py \
vm.py \
vmchannels.py \
vmexitreason.py \
diff --git a/vdsm/virt/services.py b/vdsm/virt/services.py
new file mode 100644
index 000..dcb83a8
--- /dev/null
+++ b/vdsm/virt/services.py
@@ -0,0 +1,135 @@
+#
+# Copyright 2015 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+"""
+code to perform periodic maintenance and bookkeeping of the VMs.
+"""
+
+import logging
+import threading
+
+from vdsm import executor
+from vdsm import schedule
+from vdsm.utils import monotonic_time
+
+
+_executor = None
+_scheduler = None
+_calls = []
+
+
+def start(cif):
+# `cif' will be used by future patches.
+global _scheduler
+global _executor
+global _calls
+
+if _scheduler is None:
+sched = schedule.Scheduler(name="virt
Change in vdsm[master]: vm: bootstrap services using updateVolume
Francesco Romani has uploaded a new change for review.
Change subject: vm: bootstrap services using updateVolume
..
vm: bootstrap services using updateVolume
During their lifetime the volumes of a VM needs
to be updated. This is a task carried by the
'updateVolumes' operation, which was formerly
piggybacked in the sampling threads.
But actually 'updateVolumes' is a perfect candidate
to motivy the need of a 'services' infrastructure to
run periodic (bookkeeping) tasks for VMs.
So, this patch bootstraps the usage of the newly
added services infrastructure by moving 'updateVolumes'
from sampling threads to 'services'.
No changes in behaviour are meant.
Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa
Signed-off-by: Francesco Romani
---
M vdsm/virt/services.py
M vdsm/virt/vm.py
2 files changed, 19 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/37594/1
diff --git a/vdsm/virt/services.py b/vdsm/virt/services.py
index dcb83a8..5bd4225 100644
--- a/vdsm/virt/services.py
+++ b/vdsm/virt/services.py
@@ -27,6 +27,7 @@
from vdsm import executor
from vdsm import schedule
+from vdsm.config import config
from vdsm.utils import monotonic_time
@@ -55,7 +56,10 @@
exc.start()
_executor = exc
-_calls = []
+_calls = [
+RepeatingCall(UpdateVolumes(cif),
+ config.getint('irs', 'vol_size_sample_interval'))]
+
for call in _calls:
call.start()
@@ -133,3 +137,16 @@
if self._running:
self._call = None
self._executor.dispatch(self, self._timeout)
+
+
+class UpdateVolumes(object):
+def __init__(self, cif):
+self._cif = cif
+
+def __call__(self):
+vms = self._cif.getVMs()
+for vmId, vmObj in vms.iteritems():
+if vmObj.isDisksStatsCollectionEnabled():
+# Avoid queries from storage during recovery process
+for vmDrive in vmObj.getDiskDevices():
+vmObj.updateDriveVolume(vmDrive)
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 3a61f04..ddc852d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -189,10 +189,6 @@
AdvancedStatsFunction(
self._highWrite,
config.getint('vars', 'vm_watermark_interval')))
-self.updateVolumes = (
-AdvancedStatsFunction(
-self._updateVolumes,
-config.getint('irs', 'vol_size_sample_interval')))
self.sampleCpu = (
AdvancedStatsFunction(
@@ -227,7 +223,7 @@
config.getint('vars', 'vm_sample_cpu_tune_interval'), 1))
self.addStatsFunction(
-self.highWrite, self.updateVolumes, self.sampleCpu,
+self.highWrite, self.sampleCpu,
self.sampleDisk, self.sampleNet, self.sampleBalloon,
self.sampleVmJobs, self.sampleVcpuPinning, self.sampleCpuTune)
@@ -236,14 +232,6 @@
# Avoid queries from storage during recovery process
return
self._vm.extendDrivesIfNeeded()
-
-def _updateVolumes(self):
-if not self._vm.isDisksStatsCollectionEnabled():
-# Avoid queries from storage during recovery process
-return
-
-for vmDrive in self._vm.getDiskDevices():
-self._vm.updateDriveVolume(vmDrive)
def _sampleCpu(self):
"""
--
To view, visit http://gerrit.ovirt.org/37594
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: guestagent: do not access guestinfo directly
Francesco Romani has uploaded a new change for review. Change subject: vm: guestagent: do not access guestinfo directly .. vm: guestagent: do not access guestinfo directly guest info should be get using the getGuestInfo() method and not using the guestInfo field directly. This patch fixes that. Change-Id: I04b424e751f92e87c0795e34279deca19e53899a Signed-off-by: Francesco Romani --- M vdsm/virt/vm.py 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/37591/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index c85b803..4da9653 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -1327,9 +1327,10 @@ toSave = self.status() toSave['startTime'] = self._startTime if self.lastStatus != vmstatus.DOWN and self._vmStats: -toSave['username'] = self.guestAgent.guestInfo['username'] -toSave['guestIPs'] = self.guestAgent.guestInfo['guestIPs'] -toSave['guestFQDN'] = self.guestAgent.guestInfo['guestFQDN'] +guestInfo = self.guestAgent.getGuestInfo() +toSave['username'] = guestInfo['username'] +toSave['guestIPs'] = guestInfo['guestIPs'] +toSave['guestFQDN'] = guestInfo['guestFQDN'] else: toSave['username'] = "" toSave['guestIPs'] = "" -- To view, visit http://gerrit.ovirt.org/37591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I04b424e751f92e87c0795e34279deca19e53899a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
Francesco Romani has uploaded a new change for review.
Change subject: vm: stats: cache metadata value
..
vm: stats: cache metadata value
vcpuLimit can be set only by Engine (or anyone else
impersonating it using the UpdateVmPolicy API).
It seems a little wasteful to poll, albeit infrequently
(every 15s), for changes in a value which we know
when and how it will change.
Instead of doing so, this patch adds a simple cache
variable, to be transparently updated after
each UpdateVmPolicy.
Please note that the same approach was taken for I/O
tune, based on the assumption that VDSM is the only
controller of libvirt.
Since this assumption is ingrained in the very roots
of how VDSM works, it seem fair to extend to (V)CPU
tune as well.
Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704
Signed-off-by: Francesco Romani
---
M vdsm/virt/vm.py
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/37592/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4da9653..3a61f04 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -763,6 +763,16 @@
Runs Qemu in a subprocess and communicates with it, and monitors
its behaviour.
"""
+
+# This flag will prevent excessive log flooding when running
+# on libvirt with no support for metadata xml elements.
+#
+# The issue currently exists only on CentOS/RHEL 6.5 that
+# ships libvirt-0.10.x.
+#
+# TODO: Remove as soon as there is a hard dependency we can use
+_libvirt_metadata_supported = True
+
log = logging.getLogger("vm.Vm")
# limit threads number until the libvirt lock will be fixed
_ongoingCreations = threading.BoundedSemaphore(4)
@@ -873,6 +883,7 @@
self._powerDownEvent = threading.Event()
self._liveMergeCleanupThreads = {}
self._shutdownReason = None
+self._vcpuLimit = None
def _get_lastStatus(self):
# note that we don't use _statusLock here. One of the reasons is the
@@ -1834,6 +1845,8 @@
self.guestAgent.diskMappingHash)))
if self._watchdogEvent:
stats['watchdogEvent'] = self._watchdogEvent
+if self._vcpuLimit:
+stats['vcpuUserLimit'] = self._vcpuLimit
return stats
def _getVmStatus(self):
@@ -2677,7 +2690,7 @@
qos.appendChild(vcpuLimit)
metadata_modified = True
-del params['vcpuLimit']
+self._vcpuLimit = params.pop('vcpuLimit')
if 'ioTune' in params:
# Make sure the top level element exists
--
To view, visit http://gerrit.ovirt.org/37592
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop now unused code
Francesco Romani has uploaded a new change for review.
Change subject: vm: drop now unused code
..
vm: drop now unused code
Drop VmStatsThread, since it was replaced and it is now
useless.
Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903
Signed-off-by: Francesco Romani
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 513 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/37597/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 9f54075..fc49057 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -53,7 +53,6 @@
import caps
import hooks
import supervdsm
-import numaUtils
# local package imports
from .domain_descriptor import DomainDescriptor
@@ -69,7 +68,6 @@
from .vmtune import io_tune_values_to_dom, io_tune_dom_to_values
from . import vmxml
-from .sampling import AdvancedStatsFunction, AdvancedStatsThread
from .utils import isVdsmImage
from vmpowerdown import VmShutdown, VmReboot
@@ -169,517 +167,6 @@
VolumeChainEntry = namedtuple('VolumeChainEntry',
['uuid', 'path', 'allocation'])
-
-
-class VmStatsThread(AdvancedStatsThread):
-MBPS_TO_BPS = 10 ** 6 / 8
-
-# This flag will prevent excessive log flooding when running
-# on libvirt with no support for metadata xml elements.
-#
-# The issue currently exists only on CentOS/RHEL 6.5 that
-# ships libvirt-0.10.x.
-#
-# TODO: Remove as soon as there is a hard dependency we can use
-_libvirt_metadata_supported = True
-
-def __init__(self, vm):
-AdvancedStatsThread.__init__(self, log=vm.log, daemon=True)
-self._vm = vm
-
-self.highWrite = (
-AdvancedStatsFunction(
-self._highWrite,
-config.getint('vars', 'vm_watermark_interval')))
-
-self.sampleCpu = (
-AdvancedStatsFunction(
-self._sampleCpu,
-config.getint('vars', 'vm_sample_cpu_interval'),
-config.getint('vars', 'vm_sample_cpu_window')))
-self.sampleDisk = (
-AdvancedStatsFunction(
-self._sampleDisk,
-config.getint('vars', 'vm_sample_disk_interval'),
-config.getint('vars', 'vm_sample_disk_window')))
-self.sampleNet = (
-AdvancedStatsFunction(
-self._sampleNet,
-config.getint('vars', 'vm_sample_net_interval'),
-config.getint('vars', 'vm_sample_net_window')))
-self.sampleBalloon = (
-AdvancedStatsFunction(
-self._sampleBalloon,
-config.getint('vars', 'vm_sample_balloon_interval'), 1))
-self.sampleVcpuPinning = (
-AdvancedStatsFunction(
-self._sampleVcpuPinning,
-config.getint('vars', 'vm_sample_vcpu_pin_interval'), 1))
-self.sampleCpuTune = (
-AdvancedStatsFunction(
-self._sampleCpuTune,
-config.getint('vars', 'vm_sample_cpu_tune_interval'), 1))
-
-self.addStatsFunction(
-self.highWrite, self.sampleCpu,
-self.sampleDisk, self.sampleNet, self.sampleBalloon,
-self.sampleVcpuPinning, self.sampleCpuTune)
-
-def _highWrite(self):
-if not self._vm.isDisksStatsCollectionEnabled():
-# Avoid queries from storage during recovery process
-return
-self._vm.extendDrivesIfNeeded()
-
-def _sampleCpu(self):
-"""
-Physical CPU statistics. Return value is a dict with
-at least three key/value pairs:
-* 'cpu_time': total wall clock time spent, nanoseconds.
-* 'system_time': time spent by the hypervisor in kernel
- space, nanoseconds.
-* 'user_time': time spent by the hypervisor in user space,
- nanoseconds.
-Extra keys will be ignored.
-
-Example:
-{
-'cpu_time': 17732877847L,
-'system_time': 303000L,
-'user_time': 51000L
-}
-"""
-cpuStats = self._vm._dom.getCPUStats(True, 0)
-return cpuStats[0]
-
-def _sampleDisk(self):
-"""
-Disk statistics. Return value is a dict with a key for
-each Vm drive. Each value is in turn a dict with at least
-eight key/value pairs:
-* {rd,wr,flush}_total_times: total time spent, in the
- I/O operations of the given kind, nanoseconds.
-* {rd,wr,flush}_operations: number of operations of the given kind
-* {rd,wr}_bytes: amount of bytes read or written, per disk.
-Extra keys will be ignored.
-
-Example:
-{
-'vda':
-{
-'rd_total_times': 41725620156L,
-'wr_total_times': 3038027L,
-'flush_total_times': 14947030448L,
-
Change in vdsm[master]: vm: move queryBlockJobs under services
Francesco Romani has uploaded a new change for review.
Change subject: vm: move queryBlockJobs under services
..
vm: move queryBlockJobs under services
Vm/Block Jobs monitoring is a fundamental
part of live merge support. However, to call
this 'sampling' it is an hard sell.
This patch moves the periodic monitoring of
the VM block jobs under the services umbrella,
with no intended changes in behaviour nor in
the output.
The only code changes are limited to the glue code
needed to adapt from sampling to services
framework.
Change-Id: I2bba47881033af1b928195a94456f7130a7ac343
Signed-off-by: Francesco Romani
---
M vdsm/virt/services.py
M vdsm/virt/vm.py
2 files changed, 21 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/37595/1
diff --git a/vdsm/virt/services.py b/vdsm/virt/services.py
index 5bd4225..23ee2e3 100644
--- a/vdsm/virt/services.py
+++ b/vdsm/virt/services.py
@@ -58,7 +58,9 @@
_calls = [
RepeatingCall(UpdateVolumes(cif),
- config.getint('irs', 'vol_size_sample_interval'))]
+ config.getint('irs', 'vol_size_sample_interval')),
+RepeatingCall(SampleVmJobs(cif),
+ config.getint('vars', 'vm_sample_jobs_interval'))]
for call in _calls:
call.start()
@@ -150,3 +152,13 @@
# Avoid queries from storage during recovery process
for vmDrive in vmObj.getDiskDevices():
vmObj.updateDriveVolume(vmDrive)
+
+
+class SampleVmJobs(object):
+def __init__(self, cif):
+self._cif = cif
+
+def __call__(self):
+vms = self._cif.getVMs()
+for vmId, vmObj in vms.iteritems():
+vmObj.updateVmJobs()
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ddc852d..046549f 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -209,10 +209,6 @@
AdvancedStatsFunction(
self._sampleBalloon,
config.getint('vars', 'vm_sample_balloon_interval'), 1))
-self.sampleVmJobs = (
-AdvancedStatsFunction(
-self._sampleVmJobs,
-config.getint('vars', 'vm_sample_jobs_interval'), 1))
self.sampleVcpuPinning = (
AdvancedStatsFunction(
self._sampleVcpuPinning,
@@ -225,7 +221,7 @@
self.addStatsFunction(
self.highWrite, self.sampleCpu,
self.sampleDisk, self.sampleNet, self.sampleBalloon,
-self.sampleVmJobs, self.sampleVcpuPinning, self.sampleCpuTune)
+self.sampleVcpuPinning, self.sampleCpuTune)
def _highWrite(self):
if not self._vm.isDisksStatsCollectionEnabled():
@@ -357,9 +353,6 @@
"""
infos = self._vm._dom.info()
return infos[2]
-
-def _sampleVmJobs(self):
-return self._vm.queryBlockJobs()
def _sampleCpuTune(self):
"""
@@ -631,14 +624,6 @@
if vmNumaNodeRuntimeMap:
stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap
-def _getVmJobs(self, stats):
-info = self.sampleVmJobs.getLastSample()
-if info is not None:
-# If we are unable to collect stats we must not return anything at
-# all since an empty dictionary would be interpreted as vm jobs
-# finishing.
-stats['vmJobs'] = info
-
def get(self):
stats = {}
@@ -646,7 +631,6 @@
self._getNetworkStats(stats)
self._getDiskStats(stats)
self._getBalloonStats(stats)
-self._getVmJobs(stats)
self._getNumaStats(stats)
self._getCpuTuneInfo(stats)
self._getCpuCount(stats)
@@ -872,6 +856,7 @@
self._liveMergeCleanupThreads = {}
self._shutdownReason = None
self._vcpuLimit = None
+self._vmJobs = None
def _get_lastStatus(self):
# note that we don't use _statusLock here. One of the reasons is the
@@ -1816,7 +1801,7 @@
stats[var] = decStats[var]
elif type(decStats[var]) is not dict:
stats[var] = utils.convertToStr(decStats[var])
-elif var in ('network', 'balloonInfo', 'vmJobs',
+elif var in ('network', 'balloonInfo',
'vNodeRuntimeInfo'):
stats[var] = decStats[var]
else:
@@ -1835,6 +1820,8 @@
stats['watchdogEvent'] = self._watchdogEvent
if self._vcpuLimit:
stats['vcpuUserLimit'] = self._vcpuLimit
+if self._vmJobs:
+stats['vmJobs'] = self._vmJobs
return stats
def _getVmStatus(self):
@@ -4612,6 +4599,9 @@
return True
return False
+def updateVmJobs(self):
+self._vmJobs = self.queryBlockJobs()
+
def queryBlockJobs(self):
def startCleanup(job, drive, needPivot):
t = LiveMergeCleanupThread(
Change in vdsm[master]: virt: add ExpiringCache
Francesco Romani has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 9: this version addresses the comments from Nir (thanks!) -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add createBrick verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/426/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/419/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15477/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/984/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14674/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15646/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/452/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/967/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/35498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: split up stats production
Francesco Romani has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 9: version 9 is an overhaul of the code, attempting to make it simpler. The basic concept behind this patch is unchanged, Most notably, the Producer class was dropped, as it had little state. Now 'produce' is just a plain function. This is more appropriate because this code just translates data from one format to another one. -- To view, visit http://gerrit.ovirt.org/36730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: do disk bookkeeping while sampling
Francesco Romani has abandoned this change. Change subject: virt: sampling: do disk bookkeeping while sampling .. Abandoned Preliminary benchmarking and more thought suggest that this is not the right direction. These operations must not be done in the context of the sampling thread. -- To view, visit http://gerrit.ovirt.org/36724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I74bc47bb9d4e8d07e86eec4574ff52a7ce2e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add helper to get disk params from bulk stats
Francesco Romani has abandoned this change. Change subject: vm: add helper to get disk params from bulk stats .. Abandoned In the long term, we need libvirt events to get rid of this polling altogether. In the short term, we need a different approach. -- To view, visit http://gerrit.ovirt.org/36723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I515500ee0b347e83c0230d2f67b5a554146f9807 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: decouple fetch from translation
Francesco Romani has abandoned this change. Change subject: sampling: decouple fetch from translation .. Abandoned too much noise to have a meaningful result. New attempt is simpler and at least equally effective. -- To view, visit http://gerrit.ovirt.org/36729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4e46a9f2ff96544ceac51ab011fa078859280287 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make Vm.stats public
Francesco Romani has abandoned this change. Change subject: vm: make Vm.stats public .. Abandoned no longer needed. Took a different direction to achieve the same result. -- To view, visit http://gerrit.ovirt.org/36718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic5e8086028c9bfcb5aeb2e918756fc2408861246 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: vm: use bulk-stats-style sample format
Francesco Romani has abandoned this change. Change subject: sampling: vm: use bulk-stats-style sample format .. Abandoned not needed now, so abandoned to reduce the nose. If we want to have backward compatibility, will be restored and updated. -- To view, visit http://gerrit.ovirt.org/36731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic43b1ecb5e3503f22d3b45576310a169de852b47 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add an API to check if the domain is busy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add an API to check if the domain is busy .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2323/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15478/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14675/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15647/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/453/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa253326778a102591af4ef5f2bb0434d1eade6 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: sample using bulk stats and services
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: sample using bulk stats and services .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2324/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15479/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14676/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15648/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/454/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netlink: replace old ipwrapper event monitor
Petr Horáček has abandoned this change. Change subject: netlink: replace old ipwrapper event monitor .. Abandoned -- To view, visit http://gerrit.ovirt.org/34929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ie7a9765e59a8392fff9b3fd556133159aeb60b1c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: split up stats production
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/427/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/420/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2325/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15480/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/985/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14677/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15649/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/455/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/968/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add ExpiringCache
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2326/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15481/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14678/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15650/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/456/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: add API to get all registered VMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: add API to get all registered VMs .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15482/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14679/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15651/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/457/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib58c6926b6bb3b5b14df8eb1ed59c347775422c1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: guestagent: do not access guestinfo directly
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: guestagent: do not access guestinfo directly .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2327/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15483/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14680/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15652/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/458/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b424e751f92e87c0795e34279deca19e53899a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: cache metadata value .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2328/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15484/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14681/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15653/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/459/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce the services infrastracture
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: introduce the services infrastracture .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/428/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/421/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2329/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15485/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/986/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14682/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15654/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/460/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/969/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: bootstrap services using updateVolume
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: bootstrap services using updateVolume .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2330/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15486/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14683/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15655/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/461/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move queryBlockJobs under services
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move queryBlockJobs under services .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2331/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15487/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14684/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15656/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/462/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop now unused code
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: drop now unused code .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2332/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15489/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14685/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15658/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/463/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: restore highWrite monitoring
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: restore highWrite monitoring .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2333/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15488/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15657/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/464/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b7c4d2bc4d4e35d03e1896e3a0796dff4133cd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot config list and set verbs.
Darshan N has posted comments on this change.
Change subject: gluster: volume snapshot config list and set verbs.
..
Patch Set 8:
(4 comments)
http://gerrit.ovirt.org/#/c/34741/8//COMMIT_MSG
Commit Message:
Line 11:
Line 12: *glusterSnapshotConfigList: get the snapshot configuration.
Line 13: This verb gives the snapshot configuration for the cluster
Line 14: and for all the volumes present in it.
Line 15: Returns:
> Also in both the cases the outer level key shold be called "snapshotConfig"
Done
Line 16: {'systemConfig':{'snap-max-hard-limit': 'hardLimit',
Line 17: 'snap-max-soft-limit': 'softLimit',
Line 18: 'auto-delete': 'enable/disable'},
Line 19: 'volumeConfig':{'volume name': {
Line 15: Returns:
Line 16: {'systemConfig':{'snap-max-hard-limit': 'hardLimit',
Line 17: 'snap-max-soft-limit': 'softLimit',
Line 18: 'auto-delete': 'enable/disable'},
Line 19: 'volumeConfig':{'volume name': {
> How about 'system' instead of 'systemConfig' and 'volume' instead of 'volum
Done
Line 20: 'snap-max-hard-limit': 'hardLimit'}...
Line 21: }
Line 22: }
Line 23:
Line 29: {'systemConfig':{'snap-max-hard-limit': 'hardLimit',
Line 30: 'snap-max-soft-limit': 'softLimit',
Line 31: 'auto-delete': 'enable/disable'},
Line 32: 'volumeConfig':{'volume name': {
Line 33: 'snap-max-hard-limit': 'hardLimit'}
> Here the value returned for snap-max-hard-limit should be value of "Effecti
As we discussed volume related config will provide snap-max-hard-limit,
effective-hard-limit and snap-max-soft-limit.
Line 34: }
Line 35: }
Line 36:
Line 37: *glusterSnapshotConfigSet: Set snapshot configuration
http://gerrit.ovirt.org/#/c/34741/8/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:
Line 1588: 'data': {},
Line 1589: 'returns': 'SnapConfigDetail'}
Line 1590:
Line 1591: ##
Line 1592: # @GlusterVolumr.snapshotConfigList:
> spelling ?
Done
Line 1593: #
Line 1594: # get the config values of snapshot for a volume
Line 1595: #
Line 1596: # @volumeName: Gluster volume name
--
To view, visit http://gerrit.ovirt.org/34741
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee32a95cf028cda33f25776c08820c5ed80f1033
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Shubhendu Tripathi
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot config list and set verbs.
Darshan N has posted comments on this change. Change subject: gluster: volume snapshot config list and set verbs. .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/34741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee32a95cf028cda33f25776c08820c5ed80f1033 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot config list and set verbs.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot config list and set verbs. .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/429/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/422/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15490/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/987/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14687/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15659/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/465/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/970/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee32a95cf028cda33f25776c08820c5ed80f1033 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: guestagent: do not access guestinfo directly
Vinzenz Feenstra has posted comments on this change. Change subject: vm: guestagent: do not access guestinfo directly .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b424e751f92e87c0795e34279deca19e53899a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add createBrick verb
Bala.FA has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 16: Code-Review-1
(8 comments)
http://gerrit.ovirt.org/#/c/35498/16/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 30: from blivet.devices import LVMThinLogicalVolumeDevice
Line 31:
Line 32: import fstab
Line 33: import exception as ge
Line 34: from . import makePublic
You haven't rearranged imports like
1. Have python system modules as first level
2. Have vdsm modules as second level
3. Have local modules as third level
Line 35:
Line 36:
Line 37: log = logging.getLogger("Gluster")
Line 38: _pvcreateCommandPath = utils.CommandPath("pvcreate",
Line 33: import exception as ge
Line 34: from . import makePublic
Line 35:
Line 36:
Line 37: log = logging.getLogger("Gluster")
What is logger name used in other modules wrt vdsm-gluster?
Line 38: _pvcreateCommandPath = utils.CommandPath("pvcreate",
Line 39: "/sbin/pvcreate",
Line 40: "/usr/sbin/pvcreate",)
Line 41: _lvconvertCommandPath = utils.CommandPath("lvconvert",
Line 59: DEFAULT_FS_TYPE = "xfs"
Line 60: DEFAULT_MOUNT_OPTIONS = "inode64,noatime"
Line 61:
Line 62:
Line 63: def _getDeviceDict(device, hasData, fsType=''):
1. How about 'createBrick=False' instead of hasData?
2. Why is fsType needed?
Line 64: info = {'name': device.name,
Line 65: 'size': '%s' % device.size,
Line 66: 'devPath': device.path,
Line 67: 'devUuid': device.uuid or '',
Line 86:
Line 87: def _parseDevices(devices):
Line 88: deviceList = []
Line 89: for device in devices:
Line 90: deviceList.append(_getDeviceDict(device,
_canCreateBrick(device)))
You agreed to have it as separate patch
Line 91: return deviceList
Line 92:
Line 93:
Line 94: def _canCreateBrick(device):
Line 142: '%sK' % alignment,
Line 143: dev.path])
Line 144: if rc:
Line 145: raise
ge.GlusterHostStorageDevicePVCreateFailedException(
Line 146: dev.path, alignment)
Why aren't you taking rc,out,err to the exception? Why such thing are
repeatedly missed out?
Line 147:
Line 148: blivetEnv.reset()
Line 149: return _getDeviceList([dev.name for dev in deviceList])
Line 150:
Line 191: '--thinpool', vgPoolName,
Line 192: '--poolmetadata',
Line 193: "%s/%s" % (vg.name,
metaName)])
Line 194: rc, out, err = utils.execCmd([_lvchangeCommandPath.cmd,
Line 195: '--zero', 'n', vgPoolName])
Why aren't you taking care of failure case here? You need to raise exception
appopriately
Line 196: blivetEnv.reset()
Line 197: return blivetEnv.devicetree.getDeviceByName(poolLv.name)
Line 198: else:
Line 199: pool = LVMThinPoolDevice(poolName, parents=[vg],
Line 214: '-n', 'size=8192',
Line 215: devPath])
Line 216: if rc:
Line 217: raise ge.GlusterHostStorageDeviceMkfsFailedException(
Line 218: devPath, alignment, stripeSize, fsType, rc, out,
err)
Why aren't you 'return True' if its succeeded?
Line 219: if fsType == DEFAULT_FS_TYPE:
Line 220: _formatDeviceXfs()
Line 221: else:
Line 222: log.error("%s is currently unsupported" % fsType)
Line 216: if rc:
Line 217: raise ge.GlusterHostStorageDeviceMkfsFailedException(
Line 218: devPath, alignment, stripeSize, fsType, rc, out,
err)
Line 219: if fsType == DEFAULT_FS_TYPE:
Line 220: _formatDeviceXfs()
same as above
Line 221: else:
Line 222: log.error("%s is currently unsupported" % fsType)
Line 223: raise ge.GlusterHostStorageDeviceMkfsFailedException(
Line 224: devPath, alignment, stripeSize, fsType)
--
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Sandro Bonazzola
Gerrit-Reviewer: Shubhendu Tripathi
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_
Change in vdsm[master]: _get_gateway: reformat a list comprehension for readability
Ondřej Svoboda has posted comments on this change. Change subject: _get_gateway: reformat a list comprehension for readability .. Patch Set 3: Verified+1 No functional change. -- To view, visit http://gerrit.ovirt.org/37447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9621f23669002631a67dc16941b829b517c4e017 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _get_gateway: reformat a list comprehension for readability
Dan Kenigsberg has posted comments on this change. Change subject: _get_gateway: reformat a list comprehension for readability .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9621f23669002631a67dc16941b829b517c4e017 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _get_gateway: reformat a list comprehension for readability
Dan Kenigsberg has submitted this change and it was merged. Change subject: _get_gateway: reformat a list comprehension for readability .. _get_gateway: reformat a list comprehension for readability Change-Id: I9621f23669002631a67dc16941b829b517c4e017 Signed-off-by: Ondřej Svoboda Reviewed-on: http://gerrit.ovirt.org/37447 Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M lib/vdsm/netinfo.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Ondřej Svoboda: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9621f23669002631a67dc16941b829b517c4e017 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: use IP_MASK, there's no need for prefix2netmask
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: use IP_MASK, there's no need for prefix2netmask .. Patch Set 2: Verified+1 Both affected tests (testStaticSourceRouting and testIPv6ConfigNetwork) still work after this change. -- To view, visit http://gerrit.ovirt.org/37464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib47ad4e83c8360b9bbd9a512866c215409e23976 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add drive_config helper
Francesco Romani has posted comments on this change.
Change subject: tests: Add drive_config helper
..
Patch Set 1: Code-Review+1
(1 comment)
indeed it is nicer this way.
http://gerrit.ovirt.org/#/c/37547/1/tests/vmStorageTests.py
File tests/vmStorageTests.py:
Line 46:
Line 47: def test_disk_virtio_cache(self):
Line 48: conf = drive_config(
Line 49: format='cow',
Line 50: propagateErrors='on',
could be nicer if we can be able to write
propagateErrors=True,
shared=True,
and inside drive_config some translation logic could produce the right value
(e.g. 'on' or 'shared').
OTOH, that could also be an overkill.
Line 51: shared='shared',
Line 52: specParams={
Line 53: 'ioTune': {
Line 54: 'read_bytes_sec': 612,
--
To view, visit http://gerrit.ovirt.org/37547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1d1fd263324d3e376606c97be7ab54059b7f17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add createBrick verb
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 16:
(8 comments)
http://gerrit.ovirt.org/#/c/35498/16/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 30: from blivet.devices import LVMThinLogicalVolumeDevice
Line 31:
Line 32: import fstab
Line 33: import exception as ge
Line 34: from . import makePublic
> You haven't rearranged imports like
logging is the only python system module here its mentioned first
Secondly i can keep vdsm modules (here its utils and mount)
what about blivet? can i consider it as local modules?
Line 35:
Line 36:
Line 37: log = logging.getLogger("Gluster")
Line 38: _pvcreateCommandPath = utils.CommandPath("pvcreate",
Line 33: import exception as ge
Line 34: from . import makePublic
Line 35:
Line 36:
Line 37: log = logging.getLogger("Gluster")
> What is logger name used in other modules wrt vdsm-gluster?
Gluster
Line 38: _pvcreateCommandPath = utils.CommandPath("pvcreate",
Line 39: "/sbin/pvcreate",
Line 40: "/usr/sbin/pvcreate",)
Line 41: _lvconvertCommandPath = utils.CommandPath("lvconvert",
Line 59: DEFAULT_FS_TYPE = "xfs"
Line 60: DEFAULT_MOUNT_OPTIONS = "inode64,noatime"
Line 61:
Line 62:
Line 63: def _getDeviceDict(device, hasData, fsType=''):
> 1. How about 'createBrick=False' instead of hasData?
fsType is not appearing immediately after we create lv. It appears only after
we restart the machine
Line 64: info = {'name': device.name,
Line 65: 'size': '%s' % device.size,
Line 66: 'devPath': device.path,
Line 67: 'devUuid': device.uuid or '',
Line 86:
Line 87: def _parseDevices(devices):
Line 88: deviceList = []
Line 89: for device in devices:
Line 90: deviceList.append(_getDeviceDict(device,
_canCreateBrick(device)))
> You agreed to have it as separate patch
ok
Line 91: return deviceList
Line 92:
Line 93:
Line 94: def _canCreateBrick(device):
Line 142: '%sK' % alignment,
Line 143: dev.path])
Line 144: if rc:
Line 145: raise
ge.GlusterHostStorageDevicePVCreateFailedException(
Line 146: dev.path, alignment)
> Why aren't you taking rc,out,err to the exception? Why such thing are repea
I will add it for all the applicable places wherever i used execCmd
Line 147:
Line 148: blivetEnv.reset()
Line 149: return _getDeviceList([dev.name for dev in deviceList])
Line 150:
Line 191: '--thinpool', vgPoolName,
Line 192: '--poolmetadata',
Line 193: "%s/%s" % (vg.name,
metaName)])
Line 194: rc, out, err = utils.execCmd([_lvchangeCommandPath.cmd,
Line 195: '--zero', 'n', vgPoolName])
> Why aren't you taking care of failure case here? You need to raise excepti
Done
Line 196: blivetEnv.reset()
Line 197: return blivetEnv.devicetree.getDeviceByName(poolLv.name)
Line 198: else:
Line 199: pool = LVMThinPoolDevice(poolName, parents=[vg],
Line 214: '-n', 'size=8192',
Line 215: devPath])
Line 216: if rc:
Line 217: raise ge.GlusterHostStorageDeviceMkfsFailedException(
Line 218: devPath, alignment, stripeSize, fsType, rc, out,
err)
> Why aren't you 'return True' if its succeeded?
Done
Line 219: if fsType == DEFAULT_FS_TYPE:
Line 220: _formatDeviceXfs()
Line 221: else:
Line 222: log.error("%s is currently unsupported" % fsType)
Line 216: if rc:
Line 217: raise ge.GlusterHostStorageDeviceMkfsFailedException(
Line 218: devPath, alignment, stripeSize, fsType, rc, out,
err)
Line 219: if fsType == DEFAULT_FS_TYPE:
Line 220: _formatDeviceXfs()
> same as above
Done
Line 221: else:
Line 222: log.error("%s is currently unsupported" % fsType)
Line 223: raise ge.GlusterHostStorageDeviceMkfsFailedException(
Line 224: devPath, alignment, stripeSize, fsType)
--
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Sandro Bonazzola
Gerri
Change in vdsm[master]: tests: Rename test class
Francesco Romani has posted comments on this change. Change subject: tests: Rename test class .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42feae15b306ebbc047e4f1036e99d21d41783c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for drive disk type
Francesco Romani has posted comments on this change. Change subject: tests: Add tests for drive disk type .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I048b9cc5b72ae221db74eb03168e7aa719cacaad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add createBrick verb
Timothy Asir has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/35498/16/vdsm/rpc/vdsmapi-gluster-schema.json File vdsm/rpc/vdsmapi-gluster-schema.json: Line 1284: # @devList:List of devices to be used Line 1285: # Line 1286: # @fsType: # optional file system type Line 1287: # Line 1288: # @raid: # optional dictonary contains raid details of a raid device > Please keep param names consistent between description and command definiti Done Line 1289: # Line 1290: # Returns: Line 1291: # Success or failure Line 1292: # -- To view, visit http://gerrit.ovirt.org/35498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Invalidate drive blockDev when path changes
Francesco Romani has posted comments on this change. Change subject: virt: Invalidate drive blockDev when path changes .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: also check we successfully report an IPv4 gateway
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: also check we successfully report an IPv4 gateway .. Patch Set 3: Verified+1 The test passes only in its IPv6 variant, unless coupled with the fix in the following patch: http://gerrit.ovirt.org/#/c/37440/ Initscripts (via the ifcfg configurator) configure the IPv6 gateway in the 'main' routing table so it was visible to the test (also under the former name "testIPv6ConfigNetwork"). VDSM's configures IPv4 gateways on its own, in dedicated routing tables. We have to read the "unified" routing table to discover our gateways (this exactly is the idea of the fix). -- To view, visit http://gerrit.ovirt.org/37448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00e3ec616453cfbc5957eb917e6e083099d9668 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: report a gateway for statically configured networks
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: report a gateway for statically configured networks .. Patch Set 7: Verified+1 IPv4 gateways (created in StaticSourceRoute.configure) are now correctly reported and testStaticNetworkConfig passes. (Note that due to the usage of dummy interfaces it still requires NetworkManager to be shut down – I will post a patch to stop NM from managing them, as already done for veths.) -- To view, visit http://gerrit.ovirt.org/37440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b8c789cf393fbb9aa9d040c38d2c9d9f281864 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Lior Vernia Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: do not report DHCP from (typically still valid) leases
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: do not report DHCP from (typically still valid) leases
..
netinfo: do not report DHCP from (typically still valid) leases
Although I introduced this behaviour intentionally, VDSM must stop reporting
dhcpv4 and dhcpv6 for a network that is reverted to static configutation
(which is to be effective immediately not to confuse the engine and the user).
Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599
Signed-off-by: Ondřej Svoboda
---
M tests/functional/networkTests.py
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/37617/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 37feeb2..acaf7fe 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1818,6 +1818,15 @@
self.assertSourceRoutingConfiguration(device_name,
ip_addr)
+# Do not report DHCP from (typically still valid) leases
+network[NETWORK_NAME]['bootproto'] = 'none'
+status, msg = self.vdsm_net.setupNetworks(network, {},
+ NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+test_net = self.vdsm_net.netinfo.networks[NETWORK_NAME]
+self.assertEqual(test_net['dhcpv4'], False)
+self.assertEqual(test_net['dhcpv6'], False)
+
network = {NETWORK_NAME: {'remove': True}}
status, msg = self.vdsm_net.setupNetworks(network, {},
NOCHK)
--
To view, visit http://gerrit.ovirt.org/37617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add drive_config helper
Nir Soffer has posted comments on this change.
Change subject: tests: Add drive_config helper
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37547/1/tests/vmStorageTests.py
File tests/vmStorageTests.py:
Line 46:
Line 47: def test_disk_virtio_cache(self):
Line 48: conf = drive_config(
Line 49: format='cow',
Line 50: propagateErrors='on',
> could be nicer if we can be able to write
May be nice for Drive object, not for the helper creating dict with values for
the drive object constructor. But even for drive I would not do this so we are
closer to libvirt semantics.
Line 51: shared='shared',
Line 52: specParams={
Line 53: 'ioTune': {
Line 54: 'read_bytes_sec': 612,
--
To view, visit http://gerrit.ovirt.org/37547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1d1fd263324d3e376606c97be7ab54059b7f17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: use IP_MASK, there's no need for prefix2netmask
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: use IP_MASK, there's no need for prefix2netmask .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15491/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14688/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15660/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2600/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/466/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib47ad4e83c8360b9bbd9a512866c215409e23976 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make _getNicStats a function
Francesco Romani has posted comments on this change. Change subject: vm: make _getNicStats a function .. Patch Set 2: Verified+1 Verified by booting a VM and verifying, using vdsClient getAllVmStats, that network stats are still reported correctly (they are). -- To view, visit http://gerrit.ovirt.org/37457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia191fce7a1f3330013a621d97038bb32fd3cd563 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make MBPS_TO_BPS a module constant
Francesco Romani has posted comments on this change. Change subject: vm: make MBPS_TO_BPS a module constant .. Patch Set 2: Verified+1 make private as Dan suggested. Verified by booting a VM and verifying, using vdsClient getAllVmStats, that network stats are still reported correctly (they are). -- To view, visit http://gerrit.ovirt.org/37456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff2d9f5f0b0c22efeb897d4b87a40415093b445 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmchannels: downgrade logs about expected flows
Francesco Romani has posted comments on this change. Change subject: vmchannels: downgrade logs about expected flows .. Patch Set 6: Verified+1 verified by running a VM. -- To view, visit http://gerrit.ovirt.org/34357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib041d4c844fe948523942d76236d291ecf3eb0fb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _get_gateway: reformat a list comprehension for readability
oVirt Jenkins CI Server has posted comments on this change. Change subject: _get_gateway: reformat a list comprehension for readability .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/611/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/211/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4595/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/588/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6434/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/613/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/214/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/200/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/607/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9621f23669002631a67dc16941b829b517c4e017 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add debug log for getStats()
Francesco Romani has posted comments on this change. Change subject: vm: add debug log for getStats() .. Patch Set 2: Code-Review-1 Verified+1 verified running a VM on a patched VDSM and inspecting the logs. We now use TRACE for Host_getStats, StorageDomain_getStats, VM_getStats, Host_fenceNode and I can't tell how often TRACE is enabled outside the developer boxes. Self inflicted -1 because I haven't yet rebased on top of the default log level change. -- To view, visit http://gerrit.ovirt.org/36732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23d9361568f51be9b70dab22d3a388f692011402 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: abort vm start if can't read pid
Francesco Romani has posted comments on this change. Change subject: vm: abort vm start if can't read pid .. Patch Set 3: verified using tests. Verification using running VM: - creation, happy path. PID is reported - OK - recovery: getVmPid is no longer invoked but still reported. Verified using getAllVmStats and inspecting supervdsm logs. - pending: hybernation, migration. -- To view, visit http://gerrit.ovirt.org/36129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b80baba14caded2fb3ef74451498751347323ea Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: restore cpu tuning samples
Francesco Romani has abandoned this change. Change subject: WIP: restore cpu tuning samples .. Abandoned no longer needed -- To view, visit http://gerrit.ovirt.org/37327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic3d05bb388d76e26b5fb983a9af2e998ff289054 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster.hostname: simplify by using a constant for the 'host...
Ondřej Svoboda has uploaded a new change for review. Change subject: gluster.hostname: simplify by using a constant for the 'hostname' executable .. gluster.hostname: simplify by using a constant for the 'hostname' executable Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6 Signed-off-by: Ondřej Svoboda --- M lib/vdsm/constants.py.in M vdsm/gluster/Makefile.am R vdsm/gluster/hostname.py 3 files changed, 5 insertions(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/37621/1 diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in index 89bdebd..fa65b0c 100644 --- a/lib/vdsm/constants.py.in +++ b/lib/vdsm/constants.py.in @@ -114,6 +114,8 @@ EXT_GREP = '@GREP_PATH@' +EXT_HOSTNAME = '@HOSTNAME_PATH@' + EXT_IFDOWN = '@IFDOWN_PATH@' EXT_IFUP = '@IFUP_PATH@' EXT_IONICE = '@IONICE_PATH@' diff --git a/vdsm/gluster/Makefile.am b/vdsm/gluster/Makefile.am index 96b8054..da32685 100644 --- a/vdsm/gluster/Makefile.am +++ b/vdsm/gluster/Makefile.am @@ -22,10 +22,6 @@ vdsmglusterdir = $(vdsmdir)/gluster -nodist_vdsmgluster_PYTHON = \ - hostname.py - $(NULL) - dist_vdsmgluster_PYTHON = \ __init__.py \ api.py \ @@ -33,19 +29,9 @@ cli.py \ exception.py \ gfapi.py \ + hostname.py \ hooks.py \ services.py \ storagedev.py \ tasks.py \ $(NULL) - -EXTRA_DIST = \ - hostname.py.in - $(NULL) - -CLEANFILES = \ - hostname.py - $(NULL) - -all-local: \ - $(nodist_vdsmgluster_PYTHON) diff --git a/vdsm/gluster/hostname.py.in b/vdsm/gluster/hostname.py similarity index 91% rename from vdsm/gluster/hostname.py.in rename to vdsm/gluster/hostname.py index c817b0a..6b30ac3 100644 --- a/vdsm/gluster/hostname.py.in +++ b/vdsm/gluster/hostname.py @@ -18,6 +18,7 @@ # Refer to the README and COPYING files for full details of the license # +from vdsm import constants from vdsm import utils @@ -31,7 +32,7 @@ def getHostNameFqdn(): -rc, out, err = utils.execCmd(['@HOSTNAME_PATH@', '--fqdn']) +rc, out, err = utils.execCmd([constants.EXT_HOSTNAME, '--fqdn']) if rc: raise HostNameException(rc) else: -- To view, visit http://gerrit.ovirt.org/37621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: report a gateway for statically configured networks
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: report a gateway for statically configured networks .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15492/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14689/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15661/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2601/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/467/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b8c789cf393fbb9aa9d040c38d2c9d9f281864 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Lior Vernia Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: remove a broken approach to unmanaging devices...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: remove a broken approach to unmanaging devices by NetworkManager .. Patch Set 2: (1 comment) What "now" means. http://gerrit.ovirt.org/#/c/37041/2//COMMIT_MSG Commit Message: Line 10: dnsmasq and dhclient on the respective sides) it was previously enough to set Line 11: an address on the client side to stop NetworkManager from running its own Line 12: dhclient on it. Line 13: Line 14: Now this approach is useless. On the server side, NetworkManager automatically > what do you mean by "Now"? A year ago, when writing testDhclientLeases, not really aware of NM_CONTROLLED=no yet, I invented the original hack to assign an address to the client side of the veth pair so NetworkManager would not run dhclient on it. I did not worry about the server (dnsmasq) side but I kind of remember it was getting an address. Back then I verified the functionality on Fedora 20 and RHEL 6.5, now I test on RHEL 7 so there was a major change in NetworkManager. I don't think it's necessary to pinpoint the version of NM that allowed this hack but ask me if you think it is :-) http://gerrit.ovirt.org/#/c/23098/ Line 15: takes the veth up, so we cannot even assign an address to it, and the test is Line 16: skipped. Line 17: Line 18: Let's remove the broken code now. -- To view, visit http://gerrit.ovirt.org/37041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba14753bf9cd37ec1659a49ba7e13b9478f3913 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: remove a broken approach to unmanaging devices...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: remove a broken approach to unmanaging devices by NetworkManager .. Patch Set 3: Code-Review-1 Restoring visibility, see my answer to commit message in revision 2. -- To view, visit http://gerrit.ovirt.org/37041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba14753bf9cd37ec1659a49ba7e13b9478f3913 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: also check we successfully report an IPv4 gateway
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: also check we successfully report an IPv4 gateway .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15493/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14690/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15662/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2602/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/468/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00e3ec616453cfbc5957eb917e6e083099d9668 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _get_gateway: reformat a list comprehension for readability
oVirt Jenkins CI Server has posted comments on this change. Change subject: _get_gateway: reformat a list comprehension for readability .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15494/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14691/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15663/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2603/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/469/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9621f23669002631a67dc16941b829b517c4e017 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: remove the unused function 'routeList'
Ondřej Svoboda has uploaded a new change for review. Change subject: ipwrapper: remove the unused function 'routeList' .. ipwrapper: remove the unused function 'routeList' Change-Id: If6fbc66b754a433b051528d9fe575afc7c6b3f16 Signed-off-by: Ondřej Svoboda --- M lib/vdsm/ipwrapper.py 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/37622/1 diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py index e7aac55..2b7d455 100644 --- a/lib/vdsm/ipwrapper.py +++ b/lib/vdsm/ipwrapper.py @@ -527,11 +527,6 @@ return output -def routeList(): -command = [_IP_BINARY.cmd, 'route'] -return _execCmd(command) - - def routeShowGateways(table): command = [_IP_BINARY.cmd, 'route', 'show', 'to', '0.0.0.0/0', 'table', table] -- To view, visit http://gerrit.ovirt.org/37622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If6fbc66b754a433b051528d9fe575afc7c6b3f16 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: do not report DHCP from (typically still valid) leases
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: do not report DHCP from (typically still valid) leases .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15495/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14692/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15664/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2604/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/470/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: do not report DHCP from (typically still valid) leases
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: do not report DHCP from (typically still valid) leases .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15496/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14693/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15665/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2605/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/471/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make MBPS_TO_BPS a module constant
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make MBPS_TO_BPS a module constant .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2334/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15497/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14694/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15666/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/472/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff2d9f5f0b0c22efeb897d4b87a40415093b445 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make _getNicStats a function
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make _getNicStats a function .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2335/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15498/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14695/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15667/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/473/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia191fce7a1f3330013a621d97038bb32fd3cd563 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster.hostname: simplify by using a constant for the 'host...
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster.hostname: simplify by using a constant for the 'hostname' executable .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15499/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14696/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15668/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/474/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [wip] hornetq changes
Yaniv Bronhaim has posted comments on this change.
Change subject: [wip] hornetq changes
..
Patch Set 1:
(4 comments)
http://gerrit.ovirt.org/#/c/36361/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-12-23 17:29:34 +0100
Line 4: Commit: pkliczewski
Line 5: CommitDate: 2014-12-23 17:31:44 +0100
Line 6:
Line 7: [wip] hornetq changes
i don't understand how hornetq is being used here?..
Line 8:
Line 9:
Line 10: Change-Id: I9892acc1cf27055a381ce92ea95801250500e9ee
http://gerrit.ovirt.org/#/c/36361/1/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:
Line 162:
Line 163: def reply(self, message,
destination=_DEFAULT_RESPONSE_DESTINATION):
Line 164: self.log.debug("Sending response")
Line 165: if self._dest is not None:
Line 166: destination = self._dest
its a bit weird to expect the function to use the parameter it gets but instead
replace it with an attribute if exists..
what can set self._dest anyway?
Line 167: res = stomp.Frame(stomp.Command.MESSAGE,
Line 168: {"destination": destination,
Line 169:"content-type": "application/json"},
Line 170: message)
http://gerrit.ovirt.org/#/c/36361/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 85: self.channelListener = Listener(self.log)
Line 86: self._generationID = str(uuid.uuid4())
Line 87: self.mom = None
Line 88: self.bindings = {}
Line 89: self._client = None
another client? what client?
Line 90: if _glusterEnabled:
Line 91: self.gluster = gapi.GlusterApi(self, log)
Line 92: else:
Line 93: self.gluster = None
Line 216: reactor = json_binding.createStompReactor()
Line 217: try:
Line 218: from yajsonrpc import JsonRpcClient
Line 219: stomp_client = reactor.createClient(
Line 220: self.create_socket('192.168.1.31', 61613))
what is this hard-coded address?
Line 221: json_binding._onAccept(None, stomp_client)
Line 222: self._client = JsonRpcClient(stomp_client,
'jms.queue.reponses',
Line 223: 'jms.queue.requests')
Line 224: except:
--
To view, visit http://gerrit.ovirt.org/36361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9892acc1cf27055a381ce92ea95801250500e9ee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: remove a broken approach to unmanaging devices...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: remove a broken approach to unmanaging devices by NetworkManager .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15500/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14697/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15669/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2606/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/475/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba14753bf9cd37ec1659a49ba7e13b9478f3913 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing veths using ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing veths using NM_CONTROLLED=no .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15501/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14698/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15670/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2607/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/476/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: remove the unused function 'routeList'
oVirt Jenkins CI Server has posted comments on this change. Change subject: ipwrapper: remove the unused function 'routeList' .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15502/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14699/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15671/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2608/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/477/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6fbc66b754a433b051528d9fe575afc7c6b3f16 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: remove the unused function 'routeList'
Ondřej Svoboda has posted comments on this change. Change subject: ipwrapper: remove the unused function 'routeList' .. Patch Set 1: Verified+1 Apparently the function was never used, it was added (in http://gerrit.ovirt.org/15335) as a side product of the development of http://www.ovirt.org/Features/Multiple_Gateways -- To view, visit http://gerrit.ovirt.org/37622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6fbc66b754a433b051528d9fe575afc7c6b3f16 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: do not report DHCP from (typically still valid) leases
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: do not report DHCP from (typically still valid) leases .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14700/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15672/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2609/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/478/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: Adopt new API for retrieving the image path
Adam Litke has uploaded a new change for review. Change subject: sdm: Adopt new API for retrieving the image path .. sdm: Adopt new API for retrieving the image path Change-Id: I3f2483d9aff19c82fc33377532d132683435a36b Signed-off-by: Adam Litke --- M vdsm/storage/sdm/filestore.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/37631/1 diff --git a/vdsm/storage/sdm/filestore.py b/vdsm/storage/sdm/filestore.py index 601dfa1..ab170f6 100644 --- a/vdsm/storage/sdm/filestore.py +++ b/vdsm/storage/sdm/filestore.py @@ -42,8 +42,8 @@ # in-memory lock for concurrent operations domain.acquireClusterLock(hostId) # FIXME: acquire in-memory image lock try: -imgPath = image.getImagePath(domain.getRepoPath(), - domain.sdUUID, imgUUID) +imgPath = image.Image(domain._getRepoPath()).getImageDir( +domain.sdUUID, imgUUID) domain.oop.os.mkdir(imgPath) volTmpPath = os.path.join(imgPath, volTmpName) domain.oop.truncateFile(volTmpPath, size, mode=0o660, creatExcl=True) -- To view, visit http://gerrit.ovirt.org/37631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f2483d9aff19c82fc33377532d132683435a36b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: Allow query of task information on SDM hosts
Adam Litke has uploaded a new change for review.
Change subject: sdm: Allow query of task information on SDM hosts
..
sdm: Allow query of task information on SDM hosts
Change-Id: I77ada3dc2707bca0198dac87a1e87a48bd4a9b1c
Signed-off-by: Adam Litke
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/storage/hsm.py
4 files changed, 34 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/37633/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 2821028..adbcdde 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1281,7 +1281,10 @@
return 0, ''
def getAllTasksInfo(self, args):
-status = self.s.getAllTasksInfo()
+spUUID = None
+if len(args) > 0:
+spUUID = args[0]
+status = self.s.getAllTasksInfo(spUUID)
if status['status']['code']:
return status['status']['code'], status['status']['message']
for t, inf in status['allTasksInfo'].iteritems():
@@ -1305,7 +1308,10 @@
return 0, ''
def getAllTasksStatuses(self, args):
-status = self.s.getAllTasksStatuses()
+spUUID = None
+if len(args) > 0:
+spUUID = args[0]
+status = self.s.getAllTasksStatuses(spUUID)
if status['status']['code']:
return status['status']['code'], status['status']['message']
print status # TODO
@@ -2543,7 +2549,7 @@
'get async task info'
)),
'getAllTasksInfo': (serv.getAllTasksInfo,
-('',
+('[spUUID]',
'get info of all async tasks'
)),
'getTaskStatus': (serv.getTaskStatus,
@@ -2551,7 +2557,7 @@
'get task status'
)),
'getAllTasksStatuses': (serv.getAllTasksStatuses,
-('',
+('[spUUID]',
'list statuses of all async tasks'
)),
'getAllTasks': (serv.getAllTasks,
diff --git a/vdsm/API.py b/vdsm/API.py
index 9e9010b..792d075 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1621,11 +1621,11 @@
def getDevicesVisibility(self, guidList):
return self._irs.getDevicesVisibility(guidList)
-def getAllTasksInfo(self):
-return self._irs.getAllTasksInfo()
+def getAllTasksInfo(self, spUUID=None):
+return self._irs.getAllTasksInfo(spUUID)
-def getAllTasksStatuses(self):
-return self._irs.getAllTasksStatuses()
+def getAllTasksStatuses(self, spUUID=None):
+return self._irs.getAllTasksStatuses(spUUID)
def getAllTasks(self):
return self._irs.getAllTasks()
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index a78a6d5..08911c7 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -917,13 +917,13 @@
return task.stop()
# Global storage methods
-def tasksGetAllInfo(self):
+def tasksGetAllInfo(self, spUUID=None):
api = API.Global()
-return api.getAllTasksInfo()
+return api.getAllTasksInfo(spUUID)
-def tasksGetAllStatuses(self):
+def tasksGetAllStatuses(self, spUUID=None):
api = API.Global()
-return api.getAllTasksStatuses()
+return api.getAllTasksStatuses(spUUID)
def tasksGetAll(self, options=None):
api = API.Global()
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index d3da4d5..dfc72e6 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2195,11 +2195,14 @@
:options: ?
"""
# getSharedLock(tasksResource...)
-try:
-sp = self.pools.values()[0]
-except IndexError:
-raise se.SpmStatusError()
-allTasksStatus = sp.getAllTasksStatuses()
+if spUUID == volume.BLANK_UUID:
+allTasksStatus = self.taskMng.getAllTasksStatuses('sdm')
+else:
+try:
+sp = self.pools.values()[0]
+except IndexError:
+raise se.SpmStatusError()
+allTasksStatus = sp.getAllTasksStatuses()
return dict(allTasksStatus=allTasksStatus)
@public
@@ -2237,11 +2240,14 @@
:rtype: dict
"""
# getSharedLock(tasksResource...)
-try:
-sp = self.pools.values()[0]
-except IndexError:
-raise se.SpmStatusError()
-allTasksInfo = sp.getAllTasksInfo()
+if spUUID == volume.BLANK_UUID:
+allTasksInfo = self.taskMng.getAllTasksInfo('sdm')
+else:
+try:
+sp = self.pools.values()[0]
+except IndexError:
+raise se.SpmStatusError()
+allTasksInfo = sp.get
Change in vdsm[master]: sdm: createVolumeV2 does not return a task
Adam Litke has uploaded a new change for review. Change subject: sdm: createVolumeV2 does not return a task .. sdm: createVolumeV2 does not return a task Change-Id: Ib4f78d9650a72215e354280a84dd9f02d488753e Signed-off-by: Adam Litke --- M client/vdsClient.py 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/37629/1 diff --git a/client/vdsClient.py b/client/vdsClient.py index 089c2e1..2821028 100644 --- a/client/vdsClient.py +++ b/client/vdsClient.py @@ -1072,14 +1072,14 @@ srcImgUUID = args[6] if len(args) > 7 else BLANK_UUID srcVolUUID = args[7] if len(args) > 8 else BLANK_UUID -image = self.s.createVolumeV2( +res = self.s.createVolumeV2( sdUUID, imgUUID, newVolUUID, int(diskSize), int(volFormat), description, srcImgUUID, srcVolUUID) -if image['status']['code']: -return image['status']['code'], image['status']['message'] +if res['status']['code']: +return res['status']['code'], res['status']['message'] -return 0, image['uuid'] +return 0, '' def allocateVolume(self, args): sdUUID, imgUUID, volUUID = args -- To view, visit http://gerrit.ovirt.org/37629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4f78d9650a72215e354280a84dd9f02d488753e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: add the allocateVolume command
Adam Litke has uploaded a new change for review.
Change subject: sdm: add the allocateVolume command
..
sdm: add the allocateVolume command
Change-Id: Id3db76e9e27f8f5bed5ebcb1d217ab94ec782070
Signed-off-by: Federico Simoncelli
---
M client/vdsClient.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/storage/hsm.py
M vdsm/storage/sdm/__init__.py
5 files changed, 43 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/37627/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index a347b48..089c2e1 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1081,6 +1081,13 @@
return 0, image['uuid']
+def allocateVolume(self, args):
+sdUUID, imgUUID, volUUID = args
+image = self.s.allocateVolume(sdUUID, imgUUID, volUUID)
+if image['status']['code']:
+return image['status']['code'], image['status']['message']
+return 0, image['uuid']
+
def getVolumeInfo(self, args):
sdUUID = args[0]
spUUID = args[1]
@@ -2458,6 +2465,10 @@
' ',
'Creates new volume or snapshot'
)),
+'allocateVolume': (serv.allocateVolume, (
+' ',
+'Preallocates a volume or snapshot'
+)),
'extendVolumeSize': (serv.extendVolumeSize, (
'',
'Extend the volume size (virtual disk size seen by the guest).',
diff --git a/vdsm/API.py b/vdsm/API.py
index 013e821..9e9010b 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -798,6 +798,10 @@
self._UUID, size, volFormat,
description, srcImgUUID, srcVolUUID)
+def allocate(self):
+return self._irs.allocateVolume(self._sdUUID, self._imgUUID,
+self._UUID)
+
def delete(self, postZero, force):
return self._irs.deleteVolume(self._sdUUID, self._spUUID,
self._imgUUID, [self._UUID], postZero,
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index 21535ad..a78a6d5 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -863,6 +863,10 @@
return volume.createV2(size, volFormat, description, srcImgUUID,
srcVolUUID)
+def volumeAllocate(self, sdUUID, imgUUID, volUUID):
+volume = API.Volume(volUUID, None, sdUUID, imgUUID)
+return volume.allocate()
+
def volumeExtendSize(self, spUUID, sdUUID, imgUUID, volUUID, newSize):
volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID)
return volume.extendSize(newSize)
@@ -1133,7 +1137,8 @@
'storageServer_ConnectionRefs_release'),
(self.storageServerConnectionRefsStatuses,
'storageServer_ConnectionRefs_statuses'),
-(self.volumeCreateV2, 'createVolumeV2'),)
+(self.volumeCreateV2, 'createVolumeV2'),
+(self.volumeAllocate, 'allocateVolume'),)
def wrapApiMethod(f):
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 3fabf2e..d3da4d5 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3666,6 +3666,9 @@
rm.LockType.exclusive):
self.domainMonitor.stopMonitoring([sdUUID])
+def _sdmSchedule(self, name, func, *args):
+self.taskMng.scheduleJob("sdm", None, vars.task, name, func, *args)
+
@public
def getHostLeaseStatus(self, domains):
"""
@@ -3688,3 +3691,8 @@
domain.validateCreateVolumeParams(volFormat, srcVolUUID)
return sdm.createVolume(domain, imgUUID, volUUID, size, volFormat,
description, srcImgUUID, srcVolUUID)
+
+@public
+def allocateVolume(self, sdUUID, imgUUID, volUUID):
+self._sdmSchedule('allocateVolume', sdm.allocateVolume, sdUUID,
+ imgUUID, volUUID)
diff --git a/vdsm/storage/sdm/__init__.py b/vdsm/storage/sdm/__init__.py
index 11f7ed0..976a007 100644
--- a/vdsm/storage/sdm/__init__.py
+++ b/vdsm/storage/sdm/__init__.py
@@ -43,3 +43,17 @@
return __getStoreModule(domain).createVolume(
domain, imgUUID, volUUID, size, volFormat, desc, srcImgUUID,
srcVolUUID)
+
+
+def allocateVolume(sdUUID, imgUUID, volUUID, wipeData):
+if wipeData is not True:
+raise NotImplementedError("Keeping old data is not supported")
+
+domain = sdCache.produce(sdUUID)
+
+# TODO: pass the sanlock lease to the allocating process
+sanlock.acquire(sdUUID, volUUID, [(leasePath, leaseOffset)])
+try:
+pass
+finally:
+sanlock.release(sdUUID, volUUID, [(leasePath, leaseOffset)])
--
To view, visit http://gerrit.ovirt.org/37627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3db76e9e27
Change in vdsm[master]: sdm: Fix cleanup for raw block volumes
Adam Litke has uploaded a new change for review. Change subject: sdm: Fix cleanup for raw block volumes .. sdm: Fix cleanup for raw block volumes Change-Id: I1bc16afef75a6b4b9fd350ed83a0f86a79bb9622 Signed-off-by: Adam Litke --- M vdsm/storage/sdm/blockstore.py 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/37632/1 diff --git a/vdsm/storage/sdm/blockstore.py b/vdsm/storage/sdm/blockstore.py index f851051..ceb1a2b 100644 --- a/vdsm/storage/sdm/blockstore.py +++ b/vdsm/storage/sdm/blockstore.py @@ -77,6 +77,8 @@ qemuimg.create(volTmpPath, sizeBytes, volume.fmt2str(volFormat), backingVolPath, volume.fmt2str(backingVolFormat)) +else: +volTmpPath = None metaId = (domain.sdUUID, mdSlot) @@ -97,7 +99,8 @@ lvm.renameLV(domain.sdUUID, volTmpName, volUUID) finally: # TODO: refactor and improve (errors) this part -os.unlink(volTmpPath) +if volTmpPath: +os.unlink(volTmpPath) lvm.deactivateLVs(domain.sdUUID, (volTmpName, volUUID)) domain.releaseClusterLock() -- To view, visit http://gerrit.ovirt.org/37632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1bc16afef75a6b4b9fd350ed83a0f86a79bb9622 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Comment out broken partial code
Adam Litke has uploaded a new change for review.
Change subject: Comment out broken partial code
..
Comment out broken partial code
Change-Id: I4f09f958635ead02946ac84e854505f0c3d0ea24
Signed-off-by: Adam Litke
---
M vdsm/storage/sdm/__init__.py
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/37628/1
diff --git a/vdsm/storage/sdm/__init__.py b/vdsm/storage/sdm/__init__.py
index 976a007..1e3a5bb 100644
--- a/vdsm/storage/sdm/__init__.py
+++ b/vdsm/storage/sdm/__init__.py
@@ -49,11 +49,11 @@
if wipeData is not True:
raise NotImplementedError("Keeping old data is not supported")
-domain = sdCache.produce(sdUUID)
+# domain = sdCache.produce(sdUUID)
# TODO: pass the sanlock lease to the allocating process
-sanlock.acquire(sdUUID, volUUID, [(leasePath, leaseOffset)])
-try:
-pass
-finally:
-sanlock.release(sdUUID, volUUID, [(leasePath, leaseOffset)])
+# sanlock.acquire(sdUUID, volUUID, [(leasePath, leaseOffset)])
+# try:
+# pass
+# finally:
+# sanlock.release(sdUUID, volUUID, [(leasePath, leaseOffset)])
--
To view, visit http://gerrit.ovirt.org/37628
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f09f958635ead02946ac84e854505f0c3d0ea24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: fix the getHostId interface to DomainMonitor
Adam Litke has uploaded a new change for review.
Change subject: sdm: fix the getHostId interface to DomainMonitor
..
sdm: fix the getHostId interface to DomainMonitor
Change-Id: I13d0586c6ed514fb6798ef96320380f80b6a1f06
Signed-off-by: Adam Litke
---
M vdsm/storage/monitor.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/37630/1
diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index 4fb4b01..8d9615d 100644
--- a/vdsm/storage/monitor.py
+++ b/vdsm/storage/monitor.py
@@ -130,7 +130,7 @@
return status
def getHostId(self, sdUUID):
-return self._domains[sdUUID].hostId
+return self._monitors[sdUUID].hostId
def close(self):
self.log.info("Stop monitoring all domains")
--
To view, visit http://gerrit.ovirt.org/37630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13d0586c6ed514fb6798ef96320380f80b6a1f06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: introduce the new createVolume command
Adam Litke has uploaded a new change for review.
Change subject: sdm: introduce the new createVolume command
..
sdm: introduce the new createVolume command
Change-Id: I297f99caf6b470bd6916068e97d0063f53583c48
Signed-off-by: Federico Simoncelli
---
M client/vdsClient.py
M configure.ac
M vdsm.spec.in
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/storage/Makefile.am
M vdsm/storage/hsm.py
M vdsm/storage/monitor.py
A vdsm/storage/sdm/Makefile.am
A vdsm/storage/sdm/__init__.py
A vdsm/storage/sdm/blockstore.py
A vdsm/storage/sdm/filestore.py
A vdsm/storage/sdm/utils.py
13 files changed, 325 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/37626/1
diff --git a/client/vdsClient.py b/client/vdsClient.py
index 07dbaa2..a347b48 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1065,6 +1065,22 @@
return image['status']['code'], image['status']['message']
return 0, image['uuid']
+def createVolumeV2(self, args):
+sdUUID, imgUUID, newVolUUID, \
+diskSize, volFormat, description = args[:6]
+
+srcImgUUID = args[6] if len(args) > 7 else BLANK_UUID
+srcVolUUID = args[7] if len(args) > 8 else BLANK_UUID
+
+image = self.s.createVolumeV2(
+sdUUID, imgUUID, newVolUUID, int(diskSize), int(volFormat),
+description, srcImgUUID, srcVolUUID)
+
+if image['status']['code']:
+return image['status']['code'], image['status']['message']
+
+return 0, image['uuid']
+
def getVolumeInfo(self, args):
sdUUID = args[0]
spUUID = args[1]
@@ -2437,6 +2453,11 @@
' ',
'Creates new volume or snapshot'
)),
+'createVolumeV2': (serv.createVolumeV2, (
+' '
+' ',
+'Creates new volume or snapshot'
+)),
'extendVolumeSize': (serv.extendVolumeSize, (
'',
'Extend the volume size (virtual disk size seen by the guest).',
diff --git a/configure.ac b/configure.ac
index c3dfea4..74fa86e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -371,6 +371,7 @@
vdsm/storage/Makefile
vdsm/storage/imageRepository/Makefile
vdsm/storage/protect/Makefile
+ vdsm/storage/sdm/Makefile
vdsm/storage/vdsm_lvm_rules.template
vdsm/virt/Makefile
vdsm/virt/vmdevices/Makefile
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 6c8f781..6038bf3 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1175,6 +1175,10 @@
%{_datadir}/%{vdsm_name}/storage/volume.py*
%{_datadir}/%{vdsm_name}/storage/imageRepository/__init__.py*
%{_datadir}/%{vdsm_name}/storage/imageRepository/formatConverter.py*
+%{_datadir}/%{vdsm_name}/storage/sdm/__init__.py*
+%{_datadir}/%{vdsm_name}/storage/sdm/blockstore.py*
+%{_datadir}/%{vdsm_name}/storage/sdm/filestore.py*
+%{_datadir}/%{vdsm_name}/storage/sdm/utils.py*
%{_libexecdir}/%{vdsm_name}/safelease
%{_libexecdir}/%{vdsm_name}/spmprotect.sh
%{_libexecdir}/%{vdsm_name}/spmstop.sh
diff --git a/vdsm/API.py b/vdsm/API.py
index c23b94d..013e821 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -793,6 +793,11 @@
preallocate, diskType, self._UUID, desc,
srcImgUUID, srcVolUUID)
+def createV2(self, size, volFormat, description, srcImgUUID, srcVolUUID):
+return self._irs.createVolumeV2(self._sdUUID, self._imgUUID,
+self._UUID, size, volFormat,
+description, srcImgUUID, srcVolUUID)
+
def delete(self, postZero, force):
return self._irs.deleteVolume(self._sdUUID, self._spUUID,
self._imgUUID, [self._UUID], postZero,
diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py
index b01b661..21535ad 100644
--- a/vdsm/rpc/BindingXMLRPC.py
+++ b/vdsm/rpc/BindingXMLRPC.py
@@ -856,6 +856,13 @@
return volume.create(size, volFormat, preallocate, diskType, desc,
srcImgUUID, srcVolUUID)
+def volumeCreateV2(self, sdUUID, imgUUID, volUUID, size, volFormat,
+ description, srcImgUUID=API.Image.BLANK_UUID,
+ srcVolUUID=API.Volume.BLANK_UUID):
+volume = API.Volume(volUUID, None, sdUUID, imgUUID)
+return volume.createV2(size, volFormat, description, srcImgUUID,
+ srcVolUUID)
+
def volumeExtendSize(self, spUUID, sdUUID, imgUUID, volUUID, newSize):
volume = API.Volume(volUUID, spUUID, sdUUID, imgUUID)
return volume.extendSize(newSize)
@@ -1125,7 +1132,8 @@
(self.storageServerConnectionRefsRelease,
'storageServer_ConnectionRefs_release'),
(self.storageServerConnectionRefsStatu
Change in vdsm[master]: sdm: introduce the new createVolume command
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: introduce the new createVolume command .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/430/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/423/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15504/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/988/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14701/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15673/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/479/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/971/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I297f99caf6b470bd6916068e97d0063f53583c48 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: add the allocateVolume command
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: add the allocateVolume command .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14702/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15674/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/480/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3db76e9e27f8f5bed5ebcb1d217ab94ec782070 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Comment out broken partial code
oVirt Jenkins CI Server has posted comments on this change. Change subject: Comment out broken partial code .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14703/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15675/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/481/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f09f958635ead02946ac84e854505f0c3d0ea24 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: createVolumeV2 does not return a task
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: createVolumeV2 does not return a task .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15507/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14704/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15676/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/482/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4f78d9650a72215e354280a84dd9f02d488753e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: fix the getHostId interface to DomainMonitor
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: fix the getHostId interface to DomainMonitor .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15508/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14705/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15677/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/483/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13d0586c6ed514fb6798ef96320380f80b6a1f06 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: Adopt new API for retrieving the image path
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: Adopt new API for retrieving the image path .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15509/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14706/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15678/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/484/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2483d9aff19c82fc33377532d132683435a36b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: Fix cleanup for raw block volumes
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: Fix cleanup for raw block volumes .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15510/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14707/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15679/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/485/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bc16afef75a6b4b9fd350ed83a0f86a79bb9622 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sdm: Allow query of task information on SDM hosts
oVirt Jenkins CI Server has posted comments on this change. Change subject: sdm: Allow query of task information on SDM hosts .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15511/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14708/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15680/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/486/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77ada3dc2707bca0198dac87a1e87a48bd4a9b1c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dnsmasqDhcp: fix an inverted condition
Ondřej Svoboda has uploaded a new change for review. Change subject: dnsmasqDhcp: fix an inverted condition .. dnsmasqDhcp: fix an inverted condition Anywhere _except_ EL6 we want to use dnsmasq with --bind-dynamic. Change-Id: I4fdc2ad5e173f7627be213bb40878293c373a530 Signed-off-by: Ondřej Svoboda --- M tests/functional/networkTests.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/37635/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index 37feeb2..93c2d4e 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -114,7 +114,7 @@ (None, None) if el6 else (DHCPv6_RANGE_FROM, DHCPv6_RANGE_TO)) dhcpServer.start(interface, DHCP_RANGE_FROM, DHCP_RANGE_TO, dhcpv6_range_from, dhcpv6_range_to, router=IP_GATEWAY, - bind_dynamic=el6) + bind_dynamic=not el6) except dhcp.DhcpError as e: raise SkipTest(e) -- To view, visit http://gerrit.ovirt.org/37635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4fdc2ad5e173f7627be213bb40878293c373a530 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dnsmasqDhcp: fix an inverted condition
oVirt Jenkins CI Server has posted comments on this change. Change subject: dnsmasqDhcp: fix an inverted condition .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15512/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14709/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15681/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2610/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/487/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdc2ad5e173f7627be213bb40878293c373a530 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: _bridges_ should be among devices with active DHCP ...
Ondřej Svoboda has uploaded a new change for review.
Change subject: netinfo: _bridges_ should be among devices with active DHCP
leases
..
netinfo: _bridges_ should be among devices with active DHCP leases
I don't understand how testSetupNetworksAddDelDhcp can pass.
Change-Id: I6e6d9dc729bed6e395c5b13b1a779b4acc95
Signed-off-by: Ondřej Svoboda
---
M lib/vdsm/netinfo.py
1 file changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/37636/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 6ddfdce..656a805 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -420,7 +420,8 @@
in sorted(opts.iteritems(
-def _getNetInfo(iface, bridged, routes, ipaddrs, dhcpv4_ifaces, dhcpv6_ifaces):
+def _getNetInfo(network, iface, bridged, routes, ipaddrs, dhcpv4_ifaces,
+dhcpv6_ifaces):
'''Returns a dictionary of properties about the network's interface status.
Raises a KeyError if the iface does not exist.'''
data = {}
@@ -434,11 +435,12 @@
# comment when the version is no longer supported.
data['interface'] = iface
+net_device = network if bridged else iface
ipv4addr, ipv4netmask, ipv4addrs, ipv6addrs = getIpInfo(iface, ipaddrs)
data.update({'iface': iface, 'bridged': bridged,
'addr': ipv4addr, 'netmask': ipv4netmask,
- 'dhcpv4': iface in dhcpv4_ifaces,
- 'dhcpv6': iface in dhcpv6_ifaces,
+ 'dhcpv4': net_device in dhcpv4_ifaces,
+ 'dhcpv6': net_device in dhcpv6_ifaces,
'ipv4addrs': ipv4addrs,
'ipv6addrs': ipv6addrs,
'gateway': _get_gateway(routes, iface),
@@ -647,8 +649,9 @@
d = {}
for net, netAttr in nets.iteritems():
try:
-d[net] = _getNetInfo(netAttr.get('iface', net), netAttr['bridged'],
- routes, ipAddrs, dhcpv4_ifaces, dhcpv6_ifaces)
+d[net] = _getNetInfo(net, netAttr.get('iface', net),
+ netAttr['bridged'], routes, ipAddrs,
+ dhcpv4_ifaces, dhcpv6_ifaces)
except KeyError:
continue # Do not report missing libvirt networks.
return d
--
To view, visit http://gerrit.ovirt.org/37636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e6d9dc729bed6e395c5b13b1a779b4acc95
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: _bridges_ should be among devices with active DHCP ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: _bridges_ should be among devices with active DHCP leases .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15513/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14710/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15682/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2611/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/488/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e6d9dc729bed6e395c5b13b1a779b4acc95 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: do not report DHCP from (typically still valid) leases
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: do not report DHCP from (typically still valid) leases .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15514/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14711/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15683/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2612/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/489/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: _bridges_ should be among devices with active DHCP ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: _bridges_ should be among devices with active DHCP leases .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15515/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14712/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15684/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2613/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/490/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e6d9dc729bed6e395c5b13b1a779b4acc95 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot list verb.
Darshan N has posted comments on this change.
Change subject: gluster: volume snapshot list verb.
..
Patch Set 14:
(6 comments)
http://gerrit.ovirt.org/#/c/36087/14//COMMIT_MSG
Commit Message:
Line 13: present in a volume if volume name is provided. Else It gives
Line 14: list of all snapshot across the cluster
Line 15: Returns:
Line 16: {'v1': {'snapshots': [{'snapshotName': 'snap1_v1',
Line 17:'napDscription': description of the snapshot,
> Fix this typo. Why is 'description' changed to 'snapDescription'?
Done
Line 18:'snapshotUuid': '8add41ae-c60c-4023-'
Line 19:'a1a6-5093a5d35603',
Line 20:'createTime': '2014-10-27 16:25:03',
Line 21:'snapVolume': '5eeaf23def3f446d898e1de8461a6aa7'
http://gerrit.ovirt.org/#/c/36087/14/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Line 1222: """
Line 1223: {'v1': {'snapshots': [{'snapshotName': 'snap1_v1',
Line 1224:'snapDescription': description of the
snapshot,
Line 1225:'snapshotUuid': '8add41ae-c60c-4023'
Line 1226:'-a1a6-5093a5d35603',
> How abt having these as 'name', 'description', 'id' to have similarity with
Done
Line 1227:'createTime': '2014-10-27 16:25:03',
Line 1228:'snapVolume':
'5eeaf23def3f446d898e1de8461a6aa7'
Line 1229:'snapVolumeStatus': 'ACTIVATED'}, ...],
Line 1230: 'snapRemaining': 252}
Line 1223: {'v1': {'snapshots': [{'snapshotName': 'snap1_v1',
Line 1224:'snapDescription': description of the
snapshot,
Line 1225:'snapshotUuid': '8add41ae-c60c-4023'
Line 1226:'-a1a6-5093a5d35603',
Line 1227:'createTime': '2014-10-27 16:25:03',
> Is it good idea to convert the time into epoch time and sending timezone al
Done
Line 1228:'snapVolume':
'5eeaf23def3f446d898e1de8461a6aa7'
Line 1229:'snapVolumeStatus': 'ACTIVATED'}, ...],
Line 1230: 'snapRemaining': 252}
Line 1231: }
Line 1246: else
el.find('description').text
Line 1247: snapshot['createTime'] = el.find('createTime').text
Line 1248: snapshot['snapVolume'] = el.find('snapVolume/name').text
Line 1249: status = el.find('snapVolume/status').text
Line 1250: if status == 'Started':
> its better to use status.upper() == 'STARTED'
Done
Line 1251: snapshot['snapVolumeStatus'] = SnapshotStatus.ACTIVATED
Line 1252: else:
Line 1253: snapshot['snapVolumeStatus'] = SnapshotStatus.DEACTIVATED
Line 1254: snapshot['snapshotName'] = el.find('name').text
Line 1276: 'snapRemaining': 252},...
Line 1277: }
Line 1278: """
Line 1279: volumes = {}
Line 1280: if tree.find('snapInfo/count').text == 0:
> int() is missing
Done
Line 1281: return {}
Line 1282: for el in tree.findall('snapInfo/snapshots/snapshot'):
Line 1283: snapshot = {}
Line 1284: snapshot['snapshotUuid'] = el.find('uuid').text
Line 1298: 'snapRemaining': el.find(
Line 1299: 'snapVolume/originVolume/snapRemaining').text,
Line 1300: 'snapshots': []
Line 1301: }
Line 1302: volumes[volumeName]['snapshots'].append(snapshot)
> same as above
Done
Line 1303: return volumes
Line 1304:
Line 1305:
Line 1306: @makePublic
--
To view, visit http://gerrit.ovirt.org/36087
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06945d6781432b7fb40e417dd21c0ecf107de132
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Shubhendu Tripathi
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot list verb.
Darshan N has posted comments on this change. Change subject: gluster: volume snapshot list verb. .. Patch Set 16: Verified+1 -- To view, visit http://gerrit.ovirt.org/36087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06945d6781432b7fb40e417dd21c0ecf107de132 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: volume snapshot list verb.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot list verb. .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/431/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/424/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15516/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/989/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14713/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15685/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/491/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/972/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/36087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06945d6781432b7fb40e417dd21c0ecf107de132 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Shubhendu Tripathi Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
