Change in vdsm[master]: dnsmasqDhcp: fix an inverted condition
Dan Kenigsberg has submitted this change and it was merged. Change subject: dnsmasqDhcp: fix an inverted condition .. dnsmasqDhcp: fix an inverted condition Anywhere _except_ EL6 we want to use dnsmasq with --bind-dynamic. Change-Id: I4fdc2ad5e173f7627be213bb40878293c373a530 Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37635 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/functional/networkTests.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondřej Svoboda: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fdc2ad5e173f7627be213bb40878293c373a530 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: report a gateway for statically configured networks
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: report a gateway for statically configured networks .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/619/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/219/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4603/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/596/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6442/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/223/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/621/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/222/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/208/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/615/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b8c789cf393fbb9aa9d040c38d2c9d9f281864 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Lior Vernia lver...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4605 - Failure!
we are enforcing pyflakes latests version via puppet class: vdsm_test_runner.pp barak - please check that the relevant slave on the hostgroup is getting that and updating to a version higher than pyflakes-0.8.1-3.el6.noarch.rpm e. - Original Message - From: Dan Kenigsberg dan...@redhat.com To: Jenkins ci oVirt Server jenk...@ovirt.org Cc: ee...@redhat.com, vdsm-patches@lists.fedorahosted.org, dc...@redhat.com, nsof...@redhat.com Sent: Tuesday, February 10, 2015 5:01:44 PM Subject: Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4605 - Failure! On Tue, Feb 10, 2015 at 02:19:59PM +, Jenkins ci oVirt Server wrote: Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4605/ Build Number: 4605 Build Status: Failure Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/37456 Haven't we already installed newer pyflakes (such as http://danken.fedorapeople.org/pyflakes-0.8.1-3.el6.noarch.rpm) on our slaves? We should. 14:19:47 pyflakes-0.4.0 14:19:47 ( find . -path './.git' -prune -type f -o \ 14:19:47-path './vdsm_compat' -prune -type f -o \ 14:19:47-name '*.py' -o -name '*.py.in' \ 14:19:47echo contrib/profile-stats init/daemonAdapter vdsm/get-conf-item vdsm/set-conf-item vdsm/supervdsmServer vdsm/vdsm vdsm/vdsm-restore-net-config vdsm/storage/curl-img-wrap vdsm/storage/fc-scan vdsm-tool/vdsm-tool vds_bootstrap/setup vdsm_reg/vdsm-reg-setup.in ) | xargs /usr/bin/pyflakes | \ 14:19:47grep -w -v \./vdsm/storage/lvm\.py.*: list comprehension redefines 'lv' from line .* | \ 14:19:47while read LINE; do echo $LINE; false; done 14:19:57 ./vdsm/sos/vdsm.py.in:25: redefinition of unused 'RedHatPlugin' from line 22 14:19:57 ./vdsm/sos/vdsm.py.in:25: redefinition of unused 'Plugin' from line 22 14:19:57 ./vdsm/virt/guestagent.py:140: redefinition of function 'guestDiskMapping' from line 136 14:19:57 vdsm/get-conf-item:11: redefinition of unused 'config' from line 8 14:19:57 vdsm/set-conf-item:13: redefinition of unused 'config' from line 10 14:19:58 make: *** [pyflakes] Error 1 14:19:58 Build step 'Execute shell' marked build as failure ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmchannels: downgrade logs about expected flows
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmchannels: downgrade logs about expected flows .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/620/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/220/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4604/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/597/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6443/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/224/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/622/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/223/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/209/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/616/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/34357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib041d4c844fe948523942d76236d291ecf3eb0fb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make _getNicStats a function
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make _getNicStats a function .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/622/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/222/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4606/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/599/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6445/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/226/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/624/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/225/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/211/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/618/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia191fce7a1f3330013a621d97038bb32fd3cd563 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: signals: Handle signals to non-main threads
Dan Kenigsberg has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 26: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_master_unit-tests_merged - Build # 4605 - Failure!
On Tue, Feb 10, 2015 at 02:19:59PM +, Jenkins ci oVirt Server wrote: Project: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/ Build: http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4605/ Build Number: 4605 Build Status: Failure Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/37456 Haven't we already installed newer pyflakes (such as http://danken.fedorapeople.org/pyflakes-0.8.1-3.el6.noarch.rpm) on our slaves? We should. 14:19:47 pyflakes-0.4.0 14:19:47 ( find . -path './.git' -prune -type f -o \ 14:19:47-path './vdsm_compat' -prune -type f -o \ 14:19:47-name '*.py' -o -name '*.py.in' \ 14:19:47echo contrib/profile-stats init/daemonAdapter vdsm/get-conf-item vdsm/set-conf-item vdsm/supervdsmServer vdsm/vdsm vdsm/vdsm-restore-net-config vdsm/storage/curl-img-wrap vdsm/storage/fc-scan vdsm-tool/vdsm-tool vds_bootstrap/setup vdsm_reg/vdsm-reg-setup.in ) | xargs /usr/bin/pyflakes | \ 14:19:47grep -w -v \./vdsm/storage/lvm\.py.*: list comprehension redefines 'lv' from line .* | \ 14:19:47while read LINE; do echo $LINE; false; done 14:19:57 ./vdsm/sos/vdsm.py.in:25: redefinition of unused 'RedHatPlugin' from line 22 14:19:57 ./vdsm/sos/vdsm.py.in:25: redefinition of unused 'Plugin' from line 22 14:19:57 ./vdsm/virt/guestagent.py:140: redefinition of function 'guestDiskMapping' from line 136 14:19:57 vdsm/get-conf-item:11: redefinition of unused 'config' from line 8 14:19:57 vdsm/set-conf-item:13: redefinition of unused 'config' from line 10 14:19:58 make: *** [pyflakes] Error 1 14:19:58 Build step 'Execute shell' marked build as failure ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: signals: Handle signals to non-main threads
oVirt Jenkins CI Server has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 27: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/624/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/224/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4608/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/601/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6447/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/228/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/626/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/227/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/213/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/620/ : FAILURE -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: remove a broken approach to unmanaging devices...
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: remove a broken approach to unmanaging devices by NetworkManager .. Patch Set 3: (1 comment) Please state with which NM versions the current code has been tested with. http://gerrit.ovirt.org/#/c/37041/3//COMMIT_MSG Commit Message: Line 10: dnsmasq and dhclient on the respective sides) it was previously enough to set Line 11: an address on the client side to stop NetworkManager from running its own Line 12: dhclient on it. Line 13: Line 14: Now this approach is useless. On the server side, NetworkManager automatically Could you at least specify, for future reference, which NM versions have been tested with this patch? el7 and f21's versions are mostly important Line 15: takes the veth up, so we cannot even assign an address to it, and the test is Line 16: skipped. Line 17: Line 18: Let's remove the broken code now. -- To view, visit http://gerrit.ovirt.org/37041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba14753bf9cd37ec1659a49ba7e13b9478f3913 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: signals: Handle signals to non-main threads
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 26: Removed double 'done' output on tests -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: do not report DHCP from (typically still valid) leases
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: do not report DHCP from (typically still valid) leases .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15526/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14723/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15695/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2616/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/501/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _get_gateway: allow duplicated gateways if they are in fact ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: _get_gateway: allow duplicated gateways if they are in fact the same routes .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15528/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14725/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15697/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2618/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/503/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia59155dd959e58b81e4149fa4cf2bd406f6404a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make MBPS_TO_BPS a module constant
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make MBPS_TO_BPS a module constant .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/621/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/221/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4605/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/598/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6444/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/225/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/623/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/224/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/210/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/617/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff2d9f5f0b0c22efeb897d4b87a40415093b445 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: do not report DHCP from (typically still valid) leases
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: do not report DHCP from (typically still valid) leases .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15527/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14724/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15696/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2617/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/502/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: signals: Handle signals to non-main threads
Yaniv Bronhaim has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 26: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: signals: Handle signals to non-main threads
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 26: Verified+1 verified by adding manually to engine and restarting vdsmd and supervdsmd several times, seems very responsive, the unit tests ran well, ran through the system tests framework and it ran ok as well. -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: signals: Handle signals to non-main threads
Dan Kenigsberg has submitted this change and it was merged. Change subject: signals: Handle signals to non-main threads .. signals: Handle signals to non-main threads This patch addresses an issue of signals being delayed in supervdsm, in attempt to add zombiereaper to supervdsm, zombiereaper did not receive signals it was supposed to receive. When any thread in python receives a signal, python's signal handler (running in that thread) marks the signal as received and writes down that the main thread should handle any arrived signals. When main thread calls signal.pause(), it goes to sleep until it receives a signal (on main the main thread itself). If during that time, a signal is received on any other thread, it is not handled until main thread itself receives any other signal (because of what the signal handler does) I've reported the issue here, also with a simple reproducing script: https://bugzilla.redhat.com/show_bug.cgi?id=1114434 Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Signed-off-by: Dima Kuznetsov dkuzn...@redhat.com Reviewed-on: http://gerrit.ovirt.org/29392 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M configure.ac A doc/infra/sigutils.rst M lib/vdsm/infra/Makefile.am M lib/vdsm/infra/__init__.py A lib/vdsm/infra/sigutils/Makefile.am A lib/vdsm/infra/sigutils/__init__.py A lib/vdsm/infra/sigutils/tests.py A lib/vdsm/infra/sigutils/tests_child.py M vdsm.spec.in M vdsm/supervdsmServer M vdsm/vdsm 11 files changed, 391 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Dima Kuznetsov: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dnsmasqDhcp: fix an inverted condition
oVirt Jenkins CI Server has posted comments on this change. Change subject: dnsmasqDhcp: fix an inverted condition .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/623/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/223/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4607/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/600/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6446/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/227/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/625/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/226/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/212/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/619/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdc2ad5e173f7627be213bb40878293c373a530 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: remove a broken approach to unmanaging devices...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: remove a broken approach to unmanaging devices by NetworkManager .. Patch Set 3: Dan, I found the real reason. It is (of course!) not that the veth sides are up. When NM is running it somehow sets sysctl net.ipv6.conf.veth14.disable_ipv6=1 to any veth it manages. This affects setting of an IPv6 address only so the problem only really exists for a month or so. Do you know if we can turn some knobs to enable IPv6 in NM? I am not sure that adding [ipv6] method=auto to /etc/NetworkManager/NetworkManager.conf helps. ipv6 settings in NM: https://developer.gnome.org/NetworkManager/0.9/ref-settings.html Not even putting net.ipv6.conf.all.disable_ipv6 = 0 and net.ipv6.conf.default.disable_ipv6 = 0 to /etc/sysctl.conf (which is symlinked to .d directory, of course) and rebooting to make sure (out of pure helplessness). systctl: http://wiki.centos.org/FAQ/CentOS6 Perhaps I am doing something wrong. Maybe, maybe it's a NM bug (that it seemingly ignores my configuration). But I need to replace this old hack _now_ so I can base all my work (including fixes to DHCP and gateway reporting) on the new NM_CONTROLLED=no approach. I'll try to locate a bug if it exists and as soon as most of my fixes are merged I will sit down and file the bug if it really is there. As you asked, I prepared this text to the commit message: Current NetworkManager versions (certainly require this change): 0.9.9.1-35.git20140326.4dba720.el7 and 0.9.10.1-1.4.20150115git.fc21 -- To view, visit http://gerrit.ovirt.org/37041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba14753bf9cd37ec1659a49ba7e13b9478f3913 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build gluster packages only for rhel 7 and above
Bala.FA has posted comments on this change. Change subject: Build gluster packages only for rhel 7 and above .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/37646/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-02-10 11:04:25 +0200 Line 4: Commit: Yaniv Bronhaim ybron...@redhat.com Line 5: CommitDate: 2015-02-10 11:04:25 +0200 Line 6: Line 7: Build gluster packages only for rhel 7 and above Could you please wait whether we can give equivalent functionality in rhel 6 (or platform where no blivet) by using command line tools? I will get back to you on ASAP Line 8: Line 9: Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800 -- To view, visit http://gerrit.ovirt.org/37646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: guestagent: do not access guestinfo directly
Francesco Romani has posted comments on this change. Change subject: vm: guestagent: do not access guestinfo directly .. Patch Set 2: rebased -- To view, visit http://gerrit.ovirt.org/37591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b424e751f92e87c0795e34279deca19e53899a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
Francesco Romani has posted comments on this change. Change subject: vm: stats: cache metadata value .. Patch Set 2: this version fix the rebase brokeness which we had previously. -- To view, visit http://gerrit.ovirt.org/37592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: introduce the services infrastracture
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: introduce the services infrastracture .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/435/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/427/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2340/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15533/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/993/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14731/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15702/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/509/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/976/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make MBPS_TO_BPS a module constant
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: make MBPS_TO_BPS a module constant .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/621/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/221/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4605/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/598/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6444/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/225/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/623/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/224/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/210/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/621/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff2d9f5f0b0c22efeb897d4b87a40415093b445 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: signals: Handle signals to non-main threads
oVirt Jenkins CI Server has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 27: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/224/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4608/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/601/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6447/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/228/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/626/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/228/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/214/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/620/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/625/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: remove redundant slot
Francesco Romani has posted comments on this change. Change subject: devices: remove redundant slot .. Patch Set 1: Code-Review+1 the duplication is probably a relic of an early revision which managed to survive until today. Nice catch. -- To view, visit http://gerrit.ovirt.org/37656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c70a233aade767dc181f9cfc90e5438ccd5a29 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Francesco Romani has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 2: Code-Review-1
(1 comment)
'd' and 'i' are too terse names. It is not only matter of taste, using such
short names makes looking for identifiers unneededly harder
(I can make an exception for loop variables, but that's my pet peeve as C coder)
But that's stuff for later patches, if any. One minor comment inside, shoulde
be quick and easy to fix. Other than that, looks good.
http://gerrit.ovirt.org/#/c/37655/2/vdsm/v2v.py
File vdsm/v2v.py:
Line 132: params['disks'] = []
Line 133: disks = root.findall('.//disk[@type=file]')
Line 134: for disk in disks:
Line 135: d = {}
Line 136: if disk.get('device') is not None:
let's just use
device = disk.get('device')
if device is not None:
d['type'] = device
to be consistent with the surrounding code (and equally correct)
Line 137: d['type'] = disk.get('device')
Line 138: target = disk.find('./target/[@dev]')
Line 139: if target is not None:
Line 140: d['dev'] = target.get('dev')
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for reporting usb addresses
Francesco Romani has posted comments on this change. Change subject: hostdev: add support for reporting usb addresses .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4a4e1d3703abd25c9fa0584ec0e0a1d52b685c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
Francesco Romani has posted comments on this change. Change subject: vm: stats: cache metadata value .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37592/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 717: Line 718: Runs Qemu in a subprocess and communicates with it, and monitors Line 719: its behaviour. Line 720: Line 721: unrelated, will remove Line 722: log = logging.getLogger(vm.Vm) Line 723: # limit threads number until the libvirt lock will be fixed Line 724: _ongoingCreations = threading.BoundedSemaphore(4) Line 725: DeviceMapping = ((hwclass.DISK, vmdevices.storage.Drive), -- To view, visit http://gerrit.ovirt.org/37592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: add API to get all registered VMs
Francesco Romani has posted comments on this change. Change subject: clientIF: add API to get all registered VMs .. Patch Set 10: Code-Review-1 commit message is pointless. Will improve with no code changes. A test could be a nice addition too. -- To view, visit http://gerrit.ovirt.org/36719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib58c6926b6bb3b5b14df8eb1ed59c347775422c1 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: sample using bulk stats and services
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: sample using bulk stats and services .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2338/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15531/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14729/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15700/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/507/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: stats: cache metadata value .. Patch Set 2: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2341/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15534/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14732/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15703/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/510/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: move queryBlockJobs under services
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move queryBlockJobs under services .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2342/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15535/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15704/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/511/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bba47881033af1b928195a94456f7130a7ac343 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: signals: Handle signals to non-main threads
oVirt Jenkins CI Server has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/434/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/426/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15529/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14727/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15698/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/505/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/975/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/992/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add ExpiringCache
Francesco Romani has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 10: version 10 is a rebase, which was needed because a patch later in the series is affected by recent merge of a patch which cleaned up a little getNicStats -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add an API to check if the domain is busy
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add an API to check if the domain is busy .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2337/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15530/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14728/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15699/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/506/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa253326778a102591af4ef5f2bb0434d1eade6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: drop now unused code
Francesco Romani has posted comments on this change. Change subject: vm: drop now unused code .. Patch Set 2: Code-Review-1 this probably means that a(t least one) former patch breaks the build. Check them one by one. -- To view, visit http://gerrit.ovirt.org/37597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic62c3251b770c41b48ff6823f26bbba8d8801903 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: filter out networks with unconfigured bonds
Petr Horáček has posted comments on this change. Change subject: network: filter out networks with unconfigured bonds .. Patch Set 1: Verified+1 Passed unit tests, except: testHostSampleHandlesDisappearingVlanInterfaces, testHostSampleReportsNewInterface (not related to this patch, they fail on master too), passed network's functional tests, except: testDhclientLeases, testSetupNetworksAddDelDhcp, testSetupNetworksKeepNetworkOnBondAfterBondResizing, testSetupNetworksOverDhcpIface, testSetupNetworksReconfigureBridge, testStaticNetworkConfig, not related to the patch (they fail on master too) -- To view, visit http://gerrit.ovirt.org/37569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I408fb59bf80c9ae69fb4abb45aae35507e910407 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: RFE: Report downtime for each live migration
Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration .. Patch Set 1: (1 comment) I know this is a WIP, but I had a quick look and noticed a simple silly thing. http://gerrit.ovirt.org/#/c/37075/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1800: t I know this is WIP, but still worth mentioning. Albeit should be cheap, it is wasteful to call migrateStatus twice here. Let's just do: migStatus = self.migrateStatus() stats['migrationProgress'] = migStatus['progress'] stats['migrationDowntime'] = migStatus['downtime'] -- To view, visit http://gerrit.ovirt.org/37075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add an API to check if the domain is busy
Francesco Romani has posted comments on this change. Change subject: vm: add an API to check if the domain is busy .. Patch Set 11: Code-Review-1 (2 comments) could be simplified http://gerrit.ovirt.org/#/c/36721/11/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2943: self.setUnresponsive() Line 2944: else: Line 2945: self.setResponsive() Line 2946: Line 2947: def setResponsive(self): not really needed anymore. Line 2948: self._monitorResponse = 0 Line 2949: Line 2950: def setUnresponsive(self): Line 2951: self._monitorResponse = -1 Line 2946: Line 2947: def setResponsive(self): Line 2948: self._monitorResponse = 0 Line 2949: Line 2950: def setUnresponsive(self): same Line 2951: self._monitorResponse = -1 Line 2952: Line 2953: def _completeIncomingMigration(self): Line 2954: if 'restoreState' in self.conf: -- To view, visit http://gerrit.ovirt.org/36721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa253326778a102591af4ef5f2bb0434d1eade6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add Drive.extendable property
Francesco Romani has posted comments on this change. Change subject: virt: Add Drive.extendable property .. Patch Set 3: Code-Review+1 (1 comment) I tend to like and support everything that makes the Vm class and vm.py shorter :) http://gerrit.ovirt.org/#/c/37570/3/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 149: Return True if drive supports extending. Line 150: Line 151: If a drive is extendable, current drive write watermark and Line 152: Drive.volExtensionChunk is used to detect if a drive should be Line 153: extended, and getNextVolumeSize to find the new size. I wonder if this documentation really belongs there or if it should be moved closer to the implementation. Line 154: Line 155: return self.blockDev and self.format == cow Line 156: Line 157: @property -- To view, visit http://gerrit.ovirt.org/37570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: guestagent: do not access guestinfo directly
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: guestagent: do not access guestinfo directly .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2339/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15532/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14730/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15701/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/508/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b424e751f92e87c0795e34279deca19e53899a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: split up stats production
Francesco Romani has posted comments on this change. Change subject: vm: stats: split up stats production .. Patch Set 10: Code-Review-1 the code moved in 'vmstats.py' is now easy to test, thus should be covered by tests. -- To view, visit http://gerrit.ovirt.org/36730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1d42b10714fa69c78f58ffaab7f7a32aed47ba Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add Drive.extendable property
Nir Soffer has posted comments on this change. Change subject: virt: Add Drive.extendable property .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37570/3/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 149: Return True if drive supports extending. Line 150: Line 151: If a drive is extendable, current drive write watermark and Line 152: Drive.volExtensionChunk is used to detect if a drive should be Line 153: extended, and getNextVolumeSize to find the new size. I wonder if this documentation really belongs there or if it should be move In closer to the implementation, do you mean to the code that perform extending? I added it to make it clear that extendable does not mean should be extended, only can be extended. And mentioning the other methods involved give nice overview about this. Maybe we can move this part to the module docstring, discussing extending drives. Can be done later. Line 154: Line 155: return self.blockDev and self.format == cow Line 156: Line 157: @property -- To view, visit http://gerrit.ovirt.org/37570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: clientIF: add API to get all registered VMs
Francesco Romani has posted comments on this change. Change subject: clientIF: add API to get all registered VMs .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/36719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib58c6926b6bb3b5b14df8eb1ed59c347775422c1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build gluster packages only for rhel 7 and above
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Build gluster packages only for rhel 7 and above
..
Build gluster packages only for rhel 7 and above
Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/37646/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 9c810ad..fd9b97d 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -46,7 +46,7 @@
%endif
# Gluster should not be shipped with RHEV
-%if ! 0%{?rhev_build}
+%if ! 0%{?rhev_build} 0%{?rhel} 6
%global with_gluster 1
%endif
--
To view, visit http://gerrit.ovirt.org/37646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: enhanced storageDevicesList function
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: enhanced storageDevicesList function .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15517/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14714/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/492/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25221e4266a4e14499c45916c5a4c9b723821bfb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: enhanced storageDevicesList function
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: enhanced storageDevicesList function .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15518/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14715/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15687/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/493/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25221e4266a4e14499c45916c5a4c9b723821bfb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add debug log for getStats()
Francesco Romani has posted comments on this change.
Change subject: vm: add debug log for getStats()
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/36732/2/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 460:
Line 461: def _serveRequest(self, ctx, req):
Line 462: mangledMethod = req.method.replace(., _)
Line 463: logLevel = logging.DEBUG
Line 464: if mangledMethod in ('Host_getStats',
'StorageDomain_getStats',
You mentioned in commit message that the issue was with getAllVMStats so wh
because we want to do the same for getVMList, still for debug purposes, and I
forgot to mention that in the commit message. Will fix (and rebase properly) in
the next upload.
Line 465: 'VM_getStats', 'Host_fenceNode'):
Line 466: logLevel = logging.TRACE
Line 467: self.log.log(logLevel, Calling '%s' in bridge with %s,
Line 468: req.method, req.params)
--
To view, visit http://gerrit.ovirt.org/36732
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23d9361568f51be9b70dab22d3a388f692011402
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build gluster packages only for rhel 7 and above
oVirt Jenkins CI Server has posted comments on this change. Change subject: Build gluster packages only for rhel 7 and above .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/432/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/425/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15519/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/990/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14716/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15688/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/494/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/973/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: store non-Vdsm ifcfgs with unified persistence
Dan Kenigsberg has submitted this change and it was merged. Change subject: network: store non-Vdsm ifcfgs with unified persistence .. network: store non-Vdsm ifcfgs with unified persistence Unified restoration first removes everything in the running config and then tries to regenerate everything that's in the persisted config, problem is, that original devices are not persisted. In this patch we (temporarily) use ifcfg persistence for non-Vdsm devices (even when unified persistence is set), so we are able to restore them. Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Bug-Url: https://bugzilla.redhat.com/1188251 Signed-off-by: Petr Horáček phora...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37453 Reviewed-by: Ondřej Svoboda osvob...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/network/configurators/ifcfg.py M vdsm/vdsm-restore-net-config M vdsm/vdsm-store-net-config.in 3 files changed, 25 insertions(+), 11 deletions(-) Approvals: Ondřej Svoboda: Looks good to me, but someone else must approve Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon celeb...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: store non-Vdsm ifcfgs with unified persistence
Dan Kenigsberg has posted comments on this change. Change subject: network: store non-Vdsm ifcfgs with unified persistence .. Patch Set 6: Code-Review+2 I hate the idea, as it makes unified persistence as joke. But at the moment, I see no means around it. This needs a backport, too. -- To view, visit http://gerrit.ovirt.org/37453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon celeb...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add drive_config helper
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Add drive_config helper .. tests: Add drive_config helper Instead of repeating all drive options for each test, add a helper function to create drive configuration specifying only the interesting options for the specific test. Change-Id: I7b1d1fd263324d3e376606c97be7ab54059b7f17 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37547 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/vmStorageTests.py 1 file changed, 41 insertions(+), 69 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b1d1fd263324d3e376606c97be7ab54059b7f17 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add drive_config helper
Dan Kenigsberg has posted comments on this change. Change subject: tests: Add drive_config helper .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b1d1fd263324d3e376606c97be7ab54059b7f17 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: use IP_MASK, there's no need for prefix2netmask
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: use IP_MASK, there's no need for prefix2netmask .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib47ad4e83c8360b9bbd9a512866c215409e23976 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: use IP_MASK, there's no need for prefix2netmask
Dan Kenigsberg has submitted this change and it was merged. Change subject: networkTests: use IP_MASK, there's no need for prefix2netmask .. networkTests: use IP_MASK, there's no need for prefix2netmask Change-Id: Ib47ad4e83c8360b9bbd9a512866c215409e23976 Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37464 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/functional/networkTests.py 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Ondřej Svoboda: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib47ad4e83c8360b9bbd9a512866c215409e23976 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: also check we successfully report an IPv4 gateway
Dan Kenigsberg has submitted this change and it was merged. Change subject: networkTests: also check we successfully report an IPv4 gateway .. networkTests: also check we successfully report an IPv4 gateway Change-Id: If00e3ec616453cfbc5957eb917e6e083099d9668 Bug-Url: https://bugzilla.redhat.com/1186330 Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37448 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/functional/networkTests.py 1 file changed, 23 insertions(+), 24 deletions(-) Approvals: Ondřej Svoboda: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If00e3ec616453cfbc5957eb917e6e083099d9668 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: also check we successfully report an IPv4 gateway
Dan Kenigsberg has posted comments on this change. Change subject: networkTests: also check we successfully report an IPv4 gateway .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00e3ec616453cfbc5957eb917e6e083099d9668 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: additional info for disk and network
..
v2v: additional info for disk and network
disk now return type ('disk', 'cdrom' etc)
network now return type ('e1000', 'rtl' etc)
Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Signed-off-by: Shahar Havivi shah...@redhat.com
---
M vdsm/v2v.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/37655/1
diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index 46596c9..26d2490 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -133,6 +133,7 @@
disks = root.findall('.//disk[@type=file]')
for disk in disks:
d = {}
+d['type'] = disk.get('device')
target = disk.find('./target/[@dev]')
if target is not None:
d['dev'] = target.get('dev')
@@ -158,4 +159,7 @@
target = iface.find('./target/[@dev]')
if target is not None:
i['dev'] = target.get('dev')
+model = iface.find('./model/[@type]')
+if model is not None:
+i['model'] = model.get('type')
params['networks'].append(i)
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: filter out networks with unconfigured bonds
Dan Kenigsberg has posted comments on this change. Change subject: network: filter out networks with unconfigured bonds .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I408fb59bf80c9ae69fb4abb45aae35507e910407 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for drive disk type
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Add tests for drive disk type .. tests: Add tests for drive disk type Test Drive.networkDev and Drive.blockDev before refactoring these properties. Change-Id: I048b9cc5b72ae221db74eb03168e7aa719cacaad Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37549 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/vmStorageTests.py 1 file changed, 40 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I048b9cc5b72ae221db74eb03168e7aa719cacaad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for drive disk type
Dan Kenigsberg has posted comments on this change. Change subject: tests: Add tests for drive disk type .. Patch Set 1: Code-Review+2 Raising score -- To view, visit http://gerrit.ovirt.org/37549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I048b9cc5b72ae221db74eb03168e7aa719cacaad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Rename test class
Dan Kenigsberg has posted comments on this change. Change subject: tests: Rename test class .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42feae15b306ebbc047e4f1036e99d21d41783c5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Rename test class
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Rename test class .. tests: Rename test class It is easier to grok the tests results when the name of the test case starts with meaningful word, instead of Test. TestFoo test_xxx test_yyy FooTests test_xxx test_yyy Change-Id: I42feae15b306ebbc047e4f1036e99d21d41783c5 Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37548 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/vmStorageTests.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42feae15b306ebbc047e4f1036e99d21d41783c5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: store non-Vdsm ifcfgs with unified persistence
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: store non-Vdsm ifcfgs with unified persistence .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15520/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14717/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15689/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2614/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/495/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaac0d82863334238e6db71b4a6a4f6b76a260223 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon celeb...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: report a gateway for statically configured networks
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: report a gateway for statically configured networks .. netinfo: report a gateway for statically configured networks Change-Id: I65b8c789cf393fbb9aa9d040c38d2c9d9f281864 Bug-Url: https://bugzilla.redhat.com/1186330 Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37440 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/netinfo.py M lib/vdsm/netlink/route.py 2 files changed, 11 insertions(+), 4 deletions(-) Approvals: Ondřej Svoboda: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65b8c789cf393fbb9aa9d040c38d2c9d9f281864 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Lior Vernia lver...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: report a gateway for statically configured networks
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: report a gateway for statically configured networks .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b8c789cf393fbb9aa9d040c38d2c9d9f281864 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Lior Vernia lver...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dnsmasqDhcp: fix an inverted condition
Dan Kenigsberg has posted comments on this change. Change subject: dnsmasqDhcp: fix an inverted condition .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdc2ad5e173f7627be213bb40878293c373a530 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add drive_config helper
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add drive_config helper .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/613/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/213/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4597/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/590/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6436/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/615/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/216/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/202/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/609/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b1d1fd263324d3e376606c97be7ab54059b7f17 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: _bridges_ should be among devices with active DHCP ...
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: _bridges_ should be among devices with active DHCP
leases
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37636/2/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 648: dhcpv4_ifaces, dhcpv6_ifaces = _get_dhclient_ifaces()
Line 649: d = {}
Line 650: for net, netAttr in nets.iteritems():
Line 651: try:
Line 652: d[net] = _getNetInfo(net, netAttr.get('iface', net),
I think that this patch is redundant, as we already pass the bridge name if the
network is not defined on an iface.
netAttr.get('iface', net)
Line 653: netAttr['bridged'], routes, ipAddrs,
Line 654: dhcpv4_ifaces, dhcpv6_ifaces)
Line 655: except KeyError:
Line 656: continue # Do not report missing libvirt networks.
--
To view, visit http://gerrit.ovirt.org/37636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e6d9dc729bed6e395c5b13b1a779b4acc95
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: remove the unused function 'routeList'
Dan Kenigsberg has submitted this change and it was merged. Change subject: ipwrapper: remove the unused function 'routeList' .. ipwrapper: remove the unused function 'routeList' Change-Id: If6fbc66b754a433b051528d9fe575afc7c6b3f16 Signed-off-by: Ondřej Svoboda osvob...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37622 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/ipwrapper.py 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Ondřej Svoboda: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/37622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6fbc66b754a433b051528d9fe575afc7c6b3f16 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ipwrapper: remove the unused function 'routeList'
Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: remove the unused function 'routeList' .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6fbc66b754a433b051528d9fe575afc7c6b3f16 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build gluster packages only for rhel 7 and above
Dan Kenigsberg has posted comments on this change.
Change subject: Build gluster packages only for rhel 7 and above
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37646/1/vdsm.spec.in
File vdsm.spec.in:
Line 45: %global _polkitdir
%{_localstatedir}/lib/polkit-1/localauthority/10-vendor.d
Line 46: %endif
Line 47:
Line 48: # Gluster should not be shipped with RHEV
Line 49: %if ! 0%{?rhev_build} 0%{?rhel} 6
this resolves to False on Fedora 20.
All you want is to exclude rhel6, so use
! 0%{?rhel} == 6
Line 50: %global with_gluster 1
Line 51: %endif
Line 52:
Line 53: %if ! 0%{?rhel} || ! 0%{fedora_koji_build}
--
To view, visit http://gerrit.ovirt.org/37646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7c1a0bc8d01a3af26a05c26fe7da7e735ed8800
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Cole Robinson aintdisc...@gmail.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: do not report DHCP from (typically still valid) leases
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: do not report DHCP from (typically still valid) leases
..
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37617/4/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 427: return running_config.networks[iface]['bootproto'] ==
'dhcp'
Line 428: else:
Line 429: return running_config.networks[iface]['dhcpv6']
Line 430: except KeyError:
Line 431: logging.warning('Running configuration not found for ' +
iface)
its an info or debug, as it's ok to have an interface defined out of vdsm.
Please be more specific, so we can tell if iface was missing, or
'dhcpv6'/bootproto
Line 432: return iface in ifaces_with_active_leases
Line 433:
Line 434:
Line 435: def _getNetInfo(network, iface, bridged, routes, ipaddrs,
dhcpv4_ifaces,
--
To view, visit http://gerrit.ovirt.org/37617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
Dan Kenigsberg has posted comments on this change. Change subject: network: change objectivizeNetwork to private .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Rename test class
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Rename test class .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/614/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/214/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4598/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/591/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6437/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/218/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/616/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/217/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/203/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/610/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42feae15b306ebbc047e4f1036e99d21d41783c5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15521/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14718/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15690/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/496/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37655/1/vdsm/v2v.py
File vdsm/v2v.py:
Line 132: params['disks'] = []
Line 133: disks = root.findall('.//disk[@type=file]')
Line 134: for disk in disks:
Line 135: d = {}
Line 136: d['type'] = disk.get('device')
Can 'device' ever be missing? We do NOT want to report None values over xmlrpc
Line 137: target = disk.find('./target/[@dev]')
Line 138: if target is not None:
Line 139: d['dev'] = target.get('dev')
Line 140: source = disk.find('./source/[@file]')
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make MBPS_TO_BPS a module constant
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: make MBPS_TO_BPS a module constant .. vm: make MBPS_TO_BPS a module constant There is no good reason anymore to have MBPS_TO_BPS a class constant, so this patch moves it to module level, in order to make room for more future cleanup. Change-Id: I8ff2d9f5f0b0c22efeb897d4b87a40415093b445 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37456 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/37456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ff2d9f5f0b0c22efeb897d4b87a40415093b445 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make MBPS_TO_BPS a module constant
Dan Kenigsberg has posted comments on this change. Change subject: vm: make MBPS_TO_BPS a module constant .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff2d9f5f0b0c22efeb897d4b87a40415093b445 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make _getNicStats a function
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: make _getNicStats a function .. vm: make _getNicStats a function _getNicStats used to be a classmethod of VmStatsThread, but there are no valid reasons anymore to keep it like that. This patch makes it a plain function, to make room for more refactoring in this area. There are no changes in logic. Except for moving code around, the only significant change is the removal of the now-useless 'cls' argument. Change-Id: Ia191fce7a1f3330013a621d97038bb32fd3cd563 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37457 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/vmTests.py M vdsm/virt/vm.py 2 files changed, 51 insertions(+), 53 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/37457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia191fce7a1f3330013a621d97038bb32fd3cd563 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: make _getNicStats a function
Dan Kenigsberg has posted comments on this change. Change subject: vm: make _getNicStats a function .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia191fce7a1f3330013a621d97038bb32fd3cd563 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add ExpiringCache
Francesco Romani has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/36716/9/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 77: Line 78: def __getitem__(self, key): Line 79: Line 80: Raises KeyError if a key was not found. Line 81: Raises ItemExpired if a a key expired and was cleaned up. typo: a a Line 82: ItemExpired is a subclass of KeyError. Line 83: Line 84: return self._get_live(key) Line 85: -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for drive disk type
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add tests for drive disk type .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/615/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/215/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4599/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/592/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6438/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/219/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/617/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/218/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/204/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/611/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I048b9cc5b72ae221db74eb03168e7aa719cacaad Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
Francesco Romani has posted comments on this change. Change subject: vm: stats: cache metadata value .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37592/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 770: # The issue currently exists only on CentOS/RHEL 6.5 that Line 771: # ships libvirt-0.10.x. Line 772: # Line 773: # TODO: Remove as soon as there is a hard dependency we can use Line 774: _libvirt_metadata_supported = True not really needed here Line 775: Line 776: log = logging.getLogger(vm.Vm) Line 777: # limit threads number until the libvirt lock will be fixed Line 778: _ongoingCreations = threading.BoundedSemaphore(4) -- To view, visit http://gerrit.ovirt.org/37592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: guestagent: do not access guestinfo directly
Dan Kenigsberg has posted comments on this change. Change subject: vm: guestagent: do not access guestinfo directly .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b424e751f92e87c0795e34279deca19e53899a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
Francesco Romani has posted comments on this change. Change subject: vm: stats: cache metadata value .. Patch Set 1: Code-Review-1 badly rebased -- To view, visit http://gerrit.ovirt.org/37592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: stats: cache metadata value
Dan Kenigsberg has posted comments on this change. Change subject: vm: stats: cache metadata value .. Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/37592/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 770: # The issue currently exists only on CentOS/RHEL 6.5 that Line 771: # ships libvirt-0.10.x. Line 772: # Line 773: # TODO: Remove as soon as there is a hard dependency we can use Line 774: _libvirt_metadata_supported = True unrelated Line 775: Line 776: log = logging.getLogger(vm.Vm) Line 777: # limit threads number until the libvirt lock will be fixed Line 778: _ongoingCreations = threading.BoundedSemaphore(4) -- To view, visit http://gerrit.ovirt.org/37592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I574b66764f8c3980fdbef3bc969b483a04542704 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: remove redundant slot
oVirt Jenkins CI Server has posted comments on this change. Change subject: devices: remove redundant slot .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2336/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15522/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14719/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15691/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/497/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c70a233aade767dc181f9cfc90e5438ccd5a29 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmchannels: downgrade logs about expected flows
Dan Kenigsberg has submitted this change and it was merged. Change subject: vmchannels: downgrade logs about expected flows .. vmchannels: downgrade logs about expected flows virt flows have plenty of steps logged, but some of them aren't worth of the user's attention, so downgrade them. Change-Id: Ib041d4c844fe948523942d76236d291ecf3eb0fb Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/34357 Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vmchannels.py 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/34357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib041d4c844fe948523942d76236d291ecf3eb0fb Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmchannels: downgrade logs about expected flows
Dan Kenigsberg has posted comments on this change. Change subject: vmchannels: downgrade logs about expected flows .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib041d4c844fe948523942d76236d291ecf3eb0fb Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has posted comments on this change.
Change subject: v2v: additional info for disk and network
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37655/1/vdsm/v2v.py
File vdsm/v2v.py:
Line 132: params['disks'] = []
Line 133: disks = root.findall('.//disk[@type=file]')
Line 134: for disk in disks:
Line 135: d = {}
Line 136: d['type'] = disk.get('device')
Can 'device' ever be missing? We do NOT want to report None values over xml
No,
But I will add a check
Line 137: target = disk.find('./target/[@dev]')
Line 138: if target is not None:
Line 139: d['dev'] = target.get('dev')
Line 140: source = disk.find('./source/[@file]')
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: remove redundant slot
Martin Polednik has uploaded a new change for review.
Change subject: devices: remove redundant slot
..
devices: remove redundant slot
'device' slot is defined in Base class (core.py), there is no need
to have it in child classes.
Change-Id: Ie0c70a233aade767dc181f9cfc90e5438ccd5a29
Signed-off-by: Martin Polednik mpoled...@redhat.com
---
M vdsm/virt/vmdevices/graphics.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/37656/1
diff --git a/vdsm/virt/vmdevices/graphics.py b/vdsm/virt/vmdevices/graphics.py
index 9f67be3..3165812 100644
--- a/vdsm/virt/vmdevices/graphics.py
+++ b/vdsm/virt/vmdevices/graphics.py
@@ -49,7 +49,7 @@
'main', 'display', 'inputs', 'cursor', 'playback',
'record', 'smartcard', 'usbredir')
-__slots__ = ('device', 'port', 'tlsPort')
+__slots__ = ('port', 'tlsPort')
def __init__(self, conf, log, **kwargs):
super(Graphics, self).__init__(conf, log, **kwargs)
--
To view, visit http://gerrit.ovirt.org/37656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0c70a233aade767dc181f9cfc90e5438ccd5a29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Shahar Havivi has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: remove redundant slot
Martin Polednik has posted comments on this change. Change subject: devices: remove redundant slot .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/37656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c70a233aade767dc181f9cfc90e5438ccd5a29 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for reporting usb addresses
Martin Polednik has posted comments on this change. Change subject: hostdev: add support for reporting usb addresses .. Patch Set 8: Verified+1 verified manually via hostdevListByCaps and tests check -- To view, visit http://gerrit.ovirt.org/35785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4a4e1d3703abd25c9fa0584ec0e0a1d52b685c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add ExpiringCache
Dan Kenigsberg has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dnsmasqDhcp: fix an inverted condition
Ondřej Svoboda has posted comments on this change. Change subject: dnsmasqDhcp: fix an inverted condition .. Patch Set 1: Verified+1 On Fedora 21 the journal is no longer spammed by dnsmasq complaints. -- To view, visit http://gerrit.ovirt.org/37635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fdc2ad5e173f7627be213bb40878293c373a530 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15524/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14721/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15693/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/499/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
