Change in vdsm[master]: networkTests: give an instructory message when an address co...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: give an instructory message when an address could not be added .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15580/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14778/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15749/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2625/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/556/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add Drive.chunked property
Adam Litke has posted comments on this change.
Change subject: virt: Add Drive.chunked property
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/37570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1407: # FIXME: mergeCandidates should be a dictionary of candidate
volumes
Line 1408: # once libvirt starts reporting watermark information for
all volumes.
Line 1409: mergeCandidates = {}
Line 1410: for drive in self._devices[hwclass.DISK]:
Line 1411: if not drive.extendable:
chunked? This is the first I've seen extendable.
Line 1412: continue
Line 1413:
Line 1414: capacity, alloc, physical =
self._dom.blockInfo(drive.path, 0)
Line 1415: ret.append((drive, drive.volumeID, capacity, alloc,
physical))
--
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Check if a drive is chuhked before extending
Adam Litke has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37573/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4776: # the worst case, we'll need to extend 'base' to the same size as 'top' Line 4777: # plus a bit more to accomodate additional writes to 'top' during the Line 4778: # live merge operation. Line 4779: if drive.chunked: Line 4780: self.extendDriveVolume(drive, baseVolUUID, topSize) What happens for a chain with a RAW base volume and a cow snapshot? Won't this end up calling extend on the preallocated RAW base volume? Line 4781: Line 4782: # Trigger the collection of stats before returning so that callers Line 4783: # of getVmStats after this returns will see the new job Line 4784: self._vmStats.sampleVmJobs() -- To view, visit http://gerrit.ovirt.org/37573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48416dde002272d45761296f176b97f4d870849d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for Drive.getNextVolumeSize
Nir Soffer has uploaded a new change for review.
Change subject: tests: Add tests for Drive.getNextVolumeSize
..
tests: Add tests for Drive.getNextVolumeSize
This function mixes sizes in different units, resulting in failure to
limit the volume size to Drive.truesize.
Change-Id: I2140af915f39c48803546ca7e44e07ae05872843
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M tests/vmStorageTests.py
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/37725/1
diff --git a/tests/vmStorageTests.py b/tests/vmStorageTests.py
index cb10b8b..925d52d 100644
--- a/tests/vmStorageTests.py
+++ b/tests/vmStorageTests.py
@@ -19,10 +19,12 @@
#
from monkeypatch import MonkeyPatch
+from testValidation import brokentest
from testlib import VdsmTestCase
from testlib import XMLTestCase
from testlib import permutations, expandPermutations
+from vdsm import constants
from vdsm import utils
from virt.vmdevices.storage import Drive
@@ -242,6 +244,28 @@
self.assertEqual(drive.chunked, chunked)
+class GetNextVolumeSizeTests(VdsmTestCase):
+
+def test_first_extend(self):
+drive = self.chunked_drive(1024, 8192)
+apparentsize_mb = drive.apparentsize / constants.MEGAB
+size_mb = apparentsize_mb + drive.volExtensionChunk
+self.assertEqual(drive.getNextVolumeSize(drive.apparentsize), size_mb)
+
+@brokentest()
+def test_truesize_limit(self):
+drive = self.chunked_drive(8191, 8192)
+self.assertEqual(drive.getNextVolumeSize(drive.apparentsize), 8192)
+
+def chunked_drive(self, size_mb, maxsize_mb):
+conf = drive_config(
+apparentsize=str(size_mb * constants.MEGAB),
+format='cow',
+truesize=str(maxsize_mb * constants.MEGAB),
+)
+return Drive({}, self.log, **conf)
+
+
def drive_config(**kw):
Reutrn drive configuration updated from **kw
conf = {
--
To view, visit http://gerrit.ovirt.org/37725
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2140af915f39c48803546ca7e44e07ae05872843
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has uploaded a new change for review. Change subject: virt: Fix limit when calculating next volume size .. virt: Fix limit when calculating next volume size Drive.getNextVolumeSize limit was wrong, since Drive.truesize is using bytes and the result in in megabytes. We use safer naming convention now to avoid future confusion. Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Signed-off-by: Nir Soffer nsof...@redhat.com --- M tests/vmStorageTests.py M vdsm/virt/vmdevices/storage.py 2 files changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/37726/1 diff --git a/tests/vmStorageTests.py b/tests/vmStorageTests.py index 925d52d..d661401 100644 --- a/tests/vmStorageTests.py +++ b/tests/vmStorageTests.py @@ -19,7 +19,6 @@ # from monkeypatch import MonkeyPatch -from testValidation import brokentest from testlib import VdsmTestCase from testlib import XMLTestCase from testlib import permutations, expandPermutations @@ -252,7 +251,6 @@ size_mb = apparentsize_mb + drive.volExtensionChunk self.assertEqual(drive.getNextVolumeSize(drive.apparentsize), size_mb) -@brokentest() def test_truesize_limit(self): drive = self.chunked_drive(8191, 8192) self.assertEqual(drive.getNextVolumeSize(drive.apparentsize), 8192) diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py index 7ef7f19..800128d 100644 --- a/vdsm/virt/vmdevices/storage.py +++ b/vdsm/virt/vmdevices/storage.py @@ -139,9 +139,9 @@ to be extended. For the leaf volume curSize == self.apparentsize. For internal volumes it is discovered by calling irs.getVolumeSize(). -nextSize = (self.volExtensionChunk + -((curSize + constants.MEGAB - 1) / constants.MEGAB)) -return min(nextSize, self.truesize) +curSizeMB = (curSize + constants.MEGAB - 1) / constants.MEGAB +nextSizeMB = curSizeMB + self.volExtensionChunk +return min(nextSizeMB, self.truesize / constants.MEGAB) @property def chunked(self): -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Unify Drive size units
Nir Soffer has uploaded a new change for review.
Change subject: virt: Unify Drive size units
..
virt: Unify Drive size units
Previously we used to keep some Drive size values in bytes and some in
megabytes, and return next volume size in megabytes. We had lot of code
converting sizes from megabytes to bytes. This mess makes understanding
the code harder and leads to bugs as seen the previous patch.
Now we keep all size values in bytes and return next volume size in
bytes, simplifying lot of code.
Change-Id: Ice01c9706fc27d4472c90e47bf7e808564ba0bfe
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M tests/vmStorageTests.py
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/storage.py
3 files changed, 28 insertions(+), 25 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/37727/1
diff --git a/tests/vmStorageTests.py b/tests/vmStorageTests.py
index d661401..f5ca892 100644
--- a/tests/vmStorageTests.py
+++ b/tests/vmStorageTests.py
@@ -247,13 +247,13 @@
def test_first_extend(self):
drive = self.chunked_drive(1024, 8192)
-apparentsize_mb = drive.apparentsize / constants.MEGAB
-size_mb = apparentsize_mb + drive.volExtensionChunk
-self.assertEqual(drive.getNextVolumeSize(drive.apparentsize), size_mb)
+self.assertEqual(drive.getNextVolumeSize(drive.apparentsize),
+ drive.apparentsize + drive.volExtensionChunk)
def test_truesize_limit(self):
drive = self.chunked_drive(8191, 8192)
-self.assertEqual(drive.getNextVolumeSize(drive.apparentsize), 8192)
+self.assertEqual(drive.getNextVolumeSize(drive.apparentsize),
+ drive.truesize)
def chunked_drive(self, size_mb, maxsize_mb):
conf = drive_config(
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 21a6af1..b44ad56 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1428,7 +1428,7 @@
# may result in the VM being paused) we can't use the regular
# getNextVolumeSize call as it relies on a cached value of the
# drive apparentsize.
-nextPhysSize = physical + drive.VOLWM_CHUNK_MB * constants.MEGAB
+nextPhysSize = physical + drive.VOLWM_CHUNK_MB
# NOTE: the intent of this check is to prevent faulty images to
# trick qemu in requesting extremely large extensions (BZ#998443).
@@ -1480,7 +1480,7 @@
Must be called only when the drive or the replica are chunked.
-newSize = vmDrive.getNextVolumeSize(curSize) # newSize is in megabytes
+newSize = vmDrive.getNextVolumeSize(curSize)
if getattr(vmDrive, 'diskReplicate', None):
volInfo = {'poolID': vmDrive.diskReplicate['poolID'],
@@ -1491,7 +1491,7 @@
self.log.debug(Requesting an extension for the volume
replication: %s, volInfo)
self.cif.irs.sendExtendMsg(vmDrive.poolID, volInfo,
- newSize * constants.MEGAB,
+ newSize,
self.__afterReplicaExtension)
else:
self.__extendDriveVolume(vmDrive, volumeID, newSize)
@@ -1523,9 +1523,9 @@
self.log.debug(Verifying extension for volume %s, requested size %s,
current size %s, volInfo['volumeID'],
- volInfo['newSize'] * constants.MEGAB, apparentSize)
+ volInfo['newSize'], apparentSize)
-if apparentSize volInfo['newSize'] * constants.MEGAB: # in bytes
+if apparentSize volInfo['newSize']:
raise RuntimeError(
Volume extension failed for %s (domainID: %s, volumeID: %s) %
(volInfo['name'], volInfo['domainID'], volInfo['volumeID']))
@@ -1549,7 +1549,7 @@
self.cif.irs.sendExtendMsg(
vmDrive.poolID,
volInfo,
-newSize * constants.MEGAB,
+newSize,
self.__afterVolumeExtension)
def __afterVolumeExtension(self, volInfo):
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index 800128d..d8a5dd8 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -47,7 +47,8 @@
'volumeChain', 'baseVolumeID', 'serial', 'reqsize', 'cache',
'_blockDev', 'extSharedState', 'drv', 'sgio', 'GUID',
'diskReplicate')
-VOLWM_CHUNK_MB = config.getint('irs', 'volume_utilization_chunk_mb')
+VOLWM_CHUNK_SIZE = (config.getint('irs', 'volume_utilization_chunk_mb') *
+constants.MEGAB)
VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent')
VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during replication
@@ -113,35 +114,37 @@
@property
def volExtensionChunk(self):
-Returns the
Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...
Ondřej Svoboda has uploaded a new change for review.
Change subject: dummy: unify parameter 'dummy_name' naming with a variable name
already used
..
dummy: unify parameter 'dummy_name' naming with a variable name already used
Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M tests/functional/dummy.py
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/37728/1
diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py
index f036784..eebefed 100644
--- a/tests/functional/dummy.py
+++ b/tests/functional/dummy.py
@@ -38,40 +38,40 @@
return dummy_name
-def remove(dummyName):
+def remove(dummy_name):
Removes dummy interface dummyName. Assumes root privileges.
try:
-linkDel(dummyName)
+linkDel(dummy_name)
except IPRoute2Error as e:
raise SkipTest(Unable to delete dummy interface %s because %s %
- (dummyName, e))
+ (dummy_name, e))
-def setIP(dummyName, ipaddr, netmask, family=4):
+def setIP(dummy_name, ipaddr, netmask, family=4):
try:
-addrAdd(dummyName, ipaddr, netmask, family)
+addrAdd(dummy_name, ipaddr, netmask, family)
except IPRoute2Error as e:
message = ('Failed to add the IPv%s address %s/%s to device %s: %s'
- % (family, ipaddr, netmask, dummyName, e))
+ % (family, ipaddr, netmask, dummy_name, e))
if family == 6:
message += ('; NetworkManager may have set the sysctl disable_ipv6'
' flag on the device, please see e.g. RH BZ #1102064')
raise SkipTest(message)
-def setLinkUp(dummyName):
-_setLinkState(dummyName, 'up')
+def setLinkUp(dummy_name):
+_setLinkState(dummy_name, 'up')
-def setLinkDown(dummyName):
-_setLinkState(dummyName, 'down')
+def setLinkDown(dummy_name):
+_setLinkState(dummy_name, 'down')
-def _setLinkState(dummyName, state):
+def _setLinkState(dummy_name, state):
try:
-linkSet(dummyName, [state])
+linkSet(dummy_name, [state])
except IPRoute2Error:
-raise SkipTest('Failed to bring %s to state %s' % (dummyName, state))
+raise SkipTest('Failed to bring %s to state %s' % (dummy_name, state))
--
To view, visit http://gerrit.ovirt.org/37728
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: delete our lease files also on EL6
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: delete our lease files also on EL6 .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15585/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14783/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15754/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2627/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/561/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe9bd81c33aade9baf72c54f25a802f80a36de5a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add createBrick verb
Bala.FA has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 16:
(2 comments)
http://gerrit.ovirt.org/#/c/35498/16/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 30: from blivet.devices import LVMThinLogicalVolumeDevice
Line 31:
Line 32: import fstab
Line 33: import exception as ge
Line 34: from . import makePublic
logging is the only python system module here its mentioned first
blivet is neither in vdsm nor in vdsm-gluster. Why does it consider as local
module?
Line 35:
Line 36:
Line 37: log = logging.getLogger(Gluster)
Line 38: _pvcreateCommandPath = utils.CommandPath(pvcreate,
Line 59: DEFAULT_FS_TYPE = xfs
Line 60: DEFAULT_MOUNT_OPTIONS = inode64,noatime
Line 61:
Line 62:
Line 63: def _getDeviceDict(device, hasData, fsType=''):
fsType is not appearing immediately after we create lv. It appears only af
Do you mean fsType doesn't appear in blivet? If so its blivet bug. You should
file/track the bug and mention here about the bz
Line 64: info = {'name': device.name,
Line 65: 'size': '%s' % device.size,
Line 66: 'devPath': device.path,
Line 67: 'devUuid': device.uuid or '',
--
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Sahina Bose sab...@redhat.com
Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com
Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Check if a drive is chuhked before extending
Nir Soffer has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 4: Rebase, no code change -- To view, visit http://gerrit.ovirt.org/37573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48416dde002272d45761296f176b97f4d870849d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add Drive.chunked property
Nir Soffer has posted comments on this change. Change subject: virt: Add Drive.chunked property .. Patch Set 6: This version fixed bad rename. -- To view, visit http://gerrit.ovirt.org/37570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 1: Verified using the tests. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: delete our lease files also on EL6
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: delete our lease files also on EL6 .. Patch Set 2: Verified+1 There are no leftover leases even on EL6. not related to the verification: I only noticed that testSetupNetworksReconfigureBridge shows a warning although it succeeds: WARNING:root:File: /var/lib/dhclient/dhclient-test-network.leases already removed I think that the try-finally block in the test can be simplified – it just needs to wrap setup_test_network(dhcp=True), only one such call. -- To view, visit http://gerrit.ovirt.org/37684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe9bd81c33aade9baf72c54f25a802f80a36de5a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add Drive.chunked property
Nir Soffer has posted comments on this change.
Change subject: virt: Add Drive.chunked property
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/37570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1407: # FIXME: mergeCandidates should be a dictionary of candidate
volumes
Line 1408: # once libvirt starts reporting watermark information for
all volumes.
Line 1409: mergeCandidates = {}
Line 1410: for drive in self._devices[hwclass.DISK]:
Line 1411: if not drive.extendable:
chunked? This is the first I've seen extendable.
Right, bad rename.
Line 1412: continue
Line 1413:
Line 1414: capacity, alloc, physical =
self._dom.blockInfo(drive.path, 0)
Line 1415: ret.append((drive, drive.volumeID, capacity, alloc,
physical))
--
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Check if a drive is chuhked before extending
Nir Soffer has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37573/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4776: # the worst case, we'll need to extend 'base' to the same size as 'top' Line 4777: # plus a bit more to accomodate additional writes to 'top' during the Line 4778: # live merge operation. Line 4779: if drive.chunked: Line 4780: self.extendDriveVolume(drive, baseVolUUID, topSize) What happens for a chain with a RAW base volume and a cow snapshot? Won't Before, we always called extend and in extendDriveVolume we use to skip the operation if Drive.blockDev was False. Now we call this only when Drive.blockDev == True and format == cow. How can it lead to trying to extend a raw volume? Line 4781: Line 4782: # Trigger the collection of stats before returning so that callers Line 4783: # of getVmStats after this returns will see the new job Line 4784: self._vmStats.sampleVmJobs() -- To view, visit http://gerrit.ovirt.org/37573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48416dde002272d45761296f176b97f4d870849d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add Drive.chunked property
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add Drive.chunked property .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2374/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15586/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14784/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15755/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/562/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change.
Change subject: networkTests: stop NetworkManager from managing devices using
NM_CONTROLLED=no
..
Patch Set 9: Verified+1
All tests (except those marked slow) were running on Fedora 21 even if left
on the same playground as NetworkManager.
testSetupNetworksAddOverExistingBond sadly made its comeback with:
OperStateChangedError: bond11 operstate changed: down - [('bond11', 'up'),
('bond11', 'up')]
--
To view, visit http://gerrit.ovirt.org/37037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: unify parameter 'dummy_name' naming with a variable name already used .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15593/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14791/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15762/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2630/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/569/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Unify Drive size units
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Unify Drive size units .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2378/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15594/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14792/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15763/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/570/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice01c9706fc27d4472c90e47bf7e808564ba0bfe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 1: Verified+1 Verified using the tests. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Check if a drive is chuhked before extending
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2375/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15587/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14785/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15756/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/563/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48416dde002272d45761296f176b97f4d870849d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...
Ondřej Svoboda has posted comments on this change. Change subject: dummy: unify parameter 'dummy_name' naming with a variable name already used .. Patch Set 1: Verified+1 Renaming only. (I fell to the hole I dug myself – anyone knows the proper English idiom?) -- To view, visit http://gerrit.ovirt.org/37728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15592/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14790/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15761/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2629/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/568/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15595/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14793/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15764/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2631/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/571/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for Drive.getNextVolumeSize
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for Drive.getNextVolumeSize .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/37725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2140af915f39c48803546ca7e44e07ae05872843 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2376/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15589/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14787/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15758/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/565/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Unify Drive size units
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Unify Drive size units .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2377/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15590/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14788/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15759/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/566/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice01c9706fc27d4472c90e47bf7e808564ba0bfe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15591/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14789/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15760/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2628/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/567/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add tests for Drive.getNextVolumeSize
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Add tests for Drive.getNextVolumeSize .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15588/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14786/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15757/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/564/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2140af915f39c48803546ca7e44e07ae05872843 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add missing vm id to get stats of down vm
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2371/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15576/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14774/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15745/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/552/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9534f2105b9a32ebd4b28dae42e265094a3655b9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: display directed-passthrough status in caps .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15582/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14780/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15751/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/558/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: remove a broken workaround for NM interfering ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: remove a broken workaround for NM interfering in DHCP tests .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15584/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14782/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15753/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2626/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/560/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba14753bf9cd37ec1659a49ba7e13b9478f3913 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: display directed-passthrough status in caps
..
hostdev: display directed-passthrough status in caps
Whether the underlying host supports directed passthrough can be
read via sysfs /sys/class/iommu, where support would be indicated
by pressence of dma remapping indicator - dmarX (where X = 0).
This patch exposes this fact in caps via directedPassthrough key.
Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Signed-off-by: Martin Polednik mpoled...@redhat.com
---
M vdsm/caps.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/37701/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index cb60e34..eee1032 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -596,6 +596,10 @@
return selinux
+def _getDirectedPassthrough():
+return bool(len(os.listdir('/sys/class/iommu')))
+
+
def get():
targetArch = getTargetArch()
@@ -688,6 +692,8 @@
caps['liveMerge'] = str(getLiveMergeSupport()).lower()
caps['kdumpStatus'] = _getKdumpStatus()
+caps['directedPassthrough'] = str(_getDirectedPassthrough())
+
return caps
--
To view, visit http://gerrit.ovirt.org/37701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik mpoled...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: give an instructory message when an address co...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: give an instructory message when an address could not be added .. Patch Set 1: Verified+1 Skipped tests (all of testDhclientLeases and testSetupNetworksAddDelDhcp instances) now inform that: SKIP : Failed to add the IPv6 address fdb3:84e5:4ff4:55e3::1/64 to device veth_xrSWAagFYW: ['RTNETLINK answers: Permission denied']; NetworkManager may have set the sysctl disable_ipv6 flag on the device, please see e.g. RH BZ #1102064 testSetupNetworksOverDhcpIface and testSetupNetworksReconfigureBridge do not currently add an IPv6 address and are thus unaffected. -- To view, visit http://gerrit.ovirt.org/37699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: forbid tabs in schema
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: forbid tabs in schema .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15578/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14776/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15747/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/554/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1689726cf8c598351948c9038ed91366cbbe4ee3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Invalidate drive blockDev when path changes
Adam Litke has posted comments on this change. Change subject: virt: Invalidate drive blockDev when path changes .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storageServer: Add log when isSession fails.
Maor Lipchuk has posted comments on this change. Change subject: storageServer: Add log when isSession fails. .. Patch Set 1: Awesome thanks! -- To view, visit http://gerrit.ovirt.org/37682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e84fdf4a4be2b70ccb304159c705197869cc51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: give an instructory message when an address co...
Ondřej Svoboda has uploaded a new change for review.
Change subject: networkTests: give an instructory message when an address could
not be added
..
networkTests: give an instructory message when an address could not be added
On recent Fedoras and EL7 NetworkManager sets the sysctl property disable_ipv6
on some interfaces (including veths) silently, as a workaround to IPv6LL
(link-local address) assignment clash between NM and the kernel, see e.g.
https://bugzilla.redhat.com/show_bug.cgi?id=1102064
In the next commits this problem will be addressed by telling NM to unmanage
our veth pairs and dummy devices.
Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M tests/functional/dummy.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/37699/1
diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py
index 92ce563..f036784 100644
--- a/tests/functional/dummy.py
+++ b/tests/functional/dummy.py
@@ -54,7 +54,12 @@
try:
addrAdd(dummyName, ipaddr, netmask, family)
except IPRoute2Error as e:
-raise SkipTest('Failed to set device ip: %s' % e)
+message = ('Failed to add the IPv%s address %s/%s to device %s: %s'
+ % (family, ipaddr, netmask, dummyName, e))
+if family == 6:
+message += ('; NetworkManager may have set the sysctl disable_ipv6'
+' flag on the device, please see e.g. RH BZ #1102064')
+raise SkipTest(message)
def setLinkUp(dummyName):
--
To view, visit http://gerrit.ovirt.org/37699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6af114383d06072fcd32f62a63728b5967c9f5d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Check if a drive is chuhked before extending
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Check if a drive is chuhked before extending .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2369/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14772/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15743/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/550/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48416dde002272d45761296f176b97f4d870849d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: factor out common fields in vm stats
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: factor out common fields in vm stats .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2372/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15579/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14777/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15748/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/555/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb9e8acf3a872e34ed0a2b90e99111a63606e64d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: display directed-passthrough status in caps
Martin Polednik has posted comments on this change. Change subject: hostdev: display directed-passthrough status in caps .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/37701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: remove a broken workaround for NM interfering ...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: remove a broken workaround for NM interfering in DHCP tests .. Patch Set 5: Verified+1 The tests still run and in order to not being skipped they depend on a stopped NetworkManager, except the code is cleaned of old cruft. -- To view, visit http://gerrit.ovirt.org/37041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idba14753bf9cd37ec1659a49ba7e13b9478f3913 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: require vmId in {Exited,Running}VmStats
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15577/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14775/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15746/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/553/ :
FAILURE
--
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Invalidate drive blockDev when path changes
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Invalidate drive blockDev when path changes .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2370/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15575/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14773/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15744/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/551/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add missing vm id to get stats of down vm
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2367/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15572/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14770/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15741/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/548/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9534f2105b9a32ebd4b28dae42e265094a3655b9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: add hostdev device definition
..
hostdev: add hostdev device definition
Using hostdev infrastructure for attaching a detaching devices
to/from host and passing them to VMs, this patch introduces the
device endpoint that is used for passing devices to VMs via
libvirt's hostdev element
Change-Id: I51f6713cf76914d8626718071598421bc1731722
Signed-off-by: Martin Polednik mpoled...@redhat.com
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/Makefile.am
M vdsm/virt/vmdevices/__init__.py
A vdsm/virt/vmdevices/hostdevice.py
M vdsm/virt/vmdevices/hwclass.py
7 files changed, 55 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/37700/1
diff --git a/debian/vdsm.install b/debian/vdsm.install
index cd71517..16a17ed 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -161,6 +161,7 @@
./usr/share/vdsm/virt/vmdevices/__init__.py
./usr/share/vdsm/virt/vmdevices/core.py
./usr/share/vdsm/virt/vmdevices/graphics.py
+./usr/share/vdsm/virt/vmdevices/hostdevice.py
./usr/share/vdsm/virt/vmdevices/hwclass.py
./usr/share/vdsm/virt/vmdevices/network.py
./usr/share/vdsm/virt/vmdevices/storage.py
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 9c810ad..17af0a6 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1072,6 +1072,7 @@
%{_datadir}/%{vdsm_name}/virt/vmdevices/__init__.py*
%{_datadir}/%{vdsm_name}/virt/vmdevices/core.py*
%{_datadir}/%{vdsm_name}/virt/vmdevices/graphics.py*
+%{_datadir}/%{vdsm_name}/virt/vmdevices/hostdevice.py*
%{_datadir}/%{vdsm_name}/virt/vmdevices/hwclass.py*
%{_datadir}/%{vdsm_name}/virt/vmdevices/network.py*
%{_datadir}/%{vdsm_name}/virt/vmdevices/storage.py*
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c85b803..a2b10a4 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -52,6 +52,7 @@
from logUtils import SimpleLogAdapter
import caps
import hooks
+import hostdev
import supervdsm
import numaUtils
@@ -779,7 +780,8 @@
(hwclass.REDIR, vmdevices.core.Redir),
(hwclass.RNG, vmdevices.core.Rng),
(hwclass.SMARTCARD, vmdevices.core.Smartcard),
- (hwclass.TPM, vmdevices.core.Tpm))
+ (hwclass.TPM, vmdevices.core.Tpm),
+ (hwclass.HOSTDEV, vmdevices.hostdevice.HostDevice))
def _makeDeviceDict(self):
return dict((dev, []) for dev, _ in self.DeviceMapping)
@@ -1694,6 +1696,11 @@
self._guestSockCleanup(self._guestSocketFile)
+def _reattachHostDevices(self):
+# reattach host devices
+for dev in self._devices[hwclass.HOSTDEV]:
+hostdev.reattach_detachable(dev.specParams['name'])
+
def setDownStatus(self, code, exitReasonCode, exitMessage=''):
if not exitMessage:
exitMessage = vmexitreason.exitReasons.get(exitReasonCode,
@@ -2039,6 +2046,7 @@
self._cleanupGuestAgent()
utils.rmFile(self._recoveryFile)
self._guestSockCleanup(self._qemuguestSocketFile)
+self._reattachHostDevices()
def _isDomainRunning(self):
try:
diff --git a/vdsm/virt/vmdevices/Makefile.am b/vdsm/virt/vmdevices/Makefile.am
index 71b0573..74dc033 100644
--- a/vdsm/virt/vmdevices/Makefile.am
+++ b/vdsm/virt/vmdevices/Makefile.am
@@ -23,6 +23,7 @@
__init__.py \
core.py \
graphics.py \
+ hostdevice.py \
hwclass.py \
network.py \
storage.py \
diff --git a/vdsm/virt/vmdevices/__init__.py b/vdsm/virt/vmdevices/__init__.py
index b9ff446..9c83b89 100644
--- a/vdsm/virt/vmdevices/__init__.py
+++ b/vdsm/virt/vmdevices/__init__.py
@@ -19,10 +19,11 @@
#
from . import core
+from . import hostdevice
from . import hwclass
from . import graphics
from . import network
from . import storage
# Silence pyflakes
-core, graphics, hwclass, network, storage
+core, graphics, hostdevice, hwclass, network, storage
diff --git a/vdsm/virt/vmdevices/hostdevice.py
b/vdsm/virt/vmdevices/hostdevice.py
new file mode 100644
index 000..9104b81
--- /dev/null
+++ b/vdsm/virt/vmdevices/hostdevice.py
@@ -0,0 +1,40 @@
+from hostdev import detach_detachable
+from . import core
+from . import hwclass
+
+
+class HostDevice(core.Base):
+__slots__ = ('name', '_deviceParams')
+
+def __init__(self, conf, log, **kwargs):
+super(HostDevice, self).__init__(conf, log, **kwargs)
+
+self._deviceParams = detach_detachable(self.specParams['name'])
+
+def getXML(self):
+hostdev = self.createXmlElem(hwclass.HOSTDEV, None)
+hostdev.setAttrs(managed='no', mode='subsystem',
+ type=self._deviceParams['capability'])
+source = hostdev.appendChildWithArgs('source')
+
+if 'bootOrder' in self.specParams:
+hostdev.appendChildWithArgs(
+
Change in vdsm[master]: storageServer: Add log when isSession fails.
Maor Lipchuk has abandoned this change. Change subject: storageServer: Add log when isSession fails. .. Abandoned Already fixed -- To view, visit http://gerrit.ovirt.org/37682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I82e84fdf4a4be2b70ccb304159c705197869cc51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipc...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add check for hostdev passthrough to caps
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add check for hostdev passthrough to caps .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15583/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14781/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/559/ : FAILURE -- To view, visit http://gerrit.ovirt.org/30471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789f93679740e87b2f5a88351261bc58852990d4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add Drive.chunked property
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add Drive.chunked property .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2368/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15573/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14771/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15742/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/549/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add check for hostdev passthrough to caps
Martin Polednik has posted comments on this change. Change subject: hostdev: add check for hostdev passthrough to caps .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/30471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I789f93679740e87b2f5a88351261bc58852990d4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add hostdev device definition
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add hostdev device definition .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/440/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/432/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2373/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15581/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/998/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14779/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15750/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/557/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/981/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/37700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Alona Kaplan alkap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Betak mbe...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add missing vm id to get stats of down vm
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: add missing vm id to get stats of down vm .. vm: add missing vm id to get stats of down vm The stats that are returned for a VM which is down does not contains the id of the VM. This was broken by 7f577ab94b35f2cb2560d3ae49d6b0f753588474, which failed to put the vmId in the 'Exited Vm Stats', but only in the 'Running Vm Stats' That causes a regression since the engine uses this id, without it hibernated VM is not destroyed, but remains down on the host. Thus, adding the vm-id back. Change-Id: I9534f2105b9a32ebd4b28dae42e265094a3655b9 Bug-Url: https://bugzilla.redhat.com/1191405 Signed-off-by: Arik Hadas aha...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37694 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/37694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9534f2105b9a32ebd4b28dae42e265094a3655b9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add missing vm id to get stats of down vm
Dan Kenigsberg has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 4: Code-Review+2 Raising -- To view, visit http://gerrit.ovirt.org/37694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9534f2105b9a32ebd4b28dae42e265094a3655b9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
Dan Kenigsberg has submitted this change and it was merged. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. qemu-img: check/use -T src_cache option in convert/rebase when available qemu-img is used for operations like disk move or snapshot delete. This process reads data using the hypervisor page cache. As this data might be hotter than any VM memory the system starts swapping out memory pages of the running VMs. vdsm already uses -t none option to avoid cache for output image. Now qemu-img introduced a new -T src_cache to avoid cache for the input image (bz#1116558). This patch is testing if qemu-img has the new -T src_cache option available for convert and rebase commands and using it with -T none when true. Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138690 Signed-off-by: Amador Pahim apa...@redhat.com Reviewed-on: http://gerrit.ovirt.org/36308 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Federico Simoncelli fsimo...@redhat.com --- M lib/vdsm/qemuimg.py M tests/qemuimgTests.py 2 files changed, 102 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved Amador Pahim: Verified -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: remove redundant slot
Dan Kenigsberg has posted comments on this change. Change subject: devices: remove redundant slot .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c70a233aade767dc181f9cfc90e5438ccd5a29 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: remove redundant slot
Dan Kenigsberg has submitted this change and it was merged. Change subject: devices: remove redundant slot .. devices: remove redundant slot 'device' slot is defined in Base class (core.py), there is no need to have it in child classes. Change-Id: Ie0c70a233aade767dc181f9cfc90e5438ccd5a29 Signed-off-by: Martin Polednik mpoled...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37656 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vmdevices/graphics.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit http://gerrit.ovirt.org/37656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0c70a233aade767dc181f9cfc90e5438ccd5a29 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemu-img: check/use -T src_cache option in convert/rebase ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: qemu-img: check/use -T src_cache option in convert/rebase when available .. Patch Set 14: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/630/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/229/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4613/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/606/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/233/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/631/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/233/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/219/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/626/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6452/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Amador Pahim apa...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...
Ondřej Svoboda has posted comments on this change. Change subject: dummy: unify parameter 'dummy_name' naming with a variable name already used .. Patch Set 2: Verified+1 Forgot to update a docstring. -- To view, visit http://gerrit.ovirt.org/37728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: additional info for disk and network .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/628/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/227/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4611/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/604/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/231/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/629/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/231/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/217/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/624/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6450/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 11: Verified+1 Removed the now unused veth.remove function. -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15598/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14796/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15767/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2634/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/574/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add missing vm id to get stats of down vm
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add missing vm id to get stats of down vm .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/626/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/225/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4609/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/602/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/229/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/627/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/229/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/215/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/622/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6448/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9534f2105b9a32ebd4b28dae42e265094a3655b9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Arik Hadas aha...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15596/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14794/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15765/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2632/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/572/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for reporting usb addresses
Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: add support for reporting usb addresses .. hostdev: add support for reporting usb addresses This patch extends the address field in hostdev tree that holds map of address fields relevant to the device. This is required in order to passthrough a usb device. usb_device is used because it is libvirt standard used for viable devices. Change-Id: I3d4a4e1d3703abd25c9fa0584ec0e0a1d52b685c Signed-off-by: Martin Polednik mpoled...@redhat.com Reviewed-on: http://gerrit.ovirt.org/35785 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/hostdevTests.py M vdsm/hostdev.py 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit http://gerrit.ovirt.org/35785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d4a4e1d3703abd25c9fa0584ec0e0a1d52b685c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/627/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/226/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4610/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/603/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/230/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/628/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/230/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/216/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/623/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6449/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15602/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14800/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15771/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2638/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/578/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Move status constant to vmstatus .. virt: Move status constant to vmstatus _get_lastStatus was creating a temporary tuple using values from vmstatus. The repeating vmstatus. tells us that the code belongs to the vmstatus module. Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37677 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Vinzenz Feenstra vfeen...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py M vdsm/virt/vmstatus.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
Dan Kenigsberg has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add ExpiringCache
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: add ExpiringCache .. virt: add ExpiringCache ExpiringCache is a simple cache with expiring time attached to keys. This class implements parts of the dict() interface, but do not aims to be a full replacement for dict()s. ExpiringCache is thread safe. Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: http://gerrit.ovirt.org/36716 Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/Makefile.am A tests/vmUtilsTests.py M vdsm/virt/utils.py 3 files changed, 161 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add ExpiringCache
Dan Kenigsberg has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added gluster snapshot restore verb.
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Added gluster snapshot restore verb. .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I422fab5bc9ec9dc51d759bad46487c60051bbfc1 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15600/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14798/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2636/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/576/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added gluster snapshot restore verb.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: Added gluster snapshot restore verb.
..
gluster: Added gluster snapshot restore verb.
This patch adds verb to restore gluster volume
snapshot.
*glusterSnapshotRestore: Restores a gluster volume snapshot.
Takes snapshot name as an argunment.
Returns:
{'volumeName': 'vol1',
'volumeUuid': 'uuid',
'snapshotName': 'snap2',
'snapshotUuid': 'uuid'}
Change-Id: I422fab5bc9ec9dc51d759bad46487c60051bbfc1
Signed-off-by: Darshan N dnara...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/34638
Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M client/vdsClientGluster.py
M tests/Makefile.am
A tests/glusterSnapshotRestore.xml
M tests/glusterTestData.py
M tests/gluster_cli_tests.py
M vdsm.spec.in
M vdsm/gluster/api.py
M vdsm/gluster/apiwrapper.py
M vdsm/gluster/cli.py
M vdsm/gluster/exception.py
M vdsm/rpc/vdsmapi-gluster-schema.json
11 files changed, 126 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Darshan N: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I422fab5bc9ec9dc51d759bad46487c60051bbfc1
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Darshan N dnara...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for reporting usb addresses
Dan Kenigsberg has posted comments on this change. Change subject: hostdev: add support for reporting usb addresses .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/35785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4a4e1d3703abd25c9fa0584ec0e0a1d52b685c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ondřej Svoboda has uploaded a new change for review. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Signed-off-by: Ondřej Svoboda osvob...@redhat.com --- M tests/functional/dummy.py M tests/netinfoTests.py M tests/samplingTests.py 3 files changed, 24 insertions(+), 24 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/37733/1 diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py index 9385e45..8594734 100644 --- a/tests/functional/dummy.py +++ b/tests/functional/dummy.py @@ -16,6 +16,8 @@ # # Refer to the README and COPYING files for full details of the license # +from contextlib import contextmanager + from nose.plugins.skip import SkipTest from vdsm.ipwrapper import linkAdd, linkDel, addrAdd, linkSet, IPRoute2Error @@ -53,6 +55,15 @@ (dummy_name, e)) +@contextmanager +def device(prefix='dummy_', max_length=11): +dummy_name = create() +try: +yield dummy_name +finally: +remove(dummy_name) + + def setIP(dummy_name, ipaddr, netmask, family=4): try: addrAdd(dummy_name, ipaddr, netmask, family) diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py index b64cc94..ef4bf64 100644 --- a/tests/netinfoTests.py +++ b/tests/netinfoTests.py @@ -182,21 +182,19 @@ with MonkeyPatchScope([(ipwrapper.Link, '_fakeNics', ['veth_*', 'dummy_*'])]): with veth.pair() as (v1a, v1b): -d1 = dummy.create() -fakes = set([d1, v1a, v1b]) -nics = netinfo.nics() -dummy.remove(d1) -self.assertTrue(fakes.issubset(nics), 'Fake devices %s are not' -' listed in nics %s' % (fakes, nics)) +with dummy.device() as d1: +fakes = set([d1, v1a, v1b]) +nics = netinfo.nics() +self.assertTrue(fakes.issubset(nics), 'Fake devices %s are' +' not listed in nics %s' % (fakes, nics)) with veth.pair(prefix='mehv_') as (v2a, v2b): -d2 = dummy.create(prefix='mehd_') -hiddens = set([d2, v2a, v2b]) -dummy.remove(d2) -nics = netinfo.nics() -self.assertFalse(hiddens.intersection(nics), 'Some of hidden ' - 'devices %s is shown in nics %s' % (hiddens, - nics)) +with dummy.device(prefix='mehd_') as d2: +hiddens = set([d2, v2a, v2b]) +nics = netinfo.nics() +self.assertFalse(hiddens.intersection(nics), 'Some of ' + 'hidden devices %s is shown in nics %s' % + (hiddens, nics)) def testGetIfaceCfg(self): deviceName = ___This_could_never_be_a_device_name___ diff --git a/tests/samplingTests.py b/tests/samplingTests.py index 1d0dd4d..3585530 100644 --- a/tests/samplingTests.py +++ b/tests/samplingTests.py @@ -112,15 +112,6 @@ @contextmanager -def dummy_if(): -dummy_name = dummy.create() -try: -yield dummy_name -finally: -dummy.remove(dummy_name) - - -@contextmanager def vlan(name, link, vlan_id): ipwrapper.linkAdd(name, 'vlan', link=link, args=['id', str(vlan_id)]) try: @@ -150,7 +141,7 @@ hs_before = sampling.HostSample(os.getpid()) interfaces_before = set(hs_before.interfaces.iterkeys()) -with dummy_if() as dummy_name: +with dummy.device() as dummy_name: hs_after = sampling.HostSample(os.getpid()) interfaces_after = set(hs_after.interfaces.iterkeys()) interfaces_diff = interfaces_after - interfaces_before @@ -167,7 +158,7 @@ with MonkeyPatchScope( [(ipwrapper, 'getLinks', faultyGetLinks)]): -with dummy_if() as dummy_name: +with dummy.device() as dummy_name: with vlan(self.NEW_VLAN, dummy_name, 999): hs = sampling.HostSample(os.getpid()) self.assertNotIn(self.NEW_VLAN, hs.interfaces) -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15599/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14797/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15768/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2635/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/575/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15601/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14799/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15770/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2637/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/577/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: unify parameter 'dummy_name' naming with a variable n...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: unify parameter 'dummy_name' naming with a variable name already used .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15597/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14795/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15766/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2633/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/573/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb59dadc45127ca09d2b850dab7ba8e861543bd7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: additional info for disk and network
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: additional info for disk and network
..
v2v: additional info for disk and network
disk now return type ('disk', 'cdrom' etc)
network now return type ('e1000', 'rtl' etc)
Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Signed-off-by: Shahar Havivi shah...@redhat.com
Reviewed-on: http://gerrit.ovirt.org/37655
Tested-by: Shahar Havivi shav...@redhat.com
Reviewed-by: Francesco Romani from...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/v2v.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Shahar Havivi: Verified
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Shahar Havivi shav...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: stop NetworkManager from managing devices usin...
Ondřej Svoboda has posted comments on this change. Change subject: networkTests: stop NetworkManager from managing devices using NM_CONTROLLED=no .. Patch Set 12: Verified+1 Mentioned the tiny shortcoming: we make NetworkManager the owner of one veth side twice. Enjoy, NetworkManager. -- To view, visit http://gerrit.ovirt.org/37037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add ExpiringCache
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: add ExpiringCache .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/629/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/228/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4612/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/605/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/232/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/630/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/232/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/218/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/625/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6451/ : FAILURE -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
Ondřej Svoboda has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: Verified+1 Unit tests passed with the exception of ERRORs in testHostSampleHandlesDisappearingVlanInterfaces and testHostSampleReportsNewInterface The two tests failed before this change on File /root/vdsm/tests/samplingTests.py, line 163, in testHostSampleHandlesDisappearingVlanInterfaces hs = sampling.HostSample(os.getpid()) File /root/vdsm/vdsm/virt/sampling.py, line 281, in __init__ self.numaNodeMem = NumaNodeMemorySample() File /root/vdsm/vdsm/virt/sampling.py, line 173, in __init__ memInfo = caps.getMemoryStatsByNumaCell(int(nodeIndex)) File /root/vdsm/vdsm/caps.py, line 356, in getMemoryStatsByNumaCell cellMemInfo = libvirtconnection.get().getMemoryStats(cell, 0) AttributeError: 'virConnect' object has no attribute 'getMemoryStats' -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added gluster snapshot restore verb.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Added gluster snapshot restore verb. .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/633/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/232/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4616/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/609/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/236/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/634/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/236/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/222/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/629/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6455/ : FAILURE -- To view, visit http://gerrit.ovirt.org/34638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I422fab5bc9ec9dc51d759bad46487c60051bbfc1 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dummy: move dummy_if from samplingTests as dummy.device, use...
oVirt Jenkins CI Server has posted comments on this change. Change subject: dummy: move dummy_if from samplingTests as dummy.device, use in netinfoTests .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15603/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14801/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15772/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2639/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/579/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd114b313a08f92503e6e7ba643f3c565a4eaf7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for reporting usb addresses
oVirt Jenkins CI Server has posted comments on this change. Change subject: hostdev: add support for reporting usb addresses .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/632/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/231/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4615/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/608/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/235/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/633/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/235/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/221/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/628/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6454/ : FAILURE -- To view, visit http://gerrit.ovirt.org/35785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4a4e1d3703abd25c9fa0584ec0e0a1d52b685c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testSetupNetworksAddDelDhcp: shorten before adding checks fo...
oVirt Jenkins CI Server has posted comments on this change. Change subject: testSetupNetworksAddDelDhcp: shorten before adding checks for gateways .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15604/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14802/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15773/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2640/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/580/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c58858481b10b6adc0faa35568f678328cce554 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: devices: remove redundant slot
oVirt Jenkins CI Server has posted comments on this change. Change subject: devices: remove redundant slot .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/631/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/230/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4614/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/607/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/234/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/632/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/234/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/220/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/627/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6453/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0c70a233aade767dc181f9cfc90e5438ccd5a29 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testSetupNetworksAddDelDhcp: check that gateways are reporte...
oVirt Jenkins CI Server has posted comments on this change. Change subject: testSetupNetworksAddDelDhcp: check that gateways are reported correctly .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15605/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14803/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15774/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2641/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/581/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If30824f38ecc35b1e2843ed9bed9b7d092008f8a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testSetupNetworksAddDelDhcp: check that IPv4 gateways are re...
oVirt Jenkins CI Server has posted comments on this change. Change subject: testSetupNetworksAddDelDhcp: check that IPv4 gateways are reported correctly .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15607/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14805/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15776/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2642/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/583/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If30824f38ecc35b1e2843ed9bed9b7d092008f8a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testSetupNetworksAddDelDhcp: shorten before adding checks fo...
Ondřej Svoboda has posted comments on this change. Change subject: testSetupNetworksAddDelDhcp: shorten before adding checks for gateways .. Patch Set 3: Verified+1 testSetupNetworksAddDelDhcp works as usual, the change does not affect functionality. -- To view, visit http://gerrit.ovirt.org/37679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c58858481b10b6adc0faa35568f678328cce554 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfoTests: no need to import each and every netinfo function
Ondřej Svoboda has posted comments on this change. Change subject: netinfoTests: no need to import each and every netinfo function .. Patch Set 2: Verified+1 Unit tests passed, except two as with http://gerrit.ovirt.org/#/c/37733/ -- To view, visit http://gerrit.ovirt.org/37681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a7897e69d02da44d74c1a9f51faa7dde540cc8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: filter out networks with unconfigured bonds
Ondřej Svoboda has posted comments on this change. Change subject: network: filter out networks with unconfigured bonds .. Patch Set 1: Code-Review+1 I see no problem here :-) -- To view, visit http://gerrit.ovirt.org/37569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I408fb59bf80c9ae69fb4abb45aae35507e910407 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _get_gateway: allow duplicated gateways if they are in fact ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: _get_gateway: allow duplicated gateways if they are in fact the same routes .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15608/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14806/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15777/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2643/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/584/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia59155dd959e58b81e4149fa4cf2bd406f6404a1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfoTests: no need to import each and every netinfo function
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfoTests: no need to import each and every netinfo function .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15606/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14804/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15775/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/582/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5a7897e69d02da44d74c1a9f51faa7dde540cc8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: change objectivizeNetwork to private
Ondřej Svoboda has posted comments on this change. Change subject: network: change objectivizeNetwork to private .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b83081f453cef8de2b698152869c35850a036b3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Better logging for network restoration.
Ondřej Svoboda has posted comments on this change. Change subject: Better logging for network restoration. .. Patch Set 1: Nice :-) -- To view, visit http://gerrit.ovirt.org/37506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc4be51ec3f8af210f2b4a0acdc52e372835239 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testSetupNetworksAddDelDhcp: check that IPv4 gateways are re...
Ondřej Svoboda has posted comments on this change. Change subject: testSetupNetworksAddDelDhcp: check that IPv4 gateways are reported correctly .. Patch Set 3: Verified+1 Indeed the test passes although it is sad we cannot get an IPv6 gateway from dnsmasq. -- To view, visit http://gerrit.ovirt.org/37680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If30824f38ecc35b1e2843ed9bed9b7d092008f8a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: _get_gateway: allow duplicated gateways if they are in fact ...
oVirt Jenkins CI Server has posted comments on this change. Change subject: _get_gateway: allow duplicated gateways if they are in fact the same routes .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15609/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14807/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15778/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2644/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/585/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia59155dd959e58b81e4149fa4cf2bd406f6404a1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: networkTests: show the dnsmasq command on failure to ease de...
oVirt Jenkins CI Server has posted comments on this change. Change subject: networkTests: show the dnsmasq command on failure to ease debugging on EL6 .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15610/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14808/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15779/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/586/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9236fa93b9050b68b0e0d1c316e5a3706f678c7c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testSetupNetworksOverDhcpIface: respect the system version f...
Ondřej Svoboda has uploaded a new change for review. Change subject: testSetupNetworksOverDhcpIface: respect the system version for dnsmasq .. testSetupNetworksOverDhcpIface: respect the system version for dnsmasq Change-Id: I692f09f406dd10746b79edcec04f9c564f180efc Signed-off-by: Ondřej Svoboda osvob...@redhat.com --- M tests/functional/networkTests.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/37735/1 diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py index 7edd21b..5e69625 100644 --- a/tests/functional/networkTests.py +++ b/tests/functional/networkTests.py @@ -2167,7 +2167,7 @@ with veth.pair() as (server, client): veth.setIP(server, IP_ADDRESS, IP_CIDR) veth.setLinkUp(server) -with dnsmasqDhcp(server): +with dnsmasqDhcp(server, _system_is_el6()): with namedTemporaryDir(dir='/var/lib/dhclient') as dhdir: # Start a non-vdsm owned dhclient for the 'client' iface dhclient_runner = dhcp.DhclientRunner( -- To view, visit http://gerrit.ovirt.org/37735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I692f09f406dd10746b79edcec04f9c564f180efc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
