Change in vdsm[master]: stomp: parsing buffer refactoring
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: parsing buffer refactoring .. Patch Set 4: Code-Review+1 Francesco, can you re-visit the patch? -- To view, visit https://gerrit.ovirt.org/38666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: persistence: skip bonds owned and used by vdsm
automat...@ovirt.org has posted comments on this change. Change subject: network: persistence: skip bonds owned and used by vdsm .. Patch Set 4: * Update tracker::#1154399::OK * Set MODIFIED::bug 1154399#1154399IGNORE, not all related patches are closed, check 38771 -- To view, visit https://gerrit.ovirt.org/38597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb643a0c3681631db7bd875a03ebdb91fd893e70 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: persistence: skip bonds owned and used by vdsm
Yaniv Bronhaim has submitted this change and it was merged. Change subject: network: persistence: skip bonds owned and used by vdsm .. network: persistence: skip bonds owned and used by vdsm When upgrading bonds to unified persistence, we should skip foreign bond (a bond that has ifcfg-bond lacking the generated by vdsm header). However, if any of these bonds is used by a vdsm network, it must be persisted. Otherwise, calling restore_net removes the bond (when it cleans current running config) but it fails to re-create it from the persistent config. Change-Id: Idb643a0c3681631db7bd875a03ebdb91fd893e70 Signed-off-by: Petr Horáček phora...@redhat.com Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1154399 Reviewed-on: https://gerrit.ovirt.org/38587 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38597 --- M lib/vdsm/tool/unified_persistence.py A tests/netUnifiedPersistenceTests.py 2 files changed, 176 insertions(+), 2 deletions(-) Approvals: Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb643a0c3681631db7bd875a03ebdb91fd893e70 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: parsing buffer refactoring
Piotr Kliczewski has posted comments on this change. Change subject: stomp: parsing buffer refactoring .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38666/4//COMMIT_MSG Commit Message: Line 7: stomp: parsing buffer refactoring Line 8: Line 9: Refactored how we manage buffer and parser state in Parser class. Fixing Line 10: spelling in Subscription class name and extending default buffer size in Line 11: AsyncDispatcher. This is an improvement, but we still lack rationale for these changes, whic Done Line 12: Line 13: Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Line 14: Signed-off-by: pkliczewski piotr.kliczew...@gmail.com -- To view, visit https://gerrit.ovirt.org/38666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: tests: add error code checking
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: tests: add error code checking .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16820/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16992/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2805/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: tests: add error code checking
automat...@ovirt.org has posted comments on this change. Change subject: network: tests: add error code checking .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/38865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: tests: add error code checking
automat...@ovirt.org has posted comments on this change. Change subject: network: tests: add error code checking .. Patch Set 2: * Update tracker::#1154399::OK * Check Bug-Url::OK * Check Public Bug::#1154399::OK, public bug * Check Product::#1154399::OK, Correct product oVirt * Check TR::#1154399::OK, correct target release 3.5.2 * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/38865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: models: tag non-VDSM devices used by VDSM
automat...@ovirt.org has posted comments on this change. Change subject: network: models: tag non-VDSM devices used by VDSM .. Patch Set 2: * Update tracker::#1154399::OK * Check Bug-Url::OK * Check Public Bug::#1154399::OK, public bug * Check Product::#1154399::OK, Correct product oVirt * Check TR::#1154399::OK, correct target release 3.5.2 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/38771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: models: tag non-VDSM devices used by VDSM
Petr Horáček has posted comments on this change. Change subject: network: models: tag non-VDSM devices used by VDSM .. Patch Set 2: Verified+1 Passed network's functional tests except unrelated ChangedOperstate errors. Passed net* unit tests except unrelated testGetBondingOptions. Test fails on ovirt-3.5 branch without this patch. -- To view, visit https://gerrit.ovirt.org/38771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fetch disperse count and redundacy count for volume
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Fetch disperse count and redundacy count for volume .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/751/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/347/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4732/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/724/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/352/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/753/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/351/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/341/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/757/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eb9190a7531751c4c62e3eff425c3526101b9d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Report info needed for refreshing devices
Fred Rolland has posted comments on this change. Change subject: hsm: Report info needed for refreshing devices .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/38675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfa5cf4321202362f5a00dad7c9a0347ba52ec71 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Candace Sheremeta csher...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
automat...@ovirt.org has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 3: * Update tracker::#1196327::OK * Check Bug-Url::OK * Check Public Bug::#1196327::OK, public bug * Check Product::#1196327::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/35940/9/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 438: parser.parse(data) Line 439: Line 440: frameHandler = self._frameHandler Line 441: while parser.pending 0: Line 442: frameHandler.handle_frame(self, parser.popFrame()) you still have the redundant frameHandler. and will handle_frame always exist in any dispatcher? are you sure that the hasattr is redundant in this part? Line 443: Line 444: def popFrame(self): Line 445: return self._parser.popFrame() Line 446: -- To view, visit https://gerrit.ovirt.org/35940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fetch disperse count and redundacy count for volume
Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Fetch disperse count and redundacy count for volume .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/38305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eb9190a7531751c4c62e3eff425c3526101b9d1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: models: tag non-VDSM devices used by VDSM
Petr Horáček has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/38771/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2187: self.vdsm_net.save_config()
Line 2188:
Line 2189: @cleanupNet
Line 2190: @ValidateRunningAsRoot
Line 2191: def test_setupNetworks_on_external_vlaned_bond(self):
maybe the train left already.
yep, it fails without this patch.
Line 2192: with dummyIf(1) as (nic, ):
Line 2193: with open(NET_CONF_PREF + nic, 'w') as f:
Line 2194: f.write(DEVICE=%s
Line 2195: MASTER=%s
Line 2212: BOOTPROTO=static
Line 2213: NM_CONTROLLED=no
Line 2214: HOTPLUG=no % (BONDING_NAME, VLAN_ID))
Line 2215:
Line 2216: rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME])
might be worthwhile to check that those commands succeeded so the test won'
Done
Line 2217: rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME + '.' +
VLAN_ID])
Line 2218:
Line 2219: status, msg = self.vdsm_net.setupNetworks(
Line 2220: {NETWORK_NAME: {'bonding': BONDING_NAME, 'bridged':
True,
--
To view, visit https://gerrit.ovirt.org/38771
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: models: tag non-VDSM devices used by VDSM
Dan Kenigsberg has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38771/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2212: BOOTPROTO=static
Line 2213: NM_CONTROLLED=no
Line 2214: HOTPLUG=no % (BONDING_NAME, VLAN_ID))
Line 2215:
Line 2216: rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME])
might be worthwhile to check that those commands succeeded so the test won'
+1, but this must be done on the master branch first.
Line 2217: rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME + '.' +
VLAN_ID])
Line 2218:
Line 2219: status, msg = self.vdsm_net.setupNetworks(
Line 2220: {NETWORK_NAME: {'bonding': BONDING_NAME, 'bridged':
True,
--
To view, visit https://gerrit.ovirt.org/38771
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Verified+1 restore score after yet another cross-check (OK) -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split network restoration from vdsmd.service
Petr Horáček has posted comments on this change. Change subject: split network restoration from vdsmd.service .. Patch Set 15: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/29441/15//COMMIT_MSG Commit Message: Line 12: ExecStartPre stage, it might kill dhclient, if that was spawned on Line 13: dhcp persistent interfaces. Line 14: Line 15: This patch splits systemd vdsm service into 2 dependant units: Line 16: 1. vdsm-network.service which upgrades unified persistence and 3.0.0 . Line 17:networks if needed and then restore networks as it's main mission Line 18: Line 19: 2: vdsmd.service which reconfigure the persistent network configuration Line 20:of vdsm using the configured net_configurator Line 15: This patch splits systemd vdsm service into 2 dependant units: Line 16: 1. vdsm-network.service which upgrades unified persistence and 3.0.0 Line 17:networks if needed and then restore networks as it's main mission Line 18: Line 19: 2: vdsmd.service which reconfigure the persistent network configuration : Line 20:of vdsm using the configured net_configurator Line 21: Line 22: Note that from now on, disabling vdsmd cannot render the machine Line 23: unaccessible as the vdsm networks will be started upon boot. -- To view, visit https://gerrit.ovirt.org/29441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Have the protocol detector use the Reactor
Yaniv Bronhaim has posted comments on this change. Change subject: Have the protocol detector use the Reactor .. Patch Set 13: Code-Review+1 please add more tests for those parts in following patch -- To view, visit https://gerrit.ovirt.org/37098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1cc2a205cdad335e8c3af4a77ed49c8977a79ba Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Fix callMethod in JsonRpcClient
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Fix callMethod in JsonRpcClient .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/35935/9/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 304: self._transport.connect() Line 305: Line 306: def callMethod(self, methodName, params=[], rid=None): Line 307: resp = self.call(JsonRpcRequest(methodName, params, rid))[0] Line 308: if resp.error: is it possible to get AttributeError in this case? or error will always be error is part of the protocol and by definition we can have result or error. When we hold error it means that we caught exception on the server side so on the client side we want to notify user about it. Line 309: raise JsonRpcError(resp.error['code'], resp.error['message']) Line 310: Line 311: return resp.result Line 312: -- To view, visit https://gerrit.ovirt.org/35935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf78f3b7f5d32c10339bbe6b49ce9b93662b4bb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fetch disperse count and redundacy count for volume
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Fetch disperse count and redundacy count for volume .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/38305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eb9190a7531751c4c62e3eff425c3526101b9d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: models: tag non-VDSM devices used by VDSM
automat...@ovirt.org has posted comments on this change. Change subject: network: models: tag non-VDSM devices used by VDSM .. Patch Set 3: * Update tracker::#1154399::OK * Check Bug-Url::OK * Check Public Bug::#1154399::OK, public bug * Check Product::#1154399::OK, Correct product oVirt * Check TR::#1154399::OK, correct target release 3.5.2 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/38771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: models: tag non-VDSM devices used by VDSM
Ido Barkan has posted comments on this change. Change subject: network: models: tag non-VDSM devices used by VDSM .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/35940/9/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 438: parser.parse(data) Line 439: Line 440: frameHandler = self._frameHandler Line 441: while parser.pending 0: Line 442: frameHandler.handle_frame(self, parser.popFrame()) you still have the redundant frameHandler. and will handle_frame always exi Yes, I checked and we do not need hasattr. I missed redundant frameHandler. Will fix. Line 443: Line 444: def popFrame(self): Line 445: return self._parser.popFrame() Line 446: -- To view, visit https://gerrit.ovirt.org/35940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: persistence: skip bonds owned and used by vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: network: persistence: skip bonds owned and used by vdsm .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/185/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/15/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/186/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/183/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38597 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb643a0c3681631db7bd875a03ebdb91fd893e70 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fetch disperse count and redundacy count for volume
Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: Fetch disperse count and redundacy count for volume .. gluster: Fetch disperse count and redundacy count for volume Modified the verb glusterVolumeInfo to fetch disperse count and redundancy count also. Change-Id: I4eb9190a7531751c4c62e3eff425c3526101b9d1 Signed-off-by: Shubhendu Tripathi shtri...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38305 Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/gluster_cli_tests.py M vdsm/gluster/cli.py M vdsm/rpc/vdsmapi-gluster-schema.json 3 files changed, 27 insertions(+), 10 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Shubhendu Tripathi: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4eb9190a7531751c4c62e3eff425c3526101b9d1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: tests: add error code checking
Petr Horáček has uploaded a new change for review.
Change subject: network: tests: add error code checking
..
network: tests: add error code checking
Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570
Signed-off-by: Petr Horáček phora...@redhat.com
---
M tests/functional/networkTests.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/38865/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 8af47e4..075fac4 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2213,8 +2213,10 @@
NM_CONTROLLED=no
HOTPLUG=no % (BONDING_NAME, VLAN_ID))
-rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME])
-rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME + '.' + VLAN_ID])
+rc, _, err = execCmd([EXT_IFUP, BONDING_NAME])
+self.assertEqual(rc, SUCCESS, err)
+rc, _, err = execCmd([EXT_IFUP, BONDING_NAME + '.' + VLAN_ID])
+self.assertEqual(rc, SUCCESS, err)
status, msg = self.vdsm_net.setupNetworks(
{NETWORK_NAME: {'bonding': BONDING_NAME, 'bridged': True,
--
To view, visit https://gerrit.ovirt.org/38865
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček phora...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require MOM aware of 'onlyUUID'
Francesco Romani has abandoned this change. Change subject: spec: require MOM aware of 'onlyUUID' .. Abandoned using 38805 this is not needed anymore -- To view, visit https://gerrit.ovirt.org/38711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0eed58fbacfc9168414c080b0e682d2711cb7d49 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: require MOM aware of 'onlyUUID'
automat...@ovirt.org has posted comments on this change. Change subject: spec: require MOM aware of 'onlyUUID' .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/38711 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0eed58fbacfc9168414c080b0e682d2711cb7d49 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Michal Skrivanek has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Michal Skrivanek has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add createBrick verb
Piotr Kliczewski has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 25: Code-Review+1 Api and schema changes looks good. -- To view, visit https://gerrit.ovirt.org/35498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Fix callMethod in JsonRpcClient
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Fix callMethod in JsonRpcClient .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/35935/9/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 304: self._transport.connect() Line 305: Line 306: def callMethod(self, methodName, params=[], rid=None): Line 307: resp = self.call(JsonRpcRequest(methodName, params, rid))[0] Line 308: if resp.error: is it possible to get AttributeError in this case? or error will always be part of the response ? why do you change the if error in resp? Line 309: raise JsonRpcError(resp.error['code'], resp.error['message']) Line 310: Line 311: return resp.result Line 312: -- To view, visit https://gerrit.ovirt.org/35935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf78f3b7f5d32c10339bbe6b49ce9b93662b4bb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fetch disperse count and redundacy count for volume
Dan Kenigsberg has posted comments on this change. Change subject: gluster: Fetch disperse count and redundacy count for volume .. Patch Set 5: Code-Review+2 Raising Timothy's and Pioter's score. -- To view, visit https://gerrit.ovirt.org/38305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4eb9190a7531751c4c62e3eff425c3526101b9d1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: parsing buffer refactoring
Francesco Romani has posted comments on this change. Change subject: stomp: parsing buffer refactoring .. Patch Set 4: (1 comment) I trust you infra devs, and I can imagine tracking down rationale for this patch may be not-trivial, but we still lack on documentation. https://gerrit.ovirt.org/#/c/38666/4//COMMIT_MSG Commit Message: Line 7: stomp: parsing buffer refactoring Line 8: Line 9: Refactored how we manage buffer and parser state in Parser class. Fixing Line 10: spelling in Subscription class name and extending default buffer size in Line 11: AsyncDispatcher. This is an improvement, but we still lack rationale for these changes, which should be the backbone of the commit message. To make things easier, you may want to split this patch like: - spelling mistake fix (no-brainer to review and verify) - increase of buffer size to 4096 (maybe move that to a constant?), trivial to review, hopefully easier to provide rationale - core refactoring of the buffer, move from cStringIO to string. I still don't get why we need so. Well, I can imagine, but that's it. Line 12: Line 13: Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Line 14: Signed-off-by: pkliczewski piotr.kliczew...@gmail.com -- To view, visit https://gerrit.ovirt.org/38666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: network: models: tag non-VDSM devices used by VDSM
Ido Barkan has posted comments on this change. Change subject: network: models: tag non-VDSM devices used by VDSM .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38771 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Verified+1 VDSM master works also against Engine 3.4.4 (as expected since XMLRPC is not changed in 3.5.x). -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Verified in deep together with 38805 but *NEVER* in isolation. See comments in 38805 for documentation of verification steps and log excerpts. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Make sure the \0 is a last char in the buffer
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: Make sure the \0 is a last char in the buffer .. Patch Set 9: Code-Review+1 its different patch - https://gerrit.ovirt.org/#/c/37018/2/lib/yajsonrpc/stomp.py -- To view, visit https://gerrit.ovirt.org/35938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: tests: add error code checking
Petr Horáček has uploaded a new change for review.
Change subject: network: tests: add error code checking
..
network: tests: add error code checking
Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570
Signed-off-by: Petr Horáček phora...@redhat.com
---
M tests/functional/networkTests.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/38860/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index db22006..8671244 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2369,8 +2369,10 @@
NM_CONTROLLED=no
HOTPLUG=no % (BONDING_NAME, VLAN_ID))
-rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME])
-rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME + '.' + VLAN_ID])
+rc, _, err = execCmd([EXT_IFUP, BONDING_NAME])
+self.assertEqual(rc, SUCCESS, err)
+rc, _, err = execCmd([EXT_IFUP, BONDING_NAME + '.' + VLAN_ID])
+self.assertEqual(rc, SUCCESS, err)
status, msg = self.vdsm_net.setupNetworks(
{NETWORK_NAME: {'bonding': BONDING_NAME, 'bridged': True,
--
To view, visit https://gerrit.ovirt.org/38860
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček phora...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: tests: add error code checking
automat...@ovirt.org has posted comments on this change. Change subject: network: tests: add error code checking .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: -Verified -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 5:
Additional Verification (on Isolation): VDSM Master with Engine Master:
JSONRPC:
Thread-77::DEBUG::2015-03-18
11:05:13,139::__init__::469::jsonrpc.JsonRpcServer::(_serveRequest) Calling
'Host.getVMFullList' in bridge with {u'vmList':
[u'995a5f50-9f77-479d-9f05-acc00965dd3e']}
JsonRpcServer::DEBUG::2015-03-18
11:05:13,139::__init__::506::jsonrpc.JsonRpcServer::(serve_requests) Waiting
for request
Thread-77::DEBUG::2015-03-18
11:05:13,140::__init__::500::jsonrpc.JsonRpcServer::(_serveRequest) Return
'Host.getVMFullList' in bridge with [{u'acpiEnable': u'true',
u'emulatedMachine': u'rhel6.5.0', 'pid': '18719', u'memGuaranteedSize': 8192,
u'spiceSslCipherSuite': u'DEFAULT', 'displaySecurePort': u'5900',
u'timeOffset': u'0', u'cpuType': u'SandyBridge', u'smp': u'2', 'pauseCode':
'NOERR', u'smartcardEnable': u'false', u'custom':
{u'device_b0a9483f-8106-4a62-9deb-94d701194647device_9a8c7e80-cd0b-4454-8974-5aebc6151e5e':
u'VmDevice {vmId=995a5f50-9f77-479d-9f05-acc00965dd3e,
deviceId=9a8c7e80-cd0b-4454-8974-5aebc6151e5e, device=ide, type=CONTROLLER,
bootOrder=0, specParams={}, address={slot=0x01, bus=0x00, domain=0x,
type=pci, function=0x1}, managed=false, plugged=true, readOnly=false,
deviceAlias=ide0, customProperties={}, snapshotId=null, logicalName=null}',
u'device_b0a9483f-8106-4a62-9deb-94d701194647': u'VmDevice
{vmId=995a5f50-9f77-479d-9f05-acc00965dd3e, deviceId!
=b0a9483f-8106-4a62-9deb-94d701194647, device=virtio-serial, type=CONTROLLER,
bootOrder=0, specParams={}, address={slot=0x04, bus=0x00, domain=0x,
type=pci, function=0x0}, managed=false, plugged=true, readOnly=false,
deviceAlias=virtio-serial0, customProperties={}, snapshotId=null,
logicalName=null}',
u'device_b0a9483f-8106-4a62-9deb-94d701194647device_9a8c7e80-cd0b-4454-8974-5aebc6151e5edevice_7c593783-8146-407b-8e57-20d768bc2179device_1f301e5b-db4c-4528-a381-4b62532c6d19device_473d465a-0617-431f-939a-9d94d537d932':
u'VmDevice {vmId=995a5f50-9f77-479d-9f05-acc00965dd3e,
deviceId=473d465a-0617-431f-939a-9d94d537d932, device=spicevmc, type=CHANNEL,
bootOrder=0, specParams={}, address={bus=0, controller=0, type=virtio-serial,
port=3}, managed=false, plugged=true, readOnly=false, deviceAlias=channel2,
customProperties={}, snapshotId=null, logicalName=null}',
u'device_b0a9483f-8106-4a62-9deb-94d701194647device_9a8c7e80-cd0b-4454-8974-5aebc6151e5edevice_7c593783-8146-407b-8e!
57-20d768bc2179device_1f301e5b-db4c-4528-a381-4b62532c6d19': u'VmDevice
{vmId=995a5f50-9f77-479d-9f05-acc00965dd3e,
deviceId=1f301e5b-db4c-4528-a381-4b62532c6d19, device=unix, type=CHANNEL,
bootOrder=0, specParams={}, address={bus=0, controller=0, type=virtio-serial,
port=2}, managed=false, plugged=true, readOnly=false, deviceAlias=channel1,
customProperties={}, snapshotId=null, logicalName=null}',
u'device_b0a9483f-8106-4a62-9deb-94d701194647device_9a8c7e80-cd0b-4454-8974-5aebc6151e5edevice_7c593783-8146-407b-8e57-20d768bc2179':
u'VmDevice {vmId=995a5f50-9f77-479d-9f05-acc00965dd3e,
deviceId=7c593783-8146-407b-8e57-20d768bc2179, device=unix, type=CHANNEL,
bootOrder=0, specParams={}, address={bus=0, controller=0, type=virtio-serial,
port=1}, managed=false, plugged=true, readOnly=false, deviceAlias=channel0,
customProperties={}, snapshotId=null, logicalName=null}'}, u'vmType': u'kvm',
u'memSize': 8192, u'smpCoresPerSocket': u'1', u'vmName': u'F20_R7', u'nice':
u'0', 'status': 'Up', u'bootMenuEnable': u'false', u'vmId':
u'995a5f50-9f77-479d-9f05!
-acc00965dd3e', 'displayIp': '192.168.1.39', 'displayPort': '-1',
'guestDiskMapping': {}, 'clientIp': '', 'nicModel': 'rtl8139,pv',
u'keyboardLayout': u'en-us', u'kvmEnable': u'true', u'transparentHugePages':
u'true', u'displayNetwork': u'ovirtmgmt', u'devices': [{'target': 8388608,
u'specParams': {u'model': u'virtio'}, 'alias': u'balloon0', 'deviceType':
u'balloon', u'deviceId': u'0a9631ed-7e89-47d5-80a8-9241285788ae', u'address':
{u'slot': u'0x06', u'bus': u'0x00', u'domain': u'0x', u'type': u'pci',
u'function': u'0x0'}, u'device': u'memballoon', u'type': u'balloon'},
{u'specParams': {}, 'alias': u'virtio-serial0', 'deviceType': u'controller',
u'deviceId': u'b0a9483f-8106-4a62-9deb-94d701194647', u'address': {u'slot':
u'0x04', u'bus': u'0x00', u'domain': u'0x', u'type': u'pci', u'function':
u'0x0'}, u'device': u'virtio-serial', u'type': u'controller'}, {u'specParams':
{u'vram': u'32768', u'heads': u'1'}, 'alias': u'video0', 'deviceType':
u'video', u'deviceId': u'6!
c698a9d-b68a-4886-8c27-50844e4e04ad', u'address': {u'slot': u'0x02', u'bus':
u'0x00', u'domain': u'0x', u'type': u'pci', u'function': u'0x0'},
u'device': u'qxl', u'type': u'video'}, {'device': 'spice', 'specParams':
{'displayNetwork': u'ovirtmgmt', 'keyMap': u'en-us', 'displayIp':
Change in vdsm[ovirt-3.5]: network: tests: add error code checking
Ido Barkan has posted comments on this change. Change subject: network: tests: add error code checking .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I017a6307eab44d57b456535f7bcd7779f91ed570 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Dan Kenigsberg has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
automat...@ovirt.org has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 4: * Update tracker::#1196327::OK * Check TR::#1196327::ERROR, 3.5.2 should not match .* -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
automat...@ovirt.org has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network: Flush all configurators before restoring networks
oVirt Jenkins CI Server has posted comments on this change. Change subject: Network: Flush all configurators before restoring networks .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/617/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/609/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16824/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1176/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16996/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1158/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2807/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit https://gerrit.ovirt.org/38767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3d0fb35d608a8b019ad80f7e40f4399e7db479 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
automat...@ovirt.org has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
Simone Tiraboschi has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 5: Code-Review+1 The interface looks good on hosted-engine side -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: monitor: return whether the reported status is actual
Hello Adam Litke, Nir Soffer, Allon Mureinik,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/38874
to review the following change.
Change subject: monitor: return whether the reported status is actual
..
monitor: return whether the reported status is actual
When the domain monitoring results are reported after the domain
monitor was started. The first monitoring run may haven't been yet
completed - which causes the returned status to be determined as OK
by the engine (leads to domain status change).
It was attempted to change the inital returned status in the past but it
broke the host activation flow in the engine (see change I8e0df) and
therefore the inital results can't be changed (backward comptability) -
therefore in this change i add a new info that indicates whether the
reported status is actual or not.
When providing the engine the information on whether the returned status
is actual or not, the engine can decide how to act upon the monitoring
result and ignore it if it's irrelevant.
Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d
Bug-Url: https://bugzilla.redhat.com/1183977
Signed-off-by: Liron Aravot lara...@redhat.com
Reviewed-on: https://gerrit.ovirt.org/37952
Reviewed-by: Nir Soffer nsof...@redhat.com
Reviewed-by: Allon Mureinik amure...@redhat.com
Reviewed-by: Adam Litke ali...@redhat.com
---
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/domainMonitor.py
M vdsm/storage/hsm.py
A vdsm/storage/monitor.py
4 files changed, 381 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/38874/1
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 7a469e4..d39e5e4 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -1709,12 +1709,18 @@
# acquired and therefore if it's possible to run (sanlock)
# protected VMs
#
+# @actual: Indicates if the returned status is an actual monitoring result
+# or initial result that means that the first monitor run was not
+# yet completed
+# (new in version 4.16.13)
+#
# Since: 4.10.0
# XXX: Add an enum for return codes and their meanings
##
{'type': 'StorageDomainVitals',
'data': {'code': 'int', 'delay': 'float', 'lastCheck': 'float',
- 'valid': 'bool', 'version': 'int', 'acquired': 'bool'}}
+ 'valid': 'bool', 'version': 'int', 'acquired': 'bool',
+ 'actual': 'bool'}}
##
# @PathStats:
diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py
index d9e515c..4d6b9d6 100644
--- a/vdsm/storage/domainMonitor.py
+++ b/vdsm/storage/domainMonitor.py
@@ -35,13 +35,14 @@
error, checkTime, valid, readDelay, masterMounted,
masterValid, diskUtilization, vgMdUtilization,
vgMdHasEnoughFreeSpace, vgMdFreeBelowThreashold, hasHostId,
-isoPrefix, version,
+isoPrefix, version, actual,
)
def __init__(self):
-self.clear()
+self.clear(actual=False)
-def clear(self):
+def clear(self, actual):
+self.actual = actual
self.error = None
self.checkTime = time()
self.valid = True
@@ -152,7 +153,6 @@
self.sdUUID = sdUUID
self.hostId = hostId
self.interval = interval
-self.firstChange = True
self.status = DomainMonitorStatus()
self.nextStatus = DomainMonitorStatus()
self.isIsoDomain = None
@@ -201,7 +201,7 @@
%s, self.hostId, self.sdUUID, exc_info=True)
def _monitorDomain(self):
-self.nextStatus.clear()
+self.nextStatus.clear(actual=True)
if time() - self.lastRefresh self.refreshTime:
# Refreshing the domain object in order to pick up changes as,
@@ -270,8 +270,6 @@
self.log.warn(Could not emit domain state change event,
exc_info=True)
-self.firstChange = False
-
# An ISO domain can be shared by multiple pools
if (not self.isIsoDomain and self.nextStatus.valid
and self.nextStatus.hasHostId is False):
@@ -285,4 +283,5 @@
self.status.update(self.nextStatus)
def _statusDidChange(self):
-return self.firstChange or self.status.valid != self.nextStatus.valid
+return (not self.status.actual or
+self.status.valid != self.nextStatus.valid)
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 2860882..579f5a6 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3622,6 +3622,7 @@
'version': domStatus.version,
# domStatus.hasHostId can also be None
'acquired': domStatus.hasHostId is True,
+'actual': domStatus.actual
},
'disktotal': disktotal,
diff --git
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: API: onlyUUID should affect only short status
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/38867 to review the following change. Change subject: API: onlyUUID should affect only short status .. API: onlyUUID should affect only short status this patch makes the 'onlyUUID' parameter take effect only if 'fullStatus' equals False (short status was asked). depending on 'fullStatus' boolean parameter, the getVMList API can return either full or short VM status. Due to a bug originally introduced before 3.5.0, short status was incorrectly produced as list(UUIDs), but it is meant to be a list(dict(vmId:UUID, status:vmStatus), ) The 'onlyUUID' parameter was added to preserve backward compatibility with early Engines 3.5.x, but it is meant to fix short status (fullStatus=False), and should not always affect output. Instead, the current code always produces short and broken status if 'onlyUUID' equals True, with the side effect that also fullStatus is affected. Bug-Url: https://bugzilla.redhat.com/1196327 Related-To: https://bugzilla.redhat.com/1196735 Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38679 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py M vdsm/rpc/Bridge.py M vdsm/rpc/vdsmapi-schema.json 3 files changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/38867/1 diff --git a/vdsm/API.py b/vdsm/API.py index bb750ec..c38f231 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -1378,7 +1378,7 @@ vmlist = [reportedStatus(v, fullStatus) for v in self._cif.vmContainer.values() if not vmSet or v.id in vmSet] -if onlyUUID: +if not fullStatus and onlyUUID: # BZ 1196735: api backward compatibility issue # REQUIRED_FOR: engine-3.5.0 only vmlist = [v['vmId'] for v in vmlist] diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py index 47ae94c..c964741 100644 --- a/vdsm/rpc/Bridge.py +++ b/vdsm/rpc/Bridge.py @@ -347,7 +347,7 @@ pass arguments to get verbose information for only this one VM. vmId = api._UUID -return API.Global().getVMList(True, [vmId]) +return API.Global().getVMList(True, [vmId], False) def VM_getInfo_Ret(ret): diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json index 7a469e4..d63cf6c 100644 --- a/vdsm/rpc/vdsmapi-schema.json +++ b/vdsm/rpc/vdsmapi-schema.json @@ -3480,9 +3480,12 @@ # # @vmList: #optional Filter the results by a list of UUIDs # -# @onlyUUID:#optional determines whether we need short of full status -# This parmeter is provided to keep backward compatibility -# with engine-3.5.0 +# @onlyUUID:#optional Control the Short Status format, and +# has no effect if on Full Status (fullStatus=True). +# if True, the return value is a list of UUIDs. +# if False, the return value is a list of ShortStatus. +# This parameter is provided for backward +# compatibility with engine-3.5.0. # # Returns: # A list of VM UUIDs -- To view, visit https://gerrit.ovirt.org/38867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: API: onlyUUID should affect only short status
automat...@ovirt.org has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 1: * Update tracker::#1196327::OK * Check Bug-Url::OK * Check Public Bug::#1196327::OK, public bug * Check Product::#1196327::OK, Correct product oVirt * Check TR::#1196327::OK, correct target release 3.5.2 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/38867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: API: getVMList: compatibity with internal clients
automat...@ovirt.org has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 1: * Update tracker::#1196327::OK * Check Bug-Url::OK * Check Public Bug::#1196327::OK, public bug * Check Product::#1196327::OK, Correct product oVirt * Check TR::#1196327::OK, correct target release 3.5.2 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/38868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: API: getVMList: compatibity with internal clients
Francesco Romani has posted comments on this change.
Change subject: API: getVMList: compatibity with internal clients
..
Patch Set 1:
Verification (1/3): vdsm 3.5 with Engine 3.5.0 (OK)
MOM OK:
2015-03-18 13:03:36,375 - mom.Monitor - INFO - GuestMonitor-FBD_1 running
2015-03-18 13:03:56,399 - mom.Monitor - INFO - GuestMonitor-FBD_1 running
2015-03-18 13:04:11,414 - mom.Monitor - INFO - GuestMonitor-FBD_1 running
JSONRPC OK:
Thread-221::DEBUG::2015-03-18
13:01:06,163::__init__::469::jsonrpc.JsonRpcServer::(_serveRequest) Calling
'Host.getVMList' in bridge with {}
Thread-221::DEBUG::2015-03-18
13:01:06,164::__init__::500::jsonrpc.JsonRpcServer::(_serveRequest) Return
'Host.getVMList' in bridge with [u'd9be4550-7af1-4580-9430-4bfdaa7d50cf']
Thread-221::DEBUG::2015-03-18
13:01:06,164::stompReactor::163::yajsonrpc.StompServer::(send) Sending response
JsonRpc (StompReactor)::DEBUG::2015-03-18
13:01:06,168::stompReactor::98::Broker.StompAdapter::(handle_frame) Handling
message StompFrame command='SEND'
JsonRpcServer::DEBUG::2015-03-18
13:01:06,169::__init__::506::jsonrpc.JsonRpcServer::(serve_requests) Waiting
for request
Thread-222::DEBUG::2015-03-18
13:01:06,169::__init__::469::jsonrpc.JsonRpcServer::(_serveRequest) Calling
'VM.getStats' in bridge with {u'vmID': u'd9be4550-7af1-4580-9430-4bfdaa7d50cf'}
Thread-222::DEBUG::2015-03-18
13:01:06,170::__init__::500::jsonrpc.JsonRpcServer::(_serveRequest) Return
'VM.getStats' in bridge with [{'status': 'Powering up', 'displayInfo':
[{'tlsPort': u'5900', 'ipAddress': '192.168.1.39', 'type': 'spice', 'port':
'-1'}], 'hash': '-4933515864005718306', 'acpiEnable': u'true', 'guestFQDN': '',
'pid': '7946', 'displayIp': '192.168.1.39', 'ioTune': [], 'displayPort': '-1',
'session': 'Unknown', 'displaySecurePort': u'5900', 'timeOffset': u'0',
'memUsage': '0', 'balloonInfo': {}, 'pauseCode': 'NOERR', 'clientIp': '',
'elapsedTime': '4', 'kvmEnable': u'true', 'network': {}, 'vmId':
u'd9be4550-7af1-4580-9430-4bfdaa7d50cf', 'vmType': u'kvm', 'cpuUser': '0.00',
'disks': {u'vda': {'readLatency': '0', 'apparentsize': '5502926848',
'writeLatency': '0', 'imageID': u'ba737308-0fca-4c6d-8f0f-42a6e762c555',
'flushLatency': '0', 'truesize': '5502926848'}, u'vdc': {'readLatency': '0',
'apparentsize': '1073741824', 'writeLatency': '0', 'imageID': u'5180f2!
92-ea83-44ec-82f5-bc3aed59384c', 'flushLatency': '0', 'truesize':
'1073741824'}, u'vdb': {'readLatency': '0', 'apparentsize': '1073741824',
'writeLatency': '0', 'imageID': u'3b12ce02-d9da-46f8-a743-b3937bf5a6d2',
'flushLatency': '0', 'truesize': '1073741824'}, u'hdc': {'flushLatency': '0',
'readLatency': '0', 'truesize': '0', 'apparentsize': '0', 'writeLatency':
'0'}}, 'monitorResponse': '0', 'statsAge': '1.85', 'username': 'Unknown',
'displayType': u'qxl', 'cpuSys': '0.00', 'guestCPUCount': -1, 'appsList': [],
'guestIPs': ''}]
Thread-233::DEBUG::2015-03-18
13:01:18,607::__init__::469::jsonrpc.JsonRpcServer::(_serveRequest) Calling
'Host.getVMFullList' in bridge with {u'vmList':
[u'd9be4550-7af1-4580-9430-4bfdaa7d50cf']}
Thread-233::DEBUG::2015-03-18
13:01:18,609::__init__::500::jsonrpc.JsonRpcServer::(_serveRequest) Return
'Host.getVMFullList' in bridge with [{u'acpiEnable': u'true', [...]
Thread-241::DEBUG::2015-03-18
13:01:28,028::__init__::469::jsonrpc.JsonRpcServer::(_serveRequest) Calling
'Host.getAllVmStats' in bridge with {}
Thread-241::DEBUG::2015-03-18
13:01:28,030::__init__::500::jsonrpc.JsonRpcServer::(_serveRequest) Return
'Host.getAllVmStats' in bridge with [{'displayInfo': [{'tlsPort': u'5900',
'ipAddress': '192.168.1.39', 'type': 'spice', 'port': '-1'}], 'memUsage': '11',
'acpiEnable': u'true', 'guestFQDN': u'localhost.localdomain', 'pid': '7946',
'session': 'Unknown', 'netIfaces': [], 'timeOffset': u'0', 'balloonInfo':
{'balloon_max': '4194304', 'balloon_min': '4194304', 'balloon_target':
'4194304', 'balloon_cur': '4194304'}, 'pauseCode': 'NOERR', 'disksUsage':
[{u'path': u'/sys/fs/pstore', u'total': '0', u'used': '0', u'fs': u'pstore'},
{u'path': u'/', u'total': '18369396736', u'used': '3931250688', u'fs':
u'ext4'}, {u'path': u'/sys/kernel/config', u'total': '0', u'used': '0', u'fs':
u'configfs'}, {u'path': u'/boot', u'total': '499355648', u'used': '93746176',
u'fs': u'ext4'}], 'network': {u'vnet0': {'macAddr': u'00:1a:4a:d8:81:01',
'rxDropped': '0', 'rxErrors': '0', 'txDropped': '0', !
'txRate': '0.0', 'rxRate': '0.0', 'txErrors': '0', 'state': 'unknown',
'speed': '1000', 'name': u'vnet0'}}, 'memoryStats': {u'swap_out': '0',
u'majflt': '57', u'swap_usage': '0', u'mem_cached': '200608', u'mem_free':
'3701748', u'mem_buffers': '25072', u'swap_in': '0', u'swap_total': '2097148',
u'pageflt': '55898', u'mem_total': '4048324', u'mem_unused': '3476068'},
'guestName': u'localhost.localdomain', 'elapsedTime': '26', 'vmJobs': {},
'cpuSys': '12.83', 'appsList': [u'kernel-3.11.10-301.fc20',
Change in vdsm[master]: split network restoration from vdsmd.service
oVirt Jenkins CI Server has posted comments on this change. Change subject: split network restoration from vdsmd.service .. Patch Set 16: Code-Review-1 Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/616/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/608/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16823/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1175/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16995/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1157/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2806/ : The patch does not pass the network functional tests -- To view, visit https://gerrit.ovirt.org/29441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 1: will be verified with 38868 and must be merged together. -- To view, visit https://gerrit.ovirt.org/38867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
automat...@ovirt.org has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
automat...@ovirt.org has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 5: * Update tracker::#1190207::OK * Check Bug-Url::OK * Check Public Bug::#1190207::OK, public bug * Check Product::#1190207::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sslTests: set timeout to transport through the ctor
oVirt Jenkins CI Server has posted comments on this change. Change subject: sslTests: set timeout to transport through the ctor .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16834/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17006/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7967e5e7a59c43a871e0ca5566a4677311671b60 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refresh device verb
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: Add refresh device verb .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16835/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17007/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verb to setup geo-rep mount broker.
Bala.FA has posted comments on this change. Change subject: gluster: Adds new verb to setup geo-rep mount broker. .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9498c937bdf44b7747253e9bc203cb9eca1e671f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16829/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17001/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
Yaniv Bronhaim has posted comments on this change.
Change subject: vdscli: allow a connection with a configurable timeout
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38751/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 117:wrap_transport(transport))
Line 118: else:
Line 119: # TODO: add timeout option for HTTP connection
Line 120: if timeout is not sslutils.SOCKET_DEFAULT_TIMEOUT:
Line 121: raise NotImplementedError
please add ('timeout is not supported in plaintext connection')
Line 122: transport = wrap_transport(SingleRequestTransport())
Line 123: server = xmlrpclib.Server('http://%s' % hostPort, transport)
Line 124: return server
Line 125:
--
To view, visit https://gerrit.ovirt.org/38751
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16828/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17000/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
automat...@ovirt.org has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 6: * Update tracker::#1190207::OK * Check Bug-Url::OK * Check Public Bug::#1190207::OK, public bug * Check Product::#1190207::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Network: Flush all configurators before restoring networks
automat...@ovirt.org has posted comments on this change. Change subject: Network: Flush all configurators before restoring networks .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e3d0fb35d608a8b019ad80f7e40f4399e7db479 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make _upgrade_needed public.
Ido Barkan has uploaded a new change for review. Change subject: Make _upgrade_needed public. .. Make _upgrade_needed public. It is used from outside of vdsm-restore-net-config. Also removed redundant parentheses. Change-Id: I9f116f0b0587382fbbb5194d4375579d3d14ee3c Signed-off-by: Ido Barkan ibar...@redhat.com --- M lib/vdsm/tool/upgrade.py M vdsm/vdsm-restore-net-config 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/38866/1 diff --git a/lib/vdsm/tool/upgrade.py b/lib/vdsm/tool/upgrade.py index 8447745..b636d2a 100644 --- a/lib/vdsm/tool/upgrade.py +++ b/lib/vdsm/tool/upgrade.py @@ -34,7 +34,7 @@ return os.path.join(P_VDSM_LIB, 'upgrade', upgrade.name) -def _upgrade_needed(upgrade): +def upgrade_needed(upgrade): return not os.path.exists(_upgrade_seal_path(upgrade)) @@ -85,7 +85,7 @@ if hasattr(upgrade, 'extendArgParser'): upgrade.extendArgParser(argparser) ns, args = argparser.parse_known_args(args[1:]) -if (_upgrade_needed(upgrade) or ns.runAgain): +if upgrade_needed(upgrade) or ns.runAgain: _get_upgrade_log().debug(Running upgrade %s, upgrade.name) try: upgrade.run(ns, args) diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config index bcd3924..89877ce 100755 --- a/vdsm/vdsm-restore-net-config +++ b/vdsm/vdsm-restore-net-config @@ -163,7 +163,7 @@ Flush vdsm configurations left-overs from any configurator on the system so that changes of configurator and persistence system are smooth. Only done if upgrade to unified persistence is not pending -if (not upgrade._upgrade_needed( +if (not upgrade.upgrade_needed( unified_persistence.UpgradeUnifiedPersistence)): for configurator_cls in _get_all_configurators(): configurator_cls().flush() -- To view, visit https://gerrit.ovirt.org/38866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9f116f0b0587382fbbb5194d4375579d3d14ee3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Dan Kenigsberg has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
automat...@ovirt.org has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 7: * Update tracker::#1196327::OK * Set MODIFIED::bug 1196327#1196327IGNORE, not all related patches are closed, check 38805 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Dan Kenigsberg has submitted this change and it was merged. Change subject: API: getVMList: compatibity with internal clients .. API: getVMList: compatibity with internal clients After the addition of the 'onlyUUID' parameter, the external API of VDSM is now backward compatible: - in XMLRPC, we always set explicitely onlyUUID=False, so no room for breakage - in JSONRPC, we have Host_getVMList_Call (short status), on which * if onlyUUID is provided from the outside, we use it (works with Engine = 3.5.1) * if onlyUUID is NOT given (Engine 3.5.0), we default as True, and doing so we preserve the backward compatibility - in JSONRPC, in Host_getVMFullList_Call (full status), we use onlyUUID=False explicitely, so no issue hee The internal API, however, changed behaviour. Being the API internal, it doesn't usually need special care, but this time we need, because MOM is a supported client of this API. With the current 'onlyUUID' defaults, clients of API.py will get a list of UUIDs instead of a list of Short Status. To fix this, and given the findings outlined in the above bullet points, we just switch the default value of 'onlyUUID' to cover this use case. Bug-Url: https://bugzilla.redhat.com/1196327 Related-To: https://bugzilla.redhat.com/1196735 Change-Id: I0560a262329f729716577b28aa78b177f0929121 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38805 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Dan Kenigsberg has submitted this change and it was merged. Change subject: API: onlyUUID should affect only short status .. API: onlyUUID should affect only short status this patch makes the 'onlyUUID' parameter take effect only if 'fullStatus' equals False (short status was asked). depending on 'fullStatus' boolean parameter, the getVMList API can return either full or short VM status. Due to a bug originally introduced before 3.5.0, short status was incorrectly produced as list(UUIDs), but it is meant to be a list(dict(vmId:UUID, status:vmStatus), ) The 'onlyUUID' parameter was added to preserve backward compatibility with early Engines 3.5.x, but it is meant to fix short status (fullStatus=False), and should not always affect output. Instead, the current code always produces short and broken status if 'onlyUUID' equals True, with the side effect that also fullStatus is affected. Bug-Url: https://bugzilla.redhat.com/1196327 Related-To: https://bugzilla.redhat.com/1196735 Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38679 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py M vdsm/rpc/Bridge.py M vdsm/rpc/vdsmapi-schema.json 3 files changed, 8 insertions(+), 5 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split network restoration from vdsmd.service
Petr Horáček has posted comments on this change. Change subject: split network restoration from vdsmd.service .. Patch Set 16: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/29441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: API: getVMList: compatibity with internal clients
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/38868 to review the following change. Change subject: API: getVMList: compatibity with internal clients .. API: getVMList: compatibity with internal clients After the addition of the 'onlyUUID' parameter, the external API of VDSM is now backward compatible: - in XMLRPC, we always set explicitely onlyUUID=False, so no room for breakage - in JSONRPC, we have Host_getVMList_Call (short status), on which * if onlyUUID is provided from the outside, we use it (works with Engine = 3.5.1) * if onlyUUID is NOT given (Engine 3.5.0), we default as True, and doing so we preserve the backward compatibility - in JSONRPC, in Host_getVMFullList_Call (full status), we use onlyUUID=False explicitely, so no issue hee The internal API, however, changed behaviour. Being the API internal, it doesn't usually need special care, but this time we need, because MOM is a supported client of this API. With the current 'onlyUUID' defaults, clients of API.py will get a list of UUIDs instead of a list of Short Status. To fix this, and given the findings outlined in the above bullet points, we just switch the default value of 'onlyUUID' to cover this use case. Bug-Url: https://bugzilla.redhat.com/1196327 Related-To: https://bugzilla.redhat.com/1196735 Change-Id: I0560a262329f729716577b28aa78b177f0929121 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38805 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/38868/1 diff --git a/vdsm/API.py b/vdsm/API.py index c38f231..36fafe2 100644 --- a/vdsm/API.py +++ b/vdsm/API.py @@ -1363,7 +1363,7 @@ return dict(status=doneCode) # VM-related functions -def getVMList(self, fullStatus=False, vmList=(), onlyUUID=True): +def getVMList(self, fullStatus=False, vmList=(), onlyUUID=False): return a list of known VMs with full (or partial) config each def reportedStatus(v, full): -- To view, visit https://gerrit.ovirt.org/38868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add createBrick verb
Federico Simoncelli has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 25: Code-Review+2 I'm ok with this as it's not touching the lvm core of vdsm. I din't go into the specifics of the code for which I trust Bala's vote. -- To view, visit https://gerrit.ovirt.org/35498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refresh device verb
Fred Rolland has posted comments on this change.
Change subject: hsm: Add refresh device verb
..
Patch Set 4:
(7 comments)
https://gerrit.ovirt.org/#/c/38754/4/client/vdsClient.py
File client/vdsClient.py:
Line 729: if res['status']['code']:
Line 730: return res['status']['code'], res['status']['message']
Line 731: del res['status']
Line 732: printDict(res, self.pretty)
Line 733: return 0, ''
Can you show the output of successful and failed operations?
Done
Line 734:
Line 735: def getDevicesVisibility(self, args):
Line 736: devList = args[0].split(',')
Line 737: res = self.s.getDevicesVisibility(devList, {})
Line 2220:'storageType).'
Line 2221:)),
Line : 'refreshDevice': (serv.refreshDevice,
Line 2223: ('GUID',
Line 2224:'Refresh Multipath device'
Multipath - multipath.
Done
Line 2225:)),
Line 2226: 'getDevicesVisibility': (serv.getDevicesVisibility,
Line 2227: ('devlist',
Line 2228: 'Get visibility of each device
listed'
https://gerrit.ovirt.org/#/c/38754/4/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:
Line 31:
Line 32: from vdsm import constants
Line 33: from vdsm import utils
Line 34: from vdsm.infra import zombiereaper
Line 35: from vdsm.config import config
vdsm.config should be before vdsm.infra - right?
Done
Line 36: import hba
Line 37: import misc
Line 38: import iscsi
Line 39: import supervdsm
Line 75:
Line 76: def resize(guid):
Line 77:
Line 78: In case the LUN was increased on storage server, in order to see
the
Line 79: changes it is needed to rescan the device path and resize the
multipath.
resize the multipath - resize the multipath map
Done
Line 80:
Line 81: This method calls script multipath-resize which will perform the
following:
Line 82: - Perform scsi scan of the device paths
Line 83: - Resize the multipath map
Line 77:
Line 78: In case the LUN was increased on storage server, in order to see
the
Line 79: changes it is needed to rescan the device path and resize the
multipath.
Line 80:
Line 81: This method calls script multipath-resize which will perform the
following:
script multipath-reisze - multipath-resize tool
Done
Line 82: - Perform scsi scan of the device paths
Line 83: - Resize the multipath map
Line 84: SCSI scan is a blocking operation, so it is needed to run in
external tool.
Line 85: The call to the script is blocking up to 30 seconds.
Line 79: changes it is needed to rescan the device path and resize the
multipath.
Line 80:
Line 81: This method calls script multipath-resize which will perform the
following:
Line 82: - Perform scsi scan of the device paths
Line 83: - Resize the multipath map
Please separate paragraphs with empty line.
Done
Line 84: SCSI scan is a blocking operation, so it is needed to run in
external tool.
Line 85: The call to the script is blocking up to 30 seconds.
Line 86: If the operation times out, an error is raised.
Line 87: If the return code is not 0, an error is raised.
Line 87: If the return code is not 0, an error is raised.
Line 88: TODO: move to supervdsm when zombiereaper is functional there.
Line 89:
Line 90: timeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
Line 91: log.debug(Starting multipath resize)
Lets add the guid to all logs.
Done
Line 92: proc = utils.execCmd([constants.EXT_MULTIPATH_RESIZE, guid],
sudo=True,
Line 93: sync=False, execCmdLogger=log)
Line 94: try:
Line 95: proc.wait(timeout)
--
To view, visit https://gerrit.ovirt.org/38754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland froll...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Ala Hino ah...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Fred Rolland froll...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: monitor: return whether the reported status is actual
automat...@ovirt.org has posted comments on this change. Change subject: monitor: return whether the reported status is actual .. Patch Set 1: * Update tracker::#1183977::OK * Check Bug-Url::OK * Check Public Bug::#1183977::OK, public bug * Check Product::#1183977::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1183977::ERROR, wrong target release for stable branch, 3.6.0 should match ^3.[54321].* * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/38874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hsm: Add refresh device verb
automat...@ovirt.org has posted comments on this change. Change subject: hsm: Add refresh device verb .. Patch Set 5: * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#609689::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: monitor: return whether the reported status is actual
automat...@ovirt.org has posted comments on this change. Change subject: monitor: return whether the reported status is actual .. Patch Set 3: * Update tracker::#1183977::OK * Check Bug-Url::OK * Check Public Bug::#1183977::OK, public bug * Check Product::#1183977::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1183977::ERROR, wrong target release for stable branch, 3.6.0 should match ^3.[54321].* * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/38874 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Liron Aravot lara...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 3: version 6 changes the bug url(s) (and apparently drops all the score in the process) with no code changes. Copying my score. -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
automat...@ovirt.org has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 6: * Update tracker::#1196327::OK * Check Bug-Url::OK * Check Public Bug::#1196327::OK, public bug * Check Product::#1196327::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 6: Verified+1 version 6 changes the bug url(s) (and apparently drops all the score in the process) with no code changes. Copying my score. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16993/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: make _should_keep_bridge robust against missing running...
Dan Kenigsberg has posted comments on this change.
Change subject: api: make _should_keep_bridge robust against missing
running/persistent cfg
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/38239/2/vdsm/network/api.py
File vdsm/network/api.py:
Line 753: if k not in ('bonding', 'nic', 'mtu'))
Line 754:
Line 755: def _bridge_reconfigured(current_conf, required_conf):
Line 756: # we know nothing about the running/persistent configuration;
it may
Line 757: # have been removed by emergency_net_cleanup (in
contrib/shell_helper)
this patch requires further scrutiny.
It checks one condition that cannot happen in normal production; other
conditions can happen in similar ways by external scripts. We can never test
the all.
Line 758: if current_conf is None:
Line 759: return True # recreate the bridge in this case
Line 760:
Line 761: return (_bridge_only_config(current_conf) !=
--
To view, visit https://gerrit.ovirt.org/38239
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I13a225f406e6140463e1ded2008de8444fc4e9e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16830/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17002/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: API: getVMList: compatibity with internal clients
Francesco Romani has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 1: will be verified with 38867 and must be merged together. -- To view, visit https://gerrit.ovirt.org/38868 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make _upgrade_needed public.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make _upgrade_needed public. .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16997/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/2808/ : There was an infra issue, please contact in...@ovirt.org -- To view, visit https://gerrit.ovirt.org/38866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f116f0b0587382fbbb5194d4375579d3d14ee3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: dynamic tick support
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 16: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
Bala.FA has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 29: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/17644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 29 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: split network restoration from vdsmd.service
automat...@ovirt.org has posted comments on this change. Change subject: split network restoration from vdsmd.service .. Patch Set 16: * Update tracker::#1187244::OK * Check Bug-Url::OK * Check Public Bug::#1187244::OK, public bug * Check Product::#1187244::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/29441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Make _upgrade_needed public.
automat...@ovirt.org has posted comments on this change. Change subject: Make _upgrade_needed public. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38866 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f116f0b0587382fbbb5194d4375579d3d14ee3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/348/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/725/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/353/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/754/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/352/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/342/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/758/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: API: getVMList: compatibity with internal clients
Francesco Romani has posted comments on this change.
Change subject: API: getVMList: compatibity with internal clients
..
Patch Set 1:
Verification (2/3): vdsm 3.5 vs Engine 3.4.4 (OK)
Thread-13::DEBUG::2015-03-18 13:31:57,385::BindingXMLRPC::1133::vds::(wrapper)
client [192.168.1.182]::call getVMList with () {}
Thread-13::DEBUG::2015-03-18 13:31:57,386::BindingXMLRPC::1140::vds::(wrapper)
return getVMList with {'status': {'message': 'Done', 'code': 0}, 'vmList':
[{'status': 'Up', 'vmId': '69d1c9c6-bbb2-462e-800a-b4343e1f6de7'}]}
Thread-13::DEBUG::2015-03-18 13:31:57,391::BindingXMLRPC::1133::vds::(wrapper)
client [192.168.1.182]::call vmGetStats with
('69d1c9c6-bbb2-462e-800a-b4343e1f6de7',) {}
Thread-13::DEBUG::2015-03-18 13:31:57,391::BindingXMLRPC::1140::vds::(wrapper)
return vmGetStats with {'status': {'message': 'Done', 'code': 0}, 'statsList':
[{'status': 'Powering up', 'displayInfo': [{'tlsPort': '-1', 'ipAddress': '0',
'type': 'spice', 'port': u'5900'}], 'hash': '5788221924276885634',
'acpiEnable': 'true', 'guestFQDN': '', 'pid': '10404', 'displayIp': '0',
'ioTune': [], 'displayPort': u'5900', 'session': 'Unknown',
'displaySecurePort': '-1', 'timeOffset': '0', 'memUsage': '0', 'balloonInfo':
{}, 'pauseCode': 'NOERR', 'clientIp': '', 'elapsedTime': '1', 'kvmEnable':
'true', 'network': {}, 'vmId': '69d1c9c6-bbb2-462e-800a-b4343e1f6de7',
'vmType': 'kvm', 'cpuUser': '0.00', 'disks': {u'vda': {'readLatency': '0',
'apparentsize': '1073741824', 'writeLatency': '0', 'imageID':
'268c7164-ccb9-4f5b-9fa5-341e2011594a', 'flushLatency': '0', 'truesize': '0'},
u'hdc': {'flushLatency': '0', 'readLatency': '0', 'truesize': '0',
'apparentsize': '0', 'writeLatency': '0'}}, '!
monitorResponse': '0', 'statsAge': '0.91', 'username': 'Unknown',
'displayType': 'qxl', 'cpuSys': '0.00', 'guestCPUCount': -1, 'appsList': [],
'guestIPs': ''}]}
Thread-13::DEBUG::2015-03-18 13:31:57,422::BindingXMLRPC::1133::vds::(wrapper)
client [192.168.1.182]::call getVMList with ('true',
['69d1c9c6-bbb2-462e-800a-b4343e1f6de7']) {}
Thread-13::DEBUG::2015-03-18 13:31:57,422::BindingXMLRPC::1140::vds::(wrapper)
return getVMList with {'status': {'message': 'Done', 'code': 0}, 'vmList':
[{'acpiEnable': 'true', [...]
Thread-13::DEBUG::2015-03-18 13:32:03,777::BindingXMLRPC::1133::vds::(wrapper)
client [192.168.1.182]::call getAllVmStats with () {}
Thread-13::DEBUG::2015-03-18 13:32:03,778::BindingXMLRPC::1140::vds::(wrapper)
return getAllVmStats with {'status': {'message': 'Done', 'code': 0},
'statsList': [{'status': 'Powering up', 'displayInfo': [{'tlsPort': '-1',
'ipAddress': '0', 'type': 'spice', 'port': u'5900'}], 'hash':
'5788221924276885634', 'acpiEnable': 'true', 'guestFQDN': '', 'pid': '10404',
'displayIp': '0', 'ioTune': [], 'displayPort': u'5900', 'session': 'Unknown',
'displaySecurePort': '-1', 'timeOffset': '0', 'memUsage': '0', 'balloonInfo':
{}, 'pauseCode': 'NOERR', 'clientIp': '', 'elapsedTime': '7', 'kvmEnable':
'true', 'network': {}, 'vmId': '69d1c9c6-bbb2-462e-800a-b4343e1f6de7',
'vmType': 'kvm', 'cpuUser': '0.00', 'disks': {u'vda': {'readLatency': '0',
'apparentsize': '1073741824', 'writeLatency': '0', 'imageID':
'268c7164-ccb9-4f5b-9fa5-341e2011594a', 'flushLatency': '0', 'truesize': '0'},
u'hdc': {'flushLatency': '0', 'readLatency': '0', 'truesize': '0',
'apparentsize': '0', 'writeLatency': '0'}}!
, 'monitorResponse': '0', 'statsAge': '1.28', 'username': 'Unknown',
'displayType': 'qxl', 'cpuSys': '0.00', 'guestCPUCount': -1, 'appsList': [],
'guestIPs': ''}]}
ENGINE LOGS: OK
MOM: OK
2015-03-18 13:33:05,661 - mom.RPCServer - INFO - getStatistics()
2015-03-18 13:33:07,927 - mom.Monitor - INFO - GuestMonitor-NS running
2015-03-18 13:33:12,933 - mom.Monitor - INFO - GuestMonitor-NS running
2015-03-18 13:33:17,940 - mom.Monitor - INFO - GuestMonitor-NS running
2015-03-18 13:33:21,167 - mom.RPCServer - INFO - getStatistics()
2015-03-18 13:33:22,946 - mom.Monitor - INFO - GuestMonitor-NS running
2015-03-18 13:33:27,952 - mom.Monitor - INFO - GuestMonitor-NS running
2015-03-18 13:33:32,959 - mom.Monitor - INFO - GuestMonitor-NS running
2015-03-18 13:33:36,459 - mom.RPCServer - INFO - getStatistics()
2015-03-18 13:33:37,965 - mom.Monitor - INFO - GuestMonitor-NS running
2015-03-18 13:33:42,971 - mom.Monitor - INFO - GuestMonitor-NS ending
--
To view, visit https://gerrit.ovirt.org/38868
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: API: getVMList: compatibity with internal clients
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16822/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16994/ : ABORTED -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdscli: allow a connection with a configurable timeout .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16831/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17003/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
oVirt Jenkins CI Server has posted comments on this change. Change subject: v2v: Convert VM from external source to Data Domain .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/618/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/610/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16826/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/1177/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16998/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1159/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/37509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
