Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'
Francesco Romani has uploaded a new change for review.
Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..
vm: hyperv: hypervclock dosn't have 'tickpolicy'
'hypervclock' (and kvmclock as well) does not
support the tickpolicy attribute.
This patch removes the setting, while preserving
it for 'rtc' clocksources.
Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Signed-off-by: Francesco Romani from...@redhat.com
---
M tests/vmTests.py
M vdsm/virt/vmxml.py
2 files changed, 6 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/40387/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 25aac90..3cd4967 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -285,7 +285,7 @@
def testHyperVClockXML(self):
clockXML =
clock adjustment=-3600 offset=variable
-timer name=hypervclock tickpolicy=catchup/
+timer name=hypervclock/
timer name=pit tickpolicy=delay/
timer name=hpet present=no/
/clock
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index c4fd60c..02bbb52 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -183,18 +183,16 @@
for hyperv:
clock offset=variable adjustment=-3600
-timer name=hypervclock tickpolicy=catchup
+timer name=hypervclock
/clock
-if utils.tobool(self.conf.get('hypervEnable', 'false')):
-clockName = 'hypervclock'
-else:
-clockName = 'rtc'
-
m = Element('clock', offset='variable',
adjustment=str(self.conf.get('timeOffset', 0)))
-m.appendChildWithArgs('timer', name=clockName, tickpolicy='catchup')
+if utils.tobool(self.conf.get('hypervEnable', 'false')):
+m.appendChildWithArgs('timer', name='hypervclock')
+else:
+m.appendChildWithArgs('timer', name='rtc', tickpolicy='catchup')
m.appendChildWithArgs('timer', name='pit', tickpolicy='delay')
if self.arch == caps.Architecture.X86_64:
--
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy' .. Patch Set 1: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1556/ -- To view, visit https://gerrit.ovirt.org/40387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy' .. Patch Set 1: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18326/ -- To view, visit https://gerrit.ovirt.org/40387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'
automat...@ovirt.org has posted comments on this change. Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy' .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 2: Build Started (2/5) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/869/ -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: rename stats cache to vm stats cache
automat...@ovirt.org has posted comments on this change. Change subject: WIP: rename stats cache to vm stats cache .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38c49f686dfc2bc0994d444ff24c7736f2e951b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: introduce expensive checks
automat...@ovirt.org has posted comments on this change. Change subject: sampling: introduce expensive checks .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b3bb707dd60de194eedfc2e3de1efbf05574ff7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 30: Build Started (1/5) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/870/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 30: Build Started (2/5) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/879/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Better logging for network restoration.
oVirt Jenkins CI Server has posted comments on this change. Change subject: Better logging for network restoration. .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/557/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/934/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/971/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/553/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/969/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/566/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/111/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/111/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/43/ : 0 -- To view, visit https://gerrit.ovirt.org/37506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dc4be51ec3f8af210f2b4a0acdc52e372835239 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 30: Build Started (5/5) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1424/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Gather disk replication private methods
Francesco Romani has posted comments on this change. Change subject: vm: Gather disk replication private methods .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I075636735ad9f2a53c2ed81ea20925a7bfda376d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: improve isolation in VM dispatching
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: improve isolation in VM dispatching .. Patch Set 2: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1560/ -- To view, visit https://gerrit.ovirt.org/40339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ed5f1b7c332cdfe23d78571ac135a2c1714ba7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: improve isolation in VM dispatching
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: improve isolation in VM dispatching .. Patch Set 2: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18330/ -- To view, visit https://gerrit.ovirt.org/40339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ed5f1b7c332cdfe23d78571ac135a2c1714ba7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Yaniv Bronhaim has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: only relevant to 3.5? -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Yaniv Bronhaim has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: rename stats cache to vm stats cache
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: rename stats cache to vm stats cache .. Patch Set 2: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1562/ -- To view, visit https://gerrit.ovirt.org/40371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38c49f686dfc2bc0994d444ff24c7736f2e951b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: rename stats cache to vm stats cache
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: rename stats cache to vm stats cache .. Patch Set 2: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18332/ -- To view, visit https://gerrit.ovirt.org/40371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38c49f686dfc2bc0994d444ff24c7736f2e951b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: disappeared domain are not ready for commands
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: disappeared domain are not ready for commands .. Patch Set 27: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18334/ -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Dan Kenigsberg has posted comments on this change.
Change subject: Move udevadm to lib/vdsm
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/40119/3/tests/samplingTests.py
File tests/samplingTests.py:
Line 149: s1 = sampling.InterfaceSample(lo)
Line 150: s1.operstate = 'x'
Line 151: self.assertEquals('operstate:x', s1.connlog_diff(s0))
Line 152:
Line 153: #@brokentest(Broken unless libvirtd is running)
this is a real pep8 error. add a space after the #.
but hey, this change is completely unrelated to settle!
Line 154: @MonkeyPatch(libvirtconnection, '_read_password', read_password)
Line 155: @ValidateRunningAsRoot
Line 156: def testHostSampleReportsNewInterface(self):
Line 157: hs_before = sampling.HostSample(os.getpid())
--
To view, visit https://gerrit.ovirt.org/40119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
automat...@ovirt.org has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 3: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18336/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Started (5/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/970/ -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: introduce expensive checks
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: introduce expensive checks .. Patch Set 1: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18338/ -- To view, visit https://gerrit.ovirt.org/40391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b3bb707dd60de194eedfc2e3de1efbf05574ff7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 3: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1566/ -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Started (7/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/112/ -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: disappeared domain are not ready for commands
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: disappeared domain are not ready for commands .. Patch Set 27: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1564/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18337/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1567/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Dan Kenigsberg has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: yes, the pep8 issue is only in 3.5. -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: simplify flows
automat...@ovirt.org has posted comments on this change. Change subject: sampling: simplify flows .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide103d0ed9a694cc9ddd9b0b382e2d81a1bd48c0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: replace flag with Stage
automat...@ovirt.org has posted comments on this change. Change subject: virt: sampling: replace flag with Stage .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b4fec4d609fe22e890de911342f80505de88c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
Francesco Romani has uploaded a new change for review.
Change subject: sampling: more detailed stale sampling reporting
..
sampling: more detailed stale sampling reporting
To improve troubleshooting, report timestamps
of current and stale samples when discarding
data for timestamp too old.
We are already logging this event, so adding new
information is quite cheap and can make
troubleshooting easier.
Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/sampling.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/40390/1
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index 6804406..7d7596e 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -464,13 +464,16 @@
with stale one.
with self._lock:
-if monotonic_ts = self._last_sample_time:
+last_sample_time = self._last_sample_time
+if monotonic_ts = last_sample_time:
self._samples.append(bulk_stats)
self._last_sample_time = monotonic_ts
self._update_ts(bulk_stats, monotonic_ts)
else:
-self._log.warning('dropped stale old sample')
+self._log.warning(
+'dropped stale old sample: sampled %f stored %f',
+monotonic_ts, last_sample_time)
def _update_ts(self, bulk_stats, monotonic_ts):
# FIXME: this is expected to be costly performance-wise.
--
To view, visit https://gerrit.ovirt.org/40390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
automat...@ovirt.org has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: rename SampleVMs for clarity
automat...@ovirt.org has posted comments on this change. Change subject: virt: rename SampleVMs for clarity .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadf91e0e3b7ffd4d76eff36e4906441496adb71c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
automat...@ovirt.org has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
automat...@ovirt.org has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 30: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: introduce expensive checks
Francesco Romani has uploaded a new change for review.
Change subject: sampling: introduce expensive checks
..
sampling: introduce expensive checks
To improve troubleshooting, introduce more
expensive sanity checks, with a default-off
tunable to enable them.
These sanity checks will make no attempt to recover,
will only add logs to report possible issues.
Change-Id: I7b3bb707dd60de194eedfc2e3de1efbf05574ff7
Signed-off-by: Francesco Romani from...@redhat.com
---
M lib/vdsm/config.py.in
M vdsm/virt/sampling.py
2 files changed, 19 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/40391/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index e213839..b60e836 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -325,6 +325,10 @@
('periodic_task_per_worker', '100',
'Max number of tasks which can be queued on workers.'
' This is for internal usage and may change without warning'),
+
+('expensive_checks', 'false',
+'Perform additional sanity checks and does additional debug logs'
+'which are expensive performance-wise'),
]),
# Section: [devel]
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index b0628a4..3c1510f 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -504,6 +504,7 @@
self._skip_doms = ExpiringCache(timeout)
self._sampling = Stage()
self._log = logging.getLogger(sampling.VMBulkSampler)
+self._extra_check = config.getboolean('sampling', 'expensive_checks')
def __call__(self):
timestamp = self._vm_stats_cache.clock()
@@ -517,7 +518,6 @@
# If everything's ok, we can skip all the costly checks.
bulk_stats = self._conn.getAllDomainStats(
self._stats_flags)
-self._vm_stats_cache.put(_translate(bulk_stats), timestamp)
else:
# A previous call got stuck, or not every domain
# has properly recovered. Thus we must whitelist domains.
@@ -526,7 +526,12 @@
if doms:
bulk_stats = self._conn.domainListGetStats(
doms, self._stats_flags)
-self._vm_stats_cache.put(_translate(bulk_stats), timestamp)
+else:
+bulk_stats = []
+
+stats = _translate(bulk_stats)
+self._vm_stats_cache.put(stats, timestamp)
+self._log_missing_vms(self._get_vms(), stats, timestamp)
def _get_responsive_doms(self):
vms = self._get_vms()
@@ -541,6 +546,14 @@
doms.append(vm_obj._dom._dom)
return doms
+def _log_missing_vms(self, expected_vms, retrieved_stats, timestamp):
+# costly check. add another layer of check before to embark on it.
+if self._extra_check:
+for vm_id in expected_vms:
+if vm_id not in retrieved_stats:
+self._log.debug('VM %s not updated in bulk at %f',
+vm_id, timestamp)
+
class HostStatsThread(threading.Thread):
--
To view, visit https://gerrit.ovirt.org/40391
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b3bb707dd60de194eedfc2e3de1efbf05574ff7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 16: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1558/ -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 16: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18328/ -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: improve isolation in VM dispatching
automat...@ovirt.org has posted comments on this change. Change subject: periodic: improve isolation in VM dispatching .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ed5f1b7c332cdfe23d78571ac135a2c1714ba7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs
automat...@ovirt.org has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 16: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: disappeared domain are not ready for commands
automat...@ovirt.org has posted comments on this change. Change subject: vm: disappeared domain are not ready for commands .. Patch Set 27: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: tests: add tests for sampling.SampleVMs
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: tests: add tests for sampling.SampleVMs .. Patch Set 16: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18328/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1558/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: replace flag with Stage
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: replace flag with Stage .. Patch Set 3: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1561/ -- To view, visit https://gerrit.ovirt.org/40322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b4fec4d609fe22e890de911342f80505de88c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: replace flag with Stage
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: replace flag with Stage .. Patch Set 3: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18331/ -- To view, visit https://gerrit.ovirt.org/40322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b4fec4d609fe22e890de911342f80505de88c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: rename SampleVMs for clarity
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: rename SampleVMs for clarity .. Patch Set 2: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18333/ -- To view, visit https://gerrit.ovirt.org/40370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadf91e0e3b7ffd4d76eff36e4906441496adb71c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: rename SampleVMs for clarity
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: rename SampleVMs for clarity .. Patch Set 2: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1563/ -- To view, visit https://gerrit.ovirt.org/40370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadf91e0e3b7ffd4d76eff36e4906441496adb71c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: simplify flows
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: simplify flows .. Patch Set 3: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18335/ -- To view, visit https://gerrit.ovirt.org/40326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide103d0ed9a694cc9ddd9b0b382e2d81a1bd48c0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: improve isolation in VM dispatching
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: improve isolation in VM dispatching .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18330/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1560/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ed5f1b7c332cdfe23d78571ac135a2c1714ba7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: rename SampleVMs for clarity
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: rename SampleVMs for clarity .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18333/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1563/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadf91e0e3b7ffd4d76eff36e4906441496adb71c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 1: Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18337/ -- To view, visit https://gerrit.ovirt.org/40390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Started (2/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/935/ -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Started (6/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/567/ -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Started (9/9) 0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/44/ -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Started (8/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/112/ -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: simplify per_vm_operation
oVirt Jenkins CI Server has posted comments on this change. Change subject: periodic: simplify per_vm_operation .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18336/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1566/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40327 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bff3c36b0507eaa77383083e224478d7e3861c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Dan Kenigsberg has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: introduce expensive checks
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: introduce expensive checks .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18338/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1568/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b3bb707dd60de194eedfc2e3de1efbf05574ff7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Build Started (1/5) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18339/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
Ido Barkan has posted comments on this change.
Change subject: Move udevadm to lib/vdsm
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40119/3/tests/samplingTests.py
File tests/samplingTests.py:
Line 149: s1 = sampling.InterfaceSample(lo)
Line 150: s1.operstate = 'x'
Line 151: self.assertEquals('operstate:x', s1.connlog_diff(s0))
Line 152:
Line 153: #@brokentest(Broken unless libvirtd is running)
this is a real pep8 error. add a space after the #.
slippery fingers.
Line 154: @MonkeyPatch(libvirtconnection, '_read_password', read_password)
Line 155: @ValidateRunningAsRoot
Line 156: def testHostSampleReportsNewInterface(self):
Line 157: hs_before = sampling.HostSample(os.getpid())
--
To view, visit https://gerrit.ovirt.org/40119
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
automat...@ovirt.org has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Build Started (3/5) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1569/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Move udevadm to lib/vdsm
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move udevadm to lib/vdsm .. Patch Set 4: Build Started (2/5) - http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/871/ -- To view, visit https://gerrit.ovirt.org/40119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I113bd85820805e60cbf6a7266ed788ec3ba48637 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 30: Build Started (3/5) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18329/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1557/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/869/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/878/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1423/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18327/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 30: Build Started (4/5) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1559/ -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 2: jenkins build failure not related to this change. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: virt: better timeout for periodic operations
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: virt: better timeout for periodic operations .. Patch Set 30: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/870/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/879/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/1424/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18329/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1559/ : FAILURE -- To view, visit https://gerrit.ovirt.org/39333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I735d314532c6852889e3ac188651acff044888ed Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: replace flag with Stage
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: sampling: replace flag with Stage .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18331/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1561/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09b4fec4d609fe22e890de911342f80505de88c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
Dan Kenigsberg has submitted this change and it was merged. Change subject: profiling: add support for memory profiling .. profiling: add support for memory profiling There are many python memory profilers, but most of them are tailored for interactive usage, so additional integration work is needed to use them in a daemon, like VDSM. This patch adds support for dowser: http://www.aminus.net/wiki/Dowser https://pypi.python.org/pypi/dowser/0.2 which has the following benefits which makes it in a better position to be used with VDSM: + self contained, includes WEB UI + allows live monitoring + tailored for cherrypy usage, so friendly towards server applications. + easily portable (pure package) It must be noted that dowser has some drawbacks as well - significat dependencies, both in number and in size (with respect to VDSM standards): cherrypy, PIL - based on gc module As per the cpu profile already added, this code is meant to be used only as debug aid or in development environments. The feature is controlled by a config tunable and disabled by default; the feature disable itself if any dependency is missed. Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/32019 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M debian/vdsm-python.install M lib/vdsm/config.py.in M lib/vdsm/profiling/Makefile.am A lib/vdsm/profiling/memory.py M lib/vdsm/profiling/profile.py M vdsm.spec.in 6 files changed, 124 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
Dan Kenigsberg has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 20: Code-Review+2 jenkins failure seems unrelated to the patch. (11:56:30 AM) fromani_: danken: and failed apparently because: DEBUG util.py:388: Error: Package: kernel-3.10.0-229.1.2.el7.x86_64 (el-updates) (11:56:30 AM) fromani_: DEBUG util.py:388: Requires: linux-firmware = 20140911 (11:56:30 AM) fromani_: DEBUG util.py:388: Available: linux-firmware-20140213-0.3.git4164c23.el7.noarch (el) (11:56:30 AM) fromani_: DEBUG util.py:388: linux-firmware = 20140213-0.3.git4164c23.el7 (11:56:30 AM) fromani_: DEBUG util.py:388: You could try using --skip-broken to work around the problem -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: disappeared domain are not ready for commands
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: disappeared domain are not ready for commands .. Patch Set 27: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1564/ -- To view, visit https://gerrit.ovirt.org/39370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63ba190b2f2830292ec282c1ec5c8eb8e42f3530 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Started (1/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/558/ -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: simplify flows
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: simplify flows .. Patch Set 3: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1565/ -- To view, visit https://gerrit.ovirt.org/40326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide103d0ed9a694cc9ddd9b0b382e2d81a1bd48c0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Started (3/9) - http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/972/ -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: rename stats cache to vm stats cache
oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: rename stats cache to vm stats cache .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18332/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1562/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38c49f686dfc2bc0994d444ff24c7736f2e951b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Started (4/9) - http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/554/ -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: simplify flows
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: simplify flows .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18335/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1565/ : FAILURE -- To view, visit https://gerrit.ovirt.org/40326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide103d0ed9a694cc9ddd9b0b382e2d81a1bd48c0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: graphdev: support headless VM
Michal Skrivanek has posted comments on this change. Change subject: virt: graphdev: support headless VM .. Patch Set 22: Code-Review+1 how about merging this finally?:-) -- To view, visit https://gerrit.ovirt.org/27846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafeb0bebfb43c089614127d94c054175c111ce54 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 1: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1567/ -- To view, visit https://gerrit.ovirt.org/40390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: introduce expensive checks
oVirt Jenkins CI Server has posted comments on this change. Change subject: sampling: introduce expensive checks .. Patch Set 1: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1568/ -- To view, visit https://gerrit.ovirt.org/40391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b3bb707dd60de194eedfc2e3de1efbf05574ff7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: profiling: add support for memory profiling
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: add support for memory profiling .. Patch Set 21: Build Failed http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/558/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/935/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/972/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/554/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/970/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/567/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/112/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/112/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/44/ : 0 -- To view, visit https://gerrit.ovirt.org/32019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Gather disk replication private methods
Freddy Rolland has posted comments on this change. Change subject: vm: Gather disk replication private methods .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I075636735ad9f2a53c2ed81ea20925a7bfda376d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 2: Verified+1 I looked to divide this patch into smaller chunks but I do not really see possibility. I still need to add peer verification. Tested basic flows with the engine and no issues noticed. More extensive testing required. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
Darshan N has posted comments on this change. Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39324/2/vdsm/caps.py File vdsm/caps.py: Line 712: extraFeaturesSupported Its ok to give all the features considering we don't have a good group name have made both the changes suggested by bala -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak InterfaceSampleTests.
oVirt Jenkins CI Server has posted comments on this change. Change subject: unbreak InterfaceSampleTests. .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18322/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1552/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 2: Build Started (2/5) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1554/ -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
automat...@ovirt.org has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 2: Build Started (1/5) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18324/ -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Piotr Kliczewski has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 2: Alon, I missed your comment. I am aware of the ssl session being not reused. With jsonrpc there is no issue due to different connection handling. With xmlrpc we started to use http1.1 so it should not be an issue. I engaged perf team to measure impact of this change. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs
..
Patch Set 5:
(11 comments)
https://gerrit.ovirt.org/#/c/40312/5/vdsm_hooks/ovs/ovs_network_setup.py
File vdsm_hooks/ovs/ovs_network_setup.py:
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: TODO
Line 21: - edit instead of remove and add
first bullet is not so clear
Line 22: - change bond slaves under a vlan
Line 23: - test if parameters are correct (bridged etc)
Line 24: - ip configuration
Line 25: - persistence (NOTE: i don't know if it is possible to dissable ovs
persistence
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: TODO
Line 21: - edit instead of remove and add
Line 22: - change bond slaves under a vlan
= change bond slaves of an existing bond, probably
Line 23: - test if parameters are correct (bridged etc)
Line 24: - ip configuration
Line 25: - persistence (NOTE: i don't know if it is possible to dissable ovs
persistence
Line 26: but we could simply remove the whole ovsbr0 on startup
Line 23: - test if parameters are correct (bridged etc)
Line 24: - ip configuration
Line 25: - persistence (NOTE: i don't know if it is possible to dissable ovs
persistence
Line 26: but we could simply remove the whole ovsbr0 on startup
Line 27: - add get-vds-caps hook-point, internal bridge as VDSM bridge
th get-vds-caps hook-point already exists, you only need to add a hook script.
Line 28: - add get-vds-stats hook-point
Line 29: - tests
Line 30: - on a device removal, check if it is in config and running in ovs
Line 31: do the same for remove_redundant_bridge
Line 24: - ip configuration
Line 25: - persistence (NOTE: i don't know if it is possible to dissable ovs
persistence
Line 26: but we could simply remove the whole ovsbr0 on startup
Line 27: - add get-vds-caps hook-point, internal bridge as VDSM bridge
Line 28: - add get-vds-stats hook-point
AND a script to report bond/bridge/vlan stats properly.
Also - we need a hook script for before_device_create.
Line 29: - tests
Line 30: - on a device removal, check if it is in config and running in ovs
Line 31: do the same for remove_redundant_bridge
Line 32: - better names
Line 25: - persistence (NOTE: i don't know if it is possible to dissable ovs
persistence
Line 26: but we could simply remove the whole ovsbr0 on startup
Line 27: - add get-vds-caps hook-point, internal bridge as VDSM bridge
Line 28: - add get-vds-stats hook-point
Line 29: - tests
add a functional test that is skipped if the hook is not installed. MAYBE - do
that for ALL tests. If the hook is installed, run them again with ovs per
network
Line 30: - on a device removal, check if it is in config and running in ovs
Line 31: do the same for remove_redundant_bridge
Line 32: - better names
Line 33:
Line 27: - add get-vds-caps hook-point, internal bridge as VDSM bridge
Line 28: - add get-vds-stats hook-point
Line 29: - tests
Line 30: - on a device removal, check if it is in config and running in ovs
Line 31: do the same for remove_redundant_bridge
I'm not sure this is needed - we can assume that if the network is in ovs, we
are the ones that have put it there.
Line 32: - better names
Line 33:
Line 34: import hooking
Line 35: import traceback
Line 28: - add get-vds-stats hook-point
Line 29: - tests
Line 30: - on a device removal, check if it is in config and running in ovs
Line 31: do the same for remove_redundant_bridge
Line 32: - better names
I hate the name handle_*, but I don't have a good replacement.
Line 33:
Line 34: import hooking
Line 35: import traceback
Line 36:
Line 119: non_ovs_bondings[bonding] = attrs
Line 120:
Line 121: for bonding, attrs in bondings.items():
Line 122: if 'remove' not in attrs:
Line 123: if 'custom' in attrs and
bool(attrs['custom'].get('ovs')):
Engine cannot set 'custom' on bonds.
However, we can abuse bonding's options (which is a space-sparated list of
key=value)
Line 124: self.setup_ovs_bonding(bonding, attrs)
Line 125: else:
Line 126: non_ovs_bondings[bonding] = attrs
Line 127:
Line 134:
Line 135: if vlan is not None:
Line 136: vlan = str(vlan)
Line 137: self.commands.extend(
Line 138: ['--', 'add-br', network, _BRIDGE_NAME, str(vlan)])
# TODO: handle the case of modifying an existing network
Line 139:
Line 140: if nic is not None:
Line 141: self.commands.extend(
Line 142: ['--', '--may-exist', 'add-port', _BRIDGE_NAME, nic])
Line 140: if nic is not None:
Line 141: self.commands.extend(
Line 142: ['--', '--may-exist', 'add-port', _BRIDGE_NAME, nic])
Line 143: if vlan is not None:
Line 144:
Change in vdsm[master]: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps. .. Patch Set 4: -Verified Build Started (1/2) - http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18321/ -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps. .. Patch Set 4: Build Started (2/2) - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1551/ -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds a new element 'additionalFeatures' to getVdsCaps.
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: Adds a new element 'additionalFeatures' to getVdsCaps. .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18321/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1551/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/39324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic203fa0565914d528ae457427f6f1ff7708017d2 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Ramesh N rnach...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Petr Horáček has uploaded a new change for review.
Change subject: netlink: fix PEP8 in netlink memory leak patch
..
netlink: fix PEP8 in netlink memory leak patch
Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61
Bug-Url: https://bugzilla.redhat.com/1158108
Signed-off-by: Petr Horáček phora...@redhat.com
---
M lib/vdsm/netlink.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/40383/1
diff --git a/lib/vdsm/netlink.py b/lib/vdsm/netlink.py
index d822944..8aae2e5 100644
--- a/lib/vdsm/netlink.py
+++ b/lib/vdsm/netlink.py
@@ -333,7 +333,7 @@
_nl_af2str = _int_char_proto(('nl_af2str', LIBNL))
_rtnl_scope2str = _int_char_proto(('rtnl_scope2str', LIBNL_ROUTE))
-_rtnl_link_put = _none_proto(('rtnl_link_put', LIBNL_ROUTE))
+_rtnl_link_put = _none_proto(('rtnl_link_put', LIBNL_ROUTE))
_nl_link_cache = partial(_cache_manager, _rtnl_link_alloc_cache)
_nl_addr_cache = partial(_cache_manager, _rtnl_addr_alloc_cache)
--
To view, visit https://gerrit.ovirt.org/40383
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček phora...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
automat...@ovirt.org has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: * Update tracker::#1158108::OK * Check Bug-Url::OK * Check Public Bug::#1158108::OK, public bug * Check Product::#1158108::OK, Correct product oVirt * Check TR::#1158108::OK, correct target release 3.5.3 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Rename temporary for clarity
Freddy Rolland has posted comments on this change. Change subject: vm: Rename temporary for clarity .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic46d420e4af13da3d8e1dac45895f0bdee1af6d7 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Alon Bar-Lev has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 1: in the past there were multiple issues with python2 ssl implementation, as far as I remember especially with the session renegotiation and session reuse. if we revert back to python, and let's assume the jsonrpc is using persistent connection, older engines that use xmlrpc will have performance impact. please note that in scale the engine will require to drop/reestablish sessions as the resources at engine side are limited, so assuming long living sessions is problematic, unless we introduce the concept of engine proxy. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ssl: m2crypto removal
Alon Bar-Lev has posted comments on this change. Change subject: ssl: m2crypto removal .. Patch Set 2: again, in large scale there is a must to disconnect/connect due to resource limitations, it is incorrect to assume engine can keep connection open to all hosts at once. -- To view, visit https://gerrit.ovirt.org/39990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f2688b6c00eadd3f15be0ced926a397b55c1f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Simone Tiraboschi stira...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: unbreak testHostSampleHandlesDisappearingVlanInterfaces.
Francesco Romani has posted comments on this change. Change subject: unbreak testHostSampleHandlesDisappearingVlanInterfaces. .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40346/2/tests/samplingTests.py File tests/samplingTests.py: Line 180: with MonkeyPatchScope([(sampling, 'NumaNodeMemorySample', Line 181: NumaNodeMemorySampleMock)]): Line 182: with dummy_if() as dummy_name: Line 183: with vlan(self.NEW_VLAN, dummy_name, 999): Line 184: hs = sampling.HostSample(os.getpid()) well, I guess I initially called HostSample constructor to catch future cas Your approach *is* more correct - we should test public interface, not private one. Problem is that HostSample needs a serious amount a refactoring, so this is impractical due to the huge amount of faking and monkeypatching required. In the end, this will make the test worse. On a positive side, I begun a (low-priority :( ) refactoring of the missing bits of sampling.py, including HostSample and co. Reviews will be appreciated! :) Line 185: self.assertNotIn(self.NEW_VLAN, hs.interfaces) Line 186: Line 187: Line 188: @expandPermutations -- To view, visit https://gerrit.ovirt.org/40346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f5f2298cf6202d80f54d736ef20646d7d4a04e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
