Change in vdsm[master]: gluster: Remove Vdsm's dependency on glusterfs-server pkg
Bala.FA has posted comments on this change.
Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/41568/11/vdsm.spec.in
File vdsm.spec.in:
Line 279: %endif # rhel
Line 280:
Line 281: # GlusterFS client-side RPMs needed for Gluster SD
Line 282: Requires: glusterfs-cli >= %{gluster_version}
Line 283: Requires: glusterfs-fuse >= %{gluster_version}
> Darshan,
This is not a valid assumption. vdsm/gluster/cli.py is part of vdsm package
itself and we have all gluster function calls available in supervdsm (It got
moved to vdsm package along with GlusterSD long back).
Please refer line #1189.
Line 284:
Line 285: Requires: psmisc >= 22.6-15
Line 286: Requires: bridge-utils
Line 287: Requires: sos
--
To view, visit https://gerrit.ovirt.org/41568
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: use new mocking in hostdevTests
Martin Polednik has posted comments on this change. Change subject: virt: use new mocking in hostdevTests .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40905/3/tests/hostdevTests.py File tests/hostdevTests.py: Line 206: Line 207: class Connection(fake.Connection): Line 208: Line 209: def __init__(self, *args): Line 210: self._virNodeDevices = [] > self._virNodeDevices = [ yep! will coolify Line 211: Line 212: for device in _PCI_DEVICES + _USB_DEVICES + _SCSI_DEVICES: Line 213: self._virNodeDevices.append(self.nodeDeviceLookupByName(device)) Line 214: Line 212: for device in _PCI_DEVICES + _USB_DEVICES + _SCSI_DEVICES: Line 213: self._virNodeDevices.append(self.nodeDeviceLookupByName(device)) Line 214: Line 215: def listAllDevices(self, flags=0): Line 216: return self._virNodeDevices > frankly, we don't really need the _virNodeDevices cache - we can listdir() good point, will fix Line 217: Line 218: Line 219: def _fake_totalvfs(device_name): Line 220: if device_name == 'pci__05_00_1': -- To view, visit https://gerrit.ovirt.org/40905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e21dcaf6f645acb8229c01f40569785e1416cc2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats
Martin Polednik has posted comments on this change. Change subject: virt: sampling: omit stacktrace if no cpu stats .. Patch Set 3: Code-Review+1 The code itself seems fine, will test on POWER asap (because it's one place where the KeyError is raised periodically) -- To view, visit https://gerrit.ovirt.org/42476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894a0ace8e3dce3cf3399ed71942e41f719133fb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fixed scratchpad hook's image permissions and virtio device ...
Eyal Edri has posted comments on this change. Change subject: Fixed scratchpad hook's image permissions and virtio device name .. Patch Set 2: @anton, after this will be merged, we should consider to back-port it to 3.5.4, as we're using 3.5 in the phx lab. -- To view, visit https://gerrit.ovirt.org/42573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e0e2b09eddeb020ac380bfb9b5d9be73ce5377b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Anton Marchukov Gerrit-Reviewer: Amador Pahim Gerrit-Reviewer: Anton Marchukov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Doron Fediuck Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Wenyi Gao Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Allow gluster mount with additional servers
Nir Soffer has posted comments on this change. Change subject: gluster: Allow gluster mount with additional servers .. Patch Set 28: -Verified Ala, the patch you depend on no longer includes the glusterVolumeInfo code in vdsm - is it possible that an older vdsm-gluster package was installed when you verified this patch without the vdsm-gluster package? Please verify again that after removing vdsm-gluster package, mounting gluster storage domain works. -- To view, visit https://gerrit.ovirt.org/40665 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2478a5edc1fc9d24eb96d64a32a98a2467ce2989 Gerrit-PatchSet: 28 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Darshan N Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: build: Build vdsm-gluster as part of RHEV vdsm build
Nir Soffer has posted comments on this change. Change subject: build: Build vdsm-gluster as part of RHEV vdsm build .. Patch Set 11: Code-Review-1 We cannot use this patch, as it introduce dependency on glusterfs packages which vdsm does not depend on, and which are not available for rhev users. See Allon comment in version 6: https://gerrit.ovirt.org/#/c/41858/6/vdsm.spec.in Seems that this patch should be squashed into https://gerrit.ovirt.org/41568 -- To view, visit https://gerrit.ovirt.org/41858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib487f226a7a0853b600246f1cb0707c3526a7fd0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Remove Vdsm's dependency on glusterfs-server pkg
Nir Soffer has posted comments on this change.
Change subject: gluster: Remove Vdsm's dependency on glusterfs-server pkg
..
Patch Set 11: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41568/11/vdsm.spec.in
File vdsm.spec.in:
Line 279: %endif # rhel
Line 280:
Line 281: # GlusterFS client-side RPMs needed for Gluster SD
Line 282: Requires: glusterfs-cli >= %{gluster_version}
Line 283: Requires: glusterfs-fuse >= %{gluster_version}
Darshan,
These dependencies are not enough - we depend now on
supervdsmServer.glusterVolumeInfo() for mounting a gluster domain
(see https://gerrit.ovirt.org/40665 and https://gerrit.ovirt.org/41931).
In older version of this patch (https://gerrit.ovirt.org/#/c/41568/7),
you moved the required code info vdsm, which made it possible to
use glusterfs storage domain without installing vdsm-gluster. For
that version, we do need the glusterfs-cli and glusterfs-fuse packages
as vdsm requirement.
However since you reverted these changes in version 8 of this patch,
we are depending again on vdsm-gluster, so these dependencies belong
in vdsm-gluster package, and not in vdsm.
In the current version, this patch does not solve anything. You removed
the server dependencies, but we cannot use the client packages because
the code to use them is included in a package which still required the
server packages :-)
Line 284:
Line 285: Requires: psmisc >= 22.6-15
Line 286: Requires: bridge-utils
Line 287: Requires: sos
--
To view, visit https://gerrit.ovirt.org/41568
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43c8f16e8171693d1bbbff40198c59646022603e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: omit stacktrace if no cpu stats
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/42476/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-06-19 11:04:49 +0200
Line 6:
Line 7: virt: sampling: omit stacktrace if no cpu stats
Line 8:
Line 9: Cpu stats may be temporarily unavailable.
> could you elaborate on when they are unavailable, but we should not really
in general, the bulk stats will skip groups that cannot be gathered (e.g. cpu
stats) and will raise error only in presence of critical errors, e.g. memory
allocation failure, or timeout.
So it is safer and better not assume about the availability of groups.
For example the cgroups bug we faced not long ago
(https://bugzilla.redhat.com/show_bug.cgi?id=1139223) may trigger this
misbehaviour.
(will add the above to commit message in the next upload)
Line 10: Unrecoverable errors are rare. However,
Line 11: in any case a warning is sufficient, and
Line 12: a stack trace nowadays only adds noise
Line 13: and confusion.
https://gerrit.ovirt.org/#/c/42476/2/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:
Line 80: 'invalid interval %i when computing CPU stats for %s',
Line 81: interval, vm.id)
Line 82: return
Line 83:
Line 84: try:
> it would be cleaner and safer to check precisely for the keys that may not
Libvirt uses a cgroup to do this accounting. The case I'm looking to guard
against is when all of the cpu.* below stats are missing.
If, let's say, _only_ cpu.user is missing, something really wrong happenend
inside libvirt.
In another patch, I will check for the availability of the three keys we use in
this function, and remove the try/catch block.
Line 85: stats['cpuUsage'] = str(last_sample['cpu.system'] +
Line 86: last_sample['cpu.user'])
Line 87:
Line 88: stats['cpuSys'] = _usage_percentage(
Line 94: - _diff(last_sample, first_sample, 'cpu.user')
Line 95: - _diff(last_sample, first_sample, 'cpu.system'),
Line 96: interval)
Line 97:
Line 98: except KeyError as e:
> nit: e is not used
will remove
Line 99: logging.warning("CPU stats not available for %s", vm.id)
Line 100:
Line 101:
Line 102: def balloon(vm, stats, sample):
--
To view, visit https://gerrit.ovirt.org/42476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I894a0ace8e3dce3cf3399ed71942e41f719133fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: return correct vcpu positioning info
Francesco Romani has posted comments on this change. Change subject: sampling: return correct vcpu positioning info .. Patch Set 2: Verified+1 v2 only adds tests, no code changes -> restoring score. -- To view, visit https://gerrit.ovirt.org/42571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28dbbef45c20c32f8b72b0c4d91fe2e75700d2a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: virt: do not poll storage in migrations
automat...@ovirt.org has posted comments on this change. Change subject: periodic: virt: do not poll storage in migrations .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43ec1e64700020b7d143e22c4c3d8bdceb57fb18 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: return correct vcpu positioning info
automat...@ovirt.org has posted comments on this change. Change subject: sampling: return correct vcpu positioning info .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28dbbef45c20c32f8b72b0c4d91fe2e75700d2a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats
automat...@ovirt.org has posted comments on this change. Change subject: virt: sampling: omit stacktrace if no cpu stats .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894a0ace8e3dce3cf3399ed71942e41f719133fb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs if sampling hollow VMs
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs if sampling hollow VMs .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If130a4b31016e971ac9972b67ba5d3fd70de5b7d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: executor: allow caller to resize TaskQueue
automat...@ovirt.org has posted comments on this change. Change subject: executor: allow caller to resize TaskQueue .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8df4d8bbc599fa2de1dc17de8fbd2726809f5de3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs with periodic false negative
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs with periodic false negative .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41659 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f0f5a46bcb8ed1197fe389a0b2904fa6939659d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks
automat...@ovirt.org has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
Francesco Romani has posted comments on this change. Change subject: migration: wait after the downtime is updated .. Patch Set 5: Verified+1 re-verified as previously stated -- To view, visit https://gerrit.ovirt.org/42577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: allow one-step downtime settings
Francesco Romani has posted comments on this change. Change subject: migration: allow one-step downtime settings .. Patch Set 5: Verified+1 re-verified as previously stated -- To view, visit https://gerrit.ovirt.org/42576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
Francesco Romani has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 4: Verified+1 v3->v4 changes only commit message and rebases -> restoring score. -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
automat...@ovirt.org has posted comments on this change. Change subject: migration: wait after the downtime is updated .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
automat...@ovirt.org has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: allow one-step downtime settings
automat...@ovirt.org has posted comments on this change. Change subject: migration: allow one-step downtime settings .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
Francesco Romani has posted comments on this change.
Change subject: migration: make downtime steps instance attributes
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/42578/3//COMMIT_MSG
Commit Message:
Line 10: coder
> s/r//.
The problem is that DowntimeThread has this
DOWNTIME_STEPS = config.getint('vars', 'migration_downtime_steps')
as class attribute. So config is evaluted when class statement is evaluated,
and this makes the code awkward to monkeypatch.
Moreover, I like the new code a bit more.
--
To view, visit https://gerrit.ovirt.org/42578
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
Dan Kenigsberg has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/42578/3//COMMIT_MSG Commit Message: Line 10: coder s/r//. you could have used monkeypatching for the new tests, but it's ok to make DowntimeThread more functional, and access the global vdsm.config.config a bit less. -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats
Dan Kenigsberg has posted comments on this change.
Change subject: virt: sampling: omit stacktrace if no cpu stats
..
Patch Set 2: Code-Review-1
(3 comments)
nits and questions
https://gerrit.ovirt.org/#/c/42476/2//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-06-19 11:04:49 +0200
Line 6:
Line 7: virt: sampling: omit stacktrace if no cpu stats
Line 8:
Line 9: Cpu stats may be temporarily unavailable.
could you elaborate on when they are unavailable, but we should not really
worry?
Line 10: Unrecoverable errors are rare. However,
Line 11: in any case a warning is sufficient, and
Line 12: a stack trace nowadays only adds noise
Line 13: and confusion.
https://gerrit.ovirt.org/#/c/42476/2/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:
Line 80: 'invalid interval %i when computing CPU stats for %s',
Line 81: interval, vm.id)
Line 82: return
Line 83:
Line 84: try:
it would be cleaner and safer to check precisely for the keys that may not
exist, as a big KeyError might catch unrelated errors deeper in the stack.
Howe does the typical KeyError traceback look like? Where does it come from?
Line 85: stats['cpuUsage'] = str(last_sample['cpu.system'] +
Line 86: last_sample['cpu.user'])
Line 87:
Line 88: stats['cpuSys'] = _usage_percentage(
Line 94: - _diff(last_sample, first_sample, 'cpu.user')
Line 95: - _diff(last_sample, first_sample, 'cpu.system'),
Line 96: interval)
Line 97:
Line 98: except KeyError as e:
nit: e is not used
Line 99: logging.warning("CPU stats not available for %s", vm.id)
Line 100:
Line 101:
Line 102: def balloon(vm, stats, sample):
--
To view, visit https://gerrit.ovirt.org/42476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I894a0ace8e3dce3cf3399ed71942e41f719133fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
Francesco Romani has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 3: more additional verification proof: Thread-83::DEBUG::2015-06-19 17:27:15,459::migration::436::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread started (2 steps) Thread-84::DEBUG::2015-06-19 17:27:15,460::migration::489::vm.Vm::(monitor_migration) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::starting migration monitor thread Thread-83::DEBUG::2015-06-19 17:27:15,462::migration::454::vm.Vm::(_update_downtime) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 251 -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
Francesco Romani has posted comments on this change. Change subject: migration: wait after the downtime is updated .. Patch Set 4: Verified+1 Works, downtime is updated immediately: Thread-433::DEBUG::2015-06-19 17:21:02,882::migration::436::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread started (10 steps) Thread-434::DEBUG::2015-06-19 17:21:02,882::migration::489::vm.Vm::(monitor_migration) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::starting migration monitor thread Thread-433::DEBUG::2015-06-19 17:21:02,883::migration::454::vm.Vm::(_update_downtime) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::setting migration downtime to 51 and then Thread-432::DEBUG::2015-06-19 17:21:29,321::migration::547::vm.Vm::(stop) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::stopping migration monitor thread Thread-432::DEBUG::2015-06-19 17:21:29,322::migration::446::vm.Vm::(stop) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::stopping migration downtime thread Thread-432::INFO::2015-06-19 17:21:29,322::migration::356::vm.Vm::(_startUnderlyingMigration) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration took 28 seconds to complete Thread-433::DEBUG::2015-06-19 17:21:29,323::migration::443::vm.Vm::(run) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::migration downtime thread exiting Thread-432::INFO::2015-06-19 17:21:29,331::vm::1290::vm.Vm::(setDownStatus) vmId=`ace61b23-f455-4fc7-8d59-d9c469657b2a`::Changed state to Down: Migration succeeded (code=4) -- To view, visit https://gerrit.ovirt.org/42577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
Francesco Romani has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 3: as additional verification, succesfully migrated VM. -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: do not catch unlikely ZeroDivisionError
Dan Kenigsberg has posted comments on this change. Change subject: vmstats: do not catch unlikely ZeroDivisionError .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c6719414d185a8b359b5d8a9f4a28ac87b64327 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
automat...@ovirt.org has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: do not catch unlikely ZeroDivisionError
Dan Kenigsberg has submitted this change and it was merged. Change subject: vmstats: do not catch unlikely ZeroDivisionError .. vmstats: do not catch unlikely ZeroDivisionError Nowadays, the only foreseeable reason to have ZeroDivisionError in the vmstats functions, is when interval is zero. This case is in turn very very unlikely, as it should happen only in the extravagant case of two polling cycles racing together, saving bad bugs in the sampling code. So, drop the ZeroDivisionError from the handled exception, and we add an explicit guard to be sure we record these end-of-the-world-like cases. Change-Id: I6c6719414d185a8b359b5d8a9f4a28ac87b64327 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/40916 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/vmstats.py 1 file changed, 17 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/40916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c6719414d185a8b359b5d8a9f4a28ac87b64327 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
Dan Kenigsberg has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: do not catch unlikely ZeroDivisionError
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: do not catch unlikely ZeroDivisionError .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c6719414d185a8b359b5d8a9f4a28ac87b64327 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: more detailed stale sampling reporting .. sampling: more detailed stale sampling reporting To improve troubleshooting, report timestamps of current and stale samples when discarding data for timestamp too old. We are already logging this event, so adding new information is quite cheap and can make troubleshooting easier. Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/40390 Reviewed-by: Michal Skrivanek Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/sampling.py 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: TypeError is unlikely with modern libvirt
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: TypeError is unlikely with modern libvirt .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: TypeError is unlikely with modern libvirt
Dan Kenigsberg has submitted this change and it was merged. Change subject: vmstats: TypeError is unlikely with modern libvirt .. vmstats: TypeError is unlikely with modern libvirt Modern libvirts, which we already require, make use of virTypedParameter, which the Python bindings make safe to transform in the proper native types. Thus, a TypeError is highly unlikely those days. Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/40917 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/vmstats.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/40917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: TypeError is unlikely with modern libvirt
Dan Kenigsberg has posted comments on this change. Change subject: vmstats: TypeError is unlikely with modern libvirt .. Patch Set 7: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/40917/7//COMMIT_MSG Commit Message: Line 10: use of virTypedParameter, which the Python Line 11: bindings make safe to transform in the proper Line 12: native types. Line 13: Line 14: Thus, a TypeError is highly unlikely those days. I believe that TypeError was introduced not against crazy values in libvirt response, but against more mundane last_sample == None cases, which are properly tested nowadays. Still, the bottom line applies. Line 15: Line 16: Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 -- To view, visit https://gerrit.ovirt.org/40917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: use constants for counter bounds
Dan Kenigsberg has posted comments on this change. Change subject: sampling: use constants for counter bounds .. Patch Set 5: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/24194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I706000106c3bc31edf8541c980bce1f49464ebf8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: use constants for counter bounds
Dan Kenigsberg has posted comments on this change. Change subject: sampling: use constants for counter bounds .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/24194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I706000106c3bc31edf8541c980bce1f49464ebf8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: use constants for counter bounds
automat...@ovirt.org has posted comments on this change. Change subject: sampling: use constants for counter bounds .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/24194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I706000106c3bc31edf8541c980bce1f49464ebf8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: use constants for counter bounds
Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: use constants for counter bounds .. sampling: use constants for counter bounds When we report cpu and network usage, we take two samples of Linux counters, and divide their difference by the elapsed time. If a sampled counter wraps around its upper bound, we might report an invalid negative value. To avoid that, we take the modulu of the difference. For example, assume that the first sample was (2**64 - 10) jiffies and 30 jiffies have passed until the second sample, the difference would be the hugely negative value (30 - 2**64). Taking modulu 2**64 returns the correct value of 30 jiffies. JIFFIES_BOUND is taken from the size of clock_t and NETSTATS_BOUND - from the size of the fields of struct net_device_stats. I am not aware of any programmatic way to acquire this value, but they are both of 64 bit size on x86_64 and ppc64. Taking modulu 2**32 works perfectly well, since two subsequent samples are unlikly to be that far apart, and it has the benefit of working well on a 32 bit host, too. Change-Id: I706000106c3bc31edf8541c980bce1f49464ebf8 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/24194 Reviewed-by: Nir Soffer Tested-by: Francesco Romani --- M vdsm/virt/sampling.py 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/24194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I706000106c3bc31edf8541c980bce1f49464ebf8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: fix spacing
automat...@ovirt.org has posted comments on this change. Change subject: migration: fix spacing .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8daf550fb1241872e2a0e5e7e8f0582402e03c04 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: fix spacing
Dan Kenigsberg has submitted this change and it was merged. Change subject: migration: fix spacing .. migration: fix spacing Change-Id: I8daf550fb1241872e2a0e5e7e8f0582402e03c04 Signed-off-by: Francesco Romani Reviewed-on: https://gerrit.ovirt.org/40519 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/virt/migration.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/40519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8daf550fb1241872e2a0e5e7e8f0582402e03c04 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
Francesco Romani has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 3: Verified+1 Easy refactoring patch. added (and verified) using tests. -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: allow one-step downtime settings
automat...@ovirt.org has posted comments on this change. Change subject: migration: allow one-step downtime settings .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
automat...@ovirt.org has posted comments on this change. Change subject: migration: wait after the downtime is updated .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
automat...@ovirt.org has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: make sure to send only one event per status
Piotr Kliczewski has posted comments on this change. Change subject: events: make sure to send only one event per status .. Patch Set 2: Verified+1 Verified by running latest engine and vdsm and stopping a vm to see that event was triggered. -- To view, visit https://gerrit.ovirt.org/42579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: make sure to send only one event per status
automat...@ovirt.org has posted comments on this change. Change subject: events: make sure to send only one event per status .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: send event explicitly after vm was started
automat...@ovirt.org has posted comments on this change. Change subject: events: send event explicitly after vm was started .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14e42510fd79796b7587390817a1c1a45773b00f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: make sure to send only one event per status
Piotr Kliczewski has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42579/1//COMMIT_MSG
Commit Message:
Line 7: events: make sure to send only one event per status
Line 8:
Line 9: Initially we made an assumption that engine can handle more than one
Line 10: event containing the same status. The assumtion is not true and there
Line 11: are flows where engine logic assumes only one status change.
> could you elaborate on the Engine use flows broken by this?
I was told that there are issues with Destroy vm when we receive more than
single event with 'Down' status.
Will update commit message.
Line 12:
Line 13: Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808
https://gerrit.ovirt.org/#/c/42579/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 381: self._lastStatus = value
Line 382:
Line 383: def send_status_event(self):
Line 384: with self._eventLock:
Line 385: vm_status = self._getVmStatus()['status']
> usually I prefer holding locks for the shortest possible time. do we really
We don't. Will change.
Line 386:
Line 387: if vm_status != self._evaluatedStatus:
Line 388: self._evaluatedStatus = vm_status
Line 389: stats = {
--
To view, visit https://gerrit.ovirt.org/42579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: make sure to send only one event per status
Dan Kenigsberg has posted comments on this change.
Change subject: events: make sure to send only one event per status
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42579/1//COMMIT_MSG
Commit Message:
Line 7: events: make sure to send only one event per status
Line 8:
Line 9: Initially we made an assumption that engine can handle more than one
Line 10: event containing the same status. The assumtion is not true and there
Line 11: are flows where engine logic assumes only one status change.
could you elaborate on the Engine use flows broken by this?
How are they not broken by repeated polls of an unchanging status?
Line 12:
Line 13: Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808
https://gerrit.ovirt.org/#/c/42579/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 381: self._lastStatus = value
Line 382:
Line 383: def send_status_event(self):
Line 384: with self._eventLock:
Line 385: vm_status = self._getVmStatus()['status']
usually I prefer holding locks for the shortest possible time. do we really
need to call _getVmStatus under the lock?
Line 386:
Line 387: if vm_status != self._evaluatedStatus:
Line 388: self._evaluatedStatus = vm_status
Line 389: stats = {
--
To view, visit https://gerrit.ovirt.org/42579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yeela Kaplan
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
Michal Skrivanek has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
Michal Skrivanek has posted comments on this change. Change subject: migration: wait after the downtime is updated .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: allow one-step downtime settings
Michal Skrivanek has posted comments on this change. Change subject: migration: allow one-step downtime settings .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
automat...@ovirt.org has posted comments on this change. Change subject: migration: wait after the downtime is updated .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: allow one-step downtime settings
automat...@ovirt.org has posted comments on this change. Change subject: migration: allow one-step downtime settings .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
automat...@ovirt.org has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: send event explicitly after vm was started
Dan Kenigsberg has posted comments on this change. Change subject: events: send event explicitly after vm was started .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14e42510fd79796b7587390817a1c1a45773b00f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: use new mocking in hostdevTests
Dan Kenigsberg has posted comments on this change. Change subject: virt: use new mocking in hostdevTests .. Patch Set 3: (2 comments) I want to see this patch in, but maybe it can be improved. https://gerrit.ovirt.org/#/c/40905/3/tests/hostdevTests.py File tests/hostdevTests.py: Line 206: Line 207: class Connection(fake.Connection): Line 208: Line 209: def __init__(self, *args): Line 210: self._virNodeDevices = [] self._virNodeDevices = [ self.nodeDeviceLookupByName(device) for device in _PCI_DEVICES + _USB_DEVICES + _SCSI_DEVICES] is so much cooler Line 211: Line 212: for device in _PCI_DEVICES + _USB_DEVICES + _SCSI_DEVICES: Line 213: self._virNodeDevices.append(self.nodeDeviceLookupByName(device)) Line 214: Line 212: for device in _PCI_DEVICES + _USB_DEVICES + _SCSI_DEVICES: Line 213: self._virNodeDevices.append(self.nodeDeviceLookupByName(device)) Line 214: Line 215: def listAllDevices(self, flags=0): Line 216: return self._virNodeDevices frankly, we don't really need the _virNodeDevices cache - we can listdir() in fake.Connection. If we keep it, we have (since the former patch) duplicate possibly-inconsistent data: _virNodeDevice may not list a device, but if its file exists on disk, nodeDeviceLookupByName would report it. Line 217: Line 218: Line 219: def _fake_totalvfs(device_name): Line 220: if device_name == 'pci__05_00_1': -- To view, visit https://gerrit.ovirt.org/40905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e21dcaf6f645acb8229c01f40569785e1416cc2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: use new mocking in hostdevTests
Dan Kenigsberg has posted comments on this change. Change subject: virt: use new mocking in hostdevTests .. Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/40905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e21dcaf6f645acb8229c01f40569785e1416cc2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: use new mocking in hostdevTests
Dan Kenigsberg has posted comments on this change. Change subject: virt: use new mocking in hostdevTests .. Patch Set 3: -1 mostly for visibility -- To view, visit https://gerrit.ovirt.org/40905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e21dcaf6f645acb8229c01f40569785e1416cc2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: send event explicitly after vm was started
Piotr Kliczewski has posted comments on this change. Change subject: events: send event explicitly after vm was started .. Patch Set 1: Verified+1 Verified by using latest engine and vdsm and seeing 'PoweringUp' event being triggered during vm start. -- To view, visit https://gerrit.ovirt.org/42580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14e42510fd79796b7587390817a1c1a45773b00f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: make sure to send only one event per status
Piotr Kliczewski has posted comments on this change. Change subject: events: make sure to send only one event per status .. Patch Set 1: Verified+1 Verified by running latest vdsm and the engine and checking that there was single message send for status changes during start of a vm. -- To view, visit https://gerrit.ovirt.org/42579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: send event explicitly after vm was started
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: send event explicitly after vm was started
..
events: send event explicitly after vm was started
We need to make sure that we send 'PoweringUp' status. After we moved
event send logic from _set_lastStatus to ClientIf we no longer send it.
Change-Id: I14e42510fd79796b7587390817a1c1a45773b00f
Signed-off-by: pkliczewski
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/42580/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 25a9b10..effe69d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -780,6 +780,7 @@
else:
self.log.exception("The vm start process failed")
self.setDownStatus(ERROR, vmexitreason.GENERIC_ERROR, str(e))
+self.send_status_event()
def _incomingMigrationPending(self):
return 'migrationDest' in self.conf or 'restoreState' in self.conf
--
To view, visit https://gerrit.ovirt.org/42580
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14e42510fd79796b7587390817a1c1a45773b00f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: make sure to send only one event per status
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: make sure to send only one event per status
..
events: make sure to send only one event per status
Initially we made an assumption that engine can handle more than one
event containing the same status. The assumtion is not true and there
are flows where engine logic assumes only one status change.
Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808
Signed-off-by: pkliczewski
---
M vdsm/virt/vm.py
1 file changed, 22 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/42579/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 063bc3a..25a9b10 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -306,6 +306,7 @@
else:
self._lastStatus = vmstatus.WAIT_FOR_LAUNCH
self._evaluatedStatus = None
+self._eventLock = threading.Lock()
self._migrationSourceThread = migration.SourceThread(self)
self._kvmEnable = self.conf.get('kvmEnable', 'true')
self._incomingMigrationFinished = threading.Event()
@@ -380,32 +381,30 @@
self._lastStatus = value
def send_status_event(self):
-vm_status = self._getVmStatus()['status']
+with self._eventLock:
+vm_status = self._getVmStatus()['status']
-# this check is to reduce number of send events
-# It is not safe since evaluatedStatus can change but
-# in the worst case we will send the same event twice
-if vm_status != self._evaluatedStatus:
-self._evaluatedStatus = vm_status
-stats = {
-'status': vm_status,
-'hash': str(hash((self._domain.devices_hash,
- self.guestAgent.diskMappingHash))),
-}
+if vm_status != self._evaluatedStatus:
+self._evaluatedStatus = vm_status
+stats = {
+'status': vm_status,
+'hash': str(hash((self._domain.devices_hash,
+ self.guestAgent.diskMappingHash))),
+}
-# TODO: DOWN and exitCode must be set atomically. Once this is done
-# we can remove the multiple conditions from this code.
-if vm_status == vmstatus.DOWN:
-if 'exitCode' in self.conf:
-stats['exitCode'] = self.conf['exitCode']
-if 'exitMessage' in self.conf:
-stats['exitMessage'] = self.conf['exitMessage']
-if 'exitReason' in self.conf:
-stats['exitReason'] = self.conf['exitReason']
+# TODO: DOWN and exitCode must be set atomically. Once this is
+# done we can remove the multiple conditions from this code.
+if vm_status == vmstatus.DOWN:
+if 'exitCode' in self.conf:
+stats['exitCode'] = self.conf['exitCode']
+if 'exitMessage' in self.conf:
+stats['exitMessage'] = self.conf['exitMessage']
+if 'exitReason' in self.conf:
+stats['exitReason'] = self.conf['exitReason']
-self.log.debug('Last status %s and evaluated status %s',
- self.lastStatus, vm_status)
-self._notify('VM_status', stats)
+self.log.debug('Last status %s and evaluated status %s',
+ self.lastStatus, vm_status)
+self._notify('VM_status', stats)
def _notify(self, operation, params):
sub_id = '|virt|%s|%s' % (operation, self.id)
--
To view, visit https://gerrit.ovirt.org/42579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: send event explicitly after vm was started
automat...@ovirt.org has posted comments on this change. Change subject: events: send event explicitly after vm was started .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14e42510fd79796b7587390817a1c1a45773b00f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: make sure to send only one event per status
automat...@ovirt.org has posted comments on this change. Change subject: events: make sure to send only one event per status .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42579 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I044a8f409ccdac4210784e21167bab320ddfe808 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
automat...@ovirt.org has posted comments on this change. Change subject: migration: make downtime steps instance attributes .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42578 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: allow one-step downtime settings
automat...@ovirt.org has posted comments on this change. Change subject: migration: allow one-step downtime settings .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: make downtime steps instance attributes
Francesco Romani has uploaded a new change for review.
Change subject: migration: make downtime steps instance attributes
..
migration: make downtime steps instance attributes
Move the DowntimeThread steps from class constant
to instance attribute, to make the coder more testable.
Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8
Signed-off-by: Francesco Romani
---
M vdsm/virt/migration.py
1 file changed, 8 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/42578/1
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 1e9710e..dd6b7d1 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -342,7 +342,10 @@
self._vm.log.info('starting migration to %s '
'with miguri %s', duri, muri)
-downtimeThread = DowntimeThread(self._vm, int(self._downtime))
+downtimeThread = DowntimeThread(self._vm,
+int(self._downtime),
+config.getint('vars',
+'migration_downtime_steps'))
self._monitorThread = MonitorThread(self._vm, startTime)
with utils.running(downtimeThread):
with utils.running(self._monitorThread):
@@ -410,13 +413,12 @@
class DowntimeThread(threading.Thread):
-DOWNTIME_STEPS = config.getint('vars', 'migration_downtime_steps')
-
-def __init__(self, vm, downtime):
+def __init__(self, vm, downtime, steps):
super(DowntimeThread, self).__init__()
self._vm = vm
self._downtime = downtime
+self._steps = steps
self._stop = threading.Event()
delay_per_gib = config.getint('vars', 'migration_downtime_delay')
@@ -428,9 +430,8 @@
def run(self):
self._vm.log.debug('migration downtime thread started')
-for downtime in exponential_downtime(self._downtime,
- self.DOWNTIME_STEPS):
-self._stop.wait(self._wait / self.DOWNTIME_STEPS)
+for downtime in exponential_downtime(self._downtime, self._steps):
+self._stop.wait(self._wait / self._steps)
if self._stop.isSet():
break
--
To view, visit https://gerrit.ovirt.org/42578
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I326439ad42a108c7f194cf9e8ede1c0e8e4ffec8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
automat...@ovirt.org has posted comments on this change. Change subject: migration: wait after the downtime is updated .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
Michal Skrivanek has posted comments on this change. Change subject: migration: wait after the downtime is updated .. Patch Set 1: Code-Review+1 fix typos in commit message please -- To view, visit https://gerrit.ovirt.org/42577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: allow one-step downtime settings
Michal Skrivanek has posted comments on this change.
Change subject: migration: allow one-step downtime settings
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42576/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 430:
Line 431: if DOWNTIME_STEPS > 1:
Line 432: self._update_downtime()
Line 433: else:
Line 434: self._vm._dom.migrateSetMaxDowntime(self._downtime, 0)
can we set this before the migration actually starts? can it happen?
Line 435:
Line 436: self._vm.log.debug('migration downtime thread exiting')
Line 437:
Line 438:def stop(self):
--
To view, visit https://gerrit.ovirt.org/42576
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
automat...@ovirt.org has posted comments on this change. Change subject: migration: wait after the downtime is updated .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42577 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: allow one-step downtime settings
Francesco Romani has uploaded a new change for review.
Change subject: migration: allow one-step downtime settings
..
migration: allow one-step downtime settings
In specific environments, it may be useful
to have one-step downtime setting.
This actually translates to just set the specified
downtime and go ahead.
Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8
Signed-off-by: Francesco Romani
---
M vdsm/virt/migration.py
1 file changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/42576/1
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 1e9710e..88ef6e7 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -428,6 +428,18 @@
def run(self):
self._vm.log.debug('migration downtime thread started')
+if DOWNTIME_STEPS > 1:
+self._update_downtime()
+else:
+self._vm._dom.migrateSetMaxDowntime(self._downtime, 0)
+
+self._vm.log.debug('migration downtime thread exiting')
+
+ def stop(self):
+self._vm.log.debug('stopping migration downtime thread')
+self._stop.set()
+
+ def _update_downtime(self):
for downtime in exponential_downtime(self._downtime,
self.DOWNTIME_STEPS):
self._stop.wait(self._wait / self.DOWNTIME_STEPS)
@@ -437,12 +449,6 @@
self._vm.log.debug('setting migration downtime to %d', downtime)
self._vm._dom.migrateSetMaxDowntime(downtime, 0)
-
-self._vm.log.debug('migration downtime thread exiting')
-
-def stop(self):
-self._vm.log.debug('stopping migration downtime thread')
-self._stop.set()
class MonitorThread(threading.Thread):
--
To view, visit https://gerrit.ovirt.org/42576
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: wait after the downtime is updated
Francesco Romani has uploaded a new change for review.
Change subject: migration: wait after the downtime is updated
..
migration: wait after the downtime is updated
Current VDSM code waits before to set a new downtime value.
This adds a delay before the VDSM code enters into play,
and there are scenarios on which this leads to unpleasent
behaviours.
This patch makes the DowntimeThread wait after the new
Downtime value is set, for a quicke reaction.
Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4
Signed-off-by: Francesco Romani
---
M vdsm/virt/migration.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/42577/1
diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index 88ef6e7..6103e18 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -442,13 +442,12 @@
def _update_downtime(self):
for downtime in exponential_downtime(self._downtime,
self.DOWNTIME_STEPS):
-self._stop.wait(self._wait / self.DOWNTIME_STEPS)
-
if self._stop.isSet():
break
self._vm.log.debug('setting migration downtime to %d', downtime)
self._vm._dom.migrateSetMaxDowntime(downtime, 0)
+self._stop.wait(self._wait / self.DOWNTIME_STEPS)
class MonitorThread(threading.Thread):
--
To view, visit https://gerrit.ovirt.org/42577
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab8e483803dc21900df5aa96b47634e7be3d55c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: allow one-step downtime settings
automat...@ovirt.org has posted comments on this change. Change subject: migration: allow one-step downtime settings .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42576 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e90ecf04caceddfa886563df4aee825b88b9bd8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: fix spacing
Francesco Romani has posted comments on this change. Change subject: migration: fix spacing .. Patch Set 2: Verified+1 trivial patch, verified with tests. -- To view, visit https://gerrit.ovirt.org/40519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8daf550fb1241872e2a0e5e7e8f0582402e03c04 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fixed scratchpad hook's image permissions and virtio device ...
Anton Marchukov has posted comments on this change. Change subject: Fixed scratchpad hook's image permissions and virtio device name .. Patch Set 2: I have verified this by effectively placing the updated before_vm_start.py script to the test installation and making sure that it indeed add a disk to the VM on start and removes it on shutdown. -- To view, visit https://gerrit.ovirt.org/42573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e0e2b09eddeb020ac380bfb9b5d9be73ce5377b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Anton Marchukov Gerrit-Reviewer: Anton Marchukov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fixed scratchpad hook's image permissions and virtio device ...
automat...@ovirt.org has posted comments on this change. Change subject: Fixed scratchpad hook's image permissions and virtio device name .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e0e2b09eddeb020ac380bfb9b5d9be73ce5377b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Anton Marchukov Gerrit-Reviewer: Anton Marchukov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fixed scratchpad hook's image permissions and virtio device ...
Anton Marchukov has posted comments on this change. Change subject: Fixed scratchpad hook's image permissions and virtio device name .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/42573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e0e2b09eddeb020ac380bfb9b5d9be73ce5377b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Anton Marchukov Gerrit-Reviewer: Anton Marchukov Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fixed scratchpad hook's image permissions and virtio device ...
Anton Marchukov has uploaded a new change for review.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Fixed scratchpad hook's image permissions and virtio device name
Change-Id: I4e0e2b09eddeb020ac380bfb9b5d9be73ce5377b
Signed-off-by: Anton Marchukov
---
M vdsm_hooks/scratchpad/before_vm_start.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/42573/1
diff --git a/vdsm_hooks/scratchpad/before_vm_start.py
b/vdsm_hooks/scratchpad/before_vm_start.py
index 0ff3876..ef851a4 100755
--- a/vdsm_hooks/scratchpad/before_vm_start.py
+++ b/vdsm_hooks/scratchpad/before_vm_start.py
@@ -4,6 +4,7 @@
import re
import sys
import traceback
+import stat
import hooking
@@ -38,6 +39,7 @@
sys.stderr.write('scratchpad: error running command %s, err = %s\n' %
(' '.join(command), err))
sys.exit(2)
+os.chmod(path, stat.S_IRUSR | stat.S_IWUSR | stat.S_IRGRP | stat.S_IWGRP)
def indexToDiskName(i):
@@ -47,7 +49,7 @@
i = i / 26
if i == 0:
break
-return 'hd' + (s or 'a')
+return 'vd' + (s or 'a')
def add_disk(domxml, path):
--
To view, visit https://gerrit.ovirt.org/42573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e0e2b09eddeb020ac380bfb9b5d9be73ce5377b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Anton Marchukov
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fixed scratchpad hook's image permissions and virtio device ...
automat...@ovirt.org has posted comments on this change. Change subject: Fixed scratchpad hook's image permissions and virtio device name .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e0e2b09eddeb020ac380bfb9b5d9be73ce5377b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Anton Marchukov Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: log number of request during period of time
Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonrpc: log number of request during period of time .. jsonrpc: log number of request during period of time We want to understand how many requests were received by vdsm during specified time. Every interval we log known number of requests and we reset the value. Change-Id: Ica05cc22d5ee93d9c0016207386879c52a4acb34 Signed-off-by: pkliczewski Reviewed-on: https://gerrit.ovirt.org/42551 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Dan Kenigsberg --- M lib/vdsm/config.py.in M lib/yajsonrpc/__init__.py M lib/yajsonrpc/stompreactor.py M tests/jsonRpcHelper.py M vdsm/clientIF.py M vdsm/rpc/bindingjsonrpc.py 6 files changed, 35 insertions(+), 7 deletions(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica05cc22d5ee93d9c0016207386879c52a4acb34 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: log number of request during period of time
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: log number of request during period of time .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica05cc22d5ee93d9c0016207386879c52a4acb34 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: log number of request during period of time
automat...@ovirt.org has posted comments on this change. Change subject: jsonrpc: log number of request during period of time .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/42551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica05cc22d5ee93d9c0016207386879c52a4acb34 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Rate limit epoll errors on untracked FDs
Michal Skrivanek has posted comments on this change.
Change subject: virt: Rate limit epoll errors on untracked FDs
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42569/1/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:
Line 181: self._handle_event(fileno, event)
Line 182: if self._untrackedErrors > UNTRACKED_ERROR_RESTART_LIMIT:
Line 183: self.log.critical("Too many epoll errors happened."
Line 184: "Taking down process")
Line 185: os.kill(os.getpid(), signal.SIGTERM)
don't we have a function for that somewhere?
Line 186: elif (self._untrackedErrors > 0 and
Line 187: self._untrackedErrors %
UNTRACKED_ERROR_COOLDOWN_LIMIT == 0):
Line 188: time.sleep(ERROR_RATE_LIMIT_SLEEP_TIME)
Line 189: else:
--
To view, visit https://gerrit.ovirt.org/42569
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I654e5b828e2c05e8a86fa0e945be67cec014c110
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: return correct vcpu positioning info
Piotr Kliczewski has posted comments on this change. Change subject: sampling: return correct vcpu positioning info .. Patch Set 1: Verified+1 After applying this patch I do not see this issue in the logs. -- To view, visit https://gerrit.ovirt.org/42571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28dbbef45c20c32f8b72b0c4d91fe2e75700d2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: return correct vcpu positioning info
Francesco Romani has posted comments on this change. Change subject: sampling: return correct vcpu positioning info .. Patch Set 1: Code-Review-1 I want more unit tests to make sure this won't happen again -- To view, visit https://gerrit.ovirt.org/42571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28dbbef45c20c32f8b72b0c4d91fe2e75700d2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: TypeError is unlikely with modern libvirt
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: TypeError is unlikely with modern libvirt .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I937d7cf0107ea2285f937c3af0f44e5843fad224 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs with periodic false negative
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs with periodic false negative .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41659 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f0f5a46bcb8ed1197fe389a0b2904fa6939659d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: more detailed stale sampling reporting
automat...@ovirt.org has posted comments on this change. Change subject: sampling: more detailed stale sampling reporting .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00cb8f602fc3f26d62dd34bafe05b8169e184b91 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: executor: allow caller to resize TaskQueue
automat...@ovirt.org has posted comments on this change. Change subject: executor: allow caller to resize TaskQueue .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41658 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8df4d8bbc599fa2de1dc17de8fbd2726809f5de3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sampling: return correct vcpu positioning info
automat...@ovirt.org has posted comments on this change. Change subject: sampling: return correct vcpu positioning info .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic28dbbef45c20c32f8b72b0c4d91fe2e75700d2a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vmstats: do not catch unlikely ZeroDivisionError
automat...@ovirt.org has posted comments on this change. Change subject: vmstats: do not catch unlikely ZeroDivisionError .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c6719414d185a8b359b5d8a9f4a28ac87b64327 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: make VmDispatcher ignore TooManyTasks
automat...@ovirt.org has posted comments on this change. Change subject: periodic: make VmDispatcher ignore TooManyTasks .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41657 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2d186327f8607aaeb41ca132a9a8a0806869cf Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: avoid spam logs if sampling hollow VMs
automat...@ovirt.org has posted comments on this change. Change subject: virt: avoid spam logs if sampling hollow VMs .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/41406 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If130a4b31016e971ac9972b67ba5d3fd70de5b7d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: periodic: virt: do not poll storage in migrations
automat...@ovirt.org has posted comments on this change. Change subject: periodic: virt: do not poll storage in migrations .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43ec1e64700020b7d143e22c4c3d8bdceb57fb18 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: sampling: omit stacktrace if no cpu stats
automat...@ovirt.org has posted comments on this change. Change subject: virt: sampling: omit stacktrace if no cpu stats .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894a0ace8e3dce3cf3399ed71942e41f719133fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
