Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
automat...@ovirt.org has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: resizePV parameters
Federico Simoncelli has posted comments on this change. Change subject: resize-lun: resizePV parameters .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42608/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 876: Raises se.CouldNotResizePhysicalVolume if pvresize fails Line 877: Line 878: pvName = _fqpvname(guid) Line 879: cmd = [pvresize, pvName] Line 880: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, ))) Would this silently pvresize all the devices in the VG instead of just the guid one? If so (not sure we want it) why event pass guid at all? (Also below you just invalidate pvName instead of all the resized devices) Line 881: if rc != 0: Line 882: raise se.CouldNotResizePhysicalVolume(pvName, err) Line 883: _lvminfo._invalidatepvs(pvName) Line 884: _lvminfo._invalidatevgs(vgName) -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: contrib: add veth cleanup to emergency_net_cleanup
automat...@ovirt.org has posted comments on this change. Change subject: net: contrib: add veth cleanup to emergency_net_cleanup .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/43213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8947588e178ffbe6392d06be536149260d08f5b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
automat...@ovirt.org has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Improve error handling when Vm._dom is None
Nir Soffer has uploaded a new change for review.
Change subject: vm: Improve error handling when Vm._dom is None
..
vm: Improve error handling when Vm._dom is None
Vm._dom is initialized to None on when creating a vm, and set to None if
the underlying libvirt domain has died. Since Vm._dom is modified by
multiple threads, it is impossible to check for None before using it.
Even if it was possible, we don't want to litter the code with None
checks everywhere.
Some code was using this pattern:
try:
self._dom.doSomething()
except AttributeError:
# Oh, it was None
This code is not communicating well our intent. Worse, it hides
AttributeError in doSomthing()!
Most code never check self._dom before using it. In the rare cases it is
None, we fail with this Traceback:
Thread-460::ERROR::2015-07-04
19:53:21,977::__init__::520::jsonrpc.JsonRpcServer::(_serveRequest)
Internal server error
Traceback (most recent call last):
File /usr/lib/python2.7/site-packages/yajsonrpc/__init__.py, line 515,
in _serveRequest
res = method(**params)
File /usr/share/vdsm/rpc/Bridge.py, line 277, in _dynamicMethod
result = fn(*methodArgs)
File /usr/share/vdsm/API.py, line 727, in freeze
return v.freeze()
File /usr/share/vdsm/virt/vm.py, line 2882, in freeze
frozen = self._dom.fsFreeze()
AttributeError: 'NoneType' object has no attribute 'fsFreeze'
This traceback is a poor way to say the vm is not running.
This patch introduces the DisconnectedVirDomain class. This object will
raise NotConnectedError for any attribute access. Vm._dom is initialzied
to DisconnectedVirDomain(vmid) on startup and after underlying libvirt
domain has died.
Code trying to talk with a dead vm will fail now with:
NotConnectedError: Vm '681f6b09-a9c3-4422-a7e2-2f607368718b' is not
running yet or was shut down.
Code handling disconnected state is using now:
try:
self._dom.doSomething()
except NotConnctedError:
...
This communicates our intent, and does not hide any error from the
underlying code.
Code checking for None is using now:
if self._dom.connected:
...
Change-Id: I5349ec51c7accf3b417b3bc9489c7eed5bfd8733
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M tests/vmTests.py
M tests/vmfakelib.py
M vdsm/virt/sampling.py
M vdsm/virt/vm.py
4 files changed, 47 insertions(+), 20 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/43225/1
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 038ffcc..5b63e89 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -1056,7 +1056,6 @@
def testDomainNotRunningWithoutDomain(self):
with fake.VM() as testvm:
-self.assertEqual(testvm._dom, None)
self.assertFalse(testvm._isDomainRunning())
def testDomainNotRunningByState(self):
@@ -1087,7 +1086,6 @@
def testDomainNoneNotReadyForCommands(self):
with fake.VM() as testvm:
-testvm._dom = None
self.assertFalse(testvm.isDomainReadyForCommands())
def testReadyForCommandsRaisesLibvirtError(self):
@@ -1492,7 +1490,6 @@
def testVmWithoutDom(self):
with fake.VM() as testvm:
-self.assertTrue(testvm._dom is None)
self.assertAPIFailed(testvm.setBalloonTarget(128))
def testTargetValueNotInteger(self):
diff --git a/tests/vmfakelib.py b/tests/vmfakelib.py
index 211d647..d75198e 100644
--- a/tests/vmfakelib.py
+++ b/tests/vmfakelib.py
@@ -179,6 +179,10 @@
self._diskErrors = {}
self._downtimes = []
+@property
+def connected(self):
+return True
+
def _failIfRequested(self):
if self._virtError != libvirt.VIR_ERR_OK:
raise Error(self._virtError, self._errorMessage)
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index af0910a..a14a1ef 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -546,6 +546,9 @@
elif not vm_obj.isDomainReadyForCommands():
self._skip_doms[vm_id] = True
else:
+# TODO: This racy check may fail if the underlying libvirt
+# domain has died just after checking isDomainReadyForCommands
+# succeeded.
doms.append(vm_obj._dom._dom)
return doms
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 826e4e9..fa7c517 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -138,6 +138,13 @@
pass
+class NotConnectedError(Exception):
+
+Raised when trying to talk with a vm that was not started yet or was shut
+down.
+
+
+
VALID_STATES = (vmstatus.DOWN, vmstatus.MIGRATION_DESTINATION,
vmstatus.MIGRATION_SOURCE, vmstatus.PAUSED,
vmstatus.POWERING_DOWN, vmstatus.REBOOT_IN_PROGRESS,
@@ -188,6 +195,20 @@
pass
+class
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Dima Kuznetsov has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 echodo $REBOOTCMD) Line 74: disown Line 75: (sleep 7 Line 76: log Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE Line 77: echodo $SYSTEMCTL restart vdsmd.service This is not equivalent to the original code. sysemctl restart can take 20 s I wrote it as you suggested first (rev1) but I think it is kind of a wrong approach. If we're to get rid of this code soon I won't oppose, but this code attempts to restart a service managed by systemd, and it should use facilities provided by systemd. Line 78: ) Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Stop sysv libvirtd instance if running
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Stop sysv libvirtd instance if running
..
Stop sysv libvirtd instance if running
Using service.service_stop will try first to stop with initctl. This patch
explicitly stop the sysv instance.
LABEL: OVIRT-3.5 ONLY
Change-Id: I4012cdde1ca5bbf5aca397a5a3d27deeefd83951
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1239285
Signed-off-by: Yaniv Bronhaim ybron...@redhat.com
---
M lib/vdsm/tool/configurators/libvirt.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/43227/1
diff --git a/lib/vdsm/tool/configurators/libvirt.py
b/lib/vdsm/tool/configurators/libvirt.py
index b8ab5c9..f3500b4 100644
--- a/lib/vdsm/tool/configurators/libvirt.py
+++ b/lib/vdsm/tool/configurators/libvirt.py
@@ -170,7 +170,7 @@
if hasattr(service, '_chkconfigDisable'):
service._chkconfigDisable('libvirtd')
if not os.path.isfile(TARGET):
-service.service_stop('libvirtd')
+service._serviceStop('libvirtd')
if (not os.path.isfile(TARGET) or
not filecmp.cmp(packaged, TARGET)):
oldmod = None
--
To view, visit https://gerrit.ovirt.org/43227
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4012cdde1ca5bbf5aca397a5a3d27deeefd83951
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 echodo $REBOOTCMD) Line 74: disown Line 75: (sleep 7 Line 76: log Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE Line 77: echodo $SYSTEMCTL restart vdsmd.service I wrote it as you suggested first (rev1) but I think it is kind of a wrong We are not getting rid of this code soon, we must support this for few years. The original code did not try to restart the service, and we are fixing a regression caused by incorrect porting to systemd. So the first thing we must do (quickly) is to restore the original behavior. If you think we should start vdsm after killing it, please suggest that in another patch. However, you cannot use systemctl restart instead of systemctl kill at this point in the script. Line 78: ) Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Fix resizing when vg has multiple pvs
Nir Soffer has posted comments on this change. Change subject: resize-lun: Fix resizing when vg has multiple pvs .. Patch Set 3: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/42608/3//COMMIT_MSG Commit Message: Line 6: Line 7: resize-lun: Fix resizing when vg has multiple pvs Line 8: Line 9: When resizing a PV, LVM needs the other PVs that are part of the VG Line 10: in the filters parameters. Otherwise the operation will fail. Can you explain why these pvs are needed? Line 11: Line 12: Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Line 13: Bug-Url:https://bugzilla.redhat.com/609689 -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Nir Soffer has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages We want to be sure that join won't stuck the build next time. We reset the If you check the server loop in clientIF, you will see that after you add something to the queue, the server wakes up to handle the request. After waking up, we check the enabled flag, and exit if the server was stopped. So this patch does not change this behavior, it just a cleaner way to do this, and it enables limiting the number of pending requests. Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages If you check the server loop in clientIF, you will see that after you add s We check the flag but according to the core dump we get stuck here and we wait to join forever. My aim is to solve this issue. Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Fix resizing when vg has multiple pvs
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Fix resizing when vg has multiple pvs .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Improve error handling when Vm._dom is None
Nir Soffer has posted comments on this change. Change subject: vm: Improve error handling when Vm._dom is None .. Patch Set 1: Verified+1 Verified on rhel 7.1: - Start and stop vms - Restart vdsm while vm are running - Restart vdsm while restarting vms - Migrate vms few times -- To view, visit https://gerrit.ovirt.org/43225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5349ec51c7accf3b417b3bc9489c7eed5bfd8733 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Protect sensitive return value in supervdsm log
Piotr Kliczewski has posted comments on this change. Change subject: iscsicred: Protect sensitive return value in supervdsm log .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcfa4ee17466f75270909587c45ee9f703e5e9f3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Nir Soffer has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages The original code already handle this by putting (None, None) into the queue. This change does not prevent blocking forever as it was already handled in the original code. Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Stop sysv libvirtd instance if running
automat...@ovirt.org has posted comments on this change. Change subject: Stop sysv libvirtd instance if running .. Patch Set 1: * Update tracker::#1239285::OK * Check Bug-Url::OK * Check Public Bug::#1239285::OK, public bug * Check Product::#1239285::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1239285::OK, correct target release 3.5.4 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4012cdde1ca5bbf5aca397a5a3d27deeefd83951 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Fix resizing when vg has multiple pvs
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Fix resizing when vg has multiple pvs .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/42608/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-06-21 14:43:08 +0300 Line 4: Commit: Fred Rolland froll...@redhat.com Line 5: CommitDate: 2015-06-21 16:00:43 +0300 Line 6: Line 7: resize-lun: resizePV parameters Also fix the title, look to me like Fix resizing when vg has multiple pvs Done Line 8: Line 9: In lvm.resizePV, we need all devices names in the filters parameters. Line 10: Otherwise the operation will fail. It is needed in case we have more Line 11: than one LUN on the storage domain. Line 7: resize-lun: resizePV parameters Line 8: Line 9: In lvm.resizePV, we need all devices names in the filters parameters. Line 10: Otherwise the operation will fail. It is needed in case we have more Line 11: than one LUN on the storage domain. Please explain lvm needs the other pvs when resizing another pv. Done Line 12: Line 13: Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Line 14: Bug-Url:https://bugzilla.redhat.com/609689 -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages The original code already handle this by putting (None, None) into the queu We want to be sure that join won't stuck the build next time. We reset the queue before adding (None, None) and this is the change for this patch. Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Nir Soffer has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages We check the flag but according to the core dump we get stuck here and we w Waiting for join() does not prove anything. Do you see the server thread blocked on queue.get() in the same time? Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Improve error handling when Vm._dom is None
automat...@ovirt.org has posted comments on this change. Change subject: vm: Improve error handling when Vm._dom is None .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5349ec51c7accf3b417b3bc9489c7eed5bfd8733 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
automat...@ovirt.org has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Add simpler RWLock
Dima Kuznetsov has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 6: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/42908/6/lib/vdsm/rwlock.py File lib/vdsm/rwlock.py: Line 43: if self._writer or self._waiters: Line 44: self._wait(False) Line 45: self._readers.add(threading.current_thread()) Line 46: if self._waiters: Line 47: self._wakeup_next_waiter() +1 Line 48: Line 49: def release(self): Line 50: me = threading.current_thread() Line 51: with self._lock: -- To view, visit https://gerrit.ovirt.org/42908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Fix resizing when vg has multiple pvs
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Fix resizing when vg has multiple pvs .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Dima Kuznetsov has posted comments on this change.
Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in
File vdsm/storage/protect/spmprotect.sh.in:
Line 73: (sleep 20 echodo $REBOOTCMD)
Line 74: disown
Line 75: (sleep 7
Line 76: log Trying to stop vdsm for sdUUID=$sdUUID id=$ID
lease_path=$LEASE_FILE
Line 77: echodo $SYSTEMCTL restart vdsmd.service
We are not getting rid of this code soon, we must support this for few year
Well, it looks like sysvinit (used to) run {super,}vdsmd with respawn, so
basically this gets rid of the running vdsm instance and brings up a fresh one.
I'll send a version with your suggestions but I propose we think of a prettier
way to interact with systemd services.
Line 78: )
Line 79: disown
Line 80:
Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service
--
To view, visit https://gerrit.ovirt.org/43211
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Nir Soffer has posted comments on this change.
Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using
systemctl
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in
File vdsm/storage/protect/spmprotect.sh.in:
Line 73: (sleep 20 echodo $REBOOTCMD)
Line 74: disown
Line 75: (sleep 7
Line 76: log Trying to stop vdsm for sdUUID=$sdUUID id=$ID
lease_path=$LEASE_FILE
Line 77: echodo $SYSTEMCTL restart vdsmd.service
Well, it looks like sysvinit (used to) run {super,}vdsmd with respawn, so b
What is wrong with systemctl kill that you suggested bellow?
Line 78: )
Line 79: disown
Line 80:
Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service
--
To view, visit https://gerrit.ovirt.org/43211
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: resizePV parameters
Nir Soffer has posted comments on this change. Change subject: resize-lun: resizePV parameters .. Patch Set 2: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/42608/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 876: Raises se.CouldNotResizePhysicalVolume if pvresize fails Line 877: Line 878: pvName = _fqpvname(guid) Line 879: cmd = [pvresize, pvName] Line 880: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, ))) Would this silently pvresize all the devices in the VG instead of just the Good point - Fred, please check what happens when multiple pvs can be resized. Please do not invalidate all pvs unless this actually resize all of them. Line 881: if rc != 0: Line 882: raise se.CouldNotResizePhysicalVolume(pvName, err) Line 883: _lvminfo._invalidatepvs(pvName) Line 884: _lvminfo._invalidatevgs(vgName) -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: contrib: add veth cleanup to emergency_net_cleanup
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: contrib: add veth cleanup to emergency_net_cleanup .. net: contrib: add veth cleanup to emergency_net_cleanup Change-Id: I8947588e178ffbe6392d06be536149260d08f5b7 Signed-off-by: Ido Barkan ibar...@redhat.com Reviewed-on: https://gerrit.ovirt.org/43213 Reviewed-by: Dan Kenigsberg dan...@redhat.com Continuous-Integration: Jenkins CI --- M contrib/shell_helper 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Ido Barkan: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8947588e178ffbe6392d06be536149260d08f5b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Nir Soffer has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/42915/5//COMMIT_MSG Commit Message: Line 13: protocol and pass socket for processing. Line 14: Line 15: This patch changes how request queue is managed. We want to be sure that Line 16: when we stop only sentinel is queued so the xmlrpc server thread is Line 17: properly closed. The code is nice, but it does not fix blocking issue. The only change is dropping pending requests when stopping the server, and allowing a limit on the number of pending requests, which is not used yet. Please update the commit message. Line 18: Line 19: Line 20: Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: resizePV parameters
Freddy Rolland has posted comments on this change. Change subject: resize-lun: resizePV parameters .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/42608/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 876: Raises se.CouldNotResizePhysicalVolume if pvresize fails Line 877: Line 878: pvName = _fqpvname(guid) Line 879: cmd = [pvresize, pvName] Line 880: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, ))) Good point - Fred, please check what happens when multiple pvs can be resiz I tested and it will resize only the guid one. Line 881: if rc != 0: Line 882: raise se.CouldNotResizePhysicalVolume(pvName, err) Line 883: _lvminfo._invalidatepvs(pvName) Line 884: _lvminfo._invalidatevgs(vgName) Line 876: Raises se.CouldNotResizePhysicalVolume if pvresize fails Line 877: Line 878: pvName = _fqpvname(guid) Line 879: cmd = [pvresize, pvName] Line 880: rc, out, err = _lvminfo.cmd(cmd, _lvminfo._getVGDevs((vgName, ))) Would this silently pvresize all the devices in the VG instead of just the I tested and it will resize only the guid one. The additional devices are needed in the filter Line 881: if rc != 0: Line 882: raise se.CouldNotResizePhysicalVolume(pvName, err) Line 883: _lvminfo._invalidatepvs(pvName) Line 884: _lvminfo._invalidatevgs(vgName) -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: resizePV parameters
Nir Soffer has posted comments on this change. Change subject: resize-lun: resizePV parameters .. Patch Set 2: Code-Review-1 (1 comment) Code is ok, commit message needs better explanation. https://gerrit.ovirt.org/#/c/42608/2//COMMIT_MSG Commit Message: Line 7: resize-lun: resizePV parameters Line 8: Line 9: In lvm.resizePV, we need all devices names in the filters parameters. Line 10: Otherwise the operation will fail. It is needed in case we have more Line 11: than one LUN on the storage domain. Please explain lvm needs the other pvs when resizing another pv. Line 12: Line 13: Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Line 14: Bug-Url:https://bugzilla.redhat.com/609689 -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Protect sensitive return value in supervdsm log
Tal Nisan has posted comments on this change. Change subject: iscsicred: Protect sensitive return value in supervdsm log .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcfa4ee17466f75270909587c45ee9f703e5e9f3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 4: Yes, I do. Sent it to you via email. -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: wait for restored devices to be up
automat...@ovirt.org has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 1: Verified-1 * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::#1203422::OK, correct target release 3.5.4 * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/43222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
Ido Barkan has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/43209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: wait for restored devices to be up
Ido Barkan has uploaded a new change for review. Change subject: net: wait for restored devices to be up .. net: wait for restored devices to be up If restore-net-config does not wait for all devices to be up, it might observe a transient kernel state where, for example, bonding devices might report no slaves. This makes restoration re-restore a bond because it is reported by the kernel as different from the persisted device. Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Signed-off-by: Ido Barkan ibar...@redhat.com Bug-Url: https://bugzilla.redhat.com/1203422 --- M vdsm/vdsm-restore-net-config 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/43222/1 diff --git a/vdsm/vdsm-restore-net-config b/vdsm/vdsm-restore-net-config index 17957c0..7968da3 100755 --- a/vdsm/vdsm-restore-net-config +++ b/vdsm/vdsm-restore-net-config @@ -22,8 +22,10 @@ import logging import logging.config import os +import time from vdsm.config import config +from vdsm import ipwrapper from vdsm import netinfo from vdsm.constants import P_VDSM_RUN from vdsm.netconfpersistence import KernelConfig, BaseConfig @@ -38,6 +40,7 @@ import pkgutil _NETS_RESTORED_MARK = os.path.join(P_VDSM_RUN, 'nets_restored') +_ALL_DEVICES_UP_TIMEOUT = 30 def ifcfg_restoration(): @@ -68,6 +71,8 @@ persistent_config = PersistentConfig() available_config = _filter_available(persistent_config) +_wait_for_for_all_devices_up( +available_config.networks.keys() + available_config.bonds.keys()) changed_config = _filter_changed_nets_bonds(available_config) nets = changed_config.networks bonds = changed_config.bonds @@ -168,6 +173,36 @@ return changed_or_missing +def _wait_for_for_all_devices_up(links): +sleep_time = 1 +time_left = _ALL_DEVICES_UP_TIMEOUT + +down_links = _get_links_with_state_down(links) + +# TODO: use netlink monitor here might be more elegant (not available in +# TODO: 3.5) +while down_links and time_left 0: +logging.debug(waiting for %s to be up., down_links) +time.sleep(sleep_time) +time_left -= sleep_time +down_links = _get_links_with_state_down(links) + +if down_links: +logging.warning(Not all devices are up. VDSM might restore them +although they were not changed since they were +persisted.) +else: +logging.debug(All devices are up.) + + +def _get_links_with_state_down(links): +def oper_up(link): +return bool(link.flags 1 6) + +return set([l.name for l in ipwrapper.getLinks() if +l.name in links and not oper_up(l)]) + + def _get_all_configurators(): Returns the class objects of all the configurators in the netconf pkg prefix = configurators.__name__ + '.' -- To view, visit https://gerrit.ovirt.org/43222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/42915/5//COMMIT_MSG Commit Message: Line 13: protocol and pass socket for processing. Line 14: Line 15: This patch changes how request queue is managed. We want to be sure that Line 16: when we stop only sentinel is queued so the xmlrpc server thread is Line 17: properly closed. The code is nice, but it does not fix blocking issue. The only change is dr Done Line 18: Line 19: Line 20: Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: resizePV parameters
Federico Simoncelli has posted comments on this change. Change subject: resize-lun: resizePV parameters .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Nir Soffer has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Nir Soffer has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/42915/6//COMMIT_MSG Commit Message: Line 12: We can't use xmlrpc built-in timeout handling because we detect a Line 13: protocol and pass socket for processing. Line 14: Line 15: This patch changes how we manage queued requests when stopping the server. When Line 16: we stop we drop all other requests and sentinel to stop the server. This sentense is ok, but the rest is incorrect as I explained in the previous version. Line 17: Line 18: Line 19: Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: resizePV parameters
Nir Soffer has posted comments on this change. Change subject: resize-lun: resizePV parameters .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42608/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-06-21 14:43:08 +0300 Line 4: Commit: Fred Rolland froll...@redhat.com Line 5: CommitDate: 2015-06-21 16:00:43 +0300 Line 6: Line 7: resize-lun: resizePV parameters Also fix the title, look to me like Fix resizing when vg has multiple pvs Line 8: Line 9: In lvm.resizePV, we need all devices names in the filters parameters. Line 10: Otherwise the operation will fail. It is needed in case we have more Line 11: than one LUN on the storage domain. -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
Ido Barkan has posted comments on this change.
Change subject: net: wait for restored devices to be up
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/43209/2/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 42: from network import configurators
Line 43:
Line 44: import pkgutil
Line 45:
Line 46: _ALL_DEVICES_UP_TIMEOUT = 30
why 30 seconds? does it take so long for bonds to become UP?
I just a place holder. I'll research it.
Line 47:
Line 48: _NETS_RESTORED_MARK = os.path.join(P_VDSM_RUN, 'nets_restored')
Line 49: _VIRTUAL_FUNCTIONS_PATH = os.path.join(CONF_PERSIST_DIR,
'virtual_functions')
Line 50:
Line 254:
Line 255:
Line 256: def _wait_for_for_all_devices_up(links):
Line 257: down_links = set([l for l in ipwrapper.getLinks() if
Line 258: l.name in links and not l.oper_up])
should we blindly wait for all links? I worry about some unrelated dummy de
we only wait for specific links (the ones that exist). I will also add
filtering for vdsm-owned ones and for ONBOOT=yes
Line 259:
Line 260: if not down_links:
Line 261: logging.debug(all devices are up.)
Line 262: return
Line 263:
Line 264: logging.debug(waiting for %s to be up., down_links)
Line 265: monitor = Monitor(('link',), timeout=_ALL_DEVICES_UP_TIMEOUT,
Line 266: silent_timeout=True)
Line 267: monitor.start()
you must start the monitor before collecting down_links. Otherwise, a race
I gave up Monitor. it is very hard to backport it to 3.5. simple polling will
also work fine.
Line 268: for event in monitor:
Line 269: if event['state'] == netinfo.OPERSTATE_UP:
Line 270: down_links.discard(event['name'])
Line 271: if not down_links:
Line 268: for event in monitor:
Line 269: if event['state'] == netinfo.OPERSTATE_UP:
Line 270: down_links.discard(event['name'])
Line 271: if not down_links:
Line 272: break
please log if we exit with a timeout.
Done
Line 273:
Line 274:
Line 275: def _get_all_configurators():
Line 276: Returns the class objects of all the configurators in the
netconf pkg
--
To view, visit https://gerrit.ovirt.org/43209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
automat...@ovirt.org has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 4: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
Ido Barkan has uploaded a new change for review.
Change subject: net: ignore bondingOptions in persistent networks.
..
net: ignore bondingOptions in persistent networks.
Up until https://gerrit.ovirt.org/#/c/42146/ bondingOptions were
mistakenly part of persistent network attributes. So, if we are
upgrading from an older enough version, we should drop this entry
it the copied persistent networks.
Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M lib/vdsm/netconfpersistence.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/43233/1
diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index 9b041ae..fa59edb 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -366,6 +366,11 @@
bond_attr.get('options'))
bond_attr['options'] = self._netinfo.bondOptsForIfcfg(
normalized_opts)
+# before d18e2f10 bondingOptions were also part of networks, so in case
+# we are upgrading from an older version, they should be ignored if
+# they exist.
+for net_attr in config_copy.networks.itervalues():
+net_attr.pop('bondingOptions')
def _normalize_bonding_nics(self, config_copy):
for bond_attr in config_copy.bonds.itervalues():
--
To view, visit https://gerrit.ovirt.org/43233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages Do you know which test was stuck when this happened? There is no single test which get stuck. It happens randomly. Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
Dan Kenigsberg has posted comments on this change.
Change subject: net: wait for restored devices to be up
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/43209/4/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 45: from network import configurators
Line 46:
Line 47: import pkgutil
Line 48:
Line 49: _ALL_DEVICES_UP_TIMEOUT = 30
still needs research
I suspect that 3-5 seconds would be enough bonds to settle. But certainly an
little research is needed.
Line 50:
Line 51: _NETS_RESTORED_MARK = os.path.join(P_VDSM_RUN, 'nets_restored')
Line 52: _VIRTUAL_FUNCTIONS_PATH = os.path.join(CONF_PERSIST_DIR,
'virtual_functions')
Line 53:
Line 291: return _ifcfg_predicate(link_name, predicate)
Line 292:
Line 293:
Line 294: def _onboot(link_name):
Line 295: predicate = lambda content: bool(re.search('ONBOOT=(yes|YES)',
content))
I think that this re is an overkill (and underkill). We care only about
Vdsm-written files, which always have lowercase.
And why an underkill? because initscript considers anything other than no/NO as
yes.
Let's check for '^ONBOOT=yes$'.
Line 296: return _ifcfg_predicate(link_name, predicate)
Line 297:
Line 298:
Line 299: def _ifcfg_predicate(link_name, predicate):
--
To view, visit https://gerrit.ovirt.org/43209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: resize-lun: Fix resizing when vg has multiple pvs
Nir Soffer has posted comments on this change. Change subject: resize-lun: Fix resizing when vg has multiple pvs .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/42608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Ala Hino ah...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Fred Rolland froll...@redhat.com Gerrit-Reviewer: Freddy Rolland froll...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] spmprotect: Switch from fencing by pid to fencing usin...
Dima Kuznetsov has posted comments on this change. Change subject: [WIP] spmprotect: Switch from fencing by pid to fencing using systemctl .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43211/4/vdsm/storage/protect/spmprotect.sh.in File vdsm/storage/protect/spmprotect.sh.in: Line 73: (sleep 20 echodo $REBOOTCMD) Line 74: disown Line 75: (sleep 7 Line 76: log Trying to stop vdsm for sdUUID=$sdUUID id=$ID lease_path=$LEASE_FILE Line 77: echodo $SYSTEMCTL restart vdsmd.service What is wrong with systemctl kill that you suggested bellow? I think that if the semantic is just to restart vdsm, there is a more intuitive way to do it, thats all. Line 78: ) Line 79: disown Line 80: Line 81: echodo $SYSTEMCTL kill --signal=30 vdsmd.service -- To view, visit https://gerrit.ovirt.org/43211 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifdea618514232a1f751afae54337de787f297b9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: use deque for incoming requests
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: use deque for incoming requests .. Patch Set 8: Verified+1 Verified with latest engine. Protocol was set to xmlrpc and there were no issues with communication after host deployment. -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Nir Soffer has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages Waiting for join() does not prove anything. Do you see the server thread bl Looking in the core dump, we do see two threads - thread 1 is blocked on join(), and the other on queue.get(). But looking in the core - self._enabled seems to be True. We expect it to be False in stop(). #21 Frame 0x7f35af174608, for file /tmp/run/vdsm/vdsm/rpc/bindingxmlrpc.py, line 84, in stop (self=BindingXMLRPC(_enabled=True, Maybe server_close failed to add the sentinel into the queue? the core does not have enough into to tell that. I think we should learn how to reproduce this, and only then try to fix this. Maybe add more logging and let the ci fail again. Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages Looking in the core dump, we do see two threads - thread 1 is blocked on jo Adding more logging won't help because we do not see it when the tests are run. The issue haven't happened for a while. Let's wait for it to happen again and we can collect more dumps. Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Stop sysv libvirtd instance if running
automat...@ovirt.org has posted comments on this change. Change subject: Stop sysv libvirtd instance if running .. Patch Set 2: * Update tracker::#1239285::OK * Check Bug-Url::OK * Check Public Bug::#1239285::OK, public bug * Check Product::#1239285::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1239285::OK, correct target release 3.5.4 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4012cdde1ca5bbf5aca397a5a3d27deeefd83951 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Stop sysv libvirtd instance if running
Dan Kenigsberg has posted comments on this change. Change subject: Stop sysv libvirtd instance if running .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4012cdde1ca5bbf5aca397a5a3d27deeefd83951 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Protect sensitive return value in supervdsm log
Yaniv Bronhaim has posted comments on this change. Change subject: iscsicred: Protect sensitive return value in supervdsm log .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcfa4ee17466f75270909587c45ee9f703e5e9f3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
Ido Barkan has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43209/4/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 45: from network import configurators Line 46: Line 47: import pkgutil Line 48: Line 49: _ALL_DEVICES_UP_TIMEOUT = 30 still needs research Line 50: Line 51: _NETS_RESTORED_MARK = os.path.join(P_VDSM_RUN, 'nets_restored') Line 52: _VIRTUAL_FUNCTIONS_PATH = os.path.join(CONF_PERSIST_DIR, 'virtual_functions') Line 53: -- To view, visit https://gerrit.ovirt.org/43209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Stop sysv libvirtd instance if running
Dan Kenigsberg has posted comments on this change. Change subject: Stop sysv libvirtd instance if running .. Patch Set 2: Continuous-Integration+1 unrelated failure: FAIL: testMethodMissingMethod(kw=False) (jsonRpcTests.JsonRpcServerTests) -- To view, visit https://gerrit.ovirt.org/43227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4012cdde1ca5bbf5aca397a5a3d27deeefd83951 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages
Nir Soffer has posted comments on this change. Change subject: xmlrpc: do not block forever when waiting on incoming messages .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-07-03 12:59:15 +0200 Line 4: Commit: Piotr Kliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-07-06 06:31:21 -0400 Line 6: Line 7: xmlrpc: do not block forever when waiting on incoming messages Adding more logging won't help because we do not see it when the tests are Do you know which test was stuck when this happened? Line 8: Line 9: Vdsm build using jenkins got stuck several times and after coredump Line 10: analysis it was clear that we hang on self._thread.join(). Line 11: -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: use deque for incoming requests
automat...@ovirt.org has posted comments on this change. Change subject: xmlrpc: use deque for incoming requests .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: restore default timeout value
Piotr Kliczewski has posted comments on this change. Change subject: tests: restore default timeout value .. Patch Set 1: I will mark the slowest test but from time to time all of them timeout. It depends on particular slave load. -- To view, visit https://gerrit.ovirt.org/42918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
Ido Barkan has posted comments on this change.
Change subject: net: wait for restored devices to be up
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43209/4/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 291: return _ifcfg_predicate(link_name, predicate)
Line 292:
Line 293:
Line 294: def _onboot(link_name):
Line 295: predicate = lambda content: bool(re.search('ONBOOT=(yes|YES)',
content))
I think that this re is an overkill (and underkill). We care only about V
Done
Line 296: return _ifcfg_predicate(link_name, predicate)
Line 297:
Line 298:
Line 299: def _ifcfg_predicate(link_name, predicate):
--
To view, visit https://gerrit.ovirt.org/43209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: functional - convert to run over jsonrpc
Yeela Kaplan has uploaded a new change for review.
Change subject: tests: functional - convert to run over jsonrpc
..
tests: functional - convert to run over jsonrpc
will run functional tests by default over jsonrpc
if its enabled,
otherwise will run over xmlrpc.
Change-Id: I468e7eae74dd37b915b15e18ac4b0a830675cb47
Signed-off-by: Yeela Kaplan ykap...@redhat.com
---
M lib/vdsm/jsonrpcvdscli.py
M tests/functional/utils.py
2 files changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/43237/1
diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 64c9879..affe281 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -37,6 +37,16 @@
'destroy': 'VM.destroy',
'getVmStats': 'VM.getStats',
'migrationCreate': 'VM.migrationCreate',
+'updateVmPolicy': 'VM.updateVmPolicy',
+'getVdsCapabilities': 'Host.getCapabilities',
+'list': 'Host.getVMList',
+'getAllVmStats': 'Host.getAllVmStats',
+'getVdsStats': 'Host.getStats',
+'setupNetworks': 'Host.setupNetworks',
+'editNetwork': 'Host.editNetwork',
+'delNetwork': 'Host.delNetwork',
+'addNetwork': 'Host.addNetwork',
+'setSafeNetworkConfig': 'Host.setSafeNetworkConfig',
}
diff --git a/tests/functional/utils.py b/tests/functional/utils.py
index 263fd31..05d5f5c 100644
--- a/tests/functional/utils.py
+++ b/tests/functional/utils.py
@@ -26,6 +26,7 @@
from vdsm.config import config
from vdsm.utils import retry
from vdsm import ipwrapper
+from vdsm import jsonrpcvdscli
from vdsm import netinfo
from vdsm import vdscli
from vdsm.netconfpersistence import RunningConfig
@@ -71,7 +72,12 @@
retry(self.start, (socket.error, KeyError), tries=30)
def start(self):
-self.vdscli = vdscli.connect()
+if config.getboolean('vars', 'jsonrpc_enable'):
+requestQueues = config.get('addresses', 'request_queues')
+requestQueue = requestQueues.split(,)[0]
+self.vdscli = jsonrpcvdscli.create(requestQueue)
+else:
+self.vdscli = vdscli.connect()
self.netinfo = self._get_netinfo()
if config.get('vars', 'net_persistence') == 'unified':
self.config = RunningConfig()
--
To view, visit https://gerrit.ovirt.org/43237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I468e7eae74dd37b915b15e18ac4b0a830675cb47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: response: insert results into 'info'
Yeela Kaplan has uploaded a new change for review.
Change subject: response: insert results into 'info'
..
response: insert results into 'info'
Change-Id: Ib5284969585e55a230be31bde56956fc966e46c2
Signed-off-by: Yeela Kaplan ykap...@redhat.com
---
M lib/vdsm/response.py
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/43236/1
diff --git a/lib/vdsm/response.py b/lib/vdsm/response.py
index 7a04e93..db91bdc 100644
--- a/lib/vdsm/response.py
+++ b/lib/vdsm/response.py
@@ -25,11 +25,13 @@
def success(message=None, **kwargs):
-kwargs[status] = {
-code: doneCode[code],
-message: message or doneCode[message]
+return {
+'info': kwargs,
+'status': {
+code: doneCode[code],
+message: message or doneCode[message],
+},
}
-return kwargs
def error(name, message=None):
--
To view, visit https://gerrit.ovirt.org/43236
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5284969585e55a230be31bde56956fc966e46c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: response: insert results into 'info'
automat...@ovirt.org has posted comments on this change. Change subject: response: insert results into 'info' .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5284969585e55a230be31bde56956fc966e46c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Stop sysv libvirtd instance if running
Yaniv Bronhaim has posted comments on this change. Change subject: Stop sysv libvirtd instance if running .. Patch Set 2: Code-Review-2 waiting for node verification to see if its really required -- To view, visit https://gerrit.ovirt.org/43227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4012cdde1ca5bbf5aca397a5a3d27deeefd83951 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: jsonrpc: add a creation method for client
automat...@ovirt.org has posted comments on this change. Change subject: vdscli: jsonrpc: add a creation method for client .. Patch Set 3: * Update tracker::#1138381::OK * Check Bug-Url::OK * Check Public Bug::#1138381::OK, public bug * Check Product::#1138381::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia99533227b0c3241d7951a2f39af2ff3a6210b5b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: functional - convert to run over jsonrpc
automat...@ovirt.org has posted comments on this change. Change subject: tests: functional - convert to run over jsonrpc .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I468e7eae74dd37b915b15e18ac4b0a830675cb47 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: marking slow tests with decorator
Piotr Kliczewski has posted comments on this change. Change subject: tests: marking slow tests with decorator .. Patch Set 2: Verified+1 Verified by running local test. -- To view, visit https://gerrit.ovirt.org/42918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: marking slow tests with decorator
automat...@ovirt.org has posted comments on this change. Change subject: tests: marking slow tests with decorator .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
automat...@ovirt.org has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 5: * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček phora...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/43238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
automat...@ovirt.org has posted comments on this change. Change subject: net: ignore bondingOptions in persistent networks. .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: ignore bondingOptions in persistent networks.
Ido Barkan has uploaded a new change for review.
Change subject: net: ignore bondingOptions in persistent networks.
..
net: ignore bondingOptions in persistent networks.
Up until https://gerrit.ovirt.org/#/c/42146/ bondingOptions were
mistakenly part of persistent network attributes. So, if we are
upgrading from an older enough version, we should drop this entry
it the copied persistent networks.
Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139
Signed-off-by: Ido Barkan ibar...@redhat.com
---
M lib/vdsm/netconfpersistence.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/43238/1
diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index b8de93d..b5efff8 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -363,6 +363,11 @@
bond_attr.get('options'))
bond_attr['options'] = self._netinfo.bondOptsForIfcfg(
normalized_opts)
+# before d18e2f10 bondingOptions were also part of networks, so in case
+# we are upgrading from an older version, they should be ignored if
+# they exist.
+for net_attr in config_copy.networks.itervalues():
+net_attr.pop('bondingOptions', None)
def _normalize_bonding_nics(self, config_copy):
for bond_attr in config_copy.bonds.itervalues():
--
To view, visit https://gerrit.ovirt.org/43238
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan ibar...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: wait for restored devices to be up
automat...@ovirt.org has posted comments on this change. Change subject: net: wait for restored devices to be up .. Patch Set 2: Verified-1 * Update tracker::#1203422::OK * Check Bug-Url::OK * Check Public Bug::#1203422::OK, public bug * Check Product::#1203422::OK, Correct product oVirt * Check TR::#1203422::OK, correct target release 3.5.4 * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/43222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: functional - convert to run over jsonrpc
automat...@ovirt.org has posted comments on this change. Change subject: tests: functional - convert to run over jsonrpc .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I468e7eae74dd37b915b15e18ac4b0a830675cb47 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscli: jsonrpc: add a creation method for client
automat...@ovirt.org has posted comments on this change. Change subject: vdscli: jsonrpc: add a creation method for client .. Patch Set 4: * Update tracker::#1138381::OK * Check Bug-Url::OK * Check Public Bug::#1138381::OK, public bug * Check Product::#1138381::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia99533227b0c3241d7951a2f39af2ff3a6210b5b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: functional - convert to run over jsonrpc
automat...@ovirt.org has posted comments on this change. Change subject: tests: functional - convert to run over jsonrpc .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I468e7eae74dd37b915b15e18ac4b0a830675cb47 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: use deque for incoming requests
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: use deque for incoming requests .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/42915/8//COMMIT_MSG Commit Message: Line 6: Line 7: xmlrpc: use deque for incoming requests Line 8: Line 9: This patch changes how we manage queued requests when stopping the server. When Line 10: we stop we drop all other requests and add sentinel to stop the server. could you provide here the motivation for this change? Do we suspect that we had blocked forever due to a full queue? Line 11: Line 12: Line 13: Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a -- To view, visit https://gerrit.ovirt.org/42915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: wait for restored devices to be up
Dan Kenigsberg has posted comments on this change.
Change subject: net: wait for restored devices to be up
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/43209/5/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 292:
Line 293:
Line 294: def _onboot(link_name):
Line 295: predicate = lambda content: any(
Line 296: re.match('^ONBOOT=yes$', line) for line in
content.splitlines())
if you're spliting the content into lines, you certainly do not need re.
line == 'ONBOOT=yes'
is simpler.
Line 297: return _ifcfg_predicate(link_name, predicate)
Line 298:
Line 299:
Line 300: def _ifcfg_predicate(link_name, predicate):
--
To view, visit https://gerrit.ovirt.org/43209
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cd3de577e5d0bcf5e87c4894e94e03c209ce76a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček phora...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: marking slow tests with decorator
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: marking slow tests with decorator .. tests: marking slow tests with decorator Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Reviewed-on: https://gerrit.ovirt.org/42918 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/jsonRpcTests.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: remove the sub-project
automat...@ovirt.org has posted comments on this change. Change subject: vdsm-reg: remove the sub-project .. Patch Set 1: * Update tracker::#1231379::OK * Check Bug-Url::OK * Check Public Bug::#1231379::OK, public bug * Check Product::#1231379::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d19ddb0e65657515e2dc0eb9eeae320d8d6bf71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: remove the sub-project
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-reg: remove the sub-project .. Patch Set 1: Verified+1 I could generate vdsm without vdsm-reg package. RIP vdsm-reg. -- To view, visit https://gerrit.ovirt.org/43254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d19ddb0e65657515e2dc0eb9eeae320d8d6bf71 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: disable IPv6 via sysctl if no IPv6 functionality wa...
Ondřej Svoboda has uploaded a new change for review.
Change subject: network: disable IPv6 via sysctl if no IPv6 functionality was
requested
..
network: disable IPv6 via sysctl if no IPv6 functionality was requested
This applies to bridges. On CentOS/RHEL 7, disable_ipv6=0 is the default
so bridges allowed IPv6 traffic even though it was not enabled by setting
a static address or using DHCPv6.
Change-Id: I2314d4bc120c15af44ff9e20c9281ab69c84ad0a
Bug-Url: https://bugzilla.redhat.com/1219363
Signed-off-by: Ondřej Svoboda osvob...@redhat.com
---
M tests/functional/networkTests.py
M vdsm/network/configurators/ifcfg.py
M vdsm/network/configurators/iproute2.py
3 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/43252/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index f3dff3f..94ee4db 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1685,6 +1685,9 @@
if 6 in families:
self.assertIn(IPv6_ADDRESS_AND_CIDR, test_net['ipv6addrs'])
self.assertEqual(IPv6_GATEWAY, test_net['ipv6gateway'])
+else:
+# VDSM disables IPv6 via sysctl if IPv6 is not requested
+self.assertEqual([], test_net['ipv6addrs'])
delete = {NETWORK_NAME: {'remove': True}}
status, msg = self.vdsm_net.setupNetworks(delete, {}, {})
self.assertEqual(status, SUCCESS, msg)
diff --git a/vdsm/network/configurators/ifcfg.py
b/vdsm/network/configurators/ifcfg.py
index e008994..1b36199 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -35,6 +35,7 @@
from vdsm import constants
from vdsm import ipwrapper
from vdsm import netinfo
+from vdsm import sysctl
from vdsm import utils
from vdsm.netconfpersistence import RunningConfig
@@ -93,6 +94,10 @@
bridge.port.configure(**opts)
self._addSourceRoute(bridge)
_ifup(bridge)
+if not bridge.ipv6.address and not bridge.ipv6.ipv6autoconf and (
+not bridge.ipv6.dhcpv6):
+# disallow IPv6 traffic on the bridge if IPv6 is not requested
+sysctl.disable_ipv6(bridge.name)
def configureVlan(self, vlan, **opts):
self.configApplier.addVlan(vlan, **opts)
diff --git a/vdsm/network/configurators/iproute2.py
b/vdsm/network/configurators/iproute2.py
index 9a8b751..31b1cf4 100644
--- a/vdsm/network/configurators/iproute2.py
+++ b/vdsm/network/configurators/iproute2.py
@@ -25,6 +25,7 @@
from vdsm.constants import EXT_BRCTL
from vdsm.ipwrapper import routeAdd, routeDel, ruleAdd, ruleDel, IPRoute2Error
from vdsm.netconfpersistence import RunningConfig
+from vdsm import sysctl
from vdsm.utils import CommandPath
from vdsm.utils import execCmd
@@ -72,6 +73,10 @@
self.configApplier.addBridgePort(bridge)
DynamicSourceRoute.addInterfaceTracking(bridge)
self.configApplier.setIfaceConfigAndUp(bridge)
+if not bridge.ipv6.address and not bridge.ipv6.ipv6autoconf and (
+not bridge.ipv6.dhcpv6):
+# disallow IPv6 traffic on the bridge if IPv6 is not requested
+sysctl.disable_ipv6(bridge.name)
self._addSourceRoute(bridge)
if 'custom' in opts and 'bridge_opts' in opts['custom']:
self.configApplier._setBridgeOpts(bridge,
--
To view, visit https://gerrit.ovirt.org/43252
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2314d4bc120c15af44ff9e20c9281ab69c84ad0a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: disable IPv6 via sysctl if no IPv6 functionality wa...
automat...@ovirt.org has posted comments on this change. Change subject: network: disable IPv6 via sysctl if no IPv6 functionality was requested .. Patch Set 1: * Update tracker::#1219363::OK * Check Bug-Url::OK * Check Public Bug::#1219363::OK, public bug * Check Product::#1219363::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2314d4bc120c15af44ff9e20c9281ab69c84ad0a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda osvob...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
Dan Kenigsberg has posted comments on this change.
Change subject: net: ignore bondingOptions in persistent networks.
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43233/3/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:
Line 365: normalized_opts = self._parse_bond_options(
Line 366: bond_attr.get('options'))
Line 367: bond_attr['options'] = self._netinfo.bondOptsForIfcfg(
Line 368: normalized_opts)
Line 369: # before d18e2f10 bondingOptions were also part of networks,
so in case
Please use the
# REQUIRED_FOR upgrade from vdsm=4.16.20
so it is easier to drop in the future.
Line 370: # we are upgrading from an older version, they should be
ignored if
Line 371: # they exist.
Line 372: for net_attr in config_copy.networks.itervalues():
Line 373: net_attr.pop('bondingOptions', None)
--
To view, visit https://gerrit.ovirt.org/43233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan ibar...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: maintain legacy addNetwork/delNetwork APIs
automat...@ovirt.org has posted comments on this change. Change subject: net: maintain legacy addNetwork/delNetwork APIs .. Patch Set 3: * Update tracker::#1229632::OK * Check TR::#1229632::ERROR, 3.6.0 should not match .* -- To view, visit https://gerrit.ovirt.org/43187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2eaf2b41e3e1c88721d855af0ccc3abd6c200034 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: maintain legacy addNetwork/delNetwork APIs
Dan Kenigsberg has posted comments on this change. Change subject: net: maintain legacy addNetwork/delNetwork APIs .. Patch Set 2: Code-Review+2 Verified+1 Passes functional tests (over xmlrpc) with no regression. -- To view, visit https://gerrit.ovirt.org/43187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2eaf2b41e3e1c88721d855af0ccc3abd6c200034 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: maintain legacy addNetwork/delNetwork APIs
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: maintain legacy addNetwork/delNetwork APIs .. net: maintain legacy addNetwork/delNetwork APIs commits 43a6b9 and 167b02 changed the signature of addNetwork and delNetwork respectively. The name change, from bridge to network is highly reasonable, as we support non-bridged networks. However, it must not happen, as Engine 3.5 uses argument names in its json-rpc API. commits 3abcad and 1d015d modified the schema to the new signature, so they are reverted as well. With http://www.ovirt.org/Features/HostNetworkingApi implemented in engine-3.6, no one is going to call Vdsm's addNetwork/delNetwork any more. However, we must keep backward compatibility as long as engine-3.5 is supported. Bug-Url: https://bugzilla.redhat.com/1229632 Change-Id: I2eaf2b41e3e1c88721d855af0ccc3abd6c200034 Signed-off-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: https://gerrit.ovirt.org/43187 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski piotr.kliczew...@gmail.com Reviewed-by: Ido Barkan ibar...@redhat.com --- M vdsm/API.py M vdsm/rpc/vdsmapi-schema.json 2 files changed, 8 insertions(+), 6 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2eaf2b41e3e1c88721d855af0ccc3abd6c200034 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon toni+ov...@midokura.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: marking slow tests with decorator
automat...@ovirt.org has posted comments on this change. Change subject: tests: marking slow tests with decorator .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/42918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: marking slow tests with decorator
Dan Kenigsberg has posted comments on this change. Change subject: tests: marking slow tests with decorator .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/42918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Allow pickling of protected password
automat...@ovirt.org has posted comments on this change. Change subject: password: Allow pickling of protected password .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I198f418d88348a2bae33b71e323a9741ae295d30 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: password: Allow pickling of protected password
Nir Soffer has uploaded a new change for review. Change subject: password: Allow pickling of protected password .. password: Allow pickling of protected password In commit 862d6440176c (password: Prevent password logging and persisting), we bloked pickling of protected passwords, to prevent accidental persisting of sensitive information. Turns out that when using iSCSI CHAP authentication, supervdsm is running iscsi.readSessionInfo(), returning a protected password. Under the hood, it tries to pickle the results and fails. We raise a very clear error when trying to pickle a ProtectePassword: TypeError: ProtectedPassword object cannot be pickled However, this error is swallowed in supervdsm or in the underlying multiprocessing magic, and we get this unhelpful error in vdsm: RuntimeError: Broken communication with supervdsm. Failed call to readSessionInfo Since we run lot of code via supervdsm, and returning objects transparently is extremely convenient, it seems that blocking pickling was not a good idea. This patch enables pickling of ProtectedPassword, fixing iSCSI storage when using CHAP authentication. Change-Id: I198f418d88348a2bae33b71e323a9741ae295d30 Signed-off-by: Nir Soffer nsof...@redhat.com --- M lib/vdsm/password.py M tests/passwordsTests.py 2 files changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/43256/1 diff --git a/lib/vdsm/password.py b/lib/vdsm/password.py index 52588b1..9e0756d 100644 --- a/lib/vdsm/password.py +++ b/lib/vdsm/password.py @@ -33,10 +33,6 @@ def __ne__(self, other): return not self.__eq__(other) -def __getstate__(self): - Do not serialize the the real password -raise TypeError(ProtectedPassword object cannot be pickled) - def __str__(self): return diff --git a/tests/passwordsTests.py b/tests/passwordsTests.py index 33bec3e..418d634 100644 --- a/tests/passwordsTests.py +++ b/tests/passwordsTests.py @@ -51,9 +51,10 @@ p2 = ProtectedPassword(12345678) self.assertFalse(p1 != p2) -def test_no_pickle(self): +def test_pickle_copy(self): p1 = ProtectedPassword(12345678) -self.assertRaises(TypeError, pickle.dumps, p1) +p2 = pickle.loads(pickle.dumps(p1)) +self.assertEqual(p1, p2) def test_no_marshal(self): p1 = ProtectedPassword(12345678) -- To view, visit https://gerrit.ovirt.org/43256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I198f418d88348a2bae33b71e323a9741ae295d30 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Protect sensitive return value in supervdsm log
automat...@ovirt.org has posted comments on this change. Change subject: iscsicred: Protect sensitive return value in supervdsm log .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcfa4ee17466f75270909587c45ee9f703e5e9f3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Support per-host iscsi credentials database
automat...@ovirt.org has posted comments on this change. Change subject: iscsicred: Support per-host iscsi credentials database .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6a838f6b8e132d6b0c1a8135f2c28ef1e7f847 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Tal Nisan tni...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Install the iscsi-cred directory
Nir Soffer has uploaded a new change for review.
Change subject: iscsicred: Install the iscsi-cred directory
..
iscsicred: Install the iscsi-cred directory
This directory will be populated with iscsi target credential files by
the system administrator.
Change-Id: Iea9359291a4bea9fa0d93d52f44f1e0af5235a4c
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M debian/vdsm.dirs
M debian/vdsm.postinst
M vdsm.spec.in
M vdsm/Makefile.am
4 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/43257/1
diff --git a/debian/vdsm.dirs b/debian/vdsm.dirs
index ee2bccd..3fd61f5 100644
--- a/debian/vdsm.dirs
+++ b/debian/vdsm.dirs
@@ -5,6 +5,7 @@
etc/pki/vdsm/libvirt-spice
etc/vdsm
etc/vdsm/mom.d
+etc/vdsm/iscsi-cred
rhev
rhev/data-center
rhev/data-center/hsm-tasks
diff --git a/debian/vdsm.postinst b/debian/vdsm.postinst
index 5458974..88644cb 100644
--- a/debian/vdsm.postinst
+++ b/debian/vdsm.postinst
@@ -66,6 +66,7 @@
$INSTALLDIR /var/run/vdsm/trackedInterfaces
$INSTALLDIR /var/log/vdsm
$INSTALLDIR /var/log/vdsm/backup
+install -dDm 0700 /etc/vdsm/iscsi-cred
chmod g+x /var/lib/libvirt/qemu
chmod 644 /etc/iscsi/initiatorname.iscsi
diff --git a/vdsm.spec.in b/vdsm.spec.in
index de15c12..733a6e9 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -805,6 +805,8 @@
%dir %{_libexecdir}/%{vdsm_name}
%dir %{_sysconfdir}/%{vdsm_name}
%dir %{_sysconfdir}/%{vdsm_name}/mom.d
+%dir %{_sysconfdir}/%{vdsm_name}/iscsi-cred
+%attr(0700, root, root) %{_sysconfdir}/%{vdsm_name}/iscsi-cred
%dir %{_datadir}/%{vdsm_name}
%dir %{_datadir}/%{vdsm_name}/network
%dir %{_datadir}/%{vdsm_name}/network/configurators
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 691fb8b..866ee6b 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -158,6 +158,7 @@
$(MKDIR_P) $(DESTDIR)$(vdsmlibdir)/upgrade
$(MKDIR_P) $(DESTDIR)$(vdsmbackupdir)
$(MKDIR_P) $(DESTDIR)$(localstatedir)/lib/libvirt/qemu/channels
+ $(MKDIR_P) $(DESTDIR)$(vdsmconfdir)/iscsi-cred
uninstall-local: \
uninstall-data-bonding-defaults \
--
To view, visit https://gerrit.ovirt.org/43257
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea9359291a4bea9fa0d93d52f44f1e0af5235a4c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Use local iscsi credentials database
Nir Soffer has uploaded a new change for review.
Change subject: iscsicred: Use local iscsi credentials database
..
iscsicred: Use local iscsi credentials database
When discovering send targets or logging in to targets, use the local
iscsi credentials database.
Change-Id: I065619f31fbefeb5b96bc86ed9da81ce17c1c47d
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M vdsm/storage/hsm.py
1 file changed, 24 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/43258/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 1b9de05..a236b23 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -57,6 +57,7 @@
import image
import volume
import iscsi
+import iscsicred
import misc
from misc import deprecated
import taskManager
@@ -234,17 +235,34 @@
conDict.get('initiatorName', None),
conDict.get('netIfaceName', None))
-cred = None
-username = conDict.get('user', None)
-password = conDict.get('password', None)
-if username or password:
-cred = iscsi.ChapCredentials(username, password)
+cred = _iscsi_chap_credentials(conDict)
params = storageServer.IscsiConnectionParameters(target, iface, cred)
else:
raise se.StorageServerActionError()
return storageServer.ConnectionInfo(typeName, params)
+
+
+def _iscsi_chap_credentials(con):
+
+Return iscsi.ChapCredentials from local credentials database of from
+connection info.
+
+TODO: prefer more specific credentials over less specific:
+iqn ip:port host engine.
+
+try:
+credentials = iscsicred.get_credentials('host')
+return iscsi.ChapCredentials(credentials['username'],
+ credentials['password'])
+except iscsicred.NotFound:
+username = con.get('user')
+if username:
+password = con.get('password')
+return iscsi.ChapCredentials(username, password)
+
+return None
class HSM(object):
@@ -3028,16 +3046,10 @@
ip = con['connection']
port = int(con['port'])
-username = con['user']
-password = con['password']
-if username == :
-username = password = None
iface = iscsi.IscsiInterface(default)
portal = iscsi.IscsiPortal(ip, port)
-cred = None
-if username or password:
-cred = iscsi.ChapCredentials(username, password)
+cred = _iscsi_chap_credentials(con)
try:
targets = iscsi.discoverSendTargets(iface, portal, cred)
--
To view, visit https://gerrit.ovirt.org/43258
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I065619f31fbefeb5b96bc86ed9da81ce17c1c47d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Install the iscsi-cred directory
automat...@ovirt.org has posted comments on this change. Change subject: iscsicred: Install the iscsi-cred directory .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea9359291a4bea9fa0d93d52f44f1e0af5235a4c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Use local iscsi credentials database
automat...@ovirt.org has posted comments on this change. Change subject: iscsicred: Use local iscsi credentials database .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I065619f31fbefeb5b96bc86ed9da81ce17c1c47d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Install the iscsi-cred directory
Nir Soffer has posted comments on this change. Change subject: iscsicred: Install the iscsi-cred directory .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea9359291a4bea9fa0d93d52f44f1e0af5235a4c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsicred: Use local iscsi credentials database
Nir Soffer has posted comments on this change.
Change subject: iscsicred: Use local iscsi credentials database
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/43258/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 252: TODO: prefer more specific credentials over less specific:
Line 253: iqn ip:port host engine.
Line 254:
Line 255: try:
Line 256: credentials = iscsicred.get_credentials('host')
This will read /etc/vdsm/iscsi-cred/host, assuming that we have single
credentials per host for all servers. This is the simplest possible
configuration. This may be good enough according to the bug.
https://bugzilla.redhat.com/1239266
We should support also unique credentials per-host-per-server, stored in
/etc/vdsm/iscsi-cred/voodoo8.tlv.redhat.com:3260.
Finally the most specific credentials is per-host-per-target, stored in
/etc/vdsm/iscsi-cred/iqn.2003-01.org.linux-iscsi.voodoo8.x8664:sn.a14490eb9836
The most specific credential file should win.
Line 257: return iscsi.ChapCredentials(credentials['username'],
Line 258: credentials['password'])
Line 259: except iscsicred.NotFound:
Line 260: username = con.get('user')
--
To view, visit https://gerrit.ovirt.org/43258
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I065619f31fbefeb5b96bc86ed9da81ce17c1c47d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Tal Nisan tni...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
