Change in vdsm[master]: Hook: ide2sata: To switch IDE disks to SATA

[ciudavitacos]

Javier Coscia has posted comments on this change.

Change subject: Hook: ide2sata: To switch IDE disks to SATA
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/48450/4/vdsm_hooks/ide2sata/before_vm_start.py
File vdsm_hooks/ide2sata/before_vm_start.py:

Line 55: dev = target.getAttribute('dev')
Line 56: if ((device == 'disk' or device == 'lun')
Line 57:and (bus == 'ide')):
Line 58: target.setAttribute('bus', 'sata')
Line 59: target.setAttribute('dev', 'sd%s' % dev[-1])
> This assumes that drives have only one letter, which may be correct for ide
I'll revert back the device name characters to the original patch set where the 
setAttribute didn't care how many characters will follow the 'sd'. One question 
regarding the hot-plug/unplug tests, IDE disks cannot be hot-plugged/unplugged 
while the VM is running, you have to shutdown the VM, activate/deactivate the 
disks and then start the VM again. Is there anything I need to test here? 
thanks!!
Line 60: 
Line 61: 
Line 62: def main():
Line 63: if 'ide2sata' in os.environ:


-- 
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0088dae191cf4560a00ee62023a54f5ab746a3c9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Javier Coscia 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Javier Coscia 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 6:

* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
* Check Public Bug::#1199782::OK, public bug
* Check Product::#1134256::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check Product::#1199782::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: renaming device unplug related function

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: renaming device unplug related function
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ab2b22e2a79507cde77addf28f29b80bde9e24d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: renaming device unplug related function

[mmirecki]

Marcin Mirecki has uploaded a new change for review.

Change subject: vm: renaming device unplug related function
..

vm: renaming device unplug related function

Renaming function related to unplugging a device
to contain 'device' instead of 'drive'

Change-Id: I3ab2b22e2a79507cde77addf28f29b80bde9e24d
Signed-off-by: Marcin Mirecki 
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/49038/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 74b3241..8b137a2 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -1264,7 +1264,7 @@
 testvm = TestingVm(fake.Domain())
 
 testvm._dom = FakeVmDom(self.DRIVE_XML, times_to_return_matching=99)
-self.assertRaises(HotunplugTimeout, testvm._waitForDriveRemoval,
+self.assertRaises(HotunplugTimeout, testvm._waitForDeviceRemoval,
   drive)
 
 @MonkeyPatch(config, 'getint', lambda x, y: 0)
@@ -1273,7 +1273,7 @@
 testvm = TestingVm(fake.Domain())
 
 testvm._dom = FakeVmDom(self.DRIVE_XML)
-testvm._waitForDriveRemoval(drive)
+testvm._waitForDeviceRemoval(drive)
 
 @MonkeyPatch(config, 'getint', lambda x, y: 0)
 def test_wait_for_drive_removal_removed_on_x_check(self):
@@ -1281,7 +1281,7 @@
 testvm = TestingVm(fake.Domain())
 
 testvm._dom = FakeVmDom(self.DRIVE_XML, times_to_return_matching=2)
-testvm._waitForDriveRemoval(drive)
+testvm._waitForDeviceRemoval(drive)
 self.assertEqual(testvm._dom._result_count, 2)
 
 
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index f882734..8da0f3c 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2237,7 +2237,7 @@
 
 try:
 self._dom.detachDevice(nicXml)
-self._waitForDriveRemoval(nic)
+self._waitForDeviceRemoval(nic)
 except HotunplugTimeout as e:
 self.log.error("%s", e)
 return response.error('hotunplugNic', "%s" % e)
@@ -2640,7 +2640,7 @@
 params=drive.custom)
 try:
 self._dom.detachDevice(driveXml)
-self._waitForDriveRemoval(drive)
+self._waitForDeviceRemoval(drive)
 except HotunplugTimeout as e:
 self.log.error("%s", e)
 return response.error('hotunplugDisk', "%s" % e)
@@ -2666,7 +2666,7 @@
 
 return {'status': doneCode, 'vmList': self.status()}
 
-def _waitForDriveRemoval(self, device):
+def _waitForDeviceRemoval(self, device):
 """
 As stated in libvirt documentary, after detaching a device using
 virDomainDetachDeviceFlags, we need to verify that this device
@@ -2688,13 +2688,13 @@
 deadline = (utils.monotonic_time() +
 config.getint('vars', 'hotunplug_timeout'))
 sleep_time = config.getint('vars', 'hotunplug_sleep_time')
-while self._isDriveAttached(device):
+while self._isDeviceAttached(device):
 time.sleep(sleep_time)
 if utils.monotonic_time() > deadline:
 raise HotunplugTimeout("Timeout detaching device %s"
% device.name)
 
-def _isDriveAttached(self, device):
+def _isDeviceAttached(self, device):
 root = ET.fromstring(self._dom.XMLDesc(0))
 return bool(root.findall(device.xpath))
 


-- 
To view, visit https://gerrit.ovirt.org/49038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ab2b22e2a79507cde77addf28f29b80bde9e24d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: vm: check operation result for vm nic hotunplug
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/48473/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2681: API docs- but after contacting libvirt's guys it turned out 
that this
Line 2682: is true. Bug 1257280 opened for fixing the documentation.)
Line 2683: TODO: remove this comment when the documentation will be 
fixed.
Line 2684: 
Line 2685: :param device: Device to be removed
> Device to wait for
Done
Line 2686: """
Line 2687: self.log.debug("Waiting for hotunplug to finish")
Line 2688: with utils.stopwatch("Hotunplug device %s" % device.name):
Line 2689: deadline = (utils.monotonic_time() +


Line 2687: self.log.debug("Waiting for hotunplug to finish")
Line 2688: with utils.stopwatch("Hotunplug device %s" % device.name):
Line 2689: deadline = (utils.monotonic_time() +
Line 2690: self._hotunplug_timeout)
Line 2691: while self._is_device_attached(device):
> This is much nicer, but lets do this in a separate patch, renaming also _wa
Done
Line 2692: self._wait_for_sleep()
Line 2693: if utils.monotonic_time() > deadline:
Line 2694: raise HotunplugTimeout("Timeout detaching device 
%s"
Line 2695:% device.name)


-- 
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: fix python-libvirt requirement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: fix python-libvirt requirement
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/49035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e6096df3be73b6929940460c9467d9bb2ab1768
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: fix python-libvirt requirement

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: spec: fix python-libvirt requirement
..


spec: fix python-libvirt requirement

Requiring python-libvirt-1.2.17.el7 which
is not available breaks master and makes
it impossible to install vdsm.
Fixing: https://gerrit.ovirt.org/#/c/44834/

Change-Id: I0e6096df3be73b6929940460c9467d9bb2ab1768
Signed-off-by: Yeela Kaplan 
Reviewed-on: https://gerrit.ovirt.org/49035
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Yeela Kaplan: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e6096df3be73b6929940460c9467d9bb2ab1768
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sd: Remove unused setMetadata

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sd: Remove unused setMetadata
..


Patch Set 8:

Yeela, can you share the commit id?

-- 
To view, visit https://gerrit.ovirt.org/45613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: Remove duplicate servers

[ahino]

Ala Hino has posted comments on this change.

Change subject: gluster: Remove duplicate servers
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49023/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 338: raise 
se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 339: 
Line 340: def _get_backup_servers_option(self):
Line 341: servers = OrderedDict.fromkeys([brick.split(":")[0] for brick
Line 342:in 
self.volinfo['bricks']]).keys()
> How about adding a utility function in utils?
Yup - having a unique util making the code more readable
Line 343: self.log.debug("Using bricks: %s", servers)
Line 344: if self._volfileserver in servers:
Line 345: servers.remove(self._volfileserver)
Line 346: else:


-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Hook: ide2sata: To switch IDE disks to SATA

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Hook: ide2sata: To switch IDE disks to SATA
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0088dae191cf4560a00ee62023a54f5ab746a3c9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Javier Coscia 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Javier Coscia 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: debuging: Use __repr__ instead of __str__
..


Patch Set 1: Code-Review+1

I'd suggest documenting __str__ vs. __repr__ usage on 
http://www.ovirt.org/Vdsm_Coding_Guidelines once we settle on it.

-- 
To view, visit https://gerrit.ovirt.org/48865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd724e32dfde1ca484343730f2e55c37a59fdf3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sd: Remove unused setMetadata

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: sd: Remove unused setMetadata
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/45613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[frolland]

Hello Fred Rolland,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/48962

to review the following change.

Change subject: spec: Require newer lvm2 version for el7
..

spec: Require newer lvm2 version for el7

lvm 117 introduced a regression, causing second pvcreate call to
fail during create vg flow, because of stale /etc/lvm/cache/.cache
file.

lvm2 2.02.130 fixed this issue. We require now this version.

We don't require the package on CentOS, since it is not available yet.

The issue is probably effecting also Fedora 23. We will provide a
separate patch for Fedora if needed.

Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1272035
Signed-off-by: Fred Rolland 
---
M vdsm.spec.in
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/48962/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 366921d..c89a5f4 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -192,7 +192,12 @@
 %else
 Requires: kernel >= 3.10.0-229.17.1.el7
 %endif
+%if 0%{?centos}
+# TODO: Remove when lvm2 2.02.130 is available
 Requires: lvm2 >= 2.02.107
+%else
+Requires: lvm2 >= 2.02.130
+%endif
 Requires: python >= 2.7.5-18.el7_1.1
 Requires: policycoreutils-python
 Requires: selinux-policy-targeted >= 3.13.1-16.el7


-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 1:

* #1272035::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1272035::OK, public bug
* Check Product::#1272035::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: executor: log pool status on discard

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: lib: executor: log pool status on discard
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/48333/5/lib/vdsm/executor.py
File lib/vdsm/executor.py:

Line 111: if self._running:
Line 112: self._add_worker()
Line 113: # this is a debug aid, it is not that important to be precise;
Line 114: # intentionally done outside the lock
Line 115: self._log.info('pool[%i]: (%s)',
s/pool/executor pool/ or s/pool/worker pool/ ?
Line 116:len(self._workers),
Line 117:' '.join(str(w) for w in self._workers))
Line 118: 
Line 119: def _worker_stopped(self, worker):


-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 2: Code-Review+2

Waiting for Dan

-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: Send all the pending messages in handle_write

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: Send all the pending messages in handle_write
..


Patch Set 2:

It looks good for single frame that we are sending. I wonder whether we want to 
send all the frames we have.

-- 
To view, visit https://gerrit.ovirt.org/4
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35dad03942cb53f95c57cc6b48bd3ae93885a0d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: exception: Make VdsmException reusable

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: exception: Make VdsmException reusable
..


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/48875/2//COMMIT_MSG
Commit Message:

Line 10: as
remove duplication


Line 10: make is
This makes it


https://gerrit.ovirt.org/#/c/48875/2/tests/exception_test.py
File tests/exception_test.py:

Line 19: #
Line 20: 
Line 21: from testlib import VdsmTestCase
Line 22: from vdsm.exception import VdsmException
Line 23: 
I would add GlusterException test since the change could affect it.
Line 24: 
Line 25: class SubExceptiong(VdsmException):
Line 26: code = 42
Line 27: message = "message"


-- 
To view, visit https://gerrit.ovirt.org/48875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: exception: Inherit from VdsmException

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: exception: Inherit from VdsmException
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48869
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25ffdd531fc9878a6762e2c0f670134b3aedf9a0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

[fromani]

Francesco Romani has posted comments on this change.

Change subject: debuging: Use __repr__ instead of __str__
..


Patch Set 1: Code-Review+1

TL;DR: +1
I'm ok as long as we all settle in one direction. I see the shift is towards 
__repr__ and I don't have strong objections.

+++

I'm OK but not completely sold, here's why:

Reading the python docs, I think on average the actual output is more suitable 
for __str__ than __repr__ (e.g. we rarely if ever attempt to produce an output 
that "If at all possible, this should look like a valid Python expression that 
could be used to recreate an object with the same value").

I guess we often fall short of "if at all possible" :)

-- 
To view, visit https://gerrit.ovirt.org/48865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd724e32dfde1ca484343730f2e55c37a59fdf3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: exception: Add exceptions for vdsm.define errors
..


Patch Set 5:

I like the concept. Will give the score once it is done.

-- 
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: debuging: Use __repr__ instead of __str__
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd724e32dfde1ca484343730f2e55c37a59fdf3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: vm: snapshot - use r+ to open vm conf file

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vm: snapshot - use r+ to open vm conf file
..


Patch Set 1:

why jenkins fail ?

-- 
To view, visit https://gerrit.ovirt.org/48912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 3:

* #1272035::Update tracker: OK
* Set MODIFIED::bug 1272035#1272035IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: Require newer lvm2 version for el7
..


spec: Require newer lvm2 version for el7

lvm 117 introduced a regression, causing second pvcreate call to
fail during create vg flow, because of stale /etc/lvm/cache/.cache
file.

lvm2 2.02.130 fixed this issue. We require now this version.

We don't require the package on CentOS, since it is not available yet.

The issue is probably effecting also Fedora 23. We will provide a
separate patch for Fedora if needed.

Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1272035
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/48962
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm.spec.in
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer lvm2 version for el7

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 1: Verified+1

Package available in rhel 7.2.

[root@venus-vdsa ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.2 (Maipo)

[root@venus-vdsa ~]# rpm -qa | grep lvm
lvm2-libs-2.02.130-5.el7.x86_64
lvm2-2.02.130-5.el7.x86_64

-- 
To view, visit https://gerrit.ovirt.org/48972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: ignore cpu affinity on single processor

[mskrivan]

Michal Skrivanek has posted comments on this change.

Change subject: daemon: ignore cpu affinity on single processor
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48961/1/vdsm/vdsm
File vdsm/vdsm:

Line 272: log.info('VDSM will run with cpu affinity: %s', cpu_set)
Line 273: 
Line 274: # too early to use the facilities from caps.py
Line 275: if os.sysconf('SC_NPROCESSORS_ONLN') == 1:
Line 276: log.warning('Only one cpu detected: affinity disabled')
ugh, i added comment to master version which is merged. just something to 
consider, no deal breaker...
https://gerrit.ovirt.org/#/c/48619/7/vdsm/vdsm@233
Line 277: return
Line 278: 
Line 279: taskset.set(os.getpid(), cpu_set, all_tasks=True)
Line 280: 


-- 
To view, visit https://gerrit.ovirt.org/48961
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Fixing connection when server is not one of the bricks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Fixing connection when server is not one of the bricks
..


Patch Set 1:

* #1278880::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1278880::OK, public bug
* Check Product::#1278880::OK, Correct classification oVirt
* Check TM::#1278880::OK, correct target milestone ovirt-3.6.1
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/48969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Fixing connection when server is not one of the bricks

[ahino]

Hello Sahina Bose,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/48969

to review the following change.

Change subject: gluster: Fixing connection when server is not one of the bricks
..

gluster: Fixing connection when server is not one of the bricks

When processing gluster connection info, volfileserver is set as provided by
the admin and, using volume info, backup-volfile-servers option is set. However,
there are use cases where gluster server and ovirt are configured differently
regarding ip addresses and domain names. If volfileserver appears in volume
info, it is removed in order to avoid mounting duplicate servers, otherwise,
mounting duplicate servers is possible.

Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Bug-Url: https://bugzilla.redhat.com/1278880
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/48308
Continuous-Integration: Jenkins CI
Reviewed-by: Sahina Bose 
Reviewed-by: Nir Soffer 
---
M tests/storageServerTests.py
M vdsm/storage/storageServer.py
2 files changed, 27 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/48969/1

diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index 6abd427..f39fe82 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -149,6 +149,25 @@
   "backup-volfile-servers=192.168.122.2:192.168.122.3")
 
 @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
+def test_server_not_in_volinfo(self):
+"""
+This test simulates a use case where gluster server provided in the
+path doesn't appear in the volume info.
+"""
+def glusterVolumeInfo(volname=None, volfileServer=None):
+return {'music': {'brickCount': '3',
+  'bricks': ['192.168.122.5:/tmp/music',
+ '192.168.122.2:/tmp/music',
+ '192.168.122.3:/tmp/music']}}
+
+storageServer.supervdsm.glusterVolumeInfo = glusterVolumeInfo
+
+gluster = GlusterFSConnection(spec="gluster-server:/music")
+expected_backup_servers = \
+"backup-volfile-servers=192.168.122.5:192.168.122.2:192.168.122.3"
+self.assertEquals(gluster.options, expected_backup_servers)
+
+@MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
 def test_gluster_and_user_provided_mount_options(self):
 def glusterVolumeInfo(volname=None, volfileServer=None):
 return {'music': {'brickCount': '3',
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index c321942..4385889 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -337,7 +337,14 @@
 
 def _get_backup_servers_option(self):
 servers = [brick.split(":")[0] for brick in self.volinfo['bricks']]
-servers.remove(self._volfileserver)
+self.log.debug("Using bricks: %s", servers)
+if self._volfileserver in servers:
+servers.remove(self._volfileserver)
+else:
+self.log.warning("gluster server %r is not in bricks %s, possibly "
+ "mounting duplicate servers",
+ self._volfileserver, servers)
+
 if not servers:
 return ""
 


-- 
To view, visit https://gerrit.ovirt.org/48969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Sahina Bose 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer lvm2 version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 1:

* #1272035::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1272035::OK, public bug
* Check Product::#1272035::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1272035::OK, correct target milestone ovirt-3.6.3
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/48972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Network API: Remove "force" option

[edwardh]

Edward Haas has posted comments on this change.

Change subject: Network API: Remove "force" option
..


Patch Set 1: Verified+1

Run Unit Tests & Functional Tests

-- 
To view, visit https://gerrit.ovirt.org/48960
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I985cdf22376712ab15ba58c1f2120e2c2ff3e89c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer lvm2 version for el7

[frolland]

Hello Fred Rolland,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/48972

to review the following change.

Change subject: spec: Require newer lvm2 version for el7
..

spec: Require newer lvm2 version for el7

lvm 117 introduced a regression, causing second pvcreate call to
fail during create vg flow, because of stale /etc/lvm/cache/.cache
file.

lvm2 2.02.130 fixed this issue. We require now this version.

We don't require the package on CentOS, since it is not available yet.

The issue is probably effecting also Fedora 23. We will provide a
separate patch for Fedora if needed.

Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Bug-Url: https://bugzilla.redhat.com/1272035
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/48962
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm.spec.in
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/48972/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 28b7705..d227f22 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -188,7 +188,12 @@
 %else
 Requires: kernel >= 3.10.0-229.17.1.el7
 %endif
+%if 0%{?centos}
+# TODO: Remove when lvm2 2.02.130 is available
 Requires: lvm2 >= 2.02.107
+%else
+Requires: lvm2 >= 2.02.130-2
+%endif
 Requires: python >= 2.7.5-18.el7_1.1
 Requires: policycoreutils-python
 Requires: selinux-policy-targeted >= 3.13.1-16.el7


-- 
To view, visit https://gerrit.ovirt.org/48972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: daemon: ignore cpu affinity on single processor

[mskrivan]

Michal Skrivanek has posted comments on this change.

Change subject: daemon: ignore cpu affinity on single processor
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/48619/7/vdsm/vdsm
File vdsm/vdsm:

Line 229: log.info('VDSM will run with cpu affinity: %s', cpu_set)
Line 230: 
Line 231: # too early to use the facilities from caps.py
Line 232: if os.sysconf('SC_NPROCESSORS_ONLN') == 1:
Line 233: log.warning('Only one cpu detected: affinity disabled')
if possible i would like to avoid a warning in harmless/expected situations. 
Can we just exit early na bit above with an info?
Line 234: return
Line 235: 
Line 236: taskset.set(os.getpid(), cpu_set, all_tasks=True)
Line 237: 


-- 
To view, visit https://gerrit.ovirt.org/48619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: daemon: ignore cpu affinity on single processor

[fromani]

Francesco Romani has posted comments on this change.

Change subject: daemon: ignore cpu affinity on single processor
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/48619/7/vdsm/vdsm
File vdsm/vdsm:

Line 229: log.info('VDSM will run with cpu affinity: %s', cpu_set)
Line 230: 
Line 231: # too early to use the facilities from caps.py
Line 232: if os.sysconf('SC_NPROCESSORS_ONLN') == 1:
Line 233: log.warning('Only one cpu detected: affinity disabled')
> if possible i would like to avoid a warning in harmless/expected situations
Will change to debug level
Line 234: return
Line 235: 
Line 236: taskset.set(os.getpid(), cpu_set, all_tasks=True)
Line 237: 


-- 
To view, visit https://gerrit.ovirt.org/48619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: allow waiting for import thread completion

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: allow waiting for import thread completion
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30f21c00f520f67d199c39376cbaf053025a60c2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: executor: log pool status on discard

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: lib: executor: log pool status on discard
..


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48333/5/lib/vdsm/executor.py
File lib/vdsm/executor.py:

Line 113: # this is a debug aid, it is not that important to be precise;
Line 114: # intentionally done outside the lock
Line 115: self._log.info('pool[%i]: (%s)',
Line 116:len(self._workers),
Line 117:' '.join(str(w) for w in self._workers))
This is not informational message, its a debugging message.

If this was unexpected situation it could be a warning, but expect this to 
happen from time to time, so lets have a debug message.

This notation is not very clear pool[12]: ( ).

How about:

"count=%d workers=%s", len(self._workers), self._workers

Formatting a list of object with __repr__ should work without additional code.
See https://gerrit.ovirt.org/48865
Line 118: 
Line 119: def _worker_stopped(self, worker):
Line 120: """
Line 121: Called from worker thread before it exit.


-- 
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: ignore cpu affinity on single processor

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: daemon: ignore cpu affinity on single processor
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48961
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: betterAsyncore: Send pending data without polling

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: betterAsyncore: Send pending data without polling
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48887/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 164: def set(self):
Line 165: self._eventfd.write(1)
Line 166: 
Line 167: def handle_read(self):
Line 168: self.wokeup = True
> It would set it after reading not before due errors like EAGAIN.
My assumption is that the signalfd becomes readable only when you write to it. 
So calling handle_write means the event was signaled and the reactor was woken 
up.

I don't care if the read succeed or not, unless it is this api is known to have 
spurious wakeups, and we can detect them by reading.
Line 169: self._eventfd.read()
Line 170: 
Line 171: def close(self):
Line 172: try:


-- 
To view, visit https://gerrit.ovirt.org/48887
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0f76660e7b4c31f87af342428a533a6045ddad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: betterAsyncore: Send pending data without polling

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: betterAsyncore: Send pending data without polling
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48887/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 164: def set(self):
Line 165: self._eventfd.write(1)
Line 166: 
Line 167: def handle_read(self):
Line 168: self.wokeup = True
> My assumption is that the signalfd becomes readable only when you write to 
If the reading fails we will have side effect of wokeup flag being set.
Line 169: self._eventfd.read()
Line 170: 
Line 171: def close(self):
Line 172: try:


-- 
To view, visit https://gerrit.ovirt.org/48887
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0f76660e7b4c31f87af342428a533a6045ddad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: install ovs hook only with --enable-hooks

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: install ovs hook only with --enable-hooks
..


Patch Set 1: Code-Review+2

I don't really care...

-- 
To view, visit https://gerrit.ovirt.org/48671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e6aeb4bf3c72ef515f57b153a98f504e04e4e79
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: vm: snapshot - use r+ to open vm conf file

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vm: snapshot - use r+ to open vm conf file
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: vm: snapshot - use r+ to open vm conf file

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vm: snapshot - use r+ to open vm conf file
..


vm: snapshot - use r+ to open vm conf file

Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9
copy of internal raw volumes is done using 'qemu-img convert'
instead of invoking 'dd'. Hence, we should avoid changing
the file size by opening it in a non-truncate mode to avoid
qemu-img from hanging during the convert operation.

The issue reproduces for files size of multiplicity of 512.
E.g.
Doesn't work:
$ dd if=/dev/zero of=/tmp/test.raw bs=5474 count=1
$ ./qemu-img convert -p -t none -T none -O raw /tmp/test.raw
/tmp/dest.raw

Works:
$ dd if=/dev/zero of=/tmp/test.raw bs=5120 count=1
$ ./qemu-img convert -p -t none -T none -O raw /tmp/test.raw
/tmp/dest.raw

Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49
Bug-Url: https://bugzilla.redhat.com/1282239
Relates-To: https://bugzilla.redhat.com/1229394
Signed-off-by: Daniel Erez 
Reviewed-on: https://gerrit.ovirt.org/48776
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
Reviewed-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/48912
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Daniel Erez: Verified



-- 
To view, visit https://gerrit.ovirt.org/48912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: use six.iteritems and six.itervalues

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: use six.iteritems and six.itervalues
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47139
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d098a3142f61e927e047058424d2bd6f6955145
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer lvm2 version for el7

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: config: Trivial typo fix in option description

[fromani]

Francesco Romani has posted comments on this change.

Change subject: config: Trivial typo fix in option description
..


Patch Set 1: Code-Review+1

...but config.py.in is shared domain, hence downgrading to +1

-- 
To view, visit https://gerrit.ovirt.org/48820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I527f3f64601d1845e5cca2c73b44d69f957df78f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 4: Code-Review+2

looks OK. Let's give Jenkins another change.

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: ignore cpu affinity on single processor

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: daemon: ignore cpu affinity on single processor
..


daemon: ignore cpu affinity on single processor

If VDSM runs on single processor hosts (E.g. VMs)
there is no point in enabling cpu affinity, since
we already reached the goal of running on just one CPU.

Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Bug-Url: https://bugzilla.redhat.com/1279431
Backport-To: 3.6
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/48619
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/48961
Reviewed-by: Milan Zamazal 
---
M vdsm/vdsm
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48961
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: ignore cpu affinity on single processor

[automation]

gerrit-hooks has posted comments on this change.

Change subject: daemon: ignore cpu affinity on single processor
..


Patch Set 2:

* #1279431::Update tracker: OK
* Set MODIFIED::bug 1279431#1279431OK

-- 
To view, visit https://gerrit.ovirt.org/48961
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: ignore cpu affinity on single processor

[fromani]

Francesco Romani has posted comments on this change.

Change subject: daemon: ignore cpu affinity on single processor
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48961
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: ignore cpu affinity on single processor

[fromani]

Francesco Romani has posted comments on this change.

Change subject: daemon: ignore cpu affinity on single processor
..


Patch Set 1: Verified+1

verified on branch, the same way on master (offlining cpu via cmdline, checking 
vdsm behaviour)

-- 
To view, visit https://gerrit.ovirt.org/48961
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 4: Verified+1

Verified on RHEL6.6 with Python2.6- checked dircet LUN disks, file and block 
disks- both successful and unsuccessful hotunplugging.

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: vm: snapshot - use r+ to open vm conf file

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: snapshot - use r+ to open vm conf file
..


Patch Set 2:

* #1282239::Update tracker: OK
* Set MODIFIED::bug 1282239#1282239IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/48912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Daniel Erez 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: ovs: fix getVdsCaps and getVdsStats

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc8298a737fccea626b4419bd7d462cc830afc2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: tests: test network's iface

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: tests: test network's iface
..


Patch Set 3: Code-Review-1

(1 comment)

I actually like the fact that this test breaks ovs hook

https://gerrit.ovirt.org/#/c/48366/3/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 247:  bridged)
Line 248: network_config = config.networks[networkName]
Line 249: if network_config['bridged']:
Line 250: expected_iface = networkName
Line 251: elif network_config.get('vlan'):
elif 'vlan' in network_config:

to avoid confusing with vlan=0
Line 252: expected_iface = '%s.%s' % (network_config.get('bonding') 
or
Line 253: network_config.get('nic'),
Line 254: network_config.get('vlan'))
Line 255: else:


-- 
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 4: Code-Review+1

Sorry for the noise, bool does not handle generators well.

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm.py: Deprecate getVGList

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm.py: Deprecate getVGList
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm.py: Deprecate getVGList

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: hsm.py: Deprecate getVGList
..

hsm.py: Deprecate getVGList

oVirt Engine commit 4312bfd removed all the usages of getVGList from the
engine's code.

Since this verb is useless to us (the same functionality is covered by
getVGInfo and getDeviceList), and since it's no longer called, this
patch flags it as @deprecated, with the intent to remove it completely
in the future.

Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889
Signed-off-by: Allon Mureinik 
---
M vdsm/storage/hsm.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/48998/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index a91ab28..68b90ea 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -2925,6 +2925,7 @@
 info["GUID"] = str(pv.guid)
 return info
 
+@deprecated
 @public
 def getVGList(self, storageType=None, options=None):
 """


-- 
To view, visit https://gerrit.ovirt.org/48998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm.py: Deprecate getVGList

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: hsm.py: Deprecate getVGList
..


Patch Set 1: Verified+1

Verification: code-only

-- 
To view, visit https://gerrit.ovirt.org/48998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 5: Verified-1

* #1283287::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283287::OK, public bug
* Check Product::#1283287::OK, Correct classification oVirt
* Check TM::#1283287::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::WARN, Still missing on branches ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotunplug: support python < 2.7

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: hotunplug: support python < 2.7
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48908/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2717:   DISK_TYPE.BLOCK: 'dev',
Line 2718:   DISK_TYPE.NETWORK: 'name'}
Line 2719: sources = root.findall("./devices/disk/source")
Line 2720: return bool([s for s in sources
Line 2721:  if s.get(source_key[drive.diskType]) == 
drive.path])
> We should simplify.
In case you mean by "no need to build a temporary list" to:
"s for s in sources if s.get(key) == drive.path", this is not a list 
comprehension valid syntax:
https://docs.python.org/2/tutorial/datastructures.html#list-comprehensions..
If we want to use list comprehensions, we must create a list- unless you have 
another idea..
Line 2722: 
Line 2723: def _readPauseCode(self):
Line 2724: state, reason = self._dom.state(0)
Line 2725: 


-- 
To view, visit https://gerrit.ovirt.org/48908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Fixing connection when server is not one of the bricks

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: gluster: Fixing connection when server is not one of the bricks
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48969
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: config: Trivial typo fix in option description

[fromani]

Francesco Romani has posted comments on this change.

Change subject: config: Trivial typo fix in option description
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/48820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I527f3f64601d1845e5cca2c73b44d69f957df78f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 4:

Jenkins failures are not relevant

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Make BIOS messages available on vmconsole
..


Patch Set 5: Code-Review+1

(1 comment)

minor comment inside

https://gerrit.ovirt.org/#/c/48404/5/tests/vmTests.py
File tests/vmTests.py:

Line 292: @permutations([['serial', True], ['virtio', False]])
Line 293: def testSerialBios(self, console_type, use_serial):
Line 294: devices = {'device': 'console', 'type': 'console',
Line 295:'specParams': {'consoleType': console_type}},
Line 296: with fake.VM(devices=devices, create_device_objects=True) as 
v:
minor: we usually avoid so short names. "fakevm" or "testvm" could be a better 
choice here.
Line 297: dom_xml = v._buildDomainXML()
Line 298: tree = etree.fromstring(dom_xml)
Line 299: element = tree.find(".//bios[@useserial='yes']")
Line 300: self.assertEqual(element is not None, use_serial)


-- 
To view, visit https://gerrit.ovirt.org/48404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc560d2562a913b7dba9a5c01952429459595973
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 1: Verified+1

Package available in rhel 7.2.

[root@venus-vdsa ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.2 (Maipo)

[root@venus-vdsa ~]# rpm -qa | grep lvm
lvm2-libs-2.02.130-5.el7.x86_64
lvm2-2.02.130-5.el7.x86_64

-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: allow waiting for import thread completion

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: allow waiting for import thread completion
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/48600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30f21c00f520f67d199c39376cbaf053025a60c2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add fake virt-v2v process for testing without virt-v2v

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/47738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: allow waiting for import thread completion

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: v2v: allow waiting for import thread completion
..


v2v: allow waiting for import thread completion

The wait is needed for v2v tests.

Change-Id: I30f21c00f520f67d199c39376cbaf053025a60c2
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/48600
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Tested-by: Shahar Havivi 
Reviewed-by: Francesco Romani 
---
M vdsm/v2v.py
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Shahar Havivi: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I30f21c00f520f67d199c39376cbaf053025a60c2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add fake virt-v2v process for testing without virt-v2v

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..


v2v: add fake virt-v2v process for testing without virt-v2v

Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/47738
Reviewed-by: Nir Soffer 
Tested-by: Shahar Havivi 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M tests/Makefile.am
A tests/fake-virt-v2v
A tests/fake-virt-v2v.out
M tests/v2vTests.py
M vdsm.spec.in
5 files changed, 169 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Shahar Havivi: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 2: Verified+1

Package available in rhel 7.2.

[root@venus-vdsa ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.2 (Maipo)

[root@venus-vdsa ~]# rpm -qa | grep lvm
lvm2-libs-2.02.130-5.el7.x86_64
lvm2-2.02.130-5.el7.x86_64

-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: betterAsyncore: Send pending data without polling

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: betterAsyncore: Send pending data without polling
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48887/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 164: def set(self):
Line 165: self._eventfd.write(1)
Line 166: 
Line 167: def handle_read(self):
Line 168: self.wokeup = True
It would set it after reading not before due errors like EAGAIN.
Line 169: self._eventfd.read()
Line 170: 
Line 171: def close(self):
Line 172: try:


-- 
To view, visit https://gerrit.ovirt.org/48887
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0f76660e7b4c31f87af342428a533a6045ddad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sd: Remove unused setMetadata

[ykaplan]

Yeela Kaplan has posted comments on this change.

Change subject: sd: Remove unused setMetadata
..


Patch Set 8:

Nir, the commit that added it is indeed in the rhev-3.0 branch.

-- 
To view, visit https://gerrit.ovirt.org/45613
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add fake virt-v2v process for testing without virt-v2v

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..


Patch Set 17: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/47738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: debuging: Use __repr__ instead of __str__
..


Patch Set 1:

Milan, this is a very good idea, do you want to update this page now?

-- 
To view, visit https://gerrit.ovirt.org/48865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd724e32dfde1ca484343730f2e55c37a59fdf3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: exception: Gather exceptions in vdsm.exception
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/48868/3//COMMIT_MSG
Commit Message:

Line 12: have one exception module
I am not sure whether this is good approach for errors like JsonRpcError and 
all that inherit from it.

When we start to using external to vdsm clients we do not want to have too many 
dependencies on vdsm.


-- 
To view, visit https://gerrit.ovirt.org/48868
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I076a7a381003053e7655ef5bece17c00ce9a92ca
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: debuging: Use __repr__ instead of __str__

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: debuging: Use __repr__ instead of __str__
..


Patch Set 1:

> do you want to update this page now?
OK, I'll do it once we are in confirmed agreement on the method use here.

-- 
To view, visit https://gerrit.ovirt.org/48865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd724e32dfde1ca484343730f2e55c37a59fdf3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: hostusb: make sudoers rule more specific

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: hooks: hostusb: make sudoers rule more specific
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48963
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaccc4fffd8ab055a0cd773df68b0431537901021
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48962/1/vdsm.spec.in
File vdsm.spec.in:

Line 195: %if 0%{?centos}
Line 196: # TODO: Remove when lvm2 2.02.130 is available
Line 197: Requires: lvm2 >= 2.02.107
Line 198: %else
Line 199: Requires: lvm2 >= 2.02.130
Should be lvm2 >= 2.02.130-2
Line 200: %endif
Line 201: Requires: python >= 2.7.5-18.el7_1.1
Line 202: Requires: policycoreutils-python
Line 203: Requires: selinux-policy-targeted >= 3.13.1-16.el7


-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 2:

* #1272035::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1272035::OK, public bug
* Check Product::#1272035::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Require newer lvm2 version for el7

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48962/1/vdsm.spec.in
File vdsm.spec.in:

Line 195: %if 0%{?centos}
Line 196: # TODO: Remove when lvm2 2.02.130 is available
Line 197: Requires: lvm2 >= 2.02.107
Line 198: %else
Line 199: Requires: lvm2 >= 2.02.130
> Should be lvm2 >= 2.02.130-2
Done
Line 200: %endif
Line 201: Requires: python >= 2.7.5-18.el7_1.1
Line 202: Requires: policycoreutils-python
Line 203: Requires: selinux-policy-targeted >= 3.13.1-16.el7


-- 
To view, visit https://gerrit.ovirt.org/48962
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: hostusb: make sudoers rule more specific

[ykaplan]

Yeela Kaplan has uploaded a new change for review.

Change subject: hooks: hostusb: make sudoers rule more specific
..

hooks: hostusb: make sudoers rule more specific

Change-Id: Iaccc4fffd8ab055a0cd773df68b0431537901021
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1234304
Signed-off-by: Yeela Kaplan 
---
M vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/48963/1

diff --git a/vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb 
b/vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb
index cba601d..51ea707 100644
--- a/vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb
+++ b/vdsm_hooks/hostusb/sudoers.vdsm_hook_hostusb
@@ -1 +1,3 @@
-vdsm  ALL=(ALL) NOPASSWD: /bin/chown
+Runas_AliasOP = root, vdsm
+
+vdsm  ALL=(OP) NOPASSWD: /bin/chown /dev/bus/usb/*/*


-- 
To view, visit https://gerrit.ovirt.org/48963
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaccc4fffd8ab055a0cd773df68b0431537901021
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: hostusb: make sudoers rule more specific

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: hostusb: make sudoers rule more specific
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234304::ERROR, private bug
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48963
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaccc4fffd8ab055a0cd773df68b0431537901021
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: hostusb: make sudoers rule more specific

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: hooks: hostusb: make sudoers rule more specific
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/48963
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaccc4fffd8ab055a0cd773df68b0431537901021
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hsm : Do not resize on disconnectStorageServer

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hsm : Do not resize on disconnectStorageServer
..


Patch Set 1: Code-Review+2

nope, just slipped down the list. Raising score.

-- 
To view, visit https://gerrit.ovirt.org/48705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78e236a851b7a0e9ab8f3c86e180cc50fde4ad56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm.py: Deprecate getVGList

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hsm.py: Deprecate getVGList
..


Patch Set 1: Code-Review+2

Waiting for Adam review

-- 
To view, visit https://gerrit.ovirt.org/48998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icac1e9f317af4f6089e11d647b9df361bd627889
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Cleanup conditionals in the build system

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 5: Continuous-Integration+1

CI failures unrelated, did smoke test locally, seems OK.

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure that stomp connection is active before send...

[piotr . kliczewski]

Piotr Kliczewski has uploaded a new change for review.

Change subject: stomp: make sure that stomp connection is active before sending 
messages
..

stomp: make sure that stomp connection is active before sending messages

In may happen that client sends SEND frame before CONNECT and SUBSCRIBE
frames are processed by the server which can lead to server having no
knowledge to whom send response because subscription is not finalized
yet. We need to wait for server to respond with CONNECTED frame before
sending any rpc requests.


Change-Id: I4f6881d7966fa47031d027740633ca83c834387f
Signed-off-by: pkliczewski 
---
M lib/yajsonrpc/stomp.py
M tests/stompAsyncClientTests.py
2 files changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/49000/1

diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py
index 38c05e4..b02039b 100644
--- a/lib/yajsonrpc/stomp.py
+++ b/lib/yajsonrpc/stomp.py
@@ -18,6 +18,8 @@
 import socket
 from uuid import uuid4
 from collections import deque
+from threading import Event
+from . import CALL_TIMEOUT
 
 from vdsm import utils
 import re
@@ -434,6 +436,7 @@
 self._outbox = deque()
 self._error = None
 self._subscriptions = {}
+self._ready = Event()
 self._commands = {
 Command.CONNECTED: self._process_connected,
 Command.MESSAGE: self._process_message,
@@ -481,6 +484,7 @@
 self._connected = True
 
 self.log.debug("Stomp connection established")
+self._ready.set()
 
 def _process_message(self, frame, dispatcher):
 sub_id = frame.headers.get(Headers.SUBSCRIPTION)
@@ -504,6 +508,9 @@
 raise StompError(frame)
 
 def send(self, destination, data="", headers=None):
+if not self._ready.wait(timeout=CALL_TIMEOUT):
+raise TimeoutError()
+
 final_headers = {"destination": destination}
 if headers is not None:
 final_headers.update(headers)
@@ -591,3 +598,7 @@
 def unsubscribe(self):
 self._client.unsubscribe(self)
 self._valid = False
+
+
+class TimeoutError(Exception):
+pass
diff --git a/tests/stompAsyncClientTests.py b/tests/stompAsyncClientTests.py
index 4ffc327..8d10a23 100644
--- a/tests/stompAsyncClientTests.py
+++ b/tests/stompAsyncClientTests.py
@@ -80,6 +80,9 @@
 '"id":"e8a936a6-d886-4cfa-97b9-2d54209053ff"}')
 headers = {Headers.REPLY_TO: 'jms.topic.vdsm_responses',
Headers.CONTENT_LENGTH: '103'}
+# make sure that client can send messages
+client._ready.set()
+
 client.send('jms.topic.vdsm_requests', data, headers)
 
 req_frame = client.pop_message()


-- 
To view, visit https://gerrit.ovirt.org/49000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f6881d7966fa47031d027740633ca83c834387f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure that stomp connection is active before send...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: make sure that stomp connection is active before sending 
messages
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f6881d7966fa47031d027740633ca83c834387f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 6:

* #1283287::Update tracker: OK
* Set MODIFIED::bug 1283287#1283287OK

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: hotunplug: support python 2.6
..


hotunplug: support python 2.6

In commit d0d05b02ee, we introduced a libvirt quering method to find
out if a drive was attached to a VM.

However- The XPath expression used in this method is supported only in
ElementTree1.3: http://effbot.org/zone/element-xpath.htm, which was only
introduced in Python 2.7:
https://docs.python.org/2/library/xml.etree.elementtree.html

As VDSM needs to support Python2.6 on RHEL6, this patch changes the
method to work with ElementTreee x.y available in Python 2.6.

Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Bug-Url: https://bugzilla.redhat.com/1283287
Label: ovirt-3.5-only
Signed-off-by: Amit Aviram 
Reviewed-on: https://gerrit.ovirt.org/48916
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
Continuous-Integration: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Amit Aviram: Verified
  Francesco Romani: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure that stomp connection is active before send...

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make sure that stomp connection is active before sending 
messages
..


Patch Set 1: Verified+1

Verified by running local tests several times.

-- 
To view, visit https://gerrit.ovirt.org/49000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f6881d7966fa47031d027740633ca83c834387f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: Allow attaching hosted engine sd

[rgolan]

Roy Golan has posted comments on this change.

Change subject: sp: Allow attaching hosted engine sd
..


Patch Set 1:

Nir pending your comments.

-- 
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fc1b19a6e70d4001a8f6d8c14bae7f65d0c192
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: spec: Require newer lvm2 version for el7

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require newer lvm2 version for el7
..


Patch Set 1:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/48972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I742508b0887c0337d9b97724d8e90326c68d548c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib script to build with rhev flags

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: contrib script to build with rhev flags
..

contrib script to build with rhev flags

Change-Id: Icea013429c828782b68f5c4900c78e089a9f94d4
Signed-off-by: Yaniv Bronhaim 
---
A contrib/rhev_build.sh
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/49001/1

diff --git a/contrib/rhev_build.sh b/contrib/rhev_build.sh
new file mode 100755
index 000..2f59bab
--- /dev/null
+++ b/contrib/rhev_build.sh
@@ -0,0 +1,2 @@
+echo 'Please run this script from vdsm main folder'
+make clean; ./autogen.sh --enable-rhev-build --enable-hooks 
--disable-gluster-mgmt; make dist


-- 
To view, visit https://gerrit.ovirt.org/49001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icea013429c828782b68f5c4900c78e089a9f94d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib script to build with rhev flags

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib script to build with rhev flags
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icea013429c828782b68f5c4900c78e089a9f94d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib script to build with rhev flags

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: contrib script to build with rhev flags
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icea013429c828782b68f5c4900c78e089a9f94d4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Cleanup conditionals in the build system

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
..


Patch Set 13: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Barak Korren 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches