Change in vdsm[master]: schema: introduce HostJobInfo type
Liron Aravot has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 4030: # @v2v: v2v job
Line 4031: #
Line 4032: # Since: 4.18
Line 4033: ##
Line 4034: {'enum': 'HostJobType', 'data': ['storage', 'v2v']}
why do we need the type? the engine known what job is assigned to each task by
the UUID and doesn't care about that field.
if it's for debugging and logging 'storage' is too general and the job
description is enough
Line 4035:
Line 4036: ##
Line 4037: # @HostJobStatus:
Line 4038: #
Line 4049: failed
we need to decide what happens when job ends, if it disappears automatically
statuses can be removed from here.
Line 4055:
Line 4056: ##
Line 4057: # @ErrorInfo:
Line 4058: #
Line 4059: # Information about an error
> Surprising, don't we have the error response already described elsewhere?
we need to decide what happens when job ends, if it disappears automatically
statuses can be removed from here.
Line 4060: #
Line 4061: # @code: An error code
Line 4062: #
Line 4063: # @message: A free-form description of the error
https://gerrit.ovirt.org/#/c/49450/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 42: '
you can replace the order here so it'll be aligned with the comment. :)
--
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Require newer qemu version for el7
Allon Mureinik has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 2: @Sandro - this looks like a pretty nasty bug in qemu. Any chance of getting qemu-kvm-rhev-2.3.0-31.el7_2.4 built for qemu-kvm-ev and available in our (oVirt's) repo? -- To view, visit https://gerrit.ovirt.org/50435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib59f19ba9ec56019e6f21391228983e3eb9c5ebd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Update time on VM after migration
Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after migration .. Patch Set 3: Thinking about it more and more, my opinion is we shouldn't update time after live migration. The time change may cause effects like unnecessary timeouts, logging SQL commands on the VM db as time excessive etc., which is probably not what one expects after "live" migration. It's better to leave the time change to ntp. (But the qemu-guest-agent issue is still relevant in other situations.) -- To view, visit https://gerrit.ovirt.org/49212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: vm: Update time on VM after resume
Francesco Romani has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 3: Verified+1 verified on-branch. - RHEL6: no virDomainSetTime API, no backport -> no luck. Verified we handle AttributeError without blowing up (we do). - RHEL7[.2]: verified running a VM with GA running -> works as expected - RHEL7[.2]: verified running a VM withOUT GA running -> as expected fails to set time, we log the error, we go ahead. -- To view, visit https://gerrit.ovirt.org/50456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Add api for getting host jobs info
Liron Aravot has posted comments on this change. Change subject: API: Add api for getting host jobs info .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/49451/2/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 159: : why not keeping the old implementation and add the new condition? if we are changing this, why not use a dict (get by the id) rather then iterate over all of them? -- To view, visit https://gerrit.ovirt.org/49451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957938ea9ca55d2499d09dfed39821c85e3e9d48 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: mark test_mkFloppyFs as broken
Dan Kenigsberg has uploaded a new change for review.
Change subject: tests: mark test_mkFloppyFs as broken
..
tests: mark test_mkFloppyFs as broken
test_mkFloppyFs fails quite often with
ERROR: Tests mkimage.mkFloppyFs creating an image and checking its content.
--
Traceback (most recent call last):
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testlib.py",
line 73, in wrapper
return f(self, *args)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/testValidation.py",
line 97, in wrapper
return f(*args, **kwargs)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/mkimageTests.py",
line 172, in test_mkFloppyFs
m.mount(mntOpts='loop')
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
line 225, in mount
return self._runcmd(cmd, timeout)
File
"/home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/vdsm/storage/mount.py",
line 241, in _runcmd
raise MountError(rc, ";".join((out, err)))
MountError: (32, ';mount:
/tmp/vdsm-mkimage-testswqsKjg/images/vmId_floppy.0478bd99cc3b39a408d863d4babd70bd.img:
failed to setup loop device: No such file or directory\n')
The floppy image might disappear by mkimage._commonCleanFs of a concurrent run
of the test.
Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3
Signed-off-by: Dan Kenigsberg
---
M tests/mkimageTests.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/50484/1
diff --git a/tests/mkimageTests.py b/tests/mkimageTests.py
index ab2e4e9..c74166f 100644
--- a/tests/mkimageTests.py
+++ b/tests/mkimageTests.py
@@ -34,7 +34,7 @@
from nose.plugins.skip import SkipTest
from monkeypatch import Patch
from testlib import VdsmTestCase, permutations, expandPermutations
-from testValidation import checkSudo, ValidateRunningAsRoot
+from testValidation import brokentest, checkSudo, ValidateRunningAsRoot
from vdsm import udevadm
from vdsm.utils import execCmd, stopwatch
@@ -159,6 +159,8 @@
mkimage._decodeFilesIntoDir(self.files, self.workdir)
self._check_content()
+@brokentest("mkimage._commonCleanFs of one run can remove floppy image "
+"created by a concurrent one")
@ValidateRunningAsRoot
@permutations([[None], ['FSLABEL']])
def test_mkFloppyFs(self, label):
--
To view, visit https://gerrit.ovirt.org/50484
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: mark test_mkFloppyFs as broken
gerrit-hooks has posted comments on this change. Change subject: tests: mark test_mkFloppyFs as broken .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Update time on VM after migration
Francesco Romani has posted comments on this change. Change subject: virt: vm: Update time on VM after migration .. Patch Set 3: I share your doubts (that was the reason I had in the first place to split off this change). If you feel this patch is no longer needed, feel free to abandon it. -- To view, visit https://gerrit.ovirt.org/49212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: mark test_mkFloppyFs as broken
Francesco Romani has posted comments on this change. Change subject: tests: mark test_mkFloppyFs as broken .. Patch Set 1: Code-Review+1 Agreed: first unbreak jenkins, then unbreak this test. Unfortunately, looks like we will need the floppy legacy even in 4.0, thanks to windows -- To view, visit https://gerrit.ovirt.org/50484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: move device attached check to device itself
Marcin Mirecki has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/49670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
Nir Soffer has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2:
(11 comments)
https://gerrit.ovirt.org/#/c/49450/2//COMMIT_MSG
Commit Message:
Line 10: host. We support multiple job types (v2v, storage, etc.) and all job
Line 11: types will be reported via the same Host.getJobs API call. There will
Line 12: also be a standard interface for aborting and/or deleting them.
Line 13:
Line 14: This patch adds new "pending" job status, used as the default state.
> this could be a separate change
I can separate the code change, but we like to keep the schema complete.
Line 15: This is needed for storage jobs which are executed in a thread pool.
Line 16: The jobs module and tests were updated to support the new status.
Line 17:
Line 18: This schema specify job "progress" property as optional and add a new
Line 14: This patch adds new "pending" job status, used as the default state.
Line 15: This is needed for storage jobs which are executed in a thread pool.
Line 16: The jobs module and tests were updated to support the new status.
Line 17:
Line 18: This schema specify job "progress" property as optional and add a new
> same, this could be a separate change
Same
Line 19: optional "error" property. These changes are implemented in the next
Line 20: patches.
Line 21:
Line 22: Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 4030: # @v2v: v2v job
Line 4031: #
Line 4032: # Since: 4.18
Line 4033: ##
Line 4034: {'enum': 'HostJobType', 'data': ['storage', 'v2v']}
> why do we need the type? the engine known what job is assigned to each task
There should be able access current jobs even when there is no information on
the engine side. Since jobs have a type, it makes sense to support filtering by
type.
API should not cover the current needs we see today, but also future.
Line 4035:
Line 4036: ##
Line 4037: # @HostJobStatus:
Line 4038: #
Line 4045: # @done: The job has finished successfully
Line 4046: #
Line 4047: # @aborted: The job was aborted by user request
Line 4048: #
Line 4049: # @failed: The job has failed
> we need to decide what happens when job ends, if it disappears automaticall
V2V jobs are cleaned by the engine, so this information is required for generic
job.
Even if storage jobs will be automatically removed, we would like to send an
event with the job info, and the error is part of the info.
Changing the way jobs are managed should not change the api but be a local
change, e.g. adding event repoter that get a job object and send an event.
Line 4050: #
Line 4051: # Since: 4.18
Line 4052: ##
Line 4053: {'enum': 'HostJobStatus',
Line 4055:
Line 4056: ##
Line 4057: # @ErrorInfo:
Line 4058: #
Line 4059: # Information about an error
> Surprising, don't we have the error response already described elsewhere?
We have the same structure used for specific errors. This is a generic error
type that should replace the other types.
Line 4060: #
Line 4061: # @code: An error code
Line 4062: #
Line 4063: # @message: A free-form description of the error
Line 4055:
Line 4056: ##
Line 4057: # @ErrorInfo:
Line 4058: #
Line 4059: # Information about an error
> we need to decide what happens when job ends, if it disappears automaticall
See above.
Line 4060: #
Line 4061: # @code: An error code
Line 4062: #
Line 4063: # @message: A free-form description of the error
Line 4074: # on a host.
Line 4075: #
Line 4076: # @id: The job UUID
Line 4077: #
Line 4078: # @description: A description of the job or the current status of
the job
> if this is for debug purposes, and meant not for client (Engine) consumptio
We like to always have a description. This should be something like "Copying
volume xxxyyy to domain aaabbb" or "Importing disk 1 of 3 for vm xxxyyy". Will
be use in the vdsm and engine logs. Engine UI like to translated strings, so
this text will not be useful for the ui.
Line 4079: #(for debugging purposes)
Line 4080: #
Line 4081: # @job_type: The specific job type
Line 4082: #
https://gerrit.ovirt.org/#/c/49450/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 26: _lock = threading.Lock()
Line 27: _jobs = {}
Line 28:
Line 29:
Line 30: class STATUS:
> minor: I see you added "PENDING" - which is fine. The other fields looks re
Right, this is the life cycle of a job - pending, running, done , and the
possible errors; aborted, failed.
Line 31: '''
Line 32: PENDING: Job is has not started yet
Line 33: RUNNING: Job is running
Line 34: DONE: Job has finished successfully
Line 26: _lock = threading.Lock()
Line 27: _jobs = {}
Line 28:
Line 29:
Line 30: class STATUS:
> Pending may be used in v2v as well, the time that the job start until the a
Pending means the jobs was not started yet,
Change in vdsm[ovirt-3.6]: vm: move device attached check to device itself
Francesco Romani has submitted this change and it was merged. Change subject: vm: move device attached check to device itself .. vm: move device attached check to device itself Moving the check for being attached to the device in question. Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380 Signed-off-by: Marcin Mirecki Bug-Url: https://bugzilla.redhat.com/1134256 Reviewed-on: https://gerrit.ovirt.org/48881 Reviewed-by: Francesco Romani Reviewed-by: Ido Barkan Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/49670 Reviewed-by: Nir Soffer --- M vdsm/virt/vm.py M vdsm/virt/vmdevices/core.py M vdsm/virt/vmdevices/network.py M vdsm/virt/vmdevices/storage.py 4 files changed, 18 insertions(+), 7 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Marcin Mirecki: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/49670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: vm: Update time on VM after resume
Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 3: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/50456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: move device attached check to device itself
Francesco Romani has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: vm: Update time on VM after resume
gerrit-hooks has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 3: * #1287620::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1287620::OK, public bug * Check Product::#1287620::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::#1287620::OK, correct target milestone ovirt-3.5.7 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/50456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: vm: move device attached check to device itself
gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 3: * #1134256::Update tracker: OK * Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt classification but Red Hat -- To view, visit https://gerrit.ovirt.org/49670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: virt: vm: Update time on VM after resume
Francesco Romani has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 3: Continuous-Integration+1 run the tests manually on F22, EL6[.7], EL7[.2] -- To view, visit https://gerrit.ovirt.org/50456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes
Sahina Bose has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ramesh N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
Piotr Kliczewski has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 4026: (string)
It is nice additional information but until now we haven't provided it.
Line 4039: (string)
As above with the type.
Line 4061: code
Do we have common place to store the codes to keep them unique? If so please
add info about it here.
Line 4089: #
Line 4090: # Since: 4.18
Line 4091: ##
Line 4092: {'type': 'HostJobInfo',
Line 4093: 'data': {
Looking at the schema we seem to have different convention to format data.
Please be consistent.
Line 4094: 'id': 'UUID',
Line 4095: 'description': 'str',
Line 4096: 'job_type': 'HostJobType',
Line 4097: 'status': 'HostJobStatus',
--
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Add api for getting host jobs info
Nir Soffer has posted comments on this change.
Change subject: API: Add api for getting host jobs info
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49451/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 155: job_ids = frozenset(job_ids)
Line 156: with _lock:
Line 157: jobs = _jobs.values()
Line 158: result = {}
Line 159: for job in jobs:
> why not keeping the old implementation and add the new condition?
Not sure it is possible to use dict comprehension, and even if it is possible,
it would hard to understand and error prone (this was my first failed attempt).
Line 160: if job_type and job.job_type != job_type:
Line 161: continue
Line 162: if job_ids and job.id not in job_ids:
Line 163: continue
--
To view, visit https://gerrit.ovirt.org/49451
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I957938ea9ca55d2499d09dfed39821c85e3e9d48
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes
gerrit-hooks has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes .. Patch Set 3: * #1205724::Update tracker: OK * Set MODIFIED::bug 1205724#1205724IGNORE, not all related patches are closed, check 50306 -- To view, visit https://gerrit.ovirt.org/50312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ramesh N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes
Francesco Romani has submitted this change and it was merged. Change subject: gluster: Added VDSM verb to stop gluster related processes .. gluster: Added VDSM verb to stop gluster related processes Added a verb which stops the gluster related process like brick processes, gsyncd process. This needs to be done as part of a host moving to maintenance mode. as data should not be available if a host is moved to maintenence mode for some migration etc. Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Bug-Url: https://bugzilla.redhat.com/1205724 Signed-off-by: Shubhendu Tripathi Reviewed-on: https://gerrit.ovirt.org/43821 Tested-by: Ramesh N Continuous-Integration: Jenkins CI Reviewed-by: Bala.FA Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/50312 Reviewed-by: Sahina Bose Reviewed-by: Francesco Romani --- M client/vdsClientGluster.py M vdsm/gluster/api.py M vdsm/gluster/apiwrapper.py M vdsm/gluster/exception.py M vdsm/rpc/vdsmapi-gluster-schema.json 5 files changed, 45 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Sahina Bose: Looks good to me, but someone else must approve Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/50312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Ramesh N Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Ramesh N Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Only report progress if set
Nir Soffer has posted comments on this change. Change subject: jobs: Only report progress if set .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: gluster: Added VDSM verb to stop gluster related processes
Francesco Romani has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/50312/2/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:
Line 1302: # @GlusterHost.processesStop:
Line 1303: #
Line 1304: # Stops the gluster processes on the host
Line 1305: #
Line 1306: # Since: 4.17.0
should be either 4.17.x or 4.18.0 - but not that important *now*, because we
are in a backport
Line 1307: ##
Line 1308: {'command': {'class': 'GlusterHost', 'name': 'processesStop'}}
Line 1309:
Line 1310: ##
--
To view, visit https://gerrit.ovirt.org/50312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ramesh N
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Ramesh N
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Update time on VM after migration
Michal Skrivanek has posted comments on this change. Change subject: virt: vm: Update time on VM after migration .. Patch Set 3: Code-Review-1 I concur, based on the fact that the migration downtime is 500ms max by default, even in customized environment it's in the range of what NTP can handle easily -- To view, visit https://gerrit.ovirt.org/49212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: tests: More testVideoXML tests
Milan Zamazal has posted comments on this change. Change subject: virt: tests: More testVideoXML tests .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50420/1/tests/deviceTests.py File tests/deviceTests.py: Line 303: """ Line 304: Line 305: """] Line 306: ]) Line 307: def testVideoXML(self, dev_spec, video_xml): > I wonder if this could be clearer using a module-private constant, which co While it'd be a bit nicer, it would detach the data from the test. So I prefer the current way. Line 308: video = vmdevices.core.Video(self.conf, self.log, **dev_spec) Line 309: self.assertXMLEqual(video.getXML().toxml(), video_xml) Line 310: Line 311: def testInterfaceXML(self): -- To view, visit https://gerrit.ovirt.org/50420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I581f6e3c9cd72d98e3cecf89bd1d6b40b9109229 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.
Ido Barkan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: tests: More testVideoXML tests
Francesco Romani has posted comments on this change. Change subject: virt: tests: More testVideoXML tests .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50420/1/tests/deviceTests.py File tests/deviceTests.py: Line 303: """ Line 304: Line 305: """] Line 306: ]) Line 307: def testVideoXML(self, dev_spec, video_xml): > While it'd be a bit nicer, it would detach the data from the test. So I pre Ok, fair enough. Now, question: how did you select the new testcases? Do we cover all branches now? Line 308: video = vmdevices.core.Video(self.conf, self.log, **dev_spec) Line 309: self.assertXMLEqual(video.getXML().toxml(), video_xml) Line 310: Line 311: def testInterfaceXML(self): -- To view, visit https://gerrit.ovirt.org/50420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I581f6e3c9cd72d98e3cecf89bd1d6b40b9109229 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.
Alona Kaplan has posted comments on this change. Change subject: net: support hot(un)plugNic for SRIOV network devices. .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
Nir Soffer has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 4022:
Line 4023: ##
Line 4024: # @HostJobType:
Line 4025: #
Line 4026: # The type of a @HostJob (string)
> It is nice additional information but until now we haven't provided it.
We should start to specify this. Otherwise people are confused about the values
- the order of the strings does not matter, and the values must be the actual
string, not the index of the string in the list.
We have some old storage api that use numbers instead of strings. It must be
clear that this is not valid.
Line 4027: #
Line 4028: # @storage: Storage job
Line 4029: #
Line 4030: # @v2v: v2v job
Line 4057: # @ErrorInfo:
Line 4058: #
Line 4059: # Information about an error
Line 4060: #
Line 4061: # @code: An error code
> Do we have common place to store the codes to keep them unique? If so pleas
No, we have several error codes in various modules, not related to this change.
Line 4062: #
Line 4063: # @message: A free-form description of the error
Line 4064: #
Line 4065: # Since: 4.18
Line 4089: #
Line 4090: # Since: 4.18
Line 4091: ##
Line 4092: {'type': 'HostJobInfo',
Line 4093: 'data': {
> Looking at the schema we seem to have different convention to format data.
The current format is unreadable, it time to format data in a readable way.
Line 4094: 'id': 'UUID',
Line 4095: 'description': 'str',
Line 4096: 'job_type': 'HostJobType',
Line 4097: 'status': 'HostJobStatus',
--
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: mark test_mkFloppyFs as broken
gerrit-hooks has posted comments on this change. Change subject: tests: mark test_mkFloppyFs as broken .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: tests: More testVideoXML tests
Milan Zamazal has posted comments on this change. Change subject: virt: tests: More testVideoXML tests .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50420/1/tests/deviceTests.py File tests/deviceTests.py: Line 303: """ Line 304: Line 305: """] Line 306: ]) Line 307: def testVideoXML(self, dev_spec, video_xml): > Ok, fair enough. Now, question: how did you select the new testcases? Do we > how did you select the new testcases? Do we cover all branches now? Just a few representative cases (0, 1, all optional attributes). There is no need to explode the test with all possible combinations, the code is already covered. Line 308: video = vmdevices.core.Video(self.conf, self.log, **dev_spec) Line 309: self.assertXMLEqual(video.getXML().toxml(), video_xml) Line 310: Line 311: def testInterfaceXML(self): -- To view, visit https://gerrit.ovirt.org/50420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I581f6e3c9cd72d98e3cecf89bd1d6b40b9109229 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: extract specific classes for libvirt and ova
gerrit-hooks has posted comments on this change. Change subject: v2v: extract specific classes for libvirt and ova .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9ecd4a2cde6f379188da647c3a6f8874c41abd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
Piotr Kliczewski has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 4057: # @ErrorInfo:
Line 4058: #
Line 4059: # Information about an error
Line 4060: #
Line 4061: # @code: An error code
> No, we have several error codes in various modules, not related to this cha
Not specifically to this patch but when we create an api which is used by many
devs it is good practice to have unique codes which could be easily understood
by the client.
Line 4062: #
Line 4063: # @message: A free-form description of the error
Line 4064: #
Line 4065: # Since: 4.18
Line 4089: #
Line 4090: # Since: 4.18
Line 4091: ##
Line 4092: {'type': 'HostJobInfo',
Line 4093: 'data': {
> The current format is unreadable, it time to format data in a readable way.
Please do not introduce new format. I am working on adding more value to the
schema and some significant changes to have we process it. Soon to be published.
Line 4094: 'id': 'UUID',
Line 4095: 'description': 'str',
Line 4096: 'job_type': 'HostJobType',
Line 4097: 'status': 'HostJobStatus',
--
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: extract specific classes for libvirt and ova
Shahar Havivi has posted comments on this change.
Change subject: v2v: extract specific classes for libvirt and ova
..
Patch Set 4:
(6 comments)
https://gerrit.ovirt.org/#/c/49951/4/vdsm/v2v.py
File vdsm/v2v.py:
Line 292: self._prepared_volumes = []
Line 293:
Line 294: @property
Line 295: def id(self):
Line 296: return self._id
> question: should `id' be tied to the ImportVm object (old code) or to the C
You right,
I will be in both -
in the command its the vm id
in importVm its the job id
Line 297:
Line 298: @property
Line 299: def proc(self):
Line 300: return self._proc
Line 309: nice=NICENESS.HIGH,
Line 310: ioclass=IOCLASS.IDLE,
Line 311: env=self.environments())
Line 312:
Line 313: yield
> Sure, ImportVm should have proc member, since it manage this process.
Done
Line 314: finally:
Line 315: self._teardown_volumes()
Line 316:
Line 317: def _get_disk_format(self):
Line 325: try:
Line 326: self._disk_parameters.append('--vdsm-image-uuid')
Line 327: self._disk_parameters.append(disk['imageID'])
Line 328: self._disk_parameters.append('--vdsm-vol-uuid')
Line 329: self._disk_parameters.append(disk['volumeID'])
> Why keep disk_parameters instead of returning them? This is more fragile, a
Done
Line 330: except KeyError as e:
Line 331: raise InvalidInputError('Job %r missing required
property: %s'
Line 332: % (self._id, e))
Line 333:
Line 448: cmd.extend(self._disk_parameters)
Line 449: return cmd
Line 450:
Line 451: @contextmanager
Line 452: def execute(self):
> this just invoked the parent's execute(), thus feels redundant and could be
Done
Line 453: with super(self.__class__, self).execute():
Line 454: yield
Line 455:
Line 456:
Line 460:
Line 461: def __init__(self, command):
Line 462: '''
Line 463: do not use directly, use a factory method instead!
Line 464: '''
> stale comment, you killed the factory methods.
Done
Line 465: self._command = command
Line 466: self._thread = None
Line 467:
Line 468: self._status = STATUS.STARTING
Line 536: logging.info('Job %r finished import successfully',
Line 537: self._command.id)
Line 538:
Line 539: def _wait_for_process(self):
Line 540: if self._command.proc.returncode is not None:
> This works, but I think this that it would be nicer if the Command classes
Done
Line 541: return
Line 542: logging.debug("Job %r waiting for virt-v2v process",
self._command.id)
Line 543: if not
self._command.proc.wait(timeout=self.PROC_WAIT_TIMEOUT):
Line 544: raise V2VProcessError("Job %r timeout waiting for process
pid=%s",
--
To view, visit https://gerrit.ovirt.org/49951
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a9ecd4a2cde6f379188da647c3a6f8874c41abd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add error property
Shahar Havivi has posted comments on this change. Change subject: jobs: Add error property .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f6e27bcd69db1673e5168524b0ce94f2e9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Pablo Iranzo Gómez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: mark test_mkFloppyFs as broken
Nir Soffer has posted comments on this change. Change subject: tests: mark test_mkFloppyFs as broken .. Patch Set 2: Code-Review+2 I also seen too much of this failure. -- To view, visit https://gerrit.ovirt.org/50484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Correctly apply MTU values on networks
gerrit-hooks has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
Nir Soffer has posted comments on this change. Change subject: schema: introduce HostJobInfo type .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 4057: # @ErrorInfo: Line 4058: # Line 4059: # Information about an error Line 4060: # Line 4061: # @code: An error code > Not specifically to this patch but when we create an api which is used by m I agree, we must have single error repository with test validating that all errors use unique code. Line 4062: # Line 4063: # @message: A free-form description of the error Line 4064: # Line 4065: # Since: 4.18 -- To view, visit https://gerrit.ovirt.org/49450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Correctly apply MTU values on networks
Edward Haas has posted comments on this change.
Change subject: net: Correctly apply MTU values on networks
..
Patch Set 1:
(10 comments)
https://gerrit.ovirt.org/#/c/50397/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 268: if mtu:
: mtu = int(mtu)
> this transformation is not needed anymore
Done
Line 323: if mtu:
> This also need to be reconsidered now. We should update the bridges and the
Added a remark (TODO): The MTU should be updated only if different from current
value.
Line 899: _compliment_net_defaults(networks)
> after this call- I think kernelconfig._normalize_mtu is not needed anymore,
Found to be needed after all for an edge case:
Normalization happens even on "remove" networks, where the defaults are not
explicitly added (in our case, the mtu).
I will open a new patch for removing support of "remove" networks from the
normalization.
Line 967: compliment
> complement
Done
Line 969: a network
> networks
Done
Line 972: net
> it is idiomatic to call unneeded variables '_'. Moreover, if you don't need
Done
Line 972: _nets_attr
> the convention is to not prefix method variables with '_'.
Done
Line 973: if 'remove' not in att or att['remove'] is not True)
Line 974: for attr in _nets_attr:
Line 975: if 'mtu' not in attr:
Line 976: attr['mtu'] = DEFAULT_MTU
Line 977:
> I prefer a functional approach:
Making it immutable here looks strange to me, at least at this stage.
Line 978:
Line 979: def setSafeNetworkConfig():
Line 980: """Declare current network configuration as 'safe'"""
Line 981: utils.execCmd([constants.EXT_VDSM_STORE_NET_CONFIG,
https://gerrit.ovirt.org/#/c/50397/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 43: from vdsm.netinfo.mtus
> we try to keep import statements sorted alphabetically (it make sit easier
Done
Line 1045: # Add additional nic to the bond
: # Expect to see nics MTU to be DEFAULT.
: status, msg = self.setupNetworks(
: {}, {BONDING_NAME: dict(nics=nics)}, NOCHK)
:
: self.assertEquals(status, SUCCESS, msg)
:
: self.assertMtu(DEFAULT_MTU, BONDING_NAME,
:nics[0], nics[1], nics[2])
> this part should come at a stage when the expected MTU of the bond+slaves i
Existing test is valid by itself, I'll add an additional test to cover the
scenario you mentioned.
--
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Alona Kaplan
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Replace update time migration TODO
Milan Zamazal has uploaded a new change for review. Change subject: virt: vm: Replace update time migration TODO .. virt: vm: Replace update time migration TODO As discussed in https://gerrit.ovirt.org/49212, we are not going to update time on the guest after live migration. So we replace the corresponding TODO with an explanation comment. Change-Id: Ic2f6419825973680b2188ffa34e80994a1fbdb18 Signed-off-by: Milan Zamazal --- M vdsm/virt/vm.py 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/50499/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index b375cd0..28c0019 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -2831,11 +2831,17 @@ hooks.after_device_migrate_destination( dev._deviceXML, self.conf, dev.custom) -# TODO: _syncGuestTime() should be called here as it is in -# restore_state path. But there may be some issues with the call -# such as blocking for some time when qemu-guest-agent is not -# running in the guest. We'd like to discuss them more before -# touching migration. +# We refrain from syncing time in this path. There are two basic +# reasons: +# 1. The jump change in the time (as performed by QEMU) may cause +#undesired effects like unnecessary timeouts, false alerts +#(think about logging excessive SQL command execution times), +#etc. This is not what users expect when performing live +#migrations. +# 2. The user can simply run NTP on the VM to keep the time right +#and smooth after migrations. On the contrary to suspensions, +#there is no danger of excessive delays preventing NTP from +#operation. if 'guestIPs' in self.conf: del self.conf['guestIPs'] -- To view, visit https://gerrit.ovirt.org/50499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2f6419825973680b2188ffa34e80994a1fbdb18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Replace update time migration TODO
gerrit-hooks has posted comments on this change. Change subject: virt: vm: Replace update time migration TODO .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f6419825973680b2188ffa34e80994a1fbdb18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Only report progress if set
Shahar Havivi has posted comments on this change. Change subject: jobs: Only report progress if set .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Update time on VM after migration
Milan Zamazal has abandoned this change. Change subject: virt: vm: Update time on VM after migration .. Abandoned As explained in the comments, we shouldn't merge this. See https://gerrit.ovirt.org/50499 for related source code documentation update. -- To view, visit https://gerrit.ovirt.org/49212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Update time on VM after migration
gerrit-hooks has posted comments on this change. Change subject: virt: vm: Update time on VM after migration .. Patch Set 3: * #1156194::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/49212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21ebeecf52bc3f72a2cb7fe9cd9da7b6fd1a86d7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Correctly apply MTU values on networks
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/50397/1//COMMIT_MSG Commit Message: Line 8: > IMO you should explain that because of the default behaviour of vdsm- letti Done Line 14: us > is Done -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Correctly apply MTU values on networks
gerrit-hooks has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Correctly apply MTU values on networks
Edward Haas has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts
gerrit-hooks has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add error property
gerrit-hooks has posted comments on this change. Change subject: jobs: Add error property .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f6e27bcd69db1673e5168524b0ce94f2e9e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Pablo Iranzo Gómez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Rename the FAILED constant to "failed"
Nir Soffer has uploaded a new change for review. Change subject: jobs: Rename the FAILED constant to "failed" .. jobs: Rename the FAILED constant to "failed" For consistency with other status values, as describe in the HostJobStatus schema. Change-Id: I047ed344867d461d7343e929f9756f798f487b4c Signed-off-by: Nir Soffer --- M lib/vdsm/jobs.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/50503/1 diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py index b971c46..77653dc 100644 --- a/lib/vdsm/jobs.py +++ b/lib/vdsm/jobs.py @@ -32,7 +32,7 @@ RUNNING = 'running' # Job is running DONE = 'done'# Job has finished successfully ABORTED = 'aborted' # Job was aborted by user request -FAILED = 'error' # Job has failed +FAILED = 'failed'# Job has failed class ClientError(Exception): -- To view, visit https://gerrit.ovirt.org/50503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I047ed344867d461d7343e929f9756f798f487b4c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
gerrit-hooks has posted comments on this change. Change subject: schema: introduce HostJobInfo type .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Only report progress if set
gerrit-hooks has posted comments on this change. Change subject: jobs: Only report progress if set .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Keep same order of constants for consistency
Nir Soffer has uploaded a new change for review.
Change subject: jobs: Keep same order of constants for consistency
..
jobs: Keep same order of constants for consistency
Reorder the constants according to job normal lifecyle, and use the same
order in the module.
Change-Id: I8208bec91591405d2e49f6f6dac121973db03031
Signed-off-by: Nir Soffer
---
M lib/vdsm/jobs.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/50501/1
diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 3be8f60..586e941 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -29,9 +29,9 @@
class STATUS:
RUNNING = 'running' # Job is running
+DONE = 'done'# Job has finished successfully
ABORTED = 'aborted' # Job was aborted by user request
FAILED = 'error' # Job has failed
-DONE = 'done'# Job has finished successfully
class ClientError(Exception):
@@ -105,7 +105,7 @@
raise JobNotDone("Job %r is %s" % (self.id, self.status))
def validate_not_running(self):
-if self.status not in (STATUS.DONE, STATUS.FAILED, STATUS.ABORTED):
+if self.status not in (STATUS.DONE, STATUS.ABORTED, STATUS.FAILED):
raise JobNotDone("Job %r is %s" % (self.id, self.status))
def _abort(self):
--
To view, visit https://gerrit.ovirt.org/50501
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8208bec91591405d2e49f6f6dac121973db03031
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add the PENDING state
Nir Soffer has uploaded a new change for review.
Change subject: jobs: Add the PENDING state
..
jobs: Add the PENDING state
Storage jobs will be executed in a thread pool, so job starts now in
"pending" status by default. Job should move to "running" state when it
is actually running.
Change-Id: If569eb619d79afe9dfb5c770e014e1500f2871c8
Signed-off-by: Nir Soffer
---
M lib/vdsm/jobs.py
M tests/jobsTests.py
2 files changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/50502/1
diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 586e941..b971c46 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -28,6 +28,7 @@
class STATUS:
+PENDING = 'pending' # Job has not started yet
RUNNING = 'running' # Job is running
DONE = 'done'# Job has finished successfully
ABORTED = 'aborted' # Job was aborted by user request
@@ -64,7 +65,7 @@
def __init__(self, job_id, description=''):
self._id = job_id
-self._status = STATUS.RUNNING
+self._status = STATUS.PENDING
self._description = description
@property
@@ -104,7 +105,7 @@
if self.status != STATUS.DONE:
raise JobNotDone("Job %r is %s" % (self.id, self.status))
-def validate_not_running(self):
+def validate_not_active(self):
if self.status not in (STATUS.DONE, STATUS.ABORTED, STATUS.FAILED):
raise JobNotDone("Job %r is %s" % (self.id, self.status))
@@ -125,7 +126,7 @@
def delete(job_id):
try:
job = get(job_id)
-job.validate_not_running()
+job.validate_not_active()
_delete(job_id)
except ClientError as e:
logging.info('Cannot delete job, error: %s', e)
diff --git a/tests/jobsTests.py b/tests/jobsTests.py
index 0c83e5b..86dd847 100644
--- a/tests/jobsTests.py
+++ b/tests/jobsTests.py
@@ -57,13 +57,13 @@
def test_job_initial_state(self):
job = TestingJob()
-self.assertEqual(jobs.STATUS.RUNNING, job.status)
+self.assertEqual(jobs.STATUS.PENDING, job.status)
self.assertEqual('', job.description)
self.assertEqual('testing', job.job_type)
def test_job_info(self):
job = TestingJob()
-self.assertEqual({'status': 'running', 'progress': 0,
+self.assertEqual({'status': jobs.STATUS.PENDING, 'progress': 0,
'job_type': 'testing', 'description': ''},
job.info())
@@ -126,14 +126,19 @@
[jobs.STATUS.DONE],
[jobs.STATUS.FAILED]
])
-def test_delete_job(self, status):
+def test_delete_inactive_job(self, status):
job = TestingJob()
job._status = status
jobs.add(job)
self.assertEqual(response.success(), jobs.delete(job.id))
-def test_delete_running_job(self):
+@permutations([
+[jobs.STATUS.PENDING],
+[jobs.STATUS.RUNNING],
+])
+def test_delete_active_job(self, status):
job = TestingJob()
+job._status = status
jobs.add(job)
self.assertEqual(response.error(jobs.JobNotDone.name),
jobs.delete(job.id))
--
To view, visit https://gerrit.ovirt.org/50502
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If569eb619d79afe9dfb5c770e014e1500f2871c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Add api for getting host jobs info
gerrit-hooks has posted comments on this change. Change subject: API: Add api for getting host jobs info .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957938ea9ca55d2499d09dfed39821c85e3e9d48 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove duplication in STATUS constants
gerrit-hooks has posted comments on this change. Change subject: jobs: Remove duplication in STATUS constants .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3252f79d5a58a8ea694eef753d3eb93580b8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove duplication in STATUS constants
Nir Soffer has uploaded a new change for review. Change subject: jobs: Remove duplication in STATUS constants .. jobs: Remove duplication in STATUS constants We were duplicating the names and the values of the constants. Move the description of the constants to the same line. Change-Id: I3252f79d5a58a8ea694eef753d3eb93580b8 Signed-off-by: Nir Soffer --- M lib/vdsm/jobs.py 1 file changed, 4 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/50500/1 diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py index 8c7c30e..3be8f60 100644 --- a/lib/vdsm/jobs.py +++ b/lib/vdsm/jobs.py @@ -28,16 +28,10 @@ class STATUS: -''' -RUNNING: Job is running -ABORTED: Job aborted by user request -FAILED: Job failed and no longer running -DONE: Job has finished successfully -''' -RUNNING = 'running' -ABORTED = 'aborted' -FAILED = 'error' -DONE = 'done' +RUNNING = 'running' # Job is running +ABORTED = 'aborted' # Job was aborted by user request +FAILED = 'error' # Job has failed +DONE = 'done'# Job has finished successfully class ClientError(Exception): -- To view, visit https://gerrit.ovirt.org/50500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3252f79d5a58a8ea694eef753d3eb93580b8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Rename the FAILED constant to "failed"
gerrit-hooks has posted comments on this change. Change subject: jobs: Rename the FAILED constant to "failed" .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I047ed344867d461d7343e929f9756f798f487b4c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Keep same order of constants for consistency
gerrit-hooks has posted comments on this change. Change subject: jobs: Keep same order of constants for consistency .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8208bec91591405d2e49f6f6dac121973db03031 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add the PENDING state
gerrit-hooks has posted comments on this change. Change subject: jobs: Add the PENDING state .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If569eb619d79afe9dfb5c770e014e1500f2871c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: vm: Replace update time migration TODO
Francesco Romani has posted comments on this change. Change subject: virt: vm: Replace update time migration TODO .. Patch Set 1: Code-Review+2 Verified+1 jenkins run is good enough verification for a patch which just updates a comment -- To view, visit https://gerrit.ovirt.org/50499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2f6419825973680b2188ffa34e80994a1fbdb18 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove duplication in STATUS constants
Nir Soffer has posted comments on this change. Change subject: jobs: Remove duplication in STATUS constants .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3252f79d5a58a8ea694eef753d3eb93580b8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Only report progress if set
Nir Soffer has posted comments on this change. Change subject: jobs: Only report progress if set .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/50355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Keep same order of constants for consistency
Nir Soffer has posted comments on this change. Change subject: jobs: Keep same order of constants for consistency .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8208bec91591405d2e49f6f6dac121973db03031 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Correctly apply MTU values on networks
Jenkins CI has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 3: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 2 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts
Nir Soffer has posted comments on this change. Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49505/1/vdsm/v2v.py File vdsm/v2v.py: Line 326 Line 327 Line 328 Line 329 Line 330 > Don't we want to initialize all variables in the __init__ method? Yes, but this moved to the Command class. I suggest you continue this patch when we finish to refactor the code. -- To view, visit https://gerrit.ovirt.org/49505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
Nir Soffer has posted comments on this change. Change subject: schema: introduce HostJobInfo type .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/49450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add the PENDING state
Nir Soffer has posted comments on this change. Change subject: jobs: Add the PENDING state .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If569eb619d79afe9dfb5c770e014e1500f2871c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove duplication in STATUS constants
Francesco Romani has posted comments on this change.
Change subject: jobs: Remove duplication in STATUS constants
..
Patch Set 1: Code-Review+1
(1 comment)
nicer this way.
https://gerrit.ovirt.org/#/c/50500/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 26: _lock = threading.Lock()
Line 27: _jobs = {}
Line 28:
Line 29:
Line 30: class STATUS:
minor: it would be nice to add a one-line comment or docstring reminding that
this is the expected lifecycle order of statuses.
Line 31: RUNNING = 'running' # Job is running
Line 32: ABORTED = 'aborted' # Job was aborted by user request
Line 33: FAILED = 'error' # Job has failed
Line 34: DONE = 'done'# Job has finished successfully
--
To view, visit https://gerrit.ovirt.org/50500
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3252f79d5a58a8ea694eef753d3eb93580b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Rename the FAILED constant to "failed"
Nir Soffer has posted comments on this change. Change subject: jobs: Rename the FAILED constant to "failed" .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I047ed344867d461d7343e929f9756f798f487b4c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Keep same order of constants for consistency
Francesco Romani has posted comments on this change. Change subject: jobs: Keep same order of constants for consistency .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8208bec91591405d2e49f6f6dac121973db03031 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove duplication in STATUS constants
Francesco Romani has posted comments on this change.
Change subject: jobs: Remove duplication in STATUS constants
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50500/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 26: _lock = threading.Lock()
Line 27: _jobs = {}
Line 28:
Line 29:
Line 30: class STATUS:
> minor: it would be nice to add a one-line comment or docstring reminding th
wrote this before to check the followup patch(es). If you believe this make
sense, add it wherever fits best.
Line 31: RUNNING = 'running' # Job is running
Line 32: ABORTED = 'aborted' # Job was aborted by user request
Line 33: FAILED = 'error' # Job has failed
Line 34: DONE = 'done'# Job has finished successfully
--
To view, visit https://gerrit.ovirt.org/50500
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3252f79d5a58a8ea694eef753d3eb93580b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Correctly apply MTU values on networks
Ido Barkan has posted comments on this change. Change subject: net: Correctly apply MTU values on networks .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Alona Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: mark test_mkFloppyFs as broken
Sandro Bonazzola has posted comments on this change. Change subject: tests: mark test_mkFloppyFs as broken .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50484 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13317d32352d1dfddc2ac98ae601323d10f72bc3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
Francesco Romani has posted comments on this change. Change subject: schema: introduce HostJobInfo type .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/49450/3//COMMIT_MSG Commit Message: Line 10: host. We support multiple job types (v2v, storage, etc.) and all job Line 11: types will be reported via the same Host.getJobs API call. There will Line 12: also be a standard interface for aborting and/or deleting them. Line 13: Line 14: This patch contain only the schema changes, to make it easy to see the ok, this makes sense. Line 15: big picture. The next patches adapt the existing (undocumented) jobs Line 16: module to match the new schema. Line 17: Line 18: Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009 -- To view, visit https://gerrit.ovirt.org/49450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Rename the FAILED constant to "failed"
gerrit-hooks has posted comments on this change. Change subject: jobs: Rename the FAILED constant to "failed" .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I047ed344867d461d7343e929f9756f798f487b4c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
gerrit-hooks has posted comments on this change. Change subject: schema: introduce HostJobInfo type .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add the PENDING state
gerrit-hooks has posted comments on this change. Change subject: jobs: Add the PENDING state .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If569eb619d79afe9dfb5c770e014e1500f2871c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Only report progress if set
gerrit-hooks has posted comments on this change. Change subject: jobs: Only report progress if set .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Add api for getting host jobs info
gerrit-hooks has posted comments on this change. Change subject: API: Add api for getting host jobs info .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957938ea9ca55d2499d09dfed39821c85e3e9d48 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Add error property
gerrit-hooks has posted comments on this change. Change subject: jobs: Add error property .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/50354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f6e27bcd69db1673e5168524b0ce94f2e9e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Pablo Iranzo Gómez Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Keep same order of constants for consistency
Shahar Havivi has posted comments on this change. Change subject: jobs: Keep same order of constants for consistency .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8208bec91591405d2e49f6f6dac121973db03031 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Rename the FAILED constant to "failed"
Francesco Romani has posted comments on this change. Change subject: jobs: Rename the FAILED constant to "failed" .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I047ed344867d461d7343e929f9756f798f487b4c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: introduce HostJobInfo type
Nir Soffer has posted comments on this change.
Change subject: schema: introduce HostJobInfo type
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49450/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 4089: #
Line 4090: # Since: 4.18
Line 4091: ##
Line 4092: {'type': 'HostJobInfo',
Line 4093: 'data': {
> Please do not introduce new format. I am working on adding more value to th
OK, new version keeps the old format for consistency. We should reformat this
file aromatically using a tool.
Line 4094: 'id': 'UUID',
Line 4095: 'description': 'str',
Line 4096: 'job_type': 'HostJobType',
Line 4097: 'status': 'HostJobStatus',
--
To view, visit https://gerrit.ovirt.org/49450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedc242e22de0f3c69e722596a03fb0538594009
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Only report progress if set
Francesco Romani has posted comments on this change. Change subject: jobs: Only report progress if set .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: Add support for vgamem attribute
Hello Nir Soffer, Vinzenz Feenstra, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/50507
to review the following change.
Change subject: virt: Add support for vgamem attribute
..
virt: Add support for vgamem attribute
SPICE/QXL video RAM sizes are currently specified in domain XML
element using the following attributes: ram, vram, vgamem. VDSM is
missing support for vgamem, this patch adds it.
Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355
Bug-Url: https://bugzilla.redhat.com/1275539
Signed-off-by: Milan Zamazal
Reviewed-on: https://gerrit.ovirt.org/50091
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani
Reviewed-by: Nir Soffer
Reviewed-by: Vinzenz Feenstra
Tested-by: Nir Soffer
---
M tests/deviceTests.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vmdevices/core.py
3 files changed, 12 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/50507/1
diff --git a/tests/deviceTests.py b/tests/deviceTests.py
index a248277..977ec23 100644
--- a/tests/deviceTests.py
+++ b/tests/deviceTests.py
@@ -289,11 +289,11 @@
def testVideoXML(self):
videoXML = """
-
+
"""
-dev = {'device': 'vga', 'specParams': {'vram': '32768',
- 'heads': '2'}}
+dev = {'device': 'vga',
+ 'specParams': {'vram': '32768', 'heads': '2', 'vgamem': '8192'}}
video = vmdevices.core.Video(self.conf, self.log, **dev)
self.assertXMLEqual(video.getXML().toxml(), videoXML)
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index ce0d7da..770434e 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -2941,15 +2941,19 @@
# for @qxl is the size of the secondary bar,
#
# @ram: #optional size of the primary bar for @qxl in KB,
-# not supported for 'cirrus'
+# rejected by libvirt for 'cirrus' or 'vga'
#
# @heads: #optional Specify the amount of monitors that will use single
# pci device. Currently relevant for @qxl devices only
#
+# @vgamem: #optional framebuffer size for @qxl in KB,
+# rejected by libvirt for 'cirrus' or 'vga'
+# (new in version 4.17.14)
+#
# Since: 4.10.0
##
{'type': 'VmVideoDeviceSpecParams',
- 'data': {'vram': 'uint', '*ram': 'uint','*heads': 'uint'}}
+ 'data': {'vram': 'uint', '*ram': 'uint', '*vgamem': 'uint', '*heads': 'uint'}}
##
# @VmVideoDevice:
diff --git a/vdsm/virt/vmdevices/core.py b/vdsm/virt/vmdevices/core.py
index 8b18986..1db577a 100644
--- a/vdsm/virt/vmdevices/core.py
+++ b/vdsm/virt/vmdevices/core.py
@@ -290,8 +290,9 @@
video = self.createXmlElem('video', None, ['address'])
sourceAttrs = {'vram': self.specParams.get('vram', '32768'),
'heads': self.specParams.get('heads', '1')}
-if 'ram' in self.specParams:
-sourceAttrs['ram'] = self.specParams['ram']
+for attr in ('ram', 'vgamem',):
+if attr in self.specParams:
+sourceAttrs[attr] = self.specParams[attr]
video.appendChildWithArgs('model', type=self.device, **sourceAttrs)
return video
--
To view, visit https://gerrit.ovirt.org/50507
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Vinzenz Feenstra
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: Add support for vgamem attribute
gerrit-hooks has posted comments on this change. Change subject: virt: Add support for vgamem attribute .. Patch Set 1: * #1275539::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1275539::OK, public bug * Check Product::#1275539::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::#1275539::OK, correct target milestone ovirt-3.6.4 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/50507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Add api for getting host jobs info
Francesco Romani has posted comments on this change. Change subject: API: Add api for getting host jobs info .. Patch Set 4: (1 comment) minor improvement inside https://gerrit.ovirt.org/#/c/49451/4/vdsm/API.py File vdsm/API.py: Line 1463: return v2v.convert_ova(ova_path, vminfo, jobid, self._cif.irs) Line 1464: Line 1465: def getJobs(self, job_type=None, job_ids=()): Line 1466: return dict(status=doneCode, Line 1467: jobs=jobs.info(job_type=job_type, job_ids=job_ids)) we have the response module for this kind of task. Is it gone out of favour? return response.success(jobs=jobs.info(job_type=job_type, job_ids=job_ids)) seems cleaner and shorter Line 1468: Line 1469: def getConvertedVm(self, jobid): Line 1470: return v2v.get_converted_vm(jobid) Line 1471: -- To view, visit https://gerrit.ovirt.org/49451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957938ea9ca55d2499d09dfed39821c85e3e9d48 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: Add support for vgamem attribute
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Add support for vgamem attribute .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/50507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Only report progress if set
Francesco Romani has posted comments on this change. Change subject: jobs: Only report progress if set .. Patch Set 5: Here and in an handful of related patches I see V+1 without futher explanation. I trust both of you about this, but please add a few lines documenting how the verification is made, for future reference and for documentation purposes. -- To view, visit https://gerrit.ovirt.org/50355 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo:Report host DNSs in getVdsCaps
Dan Kenigsberg has posted comments on this change. Change subject: netinfo:Report host DNSs in getVdsCaps .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/46233/3/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 1272: # @additionalFeatures: Provides a list of additional features Line 1273: # supported in this host. Line 1274: # (new in version 4.17.0) Line 1275: # Line 1276: # @dnss:Provides host DNS servers from /etc/resolve.conf > dan. which version should I put here? 4.18 Line 1277: # Line 1278: # Since: 4.17.0 Line 1279: # Line 1280: # Notes: Since ovirt-engine cannot parse software versions in 'x.y.z' format, -- To view, visit https://gerrit.ovirt.org/46233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45bb4aec72cbcf4cc6131fd829ff8cb1d8fa4403 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Meni Yakove Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: virt: Add support for vgamem attribute
Milan Zamazal has posted comments on this change. Change subject: virt: Add support for vgamem attribute .. Patch Set 1: Verified+1 Verified by running with a patched Engine and checking on QEMU command line that vgamem (and other parameters) values change as expected. -- To view, visit https://gerrit.ovirt.org/50507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic595761ef7195ec12830dd7f057471512b5c6355 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo:Report host DNSs in getVdsCaps
Dan Kenigsberg has posted comments on this change. Change subject: netinfo:Report host DNSs in getVdsCaps .. Patch Set 3: Code-Review-1 this patch would need plenty of rebase since netinfo has gone through big changes -- To view, visit https://gerrit.ovirt.org/46233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45bb4aec72cbcf4cc6131fd829ff8cb1d8fa4403 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Meni Yakove Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Meni Yakove Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Add api for getting host jobs info
Nir Soffer has posted comments on this change. Change subject: API: Add api for getting host jobs info .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49451/4/vdsm/API.py File vdsm/API.py: Line 1463: return v2v.convert_ova(ova_path, vminfo, jobid, self._cif.irs) Line 1464: Line 1465: def getJobs(self, job_type=None, job_ids=()): Line 1466: return dict(status=doneCode, Line 1467: jobs=jobs.info(job_type=job_type, job_ids=job_ids)) > we have the response module for this kind of task. Is it gone out of favour Agree, this is the using the response module is the current best practice. The response module should be killed in the long term, and replaced by error handler in the top level of the server, returning error.response (see https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:exceptions) and embedding the response in a status dict if needed (only for xmlrpc). Currently we return a response which is xmlrpc only structure, and remove the response and extract the result object in jsonrpc bridge. Take a look at the rpc/bridge.py. Line 1468: Line 1469: def getConvertedVm(self, jobid): Line 1470: return v2v.get_converted_vm(jobid) Line 1471: -- To view, visit https://gerrit.ovirt.org/49451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957938ea9ca55d2499d09dfed39821c85e3e9d48 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Add api for getting host jobs info
gerrit-hooks has posted comments on this change. Change subject: API: Add api for getting host jobs info .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/49451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957938ea9ca55d2499d09dfed39821c85e3e9d48 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: Add api for getting host jobs info
Nir Soffer has posted comments on this change. Change subject: API: Add api for getting host jobs info .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/49451/4/vdsm/API.py File vdsm/API.py: Line 1463: return v2v.convert_ova(ova_path, vminfo, jobid, self._cif.irs) Line 1464: Line 1465: def getJobs(self, job_type=None, job_ids=()): Line 1466: return dict(status=doneCode, Line 1467: jobs=jobs.info(job_type=job_type, job_ids=job_ids)) > we have the response module for this kind of task. Is it gone out of favour Fixed in current version Line 1468: Line 1469: def getConvertedVm(self, jobid): Line 1470: return v2v.get_converted_vm(jobid) Line 1471: -- To view, visit https://gerrit.ovirt.org/49451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I957938ea9ca55d2499d09dfed39821c85e3e9d48 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove duplication in STATUS constants
Nir Soffer has posted comments on this change.
Change subject: jobs: Remove duplication in STATUS constants
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50500/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 26: _lock = threading.Lock()
Line 27: _jobs = {}
Line 28:
Line 29:
Line 30: class STATUS:
> wrote this before to check the followup patch(es). If you believe this make
Not sure if we need this comment.
Line 31: RUNNING = 'running' # Job is running
Line 32: ABORTED = 'aborted' # Job was aborted by user request
Line 33: FAILED = 'error' # Job has failed
Line 34: DONE = 'done'# Job has finished successfully
--
To view, visit https://gerrit.ovirt.org/50500
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3252f79d5a58a8ea694eef753d3eb93580b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Remove duplication in STATUS constants
Nir Soffer has posted comments on this change. Change subject: jobs: Remove duplication in STATUS constants .. Patch Set 1: Verified by running the tests (we have 96% coverage). -- To view, visit https://gerrit.ovirt.org/50500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3252f79d5a58a8ea694eef753d3eb93580b8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jobs: Keep same order of constants for consistency
Nir Soffer has posted comments on this change. Change subject: jobs: Keep same order of constants for consistency .. Patch Set 1: Verified by running the tests (we have 96% coverage). -- To view, visit https://gerrit.ovirt.org/50501 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8208bec91591405d2e49f6f6dac121973db03031 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
