Change in vdsm[master]: tests: Remove unused code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Remove unused code
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9532f049910b5d4121d9b15319cc9bca061f57
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Simplify DirectFile tests

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Simplify DirectFile tests
..


Patch Set 3:

(6 comments)

Very nice reduction and simplification!  See comments about units and use of a 
constant.

https://gerrit.ovirt.org/#/c/54678/3/tests/fileUtilTests.py
File tests/fileUtilTests.py:

Line 30: 
Line 31: @expandPermutations
Line 32: class DirectFileTests(TestCaseBase):
Line 33: 
Line 34: DATA = "a" * 512 + "b" * 512
Should we use a block size constant instead of a magic number here?
Line 35: 
Line 36: @permutations([[0], [512], [1024], [1024 + 512]])
Line 37: def testRead(self, size):
Line 38: with temporaryPath(data=self.DATA) as srcPath, \


Line 32: class DirectFileTests(TestCaseBase):
Line 33: 
Line 34: DATA = "a" * 512 + "b" * 512
Line 35: 
Line 36: @permutations([[0], [512], [1024], [1024 + 512]])
perhaps the permutations could be a number of blocks.
Line 37: def testRead(self, size):
Line 38: with temporaryPath(data=self.DATA) as srcPath, \
Line 39: fileUtils.open_ex(srcPath, "dr") as f:
Line 40: self.assertEquals(f.read(size), self.DATA[:size])


Line 38: with temporaryPath(data=self.DATA) as srcPath, \
Line 39: fileUtils.open_ex(srcPath, "dr") as f:
Line 40: self.assertEquals(f.read(size), self.DATA[:size])
Line 41: 
Line 42: @permutations([[512], [1024]])
same.
Line 43: def testSeekRead(self, offset):
Line 44: with temporaryPath(data=self.DATA) as srcPath, \
Line 45: fileUtils.open_ex(srcPath, "dr") as f:
Line 46: f.seek(offset)


Line 55: def testSmallWrites(self):
Line 56: with temporaryPath() as srcPath, \
Line 57: fileUtils.open_ex(srcPath, "dw") as f:
Line 58: f.write(self.DATA[:512])
Line 59: f.write(self.DATA[512:])
Use the constant.
Line 60: 
Line 61: with fileUtils.open_ex(srcPath, "r") as f:
Line 62: self.assertEquals(f.read(), self.DATA)
Line 63: 


Line 63: 
Line 64: def testUpdateRead(self):
Line 65: with temporaryPath() as srcPath, \
Line 66: fileUtils.open_ex(srcPath, "wd") as f:
Line 67: f.write(self.DATA[:512])
same.
Line 68: 
Line 69: with fileUtils.open_ex(srcPath, "r+d") as f:
Line 70: f.seek(512)
Line 71: f.write(self.DATA[512:])


Line 67: f.write(self.DATA[:512])
Line 68: 
Line 69: with fileUtils.open_ex(srcPath, "r+d") as f:
Line 70: f.seek(512)
Line 71: f.write(self.DATA[512:])
same.
Line 72: 
Line 73: with fileUtils.open_ex(srcPath, "r") as f:
Line 74: self.assertEquals(f.read(), self.DATA)
Line 75: 


-- 
To view, visit https://gerrit.ovirt.org/54678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic86b0fe22d5d5f1c9252b658ad76a13626de8246
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose hostdevReattach maintenance verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: expose hostdevReattach maintenance verb
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54891
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfb6a4e3854de8ea412417832a57fb896b78d1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: ovs: mock setupNetworks in OVSNetworkTests class

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: tests: ovs: mock setupNetworks in OVSNetworkTests class
..

tests: ovs: mock setupNetworks in OVSNetworkTests class

Until now we marked networks and bonds as OVS ones in OVSVdsProxy.
It is easier to do so on OVSNetworkTests class.

Change-Id: I07127bb335da9462b8b439b3853f7e89eaef3064
Signed-off-by: Petr Horáček 
---
M tests/functional/networkTestsOVS.py
1 file changed, 22 insertions(+), 39 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/54889/1

diff --git a/tests/functional/networkTestsOVS.py 
b/tests/functional/networkTestsOVS.py
index 848ebba..166f205 100644
--- a/tests/functional/networkTestsOVS.py
+++ b/tests/functional/networkTestsOVS.py
@@ -32,7 +32,6 @@
   _get_source_route, NETWORK_NAME,
   IP_ADDRESS, IP_MASK, IP_CIDR, IP_GATEWAY,
   IPv6_ADDRESS, IPv6_CIDR, VLAN_ID, NOCHK, SUCCESS)
-from utils import VdsProxy
 
 # WARNING: because of this module changes networkTests module, we cannot run
 # networkTests.py and networkTestsOVS.py in one run
@@ -153,37 +152,6 @@
 networkTests._waitForKnownOperstate = _fakeWaitForOperstate
 
 
-class OVSVdsProxy(VdsProxy):
-
-def setupNetworks(self, networks, bonds, options):
-if options.pop('ovs', True):
-# skip non-bridged networks and networks without a nic/bonding,
-# such tests should be listed in not_suported list
-for _, attrs in networks.items():
-if not attrs.get('bridged', True):
-raise SkipTest('OVS does not support bridgeless networks')
-
-# setup every network as OVS network
-for network, attrs in networks.items():
-if 'remove' not in attrs:
-networks[network].update({'custom': {'ovs': True}})
-for bond, attrs in bonds.items():
-if 'remove' not in attrs:
-bond_opts = bonds[bond].get('options', '').split()
-modified = False
-for i in range(len(bond_opts)):
-if bond_opts[i].startswith('custom='):
-bond_opts[i] = ('custom=%s,ovs=True' %
-bond_opts[i].split('=', 1)[1])
-modified = True
-break
-if not modified:
-bond_opts.append('custom=ovs=True')
-bonds[bond]['options'] = ' '.join(bond_opts)
-
-return super(OVSVdsProxy, self).setupNetworks(networks, bonds, options)
-
-
 @expandPermutations
 class OVSNetworkTest(NetworkTest):
 __test__ = True
@@ -202,14 +170,29 @@
 func(*args, **kwargs)
 return wrapper
 
-def setUp(self):
-self.vdsm_net = OVSVdsProxy()
+def setupNetworks(self, nets, bonds, opts, **kwargs):
+if opts.pop('ovs', True):
+# setup every network as OVS network
+for net, attrs in nets.items():
+if not attrs.get('bridged', True):
+raise SkipTest('OVS does not support bridgeless networks')
+if 'remove' not in attrs:
+nets[net].update({'custom': {'ovs': True}})
+for bond, attrs in bonds.items():
+if 'remove' not in attrs:
+bond_opts = bonds[bond].get('options', '').split()
+modified = False
+for i in range(len(bond_opts)):
+if bond_opts[i].startswith('custom='):
+bond_opts[i] = ('custom=%s,ovs=True' %
+bond_opts[i].split('=', 1)[1])
+modified = True
+break
+if not modified:
+bond_opts.append('custom=ovs=True')
+bonds[bond]['options'] = ' '.join(bond_opts)
 
-def setupNetworks(self, *args, **kwargs):
-# Do not run test_kernel_config
-if 'test_kernel_config' in kwargs:
-kwargs.pop('test_kernel_config')
-return self.vdsm_net.setupNetworks(*args, **kwargs)
+return self.vdsm_net.setupNetworks(nets, bonds, opts)
 
 @cleanupNet
 def test_ovirtmgmtm_to_ovs(self):


-- 
To view, visit https://gerrit.ovirt.org/54889
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07127bb335da9462b8b439b3853f7e89eaef3064
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 8:

Looks nice, see comments.

-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: dsaversion: Remove 3.4 support

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: dsaversion: Remove 3.4 support
..

dsaversion: Remove 3.4 support

The current VDSM no longer supports 3.4 clusters (see, e.g., commit
1f21f1c). This patch explicitly states that in the dsaversion, to avoid
pointless failures of dnf upgrading vdsm and having the host move to
non-operational.

Change-Id: I7332b7c11bee92868a51c972bfad2c4f1648df91
Signed-off-by: Allon Mureinik 
---
M lib/vdsm/dsaversion.py.in
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/54875/1

diff --git a/lib/vdsm/dsaversion.py.in b/lib/vdsm/dsaversion.py.in
index c800a7c..6bbc02a 100644
--- a/lib/vdsm/dsaversion.py.in
+++ b/lib/vdsm/dsaversion.py.in
@@ -35,8 +35,8 @@
 'version_name': version_name,
 'software_version': software_version,
 'software_revision': software_revision,
-'supportedENGINEs': ['3.4', '3.5', '3.6', '4.0'],
-'clusterLevels': ['3.4', '3.5', '3.6', '4.0'],
+'supportedENGINEs': ['3.5', '3.6', '4.0'],
+'clusterLevels': ['3.5', '3.6', '4.0'],
 }
 
 if cpuarch.real() == cpuarch.PPC64LE:


-- 
To view, visit https://gerrit.ovirt.org/54875
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7332b7c11bee92868a51c972bfad2c4f1648df91
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[phoracek]

Petr Horáček has abandoned this change.

Change subject: net: native ovs [1]
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/54820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If008e061bdef9851ff9e71942d05bc5bd6861c10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vm: conf: proper locking in the creation path

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Vm: conf: proper locking in the creation path
..


Patch Set 1:

* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
* Check Product::#1318550::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54909
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b754690a41cdc1e1303ddd4c792df5916570872
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: explicit virt-v2v requirement

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: spec: explicit virt-v2v requirement
..


Patch Set 4: Code-Review-1

(1 comment)

Try to find out if the package could be added. That would make it available on 
both supported platforms.

https://gerrit.ovirt.org/#/c/54798/4/vdsm.spec.in
File vdsm.spec.in:

Line 143: virt-v2v is not -yet?- available on !x86_64
Since the builds exist, it could be made available. Also, the idea of 
arch-specific spec with noarch build does not seem very nice.


-- 
To view, visit https://gerrit.ovirt.org/54798
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib96fee604db1fa73f9b000c26a27153c54a94f86
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add retry on full capacity

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: migration: Add retry on full capacity
..


Patch Set 20:

I agree with mbetak. Plus this aligns with existing mechanism of queueing 
migrations by vdsm itself (src side), which is one of the few things which used 
to work well

-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: api: remove unused methods

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: api: remove unused methods
..


Patch Set 4: Code-Review+2

Too bad that the work of http://gerrit.ovirt.org/8182 is now dropped with no 
replacement on sight.

-- 
To view, visit https://gerrit.ovirt.org/53673
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa97a687aad51e319eceffd9f82bc863a28e6bb8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Royce Lv 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Simplify DirectFile tests

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Simplify DirectFile tests
..


Patch Set 3:

(6 comments)

https://gerrit.ovirt.org/#/c/54678/3/tests/fileUtilTests.py
File tests/fileUtilTests.py:

Line 30: 
Line 31: @expandPermutations
Line 32: class DirectFileTests(TestCaseBase):
Line 33: 
Line 34: DATA = "a" * 512 + "b" * 512
> Should we use a block size constant instead of a magic number here?
Yes, I'll upload another patch replacing 512 with BLOCK_SIZE, this one is big 
enough as is.
Line 35: 
Line 36: @permutations([[0], [512], [1024], [1024 + 512]])
Line 37: def testRead(self, size):
Line 38: with temporaryPath(data=self.DATA) as srcPath, \


Line 32: class DirectFileTests(TestCaseBase):
Line 33: 
Line 34: DATA = "a" * 512 + "b" * 512
Line 35: 
Line 36: @permutations([[0], [512], [1024], [1024 + 512]])
> perhaps the permutations could be a number of blocks.
Will update in next patch
Line 37: def testRead(self, size):
Line 38: with temporaryPath(data=self.DATA) as srcPath, \
Line 39: fileUtils.open_ex(srcPath, "dr") as f:
Line 40: self.assertEquals(f.read(size), self.DATA[:size])


Line 38: with temporaryPath(data=self.DATA) as srcPath, \
Line 39: fileUtils.open_ex(srcPath, "dr") as f:
Line 40: self.assertEquals(f.read(size), self.DATA[:size])
Line 41: 
Line 42: @permutations([[512], [1024]])
> same.
OK
Line 43: def testSeekRead(self, offset):
Line 44: with temporaryPath(data=self.DATA) as srcPath, \
Line 45: fileUtils.open_ex(srcPath, "dr") as f:
Line 46: f.seek(offset)


Line 55: def testSmallWrites(self):
Line 56: with temporaryPath() as srcPath, \
Line 57: fileUtils.open_ex(srcPath, "dw") as f:
Line 58: f.write(self.DATA[:512])
Line 59: f.write(self.DATA[512:])
> Use the constant.
Will use after adding it.
Line 60: 
Line 61: with fileUtils.open_ex(srcPath, "r") as f:
Line 62: self.assertEquals(f.read(), self.DATA)
Line 63: 


Line 63: 
Line 64: def testUpdateRead(self):
Line 65: with temporaryPath() as srcPath, \
Line 66: fileUtils.open_ex(srcPath, "wd") as f:
Line 67: f.write(self.DATA[:512])
> same.
In the next patch
Line 68: 
Line 69: with fileUtils.open_ex(srcPath, "r+d") as f:
Line 70: f.seek(512)
Line 71: f.write(self.DATA[512:])


Line 67: f.write(self.DATA[:512])
Line 68: 
Line 69: with fileUtils.open_ex(srcPath, "r+d") as f:
Line 70: f.seek(512)
Line 71: f.write(self.DATA[512:])
> same.
In the next patch
Line 72: 
Line 73: with fileUtils.open_ex(srcPath, "r") as f:
Line 74: self.assertEquals(f.read(), self.DATA)
Line 75: 


-- 
To view, visit https://gerrit.ovirt.org/54678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic86b0fe22d5d5f1c9252b658ad76a13626de8246
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: conf: proper locking in onConnect()

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: conf: proper locking in onConnect()
..

vm: conf: proper locking in onConnect()

Change-Id: I5f75630e204708bb4352f68240550b2b454806cc
Bug-Url: https://bugzilla.redhat.com/1318550
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/54907/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 956c8c3..955b8ad 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -845,7 +845,8 @@
 
 def onConnect(self, clientIp='', clientPort=''):
 if clientIp:
-self.conf['clientIp'] = clientIp
+with self._confLock:
+self.conf['clientIp'] = clientIp
 self._clientPort = clientPort
 
 def _timedDesktopLock(self):


-- 
To view, visit https://gerrit.ovirt.org/54907
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f75630e204708bb4352f68240550b2b454806cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add DynamicThrottling semaphores

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: Add DynamicThrottling semaphores
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: devices: drop support for ancient Engines

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: devices: drop support for ancient Engines
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49173
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9acd500670a2ace449cc50ac99bf94f58f165b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra 
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If008e061bdef9851ff9e71942d05bc5bd6861c10
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: introduction of schema

[fromani]

Francesco Romani has posted comments on this change.

Change subject: events: introduction of schema
..


Patch Set 1:

at first glance schema looks good. Will do proper review later.

-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
..


Patch Set 11: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/53679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81a0da783bc40f0f08dfdac2bbb955bc55d81b0e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: decode XML string when parsing devices

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: decode XML string when parsing devices
..


Patch Set 1: Code-Review+1

seems OK, but not completely sure swallowing errors is a good idea.
While I clear my thoughts, partial ACK.

-- 
To view, visit https://gerrit.ovirt.org/54802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
..


virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm

This is just a simple move of code, following the Sound device example,
with additional update of a test and one TODO comment.

Change-Id: I1aff4f57905d0f2d1ee60a2ed963c843feee4540
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/53619
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M tests/deviceTests.py
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/graphics.py
3 files changed, 33 insertions(+), 39 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/53619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1aff4f57905d0f2d1ee60a2ed963c843feee4540
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Remove unused code

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: Remove unused code
..


tests: Remove unused code

Remove class method from the DirectFile tests that nobody uses.

Change-Id: I4f9532f049910b5d4121d9b15319cc9bca061f57
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/54677
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
---
M tests/fileUtilTests.py
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/54677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f9532f049910b5d4121d9b15319cc9bca061f57
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 1: Code-Review-1

(1 comment)

-1 for visibility

https://gerrit.ovirt.org/#/c/54937/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-03-18 15:04:12 +0100
Line 4: Commit: Martin Polednik 
Line 5: CommitDate: 2016-03-18 15:25:56 +0100
Line 6: 
Line 7: hostdev/sr-iov: don't reattach devices
same comment as per patch 54936: please explain why this is important
Line 8: 
Line 9: Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266


-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: use the new response handling

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: use the new response handling
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 6:

Heh, I see you just did that :-)

-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for hotplug

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: add support for hotplug
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

[automation]

gerrit-hooks has posted comments on this change.

Change subject: exception: Add exceptions for vdsm.define errors
..


Patch Set 20:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: hook: add imagerepo feed containers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: hook: add imagerepo feed containers
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94ae3b82150981c76a6079d5741aeca8faa1dd33
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Run unit tests using travis-ci and docker
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: let nose produce an xunit xml format.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: let nose produce an xunit xml format.
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/45698
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa8702c58d35529898462b754fb828fdbf9b0f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..


Patch Set 6:

* #1260428::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/45774
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/45774
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I3c30439b5b84f64fd2ad69d82f33dfdfc4c9ef68
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Update v2v to use new jobs infrastructure

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Update v2v to use new jobs infrastructure
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/45382
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9118e0fe4aaeceab2109afa393dd45fbd97e070f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Update v2v to use new jobs infrastructure

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: Update v2v to use new jobs infrastructure
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/45382
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9118e0fe4aaeceab2109afa393dd45fbd97e070f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: let nose produce an xunit xml format.

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: tests: let nose produce an xunit xml format.
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/45698
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I7aa8702c58d35529898462b754fb828fdbf9b0f8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[alitke]

Adam Litke has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 22:

(2 comments)

I think this is good enough to aid in our transition to yaml.  Just a few  
comments/questions.

https://gerrit.ovirt.org/#/c/52864/22/contrib/schema-converter
File contrib/schema-converter:

Line 170: return maps
Line 171: 
Line 172: 
Line 173: def convert_unions(symbol):
Line 174: # need to fix description
what's wrong with the description?
Line 175: unions = {}
Line 176: for content in symbol.values():
Line 177: if 'union' not in content.keys():
Line 178: continue


https://gerrit.ovirt.org/#/c/52864/22/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:

Line 87
Line 88
Line 89
Line 90
Line 91
Why is this change needed?


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
..


Patch Set 12:

Some test code added to better cover the moved code.

-- 
To view, visit https://gerrit.ovirt.org/53620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Vm: conf: proper locking in the creation path

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: Vm: conf: proper locking in the creation path
..

Vm: conf: proper locking in the creation path

Change-Id: I9b754690a41cdc1e1303ddd4c792df5916570872
Bug-Url: https://bugzilla.redhat.com/1318550
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/54909/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7003808..183c6c7 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1839,7 +1839,8 @@
 self.cont()
 
 if not self.recovering or 'pid' not in self.conf:
-self.conf['pid'] = str(self._getPid())
+with self._confLock:
+self.conf['pid'] = str(self._getPid())
 
 nice = int(self.conf.get('nice', '0'))
 nice = max(min(nice, 19), 0)
@@ -1970,7 +1971,8 @@
 for dev in devices.values():
 newDevices.extend(dev)
 
-self.conf['devices'] = newDevices
+with self._confLock:
+self.conf['devices'] = newDevices
 
 def _correctDiskVolumes(self, srcDomXML):
 """


-- 
To view, visit https://gerrit.ovirt.org/54909
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b754690a41cdc1e1303ddd4c792df5916570872
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: bump libguestfs-tools-c requirement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: bump libguestfs-tools-c requirement
..


Patch Set 3:

* #1292096::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1292096::OK, public bug
* Check Product::#1292096::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc245f04473ea5e2d40e622cc4622a8b4cbb2f84
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/54664/7/lib/vdsm/virt/api.py
File lib/vdsm/virt/api.py:

Line 45: 
Line 46: _log.debug("FINISH %s response=%s", func.__name__, ret)
Line 47: 
Line 48: if isinstance(ret, dict):
Line 49: return response.success(**ret)
maybe add a debug log to document that the return value is discarded?
Line 50: return response.success()
Line 51: 


-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm
..


Patch Set 12: Verified+1

Verified by running a VM from Engine, migrating it to another host and back, 
and stopping it.

-- 
To view, visit https://gerrit.ovirt.org/53618
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cdb648a25b26001d8251abb2c53d3317b60a302
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: use the new response handling

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: use the new response handling
..


Patch Set 1:

The idea is that once the infrastructure (see patch 54664) is solid and in 
place, we could convert one flow at time when need arises and/or when we (virt 
team) have capacity.

This new handling of exception should be opt-in, the old code path should work 
as usual.

Of course we'd like to convert all the virt flows ASAP, it's "only" a matter of 
capacity. So any help would be appreciated :)

-- 
To view, visit https://gerrit.ovirt.org/54799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib594a5cc6cd8945c24cfcb3704ad92d02102993b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: api: Mandate force param in createVG

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: api: Mandate force param in createVG
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54899
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56deb0ffa0f3051464868ebeacfe7080aa292c34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: conf: proper locking in onConnect()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: conf: proper locking in onConnect()
..


Patch Set 1:

* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
* Check Product::#1318550::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54907
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f75630e204708bb4352f68240550b2b454806cc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: guest-agent: Fix API version negotiation

[vfeenstr]

Vinzenz Feenstra has posted comments on this change.

Change subject: guest-agent: Fix API version negotiation
..


Patch Set 1:

Same as master

-- 
To view, visit https://gerrit.ovirt.org/54896
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5dd8a36395615d4b908a0c88a6bbfee3cab1952
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 6:

Lets split this to infrastructure patch (with tests), and patch using this 
infrastructure, which probably should include entire vm.py.

-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: HACK: hook: add imagerepo feed containers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: HACK: hook: add imagerepo feed containers
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94ae3b82150981c76a6079d5741aeca8faa1dd33
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..

storage: Remove legacy get[Iso|Floppy]List

The legacy getIsoList and getFloppyList verbs are only used in DCs of
compatibility version 3.3 or older, while newer DCs use the
getFileStats verb. Since these old DC levels are no longer supported
by VDSM, these verbs can safely be removed.

Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Signed-off-by: Allon Mureinik 
---
M client/vdsClient.py
M lib/api/vdsmapi-schema.json
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/rpc/bindingxmlrpc.py
M lib/vdsm/storage/exception.py
M vdsm/API.py
M vdsm/storage/hsm.py
7 files changed, 0 insertions(+), 134 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/54900/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index d86b7138..4e182c6 100755
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1220,26 +1220,6 @@
 
 return 0, ''
 
-def getIsoList(self, args):
-spUUID = args[0]
-isos = self.s.getIsoList(spUUID)
-if isos['status']['code']:
-return isos['status']['code'], isos['status']['message']
-
-print('-- ISO list with proper permissions only ---')
-for entry in isos['isolist']:
-print(entry)
-return 0, ''
-
-def getFloppyList(self, args):
-spUUID = args[0]
-floppies = self.s.getFloppyList(spUUID)
-if floppies['status']['code']:
-return floppies['status']['code'], floppies['status']['message']
-for entry in floppies['isolist']:
-print(entry)
-return 0, ''
-
 def getImagesList(self, args):
 sdUUID = args[0]
 images = self.s.getImagesList(sdUUID)
@@ -2563,14 +2543,6 @@
  (' [pattern][caseSensitive]',
   'Returns files statistics from ISO domain'
   )),
-'getIsoList': (serv.getIsoList,
-   ('',
-'Returns list of all .iso images in ISO domain'
-)),
-'getFloppyList': (serv.getFloppyList,
-  ('',
-   'Returns list of all .vfd images in ISO domain'
-   )),
 'getImagesList': (serv.getImagesList,
   ('',
'Get list of all images of specific domain'
diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index da58cc3..84f8832 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -6127,22 +6127,6 @@
  'returns': ['UUID']}
 
 ##
-# @StoragePool.getFloppyList:
-#
-# Get a list of all floppy disk images associated with a Storage Pool.
-#
-# @storagepoolID:  The UUID of the Storage Pool
-#
-# Returns:
-# A list of floppy disk file names
-#
-# Since: 4.10.0
-##
-{'command': {'class': 'StoragePool', 'name': 'getFloppyList'},
- 'data': {'storagepoolID': 'UUID'},
- 'returns': ['str']}
-
-##
 # @StoragePool.getDomainsContainingImage:
 #
 # Get a list of Data Storage Domains that contain an Image.
@@ -6159,25 +6143,6 @@
 {'command': {'class': 'StoragePool', 'name': 'getDomainsContainingImage'},
  'data': {'storagepoolID': 'UUID', 'imageID': 'UUID'},
  'returns': ['UUID']}
-
-##
-# @StoragePool.getIsoList:
-#
-# Get a list of all ISO images associated with a Storage Pool.
-#
-# @storagepoolID:  The UUID of the Storage Pool
-#
-# @filenameExtension:  #optional Specify an alternate file extension (the
-#  default extension used is 'iso')
-#
-# Returns:
-# A list of available files
-#
-# Since: 4.10.0
-##
-{'command': {'class': 'StoragePool', 'name': 'getIsoList'},
- 'data': {'storagepoolID': 'UUID', '*filenameExtension': 'str'},
- 'returns': ['str']}
 
 ##
 # @StoragePool.getSpmStatus:
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 67d259f..d1880d1 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -447,9 +447,7 @@
 'StoragePool_getBackedUpVmsInfo': {'ret': 'vmlist'},
 'StoragePool_getBackedUpVmsList': {'ret': 'vmlist'},
 'StoragePool_getDomainsContainingImage': {'ret': 'domainslist'},
-'StoragePool_getFloppyList': {'ret': 'isolist'},
 'StoragePool_getInfo': {'ret': StoragePool_getInfo_Ret},
-'StoragePool_getIsoList': {'ret': 'isolist'},
 'StoragePool_getSpmStatus': {'ret': 'spm_st'},
 'StoragePool_spmStart': {'ret': 'uuid'},
 'StoragePool_upgrade': {'ret': 'upgradeStatus'},
diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py
index 10eca62..2d80a2d 100644
--- a/lib/vdsm/rpc/bindingxmlrpc.py
+++ b/lib/vdsm/rpc/bindingxmlrpc.py
@@ -815,17 +815,9 @@
 pool = API.StoragePool(spUUID)
 return pool.getBackedUpVmsList(sdUUID)
 
-def poolGetFloppyList(self, spUUID, options=None):
-

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

[fromani]

Francesco Romani has posted comments on this change.

Change subject: exception: Add exceptions for vdsm.define errors
..


Patch Set 20: Verified+1

v20 avoids to duplicate the define.py comments in exception.py
Verified running the new test and 'make check' (by yours truly and Jenkins)

-- 
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net tests: IPv6 autoconf with RA server

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: IPv6 autoconf with RA server
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54668
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c153adf7d27db0151a330f55719622a8f730a9b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
..


virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm

This is somewhat similar to other devices but has its specifics.  We put
the resulting function into a newly created source file as it doesn't
belong to supported devices.  The content of
Vm._getUnderlyingVmDevicesInfo() will be put into the same file in a
followup patch.

Change-Id: I50d160317f91db92bb6a8ae22a45d9574d1434b3
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/53678
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/Makefile.am
M vdsm/virt/vmdevices/__init__.py
A vdsm/virt/vmdevices/common.py
6 files changed, 62 insertions(+), 33 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/53678
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50d160317f91db92bb6a8ae22a45d9574d1434b3
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
..


Patch Set 12: Code-Review+1

waiting for Martin's ACK.

-- 
To view, visit https://gerrit.ovirt.org/53620
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I789d7d2349fc24b48e52260de98fb3d66b168bf7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: abstact rollback handler as netswitch.RollbackManager

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: abstact rollback handler as netswitch.RollbackManager
..

net: abstact rollback handler as netswitch.RollbackManager

In order to reuse current rollback implementation with future Switches,
we extracted RollbackIncomplete and context manager outside legacy
configurators.

Change-Id: I01a71999649d3a37ee33818483b3a2a55db0270b
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/api.py
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/legacy_switch.py
A lib/vdsm/network/netswitch.py
M vdsm.spec.in
6 files changed, 81 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/15/54815/1

diff --git a/lib/vdsm/network/Makefile.am b/lib/vdsm/network/Makefile.am
index 11b76cd..4ea4f0f 100644
--- a/lib/vdsm/network/Makefile.am
+++ b/lib/vdsm/network/Makefile.am
@@ -29,6 +29,7 @@
canonicalize.py \
legacy_switch.py \
models.py \
+   netswitch.py \
sourceroute.py \
sourceroutethread.py \
utils.py \
diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index 74557fa..c41606a 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -254,7 +254,7 @@
 logging.debug('Applying...')
 in_rollback = options.get('_inRollback', False)
 with _rollback():
-with legacy_switch.ConfiguratorClass(in_rollback) as configurator:
+with legacy_switch.Manager(in_rollback) as configurator:
 # from this point forward, any exception thrown will be handled by
 # Configurator.__exit__.
 
diff --git a/lib/vdsm/network/configurators/__init__.py 
b/lib/vdsm/network/configurators/__init__.py
index 69e97e7..38379f3 100644
--- a/lib/vdsm/network/configurators/__init__.py
+++ b/lib/vdsm/network/configurators/__init__.py
@@ -22,7 +22,6 @@
 from six.moves import configparser
 
 from vdsm.config import config
-from vdsm.netconfpersistence import RunningConfig
 from vdsm import ipwrapper
 from vdsm.netinfo import mtus
 from vdsm.netlink import monitor
@@ -32,6 +31,7 @@
 from . import qos
 from ..models import Bond, Bridge, hierarchy_vlan_tag, hierarchy_backing_device
 from ..sourceroute import StaticSourceRoute
+from .. import netswitch
 
 
 class RollbackIncomplete(Exception):
@@ -43,38 +43,11 @@
 pass
 
 
-class Configurator(object):
+class Configurator(netswitch.RollbackManager):
 def __init__(self, configApplier, inRollback=False):
 self.configApplier = configApplier
-self._inRollback = inRollback
 self._libvirtAdded = set()
-
-def __enter__(self):
-self.begin()
-return self
-
-def __exit__(self, type, value, traceback):
-if type is None:
-self.commit()
-elif self._inRollback:
-# If we failed the rollback transaction, the networking system
-# is in no good state and we fail hard
-logging.error('Failed rollback transaction last known good '
-  'network.', exc_info=(type, value, traceback))
-else:
-leftover = self.rollback()
-if leftover:
-raise RollbackIncomplete(leftover, type, value)
-
-def rollback(self):
-"""
-returns None when all the nets were successfully rolled back, a
-vdsm.netoconfpersistence.Config object with the not yet rolled back
-networks and bonds.
-"""
-# self.runningConfig will have all the changes that were applied before
-# we needed to rollback.
-return RunningConfig().diffFrom(self.runningConfig)
+super(Configurator, self).__init__(inRollback)
 
 def configureBridge(self, bridge, **opts):
 raise NotImplementedError
diff --git a/lib/vdsm/network/legacy_switch.py 
b/lib/vdsm/network/legacy_switch.py
index 2f5a696..18c1b37 100644
--- a/lib/vdsm/network/legacy_switch.py
+++ b/lib/vdsm/network/legacy_switch.py
@@ -77,7 +77,7 @@
 
 
 _persistence = _get_persistence_module()
-ConfiguratorClass = _get_configurator_class()
+Manager = _get_configurator_class()
 
 
 def _objectivize_network(bridge=None, vlan=None, vlan_id=None, bonding=None,
@@ -116,7 +116,7 @@
 :returns: the top object of the hierarchy.
 """
 if configurator is None:
-configurator = ConfiguratorClass()
+configurator = Manager()
 if _netinfo is None:
 _netinfo = CachingNetInfo()
 if opts is None:
diff --git a/lib/vdsm/network/netswitch.py b/lib/vdsm/network/netswitch.py
new file mode 100644
index 000..bb75fec
--- /dev/null
+++ b/lib/vdsm/network/netswitch.py
@@ -0,0 +1,73 @@
+# TODO: define interface of configurators here, init config bude dedit todle
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU 

Change in vdsm[master]: directio: Port to Python 3

[alitke]

Adam Litke has posted comments on this change.

Change subject: directio: Port to Python 3
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54699/2/tests/Makefile.am
File tests/Makefile.am:

Line 38:permutationTests.py \
Line 39:pthreadTests.py \
Line 40:responseTests.py \
Line 41:scheduleTests.py \
Line 42:storage_directio_test.py \
Should be in an earlier patch which added this test.
Line 43:vmStatsTests.py \
Line 44:$(NULL)
Line 45: 
Line 46: device_modules = \


-- 
To view, visit https://gerrit.ovirt.org/54699
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad6f317df3efc70adb95063227c5e07513d34135
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotplugDisk: Handle prepareVolumePath errors gracefully.

[aaviram]

Amit Aviram has abandoned this change.

Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..


Abandoned

Common error catching is being implemented, see: 
https://gerrit.ovirt.org/#/c/54664/

-- 
To view, visit https://gerrit.ovirt.org/54266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic049f388eb25127864edf5931ddb3b21b67f2dff
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm
..


Patch Set 12: Code-Review+2

raising score after approval from network devs.

-- 
To view, visit https://gerrit.ovirt.org/53621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d627a50c1ed52c584a834fb2f9066ac1ab6ac68
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [3], ip handling

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [3], ip handling
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54930
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie562fa5fb53c69fec85c8b368dbb5479d13dd473
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: data verification

[alitke]

Adam Litke has posted comments on this change.

Change subject: bridge: data verification
..


Patch Set 10:

(6 comments)

https://gerrit.ovirt.org/#/c/53919/10/lib/api/schemaapi.py
File lib/api/schemaapi.py:

Line 111: self._report_inconsistency('Parameter %s is not %s type'
Line 112:% (name, t))
Line 113: 
Line 114: def _report_inconsistency(self, message):
Line 115: if config.getboolean('devel', 'strict_mode'):
Get this value only once and cache it here in the module since it won't change.
Line 116: raise yajsonrpc.JsonRpcInvalidParamsError(message)
Line 117: else:
Line 118: self.log.warning(message)
Line 119: 


Line 178: for a in arg:
Line 179: self._verify_type(t[0], a, class_name, 
method_name)
Line 180: else:
Line 181: self._verify_ctype(t.get('type'), t, arg, name, 
class_name,
Line 182:method_name)
The above cases each need a comment to explain what they are for.
Line 183: 
Line 184: def _verify_ctype(self, t_type, t, arg, name, class_name, 
method_name):
Line 185: if t_type == 'alias':
Line 186: self._check_primitive_type(t.get('sourcetype'), arg, name)


Line 180: else:
Line 181: self._verify_ctype(t.get('type'), t, arg, name, 
class_name,
Line 182:method_name)
Line 183: 
Line 184: def _verify_ctype(self, t_type, t, arg, name, class_name, 
method_name):
_verify_complex_type would be a better name.
Line 185: if t_type == 'alias':
Line 186: self._check_primitive_type(t.get('sourcetype'), arg, name)
Line 187: elif t_type == 'map':
Line 188: for key, value in arg.iteritems():


Line 193: elif t_type == 'union':
Line 194: for value in t.get('values'):
Line 195: props = value.get('properties')
Line 196: prop_names = [prop.get('name') for prop in props]
Line 197: if not [key for key in arg.keys() if key not in 
prop_names]:
This is all getting complex.  Please add some comments here.
Line 198: self._verify_ctype(value.get('type'), value, arg, 
name,
Line 199:class_name, method_name)
Line 200: return
Line 201: self._report_inconsistency('Provided parameters %s do not 
match'


Line 241: continue
Line 242: 
Line 243: self._verify_type(prop, a, class_name, method_name)
Line 244: 
Line 245: def verify_ret_params(self, class_name, method_name, ret):
rename to verify_retval
Line 246: try:
Line 247: ret_args = self.get_ret_param(class_name, method_name)
Line 248: 
Line 249: if ret_args:


https://gerrit.ovirt.org/#/c/53919/10/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 440: ('health_check_interval', '60',
Line 441: 'Number of seconds to wait between health checks.'),
Line 442: 
Line 443: ('strict_mode', 'false',
Line 444: 'Enable exception throwing when rpc data is not 
correct.'),
value should be something like 'api-strict-mode' or 'rpc-strict-mode'
Line 445: 
Line 446: ]),
Line 447: 
Line 448: # Section: [gluster]


-- 
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: api: remove unused methods

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: api: remove unused methods
..


Patch Set 5: Verified+1

Rebase only, no code changes. Verified by running local build.

-- 
To view, visit https://gerrit.ovirt.org/53673
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa97a687aad51e319eceffd9f82bc863a28e6bb8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: move sourcerouting_test to tests/net where it belongs

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: tests: move sourcerouting_test to tests/net where it belongs
..

tests: move sourcerouting_test to tests/net where it belongs

Change-Id: I1caeaec31f4dfe2717a6cc3fded5fc937a909e25
Signed-off-by: Dan Kenigsberg 
---
M debian/vdsm-tests.install
M tests/Makefile.am
M tests/network/Makefile.am
R tests/network/ip_route_show_table_all.out
R tests/network/sourcerouting_test.py
M vdsm.spec.in
6 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/54923/1

diff --git a/debian/vdsm-tests.install b/debian/vdsm-tests.install
index 95579bd..6c810c3 100644
--- a/debian/vdsm-tests.install
+++ b/debian/vdsm-tests.install
@@ -25,6 +25,7 @@
 usr/share/vdsm/tests/lvs_3386c6f2-926f-42c4-839c-38287fac8998.out
 usr/share/vdsm/tests/mem_info.out
 usr/share/vdsm/tests/network/*.py
+usr/share/vdsm/tests/network/ip_route_show_table_all.out
 usr/share/vdsm/tests/network/netmaskconversions
 usr/share/vdsm/tests/network/tc_filter_show.out
 usr/share/vdsm/tests/run_tests.sh
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 7446760..b337a4d 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -112,7 +112,6 @@
schemaValidationTest.py \
sdm_indirection_tests.py \
securableTests.py \
-   sourceroutingTests.py \
sparsifyTests.py \
sslTests.py \
stompAdapterTests.py \
@@ -201,7 +200,6 @@
glusterVolumeRebalanceStatus.xml \
glusterVolumeRemoveBricksStatus.xml \
glusterVolumeTasks.xml \
-   ip_route_show_table_all.out \
iscsiadm_-m_iface.out \
lvs_3386c6f2-926f-42c4-839c-38287fac8998.out \
mem_info.out \
diff --git a/tests/network/Makefile.am b/tests/network/Makefile.am
index 3d3ca49..9d4f7a8 100644
--- a/tests/network/Makefile.am
+++ b/tests/network/Makefile.am
@@ -29,6 +29,7 @@
$(NULL)
 
 dist_vdsmnetworktests_DATA = \
+   ip_route_show_table_all.out \
netmaskconversions \
tc_filter_show.out \
$(NULL)
diff --git a/tests/ip_route_show_table_all.out 
b/tests/network/ip_route_show_table_all.out
similarity index 100%
rename from tests/ip_route_show_table_all.out
rename to tests/network/ip_route_show_table_all.out
diff --git a/tests/sourceroutingTests.py b/tests/network/sourcerouting_test.py
similarity index 96%
rename from tests/sourceroutingTests.py
rename to tests/network/sourcerouting_test.py
index 37bf642..179d18a 100644
--- a/tests/sourceroutingTests.py
+++ b/tests/network/sourcerouting_test.py
@@ -18,6 +18,7 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
+from __future__ import absolute_import
 import os
 
 from testlib import VdsmTestCase as TestCaseBase
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 0c982e4..34f4554 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1237,11 +1237,11 @@
 %{_datadir}/%{vdsm_name}/tests/devices/*.py*
 %{_datadir}/%{vdsm_name}/tests/devices/parsing/*.py*
 %{_datadir}/%{vdsm_name}/tests/devices/data/*.xml
-%{_datadir}/%{vdsm_name}/tests/ip_route_show_table_all.out
 %{_datadir}/%{vdsm_name}/tests/iscsiadm_-m_iface.out
 %{_datadir}/%{vdsm_name}/tests/lvs_3386c6f2-926f-42c4-839c-38287fac8998.out
 %{_datadir}/%{vdsm_name}/tests/mem_info.out
 %{_datadir}/%{vdsm_name}/tests/network/*.py*
+%{_datadir}/%{vdsm_name}/tests/network/ip_route_show_table_all.out
 %{_datadir}/%{vdsm_name}/tests/network/netmaskconversions
 %{_datadir}/%{vdsm_name}/tests/network/tc_filter_show.out
 %{_datadir}/%{vdsm_name}/tests/run_tests.sh


-- 
To view, visit https://gerrit.ovirt.org/54923
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1caeaec31f4dfe2717a6cc3fded5fc937a909e25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [2], fake bridgeless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [2], fake bridgeless
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54927
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bbf23d3864dfdf83d506a3b9885fc94eae01026
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Add create_volume job

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Add create_volume job
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/50221/12/vdsm/storage/sdm/api/base.py
File vdsm/storage/sdm/api/base.py:

Line 44: self._run()
Line 45: except Exception as e:
Line 46: self.log.exception("Job (id=%s desc=%s) failed",
Line 47:self.id, self.description)
Line 48: if not isinstance(e, utils.GeneralException):
Needs a rebase, this exceptions is in lib/vdsm/exception.py
Line 49: e = utils.GeneralException(str(e))
Line 50: self._error = e
Line 51: self._status = jobs.STATUS.FAILED
Line 52: else:


-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: Add create_block_volume

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagetests: Add create_block_volume
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e1aafd87c4fee5b3f47a63ca7b055009cd006b8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: Rename make_blocksd

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagetests: Rename make_blocksd
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54569
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: Create metadata storage area for block domains

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagetests: Create metadata storage area for block domains
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54568
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6e5306241fe730148d780e328afd8612cf8b8a3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: refactor manifest_tests fake env setup

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: refactor manifest_tests fake env setup
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50273
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74b82ffaa34d6df68e1531735cc776e4de23f95c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add test_overwrite_blocksize test

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add test_overwrite_blocksize test
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54669
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85fc8ad393aff49154d9d414bd6474a723b315f1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vered Volansky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm
..


virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm

This generally follows the Sound device example, except for additional
memSize setting in conf, an additional place where memory devices are
updated, and adding simplistic test coverage.

Change-Id: I8cdb648a25b26001d8251abb2c53d3317b60a302
Signed-off-by: Milan Zamazal 
Reviewed-on: https://gerrit.ovirt.org/53618
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M tests/devices/data/testComplexVm.xml
M tests/devices/parsing/complex_vm_tests.py
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/core.py
4 files changed, 35 insertions(+), 26 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/53618
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8cdb648a25b26001d8251abb2c53d3317b60a302
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: api: Mandate force param in createVG

[automation]

gerrit-hooks has posted comments on this change.

Change subject: api: Mandate force param in createVG
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54899
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56deb0ffa0f3051464868ebeacfe7080aa292c34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Separate storage health monitoring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Separate storage health monitoring
..


Patch Set 10:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: don't implicitly reattach devices

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: don't implicitly reattach devices
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1136292cb7e9d13a8202b1f5162299d2155e8036
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Separate storage health monitoring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Separate storage health monitoring
..


Patch Set 14:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the eventloop module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the eventloop module
..


Patch Set 9: Verified+1

Verified using the tests and with the next patch running the demo checker 
process.

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54900/2/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 532: code = 313
Line 533: message = "Storage pool not connected"
Line 534: 
Line 535: # Code 314 no longer used
Line 536: # Code 315 no longer used
> This is not very useful. How about:
Also pep8 is not happy because it likes 2 empty lines between classes and 
comments (does not make sense but we cannot fight with pep8 gods).

20:47:29 ./lib/vdsm/storage/exception.py:538:1: E302 expected 2 blank lines, 
found 1
Line 537: 
Line 538: class StoragePoolAlreadyExists(StorageException):
Line 539: code = 316
Line 540: message = "Error creating a storage pool - pool already exists"


-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 17:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: directio: Remove useless DirectFile.writelines()

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: directio: Remove useless DirectFile.writelines()
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54716
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c3e03c4d96f1862df2c5fec834cc3787145a3fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Replace magic number with constant

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Replace magic number with constant
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54954
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf89be2b776650ba189db9cca7bd1e2cfdd7b2a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Remove legacy get[Iso|Floppy]List
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54900/2/lib/vdsm/storage/exception.py
File lib/vdsm/storage/exception.py:

Line 532: code = 313
Line 533: message = "Storage pool not connected"
Line 534: 
Line 535: # Code 314 no longer used
Line 536: # Code 315 no longer used
This is not very useful. How about:

# Code 314 was used for GetIsoListError, removed in 4.18
Line 537: 
Line 538: class StoragePoolAlreadyExists(StorageException):
Line 539: code = 316
Line 540: message = "Error creating a storage pool - pool already exists"


-- 
To view, visit https://gerrit.ovirt.org/54900
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: set correct permissions for hwrng device

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/54806/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1263: self.log.exception('Could not reattach device %s 
back to host '
Line 1264:'due to missing IOMMU support.')
Line 1265: 
Line 1266: def _cleanupRngDevices(self):
Line 1267: for device in self._devices[hwclass.RNG]:
> this works
I agree with Francesco about iterating over a copy.
Line 1268: device.hwrng_fix_perm()
Line 1269: 
Line 1270: def _host_devices(self):
Line 1271: for device in self._devices[hwclass.HOSTDEV][:]:


https://gerrit.ovirt.org/#/c/54806/3/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 252: 
Line 253: def uses_source(self, source):
Line 254: return self._SOURCES[self.specParams['source']] == source
Line 255: 
Line 256: def hwrng_set_perm(self):
> consider using full-word "permission", as the partial word left me perplexe
I agree with Dan about using full words. Shortcuts are ok when we have a very 
common terms that we use everywhere (e.g. sd, dev), but this is not the case.

How about:
 
- grant_hwrng_permission()
- revoke_hwrng_permission()

I'm not sure about the names (grant, revoke), but I'm sure that the action 
should come before the object.
Line 257: supervdsm.getProxy().appropriateHwrngDevice(self.conf['vmId'])
Line 258: 
Line 259: def hwrng_fix_perm(self):
Line 260: 
supervdsm.getProxy().rmAppropriateHwrngDevice(self.conf['vmId'])


-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 6: Code-Review+1

Thanks Martin, look good, and your verification is fine.

-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: supervdsm: move udev-related functions to udev.py
..


supervdsm: move udev-related functions to udev.py

Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/54458
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Nir Soffer 
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/supervdsmServer
M vdsm/supervdsm_api/Makefile.am
A vdsm/supervdsm_api/udev.py
5 files changed, 197 insertions(+), 155 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: supervdsm: move udev-related functions to udev.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: move udev-related functions to udev.py
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8c4a5120887c2cbf13463f33fad2ef5e002e0d6
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 22:

(2 comments)

https://gerrit.ovirt.org/#/c/52864/22/contrib/schema-converter
File contrib/schema-converter:

Line 170: return maps
Line 171: 
Line 172: 
Line 173: def convert_unions(symbol):
Line 174: # need to fix description
> what's wrong with the description?
It looks like stale comment. Will remove.
Line 175: unions = {}
Line 176: for content in symbol.values():
Line 177: if 'union' not in content.keys():
Line 178: continue


https://gerrit.ovirt.org/#/c/52864/22/lib/api/vdsmapi.py
File lib/api/vdsmapi.py:

Line 87
Line 88
Line 89
Line 90
Line 91
> Why is this change needed?
Yaniv asked for py3 support so I discovered that it is not working with py3 due 
to this line.


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: native ovs [1]
..

net: native ovs [1]

Basic OVS implementation.

Change-Id: I6d18b7d3e90902d29a2fdef246972a9fb1c705f1
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/api.py
A lib/vdsm/network/ovs_switch/Makefile.am
A lib/vdsm/network/ovs_switch/__init__.py
A lib/vdsm/network/ovs_switch/libvirt.py
A lib/vdsm/network/ovs_switch/ovs.py
A lib/vdsm/network/ovs_switch/switch.py
A lib/vdsm/network/ovs_switch/validator.py
7 files changed, 353 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/54821/1

diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index 74557fa..e5c4a4f 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -33,15 +33,20 @@
 from vdsm import constants
 from vdsm import hooks
 from vdsm import netconfpersistence
+"""legacy
 from vdsm.netinfo.cache import (libvirtNets2vdsm, get as netinfo_get,
 CachingNetInfo)
 from vdsm.netinfo import networks as netinfo_networks
+"""
 from vdsm import udevadm
 from vdsm import utils
 from vdsm import ipwrapper
 
 from . canonicalize import canonicalize_networks
+"""legacy
 from . import legacy_switch
+"""
+from .ovs_switch import switch as ovs_switch
 from . import errors as ne
 from .configurators import RollbackIncomplete
 from .errors import ConfigNetworkError
@@ -243,17 +248,23 @@
 # TODO: Add canonicalize_bondings(bondings)
 
 logging.debug('Validating configuration')
+"""legacy
 legacy_switch.validate_network_setup(networks, bondings)
+"""
+ovs_switch.validate_network_setup(networks, bondings)
 
 bondings, networks, options = _apply_hook(bondings, networks, options)
 
+"""legacy
 libvirt_nets = netinfo_networks()
 _netinfo = CachingNetInfo(_netinfo=netinfo_get(
 libvirtNets2vdsm(libvirt_nets)))
+"""
 
 logging.debug('Applying...')
 in_rollback = options.get('_inRollback', False)
 with _rollback():
+"""legacy
 with legacy_switch.ConfiguratorClass(in_rollback) as configurator:
 # from this point forward, any exception thrown will be handled by
 # Configurator.__exit__.
@@ -266,6 +277,10 @@
 
 legacy_switch.add_missing_networks(configurator, networks,
bondings, _netinfo)
+"""
+with ovs_switch.OvsManager(in_rollback) as manager:
+ovs_switch.setup(networks, bondings, in_rollback,
+ manager.running_config)
 
 _check_connectivity(networks, bondings, options)
 
diff --git a/lib/vdsm/network/ovs_switch/Makefile.am 
b/lib/vdsm/network/ovs_switch/Makefile.am
new file mode 100644
index 000..ca1a4b0
--- /dev/null
+++ b/lib/vdsm/network/ovs_switch/Makefile.am
@@ -0,0 +1,28 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+include $(top_srcdir)/build-aux/Makefile.subs
+
+vdsmnetworkovsswitchdir = $(vdsmpylibdir)/network/ovs_switch
+
+dist_vdsmnetworkovsswitch_PYTHON = \
+   __init__.py \
+   ovs.py \
+   switch.py \
+   $(NULL)
diff --git a/lib/vdsm/network/ovs_switch/__init__.py 
b/lib/vdsm/network/ovs_switch/__init__.py
new file mode 100644
index 000..4a67f47
--- /dev/null
+++ b/lib/vdsm/network/ovs_switch/__init__.py
@@ -0,0 +1,19 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# 

Change in vdsm[master]: exception: Add exceptions for vdsm.define errors

[automation]

gerrit-hooks has posted comments on this change.

Change subject: exception: Add exceptions for vdsm.define errors
..


Patch Set 21:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48871
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

[edwardh]

Edward Haas has posted comments on this change.

Change subject: tests: Run unit tests using travis-ci and docker
..


Patch Set 1: Verified+1

Tested on Travis CI: https://travis-ci.org/EdDev/vdsm

-- 
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: osinfo: refactor package_versions function

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: osinfo: refactor package_versions function
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36e9a605bea5ec6b823eaca4d7669c5060122fcd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hotplugDisk: Handle prepareVolumePath errors gracefully.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotplugDisk: Handle prepareVolumePath errors gracefully.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/54266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic049f388eb25127864edf5931ddb3b21b67f2dff
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: HACK: virt: override vm type from custom property

[automation]

gerrit-hooks has posted comments on this change.

Change subject: HACK: virt: override vm type from custom property
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54872
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63b89f8791a9b0eb08100c62dcfa28d29b2321a6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: set correct permissions for hwrng device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
..


Patch Set 3:

* #1260686::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1260686::OK, public bug
* Check Product::#1260686::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: api: Mandate force param in createVG

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: api: Mandate force param in createVG
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54899/1//COMMIT_MSG
Commit Message:

Line 11: f4304e2).
Line 12: 
Line 13: As VDSM no long supports 3.0 DCs (see commit 9185d7e), there's no
Line 14: point in keeping this this parameter optional, as the engine always
Line 15: sends it.
Vdsm does not care if engine send this parameter. It is optional because you 
need to provide it only if you want to force.

I think the current api is fine and no change is needed.
Line 16: 
Line 17: Change-Id: I56deb0ffa0f3051464868ebeacfe7080aa292c34


-- 
To view, visit https://gerrit.ovirt.org/54899
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56deb0ffa0f3051464868ebeacfe7080aa292c34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Run unit tests using travis-ci and docker

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: Run unit tests using travis-ci and docker
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54856/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: tests: Run unit tests using travis-ci and docker
Line 8: 
Line 9: Integrate with travis ci to run unit tests with the help of a vdsm
Line 10: docker image.
please explain more about how this is used and which resources are needed.
Line 11: 
Line 12: Change-Id: Ia6cd647acb4c740f890e9b602783915439317880


-- 
To view, visit https://gerrit.ovirt.org/54856
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: osinfo: refactor package_versions function

[automation]

gerrit-hooks has posted comments on this change.

Change subject: osinfo: refactor package_versions function
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36e9a605bea5ec6b823eaca4d7669c5060122fcd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches