Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 22: (2 comments) https://gerrit.ovirt.org/#/c/52864/22/contrib/schema-converter File contrib/schema-converter: Line 170: return maps Line 171: Line 172: Line 173: def convert_unions(symbol): Line 174: # need to fix description > what's wrong with the description? It looks like stale comment. Will remove. Line 175: unions = {} Line 176: for content in symbol.values(): Line 177: if 'union' not in content.keys(): Line 178: continue https://gerrit.ovirt.org/#/c/52864/22/lib/api/vdsmapi.py File lib/api/vdsmapi.py: Line 87 Line 88 Line 89 Line 90 Line 91 > Why is this change needed? Yaniv asked for py3 support so I discovered that it is not working with py3 due to this line. -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
