Change in vdsm[master]: suppress for python2
Yaniv Bronhaim has posted comments on this change. Change subject: suppress for python2 .. Patch Set 11: Code-Review+1 I wonder if this compat idea is smart or not.. but might be better to have all those py3 overwriting in central place than all over the code -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Use mock module for testing
Yaniv Bronhaim has posted comments on this change. Change subject: test: Use mock module for testing .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c0af7baab7c35a2617bd60a62a0b1534e5f8894 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Build script for rhev without python3 support
Yaniv Bronhaim has posted comments on this change. Change subject: contrib: Build script for rhev without python3 support .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/55518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
gerrit-hooks has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
Yaniv Bronhaim has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Build script for rhev without python3 support
gerrit-hooks has posted comments on this change. Change subject: contrib: Build script for rhev without python3 support .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Use mock module for testing
Edward Haas has posted comments on this change. Change subject: test: Use mock module for testing .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/55342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c0af7baab7c35a2617bd60a62a0b1534e5f8894 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Handle closed stream when virt-v2v fails
gerrit-hooks has posted comments on this change. Change subject: Handle closed stream when virt-v2v fails .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Use mock module for testing
Edward Haas has posted comments on this change.
Change subject: test: Use mock module for testing
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/55342/3/tests/network/netswitch_test.py
File tests/network/netswitch_test.py:
Line 47: @mock.patch('vdsm.network.netswitch.libvirtNets2vdsm')
Line 48: @mock.patch('vdsm.network.netswitch.libvirt_nets')
Line 49: @mock.patch('vdsm.network.netswitch.legacy_switch')
Line 50: def test_setup(self, mock_switch, mock_libvirt_nets,
mock_libvirtNets2vdsm,
Line 51:mock_netinfo_get, mock_CachingNetInfo,
mock_connectivity):
> What is mock_switch and the other parameters?
These are the mocks created automatically for you.
I would not expect anything to clash, but if it does, please let me know.
I know there is even a py.test plugin that adds some minor functionality over
mock, but it does not worth depending on py.test for it.
mock.patch can be used as a context manager as well, but I found it more
convenient this way.
Line 52:
Line 53: mock_libvirt_nets.return_value = None
Line 54: mock_libvirtNets2vdsm.return_value = None
Line 55: mock_netinfo_get.return_value = None
Line 56: mock_CachingNetInfo.return_value = None
Line 57:
Line 58: netswitch.setup(self.NET_TEST, self.BOND_TEST, self.OPT_TEST,
False)
Line 59:
Line 60: mock_configurator = mock_switch.ConfiguratorClass().__enter__()
> Why do you need to call __enter__(), and where the call to __exit__()?
This is the object returned by the ConfiguratorClass contextmanager. The
'remove_networks' method is taking it as an argument in the production code, so
we check what will be returned by the mock and use it to assert the arguments
it got.
I think that there are better ways of doing this, but we need more experience
playing with mock. For now it seems to me like good enough.
Line 61: mock_switch.remove_networks.assert_called_with(self.NET_TEST,
Line 62:self.BOND_TEST,
Line 63:
mock_configurator,
Line 64:None, None)
Line 60: mock_configurator = mock_switch.ConfiguratorClass().__enter__()
Line 61: mock_switch.remove_networks.assert_called_with(self.NET_TEST,
Line 62:self.BOND_TEST,
Line 63:
mock_configurator,
Line 64:None, None)
> What if this was called several times? which call are you asserting - the f
It is called once in the production code.
If I'm not mistaken, this is the last one.
You can assert on the number of calls or even get the whole history record,
there are many options available.
https://docs.python.org/3/library/unittest.mock.html#the-mock-class
Line 65: mock_switch.bonds_setup.assert_called_with(self.BOND_TEST,
Line 66:mock_configurator,
Line 67:None,
Line 68:False)
Line 64:None, None)
Line 65: mock_switch.bonds_setup.assert_called_with(self.BOND_TEST,
Line 66:mock_configurator,
Line 67:None,
Line 68:False)
> Can you check the order of the calls? does it matter?
You can check that for the same mock (or its children), but not between
different ones (like different funcs).
That's also not recommended, it couples the test to the tested unit too much,
internal optimization in the unit should not be visible to the test, so it
won't break often.
Line 69:
mock_switch.add_missing_networks.assert_called_with(mock_configurator,
Line 70:
self.NET_TEST,
Line 71:
self.BOND_TEST,
Line 72: None)
--
To view, visit https://gerrit.ovirt.org/55342
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c0af7baab7c35a2617bd60a62a0b1534e5f8894
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
_
Change in vdsm[master]: contrib: Build script for rhev without python3 support
gerrit-hooks has posted comments on this change. Change subject: contrib: Build script for rhev without python3 support .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Build without supporting python3 by using
--disable-python3-support
..
Build without supporting python3 by using --disable-python3-support
Over some environments we still don't have all required packages for python3.
Therefore VDSM build should support build process without python3
dependencies. Using --disable-python3-support configure flag will build
vdsm without using python3.
Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0
Signed-off-by: Yaniv Bronhaim
---
M Makefile.am
M configure.ac
M tests/Makefile.am
M vdsm.spec.in
4 files changed, 29 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/55517/1
diff --git a/Makefile.am b/Makefile.am
index 8b7422a..e880dbf 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -118,9 +118,13 @@
.PHONY: python3
python3: all
- PYTHONDONTWRITEBYTECODE=1 $(PYTHON3) -m compileall \
- $(WHITELIST) \
- `find . -name '*.py'`;
+ if [ -x "$(PYTHON3)" ]; then \
+PYTHONDONTWRITEBYTECODE=1 $(PYTHON3) -m compileall \
+ $(WHITELIST) \
+ `find . -name '*.py'`; \
+ else \
+ echo "Warning: skipping python3 syntax check"; \
+ fi
# Note: dependencies ordered by time needed to run them
check-recursive: gitignore abs_imports python3 pyflakes pep8
diff --git a/configure.ac b/configure.ac
index 3307507..b2bd1d5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -70,6 +70,19 @@
AC_SUBST([VHOSTMD], ['0']))
AC_ARG_ENABLE(
+[python3_support],
+[AS_HELP_STRING(
+[--disable-python3-support],
+[disable build for python3 @<:@default=no@:>@]
+)],
+[disable_python3_support="no"]
+)
+AS_IF([test "${disable_python3_support}" = "yes"],
+ AC_SUBST([PYTHON3_SUPPORT], ['0']),
+ AC_SUBST([PYTHON3_SUPPORT], ['1']))
+
+
+AC_ARG_ENABLE(
[gluster-mgmt],
[AS_HELP_STRING(
[--enable-gluster-mgmt],
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 3feb093..a490095 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -256,5 +256,7 @@
@echo '*** into your environment. Do not submit untested code!***'
$(top_srcdir)/tests/run_tests_local.sh $(args) crossImportsTests.py
$(top_srcdir)/tests/run_tests_local.sh $(args) $(run_modules)
- PYTHON_EXE="$(PYTHON3)" $(top_srcdir)/tests/run_tests_local.sh \
- $(test_modules_py3);
+ if [ -x "$(PYTHON3)" ]; then \
+ PYTHON_EXE="$(PYTHON3)" $(top_srcdir)/tests/run_tests_local.sh \
+ $(test_modules_py3); \
+ fi
diff --git a/vdsm.spec.in b/vdsm.spec.in
index fecbf5d..8fd66d6 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -14,6 +14,7 @@
%global with_gluster_mgmt @GLUSTER_MGMT@
%global with_hooks @HOOKS@
%global with_vhostmd @VHOSTMD@
+%global support_python3 @PYTHON3_SUPPORT@
# Glusterfs package version
%global gluster_version 3.7.1
@@ -81,13 +82,15 @@
BuildRequires: rpm-python
BuildRequires: python-blivet
+%if 0%{?support_python3}
%if 0%{?rhel}
BuildRequires: python34-nose
BuildRequires: python34-six
-%else
+%else # fedora
BuildRequires: python3-nose
BuildRequires: python3-six
-%endif
+%endif # rhel
+%endif # support python3
# Autotools BuildRequires
%if 0%{?enable_autotools}
--
To view, visit https://gerrit.ovirt.org/55517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: Build script for rhev without python3 support
Yaniv Bronhaim has uploaded a new change for review. Change subject: contrib: Build script for rhev without python3 support .. contrib: Build script for rhev without python3 support Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Signed-off-by: Yaniv Bronhaim --- M contrib/rhev_build.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/55518/1 diff --git a/contrib/rhev_build.sh b/contrib/rhev_build.sh index a41af7c..45fc55e 100755 --- a/contrib/rhev_build.sh +++ b/contrib/rhev_build.sh @@ -9,7 +9,8 @@ --with-qemu-kvm='qemu-kvm-rhev' \ --with-qemu-img='qemu-img-rhev' \ --enable-hooks \ ---disable-gluster-mgmt +--disable-gluster-mgmt \ + --disable-python3-support make dist echo -- To view, visit https://gerrit.ovirt.org/55518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I74679960e82b95bfd1d5939b01855a49571cb919 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3-...
gerrit-hooks has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3-support .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
Idan Shaby has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55180/2/tests/mountTests.py File tests/mountTests.py: Line 305: with fake_mounts(["server:/path " Line 306: "/rhev/data-center/mnt/server:_path " Line 307: "nfs4 defaults 0 0"]): Line 308: self.assertTrue(mount.isMounted( Line 309: "/rhev/data-center/mnt/server:_path")) > Same, use b"..." Why also here? We are not writing this string to a file. Line 310: Line 311: def test_is_not_mounted(self): Line 312: with fake_mounts(["server:/path " Line 313: "/rhev/data-center/mnt/server:_path " -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Use mock module for testing
gerrit-hooks has posted comments on this change. Change subject: test: Use mock module for testing .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c0af7baab7c35a2617bd60a62a0b1534e5f8894 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: remove duplicate code of transformPath
Freddy Rolland has posted comments on this change. Change subject: storage: remove duplicate code of transformPath .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1841a0a0c53f6c80bfcd182ddf34e6995469bb4c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: commands: import StringIO when AsyncProc is started
gerrit-hooks has posted comments on this change. Change subject: commands: import StringIO when AsyncProc is started .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
Jenkins CI has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 3: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 2 -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: allow root-requiring network caps
Dan Kenigsberg has posted comments on this change. Change subject: caps: allow root-requiring network caps .. Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduce VolumeArtifacts
gerrit-hooks has posted comments on this change. Change subject: Introduce VolumeArtifacts .. Patch Set 26: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduce VolumeArtifacts
Adam Litke has posted comments on this change. Change subject: Introduce VolumeArtifacts .. Patch Set 25: (22 comments) https://gerrit.ovirt.org/#/c/48097/25/debian/vdsm.install File debian/vdsm.install: Line 111: ./usr/share/vdsm/storage/sd.py Line 112: ./usr/share/vdsm/storage/sdc.py Line 113: ./usr/share/vdsm/storage/sdm/__init__.py Line 114: ./usr/share/vdsm/storage/sdm/volume_artifacts.py Line 115: ./usr/share/vdsm/storage/securable.py > I this related? looks like bad merge. Done Line 116: ./usr/share/vdsm/storage/sp.py Line 117: ./usr/share/vdsm/storage/spbackends.py Line 118: ./usr/share/vdsm/storage/storageServer.py Line 119: ./usr/share/vdsm/storage/storage_mailbox.py https://gerrit.ovirt.org/#/c/48097/25/lib/vdsm/storage/exception.py File lib/vdsm/storage/exception.py: Line 1774: Line 1775: Line 1776: # Line 1777: # SDM Errors Line 1778: # Range: 909-? > 910 Done Line 1779: # Line 1780: Line 1781: class DomainHasGarbage(StorageException): Line 1782: code = 910 https://gerrit.ovirt.org/#/c/48097/25/tests/Makefile.am File tests/Makefile.am: Line 144: vmTests.py \ Line 145: vmTestsData.py \ Line 146: vmUtilsTests.py \ Line 147: vmXmlTests.py \ Line 148: volume_artifacts_test.py \ > Lets start adding storage_ prefix to our tests. Done Line 149: v2vTests.py \ Line 150: $(NULL) Line 151: Line 152: nodist_vdsmtests_PYTHON = \ https://gerrit.ovirt.org/#/c/48097/23/tests/volume_artifacts_test.py File tests/volume_artifacts_test.py: Line 68: self.assertFalse(artifacts.is_image()) Line 69: self.validate_artifacts(artifacts) Line 70: Line 71: def test_state_garbage_create(self): Line 72: with self.fake_env() as env: > is_image()? Done Line 73: artifacts = get_artifacts(env, self.img_id, self.vol_id) Line 74: artifacts.create(*BASE_RAW_PARAMS) Line 75: self.assertRaises(se.DomainHasGarbage, artifacts.create, Line 76: *BASE_RAW_PARAMS) https://gerrit.ovirt.org/#/c/48097/25/tests/volume_artifacts_test.py File tests/volume_artifacts_test.py: Line 28: Line 29: from storage import fileVolume, image, sd, volume Line 30: Line 31: Line 32: class ValidationError(Exception): > We don't need this, we should raise AssertionError for test failures. Raisi Done Line 33: pass Line 34: Line 35: Line 36: class ExpectedFailure(Exception): Line 36: class ExpectedFailure(Exception): Line 37: pass Line 38: Line 39: Line 40: BASE_RAW_PARAMS = (1073741824, volume.RAW_FORMAT, image.SYSTEM_DISK_TYPE, '') > Lets add a non-empty description (.e.g "raw volume") to make this more clea Done Line 41: BASE_COW_PARAMS = (1073741824, volume.COW_FORMAT, image.SYSTEM_DISK_TYPE, '') Line 42: Line 43: Line 44: def get_artifacts(env, img_id, vol_id): Line 42: Line 43: Line 44: def get_artifacts(env, img_id, vol_id): Line 45: artifacts_class = env.sd_manifest.get_volume_artifacts_class() Line 46: return artifacts_class(env.sd_manifest, img_id, vol_id) > This looks like useful method for StorageDomainManifest - why do we return Done Line 47: Line 48: Line 49: class VolumeArtifactsTestsMixin(object): Line 50: Line 57: artifacts = get_artifacts(env, self.img_id, self.vol_id) Line 58: self.assertFalse(artifacts.is_garbage()) Line 59: self.assertFalse(artifacts.is_image()) Line 60: self.assertRaises(ValidationError, Line 61: self.validate_artifacts, artifacts) > Can we simply assert inside validate_artifacts? Is there a reason to raise Done Line 62: Line 63: def test_state_garbage_volatile_image_dir(self): Line 64: with self.fake_env() as env: Line 65: artifacts = get_artifacts(env, self.img_id, self.vol_id) Line 67: self.assertTrue(artifacts.is_garbage()) Line 68: self.assertFalse(artifacts.is_image()) Line 69: self.validate_artifacts(artifacts) Line 70: Line 71: def test_state_garbage_create(self): > test_state_garbage_create_raises? Done Line 72: with self.fake_env() as env: Line 73: artifacts = get_artifacts(env, self.img_id, self.vol_id) Line 74: artifacts.create(*BASE_RAW_PARAMS) Line 75: self.assertRaises(se.DomainHasGarbage, artifacts.create, Line 200: self.assertTrue( Line 201: os.path.basename(path).startswith(sd.REMOVED_IMAGE_PREFIX)) Line 202: self.assertTrue(os.path.exists(path)) Line 203: self.assertFalse(os.path.exists(artifacts._image_dir)) Line 204: self.assertEqual(nr_files, len(os.listdir(path))) > I don't think we should count files but check which files exists instead. T Done Line 205: Line 206: def validate_metadata_artifact(
Change in vdsm[master]: storagetests: add a test for normalize_local_path
Nir Soffer has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 2: Verified+1 The tests fail as it should -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: add a flag for preparing with illegal volumes.
Nir Soffer has posted comments on this change. Change subject: image: add a flag for preparing with illegal volumes. .. Patch Set 2: Code-Review+1 (1 comment) Waiting for Adam review. https://gerrit.ovirt.org/#/c/55199/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 5311: # @allowIllegal: #optional False by default. If set to True, prepare will Line 5312: #succeed even if any of the image volumes are illegal, Line 5313: #for making the volume writable by untrusted source. Line 5314: #*Warning- Never use this when exposing this volume's Line 5315: # image to a vm! *Warning? Please remove uneeded indentation before "image to a vm!" Line 5316: # Line 5317: # Returns: Line 5318: # Information about prepared image Line 5319: # (new in version 4.18) -- To view, visit https://gerrit.ovirt.org/55199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie18ab167635e6e099c3a12e03ea6620578c3103f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: canonicalize 'switch' in nets and bonds
gerrit-hooks has posted comments on this change. Change subject: net: canonicalize 'switch' in nets and bonds .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71b6c0ae1a0027bbacf7da7dc8e4cd2926cbcb7d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: net: introduce 'switch' attribute for nets and bonds
Petr Horáček has posted comments on this change. Change subject: API: net: introduce 'switch' attribute for nets and bonds .. Patch Set 2: Verified+1 A network with 'switch': 'legacy' was created and stored in persistence. Passed network tests OK. -- To view, visit https://gerrit.ovirt.org/55494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22e7f1044387057f5f2211fc539dd4c004011d04 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: net: introduce 'switch' attribute for nets and bonds
gerrit-hooks has posted comments on this change. Change subject: API: net: introduce 'switch' attribute for nets and bonds .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22e7f1044387057f5f2211fc539dd4c004011d04 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: net: introduce 'switch' attribute for nets and bonds
Petr Horáček has posted comments on this change. Change subject: API: net: introduce 'switch' attribute for nets and bonds .. Patch Set 1: Verified+1 A network with 'switch': 'legacy' was created and stored in persistence. Passed network tests OK. -- To view, visit https://gerrit.ovirt.org/55494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22e7f1044387057f5f2211fc539dd4c004011d04 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ifcfg: use unified rollback
Petr Horáček has abandoned this change. Change subject: net: ifcfg: use unified rollback .. Abandoned -- To view, visit https://gerrit.ovirt.org/54217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0b0f8891eaf97648ea7fbde4e7d5cc855ce157e6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: legacy: split bonds handling to removal and setup
gerrit-hooks has posted comments on this change. Change subject: net: legacy: split bonds handling to removal and setup .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/54352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib53d04c89a72d514ffcea93981b6782f6eb4a14d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: netswitch: test implementation
Petr Horáček has abandoned this change. Change subject: net: netswitch: test implementation .. Abandoned -- To view, visit https://gerrit.ovirt.org/54361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1e4f91da9cf0abd53dd234a10a1a375bd628d67a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: netswitch: test implementation
gerrit-hooks has posted comments on this change. Change subject: net: netswitch: test implementation .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/54361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e4f91da9cf0abd53dd234a10a1a375bd628d67a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ifcfg: use unified rollback
gerrit-hooks has posted comments on this change. Change subject: net: ifcfg: use unified rollback .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/54217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b0f8891eaf97648ea7fbde4e7d5cc855ce157e6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: legacy: split bonds handling to removal and setup
Petr Horáček has abandoned this change. Change subject: net: legacy: split bonds handling to removal and setup .. Abandoned -- To view, visit https://gerrit.ovirt.org/54352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib53d04c89a72d514ffcea93981b6782f6eb4a14d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
Nir Soffer has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/55182/3/vdsm/storage/fileUtils.py
File vdsm/storage/fileUtils.py:
Line 32: from contextlib import contextmanager
Line 33: import subprocess
Line 34: import shutil
Line 35: import logging
Line 36: from mount import normalize_spec
We cannot depend on mount here, mount should depend on this module since these
function are needed in other modules. What you do here is create dependency
cycles.
The dependency should be:
storageServer -> fileUtils, mount
mount -> fileUtils
nfsSD -> fileUtils
So move here normalize_spec here.
Line 37: import errno
Line 38: import sys
Line 39: import warnings
Line 40:
Line 79: """
Line 80: return remotePath.replace('_', '__').replace('/', '_')
Line 81:
Line 82:
Line 83: def transformSpec(spec):
I'm not sure about this helper, I'll need more time to review this.
Line 84: """
Line 85: Transforms an unnormalized remote path to a new one for local mount
Line 86: """
Line 87: return transformPath(normalize_spec(spec))
--
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Use mock module for testing
Petr Horáček has posted comments on this change. Change subject: test: Use mock module for testing .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c0af7baab7c35a2617bd60a62a0b1534e5f8894 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Use mock module for testing
gerrit-hooks has posted comments on this change. Change subject: test: Use mock module for testing .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c0af7baab7c35a2617bd60a62a0b1534e5f8894 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
Nir Soffer has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/55182/3/vdsm/storage/mount.py File vdsm/storage/mount.py: Line 182: return normpath(spec) Line 183: # if ":" in spec: Line 184: # host, path = ipaddress.hosttail_split(spec) Line 185: # return host + ":" + normpath(path) Line 186: # return normpath(spec) We can delete the commented code now. Line 187: Line 188: Line 189: def getMountFromTarget(target): Line 190: target = normpath(target) -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: allow root-requiring network caps
gerrit-hooks has posted comments on this change. Change subject: caps: allow root-requiring network caps .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurators: make disable_ipv6 permanent by using sysctl.d...
gerrit-hooks has posted comments on this change. Change subject: configurators: make disable_ipv6 permanent by using sysctl.d configs .. Patch Set 6: * #1219363::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/46985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8eb8c529dae7a773530c6c5e98c12d33ef91968f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
Nir Soffer has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 2: Looks fine - lets fine the other places doing path normalization when a spec enter vdsm and add failing tests for them. I don't want to fix this only in once place since this will lead to regression. We must fix this issue globally in all code paths. -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Adding the netswitch module
Petr Horáček has posted comments on this change. Change subject: net: Adding the netswitch module .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I869e634e9f97cf279d4df83fca2b8f8d73bcea47 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurators: make disable_ipv6 permanent by using sysctl.d...
Ondřej Svoboda has abandoned this change. Change subject: configurators: make disable_ipv6 permanent by using sysctl.d configs .. Abandoned Superseded by a simpler approach. -- To view, visit https://gerrit.ovirt.org/46985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8eb8c529dae7a773530c6c5e98c12d33ef91968f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Adding the netswitch module
gerrit-hooks has posted comments on this change. Change subject: net: Adding the netswitch module .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I869e634e9f97cf279d4df83fca2b8f8d73bcea47 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurators: move disable_ipv6 code to a common function
Ondřej Svoboda has abandoned this change. Change subject: configurators: move disable_ipv6 code to a common function .. Abandoned Superseded by an other approach. -- To view, visit https://gerrit.ovirt.org/46984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I39d39f10cc2e7f593bb4ba3c65c0e04ff08715ee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: configurators: move disable_ipv6 code to a common function
gerrit-hooks has posted comments on this change. Change subject: configurators: move disable_ipv6 code to a common function .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39d39f10cc2e7f593bb4ba3c65c0e04ff08715ee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3
Nir Soffer has posted comments on this change. Change subject: monitoring: Port vdsm.storage.check to python 3 .. Patch Set 1: Tested on Fedora 22 and RHEL 7.2 -- To view, visit https://gerrit.ovirt.org/55490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41df272678c63a48d51ab17cea0ed424ccda17c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: suppress for python2
Petr Horáček has posted comments on this change. Change subject: suppress for python2 .. Patch Set 11: Verified+1 common/contextlib_test.py passed OK. [root@centos7-vdsmbox ~]# python2 Python 2.7.5 (default, Nov 20 2015, 02:00:19) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> from vdsm.compat import suppress >>> print(suppress.__doc__) Python >= 3.4 suppress context manager. https://docs.python.org/3/library/contextlib.html#contextlib.suppress >>> with suppress(OSError): ... raise OSError() ... [root@centos7-vdsmbox ~]# PYTHONPATH=$PYTHONPATH:/usr/lib/python2.7/site-packages/ python3 Python 3.4.3 (default, Jan 26 2016, 02:25:35) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from vdsm.compat import suppress >>> print(suppress.__doc__) Context manager to suppress specified exceptions After the exception is suppressed, execution proceeds with the next statement following the with statement. with suppress(FileNotFoundError): os.remove(somefile) # Execution still resumes here if the file was already removed >>> with suppress(OSError): ... raise OSError() ... -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
Nir Soffer has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 2: -Code-Review (5 comments) Found more stuff to improve, see the comments. https://gerrit.ovirt.org/#/c/55180/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-03-30 14:59:29 +0300 Line 6: Line 7: storagetests: add test for mount.isMounted Line 8: Line 9: Given a spec, this test verifies that the expected fs_file is found in Given a local path Line 10: the /proc/mounts monkey patched temporary file by calling Line 11: mount.isMounted. Line 12: Line 13: Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Line 7: storagetests: add test for mount.isMounted Line 8: Line 9: Given a spec, this test verifies that the expected fs_file is found in Line 10: the /proc/mounts monkey patched temporary file by calling Line 11: mount.isMounted. This is not very clear. This patch add the missing tests ensuring that mount.isMounted works. The fact that we have to fake /proc/mounts is not interesting in the commit message. Line 12: Line 13: Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Line 14: Related-To: https://bugzilla.redhat.com/1305529 https://gerrit.ovirt.org/#/c/55180/2/tests/mountTests.py File tests/mountTests.py: Line 289: # Line 290: # Line 291: @contextmanager Line 292: def fake_mounts(mounts_list): Line 293: data = "".join(line + "\n" for line in mounts_list) mount_list -> mount_lines Using type in the name is not a good idea, this is not a list of some objects but list of lines. Use bytes instead of strings - tempoaryPath is expecting now bytes objects: https://gerrit.ovirt.org/55489 Should be: data = b"".join(line + b"\n" for line in mount_lines) Line 294: with temporaryPath(data=data) as fake_mounts: Line 295: with monkeypatch.MonkeyPatchScope([ Line 296: (mount, '_PROC_MOUNTS_PATH', fake_mounts), Line 297: (mount, '_ETC_MTAB_PATH', fake_mounts), Line 301: Line 302: class TestRemoteSdIsMounted(TestCaseBase): Line 303: Line 304: def test_is_mounted(self): Line 305: with fake_mounts(["server:/path " Use b"...", in Python 3 you cannot write a string to a file without specifying the encoding. Line 306: "/rhev/data-center/mnt/server:_path " Line 307: "nfs4 defaults 0 0"]): Line 308: self.assertTrue(mount.isMounted( Line 309: "/rhev/data-center/mnt/server:_path")) Line 305: with fake_mounts(["server:/path " Line 306: "/rhev/data-center/mnt/server:_path " Line 307: "nfs4 defaults 0 0"]): Line 308: self.assertTrue(mount.isMounted( Line 309: "/rhev/data-center/mnt/server:_path")) Same, use b"..." Line 310: Line 311: def test_is_not_mounted(self): Line 312: with fake_mounts(["server:/path " Line 313: "/rhev/data-center/mnt/server:_path " -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: hide some methods and constants
gerrit-hooks has posted comments on this change. Change subject: ifcfg: hide some methods and constants .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fc95d637613dec5175d9200031a85fd0b5ac1e9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: suppress for python2
gerrit-hooks has posted comments on this change. Change subject: suppress for python2 .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
Nir Soffer has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 2: Code-Review+1 Nice! lets cleanup the import and merge. -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
Nir Soffer has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 2: And the docstring. -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Nir Soffer has posted comments on this change.
Change subject: network: add hosttail_join to address.py
..
Patch Set 1: Code-Review+1
(1 comment)
Nice work!
https://gerrit.ovirt.org/#/c/55473/1/tests/common/network_test.py
File tests/common/network_test.py:
Line 68: self.assertNotEqual(('2001::1', '4321'),
Line 69: ipaddress.hosttail_split('2001::1:4321'))
Line 70:
Line 71: @permutations([
Line 72: # (host, tail, expected_return_value)
expected_return_value is little too long, if you use "expected", the test
would be:
self.assertEquals(expected, ipaddress.hosttail_join(host, tail))
Which is nicer.
Line 73: ("server", "/", "server:/"),
Line 74: ("server", "/path", "server:/path"),
Line 75: ("ser:ver", "/path", "[ser:ver]:/path"),
Line 76: ("12.34.56.78", "/path", "12.34.56.78:/path"),
--
To view, visit https://gerrit.ovirt.org/55473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: prefer absolute imports
gerrit-hooks has posted comments on this change. Change subject: ifcfg: prefer absolute imports .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I643d11e8c2d915097d69ede52f15f26d63f5db3f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: allow root-requiring network caps
gerrit-hooks has posted comments on this change. Change subject: caps: allow root-requiring network caps .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: suppress for python2
gerrit-hooks has posted comments on this change. Change subject: suppress for python2 .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.
Yaniv Bronhaim has posted comments on this change. Change subject: testlib: Fix temporaryPath on Python 3. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.
Nir Soffer has posted comments on this change. Change subject: testlib: Fix temporaryPath on Python 3. .. Patch Set 1: Also tested as root on rhel 7.2. -- To view, visit https://gerrit.ovirt.org/55489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
gerrit-hooks has posted comments on this change. Change subject: net: Libvirt hook that enables ovs-legacy migration .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
Edward Haas has uploaded a new change for review.
Change subject: net: Libvirt hook that enables ovs-legacy migration
..
net: Libvirt hook that enables ovs-legacy migration
This hook allows VM/s to be migrated between OVS based hosts and legacy
based hosts, in both directions.
The hook is added to the OVS hook package.
Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec
Signed-off-by: Edward Haas
---
A tests/network/hook_ovs_test.py
M vdsm.spec.in
M vdsm/virt/libvirt-hook.sh
M vdsm_hooks/ovs/Makefile.am
A vdsm_hooks/ovs/ovs_migrate.py
5 files changed, 277 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/55497/1
diff --git a/tests/network/hook_ovs_test.py b/tests/network/hook_ovs_test.py
new file mode 100644
index 000..9f6318e
--- /dev/null
+++ b/tests/network/hook_ovs_test.py
@@ -0,0 +1,173 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+from StringIO import StringIO
+import sys
+import re
+
+from nose.plugins.attrib import attr
+
+from testlib import VdsmTestCase
+from monkeypatch import MonkeyPatchScope
+
+from vdsm import netconfpersistence
+
+sys.path.append('../vdsm_hooks/ovs') # Source Location
+sys.path.append('../../vdsm_hooks/ovs') # Source Location
+sys.path.append('/usr/libexec/vdsm/')# Deploy Location
+try:
+import ovs_utils
+except:
+# Assuming that the failure is due to ovs-vsctl missing (ovs not installed)
+from vdsm.utils import CommandPath
+with MonkeyPatchScope([(CommandPath, 'cmd', None)]):
+import ovs_utils
+import ovs_migrate
+
+
+@attr(type='unit')
+class TestOvsHookMigration(VdsmTestCase):
+
+class MockRunningConfigNoVlan:
+def __init__(self):
+self.networks = {'testnet0': {'vlan': None}}
+
+class MockRunningConfigVlan:
+def __init__(self):
+self.networks = {'testnet0': {'vlan': 101}}
+
+def test_legacy_to_legacy_non_vlan(self):
+self._assert_device_migration(from_xml=LIBVIRT_XML_DESCR_LEGACY,
+ to_xml=LIBVIRT_XML_DESCR_LEGACY,
+ is_destibation_ovs=False,
+ is_vlan_net=False,
+ normalize=False)
+
+def test_legacy_to_legacy_with_vlan(self):
+self._assert_device_migration(from_xml=LIBVIRT_XML_DESCR_LEGACY,
+ to_xml=LIBVIRT_XML_DESCR_LEGACY,
+ is_destibation_ovs=False,
+ is_vlan_net=True,
+ normalize=False)
+
+def test_ovs_to_ovs_non_vlan(self):
+self._assert_device_migration(from_xml=LIBVIRT_XML_DESCR_OVS,
+ to_xml=LIBVIRT_XML_DESCR_OVS,
+ is_destibation_ovs=True,
+ is_vlan_net=False,
+ normalize=False)
+
+def test_ovs_to_ovs_with_vlan(self):
+self._assert_device_migration(from_xml=LIBVIRT_XML_DESCR_OVS_VLAN,
+ to_xml=LIBVIRT_XML_DESCR_OVS_VLAN,
+ is_destibation_ovs=True,
+ is_vlan_net=True,
+ normalize=False)
+
+def test_legacy_to_ovs_non_vlan(self):
+self._assert_device_migration(from_xml=LIBVIRT_XML_DESCR_LEGACY,
+ to_xml=LIBVIRT_XML_DESCR_OVS,
+ is_destibation_ovs=True,
+ is_vlan_net=False,
+ normalize=True)
+
+def test_legacy_to_ovs_with_vlan(self):
+self._assert_device_migration(from_xml=LIBVIRT_XML_DESCR_LEGACY,
+ to_xml=LIBVIRT_XML_DESCR_OVS_VLAN,
+ is_destibation_ovs=True,
+ is_vlan_net=True,
+ normalize=True)
+
+def te
Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.
Francesco Romani has posted comments on this change. Change subject: testlib: Fix temporaryPath on Python 3. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: fix handling virt-v2v fail on stream close
Francesco Romani has posted comments on this change.
Change subject: v2v: fix handling virt-v2v fail on stream close
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/55477/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 714: chunk = ''
Line 715: while True:
Line 716: c = stream.read(1)
Line 717: if not c:
Line 718: raise OutputParserError('copy-disk stream closed
unexpectedly')
interesting, it was that simple in the end
Line 719: chunk += c
Line 720: if c == '\r':
Line 721: yield chunk
Line 722: chunk = ''
--
To view, visit https://gerrit.ovirt.org/55477
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Use libvirt to get drive size
Nir Soffer has posted comments on this change. Change subject: virt: Use libvirt to get drive size .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55399/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3562 Line 3563 Line 3564 Line 3565 Line 3566 You have to import virt.api and wrap this method like this: @api.method def diskSizeExtend(...) -- To view, visit https://gerrit.ovirt.org/55399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19b9f452bae0a1c03f2efe543a4bfa0d671e932d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: net: introduce 'switch' attribute for nets and bonds
Petr Horáček has uploaded a new change for review.
Change subject: API: net: introduce 'switch' attribute for nets and bonds
..
API: net: introduce 'switch' attribute for nets and bonds
'switch' attribute is needed for multiple Switches support.
Change-Id: I22e7f1044387057f5f2211fc539dd4c004011d04
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček
---
M lib/api/vdsmapi-schema.json
M lib/vdsm/network/api.py
2 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/55494/1
diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index 0ab6136..12711ca 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -83,6 +83,8 @@
# @defaultRoute: #optional boolean - Is this network's gateway the host's
# default gateway?
#
+# @switch:#optional Specify used switch. Legacy is used if not passed
+#
# @custom:#optional A dictionary of custom, free-form properties for
# network. (new in version 4.15.0)
#
@@ -96,6 +98,7 @@
'*remove': 'bool',
'*hostQos': 'HostQoSParams',
'*defaultRoute': 'bool',
+ '*switch': 'str',
'*custom': 'StringMap'}}
##
# @SetupNetworkBondAttributes:
@@ -106,12 +109,17 @@
#
# @options: #optional A string of space-separated = pairs
#
+# @switch: #optional Specify used switch. Legacy is used if not passed
+#
# @remove: #optional If True, remove existing bond only
#
# Since: 4.10.0
##
{'type': 'SetupNetworkBondAttributes',
- 'data': {'nics': ['str'], '*options': 'str', '*remove': 'bool'}}
+ 'data': {'nics': ['str'],
+ '*options': 'str',
+ '*switch': 'str',
+ '*remove': 'bool'}}
##
# @SetupNetworkOptions:
diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index a1e101b..9fc767f 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -165,6 +165,7 @@
ipv6autoconf="0|1"
dhcpv6="0|1"
defaultRoute=True|False
+switch="legacy|..."
(other options will be passed to the config file AS-IS)
-- OR --
remove=True (other attributes can't be specified)
@@ -173,6 +174,7 @@
where 'attributes' is a dict with the following optional items:
nics=["" , "", ...]
options=""
+switch="legacy|..."
-- OR --
remove=True (other attributes can't be specified)
--
To view, visit https://gerrit.ovirt.org/55494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22e7f1044387057f5f2211fc539dd4c004011d04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: net: introduce 'switch' attribute for nets and bonds
gerrit-hooks has posted comments on this change. Change subject: API: net: introduce 'switch' attribute for nets and bonds .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22e7f1044387057f5f2211fc539dd4c004011d04 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: canonicalize 'switch' in nets and bonds
gerrit-hooks has posted comments on this change. Change subject: net: canonicalize 'switch' in nets and bonds .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71b6c0ae1a0027bbacf7da7dc8e4cd2926cbcb7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: canonicalize 'switch' in nets and bonds
Petr Horáček has uploaded a new change for review.
Change subject: net: canonicalize 'switch' in nets and bonds
..
net: canonicalize 'switch' in nets and bonds
If no switch type is passed, we use 'legacy' as a default.
Change-Id: I71b6c0ae1a0027bbacf7da7dc8e4cd2926cbcb7d
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček
---
M lib/vdsm/network/api.py
M lib/vdsm/network/canonicalize.py
2 files changed, 24 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/55495/1
diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index 9fc767f..3716aff 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -36,7 +36,7 @@
from vdsm import udevadm
from vdsm import ipwrapper
-from . canonicalize import canonicalize_networks
+from . canonicalize import canonicalize_networks, canonicalize_bondings
from . import netswitch
from .configurators import RollbackIncomplete
@@ -210,7 +210,7 @@
def _setup_networks(networks, bondings, options):
canonicalize_networks(networks)
-# TODO: Add canonicalize_bondings(bondings)
+canonicalize_bondings(bondings)
logging.debug('Validating configuration')
netswitch.validate(networks, bondings)
diff --git a/lib/vdsm/network/canonicalize.py b/lib/vdsm/network/canonicalize.py
index 69afdc6..2e62c73 100644
--- a/lib/vdsm/network/canonicalize.py
+++ b/lib/vdsm/network/canonicalize.py
@@ -28,7 +28,7 @@
from . import errors as ne
-def canonicalize_networks(nets):
+def canonicalize_networks(nets, running_config):
"""
Given networks configuration, explicitly add missing defaults.
:param nets: The network configuration
@@ -37,13 +37,28 @@
# If net is marked for removal, normalize the mark to boolean and
# ignore all other attributes canonization.
if _canonicalize_remove(attrs):
-continue
+continue
_canonicalize_mtu(attrs)
_canonicalize_vlan(attrs)
_canonicalize_bridged(attrs)
_canonicalize_stp(attrs)
_canonicalize_ipv6(attrs)
+_canonicalize_switch(attrs)
+
+
+def canonicalize_bondings(bonds, running_config):
+"""
+Given bondings configuration, explicitly add missing defaults.
+:param bonds: The bonding configuration
+"""
+for attrs in six.itervalues(bonds):
+# If bond is marked for removal, normalize the mark to boolean and
+# ignore all other attributes canonization.
+if _canonicalize_remove(attrs):
+continue
+
+_canonicalize_switch(attrs)
def _canonicalize_remove(data):
@@ -89,3 +104,8 @@
def _canonicalize_ipv6(data):
if 'dhcpv6' not in data:
data['dhcpv6'] = False
+
+
+def _canonicalize_switch(data):
+if 'switch' not in data:
+data['switch'] = 'legacy'
--
To view, visit https://gerrit.ovirt.org/55495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71b6c0ae1a0027bbacf7da7dc8e4cd2926cbcb7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Use libvirt to get drive size
Nir Soffer has posted comments on this change.
Change subject: virt: Use libvirt to get drive size
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55399/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3502: return self._dom.blockInfo(drive.name)[0]
Line 3503: except libvirt.libvirtError:
Line 3504: self.log.exception("An error occurred while getting
the "
Line 3505:"current disk size")
Line 3506: return errCode['resizeErr']
> This return a dict, the caller expects a number.
Use this:
try:
curVirtualSize = self._dom.blockInfo(drive.name)[0]
except libvirt.LibvirtError as e:
raise exception.BadDiskResizeParameter()
We don't have to return error code any more - this is the way errors should be
handled in vdsm.
But check that the caller is ready for this exception.
Line 3507:
Line 3508: curVirtualSize = _getSize()
Line 3509: if curVirtualSize > newSizeBytes:
Line 3510: self.log.error(
--
To view, visit https://gerrit.ovirt.org/55399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19b9f452bae0a1c03f2efe543a4bfa0d671e932d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: fix handling virt-v2v fail on stream close
Nir Soffer has posted comments on this change. Change subject: v2v: fix handling virt-v2v fail on stream close .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55477/2//COMMIT_MSG Commit Message: Line 9: when proc.stdout.read() is close it doesn't raise an error but returns Line 10: ''. Line 11: Line 12: Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Line 13: Url: https://bugzilla.redhat.com/1298134 Bug-Url: -- To view, visit https://gerrit.ovirt.org/55477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: import netinfo modules' members directly
Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: import netinfo modules' members directly .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/53681/1/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 41: from vdsm import dsaversion Line 42: from vdsm import hooks Line 43: from vdsm import ipwrapper Line 44: from vdsm.netinfo import NET_PATH Line 45: from vdsm.netinfo.bonding import (BONDING_MASTERS, > in a big module like this one, I find the multitude of imported names quite Fair enough. I'll just split the import line as per guidelines (is this written in PEP8?) I follow. Line 46: BONDING_MODES_NAME_TO_NUMBER, BONDING_OPT, Line 47: bondOpts, getDefaultBondingOptions, slaves) Line 48: from vdsm.netinfo.cache import ifaceUsed Line 49: from vdsm.netinfo.misc import getIfaceCfg, ipv6_supported -- To view, visit https://gerrit.ovirt.org/53681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I643d11e8c2d915097d69ede52f15f26d63f5db3f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: fix handling virt-v2v fail on stream close
Nir Soffer has posted comments on this change. Change subject: v2v: fix handling virt-v2v fail on stream close .. Patch Set 2: Code-Review+1 Lets improve the commit message and merge this. -- To view, visit https://gerrit.ovirt.org/55477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add device setup and teardown
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/55135/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1685: for con in self._devices[hwclass.CONSOLE]:
Line 1686: con.cleanup()
Line 1687:
Line 1688: def _teardownDevices(self):
Line 1689: for dev_objects in self._devices.values():
This is not safe on Python 3 - check if six has a helper that does nothing on 2
and create a list on 3.
Line 1690: for dev_object in dev_objects:
Line 1691: dev_object.teardown()
Line 1692:
Line 1693: def _cleanupRecoveryFile(self):
Line 1862: for dev_name, dev in self._host_devices():
Line 1863: self.log.debug('Detaching device %s from the host.'
% dev_name)
Line 1864: dev.detach()
Line 1865:
Line 1866: for dev_objects in self._devices.values():
Same issue, same fix (six?)
Line 1867: for dev_object in dev_objects:
Line 1868: dev_object.setup()
Line 1869:
Line 1870: if self.recovering:
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Add process helpers
gerrit-hooks has posted comments on this change. Change subject: monitoring: Add process helpers .. Patch Set 4: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check Product::#1081962::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7a8e452ce2acd3aebdc76212a534e6d4a5638d9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3
Nir Soffer has posted comments on this change. Change subject: monitoring: Port vdsm.storage.check to python 3 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/55490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41df272678c63a48d51ab17cea0ed424ccda17c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.
Nir Soffer has posted comments on this change. Change subject: testlib: Fix temporaryPath on Python 3. .. Patch Set 1: Verified+1 All tests pass on 2 and 3 (as user, jenkins will test as root). -- To view, visit https://gerrit.ovirt.org/55489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Introduce the check module
Nir Soffer has posted comments on this change. Change subject: monitoring: Introduce the check module .. Patch Set 33: Verified+1 -- To view, visit https://gerrit.ovirt.org/54757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3
gerrit-hooks has posted comments on this change. Change subject: monitoring: Port vdsm.storage.check to python 3 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41df272678c63a48d51ab17cea0ed424ccda17c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.
gerrit-hooks has posted comments on this change. Change subject: testlib: Fix temporaryPath on Python 3. .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Introduce the asyncevent module
gerrit-hooks has posted comments on this change. Change subject: monitoring: Introduce the asyncevent module .. Patch Set 16: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check Product::#1081962::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Introduce the check module
gerrit-hooks has posted comments on this change. Change subject: monitoring: Introduce the check module .. Patch Set 33: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check Product::#1081962::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Port vdsm.storage.check to python 3
Nir Soffer has uploaded a new change for review.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
monitoring: Port vdsm.storage.check to python 3
Change-Id: I41df272678c63a48d51ab17cea0ed424ccda17c8
Signed-off-by: Nir Soffer
---
M lib/vdsm/storage/check.py
M tests/Makefile.am
M tests/storage_check_test.py
3 files changed, 27 insertions(+), 25 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/55490/1
diff --git a/lib/vdsm/storage/check.py b/lib/vdsm/storage/check.py
index f7de037..109e883 100644
--- a/lib/vdsm/storage/check.py
+++ b/lib/vdsm/storage/check.py
@@ -34,13 +34,13 @@
import logging
import re
+import subprocess
import threading
-
-import cpopen
from vdsm import cmdutils
from vdsm import concurrent
from vdsm import constants
+from vdsm.compat import CPopen
from vdsm.storage import asyncevent
from vdsm.storage import exception
@@ -284,8 +284,8 @@
self._check_time = self._loop.time()
_log.debug("START check %r cmd=%s delay=%.2f",
self._path, cmd, self._check_time - self._next_check)
-self._proc = cpopen.CPopen(cmd, stdin=None, stdout=None,
- stderr=cpopen.PIPE)
+self._proc = CPopen(cmd, stdin=None, stdout=None,
+stderr=subprocess.PIPE)
self._reader = self._loop.create_dispatcher(
asyncevent.BufferedReader, self._proc.stderr, self._read_completed)
@@ -339,9 +339,9 @@
class CheckResult(object):
_PATTERN = re.compile(
-r"\d+ bytes? \([\de\-.]+ [kMGT]*B\) copied, "
-r"([\de\-.]+) s, "
-r"(?:[\de\-.]+|Infinity) [kMGT]*B/s")
+br"\d+ bytes? \([\de\-.]+ [kMGT]*B\) copied, "
+br"([\de\-.]+) s, "
+br"(?:[\de\-.]+|Infinity) [kMGT]*B/s")
def __init__(self, path, rc, err, time, elapsed):
self.path = path
diff --git a/tests/Makefile.am b/tests/Makefile.am
index e51eec3..f5d6cc1 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -43,6 +43,7 @@
responseTests.py \
scheduleTests.py \
storage_asyncevent_test.py \
+ storage_check_test.py \
vmStatsTests.py \
$(NULL)
diff --git a/tests/storage_check_test.py b/tests/storage_check_test.py
index 44ba2c4..f9a106c 100644
--- a/tests/storage_check_test.py
+++ b/tests/storage_check_test.py
@@ -67,7 +67,7 @@
def test_path_ok(self):
self.checks = 1
-with temporaryPath(data="blah") as path:
+with temporaryPath(data=b"blah") as path:
checker = check.DirectioChecker(self.loop, path, self.complete)
checker.start()
self.loop.run_forever()
@@ -214,7 +214,7 @@
@permutations([[1], [50], [100], [200]])
def test_path_ok(self, checkers):
self.checkers = checkers
-with temporaryPath(data="blah") as path:
+with temporaryPath(data=b"blah") as path:
start = time.time()
for i in range(checkers):
checker = check.DirectioChecker(self.loop, path, self.complete)
@@ -250,21 +250,21 @@
@permutations([
# err, seconds
-("1\n2\n1 byte (1 B) copied, 1 s, 1 B/s\n",
+(b"1\n2\n1 byte (1 B) copied, 1 s, 1 B/s\n",
1.0),
-("1\n2\n1024 bytes (1 kB) copied, 1 s, 1 kB/s\n",
+(b"1\n2\n1024 bytes (1 kB) copied, 1 s, 1 kB/s\n",
1.0),
-("1\n2\n1572864 bytes (1.5 MB) copied, 1.5 s, 1 MB/s\n",
+(b"1\n2\n1572864 bytes (1.5 MB) copied, 1.5 s, 1 MB/s\n",
1.5),
-("1\n2\n1610612736 bytes (1.5 GB) copied, 1000.5 s, 1.53 MB/s\n",
+(b"1\n2\n1610612736 bytes (1.5 GB) copied, 1000.5 s, 1.53 MB/s\n",
1000.5),
-("1\n2\n479 bytes (479 B) copied, 5.6832e-05 s, 8.4 MB/s\n",
+(b"1\n2\n479 bytes (479 B) copied, 5.6832e-05 s, 8.4 MB/s\n",
5.6832e-05),
-("1\n2\n512 bytes (512e-3 MB) copied, 1 s, 512e-3 MB/s\n",
+(b"1\n2\n512 bytes (512e-3 MB) copied, 1 s, 512e-3 MB/s\n",
1.0),
-("1\n2\n524288 bytes (512e3 B) copied, 1 s, 512e3 B/s\n",
+(b"1\n2\n524288 bytes (512e3 B) copied, 1 s, 512e3 B/s\n",
1.0),
-("1\n2\n517 bytes (517 B) copied, 0 s, Infinity B/s\n",
+(b"1\n2\n517 bytes (517 B) copied, 0 s, Infinity B/s\n",
0.0)
])
def test_success(self, err, seconds):
@@ -281,14 +281,14 @@
self.assertIn(reason, str(ctx.exception))
@permutations([
-("",),
-("1\n2\n\n",),
-("1\n2\nBAD, 1 s, 1 kB/s\n",),
-("1\n2\n1024 bytes (1 kB) copied, 1 s, 1 BAD\n",),
-("1\n2\n1024 bytes (1 kB) copied, BAD, 1 kB/s\n",),
-("1\n2\n1024 bytes (1 kB) copied, BAD s, 1 kB/s\n",),
-("1\n2\n1024 bytes (1 kB) copied, -1- s, 1 kB/s\n",),
-("1\n2\n1024 bytes (1 kB) copied, e3- s, 1 kB/s\n",),
+(b"",),
Change in vdsm[master]: testlib: Fix temporaryPath on Python 3.
Nir Soffer has uploaded a new change for review. Change subject: testlib: Fix temporaryPath on Python 3. .. testlib: Fix temporaryPath on Python 3. Writing data to files must use bytes objects, not unicode/strings. Replace os.fdopen() with io.open(path, "wb") creating a buffered file object for writing binary data. Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Signed-off-by: Nir Soffer --- M tests/testlib.py 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/55489/1 diff --git a/tests/testlib.py b/tests/testlib.py index 94168dc..0273c30 100644 --- a/tests/testlib.py +++ b/tests/testlib.py @@ -21,6 +21,7 @@ import errno import functools import inspect +import io import logging import os import pickle @@ -125,10 +126,8 @@ def temporaryPath(perms=None, data=None, dir=TEMPDIR): fd, src = tempfile.mkstemp(dir=dir) if data is not None: -f = os.fdopen(fd, "wb") -f.write(data) -f.flush() -f.close() +with io.open(fd, "wb") as f: +f.write(data) else: os.close(fd) if perms is not None: -- To view, visit https://gerrit.ovirt.org/55489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I939d78a61f5fe1b836f59bee7ef7015cd8e79647 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sr-iov: use device setup instead of detach
gerrit-hooks has posted comments on this change. Change subject: sr-iov: use device setup instead of detach .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c97af2ea9f17ef38f9dbb4f41e5f9d1da9eebaa Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add device setup and teardown
gerrit-hooks has posted comments on this change. Change subject: virt: add device setup and teardown .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: use device setup instead of detach
gerrit-hooks has posted comments on this change. Change subject: hostdev: use device setup instead of detach .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibff865dc1a40434bf48e640baf25b67b39767001 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Artyom Lukianov has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Use libvirt to get drive size
Nir Soffer has posted comments on this change. Change subject: virt: Use libvirt to get drive size .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55399/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3493: del conf['diskReplicate'] Line 3494: self.saveState() Line 3495: Line 3496: def _diskSizeExtendCow(self, drive, newSizeBytes): Line 3497: def _getSize(): > Please avoid these nested functions, they should be used only when we need Submitted too quickly - don't add a helper, just inline this when needed. Line 3498: # Due to an old bug in libvirt (BZ#963881) this call used to be Line 3499: # broken for NFS domains when squash_root was enabled. This has Line 3500: # been fixed since libvirt-0.10.2-29 Line 3501: try: -- To view, visit https://gerrit.ovirt.org/55399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19b9f452bae0a1c03f2efe543a4bfa0d671e932d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Use libvirt to get drive size
Nir Soffer has posted comments on this change.
Change subject: virt: Use libvirt to get drive size
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/55399/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3493: del conf['diskReplicate']
Line 3494: self.saveState()
Line 3495:
Line 3496: def _diskSizeExtendCow(self, drive, newSizeBytes):
Line 3497: def _getSize():
Please avoid these nested functions, they should be used only when we need the
closure.
Use this code when you need it.
Line 3498: # Due to an old bug in libvirt (BZ#963881) this call
used to be
Line 3499: # broken for NFS domains when squash_root was enabled.
This has
Line 3500: # been fixed since libvirt-0.10.2-29
Line 3501: try:
Line 3502: return self._dom.blockInfo(drive.name)[0]
Line 3503: except libvirt.libvirtError:
Line 3504: self.log.exception("An error occurred while getting
the "
Line 3505:"current disk size")
Line 3506: return errCode['resizeErr']
This return a dict, the caller expects a number.
Line 3507:
Line 3508: curVirtualSize = _getSize()
Line 3509: if curVirtualSize > newSizeBytes:
Line 3510: self.log.error(
--
To view, visit https://gerrit.ovirt.org/55399
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19b9f452bae0a1c03f2efe543a4bfa0d671e932d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: fix handling virt-v2v fail on stream close
Nir Soffer has posted comments on this change. Change subject: v2v: fix handling virt-v2v fail on stream close .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/55477/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-03-28 15:38:16 +0300 Line 4: Commit: Shahar Havivi Line 5: CommitDate: 2016-03-30 15:53:58 +0300 Line 6: Line 7: v2v: fix handling virt-v2v fail on stream close > Handle closed stream when virt-v2v fails (?) +1 Line 8: Line 9: when proc.stdout.read() is close it doesn't raise an error but returns Line 10: ''. Line 11: Line 5: CommitDate: 2016-03-30 15:53:58 +0300 Line 6: Line 7: v2v: fix handling virt-v2v fail on stream close Line 8: Line 9: when proc.stdout.read() is close it doesn't raise an error but returns > ... closed ... When file object is closed by the other side, read return empty string, previously we assumed an exception is raised. Line 10: ''. Line 11: Line 12: Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Line 13: Url: https://bugzilla.redhat.com/1298134 -- To view, visit https://gerrit.ovirt.org/55477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Use libvirt to get drive size
Adam Litke has posted comments on this change. Change subject: virt: Use libvirt to get drive size .. Patch Set 2: Code-Review+1 Needs verification. -- To view, visit https://gerrit.ovirt.org/55399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19b9f452bae0a1c03f2efe543a4bfa0d671e932d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tal Nisan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: v2v: fix handling virt-v2v fail on stream close
Milan Zamazal has posted comments on this change. Change subject: v2v: fix handling virt-v2v fail on stream close .. Patch Set 2: Code-Review+1 (2 comments) OK, I just suggest improving the commit message. https://gerrit.ovirt.org/#/c/55477/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-03-28 15:38:16 +0300 Line 4: Commit: Shahar Havivi Line 5: CommitDate: 2016-03-30 15:53:58 +0300 Line 6: Line 7: v2v: fix handling virt-v2v fail on stream close Handle closed stream when virt-v2v fails (?) Line 8: Line 9: when proc.stdout.read() is close it doesn't raise an error but returns Line 10: ''. Line 11: PS2, Line 9: close ... closed ... -- To view, visit https://gerrit.ovirt.org/55477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: commands: import StringIO when AsyncProc is started
Nir Soffer has posted comments on this change. Change subject: commands: import StringIO when AsyncProc is started .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduce VolumeArtifacts
Nir Soffer has posted comments on this change. Change subject: Introduce VolumeArtifacts .. Patch Set 25: Code-Review-1 (6 comments) Looks good, lets finish the few minor issues and merge it. https://gerrit.ovirt.org/#/c/48097/25/vdsm/storage/fileSD.py File vdsm/storage/fileSD.py: Line 204: """ Line 205: return fileVolume.FileVolumeManifest Line 206: Line 207: def get_volume_artifacts_class(self): Line 208: return sdm.volume_artifacts.FileVolumeArtifacts We return the class to be consistent with getvolumeClass, right? Line 209: Line 210: def getDeletedImagePath(self, imgUUID): Line 211: currImgDir = self.getImagePath(imgUUID) Line 212: dirName, baseName = os.path.split(currImgDir) https://gerrit.ovirt.org/#/c/48097/25/vdsm/storage/sdm/Makefile.am File vdsm/storage/sdm/Makefile.am: Line 1 Line 2 we can update this to 2015-2016 or maybe just 2016. https://gerrit.ovirt.org/#/c/48097/25/vdsm/storage/sdm/volume_artifacts.py File vdsm/storage/sdm/volume_artifacts.py: Line 47: Line 48: TODO: block based volume Line 49: """ Line 50: Line 51: from __future__ import absolute_import This may not work correctly inside vdsm, since vdsm is not a package, be careful. Line 52: Line 53: import errno Line 54: import logging Line 55: import os Line 114: Line 115: MISSING Line 116: Line 117: - States: Line 118: - no image or volatile directories Need to indent the sub lists: - States: - no image or... - Operations: - is_garbage -> false Line 119: - Operations: Line 120: - is_garbage -> false Line 121: - is_image -> false Line 122: - create artifacts -> change state GARBAGE Line 156: return True Line 157: Line 158: vol_path = os.path.join(self._image_dir, self.vol_id) Line 159: volatile_metadata_path = (self.vol_class.metaVolumePath(vol_path) + Line 160: TEMP_VOL_FILEEXT) Why not: self._oop.fileUtils.pathExists(self.meta_volatile_path?) Line 161: return self._oop.fileUtils.pathExists(volatile_metadata_path) Line 162: Line 163: def is_image(self): Line 164: if self._image_exists is None: Line 161: return self._oop.fileUtils.pathExists(volatile_metadata_path) Line 162: Line 163: def is_image(self): Line 164: if self._image_exists is None: Line 165: self._image_exists = os.path.exists(self._image_dir) Should use self._oop - this can block entire vdsm when NFS get stuck. Do we have a reason to cache the result? we don't cache in is_garbage. Line 166: return self._image_exists Line 167: Line 168: @property Line 169: def _oop(self): -- To view, visit https://gerrit.ovirt.org/48097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I352423e39a899b9b83ccf3b8f6c17ec433e9c353 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: commands: import StringIO when AsyncProc is started
gerrit-hooks has posted comments on this change. Change subject: commands: import StringIO when AsyncProc is started .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3610865945aeee3b13b8e195c749023a524ebe97 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: compat: mock CPopen for Python 3 testing
Dan Kenigsberg has submitted this change and it was merged. Change subject: compat: mock CPopen for Python 3 testing .. compat: mock CPopen for Python 3 testing I would like to run Vdsm unit tests in Python 3, but many tests ultimately attempt to import CPopen. The right thing to do is to remove CPopen dependency from the code, but this task is lagging. Until then, this patch drops CPopen dependecy for Python 3 only. Change-Id: I3fb1310dc538ea92879ab1097d897fd7c4e2ef96 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/55379 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Piotr Kliczewski --- M lib/vdsm/commands.py M lib/vdsm/compat.py M lib/vdsm/qemuimg.py 3 files changed, 10 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/55379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fb1310dc538ea92879ab1097d897fd7c4e2ef96 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: compat: mock CPopen for Python 3 testing
gerrit-hooks has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fb1310dc538ea92879ab1097d897fd7c4e2ef96 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: compat: mock CPopen for Python 3 testing
Piotr Kliczewski has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fb1310dc538ea92879ab1097d897fd7c4e2ef96 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs [3]: validate networks and bonds
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [3]: validate networks and bonds .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55310 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bceae0aada964c47aacfcfdbe93ca19eb8f3d14 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs [6]: split to-be-removed and to-be-added
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [6]: split to-be-removed and to-be-added .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c8065561db3876ee28e007305d4578ab05b2971 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs [5]: rollback trigger
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [5]: rollback trigger .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bceae0aada964c47aacfcfdbe93ca19eb8f3d15 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
