Change in vdsm[ovirt-3.6]: Handle closed stream when virt-v2v fails
gerrit-hooks has posted comments on this change. Change subject: Handle closed stream when virt-v2v fails .. Patch Set 2: * #1298134::Update tracker: OK * Set MODIFIED::bug 1298134#1298134OK -- To view, visit https://gerrit.ovirt.org/55607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Handle closed stream when virt-v2v fails
Francesco Romani has posted comments on this change. Change subject: Handle closed stream when virt-v2v fails .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Handle closed stream when virt-v2v fails
Francesco Romani has submitted this change and it was merged. Change subject: Handle closed stream when virt-v2v fails .. Handle closed stream when virt-v2v fails When file object is closed by the other side, read return empty string, previously we assumed an exception is raised. Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Bug-Url: https://bugzilla.redhat.com/1298134 Signed-off-by: Shahar Havivi Reviewed-on: https://gerrit.ovirt.org/55607 Tested-by: Shahar Havivi Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Francesco Romani --- M vdsm/v2v.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Shahar Havivi: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Relocate hooking (api) module under lib
Dan Kenigsberg has posted comments on this change. Change subject: hooks: Relocate hooking (api) module under lib .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/55544/6/vdsm/hooking.py File vdsm/hooking.py: PS6, Line 22: TODO: When all refferences to hooking are fixed, this proxy can be removed. I'm not ready to drop the "hooking" interface layers. hooks should not make use of internal vdsm stuff. If they do, they may face serious trouble on vdsm upgrade, since the content of the "vdsm" package is *not* a public API. Please rename vdsm.hooking into vdsm._hooking so it is clearer that hook writers should keep using the absolute "import hooking" and not vdsm-internal packages. -- To view, visit https://gerrit.ovirt.org/55544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Dan Kenigsberg has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/checkipsd File vdsm_hooks/checkips/checkipsd: PS11, Line 64: -I', net, actually, we should not add the explicit -I argument. The user should choose the target host so that it sits in the subnet range. if the target host is not routeable, there's nothing we can do about it. -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: disconnectStorageServer verb
gerrit-hooks has posted comments on this change. Change subject: jsonrpcvdscli: disconnectStorageServer verb .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3308e4a8fb17ed02e83c4b744f3e870919428a5a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Dan Kenigsberg has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 11: (4 comments) https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/after_get_stats.py File vdsm_hooks/checkips/after_get_stats.py: Line 47: Line 48: CONNECTIVITY_TIMEOUT = 60 Line 49: Line 50: Line 51: def _is_network_accessible(net, stats_dir): > Done which name did you choose? I found "is_network_accessible" quite understandable. Line 52: file_path = os.path.join(stats_dir, net) Line 53: if os.path.exists(file_path): Line 54: return ( Line 55: time.time() - os.stat(file_path).st_mtime <= https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/checkipsd File vdsm_hooks/checkips/checkipsd: Line 35: CHECKIPV6 = 'checkipv6' Line 36: VDSM_CHECKIPS = 'vdsm-checkips' Line 37: Line 38: Line 39: def get_ping_addresses(net_attrs): > yes, but I can not use it, because checkips does not python module and also But why not add it to PYTHONPATH? you can do it within the script, with sys.path.append(). I prefer that over duplicating code. Line 40: ping_addresses = [] Line 41: if 'custom' in net_attrs: Line 42: for address_type in (CHECKIPV4, CHECKIPV6): Line 43: if address_type in net_attrs['custom']: Line 54: with open(file_path, 'a'): Line 55: os.utime(file_path, None) Line 56: Line 57: Line 58: def _ping_address(address, address_type, net): > it does not really interface, it is rhevm network name, I can change it to this means you have a serious issue for non-VM networks, where the name of the network and the name of the top-level interface differ. Line 59: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 60: command = [ Line 61: ping_cmd, Line 62: '-c', '1', Line 58: def _ping_address(address, address_type, net): Line 59: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 60: command = [ Line 61: ping_cmd, Line 62: '-c', '1', > So if I send: I don't understand the request for multiple ping packets. The current code declares a network as "down" if we failed to ping for 60 seconds. At this time we have sent 4 ping packets, and waited 15 seconds for for each. Yaniv, can you point me to the hosted-engine requirement? Line 63: '-w', str(PING_TIMEOUT), Line 64: '-I', net, Line 65: address Line 66: ] -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix 186c8574: When using SSL, use the original host
gerrit-hooks has posted comments on this change. Change subject: fix 186c8574: When using SSL, use the original host .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix 186c8574: When using SSL, use the original host
Dan Kenigsberg has submitted this change and it was merged. Change subject: fix 186c8574: When using SSL, use the original host .. fix 186c8574: When using SSL, use the original host When a connection to a remote is perform and encryption (SSL) is enabled, the original target host should be used for the connection and not a resolved one. This bug has been detected when trying to connect to a remote IPv4 host, with a hostname as the target host and SSL enabled. The host got resolved before calling connect, and therefore the certificate has not been matched correctly (expected a hostname but used a resolved IPv4 address). When M2C is dropped, we can easily use the server_hostname arg of https://docs.python.org/2/library/ssl.html#ssl.SSLContext.wrap_socket and avoid the duplicate name resolution. Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/55620 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M lib/vdsm/utils.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/55620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pool: Remove refreshStoragePool verb
Nir Soffer has posted comments on this change. Change subject: pool: Remove refreshStoragePool verb .. Patch Set 5: Maor, aren't we using now connectStoragePool instead or refreshStoragePool? The comment can be update to mention connectstoragePool. Internally we still keep StoragePool.connect() and StoragePool.refresh() - the later is called when vdsm is already connected to the pool in connectStoragePool. -- To view, visit https://gerrit.ovirt.org/54901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If63f5749121d481aa41e6be0b27711d431668265 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
Edward Haas has posted comments on this change. Change subject: net: Libvirt hook that enables ovs-legacy migration .. Patch Set 9: Verified+1 Verified by running a VM migration between an ovs based host and a legacy based host. The migration has been done on a VLAN based network. I was unable to test it on a non-vlan network (due to the limitation of a single such network per host). -- To view, visit https://gerrit.ovirt.org/55497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
gerrit-hooks has posted comments on this change. Change subject: net: Libvirt hook that enables ovs-legacy migration .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pool: Remove refreshStoragePool verb
Maor Lipchuk has posted comments on this change. Change subject: pool: Remove refreshStoragePool verb .. Patch Set 5: There is a comment in spbackends#getDomainsMap which probably should be removed once we get rid of refreshStoragePool: "The assumption is that whenever the storage pool metadata changes the HSM hosts will receive refreshStoragePool (and the metadata will be invalidated). So the invalidation in this method may be redundant or it was introduced to handle negative flows (missed refresh call). Anyway I think that we could get rid of this in the future, provided that the engine handles/resends failed refreshStoragePool calls." -- To view, visit https://gerrit.ovirt.org/54901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If63f5749121d481aa41e6be0b27711d431668265 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
Edward Haas has posted comments on this change. Change subject: net: Libvirt hook that enables ovs-legacy migration .. Patch Set 8: Verified+1 Verified by running a VM migration between an ovs based host and a legacy based host. The migration has been done on a VLAN based network. I was unable to test it on a non-vlan network (due to the limitation of a single such network per host). -- To view, visit https://gerrit.ovirt.org/55497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
gerrit-hooks has posted comments on this change. Change subject: net: Libvirt hook that enables ovs-legacy migration .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example
Yaniv Bronhaim has posted comments on this change. Change subject: test: Replacing MonkeyPatch with mock.patch example .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example
Edward Haas has posted comments on this change. Change subject: test: Replacing MonkeyPatch with mock.patch example .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/55603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example
Edward Haas has posted comments on this change. Change subject: test: Replacing MonkeyPatch with mock.patch example .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/55603/2/tests/network/netinfo_test.py File tests/network/netinfo_test.py: Line 87 Line 88 Line 89 Line 90 Line 91 > what about those mocks ^? It was converted to None :) These are mocks that are no longer needed. These are good examples of why a monkey patch is not a good choice for some mocking: At some point a mock was needed, after several code changes, the dependency that required the mock has been dropped (or changed).. However, the mock has not been taken out, as no error has hinted that it should. To avoid such cases, when a mock is used, we should check it was called/used. Line 114 Line 115 Line 116 Line 117 Line 118 > what about _detectType and _GetBondingOptions mocks? Same as the previous. Line 282 Line 283 Line 284 Line 285 Line 286 > how is it not needed anymore? Dan helped me figure this out, I had trouble understanding it myself (why it passes without the mocking). In testrunner.py we assign: constants.P_VDSM = "../vdsm/" for local runs. -- To view, visit https://gerrit.ovirt.org/55603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: PoC: enforcement of contract for rpc
Piotr Kliczewski has posted comments on this change. Change subject: PoC: enforcement of contract for rpc .. Patch Set 2: We still want to have this patch around for some time. -- To view, visit https://gerrit.ovirt.org/50032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25c58fb7cb90fc74eceb902aa4748b0025cf96f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: broken unsubscribe process
gerrit-hooks has posted comments on this change. Change subject: stomp: broken unsubscribe process .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/45617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45c5741f4d94b7af138e98661cfe418cbb0a2b6b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: broken unsubscribe process
Piotr Kliczewski has abandoned this change. Change subject: stomp: broken unsubscribe process .. Abandoned It looks like we do not want this patch. -- To view, visit https://gerrit.ovirt.org/45617 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I45c5741f4d94b7af138e98661cfe418cbb0a2b6b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix 186c8574: When using SSL, use the original host
gerrit-hooks has posted comments on this change. Change subject: fix 186c8574: When using SSL, use the original host .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix 186c8574: When using SSL, use the original host
Dan Kenigsberg has posted comments on this change. Change subject: fix 186c8574: When using SSL, use the original host .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Artyom Lukianov has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/checkipsd File vdsm_hooks/checkips/checkipsd: Line 58: def _ping_address(address, address_type, net): Line 59: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 60: command = [ Line 61: ping_cmd, Line 62: '-c', '1', > This is actually interesting. Suppose we have '-c 3' - and only two pings r So if I send: ping -c 3 -w 15 some_address it will send echo packet each second until timeout or until it receives 3 packets back, so if the timeout happens we will receive rc=1(do not matter if we received two packets) so I can change -c parameter to something like: timeout - 1, so we wait that 14 from 15 packets will recieved but I want first hear Dan opinion Line 63: '-w', str(PING_TIMEOUT), Line 64: '-I', net, Line 65: address Line 66: ] -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix 186c8574: When using SSL, use the original host
Jenkins CI has posted comments on this change. Change subject: fix 186c8574: When using SSL, use the original host .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/55620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3
Dan Kenigsberg has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3 .. Patch Set 10: Verified+1 build and test pass on el7 without python34 -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3
Dan Kenigsberg has submitted this change and it was merged. Change subject: Build without supporting python3 by using --disable-python3 .. Build without supporting python3 by using --disable-python3 Over some environments we still don't have all required packages for python3. Therefore VDSM build should support build process without python3 dependencies. Using --disable-python3 configure flag will build vdsm without using python3. Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Signed-off-by: Yaniv Bronhaim Reviewed-on: https://gerrit.ovirt.org/55517 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-by: Nir Soffer Tested-by: Dan Kenigsberg --- M Makefile.am M configure.ac M contrib/rhev_build.sh M tests/Makefile.am M vdsm.spec.in 5 files changed, 44 insertions(+), 15 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3
gerrit-hooks has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3 .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Relocate hooking (api) module under lib
Edward Haas has posted comments on this change. Change subject: hooks: Relocate hooking (api) module under lib .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/55544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix 186c8574: When using SSL, use the original host
Edward Haas has posted comments on this change. Change subject: fix 186c8574: When using SSL, use the original host .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/55620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
gerrit-hooks has posted comments on this change. Change subject: net: Libvirt hook that enables ovs-legacy migration .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Relocate hooking (api) module under lib
gerrit-hooks has posted comments on this change. Change subject: hooks: Relocate hooking (api) module under lib .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix 186c8574: When using SSL, use the original host
gerrit-hooks has posted comments on this change. Change subject: fix 186c8574: When using SSL, use the original host .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Relocate hooking (api) module under lib
Yaniv Bronhaim has posted comments on this change. Change subject: hooks: Relocate hooking (api) module under lib .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix 186c8574: When using SSL, use the original host
gerrit-hooks has posted comments on this change. Change subject: fix 186c8574: When using SSL, use the original host .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Relocate hooking (api) module under lib
gerrit-hooks has posted comments on this change. Change subject: hooks: Relocate hooking (api) module under lib .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix 186c8574: When using SSL, use the original host
Edward Haas has uploaded a new change for review. Change subject: fix 186c8574: When using SSL, use the original host .. fix 186c8574: When using SSL, use the original host When a connection to a remote is perform and encryption (SSL) is enabled, the original target host should be used for the connection and not a resolved one. This bug has been detected when trying to connect to a remote IPv4 host, with a hostname as the target host and SSL enabled. The host got resolved before calling connect, and therefore the certificate has not been matched correctly (expected a hostname but used a resilved IPv4 address). Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Signed-off-by: Edward Haas --- M lib/vdsm/utils.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/55620/1 diff --git a/lib/vdsm/utils.py b/lib/vdsm/utils.py index 13a8bc1..2370fcd 100644 --- a/lib/vdsm/utils.py +++ b/lib/vdsm/utils.py @@ -857,7 +857,7 @@ sock = sslctx.wrapSocket(sock) sock.settimeout(timeout) -sock.connect(sockaddr) +sock.connect((host, port)) return sock -- To view, visit https://gerrit.ovirt.org/55620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd54bcddd5ab676d94f7a5965a061d1a3cb1f40a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
gerrit-hooks has posted comments on this change. Change subject: net: Libvirt hook that enables ovs-legacy migration .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Relocate hooking (api) module under lib
Edward Haas has posted comments on this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Patch Set 4:
(1 comment)
I tried to use softlink, unfortunately it does not work: Unable to import a
softlink without having the target on the search path.
https://gerrit.ovirt.org/#/c/55544/4/vdsm.spec.in
File vdsm.spec.in:
Line 1097: %{python_sitelib}/%{vdsm_name}/dmidecodeUtil.py*
Line 1098: %{python_sitelib}/%{vdsm_name}/exception.py*
Line 1099: %{python_sitelib}/%{vdsm_name}/executor.py*
Line 1100: %{python_sitelib}/%{vdsm_name}/health.py*
Line 1101: %{python_sitelib}/%{vdsm_name}/hooking.py*
> please add it to debian/vdsm-python.install as well
Ok, I will
Line 1102: %{python_sitelib}/%{vdsm_name}/hooks.py*
Line 1103: %{python_sitelib}/%{vdsm_name}/host.py*
Line 1104: %{python_sitelib}/%{vdsm_name}/hostdev.py*
Line 1105: %{python_sitelib}/%{vdsm_name}/ipwrapper.py*
--
To view, visit https://gerrit.ovirt.org/55544
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
Nir Soffer has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 5: Continuous-Integration+1 Tested locally using: git clean -dxf && ./autogen.sh --system && make && make check && make rpm -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
Nir Soffer has submitted this change and it was merged. Change subject: storagetests: add test for mount.isMounted .. storagetests: add test for mount.isMounted Given a local path, this test verifies that the expected fs_file is found in /proc/mounts by calling mount.isMounted. Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Related-To: https://bugzilla.redhat.com/1305529 Signed-off-by: Idan Shaby Reviewed-on: https://gerrit.ovirt.org/55180 Reviewed-by: Nir Soffer Continuous-Integration: Nir Soffer Continuous-Integration: Jenkins CI --- M tests/mountTests.py 1 file changed, 40 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
gerrit-hooks has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Relocate hooking (api) module under lib
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Relocate hooking (api) module under lib
..
Patch Set 4:
(1 comment)
basically im fine with that.. however, softlink might look better :\ not sure
https://gerrit.ovirt.org/#/c/55544/4/vdsm.spec.in
File vdsm.spec.in:
Line 1097: %{python_sitelib}/%{vdsm_name}/dmidecodeUtil.py*
Line 1098: %{python_sitelib}/%{vdsm_name}/exception.py*
Line 1099: %{python_sitelib}/%{vdsm_name}/executor.py*
Line 1100: %{python_sitelib}/%{vdsm_name}/health.py*
Line 1101: %{python_sitelib}/%{vdsm_name}/hooking.py*
please add it to debian/vdsm-python.install as well
Line 1102: %{python_sitelib}/%{vdsm_name}/hooks.py*
Line 1103: %{python_sitelib}/%{vdsm_name}/host.py*
Line 1104: %{python_sitelib}/%{vdsm_name}/hostdev.py*
Line 1105: %{python_sitelib}/%{vdsm_name}/ipwrapper.py*
--
To view, visit https://gerrit.ovirt.org/55544
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
Nir Soffer has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 5: Code-Review+1 Failing tests looks good, we need to add the other failing tests that require the fixes in the next patch. -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
Nir Soffer has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example
Yaniv Bronhaim has posted comments on this change. Change subject: test: Replacing MonkeyPatch with mock.patch example .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/55603/2/tests/network/netinfo_test.py File tests/network/netinfo_test.py: Line 87 Line 88 Line 89 Line 90 Line 91 what about those mocks ^? Line 114 Line 115 Line 116 Line 117 Line 118 what about _detectType and _GetBondingOptions mocks? Line 282 Line 283 Line 284 Line 285 Line 286 how is it not needed anymore? -- To view, visit https://gerrit.ovirt.org/55603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Nir Soffer has submitted this change and it was merged. Change subject: network: add hosttail_join to address.py .. network: add hosttail_join to address.py Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Related-To: https://bugzilla.redhat.com/1305529 Signed-off-by: Idan Shaby Reviewed-on: https://gerrit.ovirt.org/55473 Reviewed-by: Edward Haas Reviewed-by: Dan Kenigsberg Reviewed-by: Nir Soffer Reviewed-by: Freddy Rolland Continuous-Integration: Jenkins CI --- M lib/vdsm/common/network/address.py M tests/common/network_test.py 2 files changed, 34 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
gerrit-hooks has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: Libvirt hook that enables ovs-legacy migration
gerrit-hooks has posted comments on this change. Change subject: net: Libvirt hook that enables ovs-legacy migration .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cf441cc365d3679382e44410dad0906d9be3ec Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Idan Shaby has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Relocate hooking (api) module under lib
gerrit-hooks has posted comments on this change. Change subject: hooks: Relocate hooking (api) module under lib .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Yaniv Kaul has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/checkipsd File vdsm_hooks/checkips/checkipsd: Line 58: def _ping_address(address, address_type, net): Line 59: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 60: command = [ Line 61: ping_cmd, Line 62: '-c', '1', > I checked a little behaviour of ping command: This is actually interesting. Suppose we have '-c 3' - and only two pings returned. What do we say about the connectivity? (I don't have a very good answer for 3. For 10 pings, I expect 9/10 - but I wonder in what error code ping would come out with!). Line 63: '-w', str(PING_TIMEOUT), Line 64: '-I', net, Line 65: address Line 66: ] -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Artyom Lukianov has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 11: (9 comments) https://gerrit.ovirt.org/#/c/54102/11/configure.ac File configure.ac: Line 400: vdsm/virt/Makefile Line 401: vdsm/virt/vmdevices/Makefile Line 402: vdsm_hooks/Makefile Line 403: vdsm_hooks/allocate_net/Makefile Line 404: vdsm_hooks/checkips/Makefile > checkips should come after checkimages. I believe we sort alphabetically? Done Line 405: vdsm_hooks/checkimages/Makefile Line 406: vdsm_hooks/diskunmap/Makefile Line 407: vdsm_hooks/ethtool_options/Makefile Line 408: vdsm_hooks/extnet/Makefile https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/Makefile.am File vdsm_hooks/Makefile.am: Line 34: # Additional hooks Line 35: if HOOKS Line 36: SUBDIRS += \ Line 37:allocate_net \ Line 38:checkips \ > same as previously - should come after checkimages. Done Line 39:checkimages \ Line 40:diskunmap \ Line 41:extnet \ Line 42:extra_ipv4_addrs \ https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/README File vdsm_hooks/checkips/README: Line 34: In the host setup network configuration window, choose edit assigned Line 35: logical network, select custom property checkipv4 or checkipv6 and Line 36: enter VLAN IP or FQDN that you want to check for Line 37: connectivity(examples 8.8.8.8,2001:4860:4860::). So if you defined Line 38: checipv4 and checipv6 custom properties and if the host fails to ping > typo: checipv4 -> checkipv4 Done Line 39: both IP's, it will drop the network's state to down. Line 40: If the network is defined as "required", https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/after_get_stats.py File vdsm_hooks/checkips/after_get_stats.py: Line 47: Line 48: CONNECTIVITY_TIMEOUT = 60 Line 49: Line 50: Line 51: def _is_network_accessible(net, stats_dir): > the name of the function is not related to what it does? Done Line 52: file_path = os.path.join(stats_dir, net) Line 53: if os.path.exists(file_path): Line 54: return ( Line 55: time.time() - os.stat(file_path).st_mtime <= Line 124: print( Line 125: 'test %s: interface %s has state %s' % Line 126: (test_msg, interface, state) Line 127: ) Line 128: os.unlink(os.path.join(temp_dir, 'check_ipv4')) > Perhaps worth putting all this in a finally (and the above in a try, so any Done Line 129: os.unlink(os.path.join(temp_dir, 'check_ipv6')) Line 130: os.rmdir(temp_dir) Line 131: Line 132: https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/checkipsd File vdsm_hooks/checkips/checkipsd: Line 1: #!/usr/bin/python > Shouldn't this file have a .py extension? I removed it because it used as a daemon and I saw we use the same approach for other vdsm services: mom - /usr/sbin/momd vdsm - /usr/share/vdsm/daemonAdapter ... Line 2: # Line 3: # Copyright 2008-2016 Red Hat, Inc. Line 4: # Line 5: # This program is free software; you can redistribute it and/or modify Line 35: CHECKIPV6 = 'checkipv6' Line 36: VDSM_CHECKIPS = 'vdsm-checkips' Line 37: Line 38: Line 39: def get_ping_addresses(net_attrs): > Isn't this function available in the utils? yes, but I can not use it, because checkips does not python module and also I do not want to include it to PYTHONPATH so when I install package: checkipsd - placed under /usr/libexec/vdsm/hooks and checips_utils.py - under /usr/libexec/vdsm/hooks/after_get_stats/ and I will recieve import error Line 40: ping_addresses = [] Line 41: if 'custom' in net_attrs: Line 42: for address_type in (CHECKIPV4, CHECKIPV6): Line 43: if address_type in net_attrs['custom']: Line 54: with open(file_path, 'a'): Line 55: os.utime(file_path, None) Line 56: Line 57: Line 58: def _ping_address(address, address_type, net): > rename 'net' to 'interface' ? it does not really interface, it is rhevm network name, I can change it to network, if you prefer Line 59: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 60: command = [ Line 61: ping_cmd, Line 62: '-c', '1', Line 58: def _ping_address(address, address_type, net): Line 59: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 60: command = [ Line 61: ping_cmd, Line 62: '-c', '1', > There were several comments that a single ping is not enough. For example, I checked a little behaviour of ping command: 1) if address pingable it sends number of packets equal to parameter under -c 2) if address does not pingable it sends packet each second until it reaches timeout ping -c 1 -w 15 10.35.4.204 PING 10.35.4.204 (10.35.4.204) 56(84) bytes of data. --- 10.35.4.204 ping statistics --- 15 packets transmitted, 0 received, 100% packet loss, ti
Change in vdsm[master]: storagetests: add test for mount.isMounted
Idan Shaby has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 5: Verified+1 (4 comments) https://gerrit.ovirt.org/#/c/55180/4/tests/mountTests.py File tests/mountTests.py: Line 303: Line 304: def test_is_mounted(self): Line 305: with fake_mounts([b"server:/path " Line 306: b"/rhev/data-center/mnt/server:_path " Line 307: b"nfs4 defaults 0 0"]): > Use b"..." for all strings here Done Line 308: self.assertTrue(mount.isMounted( Line 309: b"/rhev/data-center/mnt/server:_path")) Line 310: Line 311: def test_is_not_mounted(self): Line 305: with fake_mounts([b"server:/path " Line 306: b"/rhev/data-center/mnt/server:_path " Line 307: b"nfs4 defaults 0 0"]): Line 308: self.assertTrue(mount.isMounted( Line 309: b"/rhev/data-center/mnt/server:_path")) > Use b"..." for all strings here Done Line 310: Line 311: def test_is_not_mounted(self): Line 312: with fake_mounts([b"server:/path " Line 313: b"/rhev/data-center/mnt/server:_path " Line 310: Line 311: def test_is_not_mounted(self): Line 312: with fake_mounts([b"server:/path " Line 313: b"/rhev/data-center/mnt/server:_path " Line 314: b"nfs4 defaults 0 0"]): > Use b"..." for all strings here Done Line 315: self.assertFalse(mount.isMounted( Line 312: with fake_mounts([b"server:/path " Line 313: b"/rhev/data-center/mnt/server:_path " Line 314: b"nfs4 defaults 0 0"]): Line 315: self.assertFalse(mount.isMounted( Line 316: b"/rhev/data-center/mnt/server:_other_path")) > Use b"..." for all strings here Done -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
gerrit-hooks has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 8: * #1305529::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1305529::OK, public bug * Check Product::#1305529::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
gerrit-hooks has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
gerrit-hooks has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
gerrit-hooks has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Move mount module to vdsm storage lib.
Nir Soffer has posted comments on this change. Change subject: storage: Move mount module to vdsm storage lib. .. Patch Set 9: (8 comments) https://gerrit.ovirt.org/#/c/55292/9/lib/vdsm/storage/Makefile.am File lib/vdsm/storage/Makefile.am: Line 26:constants.py \ Line 27:exception.py \ Line 28:persistent.py \ Line 29:securable.py \ Line 30: mount.py \ Must use tab here, not spaces. Line 31:sync.py \ https://gerrit.ovirt.org/#/c/55292/9/tests/mkimageTests.py File tests/mkimageTests.py: Line 34 Line 35 Line 36 Line 37 Line 38 Import should be here. Line 38: Line 39: from vdsm import udevadm Line 40: from vdsm.commands import execCmd Line 41: from vdsm.utils import stopwatch Line 42: from vdsm import storage Move before "from vdsm import udevadm" Less specific import come before more specific imports. Line 43: import mkimage Line 44: Line 45: Line 46: @expandPermutations https://gerrit.ovirt.org/#/c/55292/9/tests/mountTests.py File tests/mountTests.py: Line 25 Line 26 Line 27 Line 28 Line 29 "from vdsm" imports should be grouped here (sorted) Line 32: Line 33: from testlib import VdsmTestCase as TestCaseBase Line 34: from testlib import namedTemporaryDir, expandPermutations, permutations Line 35: from storage.misc import execCmd Line 36: import vdsm.storage.mount as mount from vdsm.storage import mount And move it up to the "from vdsm" imports. Line 37: from testValidation import checkSudo Line 38: import monkeypatch Line 39: Line 40: FLOPPY_SIZE = (2 ** 20) * 4 https://gerrit.ovirt.org/#/c/55292/9/vdsm/mkimage.py File vdsm/mkimage.py: Line 31: DISKIMAGE_USER, DISKIMAGE_GROUP Line 32: from vdsm.constants import P_VDSM_RUN Line 33: from vdsm.commands import execCmd Line 34: from vdsm.utils import rmFile Line 35: from vdsm import storage Move before "from vdsm.constants ..." (less specific before more specific) Line 36: from storage.fileUtils import resolveUid, resolveGid Line 37: Line 38: _P_PAYLOAD_IMAGES = os.path.join(P_VDSM_RUN, 'payload') Line 39: https://gerrit.ovirt.org/#/c/55292/9/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 37: from vdsm import udevadm Line 38: from vdsm import utils Line 39: from vdsm.storage import exception as se Line 40: from vdsm.storage import sync Line 41: from vdsm.storage import mount Move under "from vdsm.storage import exception" Line 42: from vdsm.storage.mount import MountError Line 43: Line 44: import fileUtils Line 45: import fileSD Line 38: from vdsm import utils Line 39: from vdsm.storage import exception as se Line 40: from vdsm.storage import sync Line 41: from vdsm.storage import mount Line 42: from vdsm.storage.mount import MountError Leave it here, we need to eliminate this import later. Line 43: Line 44: import fileUtils Line 45: import fileSD Line 46: import iscsi -- To view, visit https://gerrit.ovirt.org/55292 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee9fab87abcabc469c15256ba12386112a100e0 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: canonicalize 'switch' in nets and bonds
Petr Horáček has posted comments on this change. Change subject: net: canonicalize 'switch' in nets and bonds .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/55495/5/lib/vdsm/network/canonicalize.py File lib/vdsm/network/canonicalize.py: Line 105: if 'dhcpv6' not in data: Line 106: data['dhcpv6'] = False Line 107: Line 108: Line 109: def _canonicalize_switch(data): > Well... you do use it in later patches. the second point convinced me. Line 110: if 'switch' not in data: -- To view, visit https://gerrit.ovirt.org/55495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71b6c0ae1a0027bbacf7da7dc8e4cd2926cbcb7d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3
Nir Soffer has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3 .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
Nir Soffer has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/55182/7/vdsm/storage/nfsSD.py File vdsm/storage/nfsSD.py: Line 72: if not misc.isAscii(domainName) and not sd.supportsUnicode(version): Line 73: raise se.UnicodeArgumentException() Line 74: Line 75: # Create local path Line 76: mntPath = fileUtils.transformSpec(remotePath) > The spec should be normalized when entering the system, not in this layer. Check this, this method is used by both posix and nfs domains, and gluster inherit this create method, so this seems to the correct to normalize the remote path on this flow. But there are other places that need remote path normalization, one of them is getStorageDomainsList, and we may have other places. This patch must fix all the place where remote path enter the system, otherwise the "fix" will introduce a regression. However it seems that transformSpec is not useful, and we should separate remote path normalization and local path creation, as we do in storageServer. Line 77: Line 78: mntPoint = cls.getMountPoint(mntPath) Line 79: Line 80: cls._preCreateValidation(sdUUID, mntPoint, remotePath, storageType, -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Nir Soffer has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 5: Dan, you can take this patch now, there is no dependency on the previous patches. -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
Nir Soffer has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 7:
(6 comments)
https://gerrit.ovirt.org/#/c/55182/7/vdsm/storage/fileUtils.py
File vdsm/storage/fileUtils.py:
Line 38
Line 39
Line 40
Line 41
Line 42
Put it here:
from vdsm.common.network import address
Line 30: from StringIO import StringIO
Line 31: from contextlib import closing
Line 32: import ctypes
Line 33: from contextlib import contextmanager
Line 34: from vdsm.common.network import address as ipaddress
This import should be near the other vdsm imports. Also do not call this
ipaddress, it has nothing to do with ip address.
Line 35: import subprocess
Line 36: import shutil
Line 37: import logging
Line 38: import errno
https://gerrit.ovirt.org/#/c/55182/7/vdsm/storage/mount.py
File vdsm/storage/mount.py:
Line 51: fs_freq, fs_passno) = line.split()[:6]
Line 52: fs_mntops = fs_mntops.split(",")
Line 53: fs_freq = int(fs_freq)
Line 54: fs_passno = int(fs_passno)
Line 55: fs_spec = fileUtils.normalize_spec(_parseFstabPath(fs_spec))
This looks good since this is one of the places where spec enter the system.
We need a test failing without this change.
Line 56:
Line 57: fs_file = normpath(_parseFstabPath(fs_file))
Line 58: for suffix in (" (deleted)", ):
Line 59: if not fs_file.endswith(suffix):
Line 194:
Line 195:
Line 196: class Mount(object):
Line 197: def __init__(self, fs_spec, fs_file):
Line 198: self.fs_spec = fileUtils.normalize_spec(fs_spec)
We normalize the spec in storageServer.MountConnection, so this normalization
should not needed.
We also need a failing test that this change fix.
Line 199: self.fs_file = normpath(fs_file)
Line 200:
Line 201: def __eq__(self, other):
Line 202: return (self.__class__ == other.__class__ and
https://gerrit.ovirt.org/#/c/55182/7/vdsm/storage/nfsSD.py
File vdsm/storage/nfsSD.py:
Line 72: if not misc.isAscii(domainName) and not
sd.supportsUnicode(version):
Line 73: raise se.UnicodeArgumentException()
Line 74:
Line 75: # Create local path
Line 76: mntPath = fileUtils.transformSpec(remotePath)
The spec should be normalized when entering the system, not in this layer. Find
how this value got here unnormalized.
Having to do this in nfs storage domain is strange, I would expect that this is
needed for all file based storage domains.
Line 77:
Line 78: mntPoint = cls.getMountPoint(mntPath)
Line 79:
Line 80: cls._preCreateValidation(sdUUID, mntPoint, remotePath,
storageType,
https://gerrit.ovirt.org/#/c/55182/7/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 209: def __init__(self, spec, vfsType=None, options="",
mountClass=mount.Mount):
Line 210: self._vfsType = vfsType
Line 211: # Note: must be normalized before we escape "/" in
_getLocalPath.
Line 212: # See https://bugzilla.redhat.com/1300749
Line 213: self._remotePath = fileUtils.normalize_spec(spec)
This looks good, but may be the wrong place for normalization, since we know
that nfsSD is using unnormalized remotePath.
The normalization may be needed in higher layer like hsm.py.
Line 214: self._options = options
Line 215: self._mount = mountClass(spec, self._getLocalPath())
Line 216:
Line 217: def _getLocalPath(self):
--
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Yaniv Kaul has posted comments on this change. Change subject: hooks:checkips: add checkips hook .. Patch Set 11: (9 comments) Some minor comments added. https://gerrit.ovirt.org/#/c/54102/11/configure.ac File configure.ac: Line 400: vdsm/virt/Makefile Line 401: vdsm/virt/vmdevices/Makefile Line 402: vdsm_hooks/Makefile Line 403: vdsm_hooks/allocate_net/Makefile Line 404: vdsm_hooks/checkips/Makefile checkips should come after checkimages. I believe we sort alphabetically? Line 405: vdsm_hooks/checkimages/Makefile Line 406: vdsm_hooks/diskunmap/Makefile Line 407: vdsm_hooks/ethtool_options/Makefile Line 408: vdsm_hooks/extnet/Makefile https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/Makefile.am File vdsm_hooks/Makefile.am: Line 34: # Additional hooks Line 35: if HOOKS Line 36: SUBDIRS += \ Line 37:allocate_net \ Line 38:checkips \ same as previously - should come after checkimages. Line 39:checkimages \ Line 40:diskunmap \ Line 41:extnet \ Line 42:extra_ipv4_addrs \ https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/README File vdsm_hooks/checkips/README: Line 34: In the host setup network configuration window, choose edit assigned Line 35: logical network, select custom property checkipv4 or checkipv6 and Line 36: enter VLAN IP or FQDN that you want to check for Line 37: connectivity(examples 8.8.8.8,2001:4860:4860::). So if you defined Line 38: checipv4 and checipv6 custom properties and if the host fails to ping typo: checipv4 -> checkipv4 Line 39: both IP's, it will drop the network's state to down. Line 40: If the network is defined as "required", https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/after_get_stats.py File vdsm_hooks/checkips/after_get_stats.py: Line 47: Line 48: CONNECTIVITY_TIMEOUT = 60 Line 49: Line 50: Line 51: def _is_network_accessible(net, stats_dir): the name of the function is not related to what it does? Line 52: file_path = os.path.join(stats_dir, net) Line 53: if os.path.exists(file_path): Line 54: return ( Line 55: time.time() - os.stat(file_path).st_mtime <= Line 124: print( Line 125: 'test %s: interface %s has state %s' % Line 126: (test_msg, interface, state) Line 127: ) Line 128: os.unlink(os.path.join(temp_dir, 'check_ipv4')) Perhaps worth putting all this in a finally (and the above in a try, so any exception would still remove the files and the directory? Line 129: os.unlink(os.path.join(temp_dir, 'check_ipv6')) Line 130: os.rmdir(temp_dir) Line 131: Line 132: https://gerrit.ovirt.org/#/c/54102/11/vdsm_hooks/checkips/checkipsd File vdsm_hooks/checkips/checkipsd: Line 1: #!/usr/bin/python Shouldn't this file have a .py extension? Line 2: # Line 3: # Copyright 2008-2016 Red Hat, Inc. Line 4: # Line 5: # This program is free software; you can redistribute it and/or modify Line 35: CHECKIPV6 = 'checkipv6' Line 36: VDSM_CHECKIPS = 'vdsm-checkips' Line 37: Line 38: Line 39: def get_ping_addresses(net_attrs): Isn't this function available in the utils? Line 40: ping_addresses = [] Line 41: if 'custom' in net_attrs: Line 42: for address_type in (CHECKIPV4, CHECKIPV6): Line 43: if address_type in net_attrs['custom']: Line 54: with open(file_path, 'a'): Line 55: os.utime(file_path, None) Line 56: Line 57: Line 58: def _ping_address(address, address_type, net): rename 'net' to 'interface' ? Line 59: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 60: command = [ Line 61: ping_cmd, Line 62: '-c', '1', Line 58: def _ping_address(address, address_type, net): Line 59: ping_cmd = 'ping' if address_type == CHECKIPV4 else 'ping6' Line 60: command = [ Line 61: ping_cmd, Line 62: '-c', '1', There were several comments that a single ping is not enough. For example, in hosted-engine setup - there was a request to try with more pings. I'd either have it as a variable, or by default use more than a single ping. Line 63: '-w', str(PING_TIMEOUT), Line 64: '-I', net, Line 65: address Line 66: ] -- To view, visit https://gerrit.ovirt.org/54102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov Gerrit-Reviewer: Artyom Lukianov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/
Change in vdsm[master]: storagetests: add test for mount.isMounted
Nir Soffer has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/55180/4/tests/mountTests.py File tests/mountTests.py: Line 303: Line 304: def test_is_mounted(self): Line 305: with fake_mounts(["server:/path " Line 306: "/rhev/data-center/mnt/server:_path " Line 307: "nfs4 defaults 0 0"]): Use b"..." for all strings here Line 308: self.assertTrue(mount.isMounted( Line 309: "/rhev/data-center/mnt/server:_path")) Line 310: Line 311: def test_is_not_mounted(self): Line 305: with fake_mounts(["server:/path " Line 306: "/rhev/data-center/mnt/server:_path " Line 307: "nfs4 defaults 0 0"]): Line 308: self.assertTrue(mount.isMounted( Line 309: "/rhev/data-center/mnt/server:_path")) Use b"..." for all strings here Line 310: Line 311: def test_is_not_mounted(self): Line 312: with fake_mounts(["server:/path " Line 313: "/rhev/data-center/mnt/server:_path " Line 310: Line 311: def test_is_not_mounted(self): Line 312: with fake_mounts(["server:/path " Line 313: "/rhev/data-center/mnt/server:_path " Line 314: "nfs4 defaults 0 0"]): Use b"..." for all strings here Line 315: self.assertFalse(mount.isMounted( Line 312: with fake_mounts(["server:/path " Line 313: "/rhev/data-center/mnt/server:_path " Line 314: "nfs4 defaults 0 0"]): Line 315: self.assertFalse(mount.isMounted( Line 316: "/rhev/data-center/mnt/server:_other_path")) Use b"..." for all strings here -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Freddy Rolland has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Handle closed stream when virt-v2v fails
Nir Soffer has posted comments on this change. Change subject: Handle closed stream when virt-v2v fails .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Nir Soffer has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Handle closed stream when virt-v2v fails
gerrit-hooks has posted comments on this change. Change subject: Handle closed stream when virt-v2v fails .. Patch Set 1: * #1298134::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298134::OK, public bug * Check Product::#1298134::OK, Correct classification oVirt * Check TM::#1298134::OK, correct target milestone ovirt-3.6.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/55607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Handle closed stream when virt-v2v fails
Shahar Havivi has posted comments on this change. Change subject: Handle closed stream when virt-v2v fails .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/55607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Shahar Havivi Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: Handle closed stream when virt-v2v fails
Shahar Havivi has uploaded a new change for review.
Change subject: Handle closed stream when virt-v2v fails
..
Handle closed stream when virt-v2v fails
When file object is closed by the other side, read return empty string,
previously we assumed an exception is raised.
Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e
Bug-Url: https://bugzilla.redhat.com/1298134
Signed-off-by: Shahar Havivi
---
M vdsm/v2v.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/55607/1
diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index 29eaa56..f54b9e2 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -623,6 +623,8 @@
chunk = ''
while True:
c = stream.read(1)
+if not c:
+raise OutputParserError('copy-disk stream closed unexpectedly')
chunk += c
if c == '\r':
yield chunk
--
To view, visit https://gerrit.ovirt.org/55607
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia166c1aa03a8d62168034cd581be80ef5a3dc69e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Artyom Lukianov has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/54102/11/vdsm.spec.in
File vdsm.spec.in:
Line 715: install -Dm 0644 init/systemd/vdsm-network.service
%{buildroot}%{_unitdir}/vdsm-network.service
Line 716: install -Dm 0644 init/systemd/supervdsmd.service
%{buildroot}%{_unitdir}/supervdsmd.service
Line 717:
Line 718: install -Dm 0644 init/systemd/mom-vdsm.service
%{buildroot}%{_unitdir}/mom-vdsm.service
Line 719:
> try to build with --disable-hooks and see my error.
ok thx for explanation
Line 720: install -Dm 0644 vdsm_hooks/checkips/vdsm-checkips.service
%{buildroot}%{_unitdir}/vdsm-checkips.service
Line 721:
Line 722: install -Dm 0644 vdsm/vdsm-modules-load.d.conf \
Line 723: %{buildroot}%{_sysconfdir}/modules-load.d/vdsm.conf
--
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov
Gerrit-Reviewer: Artyom Lukianov
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Build without supporting python3 by using --disable-python3
Dan Kenigsberg has posted comments on this change. Change subject: Build without supporting python3 by using --disable-python3 .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7437f7dbc2a1e08fcaf8e2a59de6259a94440e0 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Dan Kenigsberg has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 5: Code-Review+2 raising Edy's score -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example
Edward Haas has posted comments on this change. Change subject: test: Replacing MonkeyPatch with mock.patch example .. Patch Set 2: This patch demonstrates how mock can be used to replace MonkeyPatch. However, I highly recommend not to use it in this manner (for new code) unless you have to. I would recommend using the automatic mockers that mock provides, setting them up and then asserting on them. -- To view, visit https://gerrit.ovirt.org/55603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example
gerrit-hooks has posted comments on this change. Change subject: test: Replacing MonkeyPatch with mock.patch example .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks:checkips: add checkips hook
Dan Kenigsberg has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/54102/11/vdsm.spec.in
File vdsm.spec.in:
Line 715: install -Dm 0644 init/systemd/vdsm-network.service
%{buildroot}%{_unitdir}/vdsm-network.service
Line 716: install -Dm 0644 init/systemd/supervdsmd.service
%{buildroot}%{_unitdir}/supervdsmd.service
Line 717:
Line 718: install -Dm 0644 init/systemd/mom-vdsm.service
%{buildroot}%{_unitdir}/mom-vdsm.service
Line 719:
try to build with --disable-hooks and see my error.
put this install into
%if 0%{?with_hooks}
%fi
or better (much better) place this install in the Makefile of the new hook.
(yes, I know, automake is a bit of black magic).
Line 720: install -Dm 0644 vdsm_hooks/checkips/vdsm-checkips.service
%{buildroot}%{_unitdir}/vdsm-checkips.service
Line 721:
Line 722: install -Dm 0644 vdsm/vdsm-modules-load.d.conf \
Line 723: %{buildroot}%{_sysconfdir}/modules-load.d/vdsm.conf
--
To view, visit https://gerrit.ovirt.org/54102
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I53cec37310f0f1844d6fe244419fd8c10e9b7ebb
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov
Gerrit-Reviewer: Artyom Lukianov
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Edward Haas has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: debug: Add virt-alignment-scan.debug tool
Nir Soffer has restored this change. Change subject: debug: Add virt-alignment-scan.debug tool .. Restored -- To view, visit https://gerrit.ovirt.org/40896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I2ec4d0219ea039d57ee8809339a7e03d71980bf8 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Idan Shaby has posted comments on this change.
Change subject: network: add hosttail_join to address.py
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/55473/4/tests/common/network_test.py
File tests/common/network_test.py:
Line 68: self.assertNotEqual(('2001::1', '4321'),
Line 69: ipaddress.hosttail_split('2001::1:4321'))
Line 70:
Line 71: @permutations([
Line 72: # Valid host
> What about 'Valid host'?
Done
Line 73: ("server", "/", "server:/"),
Line 74: ("server", "/path", "server:/path"),
Line 75: ("12.34.56.78", "/path", "12.34.56.78:/path"),
Line 76:
Line 77: # IPv6
Line 78: ("2001:db8::60fe:5bf:febc:912", "/path",
Line 79: "[2001:db8::60fe:5bf:febc:912]:/path"),
Line 80:
Line 81: # Invalid host - concatenation still occurs
> What about: 'Invalid host - concatenation still occurs'
Done
Line 82: ("ser:ver", "/path", "[ser:ver]:/path"),
Line 83: ("[2001:db8::60fe:5bf:febc:912]", "/path",
Line 84: "[[2001:db8::60fe:5bf:febc:912]]:/path"),
Line 85: ])
--
To view, visit https://gerrit.ovirt.org/55473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
gerrit-hooks has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 7: * #1305529::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1305529::OK, public bug * Check Product::#1305529::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
gerrit-hooks has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
Edward Haas has posted comments on this change.
Change subject: network: add hosttail_join to address.py
..
Patch Set 4:
(2 comments)
Thanks!
https://gerrit.ovirt.org/#/c/55473/4/tests/common/network_test.py
File tests/common/network_test.py:
Line 68: self.assertNotEqual(('2001::1', '4321'),
Line 69: ipaddress.hosttail_split('2001::1:4321'))
Line 70:
Line 71: @permutations([
Line 72: # Classic cases
What about 'Valid host'?
(Spliting between hostname, ipv4 and ipv6 is optional)
Line 73: ("server", "/", "server:/"),
Line 74: ("server", "/path", "server:/path"),
Line 75: ("12.34.56.78", "/path", "12.34.56.78:/path"),
Line 76:
Line 77: # IPv6
Line 78: ("2001:db8::60fe:5bf:febc:912", "/path",
Line 79: "[2001:db8::60fe:5bf:febc:912]:/path"),
Line 80:
Line 81: # Edge cases
What about: 'Invalid host - concatenation still occurs'
Line 82: ("ser:ver", "/path", "[ser:ver]:/path"),
Line 83: ("[2001:db8::60fe:5bf:febc:912]", "/path",
Line 84: "[[2001:db8::60fe:5bf:febc:912]]:/path"),
Line 85: ])
--
To view, visit https://gerrit.ovirt.org/55473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Idan Shaby
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Tal Nisan
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: build and install vdsm only after spec or makefi...
Yaniv Bronhaim has uploaded a new change for review. Change subject: automation: build and install vdsm only after spec or makefile change .. automation: build and install vdsm only after spec or makefile change Change-Id: I45a872e0c9d3879e6c73c846f2cf11444b288a4a Signed-off-by: Yaniv Bronhaim --- M automation/check-patch.sh 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/55604/1 diff --git a/automation/check-patch.sh b/automation/check-patch.sh index 4c43c5a..ee39565 100755 --- a/automation/check-patch.sh +++ b/automation/check-patch.sh @@ -11,12 +11,11 @@ make check NOSE_WITH_COVERAGE=1 NOSE_COVER_PACKAGE="$PWD/vdsm,$PWD/lib" fi -./automation/build-artifacts.sh - # enable complex globs shopt -s extglob # if specfile was changed, try to install all created packages -if git diff-tree --no-commit-id --name-only -r HEAD | grep --quiet 'vdsm.spec.in' ; then +if git diff-tree --no-commit-id --name-only -r HEAD | grep --quiet 'vdsm.spec.in\|Makefile.am' ; then +./automation/build-artifacts.sh yum -y install "$EXPORT_DIR/"!(*.src).rpm fi -- To view, visit https://gerrit.ovirt.org/55604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45a872e0c9d3879e6c73c846f2cf11444b288a4a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example
Edward Haas has posted comments on this change.
Change subject: test: Replacing MonkeyPatch with mock.patch example
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55603/1/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:
Line 261:
Line 262: finally:
Line 263: bonds.write('-' + bondName)
Line 264:
Line 265: # @MonkeyPatch(bonding, 'BONDING_NAME2NUMERIC_PATH',
The tests pass without these patches.
However, I do not fully understand why the patching is not needed, so until I
clarify the 'why', I'm commenting the patch.
Line 266: # bonding.BONDING_NAME2NUMERIC_PATH
Line 267: # if
os.path.exists(bonding.BONDING_NAME2NUMERIC_PATH)
Line 268: # else '../vdsm/bonding-name2numeric.json')
Line 269: def test_get_bonding_option_numeric_val_exists(self):
--
To view, visit https://gerrit.ovirt.org/55603
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: automation: build and install vdsm only after spec or makefi...
gerrit-hooks has posted comments on this change. Change subject: automation: build and install vdsm only after spec or makefile change .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55604 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a872e0c9d3879e6c73c846f2cf11444b288a4a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
gerrit-hooks has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
gerrit-hooks has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 6: * #1305529::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1305529::OK, public bug * Check Product::#1305529::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example
Edward Haas has uploaded a new change for review.
Change subject: test: Replacing MonkeyPatch with mock.patch example
..
test: Replacing MonkeyPatch with mock.patch example
Replacing MonkeyPatch with mock.patch in netinfo tests, presenting how
to implement the same patching with mock.patch.
Note: The patching logic has been preserved but some patches have been
removed due to no use.
Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e
Signed-off-by: Edward Haas
---
M tests/network/netinfo_test.py
1 file changed, 33 insertions(+), 41 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/55603/1
diff --git a/tests/network/netinfo_test.py b/tests/network/netinfo_test.py
index c8395dd..311555e 100644
--- a/tests/network/netinfo_test.py
+++ b/tests/network/netinfo_test.py
@@ -26,7 +26,6 @@
from nose.plugins.attrib import attr
from vdsm import ipwrapper
-from vdsm import netinfo
from vdsm.netinfo import addresses, bonding, dns, misc, nics, routes
from vdsm.netinfo.cache import get
from vdsm.netlink import addr as nl_addr
@@ -35,8 +34,8 @@
from .ipwrapper_test import _fakeTypeDetection
from modprobe import RequireBondingMod
-from monkeypatch import MonkeyPatch, MonkeyPatchScope
from .nettestlib import dnsmasq_run, dummy_device, veth_pair, wait_for_ipv6
+from testlib import mock
from testlib import VdsmTestCase as TestCaseBase, namedTemporaryDir
from testValidation import ValidateRunningAsRoot
from testValidation import brokentest
@@ -62,7 +61,7 @@
file_path = os.path.join(temp_dir, 'resolv.conf')
for content in (RESOLV_CONF, RESOLV_CONF + '\n'):
-with MonkeyPatchScope([(dns, 'DNS_CONF_FILE', file_path)]):
+with mock.patch('vdsm.netinfo.dns.DNS_CONF_FILE', file_path):
with open(file_path, 'w') as file_object:
file_object.write(content)
@@ -81,14 +80,10 @@
self.assertRaises(ValueError, addresses.prefix2netmask, -1)
self.assertRaises(ValueError, addresses.prefix2netmask, 33)
-@MonkeyPatch(ipwrapper.Link, '_detectType',
- partial(_fakeTypeDetection, ipwrapper.Link))
def testSpeedInvalidNic(self):
nicName = '0' * 20 # devices can't have so long names
self.assertEqual(nics.speed(nicName), 0)
-@MonkeyPatch(ipwrapper.Link, '_detectType',
- partial(_fakeTypeDetection, ipwrapper.Link))
def testSpeedInRange(self):
for d in nics.nics():
s = nics.speed(d)
@@ -106,24 +101,22 @@
(123, 'unknown',0))
for passed, operstate, expected in values:
-with MonkeyPatchScope([(io, 'open',
-lambda x: io.BytesIO(str(passed))),
- (nics, 'operstate',
-lambda x: operstate)]):
+with mock.patch('vdsm.netinfo.nics.io.open',
+lambda x: io.BytesIO(str(passed))), \
+mock.patch('vdsm.netinfo.nics.operstate',
+ lambda x: operstate):
self.assertEqual(nics.speed('fake_nic'), expected)
-@MonkeyPatch(ipwrapper.Link, '_detectType',
- partial(_fakeTypeDetection, ipwrapper.Link))
-@MonkeyPatch(netinfo, 'networks', lambda: {'fake': {'bridged': True}})
-@MonkeyPatch(bonding, '_getBondingOptions', lambda x: {})
+@mock.patch('vdsm.netinfo.cache.netinfo.networks',
+lambda: {'fake': {'bridged': True}})
def testGetNonExistantBridgeInfo(self):
# Getting info of non existing bridge should not raise an exception,
# just log a traceback. If it raises an exception the test will fail as
# it should.
get()
-@MonkeyPatch(netinfo.cache, 'getLinks', lambda: [])
-@MonkeyPatch(netinfo, 'networks', lambda: {})
+@mock.patch('vdsm.netinfo.cache.getLinks', lambda: [])
+@mock.patch('vdsm.netinfo.cache.netinfo.networks', lambda: {})
def testGetEmpty(self):
result = {}
result.update(get())
@@ -190,24 +183,22 @@
not managed due to hidden bond (jbond) enslavement: me0, me1
not managed due to being hidden nics: hid0, hideous
"""
-with MonkeyPatchScope([(netinfo.misc, 'getLinks',
-self._testNics),
- (ipwrapper, '_bondExists',
-lambda x: x == 'jbond'),
- (ipwrapper.Link, '_detectType',
-partial(_fakeTypeDetection, ipwrapper.Link)),
- (ipwrapper.Link, '_fakeNics', ['fake*']),
- (ipwrapper.Link, '_hiddenBonds', ['jb*']),
- (ipwrapper.Link, '_hiddenNics', ['hid*'])
- ])
Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example
gerrit-hooks has posted comments on this change. Change subject: test: Replacing MonkeyPatch with mock.patch example .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: fix spec normalization when mounting
gerrit-hooks has posted comments on this change. Change subject: storage: fix spec normalization when mounting .. Patch Set 5: * #1305529::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1305529::OK, public bug * Check Product::#1305529::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add a test for normalize_local_path
gerrit-hooks has posted comments on this change. Change subject: storagetests: add a test for normalize_local_path .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: add test for mount.isMounted
gerrit-hooks has posted comments on this change. Change subject: storagetests: add test for mount.isMounted .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f2c1c9f9fa03a079e8d94bd91f8e7b4fd43c0ee Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: add hosttail_join to address.py
gerrit-hooks has posted comments on this change. Change subject: network: add hosttail_join to address.py .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b778445117090072d64c89ccfd94aaf3c12fa3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: restore still used types
Yaniv Bronhaim has posted comments on this change. Change subject: schema: restore still used types .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/55574/1//COMMIT_MSG Commit Message: Line 7: schema: restore still used types Line 8: Line 9: It looks like we removed whole category when we removed unused storage Line 10: methods but some of the types are reused by Line 11: StoragePool.connectStorageServer so we need to have them back. put link to the patch Line 12: Line 13: Line 14: Change-Id: I4a0992756e196d112ad3097c680c34516a1934f5 -- To view, visit https://gerrit.ovirt.org/55574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a0992756e196d112ad3097c680c34516a1934f5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding network functional tests to check-merged job
gerrit-hooks has posted comments on this change. Change subject: Adding network functional tests to check-merged job .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/53902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0c2c0e0c40bf9d269bfe1f0c3ca2b78f51ed69 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: David Caro Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
