Change in vdsm[master]: hook: ovs: assert custom bond opts with ':'

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hook: ovs: assert custom bond opts with ':'
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: Add fcoe hook

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 20:

(2 comments)

https://gerrit.ovirt.org/#/c/55029/20/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File vdsm_hooks/fcoe/fcoe_before_network_setup.py:

Line 65: for net, net_attr in six.iteritems(config.networks):
Line 66: if _has_fcoe_param(net_attr):
Line 67: nic = configured[net].get('nic')
Line 68: if nic is None:
Line 69: hooking.exit_hook("Failed to configure fcoe \
your string still has redundant spaces.
As Nir suggest, please break the long sting.
Line 70: on %s with no physical nic" % (net))
Line 71: else:
Line 72: configured[net] = nic
Line 73: 


PS20, Line 70: (net)
purist should use

  (net, )

as (net) is exactly like net.


-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: move momIF to lib

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: move momIF to lib
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54156
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73701b1a2adb53f78c431da9662ac47d36be9912
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lvm: Remove args hack for activateLVs and deactivateLVs

[alitke]

Adam Litke has posted comments on this change.

Change subject: lvm: Remove args hack for activateLVs and deactivateLVs
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f23f5b21217373bd79abdcfe3d4f8cf233b9e90
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Create fake block volume metadata

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Create fake block volume metadata
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6be6abe9cc8217f9b825a45051dd40a4f86717f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use VG tags to store fake block domain md

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Use VG tags to store fake block domain md
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ecba0eba2375f2ce971b9951e35202093c83c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeLVTags

[alitke]

Adam Litke has posted comments on this change.

Change subject: FakeLVM: Add changeLVTags
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeVGTags support

[alitke]

Adam Litke has posted comments on this change.

Change subject: FakeLVM: Add changeVGTags support
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55703
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394062ef899bd45d3da4d8fd584e71931ee1a7e9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Create fake block volume metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Create fake block volume metadata
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55704
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6be6abe9cc8217f9b825a45051dd40a4f86717f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lvm: Remove args hack for activateLVs and deactivateLVs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lvm: Remove args hack for activateLVs and deactivateLVs
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f23f5b21217373bd79abdcfe3d4f8cf233b9e90
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeLVTags

[automation]

gerrit-hooks has posted comments on this change.

Change subject: FakeLVM: Add changeLVTags
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/49546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169fffbc5d865bc987897655a1081b979910c589
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use VG tags to store fake block domain md

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use VG tags to store fake block domain md
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55705
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ecba0eba2375f2ce971b9951e35202093c83c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: Add changeVGTags support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: FakeLVM: Add changeVGTags support
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55703
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394062ef899bd45d3da4d8fd584e71931ee1a7e9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lvm: Remove args hack for activateLVs and deactivateLVs

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: lvm: Remove args hack for activateLVs and deactivateLVs
..

lvm: Remove args hack for activateLVs and deactivateLVs

In order to support calling these functions with either a single LV or a
list of LVs a hack called _normalizeArgs is being used.  The pythonic
way to do this is by using *lvNames in the argument list to indicate
that we expect a variable number of positional arguments.

Change-Id: I5f23f5b21217373bd79abdcfe3d4f8cf233b9e90
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
M vdsm/storage/blockSD.py
M vdsm/storage/lvm.py
M vdsm/storage/resourceFactories.py
5 files changed, 12 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/55846/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 6424fbf..e94cb23 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -133,7 +133,7 @@
 self.lvmd[(vgName, lvName)] = lv_md
 self.vgmd[vgName]['lv_count'] = str(lv_count)
 
-def activateLVs(self, vgName, lvNames):
+def activateLVs(self, vgName, *lvNames):
 for lv in lvNames:
 try:
 lv_md = self.lvmd[(vgName, lv)]
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 4456009..6a87972 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -272,7 +272,7 @@
 with self.base_config() as lvm:
 lvm.createLV(self.VG_NAME, self.LV_NAME, str(self.LV_SIZE_MB),
  activate=False)
-lvm.activateLVs(self.VG_NAME, [self.LV_NAME])
+lvm.activateLVs(self.VG_NAME, self.LV_NAME)
 lv = lvm.getLV(self.VG_NAME, self.LV_NAME)
 self.assertTrue(lv.active)
 self.assertEqual('a', lv.attr.state)
@@ -299,7 +299,7 @@
 
 @permutations([
 [se.VolumeGroupDoesNotExist, 'getVG', ['vg']],
-[se.CannotActivateLogicalVolume, 'activateLVs', ['vg', ['lv']]],
+[se.CannotActivateLogicalVolume, 'activateLVs', ['vg', 'lv']],
 [se.MissingTagOnLogicalVolume, 'addtag', ['vg', 'lv', 'tag']],
 [se.CannotCreateLogicalVolume, 'createLV', ['vg', 'lv', '1024']],
 [se.LogicalVolumeDoesNotExistError, 'getLV', ['vg', 'lv']],
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index e2b2f96..5745f4a 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -455,12 +455,12 @@
 
 def getLeasesFilePath(self):
 # TODO: Determine the path without activating the LV
-lvm.activateLVs(self.sdUUID, [sd.LEASES])
+lvm.activateLVs(self.sdUUID, sd.LEASES)
 return lvm.lvPath(self.sdUUID, sd.LEASES)
 
 def getIdsFilePath(self):
 # TODO: Determine the path without activating the LV
-lvm.activateLVs(self.sdUUID, [sd.IDS])
+lvm.activateLVs(self.sdUUID, sd.IDS)
 return lvm.lvPath(self.sdUUID, sd.IDS)
 
 def extendVolume(self, volumeUUID, size, isShuttingDown=None):
@@ -697,7 +697,7 @@
 domMD = os.path.join(self.domaindir, sd.DOMAIN_META_DATA)
 fileUtils.createdir(domMD)
 
-lvm.activateLVs(self.sdUUID, SPECIAL_LVS)
+lvm.activateLVs(self.sdUUID, *SPECIAL_LVS)
 for lvName in SPECIAL_LVS:
 dst = os.path.join(domMD, lvName)
 if not os.path.lexists(dst):
@@ -807,7 +807,7 @@
 def __init__(self, sdUUID):
 manifest = self.manifestClass(sdUUID)
 sd.StorageDomain.__init__(self, manifest)
-lvm.activateLVs(self.sdUUID, SPECIAL_LVS)
+lvm.activateLVs(self.sdUUID, *SPECIAL_LVS)
 self.metavol = lvm.lvPath(self.sdUUID, sd.METADATA)
 
 # Check that all devices in the VG have the same logical and physical
@@ -1126,7 +1126,7 @@
 self.removeImageLinks(imgUUID)
 allVols = self.getAllVolumes()
 volUUIDs = self._manifest._getImgExclusiveVols(imgUUID, allVols)
-lvm.deactivateLVs(self.sdUUID, volUUIDs)
+lvm.deactivateLVs(self.sdUUID, *volUUIDs)
 
 def linkBCImage(self, imgPath, imgUUID):
 dst = self.getLinkBCImagePath(imgUUID)
@@ -1196,7 +1196,7 @@
 
 If the image is based on a template image it will be activated.
 """
-lvm.activateLVs(self.sdUUID, volUUIDs)
+lvm.activateLVs(self.sdUUID, *volUUIDs)
 vgDir = os.path.join("/dev", self.sdUUID)
 return self.createImageLinks(vgDir, imgUUID, volUUIDs)
 
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index d8aec58..bcfd9ab 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -1184,16 +1184,14 @@
 _resizeLV("lvreduce", vgName, lvName, size)
 
 
-def activateLVs(vgName, lvNames):
-lvNames = _normalizeargs(lvNames)
+def activateLVs(vgName, *lvNames):
 toActivate = [lvName for lvName in lvNames
   if 

Change in vdsm[master]: FakeLVM: support single LV and array in activateLVs

[alitke]

Adam Litke has abandoned this change.

Change subject: FakeLVM: support single LV and array in activateLVs
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/49547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I091aab3c9ccab16e8d4d9693957a061afac1366d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: FakeLVM: support single LV and array in activateLVs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: FakeLVM: support single LV and array in activateLVs
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/49547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I091aab3c9ccab16e8d4d9693957a061afac1366d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Fix configfile to use unicode which allows to add toolTests ...

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Fix configfile to use unicode which allows to add toolTests to 
python3 check
..


Patch Set 14:

(3 comments)

https://gerrit.ovirt.org/#/c/48052/14/automation/check-patch.packages.fc23
File automation/check-patch.packages.fc23:

PS14, Line 5: python3
> Why this dependency is needed?
because once importing configurator.py we also import all configurators 
modules. one of them is sebool.py which requires that


https://gerrit.ovirt.org/#/c/48052/14/lib/vdsm/tool/configfile.py
File lib/vdsm/tool/configfile.py:

Line 114: def _getOldContent(self):
Line 115: confpat = re.compile(r'^\s*(?P[^=\s#]*)\s*=')
Line 116: oldlines = []
Line 117: oldentries = set()
Line 118: with io.open(self._filename, 'r', encoding='utf8') as f:
> Do we have unicode keys and values?
we might have unicode values... i don't know. why to limit?
Line 119: for line in f:
Line 120: if self._remove:
Line 121: if (self._rmstate == BEFORE and
Line 122: line.startswith(self._sectionStart)):


Line 143: oldlines.append(line)
Line 144: return oldlines, oldentries
Line 145: 
Line 146: def _start(self):
Line 147: return u"%s-%s\n" % (self._sectionStart, self._version)
> If working with bytes, use b"%s-%s" % (...)
I prefer to use unicode for configuration file
Line 148: 
Line 149: def _end(self):
Line 150: return u"%s-%s\n" % (self._sectionEnd, self._version)
Line 151: 


-- 
To view, visit https://gerrit.ovirt.org/48052
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52f11a1a10cae46773d05d0c09da80ad8eb3b772
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Fix configfile to use unicode which allows to add toolTests ...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Fix configfile to use unicode which allows to add toolTests to 
python3 check
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/48052
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52f11a1a10cae46773d05d0c09da80ad8eb3b772
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-Reviewer: mooli tayer 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: test: Replacing MonkeyPatch with mock.patch example
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/55603/3/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:

Line 114
Line 115
Line 116
Line 117
Line 118
> The conversion from mockeypatch to mock includes mockeypatch to None.
you can separate it to another patch with explanation why it is not needed any 
more in the commit msg. more appropriate


Line 102: 
Line 103: for passed, operstate, expected in values:
Line 104: with mock.patch('vdsm.netinfo.nics.io.open',
Line 105: lambda x: io.BytesIO(str(passed))), \
Line 106: mock.patch('vdsm.netinfo.nics.operstate',
> The original code was better. Having a way to monkey patch multiple modules
we do prefer to use the standard mock. i don't see any issue with this 
approach, its not uglier not prettier than using MonkeyPatch and it doesn't 
matter. the idea here is to use well documented and standard python mock library
Line 107:lambda x: operstate):
Line 108: self.assertEqual(nics.speed('fake_nic'), expected)
Line 109: 
Line 110: @mock.patch('vdsm.netinfo.cache.netinfo.networks',


-- 
To view, visit https://gerrit.ovirt.org/55603
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34ef99c00e7e2e4bbf13a52ec8471815e81d2a9e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove debian install files from vdsm

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Remove debian install files from vdsm
..


Patch Set 1:

nobody depends on this folder. you are the only one who builds vdsm for debian. 
if you maintain debian/ elsewhere we don't need this one. what other changes 
need to be made?

-- 
To view, visit https://gerrit.ovirt.org/55717
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d8cfa377c93e3bf7717285358a63c0ec28d2972
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spbackends: simplify over-general evaluation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spbackends: simplify over-general evaluation
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/41253
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I775c4a6003a03c6b65bee3abc8559a88e3eaec01
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Remove EL6 comment

[alitke]

Adam Litke has posted comments on this change.

Change subject: qemuimg: Remove EL6 comment
..


Patch Set 1: Code-Review+1

Simple enough to take on its own.

-- 
To view, visit https://gerrit.ovirt.org/55794
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a49424ab9fa8e37655a0f75e3108549b2d1ae8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: move parse_bond_options to netinfo.bonding

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: move parse_bond_options to netinfo.bonding
..

net: move parse_bond_options to netinfo.bonding

Move get_bond_options from ovs hook utils to
vdsm/lib/netinfo/bonding.py, so we can use it in other places.

Change-Id: I4619dad642facfb2dc154251412fd434d934e817
Bug-Url: https://bugzilla.redhat.com/1234867
Signed-off-by: Petr Horáček 
---
M lib/vdsm/netinfo/bonding.py
M tests/network/netinfo_test.py
M vdsm_hooks/ovs/ovs_after_get_caps.py
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
M vdsm_hooks/ovs/ovs_utils.py
5 files changed, 38 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/55841/1

diff --git a/lib/vdsm/netinfo/bonding.py b/lib/vdsm/netinfo/bonding.py
index 76d3115..75ef846 100644
--- a/lib/vdsm/netinfo/bonding.py
+++ b/lib/vdsm/netinfo/bonding.py
@@ -288,3 +288,26 @@
 raise
 
 return _bond_opts_read_elements(opt_path)
+
+
+def parse_bond_options(options, keep_custom=False):
+"""
+Parse bonding options into dictionary, if keep_custom is set to True,
+custom option will not be recursively parsed.
+
+>>> parse_bond_options('mode=4 custom=foo:yes,bar:no')
+{'custom': {'bar': 'no', 'foo': 'yes'}, 'mode': '4'}
+"""
+def _string_to_dict(str, div, eq):
+if options == '':
+return {}
+return dict(option.split(eq, 1)
+for option in str.strip(div).split(div))
+if options:
+d_options = _string_to_dict(options, ' ', '=')
+if d_options.get('custom') and not keep_custom:
+d_options['custom'] = _string_to_dict(d_options['custom'], ',',
+  ':')
+return d_options
+else:
+return {}
diff --git a/tests/network/netinfo_test.py b/tests/network/netinfo_test.py
index c8395dd..131d77c 100644
--- a/tests/network/netinfo_test.py
+++ b/tests/network/netinfo_test.py
@@ -392,6 +392,10 @@
 def _cidr_form(self, ip_addr, prefix_length):
 return '{}/{}'.format(ip_addr, prefix_length)
 
+def test_parse_bond_options(self):
+self.assertEqual(bonding.parse_bond_options('mode=4 custom=foo:bar'),
+ {'custom': {'foo': 'bar'}, 'mode': '4'})
+
 
 @attr(type='integration')
 class TestIPv6Addresses(TestCaseBase):
diff --git a/vdsm_hooks/ovs/ovs_after_get_caps.py 
b/vdsm_hooks/ovs/ovs_after_get_caps.py
index 616a87d..9be00ed 100755
--- a/vdsm_hooks/ovs/ovs_after_get_caps.py
+++ b/vdsm_hooks/ovs/ovs_after_get_caps.py
@@ -23,12 +23,13 @@
 
 from vdsm.netconfpersistence import RunningConfig
 from vdsm.netinfo import dhcp, routes as netinfo_routes, addresses, mtus
+from vdsm.netinfo.bonding import parse_bond_options
 
 from hooking import execCmd
 import hooking
 
-from ovs_utils import (get_bond_options, iter_ovs_nets, iter_ovs_bonds,
-   EXT_OVS_APPCTL, EXT_OVS_VSCTL, BRIDGE_NAME)
+from ovs_utils import (iter_ovs_nets, iter_ovs_bonds, EXT_OVS_APPCTL,
+   EXT_OVS_VSCTL, BRIDGE_NAME)
 
 
 def _get_stp(iface):
@@ -158,7 +159,7 @@
 ovs_bonding_caps = {}
 routes = netinfo_routes.get_routes()
 for bonding, attrs in iter_ovs_bonds(running_config.bonds):
-options = get_bond_options(attrs.get('options'), keep_custom=True)
+options = parse_bond_options(attrs.get('options'), keep_custom=True)
 net_info = _get_net_info(bonding, routes)
 net_info['slaves'] = attrs.get('nics')
 net_info['active_slave'] = _get_active_slave(bonding)
diff --git a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py 
b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
index 98b74bc..57098f1 100644
--- a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
+++ b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
@@ -23,13 +23,13 @@
 
 from vdsm.compat import suppress
 from vdsm.netinfo.cache import CachingNetInfo
+from vdsm.netinfo.bonding import parse_bond_options
 from vdsm.network.configurators import libvirt
 
 import hooking
 
-from ovs_utils import (get_bond_options, is_ovs_bond, iter_ovs_nets,
-   iter_ovs_bonds, rget, destroy_ovs_bridge,
-   BRIDGE_NAME, EXT_OVS_VSCTL)
+from ovs_utils import (is_ovs_bond, iter_ovs_nets, iter_ovs_bonds, rget,
+   destroy_ovs_bridge, BRIDGE_NAME, EXT_OVS_VSCTL)
 import ovs_utils
 
 log = partial(ovs_utils.log, tag='ovs_before_network_setup_ovs: ')
@@ -223,7 +223,7 @@
 commands.extend(['--', '--fake-iface', '--may-exist', 'add-bond',
  BRIDGE_NAME, bond] + attrs.get('nics'))
 
-bond_options = get_bond_options(attrs.get('options'))
+bond_options = parse_bond_options(attrs.get('options'))
 mode = rget(bond_options, ('custom', 'ovs_mode')) or 'active-backup'
 lacp = rget(bond_options, ('custom', 'ovs_lacp')) or 'off'
 

Change in vdsm[master]: net: move parse_bond_options to netinfo.bonding

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: move parse_bond_options to netinfo.bonding
..


Patch Set 1:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4619dad642facfb2dc154251412fd434d934e817
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Make the run_tests*.sh scripts readable

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: Make the run_tests*.sh scripts readable
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55729
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff09b1e71e2ca91ec3ef01490d019a893ff55b23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: move momIF to lib

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: move momIF to lib
..


Patch Set 2: Verified+1

added to engine and ran vm

-- 
To view, visit https://gerrit.ovirt.org/54156
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73701b1a2adb53f78c431da9662ac47d36be9912
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Bump mom dependency to version 0.5.3

[rmohr]

Roman Mohr has posted comments on this change.

Change subject: Bump mom dependency to version 0.5.3
..


Patch Set 1:

Mom is released upstream. Should appear within the next day in the right repos.

-- 
To view, visit https://gerrit.ovirt.org/55834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6567d7d31e0505625ff5e6c7d560b6cc9ad910
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Bump mom dependency to version 0.5.3

[msivak]

Martin Sivák has posted comments on this change.

Change subject: Bump mom dependency to version 0.5.3
..


Patch Set 1: Code-Review+1

MOM 0.5.3 was build in both Jenkins and Brew today.

-- 
To view, visit https://gerrit.ovirt.org/55834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6567d7d31e0505625ff5e6c7d560b6cc9ad910
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: move momIF to lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: move momIF to lib
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54156
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73701b1a2adb53f78c431da9662ac47d36be9912
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Bump mom dependency to version 0.5.3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Bump mom dependency to version 0.5.3
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6567d7d31e0505625ff5e6c7d560b6cc9ad910
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Bump mom dependency to version 0.5.3

[rmohr]

Roman Mohr has uploaded a new change for review.

Change subject: Bump mom dependency to version 0.5.3
..

Bump mom dependency to version 0.5.3

Use mom version 0.5.3 which supports QoS changes on running VMs.

Change-Id: Iba6567d7d31e0505625ff5e6c7d560b6cc9ad910
Signed-off-by: Roman Mohr 
---
M vdsm.spec.in
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/55834/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 602df04..c5c39b5 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -74,7 +74,7 @@
 BuildRequires: libselinux-python
 BuildRequires: libvirt-python
 BuildRequires: m2crypto
-BuildRequires: mom >= 0.4.5
+BuildRequires: mom >= 0.5.3
 BuildRequires: openssl
 BuildRequires: policycoreutils-python
 BuildRequires: psmisc
@@ -135,7 +135,7 @@
 Requires: %{name}-xmlrpc = %{version}-%{release}
 Requires: %{name}-jsonrpc = %{version}-%{release}
 Requires: safelease >= 1.0-7
-Requires: mom >= 0.4.5
+Requires: mom >= 0.5.3
 %if 0%{?with_ovirt_vmconsole}
 Requires: ovirt-vmconsole >= 1.0.0-0
 %endif


-- 
To view, visit https://gerrit.ovirt.org/55834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba6567d7d31e0505625ff5e6c7d560b6cc9ad910
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Apply storage QoS on running VM

[msivak]

Martin Sivák has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Add MoM scripts to change storage QoS on running VM

[msivak]

Martin Sivák has posted comments on this change.

Change subject: Add MoM scripts to change storage QoS on running VM
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hook: ovs: assert custom bond opts with ':'

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hook: ovs: assert custom bond opts with ':'
..


Patch Set 1: Verified+1

Function works, Engine is ok with ':' delimiter.

-- 
To view, visit https://gerrit.ovirt.org/55828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: ovs: assert custom bond opts with ':'

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hook: ovs: assert custom bond opts with ':'
..


Patch Set 2: Verified+1

Function works, Engine is ok with ':' delimiter.

-- 
To view, visit https://gerrit.ovirt.org/55827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: add tests for sampling.VMBulkSampler

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: add tests for sampling.VMBulkSampler
..


Patch Set 48:

(2 comments)

https://gerrit.ovirt.org/#/c/40053/48/tests/virt/bulk_sampling_test.py
File tests/virt/bulk_sampling_test.py:

PS48, Line 2: 2015
> 2015-2016
Done


PS48, Line 82: when=0, duration=10
> Please add the explanation. I wonder whether we really need such a long dur
let me try with shorter time


-- 
To view, visit https://gerrit.ovirt.org/40053
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id66dbd420ca29d08ae4063dc83b858be34b8940f
Gerrit-PatchSet: 48
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: ovs: assert custom bond opts with ':'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hook: ovs: assert custom bond opts with ':'
..


Patch Set 2:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Move create_volume parent uuids into separate type

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Move create_volume parent uuids into separate type
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81aa1be73cb66ef6ca00d5b6a1997defd9aa8a48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Move create_volume parent uuids into separate type

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Move create_volume parent uuids into separate type
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81aa1be73cb66ef6ca00d5b6a1997defd9aa8a48
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: SDM.create_volume split parent params

[alitke]

Adam Litke has posted comments on this change.

Change subject: schema: SDM.create_volume split parent params
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ccaf88a122dec24fa8d018c0cd94b4a08ecadce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Move create_volume parent uuids into separate type

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: sdm: Move create_volume parent uuids into separate type
..

sdm: Move create_volume parent uuids into separate type

The schema defines the parent volume reference used in SDM.create_volume
as a distinct type (ParentVolumeInfo).  Implement this in the code.
Parent volume parameters are not required but if provided, both must be
defined.

Change-Id: I81aa1be73cb66ef6ca00d5b6a1997defd9aa8a48
Signed-off-by: Adam Litke 
---
M tests/storage_sdm_create_volume_test.py
M vdsm/storage/sdm/api/create_volume.py
2 files changed, 41 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/55830/1

diff --git a/tests/storage_sdm_create_volume_test.py 
b/tests/storage_sdm_create_volume_test.py
index 079b155..af9a552 100644
--- a/tests/storage_sdm_create_volume_test.py
+++ b/tests/storage_sdm_create_volume_test.py
@@ -87,9 +87,7 @@
 return dict(sd_id=str(uuid.uuid4()), img_id=str(uuid.uuid4()),
 vol_id=str(uuid.uuid4()), virtual_size=2048,
 vol_format='RAW', disk_type='SYSTEM',
-description='test vol',
-parent_img_id=volume.BLANK_UUID,
-parent_vol_id=volume.BLANK_UUID, initial_size='0')
+description='test vol', initial_size='0')
 
 
 class CreateVolumeTests(VdsmTestCase):
@@ -156,23 +154,40 @@
   storage.sdm.api.create_volume.CreateVolumeInfo, info)
 
 def test_default_parameter(self):
-defaults = dict(
-description='',
-parent_img_id=volume.BLANK_UUID,
-parent_vol_id=volume.BLANK_UUID,
-initial_size=0
-)
-
 info = _get_vol_info()
-for k in defaults.iterkeys():
-del info[k]
+del info['description']
+del info['initial_size']
 
 info_obj = storage.sdm.api.create_volume.CreateVolumeInfo(info)
-for k, v in defaults.iteritems():
-self.assertEqual(v, getattr(info_obj, k))
+self.assertEqual('', info_obj.description)
+self.assertEqual(0, info_obj.initial_size)
+self.assertEqual(volume.BLANK_UUID, info_obj.parent.vol_id)
+self.assertEqual(volume.BLANK_UUID, info_obj.parent.img_id)
 
 def test_bad_enum_value(self):
 info = _get_vol_info()
 info['vol_format'] = 'foo'
 self.assertRaises(se.InvalidParameterException,
   storage.sdm.api.create_volume.CreateVolumeInfo, info)
+
+
+class ParentVolumeInfoTests(VdsmTestCase):
+
+def test_no_params(self):
+obj = storage.sdm.api.create_volume.ParentVolumeInfo({})
+self.assertEqual(volume.BLANK_UUID, obj.vol_id)
+self.assertEqual(volume.BLANK_UUID, obj.img_id)
+
+def test_incomplete_params_raises(self):
+self.assertRaises(exception.MissingParameter,
+  storage.sdm.api.create_volume.ParentVolumeInfo,
+  {'vol_id': 'foo'})
+self.assertRaises(exception.MissingParameter,
+  storage.sdm.api.create_volume.ParentVolumeInfo,
+  {'img_id': 'foo'})
+
+def test_complete_params(self):
+params = {'vol_id': 'foo', 'img_id': 'bar'}
+obj = storage.sdm.api.create_volume.ParentVolumeInfo(params)
+for key, val in params.items():
+self.assertEqual(val, getattr(obj, key))
diff --git a/vdsm/storage/sdm/api/create_volume.py 
b/vdsm/storage/sdm/api/create_volume.py
index a2c895a..53453c5 100644
--- a/vdsm/storage/sdm/api/create_volume.py
+++ b/vdsm/storage/sdm/api/create_volume.py
@@ -41,7 +41,7 @@
 def _run(self):
 vol_format = volume.name2type(self.vol_info.vol_format)
 self.sd_manifest.validateCreateVolumeParams(
-vol_format, self.vol_info.parent_vol_id)
+vol_format, self.vol_info.parent.vol_id)
 
 with self.sd_manifest.domain_lock(self.host_id):
 image_res_ns = sd.getNamespace(self.sd_manifest.sdUUID,
@@ -53,7 +53,7 @@
 artifacts.create(
 self.vol_info.virtual_size, vol_format,
 self.vol_info.disk_type, self.vol_info.description,
-self.vol_info.parent_vol_id)
+self.vol_info.parent.vol_id)
 artifacts.commit()
 
 
@@ -71,11 +71,19 @@
 self.vol_format = _enum(params, 'vol_format', vol_types)
 self.disk_type = _enum(params, 'disk_type', image.DISK_TYPES.values())
 self.description = params.get('description', '')
-self.parent_img_id = params.get('parent_img_id', volume.BLANK_UUID)
-self.parent_vol_id = params.get('parent_vol_id', volume.BLANK_UUID)
+self.parent = ParentVolumeInfo(params.get('parent', {}))
 self.initial_size = params.get('initial_size', 0)
 
 
+class 

Change in vdsm[master]: schema: SDM.create_volume split parent params

[automation]

gerrit-hooks has posted comments on this change.

Change subject: schema: SDM.create_volume split parent params
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ccaf88a122dec24fa8d018c0cd94b4a08ecadce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: SDM.create_volume split parent params

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: schema: SDM.create_volume split parent params
..

schema: SDM.create_volume split parent params

When creating a new volume, the parent_vol_id and parent_img_id are
optional and should be used only if the new volume is derived from a
parent (ie. snapshot volume or volume from template).  However, if one
of the parent_*_id parameters is specified the other one must also be
provided.  The best way to codify this and organize the create
parameters is to place the two parent ids together in their own data
structure.

Change-Id: I7ccaf88a122dec24fa8d018c0cd94b4a08ecadce
Signed-off-by: Adam Litke 
---
M lib/api/vdsmapi-schema.json
1 file changed, 15 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/55829/1

diff --git a/lib/api/vdsmapi-schema.json b/lib/api/vdsmapi-schema.json
index e9d39e4..fcabdfb 100644
--- a/lib/api/vdsmapi-schema.json
+++ b/lib/api/vdsmapi-schema.json
@@ -8721,6 +8721,19 @@
 {'class': 'SDM'}
 
 ##
+# @ParentVolumeInfo:
+#
+# A reference to a parent volume.
+#
+# @img_id:
+#
+# @vol_id:
+#
+# Since: 4.18
+##
+{'type': 'ParentVolumeInfo', 'data': {'img_id': 'UUID', 'vol_id': 'UUID'}}
+
+##
 # @CreateVolumeInfo:
 #
 # Parameters used for creating a new volume.
@@ -8739,11 +8752,7 @@
 #
 # @description:The Volume description (up to 210 bytes)
 #
-# @parent_img_id:  #optional Identifies the image of the parent volume.  If
-#  specified, @parent_vol_id is also required.
-#
-# @parent_vol_id:  #optional Identifies the parent volume.  If specified,
-#  @parent_img_id is also required.
+# @parent: #optional Derive from the indicated parent Volume
 #
 # @initial_size:   #optional If specified, the initial allocated size of volume
 #  in bytes.  Allowed only when creating a thinly provisioned
@@ -8755,8 +8764,7 @@
  'data': {'sd_id': 'UUID', 'img_id': 'UUID', 'vol_id': 'UUID',
   'virtual_size': 'uint', 'vol_format': 'VolumeFormat',
   'disk_type': 'DiskType', 'description': 'str',
-  '*parent_img_id': 'UUID', '*parent_vol_id': 'UUID',
-  '*initial_size': 'uint'}}
+  '*parent': 'ParentVolumeInfo', '*initial_size': 'uint'}}
 
 ##
 # @SDM.create_volume:


-- 
To view, visit https://gerrit.ovirt.org/55829
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ccaf88a122dec24fa8d018c0cd94b4a08ecadce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hook: ovs: assert custom bond opts with ':'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hook: ovs: assert custom bond opts with ':'
..


Patch Set 1: Verified-1

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.6
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/55828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: Add fcoe hook

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 20:

* #1239122::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1239122::OK, public bug
* Check Product::#1239122::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: Add fcoe hook

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 18:

(5 comments)

https://gerrit.ovirt.org/#/c/55029/18/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File vdsm_hooks/fcoe/fcoe_before_network_setup.py:

Line 27: def _has_fcoe_param(net_attr):
Line 28: """
Line 29: Check if fcoe parameter was specified for net
Line 30: """
Line 31: return net_attr.get('custom') \
> you should use parantheses instead of \ if it is possible.
+1
Line 32: and hooking.tobool(net_attr['custom'].get('fcoe'))
Line 33: 
Line 34: 
Line 35: def _configure(interface):


Line 34: 
Line 35: def _configure(interface):
Line 36: """
Line 37: Enable FCoE on specified interface by coping default configuration
Line 38: """
> Why should I do it? Any code convention? I can see hundreds of docstrings i
Peter, this docstring is fine, no change is needed.

We use either:

" title ...last word "

Note the space before and after the title. pep8 allow this format without 
spaces but I think it is ugly.

Or:

"""
title ...
"""

The second format is better because it is easier to add more text later, not 
need to change the quotes.
Line 39: # IOError can be raised here is FCOE_DEFAULT_CONFIG doesn't exist
Line 40: # or we're not able to copy file
Line 41: # Don't catch exceptions here. Propagate them to main
Line 42: # and show traceback in supervdsm log


Line 38: """
Line 39: # IOError can be raised here is FCOE_DEFAULT_CONFIG doesn't exist
Line 40: # or we're not able to copy file
Line 41: # Don't catch exceptions here. Propagate them to main
Line 42: # and show traceback in supervdsm log
> I don't think so.
We like to see nicely wrapped text in comments/docstrings.

(for example in vim, ctrl+shift+v, select the lines, press gq).

And please do not call pep8 stupid, you may upset the pep8 gods :-)
Line 43: if interface is None:
Line 44: return
Line 45: filename = os.path.join(FCOE_CONFIG_DIR, 'cfg-%s' % interface)
Line 46: if not os.path.exists(filename):


Line 50: 
Line 51: 
Line 52: def _unconfigure(interface):
Line 53: """
Line 54: Remove config file for specified interface
> the same here.
This docstring is fine, no change is needed.
Line 55: """
Line 56: if interface is None:
Line 57: return
Line 58: filename = os.path.join(FCOE_CONFIG_DIR, 'cfg-%s' % (interface))


Line 75: for net, net_attr in six.iteritems(config.networks):
Line 76: if _has_fcoe_param(net_attr):
Line 77: if configured[net] is None:
Line 78: hooking.exit_hook("""Failed to configure fcoe
Line 79:on %s with no physical nic""" %
This should be:

hooking.exit_hook("first line ...last word "
  "second line ...last word."
  % (args, ...))

Note the space at the end of the first line to keep the words separated when in 
the final message.
Line 80:   (net))
Line 81: else:
Line 82: configured[net] = net_attr.get('nic')
Line 83: 


-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hook: ovs: assert custom bond opts with ':'

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: hook: ovs: assert custom bond opts with ':'
..

hook: ovs: assert custom bond opts with ':'

On Engine side we forbid multiple '=' in one bond option. That means,
that we cannot pass custom options as 'custom=foo=bar,x=y'.

Now we use ':' as a delimiter, so custom options should look like
'custom=foo:bar,x:y'.

Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Bug-Url: https://bugzilla.redhat.com/1234867
Signed-off-by: Petr Horáček 
---
M vdsm_hooks/ovs/ovs_utils.py
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/55828/1

diff --git a/vdsm_hooks/ovs/ovs_utils.py b/vdsm_hooks/ovs/ovs_utils.py
index 751b11b..5390a82 100644
--- a/vdsm_hooks/ovs/ovs_utils.py
+++ b/vdsm_hooks/ovs/ovs_utils.py
@@ -53,18 +53,19 @@
 def get_bond_options(options, keep_custom=False):
 """ Parse bonding options into dictionary, if keep_custom is set to True,
 custom option will not be recursive parsed.
->>> get_bond_options('mode=4 custom=foo=yes,bar=no')
+>>> get_bond_options('mode=4 custom=foo:yes,bar:no')
 {'custom': {'bar': 'no', 'foo': 'yes'}, 'mode': '4'}
 """
-def _string_to_dict(str, div):
+def _string_to_dict(str, div, eq):
 if options == '':
 return {}
-return dict(option.split('=', 1)
+return dict(option.split(eq, 1)
 for option in str.strip(div).split(div))
 if options:
-d_options = _string_to_dict(options, ' ')
+d_options = _string_to_dict(options, ' ', '=')
 if d_options.get('custom') and not keep_custom:
-d_options['custom'] = _string_to_dict(d_options['custom'], ',')
+d_options['custom'] = _string_to_dict(d_options['custom'], ',',
+  ':')
 return d_options
 else:
 return {}


-- 
To view, visit https://gerrit.ovirt.org/55828
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netinfo: report switch type

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: netinfo: report switch type
..


Patch Set 4: Verified+1

Passed functional network tests.

-- 
To view, visit https://gerrit.ovirt.org/55810
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00c1267bee9c3a8fb45b72a483e0999139abaa8d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: persist bonding 'switch' parameter

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: persist bonding 'switch' parameter
..


Patch Set 1: Verified+1

Passed functional network tests.

-- 
To view, visit https://gerrit.ovirt.org/55825
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica95fc047c7338f5745f490cd262f016d193562d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: ovs: divide custom bond opts with ':'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hook: ovs: divide custom bond opts with ':'
..


Patch Set 1:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: ovs: divide custom bond opts with ':'

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: hook: ovs: divide custom bond opts with ':'
..

hook: ovs: divide custom bond opts with ':'

On Engine side we forbid multiple '=' in one bond option. That means,
that we cannot pass custom options as 'custom=foo=bar,x=y'.

Now we use ':' as a delimiter, so custom options should look like
'custom=foo:bar,x:y'.

Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Bug-Url: https://bugzilla.redhat.com/1234867
Signed-off-by: Petr Horáček 
---
M vdsm_hooks/ovs/ovs_utils.py
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/55827/1

diff --git a/vdsm_hooks/ovs/ovs_utils.py b/vdsm_hooks/ovs/ovs_utils.py
index c703689..8aa459a 100644
--- a/vdsm_hooks/ovs/ovs_utils.py
+++ b/vdsm_hooks/ovs/ovs_utils.py
@@ -51,18 +51,19 @@
 def get_bond_options(options, keep_custom=False):
 """ Parse bonding options into dictionary, if keep_custom is set to True,
 custom option will not be recursive parsed.
->>> get_bond_options('mode=4 custom=foo=yes,bar=no')
+>>> get_bond_options('mode=4 custom=foo:yes,bar:no')
 {'custom': {'bar': 'no', 'foo': 'yes'}, 'mode': '4'}
 """
-def _string_to_dict(str, div):
+def _string_to_dict(str, div, eq):
 if options == '':
 return {}
-return dict(option.split('=', 1)
+return dict(option.split(eq, 1)
 for option in str.strip(div).split(div))
 if options:
-d_options = _string_to_dict(options, ' ')
+d_options = _string_to_dict(options, ' ', '=')
 if d_options.get('custom') and not keep_custom:
-d_options['custom'] = _string_to_dict(d_options['custom'], ',')
+d_options['custom'] = _string_to_dict(d_options['custom'], ',',
+  ':')
 return d_options
 else:
 return {}


-- 
To view, visit https://gerrit.ovirt.org/55827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I086d65792969da19cb374fcd367499cfaa45955f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: Add fcoe hook

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 19:

* #1239122::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1239122::OK, public bug
* Check Product::#1239122::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: persist bonding 'switch' parameter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: persist bonding 'switch' parameter
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55825
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica95fc047c7338f5745f490cd262f016d193562d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: persist bonding 'switch' parameter

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: persist bonding 'switch' parameter
..

net: persist bonding 'switch' parameter

Legacy configurators do not pass all bonding arguments to
BaseConfig:setBonding() (but it pass everything to setNetwork()),
so we need to persist 'switch' parameter explicitly.

Change-Id: Ica95fc047c7338f5745f490cd262f016d193562d
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/iproute2.py
2 files changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/55825/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index 0891c8e..6c74472 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -126,7 +126,8 @@
 if self.unifiedPersistence:
 self.runningConfig.setBonding(
 bond.name, {'options': bond.options,
-'nics': [slave.name for slave in bond.slaves]})
+'nics': [slave.name for slave in bond.slaves],
+'switch': 'legacy'})
 
 def editBonding(self, bond, _netinfo):
 """
@@ -168,7 +169,8 @@
 if self.unifiedPersistence:
 self.runningConfig.setBonding(
 bond.name, {'options': bond.options,
-'nics': [slave.name for slave in bond.slaves]})
+'nics': [slave.name for slave in bond.slaves],
+'switch': 'legacy'})
 
 def configureNic(self, nic, **opts):
 self.configApplier.addNic(nic, **opts)
diff --git a/lib/vdsm/network/configurators/iproute2.py 
b/lib/vdsm/network/configurators/iproute2.py
index dbe5a23..1d84083 100644
--- a/lib/vdsm/network/configurators/iproute2.py
+++ b/lib/vdsm/network/configurators/iproute2.py
@@ -106,7 +106,8 @@
 self._addSourceRoute(bond)
 self.runningConfig.setBonding(
 bond.name, {'options': bond.options,
-'nics': [slave.name for slave in bond.slaves]})
+'nics': [slave.name for slave in bond.slaves],
+'switch': 'legacy'})
 
 def editBonding(self, bond, _netinfo):
 """
@@ -139,7 +140,8 @@
 self.configApplier.ifup(bond)
 self.runningConfig.setBonding(
 bond.name, {'options': bond.options,
-'nics': [slave.name for slave in bond.slaves]})
+'nics': [slave.name for slave in bond.slaves],
+'switch': 'legacy'})
 
 def configureNic(self, nic, **opts):
 DynamicSourceRoute.addInterfaceTracking(nic)


-- 
To view, visit https://gerrit.ovirt.org/55825
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica95fc047c7338f5745f490cd262f016d193562d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: Add fcoe hook

[pzhukov]

Pavel Zhukov has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 18:

(4 comments)

https://gerrit.ovirt.org/#/c/55029/17/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File vdsm_hooks/fcoe/fcoe_before_network_setup.py:

Line 73: 
Line 74: config = RunningConfig()
Line 75: for net, net_attr in six.iteritems(config.networks):
Line 76: if _has_fcoe_param(net_attr):
Line 77: if configured[net] is None:
> you seem to have missed my two comments around here, plase see
Yes. I did. Sorry
Line 78: hooking.exit_hook("""Failed to configure fcoe
Line 79:on %s with no physical nic""" %
Line 80:   (net))
Line 81: else:


https://gerrit.ovirt.org/#/c/55029/18/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File vdsm_hooks/fcoe/fcoe_before_network_setup.py:

PS18, Line 36: """
 : Enable FCoE on specified interface by coping default 
configuration
 : """
> I think you should fit in on one line:
Why should I do it? Any code convention? I can see hundreds of docstrings in 
vdsm code like
"""
One line here
"""


PS18, Line 39: # IOError can be raised here is FCOE_DEFAULT_CONFIG doesn't 
exist
 : # or we're not able to copy file
 : # Don't catch exceptions here. Propagate them to main
 : # and show traceback in supervdsm log
> i feel bad for nagging for code typography but i cannot not comment this.
I don't think so.
Do we have code convention to break the line at random place just because of 
stupid 80 characters limitation?


PS18, Line 90: elif hooking.tobool(net_attr.get('remove')):
> you don't have to use tobool, as we canonicalize values before we expose th
Since which version? I can see type 'unicode' here


-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netinfo: report switch type

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: netinfo: report switch type
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55810
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00c1267bee9c3a8fb45b72a483e0999139abaa8d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add device setup and teardown

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add device setup and teardown
..


Patch Set 7: Code-Review+1

(3 comments)

I've minor nits, but not worthy a resubmit. Full ACK on hold to avoid hiding 
other reviews.

https://gerrit.ovirt.org/#/c/55135/7/tests/vmTests.py
File tests/vmTests.py:

PS7, Line 1084: conf = {'vmName': 'testVm',
  : 'vmId': '9ffe28b6-6134-4b1e-beef-1185f49c436f',
  : 'smp': '8',
  : 'maxVCpus': '160',
  : 'memSize': '1024',
  : 'memGuaranteedSize': '512',
  : 'devices': [],
  : }
if you resubmit, please reformat as

  conf = {
'vmName': 'testVm',
...


PS7, Line 1093: def assertDeviceCalls(self, devices, expected_calls):
  : for index, device in enumerate(devices):
  : self.assertEquals(device.__calls__, 
expected_calls[index])
if you resubmit, I'd move this at the end of the class, below the actual tests.


https://gerrit.ovirt.org/#/c/55135/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS7, Line 1862: continue
useless, but I don't mind


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sr-iov: use device setup instead of detach

[fromani]

Francesco Romani has posted comments on this change.

Change subject: sr-iov: use device setup instead of detach
..


Patch Set 8: Code-Review+1

looks fine, but let's avoid another out-of-order merge ;)

-- 
To view, visit https://gerrit.ovirt.org/55137
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c97af2ea9f17ef38f9dbb4f41e5f9d1da9eebaa
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Apply storage QoS on running VM

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 1: Code-Review+1

codewise seems OK. Please make sure the new API is OK for the stable branch 
(e.g doesn't break backward compatibility).

-- 
To view, visit https://gerrit.ovirt.org/55820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Add MoM scripts to change storage QoS on running VM

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Add MoM scripts to change storage QoS on running VM
..


Patch Set 1: Code-Review+1

please get ACK(s) from SLA devs.

-- 
To view, visit https://gerrit.ovirt.org/55821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: kvmstream: tool for streaming images from libvirt

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: kvmstream: tool for streaming images from libvirt
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55797/1/kvmstream.py
File kvmstream.py:

Line 69: vol.download(stream, 0, 0, 0)
Line 70: write_output('(0/100%%)\r')
Line 71: counter = 0
Line 72: while pos < size:
Line 73: buf = s.recv(1024)
> I am not sure,
We use 1M in ovirt-imageio and vdsm when copying images. We should have a 
default and command line option to change it.
Line 74: f.write(buf)
Line 75: f.flush()
Line 76: if not pos % jump:
Line 77: counter = counter + 1


-- 
To view, visit https://gerrit.ovirt.org/55797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Apply storage QoS on running VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 1:

* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check Product::#1201482::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1201482::OK, correct target milestone ovirt-3.6.5
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/55820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Add MoM scripts to change storage QoS on running VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Add MoM scripts to change storage QoS on running VM
..


Patch Set 1:

* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check Product::#1201482::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1201482::OK, correct target milestone ovirt-3.6.5
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/55821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Add MoM scripts to change storage QoS on running VM

[rmohr]

Hello Martin Sivák, Dan Kenigsberg, Francesco Romani, Andrej Krejcir,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/55821

to review the following change.

Change subject: Add MoM scripts to change storage QoS on running VM
..

Add MoM scripts to change storage QoS on running VM

Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1201482
Signed-off-by: Andrej Krejcir 
Reviewed-on: https://gerrit.ovirt.org/54208
Reviewed-by: Francesco Romani 
Reviewed-by: Martin Sivák 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm/Makefile.am
M vdsm/mom.conf.in
M vdsm/mom.d/00-defines.policy
A vdsm/mom.d/05-iotune.policy
4 files changed, 40 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/55821/1

diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 30fc15f..b3bcd48 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -105,6 +105,7 @@
mom.d/02-balloon.policy \
mom.d/03-ksm.policy \
mom.d/04-cputune.policy \
+   mom.d/05-iotune.policy \
sourceRoute.sh \
sudoers.vdsm.in \
svdsm.logger.conf.in \
diff --git a/vdsm/mom.conf.in b/vdsm/mom.conf.in
index 4c57d8e..fbcb56a 100644
--- a/vdsm/mom.conf.in
+++ b/vdsm/mom.conf.in
@@ -25,7 +25,7 @@
 policy-engine-interval: 15
 
 # A comma-separated list of Controller plugins to enable
-controllers: Balloon, KSM, CpuTune
+controllers: Balloon, KSM, CpuTune, IoTune
 
 # Sets the maximum number of statistic samples to keep for the purpose of
 # calculating moving averages.
@@ -81,4 +81,4 @@
 
 [guest]
 # A comma-separated list of Collector plugins to use for Guest data collection.
-collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloon, GuestCpuTune
+collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloon, GuestCpuTune, 
GuestIoTune
diff --git a/vdsm/mom.d/00-defines.policy b/vdsm/mom.d/00-defines.policy
index 718cf04..206bb7a 100644
--- a/vdsm/mom.d/00-defines.policy
+++ b/vdsm/mom.d/00-defines.policy
@@ -8,4 +8,5 @@
 (defvar ksmEnabled 1)
 (defvar balloonEnabled 0)
 (defvar cpuTuneEnabled 1)
+(defvar ioTuneEnabled 1)
 
diff --git a/vdsm/mom.d/05-iotune.policy b/vdsm/mom.d/05-iotune.policy
new file mode 100644
index 000..3132986
--- /dev/null
+++ b/vdsm/mom.d/05-iotune.policy
@@ -0,0 +1,36 @@
+### Auto-IoTune 

+
+(defvar unlimited_io 0)
+
+### Helper functions
+(def set_io_limits (guest) {
+(with guest.io_tune tune {
+(defvar max_io tune.maximum)
+(tune.setTotalBytesSec max_io.total_bytes_sec)
+(tune.setReadBytesSec  max_io.read_bytes_sec)
+(tune.setWriteBytesSec max_io.write_bytes_sec)
+
+(tune.setTotalIopsSec max_io.total_iops_sec)
+(tune.setReadIopsSec  max_io.read_iops_sec)
+(tune.setWriteIopsSec max_io.write_iops_sec)
+})
+})
+
+(def reset_io_limits (guest) {
+(with guest.io_tune tune {
+(tune.setTotalBytesSec unlimited_io)
+(tune.setReadBytesSec  unlimited_io)
+(tune.setWriteBytesSec unlimited_io)
+
+(tune.setTotalIopsSec unlimited_io)
+(tune.setReadIopsSec  unlimited_io)
+(tune.setWriteIopsSec unlimited_io)
+})
+})
+
+### Main Script
+(if (== True ioTuneEnabled) {
+(with Guests guest (set_io_limits guest))
+}{
+(with Guests guest (reset_io_limits guest))
+})
\ No newline at end of file


-- 
To view, visit https://gerrit.ovirt.org/55821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Roman Mohr 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: Apply storage QoS on running VM

[rmohr]

Hello Andrej Krejcir,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/55820

to review the following change.

Change subject: Apply storage QoS on running VM
..

Apply storage QoS on running VM

Modified updateVmPolicy command to accept disk ids.
Added a function to get current io tune from libvirt.

Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1201482
Signed-off-by: Andrej Krejcir 
---
M tests/vmTests.py
M vdsm/API.py
M vdsm/rpc/Bridge.py
M vdsm/rpc/bindingxmlrpc.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/virt/vm.py
6 files changed, 106 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/55820/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index a0d7d0b..5471c03 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -809,7 +809,7 @@
 
 self.assertEqual(expected_xml, self._xml_sanitizer(dom._metadata))
 
-def testGetIoTune(self):
+def testGetIoTunePolicy(self):
 with fake.VM() as machine:
 dom = fake.Domain()
 dom._metadata = """
@@ -842,7 +842,7 @@
  u'totalBytes': 
  }}
 ]
-self.assertEqual(tunables, expected)
+self.assertEqual(tunables['ioTunePolicy'], expected)
 
 def testSetIoTune(self):
 
diff --git a/vdsm/API.py b/vdsm/API.py
index d5f6ced..46c5e66 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -770,6 +770,12 @@
 return errCode['noVM']
 return v.setCpuTuneQuota(quota)
 
+def getIoTune(self):
+v = self._cif.vmContainer.get(self._UUID)
+if not v:
+return errCode['noVM']
+return v.getIoTune()
+
 def setIoTune(self, tunables):
 v = self._cif.vmContainer.get(self._UUID)
 if not v:
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index c2a114c..8815a18 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -470,6 +470,7 @@
 'VM_diskSizeExtend': {'ret': 'size'},
 'VM_getDiskAlignment': {'ret': 'alignment'},
 'VM_getInfo': {'call': VM_getInfo_Call, 'ret': VM_getInfo_Ret},
+'VM_getIoTune': {'ret': 'ioTuneList'},
 'VM_getIoTunePolicy': {'ret': 'ioTunePolicyList'},
 'VM_getStats': {'ret': 'statsList'},
 'VM_hotplugDisk': {'ret': 'vmList'},
diff --git a/vdsm/rpc/bindingxmlrpc.py b/vdsm/rpc/bindingxmlrpc.py
index c521cd8..acb3bbd 100644
--- a/vdsm/rpc/bindingxmlrpc.py
+++ b/vdsm/rpc/bindingxmlrpc.py
@@ -554,6 +554,10 @@
 vm = API.VM(vmId)
 return vm.getIoTunePolicy()
 
+def vmGetIoTune(self, vmId):
+vm = API.VM(vmId)
+return vm.getIoTune()
+
 def vmSetIoTune(self, vmId, tunables):
 vm = API.VM(vmId)
 return vm.setIoTune(tunables)
@@ -1108,6 +1112,7 @@
 (self.merge, 'merge'),
 (self.vmUpdateVmPolicy, 'updateVmPolicy'),
 (self.vmSetIoTune, 'setIoTune'),
+(self.vmGetIoTune, 'getIoTune'),
 (self.vmGetIoTunePolicy, 'getIoTunePolicy'),
 (self.vmSetCpuTuneQuota, 'vmSetCpuTuneQuota'),
 (self.vmSetCpuTunePeriod, 'vmSetCpuTunePeriod'),
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 8ca7627..cface3b 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -2582,10 +2582,19 @@
 # @VmDiskDeviceTuneLimits:
 #
 # Extra parameters for VM disk devices.
+# Either name, path or all 4 IDs must be present
 #
 # @name:#optional The name of the target device
 #
 # @path:#optional The path of the target device
+#
+# @domainID:#optional DomainID
+#
+# @poolID:  #optional PoolId
+#
+# @imageID: #optional ImageId
+#
+# @volumeID:#optional VolumeId
 #
 # @guaranteed:  IO tune parameters - guaranteed values
 #
@@ -2595,6 +2604,8 @@
 ##
 {'type': 'VmDiskDeviceTuneLimits',
  'data': {'*name': 'str', '*path': 'str',
+  '*domainID': 'UUID', '*poolID': 'UUID',
+  '*imageID': 'UUID', '*volumeID': 'UUID',
   'guaranteed': 'VmDiskDeviceIoTuneParams',
   'maximum': 'VmDiskDeviceIoTuneParams'}}
 
@@ -8705,6 +8716,23 @@
  'returns': 'TaskStatus'}
 
 ##
+# @VM.getIoTune:
+#
+# Sets the ioTune parameters for block devices
+#
+# @vmID:The UUID of the VM
+#
+# Returns:
+# list of VmDiskDeviceTuneParams objects
+#
+# Since: 4.18.0
+##
+{'command': {'class': 'VM', 'name': 'getIoTune'},
+ 'data': {'vmID': 'UUID'},
+ 'returns': ['VmDiskDeviceTuneParams']}
+
+
+##
 # @VM.getIoTunePolicy:
 #
 # Gets the ioTune policy settings for block devices
@@ -8712,14 +8740,14 @@
 # @vmID:The UUID of the VM
 #
 # Returns:
-# list of VmDiskDeviceTuneParams objects describing
+# list of VmDiskDeviceTuneLimits objects describing
 # the current settings
 #
 # Since: 4.15.0
 ##
 {'command': {'class': 'VM', 'name': 

Change in vdsm[master]: move momIF to lib

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: move momIF to lib
..


Patch Set 1: Code-Review-1

requires manual rebase.

please verify starting up a VM from Engine (to make sure that basic mom-related 
flows fly)

-- 
To view, visit https://gerrit.ovirt.org/54156
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73701b1a2adb53f78c431da9662ac47d36be9912
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add MoM scripts to change storage QoS on running VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Add MoM scripts to change storage QoS on running VM
..


Patch Set 6:

* #1201482::Update tracker: OK
* Set MODIFIED::bug 1201482#1201482IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/54208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add MoM scripts to change storage QoS on running VM

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add MoM scripts to change storage QoS on running VM
..


Add MoM scripts to change storage QoS on running VM

Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1201482
Signed-off-by: Andrej Krejcir 
Reviewed-on: https://gerrit.ovirt.org/54208
Reviewed-by: Francesco Romani 
Reviewed-by: Martin Sivák 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M vdsm/Makefile.am
M vdsm/mom.conf.in
M vdsm/mom.d/00-defines.policy
A vdsm/mom.d/05-iotune.policy
4 files changed, 40 insertions(+), 2 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Andrej Krejcir: Verified



-- 
To view, visit https://gerrit.ovirt.org/54208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add MoM scripts to change storage QoS on running VM

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Add MoM scripts to change storage QoS on running VM
..


Patch Set 5: Code-Review+2

raising Martin's score

-- 
To view, visit https://gerrit.ovirt.org/54208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Apply storage QoS on running VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 19:

* #1201482::Update tracker: OK
* Set MODIFIED::bug 1201482#1201482IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1514: raise se.ImageVerificationError(
Line 1515: "Uploaded image format is %s while the format 
specified "
Line 1516: "by the user is %s" % (actual_format, 
expected_format)
Line 1517: )
Line 1518: if "backingfile" in actual_info:
> I believe thats a relevant scenario that we need to support, if not now so 
We don't support it now, and it is not in our todo list.
Line 1519: raise se.ImageVerificationError(
Line 1520: "'%s' is defined as a backingfile, while backingfile 
is not "
Line 1521: "allowed for an uploaded image."
Line 1522: % actual_info["backingfile"]


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Apply storage QoS on running VM

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Apply storage QoS on running VM
..


Apply storage QoS on running VM

Modified updateVmPolicy command to accept disk ids.
Added a function to get current io tune from libvirt.

Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1201482
Signed-off-by: Andrej Krejcir 
Reviewed-on: https://gerrit.ovirt.org/52746
Reviewed-by: Francesco Romani 
Reviewed-by: Martin Sivák 
Continuous-Integration: Jenkins CI
---
M lib/api/vdsmapi-schema.json
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/rpc/bindingxmlrpc.py
M tests/vmTests.py
M vdsm/API.py
M vdsm/virt/vm.py
6 files changed, 106 insertions(+), 7 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Andrej Krejcir: Verified



-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sr-iov: use device setup instead of detach

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sr-iov: use device setup instead of detach
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55137
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c97af2ea9f17ef38f9dbb4f41e5f9d1da9eebaa
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add device setup and teardown

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add device setup and teardown
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1505: @public
Line 1506: def verify_untrusted_volume(self, spUUID, sdUUID, imgUUID, 
volUUID):
Line 1507: dom = sdCache.produce(sdUUID=sdUUID)
Line 1508: vol = dom.produceVolume(imgUUID, volUUID)
Line 1509: actual_info = qemuimg.info(vol.getVolumePath())
> great.
I'm fine with these names.
Line 1510: 
Line 1511: expected_format = volume.FMT2STR[vol.getFormat()]
Line 1512: actual_format = actual_info["format"]
Line 1513: if expected_format != actual_format:


https://gerrit.ovirt.org/#/c/55746/5/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1512: actual_format = actual_info["format"]
Line 1513: if expected_format != actual_format:
Line 1514: raise se.ImageVerificationError(
Line 1515: "Uploaded image format is %s while the format 
specified "
Line 1516: "by the user is %s" % (actual_format, 
expected_format)
Can you convert the error message to talk about untrusted volume instead of 
uploaded volume?

Also do not mention "format specified by user". Vdsm does not know anything 
about the user and the upload image flow. Vdsm knows about having a volume with 
certain metadata that does not match the actual untrusted image.
Line 1517: )
Line 1518: if "backingfile" in actual_info:
Line 1519: raise se.ImageVerificationError(
Line 1520: "'%s' is defined as a backingfile, while backingfile 
is not "


Line 1517: )
Line 1518: if "backingfile" in actual_info:
Line 1519: raise se.ImageVerificationError(
Line 1520: "'%s' is defined as a backingfile, while backingfile 
is not "
Line 1521: "allowed for an uploaded image."
Same, we don't allow backing file for untrusted image.
Line 1522: % actual_info["backingfile"]
Line 1523: )
Line 1524: 
Line 1525: def validateImageMove(self, srcDom, dstDom, imgUUID):


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[laravot]

Liron Aravot has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1505: @public
Line 1506: def verify_untrusted_volume(self, spUUID, sdUUID, imgUUID, 
volUUID):
Line 1507: dom = sdCache.produce(sdUUID=sdUUID)
Line 1508: vol = dom.produceVolume(imgUUID, volUUID)
Line 1509: actual_info = qemuimg.info(vol.getVolumePath())
> great.
*meta_format
Line 1510: 
Line 1511: expected_format = volume.FMT2STR[vol.getFormat()]
Line 1512: actual_format = actual_info["format"]
Line 1513: if expected_format != actual_format:


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[laravot]

Liron Aravot has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1505: @public
Line 1506: def verify_untrusted_volume(self, spUUID, sdUUID, imgUUID, 
volUUID):
Line 1507: dom = sdCache.produce(sdUUID=sdUUID)
Line 1508: vol = dom.produceVolume(imgUUID, volUUID)
Line 1509: actual_info = qemuimg.info(vol.getVolumePath())
> I agree, the error should not mention upload.
great.
perhaps we should rename to qemu_info and metadata_info, that way its clear 
what is what.
Line 1510: 
Line 1511: expected_format = volume.FMT2STR[vol.getFormat()]
Line 1512: actual_format = actual_info["format"]
Line 1513: if expected_format != actual_format:


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[laravot]

Liron Aravot has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1514: raise se.ImageVerificationError(
Line 1515: "Uploaded image format is %s while the format 
specified "
Line 1516: "by the user is %s" % (actual_format, 
expected_format)
Line 1517: )
Line 1518: if "backingfile" in actual_info:
> We cannot support this since a user cannot send us valid backingfile option
I believe thats a relevant scenario that we need to support, if not now so in 
the future.
Line 1519: raise se.ImageVerificationError(
Line 1520: "'%s' is defined as a backingfile, while backingfile 
is not "
Line 1521: "allowed for an uploaded image."
Line 1522: % actual_info["backingfile"]


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1505: @public
Line 1506: def verify_untrusted_volume(self, spUUID, sdUUID, imgUUID, 
volUUID):
Line 1507: dom = sdCache.produce(sdUUID=sdUUID)
Line 1508: vol = dom.produceVolume(imgUUID, volUUID)
Line 1509: actual_info = qemuimg.info(vol.getVolumePath())
> I didn't get your comment - we have two "infos" here -
I agree, the error should not mention upload.
Line 1510: 
Line 1511: expected_format = volume.FMT2STR[vol.getFormat()]
Line 1512: actual_format = actual_info["format"]
Line 1513: if expected_format != actual_format:


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[laravot]

Liron Aravot has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1505: @public
Line 1506: def verify_untrusted_volume(self, spUUID, sdUUID, imgUUID, 
volUUID):
Line 1507: dom = sdCache.produce(sdUUID=sdUUID)
Line 1508: vol = dom.produceVolume(imgUUID, volUUID)
Line 1509: actual_info = qemuimg.info(vol.getVolumePath())
> No, this is very wrong. The actual info is whats we have on storage, report
I didn't get your comment - we have two "infos" here -
one received from the uploaded image and one which resides on the storage. I 
don't mind what are the names, but it should be clear what is what. right now 
it isn't and one should go to the start of the method to check what is each one.

If this is a generic method, the errors returned from here shouldn't contain 
"upload" specific comments.
Line 1510: 
Line 1511: expected_format = volume.FMT2STR[vol.getFormat()]
Line 1512: actual_format = actual_info["format"]
Line 1513: if expected_format != actual_format:


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/55746/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1562: """
Line 1563: Move/Copy image between storage domains within same storage 
pool
Line 1564: """
Line 1565: argsStr = ("spUUID=%s, srcDomUUID=%s, dstDomUUID=%s, 
imgUUID=%s, "
Line 1566:"vmUUID=%s, op=%s, force=%s, postZero=%s 
force=%s" %
> The placement of the terminating parenthesis - use:
Done
Line 1567:(spUUID, srcDomUUID, dstDomUUID, imgUUID, vmUUID, 
op,
Line 1568: force, postZero, force))
Line 1569: vars.task.setDefaultException(se.MoveImageError("%s" % 
argsStr))
Line 1570: if srcDomUUID == dstDomUUID:


-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add device setup and teardown

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add device setup and teardown
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/55135/6/tests/vmTests.py
File tests/vmTests.py:

PS6, Line 1119: [('setup', (), {}), ('teardown', (), {})
> I don't really understand. The devices are linear, therefore the one that f
You are right, it is just me being (too) paranoid.
I don't really like this constraint being implicit, 
but I think we can move on and drop this, because I don't see any actual flaw 
here.


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sr-iov: use device setup instead of detach

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sr-iov: use device setup instead of detach
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55137
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c97af2ea9f17ef38f9dbb4f41e5f9d1da9eebaa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netinfo: report switch type

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: netinfo: report switch type
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55810
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00c1267bee9c3a8fb45b72a483e0999139abaa8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Apply storage QoS on running VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 18:

* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check Product::#1201482::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: move RollbackIncomplete to network errors

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: move RollbackIncomplete to network errors
..


Patch Set 6: Verified+1

Passed functional network tests.

-- 
To view, visit https://gerrit.ovirt.org/55311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45a4ab3cbb9aa999a955e9cc6e73ad3ab2930cf7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Apply storage QoS on running VM

[rmohr]

Roman Mohr has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 18:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netinfo: report switch type

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: netinfo: report switch type
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55810
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00c1267bee9c3a8fb45b72a483e0999139abaa8d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add device setup and teardown

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: add device setup and teardown
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/55135/6/tests/vmTests.py
File tests/vmTests.py:

PS6, Line 1119: [('setup', (), {}), ('teardown', (), {})
> it would be nicer if we could check that the device tore down was the same 
I don't really understand. The devices are linear, therefore the one that 
failed setup will only have called setup, and all previous will have called 
setup


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add device setup and teardown

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add device setup and teardown
..


Patch Set 6: Code-Review+1

(3 comments)

partial review looks good so far.
Few questions/suggestions about the tests while I review the rest

https://gerrit.ovirt.org/#/c/55135/6/tests/vmTests.py
File tests/vmTests.py:

PS6, Line 1084: conf = {'vmName': 'testVm', 'vmId': 
'9ffe28b6-6134-4b1e-beef-1185f49c436f',
  : 'smp': '8', 'maxVCpus': '160', 'memSize': '1024',
  : 'memGuaranteedSize': '512', 'devices': []}
nit: in _new_ code I'd really prefer to see

  conf = {
'vmName': 'testVm',
...
'devices': [],
  }


PS6, Line 1100: with self.assertNotRaises():
  : testvm._setup_devices()
this works, but could be better:

  self.assertNotRaises(testvm._setup_devices)

(here and below in a few other places)


PS6, Line 1119: [('setup', (), {}), ('teardown', (), {})
it would be nicer if we could check that the device tore down was the same one 
that failed setup.
Maybe add some identification to the device objects? :\
(I'm fine improving in a later patch)


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add MoM scripts to change storage QoS on running VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Add MoM scripts to change storage QoS on running VM
..


Patch Set 5:

* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check Product::#1201482::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54208
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72ba6460dee19cab443b8ee57791a8c876a0419b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Apply storage QoS on running VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Apply storage QoS on running VM
..


Patch Set 18:

* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check Product::#1201482::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/52746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f5fcb8705c974f1d91c90cdb3158d2e8dd314f8
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: move RollbackIncomplete to network errors

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: move RollbackIncomplete to network errors
..


Patch Set 6:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55311
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45a4ab3cbb9aa999a955e9cc6e73ad3ab2930cf7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add vdsClient hotunplug command

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: add vdsClient hotunplug command
..


Patch Set 12:

* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Product::#1234283::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie00e5510b5306d689536b24091411332c8b80e75
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose hotplug via vdsClient

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: expose hotplug via vdsClient
..


Patch Set 12:

* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Product::#1234283::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46fb415c39d04b94428703ac19da505a2cf2800d
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose parameters needed to support hotunplug

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: expose parameters needed to support hotunplug
..


Patch Set 12:

* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Product::#1234283::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for hotunplug

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: add support for hotunplug
..


Patch Set 14:

* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Product::#1234283::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: netinfo: report switch type

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: netinfo: report switch type
..

net: netinfo: report switch type

Change-Id: I00c1267bee9c3a8fb45b72a483e0999139abaa8d
Signed-off-by: Petr Horáček 
Bug-Url: https://bugzilla.redhat.com/1195208
---
M lib/vdsm/kernelconfig.py
M lib/vdsm/netinfo/__init__.py
2 files changed, 8 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/55810/1

diff --git a/lib/vdsm/kernelconfig.py b/lib/vdsm/kernelconfig.py
index 1c97ed2..295e8a2 100644
--- a/lib/vdsm/kernelconfig.py
+++ b/lib/vdsm/kernelconfig.py
@@ -65,7 +65,6 @@
 _normalize_bonding_nics(config_copy)
 _normalize_address(config_copy)
 _normalize_ifcfg_keys(config_copy)
-_normalize_switch_types(config_copy)
 
 return config_copy
 
@@ -83,6 +82,7 @@
 _translate_nics(attributes, nics)
 _translate_ipaddr(attributes, net_attr)
 _translate_hostqos(attributes, net_attr)
+_translate_switch_type(attributes, net_attr)
 
 return attributes
 
@@ -139,7 +139,8 @@
 def _translate_netinfo_bond(bond_attr):
 return {
 'nics': sorted(bond_attr['slaves']),
-'options': bonding.bondOptsForIfcfg(bond_attr['opts'])
+'options': bonding.bondOptsForIfcfg(bond_attr['opts']),
+'switch': bond_attr['switch']
 }
 
 
@@ -147,6 +148,10 @@
 if net_attr.get('hostQos'):
 attributes['hostQos'] = _remove_zero_values_in_net_qos(
 net_attr['hostQos'])
+
+
+def _translate_switch_type(attributes, net_attr):
+attributes['switch'] = net_attr['switch']
 
 
 def _remove_zero_values_in_net_qos(net_qos):
@@ -235,14 +240,6 @@
 for k in net_attr.keys():
 if unsupported(k):
 net_attr.pop(k)
-
-
-def _normalize_switch_types(config_copy):
-# Hide switch type as it is not reported by netinfo and cannot be compared.
-for data in config_copy.networks, config_copy.bonds:
-for attrs in six.itervalues(data):
-attrs.pop('switch', None)
-return config_copy
 
 
 def _parse_bond_options(opts):
diff --git a/lib/vdsm/netinfo/__init__.py b/lib/vdsm/netinfo/__init__.py
index 941113a..d91ec98 100644
--- a/lib/vdsm/netinfo/__init__.py
+++ b/lib/vdsm/netinfo/__init__.py
@@ -54,6 +54,7 @@
 if interface is not None:
 nets[netname]['iface'] = interface.get('dev')
 nets[netname]['bridged'] = False
+# based on interface, virtualport type=?openvswitch
 else:
 nets[netname]['bridge'] = xml.find('.//bridge').get('name')
 nets[netname]['bridged'] = True


-- 
To view, visit https://gerrit.ovirt.org/55810
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I00c1267bee9c3a8fb45b72a483e0999139abaa8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches