Change in vdsm[master]: mount: Add mounts monitor
Nir Soffer has posted comments on this change. Change subject: mount: Add mounts monitor .. Patch Set 3: Verified+1 Verified using the tests (when running as root). -- To view, visit https://gerrit.ovirt.org/56516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25ad36ebfde12d2e3250e893de98bba66f160623 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Streamline backing file path building
Nir Soffer has uploaded a new change for review. Change subject: mount: Streamline backing file path building .. mount: Streamline backing file path building Use os.path.join to create the path instead of joining strings, making the code more clear. Change-Id: I6db8ac7296d68aac8c45f69ecadb95423f4074ff Signed-off-by: Nir Soffer --- M lib/vdsm/storage/mount.py 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/56518/1 diff --git a/lib/vdsm/storage/mount.py b/lib/vdsm/storage/mount.py index 2fd7237..654e3be 100644 --- a/lib/vdsm/storage/mount.py +++ b/lib/vdsm/storage/mount.py @@ -126,11 +126,13 @@ minor = os.minor(st.st_rdev) major = os.major(st.st_rdev) -loopdir = os.path.join(_SYS_DEV_BLOCK_PATH, - '%d:%d' % (major, minor), - 'loop') +backing_file = os.path.join(_SYS_DEV_BLOCK_PATH, +'%d:%d' % (major, minor), +'loop', +'backing_file') + try: -with open(loopdir + "/backing_file", "r") as f: +with open(backing_file, "r") as f: # Remove trailing newline return f.read()[:-1] except IOError as e: -- To view, visit https://gerrit.ovirt.org/56518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6db8ac7296d68aac8c45f69ecadb95423f4074ff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Streamline backing file path building
gerrit-hooks has posted comments on this change. Change subject: mount: Streamline backing file path building .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56518 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6db8ac7296d68aac8c45f69ecadb95423f4074ff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support
Jenkins CI has posted comments on this change. Change subject: mount: Remove EL 6 /etc/mtab support .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/56517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Remove EL 6 /etc/mtab support
gerrit-hooks has posted comments on this change. Change subject: mount: Remove EL 6 /etc/mtab support .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Remove EL 6 mtab support
Nir Soffer has uploaded a new change for review.
Change subject: mount: Remove EL 6 mtab support
..
mount: Remove EL 6 mtab support
On EL6 we used /etc/mtab to resolve loop devices backing image. On EL7
(and Fedora) /etc/mtab is a symlink to /proc/self/mounts - just like
/proc/mounts, and we resolve loop mount backing files using
/sys/block/major:minor/loop/backing_file.
This patch removes the now useless support for /etc/mtab, the caching
mechanism hiding the O(N^2) loop device resolving code, and the complex
performance tests simulating a EL6 system with 1 loop devices.
Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80
Signed-off-by: Nir Soffer
---
M lib/vdsm/storage/mount.py
M tests/mountTests.py
2 files changed, 1 insertion(+), 154 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/56517/1
diff --git a/lib/vdsm/storage/mount.py b/lib/vdsm/storage/mount.py
index 2fd7237..412d1fc 100644
--- a/lib/vdsm/storage/mount.py
+++ b/lib/vdsm/storage/mount.py
@@ -25,7 +25,6 @@
import os
import re
import stat
-import threading
from collections import namedtuple
from os.path import normpath
@@ -45,7 +44,6 @@
MountRecord = namedtuple("MountRecord", "fs_spec fs_file fs_vfstype "
"fs_mntops fs_freq fs_passno")
-_ETC_MTAB_PATH = '/etc/mtab'
_PROC_MOUNTS_PATH = '/proc/mounts'
_SYS_DEV_BLOCK_PATH = '/sys/dev/block/'
@@ -74,38 +72,12 @@
fs_freq, fs_passno)
-def _iterateMtab():
-with open(_ETC_MTAB_PATH, "r") as f:
-for line in f:
-yield _parseFstabLine(line)
-
-
def _parseFstabPath(path):
return _RE_ESCAPE.sub(lambda s: chr(int(s.group()[1:], 8)), path)
class MountError(RuntimeError):
pass
-
-
-_loopFsSpecsLock = threading.Lock()
-_loopFsSpecs = {}
-_loopFsSpecsTimestamp = None
-
-
-def _getLoopFsSpecs():
-global _loopFsSpecsTimestamp
-with _loopFsSpecsLock:
-mtabTimestamp = os.stat(_ETC_MTAB_PATH).st_mtime
-if _loopFsSpecsTimestamp != mtabTimestamp:
-global _loopFsSpecs
-_loopFsSpecs = {}
-for entry in _iterateMtab():
-for opt in entry.fs_mntops:
-if opt.startswith('loop='):
-_loopFsSpecs[opt[len('loop='):]] = entry.fs_spec
-_loopFsSpecsTimestamp = mtabTimestamp
-return _loopFsSpecs
def _resolveLoopDevice(path):
@@ -136,14 +108,6 @@
except IOError as e:
if e.errno != errno.ENOENT:
raise
-
-# Old kernels might not have the sysfs entry, this is a bit slower and does
-# not work on hosts that do support the above method.
-
-lookup = _getLoopFsSpecs()
-
-if path in lookup:
-return lookup[path]
return path
diff --git a/tests/mountTests.py b/tests/mountTests.py
index 7903e9e..3cb1698 100644
--- a/tests/mountTests.py
+++ b/tests/mountTests.py
@@ -20,10 +20,8 @@
from contextlib import contextmanager
import errno
-from tempfile import mkstemp, mkdtemp
+from tempfile import mkstemp
import os
-import shutil
-import stat
from vdsm import udevadm
from vdsm.utils import stopwatch
@@ -163,120 +161,6 @@
udevadm.settle(5)
-class IterMountsPerfTests(TestCaseBase):
-line_fmt = ('%(fs_spec)s\t%(fs_file)s\t%(fs_vfstype)s'
-'\t%(fs_mntops)s\t%(fs_freq)s\t%(fs_passno)s\n')
-
-@classmethod
-def _createFiles(cls, path, size):
-mounts_path = os.path.join(path, 'mounts')
-mtab_path = os.path.join(path, 'mtab')
-
-with open(mounts_path, 'w') as mounts:
-with open(mtab_path, 'w') as mtab:
-for i in range(100):
-mnt = mount.MountRecord('/dev/sda%d' % i,
-'/some/path/%d' % i,
-'btrfs',
-'rw,relatime',
-'0', '0')
-mounts.write(cls.line_fmt % mnt._asdict())
-mtab.write(cls.line_fmt % mnt._asdict())
-
-for i in range(size):
-mounts_mnt = mount.MountRecord('/dev/loop%d' % i,
- '/mnt/loop%d' % i,
- 'xfs',
- 'rw,foobar,errors=continue',
- '0', '0')
-mtab_mnt = mount.MountRecord('/images/loop%d.img' % i,
- '/mnt/loop%d' % i,
- 'xfs',
- 'rw,loop=/dev/loop%d' % i,
- '0', '0')
-mounts.write(cls.line_fmt % mounts_mnt._asdict())
-mtab
Change in vdsm[master]: mount: Remove EL 6 mtab support
gerrit-hooks has posted comments on this change. Change subject: mount: Remove EL 6 mtab support .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56517 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49a66b19924accc93f626eca98b2e91a3b7f5e80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Add mounts monitor
gerrit-hooks has posted comments on this change. Change subject: mount: Add mounts monitor .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25ad36ebfde12d2e3250e893de98bba66f160623 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Add mounts monitor
Nir Soffer has uploaded a new change for review.
Change subject: mount: Add mounts monitor
..
mount: Add mounts monitor
Since kernel version 2.6.15, /proc/mounts is pollable: after opening the
file for reading, a change in this file (i.e., a filesystem mount or
unmount) causes poll(2) to mark the file as having an error condition.
This patch adds mount.Monitor for detecting mount changes. The monitor runs in
a background thread and invoke a callback each time mounts change.
In the next patches we will use the monitor for the mounts cache and for
waiting until mount and unmount commands finished instead of the current
udevadm hack.
Change-Id: I25ad36ebfde12d2e3250e893de98bba66f160623
Signed-off-by: Nir Soffer
---
M lib/vdsm/storage/mount.py
M tests/mountTests.py
2 files changed, 225 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/56516/2
diff --git a/lib/vdsm/storage/mount.py b/lib/vdsm/storage/mount.py
index 2fd7237..71fa966 100644
--- a/lib/vdsm/storage/mount.py
+++ b/lib/vdsm/storage/mount.py
@@ -24,6 +24,7 @@
import logging
import os
import re
+import select
import stat
import threading
@@ -32,9 +33,12 @@
from vdsm import cmdutils
from vdsm import commands
+from vdsm import concurrent
from vdsm import constants
from vdsm import supervdsm
from vdsm import utils
+from vdsm.infra import filecontrol
+from vdsm.infra import eventfd
# Common vfs types
@@ -315,3 +319,140 @@
return
raise MountError(rc, ";".join((out, err)))
+
+
+class Monitor(object):
+"""
+Monitor mounts changes for current process.
+
+Since kernel version 2.6.15, /proc/mounts is pollable: after opening the
+file for reading, a change in this file (i.e., a filesystem mount or
+unmount) causes poll(2) to mark the file as having an error condition.
+
+Usage:
+
+def was_changed():
+print "mounts change detected"
+
+monitor = mounts.Monitor(was_changed)
+monitor.start()
+...
+monitor.stop()
+...
+monitor.wait()
+
+"""
+
+log = logging.getLogger("storage.Mount.Monitor")
+
+def __init__(self, callback):
+self._was_changed = callback
+self._wakeupfd = eventfd.EventFD(eventfd.EFD_CLOEXEC |
+ eventfd.EFD_NONBLOCK)
+try:
+self._mountsfd = os.open("/proc/mounts", os.O_RDONLY)
+except:
+try:
+self._wakeupfd.close()
+except Exception as e:
+self.log.exception("Unable to close wakeup fd: %s", e)
+raise
+filecontrol.set_close_on_exec(self._mountsfd)
+self._thread = concurrent.thread(self._run)
+self._stopped = False
+
+def start(self):
+"""
+Start the monitor.
+"""
+self.log.info("Start monitoring mounts")
+self._thread.start()
+
+def stop(self):
+"""
+Stop the monitor.
+
+To wait until the monitor stop, use wait().
+"""
+self.log.info("Stop monitoring mounts")
+self._stopped = True
+while True:
+try:
+return self._wakeupfd.write(1)
+except OSError as e:
+if e.errno == errno.EINTR:
+continue
+if e.errno == errno.EAGAIN:
+# If the eventfd is not writable, it should be readable,
+# and poll will return soon.
+return
+if e.errno == errno.EBADF:
+return
+raise
+
+def wait(self, timeout=None):
+"""
+Wait until the monitor stops. Return True if the monitor has stooped
+and False if the timeout expired.
+"""
+self._thread.join(timeout)
+return not self._thread.is_alive()
+
+def _run(self):
+self.log.debug("Mounts monitor started")
+poller = select.poll()
+poller.register(self._mountsfd, select.POLLPRI)
+poller.register(self._wakeupfd, select.POLLIN)
+try:
+while not self._stopped:
+try:
+events = poller.poll()
+except EnvironmentError as e:
+if e.errno != errno.EINTR:
+raise
+continue
+for fd, event in events:
+if fd is self._mountsfd:
+self._handle_mounts(event)
+elif fd is self._wakeupfd.fileno():
+self._handle_wakeup(event)
+else:
+raise AssertionError("Unexpected fd recevied from "
+ "poll (fd=%d, event=%d)"
+ % (fd, event))
+finally:
+poller.unregister(s
Change in vdsm[master]: mount: Add mounts monitor
gerrit-hooks has posted comments on this change. Change subject: mount: Add mounts monitor .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25ad36ebfde12d2e3250e893de98bba66f160623 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: mount: Add mounts monitor
gerrit-hooks has posted comments on this change. Change subject: mount: Add mounts monitor .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56516 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25ad36ebfde12d2e3250e893de98bba66f160623 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg.py: Don't check -T support
Adam Litke has posted comments on this change. Change subject: qemuimg.py: Don't check -T support .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4ac5f44b2788b76a49440330033dfc5faea0831 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata
Nir Soffer has posted comments on this change. Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata .. Patch Set 6: Please check my comments on version 2: https://gerrit.ovirt.org/#/c/56172/2/tests/storage_volume_artifacts_test.py -- To view, visit https://gerrit.ovirt.org/56172 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I366fd989b1387aa483a74e14dcfdc91b9f422060 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes
Nir Soffer has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 7: (3 comments) https://gerrit.ovirt.org/#/c/49952/7/automation/check-patch.packages.el7 File automation/check-patch.packages.el7: Line 14: python-inotify Line 15: python-ioprocess Line 16: python-netaddr Line 17: python-nose Line 18: python-tox Maybe install this via pip? Line 19: python-pthreading Line 20: python-rtslib Line 21: python-six Line 22: python34-nose https://gerrit.ovirt.org/#/c/49952/7/automation/check-patch.packages.fc23 File automation/check-patch.packages.fc23: Line 13: python-inotify Line 14: python-ioprocess Line 15: python-netaddr Line 16: python-nose Line 17: python-tox Maybe install via pip? Line 18: python-pthreading Line 19: python-six Line 20: python3-netaddr Line 21: python3-nose https://gerrit.ovirt.org/#/c/49952/7/tox.sh File tox.sh: Line 19: PEP8_BLACKLIST=(config.py \ Line 20: constants.py \ Line 21: crossImportsTests.py \ Line 22: vdsm.py \ Line 23: ) Unwanted tab Line 24: Line 25: if [ 'pyflakes' = "$1" ]; then Line 26: (find . -path './.tox' -prune -type f -o \ Line 27: -path './.git' -prune -type f -o \ -- To view, visit https://gerrit.ovirt.org/49952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg.py: Don't check compat support
Nir Soffer has posted comments on this change. Change subject: qemuimg.py: Don't check compat support .. Patch Set 1: Code-Review+1 Looks good, waiting for rebase and another review. -- To view, visit https://gerrit.ovirt.org/55925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie141ac33f60b340b7f12832e4fb6b92ea6a68289 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg.py: Don't check -T support
Nir Soffer has posted comments on this change. Change subject: qemuimg.py: Don't check -T support .. Patch Set 1: Code-Review+1 Looks good, waiting for another review. -- To view, visit https://gerrit.ovirt.org/55926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4ac5f44b2788b76a49440330033dfc5faea0831 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg.py: Don't check compat support
Nir Soffer has posted comments on this change. Change subject: qemuimg.py: Don't check compat support .. Patch Set 1: Please rebase. -- To view, visit https://gerrit.ovirt.org/55925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie141ac33f60b340b7f12832e4fb6b92ea6a68289 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Remove EL6 comment
Nir Soffer has submitted this change and it was merged. Change subject: qemuimg: Remove EL6 comment .. qemuimg: Remove EL6 comment EL6 is no longer supported, no need to document where its qemu-img binary is installed. Change-Id: I9a49424ab9fa8e37655a0f75e3108549b2d1ae8d Signed-off-by: Allon Mureinik Reviewed-on: https://gerrit.ovirt.org/55794 Reviewed-by: Adam Litke Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M lib/vdsm/qemuimg.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/55794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a49424ab9fa8e37655a0f75e3108549b2d1ae8d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Remove EL6 comment
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Remove EL6 comment .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/55794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a49424ab9fa8e37655a0f75e3108549b2d1ae8d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: qemuimg: Remove EL6 comment
Nir Soffer has posted comments on this change. Change subject: qemuimg: Remove EL6 comment .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a49424ab9fa8e37655a0f75e3108549b2d1ae8d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Don't set connected attribute in if already...
Nir Soffer has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/56224/4//COMMIT_MSG Commit Message: Line 19: Line 20: In theory, it prevents changing the attribute value from Engine after Line 21: the VM has been started. But we don't support such a feature now and Line 22: we're probably not going to add it in a foreseeable future, so this Line 23: limitation shouldn't matter. This smells like the wrong place to fix. If we want to support shared sessions, why not fix engine to send connectionAction = "keep"? Line 24: Line 25: Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c Line 26: Bug-Url: https://bugzilla.redhat.com/1060573 https://gerrit.ovirt.org/#/c/56224/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3794 Line 3795 Line 3796 Line 3797 Line 3798 This change ignore the value of connAct, so engine lost control - silently. Line 3801 Line 3802 Line 3803 Line 3804 Line 3805 If we keep this solution, please log a debug message here about ignoring connAct and keeping current session. -- To view, visit https://gerrit.ovirt.org/56224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Set timeout on boot menu
Nir Soffer has posted comments on this change.
Change subject: virt: Set timeout on boot menu
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/56393/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 240:
Line 241: ('boot_menu_timeout', '10',
Line 242: 'Boot menu timeout in seconds. '
Line 243: 'Minimum value is 0, maximum value is 65; if a different
value '
Line 244: 'is given then it is adjusted to this range.'),
Vdsm conf is not the place for this, this should be a per-vm settings
controlled by the owner of the vm, not global per-host setting.
With node/rhevh administrators do not have access to vdsm.conf.
Line 245: ]),
Line 246:
Line 247: # Section: [rpc]
Line 248: ('rpc', [
https://gerrit.ovirt.org/#/c/56393/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 302: timeout = config.getint('vars', 'boot_menu_timeout') *
1000
Line 303: if timeout < 0:
Line 304: timeout = 0
Line 305: elif timeout > 65535:
Line 306: timeout = 65535
If the configuration is invalid, we should log a warning about it or fail.
Modifying the value silently is not an option. This makes debugging
configuration issues very hard.
Also, since this timeout is needed only when boot menu is enabled, and there it
no point in boot menu without a timeout, we can just increase the timeout to
(hard coded) 10 seconds - we don't need a config option for this.
Line 307: oselem.appendChildWithArgs('bootmenu', enable='yes',
Line 308:timeout=unicode(timeout))
Line 309:
Line 310: if use_serial_console and cpuarch.is_x86(self.arch):
--
To view, visit https://gerrit.ovirt.org/56393
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f3501e8500e366e785f5a8ddfdf78fd34c997a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for bond existence
Edward Haas has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife76761b5ca5a32dcff030efd6a5bef9b9c51f7b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for nic existence
Edward Haas has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd1ae02f7e65f305f2f21101fae0303baafe1ea6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver - bond_slave commands
Edward Haas has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafe535a70139dc956594e5a30ce35509a9f8c467 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovs bonding setup
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs bonding setup .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2a3b698524d448fbc968c96a2c8104e57e770d6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovs bonding setup
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs bonding setup .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2a3b698524d448fbc968c96a2c8104e57e770d6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovs network setup
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 12: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovsnettestlib.py
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 11: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: introduce constants module
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 9: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for bond existence
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife76761b5ca5a32dcff030efd6a5bef9b9c51f7b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver - bond_slave commands
Petr Horáček has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafe535a70139dc956594e5a30ce35509a9f8c467 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver - bond_slave commands
Petr Horáček has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 2: Verified+1 Passed ovs_driver_test.py -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafe535a70139dc956594e5a30ce35509a9f8c467 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for nic existence
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd1ae02f7e65f305f2f21101fae0303baafe1ea6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver - bond_slave commands
gerrit-hooks has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafe535a70139dc956594e5a30ce35509a9f8c467 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: enhanced the legacy downtime alg
gerrit-hooks has posted comments on this change. Change subject: migration: enhanced the legacy downtime alg .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d96887ad7d9cd502441c4e594c1db40b05f17f4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovs bonding setup
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs bonding setup .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56416 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2a3b698524d448fbc968c96a2c8104e57e770d6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovs network setup
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 11: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovs network setup
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovs network setup .. Patch Set 11: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13bb7627431bac42a4195b97167a8700b713f76f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: OVS driver - bond_slave commands
Petr Horáček has posted comments on this change. Change subject: net: OVS driver - bond_slave commands .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56449/1/lib/vdsm/network/ovs/driver/vsctl.py File lib/vdsm/network/ovs/driver/vsctl.py: Line 169: command.extend(['add-bond', bridge, bond] + nics) Line 170: return Command(command) Line 171: Line 172: def attach_bond_slave(self, bond, slave): Line 173: if_cmd = ['--id=@%s' % slave, 'create', 'Interface', 'name=%s' % slave] id has to be command-unique Line 174: port_cmd = ['add', 'Port', bond, 'interfaces', '@%s' % slave] Line 175: return Command(if_cmd), Command(port_cmd) Line 176: Line 177: def detach_bond_slave(self, bond, slave): -- To view, visit https://gerrit.ovirt.org/56449 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iafe535a70139dc956594e5a30ce35509a9f8c467 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: enhanced the legacy downtime alg
gerrit-hooks has posted comments on this change. Change subject: migration: enhanced the legacy downtime alg .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d96887ad7d9cd502441c4e594c1db40b05f17f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Pass effective guest agent API version during migration
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/53523/4//COMMIT_MSG Commit Message: Line 12: Line 13: For the feature of lifecycle events for the guest it is needed that Line 14: VDSM already knows the negotiated API version right from the moment Line 15: of the migration completion so we can notify the guest about the Line 16: completion of the migration. > Ha, good point, I will make it min(MAX, passedversion) Done Line 17: Line 18: This will save VDSM from having to re-negotiate the API version, Line 19: and allow us to send the guest agent the required information right Line 20: away. https://gerrit.ovirt.org/#/c/53523/5//COMMIT_MSG Commit Message: Line 22: In case the passed version is higher than supported, the loweest Line 23: common maximum version will be chosen which will require Line 24: negotiation later on, however it will give VDSM the ability to Line 25: send the event anyway since it implies this feature to be present Line 26: on both VDSM sides of the migration. > I wrote an incorrect comment in PS4, sorry if I mislead you. well if we restore it's like a migration from a older VDSM that doesn't know events, right? In that case the version wouldn't be passed and results in an implicit version 0 => Cannot send events Line 27: Line 28: Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec Line 29: Bug-Url: https://bugzilla.redhat.com/1298120 -- To view, visit https://gerrit.ovirt.org/53523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name
Petr Horáček has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 6: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: introduce constants module
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovsnettestlib.py
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 10: Verified+1 Passed ovs_driver_test.py -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for nic existence
Petr Horáček has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 7: Verified+1 Passed ovs_test.py. -- To view, visit https://gerrit.ovirt.org/56448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd1ae02f7e65f305f2f21101fae0303baafe1ea6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: introduce constants module
Petr Horáček has posted comments on this change. Change subject: net: native ovs: introduce constants module .. Patch Set 8: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09daa5d3a346bed2449de1765195ca4eb880c151 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for bond existence
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife76761b5ca5a32dcff030efd6a5bef9b9c51f7b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for nic existence
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: check for nic existence .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd1ae02f7e65f305f2f21101fae0303baafe1ea6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for bond existence
Petr Horáček has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 5: Verified+1 Passed ovs_test.py -- To view, visit https://gerrit.ovirt.org/56461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife76761b5ca5a32dcff030efd6a5bef9b9c51f7b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: reserve ovsbr0 network name .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovsnettestlib.py
gerrit-hooks has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 10: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: ovsnettestlib.py
Petr Horáček has posted comments on this change. Change subject: net: native ovs: ovsnettestlib.py .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/56391/8/tests/network/ovs_driver_test.py File tests/network/ovs_driver_test.py: PS8, Line 26: network > redundant Done https://gerrit.ovirt.org/#/c/56391/8/tests/network/ovsnettestlib.py File tests/network/ovsnettestlib.py: PS8, Line 1: 2015- > remove Done -- To view, visit https://gerrit.ovirt.org/56391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11a4d6f06f10b6fe18f304556a1123bc3d761836 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: reserve ovsbr0 network name
Petr Horáček has posted comments on this change.
Change subject: net: native ovs: reserve ovsbr0 network name
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/56452/5/tests/network/ovs_test.py
File tests/network/ovs_test.py:
Line 100: def test_add_network_with_reserved_name(self):
Line 101: fake_running_config = BaseConfig({}, {})
Line 102: fake_to_be_added_bonds = {}
Line 103: fake_kernel_nics = ['eth0']
Line 104: with self.assertRaises(ne.ConfigNetworkError):
> You should confirm we failed on the correct specific error.
Done
Line 105: ovs_validator.validate_net_configuration(
Line 106: ovs_constants.BRIDGE_NAME, {'nic': 'eth0', 'switch':
'ovs'},
Line 107: fake_to_be_added_bonds, fake_running_config,
fake_kernel_nics)
Line 108:
--
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca84142e8fa9f25e76378abe9d05b41af921e7f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: agent: Introduction of first_connect event
Francesco Romani has posted comments on this change. Change subject: agent: Introduction of first_connect event .. Patch Set 5: Code-Review+1 thanks for the timeout -- To view, visit https://gerrit.ovirt.org/54753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idadf356c4224efa704024c0c7f87295d15899342 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Pass effective guest agent API version during migration
Francesco Romani has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration .. Patch Set 5: Code-Review-1 (1 comment) still not sure about the upgrade paths. -1 for visibility https://gerrit.ovirt.org/#/c/53523/5//COMMIT_MSG Commit Message: Line 22: In case the passed version is higher than supported, the loweest Line 23: common maximum version will be chosen which will require Line 24: negotiation later on, however it will give VDSM the ability to Line 25: send the event anyway since it implies this feature to be present Line 26: on both VDSM sides of the migration. I wrote an incorrect comment in PS4, sorry if I mislead you. We could have one issue if, for any reasons, we migrate from a Vdsm which can handle guest agent events to another one which could not. The destination Vdsm will never send the "after migration" event. Is this scenario possible? Perhaps we should require a Vdsm which could handle Guest Agent Events for clusterLevel 4.0? Another possible problem arises if 1. we run a VM managed by a Vdsm which doesn't understand guest agent events 2. we upgrade the guest agent inside the VMs, it could now understand events 3. we hibernate the VM 4. we upgrade the Vdsm to one which could handle events 5. we restore the VM what would happen in this case? Line 27: Line 28: Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec Line 29: Bug-Url: https://bugzilla.redhat.com/1298120 -- To view, visit https://gerrit.ovirt.org/53523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for nic existence
Petr Horáček has posted comments on this change.
Change subject: net: native ovs: check for nic existence
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/56448/6/lib/vdsm/network/ovs/validator.py
File lib/vdsm/network/ovs/validator.py:
PS6, Line 53: if nic is not None:
: if nic not in kernel_nics
> Sorry: if nic and ...
Done
https://gerrit.ovirt.org/#/c/56448/6/tests/network/ovs_test.py
File tests/network/ovs_test.py:
Line 56:
Line 57: def test_add_network_with_non_existing_nic(self):
Line 58: fake_running_networks = {}
Line 59: fake_kernel_nics = []
Line 60: with self.assertRaises(ne.ConfigNetworkError):
> A general note for all exceptions checks: we should check the exact failure
Added to changed tests. Will add to the rest in a separate patch.
Line 61: ovs_validator.validate_net_configuration(
Line 62: 'net1', {'nic': 'eth0', 'switch': 'ovs'},
Line 63: fake_running_networks, fake_kernel_nics)
Line 64:
--
To view, visit https://gerrit.ovirt.org/56448
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1ae02f7e65f305f2f21101fae0303baafe1ea6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs: check for bond existence
Petr Horáček has posted comments on this change. Change subject: net: native ovs: check for bond existence .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56461/4//COMMIT_MSG Commit Message: PS4, Line 9: connected with > dependent on Done https://gerrit.ovirt.org/#/c/56461/4/lib/vdsm/network/ovs/validator.py File lib/vdsm/network/ovs/validator.py: PS4, Line 58: is not None > I don't thin it is needed. Done -- To view, visit https://gerrit.ovirt.org/56461 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife76761b5ca5a32dcff030efd6a5bef9b9c51f7b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Introduction of the GuestAgentEvents class
gerrit-hooks has posted comments on this change. Change subject: virt: Introduction of the GuestAgentEvents class .. Patch Set 7: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug * Check Product::#1298120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/51781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9dde856aa43bf130e28ce1ebc8cc7dac0341f45 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: agent: Guest agent reply capability support
gerrit-hooks has posted comments on this change. Change subject: agent: Guest agent reply capability support .. Patch Set 8: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug * Check Product::#1298120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/53524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f2f26ec34728c9ad3599734bca90aa407f3c98 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Pass effective guest agent API version during migration
gerrit-hooks has posted comments on this change. Change subject: virt: Pass effective guest agent API version during migration .. Patch Set 5: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug * Check Product::#1298120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/53523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: agent: Introduction of first_connect event
gerrit-hooks has posted comments on this change. Change subject: agent: Introduction of first_connect event .. Patch Set 5: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug * Check Product::#1298120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idadf356c4224efa704024c0c7f87295d15899342 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add the migration/hibernation event handling (GuestAgent)
gerrit-hooks has posted comments on this change. Change subject: virt: Add the migration/hibernation event handling (GuestAgent) .. Patch Set 9: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug * Check Product::#1298120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/51782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If298709e7c7788e33003643dbd628f4f48e55366 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add new guest agent API function for lifecycle-events
gerrit-hooks has posted comments on this change. Change subject: virt: Add new guest agent API function for lifecycle-events .. Patch Set 6: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug * Check Product::#1298120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/51780 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2fac9daa065cb4f84289fe3910775813042096 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Let the engine control the guest lifecycle events
gerrit-hooks has posted comments on this change. Change subject: Let the engine control the guest lifecycle events .. Patch Set 2: * #1298120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1298120::OK, public bug * Check Product::#1298120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b78489169260ed53420a3b3fda33a0cc917d66c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Set timeout on boot menu
Francesco Romani has posted comments on this change. Change subject: virt: Set timeout on boot menu .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f3501e8500e366e785f5a8ddfdf78fd34c997a2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Don't set connected attribute in if already...
Milan Zamazal has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: Verified+1 Verified by installing the hook as described in the referenced bug and checking that I can open two remote viewers from the engine. -- To view, visit https://gerrit.ovirt.org/56224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers
Francesco Romani has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 3: (1 comment) I'm convinced that adding a (thin) wrapper layer is a good direction, probably our best shot atm. I'm unsure about the actual implementation. Extracting all the bits and reducing duplication *IS* a good thing, but I believe we should take additional steps and build a bit more infra. https://gerrit.ovirt.org/#/c/55769/3/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: PS3, Line 42: :rtype: DOM object the fact that we return a dom object (intentionally opaque) seem a quite strong call to pack all these functions into a class. We could do a very thin wrapper, or perhaps we could just enhance domain_descriptor and make it higher level, e.g. returning device objects instead of XML elements. What do you think? -- To view, visit https://gerrit.ovirt.org/55769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: HACK: virt: override vm type from custom property
gerrit-hooks has posted comments on this change. Change subject: HACK: virt: override vm type from custom property .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54872 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63b89f8791a9b0eb08100c62dcfa28d29b2321a6 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: expose systemd utilities
gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: expose systemd utilities
Francesco Romani has uploaded a new change for review.
Change subject: supervdsm: expose systemd utilities
..
supervdsm: expose systemd utilities
Instead of adding sudo permissions to allow to run those commands,
we expose them as supervdsm APIs.
Those systemd facilities are needed to start and stop containers.
Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987
Signed-off-by: Francesco Romani
---
A vdsm/supervdsm_api/systemd.py
1 file changed, 64 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/56491/1
diff --git a/vdsm/supervdsm_api/systemd.py b/vdsm/supervdsm_api/systemd.py
new file mode 100644
index 000..fb0f10f
--- /dev/null
+++ b/vdsm/supervdsm_api/systemd.py
@@ -0,0 +1,64 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+from vdsm import cmdutils
+from vdsm import commands
+from vdsm import utils
+
+from . import expose
+
+
+_SYSTEMCTL = utils.CommandPath("systemctl",
+ "/bin/systemctl",
+ "/usr/bin/systemctl",
+ )
+
+
+_MACHINECTL = utils.CommandPath("machinectl",
+"/bin/machinectl",
+"/usr/bin/machinectl",
+)
+
+
+@expose
+def systemd_run(unit_name, cgroup_slice, uid, gid, *args):
+_run(cmdutils.systemd_run(args,
+ unit=unit_name,
+ slice=cgroup_slice,
+ accounting=True,
+ uid=uid,
+ gid=gid))
+
+
+@expose
+def systemctl_stop(name):
+_run([_SYSTEMCTL.cmd(), 'stop', name])
+
+
+@expose
+def machinectl_poweroff(name):
+_run([_MACHINECTL.cmd(), 'poweroff', name])
+
+
+def _run(cmd):
+rc, out, err = commands.execCmd(cmd)
+if rc != 0:
+raise cmdutils.Error(cmd, rc, out, err)
+return out
--
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network: supervdsm: configure container networks
gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: optional container support
gerrit-hooks has posted comments on this change. Change subject: containers: optional container support .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: utils: add is_kvm helper
gerrit-hooks has posted comments on this change. Change subject: virt: utils: add is_kvm helper .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/55647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: containers: always add emulator to XML
gerrit-hooks has posted comments on this change. Change subject: containers: always add emulator to XML .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie40c6a3e2cdbb72053db71056092d3b7684b994d Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hook: add imagerepo feed containers
gerrit-hooks has posted comments on this change. Change subject: hook: add imagerepo feed containers .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54873 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94ae3b82150981c76a6079d5741aeca8faa1dd33 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: WIP: vm: skip domDependentInit for containers
gerrit-hooks has posted comments on this change. Change subject: WIP: vm: skip domDependentInit for containers .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/54179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7360d75c4adcab655c2cd215c6b9d91f9d92a646 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Don't set connected attribute in if already...
Francesco Romani has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Don't set connected attribute in if already...
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add is_assignable flag
Milan Zamazal has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 3:
(1 comment)
I can't judge the technical side, but codewise fine, except for wondering about
one style issue.
https://gerrit.ovirt.org/#/c/56291/4/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
Line 152: if name != 'computer':
Line 153: params['parent'] = devXML.find('parent').text
Line 154:
Line 155: params['is_assignable'] = str(_pci_header_type(name) == 0).lower()
Line 156:
I'd prefer if...else for clarity. Also, must params values be strings, couldn't
we just set the boolean value here without converting it to the string and back?
Line 157: try:
Line 158: driver_name = devXML.find('./driver/name').text
Line 159: except AttributeError:
Line 160: # No driver exposed by libvirt/sysfs.
--
To view, visit https://gerrit.ovirt.org/56291
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fd0d39e777c6bc0f3175b737ace9be92df4cca0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpcvdscli: add storage verbs
Sandro Bonazzola has posted comments on this change. Change subject: jsonrpcvdscli: add storage verbs .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2066afcbc8e7cac6a9ed534b2bb4034ea0fd854 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Don't set connected attribute in if already...
gerrit-hooks has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: * #1060573::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1060573::OK, public bug * Check Product::#1060573::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/56224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: client: do not protect requests on client side
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56288/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 93: "%s request." % method) Line 94: Line 95: Line 96: class JsonRpcRequest(object): Line 97: def __init__(self, method, params=(), reqId=None, protect=True): > I know what it does. please call the parameter protect_passwords Done Line 98: self.method = method Line 99: if protect: Line 100: self.params = protect_passwords(params) Line 101: else: -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: schema converter
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 35:
(9 comments)
https://gerrit.ovirt.org/#/c/52864/35/lib/api/json_schema.py
File lib/api/json_schema.py:
Line 1: #!/usr/bin/env python
Line 2: #
> why do you change the name of this file?
No, good reason. Will change it as you suggested in other patch.
Line 3: # Copyright (C) 2012 Adam Litke, IBM Corporation
Line 4: #
Line 5: # This program is free software; you can redistribute it and/or modify
Line 6: # it under the terms of the GNU General Public License as published by
https://gerrit.ovirt.org/#/c/52864/35/tests/schemaValidationTest.py
File tests/schemaValidationTest.py:
PS35, Line 216: if name not in params:
: raise Exception("parameters do not match
for %s.%s"
: % (command, method))
> why not
Good idea, will change.
PS35, Line 221: path = schemaapi.find_schema()
: gluster_path = schemaapi.find_schema('vdsm-api-gluster')
: cache = schemaapi.Schema([path, gluster_path])
> maybe move into setUp() and set cache as instance variable?
Done
PS35, Line 228: if not y_ret:
: if ret:
: raise Exception("Return value do not match")
: continue
> self.assertTrue(ret and y_ret)
Done
PS35, Line 234: if not isinstance(ret, list):
: raise Exception("Return expected to be
list")
> self.assertTrue(isinstance(ret, list))
Done
PS35, Line 242: if ret_type != self.swap_types(ret):
: raise Exception("Return type do not match")
> self.assertEquals(ret_type, swap_types(ret))
Done
PS35, Line 245: test_types
> same as previous methods, in each place you raise Exception
Done
PS35, Line 285: with self.assertRaises(schemaapi.MethodNotFound):
> we prefer:
Done
PS35, Line 293: assertRaises
> same
Done
--
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: introduction of schema
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 15:
(3 comments)
https://gerrit.ovirt.org/#/c/54754/15/lib/api/vdsm-events.yml
File lib/api/vdsm-events.yml:
PS15, Line 64: StatusDetails
> this is an union actually, it could contain few differents _sets_ of attrib
This is the first thing that came to my mind when I saw bunch of events that
were triggered by vdsm.
This is not really a union due to mandatory status and some of the optional
params need to be together like exit*.
PS15, Line 70: *VmStatus
> does this mean it is optional?
No, '*' is an alias as it is understood by yaml. I base this type definition on
bunch of events that I saw from live system.
https://gerrit.ovirt.org/#/c/54754/15/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Line 101: self._schema.get_method(method)
Line 102: className, methodName = method.split('.', 1)
Line 103: except (KeyError, ValueError):
Line 104: raise yajsonrpc.JsonRpcMethodNotFoundError(method)
Line 105:
> unrelated?
No, will remove
Line 106: return partial(self._dynamicMethod, className, methodName)
Line 107:
Line 108: def _convert_class_name(self, name):
Line 109: """
--
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
