Change in vdsm[master]: net: some values should be or should not be list

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: some values should be or should not be list
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cda6b112e933c1ebd79bd9485d99e8198f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 15:

(5 comments)

https://gerrit.ovirt.org/#/c/53214/15/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

PS15, Line 45: iterkeys
> This is not compatible with python3.
Done


Line 42: from vdsm import module_loader
Line 43: 
Line 44: _CONFIGURATORS = module_loader.load_modules(configurators)
Line 45: for module_name in _CONFIGURATORS.iterkeys():
Line 46: print(module_name)
> rmove print
Done
Line 47: if not hasattr(_CONFIGURATORS[module_name], 'name'):
Line 48: setattr(_CONFIGURATORS[module_name], 'name', module_name)
Line 49: 
Line 50: 


Line 44: _CONFIGURATORS = module_loader.load_modules(configurators)
Line 45: for module_name in _CONFIGURATORS.iterkeys():
Line 46: print(module_name)
Line 47: if not hasattr(_CONFIGURATORS[module_name], 'name'):
Line 48: setattr(_CONFIGURATORS[module_name], 'name', module_name)
> do it in a function - init_configurators which you call globaly
Done
Line 49: 
Line 50: 
Line 51: #
Line 52: # Configurators Interface:


https://gerrit.ovirt.org/#/c/53214/15/tests/module_loader_test.py
File tests/module_loader_test.py:

PS15, Line 41: sys.path.append(os.path.dirname(path))
> Is this for supporting relative imports?
no, it adds the temporary path to modules search path. It's only related to the 
test.


https://gerrit.ovirt.org/#/c/53214/15/vdsm.spec.in
File vdsm.spec.in:

Line 1120: %{python_sitelib}/%{vdsm_name}/kernelconfig.py*
Line 1121: %{python_sitelib}/%{vdsm_name}/libvirtconnection.py*
Line 1122: %{python_sitelib}/%{vdsm_name}/logUtils.py*
Line 1123: %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1124: %{python_sitelib}/%{vdsm_name}/machinetype.py*
> here
Done
Line 1125: %{python_sitelib}/%{vdsm_name}/momIF.py*
Line 1126: %{python_sitelib}/%{vdsm_name}/netinfo/__init__.py*
Line 1127: %{python_sitelib}/%{vdsm_name}/netinfo/addresses.py*
Line 1128: %{python_sitelib}/%{vdsm_name}/netinfo/bonding.py*


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: add gluster heal info verb

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: add gluster heal info verb
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie37b042d92115897b19cb7fc07dbf5d6b0bf038f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add basic BlockVolumeArtifacts
..


Patch Set 21:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add lvsByTag to FakeLVM

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: Add lvsByTag to FakeLVM
..

tests: Add lvsByTag to FakeLVM

lvsByTag is needed to test blockVolumeManifest.getChildren() which will
be called by the storage_volume_artifacts_test module.

Change-Id: I3f87826f624ce6edaf40e7f86657c4c824aa480b
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
2 files changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/57070/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index e967e9a..cbf3b5d 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -179,6 +179,9 @@
 tags -= set(delTags)
 lv_md['tags'] = tuple(tags)
 
+def lvsByTag(self, vgName, tag):
+return [lv for lv in self.getLV(vgName) if tag in lv.tags]
+
 def lvPath(self, vgName, lvName):
 return os.path.join(self.root, "dev", vgName, lvName)
 
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 9165bf5..9b00c02 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -307,6 +307,15 @@
 vg = lvm.getVG(self.VG_NAME)
 self.assertEqual(addtags, vg.tags)
 
+def test_lvsbytag(self):
+with self.base_config() as lvm:
+lvm.createLV(self.VG_NAME, self.LV_NAME, str(self.LV_SIZE_MB))
+lvm.changeLVTags(self.VG_NAME, self.LV_NAME, addTags=('foo',))
+lvs = lvm.lvsByTag(self.VG_NAME, 'foo')
+self.assertEqual(1, len(lvs))
+self.assertEqual(self.LV_NAME, lvs[0].name)
+self.assertEqual([], lvm.lvsByTag(self.VG_NAME, 'bar'))
+
 
 @expandPermutations
 class FakeLVMGeneralTests(VdsmTestCase):


-- 
To view, visit https://gerrit.ovirt.org/57070
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f87826f624ce6edaf40e7f86657c4c824aa480b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: snapshot wip

[automation]

gerrit-hooks has posted comments on this change.

Change subject: snapshot wip
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57057
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3649ef8d87522105b645f249f2bc35f7db7e3e29
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeStorageDomainCache

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: FakeStorageDomainCache
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Create repo image directory when creating block volumes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Create repo image directory when creating block volumes
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57071
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42ba107215e6b0316f41dfd9222b474a97b0755f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add lvsByTag to FakeLVM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add lvsByTag to FakeLVM
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57070
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87826f624ce6edaf40e7f86657c4c824aa480b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Support initial_size parameter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Support initial_size parameter
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795d5c8e187252c95764ede998447c6524b37f91
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Create repo image directory when creating block volumes

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: sdm: Create repo image directory when creating block volumes
..

sdm: Create repo image directory when creating block volumes

The qemu-img command expects to work with volume links in the storage
repository (/rhev/data-center//).  These links are normaly
lazily created when sd.produceVolume is called but since we don't have a
volume to produce yet we must create them right away.

Change-Id: I42ba107215e6b0316f41dfd9222b474a97b0755f
Signed-off-by: Adam Litke 
---
M vdsm/storage/sdm/volume_artifacts.py
1 file changed, 14 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/57071/1

diff --git a/vdsm/storage/sdm/volume_artifacts.py 
b/vdsm/storage/sdm/volume_artifacts.py
index 7de281b..d99da1c 100644
--- a/vdsm/storage/sdm/volume_artifacts.py
+++ b/vdsm/storage/sdm/volume_artifacts.py
@@ -365,7 +365,9 @@
 
 @property
 def volume_path(self):
-return lvm.lvPath(self.sd_manifest.sdUUID, self.vol_id)
+im = image.ImageManifest(self.sd_manifest.getRepoPath())
+image_dir = im.getImageDir(self.sd_manifest.sdUUID, self.img_id)
+return os.path.join(image_dir, self.vol_id)
 
 def create(self, size, vol_format, disk_type, desc, parent=None,
initial_size=None):
@@ -383,6 +385,7 @@
 lv_size = self.vol_class.calculate_volume_alloc_size(
 prealloc, size_blk, initial_size_blk)
 self._create_lv_artifact(parent, lv_size)
+self._create_image_path()
 meta_slot = self._acquire_metadata_slot()
 self._create_metadata(meta_slot, size, vol_format, prealloc, disk_type,
   desc, parent)
@@ -441,6 +444,16 @@
 lvm.createLV(self.sd_manifest.sdUUID, self.vol_id, lv_size,
  activate=True, initialTags=tags)
 
+def _create_image_path(self):
+im = image.ImageManifest(self.sd_manifest.getRepoPath())
+image_dir = im.getImageDir(self.sd_manifest.sdUUID, self.img_id)
+if not os.path.isdir(image_dir):
+self.log.info("Create placeholder %s for image's volumes",
+  image_dir)
+os.mkdir(image_dir)
+os.symlink(lvm.lvPath(self.sd_manifest.sdUUID, self.vol_id),
+   self.volume_path)
+
 def _acquire_metadata_slot(self):
 sd_id = self.sd_manifest.sdUUID
 with self.sd_manifest.acquireVolumeMetadataSlot(


-- 
To view, visit https://gerrit.ovirt.org/57071
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42ba107215e6b0316f41dfd9222b474a97b0755f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: VolumeArtifacts COW base volume support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: VolumeArtifacts COW base volume support
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If31e013187830322d4c9ebf0d76b4d6d4d81445d
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Prepare for COW_FORMAT test permutations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Prepare for COW_FORMAT test permutations
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6010b62291d7ce1e7e993de80d8c8dd50c2c08fe
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Fix blockSD file layout

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Fix blockSD file layout
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57058
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id68197ef3fb61d16c1130cec1d4d0f384d2e30b7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm_indirection: move Volume prepare and teardown

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm_indirection: move Volume prepare and teardown
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica933a9fb17450babc02e1d71c2164942e0efe70
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix for lvchange regression in rhel 6.8

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: fix for lvchange regression in rhel 6.8
..


Patch Set 1:

* #1332166::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1332166::OK, public bug
* Check Product::#1332166::SKIPPED, Wrong product Red Hat Gluster Storage and 
classification Red Hat not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57069
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cdd4f53b8494223b75a2c2041c2e8945b94ca2c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: gluster: fix for lvchange regression in rhel 6.8

[rnachimu]

Ramesh N has uploaded a new change for review.

Change subject: gluster: fix for lvchange regression in rhel 6.8
..

gluster: fix for lvchange regression in rhel 6.8

  There is a regression in lvchange command. Changes are not
applied until lv reactivation. We are changing the zeroing flag
of lv using lvchange command. This can be moved to lvconvert
command and lvchange cab be removed completely.

Bug-Url: https://bugzilla.redhat.com/1332166

Change-Id: I1cdd4f53b8494223b75a2c2041c2e8945b94ca2c
Signed-off-by: Ramesh Nachimuthu 
---
M vdsm/gluster/exception.py
M vdsm/gluster/storagedev.py
2 files changed, 2 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/57069/1

diff --git a/vdsm/gluster/exception.py b/vdsm/gluster/exception.py
index 10fa5ae..a3608d7 100644
--- a/vdsm/gluster/exception.py
+++ b/vdsm/gluster/exception.py
@@ -431,17 +431,6 @@
"data alignment %s" % (device, alignment)
 
 
-class GlusterHostStorageDeviceLVChangeFailedException(GlusterHostException):
-code = 4415
-
-def __init__(self, poolName=None, rc=0, out=(), err=()):
-self.rc = rc
-self.out = out
-self.err = err
-self.message = "Failed to run lvchange for the thin pool: %s" % (
-poolName)
-
-
 class GlusterHostStorageDeviceMakeDirsFailedException(GlusterHostException):
 code = 4416
 message = "Make directories failed"
diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index ca1ee01..c246fea 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -48,9 +48,6 @@
 _lvconvertCommandPath = utils.CommandPath("lvconvert",
   "/sbin/lvconvert",
   "/usr/sbin/lvconvert",)
-_lvchangeCommandPath = utils.CommandPath("lvchange",
- "/sbin/lvchange",
- "/usr/sbin/lvchange",)
 _vgscanCommandPath = utils.CommandPath("vgscan",
"/sbin/vgscan",
"/usr/sbin/vgscan",)
@@ -201,16 +198,12 @@
  '--thinpool', vgPoolName,
  '--poolmetadata',
  "%s/%s" % (vg.name, metaName),
- '--poolmetadataspar', 'n', '-y'])
+ '--poolmetadataspar', 'n', '-y',
+ '--zero', 'n'])
 
 if rc:
 raise ge.GlusterHostStorageDeviceLVConvertFailedException(
 vg.path, alignment, rc, out, err)
-rc, out, err = commands.execCmd([_lvchangeCommandPath.cmd,
- '--zero', 'n', vgPoolName])
-if rc:
-raise ge.GlusterHostStorageDeviceLVChangeFailedException(
-vgPoolName, rc, out, err)
 _reset_blivet(blivetEnv)
 return blivetEnv.devicetree.getDeviceByName(poolLv.name)
 


-- 
To view, visit https://gerrit.ovirt.org/57069
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cdd4f53b8494223b75a2c2041c2e8945b94ca2c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS netinfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 17:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: include OVS Netinfo in netinfo/cache.py:_get()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..


Patch Set 3:

* #1195208::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/56980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib823273a47c07b879591520237bfe122f9b9f1b5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS networks as bridgeless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: fake OVS networks as bridgeless
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: fake bridgeless networks
..


Patch Set 10:

* #1195208::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report expected devices in OVS netinfo

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: report expected devices in OVS netinfo
..

net: report expected devices in OVS netinfo

Change-Id: I5bdf8c0cd4eb2f11dfd8145d82b0d9f866595583
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/ovs/info.py
M tests/network/ovs_info_test.py
2 files changed, 52 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/57067/1

diff --git a/lib/vdsm/network/ovs/info.py b/lib/vdsm/network/ovs/info.py
index 2f6b87b..b652c44 100644
--- a/lib/vdsm/network/ovs/info.py
+++ b/lib/vdsm/network/ovs/info.py
@@ -141,7 +141,7 @@
 'dhcpv6': is_dhcpv6}
 
 
-def get_netinfo(ovs_bridges=None):
+def _get_netinfo(ovs_bridges=None):
 
 def _get_southbound_port(ports):
 southbound = None
@@ -234,3 +234,52 @@
 networking['bonds'][port] = bond_info
 
 return networking
+
+
+def _copy_port_info(source_dict, destination_dict):
+KEYS = ['mtu', 'addr', 'ipv4addrs', 'gateway', 'netmask', 'dhcpv4',
+'ipv6addrs', 'ipv6autoconf', 'ipv6gateway', 'dhcpv6', 'cfg']
+for key in KEYS:
+destination_dict[key] = source_dict[key]
+
+
+def _fake_expected_devices(netinfo):
+bridges = {}
+vlans = {}
+nics = {}
+for net, attrs in six.iteritems(netinfo):
+bridge_info = {
+'bridged': True,
+'ports': attrs['ports'],
+'stp': attrs['stp']
+}
+_copy_port_info(attrs, bridge_info)
+bridges[net] = bridge_info
+
+vlanid = attrs['vlanid']
+if vlanid is not None:
+iface = attrs['bond'] or attrs['nics'][0]
+vlan_info = {
+'vlanid': vlanid,
+'iface': iface
+}
+vlan_info.update(EMPTY_PORT_INFO)
+vlan_name = '%s.%s' % (iface, vlanid)
+vlans[vlan_name] = vlan_info
+
+for nic in attrs['nics']:
+nic_info = {
+'speed': 1000  # lie
+}
+nic_info.update(EMPTY_PORT_INFO)
+nics[nic] = nic_info
+
+netinfo['bridges'] = bridges
+netinfo['vlans'] = vlans
+netinfo['nics'] = nics
+
+return netinfo
+
+
+def get_netinfo(ovs_bridges=None):
+return _fake_expected_devices(_get_netinfo(ovs_bridges))
diff --git a/tests/network/ovs_info_test.py b/tests/network/ovs_info_test.py
index 3382ef7..3b5fcd9 100644
--- a/tests/network/ovs_info_test.py
+++ b/tests/network/ovs_info_test.py
@@ -257,8 +257,8 @@
 }
 }
 
-obtained_networks = info.get_netinfo(bridges)['networks']
+obtained_networks = info._get_netinfo(bridges)['networks']
 self.assertEquals(obtained_networks, expected_networks)
 
-obtained_bonds = info.get_netinfo(bridges)['bondings']
+obtained_bonds = info._get_netinfo(bridges)['bondings']
 self.assertEquals(obtained_bonds, expected_bonds)


-- 
To view, visit https://gerrit.ovirt.org/57067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bdf8c0cd4eb2f11dfd8145d82b0d9f866595583
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report expected devices in OVS netinfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: report expected devices in OVS netinfo
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8c0cd4eb2f11dfd8145d82b0d9f866595583
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake bridgeless networks

[phoracek]

Petr Horáček has abandoned this change.

Change subject: net: fake bridgeless networks
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/56976
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie6d83d090e356b4e0944e710fc6ef73b1c1c9bbe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS networks as bridgeless

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: fake OVS networks as bridgeless
..

net: fake OVS networks as bridgeless

Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/ovs/info.py
1 file changed, 33 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/57068/1

diff --git a/lib/vdsm/network/ovs/info.py b/lib/vdsm/network/ovs/info.py
index b652c44..c7e0e1c 100644
--- a/lib/vdsm/network/ovs/info.py
+++ b/lib/vdsm/network/ovs/info.py
@@ -23,6 +23,7 @@
 from vdsm.netinfo.routes import get_routes, get_gateway
 from vdsm.netinfo.addresses import getIpAddrs, getIpInfo, is_ipv6_local_auto
 from vdsm.netinfo.dhcp import dhcp_status
+from vdsm.network.netconfpersistence import RunningConfig
 
 from . import driver
 
@@ -281,5 +282,35 @@
 return netinfo
 
 
-def get_netinfo(ovs_bridges=None):
-return _fake_expected_devices(_get_netinfo(ovs_bridges))
+def _fake_bridgeless(netinfo):
+running_networks = RunningConfig().networks
+
+for net, attrs in six.iteritems(netinfo['networks']):
+running_attrs = running_networks.get(net)
+if running_attrs is None or running_attrs['bridged']:
+continue
+
+bond = running_attrs.get('bonding')
+nic = running_attrs.get('nic')
+tag = running_attrs.get('vlan')
+if 'vlan'in running_attrs:
+expected_vlan_name = '%s.%s' % (bond or nic, tag)
+_copy_port_info(netinfo['networks'][net],
+netinfo['vlans'][expected_vlan_name])
+elif 'bond' in running_attrs:
+_copy_port_info(netinfo['networks'][net],
+netinfo['bondings'][bond])
+elif 'nic' in running_attrs:
+_copy_port_info(netinfo['networks'][net], netinfo['nics'][nic])
+
+netinfo['bridges'].pop(net)
+netinfo['networks'][net]['bridged'] = False
+
+return netinfo
+
+
+def get_netinfo(ovs_bridges=None, fake_bridgeless=False):
+netinfo = _fake_expected_devices(_get_netinfo(ovs_bridges))
+if fake_bridgeless:
+netinfo = _fake_bridgeless(netinfo)
+return netinfo


-- 
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: include OVS Netinfo in netinfo/cache.py:_get()

[phoracek]

Petr Horáček has abandoned this change.

Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/56980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib823273a47c07b879591520237bfe122f9b9f1b5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS NetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS NetInfo
..


Patch Set 16:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/35629/6/lib/vdsm/storage/blkdiscard.py
File lib/vdsm/storage/blkdiscard.py:

Line 28: _blkdiscard = utils.CommandPath("blkdiscard",
Line 29: "/sbin/blkdiscard",)
Line 30: 
Line 31: 
Line 32: class BlkDiscardError(Exception):
Not needed, use cmdutils.Error instead.
Line 33: def __init__(self, ecode, stdout, stderr):
Line 34: self.ecode = ecode
Line 35: self.stdout = stdout
Line 36: self.stderr = stderr


Line 39: return "ecode={0}, stdout={1}, stderr={2}".format(
Line 40: self.ecode, self.stdout, self.stderr)
Line 41: 
Line 42: 
Line 43: def run_blkdiscard(device):
Should be named blkdiscard.
Line 44: cmd = [_blkdiscard.cmd]
Line 45: cmd.append(device)
Line 46: 
Line 47: rc, out, err = commands.execCmd(cmd, deathSignal=signal.SIGKILL)


-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS NetInfo

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: OVS NetInfo
..


Patch Set 15: Code-Review-1

Will be handled in a bit diffrent way, corresponding to legacy netinfo.cache, 
so they can be seamlessly switched.

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm arch specific package

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Make vdsm arch specific package
..


Patch Set 5:

Dan?

-- 
To view, visit https://gerrit.ovirt.org/42490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbc71ccded31e8b80b14dbb03fd738694ceb37c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS NetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS NetInfo
..


Patch Set 15:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: block: add blkdiscard on zero image

[nsoffer]

Nir Soffer has restored this change.

Change subject: block: add blkdiscard on zero image
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/35631
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I4e059c556c550440727b36b8af8e5dfc29ce2ccb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS NetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS NetInfo
..


Patch Set 14:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: block: simplify zeroImgVolumes using threads

[nsoffer]

Nir Soffer has restored this change.

Change subject: block: simplify zeroImgVolumes using threads
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/35630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I665d863085842de8ff93c9aacf7c26277dfb031d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 17:

(2 comments)

partial review..

https://gerrit.ovirt.org/#/c/56901/16/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

PS16, Line 64: [self._ports_uuids[uuid]
 :for uuid in 
bridge['ports']]
I think you can move it to _bridge_attr method.


PS16, Line 70: port['_uuid']
Can you send here the 'port'?
Seems like you send the uuid of the port, just to ask for the port entry back...


-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 17: Verified+1

Passed ovs_info_test.py.

Fails on Jenkins because of it uses Fedora - SELinux on Fedora blocks OVS 
devices creation in kernel.

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS NetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS NetInfo
..


Patch Set 13:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 17:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 15: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/53214/15/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

PS15, Line 45: iterkeys
This is not compatible with python3.
As you just need the keys, why not do this:

for module_name in _CONFIGURATORS:
...

If you can, try to add the load_module test to the py3 white list tests.


https://gerrit.ovirt.org/#/c/53214/15/tests/module_loader_test.py
File tests/module_loader_test.py:

PS15, Line 41: sys.path.append(os.path.dirname(path))
Is this for supporting relative imports?


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add device setup and teardown

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: add device setup and teardown
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/55135/15/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 77: def setup(self):
Line 78: """
Line 79: Actions to be executed before VM is started. This method is 
therefore
Line 80: able to modify the final device XML. Not executed in the 
recovery
Line 81: flow.
Add a big warning here about leaving the device in consistent state in case of 
failures, and mention that teardown will *not* be called in if setup failed.
Line 82: """
Line 83: pass
Line 84: 
Line 85: def teardown(self):


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: move misc module to vdsm storage lib

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: move misc module to vdsm storage lib
..


Patch Set 5:

Can you rebase and verify?

-- 
To view, visit https://gerrit.ovirt.org/56614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22627bf0d8898c491da44ced4b39e1294a322308
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: client: do not protect requests on client side

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: client: do not protect requests on client side
..


Patch Set 3:

Trying again:

Asking the user of this code to send protect_password=False for client 
connection is abusing the user of this code. The real problem is trying to 
protect passwords in the wrong place. The correct place to do this is when 
decoding a message from the wire.

If we add the wrong fix now, changing the api, hosted engine guys will add this 
flag to their code, and then we can never remove it, or we will cause them 
major pain when we remove it.

-- 
To view, visit https://gerrit.ovirt.org/56288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blockSD: fix log message in zeroImgVolumes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: blockSD: fix log message in zeroImgVolumes
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/57000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfc838c5a1a4c37ace9a2f88249527f282b1299
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blockSD: fix log message in zeroImgVolumes

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: blockSD: fix log message in zeroImgVolumes
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3bfc838c5a1a4c37ace9a2f88249527f282b1299
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blockSD: fix log message in zeroImgVolumes

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: blockSD: fix log message in zeroImgVolumes
..


blockSD: fix log message in zeroImgVolumes

When logging a debug message regarding a volume that has been zeroed, we
always use the same volume id (the last one that was passed to
_zeroVolume), instead of the correct one.
This patch logs the correct volume.

Change-Id: I3bfc838c5a1a4c37ace9a2f88249527f282b1299
Signed-off-by: Idan Shaby 
Reviewed-on: https://gerrit.ovirt.org/57000
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M vdsm/storage/blockSD.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/57000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3bfc838c5a1a4c37ace9a2f88249527f282b1299
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: get_external_vms return format for KVM images

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: get_external_vms return format for KVM images
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56912/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 935: driver = disk.find('./driver/[@type]')
Line 936: if driver is not None:
Line 937: format = driver.get('type')
Line 938: if format.lower().startswith('qcow'):
Line 939: d['format'] = 'cow'
> ok,
Also, this must be documented in the schema, we cannot return undocumented 
values.

In the schema, you will find the @VolumeFormat enum - containing "RAW" and 
"COW".
Line 940: params['disks'].append(d)
Line 941: 
Line 942: 
Line 943: def _add_networks(root, params):


-- 
To view, visit https://gerrit.ovirt.org/56912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d4985aafc21e5ff5c11ec7bca71ab9aa5b2cd9d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: v2v: add support for importing kvm based vms from libvirt
..


Patch Set 4: Code-Review+2

Shahar, please verify

-- 
To view, visit https://gerrit.ovirt.org/56459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ddbab700f2e0c54d53ed02ec61477b92c9c7960
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: kvm2ovirt: tool for copying images from libvirt

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: kvm2ovirt: tool for copying images from libvirt
..


Patch Set 7: Code-Review+2 Verified+1

Shahar, please verify

-- 
To view, visit https://gerrit.ovirt.org/55797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report ovs network with nics, vlan tag and bond

[phoracek]

Petr Horáček has abandoned this change.

Change subject: net: report ovs network with nics, vlan tag and bond
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/56991
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I844c2ef948cbb1a37ffb64f0e4bc2eac11c17fdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report ovs network with nics, vlan tag and bond

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: report ovs network with nics, vlan tag and bond
..


Patch Set 1:

* #1195208::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/56991
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I844c2ef948cbb1a37ffb64f0e4bc2eac11c17fdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Don't fail when existingConnAction is unset for a SPIC...

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Don't fail when existingConnAction is unset for a SPICE 
device
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56836
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fde83ceb994eaafd2aa956d1fa82ce6cb16094c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add basic BlockVolumeArtifacts
..


Patch Set 20: Code-Review+1

Waiting for another review.

-- 
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Support initial_size parameter

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Support initial_size parameter
..


Patch Set 13: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/56628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795d5c8e187252c95764ede998447c6524b37f91
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/56936/2/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 218: with self.fake_env() as env:
Line 219: artifacts = env.sd_manifest.get_volume_artifacts(
Line 220: self.img_id, self.vol_id)
Line 221: with MonkeyPatchScope([
Line 222: [artifacts, '_create_volume_file', failure]
We don't need to monkeypatch this object, we are throwing it away on the end of 
the test.

Can we monkey patch the object creating the file - manifest.oop.xxx?
Line 223: ]):
Line 224: self.assertRaises(ExpectedFailure, artifacts.create,
Line 225:   *BASE_RAW_PARAMS)
Line 226: self.validate_new_image_path(artifacts,


-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add basic BlockVolumeArtifacts
..


Patch Set 20:

Please another review on this change.

-- 
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Share failure function

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: Share failure function
..


tests: Share failure function

Tests that want to check failures replace VolumeArtifacts functions with
the failure() function.  Move this to the common test class so that
block tests can use it too.  Also, add **kwargs to the signature so it
will work with all functions.

Change-Id: Ib9957eed4333d89071b91ff3f842eafd7469c841
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/56863
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/storage_volume_artifacts_test.py
1 file changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/56863
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9957eed4333d89071b91ff3f842eafd7469c841
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Don't produce block volumes with TEMP_VOL_LVTAG

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7995707caaf83c93225cd414f858a556c36e5fa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Share failure function

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Share failure function
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56863
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9957eed4333d89071b91ff3f842eafd7469c841
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Don't produce block volumes with TEMP_VOL_LVTAG

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG
..


storage: Don't produce block volumes with TEMP_VOL_LVTAG

LVs with the tag TEMP_VOL_LVTAG are not volumes yet.  Validation should
prevent a VolumeManifest object from being produced against such an LV.

Change-Id: Id7995707caaf83c93225cd414f858a556c36e5fa
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/56865
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm/storage/blockVolume.py
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/56865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7995707caaf83c93225cd414f858a556c36e5fa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add device setup and teardown

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: add device setup and teardown
..


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:

Line 1114: 
Line 1115: with fake.VM(self.conf, create_device_objects=True) as 
testvm:
Line 1116: testvm._devices[hwclass.GENERAL] = devices
Line 1117: self.assertRaises(ExpectedError, testvm._setup_devices)
Line 1118: self.assertEqual(devices[0].state, fake.SETUP)
> OK, Martin's proposal works for me.
OK, so we need to document that setup must not leave the device in inconsistent 
state on any failure.

And make sure that all devices that use setup do catch *all* error and perform 
proper cleanup before raising the error.
Line 1119: self.assertEqual(devices[1].state, fake.CREATED)
Line 1120: self.assertEqual(devices[2].state, fake.CREATED)
Line 1121: 
Line 1122: def test_device_setup_fail_second(self):


-- 
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding reportStats

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Adding reportStats
..


Patch Set 1:

(6 comments)

https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/host.py
File lib/vdsm/host.py:

Line 403
Line 404
Line 405
Line 406
Line 407
Lets rename this to the new style - get_stats


Line 446: # For backwards compatibility, will be removed in the future
Line 447: stats['haScore'] = stats['haStats']['score']
Line 448: 
Line 449: stats = hooks.after_get_stats(stats)
Line 450: _current_stats = stats
Bad idea, if engine stop calling us, we never update the stats.
Line 451: return stats
Line 452: 
Line 453: 
Line 454: def reportStats():


Line 450: _current_stats = stats
Line 451: return stats
Line 452: 
Line 453: 
Line 454: def reportStats():
> isn't that what I do now? I call this reportStats from the priodic job (the
Lets name this report_stats or send_stats
Line 455: """
Line 456: Send gauge values to statsd
Line 457: The format
Line 458: """


Line 450: _current_stats = stats
Line 451: return stats
Line 452: 
Line 453: 
Line 454: def reportStats():
> I think the simplest/cleanest way is to add a new periodic.Operation, which
Too complicated, we use udp based client that should never block, so there is 
not need to use a queue.
Line 455: """
Line 456: Send gauge values to statsd
Line 457: The format
Line 458: """


Line 455: """
Line 456: Send gauge values to statsd
Line 457: The format
Line 458: """
Line 459: report = statsd.Gauge(".host." + uuid())
Isn't this a Client? Why not call it client?
Line 460: report.send('memAvailable', _current_stats['memAvailable'])
Line 461: report.send('memCommitted', _current_stats['memCommitted'])
Line 462: report.send('memFree', _current_stats['memFree'])
Line 463: report.send('swapTotal', _current_stats['swapTotal'])


Line 456: Send gauge values to statsd
Line 457: The format
Line 458: """
Line 459: report = statsd.Gauge(".host." + uuid())
Line 460: report.send('memAvailable', _current_stats['memAvailable'])
Lets use only lowercase and nice names, no shortcuts, and plural when we talk 
about collections:

.memory.available
.memory.committed
.memory.free
.swap.total
.swap.free
.vms.active
.vms.count
.vms.migrating.total
.vms.migrating.incoming
.vms.migrating.outgoing

This our chance to get rid of the ugly names in getStats.
Line 461: report.send('memCommitted', _current_stats['memCommitted'])
Line 462: report.send('memFree', _current_stats['memFree'])
Line 463: report.send('swapTotal', _current_stats['swapTotal'])
Line 464: report.send('swapFree', _current_stats['swapFree'])


-- 
To view, visit https://gerrit.ovirt.org/56880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/1//COMMIT_MSG
Commit Message:

Line 10: unexpected eof". In order to understand the state of the connection we
Line 11: want temporarily print ssl session information.
Line 12: 
Line 13: This patch should be reverted when we know that the error is expected 
or
Line 14: the issue was fixed.
Can you show an example of the output in the log?
Line 15: 
Line 16: 
Line 17: Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: make sure to handle eagain

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: stomp: make sure to handle eagain
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/56997/2//COMMIT_MSG
Commit Message:

Line 11: 
Line 12: Note that recv() may raise socket.error with EAGAIN or EWOULDBLOCK
Line 13: 
Line 14: betterAsyncore code was based on asyncore.dispatcher so the issue was
Line 15: duplicated. We need to make sure to handle this error propely.
Please mention we handle now the same errors handled by asynchat.
Line 16: 
Line 17: 
Line 18: Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Line 19: Signed-off-by: pkliczewski 


https://gerrit.ovirt.org/#/c/56997/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 116
Line 117
Line 118
Line 119
Line 120
In another patch we need to copy this constant into our code, we don't want to 
depend on private stuff from other modules.


-- 
To view, visit https://gerrit.ovirt.org/56997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7fcd96522f007dd7159c555080821c3e3f8abf1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: dispatcher can return empty string

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: stomp: dispatcher can return empty string
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56996/2/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 357
Line 358
Line 359
Line 360
Line 361
Did you check what is the source of None and what is the meaning of it?

I think we should add a comment explaining this return (e.g. socket was closed 
or no more data is available now...)


-- 
To view, visit https://gerrit.ovirt.org/56996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d3553db1b1c7ca86bd0a12a70de6d798fea906
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move hoststats code to host module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Move hoststats code to host module
..


Patch Set 2:

Lest move lib/vdsm/virt/hoststats from virt to lib/vdsm.

-- 
To view, visit https://gerrit.ovirt.org/56879
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffc814c0eacdd9a02de14b12d6f3679159e1c03
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move host stats dict creation from API.py to host module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Move host stats dict creation from API.py to host module
..


Patch Set 4:

Lets keep the name "host", it is clean and nice.

-- 
To view, visit https://gerrit.ovirt.org/56874
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Prepare for COW_FORMAT test permutations

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Prepare for COW_FORMAT test permutations
..


Patch Set 10: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6010b62291d7ce1e7e993de80d8c8dd50c2c08fe
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Support initial_size parameter

[alitke]

Adam Litke has posted comments on this change.

Change subject: Support initial_size parameter
..


Patch Set 13: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795d5c8e187252c95764ede998447c6524b37f91
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: Makefile: use tox to run make pep8 and pyflakes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: Makefile: use tox to run make pep8 and pyflakes
..


Patch Set 10:

* #1182088::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1182088::OK, public bug
* Check Product::#1182088::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stomp: dispatcher can return empty string

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: dispatcher can return empty string
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56996
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2d3553db1b1c7ca86bd0a12a70de6d798fea906
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move host stats dict creation from API.py to host module

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Move host stats dict creation from API.py to host module
..


Patch Set 5: Code-Review+1

Looks good to me, giving +1 and waiting on Francesco.

-- 
To view, visit https://gerrit.ovirt.org/56874
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move host stats dict creation from API.py to host module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Move host stats dict creation from API.py to host module
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56874
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I626a673c429d486ac78b309c2f31cb58af8852b2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: introduce the networkmanager module, with an integrat...

[osvoboda]

Ondřej Svoboda has uploaded a new change for review.

Change subject: tests: introduce the networkmanager module, with an integration 
test
..

tests: introduce the networkmanager module, with an integration test

Change-Id: Id83fa34f9ca7ca910f705e5c360ad420c7a0dcfc
Signed-off-by: Ondřej Svoboda 
---
M tests/network/Makefile.am
M tests/network/nettestlib.py
A tests/network/networkmanager.py
A tests/network/networkmanager_test.py
4 files changed, 216 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/57062/1

diff --git a/tests/network/Makefile.am b/tests/network/Makefile.am
index 9d4f7a8..6476d9d 100644
--- a/tests/network/Makefile.am
+++ b/tests/network/Makefile.am
@@ -25,6 +25,7 @@
*_test.py \
dhcp.py \
firewall.py \
+   networkmanager.py \
nettestlib.py \
$(NULL)
 
diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py
index 465c354..0881302 100644
--- a/tests/network/nettestlib.py
+++ b/tests/network/nettestlib.py
@@ -41,6 +41,7 @@
 
 from . import dhcp
 from . import firewall
+from . import networkmanager
 
 EXT_IP = "/sbin/ip"
 _IPERF3_BINARY = CommandPath('iperf3', '/usr/bin/iperf3')
@@ -443,3 +444,42 @@
 '/'.join(str(family) for family in families)))
 else:
 raise
+
+
+@contextmanager
+def nm_controlled_bond(bond_name, bond_mode=None, miimon=None,
+   ipv4_address=None, ipv4_gateway=None,
+   dhcp_server_ipv4=None, dhcp_server_ipv4_cidr=None,
+   dhcp_range_from=None, dhcp_range_to=None):
+with veth_pair() as (remote1, local1), veth_pair() as (remote2, local2):
+router_ports = [remote1, remote2]
+local_nics_to_enslave = [local1, local2]
+
+if dhcp_server_ipv4 and dhcp_server_ipv4_cidr:
+for port in router_ports:
+addrAdd(port, dhcp_server_ipv4, dhcp_server_ipv4_cidr)
+linkSet(port, ['up'])
+
+if dhcp_range_from and dhcp_range_to:
+with dnsmasq_run(router_ports, dhcp_range_from, dhcp_range_to,
+ router=ipv4_gateway):
+with wait_for_address(bond_name, families=(4,), timeout=10):
+try:
+with networkmanager.connection(
+device_name=bond_name, conn_type='bond',
+slaves=local_nics_to_enslave,
+bond_mode=bond_mode,
+miimon=miimon) as conn_name:
+yield conn_name, local_nics_to_enslave
+except networkmanager.NetworkManagerError as e:
+raise SkipTest(e.message)
+else:
+try:
+with networkmanager.connection(
+device_name=bond_name, conn_type='bond',
+slaves=local_nics_to_enslave, bond_mode=bond_mode,
+miimon=miimon, ipv4_address=ipv4_address,
+ipv4_gateway=ipv4_gateway, dhcpv4=False) as conn_name:
+yield conn_name, local_nics_to_enslave
+except networkmanager.NetworkManagerError as e:
+raise SkipTest(e.message)
diff --git a/tests/network/networkmanager.py b/tests/network/networkmanager.py
new file mode 100644
index 000..0a575cc
--- /dev/null
+++ b/tests/network/networkmanager.py
@@ -0,0 +1,131 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+from __future__ import absolute_import
+from contextlib import contextmanager
+import logging
+
+import six
+
+from vdsm.commands import execCmd
+from vdsm.utils import CommandPath
+
+_NMCLI = CommandPath('nmcli', '/usr/bin/nmcli')
+
+
+class NetworkManagerError(RuntimeError):
+pass
+
+
+def connection_add(device_name, conn_type, conn_name=None, autoconnect=None,
+   persistent=None, master=None, bond_mode=None, miimon=None,
+   ipv4_address=None, ipv4_gateway=None):
+nmcli_command = [_NMCLI.cmd, '--terse', 

Change in vdsm[master]: tests: introduce the networkmanager module, with an integrat...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: introduce the networkmanager module, with an integration 
test
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57062
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id83fa34f9ca7ca910f705e5c360ad420c7a0dcfc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: let VDSM consume a bond created by NetworkManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: let VDSM consume a bond created by NetworkManager
..


Patch Set 11:

* #1304509::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1304509::OK, public bug
* Check Product::#1304509::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7047ce59a515d0b8ed2c4c5307b4c0d47d4aa92b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/53214/15/vdsm.spec.in
File vdsm.spec.in:

Line 1120: %{python_sitelib}/%{vdsm_name}/kernelconfig.py*
Line 1121: %{python_sitelib}/%{vdsm_name}/libvirtconnection.py*
Line 1122: %{python_sitelib}/%{vdsm_name}/logUtils.py*
Line 1123: %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1124: %{python_sitelib}/%{vdsm_name}/machinetype.py*
here
Line 1125: %{python_sitelib}/%{vdsm_name}/momIF.py*
Line 1126: %{python_sitelib}/%{vdsm_name}/netinfo/__init__.py*
Line 1127: %{python_sitelib}/%{vdsm_name}/netinfo/addresses.py*
Line 1128: %{python_sitelib}/%{vdsm_name}/netinfo/bonding.py*


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 15:

(2 comments)

btw, in vdsm-tool/vdsm-tool (the executable) there is another usage for runtime 
loading that can be replaced by your module

https://gerrit.ovirt.org/#/c/53214/15/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 42: from vdsm import module_loader
Line 43: 
Line 44: _CONFIGURATORS = module_loader.load_modules(configurators)
Line 45: for module_name in _CONFIGURATORS.iterkeys():
Line 46: print(module_name)
rmove print
Line 47: if not hasattr(_CONFIGURATORS[module_name], 'name'):
Line 48: setattr(_CONFIGURATORS[module_name], 'name', module_name)
Line 49: 
Line 50: 


Line 44: _CONFIGURATORS = module_loader.load_modules(configurators)
Line 45: for module_name in _CONFIGURATORS.iterkeys():
Line 46: print(module_name)
Line 47: if not hasattr(_CONFIGURATORS[module_name], 'name'):
Line 48: setattr(_CONFIGURATORS[module_name], 'name', module_name)
do it in a function - init_configurators which you call globaly
Line 49: 
Line 50: 
Line 51: #
Line 52: # Configurators Interface:


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS NetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS NetInfo
..


Patch Set 12:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 15: Verified+1

(6 comments)

https://gerrit.ovirt.org/#/c/53214/13/lib/vdsm/module_loader.py
File lib/vdsm/module_loader.py:

PS13, Line 34: 
 : 
> Can we please control this with a flag?
I want a more general behavior so I removed this part from the function


https://gerrit.ovirt.org/#/c/53214/14/lib/vdsm/module_loader.py
File lib/vdsm/module_loader.py:

Line 26: def load_modules(pkg_name):
Line 27: modules = {}
Line 28: for _, module_name, _ in 
pkgutil.iter_modules([pkg_name.__path__[0]]):
Line 29: modules[module_name] = importlib.import_module(
Line 30: '{}.{}'.format(pkg_name.__name__, module_name))
> remove comment .. and prints..
this is a draft version


Line 32
Line 33
Line 34
Line 35
Line 36
> optional?
Done


https://gerrit.ovirt.org/#/c/53214/13/tests/module_loader_test.py
File tests/module_loader_test.py:

PS13, Line 40: utils.touchFile(os.path.join(path, '__init__.py'))
 : sys.path.append(os.path.dirname(path))
 : yield importlib.import_module(os.path.basename(path))
 : 
> What about moving this to a separated contextmanager?
Done


https://gerrit.ovirt.org/#/c/53214/13/vdsm.spec.in
File vdsm.spec.in:

Line 1191
Line 1192
Line 1193
Line 1194
Line 1195
> Please do not fix this here, it will cause uneeded conflicts with other cha
Done


Line 1191
Line 1192
Line 1193
Line 1194
Line 1195
> I agree, this change is not related to this patch.
Done


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: Makefile: use tox to run make pep8 and pyflakes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: Makefile: use tox to run make pep8 and pyflakes
..


Patch Set 9:

* #1182088::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1182088::OK, public bug
* Check Product::#1182088::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yeela Kaplan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 16: Verified+1

(3 comments)

Passed ovs_info_test.py.

Added sleep(1) before setting IP, because it was not able to find created 
interface on Jenkins.

https://gerrit.ovirt.org/#/c/56901/15/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

PS15, Line 33: ovsdb):
> ovsdb
Done


Line 44: self.ports = ports_command.result
Line 45: self.ifaces = ifaces_command.result
Line 46: 
Line 47: 
Line 48: class OvsInfo(object):
> Only one usage... you can convert it to a list comprehension at the caller.
Done
Line 49: def __init__(self):
Line 50: ovs_db = OvsDB(driver.create())
Line 51: self._ports_uuids = {port['_uuid']: port
Line 52:  for port in ovs_db.ports}


PS15, Line 73: return {'ports': ports, 'stp': stp}
 : 
> Better move it to the __init__ method to avoid kipping _ovs_db at the insta
Done


-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 16:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 14:

(3 comments)

https://gerrit.ovirt.org/#/c/53214/14/lib/vdsm/module_loader.py
File lib/vdsm/module_loader.py:

Line 26: 
Line 27: 
Line 28: def load_modules(pkg_name):
Line 29: print(sys.path)
Line 30: #sys.path.append(os.path.dirname(pkg_path))
remove comment .. and prints..
Line 31: modules = {}
Line 32: for _, module_name, _ in 
pkgutil.iter_modules([pkg_name.__path__[0]]):
Line 33: modules[module_name] = importlib.import_module(
Line 34: '{}.{}'.format(pkg_name.__name__, module_name))


Line 32: for _, module_name, _ in 
pkgutil.iter_modules([pkg_name.__path__[0]]):
Line 33: modules[module_name] = importlib.import_module(
Line 34: '{}.{}'.format(pkg_name.__name__, module_name))
Line 35: if not hasattr(modules[module_name], 'name'):
Line 36: setattr(modules[module_name], 'name', module_name)
optional?


https://gerrit.ovirt.org/#/c/53214/14/vdsm.spec.in
File vdsm.spec.in:

Line 1121: %{python_sitelib}/%{vdsm_name}/libvirtconnection.py*
Line 1122: %{python_sitelib}/%{vdsm_name}/logUtils.py*
Line 1123: %{python_sitelib}/%{vdsm_name}/m2cutils.py*
Line 1124: %{python_sitelib}/%{vdsm_name}/machinetype.py*
Line 1125: %{python_sitelib}/%{vdsm_name}/momIF.py*
should be here
Line 1126: %{python_sitelib}/%{vdsm_name}/netinfo/__init__.py*
Line 1127: %{python_sitelib}/%{vdsm_name}/netinfo/addresses.py*
Line 1128: %{python_sitelib}/%{vdsm_name}/netinfo/bonding.py*
Line 1129: %{python_sitelib}/%{vdsm_name}/netinfo/bridges.py*


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: some values should be or should not be list

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: some values should be or should not be list
..


Patch Set 4: Verified+1

(4 comments)

Passed ovs_driver_test.py

https://gerrit.ovirt.org/#/c/57034/3/lib/vdsm/network/ovs/driver/vsctl.py
File lib/vdsm/network/ovs/driver/vsctl.py:

PS3, Line 117: obj[heading] = _normalize(heading, 
_val_to_py(record[pos]))
 : results.append(obj)
> Why not direct?
Done


PS3, Line 228: 
 : 
 : def _convert_to
> nit: return data if isinstance(data, list) else [data]
Done


PS3, Line 234: def _normalize(heading, value):
 : if heading in _DB_ENTRIES_WHICH_SHOULD_BE_LIST:
 : value =
> nit: return none if data == [] else data
Done


Line 236: value = _convert_to_list(value)
Line 237: elif heading in _DB_ENTRIES_WHICH_SHOULD_NOT_BE_LIST:
Line 238: value = _convert_to_single(value)
Line 239: return value
Line 240
> nit: it will be safer to have a test checking that the two sets are mutual 
Added a TODO


-- 
To view, visit https://gerrit.ovirt.org/57034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cda6b112e933c1ebd79bd9485d99e8198f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: some values should be or should not be list

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: some values should be or should not be list
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cda6b112e933c1ebd79bd9485d99e8198f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS NetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS NetInfo
..


Patch Set 11:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: changed relative imports to absolute imports

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: changed relative imports to absolute imports
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56607
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf42bbe589b1e18b789ad8e3137d320e3a3966a7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 15:

(3 comments)

https://gerrit.ovirt.org/#/c/56901/15/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

PS15, Line 33: driver_instance
ovsdb


Line 44: self.ports = ports_command.result
Line 45: self.ifaces = ifaces_command.result
Line 46: 
Line 47: 
Line 48: def _uuids_to_names(uuids, entries_uuids):
Only one usage... you can convert it to a list comprehension at the caller.
Line 49: names = []
Line 50: for uuid in uuids:
Line 51: names.append(entries_uuids[uuid]['name'])
Line 52: return names


PS15, Line 73: ports = {port['name']: self._port_attr(port['_uuid'])
 :  for port in self._ovs_db.ports}
Better move it to the __init__ method to avoid kipping _ovs_db at the instance 
level, it can become localized.
(Not sure if you can do it nicely)

But I also think the ports need to be limited to the ones belonging to this 
specific bridge... right?


-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeStorageDomainCache

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: FakeStorageDomainCache
..

tests: FakeStorageDomainCache

Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagefakelibTests.py
M tests/storagetestlib.py
3 files changed, 33 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/57055/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index 8044195..e967e9a 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -286,3 +286,14 @@
 @recorded
 def releaseResource(self, *args, **kwargs):
 pass
+
+
+class FakeStorageDomainCache(object):
+def __init__(self, domains):
+self._domains = domains
+
+def produce(self, sd_id):
+try:
+return self._domains[sd_id]
+except KeyError:
+raise se.StorageDomainDoesNotExist(sd_id)
diff --git a/tests/storagefakelibTests.py b/tests/storagefakelibTests.py
index 898e69e..9165bf5 100644
--- a/tests/storagefakelibTests.py
+++ b/tests/storagefakelibTests.py
@@ -25,7 +25,7 @@
 
 from testlib import VdsmTestCase, namedTemporaryDir
 from testlib import permutations, expandPermutations
-from storagefakelib import FakeLVM, FakeResourceManager
+from storagefakelib import FakeLVM, FakeResourceManager, FakeStorageDomainCache
 
 from storage import blockSD, blockVolume
 from storage import lvm as real_lvm
@@ -358,3 +358,16 @@
 self.assertEqual(expected_calls, rm.__calls__)
 expected_calls.append(('releaseResource', acquire_args, {}))
 self.assertEqual(expected_calls, rm.__calls__)
+
+
+class FakeStorageDomainCacheTests(VdsmTestCase):
+
+def test_domain_does_not_exist(self):
+sdc = FakeStorageDomainCache(dict())
+self.assertRaises(se.StorageDomainDoesNotExist, sdc.produce, 'foo')
+
+def test_produce(self):
+# The cache just returns objects so we don't need to pass a domain
+dom = object()
+sdc = FakeStorageDomainCache(dict(foo=dom))
+self.assertEqual(dom, sdc.produce('foo'))
diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py
index 1a3dfce..2d9fab2 100644
--- a/tests/storagetestlib.py
+++ b/tests/storagetestlib.py
@@ -21,7 +21,7 @@
 from contextlib import contextmanager
 
 from testlib import make_file, namedTemporaryDir
-from storagefakelib import FakeLVM
+from storagefakelib import FakeLVM, FakeStorageDomainCache
 from monkeypatch import MonkeyPatchScope
 
 from vdsm import utils
@@ -46,10 +46,11 @@
 def fake_file_env(obj=None):
 with namedTemporaryDir() as tmpdir:
 sd_manifest = make_filesd_manifest(tmpdir)
+fake_sdc = FakeStorageDomainCache({sd_manifest.sdUUID: sd_manifest})
 with MonkeyPatchScope([
-[sd, 'storage_repository', tmpdir]
+[sd, 'storage_repository', tmpdir],
+[volume, 'sdCache', fake_sdc],
 ]):
-
 yield FakeEnv(sd_manifest)
 
 
@@ -64,7 +65,10 @@
 (sd, 'storage_repository', tmpdir),
 ]):
 sd_manifest = make_blocksd_manifest(tmpdir, lvm)
-yield FakeEnv(sd_manifest, lvm=lvm)
+fake_sdc = FakeStorageDomainCache(
+{sd_manifest.sdUUID: sd_manifest})
+with MonkeyPatchScope([[volume, 'sdCache', fake_sdc]]):
+yield FakeEnv(sd_manifest, lvm=lvm)
 
 
 class FakeMetadata(dict):


-- 
To view, visit https://gerrit.ovirt.org/57055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Add basic BlockVolumeArtifacts
..


Patch Set 20: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: snapshot wip

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: snapshot wip
..

snapshot wip

Change-Id: I3649ef8d87522105b645f249f2bc35f7db7e3e29
Signed-off-by: Adam Litke 
---
M tests/storage_volume_artifacts_test.py
M tests/storagetestlib.py
M vdsm/storage/sdm/volume_artifacts.py
3 files changed, 72 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/57057/1

diff --git a/tests/storage_volume_artifacts_test.py 
b/tests/storage_volume_artifacts_test.py
index 745c0ba..81952dd 100644
--- a/tests/storage_volume_artifacts_test.py
+++ b/tests/storage_volume_artifacts_test.py
@@ -23,7 +23,6 @@
 
 from monkeypatch import MonkeyPatchScope
 from testlib import VdsmTestCase, permutations, expandPermutations
-from testValidation import brokentest
 from storagetestlib import fake_block_env, fake_file_env
 
 from vdsm import qemuimg
@@ -122,7 +121,6 @@
 self.assertRaises(se.InvalidParameterException, second.create,
   *BASE_PARAMS[volume.RAW_FORMAT])
 
-@brokentest("Broken until parent volume support is added")
 def test_create_same_volume_in_image(self):
 with self.fake_env() as env:
 artifacts = env.sd_manifest.get_volume_artifacts(
@@ -170,6 +168,42 @@
 self.assertEqual(size, info['virtualsize'])
 self.assertNotIn('backingfile', info)
 
+@permutations([[volume.RAW_FORMAT], [volume.COW_FORMAT]])
+def test_create_snapshot(self, base_vol_format):
+with self.fake_env() as env:
+parent_artifacts = self.create_base_volume(env, base_vol_format,
+   img_id=self.img_id)
+parent = create_volume.ParentVolumeInfo(
+dict(img_id=parent_artifacts.img_id,
+ vol_id=parent_artifacts.vol_id))
+
+child_artifacts = env.sd_manifest.get_volume_artifacts(
+self.img_id, self.vol_id)
+size, vol_format, disk_type, desc = BASE_PARAMS[volume.COW_FORMAT]
+child_artifacts.create(size, vol_format, disk_type, desc, parent)
+child_artifacts.commit()
+
+parent_vol = env.sd_manifest.produceVolume(parent.img_id,
+   parent.vol_id)
+self.assertEqual(volume.type2name(volume.INTERNAL_VOL),
+ parent_vol.getVolType())
+#self.assertIn(self.vol_id, parent_vol.getChildren())
+
+backing_path = os.path.join('..', self.img_id, parent.vol_id)
+child_info = qemuimg.info(child_artifacts.volume_path)
+self.assertEqual(backing_path, child_info['backingfile'])
+
+def test_create_snapshot_wrong_size(self):
+# Refuse to create a snapshot when the parent is a different size
+pass
+
+def test_create_snapshot_illegal_parent(self):
+# Illegal parent raised se.createIllegalVolumeSnapshotError
+pass
+
+
+
+
 # Artifacts visibility
 
 def test_getallvolumes(self):
@@ -191,6 +225,13 @@
 self.assertRaises(se.DomainHasGarbage, artifacts.create,
   *BASE_PARAMS[volume.RAW_FORMAT])
 
+def create_base_volume(self, env, vol_format, img_id=str(uuid.uuid4()),
+   vol_id=str(uuid.uuid4())):
+artifacts = env.sd_manifest.get_volume_artifacts(img_id, vol_id)
+artifacts.create(*BASE_PARAMS[vol_format])
+artifacts.commit()
+return artifacts
+
 
 @expandPermutations
 class FileVolumeArtifactsTests(VolumeArtifactsTestsMixin, VdsmTestCase):
diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py
index 2d9fab2..39453bb 100644
--- a/tests/storagetestlib.py
+++ b/tests/storagetestlib.py
@@ -21,7 +21,7 @@
 from contextlib import contextmanager
 
 from testlib import make_file, namedTemporaryDir
-from storagefakelib import FakeLVM, FakeStorageDomainCache
+from storagefakelib import FakeLVM, FakeStorageDomainCache, FakeResourceManager
 from monkeypatch import MonkeyPatchScope
 
 from vdsm import utils
@@ -58,9 +58,11 @@
 def fake_block_env(obj=None):
 with namedTemporaryDir() as tmpdir:
 lvm = FakeLVM(tmpdir)
+rm = FakeResourceManager()
 with MonkeyPatchScope([
 (blockSD, 'lvm', lvm),
 (blockVolume, 'lvm', lvm),
+(blockVolume, 'rmanager', rm),
 (volume_artifacts, 'lvm', lvm),
 (sd, 'storage_repository', tmpdir),
 ]):
diff --git a/vdsm/storage/sdm/volume_artifacts.py 
b/vdsm/storage/sdm/volume_artifacts.py
index 5eb8768..128d289 100644
--- a/vdsm/storage/sdm/volume_artifacts.py
+++ b/vdsm/storage/sdm/volume_artifacts.py
@@ -117,10 +117,6 @@
 
 def _validate_create_params(self, size, vol_format, disk_type, desc,
 parent, initial_size, prealloc):
-# XXX: Remove 

Change in vdsm[master]: jsonrpc: change instance type to strings

[alukiano]

Artyom Lukianov has posted comments on this change.

Change subject: jsonrpc: change instance type to strings
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/57017/1//COMMIT_MSG
Commit Message:

PS1, Line 9: Change check of responce instance type from unicode
   : to strings
> you (correctly) added the bug-url which provides more context, but please a
Done


-- 
To view, visit https://gerrit.ovirt.org/57017
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4eab12560b63d82223babe0b14870b6c0b65fbb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Artyom Lukianov 
Gerrit-Reviewer: Artyom Lukianov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: snapshot wip

[automation]

gerrit-hooks has posted comments on this change.

Change subject: snapshot wip
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57057
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3649ef8d87522105b645f249f2bc35f7db7e3e29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: fix: block path fixes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: fix: block path fixes
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57058
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id68197ef3fb61d16c1130cec1d4d0f384d2e30b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches