Nir Soffer has posted comments on this change. Change subject: v2v: get_external_vms return format for KVM images ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56912/2/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 935: driver = disk.find('./driver/[@type]') Line 936: if driver is not None: Line 937: format = driver.get('type') Line 938: if format.lower().startswith('qcow'): Line 939: d['format'] = 'cow' > ok, Also, this must be documented in the schema, we cannot return undocumented values. In the schema, you will find the @VolumeFormat enum - containing "RAW" and "COW". Line 940: params['disks'].append(d) Line 941: Line 942: Line 943: def _add_networks(root, params): -- To view, visit https://gerrit.ovirt.org/56912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d4985aafc21e5ff5c11ec7bca71ab9aa5b2cd9d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
