Change in vdsm[master]: net: OVS netinfo

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 24:

(2 comments)

partial review

https://gerrit.ovirt.org/#/c/56972/24/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

Line 182: for bridge, bridge_attrs in six.iteritems(ovs_bridges):
Line 183: ports = bridge_attrs['ports']
Line 184: southbound = _get_southbound_port(ports)
Line 185: for port, port_attrs in six.iteritems(ports):
Line 186: ip_attrs = port_attrs['ip']
Seems to me that you can move the ip tree here directly, without the need to 
keep it in OvsInfo.
it also makes sense to name the ip keys as required to avoid the mapping.

So filling port info here from _get_ip_info makes sense to me.
Line 187: if ip_attrs:
Line 188: port_info = {
Line 189: 'mtu': port_attrs['mtu'],
Line 190: 'addr': ip_attrs['ipv4addr'],


PS24, Line 199: cfg
Do we need to support the 'cfg' portion? I think we deprecated it.


-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 11:

This is ready, but I'm waiting for the next patch, since this patch mark good 
tests as broken.

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/35629/6/lib/vdsm/storage/blkdiscard.py
File lib/vdsm/storage/blkdiscard.py:

Line 43: def run_blkdiscard(device):
Line 44: cmd = [_blkdiscard.cmd]
Line 45: cmd.append(device)
Line 46: 
Line 47: rc, out, err = commands.execCmd(cmd, deathSignal=signal.SIGKILL)
> Since I'm hoping to see this in 4.0.x, not sure we can do that right now. I
Right, we want this change *now*, we don't have time for additional work.
Line 48: 
Line 49: if rc != 0:


https://gerrit.ovirt.org/#/c/35629/6/tests/storage_blkdiscard_test.py
File tests/storage_blkdiscard_test.py:

Line 25: 
Line 26: BLKDISCARD = blkdiscard._blkdiscard.cmd
Line 27: 
Line 28: 
Line 29: class FakeCmd(object):
> This class looks like a general purpose utility that should appear in testl
I agree, good idea for later patch.
Line 30: 
Line 31: def __init__(self, name, *calls):
Line 32: self.patch = monkeypatch.Patch([(commands, name, self)])
Line 33: self.calls = list(calls)


-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56936/2/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 218: with self.fake_env() as env:
Line 219: artifacts = env.sd_manifest.get_volume_artifacts(
Line 220: self.img_id, self.vol_id)
Line 221: with MonkeyPatchScope([
Line 222: [artifacts, '_create_volume_file', failure]
> The problem is that lease creation also uses truncateFIle and so this test 
OK, can you add a comment about this - why we cannot monkeypatch the underlying 
code?

Also if we don't need to monkey patch in only part of the test, replacing the 
method on a new object is simpler and nicer.
Line 223: ]):
Line 224: self.assertRaises(ExpectedFailure, artifacts.create,
Line 225:   *BASE_RAW_PARAMS)
Line 226: self.validate_new_image_path(artifacts,


-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: introduce the networkmanager module, with an integrat...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: introduce the networkmanager module, with an integration 
test
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57062
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id83fa34f9ca7ca910f705e5c360ad420c7a0dcfc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: let VDSM consume a bond created by NetworkManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: let VDSM consume a bond created by NetworkManager
..


Patch Set 12:

* #1304509::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1304509::OK, public bug
* Check Product::#1304509::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7047ce59a515d0b8ed2c4c5307b4c0d47d4aa92b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

[ykaul]

Yaniv Kaul has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/35629/6/lib/vdsm/storage/blkdiscard.py
File lib/vdsm/storage/blkdiscard.py:

Line 43: def run_blkdiscard(device):
Line 44: cmd = [_blkdiscard.cmd]
Line 45: cmd.append(device)
Line 46: 
Line 47: rc, out, err = commands.execCmd(cmd, deathSignal=signal.SIGKILL)
> This module seems like a perfect candidate for StorageJob integration.  Fro
Since I'm hoping to see this in 4.0.x, not sure we can do that right now. I 
also hope that there won't be a need for progress - I expect blkdiscard to run 
fast (Gigs/sec - faster than line speed) in most storages.
Line 48: 
Line 49: if rc != 0:


-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 20:

(1 comment)

https://gerrit.ovirt.org/#/c/53214/20/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 49: for module_name in _CONFIGURATORS:
Line 50: if not hasattr(_CONFIGURATORS[module_name], 'name'):
Line 51: setattr(_CONFIGURATORS[module_name], 'name', module_name)
Line 52: 
Line 53: _init_configuratos()
If you put it like this, then this will look much nicer:

_CONFIGURATORS = _init_configuratos()

And inside _init_configuratos just use a local variable and return it.
Line 54: 
Line 55: 
Line 56: #
Line 57: # Configurators Interface:


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 21: Code-Review+1

(2 comments)

Note the small nit.

https://gerrit.ovirt.org/#/c/56901/17/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

PS17, Line 62:
> Done. However, dict is mutable, so I guess user still can write to its cont
We could return a copy and be protected, but that we can consider later on..


https://gerrit.ovirt.org/#/c/56901/21/tests/network/ovs_info_test.py
File tests/network/ovs_info_test.py:

PS21, Line 149: s
nit: The plural version is deprecated.


-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/56936/2/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 218: with self.fake_env() as env:
Line 219: artifacts = env.sd_manifest.get_volume_artifacts(
Line 220: self.img_id, self.vol_id)
Line 221: with MonkeyPatchScope([
Line 222: [artifacts, '_create_volume_file', failure]
> We don't need to monkeypatch this object, we are throwing it away on the en
The problem is that lease creation also uses truncateFIle and so this test will 
fail to create the lease since that is done before creating the volume.
Line 223: ]):
Line 224: self.assertRaises(ExpectedFailure, artifacts.create,
Line 225:   *BASE_RAW_PARAMS)
Line 226: self.validate_new_image_path(artifacts,


-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 20:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move VM status check from vm.cont() to API level

[smelamud]

Shmuel Leib Melamud has posted comments on this change.

Change subject: virt: Move VM status check from vm.cont() to API level
..


Patch Set 4: Verified+1

As discussed, moved VM status check from vm.cont() to the API level.

-- 
To view, visit https://gerrit.ovirt.org/47527
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b1c7b4eecacf87ece48dc563fd2da294af0510b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move VM status check from vm.cont() to API level

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move VM status check from vm.cont() to API level
..


Patch Set 4:

* #1238536::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1238536::OK, public bug
* Check Product::#1238536::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/47527
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b1c7b4eecacf87ece48dc563fd2da294af0510b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: fix spec normalization when mounting

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: fix spec normalization when mounting
..


Patch Set 15: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f244eb903fc049c726efba69f37b3b5fb01b561
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storagetests: add a test for normalize_local_path

[alitke]

Adam Litke has posted comments on this change.

Change subject: storagetests: add a test for normalize_local_path
..


Patch Set 11: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e95c6b2bc214b7f3cc1e2d3ec164efecd67c14a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: add support for blkdiscard command

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: add support for blkdiscard command
..


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/35629/6/lib/vdsm/storage/blkdiscard.py
File lib/vdsm/storage/blkdiscard.py:

Line 43: def run_blkdiscard(device):
Line 44: cmd = [_blkdiscard.cmd]
Line 45: cmd.append(device)
Line 46: 
Line 47: rc, out, err = commands.execCmd(cmd, deathSignal=signal.SIGKILL)
This module seems like a perfect candidate for StorageJob integration.  From 
the blkdiscard man page I see that we can get progress info which can be 
reported via the  Jobs API.
Line 48: 
Line 49: if rc != 0:


https://gerrit.ovirt.org/#/c/35629/6/tests/storage_blkdiscard_test.py
File tests/storage_blkdiscard_test.py:

Line 25: 
Line 26: BLKDISCARD = blkdiscard._blkdiscard.cmd
Line 27: 
Line 28: 
Line 29: class FakeCmd(object):
This class looks like a general purpose utility that should appear in 
testlib.py.
Line 30: 
Line 31: def __init__(self, name, *calls):
Line 32: self.patch = monkeypatch.Patch([(commands, name, self)])
Line 33: self.calls = list(calls)


-- 
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea7dd19fadc600b8fe78fb436ae430d35f52165
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: client: do not protect requests on client side

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: client: do not protect requests on client side
..


Patch Set 3:

hosted-engine setup still fails with this fix .. didnt see exactly why

-- 
To view, visit https://gerrit.ovirt.org/56288
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I197591fbf0fb42647267b6901998324dd02a8080
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS netinfo

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 24:

(2 comments)

https://gerrit.ovirt.org/#/c/56972/24/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:

Line 161: custom_opts.append('ovs_lacp:%s' % lacp)
Line 162: opts['custom'] = ','.join(custom_opts)
Line 163: return opts
Line 164: 
Line 165: def _get_fake_ports(bridge, northbound, southbound, ports):
get info is expected to be called quite often. can we define these functions 
once, on module import?
Line 166: fake_ports = []
Line 167: for port, port_attrs in six.iteritems(ports):
Line 168: tag = port_attrs['tag']
Line 169: if tag == ports[northbound]['tag'] and port != bridge:


PS24, Line 186: ip_attrs = port_attrs['ip']
  : if ip_attrs:
  : port_info = {
  : 'mtu': port_attrs['mtu'],
  : 'addr': ip_attrs['ipv4addr'],
  : 'ipv4addrs': ip_attrs['ipv4addrs'],
  : 'gateway': ip_attrs['ipv4gateway'],
  : 'netmask': ip_attrs['ipv4netmask'],
  : 'dhcpv4': ip_attrs['dhcpv4'],
  : 'ipv6addrs': ip_attrs['ipv6addrs'],
  : 'ipv6autoconf': ip_attrs['ipv6autoconf'],
  : 'ipv6gateway': ip_attrs['ipv6gateway'],
  : 'dhcpv6': ip_attrs['dhcpv6'],
  : 'cfg': {'BOOTPROTO': ('dhcp' if 
ip_attrs['dhcpv4']
  :   else 'none')}
  : }
  : else:
  : port_info = EMPTY_PORT_INFO
can you factor this (and other similar stanzas) out to a little helper 
function? I believe it would make this long function more readable.


-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Network speed reported as -1 if it can not be determined
..


Patch Set 1:

* #1322529::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1322529::OK, public bug
* Check Product::#1322529::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: Network speed reported as -1 if it can not be determined

[mmirecki]

Marcin Mirecki has uploaded a new change for review.

Change subject: net: Network speed reported as -1 if it can not be determined
..

net: Network speed reported as -1 if it can not be determined

If network speed can not be determined, as is for example the case
with virtio devices, the reported network speed should be -1

Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Bug-Url: https://bugzilla.redhat.com/1322529
Signed-off-by: mirecki 
---
M lib/vdsm/network/netinfo/nics.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/57108/1

diff --git a/lib/vdsm/network/netinfo/nics.py b/lib/vdsm/network/netinfo/nics.py
index 1fd6aaa..07240cf 100644
--- a/lib/vdsm/network/netinfo/nics.py
+++ b/lib/vdsm/network/netinfo/nics.py
@@ -56,8 +56,10 @@
 return _ibHackedSpeed(nic_name)
 else:
 logging.exception('cannot read %s nic speed', nic_name)
+return -1
 except Exception:
 logging.exception('cannot read %s speed', nic_name)
+return -1
 return 0
 
 
@@ -68,9 +70,9 @@
 https://bugzilla.redhat.com/show_bug.cgi?id=1101314
 """
 try:
-return 1 if drv_name(nic_name) == 'ib_ipoib' else 0
+return 1 if drv_name(nic_name) == 'ib_ipoib' else -1
 except IOError:
-return 0
+return -1
 
 
 def info(link, paddr):


-- 
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f5c4a2b0b3f0df53a740b2b6a0e9d331f85c1ae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
> It doesn't work like that. I ask them to set engine log level to debug from
OK
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
> we can ask qe to enable this option for some time. Wouldn't this be good en
It doesn't work like that. I ask them to set engine log level to debug from 
time to time and still I get logs with info level. I will push a patch to 
disable it by default so we do not forget. Is it OK with you?
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
> My intention is to have it enabled for some time. I need it to diagnose whe
we can ask qe to enable this option for some time. Wouldn't this be good enough?
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: Makefile: changed tests Makefile so that both python2 a...

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: WIP: Makefile: changed tests Makefile so that both python2 and 
pyhton3 will be default. That way, all tests (including new ones) will have to 
support python3 eventually.
..

WIP: Makefile: changed tests Makefile so that both python2 and pyhton3 will
be default.
That way, all tests (including new ones) will have to support python3 
eventually.

Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Signed-off-by: Irit Goihman 
---
M tests/Makefile.am
1 file changed, 100 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/57106/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index a1505e3..7cd5649 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -170,6 +170,106 @@
v2vTests.py \
$(NULL)
 
+blacklist_modules_python3 = \
+   vmRecoveryTests.py \
+   domain_manifest_test.py \
+   network/config_network_test.py \
+   network/netinfo_test.py \
+   imagetickets_test.py \
+   vmSecretTests.py \
+   network/hook_ovs_test.py \
+   encodingTests.py \
+   mountTests.py \
+   network/ip_test.py \
+   vmXmlTests.py \
+   network/conf_test.py \
+   guestagentTests.py \
+   network/sourcerouting_test.py \
+   mkimageTests.py \
+   common/contextlib_test.py \
+   network/conf_persistence_test.py \
+   hooksTests.py \
+   vdsmDumpChainsTests.py \
+   devices/parsing/complex_vm_tests.py \
+   storagetestlibTests.py \
+   utilsTests.py \
+   network/qos_test.py \
+   network/connectivity_test.py \
+   vmTests.py \
+   miscTests.py \
+   vmUtilsTests.py \
+   fuserTests.py \
+   stompAsyncDispatcherTests.py \
+   storageServerTests.py \
+   bridgeTests.pybulk_sampling_test.py \
+   storageMailboxTests.py \
+   commands_test.py \
+   periodicTests.py \
+   securableTests.py \
+   alignmentScanTests.py \
+   hostdevTests.py \
+   stompTests.py \
+   vmOperationsTests.py \
+   momTests.py \
+   fileUtilTests.py \
+   numaUtilsTests.py \
+   iscsiTests.py \
+   testlibTests.py \
+   schemaValidationTest.py \
+   toolTests.py \
+   stompAsyncClientTests.py \
+   sdm_indirection_tests.py \
+   v2vTests.py \
+   network/unified_persistence_test.py \
+   protocoldetectorTests.py \
+   fileVolumeTests.py \
+   network/link_test.py \
+   network/ipwrapper_test.py \
+   cPopenTests.py \
+   lvmTests.py \
+   hoststatsTests.py \
+   clientifTests.py \
+   resourceManagerTests.py \
+   gluster_cli_tests.py \
+   vdsClientTests.py \
+   monkeypatchTests.py \
+   sparsifyTests.py \
+   vmApiTests.py \
+   vdscliTests.py \
+   network/iproute2_test.py \
+   outOfProcessTests.py \
+   vmStorageTests.py \
+   storage_sdm_create_volume_test.py \
+   samplingTests.py \
+   momPolicyTests.py \
+   capsTests.py \
+   persistentDictTests.py \
+   qemuimgTests.py \
+   deviceTests.py \
+   storageMonitorTests.py \
+   storage_volume_artifacts_test.py \
+   blocksdTests.py \
+   network/tc_test.py \
+   fileSDTests.py \
+   storagefakelibTests.py \
+   stompAdapterTests.py \
+   blockVolumeTests.py \
+   vmfakelibTests.py \
+   storage_sdm_api_test.py \
+   toolBondingTests.py \
+   common/network_test.py \
+   schemaTests.py \
+   network/ovs_test.py \
+   transportWrapperTests.py \
+   libvirtconnectionTests.py \
+   main.py \
+   unicode_test.py \
+   storage_rwlock_test.py \
+   tasksetTests.py \
+   vmMigrationTests.py \
+   verify.py \
+   $(NULL)
+
 nodist_vdsmtests_PYTHON = \
crossImportsTests.py \
$(NULL)


-- 
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: Makefile: changed tests Makefile so that both python2 a...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: Makefile: changed tests Makefile so that both python2 and 
pyhton3 will be default. That way, all tests (including new ones) will have to 
support python3 eventually.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57106
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0f96626607fc5042eb47be0f91ecafee7965043
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
> This should be disabled by default, otherwise we are spamming the journal. 
My intention is to have it enabled for some time. I need it to diagnose whether 
unexpected eof is something that I should worry about or not. I will disable it 
once I know that it is OK or I have fix for the issue.
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm arch specific package

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: Make vdsm arch specific package
..


Patch Set 5: Code-Review+2

raising!

-- 
To view, visit https://gerrit.ovirt.org/42490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbc71ccded31e8b80b14dbb03fd738694ceb37c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS netinfo in caps

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: report OVS netinfo in caps
..


Patch Set 2: Verified+1

Passed ovs_info_test.py

-- 
To view, visit https://gerrit.ovirt.org/57102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm arch specific package

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: Make vdsm arch specific package
..


spec: Make vdsm arch specific package

Vdsm depends on packages available only on certain platforms, so it must
be arch-specific.

This patch remove noarch from vdsm package and make all sub packages
noarch.

Change-Id: Iecbc71ccded31e8b80b14dbb03fd738694ceb37c
Bug-Url: https://bugzilla.redhat.com/1320281
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/42490
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Tested-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 41 insertions(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecbc71ccded31e8b80b14dbb03fd738694ceb37c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: Make vdsm arch specific package

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Make vdsm arch specific package
..


Patch Set 6:

* #1320281::Update tracker: OK
* Set MODIFIED::bug 1320281#1320281FAILED, illegal change from NEW

-- 
To view, visit https://gerrit.ovirt.org/42490
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbc71ccded31e8b80b14dbb03fd738694ceb37c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS netinfo in caps

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: report OVS netinfo in caps
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/57016/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 444: 
Line 445: ('health_check_interval', '60',
Line 446: 'Number of seconds to wait between health checks.'),
Line 447: 
Line 448: ('m2c_debug_enable', 'true',
This should be disabled by default, otherwise we are spamming the journal. When 
a user has a problem we can enable it for debugging.
Line 449: 'Enable state information about the SSL connections which 
is by '
Line 450: 'default logged to stderr.'),
Line 451: ]),
Line 452: 


-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: data verification

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: bridge: data verification
..


Patch Set 27:

(1 comment)

https://gerrit.ovirt.org/#/c/53919/27/tests/Makefile.am
File tests/Makefile.am:

Line 124:   resourceManagerTests.py \
Line 125:   responseTests.py \
Line 126:   samplingTests.py \
Line 127:   scheduleTests.py \
Line 128:   schemaapi_test.py \
> does it pass py3?
I haven't checked. The test file is renamed later. I move to be run using py3 
in separate patch.
Line 129:   schemaTests.py \
Line 130:   schemaValidationTest.py \
Line 131:   sdm_indirection_tests.py \
Line 132:   securableTests.py \


-- 
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Detect VM with snapshots

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: Detect VM with snapshots
..


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/56574/6/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

PS6, Line 908: except libvirt.libvirtError as e:
 : logging.error('Error checking for existing snapshots; 
%r', e.message)
> I prefer if you keep using logging.exception() here.
Done


-- 
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: externalize api_strict_mode

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: schema: externalize api_strict_mode
..


Patch Set 5: Verified+1

Rebase only no code changes.

-- 
To view, visit https://gerrit.ovirt.org/56386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93dad74177d1991c322988b6bf9f0887701ee47a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: introduction of schema

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: events: introduction of schema
..


Patch Set 20: Verified+1

Fixed duplication is schema. No other code changes.

-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: externalize api_strict_mode

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: schema: externalize api_strict_mode
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93dad74177d1991c322988b6bf9f0887701ee47a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 39: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 39
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: introduction of schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: events: introduction of schema
..


Patch Set 20:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: data verification

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: bridge: data verification
..


Patch Set 27:

(1 comment)

https://gerrit.ovirt.org/#/c/53919/27/tests/Makefile.am
File tests/Makefile.am:

Line 124:   resourceManagerTests.py \
Line 125:   responseTests.py \
Line 126:   samplingTests.py \
Line 127:   scheduleTests.py \
Line 128:   schemaapi_test.py \
does it pass py3?
Line 129:   schemaTests.py \
Line 130:   schemaValidationTest.py \
Line 131:   sdm_indirection_tests.py \
Line 132:   securableTests.py \


-- 
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Don't fail when existingConnAction is unset for a SPIC...

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: virt: Don't fail when existingConnAction is unset for a SPICE 
device
..


Patch Set 5: Code-Review+2

Seeing score from Francesco and Nir I am raising.

-- 
To view, visit https://gerrit.ovirt.org/56836
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fde83ceb994eaafd2aa956d1fa82ce6cb16094c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 5:

* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check Product::#1301104::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: introduction of schema

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: events: introduction of schema
..


Patch Set 19:

(2 comments)

https://gerrit.ovirt.org/#/c/54754/18/vdsm.spec.in
File vdsm.spec.in:

Line 1563: %files yajsonrpc
Line 1564: %dir %{python_sitelib}/yajsonrpc
Line 1565: %{python_sitelib}/yajsonrpc/betterAsyncore.py*
Line 1566: %{python_sitelib}/yajsonrpc/stomp.py*
Line 1567: %{python_sitelib}/yajsonrpc/stompreactor.py*
dup
Line 1568: 
Line 1569: %files infra
Line 1570: %dir %{python_sitelib}/%{vdsm_name}
Line 1571: %dir %{python_sitelib}/%{vdsm_name}/infra


https://gerrit.ovirt.org/#/c/54754/19/vdsm.spec.in
File vdsm.spec.in:

Line 1551: %files api
Line 1552: %dir %{python_sitelib}/%{vdsm_name}
Line 1553: %dir %{python_sitelib}/%{vdsm_name}/rpc
Line 1554: %{python_sitelib}/%{vdsm_name}/rpc/vdsm-api.yml
Line 1555: %{python_sitelib}/%{vdsm_name}/rpc/vdsm-api.yml
duplication
Line 1556: %{python_sitelib}/%{vdsm_name}/rpc/vdsm-events.yml
Line 1557: %{python_sitelib}/api/vdsmapi.py*
Line 1558: %{python_sitelib}/api/__init__.py*
Line 1559: %if ! 0%{?with_gluster_mgmt}


-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Adding reportStats

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Adding reportStats
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/host.py
File lib/vdsm/host.py:

Line 446: # For backwards compatibility, will be removed in the future
Line 447: stats['haScore'] = stats['haStats']['score']
Line 448: 
Line 449: stats = hooks.after_get_stats(stats)
Line 450: _current_stats = stats
> Bad idea, if engine stop calling us, we never update the stats.
You could attempt to report stats faster then engine called. Even if the engine 
is not talking to vdsm we still need to reportStats.
Line 451: return stats
Line 452: 
Line 453: 
Line 454: def reportStats():


PS1, Line 457: The format
Why do we need to have it here? It gives me no value. I would prefer to have 
here the format of a message so we know exactly what is sent.


https://gerrit.ovirt.org/#/c/56880/1/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.py:

PS1, Line 551: reportStats
How can we specify the interval when report is sent?


-- 
To view, visit https://gerrit.ovirt.org/56880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23c1141f097f740441d085f99e0bf76eb7f718c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/53214/18/tests/Makefile.am
File tests/Makefile.am:

Line 42:glusterTestData.py \
Line 43:hookValidation.py \
Line 44:jobsTests.py \
Line 45: module_loader_test.py \
Line 46: modprobe.py \
use tab here..
Line 47:monkeypatch.py \
Line 48:network/models_test.py \
Line 49:passwordsTests.py \
Line 50:permutationTests.py \


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS netinfo in caps

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: report OVS netinfo in caps
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report OVS netinfo in caps

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: report OVS netinfo in caps
..

net: report OVS netinfo in caps

Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/network/api.py
M vdsm/caps.py
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/57102/1

diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index a2388ba..90bcd71 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -37,6 +37,7 @@
 
 from . canonicalize import canonicalize_networks, canonicalize_bondings
 from . errors import RollbackIncomplete
+from . ovs import info as ovs_info
 from . import netconfpersistence
 from . import netswitch
 
@@ -45,7 +46,7 @@
 
 def caps_networks():
 """Complement existing non-root caps"""
-return {}
+return ovs_info.get_netinfo(fake_bridgeless=True)
 
 
 def _wait_for_udev_events():
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 66eb245..2d39196 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -25,6 +25,7 @@
 import xml.etree.ElementTree as ET
 
 import libvirt
+import six
 
 from vdsm.config import config
 from vdsm.netinfo import cache as netinfo_cache
@@ -166,7 +167,8 @@
 caps.update(netinfo_data)
 
 super_caps_networks = supervdsm.getProxy().caps_networks()
-caps.update(super_caps_networks)
+for key, value in six.iteritems(super_caps_networks):
+caps[key].update(super_caps_networks[key])
 
 try:
 caps['hooks'] = hooks.installed()


-- 
To view, visit https://gerrit.ovirt.org/57102
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib53200891e292a0d9c8a347cc14344281d3ace65
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: m2c: get more information about ssl connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: m2c: get more information about ssl connection
..


Patch Set 3: Verified+1

Verified by running local build.

-- 
To view, visit https://gerrit.ovirt.org/57016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfae375617477d6345e48907dc85f6336724f1f3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json: removal of old schemas

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: json: removal of old schemas
..


Patch Set 23: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: verify data before sending

[automation]

gerrit-hooks has posted comments on this change.

Change subject: events: verify data before sending
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc854517d04db830e685edc47e6b7e1055c8d89c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report expected devices in OVS netinfo

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: report expected devices in OVS netinfo
..


Patch Set 9: Verified+1

Passed ovs_info_test.py

-- 
To view, visit https://gerrit.ovirt.org/57067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8c0cd4eb2f11dfd8145d82b0d9f866595583
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS netinfo

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 24: Verified+1

Passed ovs_info_test.py

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consume OVS netinfo by CachingNetInfo

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: consume OVS netinfo by CachingNetInfo
..


Patch Set 3:

CachingNetInfo and KernelConfig is working OK with ovs_netinfo input.

-- 
To view, visit https://gerrit.ovirt.org/57089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ae814513795381a3727734087844a5145c855b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consume OVS netinfo by CachingNetInfo

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: consume OVS netinfo by CachingNetInfo
..


Patch Set 3: Verified+1

Passed ovs_info_test.py

-- 
To view, visit https://gerrit.ovirt.org/57089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ae814513795381a3727734087844a5145c855b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS netinfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 24:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS networks as bridgeless

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: fake OVS networks as bridgeless
..


Patch Set 5: Verified+1

Passed ovs_info_test.py

-- 
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json: removal of old schemas

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: json: removal of old schemas
..


Patch Set 23: Verified+1

Rebase only, no code changes.

-- 
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS networks as bridgeless

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: fake OVS networks as bridgeless
..


Patch Set 4: Verified+1

Passed ovs_info_test.py

-- 
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consume OVS netinfo by CachingNetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: consume OVS netinfo by CachingNetInfo
..


Patch Set 3:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ae814513795381a3727734087844a5145c855b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 39: Verified+1

No code changes, schema update with recent change. Verified that schemas are 
aligned by running local build.

-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 39
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS networks as bridgeless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: fake OVS networks as bridgeless
..


Patch Set 5:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: usage of yaml schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: bridge: usage of yaml schema
..


Patch Set 22:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: introduction of schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: events: introduction of schema
..


Patch Set 19:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 21:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS Info

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: OVS Info
..


Patch Set 21: Verified+1

Passed ovs_info_test.py

-- 
To view, visit https://gerrit.ovirt.org/56901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib43bee9a13cfabc3007064b2121f0ce8b0a563bb
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: data verification

[automation]

gerrit-hooks has posted comments on this change.

Change subject: bridge: data verification
..


Patch Set 27:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json: removal of old schemas

[automation]

gerrit-hooks has posted comments on this change.

Change subject: json: removal of old schemas
..


Patch Set 23:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: schema: externalize api_strict_mode

[automation]

gerrit-hooks has posted comments on this change.

Change subject: schema: externalize api_strict_mode
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56386
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93dad74177d1991c322988b6bf9f0887701ee47a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmapi: prepare for event naming

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsmapi: prepare for event naming
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31f119b7809ae7536d3cab4de6298c648402614d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 4: Code-Review-1

codewise fine, but you seem to miss the schema updates

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 39:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 39
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: yml: generate api doc from the schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: yml: generate api doc from the schema
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0cdd7322b06899a8fb895a5bfee4d2e0e3bc8c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 4:

* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check Product::#1301104::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Use MonkeyPatchScope to inject failures

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use MonkeyPatchScope to inject failures
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceed070c2da36460f6aa60a72f079d2e185da6a7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: snapshot wip

[automation]

gerrit-hooks has posted comments on this change.

Change subject: snapshot wip
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57057
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3649ef8d87522105b645f249f2bc35f7db7e3e29
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: VolumeArtifacts COW base volume support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: VolumeArtifacts COW base volume support
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56629
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If31e013187830322d4c9ebf0d76b4d6d4d81445d
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm_indirection: move Volume prepare and teardown

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm_indirection: move Volume prepare and teardown
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica933a9fb17450babc02e1d71c2164942e0efe70
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add lvsByTag to FakeLVM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add lvsByTag to FakeLVM
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57070
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f87826f624ce6edaf40e7f86657c4c824aa480b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeStorageDomainCache

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: FakeStorageDomainCache
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sdm: Create repo image directory when creating block volumes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Create repo image directory when creating block volumes
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57071
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42ba107215e6b0316f41dfd9222b474a97b0755f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Prepare for COW_FORMAT test permutations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Prepare for COW_FORMAT test permutations
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56709
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6010b62291d7ce1e7e993de80d8c8dd50c2c08fe
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Support initial_size parameter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Support initial_size parameter
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795d5c8e187252c95764ede998447c6524b37f91
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 3: Code-Review+1

(1 comment)

looks ok, but please check the inline comments

https://gerrit.ovirt.org/#/c/57084/3/tests/osinfo_test.py
File tests/osinfo_test.py:

PS3, Line 31: ChunkedTests
why "Chunked" ?


-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: v2v: Detect VM with snapshots

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: Detect VM with snapshots
..


Patch Set 6: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/56574/6/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

PS6, Line 908: except libvirt.libvirtError as e:
 : logging.error('Error checking for existing snapshots; 
%r', e.message)
I prefer if you keep using logging.exception() here.
If we filter out known-not-working scenarios, that will dump only real 
meaningful stacktraces.


-- 
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: _upgradePool - concurrent.thread instead threading....

[laravot]

Liron Aravot has uploaded a new change for review.

Change subject: storage: _upgradePool - concurrent.thread instead 
threading.Thread
..

storage: _upgradePool - concurrent.thread instead threading.Thread

Currently _upgradePool uses threading.Thread which doesn't print
the traceback in cae of error during the execution. This makes it
hard to debug errors that might rise on the started threads.
This patch changes it to use concurrent.Thread which already includes
the use of @utils.traceback that provides the logging.

Change-Id: I1bb080c25e3dbf3c93f84ce73417e7e64bcb4fc4
Bug-Url: https://bugzilla.redhat.com/1319523
Signed-off-by: Liron Aravot 
---
M vdsm/storage/sp.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/57099/1

diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index f5e69e8..421bb7a 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -460,7 +460,7 @@
 self._upgradeCallback)
 self.log.debug("Running initial domain upgrade threads")
 for sdUUID in self._domainsToUpgrade:
-threading.Thread(target=self._upgradeCallback,
+concurrent.thread(target=self._upgradeCallback,
  args=(sdUUID, True),
  kwargs={"__securityOverride": True}).start()
 


-- 
To view, visit https://gerrit.ovirt.org/57099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bb080c25e3dbf3c93f84ce73417e7e64bcb4fc4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: _upgradePool - concurrent.thread instead threading....

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: _upgradePool - concurrent.thread instead 
threading.Thread
..


Patch Set 1:

* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1319523::ERROR, private bug
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57099
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb080c25e3dbf3c93f84ce73417e7e64bcb4fc4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 3:

* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check Product::#1301104::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: yml: generate api doc from the schema

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: yml: generate api doc from the schema
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/56387/5/lib/api/schema_to_html.py
File lib/api/schema_to_html.py:

Line 98: link = '%s' % (dataType, dataType)
Line 99: else:
Line 100: link = dataType
Line 101: f.write('%s' % link)
Line 102: f.write('%s' % html_escape(desc or ''))
> don't you prefer to add \n after each  so the output html will be easi
I wanted to keep it as it was before.
Line 103: f.write('\n')
Line 104: 
Line 105: 
Line 106: def write_params(params, caption, f):


-- 
To view, visit https://gerrit.ovirt.org/56387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0cdd7322b06899a8fb895a5bfee4d2e0e3bc8c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: add kernel cmdline reporting

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: add kernel cmdline reporting
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/57084/2/tests/capsTests.py
File tests/capsTests.py:

PS2, Line 143: def testKernelArgs(self, kernel_args):
 : with tempfile.NamedTemporaryFile() as f:
 : f.write(kernel_args)
 : actual_args = osinfo.kernel_args(f.name)
 : 
 : self.assertEqual(kernel_args, actual_args)
unrelated artifact from local version


-- 
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consume OVS netinfo by CachingNetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: consume OVS netinfo by CachingNetInfo
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ae814513795381a3727734087844a5145c855b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: report expected devices in OVS netinfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: report expected devices in OVS netinfo
..


Patch Set 8:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57067
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bdf8c0cd4eb2f11dfd8145d82b0d9f866595583
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS netinfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS netinfo
..


Patch Set 23:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5dd351faf108fd04afa78208d9c34451a856d4a
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: fake OVS networks as bridgeless

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: fake OVS networks as bridgeless
..


Patch Set 4:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0eac59a993c86fe067f2eb53937929dc65ca8581
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: yml: generate api doc from the schema

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: yml: generate api doc from the schema
..


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/56387/5/lib/api/schema_to_html.py
File lib/api/schema_to_html.py:

Line 98: link = '%s' % (dataType, dataType)
Line 99: else:
Line 100: link = dataType
Line 101: f.write('%s' % link)
Line 102: f.write('%s' % html_escape(desc or ''))
don't you prefer to add \n after each  so the output html will be easier 
to read?
Line 103: f.write('\n')
Line 104: 
Line 105: 
Line 106: def write_params(params, caption, f):


-- 
To view, visit https://gerrit.ovirt.org/56387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0cdd7322b06899a8fb895a5bfee4d2e0e3bc8c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consume OVS netinfo by CachingNetInfo

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: consume OVS netinfo by CachingNetInfo
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/57089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ae814513795381a3727734087844a5145c855b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: consume OVS netinfo by CachingNetInfo

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: consume OVS netinfo by CachingNetInfo
..

net: consume OVS netinfo by CachingNetInfo

In order to use KernelConfig, we have to introduce special handling
in CachingNetInfo for OVS networks.

Change-Id: I67ae814513795381a3727734087844a5145c855b
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/netinfo/cache.py
1 file changed, 26 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/57089/1

diff --git a/lib/vdsm/netinfo/cache.py b/lib/vdsm/netinfo/cache.py
index 7709317..5f676d1 100644
--- a/lib/vdsm/netinfo/cache.py
+++ b/lib/vdsm/netinfo/cache.py
@@ -303,27 +303,34 @@
 bonding = None
 lnics = []
 
-if self.networks[network]['bridged']:
-ports = self.networks[network]['ports']
+if self.networks[network]['switch'] == 'ovs':
+bonding = self.networks[network]['bond']
+lnics = self.networks[network]['nics']
+vlanid = self.networks[network]['vlanid']
+vlan = ('%s.%s' % (bonding or lnics[0], vlanid)
+if vlanid is not None else None)
 else:
-ports = []
-interface = self.networks[network]['iface']
-ports.append(interface)
+if self.networks[network]['bridged']:
+ports = self.networks[network]['ports']
+else:
+ports = []
+interface = self.networks[network]['iface']
+ports.append(interface)
 
-for port in ports:
-if port in self.vlans:
-assert vlan is None
-nic = vlans.vlan_device(port)
-vlanid = vlans.vlan_id(port)
-vlan = port  # vlan devices can have an arbitrary name
-assert self.vlans[port]['iface'] == nic
-port = nic
-if port in self.bondings:
-assert bonding is None
-bonding = port
-lnics += self.bondings[bonding]['slaves']
-elif port in self.nics:
-lnics.append(port)
+for port in ports:
+if port in self.vlans:
+assert vlan is None
+nic = vlans.vlan_device(port)
+vlanid = vlans.vlan_id(port)
+vlan = port  # vlan devices can have an arbitrary name
+assert self.vlans[port]['iface'] == nic
+port = nic
+if port in self.bondings:
+assert bonding is None
+bonding = port
+lnics += self.bondings[bonding]['slaves']
+elif port in self.nics:
+lnics.append(port)
 
 return lnics, vlan, vlanid, bonding
 


-- 
To view, visit https://gerrit.ovirt.org/57089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I67ae814513795381a3727734087844a5145c855b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches