Change in vdsm[master]: hooks: Relocate hooking (api) module under lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Relocate hooking (api) module under lib
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/55544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: Relocate hooking (api) module under lib

[edwardh]

Edward Haas has abandoned this change.

Change subject: hooks: Relocate hooking (api) module under lib
..


Abandoned

There is no agreement on exposing hooking in this way.

-- 
To view, visit https://gerrit.ovirt.org/55544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I5f2e0ed06d5f17885b5892bb8659c52f4542a9d9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

[edwardh]

Edward Haas has posted comments on this change.

Change subject: vdsm: removing txRate and rxRate from code
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt net: Interface default driver name set to 'vhost'

[edwardh]

Edward Haas has posted comments on this change.

Change subject: virt net: Interface default driver name set to 'vhost'
..


Patch Set 1: Verified+1

Based on Meni Yakove test which was originally performed on the 4.0 branch.

-- 
To view, visit https://gerrit.ovirt.org/61772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[edwardh]

Edward Haas has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/61482/13/tests/utilsTests.py
File tests/utilsTests.py:

Line 1060: self._noIntrWatchFd(myPipe, isEpoll=False, 
mask=select.POLLIN)
Line 1061: proc.join()
Line 1062: 
Line 1063: 
Line 1064: class AtomicFileWriteTest(TestCaseBase):
Please add a test with an exception and check that the temp file is cleaned.
Line 1065: 
Line 1066: def test_create_a_new_file(self):
Line 1067: TEXT = 'foo'
Line 1068: with namedTemporaryDir() as tmp_dir:


-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[edwardh]

Edward Haas has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 13: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/61482/12/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 953: if os.path.exists(filename):
Line 954: shutil.copyfile(filename, tmp_filename)
Line 955: with open(tmp_filename, flag) as f:
Line 956: yield f
Line 957: except IOError:
> Changed to IOError.
But it needs to be generic... If a failure occurs, the file needs to be removed 
regardless of the error type.
If no failure occurs, the file is moved to apply the change atomically.
Line 958: rmFile(tmp_filename)
Line 959: raise
Line 960: else:


-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: acquire ifaces

[edwardh]

Edward Haas has posted comments on this change.

Change subject: ovs: acquire ifaces
..


Patch Set 31: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/60404/31/tests/network/func_static_ip_test.py
File tests/network/func_static_ip_test.py:

PS31, Line 137: test_attach_slave_with_ip_to_ipless_network
test_attach_nic_with_ip_as_a_slave_to_ip_network

The IP from the nic should move to the network, nic/s and bond should have no 
ip, network should get the nic ip.


https://gerrit.ovirt.org/#/c/60404/31/tests/network/ovs_switch_test.py
File tests/network/ovs_switch_test.py:

PS31, Line 31: @mock.patch('vdsm.network.ovs.info.OvsInfo')
You can move it to the class, it's a classic scenario to use it.


PS31, Line 33: mock_ovs_info.bridges = {}
 : mock_ovs_info.bridges_by_sb = {}
 : mock_ovs_info.northbounds_by_sb = {}
Use a helper for this, it repeats 3 times.
Perhaps _ovs_info_init(ovs_info)


Line 76: mock_ovs_info,
Line 77: bonds2edit={'bond1': {'nics': ['eth0', 'eth1']}},
Line 78: nets2add={}, bonds2add={},
Line 79: expected_ifaces={'eth0', 'eth1'})
Line 80: 
Missing some scenarios:
- Edit bond: Leave one slave unchanged (perhaps just change the edit bond test).
- Edit networks: swapping nics between networks and moving a nic from one 
network to another (original network removed).
Line 81: def _assert_acquired_ifaces_post_switch_setup(
Line 82: self, _ovs_info, nets2add, bonds2add, bonds2edit, 
expected_ifaces):
Line 83: 
Line 84: ovsdb = driver.vsctl.create()


-- 
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 13: Verified+1

(1 comment)

Passed utilsTests.py

https://gerrit.ovirt.org/#/c/61482/12/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 953: if os.path.exists(filename):
Line 954: shutil.copyfile(filename, tmp_filename)
Line 955: with open(tmp_filename, flag) as f:
Line 956: yield f
Line 957: except IOError:
> still too generic. isn't IOException enough here?
Changed to IOError.
Line 958: rmFile(tmp_filename)
Line 959: raise
Line 960: else:


-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 13:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Send metrics info only if metrics enabled to avoid parsing l...

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..

Send metrics info only if metrics enabled to avoid parsing logic

Change-Id: If5df7708acb3aeca6b659cd7a5ec72748325b2cb
Signed-off-by: Yaniv Bronhaim 
---
M lib/vdsm/virt/sampling.py
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/61869/1

diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py
index 62d61ac..6049387 100644
--- a/lib/vdsm/virt/sampling.py
+++ b/lib/vdsm/virt/sampling.py
@@ -33,6 +33,7 @@
 
 from vdsm import numa
 from vdsm import utils
+from vdsm.config import config
 from vdsm.constants import P_VDSM_RUN, P_VDSM_CLIENT_LOG
 from vdsm.host import api as hostapi
 from vdsm.network import ipwrapper
@@ -44,6 +45,7 @@
 _THP_STATE_PATH = '/sys/kernel/mm/transparent_hugepage/enabled'
 if not os.path.exists(_THP_STATE_PATH):
 _THP_STATE_PATH = '/sys/kernel/mm/redhat_transparent_hugepage/enabled'
+_METRICS_ENABLED = config.getboolean('metrics', 'enabled')
 
 
 class InterfaceSample(object):
@@ -520,7 +522,8 @@
 'sampled timestamp %r elapsed %.3f acquired %r domains %s',
 timestamp,  self._stats_cache.clock() - timestamp, acquired,
 'all' if fast_path else len(doms))
-self._send_metrics()
+if _METRICS_ENABLED:
+self._send_metrics()
 
 def _send_metrics(self):
 vms = self._get_vms()
@@ -572,7 +575,7 @@
 sample = HostSample(self._pid)
 self._samples.append(sample)
 
-if self._cif:
+if self._cif and _METRICS_ENABLED:
 stats = hostapi.get_stats(self._cif, self._samples.stats())
 hostapi.report_stats(stats)
 


-- 
To view, visit https://gerrit.ovirt.org/61869
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5df7708acb3aeca6b659cd7a5ec72748325b2cb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Send metrics info only if metrics enabled to avoid parsing l...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61869
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5df7708acb3aeca6b659cd7a5ec72748325b2cb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Rename reports to metrics

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Rename reports to metrics
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61870
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I340c1854d67ce5b6be01cad6a540c6d81eaa0eff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Rename reports to metrics

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Rename reports to metrics
..

Rename reports to metrics

Leftovers from using reports instead of metrics (following
https://gerrit.ovirt.org/#/c/60846/)

Change-Id: I340c1854d67ce5b6be01cad6a540c6d81eaa0eff
Signed-off-by: Yaniv Bronhaim 
---
M lib/vdsm/host/api.py
M lib/vdsm/virt/sampling.py
M lib/vdsm/virt/vmstats.py
3 files changed, 65 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/61870/1

diff --git a/lib/vdsm/host/api.py b/lib/vdsm/host/api.py
index f55fa10..2b41ea9 100644
--- a/lib/vdsm/host/api.py
+++ b/lib/vdsm/host/api.py
@@ -81,60 +81,60 @@
 return ret
 
 
-def report_stats(hoststats):
+def send_metrics(hoststats):
 prefix = "hosts." + uuid()
-report = {}
+m = {}
 
 try:
 for dom in hoststats['storageDomains']:
 storage_prefix = prefix + '.storage.' + dom
 dom_info = hoststats['storageDomains'][dom]
-report[storage_prefix + '.delay'] = dom_info['delay']
-report[storage_prefix + '.last_check'] = dom_info['lastCheck']
+m[storage_prefix + '.delay'] = dom_info['delay']
+m[storage_prefix + '.last_check'] = dom_info['lastCheck']
 
-report[prefix + '.memory.available'] = hoststats['memAvailable']
-report[prefix + '.memory.committed'] = hoststats['memCommitted']
-report[prefix + '.memory.free_mb'] = hoststats['memFree']
-report[prefix + '.memory.usage_percent'] = hoststats['memUsed']
-report[prefix + '.memory.anon_huge_pages'] = hoststats['anonHugePages']
+m[prefix + '.memory.available'] = hoststats['memAvailable']
+m[prefix + '.memory.committed'] = hoststats['memCommitted']
+m[prefix + '.memory.free_mb'] = hoststats['memFree']
+m[prefix + '.memory.usage_percent'] = hoststats['memUsed']
+m[prefix + '.memory.anon_huge_pages'] = hoststats['anonHugePages']
 
-report[prefix + '.swap.total_mb'] = hoststats['swapTotal']
-report[prefix + '.swap.free_mb'] = hoststats['swapFree']
+m[prefix + '.swap.total_mb'] = hoststats['swapTotal']
+m[prefix + '.swap.free_mb'] = hoststats['swapFree']
 
-report[prefix + '.vms.active'] = hoststats['vmActive']
-report[prefix + '.vms.total'] = hoststats['vmCount']
+m[prefix + '.vms.active'] = hoststats['vmActive']
+m[prefix + '.vms.total'] = hoststats['vmCount']
 
-report[prefix + '.cpu.load'] = hoststats['cpuLoad']
-report[prefix + '.cpu.user'] = hoststats['cpuUser']
-report[prefix + '.cpu.sys'] = hoststats['cpuSys']
-report[prefix + '.cpu.idle'] = hoststats['cpuIdle']
-report[prefix + '.cpu.sys_vdsmd'] = hoststats['cpuSysVdsmd']
-report[prefix + '.cpu.user_vdsmd'] = hoststats['cpuUserVdsmd']
-report[prefix + '.cpu.ksm_pages'] = hoststats['ksmPages']
-report[prefix + '.cpu.ksm_cpu_precent'] = hoststats['ksmCpu']
+m[prefix + '.cpu.load'] = hoststats['cpuLoad']
+m[prefix + '.cpu.user'] = hoststats['cpuUser']
+m[prefix + '.cpu.sys'] = hoststats['cpuSys']
+m[prefix + '.cpu.idle'] = hoststats['cpuIdle']
+m[prefix + '.cpu.sys_vdsmd'] = hoststats['cpuSysVdsmd']
+m[prefix + '.cpu.user_vdsmd'] = hoststats['cpuUserVdsmd']
+m[prefix + '.cpu.ksm_pages'] = hoststats['ksmPages']
+m[prefix + '.cpu.ksm_cpu_precent'] = hoststats['ksmCpu']
 
 if hoststats['haStats']['configured']:
-report[prefix + '.ha_score'] = hoststats['haScore']
+m[prefix + '.ha_score'] = hoststats['haScore']
 
-report[prefix + '.elapsed_time'] = hoststats['elapsedTime']
+m[prefix + '.elapsed_time'] = hoststats['elapsedTime']
 
 if 'network' in hoststats:
 for interface in hoststats['network']:
 if_info = hoststats['network'][interface]
 net_prefix = prefix + '.network_interfaces.' + interface
-report[net_prefix + '.speed'] = if_info['speed']
-report[net_prefix + '.rx_rate'] = if_info['rxRate']
-report[net_prefix + '.tx_rate'] = if_info['txRate']
-report[net_prefix + '.rx_errors'] = if_info['rxErrors']
-report[net_prefix + '.tx_errors'] = if_info['txErrors']
-report[net_prefix + '.rx_dropped'] = if_info['rxDropped']
-report[net_prefix + '.tx_dropped'] = if_info['txDropped']
-report[net_prefix + '.rx'] = if_info['rx']
-report[net_prefix + '.tx'] = if_info['tx']
+m[net_prefix + '.speed'] = if_info['speed']
+m[net_prefix + '.rx_rate'] = if_info['rxRate']
+m[net_prefix + '.tx_rate'] = if_info['txRate']
+m[net_prefix + '.rx_errors'] = if_info['rxErrors']
+

Change in vdsm[master]: Send metrics info only if metrics enabled to avoid parsing l...

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61869
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5df7708acb3aeca6b659cd7a5ec72748325b2cb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Send vm info report each sampling interval from VMBulkSampler

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Send vm info report each sampling interval from VMBulkSampler
..


Patch Set 13: Code-Review+2

performance concerns addressed on 61869
we agreed to do deeper perf. analysis once the patch is in master

-- 
To view, visit https://gerrit.ovirt.org/59523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44f97279e37265deb47ded60557dc98411fb9fc
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Send vm info report each sampling interval from VMBulkSampler

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Send vm info report each sampling interval from VMBulkSampler
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44f97279e37265deb47ded60557dc98411fb9fc
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 10:

jenkins failure is real: 00:03:55.095 ./vdsm/API.py:45: 'vmstatus' imported but 
unused

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 10: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 10: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/61482/12/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 953: if os.path.exists(filename):
Line 954: shutil.copyfile(filename, tmp_filename)
Line 955: with open(tmp_filename, flag) as f:
Line 956: yield f
Line 957: except Exception:
still too generic. isn't IOException enough here?
Line 958: rmFile(tmp_filename)
Line 959: raise
Line 960: else:


-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Re-review vdsm spec

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Re-review vdsm spec
..

Re-review vdsm spec

The patch fixed fedora-review report warnings:
1. Using %{_libdir} instead of explicit path
2. Specifies vdsm-infra version to obsoletes
3. Require python2-devel instead of python-devel
4. Removed %config(noreplace) from %{_tmpfilesdir}/%{vdsm_name}.conf
which is not needed (see bug for more details)

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1361659
Change-Id: Ie005f2d45500119d8f52c49fa17eb766cda72e8e
Signed-off-by: Yaniv Bronhaim 
---
M vdsm.spec.in
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/61844/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index dba1f33..9b87e93 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -56,14 +56,14 @@
 Group:  Applications/System
 License:GPLv2+
 Url:http://www.ovirt.org/wiki/Vdsm
-Source0:%{vdsm_name}-%{version}.tar.gz
+Source0:
https://bronhaim.fedorapeople.org/%{vdsm_name}-%{version}.tar.gz
 BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 %{!?_licensedir:%global license %%doc}
 
 BuildRequires: cyrus-sasl-lib
 BuildRequires: python
-BuildRequires: python-devel
+BuildRequires: python2-devel
 BuildRequires: python-mock
 BuildRequires: python-netaddr
 BuildRequires: python-nose
@@ -156,7 +156,7 @@
 Requires: mom >= 0.5.3
 Requires(pre): shadow-utils
 
-Obsoletes: %{name}-infra
+Obsoletes: %{name}-infra >= 4.16.0
 
 %if 0%{?with_openvswitch}
 Requires: openvswitch >= 2.0.0
@@ -765,8 +765,8 @@
 install -Dm 0644 vdsm/limits.conf \
  %{buildroot}/etc/security/limits.d/99-vdsm.conf
 
-install -Dm 0755 init/systemd/systemd-vdsmd 
%{buildroot}/usr/lib/systemd/systemd-vdsmd
-install -Dm 0644 init/systemd/85-vdsmd.preset 
%{buildroot}/usr/lib/systemd/system-preset/85-vdsmd.preset
+install -Dm 0755 init/systemd/systemd-vdsmd 
%{buildroot}%{_libdir}/systemd/systemd-vdsmd
+install -Dm 0644 init/systemd/85-vdsmd.preset 
%{buildroot}%{_libdir}/systemd/system-preset/85-vdsmd.preset
 install -Dm 0644 init/systemd/vdsmd.service 
%{buildroot}%{_unitdir}/vdsmd.service
 install -Dm 0644 init/systemd/vdsm-network.service 
%{buildroot}%{_unitdir}/vdsm-network.service
 install -Dm 0644 init/systemd/supervdsmd.service 
%{buildroot}%{_unitdir}/supervdsmd.service
@@ -901,8 +901,8 @@
 %defattr(-, root, root, -)
 %doc README lib/vdsm/vdsm.conf.sample
 %license COPYING
-/usr/lib/systemd/systemd-vdsmd
-/usr/lib/systemd/system-preset/85-vdsmd.preset
+%{_libdir}/systemd/systemd-vdsmd
+%{_libdir}/systemd/system-preset/85-vdsmd.preset
 %{_unitdir}/vdsmd.service
 %{_unitdir}/vdsm-network.service
 %{_unitdir}/supervdsmd.service
@@ -967,7 +967,7 @@
 %config(noreplace) %{_sysconfdir}/rwtab.d/vdsm
 %config(noreplace) %{_sysconfdir}/sysctl.d/vdsm.conf
 %config(noreplace) %{_sysconfdir}/modules-load.d/vdsm.conf
-%config(noreplace) %{_tmpfilesdir}/%{vdsm_name}.conf
+%{_tmpfilesdir}/%{vdsm_name}.conf
 %{_sysconfdir}/dhcp/dhclient.d/sourceRoute.sh
 %{_sysconfdir}/sudoers.d/50_vdsm
 %{_sysconfdir}/cron.hourly/vdsm-logrotate


-- 
To view, visit https://gerrit.ovirt.org/61844
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie005f2d45500119d8f52c49fa17eb766cda72e8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 10: Verified+1

only rebased.

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Re-review vdsm spec

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Re-review vdsm spec
..


Patch Set 1:

* #1361659::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1361659::OK, public bug
* Check Product::#1361659::SKIPPED, Wrong product Fedora and classification 
Fedora not oVirt
* Check Product::WARN, no bug url with correct product found, make sure you 
have at least one bug-url with a product in oVirt Red Hat Enterprise 
Virtualization Manager.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61844
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie005f2d45500119d8f52c49fa17eb766cda72e8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: copy NIC hwaddr to NB
..


Patch Set 15:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd22d101868b56c6f0a7ba9b41d43dc5784bdb8
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: ovs: copy NIC hwaddr to NB
..


Patch Set 14: Verified+1

Passed network/*_test.py

-- 
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd22d101868b56c6f0a7ba9b41d43dc5784bdb8
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move mom to static

[fromani]

Francesco Romani has posted comments on this change.

Change subject: configs: move mom to static
..


Patch Set 6: Code-Review-1

(4 comments)

-1 for visibility

https://gerrit.ovirt.org/#/c/61602/6/.gitignore
File .gitignore:

Line 40: lib/vdsm/vdscli.py
Line 41: lib/vdsm/vdsm.conf.sample
Line 42: results.log
Line 43: static/logger.conf
Line 44: static/mom.conf
needs update
Line 45: static/svdsm.logger.conf
Line 46: tags
Line 47: tests/crossImportsTests.py
Line 48: tests/run_tests.sh


https://gerrit.ovirt.org/#/c/61602/6/tests/momPolicyTests.py
File tests/momPolicyTests.py:

Line 15: 
Line 16: class MomPolicyTests(TestCase):
Line 17: def _getPolicyContent(self, name):
Line 18: path = 
os.path.join(os.path.dirname(os.path.realpath(__file__)),
Line 19: "../static/mom.d",
needs update
Line 20: name)
Line 21: return open(path, "r").read()
Line 22: 
Line 23: def _loadPolicyFile(self, policy, filename):


Line 20: name)
Line 21: return open(path, "r").read()
Line 22: 
Line 23: def _loadPolicyFile(self, policy, filename):
Line 24: """Load MOM policy from static/mom.d/+filename and apply it
same
Line 25:under the 'basename without extension' policy name.
Line 26: 
Line 27:Example:
Line 28:00-constants.policy is loaded from 
static/mom.d/00-constants.policy


Line 24: """Load MOM policy from static/mom.d/+filename and apply it
Line 25:under the 'basename without extension' policy name.
Line 26: 
Line 27:Example:
Line 28:00-constants.policy is loaded from 
static/mom.d/00-constants.policy
same
Line 29:and inserted as 00-costants policy.
Line 30: """
Line 31: 
Line 32: policy_string = self._getPolicyContent(filename)


-- 
To view, visit https://gerrit.ovirt.org/61602
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaeffdb167f9f406106efa187ed48e9103648267
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move logger to static

[fromani]

Francesco Romani has posted comments on this change.

Change subject: configs: move logger to static
..


Patch Set 5: Code-Review-1

(1 comment)

missing .gitignore updates

https://gerrit.ovirt.org/#/c/61601/5/.gitignore
File .gitignore:

Line 40: lib/vdsm/vdscli.py
Line 41: lib/vdsm/vdsm.conf.sample
Line 42: results.log
Line 43: static/logger.conf
Line 44: static/svdsm.logger.conf
needs update
Line 45: tags
Line 46: tests/crossImportsTests.py
Line 47: tests/run_tests.sh
Line 48: tests/run_tests_local.sh


-- 
To view, visit https://gerrit.ovirt.org/61601
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7894e7d48047a6cb8b1f2482fd44c89b9260797e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: autoconf: properly sort makefiles

[fromani]

Francesco Romani has posted comments on this change.

Change subject: autoconf: properly sort makefiles
..


Patch Set 4: Code-Review+1

seems ok

-- 
To view, visit https://gerrit.ovirt.org/61600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6aa56ef3ff67627a2661c46e24d179812230d6a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: acquire ifaces

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: ovs: acquire ifaces
..


Patch Set 31: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 30

-- 
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: acquire ifaces

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: ovs: acquire ifaces
..


Patch Set 31: Verified+1

Passed network/*_test.py

-- 
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: vdsm: removing txRate and rxRate from code
..


Patch Set 6:

Verified with:
-master, vdsm with changes applied
-4.0, vdsm with changes applied (to verify compatiblity with 4.0 engine)

-- 
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: introduce static dir

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: introduce static dir
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61599
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I654f6ef224a1add496cdcc576f075d1748e1901e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move systemd service files to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: move systemd service files to static
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61763
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39cb88067e5b3f87c2f2c4f01f47c32a51fccd5a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: confis: move modprobe files loading to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: confis: move modprobe files loading to static
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61762
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I417100e29761dc2c498556ecd365323ae7ce3dbd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move sudoers to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: move sudoers to static
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61603
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fd006ff4fdafbe436974f868e461c105ae0dba1
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: autoconf: properly sort makefiles

[automation]

gerrit-hooks has posted comments on this change.

Change subject: autoconf: properly sort makefiles
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6aa56ef3ff67627a2661c46e24d179812230d6a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move logger to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: move logger to static
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61601
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7894e7d48047a6cb8b1f2482fd44c89b9260797e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move logrotate to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: move logrotate to static
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1563c74ba83401e7c84fd564433daefdd9cdd1ac
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move mom to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: move mom to static
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61602
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaeffdb167f9f406106efa187ed48e9103648267
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move sysctl to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: move sysctl to static
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic93502bfea8f51998b611410f20b8a6a3567e7ee
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move limits to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: move limits to static
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61605
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd6f78eb2feadaeb73ed688b4c41af5093c928c0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move kernel module loading to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: move kernel module loading to static
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61617
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52eef9425bd2dcd110ae3258ba44358c3d3707f2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: configs: move rwtab to static

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configs: move rwtab to static
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61604
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44befe2591c42b6c636f2db2b5b13c170af5ce17
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: makefile: remove unused all-local section

[automation]

gerrit-hooks has posted comments on this change.

Change subject: makefile: remove unused all-local section
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61545
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10865cf3b48b5572708fd34bdeb6e5a178f38398
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: vdsm: removing txRate and rxRate from code
..


Patch Set 6: Code-Review+1

Based on last comment I do not have more concerns about backward compatibility

-- 
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: vdsm: removing txRate and rxRate from code
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: vdsm: removing txRate and rxRate from code
..


Patch Set 6:

The engine code which receives the stats looks to be immune to missing 
rx/txRate.
The incoming value is wrapped with 
VdsBrokerObjectBuilder.assignDoubleValueWithNullProtection, which converts 
missing rx/txRate into zeros. So removing the values does not break 
compatibility with engine 4.0

-- 
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: acquire ifaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: acquire ifaces
..


Patch Set 31:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: removing txRate and rxRate from code
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: acquire external ifaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: acquire external ifaces
..


Patch Set 30:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 22: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 22:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[edwardh]

Edward Haas has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 12: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 22: Verified+1

(1 comment)

Passed network/*test.py

https://gerrit.ovirt.org/#/c/60974/21/tests/network/ifacquire_test.py
File tests/network/ifacquire_test.py:

PS21, Line 106:  to open
  : @mock.patch.object(ifacquire.utils, 'atomic_fi
> Ha... this works just because these atomic_file_write has an api similar to
Done


-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 12: Verified+1

Passed utilsTests.py

-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonvdscli: change hostname default

[edwardh]

Edward Haas has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 5: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/61782/5/tests/stompAsyncDispatcherTests.py
File tests/stompAsyncDispatcherTests.py:

Line 58: def queue_frame(self, frame):
Line 59: self._outbox.append(frame)
Line 60: 
Line 61: 
Line 62: class TestDispatcher(object):
In another patch it better be called something that hints it is a mock/fake. It 
took me a while to understand why you added a line here.
Line 63: 
Line 64: socket = None
Line 65: 
Line 66: def __init__(self, data):


-- 
To view, visit https://gerrit.ovirt.org/61782
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: enhance legacy downtime algorithm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: enhance legacy downtime algorithm
..


Patch Set 16:

* #1339521::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/56561
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d18a77c91a1344110afef1577e310faab3ffe5b
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ifcfg: write current DNS information to a management network...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: ifcfg: write current DNS information to a management network's 
ifcfg file
..


Patch Set 8:

(1 comment)

Code changes should be accompanied by tests that backs them.
Please try to do it in the same patch, if you find it too complex then we can 
split it.

https://gerrit.ovirt.org/#/c/61184/8/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

PS8, Line 193: =None
> Did you mean – make this a positional argument like 'network' and 'configur
Yes, just move it after configurator argument, without the default and check it 
everything works (should work).


-- 
To view, visit https://gerrit.ovirt.org/61184
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie10ee7938b26a7f3b2b7be80bc1a2a83cd1c376c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: enhance legacy downtime algorithm

[tjelinek]

Tomas Jelinek has abandoned this change.

Change subject: migration: enhance legacy downtime algorithm
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/56561
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I5d18a77c91a1344110afef1577e310faab3ffe5b
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 21: Code-Review+1

(1 comment)

Very nice. Only one recommendation for comment.

https://gerrit.ovirt.org/#/c/60974/21/tests/network/ifacquire_test.py
File tests/network/ifacquire_test.py:

PS21, Line 106: 'atomic_file_write',
  :new_callable=mock.mock_open
Ha... this works just because these atomic_file_write has an api similar to 
open.
Seems like a unique thing to do... better comment it here.


-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: jsonrpc: add example script to run a VM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: jsonrpc: add example script to run a VM
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61047
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc8ec3a6ea795659834392f94e7649218ac3fda8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: jsonrpc: add example script to run a VM

[fromani]

Francesco Romani has posted comments on this change.

Change subject: contrib: jsonrpc: add example script to run a VM
..


Patch Set 5: Verified+1

works as expected

-- 
To view, visit https://gerrit.ovirt.org/61047
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc8ec3a6ea795659834392f94e7649218ac3fda8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonvdscli: change hostname default

[stirabos]

Simone Tiraboschi has posted comments on this change.

Change subject: jsonvdscli: change hostname default
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61782
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fcee627f7fe61305b0e3f8bdac01fa9ac3f85d1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 19:

(11 comments)

https://gerrit.ovirt.org/#/c/60974/19/lib/vdsm/network/ifacquire.py
File lib/vdsm/network/ifacquire.py:

Line 51: 
Line 52: def __enter__(self):
Line 53: return self
Line 54: 
Line 55: def __exit__(self, type, value, traceback):
> We better log the exception and the transaction failure.
IIUIC it will be raised up to rollback and rollback will log it, or am i wrong?
Line 56: if type is None:
Line 57: try:
Line 58: self._disable_onboot()
Line 59: except:


Line 65: for iface, ifcfg_lines in six.iteritems(self._ifaces):
Line 66: if ifcfg_lines:
Line 67: _rollback_ifcfg_iface(iface, ifcfg_lines)
Line 68: 
Line 69: def acquire(self, ifaces):
> Move after __init__ please or right after __exit__.
Done
Line 70: self._backup(ifaces)
Line 71: self._turn_down()
Line 72: 
Line 73: def _backup(self, ifaces):


PS19, Line 80: _turn_down
> How about _release_iface ?
Done


PS19, Line 83: turn_down
> And here 'release' as well... (if you agree with the previous one)
Done


https://gerrit.ovirt.org/#/c/60974/19/tests/network/ifacquire_test.py
File tests/network/ifacquire_test.py:

PS19, Line 82: mock_isfile
> not needed, no need to generate a MagicMock, just replace 'return_value' wi
Done


PS19, Line 109: mock_isfile
> not needed.
Done


PS19, Line 113: handle
> How about 'file' instead of 'handle'?
Done


Line 116: atomic_write_handle.readlines.return_value = original_ifcfg
Line 117: 
Line 118: with ifacquire.Transaction(netinfo_nets={}) as a:
Line 119: a.acquire(ifaces=[NIC_NAME])
Line 120: atomic_write_handle.writelines.assert_called_with(
> New line before this please.
Done
Line 121: ifcfg_after_turn_down)
Line 122: atomic_write_handle.readlines.return_value = 
ifcfg_after_turn_down
Line 123: mock_ifdown.assert_called_with(NIC_NAME)
Line 124: atomic_write_handle.writelines.assert_called_with(


Line 120: atomic_write_handle.writelines.assert_called_with(
Line 121: ifcfg_after_turn_down)
Line 122: atomic_write_handle.readlines.return_value = 
ifcfg_after_turn_down
Line 123: mock_ifdown.assert_called_with(NIC_NAME)
Line 124: atomic_write_handle.writelines.assert_called_with(
> New line before this please
Done
Line 125: ifcfg_after_disable_onboot)
Line 126: 
Line 127: @mock.patch.object(ifacquire.ifcfg, 'ifdown', return_value=None)
Line 128: @mock.patch.object(ifacquire.os.path, 'isfile', return_value=True)


PS19, Line 134: mock_isfile,
  :  mock_ifdown
> No need for these two.
Done


Line 140: 
Line 141: with self.assertRaises(TestException):
Line 142: with ifacquire.Transaction(netinfo_nets={}) as a:
Line 143: a.acquire(ifaces=[NIC_NAME])
Line 144: raise TestException()
> new line before this one.
Done


-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 21:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

[edwardh]

Edward Haas has posted comments on this change.

Change subject: ovs: copy NIC hwaddr to NB
..


Patch Set 14: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd22d101868b56c6f0a7ba9b41d43dc5784bdb8
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 12:

(2 comments)

https://gerrit.ovirt.org/#/c/61482/9/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 933: 
Line 934: 
Line 935: @contextmanager
Line 936: def atomic_file_write(filename, flag):
Line 937: """
> ok. please follow the file standards here
Done
Line 938: Atomically write into a file.
Line 939: 
Line 940: Usage:
Line 941: 


https://gerrit.ovirt.org/#/c/61482/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:

PS11, Line 956:
> Too generic.
Done


-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: copy NIC hwaddr to NB
..


Patch Set 14:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd22d101868b56c6f0a7ba9b41d43dc5784bdb8
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ifcfg: write current DNS information to a management network...

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: write current DNS information to a management network's 
ifcfg file
..


Patch Set 8:

(4 comments)

Let me add tests in a separate patch.

https://gerrit.ovirt.org/#/c/61184/8//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-08-01 17:11:46 +0200
Line 6: 
Line 7: ifcfg: write current DNS information to a management network's ifcfg 
file
Line 8: 
Line 9: This is to maintain the current DNS configuration.
> It is to set DNS server entries, not only to preserve them.
Done
Line 10: 
Line 11: DNS1= and DNS2= are used to carry 'nameserver' entries from 
/etc/resolv.conf
Line 12: which would otherwise be lost.
Line 13: 


https://gerrit.ovirt.org/#/c/61184/8/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 551: cfg += 'IPV6_DEFAULTGW=%s\n' % 
pipes.quote(ipv6.gateway)
Line 552: elif ipv6.dhcpv6:
Line 553: cfg += 'DHCPV6C=yes\n'
Line 554: cfg += 'IPV6_AUTOCONF=%s\n' % 
_to_ifcfg_bool(ipv6.ipv6autoconf)
Line 555: # Preserve DNS configuration in a management network ifcfg 
file. Only
> I do not think the comment is needed, it is clear that this value is set if
Done
Line 556: # a top-level device (of any type) carries this information.
Line 557: if device.nameservers:
Line 558: for i, nameserver in enumerate(device.nameservers[0:2], 
1):
Line 559: cfg += 'DNS{}={}\n'.format(i, nameserver)


https://gerrit.ovirt.org/#/c/61184/8/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

PS8, Line 114: to be added to /etc/resolv.conf
> implementation detail, please remove.
Done


PS8, Line 193: =None
> No need for the default, it is populated by the canonicalize step.
Did you mean – make this a positional argument like 'network' and 
'configurator' because 'nameservers' is always populated (as well as _netinfo)?


-- 
To view, visit https://gerrit.ovirt.org/61184
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie10ee7938b26a7f3b2b7be80bc1a2a83cd1c376c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/61768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..


Adding get_batch to StatsCache - returns dict with all vms stat

Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: https://gerrit.ovirt.org/61768
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M lib/vdsm/virt/sampling.py
M tests/samplingTests.py
2 files changed, 55 insertions(+), 0 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/61768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: copy NIC hwaddr to NB
..


Patch Set 13:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd22d101868b56c6f0a7ba9b41d43dc5784bdb8
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 20:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 19: Code-Review-1

(11 comments)

https://gerrit.ovirt.org/#/c/60974/19/lib/vdsm/network/ifacquire.py
File lib/vdsm/network/ifacquire.py:

Line 51: 
Line 52: def __enter__(self):
Line 53: return self
Line 54: 
Line 55: def __exit__(self, type, value, traceback):
We better log the exception and the transaction failure.
Line 56: if type is None:
Line 57: try:
Line 58: self._disable_onboot()
Line 59: except:


Line 65: for iface, ifcfg_lines in six.iteritems(self._ifaces):
Line 66: if ifcfg_lines:
Line 67: _rollback_ifcfg_iface(iface, ifcfg_lines)
Line 68: 
Line 69: def acquire(self, ifaces):
Move after __init__ please or right after __exit__.
Line 70: self._backup(ifaces)
Line 71: self._turn_down()
Line 72: 
Line 73: def _backup(self, ifaces):


PS19, Line 80: _turn_down
How about _release_iface ?


PS19, Line 83: turn_down
And here 'release' as well... (if you agree with the previous one)

For non_ifcfg as well


https://gerrit.ovirt.org/#/c/60974/19/tests/network/ifacquire_test.py
File tests/network/ifacquire_test.py:

PS19, Line 82: mock_isfile
not needed, no need to generate a MagicMock, just replace 'return_value' with a 
lambda.
@mock.patch.object(ifacquire.os.path, 'isfile', lambda x: False)


PS19, Line 109: mock_isfile
not needed.


PS19, Line 113: handle
How about 'file' instead of 'handle'?
True for all 'handle' usages...


Line 116: atomic_write_handle.readlines.return_value = original_ifcfg
Line 117: 
Line 118: with ifacquire.Transaction(netinfo_nets={}) as a:
Line 119: a.acquire(ifaces=[NIC_NAME])
Line 120: atomic_write_handle.writelines.assert_called_with(
New line before this please.
Please separate between the action and the assertion parts.. just for 
readability.
Line 121: ifcfg_after_turn_down)
Line 122: atomic_write_handle.readlines.return_value = 
ifcfg_after_turn_down
Line 123: mock_ifdown.assert_called_with(NIC_NAME)
Line 124: atomic_write_handle.writelines.assert_called_with(


Line 120: atomic_write_handle.writelines.assert_called_with(
Line 121: ifcfg_after_turn_down)
Line 122: atomic_write_handle.readlines.return_value = 
ifcfg_after_turn_down
Line 123: mock_ifdown.assert_called_with(NIC_NAME)
Line 124: atomic_write_handle.writelines.assert_called_with(
New line before this please
Line 125: ifcfg_after_disable_onboot)
Line 126: 
Line 127: @mock.patch.object(ifacquire.ifcfg, 'ifdown', return_value=None)
Line 128: @mock.patch.object(ifacquire.os.path, 'isfile', return_value=True)


PS19, Line 134: mock_isfile,
  :  mock_ifdown
No need for these two.

@mock.patch.object(ifacquire.ifcfg, 'ifdown', lambda x: None)
@mock.patch.object(ifacquire.os.path, 'isfile', lambda x: True)


Line 140: 
Line 141: with self.assertRaises(TestException):
Line 142: with ifacquire.Transaction(netinfo_nets={}) as a:
Line 143: a.acquire(ifaces=[NIC_NAME])
Line 144: raise TestException()
new line before this one.


-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/61768/3//COMMIT_MSG
Commit Message:

Line 2: Author: Yaniv Bronhaim 
Line 3: AuthorDate: 2016-07-28 14:12:17 +0300
Line 4: Commit: Yaniv Bronhaim 
Line 5: CommitDate: 2016-08-02 13:43:52 +0300
Line 6: 
> I missing here few details about StatsCache contents. Are we using time int
Yes, samples are added to this cache each time interval.
one periodic.Operation runs the code periodically (:)), and
the samples are taken using vdsm.virt.sampling.VMBulkSampler, which in turn 
uses libvirt bulk stats.

The StatsCache is one SampleWindow (see lib/vdsm/virt/sampling.py) augmented 
with a couple of utilities.

The first utility method, get() allows one client to receive samples for just 
one VM. Let's see why this is useful and deserves mention - and code.
bulk stats returns dict like {vmid1:data1, vmid2:data2} - let's ignore what 
'dataX' is right now, is not relevant for this discussion. OTOH, Vm classes 
needs to access only their data to implement Vm.getStat(), so we factor out the 
logic needed to do so in StatsCache.get().

In the metrics reporting flow, we don't need to access only the data of a 
single VM: we want to report all of them.
so it seems too awkward to pass through the existing StatsCache.get(), because 
this will force the client code to
1. scan all the stored collection of samples
2. extract data for one Vm
3. add the extracted data to another collection

It is both simpler and more effective to return the last collection of samples.

Furthermore, this new utility method could be used later on
to optimize our getAllVmStats() flow.

HTH
Line 7: Adding get_batch to StatsCache - returns dict with all vms stat
Line 8: 
Line 9: Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d


-- 
To view, visit https://gerrit.ovirt.org/61768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 12:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/61482/11/lib/vdsm/utils.py
File lib/vdsm/utils.py:

PS11, Line 956: except:
Too generic.


-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: fix check-merged.sh

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: automation: fix check-merged.sh
..


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/61415/10/automation/deploy.sh
File automation/deploy.sh:

Line 50
Line 51
Line 52
Line 53
Line 54
dan suggests to keep this removal - vdsm functional test for setup network will 
fail if this bond exists. that's why we didn't see the need for that


-- 
To view, visit https://gerrit.ovirt.org/61415
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cecee04bd4311444052bcdc701c90d60f8ebe29
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: copy NIC hwaddr to NB
..


Patch Set 12:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd22d101868b56c6f0a7ba9b41d43dc5784bdb8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: copy NIC hwaddr to NB
..


Patch Set 11:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd22d101868b56c6f0a7ba9b41d43dc5784bdb8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: ovs: copy NIC hwaddr to NB
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/61049/9/lib/vdsm/network/ovs/switch.py
File lib/vdsm/network/ovs/switch.py:

Line 267: def _random_unicast_local_mac():
Line 268: # TODO: use prefix specified for OVS internal ifaces
Line 269: mac = [
Line 270: 0b0010,
Line 271: random.randint(0x00, 0xff),
> It's just shorter.
The mask is not enough, we must set 7. bit to 1 and 8. to 0.
Done.
Line 272: random.randint(0x00, 0xff),
Line 273: random.randint(0x00, 0xff),
Line 274: random.randint(0x00, 0xff),
Line 275: random.randint(0x00, 0xff)]


-- 
To view, visit https://gerrit.ovirt.org/61049
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfd22d101868b56c6f0a7ba9b41d43dc5784bdb8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: api: allow to return prebuilt responses

[fromani]

Francesco Romani has posted comments on this change.

Change subject: lib: api: allow to return prebuilt responses
..


Patch Set 3: Verified+1

verified with the tests.

-- 
To view, visit https://gerrit.ovirt.org/61474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1c6ab93271e2c5619483446403068ddd95ecb4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: API: modernize VM methods

[automation]

gerrit-hooks has posted comments on this change.

Change subject: API: modernize VM methods
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61475
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e2e238fc632df97b63f7bb2a6293fe1c392a842
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lib: api: allow to return prebuilt responses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: api: allow to return prebuilt responses
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61474
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1c6ab93271e2c5619483446403068ddd95ecb4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: move the api.py module in the common subtree

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: move the api.py module in the common subtree
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61473
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd4c38ebaa120c617c7f0065cd5d93f134827893
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: WIP: API: more cleanups

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: API: more cleanups
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61591
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07cca8d3e6ee56c0e190e884410074431221371d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Send vm info report each sampling interval from VMBulkSampler

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Send vm info report each sampling interval from VMBulkSampler
..


Patch Set 12:

is it worth adding some tests?

-- 
To view, visit https://gerrit.ovirt.org/59523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44f97279e37265deb47ded60557dc98411fb9fc
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/61768/3//COMMIT_MSG
Commit Message:

Line 2: Author: Yaniv Bronhaim 
Line 3: AuthorDate: 2016-07-28 14:12:17 +0300
Line 4: Commit: Yaniv Bronhaim 
Line 5: CommitDate: 2016-08-02 13:43:52 +0300
Line 6: 
I missing here few details about StatsCache contents. Are we using time 
interval to collect stats?

Please give more information what is the value of this change.
Line 7: Adding get_batch to StatsCache - returns dict with all vms stat
Line 8: 
Line 9: Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d


-- 
To view, visit https://gerrit.ovirt.org/61768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/61482/9/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 933: 
Line 934: 
Line 935: @contextmanager
Line 936: def atomic_file_write(filename, flag):
Line 937: """Atomically write into a file.
> I'm following https://www.python.org/dev/peps/pep-0257/#multi-line-docstrin
ok. please follow the file standards here
Line 938: 
Line 939: Usage:
Line 940: 
Line 941: with atomic_write('foo.txt', 'w') as f:


-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: automation: fix check-merged.sh

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: automation: fix check-merged.sh
..


Patch Set 10:

(4 comments)

https://gerrit.ovirt.org/#/c/61415/10/automation/deploy.sh
File automation/deploy.sh:

Line 28: dnf install --nogpgcheck -y libvirt-daemon
Line 29: rm -rf /var/cache/libvirt/qemu/capabilities
Line 30: systemctl restart libvirtd.service || :
Line 31: 
Line 32: # enable the local repo
write here that you use cost=1 to give this repository priority
Line 33: cat > /etc/yum.repos.d/local-ovirt.repo 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: ovs: acquire external ifaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ovs: acquire external ifaces
..


Patch Set 29:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..


Patch Set 3: Verified+1

fixed pyflakes warnings. started to use atomic and missed them

-- 
To view, visit https://gerrit.ovirt.org/61768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b194746f1fcbbf0804f9b714fff813f576861d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: introduce acquire module

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 19: Verified+1

Passed ifacquire_test.py

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 11: Verified+1

(12 comments)

Passed utilsTests.py

https://gerrit.ovirt.org/#/c/61482/8/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 932: return rget(dict.get(keys[0]), keys[1:], default)
Line 933: 
Line 934: 
Line 935: @contextmanager
Line 936: def atomic_file_write(filename, flag):
> call it - atomic_file_write_context. and if its only write, remove the flag
Write methods are available in 'w', 'a' and '+' flags. We should keep the flag 
argument.
Line 937: """Atomically write into a file.
Line 938: 
Line 939: Usage:
Line 940: 


Line 932: return rget(dict.get(keys[0]), keys[1:], default)
Line 933: 
Line 934: 
Line 935: @contextmanager
Line 936: def atomic_file_write(filename, flag):
> As I see it, it's like asking to specify the type name in the variable (or 
I think it is obvious from its usage. Plus none of our context manager 
functions has _context in it.
Line 937: """Atomically write into a file.
Line 938: 
Line 939: Usage:
Line 940: 


Line 942: f.write('shrubbery')
Line 943: # there are no changes on foo.txt yet
Line 944: # now it is changed
Line 945: """
Line 946: fd, tmp_filename = tempfile.mkstemp(
> path is a file name and not a path, at least if I follow the usage comment
Done
Line 947: dir=os.path.dirname(os.path.abspath(filename)),
Line 948: prefix=os.path.basename(filename) + '.',
Line 949: suffix='.tmp')
Line 950: os.close(fd)


Line 946: fd, tmp_filename = tempfile.mkstemp(
Line 947: dir=os.path.dirname(os.path.abspath(filename)),
Line 948: prefix=os.path.basename(filename) + '.',
Line 949: suffix='.tmp')
Line 950: os.close(fd)
> you should use the full path I guess, or call it filename. its confusing
I renamed it to 'file'. Python 3 uses the same for open() 
https://docs.python.org/3.5/library/functions.html#open
Line 951: try:
Line 952: if os.path.exists(filename):
Line 953: shutil.copyfile(filename, tmp_filename)
Line 954: with open(tmp_filename, flag) as f:


Line 953: shutil.copyfile(filename, tmp_filename)
Line 954: with open(tmp_filename, flag) as f:
Line 955: yield f
Line 956: except:
Line 957: rmFile(tmp_filename)
> use rmFile, or handle exceptions
Done
Line 958: raise
Line 959: else:


Line 956: except:
Line 957: rmFile(tmp_filename)
Line 958: raise
Line 959: else:
Line 960: os.rename(tmp_filename, filename)
> tempfile.NamedTemporaryFile(dir=os.path.dirname(file_path))
Done


Line 957: rmFile(tmp_filename)
Line 958: raise
Line 959: else:
Line 960: os.rename(tmp_filename, filename)
Line 961
> you don't need this helper, it got no use - do it directly in the function
Done


https://gerrit.ovirt.org/#/c/61482/9/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 932: return rget(dict.get(keys[0]), keys[1:], default)
Line 933: 
Line 934: 
Line 935: @contextmanager
Line 936: def atomic_file_write(filename, flag):
> file is a saved word.. better to use file_name. 
In the following patch I use 'r+' to read and edit file inside one with block.

Changed to filename.
Line 937: """Atomically write into a file.
Line 938: 
Line 939: Usage:
Line 940: 


Line 933: 
Line 934: 
Line 935: @contextmanager
Line 936: def atomic_file_write(filename, flag):
Line 937: """Atomically write into a file.
> I don't know why in rget above the doc string is in that format, but please
I'm following https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings
Line 938: 
Line 939: Usage:
Line 940: 
Line 941: with atomic_write('foo.txt', 'w') as f:


PS9, Line 942: b
> bb
Thanks!


Line 942: f.write('shrubbery')
Line 943: # there are no changes on foo.txt yet
Line 944: # now it is changed
Line 945: """
Line 946: fd, tmp_filename = tempfile.mkstemp(
> you can't ignore the fd. you need to close it
Done
Line 947: dir=os.path.dirname(os.path.abspath(filename)),
Line 948: prefix=os.path.basename(filename) + '.',
Line 949: suffix='.tmp')
Line 950: os.close(fd)


PS9, Line 957: tmp_file
> copyfile is NOT atomic. you must use os.rename() which is promised by POSIX
Done


-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 

Change in vdsm[master]: net: introduce acquire module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: introduce acquire module
..


Patch Set 19:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60974
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: atomic file write

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: atomic file write
..


Patch Set 11:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb5a2d3ac439a334db2c9075376f219c356762c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org