Change in vdsm[master]: Live Merge: Refresh base volume before live merge

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 3:

* #1367281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367281::OK, public bug
* Check Product::#1367281::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63454
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: Remove unneeded multipath call

2016-09-06 Thread frolland 
Freddy Rolland has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 1:

No idea why the ci fails on fedora

-- 
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: Remove unneeded multipath call

2016-09-06 Thread frolland 
Freddy Rolland has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient kill - early exit if iface does not exists

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: dhclient kill - early exit if iface does not exists
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Introduce iface.exists and start using it in ip.dhclient

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcece92726e7ef354b4792aee73bfc90fa5f3133
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - add refresh method to update bond config

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - add refresh method to update bond config
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63445
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f36cc24833b0fc612c3af033c54c7bca4742a5a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - Expose the (kernel) bond list.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - Expose the (kernel) bond list.
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba2b9d5ec712b268cc3775682506ec83aabbdb8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - preserve original slaves link state.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - preserve original slaves link state.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia98d01512322f88bf9819532afb2ea337cee7749
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - adding a transaction context.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - adding a transaction context.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63443
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d015ed235c3620c04131e57ad079a2ec1a0ecc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose owned_device method through the configurator

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Expose owned_device method through the configurator
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose disable IPv6 through ip.address module

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Expose disable IPv6 through ip.address module
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - Use request options to control the default r...

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: dhclient - Use request options to control the default route
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5698c905992028980f28ba3e9eecfcdfdbfd51ef
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: dhclient - address flush before starting and on shutdown
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - Add logging to the bond driver.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - Add logging to the bond driver.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043a6232d59cd87f6b973d856df297322f4be387
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Introduce iface.exists and start using it in ip.dhclient

2016-09-06 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcece92726e7ef354b4792aee73bfc90fa5f3133
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

2016-09-06 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 9: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: fix test_events_keys

2016-09-06 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: net tests: fix test_events_keys
..


Patch Set 2:

The problem is on EL7 as well and I do not think it was limited to this 'neigh' 
event.

-- 
To view, visit https://gerrit.ovirt.org/63406
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1e9b84ebb68a881bed6a0c97a23ee4c6896434
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: introducting broken_on_ci decorator

2016-09-06 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/63407/9/tests/testValidation.py
File tests/testValidation.py:

Line 141: try:
Line 142: return f(*args, **kwargs)
Line 143: except:
Line 144: # TODO: Make a more appropriate ENV variable 
available on CI.
Line 145: if os.environ.get('FAKE_GERRIT_USERNAME'):
> This is too fragile, better check env variable *we* set when running the te
+1
Line 146: raise SkipTest(msg)
Line 147: else:
Line 148: raise
Line 149: return wrapper


-- 
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: fix testGetBondingOptions

2016-09-06 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: tests: fix testGetBondingOptions
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/63424/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2016-09-06 16:15:53 +0200
Line 6: 
Line 7: tests: fix testGetBondingOptions
Line 8: 
Line 9: Bonding options are reported only if they differ from defaults.
I do not understand how it worked so far.
If the mode was reported, how did the test pass so far?
What has changed?
Line 10: Bond 'mode' is exceptional, it is reported always. We are not
Line 11: interested in this one as it may differ from machine to machine.
Line 12: 
Line 13: With this path we introduce new helper method which hides 'mode'


-- 
To view, visit https://gerrit.ovirt.org/63424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Refresh base volume before live merge

2016-09-06 Thread Jenkins CI 
Jenkins CI has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/63454
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Refresh base volume before live merge

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2:

* #1367281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367281::OK, public bug
* Check Product::#1367281::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63454
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Refresh base volume before live merge

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: core: Refresh base volume before live merge
..


Patch Set 1:

* #1367281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367281::OK, public bug
* Check Product::#1367281::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63454
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: core: Refresh base volume before live merge

2016-09-06 Thread ahino 
Ala Hino has uploaded a new change for review.

Change subject: core: Refresh base volume before live merge
..

core: Refresh base volume before live merge

When performing live merge where the base volume format is RAW,
i.e. there is a single snapshot and it is live merged, we have to
refresh the volume before performing the live merge. This is
needed because extending the base volume is done on the SPM and
refresh volume will cause other hosts to refresh the volume to get
the new size. Not doing so may end up with libvirt error
indicating that top volume size is larger than base volume, which
exactly what happened in the reported BZ.

Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Bug-Url: https://bugzilla.redhat.com/1367281
Signed-off-by: Ala Hino 
---
M vdsm/virt/vm.py
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/63454/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 9cfa4a3..01b5d21 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4433,6 +4433,18 @@
 if not self._can_merge_into(drive, baseInfo, topInfo):
 return errCode['destVolumeTooSmall']
 
+# If the base volume format is RAW, we have to refresh the volume
+# in order to enforce other hosts to load new volume size. Not
+# doing so may end up with error that top volume size is larger
+# base volume size. This could happen if disk extended after taking
+# a snapshot but before performing the live merge.
+# See https://bugzilla.redhat.com/1367281
+if drive.chunked and baseInfo['format'] == 'RAW':
+self.__refreshDriveVolume({
+'domainID': drive.domainID, 'poolID': drive.poolID,
+'imageID': drive.imageID, 'volumeID': baseVolUUID,
+})
+
 # Take the jobs lock here to protect the new job we are tracking from
 # being cleaned up by queryBlockJobs() since it won't exist right away
 with self._jobsLock:


-- 
To view, visit https://gerrit.ovirt.org/63454
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

2016-09-06 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 10: Code-Review+2

Thanks Leon!

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: introducting broken_on_ci decorator

2016-09-06 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/63407/9/tests/testValidation.py
File tests/testValidation.py:

Line 141: try:
Line 142: return f(*args, **kwargs)
Line 143: except:
Line 144: # TODO: Make a more appropriate ENV variable 
available on CI.
Line 145: if os.environ.get('FAKE_GERRIT_USERNAME'):
This is too fragile, better check env variable *we* set when running the tests 
on the ci (add it when we run the tests in automation/check-patch.sh).
Line 146: raise SkipTest(msg)
Line 147: else:
Line 148: raise
Line 149: return wrapper


-- 
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

2016-09-06 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

2016-09-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 6: Code-Review+2

raising Yaniv's score

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

2016-09-06 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Adding build-artifacts-manual.sh script

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62559
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70ed044ff9c8bc89c75e6c5e3669373468fadc1c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

2016-09-06 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Adding build-artifacts-manual.sh script

2016-09-06 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62559
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70ed044ff9c8bc89c75e6c5e3669373468fadc1c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: Adding build-artifacts-manual.sh script

2016-09-06 Thread ybronhei 
Yaniv Bronhaim has submitted this change and it was merged.

Change subject: Adding build-artifacts-manual.sh script
..


Adding build-artifacts-manual.sh script

Adding build-artifacts-manual.sh script and related
packages and repos files.
build-artifacts-manual.sh is used for creating rpms from an
existing tarball. It assumes that the tarball already exists
in the projects directory and builds srpms and rpms, and moves
the files to exported_artifacts directory.
See more info here: https://gerrit.ovirt.org/#/c/62811/

Change-Id: I70ed044ff9c8bc89c75e6c5e3669373468fadc1c
Signed-off-by: Sharon Naftaly 
Reviewed-on: https://gerrit.ovirt.org/62559
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
---
A automation/build-artifacts-manual.packages.el7
A automation/build-artifacts-manual.packages.fc23
A automation/build-artifacts-manual.repos.el7
A automation/build-artifacts-manual.repos.fc23
A automation/build-artifacts-manual.sh
5 files changed, 40 insertions(+), 0 deletions(-)

Approvals:
  Sharon Naftaly: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62559
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I70ed044ff9c8bc89c75e6c5e3669373468fadc1c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

2016-09-06 Thread ybronhei 
Yaniv Bronhaim has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: report device MMIO numa node

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: report device MMIO numa node
..


Patch Set 11:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60637
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2995b68465caa52f6c721ed5af7d537748fa647a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: move condition from appendNumaTune to buildDomainXML

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61929
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7141cfe8d5ed086dde884234990a3c00ddca2092
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: prefer numa nodes close to device MMIO
..


Patch Set 12:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60640
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bc795d2f5bad76ebf1e1bff391b3bc71037fffb
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: introducting broken_on_ci decorator

2016-09-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: properly set is_hostdevice

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: properly set is_hostdevice
..


Patch Set 5:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62064
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4b70f698fb1e6d8a8adec650d5a91d8c8736676
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: expose numa_node in host device

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hostdev: expose numa_node in host device
..


Patch Set 11:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60638
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4584b99dfbff8b2e61f4f73ad58e3b67bf0c55ce
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: devices: add is_hostdevice attribute

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: devices: add is_hostdevice attribute
..


Patch Set 5:

* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Product::#1356161::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62063
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd5c42b371d9bf0eafd99e8ad880f3f97b444e75
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - preserve original slaves link state.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - preserve original slaves link state.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia98d01512322f88bf9819532afb2ea337cee7749
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - adding a transaction context.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - adding a transaction context.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63443
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d015ed235c3620c04131e57ad079a2ec1a0ecc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - add refresh method to update bond config

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - add refresh method to update bond config
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63445
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f36cc24833b0fc612c3af033c54c7bca4742a5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose owned_device method through the configurator

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Expose owned_device method through the configurator
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - Add logging to the bond driver.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - Add logging to the bond driver.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043a6232d59cd87f6b973d856df297322f4be387
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose disable IPv6 through ip.address module

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Expose disable IPv6 through ip.address module
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62830
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0673da939d575ab43d53cdb1fced4273db05e6c7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Introduce iface.exists and start using it in ip.dhclient

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcece92726e7ef354b4792aee73bfc90fa5f3133
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose owned_device method through the configurator

2016-09-06 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: net: Expose owned_device method through the configurator
..

net: Expose owned_device method through the configurator

Provide means to check if a device is owned by VDSM specific driver.
In this case, by the ifcfg configurator.

It will be used by a following patch to determine if the device is being
used by the Linux switch.

Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/configurators/ifcfg.py
2 files changed, 21 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/63442/1

diff --git a/lib/vdsm/network/configurators/__init__.py 
b/lib/vdsm/network/configurators/__init__.py
index 43ddec9..525f3e6 100644
--- a/lib/vdsm/network/configurators/__init__.py
+++ b/lib/vdsm/network/configurators/__init__.py
@@ -97,6 +97,10 @@
 def removeSourceRoute(self, routes, rules, device):
 raise NotImplementedError
 
+@staticmethod
+def owned_device(device):
+raise NotImplementedError
+
 def configureLibvirtNetwork(self, network, iface):
 self.configApplier.createLibvirtNetwork(network,
 isinstance(iface, Bridge),
diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index 2302ae1..8eb681e 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -69,6 +69,8 @@
 NET_CONF_PREF = NET_CONF_DIR + 'ifcfg-'
 NET_LOGICALNET_CONF_BACK_DIR = NET_CONF_BACK_DIR + 'logicalnetworks/'
 
+CONFFILE_HEADER_SIGNATURE = '# Generated by VDSM version'
+
 
 def is_available():
 return True
@@ -282,11 +284,23 @@
 self._removeSourceRouteFile('rule', device)
 self._removeSourceRouteFile('route', device)
 
+@staticmethod
+def owned_device(device):
+try:
+with open(misc.NET_CONF_PREF + device) as conf:
+content = conf.read()
+except IOError as ioe:
+if ioe.errno == errno.ENOENT:
+return False
+else:
+raise
+else:
+return content.startswith(CONFFILE_HEADER_SIGNATURE)
+
 
 class ConfigWriter(object):
-CONFFILE_HEADER_BASE = '# Generated by VDSM version'
-CONFFILE_HEADER = CONFFILE_HEADER_BASE + ' %s' % \
-dsaversion.raw_version_revision
+CONFFILE_HEADER = (CONFFILE_HEADER_SIGNATURE + ' ' +
+   dsaversion.raw_version_revision)
 DELETED_HEADER = '# original file did not exist'
 
 def __init__(self, unifiedPersistence=False):


-- 
To view, visit https://gerrit.ovirt.org/63442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - preserve original slaves link state.

2016-09-06 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: net: Bond - preserve original slaves link state.
..

net: Bond - preserve original slaves link state.

Before attaching or removing a slave from a bond, its state is set to
DOWN.
This patch makes sure to preserve its original state, even when failure
occurs.
(Without it, the link may be set to DOWN, even if the slave has not been
added to the bond)

Change-Id: Ia98d01512322f88bf9819532afb2ea337cee7749
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/link/bond.py
1 file changed, 19 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/63446/1

diff --git a/lib/vdsm/network/link/bond.py b/lib/vdsm/network/link/bond.py
index d45e139..9911ad9 100644
--- a/lib/vdsm/network/link/bond.py
+++ b/lib/vdsm/network/link/bond.py
@@ -19,6 +19,7 @@
 from __future__ import absolute_import
 
 import abc
+from contextlib import contextmanager
 import logging
 import os
 import six
@@ -149,18 +150,20 @@
 
 def add_slaves(self, slaves):
 for slave in slaves:
-iface.down(slave)
-with open(self.BONDING_SLAVES % self._master, 'w') as f:
-f.write('+%s' % slave)
+with _preserve_iface_state(slave):
+iface.down(slave)
+with open(self.BONDING_SLAVES % self._master, 'w') as f:
+f.write('+%s' % slave)
 logging.info('Slave {} has been added to bond {}.'.format(
 slave, self._master))
 self._slaves.add(slave)
 
 def del_slaves(self, slaves):
 for slave in slaves:
-iface.down(slave)
-with open(self.BONDING_SLAVES % self._master, 'w') as f:
-f.write('-%s' % slave)
+with _preserve_iface_state(slave):
+iface.down(slave)
+with open(self.BONDING_SLAVES % self._master, 'w') as f:
+f.write('-%s' % slave)
 logging.info('Slave {} has been removed from bond {}.'.format(
 slave, self._master))
 self._slaves.remove(slave)
@@ -206,6 +209,16 @@
 # a reasonable scenario and leave it to upper levels to handle it.
 
 
+@contextmanager
+def _preserve_iface_state(dev):
+dev_was_up = iface.is_up(dev)
+try:
+yield
+finally:
+if dev_was_up and not iface.is_up(dev):
+iface.up(dev)
+
+
 # TODO: Use a configuration parameter to determine which driver to use.
 def _bond_driver():
 """


-- 
To view, visit https://gerrit.ovirt.org/63446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia98d01512322f88bf9819532afb2ea337cee7749
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: dhclient - address flush before starting and on shutdown
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - adding a transaction context.

2016-09-06 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: net: Bond - adding a transaction context.
..

net: Bond - adding a transaction context.

The bond transaction context is aimed to keep bonds in a controlled
state when adding, editing and removing bonds.

Specifically, it is targeted to handle the following scenario:
- Create bond99 - Success
- Add slave88   - Success
- Add slave-bad - Failure
In the creation of bond99, adding a slave failed, leaving a partial bond
configured.
When setting the bond in a transaction, bond99 will be removed before
re-raising the exception.

Change-Id: If8d015ed235c3620c04131e57ad079a2ec1a0ecc
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/link/bond.py
M tests/network/link_bond_test.py
2 files changed, 56 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/63443/1

diff --git a/lib/vdsm/network/link/bond.py b/lib/vdsm/network/link/bond.py
index fe69433..1a2b5d0 100644
--- a/lib/vdsm/network/link/bond.py
+++ b/lib/vdsm/network/link/bond.py
@@ -37,6 +37,12 @@
 if self.exists():
 self._import_existing()
 
+def __enter__(self):
+return self
+
+def __exit__(self, type, value, traceback):
+pass
+
 @abc.abstractmethod
 def create(self):
 pass
@@ -112,6 +118,16 @@
 def __init__(self, name, slaves=(), options=None):
 super(BondSysFS, self).__init__(name, slaves, options)
 
+def __enter__(self):
+self._init_exists = self.exists()
+self._init_slaves = self._slaves
+self._init_options = self._options
+return self
+
+def __exit__(self, ex_type, ex_value, traceback):
+if ex_type is not None:
+self._revert_transaction()
+
 def create(self):
 with open(self.BONDING_MASTERS, 'w') as f:
 f.write('+%s' % self._master)
@@ -160,6 +176,21 @@
 # TODO: Support options
 self._options = None
 
+def _revert_transaction(self):
+if self.exists():
+# Did not exist, partially created (some slaves failed to be added)
+if not self._init_exists:
+self.destroy()
+# Existed, failed on some editing (slaves or options editing)
+else:
+slaves2remove = self._slaves - self._init_slaves
+slaves2add = self._init_slaves - self._slaves
+self.del_slaves(slaves2remove)
+self.add_slaves(slaves2add)
+# TODO: Options support
+# We assume that a non existing bond with a failed transaction is not
+# a reasonable scenario and leave it to upper levels to handle it.
+
 
 # TODO: Use a configuration parameter to determine which driver to use.
 def _bond_driver():
diff --git a/tests/network/link_bond_test.py b/tests/network/link_bond_test.py
index 39077d2..44da399 100644
--- a/tests/network/link_bond_test.py
+++ b/tests/network/link_bond_test.py
@@ -76,6 +76,31 @@
 bond_list = Bond.bonds()
 self.assertItemsEqual([b1.master, b2.master, b3.master], bond_list)
 
+def test_bond_create_failure_on_slave_add(self):
+with dummy_devices(2) as (nic1, nic2):
+with bond_device() as base_bond:
+base_bond.add_slaves((nic1, nic2))
+
+bond_name = random_iface_name('bond_', max_length=11)
+with self.assertRaises(IOError):
+with Bond(bond_name) as broken_bond:
+broken_bond.create()
+broken_bond.add_slaves((nic1, nic2))
+self.assertFalse(Bond(bond_name).exists())
+
+def test_bond_edit_failure_on_slave_add(self):
+with dummy_devices(2) as (nic1, nic2):
+with bond_device() as base_bond, bond_device() as edit_bond:
+base_bond.add_slaves((nic1,))
+edit_bond.add_slaves((nic2,))
+
+with self.assertRaises(IOError):
+with Bond(edit_bond.master) as broken_bond:
+self.assertTrue(broken_bond.exists())
+broken_bond.add_slaves((nic1,))
+self.assertTrue(edit_bond.exists())
+self.assertEqual(set((nic2,)), edit_bond.slaves)
+
 
 @contextmanager
 def bond_device(prefix='bond_', max_length=11):


-- 
To view, visit https://gerrit.ovirt.org/63443
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8d015ed235c3620c04131e57ad079a2ec1a0ecc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient kill - early exit if iface does not exists

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: dhclient kill - early exit if iface does not exists
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - Add logging to the bond driver.

2016-09-06 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: net: Bond - Add logging to the bond driver.
..

net: Bond - Add logging to the bond driver.

Change-Id: I043a6232d59cd87f6b973d856df297322f4be387
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/link/bond.py
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/63444/1

diff --git a/lib/vdsm/network/link/bond.py b/lib/vdsm/network/link/bond.py
index 1a2b5d0..d91e496 100644
--- a/lib/vdsm/network/link/bond.py
+++ b/lib/vdsm/network/link/bond.py
@@ -19,6 +19,7 @@
 from __future__ import absolute_import
 
 import abc
+import logging
 import os
 import six
 
@@ -126,23 +127,29 @@
 
 def __exit__(self, ex_type, ex_value, traceback):
 if ex_type is not None:
+logging.info('Bond {} transaction failed, reverting...'.format(
+self._master))
 self._revert_transaction()
 
 def create(self):
 with open(self.BONDING_MASTERS, 'w') as f:
 f.write('+%s' % self._master)
+logging.info('Bond {} has been created.'.format(self._master))
 if self._slaves:
 self.add_slaves(self._slaves)
 
 def destroy(self):
 with open(self.BONDING_MASTERS, 'w') as f:
 f.write('-%s' % self._master)
+logging.info('Bond {} has been destroyed.'.format(self._master))
 
 def add_slaves(self, slaves):
 for slave in slaves:
 iface.down(slave)
 with open(self.BONDING_SLAVES % self._master, 'w') as f:
 f.write('+%s' % slave)
+logging.info('Slave {} has been added to bond {}.'.format(
+slave, self._master))
 self._slaves.add(slave)
 
 def del_slaves(self, slaves):
@@ -150,6 +157,8 @@
 iface.down(slave)
 with open(self.BONDING_SLAVES % self._master, 'w') as f:
 f.write('-%s' % slave)
+logging.info('Slave {} has been removed from bond {}.'.format(
+slave, self._master))
 self._slaves.remove(slave)
 
 def set_options(self, options):
@@ -157,6 +166,7 @@
 for key, value in options:
 with open(self.BONDING_OPT % (self._master, key), 'w') as f:
 f.write(value)
+logging.info('Bond {} options set: {}.'.format(self._master, options))
 
 def exists(self):
 return os.path.exists(self.BONDING_PATH % self._master)


-- 
To view, visit https://gerrit.ovirt.org/63444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I043a6232d59cd87f6b973d856df297322f4be387
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - Use request options to control the default r...

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: dhclient - Use request options to control the default route
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63085
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5698c905992028980f28ba3e9eecfcdfdbfd51ef
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - Expose the (kernel) bond list.

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: Bond - Expose the (kernel) bond list.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba2b9d5ec712b268cc3775682506ec83aabbdb8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - add refresh method to update bond config

2016-09-06 Thread edwardh 
Edward Haas has uploaded a new change for review.

Change subject: net: Bond - add refresh method to update bond config
..

net: Bond - add refresh method to update bond config

Change-Id: I6f36cc24833b0fc612c3af033c54c7bca4742a5a
Signed-off-by: Edward Haas 
---
M lib/vdsm/network/link/bond.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/63445/1

diff --git a/lib/vdsm/network/link/bond.py b/lib/vdsm/network/link/bond.py
index d91e496..d45e139 100644
--- a/lib/vdsm/network/link/bond.py
+++ b/lib/vdsm/network/link/bond.py
@@ -97,6 +97,10 @@
 def down(self):
 self._setlinks(up=False)
 
+def refresh(self):
+if self.exists():
+self._import_existing()
+
 @abc.abstractmethod
 def _import_existing(self):
 pass


-- 
To view, visit https://gerrit.ovirt.org/63445
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f36cc24833b0fc612c3af033c54c7bca4742a5a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: ifcfg - dhclient should always be stopped

2016-09-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: ifcfg - dhclient should always be stopped
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60930670b335d02e3878743409fd2e5f4b3e26b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: fix test_events_keys

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net tests: fix test_events_keys
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63406
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1e9b84ebb68a881bed6a0c97a23ee4c6896434
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: fix test_events_keys

2016-09-06 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: net tests: fix test_events_keys
..


net tests: fix test_events_keys

On Jenkins CI Fedora 23 this test sometimes fails because of missing
del_neigh event. It is not needed and we can drop it from expected
events.

Change-Id: I5a1e9b84ebb68a881bed6a0c97a23ee4c6896434
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/63406
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M tests/network/netlink_test.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63406
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a1e9b84ebb68a881bed6a0c97a23ee4c6896434
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: Remove unneeded multipath call

2016-09-06 Thread frolland 
Freddy Rolland has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 1:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: Remove unneeded multipath call

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 1:

* #1303578::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1303578::OK, public bug
* Check Product::#1303578::OK, Correct classification oVirt
* Check TM::#1303578::OK, correct target milestone ovirt-4.0.4
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

2016-09-06 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 5: Verified+1

passes on jenkins
http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/24/

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: fix testGetBondingOptions

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: fix testGetBondingOptions
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: introducting broken_on_ci decorator

2016-09-06 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 9: Verified+1

When a tests fails on Jenkins it is skipped, if it fails on non-Jenkins it 
raises an Exception.

-- 
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: Remove unneeded multipath call

2016-09-06 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 1: Code-Review+1

Please check why jenkins is unhappy.

-- 
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: introducting broken_on_ci decorator

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: introducting broken_on_ci decorator

2016-09-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 8:

Please mark the failing

ERROR: test_local_auto_with_dynamic_address_from_ra 
(network.netinfo_test.TestIPv6Addresses)

with your new decorator

-- 
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: fix testGetBondingOptions

2016-09-06 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: tests: fix testGetBondingOptions
..


Patch Set 1: Verified+1

The test now passes OK.

-- 
To view, visit https://gerrit.ovirt.org/63424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: introducting broken_on_ci decorator

2016-09-06 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: tests: introducting broken_on_ci decorator
..


Patch Set 8: Verified+1

When a tests fails on Jenkins it is skipped, if it fails on non-Jenkins it 
raises an Exception.

-- 
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I837fe23c9fcd461dc305c4c26cad759f8efa9f94
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: fix test_events_keys

2016-09-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net tests: fix test_events_keys
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63406
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1e9b84ebb68a881bed6a0c97a23ee4c6896434
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: fix test_events_keys

2016-09-06 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: net tests: fix test_events_keys
..


Patch Set 1: Verified+1

Test passes now.

-- 
To view, visit https://gerrit.ovirt.org/63406
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a1e9b84ebb68a881bed6a0c97a23ee4c6896434
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: Remove unneeded multipath call

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 1:

* #1303578::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1303578::OK, public bug
* Check Product::#1303578::OK, Correct classification oVirt
* Check TM::#1303578::OK, correct target milestone ovirt-4.0.4
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: storage: Remove unneeded multipath call

2016-09-06 Thread frolland 
Hello Fred Rolland,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/63427

to review the following change.

Change subject: storage: Remove unneeded multipath call
..

storage: Remove unneeded multipath call

As part of multipath rescan, we call iscsi and hba rescan.
These operations are sufficient to discover new devices and
detect changes in size.
Therefore, the multipath call is not needed and can be removed
improving the overall performance of GetDeviceList verb.
Also, the multipath call is risky as it may get stuck.

Detailed profiling :
time filename:lineno(function)
3.178 |hsm.py:1948(HSM._getDeviceList)
1.546 |--> sdc.py:80(StorageDomainCache.refreshStorage)
1.489 |--> multipath.py:65(rescan)
0.481 |--> iscsi.py:431(rescan) iscsi scan
0.076 |--> storage/hba.py:53(rescan)   fc scan
0.912 |--> multipath.py:88(multipath)  multipath
0.056 |--> multipath.py:92(resize_devices)
0.756 |--> lvm.py:843(getAllPVs)
0.756 |--> lvm.py:317(LVMCache._reloadpvs)
0.755 |--> lvm.py:290(LVMCache.cmd)pvs
0.871 |--> multipath.py:213(pathListIter)
0.029 |-->devicemapper.py:176(getPathsStatus) dmsetup status

Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Bug-Url: https://bugzilla.redhat.com/1303578
Signed-off-by: Fred Rolland 
---
M vdsm/storage/multipath.py
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/63427/1

diff --git a/vdsm/storage/multipath.py b/vdsm/storage/multipath.py
index 5c0bab6..83352c2 100644
--- a/vdsm/storage/multipath.py
+++ b/vdsm/storage/multipath.py
@@ -30,7 +30,6 @@
 from collections import namedtuple
 
 from vdsm import commands
-from vdsm import constants
 from vdsm import supervdsm
 from vdsm import udevadm
 from vdsm import utils
@@ -73,9 +72,6 @@
 # First rescan iSCSI and FCP connections
 iscsi.rescan()
 hba.rescan()
-
-# Now let multipath daemon pick up new devices
-misc.execCmd([constants.EXT_MULTIPATH], sudo=True)
 
 # Scanning SCSI interconnects starts a storm of udev events. Wait until all
 # events are processed, ensuring detection of new devices and creation or


-- 
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: fix testGetBondingOptions

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: fix testGetBondingOptions
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: fix Host.getVMList command result

2016-09-06 Thread igoihman 
Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: fix Host.getVMList command result
..


Patch Set 2: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/63408/1/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 360: 'Host_getStorageDomains': {'ret': 'domlist'},
Line 361: 'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
Line 362: 'Host_hostdevListByCaps': {'ret': 'deviceList'},
Line 363: 'Host_getVMList': {'call': Host_getVMList_Call,
Line 364:'ret': Host_getVMList_Ret},
> Please keep formatting as it is in this module.
Done
Line 365: 'Host_getVMFullList': {'call': Host_getVMFullList_Call,
Line 366:'ret': Host_getVMList_Ret},
Line 367: 'Host_getAllVmStats': {'ret': 'statsList'},
Line 368: 'Host_setupNetworks': {'ret': 'status'},


-- 
To view, visit https://gerrit.ovirt.org/63408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28f39417b0006957670bb6ccbdb673f2e0f89043
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: fix testGetBondingOptions

2016-09-06 Thread phoracek 
Petr Horáček has uploaded a new change for review.

Change subject: tests: fix testGetBondingOptions
..

tests: fix testGetBondingOptions

Bonding options are reported only if they differ from defaults.
Bond 'mode' is exceptional, it is reported always. We are not
interested in this one as it may differ from machine to machine.

With this path we introduce new helper method which hides 'mode'
option.

Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee
Signed-off-by: Petr Horáček 
---
M tests/network/netinfo_test.py
1 file changed, 11 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/63424/1

diff --git a/tests/network/netinfo_test.py b/tests/network/netinfo_test.py
index dc70a2f..d8ee47a 100644
--- a/tests/network/netinfo_test.py
+++ b/tests/network/netinfo_test.py
@@ -248,20 +248,27 @@
 
 try:  # no error is anticipated but let's make sure we can clean up
 self.assertEqual(
-bonding._getBondingOptions(bondName), {}, "This test fails"
-" when a new bonding option is added to the kernel. Please"
-" run vdsm-tool dump-bonding-options` and retest.")
+self._bond_opts_without_mode(bondName), {},
+'This test fails when a new bonding option is added to '
+'the kernel. Please run vdsm-tool dump-bonding-options` '
+'and retest.')
 
 with open(bonding.BONDING_OPT % (bondName, 'miimon'),
   'w') as opt:
 opt.write(INTERVAL)
 
-self.assertEqual(bonding._getBondingOptions(bondName),
+self.assertEqual(self._bond_opts_without_mode(bondName),
  {'miimon': INTERVAL})
 
 finally:
 bonds.write('-' + bondName)
 
+@staticmethod
+def _bond_opts_without_mode(bond_name):
+opts = bonding._getBondingOptions(bond_name)
+opts.pop('mode')
+return opts
+
 def test_get_bonding_option_numeric_val_exists(self):
 mode_num = bonding.BONDING_MODES_NAME_TO_NUMBER["balance-rr"]
 self.assertNotEqual(bonding.get_bonding_option_numeric_val(


-- 
To view, visit https://gerrit.ovirt.org/63424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If60c2e4fadf470e2325eb6014a6ddf051499b3ee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check-merged: switch fc24 to el7

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: check-merged: switch fc24 to el7
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: mom: create the socket under tmpdir

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: mom: create the socket under tmpdir
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62779
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: mom: create the socket under tmpdir

2016-09-06 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: mom: create the socket under tmpdir
..


tests: mom: create the socket under tmpdir

Some tests may fail under automation if Vdsm
is built and its test are run under a too nested
directory.
This because the absolute path of the UNIX domain
socket becomes too long.

To fix this, we create the socket under a temporary
directory.
This also makes cleanup a little easier.

Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/62779
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Roman Mohr 
Reviewed-by: Martin Sivák 
Reviewed-by: Dan Kenigsberg 
---
M tests/momTests.py
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Roman Mohr: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/62779
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: mom: create the socket under tmpdir

2016-09-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: tests: mom: create the socket under tmpdir
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62779
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Remove unneeded multipath call

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: storage: Remove unneeded multipath call
..


Patch Set 3:

* #1303578::Update tracker: OK
* Set MODIFIED::bug 1303578#1303578::IGNORE, skipping for branch 'master'

-- 
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Remove unneeded multipath call

2016-09-06 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: storage: Remove unneeded multipath call
..


storage: Remove unneeded multipath call

As part of multipath rescan, we call iscsi and hba rescan.
These operations are sufficient to discover new devices and
detect changes in size.
Therefore, the multipath call is not needed and can be removed
improving the overall performance of GetDeviceList verb.
Also, the multipath call is risky as it may get stuck.

Detailed profiling :
time filename:lineno(function)
3.178 |hsm.py:1948(HSM._getDeviceList)
1.546 |--> sdc.py:80(StorageDomainCache.refreshStorage)
1.489 |--> multipath.py:65(rescan)
0.481 |--> iscsi.py:431(rescan) iscsi scan
0.076 |--> storage/hba.py:53(rescan)   fc scan
0.912 |--> multipath.py:88(multipath)  multipath
0.056 |--> multipath.py:92(resize_devices)
0.756 |--> lvm.py:843(getAllPVs)
0.756 |--> lvm.py:317(LVMCache._reloadpvs)
0.755 |--> lvm.py:290(LVMCache.cmd)pvs
0.871 |--> multipath.py:213(pathListIter)
0.029 |-->devicemapper.py:176(getPathsStatus) dmsetup status

Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Bug-Url: https://bugzilla.redhat.com/1303578
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/59865
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M vdsm/storage/multipath.py
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/59865
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie99da5ad7ec46f4a69a3d09a811e875d5e3a5b44
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc: Remove log skipping infrastructure

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: misc: Remove log skipping infrastructure
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63267
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I714104458fb3794237c46548068b0842301404e5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc: Remove log skipping infrastructure

2016-09-06 Thread nsoffer 
Nir Soffer has submitted this change and it was merged.

Change subject: misc: Remove log skipping infrastructure
..


misc: Remove log skipping infrastructure

We had complex and expensive code for logging the caller of
resource manager requests. It was originally introduced in order to 
help debug culprits of deadlocks. Such deadlocks have not been seen for
years.

Other complex code was added so that logging in a common helper function
would rather use the line number of the helper function's caller, since
the latter is the more useful for debugging (rhbz#572050). @logskip was 
ever used very seldom (though using it more might have improved our 
code).

The code is not very important, yet it too complex and a pain to
maintain or port to Python 3. Let us drop it now.

This feature is not needed and I don't want
to maintain this code on both Python 2 and 3.

Change-Id: I714104458fb3794237c46548068b0842301404e5
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/63267
Continuous-Integration: Jenkins CI
Reviewed-by: Allon Mureinik 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Adam Litke 
---
M lib/vdsm/storage/misc.py
M tests/miscTests.py
M vdsm/storage/blockVolume.py
M vdsm/storage/resourceManager.py
M vdsm/storage/task.py
5 files changed, 4 insertions(+), 144 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63267
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I714104458fb3794237c46548068b0842301404e5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc: Remove log skipping infrastructure

2016-09-06 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: misc: Remove log skipping infrastructure
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/63267/3//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: We had complex code and expensive code for logging the caller of
Line 10: resource manager requests.  This feature is not needed and I don't want
Line 11: to maintain this code on both Python 2 and 3.
Line 12: 
> Historically, the caller of resource manager request was added in order to 
Thanks for updating the commit message.
Line 13: Change-Id: I714104458fb3794237c46548068b0842301404e5


-- 
To view, visit https://gerrit.ovirt.org/63267
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I714104458fb3794237c46548068b0842301404e5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

2016-09-06 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: Adding build-artifacts-manual.sh script
..


Adding build-artifacts-manual.sh script

Adding build-artifacts-manual.sh script and related
packages and repos files.
build-artifacts-manual.sh is used for creating rpms from an
existing tarball. It assumes that the tarball already exists
in the projects directory and builds srpms and rpms, and
moves the files to exported_artifacts directory.
See more info here: https://gerrit.ovirt.org/#/c/62811/

Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Signed-off-by: Sharon Naftaly 
Reviewed-on: https://gerrit.ovirt.org/62560
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Eyal Edri 
Reviewed-by: Dan Kenigsberg 
---
A automation/build-artifacts-manual.packages.el7
A automation/build-artifacts-manual.packages.fc24
A automation/build-artifacts-manual.repos.el7
A automation/build-artifacts-manual.repos.fc24
A automation/build-artifacts-manual.sh
5 files changed, 39 insertions(+), 0 deletions(-)

Approvals:
  Sharon Naftaly: Verified
  Eyal Edri: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Adding build-artifacts-manual.sh script

2016-09-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: Adding build-artifacts-manual.sh script
..


Patch Set 7: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3962bfd45b651323a54c04cac6fdb5e844a78f7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: mom: create the socket under tmpdir

2016-09-06 Thread ybronhei 
Yaniv Bronhaim has submitted this change and it was merged.

Change subject: tests: mom: create the socket under tmpdir
..


tests: mom: create the socket under tmpdir

Some tests may fail under automation if Vdsm
is built and its test are run under a too nested
directory.
This because the absolute path of the UNIX domain
socket becomes too long.

To fix this, we create the socket under a temporary
directory.
This also makes cleanup a little easier.

Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/63129
Continuous-Integration: Jenkins CI
Tested-by: Sharon Naftaly 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Irit Goihman 
Reviewed-by: Martin Sivák 
Reviewed-by: Eyal Edri 
---
M tests/momTests.py
1 file changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Sharon Naftaly: Verified
  Eyal Edri: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: tests: mom: create the socket under tmpdir

2016-09-06 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: tests: mom: create the socket under tmpdir
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63129
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib41253a58e8abadeb99d57072ace75461a8e078b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sharon Naftaly 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Sharon Naftaly 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

  1   2   >