Change in vdsm[master]: tests: Rename lvmTests to new naming convention

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Rename lvmTests to new naming convention
..


Patch Set 5:

Ping

-- 
To view, visit https://gerrit.ovirt.org/64328
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: guest-lvs: Add lvm bootstrap tests
..


Patch Set 8: Code-Review-1

(7 comments)

https://gerrit.ovirt.org/#/c/64367/8/tests/storage_lvm_test.py
File tests/storage_lvm_test.py:

Line 56: 
Line 57: 
Line 58: class TestDeactivation(TestCaseBase):
Line 59: 
Line 60: @ValidateRunningAsRoot
Need to mark this broken_on_ci for now.
Line 61: def test_deactivate_unused_ovirt_lvs(self):
Line 62: with fake_env() as env:
Line 63: log.debug("Creating ovirt lvs")
Line 64: run("pvcreate", "-ff", env.device)


Line 60: @ValidateRunningAsRoot
Line 61: def test_deactivate_unused_ovirt_lvs(self):
Line 62: with fake_env() as env:
Line 63: log.debug("Creating ovirt lvs")
Line 64: run("pvcreate", "-ff", env.device)
lvm commands should use global_filter limiting the operations to the test 
devices.

Maybe add helpers in the env:

env.create_pv(force=True, env.devices[0])
Line 65: run("vgcreate", "ovirt-vg", env.device)
Line 66: run("vgchange", "--addtag", blockSD.STORAGE_DOMAIN_TAG)
Line 67: run("lvcreate", "-n", "ovirt-lv-1", "-L", "128m", 
"ovirt-vg")
Line 68: run("lvcreate", "-n", "ovirt-lv-2", "-L", "128m", 
"ovirt-vg")


Line 70: lvm.bootstrap()
Line 71: # ovirt-lv must be inactive
Line 72: self.assertEqual(self.find_active_lvs("ovirt-vg"), [])
Line 73: finally:
Line 74: run("vgchange", "-an", "ovirt-vg")
The environment should keep created vgs and deactivate them.
Line 75: 
Line 76: # TODO: do not modify vgs without STORAGE_DOMAIN_TAG
Line 77: 
Line 78: def find_active_lvs(self, vgname):


Line 77: 
Line 78: def find_active_lvs(self, vgname):
Line 79: out = run("lvs", "--noheadings", "-o", "name",
Line 80:   "--select", "lv_active=active", vgname)[0]
Line 81: return [line.strip() for line in out.splitlines()]
The environment should provide such helpers, so we can write:

active_lvs = env.list_lvs(where="ovirt-vg", select="lv_active=active", 
output="name")
Line 82: 
Line 83: 
Line 84: def run(*cmd):
Line 85: rc, out, err = commands.execCmd(cmd, raw=True)


Line 84: def run(*cmd):
Line 85: rc, out, err = commands.execCmd(cmd, raw=True)
Line 86: if rc != 0:
Line 87: raise cmdutils.Error(cmd, rc, out, err)
Line 88: return out, err
Return out, err is interesting only on errors.
Line 89: 
Line 90: 
Line 91: try:
Line 92: run("systemctl", "status", "lvm2-lvmetad.socket")


Line 95: else:
Line 96: using_lvmetad = True
Line 97: 
Line 98: 
Line 99: Env = collections.namedtuple("Env", "tmpdir, device")
Replace with real class that provide lvm helpers, using devices to add filter 
to lvm commands.
Line 100: 
Line 101: 
Line 102: @contextmanager
Line 103: def fake_env():


Line 108: backing_file = os.path.join(tmpdir, "backing_file")
Line 109: with open(backing_file, "w") as f:
Line 110: f.truncate(1024**3)
Line 111: try:
Line 112: with loop.Device(backing_file) as device:
We need to support may devices for more interesting tests.
Line 113: log.debug("Using loop device %s", device.path)
Line 114: with MonkeyPatchScope([
Line 115: # Created during bootstrap.
Line 116: (lvm, "VDSM_LVM_SYSTEM_DIR",


-- 
To view, visit https://gerrit.ovirt.org/64367
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Add loop module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Add loop module
..


Patch Set 5: Code-Review-1

(6 comments)

Needs more work to be useful for more interesting lvm tests.

https://gerrit.ovirt.org/#/c/64329/5/tests/loop.py
File tests/loop.py:

Line 31: 
Line 32: log = logging.getLogger("test")
Line 33: 
Line 34: 
Line 35: class Device(object):
Rename to open()?

with loop.open("backing_file"):
...

And maybe convert to function?
Line 36: 
Line 37: def __init__(self, backing_file):
Line 38: self._backing_file = backing_file
Line 39: self._path = None


Line 39: self._path = None
Line 40: 
Line 41: @property
Line 42: def path(self):
Line 43: return self._path
Can be returned by the context manager.
Line 44: 
Line 45: @property
Line 46: def backing_file(self):
Line 47: return self._backing_file


Line 43: return self._path
Line 44: 
Line 45: @property
Line 46: def backing_file(self):
Line 47: return self._backing_file
The caller have this value, we don't need to keep it.
Line 48: 
Line 49: def __enter__(self):
Line 50: cmd = ["losetup", "--find", "--show", self._backing_file]
Line 51: rc, out, err = commands.execCmd(cmd, raw=True)


Line 45: @property
Line 46: def backing_file(self):
Line 47: return self._backing_file
Line 48: 
Line 49: def __enter__(self):
This can accept the backing file.

Extract create_device function, usable for code that need to create many 
devices.
Line 50: cmd = ["losetup", "--find", "--show", self._backing_file]
Line 51: rc, out, err = commands.execCmd(cmd, raw=True)
Line 52: if rc != 0:
Line 53: raise cmdutils.Error(cmd, rc, out, err)


Line 51: rc, out, err = commands.execCmd(cmd, raw=True)
Line 52: if rc != 0:
Line 53: raise cmdutils.Error(cmd, rc, out, err)
Line 54: self._path = out.strip()
Line 55: return self
We can return path here instead of self.
Line 56: 
Line 57: def __exit__(self, t, v, tb):
Line 58: cmd = ["losetup", "--detach", self._path]
Line 59: rc, out, err = commands.execCmd(cmd, raw=True)


Line 53: raise cmdutils.Error(cmd, rc, out, err)
Line 54: self._path = out.strip()
Line 55: return self
Line 56: 
Line 57: def __exit__(self, t, v, tb):
Extract detach_device function, usable for code that created many devices and 
need to detach them.
Line 58: cmd = ["losetup", "--detach", self._path]
Line 59: rc, out, err = commands.execCmd(cmd, raw=True)
Line 60: if rc != 0:
Line 61: if t is None:


-- 
To view, visit https://gerrit.ovirt.org/64329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37184887930ad9ec1234036fdcdeb6cee8ccac42
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: service: Add vdsm-tool-configure service

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: service: Add vdsm-tool-configure service
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/64904/3//COMMIT_MSG
Commit Message:

Line 9: oVirt-Node Next provides updates via squashfs images and
Line 10: between major/minor updates based on EL7 might occur changes
Line 11: of selinux policy/booleans affecting previous vdsm settings.
Line 12: This patch creates a new service 'vdsm-tool-update' that handle
Line 13: such image updates scenarios.
If this is a node specific issue, it should be solved in node. The service 
should be part of node and it should use the standard vdsm-tool to reconfigure 
things.
Line 14: 
Line 15: Change-Id: Ib9c4fffb09d2a5c49b0462693fb2beca47fb58ea
Line 16: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373389
Line 17: Signed-off-by: Fabian Deutsch 


-- 
To view, visit https://gerrit.ovirt.org/64904
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c4fffb09d2a5c49b0462693fb2beca47fb58ea
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Deactivate guest lvs during deactivation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Deactivate guest lvs during deactivation
..


Patch Set 4:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64369
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56bd79013909c6dfcae789f0985c6085768e792a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Deactivate guest lvs during bootstrap

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Deactivate guest lvs during bootstrap
..


Patch Set 3:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0eed7a61ff11593700c2c5ef0e7d5d4f8be784
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Rename lvmTests to new naming convention

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Rename lvmTests to new naming convention
..


Patch Set 5:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64328
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia266cfde3308f2a842a4fe3be4b6e2bbf2265386
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Skip foreign vgs during bootstrap

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Skip foreign vgs during bootstrap
..


Patch Set 4:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64370
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f072a05026cec8b9d027b52d0adf2e236089706
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Add failing test for guest lvs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Add failing test for guest lvs
..


Patch Set 9:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64330
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80d37278225262bc5692e00aed15654e84119590
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: guest-lvs: Add lvm bootstrap tests

[automation]

gerrit-hooks has posted comments on this change.

Change subject: guest-lvs: Add lvm bootstrap tests
..


Patch Set 8:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64367
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I314544930aa28cf1d929a23842a7e011d461706d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Fabian Deutsch 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Add loop module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add loop module
..


Patch Set 5:

* #1374545::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374545::OK, public bug
* Check Product::#1374545::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37184887930ad9ec1234036fdcdeb6cee8ccac42
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: yml: parameter type fixes for StoragePool.connectStorageServer

[alitke]

Adam Litke has posted comments on this change.

Change subject: yml: parameter type fixes for StoragePool.connectStorageServer
..


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/59701/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS2, Line 381: Id
Can we do better?  How about: A UUID that will be used to identify this 
connection in subsequent API calls.


Line 380: 
Line 381: -   description: Id
Line 382: name: id
Line 383: type: *UUID
Line 384: type: object
Are you missing: ifaceName, initiatorName, and netIfaceName?
Line 385: 
Line 386: LocalFsConnectionParameters: 
Line 387: added: '3.1'
Line 388: description: Parameters for initiating a connection to


Line : 0: The type is not known
Line 5556: 1: The Storage Domain uses Network File System based 
storage
Line 5557: 2: The Storage Domain uses FibreChannel based storage
Line 5558: 3: The Storage Domain uses iSCSI based storage
Line 5559: 4: The Storage Domain uses storage on the local file 
system
5 is CIFS (aka smbfs).  If it's deprecated we can say so here but I don't think 
it should be omitted.
Line 5560: 6: The Storage Domain uses posix file system
Line 5561: 7: The Storage Domain uses glusterfs
Line 5562: 
Line 5563: StorageDomainInfo: 


-- 
To view, visit https://gerrit.ovirt.org/59701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9fe2ffc3bc2327eefaae794b7b366e8202d2f2a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: wip: jsonrpc: introduce new client

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: wip: jsonrpc: introduce new client
..


Patch Set 9:

(2 comments)

We also need tests for this.

https://gerrit.ovirt.org/#/c/64502/9/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 95: def __init__(self, client):
Line 96: self._client = client
Line 97: self.default_timeout = yajsonrpc.CALL_TIMEOUT
Line 98: 
Line 99: def call(self, method, args={}, timeout=None):
args is optional now (good), but you are using mutable default argument, 
meaning that all calls share the same args dict. If some call will modify the 
dict, the modification will effect the next calls.

There no way to have default dict argument safely, the safe way to do this is:

def call(self, method, args=None, ...):
if args is None:
args = {}

We also need docstring explaining what is each argument. For example timeout 
seems to be the number of seconds to wait for response.
Line 100: if timeout is None:
Line 101: timeout = self.default_timeout
Line 102: req = yajsonrpc.JsonRpcRequest(method, args, 
reqId=str(uuid.uuid4()))
Line 103: try:


Line 105: except EnvironmentError as e:
Line 106: raise ClientError(e)
Line 107: 
Line 108: if not responses:
Line 109: raise ClientError("timeout waiting for a response")
I think we need to introduce a Timeout error, otherwise the user cannot tell if 
the issue was a timeout or other client error.
Line 110: 
Line 111: resp = responses[0]
Line 112: if resp.error:
Line 113: raise ServerError(resp.error['code'], 
resp.error['message'])


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use fresh ResourceManager for every test
..


Patch Set 5:

* #65004::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: Use fresh ResourceManager for every test
..


tests: Use fresh ResourceManager for every test

Previously if unregistring a namespace failed during shutdown failed, we
would reset the manager instance, but if a test failed and left the
manager in inconsistent state, possibly breaking unrelated tests.

Replace fragile setUp and tearDown code with monkeypatching, setting a
fresh instance before each test, and restoring the previous instance
after the test.

Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/65004
Reviewed-by: Adam Litke 
---
M tests/storage_resourcemanager_test.py
1 file changed, 77 insertions(+), 54 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Streamline resourceManager import

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Streamline resourceManager import
..


Patch Set 4:

* #65003::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06a26c4fcf6a3f4d81339df1633d28d87b99520
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use fresh ResourceManager for every test
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Streamline resourceManager import

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: Streamline resourceManager import
..


tests: Streamline resourceManager import

In the application we typically import resourceManager as rm. Do the
same in the tests to streamline the tests and make the usage of this
module same both in the tests and the real code.

Change-Id: Ie06a26c4fcf6a3f4d81339df1633d28d87b99520
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/65003
Reviewed-by: Adam Litke 
Continuous-Integration: Jenkins CI
---
M tests/storage_resourcemanager_test.py
1 file changed, 86 insertions(+), 107 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie06a26c4fcf6a3f4d81339df1633d28d87b99520
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Use fresh ResourceManager for every test
..


Patch Set 3: Continuous-Integration+1

Network again

-- 
To view, visit https://gerrit.ovirt.org/65004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Remove unused listNamespaces
..


Patch Set 4:

* #65002::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: make gluster_cli_tests pass

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3: make gluster_cli_tests pass
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65008
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e212e247f057f2988debaf3b2de923851b90b24
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: resourceManager: Remove unused listNamespaces
..


resourceManager: Remove unused listNamespaces

The only usage was a test for this, so we don't really need it, making
the ResourceManager interface smaller. This will make further
refactoring easier.

Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/65002
Reviewed-by: Adam Litke 
---
M tests/storage_resourcemanager_test.py
M vdsm/storage/resourceManager.py
2 files changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Remove unused listNamespaces
..


Patch Set 3: Continuous-Integration+1

Network tests

-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: make gluster_cli_tests pass

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: py3: make gluster_cli_tests pass
..


Patch Set 1:

Ramesh, can you verify that the change does not harm vdsm nor its gluster 
support?

-- 
To view, visit https://gerrit.ovirt.org/65008
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e212e247f057f2988debaf3b2de923851b90b24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: wip: jsonrpc: introduce new client

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: wip: jsonrpc: introduce new client
..


Patch Set 9:

(10 comments)

https://gerrit.ovirt.org/#/c/64502/8/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: '''
Line 21: vdsm client
> This is not a jsonrpc client (generic client for server using jsonrpc) but 
Done
Line 22: 
Line 23: This is a simple client which uses jsonrpc protocol introduced on 
ovirt 3.5.
Line 24: This client is not aware of the available methods and parameters.
Line 25: 


Line 26: The user should consult the schema to construct the wanted command.
Line 27: 
Line 28: The client is invoked with:
Line 29: 
Line 30: cli = client.connect(host, port, ssl)
> The common way to show code examples is to indent them with 4 spaces, the #
Done
Line 31: 
Line 32: For example:
Line 33: 
Line 34: cli = client.connect('localhost', 54321, True)


Line 36: Failure will result in ClientError exception.
Line 37: 
Line 38: Invoking commands:
Line 39: 
Line 40: cli.call('Host.getVMList')
> Maybe we can make args optional to make it nicer to call methods without ar
Done
Line 41: 
Line 42: cli.call('VM.getStats', {'vmID': 
'bc26bd11-ee3b-4a56-80d4-770f383a47b9'})
Line 43: 
Line 44: The call method expects method name and a dictionary (optional) 
containing all


Line 44: The call method expects method name and a dictionary (optional) 
containing all
Line 45: mandatory parameters, as they appear in the schema.
Line 46: 
Line 47: Complex parameters are also supported and share the same behavior.
Line 48: 
> We need to see an example result, and explain about getting the exact resul
I will address this comment in the next change
Line 49: '''
Line 50: 
Line 51: 
Line 52: from __future__ import absolute_import


Line 47: Complex parameters are also supported and share the same behavior.
Line 48: 
Line 49: '''
Line 50: 
Line 51: 
> One empty line here is enough.
Done
Line 52: from __future__ import absolute_import
Line 53: 
Line 54: import uuid
Line 55: 


Line 90: self.code = code
Line 91: self.message = message
Line 92: 
Line 93: 
Line 94: class _Client(object):
> These should come after the public apis.
Done
Line 95: def __init__(self, client):
Line 96: self._client = client
Line 97: self.default_timeout = yajsonrpc.CALL_TIMEOUT
Line 98: 


Line 110: 
Line 111: resp = responses[0]
Line 112: if resp.error:
Line 113: raise ServerError(resp.error['code'], 
resp.error['message'])
Line 114: 
> Let document if we may get here multiple responses, when I see this code I 
same
Line 115: return resp.result
Line 116: 
Line 117: def close(self):
Line 118: self._client.close()


Line 113: raise ServerError(resp.error['code'], 
resp.error['message'])
Line 114: 
Line 115: return resp.result
Line 116: 
Line 117: def close(self):
> Let keep empty line after raising/returning - the rest of the function is h
Done
Line 118: self._client.close()
Line 119: 
Line 120: def __enter__(self):
Line 121: return self


Line 118: self._client.close()
Line 119: 
Line 120: def __enter__(self):
Line 121: return self
Line 122: 
> Here is a good place for the context manager interface.
Done
Line 123: def __exit__(self, t, v, tb):
Line 124: try:
Line 125: self.close()
Line 126: except Exception:


Line 120: def __enter__(self):
Line 121: return self
Line 122: 
Line 123: def __exit__(self, t, v, tb):
Line 124: try:
> This and the exceptions are the only public apis, so they should be at the 
Done
Line 125: self.close()
Line 126: except Exception:
Line 127: if t is None:


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: wip: jsonrpc: introduce new client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: wip: jsonrpc: introduce new client
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: blockSD: Storage domain life cycle management

[automation]

gerrit-hooks has posted comments on this change.

Change subject: blockSD: Storage domain life cycle management
..


Patch Set 7:

* #1331978::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1331978::OK, public bug
* Check Product::#1331978::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56876
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7227bb43c2e1ee67a6239956aae48173a27f566e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: volume: Add qcow2_compat on create

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: volume: Add qcow2_compat on create
..


Patch Set 19: Continuous-Integration+1

Network tests again

-- 
To view, visit https://gerrit.ovirt.org/64375
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8655be6da0b4cbd1c286b0c40288681a991aff19
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Make boolean values from boolean migration options

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: Make boolean values from boolean migration options
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move ResourceInfo class to module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Move ResourceInfo class to module
..


Patch Set 4:

* #65001::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move ResourceInfo class to module

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: resourceManager: Move ResourceInfo class to module
..


resourceManager: Move ResourceInfo class to module

Simplify ResourceManger class by moving the nested ResouceInfo class to
the module. This will make further refactoring easier.

Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/65001
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
---
M vdsm/storage/resourceManager.py
1 file changed, 15 insertions(+), 15 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use fresh ResourceManager for every test
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move ResourceInfo class to module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Move ResourceInfo class to module
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Remove unused listNamespaces
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Streamline resourceManager import

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Streamline resourceManager import
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06a26c4fcf6a3f4d81339df1633d28d87b99520
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move Namespace class to module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Move Namespace class to module
..


Patch Set 3:

* #65000::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82240985fe156345fee0c08a46de5251e9d65be8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/61186/14/tests/functional/upgrade_vdsm_test.py
File tests/functional/upgrade_vdsm_test.py:

PS14, Line 40: 4.17.10.1-0
> why to downgrade to this specific version?
There isn't any specific reason, I just wanted to make sure that a package from 
3.6 version will be installed.


-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move Namespace class to module

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: resourceManager: Move Namespace class to module
..


resourceManager: Move Namespace class to module

Simplify the ResourceManager class by moving the nested Namespace class
to the module. This make further refactoring easier.

Change-Id: I82240985fe156345fee0c08a46de5251e9d65be8
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/65000
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
---
M vdsm/storage/resourceManager.py
1 file changed, 11 insertions(+), 10 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82240985fe156345fee0c08a46de5251e9d65be8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt: Don't crash in migration progress on compression bytes

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
..


Patch Set 2: Verified+1

Bug number added.

Verified that with this change the crash (KeyError) is no longer present and 
that a VM can be successfully migrated even with compression disabled.

-- 
To view, visit https://gerrit.ovirt.org/64499
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: make gluster_cli_tests pass

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3: make gluster_cli_tests pass
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65008
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e212e247f057f2988debaf3b2de923851b90b24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: make gluster_cli_tests pass

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: py3: make gluster_cli_tests pass
..

py3: make gluster_cli_tests pass

Change-Id: I7e212e247f057f2988debaf3b2de923851b90b24
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/kaxmlrpclib.py
M lib/vdsm/network/netlink/addr.py
M tests/gluster_cli_tests.py
M vdsm/gluster/storagedev.py
4 files changed, 11 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/65008/1

diff --git a/lib/vdsm/kaxmlrpclib.py b/lib/vdsm/kaxmlrpclib.py
index e24316c..66ec9e0 100644
--- a/lib/vdsm/kaxmlrpclib.py
+++ b/lib/vdsm/kaxmlrpclib.py
@@ -33,8 +33,8 @@
 from __future__ import absolute_import
 from __future__ import print_function
 
-import xmlrpclib
-import httplib
+import six.moves.xmlrpc_client
+import six.moves.http_client
 import socket
 
 # It would have been nicer to make these server-specific and not module-wide
@@ -48,19 +48,19 @@
 
 def Server(url, *args, **kwargs):
 kwargs['transport'] = TcpkeepTransport()
-server = xmlrpclib.Server(url, *args, **kwargs)
+server = six.moves.xmlrpc_client.Server(url, *args, **kwargs)
 return server
 
 ServerProxy = Server
 
 
-class TcpkeepTransport(xmlrpclib.Transport):
+class TcpkeepTransport(six.moves.xmlrpc_client.Transport):
 
 def make_connection(self, host):
 return TcpkeepHTTPConnection(host)
 
 
-class TcpkeepHTTPConnection(httplib.HTTPConnection):
+class TcpkeepHTTPConnection(six.moves.http_client.HTTPConnection):
 def connect(self):
 """Connect to the host and port specified in __init__.
 
@@ -110,7 +110,7 @@
 
 def SslServer(url, ctx, *args, **kwargs):
 kwargs['transport'] = TcpkeepSafeTransport(ctx)
-server = xmlrpclib.Server(url, *args, **kwargs)
+server = six.moves.xmlrpc_client.Server(url, *args, **kwargs)
 return server
 
 SslServerProxy = SslServer
diff --git a/lib/vdsm/network/netlink/addr.py b/lib/vdsm/network/netlink/addr.py
index 0037454..cb17bf3 100644
--- a/lib/vdsm/network/netlink/addr.py
+++ b/lib/vdsm/network/netlink/addr.py
@@ -79,7 +79,7 @@
 """Returns the textual representation of the address flags"""
 flags = (c_char * (CHARBUFFSIZE * 2))()
 return frozenset(_rtnl_addr_flags2str(_rtnl_addr_get_flags(addr), flags,
- sizeof(flags)).split(','))
+ sizeof(flags)).split(b','))
 
 
 # C function prototypes
diff --git a/tests/gluster_cli_tests.py b/tests/gluster_cli_tests.py
index 4ab9daf..0493c27 100644
--- a/tests/gluster_cli_tests.py
+++ b/tests/gluster_cli_tests.py
@@ -18,6 +18,8 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
+import six
+
 from testlib import VdsmTestCase as TestCaseBase
 from gluster import cli as gcli
 import xml.etree.cElementTree as etree
@@ -446,7 +448,7 @@
 """
 tree = etree.fromstring(out)
 status = gcli._parseVolumeStatusClients(tree)
-self.assertEquals(status.keys(), ['bricks', 'name'])
+self.assertEquals(set(six.iterkeys(status)), {'bricks', 'name'})
 self.assertEquals(status['name'], 'music')
 oBricks = [{'brick': '192.168.122.2:/tmp/music-b1',
 'hostuuid':
diff --git a/vdsm/gluster/storagedev.py b/vdsm/gluster/storagedev.py
index a7ab985..a0eefaa 100644
--- a/vdsm/gluster/storagedev.py
+++ b/vdsm/gluster/storagedev.py
@@ -35,7 +35,7 @@
 from vdsm import utils
 from vdsm.gluster import exception as ge
 
-import fstab
+from . import fstab
 from . import gluster_mgmt_api
 
 


-- 
To view, visit https://gerrit.ovirt.org/65008
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e212e247f057f2988debaf3b2de923851b90b24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt: Don't crash in migration progress on compression bytes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Don't crash in migration progress on compression bytes
..


Patch Set 2:

* #64468::Update tracker: OK
* #1380822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1380822::OK, public bug
* Check Product::#1380822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1380822::ERROR, wrong target milestone for stable branch, --- 
should match ^.*4.0.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/64499
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1885940843d705ead161c13258f1979025a03873
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Make boolean values from boolean migration options

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Make boolean values from boolean migration options
..


Patch Set 1:

* #1380822::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1380822::OK, public bug
* Check Product::#1380822::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Make boolean values from boolean migration options

[mzamazal]

Milan Zamazal has uploaded a new change for review.

Change subject: virt: Make boolean values from boolean migration options
..

virt: Make boolean values from boolean migration options

`compressed' and `autoConverge' migration options have boolean values in
the string form.  They must be converted to actual booleans before they
are checked.

Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1
Bug-Url: https://bugzilla.redhat.com/1380822
Backport-To: 4.0
Signed-off-by: Milan Zamazal 
---
M vdsm/virt/migration.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/65007/1

diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py
index bed481e..3f51c89 100644
--- a/vdsm/virt/migration.py
+++ b/vdsm/virt/migration.py
@@ -111,8 +111,8 @@
 kwargs.get('maxBandwidth') or
 config.getint('vars', 'migration_max_bandwidth')
 )
-self._autoConverge = autoConverge
-self._compressed = compressed
+self._autoConverge = utils.tobool(autoConverge)
+self._compressed = utils.tobool(compressed)
 self._incomingLimit = kwargs.get('incomingLimit')
 self._outgoingLimit = kwargs.get('outgoingLimit')
 self.status = {


-- 
To view, visit https://gerrit.ovirt.org/65007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I642eb607785a1b6f877092e187c91b7a065b38e1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: let bulk_sampling_test pass under py3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3: let bulk_sampling_test pass under py3
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8f148a7984fab0a092fca588b5de61bdeb4e899
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: py3: let bulk_sampling_test pass under py3

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: py3: let bulk_sampling_test pass under py3
..

py3: let bulk_sampling_test pass under py3

Change-Id: Ic8f148a7984fab0a092fca588b5de61bdeb4e899
Signed-off-by: Dan Kenigsberg 
---
M lib/vdsm/virt/sampling.py
M lib/vdsm/virt/utils.py
M tests/Makefile.am
3 files changed, 8 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/65006/1

diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py
index 87e86c6..e8fa2c1 100644
--- a/lib/vdsm/virt/sampling.py
+++ b/lib/vdsm/virt/sampling.py
@@ -18,6 +18,7 @@
 # Refer to the README and COPYING files for full details of the license
 #
 from __future__ import absolute_import
+import six
 
 """
 Support for VM and host statistics sampling.
@@ -279,12 +280,12 @@
 def to_connlog(self):
 text = ', '.join(
 ('%s:(%s)' % (ifid, ifacesample.to_connlog()))
-for (ifid, ifacesample) in self.interfaces.iteritems())
+for (ifid, ifacesample) in six.iteritems(self.interfaces))
 return ('recent_client:%s, ' % self.recentClient) + text
 
 def connlog_diff(self, other):
 text = ''
-for ifid, sample in self.interfaces.iteritems():
+for ifid, sample in six.iteritems(self.interfaces):
 if ifid in other.interfaces:
 diff = sample.connlog_diff(other.interfaces[ifid])
 if diff:
@@ -292,7 +293,7 @@
 else:
 text += 'new %s:(%s) ' % (ifid, sample.to_connlog())
 
-for ifid, sample in other.interfaces.iteritems():
+for ifid, sample in six.iteritems(other.interfaces):
 if ifid not in self.interfaces:
 text += 'dropped %s:(%s) ' % (ifid, sample.to_connlog())
 
@@ -560,14 +561,14 @@
vm_sample.first_value,
vm_sample.last_value,
vm_sample.interval)
-for vm_id, vm_sample in vm_samples.items()
+for vm_id, vm_sample in six.iteritems(vm_samples)
 }
 vmstats.send_metrics(stats)
 
 def _get_responsive_doms(self):
 vms = self._get_vms()
 doms = []
-for vm_id, vm_obj in vms.iteritems():
+for vm_id, vm_obj in six.iteritems(vms):
 to_skip = self._skip_doms.get(vm_id, False)
 if to_skip:
 continue
diff --git a/lib/vdsm/virt/utils.py b/lib/vdsm/virt/utils.py
index 1d215e0..7d64a28 100644
--- a/lib/vdsm/virt/utils.py
+++ b/lib/vdsm/virt/utils.py
@@ -18,6 +18,7 @@
 # Refer to the README and COPYING files for full details of the license
 #
 from __future__ import absolute_import
+import six
 
 """
 shared utilities and common code for the virt package
@@ -93,7 +94,7 @@
 with self._lock:
 expired_keys = [
 key for key, (expiration, _)
-in self._items.iteritems()
+in six.iteritems(self._items)
 if expiration <= now]
 for key in expired_keys:
 del self._items[key]
diff --git a/tests/Makefile.am b/tests/Makefile.am
index fb3d7c3..c690f3e 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -167,7 +167,6 @@
blockVolumeTests.py \
blocksdTests.py \
bridgeTests.py \
-   bulk_sampling_test.py \
cPopenTests.py \
clientifTests.py \
deviceTests.py \


-- 
To view, visit https://gerrit.ovirt.org/65006
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8f148a7984fab0a092fca588b5de61bdeb4e899
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Streamline resourceManager import

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Streamline resourceManager import
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06a26c4fcf6a3f4d81339df1633d28d87b99520
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[alitke]

Adam Litke has posted comments on this change.

Change subject: resourceManager: Remove unused listNamespaces
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move ResourceInfo class to module

[alitke]

Adam Litke has posted comments on this change.

Change subject: resourceManager: Move ResourceInfo class to module
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Use fresh ResourceManager for every test
..


Patch Set 2: Code-Review+2

Nice!

-- 
To view, visit https://gerrit.ovirt.org/65004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[alitke]

Adam Litke has posted comments on this change.

Change subject: resourceManager: Remove unused listNamespaces
..


Patch Set 2:

CI failing on network tests again.

-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move Namespace class to module

[alitke]

Adam Litke has posted comments on this change.

Change subject: resourceManager: Move Namespace class to module
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82240985fe156345fee0c08a46de5251e9d65be8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Flatten LockType constants
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Remove unused listNamespaces
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Flatten LockType constants
..


Patch Set 3: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/63628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: resourceManager: Flatten LockType constants
..


resourceManager: Flatten LockType constants

Replace the LockType class with flat constants, streamlining client
code.

Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/63628
Reviewed-by: Adam Litke 
---
M tests/storage_resourcemanager_test.py
M tests/storage_sdm_copy_data_test.py
M tests/storage_sdm_create_volume_test.py
M tests/storage_volume_test.py
M vdsm/storage/blockVolume.py
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/resourceFactories.py
M vdsm/storage/resourceManager.py
M vdsm/storage/sdm/api/copy_data.py
M vdsm/storage/sdm/api/create_volume.py
M vdsm/storage/sp.py
M vdsm/storage/task.py
M vdsm/storage/volume.py
14 files changed, 120 insertions(+), 139 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move ResourceInfo class to module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Move ResourceInfo class to module
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move Namespace class to module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Move Namespace class to module
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82240985fe156345fee0c08a46de5251e9d65be8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use fresh ResourceManager for every test
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Streamline resourceManager import

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Streamline resourceManager import
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06a26c4fcf6a3f4d81339df1633d28d87b99520
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Flatten LockType constants
..


Patch Set 4:

* #63628::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Inline LockType.validate

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Inline LockType.validate
..


Patch Set 4:

* #63627::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Inline LockType.validate

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: resourceManager: Inline LockType.validate
..


resourceManager: Inline LockType.validate

Inline the function in the single call site, allowing replacing LockType
with flat constants.

Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/63627
Reviewed-by: Adam Litke 
---
M vdsm/storage/resourceManager.py
1 file changed, 2 insertions(+), 7 deletions(-)

Approvals:
  Nir Soffer: Verified; Passed CI tests
  Adam Litke: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Inline LockType.validate

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Inline LockType.validate
..


Patch Set 3: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/63627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Inline LockType.validate

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Inline LockType.validate
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused method

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Remove unused method
..


Patch Set 3:

* #63626::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused method

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: resourceManager: Remove unused method
..


resourceManager: Remove unused method

LockType.fromState is not used. Remove it so we can replace the LockType
class with flat constants.

Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/63626
Reviewed-by: Freddy Rolland 
Reviewed-by: Adam Litke 
---
M vdsm/storage/resourceManager.py
1 file changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Nir Soffer: Verified; Passed CI tests
  Adam Litke: Looks good to me, approved
  Freddy Rolland: Looks good to me, but someone else must approve

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[alitke]

Adam Litke has posted comments on this change.

Change subject: resourceManager: Flatten LockType constants
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: remove unused field in vm stats

[ahadas]

Arik Hadas has posted comments on this change.

Change subject: remove unused field in vm stats
..


Patch Set 2:

Francesco, I understand the aim to preserve backward compatibility - but I 
think we should be realistic, I believe no-one other than components we develop 
is using vdsm and I never see any statement where we declare our intention to 
preserve compatibility with external tools that one may develop - such tools 
are supposed to interact with the engine I believe. so I think vmType can be 
dropped..

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused method

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Remove unused method
..


Patch Set 2: Continuous-Integration+1

Network tests on python 3, cannot be more irrelevant.

-- 
To view, visit https://gerrit.ovirt.org/63626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Remove unused listNamespaces
..


Patch Set 1: Verified+1

Verified by the tests.

-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move Namespace class to module

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourceManager: Move Namespace class to module
..

resourceManager: Move Namespace class to module

Simplify the ResourceManager class by moving the nested Namespace class
to the module. This make further refactoring easier.

Change-Id: I82240985fe156345fee0c08a46de5251e9d65be8
Signed-off-by: Nir Soffer 
---
M vdsm/storage/resourceManager.py
1 file changed, 11 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/65000/1

diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index 9060c44..a85fc80 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -358,15 +358,6 @@
 self.name = name
 self.fullName = "%s.%s" % (namespace, name)
 
-class Namespace(object):
-"""
-Namespace struct
-"""
-def __init__(self, factory):
-self.resources = {}
-self.lock = threading.Lock()  # rwlock.RWLock()
-self.factory = factory
-
 def __init__(self):
 self._syncRoot = rwlock.RWLock()
 self._namespaces = {}
@@ -404,7 +395,7 @@
 
 self._log.debug("Registering namespace '%s'", namespace)
 
-self._namespaces[namespace] = ResourceManager.Namespace(factory)
+self._namespaces[namespace] = Namespace(factory)
 
 def unregisterNamespace(self, namespace):
 with self._syncRoot.exclusive:
@@ -712,6 +703,16 @@
 resource.activeUsers)
 
 
+class Namespace(object):
+"""
+Namespace struct
+"""
+def __init__(self, factory):
+self.resources = {}
+self.lock = threading.Lock()  # rwlock.RWLock()
+self.factory = factory
+
+
 class Owner(object):
 log = logging.getLogger('storage.ResourceManager.Owner')
 


-- 
To view, visit https://gerrit.ovirt.org/65000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82240985fe156345fee0c08a46de5251e9d65be8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move ResourceInfo class to module

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourceManager: Move ResourceInfo class to module
..

resourceManager: Move ResourceInfo class to module

Simplify ResourceManger class by moving the nested ResouceInfo class to
the module. This will make further refactoring easier.

Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Signed-off-by: Nir Soffer 
---
M vdsm/storage/resourceManager.py
1 file changed, 15 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/65001/1

diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index a85fc80..2949d10 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -345,19 +345,6 @@
 _instance = None
 _singletonLock = threading.Lock()
 
-class ResourceInfo(object):
-"""
-Resource struct
-"""
-def __init__(self, realObj, namespace, name):
-self.queue = []
-self.activeUsers = 0
-self.currentLock = None
-self.realObj = realObj
-self.namespace = namespace
-self.name = name
-self.fullName = "%s.%s" % (namespace, name)
-
 def __init__(self):
 self._syncRoot = rwlock.RWLock()
 self._namespaces = {}
@@ -575,8 +562,7 @@
 contextCleanup.defer(request.cancel)
 return RequestRef(request)
 
-resource = resources[name] = ResourceManager.ResourceInfo(
-obj, namespace, name)
+resource = resources[name] = ResourceInfo(obj, namespace, name)
 resource.currentLock = request.lockType
 resource.activeUsers += 1
 
@@ -713,6 +699,20 @@
 self.factory = factory
 
 
+class ResourceInfo(object):
+"""
+Resource struct
+"""
+def __init__(self, realObj, namespace, name):
+self.queue = []
+self.activeUsers = 0
+self.currentLock = None
+self.realObj = realObj
+self.namespace = namespace
+self.name = name
+self.fullName = "%s.%s" % (namespace, name)
+
+
 class Owner(object):
 log = logging.getLogger('storage.ResourceManager.Owner')
 


-- 
To view, visit https://gerrit.ovirt.org/65001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Use fresh ResourceManager for every test
..


Patch Set 1: Verified+1

Verified by the tests.

-- 
To view, visit https://gerrit.ovirt.org/65004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Streamline resourceManager import

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Streamline resourceManager import
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06a26c4fcf6a3f4d81339df1633d28d87b99520
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move Namespace class to module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Move Namespace class to module
..


Patch Set 1: Verified+1

Verfied by the tests.

-- 
To view, visit https://gerrit.ovirt.org/65000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82240985fe156345fee0c08a46de5251e9d65be8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Remove unused listNamespaces
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Streamline resourceManager import

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Streamline resourceManager import
..


Patch Set 1: Verified+1

Verified by the tests.

-- 
To view, visit https://gerrit.ovirt.org/65003
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06a26c4fcf6a3f4d81339df1633d28d87b99520
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Streamline resourceManager import

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: tests: Streamline resourceManager import
..

tests: Streamline resourceManager import

In the application we typically import resourceManager as rm. Do the
same in the tests to streamline the tests and make the usage of this
module same both in the tests and the real code.

Change-Id: Ie06a26c4fcf6a3f4d81339df1633d28d87b99520
Signed-off-by: Nir Soffer 
---
M tests/storage_resourcemanager_test.py
1 file changed, 86 insertions(+), 107 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/65003/1

diff --git a/tests/storage_resourcemanager_test.py 
b/tests/storage_resourcemanager_test.py
index f616e09..88b92fd 100644
--- a/tests/storage_resourcemanager_test.py
+++ b/tests/storage_resourcemanager_test.py
@@ -26,14 +26,15 @@
 import types
 from resource import getrlimit, RLIMIT_NPROC
 
-import storage.resourceManager as resourceManager
+from storage import resourceManager as rm
+
 from storagefakelib import FakeResourceManager
 from testlib import expandPermutations, permutations
 from testlib import VdsmTestCase as TestCaseBase
 from testValidation import slowtest, stresstest
 
 
-class NullResourceFactory(resourceManager.SimpleResourceFactory):
+class NullResourceFactory(rm.SimpleResourceFactory):
 """
 A resource factory that has no resources. Used for testing.
 """
@@ -41,7 +42,7 @@
 return False
 
 
-class ErrorResourceFactory(resourceManager.SimpleResourceFactory):
+class ErrorResourceFactory(rm.SimpleResourceFactory):
 """
 A resource factory that has no resources. Used for testing.
 """
@@ -49,7 +50,7 @@
 raise Exception("EPIC FAIL!! LOLZ!!")
 
 
-class StringResourceFactory(resourceManager.SimpleResourceFactory):
+class StringResourceFactory(rm.SimpleResourceFactory):
 def createResource(self, name, lockType):
 s = StringIO("%s:%s" % (name, lockType))
 s.seek(0)
@@ -66,7 +67,7 @@
 return s
 
 
-class SwitchFailFactory(resourceManager.SimpleResourceFactory):
+class SwitchFailFactory(rm.SimpleResourceFactory):
 def createResource(self, name, lockType):
 s = StringIO("%s:%s" % (name, lockType))
 s.seek(0)
@@ -78,7 +79,7 @@
 return s
 
 
-class CrashOnCloseFactory(resourceManager.SimpleResourceFactory):
+class CrashOnCloseFactory(rm.SimpleResourceFactory):
 def createResource(self, name, lockType):
 s = StringIO("%s:%s" % (name, lockType))
 s.seek(0)
@@ -90,7 +91,7 @@
 return s
 
 
-class FailAfterSwitchFactory(resourceManager.SimpleResourceFactory):
+class FailAfterSwitchFactory(rm.SimpleResourceFactory):
 def __init__(self):
 self.fail = False
 
@@ -113,9 +114,8 @@
 
 class ResourceManagerTests(TestCaseBase):
 def setUp(self):
-manager = self.manager = resourceManager.ResourceManager.getInstance()
-manager.registerNamespace("storage",
-  resourceManager.SimpleResourceFactory())
+manager = self.manager = rm.ResourceManager.getInstance()
+manager.registerNamespace("storage", rm.SimpleResourceFactory())
 manager.registerNamespace("null", NullResourceFactory())
 manager.registerNamespace("string", StringResourceFactory())
 manager.registerNamespace("error", ErrorResourceFactory())
@@ -125,21 +125,20 @@
 
 def testErrorInFactory(self):
 manager = self.manager
-req = manager.registerResource("error", "resource",
-   resourceManager.EXCLUSIVE,
+req = manager.registerResource("error", "resource", rm.EXCLUSIVE,
lambda req, res: 1)
 self.assertTrue(req.canceled())
 
 def testSingleton(self):
-a = resourceManager.ResourceManager.getInstance()
-b = resourceManager.ResourceManager.getInstance()
+a = rm.ResourceManager.getInstance()
+b = rm.ResourceManager.getInstance()
 self.assertEquals(id(a), id(b))
 
 def testRegisterInvalidNamespace(self):
 manager = self.manager
 try:
 manager.registerNamespace("I.HEART.DOTS",
-  resourceManager.SimpleResourceFactory())
+  rm.SimpleResourceFactory())
 except ValueError:
 return
 
@@ -153,9 +152,9 @@
 
 manager = self.manager
 exclusive1 = manager.acquireResource(
-"failAfterSwitch", "resource", resourceManager.EXCLUSIVE)
+"failAfterSwitch", "resource", rm.EXCLUSIVE)
 sharedReq1 = manager.registerResource(
-"failAfterSwitch", "resource", resourceManager.SHARED, callback)
+"failAfterSwitch", "resource", rm.SHARED, callback)
 exclusive1.release()
 self.assertTrue(sharedReq1.canceled())
 

Change in vdsm[master]: resourceManager: Move ResourceInfo class to module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Move ResourceInfo class to module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Use fresh ResourceManager for every test
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65004
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: Use fresh ResourceManager for every test

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: tests: Use fresh ResourceManager for every test
..

tests: Use fresh ResourceManager for every test

Previously if unregistring a namespace failed during shutdown failed, we
would reset the manager instance, but if a test failed and left the
manager in inconsistent state, possibly breaking unrelated tests.

Replace fragile setUp and tearDown code with monkeypatching, setting a
fresh instance before each test, and restoring the previous instance
after the test.

Change-Id: Ib4a68ce670aab78b15d11dafa155b58beb6265ec
Signed-off-by: Nir Soffer 
---
M tests/storage_resourcemanager_test.py
1 file changed, 77 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/65004/1

diff --git a/tests/storage_resourcemanager_test.py 
b/tests/storage_resourcemanager_test.py
index 88b92fd..307fea5 100644
--- a/tests/storage_resourcemanager_test.py
+++ b/tests/storage_resourcemanager_test.py
@@ -28,6 +28,7 @@
 
 from storage import resourceManager as rm
 
+from monkeypatch import MonkeyPatch
 from storagefakelib import FakeResourceManager
 from testlib import expandPermutations, permutations
 from testlib import VdsmTestCase as TestCaseBase
@@ -112,30 +113,39 @@
 return s
 
 
-class ResourceManagerTests(TestCaseBase):
-def setUp(self):
-manager = self.manager = rm.ResourceManager.getInstance()
-manager.registerNamespace("storage", rm.SimpleResourceFactory())
-manager.registerNamespace("null", NullResourceFactory())
-manager.registerNamespace("string", StringResourceFactory())
-manager.registerNamespace("error", ErrorResourceFactory())
-manager.registerNamespace("switchfail", SwitchFailFactory())
-manager.registerNamespace("crashy", CrashOnCloseFactory())
-manager.registerNamespace("failAfterSwitch", FailAfterSwitchFactory())
+def manager():
+"""
+Create fresh ResourceManager instance for testing.
+"""
+manager = rm.ResourceManager()
+manager.registerNamespace("storage", rm.SimpleResourceFactory())
+manager.registerNamespace("null", NullResourceFactory())
+manager.registerNamespace("string", StringResourceFactory())
+manager.registerNamespace("error", ErrorResourceFactory())
+manager.registerNamespace("switchfail", SwitchFailFactory())
+manager.registerNamespace("crashy", CrashOnCloseFactory())
+manager.registerNamespace("failAfterSwitch", FailAfterSwitchFactory())
+return manager
 
+
+class ResourceManagerTests(TestCaseBase):
+
+@MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testErrorInFactory(self):
-manager = self.manager
+manager = rm.ResourceManager.getInstance()
 req = manager.registerResource("error", "resource", rm.EXCLUSIVE,
lambda req, res: 1)
 self.assertTrue(req.canceled())
 
+@MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testSingleton(self):
 a = rm.ResourceManager.getInstance()
 b = rm.ResourceManager.getInstance()
 self.assertEquals(id(a), id(b))
 
+@MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testRegisterInvalidNamespace(self):
-manager = self.manager
+manager = rm.ResourceManager.getInstance()
 try:
 manager.registerNamespace("I.HEART.DOTS",
   rm.SimpleResourceFactory())
@@ -144,13 +154,14 @@
 
 self.fail("Managed to register an invalid namespace")
 
+@MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testFailCreateAfterSwitch(self):
 resources = []
 
 def callback(req, res):
 resources.append(res)
 
-manager = self.manager
+manager = rm.ResourceManager.getInstance()
 exclusive1 = manager.acquireResource(
 "failAfterSwitch", "resource", rm.EXCLUSIVE)
 sharedReq1 = manager.registerResource(
@@ -159,30 +170,35 @@
 self.assertTrue(sharedReq1.canceled())
 self.assertEquals(resources[0], None)
 
+@MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testReregisterNamespace(self):
-manager = self.manager
+manager = rm.ResourceManager.getInstance()
 self.assertRaises((ValueError, KeyError), manager.registerNamespace,
   "storage", rm.SimpleResourceFactory())
 
+@MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testResourceSwitchLockTypeFail(self):
 self.testResourceLockSwitch("switchfail")
 
+@MonkeyPatch(rm.ResourceManager, "_instance", manager())
 def testRequestInvalidResource(self):
-manager = self.manager
+manager = rm.ResourceManager.getInstance()
 self.assertRaises(ValueError, manager.acquireResource,
   

Change in vdsm[master]: resourceManager: Move Namespace class to module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Move Namespace class to module
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82240985fe156345fee0c08a46de5251e9d65be8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Move ResourceInfo class to module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Move ResourceInfo class to module
..


Patch Set 1: Verified+1

Verified by the tests.

-- 
To view, visit https://gerrit.ovirt.org/65001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21170d863d19c981995aca6794a1a346e1fbe31b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused listNamespaces

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: resourceManager: Remove unused listNamespaces
..

resourceManager: Remove unused listNamespaces

The only usage was a test for this, so we don't really need it, making
the ResourceManager interface smaller. This will make further
refactoring easier.

Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Signed-off-by: Nir Soffer 
---
M tests/storage_resourcemanager_test.py
M vdsm/storage/resourceManager.py
2 files changed, 0 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/65002/1

diff --git a/tests/storage_resourcemanager_test.py 
b/tests/storage_resourcemanager_test.py
index 3ced8c3..f616e09 100644
--- a/tests/storage_resourcemanager_test.py
+++ b/tests/storage_resourcemanager_test.py
@@ -461,11 +461,6 @@
 manager.registerNamespace(
 "storage", resourceManager.SimpleResourceFactory(), True)
 
-def testListNamespaces(self):
-manager = self.manager
-namespaces = manager.listNamespaces()
-self.assertEquals(len(namespaces), 7)
-
 def testResourceAutorelease(self):
 manager = self.manager
 self.log.info("Acquiring resource", extra={'resource': "bob"})
diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index 2949d10..338a885 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -361,10 +361,6 @@
 
 return cls._instance
 
-def listNamespaces(self):
-with self._syncRoot.shared:
-return self._namespaces.keys()
-
 def registerNamespace(self, namespace, factory, force=False):
 if not self._namespaceValidator.match(namespace):
 raise ValueError("Illegal namespace '%s'" % namespace)


-- 
To view, visit https://gerrit.ovirt.org/65002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie284d49eaf63ce767375288bcab67f10001e9f14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: remove unused field in vm stats

[automation]

gerrit-hooks has posted comments on this change.

Change subject: remove unused field in vm stats
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: acceptor: stop to double close acceptor

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: acceptor: stop to double close acceptor
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63685/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:

Line 206
Line 207
Line 208
Line 209
Line 210
> My suggestion is to fix ownership in different patch. I hate adding respons
In this case we just need a different patch, removing one line here, and adding 
one line in clientIF.prepareForShutdown. This is a very simple patch perfect 
for backporting to 4.0 and even 3.6 if needed, so I don't see a need for 
another patch on top of this.


-- 
To view, visit https://gerrit.ovirt.org/63685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: remove unused fields in vm stats

[ahadas]

Arik Hadas has posted comments on this change.

Change subject: remove unused fields in vm stats
..


Patch Set 1: -Verified

indeed, I didn't take MOM into account.
Martin, I guess MOM needs vmName only for logging, right? and why does it need 
to get the pid?

-- 
To view, visit https://gerrit.ovirt.org/64973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489590b8d8454bf8b5462b5bfb7d2cb4404a924
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas 
Gerrit-Reviewer: Arik Hadas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: acceptor: stop to double close acceptor

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: acceptor: stop to double close acceptor
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63685/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:

Line 206
Line 207
Line 208
Line 209
Line 210
> If this class was the owner of the reactor, it was creating the reactor and
My suggestion is to fix ownership in different patch. I hate adding 
responsibility to ClientIF because there is already too much done there. 
Reactor is used by clients like migration as well so we need to be careful with 
the change.

In principal I agree with you that we should close were we create. I propose to 
fix the ownership in different patch.


-- 
To view, visit https://gerrit.ovirt.org/63685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Try to detect non guest iniated shutdowns

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Try to detect non guest iniated shutdowns
..


Patch Set 5:

* #1341106::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1341106::OK, public bug
* Check Product::#1341106::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64991
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie04b9806fbf0a81dc576aa28cfdda5edb079ce29
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Flatten LockType constants
..


Patch Set 2: Verified+1

This version fixes a new usage of resourceManager.LockType added in 
storage_resourcemanager_test.py. No code change otherwise.

-- 
To view, visit https://gerrit.ovirt.org/63628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Inline LockType.validate

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Inline LockType.validate
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Inline LockType.validate

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Inline LockType.validate
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Flatten LockType constants
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused method

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Remove unused method
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused method

[automation]

gerrit-hooks has posted comments on this change.

Change subject: resourceManager: Remove unused method
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: acceptor: stop to double close acceptor

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: acceptor: stop to double close acceptor
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63685/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:

Line 206
Line 207
Line 208
Line 209
Line 210
> With the current code base reactor is owned by this class. I am not sure wh
If this class was the owner of the reactor, it was creating the reactor and was 
the only user of the reactor.

The owner is clearly clientIF. It create the reactor on startup, start it, but 
never stop it. This is the right place to fix this issue.

If you think clientIF should not create the reactor, you can create it in 
vdsm.serve_clients, where we create the scheduler, but this change is not 
required to fix reactor closing.


-- 
To view, visit https://gerrit.ovirt.org/63685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: acceptor: stop to double close acceptor

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: acceptor: stop to double close acceptor
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/63685/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:

Line 206
Line 207
Line 208
Line 209
Line 210
> I think the fix is to not close the reactor - this class does not own the r
With the current code base reactor is owned by this class. I am not sure 
whether clientIf should be responsible to manege reactor life cycle. There are 
already too many responsibilities for cif. I do not see any other class which 
should own it.

Btw changing the ownership of reactor should be not related to the fix for 
double close issue.


-- 
To view, visit https://gerrit.ovirt.org/63685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Try to detect non guest iniated shutdowns

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Try to detect non guest iniated shutdowns
..


Patch Set 4:

* #1341106::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1341106::OK, public bug
* Check Product::#1341106::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64991
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie04b9806fbf0a81dc576aa28cfdda5edb079ce29
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/61186/14/tests/functional/upgrade_vdsm_test.py
File tests/functional/upgrade_vdsm_test.py:

PS14, Line 40: 4.17.10.1-0
why to downgrade to this specific version?


-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org