Piotr Kliczewski has posted comments on this change. Change subject: acceptor: stop to double close acceptor ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63685/1/lib/vdsm/protocoldetector.py File lib/vdsm/protocoldetector.py: Line 206 Line 207 Line 208 Line 209 Line 210 > I think the fix is to not close the reactor - this class does not own the r With the current code base reactor is owned by this class. I am not sure whether clientIf should be responsible to manege reactor life cycle. There are already too many responsibilities for cif. I do not see any other class which should own it. Btw changing the ownership of reactor should be not related to the fix for double close issue. -- To view, visit https://gerrit.ovirt.org/63685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
