Nir Soffer has posted comments on this change. Change subject: acceptor: stop to double close acceptor ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63685/1/lib/vdsm/protocoldetector.py File lib/vdsm/protocoldetector.py: Line 206 Line 207 Line 208 Line 209 Line 210 > With the current code base reactor is owned by this class. I am not sure wh If this class was the owner of the reactor, it was creating the reactor and was the only user of the reactor. The owner is clearly clientIF. It create the reactor on startup, start it, but never stop it. This is the right place to fix this issue. If you think clientIF should not create the reactor, you can create it in vdsm.serve_clients, where we create the scheduler, but this change is not required to fix reactor closing. -- To view, visit https://gerrit.ovirt.org/63685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
