Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
Martin Polednik has posted comments on this change. Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info .. Patch Set 1: (2 comments) Missing some description of behavior what is happening within engine. https://gerrit.ovirt.org/#/c/65562/1/lib/vdsm/numa.py File lib/vdsm/numa.py: PS1, Line 265: # hotplugged CPU Hotplugged CPU or a bug - maybe the comment could give slightly more idea of what is going on (we have a list of cpus in a numa, node, one of them is missing...) -- to help us understand the code next time we have to open it. PS1, Line 266: continue What about log message of warn/info/debug level that something fishy is going on? -- To view, visit https://gerrit.ovirt.org/65562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
gerrit-hooks has posted comments on this change. Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info .. Patch Set 2: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
Milan Zamazal has posted comments on this change. Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/65562/1/lib/vdsm/numa.py File lib/vdsm/numa.py: PS1, Line 265: # hotplugged CPU > Hotplugged CPU or a bug - maybe the comment could give slightly more idea o Done PS1, Line 266: continue > What about log message of warn/info/debug level that something fishy is goi Done -- To view, visit https://gerrit.ovirt.org/65562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan
Petr Horáček has abandoned this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Abandoned -- To view, visit https://gerrit.ovirt.org/65232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: net: edit nic detached from bridge but still attached to a vlan
gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: * Update Tracker::#1381880::IGNORE, not relevant for Red Hat classification -- To view, visit https://gerrit.ovirt.org/65233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan
gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 2: * Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification -- To view, visit https://gerrit.ovirt.org/65232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: net: edit nic detached from bridge but still attached to a vlan
Petr Horáček has abandoned this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Abandoned -- To view, visit https://gerrit.ovirt.org/65233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan
gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 2: -Verified * Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification * Check Public Bug::#1372798::OK, public bug * Check Product::#1372798::IGNORE, not relevant for classification: Red Hat * Check TM::#1372798::IGNORE, not relevant for classification: Red Hat * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/65232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan
Petr Horáček has restored this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Restored -- To view, visit https://gerrit.ovirt.org/65232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: net: edit nic detached from bridge but still attached to a vlan
Petr Horáček has restored this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Restored -- To view, visit https://gerrit.ovirt.org/65233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: restore Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan
gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 5: * Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification * Check Public Bug::#1372798::OK, public bug * Check Product::#1372798::IGNORE, not relevant for classification: Red Hat * Check TM::#1372798::IGNORE, not relevant for classification: Red Hat * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/65232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
Martin Polednik has posted comments on this change. Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: py3: make toolBondingTests pass
Petr Horáček has posted comments on this change. Change subject: py3: make toolBondingTests pass .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/65666/1/lib/vdsm/network/netinfo/bonding.py File lib/vdsm/network/netinfo/bonding.py: Line 258: Line 259: Line 260: def _bond_opts_name2numeric_scan(opt_path): Line 261: vals = {} Line 262: with open(opt_path, 'w') as opt_file: why do we use open as a context manager if we close it ourselves anyways? won't be better to create open_ignoring_flush_error that will do open and ignoring close? Line 263: for numeric_val in range(32): Line 264: name, numeric = _bond_opts_name2numeric_getval(opt_path, opt_file, Line 265: numeric_val) Line 266: if name is None: -- To view, visit https://gerrit.ovirt.org/65666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4487b787c3a14ca9508847572622f431f1188e7f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: stomp: broker cleanup
Piotr Kliczewski has uploaded a new change for review. Change subject: stomp: broker cleanup .. stomp: broker cleanup We can remove engine 3.5 supported queue names since we do not support this version anymore. Change-Id: I972268a72f51975eb78c6bac926e29ac53178dca Signed-off-by: Piotr Kliczewski --- M lib/yajsonrpc/stomp.py M lib/yajsonrpc/stompreactor.py 2 files changed, 2 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/65681/1 diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py index 41ac70f..558c519 100644 --- a/lib/yajsonrpc/stomp.py +++ b/lib/yajsonrpc/stomp.py @@ -22,11 +22,6 @@ from vdsm import utils import re -# REQUIRED_FOR: engine-3.5 -# safe to remove when 3.5 support is dropped -LEGACY_SUBSCRIPTION_ID_REQUEST = "/queue/_local/vdsm/requests" -LEGACY_SUBSCRIPTION_ID_RESPONSE = "/queue/_local/vdsm/reponses" - _RE_ESCAPE_SEQUENCE = re.compile(r"\\(.)") _RE_ENCODE_CHARS = re.compile(r"[\r\n\\:]") diff --git a/lib/yajsonrpc/stompreactor.py b/lib/yajsonrpc/stompreactor.py index 233bee3..42d7d01 100644 --- a/lib/yajsonrpc/stompreactor.py +++ b/lib/yajsonrpc/stompreactor.py @@ -200,11 +200,6 @@ frame.headers.get(stomp.Headers.REPLY_TO), frame.body) return -elif stomp.LEGACY_SUBSCRIPTION_ID_REQUEST == destination: -self._handle_internal(dispatcher, - stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE, - frame.body) -return else: try: subs = self._sub_dests[destination] @@ -323,7 +318,7 @@ """ Sends message to all subscribes that subscribed to destination. """ -def send(self, message, destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE): +def send(self, message, destination): resp = json.loads(message) response_id = resp.get("id") @@ -414,8 +409,7 @@ self._reactor.wakeup() return sub -def send(self, message, destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE, - headers=None): +def send(self, message, destination, headers=None): self.log.debug("Sending response") self._aclient.send( destination, -- To view, visit https://gerrit.ovirt.org/65681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I972268a72f51975eb78c6bac926e29ac53178dca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: stomp: broker cleanup
gerrit-hooks has posted comments on this change. Change subject: stomp: broker cleanup .. Patch Set 1: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I972268a72f51975eb78c6bac926e29ac53178dca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
Martin Polednik has posted comments on this change. Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65562/2/lib/vdsm/numa.py File lib/vdsm/numa.py: PS2, Line 274: NUMA just noticed - to any *virtual* numa node -- To view, visit https://gerrit.ovirt.org/65562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
gerrit-hooks has posted comments on this change. Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info .. Patch Set 3: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
Milan Zamazal has posted comments on this change. Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/65562/2/lib/vdsm/numa.py File lib/vdsm/numa.py: PS2, Line 274: virt > just noticed - to any *virtual* numa node Right, thanks, done. -- To view, visit https://gerrit.ovirt.org/65562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: numa: Don't crash on hotplugged CPUs when retrieving NUMA info
Martin Polednik has posted comments on this change. Change subject: numa: Don't crash on hotplugged CPUs when retrieving NUMA info .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7d00b897e430d9c4e8a23cb1451209b6f00e688 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: rpc: keep listening on socket
Piotr Kliczewski has uploaded a new change for review. Change subject: rpc: keep listening on socket .. rpc: keep listening on socket Some users are using Nessus scanner which seems to close vdsm socket. Users are not willing to configure it not to break vdsm. Due to this issue vdsm needs to be restarted to make it fully operational again. We can intercept socket closure and to reopen it. This fix was tested by using gdb to close the socket and observing that the socket is still open. Bug-Url: https://bugzilla.redhat.com/1326940 Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e Signed-off-by: Piotr Kliczewski --- M lib/vdsm/protocoldetector.py 1 file changed, 22 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/65686/1 diff --git a/lib/vdsm/protocoldetector.py b/lib/vdsm/protocoldetector.py index 196a2ab..f1450d7 100644 --- a/lib/vdsm/protocoldetector.py +++ b/lib/vdsm/protocoldetector.py @@ -51,8 +51,10 @@ class _AcceptorImpl(object): log = logging.getLogger("ProtocolDetector.AcceptorImpl") -def __init__(self, dispatcher_factory): +def __init__(self, dispatcher_factory, listener): self._dispatcher_factory = dispatcher_factory +self.listener = listener +self._keep_open = True def readable(self, dispatcher): return True @@ -73,6 +75,11 @@ def handle_close(self, dispatcher): dispatcher.close() +if self._keep_open: +self.listener.listen() + +def prepare_for_shutdown(self): +self._keep_open = False class _ProtocolDetector(object): @@ -172,15 +179,20 @@ ): self._sslctx = sslctx self._reactor = reactor -sock = _create_socket(host, port) -# TODO: Clean _host & _port, use sockaddr instead. -self._host, self._port = sock.getsockname()[0:2] -self.log.info("Listening at %s:%d", self._host, self._port) -self._acceptor = self._reactor.create_dispatcher( -sock, _AcceptorImpl(self.handle_accept)) -self._acceptor.listen(5) +self.port = port +self.host = host +self.listen() self._handlers = [] self.TIMEOUT = ssl_hanshake_timeout + +def listen(self): +sock = _create_socket(self.host, self.port) +# TODO: Clean _host & _port, use sockaddr instead. +self._host, self._port = sock.getsockname()[0:2] +self._acceptor = self._reactor.create_dispatcher( +sock, _AcceptorImpl(self.handle_accept, self)) +self._acceptor.listen(5) +self.log.info("Listening at %s:%d", self._host, self._port) def handle_accept(self, client): if self._sslctx is None: @@ -208,6 +220,8 @@ def stop(self): self.log.debug("Stopping Acceptor") self._reactor.stop() + +self._acceptor.prepare_for_shutdown() self._acceptor.close() -- To view, visit https://gerrit.ovirt.org/65686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: rpc: keep listening on socket
gerrit-hooks has posted comments on this change. Change subject: rpc: keep listening on socket .. Patch Set 1: * Update Tracker::#1326940::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1326940::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: rpc: keep listening on socket
Piotr Kliczewski has posted comments on this change. Change subject: rpc: keep listening on socket .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: virt: add optional container support
Martin Polednik has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 58: (11 comments) I believe the code is ready, just leaving some food for thought in comments. https://gerrit.ovirt.org/#/c/53820/58/lib/vdsm/containersconnection.py File lib/vdsm/containersconnection.py: PS58, Line 27: XML = containerslib.XML I have difficulty figuring out how this is further used - can you elaborate? PS58, Line 30: XML = None Symmetric issue as ^^^. https://gerrit.ovirt.org/#/c/53820/58/lib/vdsm/containerslib.py File lib/vdsm/containerslib.py: PS58, Line 59: class SuperVdsmCommand(SubProcCommand): The class overall isn't wrong, I'm just having hard time fitting it to VDSMs "way of things". We normally restrict the supervdsm by making small functions that encompass the call directly. My main "problem" is that it's very clever - and clever things can get tricky in future. Please weight the options of going with current approach VS this class. If you decide for the class, please add some high level documentation ("This is restriction of supervdsm"). Not a blocker though. PS58, Line 134: global _connections needed? PS58, Line 135: global _lock needed? https://gerrit.ovirt.org/#/c/53820/58/tests/vmTests.py File tests/vmTests.py: PS58, Line 108: 'vmType': 'kvm' I don't think this is a good change if you want to prove that the patches don't break current communication. https://gerrit.ovirt.org/#/c/53820/58/vdsm.spec.in File vdsm.spec.in: PS58, Line 713: Looks like random tab happened. PS58, Line 718: containersm typo :) https://gerrit.ovirt.org/#/c/53820/58/vdsm/virt/vm.py File vdsm/virt/vm.py: PS58, Line 1697: # Currently there is no protection agains mirroring : # a network twice, Unrelated & offset didn't change in this PS (I assume it's from the past). PS58, Line 1718: self.log.exception( : "Unexpected error on guest event notification") Unrelated, similar to above. Line 1725: con.prepare() Line 1726: Line 1727: self._guestCpuRunning = self._isDomainRunning() Line 1728: self._logGuestCpuStatus('domain initialization') Line 1729: Unrelated, although not harmful (I'd seriously leave it here). Line 1730: if self.lastStatus not in (vmstatus.MIGRATION_DESTINATION, Line 1731:vmstatus.RESTORING_STATE): Line 1732: self._initTimePauseCode = self._readPauseCode() Line 1733: if not self.recovering and self._initTimePauseCode: -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 58 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vmxml: export container metadata
Martin Polednik has posted comments on this change. Change subject: vmxml: export container metadata .. Patch Set 30: (1 comment) (quite important) question only, otherwise good to go https://gerrit.ovirt.org/#/c/60481/30/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: PS30, Line 272: cont = Element( : xmlcont.METADATA_CONTAINERS_PREFIX + ':' + : xmlcont.METADATA_CONTAINERS_ELEMENT, : text=container_type : Isn't containerImage required? -- To view, visit https://gerrit.ovirt.org/60481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network: supervdsm: configure container networks
Martin Polednik has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 51: (3 comments) Slight concern regarding setup_network not in the followup patch + should (imho) be reviewed by networking team. https://gerrit.ovirt.org/#/c/54998/51/lib/vdsm/containerslib.py File lib/vdsm/containerslib.py: PS51, Line 50: Repo = lambda **kwargs: object() This is clever. Not sure if not slightly too clever, clever nevertheless. :) PS51, Line 168: # TODO: what if the users install the vdsm-containers package later? : # how can we setup_networks, or inform the user this should be done? : # TODO: handle ipv6 : # TODO: extract subnet from ipaddr Are these meant as an evolution of this patch or something to be done in followup? PS51, Line 179: setup_network Doesn't exist in followup?! -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network: supervdsm: configure container networks
Martin Polednik has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 51: (1 comment) https://gerrit.ovirt.org/#/c/54998/51/lib/vdsm/containerslib.py File lib/vdsm/containerslib.py: PS51, Line 179: setup_network > Doesn't exist in followup?! Note to self: use browser with proper search or checkout patches properly, it does exist. -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: network: supervdsm: configure container networks
Petr Horáček has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 51: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/54998/51/vdsm/API.py File vdsm/API.py: Line 1513: Line 1514: try: Line 1515: self._cif._netConfigDirty = True Line 1516: supervdsm.getProxy().setupNetworks(networks, bondings, options) Line 1517: containersconnection.setup_networks(networks) this breaks setupNetworks rollback. if this line raises exception, API.setupNetworks fails, but networks configured by previous line are left on the host (they should be rolled back to initial state). i think we should move it to vdsm.network.api under rollback trigger. if it is possible that this will break host connectivity, we must also do some refactoring. if container network setup is dependent on switch type (linux bridge/ovs bridge), then we should place it in vdsm.network.netswitch (that would allow us to setup docker networks before connectivity check). Line 1518: return {'status': doneCode} Line 1519: except ConfigNetworkError as e: Line 1520: self.log.error(e.message, exc_info=True) Line 1521: return {'status': {'code': e.errCode, 'message': e.message}} -- To view, visit https://gerrit.ovirt.org/54998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107 Gerrit-PatchSet: 51 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: rpc: keep listening on socket
gerrit-hooks has posted comments on this change. Change subject: rpc: keep listening on socket .. Patch Set 2: * Update Tracker::#1326940::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::#1326940::OK, public bug * Check Product::IGNORE, not relevant for branch: master * Check TM::IGNORE, not relevant for branch: master * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: rpc: keep listening on socket
Piotr Kliczewski has posted comments on this change. Change subject: rpc: keep listening on socket .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/65686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I811786795ca15548da19de0f6a31cd9df6fc8c4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Use Popen.poll() for running state
Piotr Kliczewski has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: stomp: broker cleanup
gerrit-hooks has posted comments on this change. Change subject: stomp: broker cleanup .. Patch Set 2: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I972268a72f51975eb78c6bac926e29ac53178dca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: support nameserver address with %iface tail
Edward Haas has uploaded a new change for review. Change subject: net: support nameserver address with %iface tail .. net: support nameserver address with %iface tail The nameserver address may include an % tail, to specify on which iface the address is to be reached. The patch fixes the validation of the nameserver address when this tail exists. In addition, unit tests have been placed to cover the ip validation scenarios. Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2 Signed-off-by: Edward Haas --- M lib/vdsm/network/ip/validator.py M tests/network/ip_test.py 2 files changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/65693/1 diff --git a/lib/vdsm/network/ip/validator.py b/lib/vdsm/network/ip/validator.py index 9e84bd1..113f2c0 100644 --- a/lib/vdsm/network/ip/validator.py +++ b/lib/vdsm/network/ip/validator.py @@ -48,7 +48,17 @@ def _validate_nameservers_address(nameservers_addr): for addr in nameservers_addr: +addr = _normalize_address(addr) if ':' in addr: IPv6.validateAddress(addr) else: IPv4.validateAddress(addr) + + +def _normalize_address(addr): +""" +The nameserver address may be tailed with the interface from which it +should be reached: '2001::1%eth0' +For the purpose of address validation, such tail is ignored. +""" +return addr.split('%', 1)[0] diff --git a/tests/network/ip_test.py b/tests/network/ip_test.py index 8dc328e..e4c7a7e 100644 --- a/tests/network/ip_test.py +++ b/tests/network/ip_test.py @@ -22,7 +22,9 @@ from testlib import VdsmTestCase +from vdsm.network import errors as ne from vdsm.network.ip import address +from vdsm.network.ip import validator @attr(type='unit') @@ -44,3 +46,42 @@ self.assertEqual(None, ip.address) self.assertEqual(None, ip.gateway) self.assertEqual(None, ip.defaultRoute) + + +@attr(type='unit') +class TestIPValidator(VdsmTestCase): + +def test_ignore_remove_networks(self): +validator.validate({'NET0': {'remove': True, + 'defaultRoute': False, + 'nameservers': ['8.8.8.8']}}) + +def test_nameserver_defined_on_a_non_primary_network_fails(self): +with self.assertRaises(ne.ConfigNetworkError) as cne: +validator.validate({'NET0': {'defaultRoute': False, + 'nameservers': ['8.8.8.8']}}) +self.assertEqual(cne.exception.errCode, ne.ERR_BAD_PARAMS) + +def test_nameserver_faulty_ipv4_address(self): +with self.assertRaises(ne.ConfigNetworkError) as cne: +validator.validate({'NET0': {'defaultRoute': True, + 'nameservers': ['a.8.8.8']}}) +self.assertEqual(cne.exception.errCode, ne.ERR_BAD_ADDR) + +def test_nameserver_faulty_ipv6_address(self): +with self.assertRaises(ne.ConfigNetworkError) as cne: +validator.validate({'NET0': {'defaultRoute': True, + 'nameservers': ['2001:bla::1']}}) +self.assertEqual(cne.exception.errCode, ne.ERR_BAD_ADDR) + +def test_nameserver_valid_ipv4_address(self): +validator.validate({'NET0': {'defaultRoute': True, + 'nameservers': ['8.8.8.8']}}) + +def test_nameserver_valid_ipv6_address(self): +validator.validate({'NET0': {'defaultRoute': True, + 'nameservers': ['2001::1']}}) + +def test_nameserver_address_with_interface_tail(self): +validator.validate({'NET0': {'defaultRoute': True, + 'nameservers': ['2001::1%eth1']}}) -- To view, visit https://gerrit.ovirt.org/65693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: net: support nameserver address with %iface tail
gerrit-hooks has posted comments on this change. Change subject: net: support nameserver address with %iface tail .. Patch Set 1: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::WARN, no public bug url found * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/65693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea4d2eea2af8004435dae54ad56588739e028ba2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Use Popen.poll() for running state
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: Use Popen.poll() for running state .. tests: Use Popen.poll() for running state Checking if /proc/pid exists works, but using poll() is simpler and more clear. Since proc_path is used only in one test, move it the test using it. Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/65323 Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-by: Piotr Kliczewski --- M tests/utilsTests.py 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: tests: Use Popen.poll() for running state
gerrit-hooks has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 6: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/65323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I086e9317b5f8e5324d86bedeb04b485c7a09ad16 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: utils: Wait for terminated process
Dan Kenigsberg has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 5: Code-Review+1 what you say here is very clear; but since https://gerrit.ovirt.org/#/c/51407/ was very explicit about this intended semantics, I'd like to hear from Piotr+Bronheim if they are aware of anything that depends on it, and would be broken now. -- To view, visit https://gerrit.ovirt.org/65324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida04e2c7ba092efdc2927ed9f460b0098ba2ad94 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org