Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Dan Kenigsberg has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 13: Verified+1 Code-Review+2 Copy erased scores (was the latest rebase really needed?) -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Dan Kenigsberg has submitted this change and it was merged. Change subject: Adding ppc64 handling to getVdsCaps .. Adding ppc64 handling to getVdsCaps This introduces a parser capable of interpreting the /proc/cpuinfo present in IBM POWER hosts. It also retrieves the possible emulated machines for QEMU guests. The POWER 7 processors are not compatible between themselves so only the host CPU is reported as compatible in the _getCompatibleCpuModels() function. Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Signed-off-by: Vitor de Lima vitor.l...@eldorado.org.br Reviewed-on: http://gerrit.ovirt.org/17437 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M tests/capsTests.py M vdsm/caps.py 2 files changed, 63 insertions(+), 8 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5918/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5123/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6011/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Dan Kenigsberg has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Vitor de Lima has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 11: (1 comment) File lib/vdsm/constants.py.in Line 148: Line 149: EXT_CURL_IMG_WRAP = '@LIBEXECDIR@/curl-img-wrap' Line 150: Line 151: Line 152: class Architecture: The problem is that a hook (the faqemu) requires a architecture specific behaviour, the minimum amount of memory required to create a fake VM is much larger on ppc64 than on x86-64. After moving the code to caps.py, the hook can't import the Architecture anymore. Line 153: X86_64 = 'x86_64' -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5814/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5906/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5018/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Dan Kenigsberg has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 11: (1 comment) File lib/vdsm/constants.py.in Line 148: Line 149: EXT_CURL_IMG_WRAP = '@LIBEXECDIR@/curl-img-wrap' Line 150: Line 151: Line 152: class Architecture: The Architecture is produced by caps, and reported from there to Engine and vm.py. There is no need to expose it in the constants module. It would have been better if these constants where all tucked in their own module (e.g., EXT_DD defined in a dd.py wrapper module). Line 153: X86_64 = 'x86_64' -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Yaniv Bronhaim has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 11: (1 comment) File lib/vdsm/constants.py.in Line 148: Line 149: EXT_CURL_IMG_WRAP = '@LIBEXECDIR@/curl-img-wrap' Line 150: Line 151: Line 152: class Architecture: I recall I asked you to move it here because you used those not only in caps. but if it is used only there, move it Line 153: X86_64 = 'x86_64' -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Dan Kenigsberg has posted comments on this change.
Change subject: Adding ppc64 handling to getVdsCaps
..
Patch Set 11: Code-Review-1
(5 comments)
Commit Message
Line 11: machines for QEMU guests. The POWER 7 processors are not compatible
Line 12: between themselves so only the host CPU is reported as compatible
Line 13: in the _getCompatibleCpuModels() function.
Line 14:
Line 15: There is also a bug on libvirt that prevents the host CPU from being
Which bz# is this? We'd want to get rid of the workaround when it's solved.
Line 16: properly detected. This code has a workaround for this.
Line 17:
Line 18: Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
File lib/vdsm/constants.py.in
Line 148:
Line 149: EXT_CURL_IMG_WRAP = '@LIBEXECDIR@/curl-img-wrap'
Line 150:
Line 151:
Line 152: class Architecture:
Would you take this definition into the module were it's most related (caps)
and out of the constants.py dumpster?
Line 153: X86_64 = 'x86_64'
File tests/capsTests.py
Line 22: import os
Line 23: from testrunner import VdsmTestCase as TestCaseBase
Line 24: from monkeypatch import MonkeyPatch
Line 25: from vdsm import constants
Line 26: import platform
Imports from stdlib should come first.
Line 27:
Line 28: import caps
Line 29:
Line 30:
File vdsm/caps.py
Line 39: from vdsm import utils
Line 40: from vdsm import constants
Line 41: import storage.hba
Line 42:
Line 43: import platform
Here too.
Line 44:
Line 45: # For debian systems we can use python-apt if available
Line 46: try:
Line 47: import apt
Line 204: vendor = None
Line 205: allModels[m.getAttribute('name')] = vendor
Line 206:
Line 207: return allModels
Line 208: except:
We do mind. The try block should be much smaller, and and catch thing that we
care about. Vitor, which exception exactly worries you? Can we handle it more
precisely?
Line 209: logging.error('Error while getting all CPU models',
exc_info=True)
Line 210: return {}
Line 211:
Line 212:
--
To view, visit http://gerrit.ovirt.org/17437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding ppc64 handling to getVdsCaps
..
Patch Set 11: Code-Review+1
(1 comment)
File vdsm/caps.py
Line 204: vendor = None
Line 205: allModels[m.getAttribute('name')] = vendor
Line 206:
Line 207: return allModels
Line 208: except:
some would say that you should be more exception specific here. but if they
mind they can raise it themselves
Line 209: logging.error('Error while getting all CPU models',
exc_info=True)
Line 210: return {}
Line 211:
Line 212:
--
To view, visit http://gerrit.ovirt.org/17437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Vitor de Lima has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4534/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5334/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5412/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding ppc64 handling to getVdsCaps
..
Patch Set 10:
(2 comments)
File vdsm/caps.py
Line 71: def __init__(self, cpuinfo='/proc/cpuinfo'):
Line 72: Parse /proc/cpuinfo
Line 73: self._info = {}
Line 74: p = {}
Line 75: self.arch = platform.machine()
in private use. please change to _arch
Line 76:
Line 77: for line in file(cpuinfo):
Line 78: if line.strip() == '':
Line 79: p = {}
Line 179: arch = 'x86'
Line 180:
Line 181: for a in cpu_map.getElementsByTagName('arch'):
Line 182: if a.getAttribute('name') == arch:
Line 183: architectureElement = a
can be an attribute error here? you'll miss an element without logging it ..
same for above ^
Line 184:
Line 185: allModels = dict()
Line 186:
Line 187: for m in architectureElement.childNodes:
--
To view, visit http://gerrit.ovirt.org/17437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4415/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5219/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5295/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding ppc64 handling to getVdsCaps
..
Patch Set 9:
(2 comments)
one comment about raising specific exceptions. did you verify it?
File vdsm/caps.py
Line 106: return self._info.itervalues().next()['model name']
Line 107: elif self.arch == constants.Architecture.PPC64:
Line 108: return self._info.itervalues().next()['cpu']
Line 109: else:
Line 110: raise Exception('Unsupported architecture')
raise specific exception
Line 111:
Line 112:
Line 113: class CpuTopology(object):
Line 114: def __init__(self, capabilities=None):
Line 213:
Line 214: try:
Line 215: return ['model_' + getCpuModel()]
Line 216: except Exception as e:
Line 217: raise Exception('Failed to retrieve CPU model: ' + str(e))
raise RuntimeError , or another specific exception. I would log it with full
stacktrace instead of printing e.
Line 218:
Line 219: c = libvirtconnection.get()
Line 220: allModels = _getAllCpuModels()
Line 221:
--
To view, visit http://gerrit.ovirt.org/17437
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
gustavo.pedr...@eldorado.org.br
Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding ppc64 handling to getVdsCaps
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding ppc64 handling to getVdsCaps .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5034/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4230/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5108/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa gustavo.pedr...@eldorado.org.br Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Leonardo Bianconi leonardo.bianc...@eldorado.org.br Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Vitor de Lima vitor.l...@eldorado.org.br Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
