Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Nir Soffer has submitted this change and it was merged. Change subject: gluster: Fixing connection when server is not one of the bricks .. gluster: Fixing connection when server is not one of the bricks When processing gluster connection info, volfileserver is set as provided by the admin and, using volume info, backup-volfile-servers option is set. However, there are use cases where gluster server and ovirt are configured differently regarding ip addresses and domain names. If volfileserver appears in volume info, it is removed in order to avoid mounting duplicate servers, otherwise, mounting duplicate servers is possible. Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Bug-Url: https://bugzilla.redhat.com/1278880 Signed-off-by: Ala Hino Reviewed-on: https://gerrit.ovirt.org/48308 Continuous-Integration: Jenkins CI Reviewed-by: Sahina Bose Reviewed-by: Nir Soffer --- M tests/storageServerTests.py M vdsm/storage/storageServer.py 2 files changed, 27 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
gerrit-hooks has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 10: * #1278880::Update tracker: OK * Set MODIFIED::bug 1278880#1278880OK -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Nir Soffer has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: Thanks Ala! Can you backport? -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Ala Hino has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Nir Soffer has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: Code-Review+2 Thanks Sahina! Ala, would you verify this? -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Sahina Bose has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/48308/9/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 347: Line 348: if not servers: Line 349: return "" Line 350: Line 351: return "backup-volfile-servers=" + ":".join(servers) > Ala, would add a patch of top of this one, removing duplicates? Yes, there could be any number of backup-volfile-servers - and each will be tried in turn. The volfile-servers provided is for the gluster client to fetch the volfile from and is only used at the time of mounting volume. Once the volfile is retrieved from any of these servers, gluster client knows of all the servers in the cluster and will intelligently connect to them. To answer the second question - no, failure to connect to any of the servers while mounting volume does not result in bricks being marked down. Brick process is monitored separately by the glusterd services running on the servers. Line 352: Line 353: def _get_gluster_volinfo(self): Line 354: volinfo = supervdsm.getProxy().glusterVolumeInfo(self._volname, Line 355: self._volfileserver) -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Nir Soffer has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/48308/9/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 347: Line 348: if not servers: Line 349: return "" Line 350: Line 351: return "backup-volfile-servers=" + ":".join(servers) > User could have a distributed replica volume (2 X 3) with 6 bricks. These 6 Ala, would add a patch of top of this one, removing duplicates? Sahina, we are worried about a different scenario. Lets say we have servers A, B, and C. The user is configuring the domain using server D, which is just another name for A or B or C. Lets assume that D is pointing now to A. The user explains on the bug why he is using configuration. With this fix, we would mount D:/volname, with backup servers A:B:C. First question, will gluster mount helper work correctly with 3 backup servers instead of 2? Will it use C, or ignore it and use only A and B as backup servers? Next, lets assume that server D is failing. gluster mount helper will try to do failover to the next backup server, but A is the same server, so it will fail as well. Then gluster mount helper will fail over to server B. It this state, there is one brick (A and D are the same brick), but gluster mount failed twice. Would it consider this as 2 failing bricks and the file system would become readonly, or it is smart enough to detect that there are 2 bricks online? Line 352: Line 353: def _get_gluster_volinfo(self): Line 354: volinfo = supervdsm.getProxy().glusterVolumeInfo(self._volname, Line 355: self._volfileserver) -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Sahina Bose has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: Code-Review+1 Ack from me - can fix possible duplicates in server list as separate patch -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Sahina Bose has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/48308/9/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 351: .join(servers) > Not sure I completely understand this comment. Please elaborate. User could have a distributed replica volume (2 X 3) with 6 bricks. These 6 bricks could be spread over 4 servers. So, if we are just joining the list of servers from bricks - there could be duplicates in this list. -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Ala Hino has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/48308/9/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 351: .join(servers) > It is possible to end up with duplicate servers with a distribute replica. Not sure I completely understand this comment. Please elaborate. -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Sahina Bose has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/48308/9/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 351: .join(servers) It is possible to end up with duplicate servers with a distribute replica. User could have a gluster vol configuration where multiple bricks are on same server. Do we want to address that in this patch? -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Sahina Bose has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48308/2/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 337: raise
se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 338:
Line 339: def _get_backup_servers_option(self):
Line 340: servers = [brick.split(":")[0] for brick in
self.volinfo['bricks']]
Line 341: self._volfileserver = servers.pop(0)
> There is a major issue with this change.
Yes, it will work as long as server IP/FQDN configured in bricks is reachable
by hypervisor host mounting it.
Line 342: if not servers:
Line 343: return ""
Line 344:
Line 345: return "backup-volfile-servers=" + ":".join(servers)
--
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Prasanna Kumar Kalever
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Nir Soffer has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Ala Hino has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/48308/8//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-11-09 17:56:45 +0200 Line 4: Commit: Ala Hino Line 5: CommitDate: 2015-11-10 22:43:31 +0200 Line 6: Line 7: gluster: Set mount path based on gluster volume info > The title is still describing the old change. This should be something like Done Line 8: Line 9: When processing gluster connection info, volfileserver is set as provided by Line 10: the admin and, using volume info, backup-volfile-servers option is set. However, Line 11: there are use cases where gluster server and ovirt are configured differently -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
automat...@ovirt.org has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: * #1278880::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1278880::OK, public bug * Check Product::#1278880::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
