Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-28 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Paul Maidment 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-28 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 5: Code-Review+2

Given the nice verifications, please do that in a follow up patch.

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Paul Maidment 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-28 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


network: inherit DUID from a bridge's port with no restriction

A bridge must reuse the DHCP unique identifier of the underlying
network device it is built atop so DHCP client obtains the same
lease (in particular, the same address).

Recently, the flow in setupNetworks changed in a way that the device
being "replaced" by the bridge no longer reports 'dhcpv4' as True.
There is simply no evidence of DHCPv4 being used on the device, and
thus DUID would not be inherited, as the checking is too strict.

Now, dhclient run on the bridge is always called with the '-df' option
(used to refer to the bridge port's lease file) as long as it is
supported. The option is harmless: dhclient simply ignores it if the
lease file doesn't exist.

As dhclient doesn't have a -h/--help option, we pass to it an
intentionally invalid option, tricking it into listing the options it
supports. To avoid printing the error output to logs, dhclient is now
called directly, not through execCmd.

Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Signed-off-by: Ondřej Svoboda 
Reviewed-on: https://gerrit.ovirt.org/54130
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Tested-by: Edward Haas 
Tested-by: Paul Maidment 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/network/configurators/dhclient.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/legacy_switch.py
3 files changed, 22 insertions(+), 36 deletions(-)

Approvals:
  Ondřej Svoboda: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Paul Maidment: Verified
  Edward Haas: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Paul Maidment 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-28 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 5:

Thanks for the verification. To be on the safe side invocating dhclient I will 
however have to move to execCmd (with a null logger).

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Paul Maidment 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-28 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/54130/5/lib/vdsm/network/configurators/dhclient.py
File lib/vdsm/network/configurators/dhclient.py:

PS5, Line 134: subprocess
> Bypassing execCmd here seems like a hack, I'm not sure if we know what we a
All I found about dhcpctl was that it was "a set of functions to control the 
dhcp server". Anyway, I don't think we want to tie ourselves to the one DHCP 
client any more than we already do.

I reacted to Popen/CPopen elsewhere.


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-28 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 5:

I am fine using CPopen instead of Popen but don't want to make execCmd any more 
complex or play tricks to silence its logging if I can run a binary with 2 
statements.

About CPopen: https://gerrit.ovirt.org/#/c/3944/

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-28 Thread edwardh 
Edward Haas has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 5: Code-Review+1 Verified+1

(1 comment)

Verified on Centos7 (unit & functional net tests)

https://gerrit.ovirt.org/#/c/54130/5/lib/vdsm/network/configurators/dhclient.py
File lib/vdsm/network/configurators/dhclient.py:

PS5, Line 134: subprocess
Bypassing execCmd here seems like a hack, I'm not sure if we know what we are 
'loosing' here. (I think execCmd handled several limitations and problems with 
Popen in Python2)

It would have been nicer and safer to add a 'silent'/'verbose' flag to execCmd.
But as this detection method is ugly by itself, maybe it does not matter much.

For the long run,  I would suggest using dhcpctl to query and control dhclient.


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-27 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 5: Verified+1

Functional tests passed on F23.

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-27 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-27 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 4: Code-Review-1

(1 comment)

Recursive call, needlessly logged probe output.

https://gerrit.ovirt.org/#/c/54130/4/lib/vdsm/network/configurators/dhclient.py
File lib/vdsm/network/configurators/dhclient.py:

PS4, Line 65: supports_duid_file
This function calls DhcpClient.start(blocking=True) which in turn calls 
_dhclient. Bad, very bad.

The DUID probe also appears in the logs, revealing the ugly output in which we 
look for signs that -df is supported.

I think a clean way to overcome both issues is to use the execute the probe 
directly, avoiding both this recursive call and execCmd.


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-27 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-20 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 3: Verified+1

testDhcpReplaceNicWithBridge now passes.

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-20 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 3: -Code-Review

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-20 Thread osvoboda 
Ondřej Svoboda has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/54130/3/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

Line 157
Line 158
Line 159
Line 160
Line 161
> even though this function has become so much simpler, I think that it makes
I moved the check "dhclient.supports_duid_file()" to the configurators because 
I think the API shouldn't care how DUID is finally handled (ideally, if -df is 
not supported, another method (-lf) should be tried transparently). And the 
long comment inside the target function to explain its purpose.

This leaves us only with the now-inlined assignment (which got the useful parts 
of the docstring as a comment) because the check that there is a port has 
always been done by the caller.

I don't think we need a single-statement function.


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-20 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/54130/3/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

Line 157
Line 158
Line 159
Line 160
Line 161
even though this function has become so much simpler, I think that it makes 
sense to keep it. In-lining the logic complicates things for me.


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: inherit DUID from a bridge's port with no restriction

2016-03-20 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: network: inherit DUID from a bridge's port with no restriction
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches